ggaren@apple.com [Tue, 2 Dec 2008 21:52:24 +0000 (21:52 +0000)]
2008-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <zwarich@apple.com>.)
Fixed https://bugs.webkit.org/show_bug.cgi?id=22482
REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
message when running the V8 Raytrace benchmark
Rolled out r37991. It didn't properly save xmm0, which is caller-save,
before calling helper functions.
SunSpider and v8 benchmarks show little change -- possibly a .2%
SunSpider regression, possibly a .2% v8 benchmark speedup.
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Instruction.h:
(JSC::Instruction::):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUnaryOp):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitToJSNumber):
(JSC::BytecodeGenerator::emitTypeOf):
(JSC::BytecodeGenerator::emitGetPropertyNames):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* parser/Nodes.cpp:
(JSC::UnaryOpNode::emitBytecode):
(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
* parser/ResultType.h:
(JSC::ResultType::isReusable):
(JSC::ResultType::mightBeNumber):
* runtime/JSNumberCell.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 2 Dec 2008 21:32:08 +0000 (21:32 +0000)]
2008-12-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Remove unused (sampling only, and derivable) argument to JIT::emitCTICall.
https://bugs.webkit.org/show_bug.cgi?id=22587
* jit/JIT.cpp:
(JSC::JIT::emitCTICall):
(JSC::JIT::compileOpCall):
(JSC::JIT::emitSlowScriptCheck):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 2 Dec 2008 21:29:18 +0000 (21:29 +0000)]
Bug 22596: Some elements don't report AXBlockQuoteLevel
Make sure all AX objects return a block quote level
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2008 21:26:10 +0000 (21:26 +0000)]
2008-12-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Let the plug-in views know if the plug-in host crashes.
* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginHostProxy.h:
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::pluginHostDied):
(WebKit::NetscapePluginHostProxy::addPluginInstance):
(WebKit::NetscapePluginHostProxy::removePluginInstance):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::create):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
Keep a pointer to the host proxy.
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Add the instance to the host set.
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Remove the instance form the host set.
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Tell the plug-in view that the plug-in died.
* Plugins/Hosted/WebHostedNetscapePluginView.h:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
Pass the plug-in view to the instantiatePlugin.
(-[WebHostedNetscapePluginView pluginHostDied]):
Handle the plug-in host crashing.
(-[WebHostedNetscapePluginView drawRect:]):
Fill the plug-in view with a nice red shade if the plug-in crashes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 20:43:51 +0000 (20:43 +0000)]
2008-12-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Fix the inheritance chain for JSFunction.
* runtime/JSFunction.cpp:
(JSC::JSFunction::info): Add InternalFunction::info as parent class
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 20:36:17 +0000 (20:36 +0000)]
2008-12-02 Michael Moss <mmoss@chromium.org>
Reviewed by Eric Seidel.
- Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
https://bugs.webkit.org/show_bug.cgi?id=20926
Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::loadURLIntoChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 20:32:37 +0000 (20:32 +0000)]
2008-12-02 Dean McNamee <deanm@chromium.org>
Reviewed by Eric Seidel.
Correctly handle a theme returning a non-blinking interval. We should
not set any timers when the interval is 0 (non-blinking), otherwise we
repeatedly set and destroy a blinking timer, causing a paint and timer
storm. This is applicable to GTK and Windows, where a user can set a
non-blinking caret in their system preferences.
Renamed caretBlinkFrequency to the more accurate caretBlinkInterval.
* page/Frame.cpp:
(WebCore::Frame::selectionLayoutChanged):
* platform/Theme.h:
(WebCore::Theme::caretBlinkInterval):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::caretBlinkInterval):
* platform/gtk/RenderThemeGtk.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::caretBlinkInterval):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 20:27:44 +0000 (20:27 +0000)]
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22538
startsWith uses find which searches through the whole string if no match is found.
Using reverseFind with an index of 0 has the benefit of only searching for the match
at the beginning of the string. This may only be a small benefit in the overall program,
but it may help in some cases when the string is big.
No observable change in behavior, so no test.
* platform/text/StringImpl.h:
(WebCore::StringImpl::startsWith):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 20:25:26 +0000 (20:25 +0000)]
Reviewed by Darin Adler.
Wrap a JSC-only hack in a USE(JSC) block to fix the v8 build.
https://bugs.webkit.org/show_bug.cgi?id=21951
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::forgetWrapper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 19:07:42 +0000 (19:07 +0000)]
Reviewed by Darin Adler.
Add an ASSERT to try and catch the root cause of:
https://bugs.webkit.org/show_bug.cgi?id=22168
http://code.google.com/p/chromium/issues/detail?id=4122
* editing/TextIterator.cpp:
(WebCore::TextIterator::emitText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 19:04:39 +0000 (19:04 +0000)]
Reviewed by David Kilzer.
Hack build-webkit --chromium to use Win32 python instead
of using the default cygwin python. Scons + CYGWIN tries
to build with GCC by default, we force MSVC in our file
but that just results in errors from Scons. Until we can fix
this latest round of errors, at least make build-webkit --chromium
actually "work" under CYGWIN instead of forcing users to use
a cmd shell directly.
This is working around a Scons bug:
http://scons.tigris.org/issues/show_bug.cgi?id=2266
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Dec 2008 19:01:17 +0000 (19:01 +0000)]
2008-12-02 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Remove some CG-specific code from the Windows Cairo build.
https://bugs.webkit.org/show_bug.cgi?id=22586
No new test cases since this update should create no user-visible
changes, and should be fully covered by the existing regression
tests.
* WebCore.vcproj/WebCore.vcproj: Remove FontDatabase from
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::focusRingColor): Add stub method
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::populateFontDatabase): Add stub method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2008 18:32:08 +0000 (18:32 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Recover if the plug-in host dies and we try to instantiate another plugin before we get the port death notification
* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::pluginHostDied):
Remove the plug-in host from the map.
(WebKit::NetscapePluginHostManager::instantiatePlugin):
NetscapePluginHostProxy is no longer refcounted.
* Plugins/Hosted/NetscapePluginHostProxy.h:
This is no longer refcounted. Add a set of plug-in instances (unused for now).
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
Create a death notification port.
(WebKit::NetscapePluginHostProxy::pluginHostDied):
Tell the manager that we're gone and delete ourselves.
(WebKit::NetscapePluginHostProxy::deathPortCallback):
New CFMachPort callback.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 2 Dec 2008 16:14:46 +0000 (16:14 +0000)]
2008-12-02 Simon Hausmann <hausmann@webkit.org>
Rubber-stamped by Tor Arne Vestbø.
Initial API documentation for QWebDatabase, QWebSecurityOrigin and
QWebFrame::securityOrigin().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 2 Dec 2008 16:03:48 +0000 (16:03 +0000)]
2008-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Tor Arne Vestbø.
MinGW compilation fix for PluginPackageWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=22585
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Dec 2008 15:13:44 +0000 (15:13 +0000)]
Build fix for Windows projects with NOMINMAX defined globally
* platform/win/COMPtr.h: Don't redefine NOMINMAX if it's already
defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 2 Dec 2008 10:04:25 +0000 (10:04 +0000)]
Top-Level:
2008-12-02 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Removed JavaScriptCore from SUBDIRS as it's not built separately
anymore.
WebCore:
2008-12-02 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Build JavaScriptCore into libQtWebKit.so through a direct build
instead of a static library. When linking a static library into
a shared library qmake generates an incorrect .prl file, which
causes all sorts of different build problems when linking against
QtWebKit. Fixing this in qmake requires bigger changes that are
currently not possible, so we need to work around this limitation
for now. The advantages of the separate build did not outweight the
build problems it caused.
JavaScriptCore:
2008-12-02 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Fix ability to include JavaScriptCore.pri from other .pro files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Tue, 2 Dec 2008 08:49:06 +0000 (08:49 +0000)]
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22588
Move securityOrigin() from Document and WorkerContext into ScriptExecutionContext.
No observable change in behavior, so no test.
* dom/Document.cpp:
(WebCore::Document::open):
(WebCore::Document::domain):
(WebCore::Document::setDomain):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):
* dom/Document.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::setSecurityOrigin):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::securityOrigin):
* dom/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
* dom/WorkerContext.h:
These changes are for the move of securityOrigin().
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
(WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
(WebCore::XMLHttpRequest::processSyncLoadResults):
(WebCore::XMLHttpRequest::willSendRequest):
(WebCore::XMLHttpRequest::accessControlCheck):
(WebCore::XMLHttpRequest::didReceiveResponsePreflight):
Change XMLHttpRequest to use ScriptExecutionContext instead of Document to access securityOrigin().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 2 Dec 2008 08:26:37 +0000 (08:26 +0000)]
2008-12-02 André Pönitz <apoenitz@trolltech.com>
Reviewed by Simon Hausmann.
Disable the creation of debug information for the Qt build when done
inside Qt. With 670 mb it was slowing down gdb start significantly
for third-party applications that usually don't need it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Tue, 2 Dec 2008 07:24:15 +0000 (07:24 +0000)]
WebCore:
2008-12-01 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=13736 REGRESSION
(r19811): Using the down arrow in a textarea gets "stuck" at the
end of a wrapped line
And corresponding: <rdar://problem/5347931>
The basic problem here is that Position::getInlineBoxAndOffset()
failed to look beyond a single renderer. This patch looks for a
better match beyond the first renderer when the affinity is
downstream and we failed to find a "perfect" match.
* dom/Position.cpp:
(WebCore::isNonTextLeafChild):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::getInlineBoxAndOffset):
This is a fix I made based on code inspection. It looks like the
old code here and skipped over the parent as a possible match.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::nextInPreOrderAfterChildren):
LayoutTests:
2008-12-01 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
Tests for https://bugs.webkit.org/show_bug.cgi?id=13736 REGRESSION
(r19811): Using the down arrow in a textarea gets "stuck" at the
end of a wrapped line
And corresponding: <rdar://problem/5347931>
* editing/selection/wrapped-line-caret-1.html: Added.
* editing/selection/wrapped-line-caret-2.html: Added.
* platform/mac/editing/selection/wrapped-line-caret-1-
expected.checksum: Added.
* platform/mac/editing/selection/wrapped-line-caret-1-expected.png:
Added.
* platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
Added.
* platform/mac/editing/selection/wrapped-line-caret-2-
expected.checksum: Added.
* platform/mac/editing/selection/wrapped-line-caret-2-expected.png:
Added.
* platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Tue, 2 Dec 2008 06:49:22 +0000 (06:49 +0000)]
2008-12-01 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Add WML related files to Visual Studio projects.
https://bugs.webkit.org/show_bug.cgi?id=22561
* WebCore.vcproj/WebCore.vcproj:
1. Add files from the wml directory to the set of windows files.
2. Extend include paths with new wml directory.
3. Add new autogenerated WML files to DerivedSources.
4. Alphabetize preprocesor includes (holdover from earlier debugging).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 2 Dec 2008 05:25:57 +0000 (05:25 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 2 Dec 2008 05:25:15 +0000 (05:25 +0000)]
Revise node/selection image fix.
Moved updateLayout call so selection rect is fetched after the layout.
Reviewed by Adam Roben.
* page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
(WebCore::imageFromSelection):
(WebCore::Frame::nodeImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 2 Dec 2008 05:08:33 +0000 (05:08 +0000)]
WebCore:
2008-12-01 Steve Falkenburg <sfalken@apple.com>
Support needed to implement renderedImage for Windows.
https://bugs.webkit.org/show_bug.cgi?25648
Reviewed by Adam Roben.
* page/Frame.h:
* page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
(WebCore::imageFromSelection):
(WebCore::Frame::nodeImage):
* page/win/FrameCairoWin.cpp:
(WebCore::imageFromNode):
WebKit/win:
2008-12-01 Steve Falkenburg <sfalken@apple.com>
Implement renderedImage for Windows.
https://bugs.webkit.org/show_bug.cgi?25648
Reviewed by Adam Roben.
* DOMCoreClasses.cpp:
(DOMElement::renderedImage):
* DOMCoreClasses.h:
* Interfaces/DOMPrivate.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 2 Dec 2008 05:01:21 +0000 (05:01 +0000)]
2008-12-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=22581
Fix the painting of the caps lock indicator for transformed text inputs,
by replacing a call to absoluteContentBox() with code that computes the
painting rect for the input contents.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 2 Dec 2008 04:26:38 +0000 (04:26 +0000)]
Not reviewed. Forgot to include updated layout tests in last commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 2 Dec 2008 03:25:20 +0000 (03:25 +0000)]
2008-12-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich, with help from Gavin Barraclough.
Fixed https://bugs.webkit.org/show_bug.cgi?id=22583.
Refactored regular expression parsing to parse sequences of characters
as a single unit, in preparation for optimizing sequences of characters.
SunSpider reports no change.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wrec/Escapes.h: Added. Set of classes for representing an escaped
token in a pattern.
* wrec/Quantifier.h:
(JSC::WREC::Quantifier::Quantifier): Simplified this constructor slightly,
to match the new Escape constructor.
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generatePatternCharacterSequence):
* wrec/WRECGenerator.h: Added an interface for generating a sequence
of pattern characters at a time. It doesn't do anything special yet.
* wrec/WRECParser.cpp:
(JSC::WREC::Parser::consumeGreedyQuantifier):
(JSC::WREC::Parser::consumeQuantifier): Renamed "parse" to "consume" in
these functions, to match "consumeEscape."
(JSC::WREC::Parser::parsePatternCharacterSequence): New function for
iteratively aggregating a sequence of characters in a pattern.
(JSC::WREC::Parser::parseCharacterClassQuantifier):
(JSC::WREC::Parser::parseBackreferenceQuantifier): Renamed "parse" to
"consume" in these functions, to match "consumeEscape."
(JSC::WREC::Parser::parseCharacterClass): Refactored to use the common
escape processing code in consumeEscape.
(JSC::WREC::Parser::parseEscape): Refactored to use the common
escape processing code in consumeEscape.
(JSC::WREC::Parser::consumeEscape): Factored escaped token processing
into a common function, since we were doing this in a few places.
(JSC::WREC::Parser::parseTerm): Refactored to use the common
escape processing code in consumeEscape.
* wrec/WRECParser.h:
(JSC::WREC::Parser::consumeOctal): Refactored to use a helper function
for reading a digit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 2 Dec 2008 03:04:15 +0000 (03:04 +0000)]
Reviewed by George Staikos.
Add two new helper functions to WMLElement, parseValueSubstitutingVariableReferences/parseValueForbiddingVariableReferences.
Convert all elements to parse their attribute values using these new helper functions. This simplifies the
actual attribute parsing code in all WMLElement derived classes, as most WML attribute values either report
an error if there's a variable reference used in the attribute value, or if it's invalid.
Split the WMLErrorInvalidVariableReference error which covered both 'invalid syntax' / 'wrong location'
in two seperated error codes: WMLErrorInvalidVariableReference / WMLErrorInvalidVariableReferenceLocation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 2 Dec 2008 02:59:41 +0000 (02:59 +0000)]
Not reviewed, add reviewers full name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 2 Dec 2008 02:49:35 +0000 (02:49 +0000)]
Reviewed by George.
Fix switching active cards within a document. No way to test, until <go> support is implemented.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 2 Dec 2008 01:57:56 +0000 (01:57 +0000)]
2008-12-01 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
<https://bugs.webkit.org/show_bug.cgi?id=20340>
SegmentedVector currently frees segments and reallocates them when used
as a stack. This can lead to unsafe use of pointers into freed segments.
In order to fix this problem, SegmentedVector will be changed to only
grow and never shrink. Also, rename the reserveCapacity() member
function to grow() to match the actual usage in BytecodeGenerator, where
this function is used to allocate a group of registers at once, rather
than merely saving space for them.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Use grow() instead of
reserveCapacity().
* bytecompiler/SegmentedVector.h:
(JSC::SegmentedVector::SegmentedVector):
(JSC::SegmentedVector::last):
(JSC::SegmentedVector::append):
(JSC::SegmentedVector::removeLast):
(JSC::SegmentedVector::grow): Renamed from reserveCapacity().
(JSC::SegmentedVector::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Tue, 2 Dec 2008 01:31:58 +0000 (01:31 +0000)]
2008-12-01 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Mark Rowe.
Updated the reference images for the <video> layout tests as the ones checked-in previously
do not pass on the pixel bots.
https://bugs.webkit.org/show_bug.cgi?id=21911
* platform/mac/media/video-aspect-ratio-expected.checksum:
* platform/mac/media/video-aspect-ratio-expected.png:
* platform/mac/media/video-controls-rendering-expected.checksum:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-display-toggle-expected.checksum:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-layer-crash-expected.checksum:
* platform/mac/media/video-layer-crash-expected.png:
* platform/mac/media/video-transformed-expected.checksum:
* platform/mac/media/video-transformed-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 2 Dec 2008 01:07:50 +0000 (01:07 +0000)]
Fix logic error in LegacyWebArchive::create() from r38884.
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Only continue if the
subresource is actually added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 2 Dec 2008 00:53:35 +0000 (00:53 +0000)]
Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
<https://bugs.webkit.org/show_bug.cgi?id=22466>
<rdar://problem/6403593>
Reviewed by Brady Eidson.
WebCore:
Test: http/tests/webarchive/test-preload-resources.html
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Check the WebCore cache for
resources if DocumentLoader::subresource() doesn't return them.
Note that the DocumentLoader::subresource() method returned
preloaded resources before r35867, but this caused a regression in
Mail.
WebKitTools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(normalizeHTTPResponseHeaderFields): Added. Normalizes Date, Etag,
Keep-Alive, Last-Modified and Server header fields to prevent false
positive test failures.
(convertWebResourceResponseToDictionary): Call
normalizeHTTPResponseHeaderFields() to noramlize HTTP response
header fields.
LayoutTests:
* http/tests/webarchive/resources/test-preload-resources.css: Added.
* http/tests/webarchive/test-preload-resources-expected.webarchive: Added.
* http/tests/webarchive/test-preload-resources.html: Added.
* platform/qt/Skipped: Added http/tests/webarchive and grouped the
skipped list of other webarchive tests together.
* platform/win/Skipped: Added http/tests/webarchive.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2008 00:51:04 +0000 (00:51 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Move instantiatePlugin to NetscapePluginHostManager.
* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginHostProxy.h:
* Plugins/Hosted/NetscapePluginHostProxy.mm:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2008 00:36:25 +0000 (00:36 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Pass the plug-in host port directly to the instance proxy.
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::instantiatePlugin):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::create):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
(WebKit::NetscapePluginInstanceProxy::resize):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::focusChanged):
(WebKit::NetscapePluginInstanceProxy::windowFocusChanged):
(WebKit::NetscapePluginInstanceProxy::windowFrameChanged):
(WebKit::NetscapePluginInstanceProxy::startTimers):
(WebKit::NetscapePluginInstanceProxy::mouseEvent):
(WebKit::NetscapePluginInstanceProxy::stopTimers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 2 Dec 2008 00:10:33 +0000 (00:10 +0000)]
2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22564: Make HTML elements' constructors take a QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=22564
- Modified the remaining HTML elements' constructors to take a QualifiedName.
- Added an assertion that the QualifiedName given corresponds to the element constructed.
* bindings/js/JSAudioConstructor.cpp:
(WebCore::constructAudio):
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::HTMLAudioElement):
* html/HTMLAudioElement.h:
* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::HTMLBRElement):
* html/HTMLBRElement.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
* html/HTMLElementFactory.cpp:
(WebCore::brConstructor):
(WebCore::quoteConstructor):
(WebCore::marqueeConstructor):
(WebCore::audioConstructor):
(WebCore::videoConstructor):
(WebCore::sourceConstructor):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
* html/HTMLMarqueeElement.h:
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::HTMLQuoteElement):
* html/HTMLQuoteElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::HTMLSourceElement):
* html/HTMLSourceElement.h:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::HTMLVideoElement):
* html/HTMLVideoElement.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::updateFromElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Mon, 1 Dec 2008 23:58:49 +0000 (23:58 +0000)]
2008-12-01 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22464
Add a test for a potential crash when performing a same-origin
check on a subframe reloaded with about:blank.
* fast/js/same-origin-subframe-about-blank-expected.txt: Added.
* fast/js/same-origin-subframe-about-blank.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Mon, 1 Dec 2008 23:37:16 +0000 (23:37 +0000)]
2008-12-01 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Fixed <video> layout tests so that DRT is notified they are done only when the video frames
are effectively rendered in the page. This requires using a timeout since there is no <video>
event that fires when the first frame has been drawn (the closest even fires when the element
is ready to render and will eventually draw at some unknown point in the future).
Thanks to this change, these tests now pass in --pixel mode as well.
https://bugs.webkit.org/show_bug.cgi?id=21911
* media/video-aspect-ratio.html:
* media/video-controls-rendering.html:
* media/video-display-toggle.html:
* media/video-layer-crash.html:
* media/video-paint-test.js:
(init):
* media/video-transformed.html:
* platform/mac/media/video-aspect-ratio-expected.checksum:
* platform/mac/media/video-aspect-ratio-expected.png:
* platform/mac/media/video-controls-rendering-expected.checksum:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-display-toggle-expected.checksum:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-layer-crash-expected.checksum:
* platform/mac/media/video-layer-crash-expected.png:
* platform/mac/media/video-transformed-expected.checksum:
* platform/mac/media/video-transformed-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Mon, 1 Dec 2008 23:07:04 +0000 (23:07 +0000)]
2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Antti Koivisto.
Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441
Add an assertion to the modified HTML elements' constructor
to check that the QualifiedName parameter is the one that
matches the Element's.
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::HTMLBaseElement):
* html/HTMLBlockquoteElement.cpp:
(WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::HTMLBodyElement):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::HTMLButtonElement):
* html/HTMLDListElement.cpp:
(WebCore::HTMLDListElement::HTMLDListElement):
* html/HTMLDirectoryElement.cpp:
(WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::HTMLDivElement):
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
* html/HTMLHeadElement.cpp:
(WebCore::HTMLHeadElement::HTMLHeadElement):
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::HTMLHtmlElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
* html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::HTMLLIElement):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::HTMLLabelElement):
* html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::HTMLLegendElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
* html/HTMLMenuElement.cpp:
(WebCore::HTMLMenuElement::HTMLMenuElement):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::HTMLMetaElement):
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::HTMLOListElement):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::HTMLTitleElement):
* html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::HTMLUListElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 1 Dec 2008 22:50:37 +0000 (22:50 +0000)]
Disable WREC for x86_64 since memory allocated by the system allocator is not marked executable,
which causes 64-bit debug builds to crash. Once we have a dedicated allocator for executable
memory we can turn this back on.
Rubber-stamped by Anders Carlsson.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Mon, 1 Dec 2008 22:50:14 +0000 (22:50 +0000)]
2008-12-01 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22046
Fixed another case of crashing because the animation object is getting deleted when
it's in the middle of a callback. I actually moved where I am retaining the pointer
up out of the lower level AnimationBase code and into the timer callback that calls
them. So now the pointer is valid throughout the entire sequence of callback code.
The testcase for https://bugs.webkit.org/show_bug.cgi?id=22052 also exhibits a
crash which this patch fixes.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::animationTimerCallbackFired):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimationPrivate::setAnimationStartTime):
(WebCore::CompositeAnimationPrivate::setTransitionStartTime):
(WebCore::CompositeAnimationPrivate::styleAvailable):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::sendAnimationEvent):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 1 Dec 2008 22:23:29 +0000 (22:23 +0000)]
2008-12-01 Antti Koivisto <antti@apple.com>
Reviewed by Maciej Stachowiak.
Restore inline buffer after vector is shrunk back below its inline capacity.
* wtf/Vector.h:
(WTF::):
(WTF::VectorBuffer::restoreInlineBufferIfNeeded):
(WTF::::shrinkCapacity):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2008 22:18:15 +0000 (22:18 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Try to fix the Tiger build.
* Plugins/WebNetscapePluginView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 1 Dec 2008 22:09:36 +0000 (22:09 +0000)]
Reviewed by Adam Roben.
NULL-check documentFrameView() and topDocumentFrameView() it's possible
for either of these methods to return NULL, and this was seen to cause
crashes in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=22572
* AccessibleBase.cpp:
(AccessibleBase::get_accParent):
(AccessibleBase::accLocation):
(AccessibleBase::accHitTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2008 22:00:50 +0000 (22:00 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Rename _layer to _pluginLayer where I forgot to do so.
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView destroyPlugin]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView setLayer:]):
(-[WebNetscapePluginView destroyPlugin]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 1 Dec 2008 21:56:00 +0000 (21:56 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2008 21:45:40 +0000 (21:45 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2008 21:44:41 +0000 (21:44 +0000)]
2008-12-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make sure to re-insert layers as needed so they won't be lost when the layer backed
view is removed from the view hierarchy.
* Plugins/Hosted/WebHostedNetscapePluginView.h:
Add _layer ivar.
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
Don't add the layer here.
(-[WebHostedNetscapePluginView setLayer:]):
Instead, add it here.
(-[WebHostedNetscapePluginView destroyPlugin]):
Set _layer to 0.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
Don't add the layer here.
(-[WebNetscapePluginView setLayer:]):
Do it here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Mon, 1 Dec 2008 21:23:32 +0000 (21:23 +0000)]
2008-12-01 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22463
Add a test for accessing navigator.cookieEnabled after navigation.
* fast/dom/navigator-cookieEnabled-no-crash-expected.txt: Added.
* fast/dom/navigator-cookieEnabled-no-crash.html: Added.
* fast/dom/resources/test-successful-destination.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 1 Dec 2008 21:14:06 +0000 (21:14 +0000)]
2008-11-30 Antti Koivisto <antti@apple.com>
Reviewed by Mark Rowe.
Try to return free pages in the current thread cache too.
* wtf/FastMalloc.cpp:
(WTF::TCMallocStats::releaseFastMallocFreeMemory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Mon, 1 Dec 2008 20:59:38 +0000 (20:59 +0000)]
2008-12-01 Pamela Greene <pam@chromium.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=22365
Add a test to verify behavior of DOM node constructors.
* fast/dom/dom-constructors-expected.txt: Added.
* fast/dom/dom-constructors.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Mon, 1 Dec 2008 20:52:29 +0000 (20:52 +0000)]
Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
<https://bugs.webkit.org/show_bug.cgi?id=22559>
Reviewed by Adam Roben.
* Scripts/bisect-builds: Updated status message to report the
maximum number of builds left to test after the current one.
(max): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Mon, 1 Dec 2008 20:48:19 +0000 (20:48 +0000)]
2008-12-01 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22358
Add a test for crash on "Copy" after showing a tooltip.
* editing/pasteboard/copy-crash-expected.txt: Added.
* editing/pasteboard/copy-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 1 Dec 2008 20:03:15 +0000 (20:03 +0000)]
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22531
Stack overflow on PowerPC on fast/workers/use-machine-stack.html
Disabling the test until the problem can be investigated.
* fast/workers/use-machine-stack.html: Removed.
* fast/workers/use-machine-stack.html-disabled: Copied from fast/workers/use-machine-stack.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Mon, 1 Dec 2008 17:25:41 +0000 (17:25 +0000)]
2008-12-01 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=22553
Remove unneeded GObject casts.
Remove unneeded casts to GObject in functions that take a gpointer
argument.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):
(WebKit::ChromeClient::createWindow):
(WebKit::ChromeClient::setToolbarsVisible):
(WebKit::ChromeClient::toolbarsVisible):
(WebKit::ChromeClient::setStatusbarVisible):
(WebKit::ChromeClient::statusbarVisible):
(WebKit::ChromeClient::setScrollbarsVisible):
(WebKit::ChromeClient::scrollbarsVisible):
(WebKit::ChromeClient::setMenubarVisible):
(WebKit::ChromeClient::menubarVisible):
(WebKit::ChromeClient::setToolTip):
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::createPage):
* webkit/webkitwebframe.cpp:
* webkit/webkitwebview.cpp:
* webkit/webkitwebwindowfeatures.cpp:
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 1 Dec 2008 14:24:34 +0000 (14:24 +0000)]
Make it clearer in ChangeLog entry that the last change only affected debug builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 1 Dec 2008 14:19:35 +0000 (14:19 +0000)]
2008-12-01 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22567
Make HashTable work as expected with respect to threads. Specifically, it has class-level
thread safety and constant methods work on constant objects without synchronization.
No observable change in behavior, so no test.
* wtf/HashTable.cpp:
(WTF::hashTableStatsMutex):
(WTF::HashTableStats::~HashTableStats):
(WTF::HashTableStats::recordCollisionAtCount):
Guarded variable access with a mutex.
* wtf/HashTable.h:
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
(WTF::::add):
(WTF::::reinsert):
(WTF::::remove):
(WTF::::rehash):
Changed increments of static variables to use atomicIncrement.
(WTF::::invalidateIterators):
(WTF::addIterator):
(WTF::removeIterator):
Guarded mutable access with a mutex.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 1 Dec 2008 09:25:48 +0000 (09:25 +0000)]
2008-12-01 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt/Mac] Initialize NPAPI plugins before getting their entry points
The old behavior (calling NP_GetEntryPoints before NP_Initialize) was
copied from Windows, but caused Silverlight on Mac to crash when loaded.
Apparently the call order of NP_Initialize and NP_GetEntryPoints is
reversed on Mac. See https://bugzilla.mozilla.org/show_bug.cgi?id=344425
Reported-by: Peter Johnson <peter@zattoo.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 1 Dec 2008 09:18:36 +0000 (09:18 +0000)]
2008-11-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Enable WREC on PLATFORM(X86_64). This change predominantly requires changes to the
WREC::Generator::generateEnter method to support the x86-64 ABI, and addition of
support for a limited number of quadword operations in the X86Assembler.
This patch will cause the JS heap to be allocated with RWX permissions on 64-bit Mac
platforms. This is a regression with respect to previous 64-bit behaviour, but is no
more permissive than on 32-bit builds. This issue should be addressed at some point.
(This is tracked by bug #21783.)
https://bugs.webkit.org/show_bug.cgi?id=22554
Greater than 4x speedup on regexp-dna, on x86-64.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::loadPtr):
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::pop):
(JSC::MacroAssembler::push):
(JSC::MacroAssembler::move):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::movq_rr):
(JSC::X86Assembler::addl_i8m):
(JSC::X86Assembler::addl_i32r):
(JSC::X86Assembler::addq_i8r):
(JSC::X86Assembler::addq_i32r):
(JSC::X86Assembler::movq_mr):
(JSC::X86Assembler::movq_rm):
* wrec/WREC.h:
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generateEnter):
(JSC::WREC::Generator::generateReturnSuccess):
(JSC::WREC::Generator::generateReturnFailure):
* wtf/Platform.h:
* wtf/TCSystemAlloc.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 1 Dec 2008 09:07:07 +0000 (09:07 +0000)]
2008-12-01 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Preliminary work for bug 20340: SegmentedVector segment allocations can lead to unsafe use of temporary registers
<https://bugs.webkit.org/show_bug.cgi?id=20340>
SegmentedVector currently frees segments and reallocates them when used
as a stack. This can lead to unsafe use of pointers into freed segments.
In order to fix this problem, SegmentedVector will be changed to only
grow and never shrink, with the sole exception of clearing all of its
data, a capability that is required by Lexer. This patch changes the
public interface to only allow for these capabilities.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Use reserveCapacity()
instead of resize() for m_globals and m_parameters.
* bytecompiler/SegmentedVector.h:
(JSC::SegmentedVector::resize): Removed.
(JSC::SegmentedVector::reserveCapacity): Added.
(JSC::SegmentedVector::clear): Added.
(JSC::SegmentedVector::shrink): Removed.
(JSC::SegmentedVector::grow): Removed.
* parser/Lexer.cpp:
(JSC::Lexer::clear): Use clear() instead of resize(0).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 1 Dec 2008 05:35:44 +0000 (05:35 +0000)]
Bug 22510: Crash at WebCore::AccessibilityRenderObject::activeDescendant() on Google Reader with ARIA
https://bugs.webkit.org/show_bug.cgi?id=22510
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 30 Nov 2008 22:28:56 +0000 (22:28 +0000)]
2008-11-30 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Renames jumps to m_jumps in JumpList.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::JumpList::link):
(JSC::MacroAssembler::JumpList::linkTo):
(JSC::MacroAssembler::JumpList::append):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 30 Nov 2008 22:19:42 +0000 (22:19 +0000)]
JavaScriptCore:
2008-11-30 Antti Koivisto <antti@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22557
Report free size in central and thread caches too.
* wtf/FastMalloc.cpp:
(WTF::TCMallocStats::fastMallocStatistics):
* wtf/FastMalloc.h:
WebKit/mac:
2008-11-30 Antti Koivisto <antti@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22557
Report free size in central and thread caches too.
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics memoryStatistics]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 30 Nov 2008 20:09:08 +0000 (20:09 +0000)]
2008-11-30 Antti Koivisto <antti@apple.com>
Another Windows build fix.
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 30 Nov 2008 20:07:07 +0000 (20:07 +0000)]
2008-11-30 Antti Koivisto <antti@apple.com>
Windows build fix.
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 30 Nov 2008 08:31:11 +0000 (08:31 +0000)]
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22530
Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID
* dom/WorkerThread.cpp:
(WebCore::WorkerThread::start): Protect worker startup with a mutex to ensure that this
function runs to completion before the thread begins execution.
(WebCore::WorkerThread::workerThread): Updated comments.
(WebCore::WorkerThread::stop): Ditto.
* dom/WorkerThread.h: Renamed m_workerContextMutex to m_threadCreationMutex, because it now
protects startup as a whole.
* storage/DatabaseThread.cpp:
* storage/DatabaseThread.h:
* storage/LocalStorageThread.cpp:
* storage/LocalStorageThread.h:
Fixed the same m_threadID problem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 30 Nov 2008 07:09:50 +0000 (07:09 +0000)]
JavaScriptCore:
2008-11-29 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22557
Add statistics for JavaScript GC heap.
* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::objectCount):
(JSC::addToStatistics):
(JSC::Heap::statistics):
* runtime/Collector.h:
WebKit/mac:
2008-11-29 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22557
Add statistics for JavaScript GC heap.
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectsCount]):
(+[WebCoreStatistics memoryStatistics]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 30 Nov 2008 00:39:57 +0000 (00:39 +0000)]
2008-11-29 Antti Koivisto <antti@apple.com>
Fix debug build by adding a stub method.
* wtf/FastMalloc.cpp:
(WTF::fastMallocStatistics):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Sat, 29 Nov 2008 23:44:49 +0000 (23:44 +0000)]
WebCore:
2008-11-29 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alexey Proskuryakov.
Remove Visual Studio project dependencies on non-redistributable
components in the Debug_Cairo and Release_Cairo build targets.
See https://bugs.webkit.org/show_bug.cgi?id=22527
* WebCore.vcproj/WebCore.vcproj:
WebKit/win:
2008-11-29 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alexey Proskuryakov.
Remove Visual Studio project dependencies on non-redistributable
components in the Debug_Cairo and Release_Cairo build targets.
See https://bugs.webkit.org/show_bug.cgi?id=22527
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother
building the unused QuickTime support library.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 29 Nov 2008 22:35:04 +0000 (22:35 +0000)]
2008-11-29 Sam Weinig <sam@webkit.org>
Rubber-stamped by Alexey Proskuryakov.
Fix some sorting
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 29 Nov 2008 22:33:49 +0000 (22:33 +0000)]
WebCore:
2008-11-28 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
NULL pointer crash in dispatchEvent(null);
Test: fast/events/dispatchEvent-crash.html
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchEvent):
* dom/Worker.cpp:
(WebCore::Worker::dispatchEvent):
* dom/WorkerContext.cpp:
(WebCore::WorkerContext::dispatchEvent):
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::dispatchEvent):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dispatchEvent):
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchEvent):
LayoutTests:
2008-11-28 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Test for https://bugs.webkit.org/show_bug.cgi?id=21063
NULL pointer crash in dispatchEvent(null);
* fast/events/dispatchEvent-crash-expected.txt: Added.
* fast/events/dispatchEvent-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 29 Nov 2008 22:10:16 +0000 (22:10 +0000)]
JavaScriptCore:
2008-11-29 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22557
Add function for getting basic statistics from FastMalloc.
* JavaScriptCore.exp:
* wtf/FastMalloc.cpp:
(WTF::DLL_Length):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMallocStats::fastMallocStatistics):
* wtf/FastMalloc.h:
WebKit/mac:
2008-11-29 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22557
- Add purgeable memory statistics to cache statistics.
- Add method for getting fastMalloc statistics.
- Add method to force returning free memory back to system.
* Misc/WebCache.mm:
(+[WebCache statistics]):
* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):
(+[WebCoreStatistics memoryStatistics]):
(+[WebCoreStatistics returnFreeMemoryToSystem]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 29 Nov 2008 21:40:23 +0000 (21:40 +0000)]
WebCore:
Reviewed by Alexey Proskuryakov.
- fix https://bugs.webkit.org/show_bug.cgi?id=22454
<rdar://problem/6405550> REGRESSION (3.2-TOT): Crash below FontFallbackList::fontDataAt on jacobian.org
Test: http/tests/misc/font-face-in-multiple-segmented-faces.html
The crash happened because style recalculation was invoked by
CSSFontSelector after one CSSSegmentedFontFace had pruned its tables but
before another CSSSegmentedFontFace using the same CSSFontFace had done
so. The fix is to let all CSSSegmentedFontFaces using the CSSFontFace
prune their tables before telling the CSSFontSelector to recalc style.
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fontLoaded):
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded):
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test for https://bugs.webkit.org/show_bug.cgi?id=22454
<rdar://problem/6405550> REGRESSION (3.2-TOT): Crash below FontFallbackList::fontDataAt on jacobian.org
* http/tests/misc/font-face-in-multiple-segmented-faces-expected.txt: Added.
* http/tests/misc/font-face-in-multiple-segmented-faces.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 29 Nov 2008 18:29:10 +0000 (18:29 +0000)]
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=14968
document.open() erroneously returns void instead of the new Document
Test: fast/dom/HTMLDocument/document-open-return-value.html
* bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
Return the document on which this method was invoked, per HTML5.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Sat, 29 Nov 2008 12:14:27 +0000 (12:14 +0000)]
2008-11-29 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=17122
[GTK] Bad font default settings
Implement a property "enforce-96-dpi" in WebKitWebSettings
that can be enabled to force the view to assume 96 DPI.
* webkit/webkitwebsettings.cpp:
(_WebKitWebSettingsPrivate::):
(_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
(_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
(_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sat, 29 Nov 2008 12:07:29 +0000 (12:07 +0000)]
2008-11-29 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
The C++ standard does not automatically grant the friendships of an
enclosing class to its nested subclasses, so we should do so explicitly.
This fixes the GCC 4.0 build, although both GCC 4.2 and Visual C++ 2005
accept the incorrect code as it is.
* assembler/MacroAssembler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 29 Nov 2008 11:10:35 +0000 (11:10 +0000)]
2008-11-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Add the class MacroAssembler to provide some abstraction of code generation,
and change WREC to make use of this class, rather than directly accessing
the X86Assembler.
This patch also allows WREC to be compiled without the rest of the JIT enabled.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssembler.h: Added.
(JSC::MacroAssembler::):
(JSC::MacroAssembler::MacroAssembler):
(JSC::MacroAssembler::copyCode):
(JSC::MacroAssembler::Address::Address):
(JSC::MacroAssembler::ImplicitAddress::ImplicitAddress):
(JSC::MacroAssembler::BaseIndex::BaseIndex):
(JSC::MacroAssembler::Label::Label):
(JSC::MacroAssembler::Jump::Jump):
(JSC::MacroAssembler::Jump::link):
(JSC::MacroAssembler::Jump::linkTo):
(JSC::MacroAssembler::JumpList::link):
(JSC::MacroAssembler::JumpList::linkTo):
(JSC::MacroAssembler::JumpList::append):
(JSC::MacroAssembler::Imm32::Imm32):
(JSC::MacroAssembler::add32):
(JSC::MacroAssembler::or32):
(JSC::MacroAssembler::sub32):
(JSC::MacroAssembler::loadPtr):
(JSC::MacroAssembler::load32):
(JSC::MacroAssembler::load16):
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::pop):
(JSC::MacroAssembler::push):
(JSC::MacroAssembler::peek):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::move):
(JSC::MacroAssembler::compareImm32ForBranch):
(JSC::MacroAssembler::compareImm32ForBranchEquality):
(JSC::MacroAssembler::jae32):
(JSC::MacroAssembler::je32):
(JSC::MacroAssembler::je16):
(JSC::MacroAssembler::jg32):
(JSC::MacroAssembler::jge32):
(JSC::MacroAssembler::jl32):
(JSC::MacroAssembler::jle32):
(JSC::MacroAssembler::jne32):
(JSC::MacroAssembler::jump):
(JSC::MacroAssembler::breakpoint):
(JSC::MacroAssembler::ret):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cmpw_rm):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
* interpreter/Interpreter.h:
(JSC::Interpreter::assemblerBuffer):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* wrec/WREC.cpp:
(JSC::WREC::Generator::compileRegExp):
* wrec/WREC.h:
* wrec/WRECFunctors.cpp:
(JSC::WREC::GeneratePatternCharacterFunctor::generateAtom):
(JSC::WREC::GenerateCharacterClassFunctor::generateAtom):
(JSC::WREC::GenerateBackreferenceFunctor::generateAtom):
(JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
* wrec/WRECFunctors.h:
(JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generateEnter):
(JSC::WREC::Generator::generateReturnSuccess):
(JSC::WREC::Generator::generateSaveIndex):
(JSC::WREC::Generator::generateIncrementIndex):
(JSC::WREC::Generator::generateLoadCharacter):
(JSC::WREC::Generator::generateJumpIfEndOfInput):
(JSC::WREC::Generator::generateJumpIfNotEndOfInput):
(JSC::WREC::Generator::generateReturnFailure):
(JSC::WREC::Generator::generateBacktrack1):
(JSC::WREC::Generator::generateBacktrackBackreference):
(JSC::WREC::Generator::generateBackreferenceQuantifier):
(JSC::WREC::Generator::generateNonGreedyQuantifier):
(JSC::WREC::Generator::generateGreedyQuantifier):
(JSC::WREC::Generator::generatePatternCharacter):
(JSC::WREC::Generator::generateCharacterClassInvertedRange):
(JSC::WREC::Generator::generateCharacterClassInverted):
(JSC::WREC::Generator::generateCharacterClass):
(JSC::WREC::Generator::generateParentheses):
(JSC::WREC::Generator::generateParenthesesNonGreedy):
(JSC::WREC::Generator::generateParenthesesResetTrampoline):
(JSC::WREC::Generator::generateAssertionBOL):
(JSC::WREC::Generator::generateAssertionEOL):
(JSC::WREC::Generator::generateAssertionWordBoundary):
(JSC::WREC::Generator::generateBackreference):
(JSC::WREC::Generator::terminateAlternative):
(JSC::WREC::Generator::terminateDisjunction):
* wrec/WRECGenerator.h:
(JSC::WREC::Generator::Generator):
* wrec/WRECParser.cpp:
(JSC::WREC::Parser::parsePatternCharacterQualifier):
(JSC::WREC::Parser::parseCharacterClassQuantifier):
(JSC::WREC::Parser::parseBackreferenceQuantifier):
(JSC::WREC::Parser::parseParentheses):
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseOctalEscape):
(JSC::WREC::Parser::parseEscape):
(JSC::WREC::Parser::parseTerm):
(JSC::WREC::Parser::parseDisjunction):
* wrec/WRECParser.h:
(JSC::WREC::Parser::Parser):
(JSC::WREC::Parser::parsePattern):
(JSC::WREC::Parser::parseAlternative):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Nov 2008 04:00:20 +0000 (04:00 +0000)]
Reviewed by Cameron Zwarich.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550
Add <timer> element support. It provides a way to execute a task with a delay.
The user is notified by firing the task associated with the <card>'s ontimer attribute.
Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Nov 2008 02:52:04 +0000 (02:52 +0000)]
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549
Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
Changes numerous of layout tests which contain <do> elements, as they render as buttons now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 29 Nov 2008 01:23:48 +0000 (01:23 +0000)]
2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
Simplify the code. There is no reason to have code like
if (true) return false; which is using temporary variables.
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 29 Nov 2008 01:23:09 +0000 (01:23 +0000)]
2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
Remove bogus null checks. The WebKitWebView own's a WebCore::Page
which is owning a WebCore::ChromeClient. There is no way that a
WebCore::ChromeClient is still around when the WebKitWebView is gone.
m_webView can only be null when a ChromeClient gets constructed with
a null WebKitWebView which is not allowed.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::windowRect):
(WebKit::ChromeClient::setWindowRect):
(WebKit::ChromeClient::pageRect):
(WebKit::ChromeClient::focus):
(WebKit::ChromeClient::unfocus):
(WebKit::ChromeClient::show):
(WebKit::ChromeClient::setToolbarsVisible):
(WebKit::ChromeClient::toolbarsVisible):
(WebKit::ChromeClient::setStatusbarVisible):
(WebKit::ChromeClient::statusbarVisible):
(WebKit::ChromeClient::setScrollbarsVisible):
(WebKit::ChromeClient::setMenubarVisible):
(WebKit::ChromeClient::menubarVisible):
(WebKit::ChromeClient::canTakeFocus):
(WebKit::ChromeClient::repaint):
(WebKit::ChromeClient::scroll):
(WebKit::ChromeClient::platformWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 29 Nov 2008 00:20:56 +0000 (00:20 +0000)]
2008-11-28 Gustavo Noronha Silva <gns@gnome.org>
Reviewed and slightly modified by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=19130
ChromeClient::createWindow and friends need to be implemented
Code from Gustavo Noronha and Marco Barisione
<marco.barisione@collabora.co.uk> in this change set.
Implemented all the ChromeClient interfaces needed to have new
window creation functioning and exposed to client code. We
implemented a mirror GObject to the WindowFeatures object provided
by WebCore.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowRect):
(WebKit::ChromeClient::setWindowRect):
(WebKit::ChromeClient::unfocus):
(WebKit::ChromeClient::createWindow):
(WebKit::ChromeClient::show):
(WebKit::ChromeClient::setToolbarsVisible):
(WebKit::ChromeClient::toolbarsVisible):
(WebKit::ChromeClient::setStatusbarVisible):
(WebKit::ChromeClient::statusbarVisible):
(WebKit::ChromeClient::setScrollbarsVisible):
(WebKit::ChromeClient::scrollbarsVisible):
(WebKit::ChromeClient::setMenubarVisible):
(WebKit::ChromeClient::menubarVisible):
(WebKit::ChromeClient::setResizable):
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClient::dispatchShow):
(WebKit::FrameLoaderClient::dispatchCreatePage):
* webkit/webkit.h:
* webkit/webkitdefines.h:
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
* webkit/webkitwebview.h:
* webkit/webkitwebwindowfeatures.cpp: Added.
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
(_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
* webkit/webkitwebwindowfeatures.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 28 Nov 2008 21:36:13 +0000 (21:36 +0000)]
Reviewed by Sam Weinig.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545
Add onenterforward/onenterbackward/ontimer support for <card> elements.
No testing possible at the moment because WMLGoElement is not yet implemented.
After that we can add tests covering the <card> event handling.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 28 Nov 2008 18:14:02 +0000 (18:14 +0000)]
2008-11-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Tor Arne Vestbø.
Regression seen on QtWebKit - causes a build failure on Win using MinGW
https://bugs.webkit.org/show_bug.cgi?id=22536
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 28 Nov 2008 15:19:09 +0000 (15:19 +0000)]
2008-11-28 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Fix compilation on Windows CE
Port away from the use of errno after calling strtol(), instead
detect conversion errors by checking the result and the stop
position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 28 Nov 2008 15:19:01 +0000 (15:19 +0000)]
2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 28 Nov 2008 15:18:53 +0000 (15:18 +0000)]
2008-11-28 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Fix compilation and linking on Windows CE.
Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
from the Windows'ish build.
Link against the newly required mmtimer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 28 Nov 2008 15:18:45 +0000 (15:18 +0000)]
2008-11-28 Simon Hausmann <hausmann@webkit.org>
Rubber-stamped by Tor Arne Vestbø.
Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 28 Nov 2008 10:23:41 +0000 (10:23 +0000)]
2008-11-28 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=22524
Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
of XMLHttpRequest by Workers (on threads).
No observable change in behavior, so no test.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
(WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
(WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
(WebCore::PreflightResultCacheItem::allowsRequest):
(WebCore::createXMLHttpRequestStaticData):
(WebCore::initializeXMLHttpRequestStaticData):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::isSafeRequestHeader):
(WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
* xml/XMLHttpRequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 28 Nov 2008 05:03:46 +0000 (05:03 +0000)]
2008-11-27 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
r38825 made JSFunction::m_body private, but some inspector code in
WebCore sets the field. Add setters for it, and update the inspector
code to use the new getters and setters.
JavaScriptCore:
* runtime/JSFunction.h:
(JSC::JSFunction::setBody):
WebCore:
* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 28 Nov 2008 02:24:20 +0000 (02:24 +0000)]
2008-11-27 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix FIXME by adding accessor for JSFunction's m_body property.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::cti_op_call_JSFunction):
(JSC::Interpreter::cti_vm_dontLazyLinkCall):
(JSC::Interpreter::cti_vm_lazyLinkCall):
* profiler/Profiler.cpp:
(JSC::createCallIdentifierFromFunctionImp):
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.h:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::body):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 28 Nov 2008 01:43:51 +0000 (01:43 +0000)]
2008-11-27 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22468: Coding style: config.h should only be included in implementation files, not in header
https://bugs.webkit.org/show_bug.cgi?id=22468
Clarified the rules about config.h inclusion and added 2 new examples to illustrate it. Also
added an explanation about the implementation files.
* coding/coding-style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 28 Nov 2008 01:26:18 +0000 (01:26 +0000)]
2008-11-27 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Remove unused member variables from ProgramNode.
* parser/Nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Thu, 27 Nov 2008 23:30:56 +0000 (23:30 +0000)]
2008-11-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alexey Proskuryakov.
Enable mouse panning feaure on Windows Cairo build.
See http://bugs.webkit.org/show_bug.cgi?id=22525
* wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 27 Nov 2008 18:03:06 +0000 (18:03 +0000)]
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22529
Crashes seen on buildbots due to trying to stop a worker thread twice
* dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
Don't try to stop the thread if it's already stopping.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 27 Nov 2008 16:13:54 +0000 (16:13 +0000)]
WebCore:
2008-11-27 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Make JavaScript bindings for Qt plugin widgets work again
this was a regression; need to handle non-NPAPI plugins as in 4.4.
WebKit:
2008-11-27 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Added auto tests for making JavaScript bindings for Qt plugin widgets
work again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 27 Nov 2008 13:07:08 +0000 (13:07 +0000)]
2008-11-27 Alp Toker <alp@nuanti.com>
Change recently introduced C++ comments in Platform.h to C comments to
fix the minidom build with traditional C.
Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
API header breakage at build time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 27 Nov 2008 12:21:28 +0000 (12:21 +0000)]
Fixed ChangeLog dates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 27 Nov 2008 12:14:09 +0000 (12:14 +0000)]
2008-11-27 Alp Toker <alp@nuanti.com>
Remove C++ comment from JavaScriptCore API headers (introduced r35449).
Fixes build for ANSI C applications using the public API.
* API/WebKitAvailability.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log