WebKit-https.git
8 years agoComcast website displays bottom of page when loaded
andersca@apple.com [Sat, 12 May 2012 00:56:13 +0000 (00:56 +0000)]
Comcast website displays bottom of page when loaded
https://bugs.webkit.org/show_bug.cgi?id=86277
<rdar://problem/11426887>

Reviewed by Beth Dakin.

There were two bugs here. The first bug was that FrameView::setScrollPosition didn't end up calling into the scrolling coordinator
to update the scroll position. The second bug was that ScrollingTreeNodeMac::setScrollPosition didn't constrain the scroll position
to the edge of the page.

* page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
Call requestScrollPositionUpdate.

* page/scrolling/ScrollingTree.cpp:
* page/scrolling/ScrollingTree.h:
Remove setMainFrameScrollPosition, it is not called by anyone.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Clamp to the page size and call setScrollPositionWithoutContentEdgeConstraints.

(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
Update the scroll layer position and call back to the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call setScrollPosition.

(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Call setScrollPositionWithoutContentEdgeConstraints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert some MathML layout tests to reftests
commit-queue@webkit.org [Sat, 12 May 2012 00:42:16 +0000 (00:42 +0000)]
Convert some MathML layout tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=86250

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

* mathml/presentation/msub-base-changed-expected.html: Added.
* mathml/presentation/msub-sub-changed-expected.html: Added.
* mathml/presentation/msubsup-base-changed-expected.html: Added.
* mathml/presentation/msubsup-sub-changed-expected.html: Added.
* mathml/presentation/msubsup-sup-changed-expected.html: Added.
* mathml/presentation/msup-base-changed-expected.html: Added.
* mathml/presentation/msup-sup-changed-expected.html: Added.
* platform/efl/mathml/presentation/msub-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msub-sub-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msup-base-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/efl/mathml/presentation/msup-sup-changed-expected.png: Removed.
* platform/efl/mathml/presentation/msup-sup-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msub-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msub-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msub-sub-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msub-sub-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msup-base-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msup-base-changed-expected.txt: Removed.
* platform/mac/mathml/presentation/msup-sup-changed-expected.png: Removed.
* platform/mac/mathml/presentation/msup-sup-changed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce PropertyName class
barraclough@apple.com [Sat, 12 May 2012 00:39:43 +0000 (00:39 +0000)]
Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Geoff Garen.

Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
This change paves the way to allow for properties keyed by values that are not Identifiers.

This change is largely a mechanical find & replace.
It also changes JSFunction's constructor to take a UString& instead of an Identifier&
(since in some cases we can no longer guarantee that we'lll have an Identifier), and
unifies Identifier's methods to obtain array indices onto PropertyName.

The new PropertyName class retains the ability to support .impl() and .ustring(), but
in a future patch we may need to rework this, since not all PropertyNames should be
equal based on their string representation.

Source/JavaScriptCore:

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::finishCreation):
* API/JSCallbackFunction.h:
(JSCallbackFunction):
(JSC::JSCallbackFunction::create):
* API/JSCallbackObject.h:
(JSCallbackObject):
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* API/JSObjectRef.cpp:
(JSObjectMakeFunctionWithCallback):
* JSCTypedArrayStubs.h:
(JSC):
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putDirectVirtual):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineOwnProperty):
* debugger/DebuggerActivation.h:
(DebuggerActivation):
* jsc.cpp:
(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
* runtime/Arguments.h:
(Arguments):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(ArrayConstructor):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
(JSC::putProperty):
* runtime/ArrayPrototype.h:
(ArrayPrototype):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::finishCreation):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(BooleanPrototype):
* runtime/ClassInfo.h:
(MethodTable):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(DateConstructor):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
(DatePrototype):
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(ErrorPrototype):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
(FunctionPrototype):
* runtime/Identifier.cpp:
(JSC):
* runtime/Identifier.h:
(Identifier):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
(InternalFunction):
* runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putDirectVirtual):
(JSC::JSActivation::deleteProperty):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
(JSActivation):
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
(JSArray):
(JSC):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::finishCreation):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlot):
(JSC::JSCell::put):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::putDirectVirtual):
(JSC::JSCell::defineOwnProperty):
(JSC::JSCell::getOwnPropertyDescriptor):
* runtime/JSCell.h:
(JSCell):
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::getCalculatedDisplayName):
* runtime/JSFunction.h:
(JSFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
(JSC::JSGlobalObject::symbolTableHasProperty):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
* runtime/JSNotAnObject.h:
(JSNotAnObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
(JSONObject):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::hasProperty):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::callDefaultValueFunction):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::get):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSValue::get):
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.h:
(JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSString):
(JSC::JSString::getStringPropertySlot):
* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
* runtime/JSValue.h:
(JSC):
(JSValue):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::putDirectVirtual):
* runtime/JSVariableObject.h:
(JSVariableObject):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashTable::entry):
(JSC):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueSlot):
(JSC::getStaticValueDescriptor):
(JSC::lookupPut):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
(MathObject):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/NumberConstructor.cpp:
(JSC):
(JSC::NumberConstructor::finishCreation):
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
(JSC::NumberConstructor::put):
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):
* runtime/NumberConstructor.h:
(NumberConstructor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(NumberPrototype):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
* runtime/ObjectConstructor.h:
(ObjectConstructor):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(ObjectPrototype):
* runtime/PropertySlot.h:
(PropertySlot):
(JSC::PropertySlot::getValue):
* runtime/RegExpConstructor.cpp:
(JSC):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::RegExpConstructor::put):
* runtime/RegExpConstructor.h:
(RegExpConstructor):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::defineOwnProperty):
* runtime/RegExpObject.cpp:
(JSC):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::deleteProperty):
(JSC::RegExpObject::defineOwnProperty):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):
(JSC::RegExpObject::put):
* runtime/RegExpObject.h:
(RegExpObject):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(RegExpPrototype):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::deleteProperty):
* runtime/StrictEvalActivation.h:
(StrictEvalActivation):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::finishCreation):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(StringConstructor):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::put):
(JSC::StringObject::defineOwnProperty):
(JSC::StringObject::deleteProperty):
* runtime/StringObject.h:
(StringObject):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:
(StringPrototype):
* runtime/Structure.cpp:
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
* runtime/Structure.h:
(Structure):
(JSC::Structure::get):

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
(WebCore::JSCSSStyleDeclaration::putDelegate):
* bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMBinding.h:
(WebCore):
(WebCore::propertyNameToString):
(WebCore::propertyNameToAtomicString):
* bindings/js/JSDOMMimeTypeArrayCustom.cpp:
(WebCore::JSDOMMimeTypeArray::canGetItemsForName):
(WebCore::JSDOMMimeTypeArray::nameGetter):
* bindings/js/JSDOMPluginArrayCustom.cpp:
(WebCore::JSDOMPluginArray::canGetItemsForName):
(WebCore::JSDOMPluginArray::nameGetter):
* bindings/js/JSDOMPluginCustom.cpp:
(WebCore::JSDOMPlugin::canGetItemsForName):
(WebCore::JSDOMPlugin::nameGetter):
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putDirectVirtual):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
* bindings/js/JSDOMWindowShell.h:
(JSDOMWindowShell):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLAppletElement::putDelegate):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLEmbedElement::putDelegate):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLObjectElement::putDelegate):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::putDelegate):
(WebCore::JSLocationPrototype::defineOwnProperty):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
(WebCore::runtimeObjectCustomPut):
* bindings/js/JSPluginElementFunctions.h:
(WebCore):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):
* bridge/c/c_class.h:
(CClass):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::finishCreation):
(JSC::Bindings::CInstance::getMethod):
* bridge/c/c_instance.h:
(CInstance):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
* bridge/jni/jsc/JavaClassJSC.h:
(JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::finishCreation):
* bridge/jni/jsc/JavaInstanceJSC.h:
(JavaInstance):
* bridge/jsc/BridgeJSC.h:
(Class):
(JSC::Bindings::Class::fallbackObject):
(JSC::Bindings::Instance::setValueOfUndefinedField):
(Instance):
(JSC::Bindings::Instance::getOwnPropertySlot):
(JSC::Bindings::Instance::getOwnPropertyDescriptor):
(JSC::Bindings::Instance::put):
* bridge/objc/objc_class.h:
(ObjcClass):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
(JSC::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_instance.h:
(ObjcInstance):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::finishCreation):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::create):
(JSC::Bindings::ObjcFallbackObjectImp::propertyName):
(ObjcFallbackObjectImp):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
(JSC::Bindings::ObjcFallbackObjectImp::put):
(JSC::Bindings::callObjCFallbackObject):
(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::deleteProperty):
* bridge/runtime_array.h:
(RuntimeArray):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::finishCreation):
(JSC::RuntimeMethod::lengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::create):
(RuntimeMethod):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::deleteProperty):
* bridge/runtime_object.h:
(RuntimeObject):

Source/WebKit/mac:

* Plugins/Hosted/ProxyInstance.h:
(ProxyInstance):
* Plugins/Hosted/ProxyInstance.mm:
(ProxyClass):
(WebKit::ProxyClass::methodsNamed):
(WebKit::ProxyClass::fieldNamed):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::finishCreation):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::finishCreation):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):
(JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(JSNPObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse after free in WebCore::RenderObject::document
commit-queue@webkit.org [Sat, 12 May 2012 00:28:32 +0000 (00:28 +0000)]
use after free in WebCore::RenderObject::document
https://bugs.webkit.org/show_bug.cgi?id=84891

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderMathMLFenced::addChild() to use the beforeChild parameter. When beforeChild
is 0, insert child renderers before the closing fence, which might not be the same as
this->lastChild(), e.g. possibly due to anonymous blocks or generated content.

Tests: mathml/presentation/mfenced-add-child1-expected.html
       mathml/presentation/mfenced-add-child1.html
       mathml/presentation/mfenced-add-child2-expected.html
       mathml/presentation/mfenced-add-child2.html

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
* rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):

LayoutTests:

* mathml/presentation/mfenced-add-child1-expected.html: Added.
* mathml/presentation/mfenced-add-child1.html: Added.
* mathml/presentation/mfenced-add-child2-expected.html: Added.
* mathml/presentation/mfenced-add-child2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo a DEPS roll per build failure caused by r116810.
rniwa@webkit.org [Sat, 12 May 2012 00:14:15 +0000 (00:14 +0000)]
Do a DEPS roll per build failure caused by r116810.

See http://webkitmemes.tumblr.com/post/21734202168/the-solution-to-any-chromium-problem for the rationale.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCan't scroll on webpage after following links from Blogger
andersca@apple.com [Sat, 12 May 2012 00:09:04 +0000 (00:09 +0000)]
Can't scroll on webpage after following links from Blogger
https://bugs.webkit.org/show_bug.cgi?id=86274
<rdar://problem/11431352>

Reviewed by Beth Dakin.

When committing a new scroll layer, make sure to reset the scroll position.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Support drawing debug borders
commit-queue@webkit.org [Fri, 11 May 2012 23:57:55 +0000 (23:57 +0000)]
[TextureMapper] Support drawing debug borders
https://bugs.webkit.org/show_bug.cgi?id=86237

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This is the implementation of an interactive debugging
feature.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create): Moved this to the top of the file to
reduce contention for the coveted last spot in the file. This also
follows the pattern used in many WebCore files of having the factories
at the top.
(WebCore::GraphicsLayerTextureMapper::setDebugBorder): Added this
plumbing.
* platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added
plumbing.
* platform/graphics/texmap/TextureMapper.h: Ditto.
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
Initialize the new member.
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper): When
debug borders are enabled call the new drawBorder method on the TM.
(WebCore::TextureMapperTiledBackingStore::setDebugBorder): Added this
plumbing.
* platform/graphics/texmap/TextureMapperBackingStore.h: Added plumbing
and members to store debug border states. This is necessary because of
the when painting there is no handle on the GraphicsLayers.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRect): Factored out the common bits of
drawTexture and drawBorder into this helper.
(WebCore::TextureMapperGL::drawBorder): Added this method, which works
very similarly to drawTexture, but uses a different shader program and
must also set the line width and color.
(WebCore::TextureMapperGL::drawTexture): Factored out the bits that
are shared with drawRect.
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL): Added the new method declarations.
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(WebCore::TextureMapperImageBuffer::drawBorder): Added an empty
implementation. Later we can add an implementation for the ImageBuffer
TM.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore): When updating the
backing store send the debug border information through.
(WebCore::TextureMapperLayer::syncCompositingStateSelf): When updating
the layer state, also update the debug indicators. This is required to
initialize the debug border values for the layer.
(WebCore::TextureMapperLayer::setDebugBorder): Added this plumbing.
* platform/graphics/texmap/TextureMapperLayer.h: Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.cpp: Added a
solid color shader that doesn't care about texture coordinates or
opacity values.
(WebCore::TextureMapperShaderManager::solidColorProgram): Added. This
is a shorter getter for the solid color program that doesn't require
casting from the caller.
(WebCore::TextureMapperShaderManager::getShaderProgram): Added support
for the solid color program.
(WebCore::TextureMapperShaderProgramSolidColor::create): Added.
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::vertexShaderSource):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::fragmentShaderSource):
Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgramSolidColor): Added.
(WebCore::TextureMapperShaderProgramSolidColor::colorVariable): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRolling out r116659.
msaboff@apple.com [Fri, 11 May 2012 23:50:02 +0000 (23:50 +0000)]
Rolling out r116659.

Causes ASSERT failures on bots.

Rubber stamped by Geoff Garen.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC):
(JSC::SlotVisitor::copyAndAppend):
* heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
* runtime/JSString.h:
(JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit):
(JSC::JSRopeString::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInstrument timer function calls so they show up in the Web Inspector Timeline.
timothy@apple.com [Fri, 11 May 2012 23:40:47 +0000 (23:40 +0000)]
Instrument timer function calls so they show up in the Web Inspector Timeline.

https://webkit.org/b/86173

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-timer.html

* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext): Wrap the call with JSMainThreadExecState::instrumentFunctionCall
and InspectorInstrumentation::didCallFunction.

LayoutTests:

* inspector/timeline/timeline-injected-script-eval-expected.txt: Updated for the blocked scriptName and scriptLine.
* inspector/timeline/timeline-script-tag-1-expected.txt: Updated for the blocked lineNumber.
* inspector/timeline/timeline-script-tag-2-expected.txt: Ditto.
* inspector/timeline/timeline-test.js: Block scriptName, scriptLine, lineNumber and timerId.
* inspector/timeline/timeline-timer-expected.txt: Added.
* inspector/timeline/timeline-timer.html: Added.
* platform/chromium/inspector/timeline/timeline-timer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
beidson@apple.com [Fri, 11 May 2012 23:20:14 +0000 (23:20 +0000)]
<rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
REGRESSION(r104885): Images missing from printed YummySoup! recipes

We thought clients were passing paths as URLs.
It turns out it was more likely they were passing file: URLs with the file: scheme removed.
And that jives perfectly with the behavior change caused by r104885.

Reviewed by Alexey Proskuryakov.

Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
to create the new URL simply by appending "file:":
* Misc/WebNSURLExtras.h:
* Misc/WebNSURLExtras.mm:
(-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):

* WebView/WebFrame.mm:
(-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the
  existing URL string.
(-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
(-[WebFrame loadHTMLString:baseURL:]):
(-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
commit-queue@webkit.org [Fri, 11 May 2012 23:08:16 +0000 (23:08 +0000)]
[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
https://bugs.webkit.org/show_bug.cgi?id=86240

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Free the output received from the g_spawn_sync().

* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAppease thread verifier when dealing with the JSC API's shared VM
oliver@apple.com [Fri, 11 May 2012 23:07:51 +0000 (23:07 +0000)]
Appease thread verifier when dealing with the JSC API's shared VM
https://bugs.webkit.org/show_bug.cgi?id=86268

Reviewed by Geoffrey Garen.

If we're the shared VM, just disable the verifier.  This makes debug builds
livable against non-webkit clients.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium/mac] Let libwebkit.dylib link in Debug/components build
thakis@chromium.org [Fri, 11 May 2012 23:03:45 +0000 (23:03 +0000)]
[chromium/mac] Let libwebkit.dylib link in Debug/components build
https://bugs.webkit.org/show_bug.cgi?id=86244

Reviewed by James Robinson.

In static builds, this was not needed because the targets depending on
'webkit' already link in QuartzCore. In Release components builds, it wasn't
needed because they are built with -dead_strip, which stripped the referencing
code.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove a Chromium test expectation now that the regression is fixed in r116814.
rniwa@webkit.org [Fri, 11 May 2012 22:58:11 +0000 (22:58 +0000)]
Remove a Chromium test expectation now that the regression is fixed in r116814.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116802.
commit-queue@webkit.org [Fri, 11 May 2012 22:55:42 +0000 (22:55 +0000)]
Unreviewed, rolling out r116802.
http://trac.webkit.org/changeset/116802
https://bugs.webkit.org/show_bug.cgi?id=86260

This patch causes compiling error to chromium builds
(Requested by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* WebCore.gypi:

Source/WebKit/chromium:

* features.gypi:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression fix after r116798.
rniwa@webkit.org [Fri, 11 May 2012 22:38:32 +0000 (22:38 +0000)]
Regression fix after r116798.

We need to return true for the html element in the design mode
in which case parentNode() is editable and is not a body element.

* dom/Node.cpp:
(WebCore::Node::isRootEditableElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJIT memory allocator is not returning memory to the OS on Darwin
fpizlo@apple.com [Fri, 11 May 2012 22:37:13 +0000 (22:37 +0000)]
JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047

Reviewed by Geoff Garen.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move createLocalStorageNamespace to Platform.h
pilgrim@chromium.org [Fri, 11 May 2012 22:30:34 +0000 (22:30 +0000)]
[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):
* chromium/public/WebStorageArea.h: Added.
(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):
* chromium/public/WebStorageNamespace.h: Added.
(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebStorageArea.h:
* public/WebStorageNamespace.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::blobRegistry):
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit...
jamesr@google.com [Fri, 11 May 2012 22:19:38 +0000 (22:19 +0000)]
[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Adam Barth.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium on top of
the Platform interface WebGraphicsContext3D. This moves the implementation support code from WebKit/chromium/src
to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore interfaces and
allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

* WebCore.gypi:
* platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.
(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
* platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.
(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
* platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.
(WebKit):
(WebCore):
(GraphicsContext3DPrivate):

Source/WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose WebPluginContainer of WebPlugin to embedder
fsamuel@chromium.org [Fri, 11 May 2012 22:18:35 +0000 (22:18 +0000)]
[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's  WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

* public/WebPlugin.h:
(WebPlugin):
(WebKit::WebPlugin::container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClarified JSGlobalData (JavaScript VM) lifetime
ggaren@apple.com [Fri, 11 May 2012 22:17:00 +0000 (22:17 +0000)]
Clarified JSGlobalData (JavaScript VM) lifetime
https://bugs.webkit.org/show_bug.cgi?id=85142

Reviewed by Alexey Proskuryakov.

(Follow-up fix.)

* API/JSContextRef.cpp:
(JSGlobalContextCreate): Restored some code I removed because I misread an #ifdef.
(We don't need to test BUILDING_ON_LEOPARD, but we still need the linked-on
test, because apps might have been linked on older OS's.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntegrate IETC CSS : xml namespace tests
tomz@codeaurora.org [Fri, 11 May 2012 21:53:20 +0000 (21:53 +0000)]
Integrate IETC CSS : xml namespace tests
https://bugs.webkit.org/show_bug.cgi?id=86144

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Adam Barth.

Integrating 17 IETC xml namespace tests, along with associated
reference tests.

* ietestcenter/css3/namespaces/declaring-001-expected.xml: Added.
* ietestcenter/css3/namespaces/declaring-001.xml: Added.
* ietestcenter/css3/namespaces/prefix-007-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-007.xml: Added.
* ietestcenter/css3/namespaces/prefix-008-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-008.xml: Added.
* ietestcenter/css3/namespaces/prefix-009-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-009.xml: Added.
* ietestcenter/css3/namespaces/prefix-010-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-010.xml: Added.
* ietestcenter/css3/namespaces/prefix-011-expected.xml: Added.
* ietestcenter/css3/namespaces/prefix-011.xml: Added.
* ietestcenter/css3/namespaces/qualifiedNames-001-expected.xml: Added.
* ietestcenter/css3/namespaces/qualifiedNames-001.xml: Added.
* ietestcenter/css3/namespaces/scope-003-expected.xml: Added.
* ietestcenter/css3/namespaces/scope-003.xml: Added.
* ietestcenter/css3/namespaces/syntax-016-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-016.xml: Added.
* ietestcenter/css3/namespaces/syntax-017-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-017.xml: Added.
* ietestcenter/css3/namespaces/syntax-018-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-018.xml: Added.
* ietestcenter/css3/namespaces/syntax-019-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-019.xml: Added.
* ietestcenter/css3/namespaces/syntax-020-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-020.xml: Added.
* ietestcenter/css3/namespaces/syntax-021-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-021.xml: Added.
* ietestcenter/css3/namespaces/syntax-022-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-022.xml: Added.
* ietestcenter/css3/namespaces/syntax-023-expected.xml: Added.
* ietestcenter/css3/namespaces/syntax-023.xml: Added.
* ietestcenter/css3/namespaces/terminology-001-expected.xml: Added.
* ietestcenter/css3/namespaces/terminology-001.xml: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Mark 1 crashed test for chromium mac.
jianli@chromium.org [Fri, 11 May 2012 21:49:32 +0000 (21:49 +0000)]
Unreviewed. Mark 1 crashed test for chromium mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImageSkia.cpp does not conform to style guidelines
commit-queue@webkit.org [Fri, 11 May 2012 21:40:50 +0000 (21:40 +0000)]
ImageSkia.cpp does not conform to style guidelines
https://bugs.webkit.org/show_bug.cgi?id=86219

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-11
Reviewed by Stephen White.

No tests as this is purely style changees.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::TransformDimensions):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaseline one test for chromium mac.
jianli@chromium.org [Fri, 11 May 2012 21:36:20 +0000 (21:36 +0000)]
Unreviewed. Rebaseline one test for chromium mac.

* platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after fonts update in r116778.
philn@webkit.org [Fri, 11 May 2012 21:28:02 +0000 (21:28 +0000)]
Unreviewed, GTK rebaseline after fonts update in r116778.

* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/gtk/fast/dynamic/text-combine-expected.txt:
* platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
* platform/gtk/fast/ruby/nested-ruby-expected.txt:
* platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
* platform/gtk/fast/text/emphasis-combined-text-expected.txt:
* platform/gtk/fast/text/emphasis-vertical-expected.txt:
* platform/gtk/fast/text/international/001-expected.txt:
* platform/gtk/fast/text/international/002-expected.txt:
* platform/gtk/fast/text/international/003-expected.txt:
* platform/gtk/fast/text/international/plane2-expected.txt:
* platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
* platform/gtk/fast/text/international/text-spliced-font-expected.txt:
* platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt:
* platform/gtk/fast/text/international/wrap-CJK-001-expected.txt:
* platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
* platform/gtk/fast/text/justify-ideograph-simple-expected.txt:
* platform/gtk/fast/text/justify-ideograph-vertical-expected.txt:
* platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
* platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/svg/dom/altGlyph-dom-expected.txt:
* platform/gtk/svg/text/text-fonts-01-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium build fix after http://trac.webkit.org/changeset/116799.
timothy_horton@apple.com [Fri, 11 May 2012 21:24:09 +0000 (21:24 +0000)]
Unreviewed Chromium build fix after trac.webkit.org/changeset/116799.

* rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Compute the best target node on a GestureTap event
commit-queue@webkit.org [Fri, 11 May 2012 21:16:19 +0000 (21:16 +0000)]
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

Will be using the tests in the touchadjustment/ directory.

* WebCore.gypi:
Include TouchAdjustment.* files.

Source/WebKit/chromium:

* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

* platform/chromium/test_expectations.txt:
Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116498.
commit-queue@webkit.org [Fri, 11 May 2012 21:12:02 +0000 (21:12 +0000)]
Unreviewed, rolling out r116498.
http://trac.webkit.org/changeset/116498
https://bugs.webkit.org/show_bug.cgi?id=86251

Causes crashes in major sites and security issues (Requested
by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::invalidateTextPositioningElements):
(WebCore::recursiveUpdateScaledFont):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
(WebCore):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
(WebCore::RenderSVGText::layoutAttributes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

* svg/text/add-tspan-position-bug-expected.html: Removed.
* svg/text/add-tspan-position-bug.html: Removed.
* svg/text/modify-tspan-position-bug-expected.html: Removed.
* svg/text/modify-tspan-position-bug.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.
kevino@webkit.org [Fri, 11 May 2012 20:24:31 +0000 (20:24 +0000)]
[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrameView->m_lastPaintTime is not updated in the tiled drawing case
timothy_horton@apple.com [Fri, 11 May 2012 20:16:47 +0000 (20:16 +0000)]
FrameView->m_lastPaintTime is not updated in the tiled drawing case
https://bugs.webkit.org/show_bug.cgi?id=86246
<rdar://problem/11248475>

Reviewed by Simon Fraser.

Update FrameView's m_lastPaintTime from RenderLayerBacking::paintContents
if the RenderLayerBacking is backing a tiled drawing layer.

In the future we might want to consider updating m_lastPaintTime when any
compositing layer is painted into, but this change gets us on par with the
non-tiled-drawing case as it stands now.

No new tests.

* page/FrameView.h:
(WebCore::FrameView::setLastPaintTime):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd helper function for node()->rootEditableElement() == node()
commit-queue@webkit.org [Fri, 11 May 2012 20:09:13 +0000 (20:09 +0000)]
Add helper function for node()->rootEditableElement() == node()
https://bugs.webkit.org/show_bug.cgi?id=86217

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

Added Node::isRootEditableElement and updated existing code that did
(node->rootEditableElement() == node) to use isRootEditableElement
instead.

No new tests. No change in behavior.

* dom/Node.cpp:
(WebCore::Node::isRootEditableElement):
(WebCore):
* dom/Node.h:
(Node):
Added new helper function.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::addOverflowFromInlineChildren):
Updates to existing code to use the new helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Create WebTransformationMatrix interface for chromium platform
shawnsingh@chromium.org [Fri, 11 May 2012 20:07:12 +0000 (20:07 +0000)]
[chromium] Create WebTransformationMatrix interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=86049

Reviewed by James Robinson.

Source/Platform:

* Platform.gyp/Platform.gyp:
* Platform.gypi:
* chromium/public/WebTransformationMatrix.h: Added.
(WebCore):
(WebKit):
(WebTransformationMatrix):

Source/WebCore:

This patch creates a WebTransformationMatrix interface. It will
remain unused at the moment, until (a) unit tests are created
and (b) when we are ready to make a brief transition of all other
chromium code to use it.

* WebCore.gypi:
* platform/chromium/support/WebTransformationMatrix.cpp: Added.
(WebKit):
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::operator*):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
kling@webkit.org [Fri, 11 May 2012 19:49:28 +0000 (19:49 +0000)]
WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
<http://webkit.org/b/86143>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

To avoid spins beneath PluginInfoStore::getPluginInfo(), do this work on a secondary
thread in the UIProcess.

* Shared/APIObject.h:

    Made APIObject a ThreadSafeRefCounted. In the context of this patch, this is to
    be able to dispatch bound Functions on WebContext.

* WebProcess/mac/KeychainItemShimMethods.mm:
(WebKit::responseMap):
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::responseMap):
* WebKit2.xcodeproj/project.pbxproj:
* Shared/BlockingResponseMap.h:
(BlockingResponseMap):
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

     Renamed from Source/WebKit2/WebProcess/mac/KeychainShimResponseMap.h.
     Generalize this somewhat since it's useful in more than just the keychain scenario.
     This can/should be generalized further, but that's a topic for another patch.

* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):

    Slap a mutex on the PluginInfoStore since it can now be called from both the
    main thread (via WKFrameCanShowMIMEType) and the GetPlugin work queue.

* UIProcess/WebContext.messages.in:
* UIProcess/WebContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):
(WebKit::WebContext::getPlugins):
(WebKit::WebContext::didReceiveMessageOnConnectionWorkQueue):

    Make GetPlugins a DispatchOnConnectionQueue message and execute it on a new
    plug-in work queue. This effectively makes the GetPlugin call asynchronous.
    On Mac, the built-in PDF reader is still registered on the main thread as that
    ends up calling into localizedString().

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didGetPlugins):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

    Add a DidGetPlugins message to WebProcess. This is passed directly to the handler
    in WebPlatformStrategies.cpp.

* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::responseMap):
(WebKit::handleDidGetPlugins):
(WebKit::generateRequestID):
(WebKit::WebPlatformStrategies::populatePluginCache):

    Use a BlockingResponseMap to block the WebProcess main thread until the UIProcess
    responds with DidGetPlugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] Make CSS Shaders render to texture framebuffers
achicu@adobe.com [Fri, 11 May 2012 19:45:39 +0000 (19:45 +0000)]
[CSS Shaders] Make CSS Shaders render to texture framebuffers
https://bugs.webkit.org/show_bug.cgi?id=85113

Reviewed by Dean Jackson.

Source/WebCore:

Added the required members to store the framebuffer, the texture and the depth buffer. Also removed the m_drawingBuffer
because context->readPixels doesn't require one anymore.

ReadPixels is not flipping the result, so I've also removed the flipping projection matrix that was specific only to Chromium.

Added a test to check that colors are not switched and the resulting image is not mirrored.

Test: css3/filters/custom/effect-color-check.html

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::~FECustomFilter):
(WebCore):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):

LayoutTests:

Added a test to check that colors are not switched and the resulting image is not mirrored.

* css3/filters/custom/effect-color-check-expected.png: Added.
* css3/filters/custom/effect-color-check-expected.txt: Added.
* css3/filters/custom/effect-color-check.html: Added.
* css3/filters/resources/color-fill.fs: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled...
andersca@apple.com [Fri, 11 May 2012 19:40:30 +0000 (19:40 +0000)]
REGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled string
https://bugs.webkit.org/show_bug.cgi?id=86170

Reviewed by Andreas Kling.

The string we are passing to the TextRun constructor needs to stay alive for longer so revert back to the old
behavior where we store it as a member variable.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Tests needs rebaselining after r116776
commit-queue@webkit.org [Fri, 11 May 2012 19:21:53 +0000 (19:21 +0000)]
[EFL] Tests needs rebaselining after r116776
https://bugs.webkit.org/show_bug.cgi?id=86227

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-11

* platform/efl/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/efl/fast/dynamic/text-combine-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/efl/fast/ruby/base-shorter-than-text-expected.png:
* platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
* platform/efl/fast/ruby/nested-ruby-expected.png:
* platform/efl/fast/ruby/nested-ruby-expected.txt:
* platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/efl/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/efl/fast/text/backslash-to-yen-sign-expected.png:
* platform/efl/fast/text/backslash-to-yen-sign-expected.txt:
* platform/efl/fast/text/emphasis-combined-text-expected.png:
* platform/efl/fast/text/emphasis-combined-text-expected.txt:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/efl/fast/text/justify-ideograph-simple-expected.png:
* platform/efl/fast/text/justify-ideograph-simple-expected.txt:
* platform/efl/fast/text/justify-ideograph-vertical-expected.png:
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.png:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
simon.fraser@apple.com [Fri, 11 May 2012 18:56:32 +0000 (18:56 +0000)]
Source/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

A DisplayRefreshMonitor would keep its CVDisplayLink alive for as long
as it had clients, and the client is the ScriptedAnimationController, which
lives on the document. So a single requestAnimationFrame call would kick
off a CVDisplayLink which lived until the document was destroyed.

Fix by having the DisplayRefreshMonitor kill itself if the CVDisplayLink
fires for 10 times with no scheduled callbacks (to avoid creation/deletion
thrash on pages that call requestAnimationFrames with short setTimeouts,
as some do).

Use a HashMap in DisplayRefreshMonitorManager for the set of DisplayRefreshMonitor,
with the displayID as the key (using UnsignedWithZeroKeyHashTraits<uint64_t> since
we want to allow for 0 to be a valid displayID).

Use a HashSet in DisplayRefreshMonitor for the client set, so that we don't have to
worry about adding clients twice.

Also fix a possible crash when the only client of a DisplayRefreshMonitor
was removed from inside the callback by making DisplayRefreshMonitor ref-counted,
with a protector.

Test: fast/animation/request-animation-frame-detach-element2.html

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize m_unscheduledFireCount
(WebCore::DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread): Renamed
from refreshDisplayOnMainThread, since it doesn't just refresh the display.
(WebCore::DisplayRefreshMonitor::addClient): No longer inline.
(WebCore::DisplayRefreshMonitor::removeClient): No longer inline.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Keep track of m_unscheduledFireCount,
which we used to kill this monitor if it has been idle for a while.
Use a RefPtr<DisplayRefreshMonitor> to prevent deletion while running the callback.
Copy the clients to a vector to protect against mutating the set while enumerating it.
Notify the DisplayRefreshMonitorManager when we're done, so that it can decide
to delete inactive monitors.

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient): find or allocate
a DisplayRefreshMonitor for a given client.
(WebCore::DisplayRefreshMonitorManager::registerClient): Simplified by use of HashMap.
(WebCore::DisplayRefreshMonitorManager::unregisterClient): Ditto.
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation): Ditto. Uses
ensureMonitorForClient() since an earlier inactive monitor may have been removed.
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh): Remove inactive
monitors.
* platform/graphics/DisplayRefreshMonitor.h: Make DisplayRefreshMonitor
ref-counted, to make it easier to avoid deletion while it's on the stack.
(WebCore::DisplayRefreshMonitor::create):
(DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::shouldBeTerminated):
(DisplayRefreshMonitorManager):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Attempt to
keep things building.
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
to give the manager a chance to kill this monitor.
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired): Don't bail early
if not scheduled; we want to call handleDisplayRefreshedNotificationOnMainThread(),

LayoutTests: CVDisplayLink keeps running after a single requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

Test removing a frame inside its requestAnimationFrame callback.

* fast/animation/request-animation-frame-detach-element2-expected.txt: Added.
* fast/animation/request-animation-frame-detach-element2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentation...
pfeldman@chromium.org [Fri, 11 May 2012 18:50:41 +0000 (18:50 +0000)]
Web Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentationModel into ResourceBinding
https://bugs.webkit.org/show_bug.cgi?id=86234

Reviewed by Vsevolod Vlasov.

Simple move refactoring.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RenderLayer::m_scrollOverflow
jchaffraix@webkit.org [Fri, 11 May 2012 18:48:19 +0000 (18:48 +0000)]
Remove RenderLayer::m_scrollOverflow
https://bugs.webkit.org/show_bug.cgi?id=86226

Reviewed by Simon Fraser.

No expected change in behavior.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeScrollDimensions):
Added 2 local variables to compute the left / top scrollable overflows.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrolledContentOffset):
Returned m_scrollOffset directly as this is what the old code was doing by adding
m_scrollOrigin then adding m_scrollOverflow (which was set to -m_scrollOrigin in
computeScrollDimensions).

(RenderLayer::m_scrollOffset): Improved the comment about what m_scrollOffset is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
pfeldman@chromium.org [Fri, 11 May 2012 18:31:41 +0000 (18:31 +0000)]
Web Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=86229

Reviewed by Vsevolod Vlasov.

This change also starts tracking messages along with the live location changes.

Tested with script-formatter-console.html.

* inspector/front-end/BreakpointManager.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify FloatingObject by removing unnecessary convenience methods.
eae@chromium.org [Fri, 11 May 2012 18:21:39 +0000 (18:21 +0000)]
Simplify FloatingObject by removing unnecessary convenience methods.
https://bugs.webkit.org/show_bug.cgi?id=86163

Reviewed by Eric Seidel.

Simplify the pixel snapping in FloatingObject by getting rid of a bunch
of convenience methods.

No new tests, no change in functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):
* rendering/RenderBlock.h:
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline should fetch stale expectations :)
dpranke@chromium.org [Fri, 11 May 2012 18:10:34 +0000 (18:10 +0000)]
webkit-patch rebaseline should fetch stale expectations :)
https://bugs.webkit.org/show_bug.cgi?id=86231

Unreviewed, build fix.

This change reverts r115492 and goes back to fetching individual
baselines from the layout tests directory, rather than fetching
entire zip files. The performance hit over networks for people
far away from the bots has turned out to be severe, so we need a
better solution to this.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._results_url):
(RebaselineTest._file_name_for_expected_result):
(RebaselineTest._rebaseline_test):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Ensure that animations continue to run when transform-style is changed
commit-queue@webkit.org [Fri, 11 May 2012 18:04:15 +0000 (18:04 +0000)]
[chromium] Ensure that animations continue to run when transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283

Source/WebCore:

Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

Test: animations/change-transform-style-during-animation.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):

Source/WebKit/chromium:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

* WebKit.gypi:
* tests/GraphicsLayerChromiumTest.cpp: Added.
(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

LayoutTests:

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

* animations/change-transform-style-during-animation-expected.png: Added.
* animations/change-transform-style-during-animation-expected.txt: Added.
* animations/change-transform-style-during-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix crash seen when running with libgmalloc
weinig@apple.com [Fri, 11 May 2012 17:57:17 +0000 (17:57 +0000)]
Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
https://bugs.webkit.org/show_bug.cgi?id=86232

Reviewed by Gavin Barraclough.

* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
tomz@codeaurora.org [Fri, 11 May 2012 17:28:21 +0000 (17:28 +0000)]
[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Csaba Osztrogonác.

Reference tests originally assumed "background: green" was identical
to the green used in the pngs used by the feature tests. On local builds
of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac
and QT bots however, it became clear this was an invalid assumption. I've
re-written the reference tests to use the original pngs as appropriate.
I have reproduced the failures on a Mac & Qt32 and verified that the newly
re-written reference tests behave properly now.

* ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Fix a reference counting issue in UserMediaRequest
tommyw@google.com [Fri, 11 May 2012 17:09:28 +0000 (17:09 +0000)]
MediaStream API: Fix a reference counting issue in UserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=86210

Reviewed by Abhishek Arya.

.:

* ManualTests/user-media-request-crash.html: Added.

Source/WebCore:

When contextDestroyed() is called on UserMediaRequest it does a callback to the
page client. If the receiving code clears their stored copy the UserMediaRequest
object is destroyed in the middle of the call.

Currently only testable manually against chrome, preferably with asan turned on.
I have added a manual test that verifies the fix, but I have started work
to make DumpRenderTree able to test this and many other things. The first patch is here:
https://bugs.webkit.org/show_bug.cgi?id=86215

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::contextDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosplit MediaPlayer::enterFullscreen into 2 seperate functions
commit-queue@webkit.org [Fri, 11 May 2012 17:05:23 +0000 (17:05 +0000)]
split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin <qinmin@google.com> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

In WebCore, we splitted bool enterFullscreen() into two seperate calls:
void enterFullscreen() and bool canEnterFullscreen()
This is the change in the chromium part that we needed to support the WebCore change
No behavior change, just refactoring.

* public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening failure test cases.
commit-queue@webkit.org [Fri, 11 May 2012 16:51:30 +0000 (16:51 +0000)]
[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86212

Unreviewed EFL gardening.

Test expectations update, moving related bugs from Skipped list to test_expectations.txt.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-11

* platform/efl/Skipped:
* platform/efl/test_expectations.txt: adding new bug regarding to missing contextClick implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
pfeldman@chromium.org [Fri, 11 May 2012 16:46:02 +0000 (16:46 +0000)]
Web Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=86220

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now that breakpoint manager does not depend on the source mapping instance from the
debugger presentation model, it can be moved out.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
commit-queue@webkit.org [Fri, 11 May 2012 16:41:53 +0000 (16:41 +0000)]
[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <reveman@chromium.org> on 2012-05-11
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
commit-queue@webkit.org [Fri, 11 May 2012 16:41:43 +0000 (16:41 +0000)]
[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=86198

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
Mincho / Gothic fonts to display Japanese and Chinese characters.

* gtk/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that GTK's
DumpRenderTree is able to display Chinese characters.

* platform/gtk/svg/batik/text/verticalText-expected.png:
* platform/gtk/svg/batik/text/verticalText-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTwo of the touch-adjustment tests are flaky.
commit-queue@webkit.org [Fri, 11 May 2012 16:33:42 +0000 (16:33 +0000)]
Two of the touch-adjustment tests are flaky.
https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Move the touch points and text so the tests are more stable.

* touchadjustment/event-triggered-widgets-expected.txt:
* touchadjustment/event-triggered-widgets.html:
* touchadjustment/touch-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] SVG Batik test fails to display Chinese characters
commit-queue@webkit.org [Fri, 11 May 2012 16:28:52 +0000 (16:28 +0000)]
[EFL][DRT] SVG Batik test fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=84461

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
new Kochi Mincho / Gothic fonts to display Japanese and Chinese
characters.

* DumpRenderTree/efl/CMakeLists.txt:
* efl/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that EFL's
DumpRenderTree is able to display Chinese characters.

* platform/efl/svg/batik/text/verticalText-expected.png:
* platform/efl/svg/batik/text/verticalText-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: pass source mapping into UISourceCode's constructor; move formatting...
pfeldman@chromium.org [Fri, 11 May 2012 16:13:57 +0000 (16:13 +0000)]
Web Inspector: pass source mapping into UISourceCode's constructor; move formatting outside mapping.
https://bugs.webkit.org/show_bug.cgi?id=86099

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This changes moves formatting out of the source mapping machinery.
As a result, it removes most of the DebuggerPresentation's mapping-related code as well
as most of the raw source code's code.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Breakpoint):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.setStatus):
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.fireContentAvailable):
(WebInspector.JavaScriptSource.prototype.setFormatted.if):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
(WebInspector.JavaScriptSource.prototype.togglingFormatter):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.overrideLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterSourceMapping):
(WebInspector.FormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.FormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.IdentityFormatterSourceMapping):
(WebInspector.IdentityFormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.IdentityFormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.FormatterSourceMappingImpl):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._handleUISourceCodeAdded):
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.mimeType):
(WebInspector.UISourceCode.prototype.content):
(WebInspector.UISourceCode.prototype.fireContentAvailable):
(WebInspector.UISourceCode.prototype.contentLoaded):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/linkifier.html:
* inspector/debugger/pause-in-inline-script.html:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/resources/test-navigation.html: Removed.
* inspector/debugger/script-formatter-breakpoints-expected.txt:
* inspector/debugger/script-formatter-breakpoints.html:
* inspector/debugger/script-formatter-console.html:
* inspector/debugger/selected-call-frame-after-formatting-source.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Input Attribute Placeholder RefTests failing
commit-queue@webkit.org [Fri, 11 May 2012 15:51:48 +0000 (15:51 +0000)]
[EFL][DRT] Input Attribute Placeholder RefTests failing
https://bugs.webkit.org/show_bug.cgi?id=85603

Unreviewed, build fix for EFL.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-11

* platform/efl/RenderThemeEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Try to make spacing of fine print items in lower left nicer looking.
darin@apple.com [Fri, 11 May 2012 15:51:19 +0000 (15:51 +0000)]
   Try to make spacing of fine print items in lower left nicer looking.

* css/main.css:
(#notice, #trademark, #terms): Changed top margin to 10px.
(#notice): Put 30px margin here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS tweak needed for the trademark terms of use.
darin@apple.com [Fri, 11 May 2012 15:48:50 +0000 (15:48 +0000)]
CSS tweak needed for the trademark terms of use.

* css/main.css:
(#notice, #trademark, #terms): Added #trademark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove support of combined nodes and edges serialization schema.
commit-queue@webkit.org [Fri, 11 May 2012 15:46:18 +0000 (15:46 +0000)]
Web Inspector: Remove support of combined nodes and edges serialization schema.
https://bugs.webkit.org/show_bug.cgi?id=86209

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-11
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get _nodes):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-loader-expected.txt:
* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest._postprocessHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a link to WebKit trademark terms of use, other small website changes
darin@apple.com [Fri, 11 May 2012 15:40:50 +0000 (15:40 +0000)]
Add a link to WebKit trademark terms of use, other small website changes
https://bugs.webkit.org/show_bug.cgi?id=86112

Reviewed by Dan Bernstein.

* contact.html: Use RIGHT SINGLE QUOTATION MARK instead of APOSTROPHE as appropriate.
Fixed awkward use of the phrase "per itself" and the use of "intent" where "intend"
was intended.

* nav.inc: Added mention of the WebKit trademark and a link to the trademark terms
of use on the macosforge.org terms of use page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK 64-bit Debug bot fix attempt.
philn@webkit.org [Fri, 11 May 2012 15:23:49 +0000 (15:23 +0000)]
Unreviewed, GTK 64-bit Debug bot fix attempt.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output): Ignore unicode decoding errors when
processing gdb output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add Profiler.getHeapObjectId command
yurys@chromium.org [Fri, 11 May 2012 15:05:42 +0000 (15:05 +0000)]
Web Inspector: add Profiler.getHeapObjectId command
https://bugs.webkit.org/show_bug.cgi?id=86211

Reviewed by Pavel Feldman.

Added Profiler.getHeapObjectId command to the protocol which allows to convert remote
object id to heap snapshot object id.

* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):
* bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::findObjectById):
(WebCore):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getHeapObjectId):
(WebCore):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt support for new layout types.
commit-queue@webkit.org [Fri, 11 May 2012 14:11:26 +0000 (14:11 +0000)]
Qt support for new layout types.
https://bugs.webkit.org/show_bug.cgi?id=85607

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Adds similar Qt support to FractionalLayout classes as Qt has for
FloatSomething and IntSomething classes. This means Qt code can stay
unchanged from after the redefinition of Layout classes.

No new functionality. No new tests.

* Target.pri:
* platform/FractionalLayoutUnit.h:
(WebCore::operator<<):
(WebCore::operator>>):
* platform/graphics/FractionalLayoutPoint.h:
(FractionalLayoutPoint):
* platform/graphics/FractionalLayoutRect.h:
(FractionalLayoutRect):
* platform/graphics/FractionalLayoutSize.h:
(FractionalLayoutSize):
* platform/graphics/qt/FractionalLayoutPointQt.cpp: Added.
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::operator QPointF):
* platform/graphics/qt/FractionalLayoutRectQt.cpp: Added.
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::operator QRectF):
* platform/graphics/qt/FractionalLayoutSizeQt.cpp: Added.
(WebCore::FractionalLayoutSize::FractionalLayoutSize):
(WebCore::FractionalLayoutSize::operator QSizeF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInternals::touchPositionAdjustedToBestClickableNode adjust twice for scroll-offset
commit-queue@webkit.org [Fri, 11 May 2012 14:04:45 +0000 (14:04 +0000)]
Internals::touchPositionAdjustedToBestClickableNode adjust twice for scroll-offset
https://bugs.webkit.org/show_bug.cgi?id=86205

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Source/WebCore:

Remove the redundant conversion from document to window coords.

Test: touchadjustment/scroll-offset.html

* testing/Internals.cpp:
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):

LayoutTests:

Add test of touchPositionAdjustedToBestClickableNode with scroll-offset.

* touchadjustment/scroll-offset-expected.txt: Added.
* touchadjustment/scroll-offset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Updat test expectations.
tkent@chromium.org [Fri, 11 May 2012 13:55:21 +0000 (13:55 +0000)]
[Chromium] Updat test expectations.

* platform/chromium-mac-leopard/fast/block/float/032-expected.png: Removed.
* platform/chromium-mac-leopard/fast/block/float/032-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: load heap snapshot implementation.
loislo@chromium.org [Fri, 11 May 2012 13:53:30 +0000 (13:53 +0000)]
Web Inspector: load heap snapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=86097

The idea is to have a hidden file selector control.
When the user select a context menu item or click a button
we redirect this user-action to file selector.
As result we see the standard file selector dialog.
When the user selects a file we load it's chunks and push the chunks to the worker.
The loaded snapshot can be completely unrelated to the current page.
Thats why we have to skip range selection options in Summary tab.

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions): we have to skip the profiles loaded from file because there is no guaranty t
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.HeapSnapshotProfileType.prototype.createProfile): cosmetic changes.
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype._setupWorker): a common part was extracted from load method and reused in loadFromFile.
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate): cosmetic changes.
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.canLoadFromFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.loadFromFile): chunk based file loader.
(WebInspector.HeapProfileHeader.prototype.loadFromFile.loadNextChunk):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.ProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.canLoadFromFile): default implementation for 'load' part.
(WebInspector.ProfileHeader.prototype.loadFromFile): default implementation for 'load' part.
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Intents code only supports V8
commit-queue@webkit.org [Fri, 11 May 2012 13:49:17 +0000 (13:49 +0000)]
Web Intents code only supports V8
https://bugs.webkit.org/show_bug.cgi?id=85954

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-11
Reviewed by Adam Barth.

.:

Add ENABLE_WEB_INTENTS flag to CMake.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Add necessary abstraction for js Dictionary and ScriptValue so that
the Web Intents code in WebCore compiles with JSC, not just V8.

This required changes in the JSC bindings generator to pass
callback arguments of type SerializedScriptValue as raw pointers
instead of RefPtr. This matches the change made to the V8 bindings
generator in r104531.

* CMakeLists.txt:
* Modules/intents/Intent.cpp:
* Modules/intents/Intent.h:
* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::Dictionary):
(WebCore):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
* bindings/js/Dictionary.h:
(Dictionary):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:
(WebCore):
(WebCore::JSDictionary::initializerObject):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore):
* bindings/js/ScriptValue.h:
(ScriptValue):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(GetNativeTypeForCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Can't type spaces in "Override User Agent" field
apavlov@chromium.org [Fri, 11 May 2012 13:42:50 +0000 (13:42 +0000)]
Web Inspector: Can't type spaces in "Override User Agent" field
https://bugs.webkit.org/show_bug.cgi?id=86202

Reviewed by Yury Semikhatsky.

* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.isClosingKey):
(WebInspector.HelpScreen.prototype._onKeyDown):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype.isClosingKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Input Attribute Placeholder RefTests failing
commit-queue@webkit.org [Fri, 11 May 2012 13:39:38 +0000 (13:39 +0000)]
[EFL][DRT] Input Attribute Placeholder RefTests failing
https://bugs.webkit.org/show_bug.cgi?id=85603

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-11
Reviewed by Hajime Morita.

Source/WebCore:

Refrain from overriding style coloring by theme coloring.
RenderThemeEfl was always overriding colors and whitespace
handling leading to failures in reftests that verify placeholder styling
which expect the user agent stylesheet to be applied correctly
without any color overrides. Also, leave whitespace handling untouched.

No new tests, covered by existing tests. See also
the LayoutTests/ChangeLog in this commit for the required
rebaselining.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyEdjeColors):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

Source/WebKit/efl:

Removing color classes which we don't need anymore after
RenderThemeEfl.cpp is less aggressively overriding styling.

* DefaultTheme/default.edc:

LayoutTests:

Rebaselining after we're allowing color styling of menulists,
search and text fields and textareas and after removing
whitespace handling override.

* platform/efl/Skipped:
* platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
* platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
* platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
* platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/efl/fast/block/float/float-avoidance-expected.txt:
* platform/efl/fast/block/margin-collapse/103-expected.txt:
* platform/efl/fast/css/continuationCrash-expected.txt:
* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/line-height-expected.txt:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/efl/fast/css/rtl-ordering-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/css/text-transform-select-expected.txt:
* platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/efl/fast/dom/isindex-001-expected.txt:
* platform/efl/fast/dom/isindex-002-expected.txt:
* platform/efl/fast/dynamic/008-expected.txt:
* platform/efl/fast/events/autoscroll-expected.txt:
* platform/efl/fast/forms/003-expected.txt:
* platform/efl/fast/forms/004-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label01-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label02-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label03-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label04-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt:
* platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt:
* platform/efl/fast/forms/basic-buttons-expected.txt:
* platform/efl/fast/forms/basic-inputs-expected.txt:
* platform/efl/fast/forms/blankbuttons-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/button-positioned-expected.txt:
* platform/efl/fast/forms/button-sizes-expected.txt:
* platform/efl/fast/forms/button-style-color-expected.txt:
* platform/efl/fast/forms/button-table-styles-expected.txt:
* platform/efl/fast/forms/button-text-transform-expected.txt:
* platform/efl/fast/forms/control-clip-overflow-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/disabled-select-change-index-expected.txt:
* platform/efl/fast/forms/encoding-test-expected.txt:
* platform/efl/fast/forms/fieldset-align-expected.txt:
* platform/efl/fast/forms/file/file-input-direction-expected.txt:
* platform/efl/fast/forms/file/file-input-disabled-expected.txt:
* platform/efl/fast/forms/floating-textfield-relayout-expected.txt:
* platform/efl/fast/forms/formmove3-expected.txt:
* platform/efl/fast/forms/input-align-expected.txt:
* platform/efl/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/efl/fast/forms/input-appearance-focus-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/efl/fast/forms/input-appearance-selection-expected.txt:
* platform/efl/fast/forms/input-appearance-visibility-expected.txt:
* platform/efl/fast/forms/input-appearance-width-expected.txt:
* platform/efl/fast/forms/input-button-sizes-expected.txt:
* platform/efl/fast/forms/input-disabled-color-expected.txt:
* platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/efl/fast/forms/input-field-text-truncated-expected.txt:
* platform/efl/fast/forms/input-readonly-dimmed-expected.txt:
* platform/efl/fast/forms/input-readonly-empty-expected.txt:
* platform/efl/fast/forms/input-spaces-expected.txt:
* platform/efl/fast/forms/input-table-expected.txt:
* platform/efl/fast/forms/input-text-click-inside-expected.txt:
* platform/efl/fast/forms/input-text-option-delete-expected.txt:
* platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/efl/fast/forms/input-text-word-wrap-expected.txt:
* platform/efl/fast/forms/input-type-text-min-width-expected.txt:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/forms/input-width-expected.txt:
* platform/efl/fast/forms/menulist-deselect-update-expected.txt:
* platform/efl/fast/forms/menulist-narrow-width-expected.txt:
* platform/efl/fast/forms/menulist-no-overflow-expected.txt:
* platform/efl/fast/forms/menulist-restrict-line-height-expected.txt:
* platform/efl/fast/forms/menulist-separator-painting-expected.txt:
* platform/efl/fast/forms/menulist-style-color-expected.txt:
* platform/efl/fast/forms/menulist-width-change-expected.txt:
* platform/efl/fast/forms/minWidthPercent-expected.txt:
* platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/efl/fast/forms/option-script-expected.txt:
* platform/efl/fast/forms/option-strip-whitespace-expected.txt:
* platform/efl/fast/forms/option-text-clip-expected.txt:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/efl/fast/forms/search-rtl-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/forms/select-align-expected.txt:
* platform/efl/fast/forms/select-background-none-expected.txt:
* platform/efl/fast/forms/select-baseline-expected.txt:
* platform/efl/fast/forms/select-change-listbox-to-popup-expected.txt:
* platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
* platform/efl/fast/forms/select-initial-position-expected.txt:
* platform/efl/fast/forms/select-selected-expected.txt:
* platform/efl/fast/forms/select-size-expected.txt:
* platform/efl/fast/forms/select-style-expected.txt:
* platform/efl/fast/forms/select-visual-hebrew-expected.txt:
* platform/efl/fast/forms/select-writing-direction-natural-expected.txt:
* platform/efl/fast/forms/selectlist-minsize-expected.txt:
* platform/efl/fast/forms/stuff-on-my-optgroup-expected.txt:
* platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
* platform/efl/fast/forms/targeted-frame-submission-expected.txt:
* platform/efl/fast/forms/text-style-color-expected.txt:
* platform/efl/fast/forms/textAreaLineHeight-expected.txt:
* platform/efl/fast/forms/textarea-align-expected.txt:
* platform/efl/fast/forms/textarea-scroll-height-expected.txt:
* platform/efl/fast/forms/textarea-scrolled-type-expected.txt:
* platform/efl/fast/forms/textarea-setinnerhtml-expected.txt:
* platform/efl/fast/forms/textarea-width-expected.txt:
* platform/efl/fast/forms/textfield-focus-ring-expected.txt:
* platform/efl/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
* platform/efl/fast/html/details-no-summary4-expected.txt:
* platform/efl/fast/html/details-open-javascript-expected.txt:
* platform/efl/fast/html/details-open2-expected.txt:
* platform/efl/fast/html/details-open4-expected.txt:
* platform/efl/fast/html/details-replace-summary-child-expected.txt:
* platform/efl/fast/html/details-replace-text-expected.txt:
* platform/efl/fast/html/keygen-expected.txt:
* platform/efl/fast/invalid/014-expected.txt:
* platform/efl/fast/lists/dynamic-marker-crash-expected.txt:
* platform/efl/fast/overflow/overflow-x-y-expected.txt:
* platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* platform/efl/fast/overflow/scrollRevealButton-expected.txt:
* platform/efl/fast/parser/document-write-option-expected.txt:
* platform/efl/fast/parser/entity-comment-in-textarea-expected.txt:
* platform/efl/fast/parser/open-comment-in-textarea-expected.txt:
* platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/repaint/subtree-root-skipped-expected.txt:
* platform/efl/fast/replaced/replaced-breaking-expected.txt:
* platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/efl/fast/replaced/three-selects-break-expected.txt:
* platform/efl/fast/replaced/width100percent-button-expected.txt:
* platform/efl/fast/replaced/width100percent-menulist-expected.txt:
* platform/efl/fast/replaced/width100percent-textarea-expected.txt:
* platform/efl/fast/replaced/width100percent-textfield-expected.txt:
* platform/efl/fast/table/003-expected.txt:
* platform/efl/fast/table/colspanMinWidth-expected.txt:
* platform/efl/fast/table/spanOverlapRepaint-expected.txt:
* platform/efl/fast/table/text-field-baseline-expected.txt:
* platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/efl/test_expectations.txt:
* platform/efl/transforms/2d/zoom-menulist-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116205): [GTK]: build no longer supports thin archives
kov@webkit.org [Fri, 11 May 2012 13:34:29 +0000 (13:34 +0000)]
REGRESSION(r116205): [GTK]: build no longer supports thin archives
https://bugs.webkit.org/show_bug.cgi?id=86207

Source/WebCore:

* GNUmakefile.am: go back to not linking libWebCoreModules into
libWebCore; when linking 2 convenience libraries libtools tries to
extract the object files from one of them to add to the other, breaking
thin archive builds

Source/WebKit/gtk:

* GNUmakefile.am: link libWebCoreModules into the webkitgtk shared
library.

Source/WebKit2:

* GNUmakefile.am: link libWebCoreModules to the webkit2gtk shared
library; tell the linker to ignore internal unresolved symbols for
PluginProcess and avoid linking libWebCoreModules.

Tools:

* GNUmakefile.am: link libWebCoreModules to DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion failure in ietestcenter/css3/valuesandunits/units-000.htm
antti@apple.com [Fri, 11 May 2012 13:32:51 +0000 (13:32 +0000)]
Assertion failure in ietestcenter/css3/valuesandunits/units-000.htm
https://bugs.webkit.org/show_bug.cgi?id=86208

Not reviewed.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update DumpRenderTree.cpp to also run ref-tests if there're any
commit-queue@webkit.org [Fri, 11 May 2012 13:25:46 +0000 (13:25 +0000)]
[BlackBerry] Update DumpRenderTree.cpp to also run ref-tests if there're any
https://bugs.webkit.org/show_bug.cgi?id=86055

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-05-11
Reviewed by Rob Buis.

Ref-tests are tests with suffix "-expected", "-expected-mismatch" and a valid
extension(".html", ".htm", etc.).
Currently torch-launcher only run tests parsed by NRWT, with ref-tests
excluded. As a result, if a test have ref-tests (which were not run), our
DumpRenderTree Perl script will think there's a crash and exit with code 1.
So NRWT will report the result as CRASH.
We need to update DumpRenderTree.cpp to try to find ref-tests and run them.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::getRefTests):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::runTests):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSanitization algorithm for input type=email should strip whitespaces
keishi@webkit.org [Fri, 11 May 2012 13:04:02 +0000 (13:04 +0000)]
Sanitization algorithm for input type=email should strip whitespaces
https://bugs.webkit.org/show_bug.cgi?id=86177

Reviewed by Kent Tamura.

Source/WebCore:

No new tests. Covered by: fast/forms/ValidityState-typeMismatch-email.html

The spec says that the value sanitization algorithm should
> Strip line breaks from the value, then strip leading and trailing whitespace from the value.

* html/EmailInputType.cpp:
(WebCore::EmailInputType::sanitizeValue):

LayoutTests:

* fast/forms/ValidityState-typeMismatch-email-expected.txt:
* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/input-value-sanitization.html:
* fast/forms/resources/ValidityState-typeMismatch-email.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116752.
commit-queue@webkit.org [Fri, 11 May 2012 12:56:04 +0000 (12:56 +0000)]
Unreviewed, rolling out r116752.
http://trac.webkit.org/changeset/116752
https://bugs.webkit.org/show_bug.cgi?id=86201

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

* html/FormAssociatedElement.cpp:
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::setCustomValidity):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValidValue):
(WebCore::HTMLInputElement::typeMismatch):
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::patternMismatch):
(WebCore::HTMLInputElement::rangeUnderflow):
(WebCore::HTMLInputElement::rangeOverflow):
(WebCore::HTMLInputElement::minimum):
(WebCore::HTMLInputElement::maximum):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::minimumString):
(WebCore::HTMLInputElement::maximumString):
(WebCore):
(WebCore::HTMLInputElement::stepBaseString):
(WebCore::HTMLInputElement::stepString):
(WebCore::HTMLInputElement::typeMismatchText):
(WebCore::HTMLInputElement::valueMissingText):
(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::setCustomValidity):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::valueMissing):
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLTextAreaElement.cpp:
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::valueMissing):
(HTMLTextAreaElement):
* html/InputType.cpp:
(WebCore::InputType::alignValueForStep):
(WebCore::InputType::stepUpFromRenderer):
* html/InputType.h:
(InputType):
* html/ValidityState.cpp:
(WebCore::ValidityState::validationMessage):
(WebCore):
(WebCore::ValidityState::setCustomErrorMessage):
(WebCore::ValidityState::valueMissing):
(WebCore::ValidityState::typeMismatch):
(WebCore::ValidityState::patternMismatch):
(WebCore::ValidityState::tooLong):
(WebCore::ValidityState::rangeUnderflow):
(WebCore::ValidityState::rangeOverflow):
(WebCore::ValidityState::stepMismatch):
(WebCore::ValidityState::customError):
(WebCore::ValidityState::valid):
* html/ValidityState.h:
(ValidityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Search box doesn't allow CSS selectors anymore
apavlov@chromium.org [Fri, 11 May 2012 12:47:57 +0000 (12:47 +0000)]
Web Inspector: Search box doesn't allow CSS selectors anymore
https://bugs.webkit.org/show_bug.cgi?id=86196

Reviewed by Pavel Feldman.

Source/WebCore:

Refactoring in http://trac.webkit.org/changeset/99983 inadvertently removed the selector matching during
node search in the InspectorDOMAgent. This change re-introduces the Document::querySelectorAll() evaluation
for the user query.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

* inspector/elements/elements-panel-search-expected.txt:
* inspector/elements/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116527.
inferno@chromium.org [Fri, 11 May 2012 12:45:05 +0000 (12:45 +0000)]
Unreviewed, rolling out r116527.
http://trac.webkit.org/changeset/116527
https://bugs.webkit.org/show_bug.cgi?id=86199

Causing crashes on ClusterFuzz (Requested by inferno-sec on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbarPart.h:

LayoutTests:

* scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed.
* scrollbars/scrollbar-percent-padding-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update wrong expectations.
tkent@chromium.org [Fri, 11 May 2012 12:41:52 +0000 (12:41 +0000)]
[Chromium] Update wrong expectations.

* platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Removed.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Move ValidityState methods implementation to another place
commit-queue@webkit.org [Fri, 11 May 2012 12:39:47 +0000 (12:39 +0000)]
[Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-11
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added.  Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added.  set custom error message.
* html/FormAssociatedElement.h:
(FormAssociatedElement): Added new instance value m_customValidationMessage.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing):  Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.
* html/HTMLInputElement.h:
(HTMLInputElement): Make tooLong method private.
* html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.
* html/HTMLSelectElement.h:
(HTMLSelectElement):  Added entries for newly added methods.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.
* html/HTMLTextAreaElement.h:
(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.
* html/InputType.cpp:
(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep):  Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer):  Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added.  Moved from HTMLInputElement.
* html/InputType.h:
(InputType): Added entries for newly added methods and update methods signature.
* html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.
(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):
* html/ValidityState.h:
(ValidityState): Remove custom validation message related things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a build error without SVG, introduced by tab-size support.
tkent@chromium.org [Fri, 11 May 2012 12:14:28 +0000 (12:14 +0000)]
Fix a build error without SVG, introduced by tab-size support.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Gardening failure cases on EFL build bot
commit-queue@webkit.org [Fri, 11 May 2012 12:06:50 +0000 (12:06 +0000)]
[EFL][DRT] Gardening failure cases on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=86192

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening failure cases on editing/style and editing/pasteboard
commit-queue@webkit.org [Fri, 11 May 2012 11:52:58 +0000 (11:52 +0000)]
[EFL] Gardening failure cases on editing/style and editing/pasteboard
https://bugs.webkit.org/show_bug.cgi?id=86184

Unreviewed EFL gardening.

Test expectations update.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-11

* platform/efl/test_expectations.txt: adding tests regarding to missing beginDragWithFiles
execCommand('copy') and execCommand('paste') implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] fast/css/getComputedStyle/computed-style-without-renderer.html fails on EFL
commit-queue@webkit.org [Fri, 11 May 2012 11:43:24 +0000 (11:43 +0000)]
[EFL][DRT] fast/css/getComputedStyle/computed-style-without-renderer.html fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=86190

Unreviewed, EFL rebaseline after r116723.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11

* platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline for some tests, and optimization.
tkent@chromium.org [Fri, 11 May 2012 11:23:30 +0000 (11:23 +0000)]
[Chromium] Rebaseline for some tests, and optimization.

* fast/block/float/032-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/032-expected.txt.
* fast/forms/input-appearance-bkcolor-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-appearance-bkcolor-expected.txt.
* fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/platform/efl/fast/images/color-jpeg-with-color-profile-expected.png.
* platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Added.
* platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-leopard/fast/block/float/032-expected.png:
* platform/chromium-mac-leopard/fast/block/float/032-expected.txt:
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt.
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
* platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/text-style-color-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac/fast/block/float/032-expected.png:
* platform/chromium-mac/fast/block/float/032-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/chromium-mac/fast/forms/text-style-color-expected.png:
* platform/chromium-mac/fast/forms/text-style-color-expected.txt: Removed.
* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.txt: Removed.
* platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
* platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-win/fast/block/float/032-expected.txt:
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/chromium-win/fast/forms/text-style-color-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/block/float/032-expected.txt: Removed.
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Removed.
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt: Removed.
* tables/mozilla/bugs/bug99948-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug99948-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] Move Selection from DOMWindow to TreeScope.
shinyak@chromium.org [Fri, 11 May 2012 10:36:31 +0000 (10:36 +0000)]
[Refactoring] Move Selection from DOMWindow to TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=82699

Reviewed by Ryosuke Niwa.

Since ShadowRoot will also manage its own version of DOMSelection, we would like to
share the code among Document and DOMSelection. This patch moves DOMSelection from DOMWindow to TreeScope
so that ShadowRoot can also use it.

No new tests, should covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::updateFocusAppearanceTimerFired):
* dom/Document.h:
(Document):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
* dom/TreeScope.cpp:
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::getSelection):
(WebCore):
* dom/TreeScope.h:
(WebCore):
(TreeScope):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::clearTreeScope):
(WebCore):
* page/DOMSelection.h:
(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):
* page/DOMWindow.h:
(DOMWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix attempt.
morrita@google.com [Fri, 11 May 2012 10:26:21 +0000 (10:26 +0000)]
Unreviewed build fix attempt.

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: console should allow JS execution in the context of an isolated world
yurys@chromium.org [Fri, 11 May 2012 09:55:19 +0000 (09:55 +0000)]
Web Inspector: console should allow JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85612

Reviewed by Pavel Feldman.

Added an option to select not only a frame but also isolated world in which
to perform evaluation of the code typed into the console.

Each execution context can be identified using it injected script id. We call it
execution context id in the protocol. Runtime agent is extended with an event that
is sent when new ExecutionContext is created. The event tracking can be enabled/disabled
using setReportExecutionContextCreation command.

* bindings/js/ScriptController.cpp:
(WebCore):
(WebCore::isolatedWorldToSecurityOriginMap):
* bindings/js/ScriptController.h:
(ScriptController):
* bindings/js/ScriptState.cpp:
(WebCore::isolatedWorldScriptState):
(WebCore):
* bindings/js/ScriptState.h:
(WebCore):
* bindings/v8/ScriptController.cpp:
(WebCore):
(WebCore::ScriptController::isolatedWorldToSecurityOriginMap):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptState.cpp:
(WebCore::isolatedWorldScriptState):
(WebCore):
* bindings/v8/ScriptState.h:
(WebCore):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::setSecurityOrigin):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setIsolatedWorldSecurityOrigin):
(WebCore::V8Proxy::isolatedWorldContext):
(WebCore):
(WebCore::V8Proxy::isolatedWorldToSecurityOriginMap):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* inspector/CodeGeneratorInspector.py:
(DomainNameFixes):
* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCreateIsolatedContextImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateIsolatedContext):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::pageRuntimeAgent):
(WebCore::InstrumentingAgents::setPageRuntimeAgent):
(InstrumentingAgents):
* inspector/PageRuntimeAgent.cpp:
(PageRuntimeAgentState):
(WebCore):
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore::PageRuntimeAgent::setReportExecutionContextCreation):
(WebCore::PageRuntimeAgent::didCreateExecutionContext):
(WebCore::PageRuntimeAgent::getScriptStateForEval):
* inspector/PageRuntimeAgent.h:
(WebCore):
(PageRuntimeAgent):
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::setReportExecutionContextCreation):
(WebCore::WorkerRuntimeAgent::getScriptStateForEval):
* inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype._currentEvaluationContextId):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedWorldId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype._didLoadCachedResources):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.isolatedContextCreated):
(WebInspector.ExecutionContext):
(WebInspector.ExecutionContext.comparator):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext):
(WebInspector.FrameEvaluationContext.prototype._ensureMainWorldContextAdded):
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: use div, not span as a parent element for ElementsTreeOutline in Audit...
caseq@chromium.org [Fri, 11 May 2012 09:35:00 +0000 (09:35 +0000)]
Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=86188

Reviewed by Yury Semikhatsky.

Source/WebCore:

We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
within _treeElementFromEvent(), which returns 0 for inline elements.

* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node):

LayoutTests:

* inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInline Node::traverseNextNode
antti@apple.com [Fri, 11 May 2012 09:28:52 +0000 (09:28 +0000)]
Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.

In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.

Performance bots will tell if this was worthwhile.

* dom/ContainerNode.h:
(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):
* dom/Node.cpp:
(WebCore::Node::traverseNextAncestorSibling):
* dom/Node.h:
(Node):
* bindings/v8/RetainedDOMInfo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Fri, 11 May 2012 09:05:09 +0000 (09:05 +0000)]
[Chromium] Test expectation update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
yurys@chromium.org [Fri, 11 May 2012 08:42:07 +0000 (08:42 +0000)]
Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
https://bugs.webkit.org/show_bug.cgi?id=85708

Reviewed by Pavel Feldman.

Instead of calling emitCommitLoadIfNeeded after all agents are restored
required actions are performed directly in the restore() methods.

* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::didCommitLoadFired):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::restore):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
* inspector/InspectorPageAgent.h:
(WebCore):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::restore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Extensions API] add audit formatters for remote objects and DOM elements
caseq@chromium.org [Fri, 11 May 2012 08:29:08 +0000 (08:29 +0000)]
Web Inspector: [Extensions API] add audit formatters for remote objects and DOM elements
https://bugs.webkit.org/show_bug.cgi?id=86108

Reviewed by Pavel Feldman.

Source/WebCore:

       - added two new formatters to AuditResults object of webInspector.audits API;

* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.resourceLink):
(WebInspector.AuditFormatters.object.onEvaluate):
(WebInspector.AuditFormatters.object): format as a remote object property list;
(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node.onEvaluate):
(WebInspector.AuditFormatters.node): format as a DOM elements sub-tree;
(WebInspector.AuditFormatters.Utilities.evaluate): common expression evaluation logic for both new formatters;
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.AuditResultImpl):
* inspector/front-end/auditsPanel.css:
(.audit-result-tree ol.outline-disclosure):
(.audit-result-tree .section .header):
(.audit-result-tree .section .header::before):

LayoutTests:

- rebaselined tests to account for two new AuditResults method and their results;

* inspector/extensions/extensions-audits-api-expected.txt:
* inspector/extensions/extensions-audits-expected.txt:
* inspector/extensions/extensions-audits-tests.js:
(initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):
* inspector/extensions/extensions-audits.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SOUP] Allow sending URI request data in chunks
carlosgc@webkit.org [Fri, 11 May 2012 08:14:39 +0000 (08:14 +0000)]
[SOUP] Allow sending URI request data in chunks
https://bugs.webkit.org/show_bug.cgi?id=85880

Reviewed by Martin Robinson.

The API to handle custom URI schemes will receive an input stream
to read from. Current code requires to buffer the whole stream
before sending it to the WebProcess. This patch allows to send the
data in chunks while it's read from the stream.

* GNUmakefile.list.am: Add new files to compilation
* UIProcess/API/C/soup/WKSoupRequestManager.cpp:
(WKSoupRequestManagerRegisterURIScheme): Use toWTFString() to
convert from WKString to WTFString.
(WKSoupRequestManagerDidHandleURIRequest): Use didHandleURIRequest
as it has been renamed.
(WKSoupRequestManagerDidReceiveURIRequestData): New method to send
more data for the uri request to the web process.
* UIProcess/API/C/soup/WKSoupRequestManager.h:
* UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
HandleURIRequest has been renamed to DidHandleURIRequest.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Send DidReceiveURIRequestData message to the web process.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Use
didHandleURIRequest as it has been renamed.
* UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
* WebProcess/soup/WebKitSoupRequestInputStream.cpp: Added.
(AsyncReadData::AsyncReadData): Helper struct to store information
about pending async read operations.
(_WebKitSoupRequestInputStreamPrivate):
(webkitSoupRequestInputStreamReadAsyncResultComplete): Read the
data from the memory input stream and complete the async read
operation.
(webkitSoupRequestInputStreamReadAsync): Read the data from the
memory input stream and complete the async read operation if
there's data to read, or save the async result to be completed
when more data is added to the stream.
(webkitSoupRequestInputStreamReadFinish): Finish an async read
started with webkitSoupRequestInputStreamReadAsync.
(webkitSoupRequestInputStreamFinalize):
(webkit_soup_request_input_stream_init):
(webkit_soup_request_input_stream_class_init):
(webkitSoupRequestInputStreamNew): Create a new input stream with
a fixed size or 0 if content length is not known.
(webkitSoupRequestInputStreamAddData): Add more data to the
stream and complete any pending async read.
(webkitSoupRequestInputStreamFinished): Whether all data expected
by the stream has been received.
* WebProcess/soup/WebKitSoupRequestInputStream.h: Added.
* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::didHandleURIRequest): Create a
WebKitSoupRequestInputStream if we haven't received all the
request data in the HandleURIRequest message. Otherwise just
create a memory input stream with all the data.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): Add the data
received to the WebKitSoupRequestInputStream associated to the
given request identifier.
* WebProcess/soup/WebSoupRequestManager.h:
* WebProcess/soup/WebSoupRequestManager.messages.in: Add
contentLength parameter to DidHandleURIRequest message and add
DidReceiveURIRequestData message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip a new failing test.
ossy@webkit.org [Fri, 11 May 2012 07:53:37 +0000 (07:53 +0000)]
Unreviewed gardening, skip a new failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116727.
commit-queue@webkit.org [Fri, 11 May 2012 07:33:16 +0000 (07:33 +0000)]
Unreviewed, rolling out r116727.
http://trac.webkit.org/changeset/116727
https://bugs.webkit.org/show_bug.cgi?id=86181

Build error on Chromium-Android (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::exitFullscreen):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectation update.
morrita@google.com [Fri, 11 May 2012 07:16:26 +0000 (07:16 +0000)]
Unreviewed expectation update.

* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
ossy@webkit.org [Fri, 11 May 2012 07:11:31 +0000 (07:11 +0000)]
Unreviewed gardening.

* fast/css/getComputedStyle/computed-style-expected.txt: Updated after r116723.
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r116723.
* platform/qt/Skipped: Skip new crashing and failing tests.
* platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r116723.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116731.
commit-queue@webkit.org [Fri, 11 May 2012 07:00:46 +0000 (07:00 +0000)]
Unreviewed, rolling out r116731.
http://trac.webkit.org/changeset/116731
https://bugs.webkit.org/show_bug.cgi?id=86178

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore):
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a perf tab to garden-o-matic
ojan@chromium.org [Fri, 11 May 2012 06:56:59 +0000 (06:56 +0000)]
Add a perf tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86169

Reviewed by Dimitri Glazkov.

This is a first stab at making it easier to view the Chromium WebKit canary
perf graphs. For now, it's just a couple select elements and an iframe.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
commit-queue@webkit.org [Fri, 11 May 2012 06:33:58 +0000 (06:33 +0000)]
[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <reveman@chromium.org> on 2012-05-10
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElementShadow should minimize the usage of "ShadowRoot" name
morrita@google.com [Fri, 11 May 2012 05:35:12 +0000 (05:35 +0000)]
ElementShadow should minimize the usage of "ShadowRoot" name
https://bugs.webkit.org/show_bug.cgi?id=85970

Reviewed by Dimitri Glazkov.

.:

Removed symbols which no longer exists

* Source/autotools/symbols.filter:

Source/WebCore:

This change cleans two out dated assumptions which brought in at
early stage of Shadow DOM implementation.

- Removed Element::hasShadowRoot(): shadow existence can be checked by Element::shadow().
- Made ElementShadow::removeAllShadowRoots() private: we no longer allow ShadowRoot removal.
  It can only happens at the ElementShadow destruction.

Most of changes in element implementations are basically simple
replacement from hasShadowRoot() to shadow().

No new tests. Covered by existing tests.

* WebCore.exp.in:
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectDescendant):
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseChild):
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
* dom/Element.h:
(Element):
(WebCore::isShadowHost):
(WebCore):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::removeAllShadowRoots):
* dom/ElementShadow.h:
(ElementShadow):
(WebCore::ElementShadow::host):
* dom/EventDispatcher.cpp:
* dom/Node.cpp:
(WebCore::oldestShadowRootFor):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
* html/shadow/SliderThumbElement.cpp:
(WebCore::trackLimiterElementOf):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* page/FocusController.cpp:
(WebCore):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

Removed symbols which no longer exists

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Removed tests cases which exercise shadow root removals.
Such functionality was only available from Internals object
and it made little sense to test it.

* fast/dom/shadow/content-element-move-expected.txt:
* fast/dom/shadow/content-element-move.html:
* fast/dom/shadow/dynamically-created-shadow-root-expected.html:
* fast/dom/shadow/dynamically-created-shadow-root.html:
* fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
* fast/dom/shadow/layout-tests-can-access-shadow.html:
* fast/dom/shadow/multiple-shadowroot-expected.txt:
* fast/dom/shadow/multiple-shadowroot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116730 268f45cc-cd09-0410-ab3c-d52691b4dbfc