WebKit-https.git
10 years ago2009-08-13 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 17:52:26 +0000 (17:52 +0000)]
2009-08-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        [CAIRO] getImageData fails on a given rect bigger than the image rect

        The destination image and the source image was mixed up on creating the
        imageData.

        This is just a clean up and doesn't affect the current behavior. It's not
        possible to test this failure in a LayoutTest. Only canvas uses getImageData
        at the moment and returns before calling getImageData, if the image rect does
        not contain the requested rect.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 13 Aug 2009 17:38:11 +0000 (17:38 +0000)]
2009-08-13  Dirk Schulze  <krit@webkit.org>

        Unreviewed.
        Added 'Dirk Schulze' to the committers list.

        * Scripts/modules/committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Thu, 13 Aug 2009 17:18:13 +0000 (17:18 +0000)]
2009-08-13  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Due to fixes in http://trac.webkit.org/changeset/47038 and http://trac.webkit.org/changeset/47163,
        fast/events/mouse-click-events.html now passes, removing it from Skipped List.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 17:14:59 +0000 (17:14 +0000)]
2009-08-13  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding RenderTheme to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=28258

        * platform/haiku/RenderThemeHaiku.cpp: Added.
        (WebCore::RenderThemeHaiku::create):
        (WebCore::RenderTheme::themeForPage):
        (WebCore::RenderThemeHaiku::RenderThemeHaiku):
        (WebCore::RenderThemeHaiku::~RenderThemeHaiku):
        (WebCore::supportsFocus):
        (WebCore::RenderThemeHaiku::supportsFocusRing):
        (WebCore::RenderThemeHaiku::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeHaiku::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeHaiku::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeHaiku::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeHaiku::platformTextSearchHighlightColor):
        (WebCore::RenderThemeHaiku::systemFont):
        (WebCore::RenderThemeHaiku::paintCheckbox):
        (WebCore::RenderThemeHaiku::setCheckboxSize):
        (WebCore::RenderThemeHaiku::paintRadio):
        (WebCore::RenderThemeHaiku::setRadioSize):
        (WebCore::RenderThemeHaiku::adjustMenuListStyle):
        (WebCore::RenderThemeHaiku::paintMenuList):
        * platform/haiku/RenderThemeHaiku.h: Added.
        (WebCore::RenderThemeHaiku::supportsHover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore...
kevino@webkit.org [Thu, 13 Aug 2009 17:13:57 +0000 (17:13 +0000)]
wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore or jscore libs change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 17:08:19 +0000 (17:08 +0000)]
2009-08-13  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp
        https://bugs.webkit.org/show_bug.cgi?id=28256

        * platform/haiku/ContextMenuHaiku.cpp:
        (WebCore::ContextMenuReceiver::ContextMenuReceiver):
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenu::insertItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Joseph Pecoraro <joepeck02@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 16:51:22 +0000 (16:51 +0000)]
2009-08-13  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Darin Adler.

        Inspector: Show Hidden Cookie Data
        https://bugs.webkit.org/show_bug.cgi?id=28185

          Added new file Cookie.h to the WebCore XCode

        * WebCore.xcodeproj/project.pbxproj:

          InspectorController.cookies() binding

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::cookies):
        * inspector/InspectorBackend.idl:

          Struct for static Cookie information
          (name, value, path, domain, expires, httpOnly, secure, session)

        * platform/Cookie.h: Added.
        (WebCore::Cookie::Cookie):

          Getter for the a list of raw Cookies
          getRawCookies(., ., out Vector<Cookie>)

        * platform/CookieJar.h:

          Implementation of getRawCookies for the mac platform.

        * platform/mac/CookieJar.mm:
        (WebCore::getRawCookies):

          Stub other CookieJar implementations to satisfy the interface.

        * platform/haiku/CookieJarHaiku.cpp:
        (WebCore::getRawCookies):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::getRawCookies):
        * platform/network/curl/CookieJarCurl.cpp:
        (WebCore::getRawCookies):
        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::getRawCookies):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::getRawCookies):
        * platform/network/win/CookieJarWin.cpp:
        (WebCore::getRawCookies):
        * platform/qt/CookieJarQt.cpp:
        (WebCore::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 13 Aug 2009 16:43:22 +0000 (16:43 +0000)]
2009-08-13  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Disables Geolocation 'enabled' test for GTK port, as the GTK Geolocation implementation is incomplete.
        https://bugs.webkit.org/show_bug.cgi?id=27716

        * platform/gtk/Skipped: Modified. Disables Geolocation 'enabled' test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
eric@webkit.org [Thu, 13 Aug 2009 16:36:38 +0000 (16:36 +0000)]
2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Gtk][REGRESSION] XHR test failures after r45558
        https://bugs.webkit.org/show_bug.cgi?id=27143

        Reenable the test that is fixed by this changeset.

        * platform/gtk/Skipped:

2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Gtk][REGRESSION] XHR test failures after r45558
        https://bugs.webkit.org/show_bug.cgi?id=27143

        Fix one of the regressions caused by the new sniffing code -
        disable sniffing when that behavior is explicitly requested.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Thu, 13 Aug 2009 16:29:51 +0000 (16:29 +0000)]
2009-08-13  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Add a new gesture in Web Inspector to remove breakpoints
        https://bugs.webkit.org/show_bug.cgi?id=19131

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._documentMouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Norbert Leser <norbert.leser@nokia.com>
eric@webkit.org [Thu, 13 Aug 2009 16:23:00 +0000 (16:23 +0000)]
2009-08-13  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Symbian target components (library and executable files)
        require Unique Identifiers (i.e., UID3).
        These identifiers are defined in the respective project
        file, conditionally for "symbian" platform.

        * WebCore.pro:

2009-08-13  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Symbian target components (library and executable files)
        require Unique Identifiers (i.e., UID3).
        These identifiers are defined in the respective project
        files, conditionally for "symbian" platform.

        * QtLauncher/QtLauncher.pro:
        * tests/qwebelement/qwebelement.pro:
        * tests/qwebframe/qwebframe.pro:
        * tests/qwebhistory/qwebhistory.pro:
        * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
        * tests/qwebpage/qwebpage.pro:
        * tests/qwebview/qwebview.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Thu, 13 Aug 2009 16:16:11 +0000 (16:16 +0000)]
2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        wrong calculation of overflow size for flexbox and table
        https://bugs.webkit.org/show_bug.cgi?id=28064

        RenderFlexibleBox and RenderTable were using the width of overflow
        to update height of overflow, so height became wrong value and
        width was not updated. As the corresponding code of RenderBlock
        was sane, I factored it out and used from RenderFlexibleBox and
        RenderTable.

        * fast/reflections/reflection-overflow-scroll-expected.txt:
        * fast/reflections/reflection-overflow-scroll.html:
        * fast/reflections/resources/reflection-overflow-scroll.js:

2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        wrong calculation of overflow size for flexbox and table
        https://bugs.webkit.org/show_bug.cgi?id=28064

        RenderFlexibleBox and RenderTable were using the width of overflow
        to update height of overflow, so height became wrong value and
        width was not updated. As the corresponding code of RenderBlock
        was sane, I factored it out and used from RenderFlexibleBox and
        RenderTable.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateOverflowWithShadowAndReflection): created from code of layoutBlock
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderBlock.h:
        * rendering/RenderFlexibleBox.cpp: use updateOverflowWithShadowAndReflection
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): use updateOverflowWithShadowAndReflection

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable running testapi in run-javascriptcore-tests on Windows
aroben@apple.com [Thu, 13 Aug 2009 16:01:46 +0000 (16:01 +0000)]
Enable running testapi in run-javascriptcore-tests on Windows

Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
testapi on Windows

Reviewed by Mark Rowe.

* Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
the AppleWinWebKit configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable testapi in run-javascriptcore-tests on Mac
aroben@apple.com [Thu, 13 Aug 2009 16:00:50 +0000 (16:00 +0000)]
Re-enable testapi in run-javascriptcore-tests on Mac

This seems to have been mistakenly disabled in r47089.

Rubber-stamped by Mark Rowe.

* Scripts/run-javascriptcore-tests: Removed comment markers that were
preventing running testapi.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the special-case for Qt wrt JSVALUE_32 introduced in
hausmann@webkit.org [Thu, 13 Aug 2009 14:54:21 +0000 (14:54 +0000)]
Remove the special-case for Qt wrt JSVALUE_32 introduced in
r46709. It must've been a dependency issue on the bot, as
after a manual build all the tests pass on amd64 and ia32.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-13
Reviewed by Ariya Hidayat.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 13 Aug 2009 14:29:07 +0000 (14:29 +0000)]
2009-08-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by George Staikos.

        [Qt] These tests pass, update the metrics and exclude from Skipped.

        * platform/qt/Skipped:
        * platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
        * platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
        * platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
        * platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
        * platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
        * platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
        * platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r47185, the fix for <https://bugs.webkit.org/show_bug.cgi?id=28185>, as it...
mrowe@apple.com [Thu, 13 Aug 2009 12:53:29 +0000 (12:53 +0000)]
Revert r47185, the fix for <https://bugs.webkit.org/show_bug.cgi?id=28185>, as it broke the
Windows build in a non-obvious manner.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInspectorBackendCustom.cpp:
* inspector/InspectorBackend.idl:
* platform/Cookie.h: Removed.
* platform/CookieJar.h:
* platform/haiku/CookieJarHaiku.cpp:
(WebCore::setCookies):
(WebCore::cookies):
* platform/mac/CookieJar.mm:
* platform/network/chromium/CookieJarChromium.cpp:
* platform/network/curl/CookieJarCurl.cpp:
* platform/network/soup/CookieJarSoup.cpp:
* platform/network/win/CookieJarCFNetWin.cpp:
* platform/network/win/CookieJarWin.cpp:
* platform/qt/CookieJarQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 13 Aug 2009 12:44:38 +0000 (12:44 +0000)]
2009-08-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Not reviewed: build fix (for r47192), adding new file from
        https://bugs.webkit.org/show_bug.cgi?id=28174

        * inspector/front-end/StatusBarButton.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 13 Aug 2009 12:36:41 +0000 (12:36 +0000)]
2009-08-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Test result for quadraticCurveTo.

        * platform/qt/Skipped: Exclude quadraticCurveTo test.
        * platform/qt/fast/canvas/quadraticCurveTo-expected.checksum: Added.
        * platform/qt/fast/canvas/quadraticCurveTo-expected.png: Added.
        * platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Thu, 13 Aug 2009 12:16:46 +0000 (12:16 +0000)]
2009-08-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Introduced StatusBarButton class that encapsulates glyphs support.
        Views updated accordingly.

        https://bugs.webkit.org/show_bug.cgi?id=28174

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.get statusBarItems):
        Updated to retrieve DOM element from StatusBarButton instance
        (here and in similar getters below.)
        (WebInspector.CookieItemsView.prototype.hide):
        (WebInspector.CookieItemsView.prototype.update):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
        (WebInspector.DOMStorageItemsView.prototype.hide):
        (WebInspector.DOMStorageItemsView.prototype.update):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype.get statusBarItems):
        (WebInspector.ElementsPanel.prototype.hide):
        (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
        * inspector/front-end/Panel.js:
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype.get statusBarItems):
        (WebInspector.ProfileView.prototype._updatePercentButton):
        (WebInspector.ProfileView.prototype._focusClicked):
        (WebInspector.ProfileView.prototype._excludeClicked):
        (WebInspector.ProfileView.prototype._resetClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.get statusBarItems):
        (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get statusBarItems):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.get statusBarItems):
        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
        (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
        * inspector/front-end/StatusBarButton.js: Added.
        (WebInspector.StatusBarButton):
        (WebInspector.StatusBarButton.prototype._clicked):
        (WebInspector.StatusBarButton.prototype.get disabled):
        (WebInspector.StatusBarButton.prototype.set disabled):
        (WebInspector.StatusBarButton.prototype.get title):
        (WebInspector.StatusBarButton.prototype.set title):
        (WebInspector.StatusBarButton.prototype.get toggled):
        (WebInspector.StatusBarButton.prototype.set toggled):
        (WebInspector.StatusBarButton.prototype.get visible):
        (WebInspector.StatusBarButton.prototype.set visible):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css: For uniformity, class names are always used
        to identify status bar buttons. Also, fixed "Reload" button style to use glyphs.
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 13 Aug 2009 12:15:19 +0000 (12:15 +0000)]
2009-08-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Fix test result and add pixel test.

        * platform/qt/fast/canvas/canvas-zoom-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-zoom-expected.png: Added.
        * platform/qt/fast/canvas/canvas-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore/ChangeLog
ariya@webkit.org [Thu, 13 Aug 2009 11:45:22 +0000 (11:45 +0000)]
WebCore/ChangeLog

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add shadow support in GraphicsContext::fillRect().

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRect): Paint shadow if necessary.
        (WebCore::GraphicsContext::setPlatformShadow): Inverse y offset.

LayoutTests/ChangeLog

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add pixel tests result for canvas shadow support.

        * platform/qt/Skipped: Exclude new passing tests.
        * platform/qt/fast/canvas/shadow-offset-1-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-1-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-1-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-2-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-2-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-2-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-3-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-3-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-3-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-4-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-4-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-4-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-5-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-5-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-5-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-6-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-6-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-6-expected.txt: Added.
        * platform/qt/fast/canvas/shadow-offset-7-expected.checksum: Added.
        * platform/qt/fast/canvas/shadow-offset-7-expected.png: Added.
        * platform/qt/fast/canvas/shadow-offset-7-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 13 Aug 2009 10:17:59 +0000 (10:17 +0000)]
2009-08-13  David Levin  <levin@chromium.org>

        Unreviewed build fix for Chromium Linux.

        Rollback r47157 as this broke debug tests of Chromium Linux.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for chromium.
levin@chromium.org [Thu, 13 Aug 2009 09:59:28 +0000 (09:59 +0000)]
Unreviewed build fix for chromium.

Patch by David Levin <levin@chromium.org> on 2009-08-13
The chromium build broke due to r47185 which added
a cookies array to inspector/InspectorBackend.idl.

* bindings/v8/custom/V8CustomBinding.h: Added the declaration for the cookies callback.
* bindings/v8/custom/V8InspectorBackendCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL(InspectorBackendCookies)): Stubbed out an implementation
 for the cookies callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for media timebar test on windows.
dimich@chromium.org [Thu, 13 Aug 2009 07:33:17 +0000 (07:33 +0000)]
Fix for media timebar test on windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd optimize call and property access support for ARM JIT.
barraclough@apple.com [Thu, 13 Aug 2009 05:58:36 +0000 (05:58 +0000)]
Add optimize call and property access support for ARM JIT.
https://bugs.webkit.org/show_bug.cgi?id=24986

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-12
Reviewed by Gavin Barraclough.

For tightly coupled sequences the BEGIN_UNINTERRUPTED_SEQUENCE and
END_UNINTERRUPTED_SEQUENCE macros have been introduced which ensure
space for instructions and constants of the named sequence. This
method is vital for those architecture which are using constant pool.

The 'latePatch' method - which was linked to JmpSrc - is replaced with
a port specific solution (each calls are marked to place their address
on the constant pool).

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::executableCopy): Add extra align for constant pool.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::sizeOfConstantPool):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkCall):
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushIfNoSpaceFor): Fix the
computation of the remaining space.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ensureSpace):
(JSC::MacroAssemblerARM::sizeOfConstantPool):
(JSC::MacroAssemblerARM::prepareCall):
* assembler/X86Assembler.h:
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 05:58:29 +0000 (05:58 +0000)]
2009-08-12  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Show Hidden Cookie Data
        https://bugs.webkit.org/show_bug.cgi?id=28185

          Added new file Cookie.h to the WebCore XCode

        * WebCore.xcodeproj/project.pbxproj:

          InspectorController.cookies() binding

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::cookies):
        * inspector/InspectorBackend.idl:

          Struct for static Cookie information
          (name, value, path, domain, expires, httpOnly, secure, session)

        * platform/Cookie.h: Added.
        (WebCore::Cookie::Cookie):

          Getter for the a list of raw Cookies
          getRawCookies(., ., out Vector<Cookie>)

        * platform/CookieJar.h:

          Implementation of getRawCookies for the mac platform.

        * platform/mac/CookieJar.mm:
        (WebCore::getRawCookies):

          Stub other CookieJar implementations to satisfy the interface.

        * platform/haiku/CookieJarHaiku.cpp:
        (WebCore::getRawCookies):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::getRawCookies):
        * platform/network/curl/CookieJarCurl.cpp:
        (WebCore::getRawCookies):
        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::getRawCookies):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::getRawCookies):
        * platform/network/win/CookieJarWin.cpp:
        (WebCore::getRawCookies):
        * platform/qt/CookieJarQt.cpp:
        (WebCore::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber Stamped by Dave Kilzer.
barraclough@apple.com [Thu, 13 Aug 2009 05:26:02 +0000 (05:26 +0000)]
Rubber Stamped by Dave Kilzer.

Disable WTF_USE_JSVALUE32_64 on iPhone for now (support not yet added for ARMv7).

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOoops - moved code that had been accidentally added to op_new_func instead of
barraclough@apple.com [Thu, 13 Aug 2009 05:21:48 +0000 (05:21 +0000)]
Ooops - moved code that had been accidentally added to op_new_func instead of
op_new_func_exp, to where it shoulds be.

Reviewed by Maciej Stachoviak.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Joe Mason <joe.mason@torchmobile.com>
abarth@webkit.org [Thu, 13 Aug 2009 05:00:26 +0000 (05:00 +0000)]
2009-08-12  Joe Mason  <joe.mason@torchmobile.com>

        Reviewed by Adam Barth.

        Better explanation of "Null after navigation" in object diagram
        https://bugs.webkit.org/show_bug.cgi?id=28232

        * coding/major-objects.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-08 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Thu, 13 Aug 2009 04:51:16 +0000 (04:51 +0000)]
2009-08-08  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Cookies in Storage Panel
        https://bugs.webkit.org/show_bug.cgi?id=27202

          Data Structure for a Cookie. Just Key/Value for Now:

        * inspector/front-end/Cookie.js: Added.
        (WebInspector.Cookie):
        (WebInspector.Cookie.prototype.get key):
        (WebInspector.Cookie.prototype.set key):
        (WebInspector.Cookie.prototype.get value):
        (WebInspector.Cookie.prototype.set value):

          A Storage View for Cookies.  Allows for Refresh/Delete:

        * inspector/front-end/CookieItemsView.js: Added.
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.get statusBarItems): refresh and delete buttons
        (WebInspector.CookieItemsView.prototype.show):
        (WebInspector.CookieItemsView.prototype.hide):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype.buildCookies): parses the inspected window's document.cookie string
        (WebInspector.CookieItemsView.prototype.dataGridForCookies): creates a datagrid for cookies
        (WebInspector.CookieItemsView.prototype._deleteButtonClicked): attempt at deleting the cookie (not flawless)
        (WebInspector.CookieItemsView.prototype._refreshButtonClicked): rebuild the datagrid

          Include a SidebarSection Section in the Databases Panel:

        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.show): calls populateInterface
        (WebInspector.DatabasesPanel.prototype.populateInterface): adds cookies if they don't exist
        (WebInspector.DatabasesPanel.prototype.reset): remove cookie specific parts
        (WebInspector.DatabasesPanel.prototype.addCookies): add cookies sidebar tree element
        (WebInspector.DatabasesPanel.prototype.showCookies): sets the visible view to a CookiesItemView
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        (WebInspector.CookieSidebarTreeElement.prototype.get mainTitle): just "Cookies" at the moment
        (WebInspector.CookieSidebarTreeElement.prototype.set mainTitle):
        (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): no subtitle yet
        (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):

          New "Cookies" Image for the Sidebar:

        * inspector/front-end/Images/cookie.png: Added.
        * inspector/front-end/inspector.css:

          Include the Added Files where appropriate:

        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 George Wright <george.wright@torchmobile.com>
staikos@webkit.org [Thu, 13 Aug 2009 04:46:48 +0000 (04:46 +0000)]
2009-08-12  George Wright  <george.wright@torchmobile.com>

        Reviewed by George Staikos.

        Add SQLTransactionCoordinator.[h,cpp] to WebCore.pro.

        https://bugs.webkit.org/show_bug.cgi?id=28246

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix double-fail of bug url. Not reviewed.
staikos@webkit.org [Thu, 13 Aug 2009 04:38:09 +0000 (04:38 +0000)]
Fix double-fail of bug url.  Not reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 George Staikos <george.staikos@torchmobile.com>
staikos@webkit.org [Thu, 13 Aug 2009 02:55:15 +0000 (02:55 +0000)]
2009-08-12  George Staikos  <george.staikos@torchmobile.com>

        Reviewed by Adam Treat.

        Enable WCSS and XHTML-MP flags for build-webkit.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 George Staikos <george.staikos@torchmobile.com>
staikos@webkit.org [Thu, 13 Aug 2009 02:48:57 +0000 (02:48 +0000)]
2009-08-12  George Staikos  <george.staikos@torchmobile.com>

        Reviewed by Adam Treat.

        Mark unused variables to avoid compile failures in -Werror.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Charles Wei <charles.wei@torchmobile.com.cn>
staikos@webkit.org [Thu, 13 Aug 2009 02:47:16 +0000 (02:47 +0000)]
2009-08-12  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by Niko Zimmermann.

        This is to add WCSS marquee support , which is defined by OMA and is an extension for CSS2,
        It extends CSS display with "display:-wap-marquee;-wap-marquee-dir:xxx;-wap-marquee-speed:xxx;-wap-marquee-style:xxx"
        Minor fixes by Eric Seidel and George Staikos.
        https://bugs.webkit.org/show_bug.cgi?id=23727

        No new tests, the tests have already been landed at LayoutTests/fast/wcss/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago run-webkit-tests: document --nthly flag in help message
ddkilzer@apple.com [Thu, 13 Aug 2009 02:18:35 +0000 (02:18 +0000)]
    run-webkit-tests: document --nthly flag in help message

        Reviewed by Simon Fraser.

        * Scripts/run-webkit-tests: Added --nthly flag to $usage string.
        Also noted that -1|--singly implies --nthly 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Alpha Lam < hclam@chromium.org>
dimich@chromium.org [Thu, 13 Aug 2009 01:37:15 +0000 (01:37 +0000)]
2009-08-12 Alpha Lam < hclam@chromium.org>

Not reviewed, Windows test fix after http://trac.webkit.org/changeset/47171.
This splits the expected result file into mac and Windows
versions since the result is different on Windows.

* platform/mac/media/controls-drag-timebar-expected.txt: Renamed from LayoutTests/media/controls-drag-timebar-expected.txt.
* platform/win/media/controls-drag-timebar-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 01:31:45 +0000 (01:31 +0000)]
2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just adding missing results.

        <canvas> without CSS width/height is unaffected by full page zoom
        https://bugs.webkit.org/show_bug.cgi?id=26908

        Adding missing test results.  Unsure why run-webkit-tests didn't fail.

        * fast/canvas/canvas-zoom-expected.checksum: Added.
        * fast/canvas/canvas-zoom-expected.png: Added.
        * fast/canvas/canvas-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 George Wright <george.wright@torchmobile.com>
eric@webkit.org [Thu, 13 Aug 2009 01:07:48 +0000 (01:07 +0000)]
2009-08-12  George Wright  <george.wright@torchmobile.com>

        Reviewed by David Hyatt.

        Test the four cases of width and height being declared or not for a
        canvas element with CSS zooming enabled.

        https://bugs.webkit.org/show_bug.cgi?id=26908

        * fast/canvas/canvas-zoom.html: Added.

2009-08-12  George Wright  <george.wright@torchmobile.com>

        Reviewed by David Hyatt.

        Update the canvas renderer's intrinsic size with the zoomed
        lengths and ensure the intrinsic size is correct when setting
        an initial style.

        https://bugs.webkit.org/show_bug.cgi?id=26908

        Test: fast/canvas/canvas-zoom.html

        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::canvasSizeChanged):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::styleDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Thu, 13 Aug 2009 01:00:41 +0000 (01:00 +0000)]
2009-08-12  Alpha Lam  <hclam@chromium.org>

        Reviewed by Simon Fraser.

        Fix regression for dragging the media controller thumb.
        https://bugs.webkit.org/show_bug.cgi?id=28211

        Add a layout test to make sure dragging the timebar thumb of media
        controls causes seeks.

        * media/controls-drag-timebar-expected.txt: Added.
        * media/controls-drag-timebar.html: Added.

2009-08-12  Alpha Lam  <hclam@chromium.org>

        Reviewed by Simon Fraser.

        Fix regression for dragging the media controller thumb.
        https://bugs.webkit.org/show_bug.cgi?id=28211

        Modified the conditions for rejecting events on the media controller
        to only rejecting mouse events not from the left button.

        Test: media/controls-drag-timebar.html

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Thu, 13 Aug 2009 00:52:54 +0000 (00:52 +0000)]
2009-08-12  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Eric Seidel.

        Regression test. Tests that two transactions that run on two
        different handles for the same DB do not cause a deadlock.

        https://bugs.webkit.org/show_bug?id=27966

        * storage/multiple-transactions-on-different-handles-expected.txt: Added.
        * storage/multiple-transactions-on-different-handles.html: Added.

2009-08-12  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Eric Seidel.

        Fixing a deadlock caused by two transactions that run on two
        different database handles for the same DB. Adding a per-DB thread
        transaction coordinator that allows the DB thread to run only one
        transaction per DB file at any given time.

        Adding a regression test for this bug.

        Test: storage/multiple-transactions-on-different-handles.html

        https://bugs.webkit.org/show_bug.cgi?id=27996

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/Database.cpp:
        (WebCore::Database::transactionCoordinator):
        * storage/Database.h:
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread):
        * storage/DatabaseThread.h:
        (WebCore::DatabaseThread::transactionCoordinator):
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::SQLTransaction):
        (WebCore::SQLTransaction::debugStepName):
        (WebCore::SQLTransaction::performNextStep):
        (WebCore::SQLTransaction::aquireLock):
        (WebCore::SQLTransaction::lockAquired):
        (WebCore::SQLTransaction::cleanupAfterSuccessCallback):
        (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
        * storage/SQLTransaction.h:
        * storage/SQLTransactionCoordinator.cpp: Added.
        * storage/SQLTransactionCoordinator.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 00:40:50 +0000 (00:40 +0000)]
2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, finishing previous commit.

        Add Geolocation layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=27716

        Add changes missed in http://trac.webkit.org/changeset/47168

        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 13 Aug 2009 00:23:44 +0000 (00:23 +0000)]
2009-08-12  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Bug 27716: Add Geolocation layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=27716

        Adds the first, basic Geolocation layout test. This simply tests that
        navigator.geolocation is present when it should be.

        * fast/dom/Geolocation: Added. Directory for Geolocation layout tests.
        * fast/dom/Geolocation/enabled.html: Added. HTML wrapper for enabled.js test.
        * fast/dom/Geolocation/resources: Added. Directory for Geolocation layout tests JS source.
        * fast/dom/Geolocation/resources/enabled.js: Added. Tests that navigator.geolocation is present.
        * fast/dom/Geolocation/resources/TEMPLATE.html: Added. Template for creating HTML wrapper files for JS tests with make-js-test-wrappers.
        * fast/dom/Geolocation/enabled-expected.txt: Added. Expected result for above test.
        * platform/mac/Skipped: Modified. Skip Geolocation tests.
        * platform/qt/Skipped: Modified. Skip Geolocation tests.
        * platform/win/Skipped: Modified. Skip Geolocation tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 00:07:14 +0000 (00:07 +0000)]
2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just fixing mismerged ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 00:03:52 +0000 (00:03 +0000)]
2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        bugzilla-tool : various improvements for running the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=28199

        Make run_and_throw_if_fail silence STDERR as well as STDIN.
        I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
        Change a few "print" statements to "log" so they appear in the output.
        Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
        Added a little more logging so that --quiet mode is easier to understand.
        Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
        Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
        Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
        Made curl call (downloading patch files) quieter.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

<<<<<<< HEAD:WebKitTools/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Custom properties on DOM objects are lost after GC (as demonstrated by the...
darin@apple.com [Wed, 12 Aug 2009 23:40:28 +0000 (23:40 +0000)]
WebCore: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

* GNUmakefile.am: Added the two new source files.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.

* bindings/js/JSCSSRuleListCustom.cpp: Added.
(WebCore::JSCSSRuleList::markChildren): Call markDOMObjectWrapper
on rules in the list.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::markChildren): Added. Call
markDOMObjectWrapper on the CSSValue objects that are owned by the
declaration as values of the properties.

* bindings/js/JSDOMBinding.cpp:
(WebCore::isObservableThroughDOM): Added code to handle some
cases where nodes are observable because they own objects that
in turn have custom properties.

* bindings/js/JSDOMBinding.h: Fix a typo in the header.

* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren): Added call to markDOMObjectWrapper
for implementation and styleSheets.

* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren): Added. Calls markDOMObjectWrapper
for attributes and style.

* bindings/js/JSHTMLCanvasElementCustom.cpp: Added.
(WebCore::JSHTMLCanvasElement::markChildren): Call markDOMObjectWrapper
on the rendering context.

* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::markChildren): Call markDOMObjectWrapper on
items in the stylesheet.

* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::markChildren): Added. Calls
markDOMObjectWrapper on stylesheets in the list.

* css/CSSRuleList.idl: Added CustomMarkFunction.
* css/CSSStyleDeclaration.idl: Ditto.
* css/StyleSheetList.idl: Ditto.
* dom/Element.idl: Ditto.
* html/HTMLCanvasElement.idl: Ditto.

* dom/Element.h: Made everything private that could be.
Added access to the attributeMap that does returns
the existing map without doing any of the lazy-updating work. This
is needed to get at the existing attributes during garbage collection
without having side effects.

* html/HTMLCanvasElement.h: Cleaned up the header a bit, making
members private. Added renderingContext2D function for use in
JSHTMLCanvasElement::markChildren.

LayoutTests: Custom properties on DOM objects are lost after GC (as demonstrated by the gc-9.html test)
https://bugs.webkit.org/show_bug.cgi?id=28194

Patch by Darin Adler <darin@apple.com> on 2009-08-12
Reviewed by Geoff Garen.

* fast/dom/gc-9-expected.txt: Regenerated.
* fast/dom/gc-9.html: Updated to expect correct behavior instead of failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for Windows Debug.
bweinstein@apple.com [Wed, 12 Aug 2009 23:35:19 +0000 (23:35 +0000)]
Build fix for Windows Debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Wed, 12 Aug 2009 23:24:35 +0000 (23:24 +0000)]
2009-08-12  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Eric Seidel.

        Fixes two bugs about Pan Scrolling - Scrolling with middle mouse button doesn't
        work in Expanded view on reader.google.com, and Can enter auto scroll from a non-scrollable area.
        https://bugs.webkit.org/show_bug.cgi?id=28023
        https://bugs.webkit.org/show_bug.cgi?id=24794

        Added a new method to RenderBox seeing if the Box can be scrolled and actually has something to
        scroll, and use that for pan scrolling.

        Test: platform/win/fast/events/panScroll-nested-divs.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::updateAutoscrollRenderer):
        (WebCore::EventHandler::handleMousePressEvent):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
        * rendering/RenderBox.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollByRecursively):

2009-08-12  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Eric Seidel.

        Added a Windows test for https://bugs.webkit.org/show_bug.cgi?id=28023.

        * platform/win/fast/events/panScroll-nested-divs-expected.txt: Added.
        * platform/win/fast/events/panScroll-nested-divs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6017913> Replace use of HISearchWindowShow in -[WebView _searchWithSp...
mrowe@apple.com [Wed, 12 Aug 2009 23:19:14 +0000 (23:19 +0000)]
<rdar://problem/6017913> Replace use of HISearchWindowShow in -[WebView _searchWithSpotlightFromMenu].

Reviewed by Kevin Decker.

* WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]): Use -[NSWorkspace showSearchResultsForQueryString:] post-Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix missing "by" in ChangeLog.
bweinstein@apple.com [Wed, 12 Aug 2009 23:12:13 +0000 (23:12 +0000)]
Fix missing "by" in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Wed, 12 Aug 2009 23:10:47 +0000 (23:10 +0000)]
2009-08-12  Brian Weinstein  <bweinstein@apple.com>

        Reviewed Adam Roben.

        Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
        list detaches drop down.

        Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
        the popup (matches other browser behavior).

        * WebView.cpp:
        (WebView::mouseWheel):

2009-08-12  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
        list detaches drop down.

        Added a function for Windows PopupMenu's to return their class name.

         * platform/PopupMenu.h:
         * platform/win/PopupMenuWin.cpp:
         (WebCore::PopupMenu::popupClassName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Added workaround for the limitation that VirtualFree with MEM_RELEASE
adachan@apple.com [Wed, 12 Aug 2009 23:07:08 +0000 (23:07 +0000)]
    Added workaround for the limitation that VirtualFree with MEM_RELEASE
        can only accept the base address returned by VirtualAlloc when the region
        was reserved and it can only free the entire region, and not a part of it.

        Reviewed by Oliver Hunt.

        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):
        * runtime/MarkStackWin.cpp:
        (JSC::MarkStack::releaseStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 12 Aug 2009 23:03:51 +0000 (23:03 +0000)]
2009-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        WINCE PORT: Color and Gradient
        https://bugs.webkit.org/show_bug.cgi?id=27511

        * platform/graphics/wince/ColorWince.cpp: Added.
        * platform/graphics/wince/GradientWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 12 Aug 2009 22:55:59 +0000 (22:55 +0000)]
2009-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
        https://bugs.webkit.org/show_bug.cgi?id=28172

        No new tests because it's a just typo fix.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 George Wright <george.wright@torchmobile.com>
eric@webkit.org [Wed, 12 Aug 2009 22:49:16 +0000 (22:49 +0000)]
2009-08-12  George Wright  <george.wright@torchmobile.com>

        Reviewed by Adam Treat.

        Initialise zoom levels independent of whether a URL is valid or not to
        fix https://bugs.webkit.org/show_bug.cgi?id=28162

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=27458
pkasting@chromium.org [Wed, 12 Aug 2009 22:21:01 +0000 (22:21 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27458
Support for the :default CSS pseudoclass, as per HTML5 spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#selector-default

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

Tests: fast/css/pseudo-default-001.html
       fast/css/pseudo-default-002.html
       fast/css/pseudo-default-003.html
       fast/css/pseudo-default-004.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType): pseudoDefault
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): sharing stuff is
aware that only one default button can be present in a form
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): applies
the :default CSS pseudoclass
* dom/Element.h:
(WebCore::Element::isDefaultButtonForForm): new method to determine
whether a FormControl is a default button for a given form
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isDefaultButtonForForm): ditto
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::defaultButton): extracts the default button
from the form
* html/HTMLFormElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27458
Test suite for the :default CSS pseudoclass.

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
Reviewed by Darin Adler.

* fast/css/pseudo-default-001-expected.txt: Added.
* fast/css/pseudo-default-001.html: Added.
* fast/css/pseudo-default-002-expected.txt: Added.
* fast/css/pseudo-default-002.html: Added.
* fast/css/pseudo-default-003-expected.txt: Added.
* fast/css/pseudo-default-003.html: Added.
* fast/css/pseudo-default-004-expected.txt: Added.
* fast/css/pseudo-default-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=27323
pkasting@chromium.org [Wed, 12 Aug 2009 22:15:51 +0000 (22:15 +0000)]
WebKitLibraries: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

* win/tools/scripts/auto-version.sh:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Change pattern that strips all trailing whitespace to just remove EOL
chars (\r, \n), to make it clear that varying EOL chars is the primary
problem being solved.

Reviewed by Darin Adler.

* Scripts/prepare-ChangeLog:
* Scripts/resolve-ChangeLogs:
* Scripts/svn-create-patch:
* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 12 Aug 2009 22:10:20 +0000 (22:10 +0000)]
2009-08-12  David Levin  <levin@chromium.org>

        No review, rolling out r47106.
        https://bugs.webkit.org/show_bug.cgi?id=28215

        This patch relied on a new version of v8 which is not available
        in chromium yet.

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8StringToAtomicWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 12 Aug 2009 22:08:55 +0000 (22:08 +0000)]
2009-08-12  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Bug 26993 : Geolocation::requestPermission()
        https://bugs.webkit.org/show_bug.cgi?id=26993

        Second patch to allow the Geolocation permission request to chrome to be asynchronous
        or synchronous. Fixes a bug where callbacks were called twice when permissions
        are granted synchronously.

        No new tests required.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::setIsAllowed): Modified. Calls makeSuccessCallbacks() rather than geolocationServicePositionChanged().
        (WebCore::Geolocation::geolocationServicePositionChanged): Modified. Updated logic to avoid repeated callbacks when permissions are granted synchronously.
        (WebCore::Geolocation::makeSuccessCallbacks): Added. Calls success callbacks.
        * page/Geolocation.h: Modified. Adds makeSuccessCallbacks().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6952336>
andersca@apple.com [Wed, 12 Aug 2009 22:03:02 +0000 (22:03 +0000)]
<rdar://problem/6952336>
CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27

Reviewed by Sam Weinig.

Make sure to set the security origin before calling dispatchWindowObjectAvailable.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Xiaomei Ji <xji@chromium.org>
eric@webkit.org [Wed, 12 Aug 2009 21:49:20 +0000 (21:49 +0000)]
2009-08-12  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Eric Seidel.

        Fix [Chromium] drop down menu letter selection, skip selections
        https://bugs.webkit.org/show_bug.cgi?id=28205

        Not auto-testable since it is chromim platform specific code, and it involves sending a keyboard
        event to the popup, which is not possible (eventSender sends the key
        events through webview, we want to go through the webwidget).

        * manual-tests/keyboard_select_elements_with_same_beginning.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::isCharacterTypeEvent): style change.
        (WebCore::PopupListBox::handleKeyEvent): typeAheadFind should be called only when the event is
        a character type event to avoid calling twice for English.
        (WebCore::PopupListBox::typeAheadFind): remove unnecessary checking of isCharacterTypeEvent() since the whole function is only called under that condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 12 Aug 2009 21:22:38 +0000 (21:22 +0000)]
2009-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix.

        Last-minute change on the new soup API to use the keyring was not
        reflected in our usage - the documentation says we should use
        g_slist_free, and soup_auth_free_saved_users doesn't exist.

        * webkit/webkitsoupauthdialog.c:
        (session_authenticate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebPreferenceKeysPrivate.h available for client use
aroben@apple.com [Wed, 12 Aug 2009 21:08:17 +0000 (21:08 +0000)]
Make WebPreferenceKeysPrivate.h available for client use

Reviewed by Dave Hyatt.

Fixes <http://webkit.org/b/28227>.

* WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
$WebKitOutputDir, just like we do for a few other headers. Also let VS
reorder some XML attributes.

* WebPreferenceKeysPrivate.h: Touched this file to force a build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 21:02:26 +0000 (21:02 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding GraphicsContext to WebCore/platform/graphics/haiku.
        https://bugs.webkit.org/show_bug.cgi?id=28130

        * platform/graphics/haiku/GraphicsContextHaiku.cpp: Added.
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::platformContext):
        (WebCore::GraphicsContext::savePlatformState):
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::beginPath):
        (WebCore::GraphicsContext::addPath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::drawFocusRing):
        (WebCore::GraphicsContext::drawLineForText):
        (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
        (WebCore::GraphicsContext::roundToDevicePixels):
        (WebCore::GraphicsContext::beginTransparencyLayer):
        (WebCore::GraphicsContext::endTransparencyLayer):
        (WebCore::GraphicsContext::clearRect):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::setLineCap):
        (WebCore::GraphicsContext::setLineJoin):
        (WebCore::GraphicsContext::setMiterLimit):
        (WebCore::GraphicsContext::setAlpha):
        (WebCore::GraphicsContext::setCompositeOperation):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipToImageBuffer):
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::translate):
        (WebCore::GraphicsContext::origin):
        (WebCore::GraphicsContext::rotate):
        (WebCore::GraphicsContext::scale):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        (WebCore::GraphicsContext::concatCTM):
        (WebCore::GraphicsContext::setPlatformShouldAntialias):
        (WebCore::GraphicsContext::setImageInterpolationQuality):
        (WebCore::GraphicsContext::setURLForRect):
        (WebCore::GraphicsContext::setPlatformFont):
        (WebCore::GraphicsContext::setPlatformStrokeColor):
        (WebCore::GraphicsContext::getHaikuStrokeStyle):
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        (WebCore::GraphicsContext::setPlatformStrokeThickness):
        (WebCore::GraphicsContext::setPlatformFillColor):
        (WebCore::GraphicsContext::clearPlatformShadow):
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 20:55:51 +0000 (20:55 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Modifying WebCore/platform/graphics files to allow Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=28128

        * platform/graphics/BitmapImage.h: Adding getBBitmap() function.
        * platform/graphics/Color.h: rgb_color is the Color struct in Haiku.
        * platform/graphics/FloatPoint.h: BPoint is the Point class in Haiku.
        * platform/graphics/FloatRect.h: BRect is the Rect class in Haiku.
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h: BView is the PlatformGraphicsContext
        class for Haiku. Adding getHaikuStrokeStyle() function.
        * platform/graphics/Icon.h: Adding an empty Icon() constructor because
        this class isn't implemented for the moment.
        * platform/graphics/ImageSource.h: BBitmap is the native bitmap class
        for Haiku.
        * platform/graphics/IntPoint.h: BPoint is the Point class in Haiku.
        * platform/graphics/IntRect.h: BRect is the Rect class in Haiku.
        * platform/graphics/IntSize.h: BSize is the Size class in Haiku.
        * platform/graphics/Path.h: BRegion is the Path class in Haiku.
        * platform/graphics/Pattern.h: Adding the GraphicsDef.h header and the
        native pattern type.
        * platform/graphics/SimpleFontData.h: Adding Haiku's Font.h header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 20:44:16 +0000 (20:44 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding modification to the WebCore/platform/ files to allow
        the Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=28128

        * platform/ContextMenuItem.h: BMenu is the PlatformMenuItemDescription
        class of Haiku.
        * platform/Cursor.h: BCursor is the Cursor class of Haiku.
        * platform/DragData.h: Use a BMessage as DragDataRef.
        * platform/DragImage.h: Use a BBitmap as DragImageRef.
        * platform/PlatformKeyboardEvent.h: Use BMessage as event vehicle.
        * platform/PlatformMenuDescription.h: BMenu is the
        PlatformMenuDescription class of Haiku.
        * platform/PlatformMouseEvent.h: Use BMessage as event vehicle.
        * platform/PlatformWheelEvent.h: Use BMessage as event vehicle.
        * platform/PopupMenu.h: Adding a m_menu attribute for Haiku.
        * platform/Widget.h: BView is the PlatformWidget class of Haiku.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 20:35:32 +0000 (20:35 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Tiny modifications on WebCore files to allow Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=28128

        * bindings/js/ScriptControllerHaiku.cpp: Style cleanup.
        * loader/CachedFont.cpp: Haiku behaves like Qt, Gtk, or Chromium,
        so many PLATFORM(HAIKU) were added to these functions.
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allClientsRemoved):
        * page/EventHandler.cpp: Like the mac and Qt port, Haiku doesn't need the
        invertSenseOfTabsToLinks() function.
        * page/haiku/DragControllerHaiku.cpp: Style cleanup.
        * platform/image-decoders/ImageDecoder.h: For image decoding Haiku
        behaves like Cairo or Wx, (not like Skia).
        (WebCore::RGBA32Buffer::getAddr):
        * platform/text/PlatformString.h: Adding the String(BString&) and BString()
        methods specific to Haiku.
        * platform/text/UnicodeRange.h: Haiku needs to include stdint.h.
        * platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp:
        (WebCore::currentSearchLocaleID): Missing function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 20:23:13 +0000 (20:23 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding the ScrollbarTheme files.
        https://bugs.webkit.org/show_bug.cgi?id=28125

        * platform/haiku/ScrollbarThemeHaiku.cpp: Added.
        (buttonWidth):
        (WebCore::ScrollbarTheme::nativeTheme):
        (WebCore::ScrollbarThemeHaiku::ScrollbarThemeHaiku):
        (WebCore::ScrollbarThemeHaiku::~ScrollbarThemeHaiku):
        (WebCore::ScrollbarThemeHaiku::scrollbarThickness):
        (WebCore::ScrollbarThemeHaiku::hasButtons):
        (WebCore::ScrollbarThemeHaiku::hasThumb):
        (WebCore::ScrollbarThemeHaiku::backButtonRect):
        (WebCore::ScrollbarThemeHaiku::forwardButtonRect):
        (WebCore::ScrollbarThemeHaiku::trackRect):
        (WebCore::ScrollbarThemeHaiku::paintScrollbarBackground):
        (WebCore::ScrollbarThemeHaiku::paintButton):
        (WebCore::ScrollbarThemeHaiku::paintThumb):
        * platform/haiku/ScrollbarThemeHaiku.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 20:16:21 +0000 (20:16 +0000)]
2009-08-12  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding eight simple files to WebCore/platform/graphics/haiku.
        https://bugs.webkit.org/show_bug.cgi?id=28122

        * platform/graphics/haiku/ColorHaiku.cpp: Added.
        (WebCore::Color::Color):
        (WebCore::Color::operator rgb_color):
        (WebCore::focusRingColor):
        * platform/graphics/haiku/FloatPointHaiku.cpp: Added.
        (WebCore::FloatPoint::FloatPoint):
        (WebCore::FloatPoint::operator BPoint):
        * platform/graphics/haiku/FloatRectHaiku.cpp: Added.
        (WebCore::FloatRect::FloatRect):
        (WebCore::FloatRect::operator BRect):
        * platform/graphics/haiku/GradientHaiku.cpp: Added.
        (WebCore::Gradient::platformDestroy):
        (WebCore::Gradient::platformGradient):
        (WebCore::Gradient::fill):
        * platform/graphics/haiku/IntPointHaiku.cpp: Added.
        (WebCore::IntPoint::IntPoint):
        (WebCore::IntPoint::operator BPoint):
        * platform/graphics/haiku/IntRectHaiku.cpp: Added.
        (WebCore::IntRect::IntRect):
        (WebCore::IntRect::operator BRect):
        * platform/graphics/haiku/IntSizeHaiku.cpp: Added.
        (WebCore::IntSize::IntSize):
        (WebCore::IntSize::operator BSize):
        * platform/graphics/haiku/PathHaiku.cpp: Added.
        (WebCore::Path::Path):
        (WebCore::Path::~Path):
        (WebCore::Path::operator=):
        (WebCore::Path::hasCurrentPoint):
        (WebCore::Path::contains):
        (WebCore::Path::translate):
        (WebCore::Path::boundingRect):
        (WebCore::Path::moveTo):
        (WebCore::Path::addLineTo):
        (WebCore::Path::addQuadCurveTo):
        (WebCore::Path::addBezierCurveTo):
        (WebCore::Path::addArcTo):
        (WebCore::Path::closeSubpath):
        (WebCore::Path::addArc):
        (WebCore::Path::addRect):
        (WebCore::Path::addEllipse):
        (WebCore::Path::clear):
        (WebCore::Path::isEmpty):
        (WebCore::Path::debugString):
        (WebCore::Path::apply):
        (WebCore::Path::transform):
        (WebCore::Path::strokeBoundingRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 Aug 2009 20:03:19 +0000 (20:03 +0000)]
2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just fixing line-endings.

        Change from DOS to unix line endings on tests from
        http://trac.webkit.org/changeset/47130

        * fast/events/set-event-in-another-frame-expected.txt:
        * fast/events/set-event-to-null-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAs per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and...
andersca@apple.com [Wed, 12 Aug 2009 19:51:14 +0000 (19:51 +0000)]
As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: Implement Keygen for WINCE
treat@webkit.org [Wed, 12 Aug 2009 19:45:09 +0000 (19:45 +0000)]
WINCE PORT: Implement Keygen for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Lyon Chen <lyon.chen@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

* platform/wince/KeygenWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kevin Ollivier.
bfulgham@webkit.org [Wed, 12 Aug 2009 19:41:48 +0000 (19:41 +0000)]
Rubber-stamped by Kevin Ollivier.

Handle crash in wx due to null value passed to strlen in
the CString constructor.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath):  Check for null return from getenv
and use default CString constructor instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: simple stubs to make it build for WINCE
treat@webkit.org [Wed, 12 Aug 2009 19:41:09 +0000 (19:41 +0000)]
WINCE PORT: simple stubs to make it build for WINCE
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

* platform/wince/DragDataWince.cpp: Added.
* platform/wince/DragImageWince.cpp: Added.
* platform/wince/EditorWince.cpp: Added.
* platform/wince/KURLWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCEPORT: FileSystem and FileChooser
treat@webkit.org [Wed, 12 Aug 2009 19:38:42 +0000 (19:38 +0000)]
WINCEPORT: FileSystem and FileChooser
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

* platform/wince/FileChooserWince.cpp: Added.
* platform/wince/FileSystemWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: implement Cursor for WINCE. There's no real cursor on most
treat@webkit.org [Wed, 12 Aug 2009 19:35:00 +0000 (19:35 +0000)]
WINCE PORT: implement Cursor for WINCE. There's no real cursor on most
WinMob devices. We pass the cursor info to application, which so that
can determine what to do.
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by Eric Seidel.

* platform/wince/CursorWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: MIMETypeRegistry
treat@webkit.org [Wed, 12 Aug 2009 19:32:10 +0000 (19:32 +0000)]
WINCE PORT: MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

* platform/wince/MIMETypeRegistryWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: Pasteboard and SearchPopupMenu
treat@webkit.org [Wed, 12 Aug 2009 19:28:11 +0000 (19:28 +0000)]
WINCE PORT: Pasteboard and SearchPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Joe Mason <joe.mason@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

* platform/wince/PasteboardWince.cpp: Added.
* platform/wince/SearchPopupMenuWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp
treat@webkit.org [Wed, 12 Aug 2009 19:24:47 +0000 (19:24 +0000)]
WINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27543

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
Reviewed by George Staikos.

* platform/wince/SharedTimerWince.cpp: Added.
* platform/wince/SystemTimeWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Mark Mentovai <mark@chromium.org>
eric@webkit.org [Wed, 12 Aug 2009 19:05:53 +0000 (19:05 +0000)]
2009-08-12  Mark Mentovai  <mark@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=28204
        Allow C++ exceptions to be disabled in WebCore's V8 Mac build.

        * WebCorePrefix.h:
        Only undefine |try| and |catch| when building Objective-C[++],
        leaving the C++ library definitions intact for C++.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 12 Aug 2009 18:43:47 +0000 (18:43 +0000)]
2009-08-12  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Add a Custom Setter for DOMWindowEvent in the V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=27719

        Tests: fast/events/set-event-in-another-frame.html
               fast/events/set-event-to-null.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 12 Aug 2009 18:37:14 +0000 (18:37 +0000)]
2009-08-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Remove keyring optional features
        https://bugs.webkit.org/show_bug.cgi?id=28173

        Remove keyring support, we now do authentication storage through
        libsoup. We depend on libsoup master now, will bump the dependency
        when there's a new release.

        * GNUmakefile.am:
        * configure.ac:

WebKit/gtk:

2009-08-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Remove keyring optional features
        https://bugs.webkit.org/show_bug.cgi?id=28173

        Remove keyring support from our code and rely on libsoup to store
        the authentication data if the user requests that support in their
        application/library.

        * webkit/webkitsoupauthdialog.c:
        (response_callback):
        (show_auth_dialog):
        (session_authenticate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 Aug 2009 18:33:27 +0000 (18:33 +0000)]
2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just skipping tests to make the bots green.

        REGRESSION (r47110): 4 media regressions on the bots
        https://bugs.webkit.org/show_bug.cgi?id=28221

        Skipping these until Eric Carlson has a fix.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=27965
pkasting@chromium.org [Wed, 12 Aug 2009 18:27:14 +0000 (18:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=27965
Merge wx/ImageSourceWx.cpp into ImageSource.cpp.  No changes to
ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.

Reviewed by Adam Treat.

* WebCore.gypi:
* WebCoreSources.bkl:
* platform/graphics/wx/ImageSourceWx.cpp: Removed.
* webcore-wx.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=27933
pkasting@chromium.org [Wed, 12 Aug 2009 18:23:00 +0000 (18:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=27933
Build fix after r47099.

Reviewed by Dave Levin.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx waf build fix, add new directories to the build.
kevino@webkit.org [Wed, 12 Aug 2009 18:18:08 +0000 (18:18 +0000)]
wx waf build fix, add new directories to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowxPython build fix, the SWIG defines must also be available when compiling.
kevino@webkit.org [Wed, 12 Aug 2009 18:11:00 +0000 (18:11 +0000)]
wxPython build fix, the SWIG defines must also be available when compiling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails...
cfleizach@apple.com [Wed, 12 Aug 2009 17:56:16 +0000 (17:56 +0000)]
Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=28219

Reviewed by Eric Seidel.

* platform/mac-snowleopard/Skipped:
* platform/mac/accessibility/string-range-contains-listmarker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove support for a window resizer within the WebView
aroben@apple.com [Wed, 12 Aug 2009 17:23:14 +0000 (17:23 +0000)]
Remove support for a window resizer within the WebView

WebKit/win:

Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.

Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView

Reviewed by Dave Hyatt.

* Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::windowResizerRect): Now always returns an empty
rect.

* WebView.cpp:
(WebView::paint):
(WebView::handleMouseEvent):
* WebView.h:
Removed window-resizer-related code.

WebKitTools:

Update DumpRenderTree for IWebUIDelegatePrivate changes

Reviewed by Dave Hyatt.

* DumpRenderTree/win/UIDelegate.h: Updated to match
IWebUIDelegatePrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't try to seek to the end of stdin on Cygwin
aroben@apple.com [Wed, 12 Aug 2009 17:18:44 +0000 (17:18 +0000)]
Don't try to seek to the end of stdin on Cygwin

Doing so seems to always cause an exception (for unknown reasons).

Fixes <http://webkit.org/b/28159> create-bug throws an exception in
Cygwin

Reviewed by Dave Kilzer.

* Scripts/bugzilla-tool:
(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't raise an exception when --cc is not passed to create-bug
aroben@apple.com [Wed, 12 Aug 2009 17:17:27 +0000 (17:17 +0000)]
Don't raise an exception when --cc is not passed to create-bug

Fixes <http://webkit.org/b/28158> create-bug throws an exception if
--cc is not specified

Reviewed by Dave Kilzer.

* Scripts/modules/bugzilla.py:
(Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
string was specified. Otherwise we'll generate an exception about the
"cc" variable not being a string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd delegate methods about focus and blur and state change
bolsinga@apple.com [Wed, 12 Aug 2009 16:55:49 +0000 (16:55 +0000)]
Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Reviewed by Eric Seidel.

Have ObjC delegate methods match C++ method names in the ChromeClient.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::formDidFocus):
(WebChromeClient::formDidBlur):
* WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWINCE PORT: Implement Path for WINCE. Most code can be
treat@webkit.org [Wed, 12 Aug 2009 16:50:34 +0000 (16:50 +0000)]
WINCE PORT: Implement Path for WINCE. Most code can be
reused for other ports that don't have native path support
https://bugs.webkit.org/show_bug.cgi?id=28188

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
Reviewed by Adam Treat.

Written also by George Staikos (including quadCurve() and bezier())

* platform/graphics/wince/PathWince.cpp: Added.
* platform/graphics/wince/PlatformPathWince.cpp: Added.
* platform/graphics/wince/PlatformPathWince.h: Added.
* platform/graphics/wince/WinceGraphicsExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 12 Aug 2009 16:49:04 +0000 (16:49 +0000)]
2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Windows build fix.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::localizedMediaTimeDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Joseph Pecoraro <joepeck02@gmail.com>
eric@webkit.org [Wed, 12 Aug 2009 16:43:28 +0000 (16:43 +0000)]
2009-08-12  Joseph Pecoraro  <joepeck02@gmail.com>

        "Double-click to add" new style button does not always show up [quick fix]
        https://bugs.webkit.org/show_bug.cgi?id=28187

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com>
eric@webkit.org [Wed, 12 Aug 2009 16:42:45 +0000 (16:42 +0000)]
2009-08-12  Crystal Zhang <crystal.zhang@torchmobile.com>

        Reviewed by George Staikos.

        WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
        https://bugs.webkit.org/show_bug.cgi?id=28178

        * platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
        * platform/graphics/wince/MediaPlayerProxy.cpp: Added.
        * platform/graphics/wince/MediaPlayerProxy.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 12 Aug 2009 16:41:59 +0000 (16:41 +0000)]
2009-08-12  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=28175

        Call QDir::toNativeSeparators() before the path is passed to the OS.

        Based on work by David Leong.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::pathByAppendingComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 12 Aug 2009 16:41:48 +0000 (16:41 +0000)]
2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Tiger build fix.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
            Define NSAccessibilityTimelineSubrole for Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 12 Aug 2009 16:35:00 +0000 (16:35 +0000)]
2009-08-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Ariya Hidayat.

        Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
        of getImageData. This changed since r47099.

        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47112 268f45cc-cd09-0410-ab3c-d52691b4dbfc