darin@apple.com [Mon, 26 Jan 2009 10:16:38 +0000 (10:16 +0000)]
2009-01-26 Darin Adler <darin@apple.com>
Requested by David Hyatt.
* platform/mac/fast/table/form-with-table-style-expected.checksum: Updated to reflect
the progression; we now render things we used to fail to render.
* platform/mac/fast/table/form-with-table-style-expected.png: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 07:31:14 +0000 (07:31 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Try to fix GTK build.
* webkit/webkitwebview.cpp: Added include of FloatQuad.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 07:29:05 +0000 (07:29 +0000)]
WebKit:
2009-01-25 Darin Adler <darin@apple.com>
Try to fix full build on Mac Leopard.
* WebKit.xcodeproj/project.pbxproj: Removed WebKitPluginClient.defs from the WebKit target.
Maybe this is temporary, but I had to do it to get the full build to succeed.
WebKit/mac:
2009-01-25 Darin Adler <darin@apple.com>
* Plugins/Hosted/HostedNetscapePluginStream.mm: Added a missing extern "C".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 07:26:29 +0000 (07:26 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Try to fix Windows build.
* WebView.cpp: Added FloatQuad.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 07:14:59 +0000 (07:14 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Try to fix Tiger buildbot.
* WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
* page/mac/WebDashboardRegion.m:
(typeName): Added.
(-[WebDashboardRegion description]): Use typeName.
(-[WebDashboardRegion isEqual:]): Added comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 26 Jan 2009 06:42:30 +0000 (06:42 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23535
Strengthen debug checks in KURL
Covered (and prompted) by existing tests.
* platform/KURL.cpp:
(WebCore::checkEncodedString): Check that the first character of the URL is an allowed
first scheme character, not just that it isn't a slash.
(WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
because of parsing being idempotent).
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
empty security origin is created.
(WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
it - it is not guaranteed to be properly encoded.
* dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
string, it needs to be parsed into an URL, not just converted into one.
* html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
Create the security origin with createFromString() instead of create(). I do not know where
the string comes from and whether it might not be properly encoded, but this change can't
hurt, and makes the code slightly more clear.
* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
origin with createFromString() instead of create(). The string comes from an HTTP response
header, so it may not be a properly encoded URL.
* loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
invalid URLs.
* page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
SecurityOrigin::createFromString() (no change in behavior).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 05:13:35 +0000 (05:13 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Discussed with Mark Rowe; not sure he reviewed it.
* Configurations/Base.xcconfig: Add all the same warnings as in WebCore except for
-Wcast-qual and -Wunused-parameter, which both need to be off at least for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 26 Jan 2009 04:14:36 +0000 (04:14 +0000)]
Improve the consistency of settings in our .xcconfig files.
Rubber-stamped by Dan Bernstein.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 26 Jan 2009 03:40:34 +0000 (03:40 +0000)]
Land table/forms layout test progression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 26 Jan 2009 03:38:55 +0000 (03:38 +0000)]
WebCore:
2009-01-25 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
The new table code created a bug involving markAllDescendantsWithFloatsForLayout, namely that it could
end up marking ancestors of a block as needing layout when that block was still in the process of
doing a layout.
The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
we are "mid-layout." If this flag is set, then the method will make sure to do only local dirtying
of objects to avoid accidentally marking a clean ancestor as needing layout again.
Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
with a check of whether or not we are mid-layout being done by those methods instead.
Reviewed by Oliver Hunt
Added fast/repaint/dynamic-table-vertical-alignment-change.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::removeFromObjectLists):
* rendering/RenderObject.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
2009-01-25 David Hyatt <hyatt@apple.com>
Add layout test for https://bugs.webkit.org/show_bug.cgi?id=23524.
Reviewed by Oliver Hunt
* fast/repaint/dynamic-table-vertical-alignment-change.html: Added.
* platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum: Added.
* platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
* platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 26 Jan 2009 03:02:08 +0000 (03:02 +0000)]
JavaScriptCore:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Turn on the following warnings:
-Wcast-qual
-Wextra-tokens
-Wformat=2
-Winit-self
-Wmissing-noreturn
-Wpacked
-Wrendundant-decls
* Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
-W for clarity since we don't have to support the older versions of gcc that require the
old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
-Wno-format-y2k since we can have that one on now.
WebCore:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Turn on the following warnings:
-Wcast-qual
-Wextra-tokens
-Wformat=2
-Winit-self
-Wmissing-noreturn
-Wpacked
-Wrendundant-decls
* Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
-W for clarity since we don't have to support the older versions of gcc that require the
old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
-Wno-format-y2k since we can have that one on now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 26 Jan 2009 01:32:54 +0000 (01:32 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
string hashing code when opening a Digg RSS article
Test: fast/loader/null-request-after-willSendRequest.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Null-check the request returned from
the client's willSendRequest method.
LayoutTests:
Reviewed by Oliver Hunt.
- test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
string hashing code when opening a Digg RSS article
* fast/loader/null-request-after-willSendRequest-expected.txt: Added.
* fast/loader/null-request-after-willSendRequest.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 26 Jan 2009 00:47:25 +0000 (00:47 +0000)]
2009-01-25 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
instead of the ancestor overflow (23525)
Make sure that we always call scroll() on the nearest enclosing RenderBox. No test case is possible
here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
Reviewed by Dan Bernstein
* page/EventHandler.cpp:
(WebCore::scrollAndAcceptEvent):
(WebCore::EventHandler::scrollOverflow):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingBox):
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 23:42:44 +0000 (23:42 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
https://bugs.webkit.org/show_bug.cgi?id=23538
rdar://problem/6523719
I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
than doing fallback.
* rendering/RenderPartObject.cpp:
(WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
inelegant if statement.
(WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
(WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
(WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
return a string than an "out" parameter. Fixed the logic to only prefer the ActiveX type over the
type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
new havePlugin function so we handle the case where pluginData is 0.
(WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
that knows how to handle <object> elements.
(WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
use this data still need to be called; they still do something even if no plug-ins are present. And
they have now been corrected to handle 0 properly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 21:19:40 +0000 (21:19 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
* rendering/RenderMenuList.cpp: Fix build by adding back needed include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 21:11:42 +0000 (21:11 +0000)]
2009-01-25 Judit Jasz <jasy@inf.u-szeged.hu>
Reviewed by Darin Adler.
Compilation problem fixing
http://bugs.webkit.org/show_bug.cgi?id=23497
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall): Use JSValuePtr::encode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 20:27:41 +0000 (20:27 +0000)]
JavaScriptCore:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
* parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
This makes both separate compilation and all-in-one compilation work with the
-Wredundant-decls warning.
WebCore:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
Also make the local variable be a RenderBlock so the cast is closer to the code
that guarantees it's correct.
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle): Put the enum into a local variable that's a built-in
type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 20:25:34 +0000 (20:25 +0000)]
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Third patch: Use the noreturn attribute on functions that don't
return to prepare for the use of the -Wmissing-noreturn warning.
* jit/JITCall.cpp:
(JSC::unreachable): Added NO_RETURN.
* jsc.cpp:
(functionQuit): Ditto.
(printUsageStatement): Ditto.
* wtf/AlwaysInline.h: Added definition of NO_RETURN.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 25 Jan 2009 20:23:04 +0000 (20:23 +0000)]
WebCore:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23522: use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Step one: RenderText.
Also change set of RenderFlow* to be a ListHashSet as the comment in the
header indicated.
* dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Use toRenderText.
(WebCore::CharacterData::appendData): Ditto.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner): Ditto.
(WebCore::ContainerNode::getLowerRightCorner): Ditto.
* dom/Position.cpp:
(WebCore::nextRenderedEditable): Ditto.
(WebCore::previousRenderedEditable): Ditto.
(WebCore::Position::renderedOffset): Ditto. Also use function members
instead of data members of InlineTextBox.
(WebCore::Position::upstream): Ditto.
(WebCore::Position::downstream): Ditto.
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
(WebCore::Position::inRenderedText): Ditto.
(WebCore::Position::isRenderedCharacter): Ditto.
(WebCore::searchAheadForBetterMatch): Ditto.
(WebCore::Position::getInlineBoxAndOffset): Ditto.
* dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
included in RenderObject.h.
* dom/Text.cpp:
(WebCore::Text::splitText): Use toRenderText.
(WebCore::Text::recalcStyle): Ditto.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
* editing/SelectionController.cpp:
(WebCore::SelectionController::debugRenderer): Ditto.
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode): Ditto.
(WebCore::TextIterator::handleTextBox): Ditto.
(WebCore::TextIterator::emitText): Ditto.
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
* editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
no longer included in RenderObject.h.
* inspector/InspectorController.cpp: Ditto.
* page/Frame.cpp: Ditto.
* rendering/RenderBox.cpp: Ditto.
* rendering/RenderInline.cpp: Ditto.
* rendering/RenderPath.cpp: Ditto.
* rendering/RenderSVGContainer.cpp: Ditto.
* rendering/RenderSVGImage.cpp: Ditto.
* rendering/RenderSVGInlineText.cpp: Ditto.
* rendering/RenderSVGTSpan.cpp: Ditto.
* rendering/RenderSVGText.cpp: Ditto.
* rendering/RenderSVGTextPath.cpp: Ditto.
* rendering/RenderTableCell.cpp: Ditto.
* rendering/RenderView.cpp: Ditto.
* editing/visible_units.cpp:
(WebCore::startPositionForLine): Use function members instead of data
members of InlineTextBox.
(WebCore::endPositionForLine): Ditto.
(WebCore::startOfParagraph): Use toRenderText.
(WebCore::endOfParagraph): Ditto.
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::deleteLine): Ditto.
(WebCore::InlineTextBox::extractLine): Ditto.
(WebCore::InlineTextBox::attachLine): Ditto.
(WebCore::InlineTextBox::placeEllipsisBox): Ditto.
(WebCore::InlineTextBox::paintDecoration): Ditto.
(WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.
* rendering/InlineTextBox.h: Made most members private. Use toRenderText.
* rendering/RenderArena.cpp:
(WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
(WebCore::RenderArena::free): Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
instead of RenderFlowSequencedSet.
(WebCore::RenderBlock::paintContinuationOutlines): Ditto.
(WebCore::stripTrailingSpace): Ditto.
(WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
(WebCore::RenderBlock::updateFirstLetter): Ditto.
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::addChild): Use toRenderText.
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
instead of RenderFlowSequencedSet.
(WebCore::RenderFlow::paintLines): Ditto.
* rendering/RenderMenuList.cpp: Removed some unneeded includes.
* rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
Made more members private.
* rendering/RenderObject.cpp: Updated includes.
(WebCore::RenderObject::isEditable): Use toRenderText.
(WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
include VisiblePosition.h in the header just for this.
* rendering/RenderObject.h: Removed unneeded includes and forward declarations.
Changed special vertical position values to be constants rather than an enum.
Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
* rendering/RenderText.cpp:
(WebCore::RenderText::findNextInlineTextBox): Use function members instead of
data members of InlineTextBox.
(WebCore::RenderText::positionForCoordinates): Ditto.
(WebCore::isInlineFlowOrEmptyText): Use toRenderText.
(WebCore::RenderText::previousCharacter): Use function members instead of
data members of InlineTextBox.
(WebCore::RenderText::position): Ditto.
(WebCore::RenderText::caretMinOffset): Ditto.
(WebCore::RenderText::caretMaxOffset): Ditto.
(WebCore::RenderText::caretMaxRenderedOffset): Ditto.
* rendering/RenderText.h: Added definition of toRenderText.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<): Use toRenderText and toRenderBox.
(WebCore::writeTextRun): Ditto.
(WebCore::write): Ditto.
* rendering/bidi.cpp:
(WebCore::InlineIterator::increment): Use toRenderText.
(WebCore::InlineIterator::current): Ditto.
(WebCore::checkMidpoints): Ditto.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
(WebCore::RenderBlock::layoutInlineChildren): Ditto.
(WebCore::RenderBlock::determineStartPosition): Ditto.
(WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
(WebCore::RenderBlock::findNextLineBreak): Ditto.
WebKit/mac:
2009-01-25 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Bug 23522: use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Step one: RenderText.
* WebView/WebRenderNode.mm:
(copyRenderNode): Use toRenderText.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 17:29:05 +0000 (17:29 +0000)]
2009-01-25 Urs Wolfer <uwolfer@kde.org>
Reviewed by Simon Hausmann.
Add QWebPage::SelectAll to WebAction enum to select all content.
https://bugs.webkit.org/show_bug.cgi?id=22946
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 17:26:24 +0000 (17:26 +0000)]
2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix gcc compiler warning (deprecated conversion from constant string to char*)
"" cannot be stored in a char*
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 17:22:44 +0000 (17:22 +0000)]
2009-01-25 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Fixed the terminology used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 17:20:52 +0000 (17:20 +0000)]
2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Rename links from trolltech.com to qtsoftware.com
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 17:04:49 +0000 (17:04 +0000)]
2009-01-25 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Make QWebPage auto-test more robust by cleaning up generated files
Sometimes the auto-test may segfault, leaving behind files because the
call to cleanupTestCase() never happens, so we also clean up the files
at initTestCase() just to make sure we're running in a clean environment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Sun, 25 Jan 2009 14:56:27 +0000 (14:56 +0000)]
2008-12-20 Urs Wolfer <uwolfer@kde.org>
Reviewed by Simon Hausmann.
Fix: compile qwebhistory.h with pendantic comiler flag.
https://bugs.webkit.org/show_bug.cgi?id=22947
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 25 Jan 2009 12:03:55 +0000 (12:03 +0000)]
Remove a slightly misleading comment from ChangeLog - the issue is related to bug 23500, but not the same.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 25 Jan 2009 11:59:14 +0000 (11:59 +0000)]
Reviewed by Darin Adler.
<rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
WebCore:
Changed single argument KURL constructors back to always expect an already encoded string,
eliminating extra conversions.
This is a rather unstable situation, as it is often unclear whether a given string is safe
to convert to KURL without resolving. I think that going forward, the solution is to try to
keep encoded URLs as KURL instances, and not as strings.
* platform/KURL.h: Updated comments.
* platform/KURL.cpp:
(WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
since encoding is scheme-dependent, such a verification would be quite complicated.
Don't encode the string as UTF-8, as it supposed to be ASCII-only.
Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
any reason for it to exist, but I saw several cases where this code path was taken
inadvertently (see examples in LayoutTests/ChangeLog).
(WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
the old one), and an already encoded string is expected by parse().
In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
(WebCore::KURL::setHost): Ditto.
(WebCore::KURL::setPort): Ditto.
(WebCore::KURL::setHostAndPort): Ditto.
(WebCore::KURL::setUser): Ditto.
(WebCore::KURL::setPass): Ditto.
(WebCore::KURL::setRef): Ditto.
(WebCore::KURL::setQuery): Ditto.
(WebCore::KURL::setPath): Ditto. Note that problems described in bug 23500 mask some of
the problems in release builds currently, as the incorrectly parsed URL is ignored.
(WebCore::KURL::parse): Verify that the passed string is already encoded.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
* html/HTMLLinkElement.h:
Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see
LayoutTests/ChangeLog).
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
(WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
String to KURL conversion requires the string to be already encoded.
* page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
security origin object), so I just made the code as close to what we already had as possible.
LayoutTests:
* http/tests/misc/dns-prefetch-control-expected.txt:
* http/tests/misc/dns-prefetch-control.html:
Google documentation for DNS Prefetch makes use of net-path relative URLs (//server-name),
explaining that scheme is not necessary. This is of course true, but this test uses data:
subframes, and data: is a non-hierachical scheme, so resolving such URLs fails, resulting
in a KURL object that is not valid. WebKit used to ignore this, and tried to create a URL
from this string again, now with a single argument KURL constructor, which resulted in a
valid file: URL, which was successfully used! Both issues have been corrected in WebCore,
so I had to change the test to no longer use relative net-path URLs.
* http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
* http/tests/security/postMessage/invalid-origin-throws-exception.html:
URLs that start with "/" are no longer converted to "file:" ones, so the results now
match Firefox.
* http/tests/uri/resolve-encoding-relative-expected.txt: Added.
* http/tests/uri/resolve-encoding-relative.html: Added.
Added a test to cover some cases of relative URL resolving that were not covered before.
Expected results are taken from Firefox 3, and WebKit doesn't match in how fragments are
encoded (we use document encoding, while Firefox uses UTF-8). Since fragments are not
sent in HTTP requests, this is not too dangerous, but the Firefox behavior looks more
consistent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sun, 25 Jan 2009 00:34:58 +0000 (00:34 +0000)]
Oops, fix the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 24 Jan 2009 22:41:22 +0000 (22:41 +0000)]
2009-01-24 Eric Carlson <eric.carlson@apple.com>
<video> controls visibility test needs to dump render tree as text because
the test does not always end at the same time, so the timeline slider thumb
is not always at the same position.
* media/video-controls-visible-audio-only.html:
* platform/mac/media/video-controls-visible-audio-only-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 24 Jan 2009 22:39:16 +0000 (22:39 +0000)]
Add QWebFrame::renderContents() method which allows arbitary rendering
of any content region within the QWebFrame. It also does not draw any
scrollbars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 24 Jan 2009 20:59:20 +0000 (20:59 +0000)]
2009-01-24 Darin Adler <darin@apple.com>
Try to fix expected results for new video element test.
* platform/mac/media/video-controls-visible-audio-only-expected.png: Landed new result
generated on my machine.
* platform/mac/media/video-controls-visible-audio-only-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 24 Jan 2009 20:40:01 +0000 (20:40 +0000)]
2009-01-24 Darin Adler <darin@apple.com>
Try to fix Qt build.
* WebCore.pro: Added JSTextCustom.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Sat, 24 Jan 2009 15:10:06 +0000 (15:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=23467
Change styleAvailable functionality to be a linked list
rather than scanning every CompositeAnimation for
Animations that are waiting for styleAvailable. This has
potential for large performance improvement in cases where
there are many animations firing at once. But it will also
help in my next fix, which is to synchronize software and
accelerated animations.
I also changed slightly when the beginAnimationUpdate and
endAnimationUpdate calls are made. But this has no real
effect on performance or behavior.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 24 Jan 2009 09:55:16 +0000 (09:55 +0000)]
Force inlining of Lexer::matchPunctuator
Reviewed by Maciej Stachowiak.
2.2% win when parsing jQuery, Mootools, Prototype, etc
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 24 Jan 2009 09:39:19 +0000 (09:39 +0000)]
Reviewed by Darin Adler.
<rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
Test: http/tests/xmlhttprequest/encode-request-url-2.html
* platform/KURL.cpp:
(WebCore::appendASCII): Added a helper function.
(WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
specified behavior.
(WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
of the byte stream can use different encodings, round-tripping is not possible.
(WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
this function convert the string to utf-8. I think that on the remanining code paths, it is
correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
FIXME warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sat, 24 Jan 2009 08:05:24 +0000 (08:05 +0000)]
2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix after r40170
* GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
and editing/RemoveNodeAttributeCommand.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 24 Jan 2009 06:19:11 +0000 (06:19 +0000)]
Fix the Qt build after r40205.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 24 Jan 2009 05:47:59 +0000 (05:47 +0000)]
2009-01-23 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* history/CachedFrame.cpp: Added.
(WebCore::cachedFrameCounter):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::~CachedFrame):
(WebCore::CachedFrame::restore):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::setCachedFramePlatformData):
(WebCore::CachedFrame::cachedFramePlatformData):
* history/CachedFrame.h: Added.
(WebCore::CachedFrame::document):
(WebCore::CachedFrame::documentLoader):
(WebCore::CachedFrame::view):
(WebCore::CachedFrame::mousePressNode):
(WebCore::CachedFrame::url):
(WebCore::CachedFrame::domWindow):
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
(WebCore::CachedPage::setCachedFramePlatformData):
(WebCore::CachedPage::cachedFramePlatformData):
* history/CachedPage.h:
(WebCore::CachedPage::document):
(WebCore::CachedPage::documentLoader):
(WebCore::CachedPage::view):
(WebCore::CachedPage::mousePressNode):
(WebCore::CachedPage::url):
(WebCore::CachedPage::domWindow):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
creating a CachedPage was a historical relic. Take the opportunity to clean that up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 24 Jan 2009 03:59:09 +0000 (03:59 +0000)]
2009-01-23 David Hyatt <hyatt@apple.com>
Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
that triggered the ASSERT (since all of these places are effectively regressions from my landing that
devirtualized width()/height()).
Reviewed by Adele
* dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clientWidth):
(WebCore::RenderBox::clientHeight):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::absoluteOutlineBounds):
* rendering/RenderBox.h:
(WebCore::RenderBox::width):
(WebCore::RenderBox::height):
(WebCore::RenderBox::size):
(WebCore::RenderBox::frameRect):
(WebCore::RenderBox::borderBoundingBox):
* rendering/RenderFlow.h:
(WebCore::RenderFlow::borderBoundingBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleWillChange):
* rendering/RenderScrollbarPart.h:
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::isKeyboardFocusable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 24 Jan 2009 03:03:25 +0000 (03:03 +0000)]
2009-01-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Fix for <rdar://problem/6126212>
Ensure that callbacks out from the JSC interface are only allowed
to return in reverse-chronological order to that in which they were
made. If we allow earlier callbacks to return first, then this may
result in setions of the RegisterFile in use by another thread
being trampled.
See uber-comment in JSLock.h for details.
* runtime/JSLock.cpp:
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 24 Jan 2009 02:39:56 +0000 (02:39 +0000)]
2009-01-23 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Second patch: Slightly less simple cases of various warnings.
* bridge/jni/jni_runtime.h:
(JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
away const.
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
reinterpret_cast; this is casting the result of malloc, and the idiom is to use
static_cast, which works because we're casting from void*.
(WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
C-style casts.
* xml/XSLTUnicodeSort.cpp:
(inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
instead of redefining the function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 24 Jan 2009 02:23:12 +0000 (02:23 +0000)]
2009-01-23 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
https://bugs.webkit.org/show_bug.cgi?id=23475
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::search): Set the character start flag to false to
ensure we won't ever return the same result twice. There are other ways we
could accomplish this, mentioned in the comment, but this one was the smallest
and cleanest I could think of.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 24 Jan 2009 02:22:21 +0000 (02:22 +0000)]
2009-01-23 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
https://bugs.webkit.org/show_bug.cgi?id=23510
That patch fixed the optimization that's supposed to give a faster path for
allocating the wrappers for DOM Text objects. But CDATASection is the one
subclass of Text objects.
* GNUmakefile.am: Added JSCDATASectionCustom.cpp.
* WebCore.scons: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.
* bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
(WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
* bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
for CDATASection. We don't want to have to check when creating a wrapper for a
Text object whether it's a CDATASection object or not, so we need to do this overload
at compile time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 24 Jan 2009 02:00:43 +0000 (02:00 +0000)]
Reviewed by Eric Seidel.
Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
another base class, just like FormControlElement.
Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
Add new virtual function isFormControlElementWithState() to Element.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Sat, 24 Jan 2009 01:23:21 +0000 (01:23 +0000)]
Bug 23492: Separating the WebKitSystemInterface Calls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 24 Jan 2009 01:21:29 +0000 (01:21 +0000)]
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
Move null checking into makeRange
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 24 Jan 2009 00:54:46 +0000 (00:54 +0000)]
Fix the Gtk build too after removal of RenderBox::toConstRenderBox
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 24 Jan 2009 00:52:36 +0000 (00:52 +0000)]
Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 24 Jan 2009 00:47:44 +0000 (00:47 +0000)]
Fix the Qt build after r40168.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 24 Jan 2009 00:26:43 +0000 (00:26 +0000)]
WebCore:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.order:
* WebCore.xcodeproj/project.pbxproj:
* history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
(WebCore::CachedFramePlatformData::~CachedFramePlatformData):
* history/CachedPagePlatformData.h: Removed.
* history/CachedPage.cpp:
(WebCore::CachedPage::clear):
(WebCore::CachedPage::setCachedFramePlatformData):
(WebCore::CachedPage::cachedFramePlatformData):
* history/CachedPage.h:
WebKit:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
* WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h.
(WebCachedFramePlatformData::WebCachedFramePlatformData):
* WebCoreSupport/WebCachedPagePlatformData.h: Removed.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::savePlatformDataToCachedPage):
(WebFrameLoaderClient::transitionToCommittedFromCachedPage):
* WebKit.order:
WebKit/win:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
* WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
(WebCachedFramePlatformData::WebCachedFramePlatformData):
* WebCachedPagePlatformData.h: Removed.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::savePlatformDataToCachedPage):
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 24 Jan 2009 00:23:04 +0000 (00:23 +0000)]
Reviewed by Kevin Ollivier.
Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 24 Jan 2009 00:19:17 +0000 (00:19 +0000)]
Build fixes for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 23:33:57 +0000 (23:33 +0000)]
Fix Windows bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 23:33:35 +0000 (23:33 +0000)]
Fix Windows bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 23 Jan 2009 23:33:28 +0000 (23:33 +0000)]
2009-01-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Fix for https://bugs.webkit.org/show_bug.cgi?id=23407
Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
is never hidden (as with an <audio> element).
Test: media/video-controls-visible-audio-only.html
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::hasVideo):
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWin::hasVideo):
* platform/graphics/win/QTMovieWin.h:
2009-01-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Test for behavior of <video> element controller when a media file has
only audio.
https://bugs.webkit.org/show_bug.cgi?id=23407
* media/video-controls-visible-audio-only.html: Added.
* platform/mac/media/video-controls-visible-audio-only-expected.checksum: Added.
* platform/mac/media/video-controls-visible-audio-only-expected.png: Added.
* platform/mac/media/video-controls-visible-audio-only-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 23:25:07 +0000 (23:25 +0000)]
2009-01-23 David Hyatt <hyatt@apple.com>
Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.
Reviewed by Oliver Hunt
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):
* dom/Element.cpp:
(WebCore::Element::scrollByUnits):
* dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
* editing/TextIterator.cpp:
(WebCore::shouldEmitExtraNewlineForNode):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::width):
(WebCore::HTMLFrameElementBase::height):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::scrollOverflow):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
* rendering/InlineBox.h:
(WebCore::InlineBox::renderBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeAbsoluteRepaintRect):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::containingBlockHeightForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
* rendering/RenderBox.h:
(WebCore::toRenderBox):
(WebCore::RenderBox::previousSiblingBox):
(WebCore::RenderBox::nextSiblingBox):
(WebCore::RenderBox::parentBox):
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::absoluteClippedOverflowRect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::boundingBox):
* rendering/RenderObject.cpp:
(WebCore::addLayers):
(WebCore::RenderObject::removeLayers):
(WebCore::RenderObject::moveLayers):
(WebCore::RenderObject::findNextLayer):
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::localToAbsoluteQuad):
(WebCore::RenderObject::offsetFromContainer):
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::updateHitTestResult):
(WebCore::RenderObject::addDashboardRegions):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::hitTestMediaControlPart):
(WebCore::RenderTheme::baselinePosition):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::hitTestMediaControlPart):
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation):
* rendering/bidi.cpp:
(WebCore::inlineWidth):
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::requiresLineBox):
(WebCore::RenderBlock::findNextLineBreak):
* svg/SVGLength.cpp:
(WebCore::SVGLength::PercentageOfViewport):
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::isKeyboardFocusable):
* wml/WMLInputElement.cpp:
(WebCore::isInputFocusable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 23 Jan 2009 23:03:21 +0000 (23:03 +0000)]
2009-01-23 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
https://bugs.webkit.org/show_bug.cgi?id=23509
Add null checking around next/previous sentence retrieval in AX code
* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::nextSentenceEndPosition):
(WebCore::AccessibilityObject::previousSentenceStartPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 23 Jan 2009 22:50:47 +0000 (22:50 +0000)]
2009-01-23 Adele Peterson <adele@apple.com>
Build fix.
Use new linesBoundingBox method instead of
boundingBoxWidth and boundingBoxHeight for RenderText objects.
* WebView/WebRenderNode.mm: (copyRenderNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 23 Jan 2009 22:41:48 +0000 (22:41 +0000)]
wx build fix, add missing include dir.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 23 Jan 2009 22:39:31 +0000 (22:39 +0000)]
2009-01-23 David Kilzer <ddkilzer@apple.com>
* Scripts/do-webcore-rename: Removed 10 header guard renames that
had already been fixed, and updated 4 renames whose original values
had changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 23 Jan 2009 22:38:25 +0000 (22:38 +0000)]
Added missing comma to copyright.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 22:20:23 +0000 (22:20 +0000)]
Land new results now that text runs at negative positions dump their widths correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 22:19:59 +0000 (22:19 +0000)]
Land new results now that text runs at negative positions dump their widths correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 22:19:09 +0000 (22:19 +0000)]
Update the test results for compacts and run-ins now that they dump accurate positions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 22:18:18 +0000 (22:18 +0000)]
Add new repaint test for hover regression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 22:17:26 +0000 (22:17 +0000)]
2009-01-23 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
well.
Reviewed by Oliver Hunt
* WebCore.base.exp:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):
* dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockHeightForPositioned):
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::absoluteClippedOverflowRect):
(WebCore::RenderFlow::linesBoundingBox):
* rendering/RenderFlow.h:
* rendering/RenderInline.cpp:
* rendering/RenderInline.h:
(WebCore::RenderInline::offsetWidth):
(WebCore::RenderInline::offsetHeight):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
* rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
* rendering/RenderText.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::write):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 21:28:37 +0000 (21:28 +0000)]
Fix RenderFlow. Botched the application of my patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 21:25:32 +0000 (21:25 +0000)]
2009-01-23 David Hyatt <hyatt@apple.com>
Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
RenderText, since none of the work done in styleWillChange was relevant to text nodes.
Reviewed by Sam Weinig
* dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::renderView):
(WebCore::Document::prepareMouseEvent):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::scrollByUnits):
* editing/SelectionController.cpp:
(WebCore::SelectionController::contains):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::start):
(WebCore::HTMLMarqueeElement::stop):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::topRenderer):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
* page/AccessibilityRenderObject.h:
* page/EventHandler.cpp:
(WebCore::scrollAndAcceptEvent):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
* page/Frame.cpp:
(WebCore::Frame::clearTimers):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::scroll):
(WebCore::RenderBox::canBeProgramaticallyScrolled):
(WebCore::RenderBox::autoscroll):
(WebCore::RenderBox::panScroll):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeAbsoluteRepaintRect):
* rendering/RenderBox.h:
(WebCore::RenderBox::layer):
(WebCore::RenderBox::requiresLayer):
(WebCore::RenderBox::stopAutoscroll):
(WebCore::RenderBox::hasAutoVerticalScrollbar):
(WebCore::RenderBox::hasAutoHorizontalScrollbar):
(WebCore::RenderBox::scrollsOverflow):
(WebCore::RenderBox::scrollsOverflowX):
(WebCore::RenderBox::scrollsOverflowY):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::absoluteClippedOverflowRect):
(WebCore::RenderFlow::addFocusRingRects):
* rendering/RenderForeignObject.cpp:
* rendering/RenderForeignObject.h:
(WebCore::RenderForeignObject::requiresLayer):
* rendering/RenderInline.cpp:
* rendering/RenderInline.h:
(WebCore::RenderInline::requiresLayer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
* rendering/RenderObject.cpp:
(WebCore::addLayers):
(WebCore::RenderObject::removeLayers):
(WebCore::RenderObject::moveLayers):
(WebCore::RenderObject::findNextLayer):
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::localToAbsoluteQuad):
(WebCore::RenderObject::offsetFromContainer):
(WebCore::RenderObject::destroy):
* rendering/RenderObject.h:
* rendering/RenderPath.cpp:
* rendering/RenderPath.h:
(WebCore::RenderPath::requiresLayer):
* rendering/RenderReplica.h:
(WebCore::RenderReplica::requiresLayer):
* rendering/RenderSVGContainer.cpp:
* rendering/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::requiresLayer):
* rendering/RenderSVGHiddenContainer.cpp:
* rendering/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::requiresLayer):
* rendering/RenderSVGImage.cpp:
* rendering/RenderSVGImage.h:
(WebCore::RenderSVGImage::requiresLayer):
* rendering/RenderSVGInline.h:
(WebCore::RenderSVGInline::requiresLayer):
* rendering/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::requiresLayer):
* rendering/RenderSVGText.cpp:
* rendering/RenderSVGText.h:
(WebCore::RenderSVGText::requiresLayer):
* rendering/RenderScrollbarPart.h:
(WebCore::RenderScrollbarPart::requiresLayer):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setCurrentPosition):
* rendering/RenderTableCell.cpp:
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::requiresLayer):
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::requiresLayer):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderText.h:
(WebCore::RenderText::styleWillChange):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::autoscroll):
(WebCore::RenderTextControl::scroll):
* rendering/RenderTextControl.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::externalRepresentation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 21:18:13 +0000 (21:18 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::proxyClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 20:56:33 +0000 (20:56 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix GCC 4.0 build.
* Configurations/Base.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 20:53:17 +0000 (20:53 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix tyop.
* editing/markup.cpp:
(WebCore::joinMarkups):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Jan 2009 20:51:33 +0000 (20:51 +0000)]
2009-01-23 Darin Adler <darin@apple.com>
Try to fix WX build.
* runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h>
for the definition of UChar.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 20:50:59 +0000 (20:50 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
* Configurations/Base.xcconfig:
Fix GCC 4.0 build.
* editing/markup.cpp:
(WebCore::joinMarkups):
Pass a const reference to the vector.
* html/HTMLElement.cpp:
* platform/text/String.cpp:
Add comments indicating that these functions are for use in the debugger.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 20:37:44 +0000 (20:37 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
* Configurations/Base.xcconfig:
GCC 4.0 build fix.
* runtime/JSNumberCell.h:
64-bit build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 23 Jan 2009 20:35:59 +0000 (20:35 +0000)]
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Upstream Chromium's image decoders for use with PLATFORM(SKIA)
* platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
* platform/image-decoders/skia/BMPImageDecoder.h: Added.
* platform/image-decoders/skia/BMPImageReader.cpp: Added.
* platform/image-decoders/skia/BMPImageReader.h: Added.
* platform/image-decoders/skia/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
(WebCore::GIFImageDecoderPrivate::decode):
(WebCore::GIFImageDecoderPrivate::getColorMap):
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
* platform/image-decoders/skia/GIFImageDecoder.h:
(WebCore::GIFImageDecoder::filenameExtension):
(WebCore::GIFImageDecoder::frameDurationAtIndex):
(WebCore::GIFImageDecoder::):
* platform/image-decoders/skia/GIFImageReader.cpp:
(GIFImageReader::do_lzw):
(GIFImageReader::read):
* platform/image-decoders/skia/GIFImageReader.h:
* platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
* platform/image-decoders/skia/ICOImageDecoder.h: Added.
* platform/image-decoders/skia/ImageDecoder.h:
(WebCore::RefCountedNativeImageSkia::create):
(WebCore::RefCountedNativeImageSkia::bitmap):
(WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
(WebCore::RGBA32Buffer::):
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::~RGBA32Buffer):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::bitmap):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
(WebCore::RGBA32Buffer::rect):
(WebCore::RGBA32Buffer::status):
(WebCore::RGBA32Buffer::duration):
(WebCore::RGBA32Buffer::disposalMethod):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setRect):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::setDuration):
(WebCore::RGBA32Buffer::setDisposalMethod):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setRGBA):
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::~ImageDecoder):
(WebCore::ImageDecoder::setData):
(WebCore::ImageDecoder::isSizeAvailable):
(WebCore::ImageDecoder::size):
(WebCore::ImageDecoder::frameCount):
(WebCore::ImageDecoder::repetitionCount):
(WebCore::ImageDecoder::supportsAlpha):
(WebCore::ImageDecoder::failed):
(WebCore::ImageDecoder::setFailed):
(WebCore::ImageDecoder::clearFrameBufferCache):
(WebCore::ImageDecoder::setSize):
(WebCore::ImageDecoder::isOverSize):
* platform/image-decoders/skia/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/skia/JPEGImageDecoder.h:
(WebCore::JPEGImageDecoder::filenameExtension):
(WebCore::JPEGImageDecoder::supportsAlpha):
(WebCore::JPEGImageDecoder::reader):
* platform/image-decoders/skia/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::close):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::decode):
(WebCore::PNGImageDecoder::decodingFailed):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::rowAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
* platform/image-decoders/skia/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::reader):
* platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
* platform/image-decoders/skia/XBMImageDecoder.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 19:58:29 +0000 (19:58 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the resulting warnings.
* Configurations/Base.xcconfig:
* History/WebHistory.mm:
(timeIntervalForBeginningOfDay):
* History/WebHistoryItem.mm:
(historyItemWrappers):
* Misc/WebNSPasteboardExtras.mm:
(imageFromElement):
* WebView/WebFrame.mm:
* WebView/WebScriptDebugger.mm:
(toNSString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 19:52:19 +0000 (19:52 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the resulting warnings.
* Configurations/Base.xcconfig:
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::customGetOwnPropertySlot):
* bindings/objc/DOMRGBColor.mm:
(WebCore::getWrapperForRGB):
(WebCore::setWrapperForRGB):
(WebCore::removeWrapperForRGB):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/c_instance.cpp:
(JSC::Bindings::globalExceptionString):
* bridge/runtime_object.cpp:
(JSC::callRuntimeConstructor):
* css/CSSParser.cpp:
(WebCore::parseGradientColorStop):
* css/CSSPrimitiveValue.cpp:
(WebCore::scaleFactorForConversion):
* css/CSSStyleSelector.cpp:
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::getTransformOperationType):
* dom/make_names.pl:
* editing/DeleteSelectionCommand.cpp:
(WebCore::updatePositionForTextRemoval):
* editing/EditorCommand.cpp:
(WebCore::valueBackColor):
(WebCore::valueFontName):
(WebCore::valueFontSize):
(WebCore::valueFontSizeDelta):
(WebCore::valueForeColor):
* editing/VisiblePosition.cpp:
(WebCore::canonicalizeCandidate):
* editing/htmlediting.cpp:
* editing/markup.cpp:
(WebCore::joinMarkups):
* html/HTMLElement.cpp:
(WebCore::inlineTagList):
(WebCore::blockTagList):
* html/HTMLMediaElement.cpp:
(WebCore::serializeTimeOffset):
(WebCore::parseTimeOffset):
* page/mac/FrameMac.mm:
(WebCore::regExpForLabels):
* platform/Arena.cpp:
* platform/graphics/Color.cpp:
(WebCore::colorFloatToRGBAByte):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
* platform/graphics/cg/PathCG.cpp:
(WebCore::CGPathApplierToPathApplier):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::initFontData):
* platform/mac/PlatformMouseEventMac.mm:
* platform/text/String.cpp:
* rendering/RenderBlock.cpp:
(WebCore::continuationOutlineTable):
(WebCore::getHeightForLineCount):
* rendering/RenderView.cpp:
(WebCore::rendererAfterPosition):
* rendering/RootInlineBox.cpp:
(WebCore::isEditableLeaf):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::hasFractions):
* rendering/style/RenderStyle.cpp:
(WebCore::positionedObjectMoved):
* svg/SVGFont.cpp:
(WebCore::floatWidthUsingSVGFontCallback):
(WebCore::floatWidthMissingGlyphCallback):
(WebCore::drawTextUsingSVGFontCallback):
(WebCore::drawTextMissingGlyphCallback):
* svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList):
* svg/graphics/SVGPaintServerGradient.cpp:
(WebCore::operator<<):
* xml/XPathGrammar.y:
* xml/XSLTExtensions.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 23 Jan 2009 19:42:22 +0000 (19:42 +0000)]
No review, removing an empty file.
Remove RemoveNodeAttributeCommand since it was empty.
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/RemoveNodeAttributeCommand.cpp: Removed.
* editing/RemoveNodeAttributeCommand.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Jan 2009 19:40:56 +0000 (19:40 +0000)]
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the warnings.
* API/JSClassRef.cpp:
(clearReferenceToPrototype):
* Configurations/Base.xcconfig:
* runtime/Collector.cpp:
(JSC::getPlatformThreadRegisters):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/JSGlobalObjectFunctions.h:
* runtime/JSNumberCell.h:
* runtime/UString.cpp:
(JSC::initializeStaticBaseString):
(JSC::createRep):
* wtf/FastMalloc.cpp:
* wtf/Threading.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 23 Jan 2009 19:16:59 +0000 (19:16 +0000)]
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig
Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
* bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
* bindings/js/ScriptCachedPageData.cpp: Removed.
* bindings/js/ScriptCachedPageData.h: Removed.
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* history/CachedPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 23 Jan 2009 19:03:51 +0000 (19:03 +0000)]
Fix build.
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::baselinePosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 23 Jan 2009 18:56:17 +0000 (18:56 +0000)]
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
* platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 23 Jan 2009 18:53:20 +0000 (18:53 +0000)]
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing image-decoders in preparation for landing Skia changes on top.
* platform/image-decoders/skia: Added.
* platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
* platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
* platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
* platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
* platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
* platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
* platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
* platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 23 Jan 2009 16:57:16 +0000 (16:57 +0000)]
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23478
Add a test for application test resource loading failure
* http/tests/appcache/404-resource-expected.txt: Added.
* http/tests/appcache/404-resource.html: Added.
* http/tests/appcache/resources/404-resource.manifest: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 23 Jan 2009 16:18:13 +0000 (16:18 +0000)]
Build fix in RenderThemeGtk for RenderBox usage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 23 Jan 2009 16:07:37 +0000 (16:07 +0000)]
2009-01-23 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
data to be passed across threads.
No observable change in behavior, so no test.
* platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
* platform/network/FormData.h:
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
* platform/network/ResourceResponseBase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 23 Jan 2009 15:53:42 +0000 (15:53 +0000)]
2009-01-23 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23374
Add WorkerRunLoop to encapsulate message queue and timer heap.
This is first half (timer heap is added as separate patch).
* GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
* WebCore.vcproj/WebCore.vcproj: Same as above.
* WebCore.xcodeproj/project.pbxproj: Same as above
* dom/WorkerContext.cpp:
(WebCore::WorkerContext::postTask):
* dom/WorkerContext.h:
* dom/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
* dom/WorkerRunLoop.cpp: Added.
(WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
(WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
(WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
* dom/WorkerRunLoop.h: Added.
(WebCore::WorkerRunLoop::WorkerRunLoop):
* dom/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
* dom/WorkerThread.h:
(WebCore::WorkerThread::runLoop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Fri, 23 Jan 2009 15:02:38 +0000 (15:02 +0000)]
Redo previous patch trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 23 Jan 2009 14:50:54 +0000 (14:50 +0000)]
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23459
Workers are not properly terminated if execution hasn't begun yet
Doesn't affect observable behavior, so test case is not possible.
* dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
it couldn't be called earlier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 23 Jan 2009 13:29:42 +0000 (13:29 +0000)]
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
Make the test more robust by taking into account the platform-specific
cursor flashing time.
* tests/qwebframe/tst_qwebframe.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 23 Jan 2009 12:39:32 +0000 (12:39 +0000)]
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
[Qt] Fix the build after RenderBox refactoring in r40153.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::baselinePosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 23 Jan 2009 12:39:10 +0000 (12:39 +0000)]
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Alexey Proskuryakov.
Fix the build after RenderBox refactoring in r40153.
* plugins/PluginView.cpp:
(WebCore::PluginView::invalidateWindowlessPluginRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 23 Jan 2009 12:38:47 +0000 (12:38 +0000)]
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Simplify the assertion.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getWindowsContext):
(WebCore::GraphicsContext::releaseWindowsContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 07:19:48 +0000 (07:19 +0000)]
Land updated layout tests (progressions) after border/padding move.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 07:14:49 +0000 (07:14 +0000)]
2009-01-22 David Hyatt <hyatt@apple.com>
Move the border and padding methods from RenderObject to RenderBox.
Reviewed by Oliver Hunt
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesVertically):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::borderLeft):
(WebCore::InlineFlowBox::borderRight):
(WebCore::InlineFlowBox::paddingLeft):
(WebCore::InlineFlowBox::paddingRight):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paddingTop):
(WebCore::RenderBox::paddingBottom):
(WebCore::RenderBox::paddingLeft):
(WebCore::RenderBox::paddingRight):
(WebCore::RenderBox::calcHeight):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::containingBlockHeightForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteVerticalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderTop):
(WebCore::RenderBox::borderBottom):
(WebCore::RenderBox::borderLeft):
(WebCore::RenderBox::borderRight):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textBlockWidth):
(WebCore::RenderTextControl::calcHeight):
(WebCore::RenderTextControl::calcPrefWidths):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 05:13:22 +0000 (05:13 +0000)]
2009-01-22 David Hyatt <hyatt@apple.com>
Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
other margin functions that have to come along for the ride).
Reviewed by Oliver Hunt
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* editing/TextIterator.cpp:
(WebCore::shouldEmitExtraNewlineForNode):
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
(WebCore::InlineBox::renderBox):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::marginLeft):
(WebCore::InlineFlowBox::marginRight):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::handleCompactChild):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::calcInlinePrefWidths):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
(WebCore::RenderBox::hasHorizontalBordersOrPadding):
(WebCore::RenderBox::marginTop):
(WebCore::RenderBox::marginBottom):
(WebCore::RenderBox::marginLeft):
(WebCore::RenderBox::marginRight):
(WebCore::RenderBox::isSelfCollapsingBlock):
(WebCore::RenderBox::collapsedMarginTop):
(WebCore::RenderBox::collapsedMarginBottom):
(WebCore::RenderBox::isTopMarginQuirk):
(WebCore::RenderBox::isBottomMarginQuirk):
(WebCore::RenderBox::maxTopMargin):
(WebCore::RenderBox::maxBottomMargin):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
* rendering/RenderObject.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::lineHeight):
(WebCore::RenderSVGContainer::baselinePosition):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcHeight):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::baselinePosition):
* rendering/bidi.cpp:
(WebCore::getBorderPaddingMargin):
(WebCore::inlineWidth):
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::inlineFlowRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 23 Jan 2009 04:57:00 +0000 (04:57 +0000)]
Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
Rubber-stamped by Anders Carlsson.
Current versions of Xcode only respect it for C and Objective-C files,
and our code doesn't currently compile if it is applied to C++ and
Objective-C++ files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 04:30:47 +0000 (04:30 +0000)]
Fix build bustage on Gtk.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 04:07:34 +0000 (04:07 +0000)]
2009-01-22 David Hyatt <hyatt@apple.com>
Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
intrinsicPaddingBottom just be normal non-bitfield values.
Reviewed by Oliver Hunt
* rendering/RenderFlow.h:
(WebCore::RenderFlow::RenderFlow):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::updateWidth):
(WebCore::RenderTableCell::layout):
* rendering/RenderTableCell.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Jan 2009 04:06:06 +0000 (04:06 +0000)]
Update layout tests for table cell changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log