WebKit-https.git
10 years agoVersioning.
mrowe@apple.com [Tue, 19 Jan 2010 20:40:39 +0000 (20:40 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
kov@webkit.org [Tue, 19 Jan 2010 20:22:17 +0000 (20:22 +0000)]
    Reviewed by Xan Lopez.

        News items for 1.1.19.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for crash on large TransparencyWin allocation. The fix is
senorblanco@chromium.org [Tue, 19 Jan 2010 20:19:12 +0000 (20:19 +0000)]
Fix for crash on large TransparencyWin allocation.  The fix is
to leave m_layerValid false when the allocPixels of
OwnedBuffers::m_referenceBitmap fails.  Then TransparencyWin won't
attempt to use it.

Reviewed by Dimitri Glazkov.

Will be covered by a new unit test in Chromium's test_shell_tests (when
this is rolled into Chromium).

https://bugs.webkit.org/show_bug.cgi?id=33844

* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::initializeNewContext):
Early return when m_referenceBitmap or its pixels is NULL, leaving
m_layerValid false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 19 Jan 2010 19:48:36 +0000 (19:48 +0000)]
2010-01-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix for JIT with RVCT.

        Remove IMPORT statement; cti_vm_throw is already defined in JITStubs.h.
        Remove extra ')'.

        * jit/JITStubs.cpp:
        (JSC::ctiVMThrowTrampoline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 19 Jan 2010 19:31:49 +0000 (19:31 +0000)]
2010-01-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        video.networkState remains NETWORK_LOADING indefinitely when no <source> element was able to be loaded
        https://bugs.webkit.org/show_bug.cgi?id=33744

        Test: media/video-source-none-supported.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadNextSourceChild): Call waitForSourceChange if
            there are no valid source elements.
        (WebCore::HTMLMediaElement::waitForSourceChange): New, set networkState to NETWORK_NO_SOURCE.
        (WebCore::HTMLMediaElement::setNetworkState): Call waitForSourceChange if the movie
            hasn't reached HAVE_METADATA and there are no more <source> elements to try.
        * html/HTMLMediaElement.h: Declare waitForSourceChange.

2010-01-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        video.networkState remains NETWORK_LOADING indefinitely when no <source> element was able to be loaded
        https://bugs.webkit.org/show_bug.cgi?id=33744

        * media/video-source-none-supported-expected.txt: Added.
        * media/video-source-none-supported.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
kov@webkit.org [Tue, 19 Jan 2010 19:11:23 +0000 (19:11 +0000)]
    Reviewed by Xan Lopez.

        [GTK] More crashes related to the clipboard management
        https://bugs.webkit.org/show_bug.cgi?id=33746

        Pass the WebKitWebView object (which is a GObject, thus
        ref-counted) to the clipboard functions instead of passing the
        Page - this allows us to explicitely protect the object inbetween
        the clipboard call and its callbacks, which fixes the crash.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::respondToChangedSelection):
        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::getClipboardContentsCallback):
        (WebKit::clearClipboardContentsCallback):
        (WebKit::PasteboardHelperGtk::writeClipboardContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 19 Jan 2010 18:48:18 +0000 (18:48 +0000)]
2010-01-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=33408

        Implements an optimization to ignore fixed background images
        (i.e. background-attachment: fixed) when a page does not contain
        any fixed position elements so as to allow fast repaints (via bit
        blit) when scrolling a page.

        Currently, if a page has elements that specify either a fixed
        background or a fixed position then we perform a slow repaint
        (i.e disable blitting) so as to avoid rendering artifacts.
        However, on low-powered/mobile devices slow repaints can cause
        noticeable delays when scrolling a page with a fixed background
        image. By sacrificing support for fixed background images when
        there are no fixed elements on the page and with come care, we
        don't need to force slow repaints and can avoid rendering artifacts.
        Hence, on such devices we can improve the responsiveness of
        scrolling a page with a fixed background image.

        Note, this optimization is only enabled if the WebKit is built
        with FAST_MOBILE_SCROLLING enabled.

        Tests: fast/fast-mobile-scrolling/fixed-position-element.html
               fast/fast-mobile-scrolling/no-fixed-position-elements.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
        Disable fixed background attachment if we can blit on scroll.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):
2010-01-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=33408

        Tests that fixed background images are ignored when there are no
        fixed elements on a page and honored otherwise.

        Note, includes expected failure results for the test
        fast/fast-mobile-scrolling/no-fixed-position-elements.html, since
        the Mac and Windows ports do not support FAST_MOBILE_SCROLLING.

        * fast/fast-mobile-scrolling: Added.
        * fast/fast-mobile-scrolling/fixed-position-element.html: Added.
        * fast/fast-mobile-scrolling/no-fixed-position-elements.html: Added.
        * platform/mac/fast/fast-mobile-scrolling: Added.
        * platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
        * platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
        * platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
        * platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
        * platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
        Expected failure result since the Mac port does not enable FAST_MOBILE_SCROLLING.
        * platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
        Expected failure result since the Mac port does not enable FAST_MOBILE_SCROLLING.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Tue, 19 Jan 2010 18:29:44 +0000 (18:29 +0000)]
Windows build fix

* WebScriptWorld.cpp: Added missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild bustage fix. Land modified WebCore.base.exp file that includes export of curre...
hyatt@apple.com [Tue, 19 Jan 2010 18:26:14 +0000 (18:26 +0000)]
Build bustage fix.  Land modified WebCore.base.exp file that includes export of currentWorld().

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild bustage fix. Make sure the newly added scriptWorldForGlobalContext function...
hyatt@apple.com [Tue, 19 Jan 2010 18:24:20 +0000 (18:24 +0000)]
Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.

* Interfaces/IWebScriptWorld.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in Page::backForwardList when using History object from a detached window
beidson@apple.com [Tue, 19 Jan 2010 18:17:50 +0000 (18:17 +0000)]
Crash in Page::backForwardList when using History object from a detached window
<rdar://problem/7556252> and https://bugs.webkit.org/show_bug.cgi?id=33828

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/loader/stateobjects/state-api-on-detached-frame-crash.html

* page/History.cpp:
(WebCore::History::stateObjectAdded): Do an early return when detached. The spec
  doesn't really cover expected behavior and we already do something similar in
  other places, such as in History::length().

LayoutTests:

* fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt: Added.
* fast/loader/stateobjects/state-api-on-detached-frame-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to fix build.
sfalken@apple.com [Tue, 19 Jan 2010 18:11:28 +0000 (18:11 +0000)]
Touch WebKit.idl to fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/mac: Add an API to obtain the WebScriptWorld for a given JSGlobalContextRef.
hyatt@apple.com [Tue, 19 Jan 2010 17:53:23 +0000 (17:53 +0000)]
WebKit/mac: Add an API to obtain the WebScriptWorld for a given JSGlobalContextRef.

Reviewed by Adam Roben.

* WebView/WebScriptWorld.h:
* WebView/WebScriptWorld.mm:
(+[WebScriptWorld scriptWorldForGlobalContext:]):

WebKit/win: Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.

Reviewed by Adam Roben.

* Interfaces/IWebScriptWorld.idl:
* WebScriptWorld.cpp:
(WebScriptWorld::scriptWorldForGlobalContext):
* WebScriptWorld.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 19 Jan 2010 17:00:49 +0000 (17:00 +0000)]
2010-01-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by NOBODY (build fix).

        Revert r53467. Browser crashes on opening inspector if there
        are messages in console.

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::databaseForId):
        (WebCore::JSInjectedScriptHost::inspectedWindow):
        (WebCore::JSInjectedScriptHost::wrapCallback):
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::nodeForId):
        (WebCore::JSInjectedScriptHost::wrapObject):
        (WebCore::JSInjectedScriptHost::unwrapObject):
        (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
        (WebCore::JSInjectedScriptHost::selectDatabase):
        (WebCore::JSInjectedScriptHost::selectDOMStorage):
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptObject.h:
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::quarantineValue):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptObject.h:
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::quarantineValue):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::inspectedWindowCallback):
        (WebCore::V8InjectedScriptHost::wrapCallbackCallback):
        (WebCore::V8InjectedScriptHost::wrapObjectCallback):
        (WebCore::V8InjectedScriptHost::unwrapObjectCallback):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::wrapObject):
        (WebCore::InjectedScriptHost::unwrapObject):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        (WebCore::InspectorBackend::releaseWrapperObjectGroup):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::wrapObject):
        (WebCore::InspectorController::unwrapObject):
        (WebCore::InspectorController::releaseWrapperObjectGroup):
        (WebCore::InspectorController::resetInjectedScript):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addConsoleMessage):
        (WebCore::InspectorFrontend::pausedScript):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        (WebInspector.ConsoleView.prototype.completions):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._formatarray):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.parseRule):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.executeSql):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.setDocument):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        ():
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.dispatch):
        (InjectedScript.toggleStyleEnabled):
        (InjectedScript._serializeRule):
        (InjectedScript._serializeStyle):
        (InjectedScript.getProperties):
        (InjectedScript.setPropertyValue):
        (InjectedScript._evaluateAndWrap):
        (InjectedScript.getCallFrames):
        (InjectedScript._inspectObject):
        (InjectedScript._ensureCommandLineAPIInstalled):
        (InjectedScript._resolveObject):
        (InjectedScript._window):
        (InjectedScript._objectForId):
        (InjectedScript.createProxyObject):
        (InjectedScript.executeSql):
        (InjectedScript.executeSql.errorCallback):
        (InjectedScript.executeSql.queryTransaction):
        (Object.type):
        (String.prototype.escapeCharacters):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane):
        (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
        (WebInspector.MetricsSidebarPane.prototype.update):
        (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy):
        (WebInspector.ObjectProxy.getPropertiesAsync):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.pausedScript):
        (WebInspector.addConsoleMessage):
        (WebInspector.log.logMessage):
        (WebInspector.log):

2010-01-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by NOBODY (build fix).

        Revert r53467. Browser crashes on opening inspector if there
        are messages in console.

        * inspector/styles-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
steveblock@google.com [Tue, 19 Jan 2010 14:50:57 +0000 (14:50 +0000)]
Unreviewed build fix.

Fixes Snow Leopard build due to http://trac.webkit.org/changeset/53464

* Plugins/Hosted/WebHostedNetscapePluginView.mm: Modified. Import <WebCore/Bridge.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 19 Jan 2010 14:27:58 +0000 (14:27 +0000)]
2010-01-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Inject inspector script directly into the inspected context. All the
        communication between the script and the frontend is serialized into
        JSON strings. It allows to get rid of object quarantines in Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=32554

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::databaseForId):
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::nodeForId):
        (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
        (WebCore::JSInjectedScriptHost::selectDatabase):
        (WebCore::JSInjectedScriptHost::selectDOMStorage):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptObject.h:
        (WebCore::ScriptObject::scriptState):
        * bindings/js/ScriptValue.cpp:
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptObject.h:
        (WebCore::ScriptObject::scriptState):
        * bindings/v8/ScriptValue.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::setInjectedScriptSource):
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        (WebCore::InspectorBackend::releaseWrapperObjectGroup):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::injectedScriptForNodeId):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addConsoleMessage):
        (WebCore::InspectorFrontend::pausedScript):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.parseRule):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.executeSql):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode):
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.setDocument):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        ():
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess):
        (InjectedScriptAccess.getDefault):
        (get InjectedScriptAccess):
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane):
        (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
        * inspector/front-end/ObjectPropertiesSection.js:
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
        * inspector/front-end/ScriptsPanel.js:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.pausedScript):
        (WebInspector.addConsoleMessage):
        (WebInspector.log.logMessage):
        (WebInspector.log):

2010-01-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Inject inspector script directly into the inspected context. All the
        communication between the script and the frontend is serialized into
        JSON strings. It allows to get rid of object quarantines in Web Inspector.

        Refactor test case due to InjectedScriptAccess changes.

        https://bugs.webkit.org/show_bug.cgi?id=32554

        * inspector/styles-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 MORITA Hajime <morrita@gmail.com>
hamaji@chromium.org [Tue, 19 Jan 2010 14:04:21 +0000 (14:04 +0000)]
2010-01-19  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Shinichiro Hamaji.

        [Chromium] layout_test on linux fails on doubleclick-beside-cr-span.html

        Place larger margins before clicking position to grab certain words
        instead of clicking blank, whitespaces or tabs before that words.
        Note that widths of rendered tab characters are hard to predict,
        So such margins are particularly helpful with them.

        https://bugs.webkit.org/show_bug.cgi?id=33769

        * editing/selection/doubleclick-beside-cr-span.html:
          Fix to compute click position using actual character width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
steveblock@google.com [Tue, 19 Jan 2010 12:30:19 +0000 (12:30 +0000)]
Unreviewed build fix.

Fixes Windows build due to http://trac.webkit.org/changeset/53464
Updates WebCore.vcproj to reflect renaming of runtime.[cpp|h] to Bridge.[cpp|h]

No new tests, build fix only.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenames WebCore/bridge/runtime.[cpp|h] to WebCore/bridge/Bridge.[cpp|h]
steveblock@google.com [Tue, 19 Jan 2010 11:51:03 +0000 (11:51 +0000)]
Renames WebCore/bridge/runtime.[cpp|h] to WebCore/bridge/Bridge.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=33801

Reviewed by Adam Barth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION (r53450): 3 tests fail on Qt bot
ossy@webkit.org [Tue, 19 Jan 2010 11:04:08 +0000 (11:04 +0000)]
[Qt] REGRESSION (r53450): 3 tests fail on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=33834

Reviewed by Kenneth Rohde Christiansen.

* platform/qt/Skipped:
 - css1/box_properties/acid_test.html skipped.
 - fast/forms/textarea-scrollbar-height.html skipped.
* platform/qt/css1/font_properties/font-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Jan 2010 09:06:37 +0000 (09:06 +0000)]
2010-01-19  Xan Lopez  <xlopez@igalia.com>

        svg/custom/use-instanceRoot-event-bubbling.xhtml is flakey
        https://bugs.webkit.org/show_bug.cgi?id=33835

        Skip flakey test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Jan 2010 08:56:33 +0000 (08:56 +0000)]
2010-01-19  Xan Lopez  <xlopez@igalia.com>

        New baseline for failing test.

        * platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Copied from LayoutTests/platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: REGRESSION (52082): Crash on worker thread when reloading http:/...
ggaren@apple.com [Tue, 19 Jan 2010 08:39:04 +0000 (08:39 +0000)]
JavaScriptCore: REGRESSION (52082): Crash on worker thread when reloading radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826

Reviewed by Oliver Hunt.

This bug was caused by a GC-protected object being destroyed early by
Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
to GC-protected memory to be valid.

The solution is to do two passes of tear-down in Heap::destroy. The first
pass tears down all unprotected objects. The second pass ASSERTs that all
previously protected objects are now unprotected, and then tears down
all perviously protected objects. These two passes simulate the two passes
that would have been required to free a protected object during normal GC.

* API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.

* runtime/Collector.cpp:
(JSC::Heap::destroy): Moved ASSERTs to here.
(JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its
setter to the function that does the shrinking.
(JSC::Heap::freeBlocks): Implemented above algorithm.
(JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.

WebCore: REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826

Reviewed by Oliver Hunt.

Test: fast/workers/worker-gc2.html

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController): Removed some
ASSERTs that have moved to JavaScriptCore.

LayoutTests: REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826

Reviewed by Oliver Hunt.

Added a test for this edge case.

* fast/workers/resources/worker-gc2.js: Added.
(Dummy):
* fast/workers/worker-gc2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReverting r53455, breaks 2 javascriptcore tests.
barraclough@apple.com [Tue, 19 Jan 2010 08:25:22 +0000 (08:25 +0000)]
Reverting r53455, breaks 2 javascriptcore tests.

Reviewed by NOBODY (build fix).

JavaScriptCore:

* API/JSContextRef.cpp:
* runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrinkBlocks):

WebCore:

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):

LayoutTests:

* fast/workers/resources/worker-gc2.js: Removed.
* fast/workers/worker-gc2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForgot to add this test result.
ggaren@apple.com [Tue, 19 Jan 2010 08:14:13 +0000 (08:14 +0000)]
Forgot to add this test result.

* fast/workers/worker-gc2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Jan 2010 08:05:49 +0000 (08:05 +0000)]
2010-01-19  Xan Lopez  <xlopez@igalia.com>

        Skip tests generating new results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r53454, since it causes much sadness in this world.
barraclough@apple.com [Tue, 19 Jan 2010 07:22:51 +0000 (07:22 +0000)]
Revert r53454, since it causes much sadness in this world.

Patch by Gavin Barraclough <barraclough@apple.com> on 2010-01-18
Reviewed by NOBODY (build fix).

* runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
* wtf/StringHashFunctions.h:
(WTF::stringHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 19 Jan 2010 07:00:38 +0000 (07:00 +0000)]
2010-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
        https://bugs.webkit.org/show_bug.cgi?id=33826

        This bug was caused by a GC-protected object being destroyed early by
        Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
        to GC-protected memory to be valid.

        The solution is to do two passes of tear-down in Heap::destroy. The first
        pass tears down all unprotected objects. The second pass ASSERTs that all
        previously protected objects are now unprotected, and then tears down
        all perviously protected objects. These two passes simulate the two passes
        that would have been required to free a protected object during normal GC.

        * API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.

        * runtime/Collector.cpp:
        (JSC::Heap::destroy): Moved ASSERTs to here.
        (JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its
        setter to the function that does the shrinking.
        (JSC::Heap::freeBlocks): Implemented above algorithm.
        (JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.
2010-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
        https://bugs.webkit.org/show_bug.cgi?id=33826

        Test: fast/workers/worker-gc2.html

        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::~WorkerScriptController): Removed some
        ASSERTs that have moved to JavaScriptCore.
2010-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
        https://bugs.webkit.org/show_bug.cgi?id=33826

        Added a test for this edge case.

        * fast/workers/resources/worker-gc2.js: Added.
        (Dummy):
        * fast/workers/worker-gc2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33731
barraclough@apple.com [Tue, 19 Jan 2010 05:51:40 +0000 (05:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).

Patch by Gavin Barraclough <barraclough@apple.com> on 2010-01-18
Reviewed by Oliver Hunt.

This break the OS X Leaks tool.  Instead, free up some more bits from the refCount.

* runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
* wtf/StringHashFunctions.h:
(WTF::stringHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 19 Jan 2010 04:32:13 +0000 (04:32 +0000)]
2010-01-18  Daniel Bates  <dbates@webkit.org>

        https://bugs.webkit.org/show_bug.cgi?id=33089

        Unreviewed. Add expected results for Windows.

        * platform/win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 19 Jan 2010 03:10:41 +0000 (03:10 +0000)]
2010-01-18  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33089

        Implements all of the alphabetic CSS3 list-style-types as per
        section 4.4 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#alphabetic>.

        Test: fast/lists/w3-css3-list-styles-alphabetic.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Updated comment to include
        added list-style-types.
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added new list style types,
        alphabetized enums, and removed indent to conform to the WebKit Code Style Guidelines.
        * css/CSSValueKeywords.in:
        * inspector/front-end/CSSSourceSyntaxHighlighter.js:
        (WebInspector.CSSSourceSyntaxHighlighter): Added new list style types
        and alphabetized array valueKeywords.
        * platform/text/CharacterNames.h: Added constant ethiopicPrefaceColon.
        * rendering/RenderListMarker.cpp:
        (WebCore::toAlphabetic):
        (WebCore::listMarkerSuffix): Added.
        (WebCore::listMarkerText):
        (WebCore::RenderListMarker::paint): Modified to call WebCore::listMarkerSuffix.
        (WebCore::RenderListMarker::calcPrefWidths): Ditto.
        (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
        * rendering/style/RenderStyle.h:
        (WebCore::):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):
2010-01-18  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33089

        Tests that all of the alphabetic CSS3 list-style-types are supported.

        * fast/lists/w3-css3-list-styles-alphabetic.html: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 19 Jan 2010 03:08:24 +0000 (03:08 +0000)]
2010-01-18  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix misspelling of the word maximum in comment.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::maximum):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Sam Weinig.
mitz@apple.com [Tue, 19 Jan 2010 02:59:21 +0000 (02:59 +0000)]
Rubber-stamped by Sam Weinig.

<rdar://problem/7476957> REGRESSION (r49567): Business widget list does not line up: too tall due to line height rounding change

WebCore:

Reverted r49567.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::computedLineHeight):

LayoutTests:

Reverted r49567, but left in the test added in that revision, now with a failing result.

* css1/font_properties/font.html:
* fast/css/line-height-rounding-expected.txt:
* platform/mac/css1/font_properties/font-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-ln-03-d-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoves JSC-specific implementation of JavaString to a private implementation class.
steveblock@google.com [Tue, 19 Jan 2010 02:56:44 +0000 (02:56 +0000)]
Moves JSC-specific implementation of JavaString to a private implementation class.
https://bugs.webkit.org/show_bug.cgi?id=33558

Reviewed by Adam Barth.

Also modifies JavaField::name and JavaMethod::name to return const JavaString&, rather than UString::Rep*,
which is JSC-specific. This allows this code to be used with both JSC and V8, as required by Android.

No new tests, refactoring only.

* WebCore.xcodeproj/project.pbxproj: Modified. Added JavaStringJSC.h
* bridge/jni/jni_class.cpp: Modified.
(JavaClass::JavaClass): Modified. Updates call sites of JavaField::name and JavaMethod::name.
* bridge/jni/jni_runtime.h: Modified.
(JSC::Bindings::JavaString::JavaString): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::UTF8String): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::uchars): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::length): Modified. Pass through to implementation.
(JSC::Bindings::JavaString::operator UString): Modified. Pass through to implementation.
(JSC::Bindings::JavaField::name): Modified. Pass through to implementation.
(JSC::Bindings::JavaMethod::name): Modified. Pass through to implementation.
* bridge/jni/jsc/JavaStringJSC.h: Added.
(JSC::Bindings::JavaStringImpl::~JavaStringImpl):
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
(JSC::Bindings::JavaStringImpl::uString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Tue, 19 Jan 2010 02:53:16 +0000 (02:53 +0000)]
2010-01-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip an error after invalid blocks in a CSS expression.
        https://bugs.webkit.org/show_bug.cgi?id=33650

        * fast/css/parsing-error-recovery.html:
2010-01-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip an error after invalid blocks in a CSS expression.
        https://bugs.webkit.org/show_bug.cgi?id=33650

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33731
barraclough@apple.com [Tue, 19 Jan 2010 02:22:37 +0000 (02:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.

Reviewed by Darin Adler & Oliver Hunt.

These break the OS X Leaks tool.  Move the management of null-terminated copies
out from StringImpl to String, and use a bit stolen from the refCount to hold the
'InTable' flag.

* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/sql/SQLiteStatement.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::String::copyWithNullTermination):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 19 Jan 2010 02:17:28 +0000 (02:17 +0000)]
2010-01-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Rewrite SVG <use> support in a modern-fashion
        https://bugs.webkit.org/show_bug.cgi?id=33776

        Tests: svg/custom/relative-sized-deep-shadow-tree-content.xhtml
               svg/custom/relative-sized-shadow-tree-content.xhtml

        Fixes: svg/W3C-SVG-1.1/animate-elem-30-t.svg (animated circle sometimes takes wrong path)

        Rewrite <use> support in less intrusive way. Try hard to avoid recloning where possible, and do it lazily.
        Introduce RenderSVGShadowTreeRootContainer as special renderer for SVGUseElement, that now manages the
        render tree, instead of SVGUseElement manually hacking around it's own renderer from the DOM side.

        Instead of recloning the whole shadow tree for every attribute change (DOM setAttribute / SVG DOM changes / CSS changes / childrenChanged()...)
        just notify the RenderSVGShadowTreeRootContainer that it's supposed to reclone the tree upon the next updateFromElement() call.

        updateFromElement() is fired from SVGUseElement::attach() / recalcStyle(), as it's done for HTMLFormControlElement/HTMLMediaElement, thus
        lazily recloning the shadow tree if necessary.

        Animations for <use> elements was a real performance bottlenck as the tree got recloned on every attribute change. Reclones are _completly_
        avoided for animations now - the SVGAnim*Element classes already updated the instances of an element manually, though that resulted in a reclone
        nontheless, and thus killing performance. <use> elements can only be recloned through mutations of the elements that they reference to.
        For example referencing a <rect> element from a <use> element and scripting the <rect> element (setAttribute, or child tree mutations etc.).
        We reclone instead of trying to synchronize trees - as it's currenty implemented - because it's very hard to do it right.

        Any DOM / SVG DOM / CSS change on the <use> element don't reclone the tree anymore, this is a huge speed benefit.
        x/y attribute changes are correctly handled in the render tree now (by an additional local transformation), now percentual values work
        as expected, and resize on window changes - affecting lots of testcases.

        The <use> implementation is much safer now, not doing any mutations synchronously from svgAttributeChanged etc.
        Remove hack to force garbage collection on SVGElementInstance destruction - can't reproduce it anymore.

        * Android.mk: Add new files to build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/RenderSVGShadowTreeRootContainer.cpp: Added. This is the rendered now created by SVGUseElement.
        (WebCore::RenderSVGShadowTreeRootContainer::RenderSVGShadowTreeRootContainer):
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
        (WebCore::RenderSVGShadowTreeRootContainer::updateStyle): Used form SVGUseElement to request style recalculations for the shadow tree renderers
        (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement): Used from SVGUseElement attach/recalcStyle to eventually request shadow tree updates.
        (WebCore::RenderSVGShadowTreeRootContainer::styleDidChange): Used to propage style updates across shadow tree boundaries.
        * rendering/RenderSVGShadowTreeRootContainer.h: Added.
        (WebCore::RenderSVGShadowTreeRootContainer::markShadowTreeForRecreation): Marks the shadow tree for a reclone, next time updateFromElement is used.
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Take containerTranslation() into account, supplied by RenderSVGSDhadowTreeContainer.
        * rendering/SVGShadowTreeElements.cpp: Added. This is the root element of the SVG shadow tree residing as (hidden) child of SVGUseElement (DOM wise).
        (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
        (WebCore::SVGShadowTreeContainerElement::~SVGShadowTreeContainerElement):
        (WebCore::SVGShadowTreeContainerElement::containerTranslation): Used from calculateLocalTransform() to take x/y translation into account for shadow tree container elements.
        (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
        (WebCore::SVGShadowTreeRootElement::~SVGShadowTreeRootElement):
        (WebCore::SVGShadowTreeRootElement::attachElement): Used by RenderSVGShadowTreeRootContainer, instead of attach(), as we're a shadow tree root node.
        * rendering/SVGShadowTreeElements.h: Added. This is the root element of each SVG shadow sub-tree (whenever a <use> element is expanded in the shadow tree).
        (WebCore::SVGShadowTreeContainerElement::isShadowTreeContainerElement): Return true here.
        (WebCore::SVGShadowTreeContainerElement::setContainerOffset): Used from SVGUseElement to propagate x/y translation values set on <use> elements in the shadow tree.
        (WebCore::SVGShadowTreeRootElement::isShadowNode): Identify us as shadow node.
        (WebCore::SVGShadowTreeRootElement::shadowParentNode): Ditto. Return actual shadow parent node (== corresponding use element).
        * svg/SVGElement.cpp: Shrink size of all SVG*Elements, by removing the m_shadowParent parent. SVGShadowTreeRootElement is the new base class for shadow tree.
        (WebCore::SVGElement::SVGElement):
        (WebCore::SVGElement::eventParentNode): Call virtual shadowParentNode() method, instead of accessing m_shadowParent.
        * svg/SVGElement.h: Remove isShadowNode() / shadowParentNode() / setShadowParentNode().
        * svg/SVGElementInstance.cpp: Remove the hack, calling garbage collection before destruction. Can't reproduce this anymore, let's see what the bots say.
        (WebCore::SVGElementInstance::SVGElementInstance): Remove now unnecessary m_needsUpdate flag.
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Don't invalidate if instance updates are blocked (see SVGStyledElement changes)
        * svg/SVGElementInstance.h: Remove m_needsUpdate, and forgetWrapper() method.
        * svg/SVGGElement.h:
        (WebCore::SVGGElement::isShadowTreeContainerElement): Add new virtual method here returning false by default, SVGShadowTreeContainerElement will override it.
        * svg/SVGStyledElement.cpp: Remove gElementsWithInstanceUpdatesBlocked HashSet tracking the state of instancesUpdatesBlocked() per SVGStyledElement - make it a member variable.
        * svg/SVGStyledElement.h: Add inline getter/setters around m_instanceUpdatesBlocked.
        (WebCore::SVGStyledElement::instanceUpdatesBlocked):
        (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
        * svg/SVGUseElement.cpp: Full rewrite of <use> support, a detailed discussion would blow the ChangeLog - see short version above.
        (WebCore::SVGUseElement::SVGUseElement):
        (WebCore::SVGUseElement::instanceRoot):
        (WebCore::SVGUseElement::insertedIntoDocument):
        (WebCore::SVGUseElement::removedFromDocument):
        (WebCore::SVGUseElement::svgAttributeChanged):
        (WebCore::updateContainerOffset):
        (WebCore::SVGUseElement::updateContainerOffsets):
        (WebCore::SVGUseElement::recalcStyle):
        (WebCore::dumpInstanceTree):
        (WebCore::SVGUseElement::buildPendingResource):
        (WebCore::SVGUseElement::buildShadowAndInstanceTree):
        (WebCore::SVGUseElement::createRenderer):
        (WebCore::updateFromElementCallback):
        (WebCore::SVGUseElement::attach):
        (WebCore::SVGUseElement::detach):
        (WebCore::SVGUseElement::toClipPath):
        (WebCore::SVGUseElement::buildInstanceTree):
        (WebCore::SVGUseElement::handleDeepUseReferencing):
        (WebCore::SVGUseElement::buildShadowTree):
        (WebCore::SVGUseElement::expandUseElementsInShadowTree):
        (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
        (WebCore::SVGUseElement::instanceForShadowTreeElement):
        (WebCore::SVGUseElement::invalidateShadowTree):
        (WebCore::SVGUseElement::transferUseAttributesToReplacedElement):
        * svg/SVGUseElement.h:
        (WebCore::SVGUseElement::isPendingResource):
2010-01-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Rewrite SVG <use> support in a modern-fashion
        https://bugs.webkit.org/show_bug.cgi?id=33776

        Update some test results, after rewriting <use> support.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.checksum: Added.
        * platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Added.
        * platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
        * platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.checksum: Added.
        * platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png: Added.
        * platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
        * platform/mac/svg/custom/use-events-crash-expected.txt:
        * platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
        * platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
        * platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
        * platform/mac/svg/custom/use-recursion-1-expected.txt:
        * platform/mac/svg/custom/use-recursion-2-expected.txt:
        * platform/mac/svg/custom/use-recursion-3-expected.txt:
        * platform/mac/svg/custom/use-recursion-4-expected.txt:
        * platform/mac/svg/hixie/error/017-expected.txt:
        * platform/mac/svg/text/text-text-05-t-expected.checksum:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * svg/custom/relative-sized-deep-shadow-tree-content.xhtml: Added.
        * svg/custom/relative-sized-shadow-tree-content.xhtml: Added.
        * svg/text/text-text-05-t.svg: Remove possible race-condition, between selecting & dumping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 19 Jan 2010 01:49:42 +0000 (01:49 +0000)]
2010-01-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        HTMLInputElement::valueAsDate setter support for type=month.
        https://bugs.webkit.org/show_bug.cgi?id=33021

        Expose the following functions to be used by WebCore:
         - WTF::msToyear()
         - WTF::dayInYear()
         - WTF::monthFromDayInYear()
         - WTF::dayInMonthFromDayInYear()

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/DateMath.cpp:
        (WTF::msToYear): Remove "static inline".
        (WTF::dayInYear): Remove "static inline".
        (WTF::monthFromDayInYear): Remove "static inline".
        (WTF::dayInMonthFromDayInYear): Remove "static inline".
        * wtf/DateMath.h: Declare the above functions.

2010-01-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        HTMLInputElement::valueAsDate setter support for type=month.
        https://bugs.webkit.org/show_bug.cgi?id=33021

        Add setter tests to input-valueasdate-month.js, and update the
        expectation.

        * fast/forms/input-valueasdate-expected.txt:
        * fast/forms/input-valueasdate-month-expected.txt:
        * fast/forms/script-tests/input-valueasdate-month.js:
        * fast/forms/script-tests/input-valueasdate.js:

2010-01-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        HTMLInputElement::valueAsDate setter support for type=month.
        https://bugs.webkit.org/show_bug.cgi?id=33021

        Introduce ISODateTime::setMillisecondsSinceEpochForMonth() and
        toString() for the Month type, and HTMLInputElement::setValueAsDate()
        calls them.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValueAsDate):
        * html/ISODateTime.cpp:
        (WebCore::beforeGregorianStartDate):
        (WebCore::ISODateTime::addDay): Use beforeGregorianStartDate().
        (WebCore::ISODateTime::parseMonth): Use beforeGregorianStartDate().
        (WebCore::ISODateTime::setMillisecondsSinceEpochForDateInternal):
        (WebCore::ISODateTime::setMillisecondsSinceEpochForMonth):
        (WebCore::ISODateTime::toString): Implement only for the Month type.
        * html/ISODateTime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build by reverting the previous change.
darin@apple.com [Tue, 19 Jan 2010 01:19:37 +0000 (01:19 +0000)]
Fix build by reverting the previous change.

* runtime/UString.h: Rolled out the FastAllocBase base class.
It was making UString larger, and therefore JSString larger,
and too big for a garbage collection cell.

This raises the unpleasant possibility that many classes became
larger because we added the FastAllocBase base class. I am
worried about this, and it needs to be investigated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoScript attributes are copied and pasted, making cross-domain attacks possible (30019)
steveblock@google.com [Tue, 19 Jan 2010 01:12:43 +0000 (01:12 +0000)]
Script attributes are copied and pasted, making cross-domain attacks possible (30019)
<rdar://problem/6008809>
https://bugs.webkit.org/show_bug.cgi?id=30019

Patch by Enrica Casucci <enrica@apple.com> on 2010-01-18
Reviewed by Darin Adler.

When we create the document fragment from a markup string,
either to perform a paste operation or a drag and drop, we
want to remove all the event handlers and any attribute that contain
a value that leads to code execution.
The HTMLParser class is now aware of the needs of stripping these attributes.
I've modified the call to createMarkupString for every platform.

Test: editing/pasteboard/paste-noscript.html

* WebCore.base.exp:
* dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::setAttributeMap):
* dom/Element.h:
* dom/MappedAttributeEntry.h:
(WebCore::):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
* editing/markup.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
* html/HTMLElement.h:
* html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::parseToken):
* html/HTMLParser.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::parseHTMLDocumentFragment):
* html/HTMLTokenizer.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCF_HTML):
(WebCore::fragmentFromHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoScript attributes are copied and pasted, making cross-domain attacks possible (30019)
enrica@apple.com [Tue, 19 Jan 2010 01:07:49 +0000 (01:07 +0000)]
Script attributes are copied and pasted, making cross-domain attacks possible (30019)
<rdar://problem/6008809>
https://bugs.webkit.org/show_bug.cgi?id=30019

Reviewed by Darin Adler.

WebCore:

When we create the document fragment from a markup string,
either to perform a paste operation or a drag and drop, we
want to remove all the event handlers and any attribute that contain
a value that leads to code execution.
The HTMLParser class is now aware of the needs of stripping these attributes.
I've modified the call to createMarkupString for every platform.

Test: editing/pasteboard/paste-noscript.html

* WebCore.base.exp:
* dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::setAttributeMap):
* dom/Element.h:
* dom/MappedAttributeEntry.h:
(WebCore::):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
* editing/markup.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
* html/HTMLElement.h:
* html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser):
(WebCore::HTMLParser::parseToken):
* html/HTMLParser.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::parseHTMLDocumentFragment):
* html/HTMLTokenizer.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCF_HTML):
(WebCore::fragmentFromHTML):

WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Modified the call to createMarkupString.

LayoutTests:

* editing/pasteboard/paste-noscript-expected.txt: Added.
* editing/pasteboard/paste-noscript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<https://bugs.webkit.org/show_bug.cgi?id=33816>
sfalken@apple.com [Tue, 19 Jan 2010 01:05:47 +0000 (01:05 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=33816>
Crashes in Geolocation code due to refcounting, observer balance issues.

Reviewed by Sam Weinig.

Hold a ref to the GeoNotifier while dispatching a callback. The code was
copying a data member to avoid accessing a freed this ptr, but was still
using the this ptr.

Geolocation::removeObserver calls are not always balanced with addObserver.
Instead of asserting and continuing, don't try to remove non-existant
observers.

* page/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::timerFired): Protect notifier.
* page/GeolocationController.cpp:
(WebCore::GeolocationController::removeObserver): Change ASSERT into an if with early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Sam Weinig.
sfalken@apple.com [Tue, 19 Jan 2010 01:03:54 +0000 (01:03 +0000)]
Rubber-stamped by Sam Weinig.

Add missing export for Geolocation.

* WebKit.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 19 Jan 2010 00:53:39 +0000 (00:53 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33815
        Crash when using DOMTimer from a detached frame

        Test: fast/dom/Window/timer-null-script-execution-context.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        Make setTimer and setInterval raise an exception. It is not specified in HTML5, but both
        IE and Firefox do raise an exception in this situation, although different ones.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setTimeout): Raise INVALID_ACCESS_ERR if script execution context is
        null (meaning that the window is detached).
        (WebCore::DOMWindow::setInterval): Ditto.
        (WebCore::DOMWindow::clearTimeout): Silently return early if there is no script execution
        context.
        (WebCore::DOMWindow::clearInterval): Ditto.
        Raise INVALID_ACCESS_ERR if script execution context is null (meaning .

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 19 Jan 2010 00:50:58 +0000 (00:50 +0000)]
2010-01-18  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for UString class
        https://bugs.webkit.org/show_bug.cgi?id=27831

        Inherits the following class from FastAllocBase because it is
        instantiated by 'new' and no need to be copyable:

        class name     - instantiated at:
        classs UString - JavaScriptCore/runtime/UString.cpp:160

        * runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some ALWAYS_INLINE for key functions not inlined by some versions of GCC.
darin@apple.com [Tue, 19 Jan 2010 00:02:40 +0000 (00:02 +0000)]
Add some ALWAYS_INLINE for key functions not inlined by some versions of GCC.
rdar://problem/7553780

Patch by Evan Cheng <evan.cheng@apple.com> on 2010-01-18
Reviewed by Darin Adler.

* runtime/JSObject.h:
(JSC::JSObject::getPropertySlot): ALWAYS_INLINE both overloads.
* runtime/JSString.h:
(JSC::JSString::JSString): ALWAYS_INLINE the version that takes a UString.
* runtime/UString.h:
(JSC::operator==): ALWAYS_INLINE the version that compares two UString objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 18 Jan 2010 23:49:35 +0000 (23:49 +0000)]
2010-01-18  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Fix style in WebCore/bridge/jni/jsc/JavaInstanceJSC.[cpp|h]
        https://bugs.webkit.org/show_bug.cgi?id=33792

        No new tests, style fixes only.

        * bridge/jni/jni_runtime.cpp: Modified.
        (JavaField::dispatchValueFromInstance): Modified. Updated to use renamed JavaInstance::m_instance
        (JavaField::dispatchSetValueToInstance): Modified. Updated to use renamed JavaInstance::m_instance
        (JavaArray::JavaArray): Modified. Updated to use renamed JavaInstance::m_instance
        * bridge/jni/jni_runtime.h: Modified.
        (JSC::Bindings::JavaArray::javaArray): Modified. Updated to use renamed JavaInstance::m_instance
        * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Fixed style
        * bridge/jni/jsc/JavaInstanceJSC.h: Modified. Fixed style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tim Hatcher.
bweinstein@apple.com [Mon, 18 Jan 2010 23:14:03 +0000 (23:14 +0000)]
Rubber-stamped by Tim Hatcher.

Updated Windows results after r53424.

* platform/win/fast/css/zoom-body-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=30073
cmarrin@apple.com [Mon, 18 Jan 2010 23:09:22 +0000 (23:09 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=30073
        Moved reshape to HTMLCanvasElement::reset and have it always
        set the size to the canvas width and height attrs.

        This is not testable with LayoutTests, so I instead added logic
        to the demo at:

        https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/webkit/SpinningBox.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoffrey Garen.
ap@apple.com [Mon, 18 Jan 2010 22:51:22 +0000 (22:51 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=33813
        <rdar://problem/7545104> Crash when using DOMApplicationCache from a destroyed frame

        Test: http/tests/appcache/destroyed-frame.html

        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::scriptExecutionContext): Return null when there is no frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
mitz@apple.com [Mon, 18 Jan 2010 22:20:13 +0000 (22:20 +0000)]
REGRESSION (r53420): incomplete repaint of bottom of bugs.webkit.org comment field
https://bugs.webkit.org/show_bug.cgi?id=33809

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/trailing-floats-root-line-box-overflow.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Copy bottom overflow from the last
root box to the trailing floats box, which is becoming the last root box. This is
needed because painting code assumes that the last line in a block is the one with the
lowest overflow bottom.

LayoutTests:

* fast/repaint/trailing-floats-root-line-box-overflow-expected.checksum: Added.
* fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
* fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
* fast/repaint/trailing-floats-root-line-box-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed trivial buildfix. (r53429)
ossy@webkit.org [Mon, 18 Jan 2010 22:14:44 +0000 (22:14 +0000)]
[Qt] Unreviewed trivial buildfix. (r53429)

* WebCore.pri: missing XMLNS_NAMES added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 18 Jan 2010 22:12:12 +0000 (22:12 +0000)]
2010-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Removed unnecessary use of scriptExecutionContext() when creating a JS event listener.
        https://bugs.webkit.org/show_bug.cgi?id=33811

        This change simplifies a bunch of code, and also reduces
        the number of places that use the difficult-to-understand and possibly
        crashy-null scriptExecutionContext() idiom.

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSEventListener.h:
        (WebCore::createJSAttributeEventListener):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 18 Jan 2010 22:05:55 +0000 (22:05 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33787
        Add constants for more XML strings

        No change in functionality, so no tests.

        * WebCore/xml/xmlnsattrs.in: Added a new file for xmlns namespace and attribute -
        XMLNames.{h,cpp} are auto-generated, and I dodn't see a reasonable way to extend it.

        * platform/text/AtomicString.cpp: (WebCore::AtomicString::init):
        * platform/text/AtomicString.h:
        Added atomic strings for "xml" and "xmlns".

        * page/Frame.cpp: (WebCore::Frame::Frame): Call XMLNSNames::init().

        * dom/Attr.cpp: (WebCore::Attr::setPrefix):
        * dom/Document.cpp:
        (WebCore::Document::hasPrefixNamespaceMismatch):
        (WebCore::Document::createAttributeNS):
        * dom/Node.cpp:
        (WebCore::Node::checkSetPrefix):
        (WebCore::Node::isDefaultNamespace):
        (WebCore::Node::lookupNamespaceURI):
        (WebCore::Node::lookupNamespacePrefix):
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::handleElementNamespaces):
        * editing/markup.cpp:
        (WebCore::shouldAddNamespaceAttr):
        (WebCore::appendNamespace):
        * xml/XPathStep.cpp:
        (WebCore::XPath::nodeMatchesBasicTest):
        (WebCore::XPath::Step::nodesInAxis):
        Use the new constants.

        * Android.derived.mk:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added the new files to projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix !ENABLE(3D_CANVAS) build.
andersca@apple.com [Mon, 18 Jan 2010 22:04:20 +0000 (22:04 +0000)]
Fix !ENABLE(3D_CANVAS) build.

* rendering/RenderLayerBacking.cpp:
(WebCore::is3DCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Adam Roben.
ap@apple.com [Mon, 18 Jan 2010 21:58:07 +0000 (21:58 +0000)]
    Rubber-stamped by Adam Roben.

        Change a newly added WebSocket test to work on Windows.

        * websocket/tests/multiple-connections.html: Decrease the number of simultaneous connections
        from 100 to 50. On Windows buildbot, only ~70 connections are allowed for some reason - but
        we only need much fewer to compare to HTTP simultaneous connection limit anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip test introduced in r53423 because of missing layoutTestController.setDomain...
ossy@webkit.org [Mon, 18 Jan 2010 21:54:37 +0000 (21:54 +0000)]
[Qt] Skip test introduced in r53423 because of missing layoutTestController.setDomainRelaxationForbiddenForURLScheme()

* platform/qt/Skipped: http/tests/security/setDomainRelaxationForbiddenForURLScheme.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add platform dependent expected file because of different font size.
ossy@webkit.org [Mon, 18 Jan 2010 21:47:58 +0000 (21:47 +0000)]
[Qt] Add platform dependent expected file because of different font size.

Reviewed by Ariya Hidayat.

* platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Copied from LayoutTests/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdjust the scroll position when doing a full page zoom, so the content
timothy@apple.com [Mon, 18 Jan 2010 21:30:35 +0000 (21:30 +0000)]
Adjust the scroll position when doing a full page zoom, so the content
stays in relatively the same position.

<rdar://problem/6150099> Zooming should keep the page content in the same place

Reviewed by Oliver Hunt.

* page/Frame.cpp:
(WebCore::Frame::setZoomFactor): Apply the zoom percent difference to
the scroll position, only when doing a full page zoom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebKit SPI to disallow setting document.domain from certain URL schemes
aroben@apple.com [Mon, 18 Jan 2010 21:26:39 +0000 (21:26 +0000)]
Add WebKit SPI to disallow setting document.domain from certain URL schemes

Fixes <http://webkit.org/b/33806> <rdar://problem/7552837> Would like
API to disallow setting of document.domain for pages with certain URL
schemes

Reviewed by Sam Weinig.

WebCore:

Add SecurityOrigin::{set,is}DomainRelaxationForbiddenForURLScheme and
respect it

Test: http/tests/security/setDomainRelaxationForbiddenForURLScheme.html

* WebCore.base.exp: Export
SecurityOrigin::setDomainRelaxationForbiddenForURLScheme.

* dom/Document.cpp:
(WebCore::Document::setDomain): If domain relaxation is forbidden for
our security origin's scheme, throw an exception and don't allow
the domain to be set.

* page/SecurityOrigin.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation): Added. Returns a
global set of schemes.
(WebCore::SecurityOrigin::setDomainRelaxationForbiddenForURLScheme):
Add or remove the scheme to schemesForbiddenFromDomainRelaxation, as
appropriate.
(WebCore::SecurityOrigin::isDomainRelaxationForbiddenForURLScheme):
Returns true if the scheme is in schemesForbiddenFromDomainRelaxation.

* page/SecurityOrigin.h: Added
{set,is}DomainRelaxationForbiddenForURLScheme.

WebKit/mac:

Add +[WebView _setDomainRelaxationForbidden:forURLScheme:]

* WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
* WebView/WebViewPrivate.h:
Added. Calls through to SecurityOrigin.

WebKit/win:

Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme

* Interfaces/IWebViewPrivate.idl: Added
setDomainRelaxationForbiddenForURLScheme.

* Interfaces/WebKit.idl: Touched to force a build.

* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
* WebView.h:
Added. Calls through to SecurityOrigin.

WebKitTools:

Add LayoutTestController support for calling new WebKit SPI to
disallow setting document.domain

* DumpRenderTree/LayoutTestController.cpp:
(setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
through to LayoutTestController.
(LayoutTestController::staticFunctions): Added
setDomainRelaxationForbiddenForURLScheme.

* DumpRenderTree/LayoutTestController.h: Added
setDomainRelaxationForbiddenForURLScheme.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
Added. Calls through to WebKit.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
Stubbed out.

LayoutTests:

Add tests for new WebKit SPI to disallow setting document.domain

* http/tests/security/setDomainRelaxationForbiddenForURLScheme-expected.txt: Added.
* http/tests/security/setDomainRelaxationForbiddenForURLScheme.html: Added.

* platform/gtk/Skipped: Skip the new test since WebKitGtk doesn't have
this API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Csaba Osztrogon√°c <ossy@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 21:18:38 +0000 (21:18 +0000)]
2010-01-18  Csaba Osztrogon√°c  <ossy@webkit.org>

        Reviewed by Darin Adler.

        Delete dftables-xxxxxxxx.in files automatically.
        https://bugs.webkit.org/show_bug.cgi?id=33796

        * pcre/dftables: unlink unnecessary temporary file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAddress review comments on the last change
mitz@apple.com [Mon, 18 Jan 2010 20:57:17 +0000 (20:57 +0000)]
Address review comments on the last change

* rendering/TrailingFloatsRootInlineBox.h:
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6892207> REGRESSION (Safari 4): Menus at sciencedirect.com push the...
mitz@apple.com [Mon, 18 Jan 2010 20:55:25 +0000 (20:55 +0000)]
<rdar://problem/6892207> REGRESSION (Safari 4): Menus at sciencedirect.com push the main article context down the page
<rdar://problem/7546035> Second right floated image misplacment
https://bugs.webkit.org/show_bug.cgi?id=33245

Reviewed by Darin Adler.

WebCore:

Test: fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2.html

When the last line of a block contains a line break and there are floats
after the line break, it is incorrect to put those floats in the last line's
floats vector (along with floats from before the break). Instead, create
an additional line box (a TrailingFloatsRootInlineBox) and put those floats
in its floats vector.

* WebCore.vcproj/WebCore.vcproj: Added TrailingFloatsRootInlineBox.h
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markLinesDirtyInVerticalRange): Added an optional
parameter, which is the highest line to dirty.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Create a TrailingFloatsRootInlineBox
for the floats occurring after the line break on the last line.
(WebCore::RenderBlock::determineStartPosition): Prevent dirtying of lines
above the first dirty line.
* rendering/TrailingFloatsRootInlineBox.h: Added.
(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox): Call
setHasVirtualHeight().
(WebCore::TrailingFloatsRootInlineBox::virtualHeight): Return 0.

LayoutTests:

* fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2.html: Added.
* fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.checksum: Added.
* fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Added.
* fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 18 Jan 2010 19:56:26 +0000 (19:56 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33804
        Test that WebSocket is not subject to HTTP connection limit

        * websocket/tests/multiple-connections-expected.txt: Added.
        * websocket/tests/multiple-connections.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEeeep! reverting r53416 & r53417, more to be done to fix windows.
barraclough@apple.com [Mon, 18 Jan 2010 19:44:50 +0000 (19:44 +0000)]
Eeeep! reverting r53416 & r53417, more to be done to fix windows.

Reviewed by NOBODY (build fix).

* WebCore.base.exp:
* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/sql/SQLiteStatement.h:
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::String::charactersWithNullTermination):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::operator delete):
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::createGlobalData):
* storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* platform/win/ClipboardUtilitiesWin.cpp:
barraclough@apple.com [Mon, 18 Jan 2010 19:40:44 +0000 (19:40 +0000)]
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::createGlobalData):

Reviewed by NOBODY (windows build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33731
barraclough@apple.com [Mon, 18 Jan 2010 19:27:50 +0000 (19:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.

Reviewed by Darin Adler.

These break the OS X Leaks tool.  Move the management of null-terminated copies
out from StringImpl to String, and use a bit stolen from the refCount to hold the
'InTable' flag.

* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/sql/SQLiteStatement.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::String::copyWithNullTermination):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Made root compositing layer scroll rather than scroll parent.
cmarrin@apple.com [Mon, 18 Jan 2010 18:48:34 +0000 (18:48 +0000)]
    Made root compositing layer scroll rather than scroll parent.
        https://bugs.webkit.org/show_bug.cgi?id=32279

        There's some general cleanup here so the frames, bounds and
        positions of all the associated layers are correct.
        I also changed API of setScrollFrame to use an IntRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Jan 2010 18:36:26 +0000 (18:36 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Roben.

        Rename patches-to-commit to patches-in-commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=33789

        The command really lists the patches in the commit-queue not all the
        patches that are pending-commit (as the FIXME commands).

        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/queries_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Mon, 18 Jan 2010 18:31:21 +0000 (18:31 +0000)]
2010-01-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Timeline panel scrolling speed can be 2 times faster.
        https://bugs.webkit.org/show_bug.cgi?id=33794

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._scheduleRefresh):
        (WebInspector.TimelinePanel.prototype._refreshRecords):
        (WebInspector.TimelineCalculator):
        (WebInspector.TimelineCalculator.prototype.calculateWindow):
        (WebInspector.TimelineCalculator.prototype.reset):
        (WebInspector.TimelineCalculator.prototype.updateBoundaries):
        (WebInspector.TimelineRecordGraphRow.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 18 Jan 2010 18:15:24 +0000 (18:15 +0000)]
2010-01-18  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Moves JSC-specific version of JavaInstance from bridge/jni/jni_instance to bridge/jni/jsc/JavaInstanceJSC
        https://bugs.webkit.org/show_bug.cgi?id=33672

        No new tests, refactoring only.

        * Android.jscbindings.mk: Modified. Removed jni_instance.cpp and added JavaInstanceJSC.cpp
        * GNUmakefile.am: Modified. Removed jni_instance.h and added JavaInstanceJSC.h
        * WebCore.xcodeproj/project.pbxproj: Modified. Removed jni_instance.[cpp|h] and added JavaInstanceJSC.[cpp|h]
        * bindings/js/ScriptControllerMac.mm: Modified. Includes JavaInstanceJSC.h
        * bridge/jni/jni_instance.cpp: Removed.
        * bridge/jni/jni_instance.h: Removed.
        * bridge/jni/jni_runtime.h: Modified. Includes JavaInstanceJSC.h
        * bridge/jni/jsc/JavaInstanceJSC.cpp: Copied from WebCore/bridge/jni/jni_instance.cpp.
        * bridge/jni/jsc/JavaInstanceJSC.h: Copied from WebCore/bridge/jni/jni_instance.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify image decoders slightly by using OwnPtr instead of raw pointers
pkasting@chromium.org [Mon, 18 Jan 2010 17:46:39 +0000 (17:46 +0000)]
Simplify image decoders slightly by using OwnPtr instead of raw pointers
and eliminating a basically-useless wrapper class in the GIF decoder.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::~ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::failRead):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::~GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
(WebCore::JPEGImageDecoder::~JPEGImageDecoder):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::~PNGImageDecoder):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::decode):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/png/PNGImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDataTransfer interface broken on Windows--types member is always undefined, and getDa...
aroben@apple.com [Mon, 18 Jan 2010 17:20:01 +0000 (17:20 +0000)]
DataTransfer interface broken on Windows--types member is always undefined, and getData() does not work.

https://bugs.webkit.org/show_bug.cgi?id=30527

Patch by Daniel Cheng <dcheng@google.com> on 2010-01-18
Reviewed by Adam Roben.

WebCore:

* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat): pass FORMATETC as a const ref.
(WebCore::ClipboardWin::types): fix calls to IEnumFORMATETC.
(WebCore::ClipboardWin::hasData): fix calls to IEnumFORMATETC.

LayoutTests:

* fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Updated test expectations.
* fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added test cases.
* platform/win/Skipped: Re-enabled fast/events/drag-and-drop-dataTransfer-types-nocrash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Mon, 18 Jan 2010 16:58:16 +0000 (16:58 +0000)]
2010-01-18  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Don't show Profiles welcome screen on panel switch,
        if a profile view is shown.

        https://bugs.webkit.org/show_bug.cgi?id=33799

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Force qmake to generate a single makefile for DerivedSources.pro
vestbo@webkit.org [Mon, 18 Jan 2010 15:11:06 +0000 (15:11 +0000)]
[Qt] Force qmake to generate a single makefile for DerivedSources.pro

Reviewed by Simon Hausmann.

JavaScriptCore:

* DerivedSources.pro:

WebCore:

* DerivedSources.pro:

WebKitTools:

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up use of /useenv when invoking Visual C++
aroben@apple.com [Mon, 18 Jan 2010 15:05:57 +0000 (15:05 +0000)]
Clean up use of /useenv when invoking Visual C++

This change reverts things to their pre-r49485 state. That revision
(and, subsequently, r49664 and r51788) started passing /useenv to
Visual C++, even in cases where we don't want to do so (such as when
invoking Visual C++ Express), in the name of making the Chromium build
work. Now that Chromium isn't using buildVisualStudioProject or
pdevenv, we can put things back they way they were.

Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
(due to /useenv flag)

Reviewed by Sam Weinig.

* Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
script anymore.
* Scripts/webkitdirs.pm:
(buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
care of this itself, and we don't want to pass /useenv when not using
pdevenv (e.g., when using VC++ Express, because that will cause it to
ignore the Platform SDK).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Jonathan Dixon <joth@chromium.org>
eric@webkit.org [Mon, 18 Jan 2010 14:37:01 +0000 (14:37 +0000)]
2010-01-18  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Adam Barth.

        Add support for enabling navigator.geolocation at runtime in the V8 bindings.
        Adds the [EnabledAtRuntime] modifier to the navigator IDL.
        https://bugs.webkit.org/show_bug.cgi?id=33467

        * WebCore.gypi:
        * bindings/v8/RuntimeEnabledFeatures.cpp:
        * bindings/v8/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
        (WebCore::RuntimeEnabledFeatures::geolocationEnabled):
        * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
        (WebCore::V8Navigator::GeolocationEnabled):
        * page/Navigator.cpp:
        (WebCore::Navigator::geolocation):
        * page/Navigator.idl:
2010-01-18  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Adam Barth.

        Add support for enabling navigator.geolocation at runtime in the V8 bindings.
        Adds the [EnabledAtRuntime] modifier to the navigator IDL.
        https://bugs.webkit.org/show_bug.cgi?id=33467

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableGeolocation):
        (WebKit::WebRuntimeFeatures::isGeolocationEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Mon, 18 Jan 2010 14:20:51 +0000 (14:20 +0000)]
2010-01-18  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Improve Resources panel performance for lots of resources

        DOM properties are extracted into const's, comparisons are faster.
        https://bugs.webkit.org/show_bug.cgi?id=33790

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.CompareByStartTime):
        (WebInspector.Resource.CompareByResponseReceivedTime):
        (WebInspector.Resource.CompareByEndTime):
        (WebInspector.Resource.CompareByDuration):
        (WebInspector.Resource.CompareByLatency):
        (WebInspector.Resource.CompareBySize):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceGraph.prototype.refreshLabelPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 14:05:03 +0000 (14:05 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch land-safely should obsolete old patches
        https://bugs.webkit.org/show_bug.cgi?id=33788

        When posting a commit-queue+ patch with land-safely, we should
        obsolete the old patches on the bug.  They're really confusing
        because the main use case is to address reviewer feedback on a
        previous patch.

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 13:49:30 +0000 (13:49 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        webkit-patch should authenticate more often
        https://bugs.webkit.org/show_bug.cgi?id=33701

        This makes it easier to work with security patches.

        * Scripts/webkitpy/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Daniel Bates <dbates@rim.com>
eric@webkit.org [Mon, 18 Jan 2010 13:33:41 +0000 (13:33 +0000)]
2010-01-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33726

        Following up on changes made with respect to bug #33498, we should
        fix the the style errors found by the style bot.

        Moreover, this fixes all the style errors found by check-webkit-style
        except the use of an underline in the variable name _niflags. We should
        fix this in a second run through for all the other variables names that
        contain an underline because there are many.

        No functionality was changed. So, no new tests.

        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::create):
        (WebCore::SVGRenderStyle::copy):
        (WebCore::SVGRenderStyle::operator!=):
        (WebCore::SVGRenderStyle::hasStroke):
        (WebCore::SVGRenderStyle::hasFill):
        (WebCore::SVGRenderStyle::InheritedFlags::operator==):
        (WebCore::SVGRenderStyle::InheritedFlags::operator!=):
        (WebCore::SVGRenderStyle::NonInheritedFlags::operator==):
        (WebCore::SVGRenderStyle::NonInheritedFlags::operator!=):
        (WebCore::SVGRenderStyle::NonInheritedFlags::):
        (WebCore::SVGRenderStyle::):
        (WebCore::SVGRenderStyle::setBitDefaults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Android] DOMWrapperMap::Visitor needs virtual destructor
benm@google.com [Mon, 18 Jan 2010 12:54:08 +0000 (12:54 +0000)]
[Android] DOMWrapperMap::Visitor needs virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=33675

Patch by Andrei Popescu <andreip@google.com> on 2010-01-18
Reviewed by Adam Barth.

Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.

No new tests needed, functionality not changed.

* bindings/v8/V8DOMMap.h:
(WebCore::DOMWrapperMap::Visitor::~Visitor): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Gustavo Noronha Silva.
ossy@webkit.org [Mon, 18 Jan 2010 12:14:49 +0000 (12:14 +0000)]
Rubber-stamped by Gustavo Noronha Silva.

Rolling out r53391 and r53392 because of random crashes on buildbots.
https://bugs.webkit.org/show_bug.cgi?id=33731

* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* jit/JIT.cpp:
(JSC::JIT::unlinkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
* runtime/UString.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
* wtf/StringHashFunctions.h:
(WTF::stringHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Jan 2010 10:13:39 +0000 (10:13 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        style checker needs to know about GObject-specific requirements
        inside WebCore/bindings/gobject/
        https://bugs.webkit.org/show_bug.cgi?id=33606

        Add an exception to the underscore rule for certain
        GObject-specific names.

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Jan 2010 10:13:01 +0000 (10:13 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Shinichiro Hamaji.

        [check-webkit-style] does understand ResourceHandleWin.h
        https://bugs.webkit.org/show_bug.cgi?id=32975

        I'm not 100% convinced this fix is correct, but without more examples,
        it's hard to generalize.  We can always generalize the fix in the
        future.

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build with strict gcc and RVCT versions: It's not legal to cast a
hausmann@webkit.org [Mon, 18 Jan 2010 09:54:51 +0000 (09:54 +0000)]
Fix the build with strict gcc and RVCT versions: It's not legal to cast a
pointer to a function to a void* without an intermediate cast to a non-pointer
type. A cast to a ptrdiff_t inbetween fixes it.

Reviewed by Kenneth Rohde Christiansen.

* runtime/JSString.h:
(JSC::Fiber::JSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Jan 2010 09:29:05 +0000 (09:29 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix.

        * Scripts/webkitpy/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Jan 2010 09:15:35 +0000 (09:15 +0000)]
2010-01-18  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Actually make land-safely mark commit-queue+ as
        discussed with Eric.

        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/steps/postdiffforcommit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Symbian build fix.
hausmann@webkit.org [Mon, 18 Jan 2010 09:02:18 +0000 (09:02 +0000)]
Unreviewed Symbian build fix.

If we don't link with def files, then we have to pass EXPORTUNFROZEN,
so that the build system still creates the .dso files in
release/armv5/lib and we can actually link against the created QtWebKit
dlls.

Thanks Iain for the help!

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Eric Seidel.
ossy@webkit.org [Mon, 18 Jan 2010 07:47:08 +0000 (07:47 +0000)]
Rubber-stamped by Eric Seidel.

[Qt] Platform dependent expected file added for r53388. (similar to original one, only styles differ)
https://bugs.webkit.org/show_bug.cgi?id=33784 (need to unify path dumping)

* platform/qt/svg/custom/transformedMaskFails-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33731
barraclough@apple.com [Mon, 18 Jan 2010 07:36:45 +0000 (07:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).

Reviewed by Oliver Hunt.

This break the OS X Leaks tool.  Instead, free up some more bits from the refCount.

* runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
* wtf/StringHashFunctions.h:
(WTF::stringHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33731
barraclough@apple.com [Mon, 18 Jan 2010 07:28:53 +0000 (07:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.

Reviewed by Oliver Hunt.

These break the OS X Leaks tool.  Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.

* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* jit/JIT.cpp:
(JSC::JIT::unlinkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Srinidhi Shreedhara <srinidhi.shreedhara@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 18 Jan 2010 05:41:52 +0000 (05:41 +0000)]
2010-01-17  Srinidhi Shreedhara  <srinidhi.shreedhara@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] [Symbian] SetWindow call in npapi plugin does not happen when the cooridnates are negative
        https://bugs.webkit.org/show_bug.cgi?id=33573

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Remove tests for negative
        coordinates for early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 18 Jan 2010 04:53:26 +0000 (04:53 +0000)]
2010-01-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [Chromium] Remove an old runFileChooser() method.
        https://bugs.webkit.org/show_bug.cgi?id=33778

        Chromium code switched to new runFileChooser() introduced by
        r53269. The old one is not needed anymore.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::runOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Jan 2010 03:59:54 +0000 (03:59 +0000)]
2010-01-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r52449): SVG mask wrongly clipped when not at origin for recent nightly build
        https://bugs.webkit.org/show_bug.cgi?id=33782

        Testcase for a mask containing transformed elements

        * platform/mac/svg/custom/transformedMaskFails-expected.png: Added.
        * svg/custom/transformedMaskFails-expected.txt: Added.
        * svg/custom/transformedMaskFails.svg: Added.
2010-01-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r52449): SVG mask wrongly clipped when not at origin for recent nightly build
        https://bugs.webkit.org/show_bug.cgi?id=33782

        Test: svg/custom/transformedMaskFails.svg

        When computing the bounds for elements in a mask, we iterate through
        all of our children requesting their repaint bounds using
        repaintRectInLocalCoordinates(), but we were not converting that
        rect into our own coordinate system, thus leading to an incorrect
        repaint rect.  This patch simply adds the missing localToParent
        transform.

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 03:28:09 +0000 (03:28 +0000)]
2010-01-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        style-queue complains about one-line macros that include multiple statements
        https://bugs.webkit.org/show_bug.cgi?id=33173

        Add an exception for multiple statements on a line that starts a macro.

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 03:11:47 +0000 (03:11 +0000)]
2010-01-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        [check-webkit-style] qt unit testing false positives
        https://bugs.webkit.org/show_bug.cgi?id=32833

        Exempt the Qt API and unit tests from the style checker.

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Mon, 18 Jan 2010 02:58:04 +0000 (02:58 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 18 Jan 2010 02:47:00 +0000 (02:47 +0000)]
2010-01-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Avoid slow access to AX objects on attribute access when AX is off
        https://bugs.webkit.org/show_bug.cgi?id=33779

        ~4% Dromaeo attributes test speedup

        * dom/Element.cpp:
        (WebCore::Element::updateAfterAttributeChanged): Don't do expensive lookup of
        AX object cache unless accessibility is on and an AX-related attribute is
        changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 18 Jan 2010 02:39:12 +0000 (02:39 +0000)]
2010-01-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        style-check script reports loads of errors on gtk2drawing.c
        https://bugs.webkit.org/show_bug.cgi?id=33771

        Exempt WebCore/platform/gtk/gtk2drawing.c and
        WebCore/platform/gtk/gtk2drawing.h from style checks.

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53383 268f45cc-cd09-0410-ab3c-d52691b4dbfc