WebKit-https.git
8 years ago[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
commit-queue@webkit.org [Wed, 14 Mar 2012 21:56:46 +0000 (21:56 +0000)]
[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
https://bugs.webkit.org/show_bug.cgi?id=81082

Source/WebCore:

Don't return an invalid JSValue. Check if the ScriptValue
has no value and return undefined in that case.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

Updated test: inspector/console/command-line-api.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):

LayoutTests:

Test for an undefined inspectedObject.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, mark two compositing tests as passing.
enne@google.com [Wed, 14 Mar 2012 21:43:20 +0000 (21:43 +0000)]
[chromium] Unreviewed, mark two compositing tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=75568

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove canRecoverFromContextLoss attribute, it's unused
jamesr@google.com [Wed, 14 Mar 2012 21:42:28 +0000 (21:42 +0000)]
[chromium] Remove canRecoverFromContextLoss attribute, it's unused
https://bugs.webkit.org/show_bug.cgi?id=81158

Reviewed by Stephen White.

Source/WebCore:

Canvas accelerated no longer depends on the canRecoverFromContextLoss attribute after r110716.

* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::get):

Source/WebKit/chromium:

Deletes the canRecoverFromContextLoss attribute from WebCore::GraphicsContext3D::Attributes. This is still left in
WebGraphicsContext3D::Attributes, since chromium-side code still references it.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOpening a URL in a MediaDocument does not propagate MIME type info to media element
jer.noble@apple.com [Wed, 14 Mar 2012 21:34:23 +0000 (21:34 +0000)]
Opening a URL in a MediaDocument does not propagate MIME type info to media element
https://bugs.webkit.org/show_bug.cgi?id=81148

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/media-document.html

Pass through the mime type from the DocumentLoader into the <source type=""> attribute of the
generated video element.

* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

* http/tests/media/media-document-expected.txt: Added.
* http/tests/media/media-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix accelerated Canvas2D with threaded compositing.
senorblanco@chromium.org [Wed, 14 Mar 2012 21:27:48 +0000 (21:27 +0000)]
[chromium] Fix accelerated Canvas2D with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=80998

Reviewed by James Robinson.

Source/WebCore:

Covered by unit tests Canvas2DLayerChromiumTest and
TreeSynchronizerTest.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore):
Delay creation of the front texture for double-buffering until the
first call to paintContentsIfDirty().
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
Remove setTextureManager() and setLayerTreeHost(), since their job
has been subsumed by paintContentsIfDirty().
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
Perform an early-out if the passed-in layer is NULL.

Source/WebKit/chromium:

* tests/Canvas2DLayerChromiumTest.cpp:
Instantiate a CCLayerTreeHost, so that Canvas2DLayerChromium can
retrieve its texture manager.  Also move the test into the unnamed
namespace -- since it's already using WebCore, there's little reason for
it to also be in the namespace.
* tests/TreeSynchronizerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):
Add a new test for trying to synchronize NULL tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ARMv7 work again
oliver@apple.com [Wed, 14 Mar 2012 21:21:42 +0000 (21:21 +0000)]
Make ARMv7 work again
https://bugs.webkit.org/show_bug.cgi?id=81157

Reviewed by Geoffrey Garen.

We were trying to use the ARMv7 dataRegister as a scratch register in a scenario
where we the ARMv7MacroAssembler would also try to use dataRegister for its own
nefarious purposes.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::store32):
* assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB layout tests: factor out prefix-handling-code
dgrogan@chromium.org [Wed, 14 Mar 2012 21:20:56 +0000 (21:20 +0000)]
IndexedDB layout tests: factor out prefix-handling-code
https://bugs.webkit.org/show_bug.cgi?id=80664

This makes our tests vendor neutral so that we can load them in any
browser to check what that browser does.

Also changed some instances of 'window' to 'self' so that they are more
worker friendly.

Reviewed by Tony Chang.

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-shared-workers-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required.html:
* storage/indexeddb/createObjectStore-null-name-expected.txt:
* storage/indexeddb/createObjectStore-null-name.html:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue.html:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-key-order.html:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-primary-key-order.html:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-reverse-bug.html:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required.html:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-basics.html:
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/database-name-undefined.html:
* storage/indexeddb/database-odd-names-expected.txt:
* storage/indexeddb/database-odd-names.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/delete-closed-database-object.html:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/delete-range.html:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/deleteIndex.html:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required.html:
* storage/indexeddb/deleteObjectStore-null-name-expected.txt:
* storage/indexeddb/deleteObjectStore-null-name.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/factory-basics.html:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-count.html:
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/index-get-key-argument-required.html:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-multientry.html:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/index-population.html:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/invalid-keys.html:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-generator.html:
* storage/indexeddb/key-sort-order-across-types-expected.txt:
* storage/indexeddb/key-sort-order-across-types.html:
* storage/indexeddb/key-sort-order-date-expected.txt:
* storage/indexeddb/key-sort-order-date.html:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array.html:
* storage/indexeddb/key-type-infinity-expected.txt:
* storage/indexeddb/key-type-infinity.html:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-basics.html:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-edges.html:
* storage/indexeddb/keypath-fetch-key-expected.txt:
* storage/indexeddb/keypath-fetch-key.html:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange-required-arguments-expected.txt:
* storage/indexeddb/keyrange-required-arguments.html:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/list-ordering.html:
* storage/indexeddb/mozilla/add-twice-failure-expected.txt:
* storage/indexeddb/mozilla/add-twice-failure.html:
* storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
* storage/indexeddb/mozilla/autoincrement-indexes.html:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/clear.html:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-index-unique.html:
* storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
* storage/indexeddb/mozilla/create-index-with-integer-keys.html:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics.html:
* storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-null-name.html:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
* storage/indexeddb/mozilla/cursor-mutation.html:
* storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
* storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/cursors.html:
* storage/indexeddb/mozilla/delete-result-expected.txt:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/mozilla/event-source-expected.txt:
* storage/indexeddb/mozilla/event-source.html:
* storage/indexeddb/mozilla/global-data-expected.txt:
* storage/indexeddb/mozilla/global-data.html:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/indexes.html:
* storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
* storage/indexeddb/mozilla/key-requirements-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key.html:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key.html:
* storage/indexeddb/mozilla/key-requirements.html:
* storage/indexeddb/mozilla/object-cursors-expected.txt:
* storage/indexeddb/mozilla/object-cursors.html:
* storage/indexeddb/mozilla/object-identity-expected.txt:
* storage/indexeddb/mozilla/object-identity.html:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/object-store-remove-values.html:
* storage/indexeddb/mozilla/objectstorenames-expected.txt:
* storage/indexeddb/mozilla/objectstorenames.html:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/odd-result-order.html:
* storage/indexeddb/mozilla/open-database-null-name-expected.txt:
* storage/indexeddb/mozilla/open-database-null-name.html:
* storage/indexeddb/mozilla/put-get-values-expected.txt:
* storage/indexeddb/mozilla/put-get-values.html:
* storage/indexeddb/mozilla/readonly-transactions-expected.txt:
* storage/indexeddb/mozilla/readonly-transactions.html:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions.html:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/readyState.html:
* storage/indexeddb/mozilla/remove-index-expected.txt:
* storage/indexeddb/mozilla/remove-index.html:
* storage/indexeddb/mozilla/remove-objectstore-expected.txt:
* storage/indexeddb/mozilla/remove-objectstore.html:
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/mozilla/versionchange-abort.html:
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mozilla/versionchange.html:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectStore-required-arguments.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-count.html:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/odd-strings.html:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/open-close-version.html:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/open-during-transaction.html:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071.html:
* storage/indexeddb/queued-commands-expected.txt:
* storage/indexeddb/queued-commands.html:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/readonly-properties.html:
* storage/indexeddb/readonly.html:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/index-basics.js:
(test):
* storage/indexeddb/resources/objectstore-basics.js:
(test):
(setVersionSuccess):
(createIndex):
(addData):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
* storage/indexeddb/resources/shared.js:
(removeVendorPrefixes):
* storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
* storage/indexeddb/setVersion-null-expected.txt:
* storage/indexeddb/setVersion-null.html:
* storage/indexeddb/setVersion-undefined-expected.txt:
* storage/indexeddb/setVersion-undefined.html:
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/set_version_blocked.html:
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/set_version_queue.html:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort-workers-expected.txt:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/transaction-rollback.html:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/transaction-storeNames-required.html:
* storage/indexeddb/two-version-changes-expected.txt:
* storage/indexeddb/two-version-changes.html:
* storage/indexeddb/value-undefined-expected.txt:
* storage/indexeddb/value-undefined.html:
* storage/indexeddb/values-odd-types-expected.txt:
* storage/indexeddb/values-odd-types.html:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-abort.html:
* storage/indexeddb/version-change-exclusive-expected.txt:
* storage/indexeddb/version-change-exclusive.html:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove EntriesCallback to Modules/filesystem/
commit-queue@webkit.org [Wed, 14 Mar 2012 21:20:51 +0000 (21:20 +0000)]
Move EntriesCallback to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81032

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/filesystem/EntriesCallback.h: Copied from Source/WebCore/fileapi/EntriesCallback.h.
* Modules/filesystem/EntriesCallback.idl: Copied from Source/WebCore/fileapi/EntriesCallback.idl.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/EntriesCallback.h: Removed.
* fileapi/EntriesCallback.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap::destroy leaks CopiedSpace
mhahnenberg@apple.com [Wed, 14 Mar 2012 21:14:16 +0000 (21:14 +0000)]
Heap::destroy leaks CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=81055

Reviewed by Geoffrey Garen.

Added a destroy() function to CopiedSpace that moves all normal size
CopiedBlocks from the CopiedSpace to the Heap's list of free blocks
as well as deallocates all of the oversize blocks in the CopiedSpace.
This function is now called in Heap::destroy().

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::destroy):
(JSC):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/Heap.cpp:
(JSC::Heap::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomultiline column flexbox with auto height wrap too much
tony@chromium.org [Wed, 14 Mar 2012 21:10:24 +0000 (21:10 +0000)]
multiline column flexbox with auto height wrap too much
https://bugs.webkit.org/show_bug.cgi?id=80929

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/multiline-column-auto.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore):
(WebCore::RenderBox::computeContentLogicalHeightUsing): Pull out into a separate method.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::lineBreakLength): Compute the value based on height & max-height for column layout.
(WebCore):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/multiline-column-auto-expected.txt: Added.
* css3/flexbox/multiline-column-auto.html: Added.
* css3/flexbox/multiline-shrink-to-fit-expected.html:
* css3/flexbox/multiline-shrink-to-fit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110559.
commit-queue@webkit.org [Wed, 14 Mar 2012 21:04:37 +0000 (21:04 +0000)]
Unreviewed, rolling out r110559.
http://trac.webkit.org/changeset/110559
https://bugs.webkit.org/show_bug.cgi?id=81142

Broke Dromaeo tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* Dromaeo/resources/dromaeorunner.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPeerConnection was renamed to DeprecatedPeerConnection in r110587. Update the expected
jberlin@webkit.org [Wed, 14 Mar 2012 21:04:25 +0000 (21:04 +0000)]
PeerConnection was renamed to DeprecatedPeerConnection in r110587. Update the expected
results.

The rebaseline landed for Qt in 110685 should actually have been landed for all ports.
Land it for all ports, and remove the Qt specific expected results.

* fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/qt/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize the multiply-add in Biquad.cpp::process
commit-queue@webkit.org [Wed, 14 Mar 2012 21:01:37 +0000 (21:01 +0000)]
Optimize the multiply-add in Biquad.cpp::process
https://bugs.webkit.org/show_bug.cgi?id=75528

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-14
Reviewed by Chris Rogers.

Pipeline the multiply-add with SSE2 instructions and get about 20% improvement for the function.

* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitP...
ap@apple.com [Wed, 14 Mar 2012 20:59:53 +0000 (20:59 +0000)]
    WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitProvisionalLoad after running regression tests
        https://bugs.webkit.org/show_bug.cgi?id=81150
        <rdar://problem/11002254>

        Reviewed by Anders Carlsson.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
        (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
        It's not great, but for now we need to handle this case. Hopefully, some day we'll make
        both WebKit2 processes better aware of what's going on with loading in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up a few more baseline.
abarth@webkit.org [Wed, 14 Mar 2012 20:57:36 +0000 (20:57 +0000)]
Clean up a few more baseline.

* platform/chromium-mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates: Removed.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
jamesr@google.com [Wed, 14 Mar 2012 20:52:42 +0000 (20:52 +0000)]
[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=79823

Reviewed by Adrienne Walker.

Source/WebCore:

LayerRendererChromium was storing a weak pointer to the current render surface in m_currentRenderSurface and
using this in useRenderSurface() to avoid rebinding if we called useRenderSurface() multiple times in a row on
the same surface. This pointer was never cleared, so if any subsequent surface landed at the same address this
caching would misbehave and we'd fail to correctly initialize the new render surface. The caching wasn't
actually buying us anything anyway since we only call useRenderSurface() once per surface per frame and we
always set the viewport for the default render surface.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKTR doesn't have an implemenation of hasSpellingMarker yet.
jberlin@webkit.org [Wed, 14 Mar 2012 20:38:09 +0000 (20:38 +0000)]
WKTR doesn't have an implemenation of hasSpellingMarker yet.

Add more tests that rely on it to the WK2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd the chromium lion bot to garden-o-matic and remove
ojan@chromium.org [Wed, 14 Mar 2012 20:30:16 +0000 (20:30 +0000)]
Add the chromium lion bot to garden-o-matic and remove
the platform_move_to in builders.py since the Chromium Lion
port is now a normal port.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* Scripts/webkitpy/layout_tests/port/builders.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
commit-queue@webkit.org [Wed, 14 Mar 2012 20:22:55 +0000 (20:22 +0000)]
Frame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
https://bugs.webkit.org/show_bug.cgi?id=80155

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that an iframe only schedules and calls parent's layout,
when it is going to be flattened. Non-flattened iframe does not affect
parent's layout, so normal layout flow applies. isInSubframeLayoutWithFrameFlattening()
function has been added to test whether a particular child frame is changing
parent's layout. This function also ensures that scheduleRelayout() and layout()
are in sync of checking againts frame flattening.

Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html

* page/FrameView.cpp:
(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
(FrameView):
* rendering/RenderIFrame.h:
(RenderIFrame):
(WebCore::RenderIFrame::renderName):

LayoutTests:

* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout-expected.txt: Added.
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't cap the scroll position if layout happens when a FrameView's overhangAmount...
andersca@apple.com [Wed, 14 Mar 2012 20:07:42 +0000 (20:07 +0000)]
Don't cap the scroll position if layout happens when a FrameView's overhangAmount is non-zero
https://bugs.webkit.org/show_bug.cgi?id=81146
<rdar://problem/10850075>

Reviewed by Beth Dakin.

If layout happens when a page has a non-zero overhang amount, we shouldn't cap the scroll position
to be inside of the valid maximum/minimum scroll offsets because that will cause the page to jump back, which
can look really bad if layout happens in response to the page being scrolled.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Lion failures in order to green the lion bot.
ojan@chromium.org [Wed, 14 Mar 2012 19:58:02 +0000 (19:58 +0000)]
Add Lion failures in order to green the lion bot.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Introducing IceCandidate
tommyw@google.com [Wed, 14 Mar 2012 19:53:23 +0000 (19:53 +0000)]
MediaStream API (JSEP): Introducing IceCandidate
https://bugs.webkit.org/show_bug.cgi?id=80699

Reviewed by Adam Barth.

Patch #2 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the JS object IceCandidate and its WebCore/platform sibling IceCandidateDescriptor.
This object will be created both from JS and the embedder.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* Modules/mediastream/IceCandidate.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidate::create):
(WebCore::IceCandidate::IceCandidate):
(WebCore::IceCandidate::~IceCandidate):
(WebCore::IceCandidate::label):
(WebCore::IceCandidate::candidateLine):
(WebCore::IceCandidate::toSdp):
(WebCore::IceCandidate::descriptor):
* Modules/mediastream/IceCandidate.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidate):
* Modules/mediastream/IceCandidate.idl: Added.
* WebCore.gypi:
* platform/mediastream/IceCandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidateDescriptor::create):
(WebCore::IceCandidateDescriptor::IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::~IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::toSdp):
* platform/mediastream/IceCandidateDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::label):
(WebCore::IceCandidateDescriptor::candidateLine):
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSdp):
(WebCore):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamCenter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix regression/crash introduced in r110724 - bad type passed from skipped_tests(...
dpranke@chromium.org [Wed, 14 Mar 2012 19:51:26 +0000 (19:51 +0000)]
Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobackground-visibility:hidden should create a RenderLayer
simon.fraser@apple.com [Wed, 14 Mar 2012 19:50:28 +0000 (19:50 +0000)]
background-visibility:hidden should create a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=81134

Source/WebCore:

Reviewed by Dean Jackson.

Background-visibility:hidden has to create RenderLayers, because it's implemented
via compositing and/or paint short-circuiting in RenderLayer code.

Test: transforms/3d/general/background-visibility-layers.html

* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasHiddenBackface):
* rendering/RenderTableRow.h:

LayoutTests:

Reviewed by Dean Jackson.

Test for background-visibility: hidden making a RenderLayer.

* transforms/3d/general/background-visibility-layers-actual.png: Added.
* transforms/3d/general/background-visibility-layers-actual.txt: Added.
* transforms/3d/general/background-visibility-layers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions][CSSOM] Implement regionLayoutEvent
commit-queue@webkit.org [Wed, 14 Mar 2012 19:48:06 +0000 (19:48 +0000)]
[CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882

Patch by Raul Hudea <rhudea@adobe.com> on 2012-03-14
Reviewed by David Hyatt.

Source/WebCore:

Adding the regionLayoutEvent that is dispatch for all regions after each flow-thread layout.

Tests: fast/regions/region-event-add-to-flow.html
       fast/regions/region-event-remove-from-dom.html
       fast/regions/region-event-remove-from-flow.html
       fast/regions/region-event.html

* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Added check for regionLayoutUpdate listeners
* dom/Document.h:
* dom/EventNames.h:
(WebCore):
* dom/Node.cpp:
(WebCore::Node::dispatchRegionLayoutUpdateEvent):
(WebCore):
* dom/Node.h:
(Node):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): Start the event dispatch timer but only if there are regionLayoutUpdate listeners and there is at least one region that had its layout updated.
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Mark regions that might had a layout update
(WebCore::RenderFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setDispatchRegionLayoutUpdateEvent):
(WebCore::RenderRegion::shouldDispatchRegionLayoutUpdateEvent):
(RenderRegion):

LayoutTests:

* fast/regions/region-event-add-to-flow-expected.txt: Added.
* fast/regions/region-event-add-to-flow.html: Added.
* fast/regions/region-event-expected.txt: Added.
* fast/regions/region-event-remove-from-dom-expected.txt: Added.
* fast/regions/region-event-remove-from-dom.html: Added.
* fast/regions/region-event-remove-from-flow-expected.txt: Added.
* fast/regions/region-event-remove-from-flow.html: Added.
* fast/regions/region-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add support for vertical sliders in mobile theme
pierre.rossi@gmail.com [Wed, 14 Mar 2012 19:45:31 +0000 (19:45 +0000)]
[Qt] Add support for vertical sliders in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=80179

This makes sliders using the "slider-vertical" appearance more sensible.

Reviewed by Simon Hausmann.

No new tests, since the mobile theme still isn't used in layout tests.

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
* platform/qt/RenderThemeQtMobile.h:
(StylePainterMobile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline chromium-lion tests that have "MISSING" results.
ojan@chromium.org [Wed, 14 Mar 2012 19:30:54 +0000 (19:30 +0000)]
Rebaseline chromium-lion tests that have "MISSING" results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix UI process crash when a plug-in process crashes with a modal dialog showing
andersca@apple.com [Wed, 14 Mar 2012 19:26:11 +0000 (19:26 +0000)]
Fix UI process crash when a plug-in process crashes with a modal dialog showing
https://bugs.webkit.org/show_bug.cgi?id=81139
<rdar://problem/9641197>

Reviewed by Dan Bernstein.

When a plug-in process crashes, its corresponding PluginProcessProxy object is deleted immediately,
which is bad if we're currently running a nested run loop.

Fix this by making PluginProcessProxy ref-counted and protecting it before the call to -[NSApp runModalForWindow:].

* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginProcessWithPath):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
* UIProcess/Plugins/PluginProcessManager.h:
(PluginProcessManager):
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
* UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::beginModal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebProcess spins beneath [QTMovie movieFileTypes:]
jer.noble@apple.com [Wed, 14 Mar 2012 19:24:19 +0000 (19:24 +0000)]
WebProcess spins beneath [QTMovie movieFileTypes:]
https://bugs.webkit.org/show_bug.cgi?id=81133

Reviewed by Eric Carlson.

No new tests; speculative fix for top WebProcess spin.

When checking to see if a given mime type is supported by QuickTime,
immediately exclude all types that do not begin with 'audio/' or 'video/'.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::supportsType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate SVG baseline after work on <use> element. These results all
abarth@webkit.org [Wed, 14 Mar 2012 19:10:47 +0000 (19:10 +0000)]
Update SVG baseline after work on <use> element.  These results all
seem to be minor differences or progressions.

* platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPlease add a way to manually skip some tests in NRWT
dpranke@chromium.org [Wed, 14 Mar 2012 18:55:58 +0000 (18:55 +0000)]
Please add a way to manually skip some tests in NRWT
https://bugs.webkit.org/show_bug.cgi?id=81019

Reviewed by Ojan Vafai.

This patch implements the -i / --ignore-tests flag from ORWT
and refactors the test_expectations.py code slightly to handle
it.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_ignore_tests):
(MainTest.test_ignore_tests.assert_ignored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platfo...
dpranke@chromium.org [Wed, 14 Mar 2012 18:53:34 +0000 (18:53 +0000)]
nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
https://bugs.webkit.org/show_bug.cgi?id=81028

Reviewed by Ojan Vafai.

The mac port had incorrect lookups for 'mac-lion' and
'mac-future' in some places. This patch fixes that and adds a
bunch of tests.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.baseline_path):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.assert_skipped_file_search_paths):
(MacTest.test_skipped_file_search_paths):
(_assert_search_path):
(test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_file_search_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWK2: Spelling tests that rely on getting the marked range or the marked count synchro...
jberlin@webkit.org [Wed, 14 Mar 2012 18:37:37 +0000 (18:37 +0000)]
WK2: Spelling tests that rely on getting the marked range or the marked count synchronously fail
https://bugs.webkit.org/show_bug.cgi?id=81138

Add some expected failing results for such tests to get the bots green.

* platform/mac-wk2/editing/spelling/markers-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-insert-html-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, remove expectations for non-crashing tests
enne@google.com [Wed, 14 Mar 2012 18:33:16 +0000 (18:33 +0000)]
[Chromium] Unreviewed, remove expectations for non-crashing tests
https://bugs.webkit.org/show_bug.cgi?id=78038

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
commit-queue@webkit.org [Wed, 14 Mar 2012 18:29:32 +0000 (18:29 +0000)]
Make RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
https://bugs.webkit.org/show_bug.cgi?id=80301

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Reorganize RenderIFrame flattenFrame() code, so that it returns
earlier for the normal use case, when frame flattening is disabled.
It also removes leftover null check.

No new tests, since there's no new functionality.

* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Provide explicit polling API to check if the platform is capable of accele...
jamesr@google.com [Wed, 14 Mar 2012 18:12:29 +0000 (18:12 +0000)]
[chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=80667

Reviewed by Darin Fisher.

Source/WebCore:

Query the platform to see if we can instantiate a context suitable for accelerating 2d canvas. If we can't, for
instance if we're on a system that can't preserve a context when the screensaver comes up, then immediately fall
back to software.

Covered by canvas layout tests in the virtual-gpu mode.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::canAccelerate2dCanvas):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport drag in mouse events for WebKit2 EventSender
jberlin@webkit.org [Wed, 14 Mar 2012 18:03:01 +0000 (18:03 +0000)]
Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552
https://bugs.webkit.org/show_bug.cgi?id=69946

Add some tests that use eventSender.dragMode to the WK2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Handle printing errors in WebKit2
carlosgc@webkit.org [Wed, 14 Mar 2012 17:56:59 +0000 (17:56 +0000)]
[GTK] Handle printing errors in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=77197

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

* platform/gtk/ErrorsGtk.cpp:
(WebCore::printError): Create a generic print error.
(WebCore::printerNotFoundError): Create a print error to notify
that the selected printer could not be found.
(WebCore::invalidPageRangeToPrint): Create a print error when the
selected page range is invalid and there are no pages to print.
* platform/gtk/ErrorsGtk.h:
(WebCore): Add print error doamin.

Source/WebKit2:

* UIProcess/API/gtk/WebKitError.cpp:
(webkit_print_error_quark): Add new error domain for print
errors.
* UIProcess/API/gtk/WebKitError.h: Ad print errors.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init): Add
WebKitPrintOperation::failed signal.
(drawPagesForPrintingCompleted): Emit WebKitPrintOperation::failed
when the print operation failed with the given error.
(webkitPrintOperationPrintPagesForFrame): Use
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrint):
(testPrintOperationErrors): Test different print errors are
correctly reported.
(beforeAll):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate print finished callbacks
map.
(WebKit::WebPageProxy::printFinishedCallback): Callback called
when the print operation has finished in the web process.
(WebKit::WebPageProxy::processDidCrash): Invalidate print finished
callbacks map.
(WebKit::WebPageProxy::drawPagesForPrinting): Use a
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/WebPageProxy.h:
(WebKit): Delcare PrintFinishedCallback as a generic callback.
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in: Use PrintFinishedCallback
instead of VoidCallback as callback argument of
DrawPagesForPrinting message.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Mark the data as invalid
when there are no pages to print.
(PrintPagesData): Add isValid parameter to mark the data struct as
invalid.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Call
printPagesDone() instead of printDone().
(WebKit::WebPrintOperationGtk::printPagesDone): Renamed.
(WebKit::WebPrintOperationGtk::printDone): Notify the UI process
that the print operation has finsihed.
(WebKit::WebPrintOperationGtk::print): Finish the print if the
PrintPagesData struct is not valid.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Enable HTML5 Summary and Details elements
commit-queue@webkit.org [Wed, 14 Mar 2012 17:32:27 +0000 (17:32 +0000)]
[EFL] Enable HTML5 Summary and Details elements
https://bugs.webkit.org/show_bug.cgi?id=81027

Enabling Summary and Details elements by default and removing related
tests from skip list since they should pass now.

.:

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

LayoutTests:

Tests expectations from Ubuntu 11.10 using EFL from SVN. Hopefully the
same as the build bot.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

* platform/efl/Skipped:
* platform/efl/fast/html/details-add-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-nested-1-expected.txt: Added.
* platform/efl/fast/html/details-nested-2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary1-expected.txt: Added.
* platform/efl/fast/html/details-no-summary2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary3-expected.txt: Added.
* platform/efl/fast/html/details-no-summary4-expected.txt: Added.
* platform/efl/fast/html/details-open-javascript-expected.txt: Added.
* platform/efl/fast/html/details-open1-expected.txt: Added.
* platform/efl/fast/html/details-open2-expected.txt: Added.
* platform/efl/fast/html/details-open3-expected.txt: Added.
* platform/efl/fast/html/details-open4-expected.txt: Added.
* platform/efl/fast/html/details-open5-expected.txt: Added.
* platform/efl/fast/html/details-open6-expected.txt: Added.
* platform/efl/fast/html/details-position-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/efl/fast/html/details-replace-text-expected.txt: Added.
* platform/efl/fast/html/details-writing-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
commit-queue@webkit.org [Wed, 14 Mar 2012 17:05:06 +0000 (17:05 +0000)]
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-14
Reviewed by Rob Buis.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::isActive):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(WebKit):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
* Api/BackingStore.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::toWebCoreMouseEventType):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake SVGUseElement respect & support externalResourcesRequired
zimmermann@webkit.org [Wed, 14 Mar 2012 16:59:16 +0000 (16:59 +0000)]
Make SVGUseElement respect & support externalResourcesRequired
https://bugs.webkit.org/show_bug.cgi?id=81109

Reviewed by Rob Buis.

Source/WebCore:

Generalize the existing externalResourcesRequired support from SVGScriptElement
into SVGExternalResourcesRequired, so it can be shared with SVGUseElement, which
was lacking proper externalResourcesRequired support.

<use xlink:href="external.svg" onload="alert('hi')" externalResourcesRequired="true"/>
The onload handler now fires _after_ the external resources loaded, making it possible
to write reliable tests that switch from internal to external resources or the other
way around. Converted the new tests in svg/dynamic-updates/SVGUseElement* to listen
to SVGLoad events, to make them reliable.

We may be able to generalize this to cover SVGImageElement as well (the only other class which
is currently supporting externalResourcesRequired - but that's more involved, so I left it TODO).

Covered by existing tests and the changes to the new SVGUseElement tests.

* svg/SVGElement.h:
(SVGElement): Make haveLoadedRequiredResources() public so SVGExternalResourcesRequired can call it.
* svg/SVGExternalResourcesRequired.cpp: Refactored code from SVGScriptElement, 1:1 copies w/o changes.
(WebCore::SVGExternalResourcesRequired::handleAttributeChange):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent):
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
(WebCore::SVGExternalResourcesRequired::finishParsingChildren):
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources):
* svg/SVGExternalResourcesRequired.h: Add new virtual functions, that must be available in classes that inherit from SVGExternalResourcesRequired.
(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent):
(WebCore::SVGExternalResourcesRequired::isParserInserted):
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent):
* svg/SVGScriptElement.cpp: Refactored externalResourcesRequired handling into SVGExternalResourcesRequired.
(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::finishParsingChildren):
* svg/SVGScriptElement.h: Ditto.
(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::setHaveFiredLoadEvent):
(WebCore::SVGScriptElement::isParserInserted):
(WebCore::SVGScriptElement::haveFiredLoadEvent):
* svg/SVGTests.cpp: Fix obvious typo, that leads to an assertion. Always return true if we know the attributeName.
(WebCore::SVGTests::handleAttributeChange):
* svg/SVGTests.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument): Remove ambigous call warning.
* svg/SVGUseElement.cpp: Support externalResourcesRequired="true/false" + dynamic changes of it. Covered by existing tests.
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren):
(WebCore):
* svg/SVGUseElement.h: Ditto.
(WebCore::SVGUseElement::haveLoadedRequiredResources):
(WebCore::SVGUseElement::setHaveFiredLoadEvent):
(WebCore::SVGUseElement::isParserInserted):
(WebCore::SVGUseElement::haveFiredLoadEvent):
* svg/svgtags.in: Pass "bool wasInsertedByParser" to SVGUseElement constructor.

LayoutTests:

Fix flakiness of new external <use> tests introduced in r110676.

* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt:
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt:
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js:
(repaintTest):
(externalLoadDone):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js:
(repaintTest):
(externalLoadDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
jberlin@webkit.org [Wed, 14 Mar 2012 16:32:40 +0000 (16:32 +0000)]
Mac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=81125

Add expected failing results for Mac WK2 to get the bots green.

* platform/mac-wk2/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRa...
commit-queue@webkit.org [Wed, 14 Mar 2012 16:23:02 +0000 (16:23 +0000)]
[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=81000

Source/JavaScriptCore:

Enable WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

* wtf/Platform.h:

Source/WebCore:

Add BlackBerry port for DisplayRefreshMonitor using AnimationFrameRateController.
Moved refreshDisplayOnMainThread to platform independant part of header.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

* PlatformBlackBerry.cmake:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore):
(DisplayAnimationClient):
(WebCore::DisplayAnimationClient::~DisplayAnimationClient):
(DisplayRefreshMonitor):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Added.
(WebCore):
(WebCore::DisplayAnimationClient::DisplayAnimationClient):
(WebCore::DisplayAnimationClient::animationFrameChanged):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::startAnimationClient):
(WebCore::DisplayRefreshMonitor::stopAnimationClient):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/blackberry:

Set the platform display ID, needed for DisplayRefreshMonitor.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnt...
jer.noble@apple.com [Wed, 14 Mar 2012 16:21:05 +0000 (16:21 +0000)]
Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
https://bugs.webkit.org/show_bug.cgi?id=81056

Reviewed by Jessie Berlin.

Source/WebKit2:

Give the InjectedBundlePageFullScreenClient a first crack at beganEnterFullScreen and beganExitFullScreen:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):

And call the client function if it exists; otherwise, continue to message the page:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::beganEnterFullScreen):
(WebKit::InjectedBundlePageFullScreenClient::beganExitFullScreen):
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Add a custom APIClientTraits for InjectedBundlePageFullScreenClient to handle the API number change.
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:

Tools:

Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: use class name indexes instead of class names when evaluating aggregates
yurys@chromium.org [Wed, 14 Mar 2012 16:20:16 +0000 (16:20 +0000)]
Web Inspector: use class name indexes instead of class names when evaluating aggregates
https://bugs.webkit.org/show_bug.cgi?id=81100

Class name and type name indexes are now used when calculating class aggregates
in heap snapshots instead of string lookup followed by a string comparison.

Class names like "Window / www.webkit.org" are now left as is in the UI (it used
to be trimed to just "Window").

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get classNameIndex):
(WebInspector.HeapSnapshotNode.prototype.hasType):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add didCancelFrame timeline event
caseq@chromium.org [Wed, 14 Mar 2012 16:04:38 +0000 (16:04 +0000)]
Web Inspector: add didCancelFrame timeline event
https://bugs.webkit.org/show_bug.cgi?id=80994

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

- add an ability to cancel certain timeline events, unless they've been followed by other events.
- implement didCancelFrame() event, fired when a platform decides not to render frame after didBeginFrame() was called.

Test: inspector/timeline/timeline-frames.html

* WebCore.exp.in:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCancelFrameImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCancelFrame):
(WebCore):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
(WebCore::InspectorTimelineAgent::cancelRecord):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
* testing/Internals.cpp:
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore):
(WebCore::Internals::emitInspectorDidCancelFrame):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/chromium:

- add intrumentCanceFrame(), called when renderer decides not to
    render frame after instrumentBeginFrame() was called.

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentCancelFrame):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

- added test for didBeginFrame()/didCancelFrame()

* inspector/timeline/timeline-frames-expected.txt: Added.
* inspector/timeline/timeline-frames.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe width and height of the scroll indicators in the MiniBrowser does not consider...
ahf@0x90.dk [Wed, 14 Mar 2012 15:42:51 +0000 (15:42 +0000)]
The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. https://bugs.webkit.org/show_bug.cgi?id=81112

Reviewed by Kenneth Rohde Christiansen.

This patch fixes the issue by withdrawing two times the anchor
margins.

* MiniBrowser/qt/qml/ScrollIndicator.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegion can acquire an empty span by subtracting an empty Region
commit-queue@webkit.org [Wed, 14 Mar 2012 15:37:33 +0000 (15:37 +0000)]
Region can acquire an empty span by subtracting an empty Region
https://bugs.webkit.org/show_bug.cgi?id=81074

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-14
Reviewed by Anders Carlsson.

Source/WebCore:

Subtracting an empty Region B from a Region A can cause A to end
up with an empty span. This violates the rule that two Regions
that cover the exact same area should have equal spans and segments.

Unit test: RegionTest.emptySpan

* platform/graphics/Region.cpp:
(WebCore::Region::subtract):

Source/WebKit/chromium:

* tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Textmap] Disable driver based BGRA swizzling for OpenGL/ES
hausmann@webkit.org [Wed, 14 Mar 2012 15:31:56 +0000 (15:31 +0000)]
[Textmap] Disable driver based BGRA swizzling for OpenGL/ES

Reviewed by Noam Rosenthal.

The current way of detecting swizzling support (check for GL_EXT_texture_format_BGRA8888)
is unfortunately not reliable. We need a better way of detection that (filed bug 81103).
In the meantime this patch reverts back to doing the swizzling in the texture mapper to
get pixels back onto the screen.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS
vestbo@webkit.org [Wed, 14 Mar 2012 15:28:34 +0000 (15:28 +0000)]
[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
leo.yang@torchmobile.com.cn [Wed, 14 Mar 2012 15:24:13 +0000 (15:24 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=81086

Reviewed by Rob Buis.

Source/WebCore:

* platform/Cursor.h:
(WebCore):
(WebCore::Cursor::Cursor):
Add the BlackBerry specific PlatformCursor.
* platform/blackberry/PageClientBlackBerry.h:
There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly in this file.
(PageClientBlackBerry):

Source/WebKit/blackberry:

There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCursor):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implement LayoutTestController::clearBackForwardList
commit-queue@webkit.org [Wed, 14 Mar 2012 15:15:34 +0000 (15:15 +0000)]
[EFL] Implement LayoutTestController::clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=80142

Tools:

Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearBackForwardList): Implemented.

LayoutTests:

Unskip tests connected with clearBackForwardList.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] RunLoopQt is missing reentrancy guards
abecsi@webkit.org [Wed, 14 Mar 2012 15:02:14 +0000 (15:02 +0000)]
[Qt] RunLoopQt is missing reentrancy guards
https://bugs.webkit.org/show_bug.cgi?id=80982

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-14
Reviewed by Tor Arne Vestbø.

Avoid recursive calls to RunLoop::performWork() with a simple
counting mechanism, to avoid out-of-order message dispatching.

* platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
loislo@chromium.org [Wed, 14 Mar 2012 14:41:26 +0000 (14:41 +0000)]
Source/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
https://bugs.webkit.org/show_bug.cgi?id=81033

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):

Source/WebKit/chromium: Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-13

* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):

LayoutTests: Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205

Patch by Kentaro Hara <haraken@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
commit-queue@webkit.org [Wed, 14 Mar 2012 13:23:10 +0000 (13:23 +0000)]
Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.

Fix build error introduced by r110669.

* platform/network/soup/DNSSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline update for <use> related SVG files.
morrita@google.com [Wed, 14 Mar 2012 13:01:17 +0000 (13:01 +0000)]
Unreviewed rebaseline update for <use> related SVG files.

* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Removed.
* platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textPosition-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textStyles-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.txt:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/smallFonts-expected.png:
* platform/chromium-win/svg/batik/text/smallFonts-expected.txt:
* platform/chromium-win/svg/batik/text/textAnchor-expected.png:
* platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
* platform/chromium-win/svg/batik/text/textDecoration-expected.png:
* platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect2-expected.png:
* platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.png:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout-expected.png:
* platform/chromium-win/svg/batik/text/textLayout-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout2-expected.png:
* platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
* platform/chromium-win/svg/batik/text/textLength-expected.png:
* platform/chromium-win/svg/batik/text/textLength-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition-expected.png:
* platform/chromium-win/svg/batik/text/textPosition-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.png:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties2-expected.png:
* platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.txt:
* platform/chromium-win/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/batik/text/verticalText-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac-future/svg/batik/masking/maskRegions-expected.png: Removed.
* platform/mac/svg/batik/masking/maskRegions-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebHTTPBody: Keep track of whether the data includes passwords.
commit-queue@webkit.org [Wed, 14 Mar 2012 12:41:37 +0000 (12:41 +0000)]
WebHTTPBody: Keep track of whether the data includes passwords.
https://bugs.webkit.org/show_bug.cgi?id=81003

Patch by Marja Hölttä <marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.

This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.

Source/WebCore:

* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Check if the data contains passwords.
* platform/network/FormData.cpp:
(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.
* platform/network/FormData.h:
(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):

Source/WebKit/chromium:

* public/platform/WebHTTPBody.h:
(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add snippets tab to scripts navigator.
vsevik@chromium.org [Wed, 14 Mar 2012 12:23:08 +0000 (12:23 +0000)]
Web Inspector: Add snippets tab to scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=81018

Reviewed by Pavel Feldman.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/SnippetsModel.js:

LayoutTests:

* http/tests/inspector/debugger-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Copy on the Console gives a mangled result.
pfeldman@chromium.org [Wed, 14 Mar 2012 12:03:48 +0000 (12:03 +0000)]
Web Inspector: Copy on the Console gives a mangled result.
https://bugs.webkit.org/show_bug.cgi?id=81091

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

LayoutTests:

* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* inspector/console/console-assert-expected.txt:
* inspector/console/console-big-array-expected.txt:
* inspector/console/console-clear-expected.txt:
* inspector/console/console-command-clear-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-external-array-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/console/console-log-before-inspector-open-expected.txt:
* inspector/console/console-log-document-proto-expected.txt:
* inspector/console/console-log-syntax-error-expected.txt:
* inspector/console/console-log-toString-object-expected.txt:
* inspector/console/console-nested-group-expected.txt:
* inspector/console/console-object-constructor-name-expected.txt:
* inspector/console/console-repeat-count-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/console/console-trace-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
* platform/chromium/inspector/console/alert-toString-exception-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-log-document-proto-expected.txt:
* platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
* platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
* platform/qt/inspector/console/console-format-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Mar 2012 12:00:44 +0000 (12:00 +0000)]
2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        External <use> xlink:href references do not work
        https://bugs.webkit.org/show_bug.cgi?id=12499

        Reviewed by Zoltan Herczeg.

        Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
        Replace xml:id with id everywhere, to make the new tiny tests work.

        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.png:
        * platform/mac/svg/batik/filters/filterRegions-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
        * svg/custom/use-external-crash-expected.txt: Added.
        * svg/custom/use-external-crash.svg: Added.

2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        External <use> xlink:href references do not work
        https://bugs.webkit.org/show_bug.cgi?id=12499

        Reviewed by Zoltan Herczeg.

        Follow-up fix after r110676.
        Assertions are firing due last minute changes in isExternalURIReference.

        Fix detecting local resources properly, when the given iri contains a /complex/path.
        Use document->completeURL() instead, and compare with the document->url() to decide
        if its a local reference or not.

        If an external document load fails with an error (eg. file missing) don't assert
        in debug builds, instead handle it gracefully.

        I decided to clean the code up as well, to make it more safe & obvious.

        Test: svg/custom/use-external-crash.svg

        * svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::targetElementFromIRIString):
        * svg/SVGURIReference.h:
        (WebCore::SVGURIReference::isExternalURIReference):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::externalDocument):
        (WebCore::SVGUseElement::buildPendingResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago3D transformed surfaces with z>0 gets cropped
commit-queue@webkit.org [Wed, 14 Mar 2012 11:56:47 +0000 (11:56 +0000)]
3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.

The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.

No new tests. Tested by current compositing layout tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginScissorClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Rebaseline after r110667.
ossy@webkit.org [Wed, 14 Mar 2012 11:47:36 +0000 (11:47 +0000)]
[Qt] Rebaseline after r110667.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.

* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Add platform specific expectaions after r110593
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 11:43:53 +0000 (11:43 +0000)]
[Qt] Unreviewed. Add platform specific expectaions after r110593
new file:   LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file:   LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed flakiness marking.
morrita@google.com [Wed, 14 Mar 2012 11:39:46 +0000 (11:39 +0000)]
Unreviewed flakiness marking.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaselining expectations.
morrita@google.com [Wed, 14 Mar 2012 11:06:09 +0000 (11:06 +0000)]
Unreviewed rebaselining expectations.

* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLayout-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLength-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] svg/animations tests are very flaky
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:44:51 +0000 (10:44 +0000)]
[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703

Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, rebaseline after r110587.
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:31:37 +0000 (10:31 +0000)]
[Qt] Unreviewed, rebaseline after r110587.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
morrita@google.com [Wed, 14 Mar 2012 10:11:30 +0000 (10:11 +0000)]
Unreviewed build fix.

* html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::owner): Changed return type from HTMLMediaElement* to Node* and uninlined.
* html/track/TextTrackList.h:
(TextTrackList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [InspectorIndexedDB] Remote object should be released when data view...
vsevik@chromium.org [Wed, 14 Mar 2012 10:04:33 +0000 (10:04 +0000)]
Web Inspector: [InspectorIndexedDB] Remote object should be released when data view is removed/updated.
https://bugs.webkit.org/show_bug.cgi?id=81022

Reviewed by Pavel Feldman.

* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.get statusBarItems):
(WebInspector.IDBDataView.prototype.clear):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype._objectStoreRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype._indexRemoved):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Update expectaions after r110676
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:02:17 +0000 (10:02 +0000)]
[Qt] Unreviewed. Update expectaions after r110676

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Introduce SnippetsScriptMapping.
vsevik@chromium.org [Wed, 14 Mar 2012 09:59:50 +0000 (09:59 +0000)]
Web Inspector: Introduce SnippetsScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80890

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._mappingForScript):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.snippetForId):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetsScriptMapping.prototype.addScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript.get if):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted):
(WebInspector.SnippetsScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK svg rebaseline after r110676.
philn@webkit.org [Wed, 14 Mar 2012 09:38:09 +0000 (09:38 +0000)]
Unreviewed, GTK svg rebaseline after r110676.

* platform/gtk/svg/batik/filters/feTile-expected.txt:
* platform/gtk/svg/batik/filters/filterRegions-expected.txt:
* platform/gtk/svg/batik/masking/maskRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
* platform/gtk/svg/batik/text/textAnchor-expected.txt:
* platform/gtk/svg/batik/text/textDecoration-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect2-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/textFeatures-expected.txt:
* platform/gtk/svg/batik/text/textLayout-expected.txt:
* platform/gtk/svg/batik/text/textLayout2-expected.txt:
* platform/gtk/svg/batik/text/textLength-expected.txt:
* platform/gtk/svg/batik/text/textOnPath-expected.txt:
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/gtk/svg/batik/text/textPosition-expected.txt:
* platform/gtk/svg/batik/text/textPosition2-expected.txt:
* platform/gtk/svg/batik/text/textProperties-expected.txt:
* platform/gtk/svg/batik/text/textProperties2-expected.txt:
* platform/gtk/svg/batik/text/textStyles-expected.txt:
* platform/gtk/svg/batik/text/verticalText-expected.txt:
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/gtk/svg/hixie/error/014-expected.txt:
* platform/gtk/svg/hixie/use/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Mar 2012 09:08:49 +0000 (09:08 +0000)]
2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update two pixel test results on Lion, now svg/ passes with --tolerance 0 again.

        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110673.
commit-queue@webkit.org [Wed, 14 Mar 2012 09:01:47 +0000 (09:01 +0000)]
Unreviewed, rolling out r110673.
http://trac.webkit.org/changeset/110673
https://bugs.webkit.org/show_bug.cgi?id=81090

"Qt minimal build broken" (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLast buildfix for Qt after r110595. :)
ossy@webkit.org [Wed, 14 Mar 2012 08:55:15 +0000 (08:55 +0000)]
Last buildfix for Qt after r110595. :)

Reviewed by Benjamin Poulain.

* Api/qwebpage.cpp:
* WebCoreSupport/GeolocationClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExternal <use> xlink:href references do not work
reni@webkit.org [Wed, 14 Mar 2012 08:52:35 +0000 (08:52 +0000)]
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Source/WebCore:

This is a follow-up patch after r108785.
In this patch we bind the previously introduced CachedSVGDocument class
into the caching mechanism of SVGUseElement. The mode how external resources
are handled is similar to the processing of internal ones. We build the instance
and shadow tree the same way but we have to keep in mind that the requested resources
maybe not loaded yet. We can check it with cachedDocumentIsStillLoading() function.

SVGURIReference::targetElementFromIRIString() also need to be extended. The baseURI
computation needs to take the referenced documents URL into account, instead of the current documents.

The patch affects a lot of tests which have external resources especially in svg/batik. Because
of the size of that test refactor they will be commited in a follow-up patch.

Tests: svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg
       svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg
       svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg
       svg/custom/use-extern-href.svg
       svg/custom/use-referencing-an-image-expected.svg
       svg/custom/use-referencing-an-image.svg
       svg/custom/use-referencing-indirectly-itself-expected.svg
       svg/custom/use-referencing-indirectly-itself.svg
       svg/custom/use-referencing-itself-expected.svg
       svg/custom/use-referencing-itself.svg
       svg/dynamic-updates/SVGUseElement-dom-href1-attr.html
       svg/dynamic-updates/SVGUseElement-dom-href2-attr.html
       svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html
       svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore):
(WebCore::CachedResourceLoader::requestSVGDocument):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* page/ContentSecurityPolicy.h:
* platform/KURL.cpp:
(WebCore::equalIgnoringFragmentIdentifier):
* platform/network/chromium/ResourceRequest.h:
* svg/SVGURIReference.cpp:
(WebCore::urlFromIRIStringWithFragmentIdentifier):
(WebCore):
(WebCore::SVGURIReference::targetElementFromIRIString):
* svg/SVGURIReference.h:
(SVGURIReference):
(WebCore::SVGURIReference::isExternalURIReference):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore):
(WebCore::SVGUseElement::referencedDocument):
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::cachedDocumentIsStillLoading):
(WebCore::SVGUseElement::instanceTreeIsLoading):
* svg/SVGUseElement.h:
(WebCore):
(SVGUseElement):

LayoutTests:

Adding tests to check the new functionality of SVGUseElement what can use
sources from external URIs too. New tests in this patch cover the corner cases
of this feature: referencing resources directly and indirectly, changing
the referenced URI from an internal to an external one, handling
security issues like self referencing, self referencing across document, etc.
Furthermore the patch infer some rebaseline in svg/batik directory because
they use external resources.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/feTile-expected.txt:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.txt:
* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/batik/masking/maskRegions-expected.txt:
* platform/mac/svg/batik/paints/gradientLimit-expected.png:
* platform/mac/svg/batik/paints/gradientLimit-expected.txt:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/mac/svg/batik/paints/patternRegionA-expected.png:
* platform/mac/svg/batik/paints/patternRegionA-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-expected.png:
* platform/mac/svg/batik/paints/patternRegions-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/mac/svg/batik/text/longTextOnPath-expected.png:
* platform/mac/svg/batik/text/longTextOnPath-expected.txt:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/smallFonts-expected.txt:
* platform/mac/svg/batik/text/textAnchor-expected.png:
* platform/mac/svg/batik/text/textAnchor-expected.txt:
* platform/mac/svg/batik/text/textDecoration-expected.png:
* platform/mac/svg/batik/text/textDecoration-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect2-expected.png:
* platform/mac/svg/batik/text/textEffect2-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/textFeatures-expected.png:
* platform/mac/svg/batik/text/textFeatures-expected.txt:
* platform/mac/svg/batik/text/textLayout-expected.png:
* platform/mac/svg/batik/text/textLayout-expected.txt:
* platform/mac/svg/batik/text/textLayout2-expected.png:
* platform/mac/svg/batik/text/textLayout2-expected.txt:
* platform/mac/svg/batik/text/textLength-expected.png:
* platform/mac/svg/batik/text/textLength-expected.txt:
* platform/mac/svg/batik/text/textOnPath-expected.png:
* platform/mac/svg/batik/text/textOnPath-expected.txt:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/mac/svg/batik/text/textPosition-expected.png:
* platform/mac/svg/batik/text/textPosition-expected.txt:
* platform/mac/svg/batik/text/textPosition2-expected.png:
* platform/mac/svg/batik/text/textPosition2-expected.txt:
* platform/mac/svg/batik/text/textProperties-expected.png:
* platform/mac/svg/batik/text/textProperties-expected.txt:
* platform/mac/svg/batik/text/textProperties2-expected.png:
* platform/mac/svg/batik/text/textProperties2-expected.txt:
* platform/mac/svg/batik/text/textStyles-expected.png:
* platform/mac/svg/batik/text/textStyles-expected.txt:
* platform/mac/svg/batik/text/verticalText-expected.png:
* platform/mac/svg/batik/text/verticalText-expected.txt:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/mac/svg/custom/use-extern-href-expected.png: Added.
* platform/mac/svg/custom/use-extern-href-expected.txt: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac/svg/hixie/error/014-expected.txt:
* platform/mac/svg/hixie/use/002-expected.png:
* platform/mac/svg/hixie/use/002-expected.txt:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: Added.
* svg/batik/filters/filterRegions.svg:
* svg/batik/text/textProperties.svg:
* svg/batik/text/textProperties2.svg:
* svg/batik/text/textStyles.svg:
* svg/custom/resources/rgb.svg:
* svg/custom/use-extern-href.svg: Added.
* svg/custom/use-referencing-an-image-expected.svg: Added.
* svg/custom/use-referencing-an-image.svg: Added.
* svg/custom/use-referencing-indirectly-itself-expected.svg: Added.
* svg/custom/use-referencing-indirectly-itself.svg: Added.
* svg/custom/use-referencing-itself-expected.svg: Added.
* svg/custom/use-referencing-itself.svg: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js: Added.
(repaintTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip a new failing inspector test in GTK and add new
philn@webkit.org [Wed, 14 Mar 2012 08:32:39 +0000 (08:32 +0000)]
Unreviewed, skip a new failing inspector test in GTK and add new
baseline for a svg test.

* platform/gtk/Skipped:
* platform/gtk/svg/custom/delete-text-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 14 Mar 2012 08:18:35 +0000 (08:18 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
commit-queue@webkit.org [Wed, 14 Mar 2012 08:04:18 +0000 (08:04 +0000)]
Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-14
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.__init__):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r110667.
philn@webkit.org [Wed, 14 Mar 2012 08:04:02 +0000 (08:04 +0000)]
Unreviewed, GTK rebaseline after r110667.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for EFL after r110669.
sergio@webkit.org [Wed, 14 Mar 2012 07:32:07 +0000 (07:32 +0000)]
Unreviewed. Build fix for EFL after r110669.

* PlatformEfl.cmake: added DNSSoup.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Use the same DNS prefetching path than the other ports.
sergio@webkit.org [Wed, 14 Mar 2012 07:23:49 +0000 (07:23 +0000)]
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

* GNUmakefile.list.am:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLLinkElement.cpp:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* platform/network/DNS.h:
(WebCore):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/chromium/DNSChromium.cpp:
* platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
* platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGTK 32-bit Linux Release build failing after r110580 (from bug 80338)
commit-queue@webkit.org [Wed, 14 Mar 2012 07:11:22 +0000 (07:11 +0000)]
GTK 32-bit Linux Release build failing after r110580 (from bug 80338)
https://bugs.webkit.org/show_bug.cgi?id=81063

Prospective build fix for GTK 32-bit Linux Release.

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-14
Reviewed by Martin Robinson.

* Source/autotools/symbols.filter: Adding symbol for ClientRectList(Vector<FloatQuad>) for
GTK 32-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReturn null when shouldAllowAccessToNode() fails
haraken@chromium.org [Wed, 14 Mar 2012 07:06:03 +0000 (07:06 +0000)]
Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205

Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

Source/WebCore:

Tests: http/tests/security/local-iFrame-from-remote.html
       http/tests/security/cross-frame-access-frameelement.html
       http/tests/security/cross-frame-access-put.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

* bindings/scripts/test/JS/JSTestObj.cpp: Updated run-bindings-tests results.
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

LayoutTests:

* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
morrita@google.com [Wed, 14 Mar 2012 07:02:49 +0000 (07:02 +0000)]
Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [Forms] Hidden input element should not have labels.
commit-queue@webkit.org [Wed, 14 Mar 2012 06:54:01 +0000 (06:54 +0000)]
Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.

Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.

No new tests. Existing tests are updated.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.
* html/HiddenInputType.h:  Added isLabelable returning false.
* html/InputType.cpp:
(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):
* html/InputType.h:
(InputType): Added isLabelable declaration.

LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.

* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labelable-elements.html:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] The "output" element should have labels.
commit-queue@webkit.org [Wed, 14 Mar 2012 06:35:49 +0000 (06:35 +0000)]
[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

* html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, marking some tests flaky.
morrita@google.com [Wed, 14 Mar 2012 06:24:15 +0000 (06:24 +0000)]
Unreviewed, marking some tests flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove opacity clamping into RenderStyle setter.
macpherson@chromium.org [Wed, 14 Mar 2012 03:19:02 +0000 (03:19 +0000)]
Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966

Reviewed by Eric Seidel.

Covered by existing tests.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::setOpacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValueToInt32 speculation will cause OSR exits even when it does not have to
fpizlo@apple.com [Wed, 14 Mar 2012 02:54:58 +0000 (02:54 +0000)]
ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>

Reviewed by Anders Carlsson.

Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead
   of exiting, if it doesn't know what speculations to perform.
2) ValueToInt32 will speculate boolean if it sees this to be profitable.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Windows build fixing
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:47:48 +0000 (02:47 +0000)]
More Windows build fixing

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:40:19 +0000 (02:40 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoType conversion of exponential part failed
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:12:25 +0000 (02:12 +0000)]
Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673

Reviewed by Geoffrey Garen.

* parser/Lexer.cpp:
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).
* runtime/LiteralParser.cpp:
(JSC::::Lexer::lexNumber):
* tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that
we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.
* wtf/dtoa.cpp:
(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.
* wtf/dtoa.h:
* wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the
Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).
* wtf/text/WTFString.cpp:
(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit the extra logic out of RenderObjectChildList::updateBeforeAfterContent
igor.o@sisa.samsung.com [Wed, 14 Mar 2012 01:38:08 +0000 (01:38 +0000)]
Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent

Reviewed by Julien Chaffraix.

No change in behavior expected.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderObjectChildList.h:
(WebCore):
(RenderObjectChildList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.
ojan@chromium.org [Wed, 14 Mar 2012 01:37:58 +0000 (01:37 +0000)]
FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix since is_pod<> includes some header that I didn't know about.
fpizlo@apple.com [Wed, 14 Mar 2012 01:26:38 +0000 (01:26 +0000)]
Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.

* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFind bouncy doesn’t hide when a subframe is scrolled
andersca@apple.com [Wed, 14 Mar 2012 01:09:47 +0000 (01:09 +0000)]
Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>

Reviewed by Andreas Kling.

Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
* WebProcess/WebPage/FindController.h:
(FindController):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs a more-complete implementation of eventSender.
jberlin@webkit.org [Wed, 14 Mar 2012 01:07:29 +0000 (01:07 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Skip yet another test that uses eventSender.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFunctions with C linkage should return POD types
fpizlo@apple.com [Wed, 14 Mar 2012 00:46:03 +0000 (00:46 +0000)]
Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061

Reviewed by Mark Rowe.

* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:
(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove duplicate GC functions from layout tests
arv@chromium.org [Wed, 14 Mar 2012 00:36:34 +0000 (00:36 +0000)]
Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047

Reviewed by Ojan Vafai.

* fast/canvas/webgl/shader-deleted-by-accessor.html:
* fast/dom/Window/customized-property-survives-gc.html:
* fast/dom/inline-event-attributes-lookup-removed-form.html:
* fast/dom/inline-event-attributes-lookup-removed.html:
* fast/dom/shadow/gc-shadow.html:
* fast/filesystem/resources/file-writer-gc-blob.js:
* fast/forms/input-image-submit.html:
* fast/forms/interactive-validation-remove-node-in-handler.html:
* fast/forms/select-set-length-with-mutation-remove.html:
* fast/js/resources/js-test-pre.js:
(gc.else.gcRec):
(gc):
* http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
* http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
* webaudio/mediaelementaudiosourcenode-gc.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110650 268f45cc-cd09-0410-ab3c-d52691b4dbfc