WebKit-https.git
11 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 15:00:25 +0000 (15:00 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24541
        Scrolling with home and end keys not always works

        Also make page up and page down keys be handled by the webview key
        event code, so that they also work in cases where the GTK+
        scrollbars don't handle them directly, like in the bugzill's patch
        review page.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 15:00:11 +0000 (15:00 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24541
        Scrolling with home and end keys not always works

        Make home and end keys behave more consistently for scrolling the
        view.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 24378: resolve-ChangeLogs should use git status or svn status to find...
ddkilzer@apple.com [Thu, 12 Mar 2009 14:46:05 +0000 (14:46 +0000)]
    Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs

        <https://bugs.webkit.org/show_bug.cgi?id=24378>

        Reviewed by Adam Roben.

        * Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
        and no file or directory names are specified on the command-line
        then try to find unmerged ChangeLog files based on 'svn stat' or
        'git diff'.  Added global $isGit and $isSVN variables so that
        isGit() and isSVN() only have to be called once.
        (findUnmergedChangeLogs): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 13:18:42 +0000 (13:18 +0000)]
2009-03-12  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=24254
        [GTK] spacebar doesn't scroll down

        Make spacebar and shift+spacebar scroll like page up and down
        respectively would.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 12 Mar 2009 12:42:09 +0000 (12:42 +0000)]
2009-03-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 24110: cloneNode should call cloneElement and not the reverse

        - Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren.
          Now cloneNode calls one of the 2 previous methods.

        - Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.

        - Moved cloneNode to the Element private section so that WebCore callers cannot use it.

        - Removed Element::cloneNode usage through WebCore.

        * dom/Element.cpp:
        (WebCore::Element::cloneNode): Moved to Element's private section and it
        now calls the two next methods.
        (WebCore::Element::cloneElementWithChildren): Added.
        (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement
        to avoid ambiguity.
        * dom/Element.h:

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement
        to call to cloneElementWithoutChildren.
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply): Ditto.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Ditto.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::doApply): Ditto.
        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Ditto.
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildShadowTree): Ditto.
        (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 12 Mar 2009 11:08:22 +0000 (11:08 +0000)]
2009-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Fixed a crash on the 1x1 pixel check for background image in gtk.
        We need to load the image first and need to be sure that the image
        is not null before checking the type.

        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 12 Mar 2009 08:46:07 +0000 (08:46 +0000)]
2009-03-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24544
        Rename setUrl to setURL

        Use proper case for setUrl method, rename it to setURL.

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        * platform/network/ResourceResponseBase.h:
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::writeCallback):
        (WebCore::headerCallback):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 12 Mar 2009 07:58:03 +0000 (07:58 +0000)]
2009-03-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24519
        [GTK] Use two argument KURL ctor in ResourceHandleSoup

        Use two argument KURL ctor, the single argument ctor expects its
        input to be the output of a previous KURL::parse call, which is
        not the case here.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 12 Mar 2009 07:41:33 +0000 (07:41 +0000)]
2009-03-11  Jon Honeycutt  <jhoneycutt@apple.com>

        Fix for <rdar://6418681>
        https://bugs.webkit.org/show_bug.cgi?id=22644

        Reviewed by Steve Falkenburg.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
        Client plug-in to the blacklist; it requires a Mozilla-based browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix
oliver@apple.com [Thu, 12 Mar 2009 07:26:43 +0000 (07:26 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
oliver@apple.com [Thu, 12 Mar 2009 06:39:38 +0000 (06:39 +0000)]
<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4

Reviewed by Adele Peterson.

A number of dashboard widgets rely on canvas failing silently when given invalid
colors for gradient stops, but both the spec and firefox throw exceptions here.
So we work around this by creating a dashboard quirk that will only suppress the
exception in dashboard compatibility mode.

Test: fast/canvas/canvas-gradient-addStop-error.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove duplicate header include
ddkilzer@apple.com [Thu, 12 Mar 2009 06:02:10 +0000 (06:02 +0000)]
    Remove duplicate header include

        Rubber-stamped by Mark Rowe.

        * WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>.
        Also realphabetized lowercase #include statements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Clarify comments regarding order of FEATURE_DEFINES
ddkilzer@apple.com [Thu, 12 Mar 2009 05:14:55 +0000 (05:14 +0000)]
    Clarify comments regarding order of FEATURE_DEFINES

        Rubber-stamped by Mark Rowe.

JavaScriptCore:

        * Configurations/JavaScriptCore.xcconfig: Added warning about
        the consequences when FEATURE_DEFINES are not kept in sync.

WebCore:

        * Configurations/WebCore.xcconfig: Added warning about the
        consequences when FEATURE_DEFINES are not kept in sync.

WebKit/mac:

        * Configurations/WebKit.xcconfig: Added warning about the
        consequences when FEATURE_DEFINES are not kept in sync.

WebKitTools:

        * Scripts/build-webkit: Added warning about keeping
        FEATURE_DEFINES in order and the consequences when they are not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 12 Mar 2009 04:27:42 +0000 (04:27 +0000)]
2009-03-11  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24515
        [GTK] soup backend should use GMappedFile instead of mmap directly

        Rewrite mmap code used to upload files to use GMappedFile, so that
        it is platform-independent.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 12 Mar 2009 04:06:24 +0000 (04:06 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
mitz@apple.com [Thu, 12 Mar 2009 03:39:14 +0000 (03:39 +0000)]
JavaScriptCore:

        Reviewed by Darin Adler.

        - WTF support for fixing <rdar://problem/3919124> Thai text selection
          in Safari is incorrect

        * wtf/unicode/icu/UnicodeIcu.h:
        (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns
        whether the character has Unicode line breaking property value SA
        ("Complex Context").
        * wtf/unicode/qt4/UnicodeQt4.h:
        (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an
        implementation that always returns false.

WebCore:

        Reviewed by Darin Adler.

        - WebCore part of fixing <rdar://problem/3919124> Thai text selection
          in Safari is incorrect

        Test: platform/mac/editing/selection/word-thai.html

        Tested on Mac, but should work on all ICU platforms (or more precisely
        on all platforms that implement
        WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).

        * editing/TextIterator.cpp:
        (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
        Added.
        (WebCore::BackwardsCharacterIterator::range): Added.
        (WebCore::BackwardsCharacterIterator::advance): Added.

        * editing/TextIterator.h: Added BackwardsCharacterIterator with the
        minimal functionality required for this patch.
        (WebCore::BackwardsCharacterIterator::atEnd): Added.

        * editing/visible_units.cpp:
        (WebCore::firstNonComplexContextLineBreak): Added this helper function
        that returns the index of the first character in the string whose
        Unicode line breaking property value is not SA ("Complex Context"), or
        the length of the string if there is no such character.
        (WebCore::lastNonComplexContextLineBreak): Added this helper function
        that returns the index of the last character in the string whose
        Unicode line breaking property value is not SA ("Complex Context"), or
        -1 if there is no such character.
        (WebCore::previousBoundary): Changed the signature of the search
        function to include an offset parameter. Renamed the 'exception' local
        variable to 'ec' and changed its type to ExceptionCode. Extend the
        string forwards until the first character with Unicode line breaking
        property value other than SA. This gives the boundary search function
        enough context in the forward direction. Changed to use a
        BackwardsCharacterIterator for translating the backwards offset into
        a position.
        (WebCore::nextBoundary): Changed the signature of the search
        function to include an offset parameter. Extend the string backwards
        until the first character with Unicode line breaking property value
        other than SA. This gives the boundary search function enough context in
        the backwards direction. Restricted the workaround for <rdar://5192593>
        only to the line break case, because it was causing an extra character
        to be selected following a word that ended with a combining mark.
        (WebCore::startWordBoundary): Added an offset parameter. Check that
        going backwards from the given offset, there is a character with Unicode
        line breaking property value other than SA, and otherwise return 0 to
        request more context.
        (WebCore::endWordBoundary): Similar, but in reverse.
        (WebCore::previousWordPositionBoundary): Similar.
        (WebCore::nextWordPositionBoundary): Similar.
        (WebCore::startSentenceBoundary): Updated for the new search function
        signature.
        (WebCore::endSentenceBoundary): Ditto.
        (WebCore::previousSentencePositionBoundary): Ditto.
        (WebCore::nextSentencePositionBoundary): Ditto.

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/3919124> Thai text selection in Safari is
          incorrect

        * platform/mac/editing/selection/word-thai-expected.txt: Added.
        * platform/mac/editing/selection/word-thai.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 12 Mar 2009 01:29:07 +0000 (01:29 +0000)]
2009-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Don't use "::" in thread names because it is ugly!

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
        it clear this is a WebCore-created thread.
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 12 Mar 2009 01:26:55 +0000 (01:26 +0000)]
2009-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Give threads names on platforms with pthread_setname_np.

        * wtf/Threading.cpp:
        (WTF::NewThreadContext::NewThreadContext): Initialize thread name.
        (WTF::threadEntryPoint): Call setThreadNameInternal.
        (WTF::createThread): Pass thread name.

        * wtf/Threading.h: Added new comments, setThreadNameInternal.

        * wtf/ThreadingGtk.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingNone.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingPthreads.cpp:
        (WTF::setThreadNameInternal): Call pthread_setname_np when available.
        * wtf/ThreadingQt.cpp:
        (WTF::setThreadNameInternal): Added. Empty.
        * wtf/ThreadingWin.cpp:
        (WTF::setThreadNameInternal): Added. Empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly...
mrowe@apple.com [Thu, 12 Mar 2009 00:53:21 +0000 (00:53 +0000)]
<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex

Rubber-stamped by Darin Adler.

* platform/mac/PlatformScreenMac.mm:
(WebCore::screenIsMonochrome): Return false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Mar 2009 00:51:45 +0000 (00:51 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24531

        Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
        returns a null style if it has a valid renderer, which could happen if a
        CompositeAnimation existed, but wasn't running any animations or transitions.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Wed, 11 Mar 2009 23:25:32 +0000 (23:25 +0000)]
WebCore:

2009-03-11  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
        top value on position:relative child not calculated correctly if
        parent has percentage height
        - and corresponding -
        <rdar://problem/6172925>

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

2009-03-11  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Test for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
        top value on position:relative child not calculated correctly if
        parent has percentage height
        - and corresponding -
        <rdar://problem/6172925>

        * fast/css/percent-top-value-with-relative-position.html: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.checksum: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.png: Added.
        * platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jian Li <jianli@chromium.org>
levin@chromium.org [Wed, 11 Mar 2009 21:54:23 +0000 (21:54 +0000)]
2009-03-11  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement ScriptValue::hasNoValue for V8.
        https://bugs.webkit.org/show_bug.cgi?id=24507

        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::hasNoValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 11 Mar 2009 21:54:17 +0000 (21:54 +0000)]
2009-03-11  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 24459: Add v8 bindings for event.
        <https://bugs.webkit.org/show_bug.cgi?id=24459>

        Adding custom event bindings.

        * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
        * bindings/v8/custom/V8AbstractEventListener.h: Added.
        * bindings/v8/custom/V8AttrCustom.cpp:
        Fixed messed up copyright header.
        * bindings/v8/custom/V8CustomEventListener.cpp: Added.
        * bindings/v8/custom/V8CustomEventListener.h:
        Replaced forwarding header with the real implementation.
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8LazyEventListener.cpp: Added.
        * bindings/v8/custom/V8LazyEventListener.h: Added.
        * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
        * bindings/v8/custom/V8ObjectEventListener.h: Added.
        * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
        * bindings/v8/custom/V8WorkerContextEventListener.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 11 Mar 2009 21:40:49 +0000 (21:40 +0000)]
2009-03-11  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24521
        Add some missing includes for the non-JSC build.

        * platform/text/PlatformString.h: added OwnPtr.h
        * xml/XMLHttpRequest.cpp: added SecurityOrigin.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Pamela Greene <pam@chromium.org>
pam@chromium.org [Wed, 11 Mar 2009 21:17:03 +0000 (21:17 +0000)]
2009-03-11  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test for potential crash in window.frames.length
        These files were accidentally left out of r41459.

        https://bugs.webkit.org/show_bug.cgi?id=24339

        * fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
        * fast/dom/Window/window-collection-length-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 11 Mar 2009 20:58:54 +0000 (20:58 +0000)]
2009-03-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6656147>.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Pass the requestID to _WKPHInstantiatePlugin.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        Pass the requestID to setCurrentReply.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
        Store the reply in a map with the requestID as the key.

        (WebKit::NetscapePluginInstanceProxy::waitForReply):
        Wait for a reply that matches the given requestID.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Initialize member variables.

        (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
        Delete all requests.

        (WebKit::NetscapePluginInstanceProxy::print):
        Pass the requestID to _WKPHPluginInstancePrint.

        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        Rename m_currentRequestID to m_currentURLRequestID.

        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        Process requests until we find a reply with the right requestID.

        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Pass a requestID to the _WKPH function.

        (WebKit::NetscapePluginInstanceProxy::nextRequestID):
        Ditto.

        * Plugins/Hosted/ProxyInstance.mm:
        Pass a requestID to the _WKPH functions.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add requestID parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 20:41:29 +0000 (20:41 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Fix Scons build. Patch from Alexander Guy.

        * WebCore.scons:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Export functions needed by ThreadSpecific from WebKit
aroben@apple.com [Wed, 11 Mar 2009 20:39:34 +0000 (20:39 +0000)]
    Export functions needed by ThreadSpecific from WebKit

        Reviewed by John Sullivan.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        Export WTF::tlsKeyCount and WTF::tlsKeys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Change the Windows implementation of ThreadSpecific to use functions instead...
aroben@apple.com [Wed, 11 Mar 2009 20:39:21 +0000 (20:39 +0000)]
    Change the Windows implementation of ThreadSpecific to use functions instead of extern globals

        This will make it easier to export ThreadSpecific from WebKit.

        Reviewed by John Sullivan.

        * API/JSBase.cpp:
        (JSEvaluateScript):
        Touched this file to force ThreadSpecific.h to be copied into
        $WebKitOutputDir.

        * wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount()
        and g_tls_keys with tlsKeys().

        (WTF::::ThreadSpecific):
        (WTF::::~ThreadSpecific):
        (WTF::::get):
        (WTF::::set):
        (WTF::::destroy):
        Updated to use the new functions.

        * wtf/ThreadSpecificWin.cpp:
        (WTF::tlsKeyCount):
        (WTF::tlsKeys):
        Added.

        (WTF::ThreadSpecificThreadExit): Changed to use the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:45:18 +0000 (19:45 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24366

        Make this test more reliable by only calling runAnimationTest() once
        the animation starts, not before some setTimeout().

        * animations/change-keyframes-name-expected.txt:
        * animations/change-keyframes-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 11 Mar 2009 19:09:14 +0000 (19:09 +0000)]
2009-03-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6620064>.

        * Plugins/WebPluginContainerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:04:31 +0000 (19:04 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24266

        Land new expected results for transform-absolute-in-positioned-container.html,
        and new pixel results for reflection-masks.html. Both are progressions.

        * platform/mac/fast/reflections/reflection-masks-expected.checksum:
        * platform/mac/fast/reflections/reflection-masks-expected.png:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
        * platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 19:00:13 +0000 (19:00 +0000)]
2009-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23093

        When the cancel button in the search field is shown or hidden,
        we need to explicitly setStyle() on the cancel button's renderer,
        to ensure that repaint happens. Changing the style without telling
        the renderer won't work.

        Test: fast/repaint/search-field-cancel.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
        (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
        (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Marc-André Decoste <mad@chromium.org>
pam@chromium.org [Wed, 11 Mar 2009 17:58:06 +0000 (17:58 +0000)]
2009-03-11  Marc-AndrĂ© Decoste  <mad@chromium.org>

        Reviewed by Eric Seidel.

        Fixed the positions of the list boxes so that the size of their
        rendering doesn't affect the test coordinates.
        https://bugs.webkit.org/show_bug.cgi?id=24006

        * fast/forms/option-mouseevents-expected.txt:
        * fast/forms/option-mouseevents.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Hironori Bono <hbono@chromium.org>
ap@webkit.org [Wed, 11 Mar 2009 16:05:04 +0000 (16:05 +0000)]
2009-03-11  Hironori Bono  <hbono@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=15790
        Ligatures aren't accounted for when manipulating VisiblePositions

        Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
        Indic ligature which uses a virama sign.

        Test: editing/deleting/skip-virama-001.html

        * platform/text/TextBreakIteratorICU.cpp:
        (WebCore::cursorMovementIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by George Staikos.
ap@webkit.org [Wed, 11 Mar 2009 15:46:38 +0000 (15:46 +0000)]
    Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24513
        REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)

        Fixes existing tests on Tiger.

        * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
        Use characterBreakIterator on Tiger (like we used to do).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:53:11 +0000 (14:53 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Only run code in dispose once per instance.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:53:01 +0000 (14:53 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Call deref() on our internal HistoryItem on dispose, as we always
        acquire it with a releaseRef() call to a PassRefPtr, which passes
        ownership.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 11 Mar 2009 14:52:49 +0000 (14:52 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        return foo? foo : NULL == return foo

        * webkit/webkitwebhistoryitem.cpp:
        (WebKit::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 12:27:42 +0000 (12:27 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Enable http/tests/security/cross-frame-access-private-browsing.html test.

        * platform/gtk/Skipped:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Add private browsing option "enable-private-browsing" to WebKitWebSettings.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=24487

        Also reset WebSettings to its default state for JavaScript
        profiling, Developer Extras and Private Browsing before running
        the test (can be after each test but we want to be consistent with
        other ports in this regard)

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        (runTest):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setPrivateBrowsingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 12:06:06 +0000 (12:06 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] BackForward history leak?
        https://bugs.webkit.org/show_bug.cgi?id=19528

        Don't ref the history items when returning the back/forward list
        Added test_webkit_web_history_item_lifetime test case for this.

        * tests/main.c:
        (test_webkit_web_history_item_lifetime):
        (test_webkit_web_back_forward_list_order): Style fix.
        (test_webkit_web_back_forward_list_add_item): Style fix.
        (main):
        * webkit/webkitwebbackforwardlist.cpp:
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 11 Mar 2009 11:58:20 +0000 (11:58 +0000)]
    Reviewed by Oliver Hunt.

        <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
        in instancesRespondToSelector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 11:57:43 +0000 (11:57 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Fix make clean targets
        https://bugs.webkit.org/show_bug.cgi?id=24450

        Fix 'make' clean targets. We shouldn't be removing DerivedSources
        if it's only clean. Only remove it if it's distclean or
        maintainer-clean. Also remove build-related auxillary files on
        dist/maintainer clean.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 11 Mar 2009 11:52:44 +0000 (11:52 +0000)]
2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        pangoft2 is also used in directfb builds so use it for all targets

        * configure.ac:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        Add missing stdio.h include to get the build going

        * plugins/gtk/PluginPackageGtk.cpp:

2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
        https://bugs.webkit.org/show_bug.cgi?id=2260

        Add plugin support only for X11 builds

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (setDefaultsToConsistentStateValuesForTesting):
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Wed, 11 Mar 2009 06:46:05 +0000 (06:46 +0000)]
2009-03-10  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Ken Kocienda.

        * dom/Range.cpp:
        (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
        would include rects for the divs contents.  Set the correct RenderObject to stop at.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 11 Mar 2009 06:28:33 +0000 (06:28 +0000)]
    Reviewed by Sam Weinig.

        <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR

WebCore:
        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
        comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
        there are security concerns with exposing them for cross-origin requests, so it's not clear
        if we want to change anything here.

LayoutTests:
        * http/tests/security/cookies/xmlhttprequest.html: We don't expose cookies for documents
        retrieved via XMLHttpRequest. Added a check to make sure that we don't forget about cross-
        origin restrictions if we ever decide to change that.

        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi: While at it, fixed a broken check
        for Set-Cookie2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Mar 2009 05:43:58 +0000 (05:43 +0000)]
2009-03-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24503

        Fix hit testing of absolutely positioned single line text controls by
        ensuring that we set result.innerNode() correctly. If the hit node is
        a descendant of the inner text element or if it is the <input> itself,
        then we say we hit the innerTextElement.

        Rename hitInnerTextBlock() to hitInnerTextElement() to match the
        'innerTextElement' terminology used elsewhere.

        Assert that if renderer()->hitTest() returns false, no-one set
        result.innerNode().

        Test: fast/forms/search-abs-pos-cancel-button.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestContents):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 11 Mar 2009 02:20:32 +0000 (02:20 +0000)]
2009-03-10  Antti Koivisto  <antti@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

        Another case where we would trigger extended encoding loading needlessly.

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::isNonByteBasedEncoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
justin.garcia@apple.com [Wed, 11 Mar 2009 00:08:32 +0000 (00:08 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Wed, 11 Mar 2009 00:05:24 +0000 (00:05 +0000)]
WebCore:

2009-03-10  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
        scroll bar appears for long line of text with NOWRAP set

        This is a regression from http://trac.webkit.org/changeset/32226
        I talked with Dan about the original change, and we decided that
        the best fix was to remove his small potential-optimization that
        only created a separate line box for whitespace under certain
        circumstances. This new code will always create a separate line
        box.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

2009-03-10  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB):
        No scroll bar appears for long line of text with NOWRAP set

        New test:
        * fast/inline/long-wrapped-line.html: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
        * platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.

        These tests all have changed results from the patch. Now trailing
        whitespace always has its own linebox instead of sometimes sharing
        a linebox with text.
        * platform/mac/editing/deleting/5206311-1-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/execCommand/5482023-expected.txt:
        * platform/mac/editing/execCommand/boldSelection-expected.txt:
        * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
        * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * platform/mac/editing/execCommand/print-expected.txt:
        * platform/mac/editing/execCommand/selectAll-expected.txt:
        * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
        * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
        * platform/mac/editing/inserting/12882-expected.txt:
        * platform/mac/editing/inserting/editable-html-element-expected.txt:
        * platform/mac/editing/inserting/insert-div-019-expected.txt:
        * platform/mac/editing/inserting/insert-div-020-expected.txt:
        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/inserting/insert-div-022-expected.txt:
        * platform/mac/editing/inserting/insert-div-023-expected.txt:
        * platform/mac/editing/inserting/insert-div-024-expected.txt:
        * platform/mac/editing/inserting/insert-div-025-expected.txt:
        * platform/mac/editing/inserting/insert-div-027-expected.txt:
        * platform/mac/editing/inserting/typing-003-expected.txt:
        * platform/mac/editing/pasteboard/4989774-expected.txt:
        * platform/mac/editing/pasteboard/5028447-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
        * platform/mac/editing/selection/4947387-expected.txt:
        * platform/mac/editing/selection/4983858-expected.txt:
        * platform/mac/editing/selection/5081257-1-expected.txt:
        * platform/mac/editing/selection/5081257-2-expected.txt:
        * platform/mac/editing/selection/5136696-expected.txt:
        * platform/mac/editing/selection/5234383-1-expected.txt:
        * platform/mac/editing/selection/5234383-2-expected.txt:
        * platform/mac/editing/selection/7152-1-expected.txt:
        * platform/mac/editing/selection/7152-2-expected.txt:
        * platform/mac/editing/selection/after-line-wrap-expected.txt:
        * platform/mac/editing/selection/click-start-of-line-expected.txt:
        * platform/mac/editing/selection/drag-in-iframe-expected.txt:
        * platform/mac/editing/selection/editable-html-element-expected.txt:
        * platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
        * platform/mac/editing/selection/end-of-document-expected.txt:
        * platform/mac/editing/selection/extend-by-character-003-expected.txt:
        * platform/mac/editing/selection/extend-by-character-005-expected.txt:
        * platform/mac/editing/selection/extend-by-word-002-expected.txt:
        * platform/mac/editing/selection/mixed-editability-1-expected.txt:
        * platform/mac/editing/selection/move-by-character-003-expected.txt:
        * platform/mac/editing/selection/move-by-character-005-expected.txt:
        * platform/mac/editing/selection/select-all-001-expected.txt:
        * platform/mac/editing/selection/select-all-002-expected.txt:
        * platform/mac/editing/selection/select-all-003-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
        * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
        * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
        * platform/mac/editing/style/create-block-for-style-001-expected.txt:
        * platform/mac/editing/style/create-block-for-style-002-expected.txt:
        * platform/mac/editing/style/create-block-for-style-003-expected.txt:
        * platform/mac/editing/style/create-block-for-style-004-expected.txt:
        * platform/mac/editing/style/create-block-for-style-005-expected.txt:
        * platform/mac/editing/style/create-block-for-style-006-expected.txt:
        * platform/mac/editing/style/create-block-for-style-007-expected.txt:
        * platform/mac/editing/style/create-block-for-style-008-expected.txt:
        * platform/mac/editing/style/create-block-for-style-009-expected.txt:
        * platform/mac/editing/style/create-block-for-style-010-expected.txt:
        * platform/mac/editing/style/create-block-for-style-011-expected.txt:
        * platform/mac/editing/style/create-block-for-style-012-expected.txt:
        * platform/mac/editing/style/create-block-for-style-013-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-001-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-004-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:
        * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
        * platform/mac/fast/clip/outline-overflowClip-expected.txt:
        * platform/mac/fast/forms/negativeLineHeight-expected.txt:
        * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
        * platform/mac/fast/lists/drag-into-marker-expected.txt:
        * platform/mac/fast/parser/comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
        * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
        * platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
        * platform/mac/fast/repaint/selection-after-delete-expected.txt:
        * platform/mac/fast/repaint/selection-after-remove-expected.txt:
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
        * platform/mac/fast/text/trailing-white-space-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
        * platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
        * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
        * platform/mac/http/tests/navigation/post-goback2-expected.txt:
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
        * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
        * platform/mac/http/tests/navigation/success200-goback-expected.txt:
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 10 Mar 2009 23:57:14 +0000 (23:57 +0000)]
2009-03-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6166844>
        https://bugs.webkit.org/show_bug.cgi?id=24495

        Use same rule for loading java applets as we do for images.

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build.
justin.garcia@apple.com [Tue, 10 Mar 2009 23:23:48 +0000 (23:23 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Tue, 10 Mar 2009 22:59:07 +0000 (22:59 +0000)]
2009-03-10  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by David Kilzer.

        Get rid of revealCaret and use revealSelection instead.

        * WebCore.base.exp:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 10 Mar 2009 22:48:46 +0000 (22:48 +0000)]
2009-03-10  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Geoff Garen.

        Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
        <https://bugs.webkit.org/show_bug.cgi?id=24291>
        <rdar://problem/6663472>

        Add an extra newline to the end of the body of the program text constructed
        by the Function constructor for parsing. This allows single line comments to
        be handled correctly by the parser.

        JavaScriptCore:

        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):

        LayoutTests:

        * fast/events/onload-single-line-comment-expected.txt: Added.
        * fast/events/onload-single-line-comment.html: Added.
        * fast/js/function-constructor-single-line-comment-expected.txt: Added.
        * fast/js/function-constructor-single-line-comment.html: Added.
        * fast/js/resources/function-constructor-single-line-comment.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory...
sfalken@apple.com [Tue, 10 Mar 2009 21:46:32 +0000 (21:46 +0000)]
    <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults

        Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.

        This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
        The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
        saying there was browsing history for a particular day, and then return no history items when we requested a
        list of sites visited that day.

        Reviewed by Ada Chan.

        * MarshallingHelpers.cpp:
        (MarshallingHelpers::DATEToCFAbsoluteTime):
        (MarshallingHelpers::CFAbsoluteTimeToDATE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 10 Mar 2009 19:49:47 +0000 (19:49 +0000)]
2009-03-10  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Geoff Garen.

        Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
        <https://bugs.webkit.org/show_bug.cgi?id=23736>
        <rdar://problem/6560278>

        Before replacing the document, FrameLoader::executeIfJavaScriptURL()
        should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().

        WebCore:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):

        LayoutTests:

        * http/tests/misc/javascript-url-stop-loaders-expected.txt: Added.
        * http/tests/misc/javascript-url-stop-loaders.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 10 Mar 2009 19:31:22 +0000 (19:31 +0000)]
WebCore:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24494: crash when deleting at end of document and merging paragraphs
        https://bugs.webkit.org/show_bug.cgi?id=24494
        rdar://problem/6571537

        Test: editing/deleting/merge-at-end-of-document.html

        * dom/Range.cpp:
        (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
        use && in assertions since we'd like to know which condition is failing.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
        calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
        function doesn't know which value to return.

LayoutTests:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24494: crash when deleting at end of document and merging paragraphs
        https://bugs.webkit.org/show_bug.cgi?id=24494
        rdar://problem/6571537

        * editing/deleting/merge-at-end-of-document-expected.txt: Added.
        * editing/deleting/merge-at-end-of-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 10 Mar 2009 18:46:50 +0000 (18:46 +0000)]
2009-03-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel. Math checked by Oliver Hunt.

        Implement the Cairo version of the checkForSolidColor() method. This halfes the
        time to draw on 1x1 px background images.
        I added two new calls to Color for the pixel manipulation on cairo_surface's.
        They are neede to premultiply/unpremultiply the colors of the surface.

        [CAIRO] Introduce single-pixel image optimizations
        https://bugs.webkit.org/show_bug.cgi?id=17284

        * platform/graphics/Color.cpp:
        (WebCore::colorFromPremultipliedARGB):
        (WebCore::premultipliedARGBFromColor):
        * platform/graphics/Color.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Mar 2009 18:38:02 +0000 (18:38 +0000)]
2009-03-10  Adam Treat  <adam.treat@torchmobile.com>

        Build fix for Qt after r41555.

        * Api/qwebpage.cpp:
        (QWebPage::acceptNavigationRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 18:22:12 +0000 (18:22 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Use g_hash_table_new_full so we can save the manual unref on the
        values when removing them from the table.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 17:34:32 +0000 (17:34 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24493
        [GTK] Misc patches for WebKitWebHistoryItem

        Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
        guidelines.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac:
xan@webkit.org [Tue, 10 Mar 2009 17:00:57 +0000 (17:00 +0000)]
WebKit/mac:

2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review.

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):

WebKit/qt:

2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:38:53 +0000 (16:38 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        Correct return value to false instead of NULL.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 10 Mar 2009 16:23:33 +0000 (16:23 +0000)]
2009-03-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24437

        Add support for registering noAccess URL schemes:
        1-  Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
        that list upon construction (similar to how isLocal is implemented).
        2-  Make InspectorController call grantUniversalAccess on its Document's
        SecurityOrigin at the time when windowScriptObjectAvailable is called.

        This enables content such as the inspector to be loaded from a custom (non-file)
        URL, which is how Chromium loads the inspector.  It also allows other URL schemes
        to be treated like data: URLs, which Chromium utilizes for its various HTML-based
        UI panels.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * loader/FrameLoader.cpp:
        (WebCore::localSchemes):
        (WebCore::noAccessSchemes):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::isLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:19:27 +0000 (16:19 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Build fix, no review

        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (visiblePositionForTextMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-10 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 10 Mar 2009 16:10:24 +0000 (16:10 +0000)]
2009-03-10  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24491
        Rename posOffset to m_offset, get rid of accessor

        As suggested in dom/Position.h, this patch gets rid of the
        'offset()' accessor and renames posOffset to m_offset. I've used
        m_offset instead of offset to follow the style guide lines, since
        Position is still a class and not a structure. If the long term
        plan is still to make it a structure it would be pretty easy to
        just s/m_offset/offset/ globally when that is achieved.

        * dom/Position.cpp:
        (WebCore::Position::previous):
        (WebCore::Position::next):
        (WebCore::Position::atStart):
        (WebCore::Position::atEnd):
        (WebCore::Position::renderedOffset):
        (WebCore::Position::isCandidate):
        (WebCore::Position::inRenderedText):
        (WebCore::Position::isRenderedCharacter):
        (WebCore::Position::rendersInDifferentPosition):
        (WebCore::Position::leadingWhitespacePosition):
        (WebCore::Position::debugPosition):
        (WebCore::Position::formatForDebugger):
        * dom/Position.h:
        (WebCore::Position::Position):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):
        * dom/Range.cpp:
        * dom/RangeBoundaryPoint.h:
        (WebCore::RangeBoundaryPoint::position):
        (WebCore::RangeBoundaryPoint::set):
        (WebCore::RangeBoundaryPoint::setOffset):
        (WebCore::RangeBoundaryPoint::setToChild):
        (WebCore::RangeBoundaryPoint::setToStart):
        (WebCore::RangeBoundaryPoint::setToEnd):
        (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
        (WebCore::CompositeEditCommand::deleteInsignificantText):
        (WebCore::CompositeEditCommand::removePlaceholderAt):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace):
        * editing/Editor.cpp:
        (WebCore::Editor::setComposition):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::getCompositionSelection):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::input):
        (WebCore::InsertTextCommand::insertTab):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::debugPosition):
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        (WebCore::VisibleSelection::debugPosition):
        (WebCore::VisibleSelection::showTreeForThis):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions):
        (WebCore::rangeCompliantEquivalent):
        (WebCore::isFirstPositionAfterTable):
        (WebCore::isLastPositionBeforeTable):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::extentOffset):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * page/Frame.cpp:
        (WebCore::Frame::selectionLayoutChanged):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::indexForVisiblePosition):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 10 Mar 2009 14:46:42 +0000 (14:46 +0000)]
WebCore:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

        * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
        call to the one of the two overloads of this function that wasn't calling it. This fixes
        this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        * fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
        * fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 14:10:56 +0000 (14:10 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24285
        Text resource loading checks for BOM twice

        This removes TextDecoder class, since its only purpose was to check for BOM, which is
        already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
        BOM checked, but I didn't find any cases where it would significantly change behavior.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Remove TextDecoder.{h,cpp}.

        * platform/text/TextDecoder.cpp: Removed.
        * platform/text/TextDecoder.h: Removed.

        * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
        TextCodec separately.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
        (WebCore::TextResourceDecoder::setEncoding): Ditto.
        (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
        even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
        BOM again. Made this function return the detected BOM length.
        (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
        a text resource.
        (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
        resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.

        * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
        Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
        checks for BOM, which was a counter-intuitive feature.

        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::setEncoding):
        (WebCore::CachedScript::encoding):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:
        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):
        Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
        A side effect of this is that these resources will now be subject to encoding auto-detection.

        * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
        * page/Page.cpp: (WebCore::Page::userStyleSheet):
        Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
        re-usable (for repeated decoding of the same resource).

        * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 12:58:05 +0000 (12:58 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24488
        An assertion failure when updating an offline application cache after emptying caches

        Emptying appcache cannot be performed automatically, so no test.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
        storage, even if the application wasn't updated server side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6425807> Implement WorkerUtils.importScripts()
oliver@apple.com [Tue, 10 Mar 2009 09:44:30 +0000 (09:44 +0000)]
<rdar://problem/6425807> Implement WorkerUtils.importScripts()
<https://bugs.webkit.org/show_bug.cgi?id=22721>

Reviewed by Alexey Proskuryakov

Implement importScripts, currently uses a series of synchronous loads
to fetch the scripts, but this is simpler than a synchronous load of
multiple loads in parallel.  In future we'll want to switch to parallel
loading, but this will do for now.

Test: http/tests/workers/worker-importScripts.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 08:11:04 +0000 (08:11 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24462
        Move cross-origin access control code out of XMLHttpRequest

        Step 1: move preflight result cache and access control helper functions.

        No change in behavior, so no test.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/CrossOriginAccessControl.cpp: Added.
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
        (WebCore::isSimpleCrossOriginAccessRequest):
        (WebCore::createAllowedCrossOriginResponseHeadersSet):
        (WebCore::isOnAccessControlResponseHeaderWhitelist):
        (WebCore::passesAccessControlCheck):
        * loader/CrossOriginAccessControl.h: Added.
        * loader/CrossOriginPreflightResultCache.cpp: Added.
        (WebCore::parseAccessControlMaxAge):
        (WebCore::addToAccessControlAllowList):
        (WebCore::parseAccessControlAllowList):
        (WebCore::CrossOriginPreflightResultCacheItem::parse):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
        (WebCore::CrossOriginPreflightResultCache::shared):
        (WebCore::CrossOriginPreflightResultCache::appendEntry):
        (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
        * loader/CrossOriginPreflightResultCache.h: Added.
        (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
        (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
        (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 07:46:09 +0000 (07:46 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19797
        Bring the list of forbidden headers in sync with XMLHttpRequest spec draft

        Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
        XMLHttpRequest 2 draft.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
mitz@apple.com [Tue, 10 Mar 2009 07:03:45 +0000 (07:03 +0000)]
    Reviewed by Adele Peterson.

        - fix https://bugs.webkit.org/show_bug.cgi?id=23975
          <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
        scrollbar rect calculation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 10 Mar 2009 05:50:27 +0000 (05:50 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Oliver Hunt

        https://bugs.webkit.org/show_bug.cgi?id=24475

        When repainting replaced elements, need to union the selection
        and overflow rects because either may extend outside the other.

        Test: fast/repaint/transform-replaced-shadows.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24447: REGRESSION (r41508): Google Maps does not complete initialization
oliver@apple.com [Tue, 10 Mar 2009 01:09:44 +0000 (01:09 +0000)]
Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>

Reviewed by Gavin Barraclough

r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets.  This causes problems when condition loads occur in an
expression -- namely through the ?: and || operators.  This patch corrects these issues
by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.

I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug.  That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Tue, 10 Mar 2009 00:38:33 +0000 (00:38 +0000)]
2009-03-09  Stephanie Lewis  <slewis@apple.com>

        Fix build.

        * editing/Editor.cpp:
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::markAllMisspellingsAndBadGrammarInRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Kim Christensen <kimworking@gmail.com>
darin@chromium.org [Tue, 10 Mar 2009 00:22:38 +0000 (00:22 +0000)]
2009-03-09  Kim Christensen  <kimworking@gmail.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24276
        Dropdown / select boxes do not consider the windows task bar in Chromium.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 9 Mar 2009 22:34:30 +0000 (22:34 +0000)]
2009-03-09  Sam Weinig  <sam@webkit.org>

        Roll out r41393.  It has been causing failures on the bots for about a week.

        * fast/block/float/resources/se_arrow.png: Removed.
        * fast/block/float/resources/yinyang.png: Removed.
        * fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
        * fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
        * fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 9 Mar 2009 22:20:50 +0000 (22:20 +0000)]
WebCore:

        Reviewed by Adele Peterson and Dave Hyatt.

        - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
          misaligned edit fields

        Test: fast/forms/legend-display-none.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
        property of legend elements to 'block' unless it is 'none'.
        * css/html4.css: Do not force the display property of legend elements to
        'block' using CSS, because that prevents style rules from setting it to
        'none'.

LayoutTests:

        Reviewed by Adele Peterson and Dave Hyatt.

        - test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
          misaligned edit fields

        * fast/forms/legend-display-none-expected.txt: Added.
        * fast/forms/legend-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Mon, 9 Mar 2009 21:01:54 +0000 (21:01 +0000)]
WebCore:

2009-03-09  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23024

        Fix an incorrect criteria in the if statement that leaves references to
        deleted floating objects in RenderBlock.

        Test: fast/block/float/crash-on-absolute-positioning.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

2009-03-09  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23024

        Added regression test for a bug that causes crashes.

        * fast/block/float/crash-on-absolute-positioning.html: Added.
        * platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 9 Mar 2009 21:01:42 +0000 (21:01 +0000)]
2009-03-09  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 23175: String and UString should be able to share a UChar* buffer.
        <https://bugs.webkit.org/show_bug.cgi?id=23175>

        Add CrossThreadRefCounted.

        * wtf/CrossThreadRefCounted.h: Added.
        (WTF::CrossThreadRefCounted::create):
        (WTF::CrossThreadRefCounted::isShared):
        (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe):
        (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread):
        (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
        (WTF::CrossThreadRefCounted::~CrossThreadRefCounted):
        (WTF::CrossThreadRefCounted::ref):
        (WTF::CrossThreadRefCounted::deref):
        (WTF::CrossThreadRefCounted::release):
        (WTF::CrossThreadRefCounted::copy):
        (WTF::CrossThreadRefCounted::threadSafeDeref):
        * wtf/RefCounted.h:
        * wtf/Threading.h:
        (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase):
        (WTF::ThreadSafeSharedBase::derefBase):
        (WTF::ThreadSafeShared::ThreadSafeShared):
        (WTF::ThreadSafeShared::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:22 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 idl file.
        https://bugs.webkit.org/show_bug.cgi?id=24424

        * page/Location.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:16 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 for History.idl.

        * page/History.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:10 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 implementations of DOMWindow.idl.

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 9 Mar 2009 18:39:52 +0000 (18:39 +0000)]
2009-03-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        WebKit side of <rdar://problem/6530007>

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEnumerate):
        Call NetscapePluginInstanceProxy::enumerate.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::enumerate):
        Enumerate the JS object and serialize its values.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::getPropertyNames):
        Ask the plug-in host to get the property names and deserialize them.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 18:06:10 +0000 (18:06 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24163

        Implement mapping of FloatQuads through 3D transforms.

        Removed the redundant localToContainerQuad() methods, which can now
        shared code with the old mapLocalToAbsolutePoint(), which was
        renamed to mapLocalToContainer(). This can now convert a point,
        and optionally a FloatQuad, which are carried along in the TransformState.

        Optimized TransformState to reduce to simple FloatPoint.move()
        if there are no transforms, and to heap-allocate a transform only if
        necessary to accumulate transforms (when using preserve-3d).

        Tested by 3d point mapping tests, and the inspector highlight (which now shows
        the correct quads for 3d-transformed elements).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 17:01:29 +0000 (17:01 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24433

        During hit testing with transforms, if a layer has backface-visibility: hidden,
        we need to check for it whether or not the layer has a transform, because it
        might be an ancestor that is transformed.

        Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 16:53:32 +0000 (16:53 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt and Cameron Zwarich

        https://bugs.webkit.org/show_bug.cgi?id=24440

        The sublayer added to WebHTMLView to host accelerated compositing layers needs to
        be a subclass of NSView which allows context menu clicks through.

        * WebView/WebHTMLView.mm:
        (-[WebLayerHostingView rightMouseDown:]):
        (-[WebHTMLView attachRootLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
treat@webkit.org [Mon, 9 Mar 2009 16:37:43 +0000 (16:37 +0000)]
2009-03-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24353
        Allow to overrule default build options for Qt build.

        * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
        * JavaScriptCore.pri: Allow to overrule ENABLE_JIT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 9 Mar 2009 16:32:21 +0000 (16:32 +0000)]
2009-03-09  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24463
        WebCore::qstring is detaching and copying twice for every single
        WebCore::TextRun that is processed and drawn.  This elevates this method
        to one of the top-ten most expensive methods in all of QtWebKit according
        to profiling.  This changes the method so that QString only detaches
        when absolutely necessary.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::qstring):
        (WebCore::fixSpacing):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Mon, 9 Mar 2009 06:29:27 +0000 (06:29 +0000)]
2009-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber-stamped by Mark Rowe.

        [Gtk] Skip failing tests that require the eventSender.

        The Gtk+ platform is lacking an implementation of the
        eventSender. We will enable the tests once there is an
        implementation of that class.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSplit ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
mrowe@apple.com [Mon, 9 Mar 2009 05:36:31 +0000 (05:36 +0000)]
Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
Frame.h no longer needs to include it.  This cuts the size of the symbols
for a debug build by around 3%.

Reviewed by Oliver Hunt.

* dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
(WebCore::Frame::revealCaret):
* page/Frame.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::autoscroll):
* rendering/RenderLayer.h:
* rendering/ScrollBehavior.cpp: Added.
(WebCore::):
* rendering/ScrollBehavior.h: Added.
(WebCore::):
(WebCore::ScrollAlignment::getVisibleBehavior):
(WebCore::ScrollAlignment::getPartialBehavior):
(WebCore::ScrollAlignment::getHiddenBehavior):

Add the new files to the build systems:
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:

Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
* dom/Clipboard.cpp:
* editing/EditorCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/TypingCommand.cpp:
* html/HTMLFormControlElement.cpp:
* loader/archive/cf/LegacyWebArchive.cpp:
* loader/icon/IconLoader.cpp:
* page/animation/AnimationController.cpp:
* rendering/RenderSlider.cpp:
* rendering/RenderTextControl.cpp:

WebKit/mac:
* Plugins/WebNetscapePluginView.mm:
* WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

WebKit/win:
* WebView.cpp:
(WebView::centerSelectionInVisibleArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPush the include of Frame.h out of RenderView.h and down to those files
mrowe@apple.com [Mon, 9 Mar 2009 03:44:38 +0000 (03:44 +0000)]
Push the include of Frame.h out of RenderView.h and down to those files
that need it.  This cuts the size of symbols for RenderFoo object files
by around 15% in a debug build.

Reviewed Dan Bernstein.

* bindings/objc/DOM.mm:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderReplaced.cpp:
* rendering/RenderText.cpp:
* rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some unnecessary or redundant includes from files related to the JS bindings.
mrowe@apple.com [Mon, 9 Mar 2009 03:18:08 +0000 (03:18 +0000)]
Remove some unnecessary or redundant includes from files related to the JS bindings.
This cuts the size of the symbols for a debug build by around 3%.

Rubber-stamped by Dan Bernstein.

* bindings/js/JSCustomPositionCallback.cpp:
* bindings/js/JSCustomPositionErrorCallback.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/JSSVGPODTypeWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled
zecke@webkit.org [Mon, 9 Mar 2009 03:17:11 +0000 (03:17 +0000)]
[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled

setJavaScriptProfilingEnabled is implemented by enabling the
developer extras using the WebKitWebSettings and adding the
JavaScript Profiling option to the WebKitWebInspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Mar 2009 23:21:14 +0000 (23:21 +0000)]
2009-03-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
        and provisionalHistoryItem() from FrameLoader.

        * WebCore.base.exp:
        * WebCore.order:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::frameLoadCompleted):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 8 Mar 2009 19:35:54 +0000 (19:35 +0000)]
2009-03-08  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        Implement proper logging for the GTK+ port, inspired by the one in
        Qt. We use the WEBKIT_DEBUG environment variable which was already
        being used to decide whether to setup a logger for soup or not.

        * platform/gtk/LoggingGtk.cpp:
        (WebCore::getChannelFromName):
        (WebCore::InitializeLoggingChannelsIfNecessary):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ensureSessionIsInitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
oliver@apple.com [Sun, 8 Mar 2009 13:01:30 +0000 (13:01 +0000)]
Build fix.

Reviewed by NOBODY(Build fix)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24268: RuntimeArray is not a fully implemented JSArray
oliver@apple.com [Sun, 8 Mar 2009 10:47:01 +0000 (10:47 +0000)]
Bug 24268: RuntimeArray is not a fully implemented JSArray
<https://bugs.webkit.org/show_bug.cgi?id=24268>

Reviewed by Cameron Zwarich.

Don't cast a type to JSArray, just because it reportsArray as a supertype
in the JS type system.  Doesn't appear feasible to create a testcase
unfortunately as setting up the failure conditions requires internal access
to JSC not present in DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 8 Mar 2009 00:05:05 +0000 (00:05 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - WebCore part of removing build-time and run-time support for legacy
          versions of CFNetwork and Core Graphics

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::platformDataInit):
        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::setHTTPBody):
        (WebCore::httpBodyFromRequest):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::didSendBodyData):
        (WebCore::shouldUseCredentialStorageCallback):
        (WebCore::ResourceHandle::start):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::filterCookies):

WebKit/win:

        Reviewed by Mark Rowe.

        - WebKit part of removing build-time and run-time support for legacy
          versions of CFNetwork and Core Graphics

        * WebView.cpp:
        (WebView::setCacheModel):

WebKitLibraries:

        Reviewed by Mark Rowe.

        - WebKitSystemInterface part of removing build-time and run-time support
          for legacy versions of CFNetwork and Core Graphics

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41517 268f45cc-cd09-0410-ab3c-d52691b4dbfc