mjs@apple.com [Mon, 24 Jan 2011 21:33:24 +0000 (21:33 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Skip a newly added test that uses textInputController
https://bugs.webkit.org/show_bug.cgi?id=53027
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 24 Jan 2011 21:02:03 +0000 (21:02 +0000)]
WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
https://bugs.webkit.org/show_bug.cgi?id=53029
Reviewed by Adam Roben.
* UIProcess/win/TextCheckerWin.cpp:
Disable the warnings for this file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 20:31:09 +0000 (20:31 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032
Fix the expected output, which still had an error.
* storage/indexeddb/objectstore-autoincrement-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 24 Jan 2011 20:22:28 +0000 (20:22 +0000)]
2011-01-24 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911
Plain refactoring, covered by the existing tests.
* WebCore.gypi: IntrusiveDOMWrapperMap.h added.
* bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/IntrusiveDOMWrapperMap.h: Added.
(WebCore::ChunkedTable::ChunkedTable):
(WebCore::ChunkedTable::add):
(WebCore::ChunkedTable::remove):
(WebCore::ChunkedTable::clear):
(WebCore::ChunkedTable::visit):
(WebCore::ChunkedTable::Chunk::Chunk):
(WebCore::ChunkedTable::clearEntries):
(WebCore::ChunkedTable::visitEntries):
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
* bindings/v8/StaticDOMDataStore.h: include added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 20:11:02 +0000 (20:11 +0000)]
2011-01-24 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[chromium] Remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=53022
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 19:43:59 +0000 (19:43 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032
This fixes the layout test by modifying the arguments to IDBDatabase::transaction.
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 19:42:08 +0000 (19:42 +0000)]
2011-01-24 Shane Stephens <shanestephens@google.com>
Reviewed by Chris Marrin.
TransformationMatrix multiply operations apply operands in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=52780
Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).
Remove TransformationMatrix::multiply, which was actually doing a multLeft.
Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".
Convert all call sites for these methods to provide operands in the correct order.
No new tests as patch adds no new functionality.
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::multiply):
* platform/graphics/transforms/Matrix3DTransformOperation.h:
(WebCore::Matrix3DTransformOperation::apply):
* platform/graphics/transforms/MatrixTransformOperation.h:
(WebCore::MatrixTransformOperation::apply):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):
(WebCore::TransformationMatrix::rotate3d):
(WebCore::TransformationMatrix::skew):
(WebCore::TransformationMatrix::applyPerspective):
(WebCore::TransformationMatrix::multiply):
(WebCore::TransformationMatrix::recompose):
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::operator*=):
(WebCore::TransformationMatrix::operator*):
* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTransformFromContainer):
* rendering/TransformState.cpp:
(WebCore::TransformState::applyTransform):
(WebCore::HitTestingTransformState::applyTransform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:33:52 +0000 (19:33 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Wait for half a second if we're asked to paint when receiving a DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=53028
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:18:43 +0000 (19:18 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement forceRedisplay in the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53026
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
* WebProcess/WebPage/DrawingAreaImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:11:58 +0000 (19:11 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fill unpainted rects with the background color.
https://bugs.webkit.org/show_bug.cgi?id=53025
* UIProcess/API/mac/WKView.mm:
(drawPageBackground):
Add new helper function.
(-[WKView drawRect:]):
Iterate over the unpainted rects and fill them with the background color.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 19:01:45 +0000 (19:01 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Nate Chapin.
IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/tutorial.html:
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Nate Chapin.
IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012
This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on public-webapps@w3.org mailing list.
We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToWebCoreDOMStringList):
* bindings/v8/V8Binding.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.idl:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 18:33:04 +0000 (18:33 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
check-webkit-style: Update exemptions following Source/ move.
https://bugs.webkit.org/show_bug.cgi?id=53017
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 24 Jan 2011 17:54:10 +0000 (17:54 +0000)]
WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
Reviewed by John Sullivan.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Mon, 24 Jan 2011 17:40:37 +0000 (17:40 +0000)]
2011-01-24 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
Move contentEditable related test cases to the right place as they are DOM
related instead of editing related.
https://bugs.webkit.org/show_bug.cgi?id=53010
* editing/editability: Removed.
* editing/editability/attr-empty-string-expected.txt: Removed.
* editing/editability/attr-empty-string.html: Removed.
* editing/editability/attr-false-string-expected.txt: Removed.
* editing/editability/attr-false-string.html: Removed.
* editing/editability/attr-invalid-string-expected.txt: Removed.
* editing/editability/attr-invalid-string.html: Removed.
* editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
* editing/editability/attr-missing-ancestor-false.html: Removed.
* editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
* editing/editability/attr-missing-ancestor-true.html: Removed.
* editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
* editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
* editing/editability/attr-missing-parent-false-expected.txt: Removed.
* editing/editability/attr-missing-parent-false.html: Removed.
* editing/editability/attr-missing-parent-true-expected.txt: Removed.
* editing/editability/attr-missing-parent-true.html: Removed.
* editing/editability/attr-true-string-expected.txt: Removed.
* editing/editability/attr-true-string.html: Removed.
* editing/editability/set-false-expected.txt: Removed.
* editing/editability/set-false.html: Removed.
* editing/editability/set-inherit-parent-false-expected.txt: Removed.
* editing/editability/set-inherit-parent-false.html: Removed.
* editing/editability/set-inherit-parent-true-expected.txt: Removed.
* editing/editability/set-inherit-parent-true.html: Removed.
* editing/editability/set-invalid-value-expected.txt: Removed.
* editing/editability/set-invalid-value.html: Removed.
* editing/editability/set-true-expected.txt: Removed.
* editing/editability/set-true.html: Removed.
* editing/editability/set-value-caseinsensitive-expected.txt: Removed.
* editing/editability/set-value-caseinsensitive.html: Removed.
* fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
* fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
* fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
* fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
* fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
* fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
* fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
* fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
* fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
* fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
* fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
* fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
* fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
* fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
* fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
* fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
* fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
* fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
* fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
* fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
* fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
* fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
* fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
* fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
* fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
* fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 24 Jan 2011 17:37:45 +0000 (17:37 +0000)]
2011-01-24 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] turn off gyp circular dependency checking and roll chromium deps
https://bugs.webkit.org/show_bug.cgi?id=52935
* DEPS:
* gyp_webkit: Turn off gyp circular dependency checking on Linux
and Win since we don't do these checks in gyp_chromium. It's
just making it harder for us to roll DEPS and have something
explode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Mon, 24 Jan 2011 17:35:21 +0000 (17:35 +0000)]
2011-01-24 Satish Sampath <satish@chromium.org>
Reviewed by Csaba Osztrogonác.
Remove obsolete public/API method in chromium port
https://bugs.webkit.org/show_bug.cgi?id=53015
* public/WebSpeechInputController.h:
(WebKit::WebSpeechInputController::startRecognition): Removed obsolete method
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 24 Jan 2011 17:29:27 +0000 (17:29 +0000)]
2011-01-24 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 24 Jan 2011 17:25:40 +0000 (17:25 +0000)]
Add editing/inserting/insert-composition-whitespace.html to the windows
skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:56:12 +0000 (16:56 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 3)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:50:00 +0000 (16:50 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 2)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:37:56 +0000 (16:37 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 1)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 24 Jan 2011 16:20:00 +0000 (16:20 +0000)]
Typo fix.
Rubber-stamped by Csaba Osztrogonác.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 24 Jan 2011 15:28:01 +0000 (15:28 +0000)]
2011-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract dispatch API from network manager.
https://bugs.webkit.org/show_bug.cgi?id=53009
* WebCore.xcodeproj/project.pbxproj:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.reset):
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
(WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._updateResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.reset):
(WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 15:20:30 +0000 (15:20 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
https://bugs.webkit.org/show_bug.cgi?id=53007
It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.
* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
* page/Page.cpp:
(WebCore::Page::Page):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 15:11:30 +0000 (15:11 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._update):
* inspector/front-end/DOMAgent.js:
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Mon, 24 Jan 2011 15:01:30 +0000 (15:01 +0000)]
[Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary
https://bugs.webkit.org/show_bug.cgi?id=49915
Reviewed by Andreas Kling.
In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
the context is saved/stored within the loop.
In the second loop the calls are also avoidable by using inverse translation on context.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 24 Jan 2011 14:46:15 +0000 (14:46 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix warnings about unregistering an invalid timer
https://bugs.webkit.org/show_bug.cgi?id=53006
The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::schedulePurge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Mon, 24 Jan 2011 14:39:58 +0000 (14:39 +0000)]
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix heap snapshot table sorting.
Fix table sorting to avoid qsort instability artefacts.
https://bugs.webkit.org/show_bug.cgi?id=52914
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._sortData):
(WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
(WebInspector.HeapSnapshotDataGridList.propertyComparator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 14:24:10 +0000 (14:24 +0000)]
Unreviewed.
RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517
* platform/qt-linux/editing: Removed.
* platform/qt-linux/editing/selection: Removed.
* platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
* platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 14:16:00 +0000 (14:16 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Mon, 24 Jan 2011 14:06:33 +0000 (14:06 +0000)]
2011-01-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Find duplicate strings in localizedStrings.js, update it.
https://bugs.webkit.org/show_bug.cgi?id=53005
* English.lproj/localizedStrings.js:
* Scripts/check-inspector-strings:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 14:05:06 +0000 (14:05 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* bindings/js/ScriptDebugServer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 13:55:59 +0000 (13:55 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: set breakpoints by line:column.
https://bugs.webkit.org/show_bug.cgi?id=52615
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::restoreBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptBreakpoint.cpp: Removed.
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get url):
* inspector/front-end/BreakpointManager.js:
(WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.continueToLine):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointSetOnBackend):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 13:05:35 +0000 (13:05 +0000)]
* runtime: Removed. It was accidentally created by r76457.
Rubber-stamped by Csaba Osztrogonác.
Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 12:58:32 +0000 (12:58 +0000)]
2011-01-24 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove CleanupHandler by passing file descriptors.
Deleting files in signal handler of UI process is not a good idea,
because the memory where filenames are stored might not be valid
after a crash.
To avoid the need of using signal handlers for cleanup,
change following:
1) Avoid passing filenames between processes, pass fds
2) When mmap'ing files, delete them immediately after
opening and mmap'ing them.
3) Pass sockets with fds during fork+exec instead of
passing them via the filesystem.
4) Use mmap'ed files for implementation of SharedMemory.
QSharedMemory does not support cleanup correctly.
Consquences:
- Move MappedMemory to SharedMemory, make UpdateChunk use this.
- Implement CoreIPC::Attachment using mmaped files.
- Send messages using datagram socket. This solution works
similiarly to Mach ports on Mac.
- Send big messages out-of-line and thus avoid increasing
the receive buffer.
- Remove MemoryMappedPool and rely on libc/kernel caching
of mmapped areas.
- Unmap memory areas after use.
- When UI process crashes, kill the web process using SIGKILL.
This is possible again because cleanup handler is not needed.
[WK2][Qt] Multiple problems with MemoryMappedPool
https://bugs.webkit.org/show_bug.cgi?id=51984
* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::Attachment):
* Platform/CoreIPC/Attachment.h:
(CoreIPC::Attachment::size):
(CoreIPC::Attachment::releaseFileDescriptor):
(CoreIPC::Attachment::fileDescriptor):
* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyOOL):
(CoreIPC::MessageInfo::isMessageBodyOOL):
(CoreIPC::MessageInfo::bodySize):
(CoreIPC::MessageInfo::messageID):
(CoreIPC::MessageInfo::attachmentCount):
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard):
(CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::platformCanSendOutgoingMessages):
(CoreIPC::Connection::sendOutgoingMessage):
* Platform/SharedMemory.h:
* Platform/WorkQueue.h:
* Platform/qt/MappedMemoryPool.cpp: Removed.
* Platform/qt/MappedMemoryPool.h: Removed.
* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):
(WebKit::SharedMemory::create):
(WebKit::accessModeMMap):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::accessModeFile):
(WebKit::SharedMemory::createHandle):
* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::registerSocketEventHandler):
* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):
* Shared/qt/UpdateChunk.h:
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::QtWebProcess::QtWebProcess):
(WebKit::QtWebProcess::setupChildProcess):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::platformInvalidate):
* UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
* WebKit2.pro:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 12:56:15 +0000 (12:56 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
* platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 12:46:05 +0000 (12:46 +0000)]
2011-01-24 Peter Beverloo <peter@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recognize application/x-font-woff as a valid mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52977
No new tests.
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 11:55:17 +0000 (11:55 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix for r76497.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 24 Jan 2011 11:53:29 +0000 (11:53 +0000)]
[Qt] Regroup MiniBrowser's menubar and add open file action
https://bugs.webkit.org/show_bug.cgi?id=53000
Reviewed by Andreas Kling.
Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::openFile):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Mon, 24 Jan 2011 11:52:43 +0000 (11:52 +0000)]
2011-01-24 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395
Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.
* fast/regex/script-tests/slow.js:
* fast/regex/slow-expected.txt:
2011-01-24 Peter Varga <pvarga@webkit.org>
Reviewed by Oliver Hunt.
Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395
Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 24 Jan 2011 11:51:17 +0000 (11:51 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Use rad2deg() from WTF instead of rolling our own.
https://bugs.webkit.org/show_bug.cgi?id=52993
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 11:35:07 +0000 (11:35 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, test fix for r76497.
* http/tests/inspector/debugger-test2.js:
(initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
(initialize_DebuggerTest.InspectorTest._showScriptSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 11:22:49 +0000 (11:22 +0000)]
Unreviewed fix after r76496
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
* BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
* Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Mon, 24 Jan 2011 10:57:08 +0000 (10:57 +0000)]
2011-01-24 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=52885
No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::closeCallback):
(WebCore::readCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 10:38:43 +0000 (10:38 +0000)]
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: eliminate SourceView and ScriptView classes.
https://bugs.webkit.org/show_bug.cgi?id=52896
SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
* inspector/front-end/ScriptView.js: Removed.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
(WebInspector.ScriptsPanel.prototype._formatScript):
(WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.hasContent):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
* inspector/front-end/SourceView.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 24 Jan 2011 10:36:47 +0000 (10:36 +0000)]
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* Source/DerivedSources.pro: Copied from DerivedSources.pro.
* Source/WebKit.pri: Renamed from WebKit.pri.
* Source/WebKit.pro: Added.
* Source/common.pri: Renamed from common.pri.
* WebKit.pro: Removed.
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
No new tests needed.
* WebCore.pri:
* WebCore.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* declarative/declarative.pro:
* docs/docs.pri:
* tests/tests.pri:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DerivedSources.pro:
* WebKit2.pro:
* WebProcess.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DerivedSources.pro: Renamed from DerivedSources.pro.
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* MiniBrowser/DerivedSources.pro:
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/webkitdirs.pm:
* Tools.pro: Added.
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 24 Jan 2011 10:32:30 +0000 (10:32 +0000)]
Unreviewed, trivial fix.
Fix a Chromium-only assertion failure by r76491.
https://bugs.webkit.org/show_bug.cgi?id=38982
Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):
* platform/FileChooser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 24 Jan 2011 10:27:07 +0000 (10:27 +0000)]
2011-01-24 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextControlInnerElement::m_shadowParent should be removed.
https://bugs.webkit.org/show_bug.cgi?id=52998
No new tests. No behavioral change.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
* rendering/TextControlInnerElements.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 10:20:57 +0000 (10:20 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION (r72895): console.trace crashes
https://bugs.webkit.org/show_bug.cgi?id=52981
- Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has
non-null value.
- Use PassRefPtr for objects whos ownership is passed to the inspector.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleMarkTimeline):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
(WebCore::InspectorInstrumentation::addProfile):
(WebCore::InspectorInstrumentation::profilerEnabled):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
* inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::didOpenDatabase):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
* inspector/InspectorInstrumentation.h:
* page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly.
(WebCore::Console::addMessage):
(WebCore::Console::trace):
(WebCore::Console::count):
(WebCore::Console::markTimeline):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 09:16:25 +0000 (09:16 +0000)]
2011-01-24 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (LINUX/SVG) in response to r76442, again.
* platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/chromium-linux/svg/text/text-hkern-expected.txt: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
* platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
* platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
* platform/chromium-linux/svg/text/text-vkern-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 24 Jan 2011 09:15:37 +0000 (09:15 +0000)]
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982
An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.
* WebCore.gypi:
* platform/graphics/Icon.h:
(WebCore::Icon::create): Add Chromium-specific factory.
* platform/graphics/chromium/IconChromium.cpp: Added.
* platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
* platform/graphics/chromium/IconChromiumMac.cpp: Removed.
* platform/graphics/chromium/IconChromiumWin.cpp: Removed.
* platform/graphics/chromium/PlatformIcon.h:
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982
Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading
to WebViewClient::queryIconForFiles(), and an implementation of
WebViewClient::queryIconForFiles() loads an icon and passes it to a
FileChooser through WebIconLoadingCompletion.
* WebKit.gyp:
* public/WebIconLoadingCompletion.h: Added.
(WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion):
* public/WebViewClient.h:
(WebKit::WebViewClient::queryIconForFiles):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::chooseIconForFiles):
* src/WebIconLoadingCompletionImpl.cpp: Added.
(WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl):
(WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl):
(WebKit::WebIconLoadingCompletionImpl::didLoadIcon):
* src/WebIconLoadingCompletionImpl.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 24 Jan 2011 09:10:40 +0000 (09:10 +0000)]
2011-01-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, GTK still does not have TestInputController support. Opened
a bug to follow the issue:
https://bugs.webkit.org/show_bug.cgi?id=52997
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 24 Jan 2011 09:05:09 +0000 (09:05 +0000)]
2011-01-24 MORITA Hajime <morrita@google.com>
Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 08:44:20 +0000 (08:44 +0000)]
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move search functions from SourceView to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=52895
This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
(WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
(WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
(WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceFrame.prototype.showingFirstSearchResult):
(WebInspector.SourceFrame.prototype.showingLastSearchResult):
(WebInspector.SourceFrame.prototype._jumpToSearchResult):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype.performSearch):
(WebInspector.SourceView.prototype.jumpToFirstSearchResult):
(WebInspector.SourceView.prototype.jumpToLastSearchResult):
(WebInspector.SourceView.prototype.jumpToNextSearchResult):
(WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceView.prototype.showingFirstSearchResult):
(WebInspector.SourceView.prototype.showingLastSearchResult):
(WebInspector.SourceView.prototype.clearMessages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 08:33:57 +0000 (08:33 +0000)]
2011-01-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76463.
http://trac.webkit.org/changeset/76463
https://bugs.webkit.org/show_bug.cgi?id=52993
It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 24 Jan 2011 08:33:42 +0000 (08:33 +0000)]
2011-01-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipped tests failing the 64bits bot and passing in the
32bits bots. Bug following the issue:
https://bugs.webkit.org/show_bug.cgi?id=52996
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 07:52:50 +0000 (07:52 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (LINUX/SVG) in response to r76442.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
* platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 07:19:13 +0000 (07:19 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN/SVG) in response to r76442.
* platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
* platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
* platform/chromium-win/svg/text/text-text-04-t-expected.png:
* platform/chromium-win/svg/text/text-text-04-t-expected.txt:
* platform/chromium-win/svg/text/text-vkern-expected.checksum:
* platform/chromium-win/svg/text/text-vkern-expected.png:
* platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 24 Jan 2011 07:13:16 +0000 (07:13 +0000)]
2011-01-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.updateSidebarWidth):
(WebInspector.NetworkPanel.prototype._positionSummaryBar):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 24 Jan 2011 06:53:34 +0000 (06:53 +0000)]
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241
Added a test that exercises continous whitespace characters and tabs inserted by IME.
* editing/inserting/insert-composition-whitespace-expected.txt: Added.
* editing/inserting/insert-composition-whitespace.html: Added.
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241
* Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to
distinguish text input which is originated by composition.
* Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing
range of string on text node, instead of surrounding part of that.
Test: editing/inserting/insert-composition-whitespace.html
* dom/TextEvent.h:
(WebCore::TextEvent::isComposition):
* dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
* editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
(WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
* editing/CompositeEditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::insertTextForConfirmedComposition): Added.
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
(WebCore::Editor::setComposition):
* editing/Editor.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
* editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
(WebCore::TypingCommand::setCompositionType): Added.
(WebCore::TypingCommand::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 05:37:30 +0000 (05:37 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN) in response to r76442.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
* platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
* platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 03:48:49 +0000 (03:48 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 24 Jan 2011 03:46:54 +0000 (03:46 +0000)]
Follow-up to r76477.
Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.
Source/JavaScriptCore:
* JavaScriptCore.xcodeproj/project.pbxproj:
Source/JavaScriptGlue:
* JavaScriptGlue.xcodeproj/project.pbxproj:
Source/WebCore:
Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 24 Jan 2011 03:26:48 +0000 (03:26 +0000)]
Build fix after r76459.
Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.
The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::inspectorAgents):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 02:33:02 +0000 (02:33 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations in response to r76442.
* platform/chromium-linux/fast/css/acid2-expected.txt: Added.
* platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
* platform/chromium-linux/fast/css/acid2-pixel-expected.png:
* platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
* platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
* platform/chromium-linux/fast/forms/button-sizes-expected.png:
* platform/chromium-linux/fast/forms/button-sizes-expected.txt:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
* platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
* platform/chromium-linux/svg/text/text-text-01-b-expected.png:
* platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Mon, 24 Jan 2011 01:53:35 +0000 (01:53 +0000)]
2011-01-21 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=49780
Tests: Existing tests in LayoutTests/compositing/masks
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::bindContentsTexture):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::maskLayer):
(WebCore::LayerChromium::unreserveContentsTexture):
(WebCore::LayerChromium::bindContentsTexture):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayersRecursive):
* platform/graphics/chromium/LayerTexture.cpp:
(WebCore::LayerTexture::bindTexture):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
(WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 24 Jan 2011 01:00:57 +0000 (01:00 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934
Add an additional function to calculate the hash
of data with a runtimedependent size.
* wtf/StringHasher.h:
(WTF::StringHasher::createBlobHash):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
* platform/LinkHash.cpp:
(WebCore::visitedLinkHashInline):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::IntegerArrayHash::hash):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::computeHash):
* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Sun, 23 Jan 2011 23:50:52 +0000 (23:50 +0000)]
2011-01-23 Damian Kaleta <dkaleta@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/8905171>
https://bugs.webkit.org/show_bug.cgi?id=52985
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it
consistent with WebKit1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 23 Jan 2011 23:17:26 +0000 (23:17 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add an overload to base64Encode with String output
https://bugs.webkit.org/show_bug.cgi?id=50122
This change removes duplicated code.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceContentBase64):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::encodeBasicAuthorization):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::encodeBasicAuthorization):
* platform/text/Base64.cpp:
(WebCore::base64Encode):
* platform/text/Base64.h:
(WebCore::base64Encode):
* platform/wince/KeygenWinCE.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 23 Jan 2011 22:57:22 +0000 (22:57 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Fix comment in String::ascii()
https://bugs.webkit.org/show_bug.cgi?id=52980
* wtf/text/WTFString.cpp:
(WTF::String::ascii):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sun, 23 Jan 2011 22:28:01 +0000 (22:28 +0000)]
2011-01-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=52968
Use a separate NSView for printing
Also addresses <rdar://problem/8900148> Improper check for
-[NSGraphicsContext currentContextDrawingToScreen]
* UIProcess/API/mac/WKPrintingView.h: Added.
* UIProcess/API/mac/WKPrintingView.mm: Added.
(-[WKPrintingView initWithFrameProxy:]):
(-[WKPrintingView isFlipped]):
(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WKPrintingView drawPageBorderWithSize:]):
(-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]):
(-[WKPrintingView rectForPage:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
* WebKit2.xcodeproj/project.pbxproj:
Moved printing code to a separate view, simplifying as appropriate. The view is currently not
referenced by anything in WebKit2 directly, being owned by NSPrintOperation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 23 Jan 2011 22:02:46 +0000 (22:02 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979
* wtf/text/WTFString.h:
(WTF::String::containsOnlyLatin1):
(WTF::charactersAreAllLatin1):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979
Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().
* page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sun, 23 Jan 2011 21:08:42 +0000 (21:08 +0000)]
2011-01-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=15649
Empty STYLE elements are not reflected into the document.styleSheets object
Adding a test for a bug that no longer occurs.
* fast/dom/document-stylesheets-empty-style-expected.txt: Added.
* fast/dom/document-stylesheets-empty-style.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 23 Jan 2011 19:50:05 +0000 (19:50 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add missing CodeGenerator dependencies
https://bugs.webkit.org/show_bug.cgi?id=52976
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Sun, 23 Jan 2011 19:28:41 +0000 (19:28 +0000)]
2011-01-23 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839
Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.
Build fix so no new tests.
* WebCore.pro:
* plugins/symbian/PluginPackageSymbian.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 23 Jan 2011 19:16:37 +0000 (19:16 +0000)]
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Oliver Hunt.
Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52948
r70111 removed support for JSVALUE32.
ARM, MIPS and X86 support JSVALUE32_64 only.
* jit/JITStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 23 Jan 2011 17:33:32 +0000 (17:33 +0000)]
<rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
Reviewed by John Sullivan.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 23 Jan 2011 16:24:25 +0000 (16:24 +0000)]
2011-01-23 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Use rad2deg() from WTF instead of rolling our own.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 23 Jan 2011 14:43:02 +0000 (14:43 +0000)]
2011-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Viewport meta: Always adjust device dimensions to the device pixel ratio.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 23 Jan 2011 14:33:36 +0000 (14:33 +0000)]
2011-01-23 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Don't scale absolute geometry specified by viewport meta tag.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sun, 23 Jan 2011 10:48:14 +0000 (10:48 +0000)]
2011-01-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.
Touch Inspector.idl.
* inspector/Inspector.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sun, 23 Jan 2011 09:36:21 +0000 (09:36 +0000)]
2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: next step in splitting InspectorController.
Splitting InspectorController is a bit tricky process.
As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;
The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.
As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.
https://bugs.webkit.org/show_bug.cgi?id=52955
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::nodeForId):
(WebCore::JSInjectedScriptHost::selectDOMStorage):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::nodeForIdCallback):
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::injectedScriptForMainFrame):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
(WebCore::InjectedScriptHost::frontend):
(WebCore::InjectedScriptHost::didCreateWorker):
(WebCore::InjectedScriptHost::didDestroyWorker):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::inspectorAgent):
(WebCore::InjectedScriptHost::disconnectController):
* inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp.
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::~InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::enabled):
(WebCore::InspectorAgent::inspectorStartsAttached):
(WebCore::InspectorAgent::setInspectorStartsAttached):
(WebCore::InspectorAgent::setInspectorAttachedHeight):
(WebCore::InspectorAgent::inspectorAttachedHeight):
(WebCore::InspectorAgent::searchingForNodeInPage):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::inspect):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::highlight):
(WebCore::InspectorAgent::highlightDOMNode):
(WebCore::InspectorAgent::highlightFrame):
(WebCore::InspectorAgent::hideHighlight):
(WebCore::InspectorAgent::mouseDidMoveOverElement):
(WebCore::InspectorAgent::handleMousePress):
(WebCore::InspectorAgent::setInspectorFrontendClient):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setSearchingForNode):
(WebCore::InspectorAgent::connectFrontend):
(WebCore::InspectorAgent::show):
(WebCore::InspectorAgent::showPanel):
(WebCore::InspectorAgent::close):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::resourceAgent):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::unbindAllResources):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::mainResourceFiredDOMContentEvent):
(WebCore::InspectorAgent::mainResourceFiredLoadEvent):
(WebCore::InspectorAgent::isMainResourceLoader):
(WebCore::InspectorAgent::willSendRequest):
(WebCore::InspectorAgent::ensureSettingsLoaded):
(WebCore::InspectorAgent::startTimelineProfiler):
(WebCore::InspectorAgent::stopTimelineProfiler):
(WebCore::PostWorkerNotificationToFrontendTask::create):
(WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask):
(WebCore::PostWorkerNotificationToFrontendTask::performTask):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
(WebCore::InspectorAgent::didOpenDatabase):
(WebCore::InspectorAgent::getCookies):
(WebCore::InspectorAgent::buildArrayForCookies):
(WebCore::InspectorAgent::buildObjectForCookie):
(WebCore::InspectorAgent::deleteCookie):
(WebCore::InspectorAgent::didUseDOMStorage):
(WebCore::InspectorAgent::didCreateWebSocket):
(WebCore::InspectorAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorAgent::didCloseWebSocket):
(WebCore::InspectorAgent::isRecordingUserInitiatedProfile):
(WebCore::InspectorAgent::startUserInitiatedProfiling):
(WebCore::InspectorAgent::stopUserInitiatedProfiling):
(WebCore::InspectorAgent::profilerEnabled):
(WebCore::InspectorAgent::enableProfiler):
(WebCore::InspectorAgent::disableProfiler):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::disableDebugger):
(WebCore::InspectorAgent::resume):
(WebCore::InspectorAgent::setAllBrowserBreakpoints):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::didEvaluateForTestInFrontend):
(WebCore::quadToPath):
(WebCore::drawOutlinedQuad):
(WebCore::drawOutlinedQuadWithClip):
(WebCore::drawHighlightForBox):
(WebCore::drawHighlightForLineBoxesOrSVGRenderer):
(WebCore::convertFromFrameToMainFrame):
(WebCore::frameToMainFrameOffset):
(WebCore::InspectorAgent::drawNodeHighlight):
(WebCore::InspectorAgent::drawElementTitle):
(WebCore::InspectorAgent::openInInspectedWindow):
(WebCore::InspectorAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorAgent::setInspectorExtensionAPI):
(WebCore::InspectorAgent::inspectedURL):
(WebCore::InspectorAgent::reloadPage):
(WebCore::InspectorAgent::setExtraHeaders):
* inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h.
(WebCore::InspectorAgent::inspectorBackendDispatcher):
(WebCore::InspectorAgent::inspectorClient):
(WebCore::InspectorAgent::injectedScriptHost):
(WebCore::InspectorAgent::inspectedPage):
(WebCore::InspectorAgent::hideDOMNodeHighlight):
(WebCore::InspectorAgent::hideFrameHighlight):
(WebCore::InspectorAgent::frontend):
(WebCore::InspectorAgent::inspectorController):
(WebCore::InspectorAgent::inspectorAgent):
(WebCore::InspectorAgent::consoleAgent):
(WebCore::InspectorAgent::cssAgent):
(WebCore::InspectorAgent::domAgent):
(WebCore::InspectorAgent::injectedScriptAgent):
(WebCore::InspectorAgent::runtimeAgent):
(WebCore::InspectorAgent::timelineAgent):
(WebCore::InspectorAgent::databaseAgent):
(WebCore::InspectorAgent::domStorageAgent):
(WebCore::InspectorAgent::fileSystemAgent):
(WebCore::InspectorAgent::browserDebuggerAgent):
(WebCore::InspectorAgent::debuggerAgent):
(WebCore::InspectorAgent::profilerAgent):
(WebCore::InspectorAgent::applicationCacheAgent):
(WebCore::InspectorAgent::hasInspectorFrontendClient):
(WebCore::InspectorAgent::hasFrontend):
(WebCore::InspectorAgent::startProfiling):
(WebCore::InspectorAgent::stopProfiling):
(WebCore::InspectorAgent::debuggerEnabled):
(WebCore::InspectorAgent::state):
(WebCore::InspectorAgent::settings):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorBrowserDebuggerAgent.h:
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::stop):
(WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
(WebCore::InspectorFileSystemAgent::didGetFileSystemPath):
(WebCore::InspectorFileSystemAgent::didGetFileSystemError):
* inspector/InspectorFileSystemAgent.h:
(WebCore::InspectorFileSystemAgent::create):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setExtensionAPI):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: next step in splitting InspectorController.
#include "InspectorController.h" was added.
https://bugs.webkit.org/show_bug.cgi?id=52955
* WebCoreSupport/InspectorServerQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sun, 23 Jan 2011 05:48:11 +0000 (05:48 +0000)]
2011-01-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
https://bugs.webkit.org/show_bug.cgi?id=52970
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 23 Jan 2011 05:03:16 +0000 (05:03 +0000)]
2011-01-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
ASSERT running run-webkit-tests --threaded.
https://bugs.webkit.org/show_bug.cgi?id=52971
SunSpider and v8 report no change.
* runtime/ConservativeSet.cpp:
(JSC::ConservativeSet::grow):
(JSC::ConservativeSet::add):
* runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and
the growth policy to 2X, to make SunSpider and v8 happy.
(JSC::ConservativeSet::ConservativeSet):
(JSC::ConservativeSet::~ConservativeSet):
(JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc.
Malloc is forbidden during a multi-threaded mark phase because it can
cause deadlock.
2011-01-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Dan Bernstein.
Beefed up --threaded mode to catch even more kinds of errors.
https://bugs.webkit.org/show_bug.cgi?id=52971
* DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
context group to force JSC to mark multiple threads. (This used to be
the default, but it changed in SnowLeopard.)
(runJavaScriptThread): Do more locking and unlocking, and more allocation,
to give threading mistakes more chances to show themselves.
(startJavaScriptThreads):
(stopJavaScriptThreads):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 23 Jan 2011 00:33:55 +0000 (00:33 +0000)]
2011-01-22 Chris Rogers <crogers@google.com>
Rubber-stamped by Anders Carlsson.
Fix FFTFrameStub to compile properly
https://bugs.webkit.org/show_bug.cgi?id=52969
No new tests since this is a build fix.
* platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::FFTFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Sat, 22 Jan 2011 21:55:43 +0000 (21:55 +0000)]
2011-01-22 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
https://bugs.webkit.org/show_bug.cgi?id=52967
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::horizontalScrollbar):
(WebKit::WebScrollbarImpl::verticalScrollbar):
* src/WebScrollbarImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 22 Jan 2011 20:11:22 +0000 (20:11 +0000)]
2011-01-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Rubber-stamped by Maciej Stachowiak.
A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946
SunSpider reports no change.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems.
* runtime/ConservativeSet.cpp: Added.
(JSC::isPointerAligned):
(JSC::ConservativeSet::add):
* runtime/ConservativeSet.h: Added.
(JSC::ConservativeSet::ConservativeSet):
(JSC::ConservativeSet::mark): Split ConservativeSet out into its own
file, and moved the conservative check into ConservativeSet::add, making
ConservativeSet's responsibility clearer.
* runtime/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/MachineStackMarker.cpp:
(JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
(JSC::MachineStackMarker::markOtherThreadConservatively):
* runtime/MachineStackMarker.h:
* runtime/MarkStack.h: Updated for changes above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 22 Jan 2011 19:56:38 +0000 (19:56 +0000)]
2011-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Transparent windows with compositing WebKit2 content show garbage
https://bugs.webkit.org/show_bug.cgi?id=52966
<rdar://problem/8765051>
* UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
(WebKit::LayerBackedDrawingAreaProxy::paint):
If the WKView should draw transparent background, do so.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 22 Jan 2011 19:36:34 +0000 (19:36 +0000)]
2011-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add an asynchronous WKPageForceRepaint
https://bugs.webkit.org/show_bug.cgi?id=52964
<rdar://problem/8898527>
* UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint):
Call WebPageProxy::forceRepaint.
* UIProcess/API/C/WKPage.h:
Add WKPageForceRepaint.
* UIProcess/GenericCallback.h:
Add a "generic" VoidCallback class.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
Insert the callback in the m_voidCallbacks map and send a forceRepaint message.
(WebKit::WebPageProxy::voidCallback):
Call the right void callback.
(WebKit::WebPageProxy::processDidCrash):
Invalidate m_voidCallbacks.
* UIProcess/WebPageProxy.messages.in:
Add a VoidCallback message.
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::forceRepaint):
Force a repaint.
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
Add forceRepaint.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
Call forceRepaint on the drawing area.
* WebProcess/WebPage/WebPage.messages.in:
Add a ForceRepaint message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 22 Jan 2011 17:27:34 +0000 (17:27 +0000)]
2011-01-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956
* platform/qt/Skipped:
2011-01-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::addURLToRedirect):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-01-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::addURLToRedirect):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 16:16:07 +0000 (16:16 +0000)]
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960
Revert accidently landed mac baseline changes.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/mac/svg/batik/text/xmlSpace-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/mac/svg/text/text-hkern-expected.txt:
* platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/mac/svg/text/text-text-04-t-expected.txt:
* platform/mac/svg/text/text-vkern-expected.txt:
* platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 15:14:17 +0000 (15:14 +0000)]
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960
Rebaselined several text dumps from the bots, after the FontMetrics change.
All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
Mac still has the old results - as it depends on a rounding trick at the moment.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/gtk/svg/text/text-hkern-expected.txt:
* platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/gtk/svg/text/text-vkern-expected.txt:
* platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/mac/svg/batik/text/xmlSpace-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/mac/svg/text/text-hkern-expected.txt:
* platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/mac/svg/text/text-text-04-t-expected.txt:
* platform/mac/svg/text/text-vkern-expected.txt:
* platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/text/text-hkern-expected.txt:
* platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/qt/svg/text/text-vkern-expected.txt:
* platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Sat, 22 Jan 2011 15:00:18 +0000 (15:00 +0000)]
2011-01-22 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890
* storage/indexeddb/data-corruption-expected.txt: Added.
* storage/indexeddb/data-corruption.html: Added.
2011-01-22 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890
We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::getColumnBlobAsString):
(WebCore::SQLiteStatement::getColumnBlobAsVector):
* platform/sql/SQLiteStatement.h:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::loadCurrentRow):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::runCommands):
(WebCore::createTables):
(WebCore::createMetaDataTable):
(WebCore::migrateDatabase):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::putObjectStoreData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 14:18:55 +0000 (14:18 +0000)]
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix WinCE build.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 22 Jan 2011 14:13:57 +0000 (14:13 +0000)]
2011-01-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802
* platform/qt/Skipped:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
2011-01-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 13:46:31 +0000 (13:46 +0000)]
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960
SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.
Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.
* platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::floatLineSpacing):
(WebCore::FontMetrics::setLineSpacing):
(WebCore::FontMetrics::lineSpacing):
(WebCore::FontMetrics::reset):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sat, 22 Jan 2011 12:52:18 +0000 (12:52 +0000)]
2011-01-22 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/backgrounds/svg-as-mask.html fails
https://bugs.webkit.org/show_bug.cgi?id=52906
Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 12:44:50 +0000 (12:44 +0000)]
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Fix Chromium/Win build.
* platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 22 Jan 2011 11:46:23 +0000 (11:46 +0000)]
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
* src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics.
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
* src/WebFontImpl.cpp: Ditto.
(WebKit::WebFontImpl::ascent):
(WebKit::WebFontImpl::descent):
(WebKit::WebFontImpl::height):
(WebKit::WebFontImpl::lineSpacing):
(WebKit::WebFontImpl::xHeight):
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
* FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
(FullscreenVideoController::draw):
* WebCoreSupport/WebDragClient.cpp: Ditto.
(WebDragClient::createDragImageForLink):
* WebKitGraphics.cpp: Ditto.
(FontMetrics):
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.
This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.
Shouldn't affect existing tests.
* GNUmakefile.am: Add FontMetrics.h to build.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(baselinePositionForAccessibilityRenderObject):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* html/canvas/CanvasRenderingContext2D.cpp: Ditto.
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* inspector/InspectorController.cpp: Ditto.
(WebCore::InspectorController::drawElementTitle):
* platform/chromium/PopupMenuChromium.cpp: Ditto.
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):
* platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor...
(WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
* platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information.
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::floatWidthForSimpleText):
* platform/graphics/FontMetrics.h: Added.
(WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData.
(WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm.
(WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value.
(WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float.
(WebCore::FontMetrics::setAscent): Sets the stored m_ascent float.
(WebCore::FontMetrics::floatDescent): Returns the stored m_descent float.
(WebCore::FontMetrics::setDescent): Sets the stored m_descent float.
(WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent().
(WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float.
(WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float.
(WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float.
(WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float.
(WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix).
(WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float.
(WebCore::FontMetrics::ascent): Returns a rounded version of ascent().
(WebCore::FontMetrics::descent): Ditto (for descent).
(WebCore::FontMetrics::height): Returns ascent() + descent().
(WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap().
(WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing).
(WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
* platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone.
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::initCharWidths):
* platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it.
(WebCore::SimpleFontData::fontMetrics):
(WebCore::SimpleFontData::avgCharWidth):
* platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics.
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics.
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
(WebCore::UniscribeHelperTextRun::nextWinFontData):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics.
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/mac/FontMac.mm: Ditto.
(WebCore::showGlyphsWithAdvances):
* platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
* platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.)
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics.
(WebCore::drawGDIGlyphs):
* platform/graphics/win/FontWin.cpp: Ditto.
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
(WebCore::SimpleFontData::initGDIFont):
* platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics.
(WebCore::GraphicsContext::drawText):
* platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* rendering/EllipsisBox.cpp: Ditto.
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/InlineBox.cpp: Ditto.
(WebCore::InlineBox::logicalHeight):
* rendering/InlineFlowBox.cpp: Ditto.
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineTextBox.cpp: Ditto.
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
* rendering/RenderBlock.cpp: Ditto.
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
* rendering/RenderBox.cpp: Ditto.
(WebCore::RenderBox::localCaretRect):
* rendering/RenderEmbeddedObject.cpp: Ditto.
(WebCore::RenderEmbeddedObject::paintReplaced):
* rendering/RenderImage.cpp: Ditto.
(WebCore::RenderImage::setImageSizeForAltText):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderInline.cpp: Ditto.
(WebCore::RenderInline::baselinePosition):
* rendering/RenderListBox.cpp: Ditto.
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::itemHeight):
* rendering/RenderListMarker.cpp: Ditto.
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::getRelativeMarkerRect):
* rendering/RenderTextControl.cpp: Ditto.
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTextControlSingleLine.cpp: Ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
* rendering/RenderThemeWin.cpp: Ditto.
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
* rendering/mathml/RenderMathMLFraction.cpp: Ditto.
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor.
(WebCore::InheritedFlags::fontMetrics):
(WebCore::InheritedFlags::computedLineHeight):
* rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineTextBox.cpp: Ditto.
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::positionOffsetForDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
(WebCore::SVGInlineTextBox::calculateBoundaries):
* rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto.
(WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
(WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
* rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto.
(WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
* rendering/svg/SVGTextMetrics.cpp: Ditto.
(WebCore::SVGTextMetrics::SVGTextMetrics):
* rendering/svg/SVGTextQuery.cpp: Ditto.
(WebCore::calculateGlyphBoundaries):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
* svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::SVGLength::convertValueFromUserUnitsToEXS):
(WebCore::SVGLength::convertValueFromEXSToUserUnits):
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics.
(WebKit::WebPopupMenu::setUpPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 22 Jan 2011 11:36:49 +0000 (11:36 +0000)]
2011-01-22 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76430.
* runtime/MachineStackMarker.cpp:
(JSC::swapIfBackwards):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc