WebKit-https.git
10 years agoDon't hang in WebKitAPITest if no messages have been posted
aroben@apple.com [Tue, 5 Jan 2010 18:14:35 +0000 (18:14 +0000)]
Don't hang in WebKitAPITest if no messages have been posted

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix WebKitCreateInstance helper
aroben@apple.com [Tue, 5 Jan 2010 18:14:22 +0000 (18:14 +0000)]
Fix WebKitCreateInstance helper

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
through, instead of taking its address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 17:54:27 +0000 (17:54 +0000)]
2010-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Adam Roben.

        Fix  build warnings blindly
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.cpp:
        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
mitz@apple.com [Tue, 5 Jan 2010 17:45:37 +0000 (17:45 +0000)]
Build fix

* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 16:24:40 +0000 (16:24 +0000)]
2010-01-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Darin Adler.

        Fix an obvious bug and build errors in previous commit (r52795)
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::isEmpty):
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::maybeTransferPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Tue, 5 Jan 2010 16:09:01 +0000 (16:09 +0000)]
2010-01-05  Gustavo Noronha Silva  <gns@gnome.org>

        Updated docs for 1.1.18 release.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollow r52729 in ARMAssembler.
loki@webkit.org [Tue, 5 Jan 2010 15:53:17 +0000 (15:53 +0000)]
Follow r52729 in ARMAssembler.
https://bugs.webkit.org/show_bug.cgi?id=33208

Reviewed by Maciej Stachowiak.

Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 5 Jan 2010 15:53:07 +0000 (15:53 +0000)]
2010-01-05  Xan Lopez  <xlopez@igalia.com>

        Bump for 1.1.18 release.

        * configure.ac:

WebKit/gtk:

2010-01-05  Xan Lopez  <xlopez@igalia.com>

        Update for 1.1.18 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 15:14:00 +0000 (15:14 +0000)]
2010-01-04  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Let SharedBuffer use a group of memory segments internally.
        It will merge the segments into a flat consecutive buffer only when
        necessary.
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.cpp:
        (WebCore::allocateSegment):
        (WebCore::freeSegment):
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::~SharedBuffer):
        (WebCore::SharedBuffer::adoptVector):
        (WebCore::SharedBuffer::size):
        (WebCore::SharedBuffer::data):
        (WebCore::SharedBuffer::append):
        (WebCore::SharedBuffer::clear):
        (WebCore::SharedBuffer::copy):
        (WebCore::SharedBuffer::buffer):
        (WebCore::SharedBuffer::getSomeData):
        * platform/SharedBuffer.h:
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        * platform/haiku/SharedBufferHaiku.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/qt/SharedBufferQt.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Gtk+
mjs@apple.com [Tue, 5 Jan 2010 11:00:49 +0000 (11:00 +0000)]
Unreviewed build fix for Gtk+

Don't use // comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial Symbian build fix
hausmann@webkit.org [Tue, 5 Jan 2010 10:28:35 +0000 (10:28 +0000)]
Unreviewed trivial Symbian build fix

* plugins/symbian/PluginViewSymbian.cpp: Add missing HostWindow.h inclusion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix broken export macros in package builds.
hausmann@webkit.org [Tue, 5 Jan 2010 09:45:30 +0000 (09:45 +0000)]
[Qt] Fix broken export macros in package builds.

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=33202

Always define QT_MAKEDLL unless we're doing a static
build or we're building inside of Qt. When building
inside of Qt the correct define is pulled from qbase.pri.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 5 Jan 2010 08:58:28 +0000 (08:58 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        * wtf/Platform.h: Rename, reorganize and document OS() macros.

        Adapt to name changes. Also fixed a few incorrect OS checks.

        * API/JSContextRef.cpp:
        * assembler/MacroAssemblerARM.cpp:
        (JSC::isVFPPresent):
        * assembler/MacroAssemblerX86Common.h:
        * bytecode/SamplingTool.cpp:
        * config.h:
        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::~RegisterFile):
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        (JSC::RegisterFile::grow):
        * jit/ExecutableAllocator.h:
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        * jit/ExecutableAllocatorPosix.cpp:
        * jit/ExecutableAllocatorSymbian.cpp:
        * jit/ExecutableAllocatorWin.cpp:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JITStubs.cpp:
        * jsc.cpp:
        (main):
        * parser/Grammar.y:
        * profiler/ProfileNode.cpp:
        (JSC::getCount):
        * runtime/Collector.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlockPtr):
        (JSC::currentThreadStackBase):
        (JSC::getCurrentPlatformThread):
        (JSC::suspendThread):
        (JSC::resumeThread):
        (JSC::getPlatformThreadRegisters):
        (JSC::otherThreadStackPointer):
        * runtime/Collector.h:
        * runtime/DateConstructor.cpp:
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        * runtime/InitializeThreading.cpp:
        (JSC::initializeThreading):
        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):
        * runtime/MarkStackPosix.cpp:
        * runtime/MarkStackSymbian.cpp:
        * runtime/MarkStackWin.cpp:
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncLastIndexOf):
        * runtime/TimeoutChecker.cpp:
        (JSC::getCPUTime):
        * runtime/UString.cpp:
        (JSC::UString::from):
        * wtf/Assertions.cpp:
        * wtf/Assertions.h:
        * wtf/CurrentTime.cpp:
        (WTF::lowResUTCTime):
        * wtf/CurrentTime.h:
        (WTF::getLocalTime):
        * wtf/DateMath.cpp:
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_ThreadCache::InitModule):
        (WTF::TCMallocStats::):
        * wtf/FastMalloc.h:
        * wtf/MathExtras.h:
        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):
        * wtf/RandomNumberSeed.h:
        (WTF::initializeRandomNumberGenerator):
        * wtf/StringExtras.h:
        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * wtf/TCSystemAlloc.cpp:
        * wtf/ThreadSpecific.h:
        (WTF::::destroy):
        * wtf/Threading.h:
        * wtf/ThreadingPthreads.cpp:
        (WTF::initializeThreading):
        (WTF::isMainThread):
        * wtf/ThreadingWin.cpp:
        (WTF::wtfThreadEntryPoint):
        (WTF::createThreadInternal):
        * wtf/VMTags.h:
        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::Collator::userDefault):
        * wtf/win/MainThreadWin.cpp:
        (WTF::initializeMainThreadPlatform):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * src/ChromiumBridge.cpp:
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled):
        (WebKit::):
        (WebKit::EditorClientImpl::handleEditingKeyboardEvent):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):
        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::makeContextCurrent):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectionAsText):
        (WebKit::WebFrameImpl::printPage):
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::handleMouseEvent):
        (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::mouseContextMenu):
        (WebKit::WebViewImpl::mouseUp):
        (WebKit::WebViewImpl::keyEvent):
        (WebKit::WebViewImpl::sendContextMenuEvent):
        (WebKit::WebViewImpl::setScrollbarColors):
        (WebKit::WebViewImpl::navigationPolicyFromMouseEvent):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * webkit/webkitwebsettings.cpp:
        (webkit_get_user_agent):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes. Also fixed a few incorrect OS checks.

        * accessibility/AccessibilityObject.h:
        * config.h:
        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::platform):
        * loader/CachedFont.cpp:
        * loader/FTPDirectoryDocument.cpp:
        * loader/FTPDirectoryParser.cpp:
        * page/EventHandler.cpp:
        * page/Frame.cpp:
        (WebCore::Frame::setUseSecureKeyboardEntry):
        * page/NavigatorBase.cpp:
        (WebCore::NavigatorBase::platform):
        * page/Page.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * page/chromium/DragControllerChromium.cpp:
        (WebCore::DragController::isCopyKeyDown):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::accessKeyModifiers):
        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/FileSystem.h:
        * platform/KeyboardCodes.h:
        * platform/PurgeableBuffer.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeRange):
        * platform/chromium/ClipboardUtilitiesChromium.cpp:
        * platform/chromium/ClipboardUtilitiesChromium.h:
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformKeyboardEventChromium.cpp:
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
        (WebCore::PlatformKeyboardEvent::currentCapsLockState):
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenu::show):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontCache.cpp:
        (WebCore::alternateFamilyName):
        * platform/graphics/FontCache.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/ColorCG.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.h:
        * platform/graphics/chromium/FontPlatformData.h:
        * platform/graphics/opentype/OpenTypeUtilities.cpp:
        * platform/graphics/opentype/OpenTypeUtilities.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::PlatformContextSkia):
        (PlatformContextSkia::save):
        (PlatformContextSkia::restore):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::paint):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::filenameToString):
        (WebCore::filenameFromString):
        (WebCore::filenameForDisplay):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        * platform/network/curl/ResourceHandleManager.cpp:
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):
        * platform/text/String.cpp:
        (WebCore::String::format):
        (WebCore::String::number):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encode):
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        (WebCore::extendTextCodecMaps):
        * platform/text/TextStream.cpp:
        * platform/text/TextStream.h:
        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::decode):
        * platform/win/PlatformMouseEventWin.cpp:
        (WebCore::messageToEventType):
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/win/PlatformScreenWin.cpp:
        (WebCore::deviceInfoForWidget):
        (WebCore::screenIsMonochrome):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::paint):
        (WebCore::PopupMenu::registerClass):
        (WebCore::PopupMenu::PopupMenuWndProc):
        (WebCore::PopupMenu::wndProc):
        * platform/win/SystemTimeWin.cpp:
        (WebCore::userIdleTime):
        * platform/wx/FileSystemWx.cpp:
        (WebCore::unloadModule):
        * plugins/PluginDatabase.cpp:
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::compareFileVersion):
        * plugins/PluginPackage.h:
        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameRect):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::addWindowsMediaPlayerPluginDirectory):
        (WebCore::addMacromediaPluginDirectories):
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::load):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::registerPluginView):
        (WebCore::PluginView::wndProc):
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paintIntoTransformedContext):
        (WebCore::PluginView::paintWindowedPluginIntoContext):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::setParent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::platformStart):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Tue, 5 Jan 2010 08:47:34 +0000 (08:47 +0000)]
2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Minor improvements to test-webkit-scripts, as suggested
        by an earlier review.

        https://bugs.webkit.org/show_bug.cgi?id=33125

        * Scripts/test-webkit-scripts:
          - Used OptionParser class instead of getopt.getopt().
          - Created main() method for __main__ block.
          - Enclosed functions in a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo review. Fix DRT breakage on Tiger/Leopard.
cfleizach@apple.com [Tue, 5 Jan 2010 08:06:07 +0000 (08:06 +0000)]
No review. Fix DRT breakage on Tiger/Leopard.

Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 5 Jan 2010 08:00:15 +0000 (08:00 +0000)]
2010-01-04  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Expose more DOM methods to support LayoutTests
        https://bugs.webkit.org/show_bug.cgi?id=33185

        * public/WebDocument.h: Adds documentElement method.
        * public/WebElement.h: Adds innerText method.
        * public/WebFrame.h: Adds renderTreeAsText and counterValueForElementById
        methods, and fixes a few whitespace issues.
        * src/WebDocument.cpp:
        (WebKit::WebDocument::documentElement):
        * src/WebElement.cpp:
        (WebKit::WebElement::innerText):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearName):
        (WebKit::WebFrameImpl::renderTreeAsText):
        (WebKit::WebFrameImpl::counterValueForElementById):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 5 Jan 2010 07:54:16 +0000 (07:54 +0000)]
2010-01-04  Darin Fisher  <darin@chromium.org>

        Fix Chromium build bustage.

        * src/WebAnimationControllerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ARIA "Live Region" support
cfleizach@apple.com [Tue, 5 Jan 2010 07:46:08 +0000 (07:46 +0000)]
Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

Reviewed by Darin Adler.

WebCore:

Tests: platform/mac/accessibility/aria-liveregions-attributes.html
       platform/mac/accessibility/aria-liveregions-notifications.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::contentChanged):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isChildOfARIALiveRegion):
(WebCore::AccessibilityObject::supportsARIALiveRegion):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::contentChanged):
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityObject::ariaLiveRegionBusy):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::areChildrenDirty):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AccessibilityObjectWrapper.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* html/HTMLAttributeNames.in:
* rendering/RenderText.cpp:
(WebCore::RenderText::setText):

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(indexOfChildCallback):
(boolAttributeValueCallback):
(stringAttributeValueCallback):
(addNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

* accessibility/aria-activedescendant-crash.html:
* platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
* platform/mac/accessibility/aria-liveregions-attributes.html: Added.
* platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
* platform/mac/accessibility/aria-liveregions-notifications.html: Added.
* platform/mac/accessibility/aria-menu-role-descriptions.html:
* platform/mac/accessibility/slider-supports-actions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 5 Jan 2010 05:33:22 +0000 (05:33 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool rollout should require a reason
        https://bugs.webkit.org/show_bug.cgi?id=30810

        * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
        * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
        * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
        * Scripts/webkitpy/commands/download_unittest.py: pass required reason
        * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Chris Evans <cevans@chromium.org>
abarth@webkit.org [Tue, 5 Jan 2010 05:19:56 +0000 (05:19 +0000)]
2010-01-04  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Test for https://bugs.webkit.org/show_bug.cgi?id=29820
        Adopt a more conservative approach for loading CSS cross-origin.

        * http/tests/security/cross-origin-css.html: Added.
        * http/tests/security/cross-origin-css-expected.txt: Added.
        * http/tests/security/cross-origin-css-in-xml.xml: Added.
        * http/tests/security/cross-origin-css-in-xml-expected.txt: Added.
        * http/tests/security/resources/xorigincss1.css: Added.
        * http/tests/security/resources/xorigincss2.css: Added.
        * http/tests/security/resources/xorigincss1.html: Added.
        * http/tests/security/resources/xorigincss2.html: Added.
        * http/tests/security/resources/xorigincss3.html: Added.
        * http/tests/security/resources/xorigincss4.html: Added.
        * http/tests/security/resources/xorigincss5.html: Added.
        * http/tests/security/resources/xorigincss6.html: Added.
2010-01-04  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Adopt a more conservative approach for loading CSS cross-origin. When
        loading CSS cross-origin, it must be start with valid CSS if the MIME
        type is broken.

        https://bugs.webkit.org/show_bug.cgi?id=29820

        Test: http/tests/security/cross-origin-css.html
        Test: http/tests/security/cross-origin-css-in-xml.xml

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::setCSSStyleSheet): Enforce stricter load
        requirements for cross-origin loads.
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet): Enforce stricter load
        requirements for cross-origin loads.
        * css/CSSStyleSheet.h:
        * css/CSSStyleSheet.cpp:
        * css/CSSParser.cpp:
        * css/CSSGrammar.y:
        * css/CSSParser.h:
        Add ability to tell whether the CSS parse started with a syntactically
        valid CSS rule.
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::sheetText): Add ability to return
        whether the MIME type was acceptable for CSS.
        (WebCore::CachedCSSStyleSheet::canUseSheet): If requested, return
        whether the MIME type was valid or not.
        * dom/ProcessingInstruction.cpp
        (WebCore::ProcessingInstruction::setCSSStyleSheet): Make use of strict
        mode explicit and add comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements...
mitz@apple.com [Tue, 5 Jan 2010 04:45:28 +0000 (04:45 +0000)]
<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements correctly
<rdar://problem/7397558> REGRESSION: AXImages inside of AXLink cause AXLink to have wrong bounds

Reviewed by Simon Fraser.

WebCore:

Test: accessibility/dimensions-include-descendants.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect): Use absoluteFocusRingQuads()
for non-text renderers. The focus ring encompasses descendants, which is
what we want for the accessibility indicator.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteFocusRingQuads): Added.
* rendering/RenderObject.h:

LayoutTests:

* accessibility/dimensions-include-descendants-expected.txt: Added.
* accessibility/dimensions-include-descendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Ojan Vafai <ojan@ojanmacpro.sfo.corp.google.com>
ojan@chromium.org [Tue, 5 Jan 2010 03:53:28 +0000 (03:53 +0000)]
2010-01-04  Ojan Vafai  <ojan@ojanmacpro.sfo.corp.google.com>

        Reviewed by Dan Bernstein.

        Remove unnecessary division by a constant in SimpleFontDataMac.mm.
        https://bugs.webkit.org/show_bug.cgi?id=33189

        This was added in http://trac.webkit.org/changeset/8104 and seems like
        it was just there to match the previously private function which we no
        longer use.

        No new tests. No change in behavior.

        * platform/graphics/mac/SimpleFontDataMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: Accessibility role of <select> elements is wrong
jhoneycutt@apple.com [Tue, 5 Jan 2010 03:40:59 +0000 (03:40 +0000)]
MSAA: Accessibility role of <select> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33192

Reviewed by Sam Weinig.

WebKit/win:

* AccessibleBase.cpp:
(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.

LayoutTests:

* platform/win/accessibility/select-element-role-expected.txt: Added.
* platform/win/accessibility/select-element-role.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake distcheck build fixes.
kov@webkit.org [Tue, 5 Jan 2010 01:43:47 +0000 (01:43 +0000)]
Make distcheck build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build fix. Unreviewed.
jhoneycutt@apple.com [Tue, 5 Jan 2010 01:38:32 +0000 (01:38 +0000)]
Qt build fix. Unreviewed.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSelection-related code needs stricter rules about how it relates to layout
darin@apple.com [Tue, 5 Jan 2010 01:35:59 +0000 (01:35 +0000)]
Selection-related code needs stricter rules about how it relates to layout
https://bugs.webkit.org/show_bug.cgi?id=32882

Reviewed by Maciej Stachowiak.

Covered by existing tests along with the new assertions.

* dom/Document.cpp:
(WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
already false by the time post-attach callbacks are done so that
layout triggered inside those callbacks can work properly.

* editing/SelectionController.cpp:
(WebCore::SelectionController::layout): Added code to trigger a
layout when it's needed.
(WebCore::SelectionController::recomputeCaretRect): Removed unneeded
code to do nothing when FrameView is 0. Added an assertion that layout
is not needed at the time the function is called.
(WebCore::SelectionController::invalidateCaretRect): Added code to
trigger a layout when it's needed.
(WebCore::SelectionController::paintCaret): Added an assertion that
layout is not needed at the time the function is called.

* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus): Added. Helper function that expresses
the rule for which form control elements should auto-focus.
(WebCore::focusPostAttach): Added. Called post-attach to focus an
element if we discover it should be focused during attach.
(WebCore::HTMLFormControlElement::attach): Refactored code for
which elements need auto-focus into a separate function. Instead
of focusing right away, use the focusPostAttach function to focus
after attach is done. Also added calls to suspendPostAttachCallbacks
and resumePostAttachCallbacks so post-attach callbacks happen late
enough. Before, they could run inside the base attach function.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach): Added calls to
suspendPostAttachCallbacks and resumePostAttachCallbacks so
post-attach callbacks happen late enough

* page/Frame.cpp:
(WebCore::Frame::revealSelection): Added code to trigger a layout
when it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoerk, demangle the ChangeLog!
barraclough@apple.com [Tue, 5 Jan 2010 01:32:11 +0000 (01:32 +0000)]
erk, demangle the ChangeLog!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
barraclough@apple.com [Tue, 5 Jan 2010 01:24:48 +0000 (01:24 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig, additional coding by Mark Rowe.

* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/UStringImpl.cpp:
* runtime/UStringImpl.h:
(JSC::UStringImpl::computeHash):
* wtf/HashFunctions.h:
* wtf/StringHashFunctions.h: Added.
(WTF::stringHash):

JavaScriptGlue: Add a forwarding header so that StringHashFunctions.h can be found.

Reviewed by Sam Weinig.

* ForwardingHeaders/wtf/StringHashFunctions.h: Added.

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Patch by Mark Rowe <mrowe@apple.com> on 2010-01-04
Reviewed by Sam Weinig.

* ForwardingHeaders/wtf/StringHashFunctions.h: Added.
* platform/text/StringHash.h:
* platform/text/StringImpl.h:
(WebCore::StringImpl::computeHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 5 Jan 2010 01:21:08 +0000 (01:21 +0000)]
2010-01-04  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Adding WebAnimationController to chromium's WebKit API.

        https://bugs.webkit.org/show_bug.cgi?id=32870

        * WebKit.gyp:
        * public/WebAnimationController.h: Added.
        (WebKit::WebAnimationController::~WebAnimationController):
        * public/WebFrame.h:
        * src/WebAnimationControllerImpl.cpp: Added.
        (WebKit::WebAnimationControllerImpl::WebAnimationControllerImpl):
        (WebKit::WebAnimationControllerImpl::pauseAnimationAtTime):
        (WebKit::WebAnimationControllerImpl::pauseTransitionAtTime):
        (WebKit::WebAnimationControllerImpl::numberOfActiveAnimations):
        * src/WebAnimationControllerImpl.h: Added.
        (WebKit::WebAnimationControllerImpl::~WebAnimationControllerImpl):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::animationController):
        (WebKit::WebFrameImpl::WebFrameImpl):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Jay Campan <jcampan@google.com>
eric@webkit.org [Tue, 5 Jan 2010 01:12:20 +0000 (01:12 +0000)]
2010-01-04  Jay Campan  <jcampan@google.com>

        Reviewed by Darin Fisher

        Adding  more DOM API methods. They are needed for the upcoming
        translate feature.

        * public/WebElement.h:
        * public/WebNode.h:
        * src/WebElement.cpp:
        (WebKit::WebElement::tagName):
        (WebKit::WebElement::setAttribute):
        * src/WebNode.cpp:
        (WebKit::WebNode::setNodeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: <select> elements should broadcast value change events
jhoneycutt@apple.com [Tue, 5 Jan 2010 01:12:13 +0000 (01:12 +0000)]
MSAA: <select> elements should broadcast value change events

https://bugs.webkit.org/show_bug.cgi?id=33088

<rdar://problem/7332364>

Reviewed by Darin Adler.

WebCore:

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postNotification):
If the post type is async, follow the old code path; otherwise, call
postPlatformNotification().

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
Added a new accessibility notification, AXMenuListValueChanged. Added
a new parameter to postNotification() to specify whether the post should
be synchronous or asynchronous.

* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
If the WebCore notification is AXMenuListValueChanged, broadcast an
EVENT_OBJECT_VALUECHANGE event.

* dom/SelectElement.cpp:
(WebCore::SelectElement::setSelectedIndex):
When the selected index of a RenderMenuList is changed, call
RenderMenuList::didSetSelectedIndex().

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
Initialize new member
(WebCore::RenderMenuList::didSetSelectedIndex):
If the selected index has changed, post AXMenuListValueChanged to the
object synchronously.

* rendering/RenderMenuList.h:
Declare didSetSelectedIndex(), and add a member to hold the last
selected index.

WebKitTools:

* DumpRenderTree/AccessibilityController.cpp:
(logValueChangeEventsCallback):
Start logging value change events.
(AccessibilityController::getJSClass):
Add a "logValueChangeEvents" to the AccessibilityController's JS class
definition.
(AccessibilityController::resetToConsistentState):
Disable logging of value change events.

* DumpRenderTree/AccessibilityController.h:
Declare setLogValueChangeEvents(), and add a member variable for the
value change event hook.

* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogValueChangeEvents):
Stubbed.

* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::setLogValueChangeEvents):
Stubbed.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize new member var.
(AccessibilityController::~AccessibilityController):
Disable logging of value change events.
(logEventProc):
When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
and its value.
(AccessibilityController::setLogValueChangeEvents):
If disabling logging, unhook the event, and clear the event hook
member var. Otherwise, query for the root element to enable
accessibility, and hook EVENT_OBJECT_VALUECHANGE.

LayoutTests:

* platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
* platform/win/accessibility/select-element-valuechange-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Added missing null check in BarInfo code.
darin@apple.com [Tue, 5 Jan 2010 01:07:26 +0000 (01:07 +0000)]
WebCore: Added missing null check in BarInfo code.

Reviewed by Sam Weinig.

Test: fast/dom/Window/BarInfo-after-frame-removed.html

* page/BarInfo.cpp:
(WebCore::BarInfo::visible): Added null check. A few other
cleanups.

LayoutTests: Added test for use of BarInfo object after a frame is no longer
associated with a web page.

Reviewed by Sam Weinig.

* fast/dom/Window/BarInfo-after-frame-removed-expected.txt: Added.
* fast/dom/Window/BarInfo-after-frame-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 5 Jan 2010 01:04:47 +0000 (01:04 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        long_help for submit-patch
        https://bugs.webkit.org/show_bug.cgi?id=33184

        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Jon Honeycutt.
mrowe@apple.com [Tue, 5 Jan 2010 00:54:46 +0000 (00:54 +0000)]
Rubber-stamped by Jon Honeycutt.

Delete an empty and unused JavaScript file.

* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/InspectorControllerStub.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix, add a couple include dirs to the build.
kevino@webkit.org [Tue, 5 Jan 2010 00:27:38 +0000 (00:27 +0000)]
[wx] Build fix, add a couple include dirs to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r52758 as it accidentally the whole build.
mrowe@apple.com [Tue, 5 Jan 2010 00:13:21 +0000 (00:13 +0000)]
Roll out r52758 as it accidentally the whole build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 4 Jan 2010 23:50:34 +0000 (23:50 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33181
        The first letter is not removed properly from inline input hole

        * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was
        confirmed, cancel it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of a build fix for Windows, this at least gets WTF to build.
bweinstein@apple.com [Mon, 4 Jan 2010 23:48:12 +0000 (23:48 +0000)]
Part of a build fix for Windows, this at least gets WTF to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* wtf/unicode/Unicode.h:
barraclough@apple.com [Mon, 4 Jan 2010 23:18:55 +0000 (23:18 +0000)]
* wtf/unicode/Unicode.h:

Reviewed by NOBODY (more speculative build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 23:13:50 +0000 (23:13 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        commit-queue can wrongly reject patches if the buildbots are behind
        https://bugs.webkit.org/show_bug.cgi?id=30098

        Check to make sure we can currently build and test before trying to
        land a patch.

        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, attempt to fix ARM bulid.
dimich@chromium.org [Mon, 4 Jan 2010 23:05:34 +0000 (23:05 +0000)]
Not reviewed, attempt to fix ARM bulid.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber stamped by Geoff Garen.
barraclough@apple.com [Mon, 4 Jan 2010 22:49:27 +0000 (22:49 +0000)]
Rubber stamped by Geoff Garen.

Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).

* API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* wtf/HashFunctions.h:
barraclough@apple.com [Mon, 4 Jan 2010 22:42:25 +0000 (22:42 +0000)]
* wtf/HashFunctions.h:

Reviewed by NOBODY build fix for DRT, fix incorrect style include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Mon, 4 Jan 2010 22:30:24 +0000 (22:30 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
mitz@apple.com [Mon, 4 Jan 2010 22:09:23 +0000 (22:09 +0000)]
Windows build fix

* page/FrameView.cpp:
(WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
barraclough@apple.com [Mon, 4 Jan 2010 22:00:38 +0000 (22:00 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
* runtime/UStringImpl.h:
(JSC::UStringImpl::computeHash):
* wtf/HashFunctions.h:
(WTF::stringHash):

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Reviewed by Sam Weinig.

* platform/text/StringImpl.h:
(WebCore::StringImpl::computeHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 4 Jan 2010 21:50:29 +0000 (21:50 +0000)]
2010-01-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Repaint issues in text input under a scale transform
        https://bugs.webkit.org/show_bug.cgi?id=32086

        When doing a subtree layout we have to look up the container chain to see if there
        are any properties, such as transforms or reflections, that mean that we are unable
        to use layoutState.

        Test: fast/repaint/subtree-layoutstate-transform.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout): Call canUseLayoutStateForSubtree() to determine
        whether it's OK to use layoutState.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::canUseLayoutStateForSubtree): New method that reports whether it's
        OK to use layoutState when doing a subtree layout from the given root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Reentrancy problem with selection in some edge cases.
darin@apple.com [Mon, 4 Jan 2010 21:49:01 +0000 (21:49 +0000)]
WebCore: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

Test: fast/forms/selection-layout-reentry-strange-case.html

Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.

* dom/Document.cpp:
(WebCore::Document::updateLayout): Changed this to use the
definition of needsLayout from FrameView rather than rolling
its own.

* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.

* editing/SelectionController.h: Added setNeedsDisplayUpdate,
needsDisplayUpdate, and m_needsDisplayUpdate.

* page/Frame.cpp:
(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function. Also added a global reentrancy check
since that's the easiest way I could think of to prevent infinite
recursion in the case where recomputeCaretRect ends up triggering
a layout. As a side effect, fixed theoretical problems in
TEXT_CARET builds by improving the ifdef.
(WebCore::Frame::caretBlinkTimerFired): Loosen assertions a
bit. Later we might want to decouple caret rect from caret state
a bit more and add these assertions back.
(WebCore::Frame::selectionBounds): Call Document::updateLayout.
This function is for external clients and they do not currently
do anything to make sure layout is up to date.

* page/FrameView.cpp:
(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.

LayoutTests: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

* fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
* fast/forms/selection-layout-reentry-strange-case.html: Added.
* platform/mac/accessibility/frame-with-title-expected.txt: Updated since
the number of layouts is now different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 4 Jan 2010 21:30:41 +0000 (21:30 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33161
        Assertion failure in WebView when using Chinese Simplified IME

        * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode
        check. We can't make assertions about arguments passed from outside WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 4 Jan 2010 21:27:10 +0000 (21:27 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33157
        Implement TextInput logging channel on Windows

        * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
        * WebKitLogging.h:
        Added a TextInput channel in place of unused Network one.

        * WebView.cpp:
        (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward
        it to DefWindowProc, so there is no need to return an unused boolean result for "handled".
        (WebView::onIMEStartComposition): Added logging.
        (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition.
        (imeNotificationName): A helper function for detailed logging in onIMENotify.
        (imeRequestName): A helper function for detailed logging in onIMERequest.
        (WebView::onIMEComposition): Added logging.
        (WebView::onIMEEndComposition): Ditto.
        (WebView::onIMEChar): Ditto.
        (WebView::onIMENotify): Ditto.
        (WebView::onIMERequestCharPosition): Changed to return result directly.
        (WebView::onIMERequestReconvertString): Ditto.
        (WebView::onIMERequest): Changed to return result directly. Added logging.
        (WebView::onIMESelect): Added logging.
        (WebView::onIMESetContext): Added logging.

        * WebView.h: onIMERequest functions now return result directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a test harness for the Windows WebKit API, and a few tests
aroben@apple.com [Mon, 4 Jan 2010 21:19:41 +0000 (21:19 +0000)]
Add a test harness for the Windows WebKit API, and a few tests

We currently only have tests for a handful of bugs regarding WebView
destruction, but more tests can easily be added later. Eventually
we'll run these tests as part of run-webkit-tests.

Fixes <http://webkit.org/b/33167>.

Reviewed by Sam Weinig.

WebKit/win:

* WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
after DumpRenderTree.vcproj.

WebKitTools:

* WebKitAPITest/HostWindow.cpp: Added.
(WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
(WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
needed.
(WebKitAPITest::HostWindow::initialize): Create our window.
(WebKitAPITest::HostWindow::clientRect): Return our window's client
rect.
(WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
(WebKitAPITest::HostWindow::wndProc): Just call through to
DefWindowProcW.

* WebKitAPITest/HostWindow.h: Added.
(WebKitAPITest::HostWindow::window): Simple getter.

* WebKitAPITest/Test.h: Added. This file defines some macros useful
for writing tests.

* WebKitAPITest/TestsController.cpp: Added.
(WebKitAPITest::TestsController::TestsController): Initialize our
members.
(WebKitAPITest::TestsController::shared): Return the shared instance.
(WebKitAPITest::TestsController::runAllTests): Run a message pump
until a WM_QUIT message is received, then return whether all tests
succeeded.
(WebKitAPITest::TestsController::addTest): Add the test to m_tests and
start running tests soon.
(WebKitAPITest::TestsController::testFailed): Record the failure and
print a message about it to stdout.
(WebKitAPITest::TestsController::runNextTest): If we don't have any
tests to run, post a WM_QUIT message to stop the message pump.
Otherwise, run the test and print whether it passed, then schedule the
next test.
(WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
to run the next test.
(WebKitAPITest::TestsController::registerWindowClass): Does what it
says.
(WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
fired, call runNextTest(). Pass everything else through to
DefWindowProcW.

* WebKitAPITest/TestsController.h: Added.

* WebKitAPITest/WebKitAPITest.vcproj: Added.

* WebKitAPITest/WebKitAPITestCommon.vsprops: Added.

* WebKitAPITest/main.cpp: Added.
(main): (Mostly) just calls TestsController::runAllTests.

* WebKitAPITest/tests/WebViewDestruction.cpp: Added.
(WebKitAPITest::WebKitCreateInstance): Helper function template to
call through to the real WebKitCreateInstance.
(WebKitAPITest::webViewCount): Helper function to call through to
IWebKitStatistics::webViewCount.
(WebKitAPITest::createWebView): Helper function to create a WebView
and put it inside a HostWindow.
(WebKitAPITest::runMessagePump): Helper function to run a message pump
for a specified number of milliseconds, or until a WM_QUIT message is
received.
(WebKitAPITest::CloseWithoutDestroyWindow): Test for
<http://webkit.org/b/32827>.
(WebKitAPITest::MainFrameAfterClose): Test for
<http://webkit.org/b/32868>.
(WebKitAPITest::NoCloseOrDestroyWindow): Test for
<http://webkit.org/b/33162>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrect debug assertion (and possible runtime errors) by
bfulgham@webkit.org [Mon, 4 Jan 2010 20:28:01 +0000 (20:28 +0000)]
Correct debug assertion (and possible runtime errors) by
checking validity of bitmap settings used to create
the Windows Cairo contexts.
https://bugs.webkit.org/show_bug.cgi?id=33164.

Reviewed by Adam Roben.

* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::createCairoContextWithHDC): Check validity of selected
  OBJ_BITMAP retrieved, and only create 32-bit context when
  a valid bitmap is provided.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33158
barraclough@apple.com [Mon, 4 Jan 2010 19:18:31 +0000 (19:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33158
Refactor JSC API entry/exit to use RAII instead of copy/pasting code.
Make it easier to change set of actions taken when passing across the API boundary.

Reviewed by Sam "Shimmey Shimmey" Weinig.

* API/APIShims.h: Added.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):
* API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):
* API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, revert r52745 and r52746 on behalf of Nikolas Zimmermann, as discussed...
dimich@chromium.org [Mon, 4 Jan 2010 19:06:07 +0000 (19:06 +0000)]
Not reviewed, revert r52745 and r52746 on behalf of Nikolas Zimmermann, as discussed on IRC.
Patch produced by 'git revert' and then reverting back ChangeLog files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated copyright string
mitz@apple.com [Mon, 4 Jan 2010 18:55:26 +0000 (18:55 +0000)]
Updated copyright string

Reviewed by Ada Chan and Mark Rowe.

JavaScriptCore:

* Info.plist:
* JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:

JavaScriptGlue:

* Info.plist:

WebCore:

* Info.plist:
* WebCore.vcproj/QTMovieWin.rc:

WebKit/mac:

* Info.plist:

WebKit/win:

* WebKit.vcproj/WebKit.rc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: any DIV with an aria role should not be ignored
cfleizach@apple.com [Mon, 4 Jan 2010 18:54:56 +0000 (18:54 +0000)]
AX: any DIV with an aria role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=33090

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-divs-not-ignored.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

* platform/mac/accessibility/aria-divs-not-ignored-expected.txt: Added.
* platform/mac/accessibility/aria-divs-not-ignored.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 4 Jan 2010 18:46:47 +0000 (18:46 +0000)]
2010-01-04  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate declarations for V8 runtime enablers.

        https://bugs.webkit.org/show_bug.cgi?id=33156

        * bindings/scripts/CodeGeneratorV8.pm: Generate runtime enabler declarations.
        * bindings/v8/custom/V8CustomBinding.h: Remove manual declarations of runtime enablers.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8WebSocketCustom.cpp: Remove closeCallback(), which isn't actually being used.
        * bindings/v8/custom/V8WorkerContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 17:46:12 +0000 (17:46 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Forgot to add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to Chromium build.

        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 17:31:35 +0000 (17:31 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it had many issues:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg
              svg/custom/marker-opacity.svg

        * Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
        * GNUmakefile.am: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML.
        (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time.
        (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes.
        (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
        * rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency.
        (WebCore::RenderPath::path): Inline this accessor.
        * rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
        * rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated.
        (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code).
        (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
        * rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
        * rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights.
        (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo.
        (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker.
        (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout.
        (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values.
        (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method.
        (WebCore::SVGMarkerData::updateOutslope): Ditto.
        (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation.
        (WebCore::SVGMarkerData::updateInslope): Helper method.
        * rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles)
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers().
        (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers.
        (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix.
        (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers.
        (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto.
        (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
        * svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer()
        (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
        * svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
                                        and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
                                        ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
                                        per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
        (WebCore::resourceSet): Add global static HashSet<SVGResource*>.
        (WebCore::SVGResource::SVGResource): Add us to the resourceSet.
        (WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
        (WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
        (WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker.
        (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer.
        (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
        * svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values.
        (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker().
        (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef().
        (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Roben <aroben@apple.com>
aroben@apple.com [Mon, 4 Jan 2010 17:29:24 +0000 (17:29 +0000)]
2010-01-04  Adam Roben  <aroben@apple.com>

        No review, rolling out r52741.
        http://trac.webkit.org/changeset/52741
        https://bugs.webkit.org/show_bug.cgi?id=33056

        * wtf/AlwaysInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 4 Jan 2010 17:20:56 +0000 (17:20 +0000)]
2010-01-04  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Add cacheFlush support for WinCE
        https://bugs.webkit.org/show_bug.cgi?id=33110

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 17:09:27 +0000 (17:09 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix typo in test name.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 4 Jan 2010 17:06:30 +0000 (17:06 +0000)]
2010-01-04  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Implement NO_RETURN for COMPILER(MSVC).
        https://bugs.webkit.org/show_bug.cgi?id=33056

        * wtf/AlwaysInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 16:50:36 +0000 (16:50 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.  Update two win-specific test results, that showed up on the Windows Release/Debug slave.
        Skip fast/frames/iframe-onload-remove-self-no-crash.html as it crashes the debug slave, filed bug.

        All bots except SnowLeopard Leaks & GTK Linux Debug (32-bit) should turn to green now!

        * platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt:
        * platform/win/fast/forms/basic-selects-expected.txt: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for Git's "diff.mnemonicprefix" config option to WebKitTools
vestbo@webkit.org [Mon, 4 Jan 2010 16:12:27 +0000 (16:12 +0000)]
Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=32820

* Scripts/VCSUtils.pm:
* Scripts/svn-apply:
* Scripts/svn-unapply:
* Scripts/test-webkitperl: Run gitdiff2svndiff test
* Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
* Scripts/webkitpy/diff_parser.py:
* Scripts/webkitpy/diff_parser_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 16:01:27 +0000 (16:01 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Bring back Tiger bot to green: svg/custom/use-on-symbol-inside-pattern.svg exposes a bug on both Tiger & Win.
        Reopened bug 17393 and skipping this test for now, as it requires a larger rework of Path::debugString().

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 15:54:15 +0000 (15:54 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Attempt to mark all Gtk bots green again, as discussed with Gustavo Noronha Silva.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 15:48:15 +0000 (15:48 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skipping plugins/get-url-with-iframe-target.html, filed bug 33154, cc'ing the original author.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 4 Jan 2010 15:42:15 +0000 (15:42 +0000)]
2010-01-04  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skipping http/tests/navigation/*iframe* on Tiger, just like it has been done for win.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix standalone package builds.
hausmann@webkit.org [Mon, 4 Jan 2010 15:37:26 +0000 (15:37 +0000)]
[Qt] Fix standalone package builds.

Reviewed by Tor Arne Vestbø.

.:

* WebKit.pri: Add logic for detecting standalone builds. Set OUTPUT_DIR to the top-level dir in that case.
* WebKit.pro: Don't build JSC and DRT for package builds.

WebCore:

* WebCore.pro: Moved logic for detecting standalone builds to WebKit.pri. Set DESTDIR for package builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Mon, 4 Jan 2010 15:33:41 +0000 (15:33 +0000)]
2010-01-04  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        https://bugs.webkit.org/show_bug.cgi?id=29048
        [Qt] make RenderStyle.h compile in winscw compiler.

        Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
        error when compareEqual is defined as template.

        The compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDivided the Perl unit tests into separate files and put
ddkilzer@apple.com [Mon, 4 Jan 2010 14:59:29 +0000 (14:59 +0000)]
Divided the Perl unit tests into separate files and put
them in a separate directory, and renamed test-webkit-perl
to test-webkitperl.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-04
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33124

* Scripts/VCSUtils.pm:
  - Renamed generateRunPatchCommand() to generatePatchCommand().

* Scripts/VCSUtils_unittest.pl: Removed.
  - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.

* Scripts/test-webkit-perl: Removed.
  - Renamed to test-webkitperl.

* Scripts/test-webkit-scripts:
  - Updated paths to test-webkitpy and test-webkitperl.

* Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
  - Added paths to new test files.

* Scripts/webkitperl: Added.
* Scripts/webkitperl/VCSUtils_unittest: Added.
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
* Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
* Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 13:18:51 +0000 (13:18 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Hausmann.

        Fix some PLATFORM(*_ENDIAN) uses to CPU()
        https://bugs.webkit.org/show_bug.cgi?id=33148

        * runtime/JSCell.cpp:
        (JSC::):
        * runtime/JSValue.h:
        (JSC::JSValue::):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Hausmann.

        Fix some PLATFORM(*_ENDIAN) uses to CPU()
        https://bugs.webkit.org/show_bug.cgi?id=33148

        * platform/image-decoders/bmp/BMPImageReader.h:
        (WebCore::BMPImageReader::readUint16):
        (WebCore::BMPImageReader::readUint32):
        (WebCore::BMPImageReader::readCurrentPixel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 12:01:40 +0000 (12:01 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Document CPU() macros in comments.
        https://bugs.webkit.org/show_bug.cgi?id=33147

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 11:38:56 +0000 (11:38 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Reorganize, document and rename CPU() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33145
        ExecutableAllocatorSymbian appears to have buggy ARM version check
        https://bugs.webkit.org/show_bug.cgi?id=33138

        * wtf/Platform.h:
        Rename all macros related to detection of particular CPUs or
        classes of CPUs to CPU(), reorganize and document them.

        All remaining changes are adapting to the renames, plus fixing the
        second bug cited above.

        * assembler/ARMAssembler.cpp:
        * assembler/ARMAssembler.h:
        * assembler/ARMv7Assembler.h:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::Imm32::Imm32):
        * assembler/MacroAssembler.h:
        * assembler/MacroAssemblerARM.cpp:
        * assembler/MacroAssemblerARM.h:
        * assembler/MacroAssemblerCodeRef.h:
        (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
        * assembler/MacroAssemblerX86.h:
        * assembler/MacroAssemblerX86Common.h:
        * assembler/MacroAssemblerX86_64.h:
        * assembler/X86Assembler.h:
        (JSC::X86Registers::):
        (JSC::X86Assembler::):
        (JSC::X86Assembler::movl_mEAX):
        (JSC::X86Assembler::movl_EAXm):
        (JSC::X86Assembler::repatchLoadPtrToLEA):
        (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
        * jit/ExecutableAllocator.h:
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        * jit/ExecutableAllocatorPosix.cpp:
        * jit/ExecutableAllocatorSymbian.cpp:
        (JSC::ExecutableAllocator::intializePageSize):
        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        * jit/JITInlineMethods.h:
        (JSC::JIT::beginUninterruptedSequence):
        (JSC::JIT::restoreArgumentReferenceForTrampoline):
        (JSC::JIT::emitCount):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        * jit/JITStubs.h:
        * runtime/Collector.cpp:
        (JSC::currentThreadStackBase):
        (JSC::getPlatformThreadRegisters):
        (JSC::otherThreadStackPointer):
        * wrec/WREC.h:
        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateEnter):
        (JSC::WREC::Generator::generateReturnSuccess):
        (JSC::WREC::Generator::generateReturnFailure):
        * wrec/WRECGenerator.h:
        * wtf/FastMalloc.cpp:
        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * wtf/Threading.h:
        * wtf/dtoa.cpp:
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateEnter):
        (JSC::Yarr::RegexGenerator::generateReturn):
        * yarr/RegexJIT.h:
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Reorganize, document and rename CPU() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33145

        * webkit/webkitwebsettings.cpp:
        (webkit_get_user_agent):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Reorganize, document and rename CPU() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33145

        * page/NavigatorBase.cpp:
        * platform/text/AtomicString.cpp:
        (WebCore::equal):
        * platform/text/StringHash.h:
        (WebCore::StringHash::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 11:37:24 +0000 (11:37 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make bugzilla-tool rollout include a bug link in the ChangeLog entry
        https://bugs.webkit.org/show_bug.cgi?id=33146

        One more step towards better rollouts.

        * Scripts/webkitpy/changelogs.py:
        * Scripts/webkitpy/changelogs_unittest.py:
        * Scripts/webkitpy/steps/preparechangelogforrevert.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 4 Jan 2010 11:04:46 +0000 (11:04 +0000)]
2009-12-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] G_OBJECT() cast is not necessary for signals connection and properties access
        https://bugs.webkit.org/show_bug.cgi?id=32661

        Reverted the SENTINEL / NULL crap :) Hopefully the style-bot won't
        complain about NULL usage in g_object_{get,set} anymore.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::hasVideo):
        (WebCore::MediaPlayerPrivate::hasAudio):
        (WebCore::MediaPlayerPrivate::setVolume):
        (WebCore::MediaPlayerPrivate::setRate):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 11:04:28 +0000 (11:04 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Sort the step options
        https://bugs.webkit.org/show_bug.cgi?id=33144

        * Scripts/webkitpy/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 10:57:03 +0000 (10:57 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Need support for longer text in per-command help
        https://bugs.webkit.org/show_bug.cgi?id=33143

        Add some minimal additional help to land-diff and
        pave the way for adding better help to all commands.

        * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
        * Scripts/webkitpy/multicommandtool.py: support long_help
        * Scripts/webkitpy/multicommandtool_unittest.py: test long_help

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 10:46:42 +0000 (10:46 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add unit test for MarkBugFixed
        https://bugs.webkit.org/show_bug.cgi?id=33142

        MarkBugFixed is way behind in command technology, but it still needs a
        unit test, as the FIXME commands.

        Also, remove mark-bug-fixed and create-bug from main help since we have
        more modern commands to replace them.

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 10:24:30 +0000 (10:24 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add missing unit test for CommitMessageForCurrentDiff
        https://bugs.webkit.org/show_bug.cgi?id=33141

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix.
ossy@webkit.org [Mon, 4 Jan 2010 10:05:07 +0000 (10:05 +0000)]
Unreviewed trivial fix.

[Qt] r52694 moved a test, but it isn't renamed in the skiplist.

* platform/qt/Skipped: animations/transform-origin-vs-functions.html renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Alex Milowski <alex@milowski.com>
eric@webkit.org [Mon, 4 Jan 2010 09:58:58 +0000 (09:58 +0000)]
2010-01-04  Alex Milowski  <alex@milowski.com>

        Reviewed by Eric Seidel.

        Added expected outputs for pixel tests that were missing.

        * platform/mac/mathml/presentation/sub-expected.checksum: Added.
        * platform/mac/mathml/presentation/sub-expected.png: Added.
        * platform/mac/mathml/presentation/sup-expected.checksum: Added.
        * platform/mac/mathml/presentation/sup-expected.png: Added.
        * platform/mac/mathml/presentation/tables-expected.checksum: Added.
        * platform/mac/mathml/presentation/tables-expected.png: Added.
2010-01-04  Alex Milowski  <alex@milowski.com>

        Reviewed by Eric Seidel.

        Updated license to match recommended header license.

        * mathml/MathMLElement.cpp:
        * mathml/MathMLElement.h:
        * mathml/MathMLInlineContainerElement.cpp:
        * mathml/MathMLInlineContainerElement.h:
        * mathml/MathMLMathElement.cpp:
        * mathml/MathMLMathElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:49:18 +0000 (09:49 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add missing unit test for CommitMessageForCurrentDiff
        https://bugs.webkit.org/show_bug.cgi?id=33141

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:48:06 +0000 (09:48 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove raw_input from queues in favor of user.prompt
        https://bugs.webkit.org/show_bug.cgi?id=33140

        This lets up properly mock out the user interaction instead of hacking
        around it with the options.

        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/commands/queuestest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 09:42:04 +0000 (09:42 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        * .gitignore: Ignore autoinstall.cache.d directory created by autoinstall.py
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        Use the nifty "autoinstall" module from Daniel Krech:
        http://pypi.python.org/pypi/autoinstall/0.2
        http://code.google.com/p/pyautoinstall/
        It's available under a WebKit-compatible BSD license.

        * Scripts/webkitpy/__init__.py:
         - bind "mechanize" to an autoinstall importer which will
           auto-download mechanize if necessary.
        * Scripts/webkitpy/autoinstall.py: Added.
        * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
        * Scripts/webkitpy/statusbot.py: ditto.
        * Scripts/webkitpy/webkit_mechanize.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:33:43 +0000 (09:33 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Move AbstractSequencedCommand to a more general location
        https://bugs.webkit.org/show_bug.cgi?id=33137

        I do what the FIXME tell me to do.

        * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:30:11 +0000 (09:30 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename StatusBot to StatusServer
        https://bugs.webkit.org/show_bug.cgi?id=33139

        It's not a bot.  It's a server.

        * Scripts/bugzilla-tool:
        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/statusbot.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:05:11 +0000 (09:05 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] submit-pach should have a -o/--open option to open the bug after submit
        https://bugs.webkit.org/show_bug.cgi?id=33136

        Python makes this very easy.

        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/steps/options.py:
        * Scripts/webkitpy/steps/postdiff.py:
        * Scripts/webkitpy/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 08:47:16 +0000 (08:47 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Move steps to a submodule
        https://bugs.webkit.org/show_bug.cgi?id=33135

        For great victory.  This will probably introduce some regressions
        because our test coverage isn't perfect, but I've tried to be careful.

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/buildsteps.py: Removed.
        * Scripts/webkitpy/buildsteps_unittest.py: Removed.
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/steps/__init__.py: Added.
        * Scripts/webkitpy/steps/abstractstep.py: Added.
        * Scripts/webkitpy/steps/applypatch.py: Added.
        * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
        * Scripts/webkitpy/steps/build.py: Added.
        * Scripts/webkitpy/steps/checkstyle.py: Added.
        * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
        * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
        * Scripts/webkitpy/steps/closebug.py: Added.
        * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
        * Scripts/webkitpy/steps/closepatch.py: Added.
        * Scripts/webkitpy/steps/commit.py: Added.
        * Scripts/webkitpy/steps/completerollout.py: Added.
        * Scripts/webkitpy/steps/confirmdiff.py: Added.
        * Scripts/webkitpy/steps/createbug.py: Added.
        * Scripts/webkitpy/steps/editchangelog.py: Added.
        * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
        * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
        * Scripts/webkitpy/steps/metastep.py: Added.
        * Scripts/webkitpy/steps/obsoletepatches.py: Added.
        * Scripts/webkitpy/steps/options.py: Added.
        * Scripts/webkitpy/steps/postdiff.py: Added.
        * Scripts/webkitpy/steps/preparechangelog.py: Added.
        * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
        * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
        * Scripts/webkitpy/steps/revertrevision.py: Added.
        * Scripts/webkitpy/steps/runtests.py: Added.
        * Scripts/webkitpy/steps/steps_unittest.py: Added.
        * Scripts/webkitpy/steps/update.py: Added.
        * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
        * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
        * Scripts/webkitpy/stepsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:43:22 +0000 (08:43 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33097

        Cleans up the File menu to better conform to the File menu in Safari
        both in terms of options and keyboard shortcuts. Adds a "Quit" menu
        options to close all open windows.

        * QGVLauncher/main.cpp:
        (MainWindow::buildUI):
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33097

        Cleans up the File menu to better conform to the File menu in Safari
        both in terms of options and keyboard shortcuts. Adds a "Quit" menu
        options to close all open windows. Also, renames the Tools menu to
        Develop.

        * QtLauncher/main.cpp:
        (MainWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:40:11 +0000 (08:40 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        https://bugs.webkit.org/show_bug.cgi?id=33039

        Unreviewed fix.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 08:35:23 +0000 (08:35 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Clean up COMPILER macros and remove unused ones.
        https://bugs.webkit.org/show_bug.cgi?id=33132

        Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
        not used anywhere.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 08:30:15 +0000 (08:30 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33039

        [bzt] Second attempt to fix an issue where bugzilla-tool dies
        when the keychain lookup fails to find an entry for bugs.webkit.org.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 4 Jan 2010 08:21:52 +0000 (08:21 +0000)]
2010-01-03  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResources don't invalidate if target object changes attributes
        https://bugs.webkit.org/show_bug.cgi?id=33091

        It's neccessary to invalidate all resources of an object, if the attributes of this
        target change. Otherwise the saved resource data (like ImageBuffers) don't match
        to the new object properties.

        Test: svg/custom/resource-invalidate-on-target-update.svg

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::svgAttributeChanged):
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/SVGStyledElement.h:

2010-01-03  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResources don't invalidate if target object changes attributes
        https://bugs.webkit.org/show_bug.cgi?id=33091

        Check if SVG resources are invalidated, if target object changes
        attributes.

        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
        * svg/custom/resource-invalidate-on-target-update.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:20:19 +0000 (08:20 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33039

        [bzt] Second attempt to fix an issue where bugzilla-tool dies
        when the keychain lookup fails to find an entry for bugs.webkit.org.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 08:13:19 +0000 (08:13 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
        https://bugs.webkit.org/show_bug.cgi?id=33131

        Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
        but for now we just deploy it everywhere and don't try to fix up the few valid uses
        of Command.

        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/multicommandtool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 07:40:03 +0000 (07:40 +0000)]
2010-01-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric Seidel.

        Update wtf/Platform.h to document the new system for porting macros.
        https://bugs.webkit.org/show_bug.cgi?id=33130

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 07:15:25 +0000 (07:15 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix.  Need to import ScriptError.

        * Scripts/webkitpy/buildsteps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 07:08:08 +0000 (07:08 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make it easier to run submit-patch when previous run cancelled
        https://bugs.webkit.org/show_bug.cgi?id=33070

        This patch renames create-review to submit-patch (as requested by
        Maciej).

        This patch makes it easier to run submit-patch after the user has
        already cancelled a previous run of submit-patch by detecting when we
        already have ChangeLogs and reading the bug number from them (and not
        attempting to recreate them).  Aside from performance and the extra
        edit step, this command should not subsume post-dif.

        Also, added a --email command line argument so that the output of
        prepare-ChangeLog makes sense when it can't find the user's email
        address.

        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/buildsteps.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52704 268f45cc-cd09-0410-ab3c-d52691b4dbfc