13 years ago Reviewed by Maciej Stachowiak.
ggaren [Sun, 24 Dec 2006 07:19:11 +0000 (07:19 +0000)]
    Reviewed by Maciej Stachowiak.

        Added --threaded support to run-webkit-tests and DumpRenderTree.

        In "threaded" mode, DRT runs a concurrent JavaScript thread with each test,
        stressing the thread safety of JavaScriptCore and the JavaScriptCore/WebCore
        interface. This is useful for tracking down bugs you might see on a system
        configured to use a PAC file.

        Ironically, I can proudly state that very few layout tests pass.

        * DumpRenderTree/DumpRenderTree.m: Added javaScriptThread and helper functions
        for starting and stopping it.
        (runJavaScriptThread): helper function
        (startJavaScriptThread): helper function
        (stopJavaScriptThread): helper function

        (dumpRenderTree): Added --threaded command line argument.
        * Scripts/run-webkit-tests: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap [Sun, 24 Dec 2006 07:09:13 +0000 (07:09 +0000)]
    Reviewed by Geoff.

        REGRESSION: trying to change a property in a computed style declaration results in a crash

        Test: fast/dom/computed-style-set-property.html

        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::put): Added a check for null m_impl->stylesheet(). Also, fixed
        incorrect logic in Dashboard branch - it didn't return in time if removeProperty() raised
        an exception (credit for noticing this bug goes to Geoff).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
weinig [Sun, 24 Dec 2006 03:19:05 +0000 (03:19 +0000)]
    Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11940
        Bad transparency in some cursor pointer images

        * Resources/northEastResizeCursor.png:
        * Resources/northEastSouthWestResizeCursor.png:
        * Resources/northWestResizeCursor.png:
        * Resources/northWestSouthEastResizeCursor.png:
        * Resources/southEastResizeCursor.png:
        * Resources/southWestResizeCursor.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Sun, 24 Dec 2006 00:48:03 +0000 (00:48 +0000)]

        Reviewed by Geoff.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=11876
        CSSMediaRule functions insertRule and deleteRule don't raise exceptions

        * fast/dom/css-mediarule-functions-expected.txt: Added.
        * fast/dom/css-mediarule-functions.html: Added.


        Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11876
        CSSMediaRule functions insertRule and deleteRule don't raise exceptions

        Test added:
        * fast/dom/css-mediarule-functions.html

        * bindings/js/kjs_css.cpp:
        * css/CSSMediaRule.cpp: add exception handling
        * css/CSSMediaRule.h: add ExceptionCode arguments
        * css/CSSMediaRule.idl: un-comment exceptions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate editing/pasteboard/paste-table-002 results now that the two style decl arrays...
hyatt [Sat, 23 Dec 2006 18:18:34 +0000 (18:18 +0000)]
Update editing/pasteboard/paste-table-002 results now that the two style decl arrays are in sync.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-23 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Sat, 23 Dec 2006 16:19:28 +0000 (16:19 +0000)]
2006-12-23  David Kilzer  <ddkilzer@webkit.org>

        Reviewed by Mitz.

        Regenerate test results with default fonts installed.

        * svg/custom/js-font-test-expected.png: Regenerated.
        * svg/custom/js-font-test-expected.txt: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix 11942. The inheritable properties array is duplicated (lame). Make
hyatt [Sat, 23 Dec 2006 12:39:54 +0000 (12:39 +0000)]
    Fix 11942.  The inheritable properties array is duplicated (lame).  Make
        sure to keep both in sync.

        Reviewed by mitz

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSMutableStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-22 Mark Rowe <bdash@webkit.org>
bdash [Sat, 23 Dec 2006 06:01:00 +0000 (06:01 +0000)]
2006-12-22  Mark Rowe  <bdash@webkit.org>

        Reviewed by Brady.

        Fix for <rdar://problem/4265976>
        prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method

        * Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Sat, 23 Dec 2006 00:19:06 +0000 (00:19 +0000)]

        Reviewed by Brady Eidson.

        Test for <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com

        Tests an onload handler for a synchronously loaded iframe removing the iframe
        from the document.

        * fast/frames/onload-remove-iframe-crash-expected.txt: Added.
        * fast/frames/onload-remove-iframe-crash.html: Added.


        Reviewed by Brady Eidson.

        Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com

        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::createFrame): Updated to reflect the fact that
        createChildFrameNamed: now returns a WebCore::Frame* instead of a
        WebCoreFrameBridge *.
        * page/mac/WebCoreFrameBridge.h:


        Reviewed by Brady Eidson.

        Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com

        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
        - The fix:
            Changed to re-fetch the child frame we're trying to load before returning it,
            since its onload handler may have removed it from the document. This
            allows us to treat a removed frame like a frame that never loaded.

        - Plus some cleanup:
            - Changed to return a WebCore::Frame* instead of a WebFrameBridge *,
            to simplify some code.
            - Grouped ObjC objects by usage, and moved calls to -release so that they
            immediately follow the calls that retain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure to actually set the stroke thickness for text decorations.
hyatt [Fri, 22 Dec 2006 23:28:35 +0000 (23:28 +0000)]
    Make sure to actually set the stroke thickness for text decorations.
        Covered by bugzilla bug 11921.

        Reviewed by mitz

        * rendering/InlineFlowBox.cpp:
        * rendering/InlineTextBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Rob.
zimmermann [Fri, 22 Dec 2006 19:35:33 +0000 (19:35 +0000)]
Reviewed by Rob.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11934

Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList
interface) has live update problems, as the notifyAttributeChange() function
isn't called anywhere. The context param is currently stored per SVGPathSeg,
which is not needed - as it can be done using SVGPathSegList completely. It
wastes memory, that is fixed. In order to get rid of the context param in
SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement*
objects ("context element"). That is done using a new HashMap in the
SVGDocumentExtensions class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-22 Mitz Pettel <mitz@webkit.org>
ap [Fri, 22 Dec 2006 19:26:12 +0000 (19:26 +0000)]
2006-12-22  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Beth.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11903
          REGRESSION: outline not drawn if line style is dashed.

        This fixes a bunch of existing pixel tests.

        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker
sullivan [Fri, 22 Dec 2006 18:49:14 +0000 (18:49 +0000)]
    Reviewed by Kevin Decker

        - renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition
          in anticipation of fixing it to work more correctly with grammar checking, where
          only checking adjacent words isn't good enough.

        * editing/Editor.h:
        renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition

        * editing/TypingCommand.cpp:
        updated for name change

        * editing/mac/EditorMac.mm:
        renamed from markMisspellingsInAdjacentWords and added FIXME comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-22 Eric Seidel <eric@webkit.org>
eseidel [Fri, 22 Dec 2006 17:43:32 +0000 (17:43 +0000)]
2006-12-22  Eric Seidel  <eric@webkit.org>

        Reviewed by aroben.

        Overriding visibility does not behave as expected.

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint): allow children to draw when container is visibility='hidden'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen
sullivan [Fri, 22 Dec 2006 14:11:15 +0000 (14:11 +0000)]
    Reviewed by Geoff Garen

        - improved concept and implementation of my previous checkin after discussing with Darin

        * WebView/WebViewPrivate.h:
        * WebView/WebView.mm:
        (-[WebView setHoverFeedbackSuspended:]):
        renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has
        changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can
        rework the document architecture and make this kind of thing less hacky (but this is following existing
        customs, so I don't feel too bad)
        (-[WebView isHoverFeedbackSuspended]):
        renamed from ignoresMouseMovedEvents

        * WebView/WebHTMLViewInternal.h:
        declare _hoverFeedbackSuspendedChanged

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        test the webView's state of the hit-tested WebHTMLView rather than self
        (-[WebHTMLView _hoverFeedbackSuspendedChanged]):
        generate a fake mouse-moved event, which simulates the mouse moving away from
        the current element or back over it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Rob.
zimmermann [Fri, 22 Dec 2006 09:30:51 +0000 (09:30 +0000)]
Reviewed by Rob.

Fix SVGPathSeg JS object creation. SVGPathSegList has to return
the actual SVGPathSegLineToAbs/MoveToRel... object instead of a pure
SVGPathSeg JS object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Fri, 22 Dec 2006 05:53:19 +0000 (05:53 +0000)]
        Reviewed by Geoff.

        Fix for <rdar://problem/4897162> REGRESSION: Attempting to create a
        new message in .Mac web mail causes Safari to crash
        ( KJS::DOMCSSStyleDeclaration::put() + 368 )

        This was a regression from my clone-node change. This fix is very

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::copyNonAttributeProperties): Must set the
        data that getInlineStyleDecl() points to instead of setting
        m_inlineStyleDecl directly. I also changed some variable names.
        * dom/StyledElement.h: Don't need parameter name here.

Layout Tests:
        Reviewed by Beth. (Geoff wrote the new test.)

        New test for <rdar://problem/4897162>. This also reverts the layout
        test changes that were caused by the first rev of the clone-node
        style change.

        * editing/style/remove-underline-across-paragraph-expected.checksum:
        * editing/style/remove-underline-across-paragraph-expected.png:
        * editing/style/remove-underline-across-paragraph-expected.txt:
        * editing/style/remove-underline-expected.checksum:
        * editing/style/remove-underline-expected.png:
        * editing/style/remove-underline-expected.txt:
        * fast/dom/clone-node-style-expected.txt: Added.
        * fast/dom/clone-node-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-21 Mark Rowe <bdash@webkit.org>
bdash [Fri, 22 Dec 2006 02:20:51 +0000 (02:20 +0000)]
2006-12-21  Mark Rowe  <bdash@webkit.org>

        Reviewed by Tim Hatcher.

        Bug 11922: REGRESSION(r17128): Drosera no longer shows local variables in stack frame

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): Use an anonymous function with function.call to
        ensure that the properties are being retrieved from the correct scope object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Fri, 22 Dec 2006 01:53:48 +0000 (01:53 +0000)]

        Reviewed by Geoff.

        Test for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

        * fast/events/onsearch-enter-expected.txt: Added.
        * fast/events/onsearch-enter.html: Added.


        Reviewed by Geoff.

        - Fix for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

        Test: fast/events/onsearch-enter.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Calls onSearch when handling "Enter".  Also removed
         special case for AppKit search fields, so now the enter event is considered handled here.
        (WebCore::HTMLInputElement::onSearch): Added. Dispatches search event.
        * html/HTMLInputElement.h: Added onSearch.
        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::onSearch): Calls onSearch on the node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
darin [Fri, 22 Dec 2006 01:26:59 +0000 (01:26 +0000)]
    Reviewed by Oliver.

        * WebInspector/webInspector/inspector.js: Added default values for the new CSS
        properties so they don't appear in the inspector when their values are

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen
sullivan [Thu, 21 Dec 2006 23:02:26 +0000 (23:02 +0000)]
    Reviewed by Geoff Garen

        - added WebKit support for making a web page temporarily ignore mouse movements

        * WebView/WebViewPrivate.h:
        declare ignoresMouseMovedEvents and setIgnoresMouseMovedEvents:

        * WebView/WebView.mm:
        added ignoresMouseMovedEvents boolean field to _private data structure
        (-[WebView setIgnoresMouseMovedEvents:]):
        set new boolean field
        (-[WebView ignoresMouseMovedEvents]):
        return new boolean field

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        bail out right away if [[self _webView] ignoresMouseMovedEvents]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 21 Dec 2006 22:39:21 +0000 (22:39 +0000)]

        Reviewed by Brady Eidson.

        <rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
        when creating an iframe from an iframe onload handler

        Test for adding an iframe to the document from another iframe's onload handler.

        * fast/loader/iframe-recursive-synchronous-load-expected.txt: Added.
        * fast/loader/iframe-recursive-synchronous-load.html: Added.


        Reviewed by Brady Eidson.

        Fixed <rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
        when creating an iframe from an iframe onload handler

        I added that assertion to try to "keep things simple," but I've found a
        testcase that demonstrates why things need to be complicated.

        * dom/ContainerNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Thu, 21 Dec 2006 20:16:27 +0000 (20:16 +0000)]
    Reviewed by Darin.

        Allow setting CSS values to null.

        * bindings/js/kjs_css.cpp:
        Convert null values to null strings.

        * fast/dom/css-set-property-exception-expected.txt:
        * fast/dom/css-set-property-exception.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
rwlbuis [Thu, 21 Dec 2006 19:45:50 +0000 (19:45 +0000)]
    Reviewed by Anders.

        CSSMediaRule functions insertRule and deleteRule assert when called from js in debug builds

        Test explicitly for the two media rule functions so it ends up calling callAsFunction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd support for the layoutTestController JavaScript object
lars [Thu, 21 Dec 2006 13:46:30 +0000 (13:46 +0000)]
Add support for the layoutTestController JavaScript object
to be able to get textOnly dumps.
Added a Qt specific hack to always get the same fonts (the ones
added in this submit) and the same dpi when running the layout tests.
Modified the run-webkit-tests script to also do a comparison to the
Mac generated outputs (by stripping out positioning information).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-21 Mark Rowe <bdash@webkit.org>
bdash [Thu, 21 Dec 2006 08:08:59 +0000 (08:08 +0000)]
2006-12-21  Mark Rowe  <bdash@webkit.org>

        Reviewed by Geoff.

        Bug 11888: REGRESSION (r18320): Web Inspector panes broken

        * WebInspector/webInspector/inspector.js: Use removeProperty to reset a style property to its
        initial value.  Bail out early from updateNodePane if Inspector has not yet been set.

2006-12-21  Mark Rowe  <bdash@webkit.org>

        Reviewed by Geoff.

        Bug 11888: REGRESSION (r18320): Web Inspector panes broken

        * Drosera/debugger.js: Use removeProperty to reset a style property to its initial value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated results for computed style test.
hyatt [Thu, 21 Dec 2006 07:53:18 +0000 (07:53 +0000)]
Land updated results  for computed style test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure the execrable match-nearest-mail-blockquote-color CSS property...
hyatt [Thu, 21 Dec 2006 07:41:41 +0000 (07:41 +0000)]
    Make sure the execrable match-nearest-mail-blockquote-color CSS property is actually initialized (amazingly
        it started off with the value "match", since it wasn't even initialized).  Now that it is actually being
        initialized and properly copied and assigned to, tests have failed.  It seems that we were getting the
        behavior of "match" by default, when the initial value was supposed to be "normal."

        Because this property really should not exist at all, it's unclear to me what the right solution is here.

        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam's rubberstamp
beidson [Thu, 21 Dec 2006 05:43:32 +0000 (05:43 +0000)]
    Reviewed by Adam's rubberstamp

        Accidentally left a logging channel on in my checkin

        * platform/Logging.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann [Thu, 21 Dec 2006 01:42:38 +0000 (01:42 +0000)]
Reviewed by Oliver.

Fix removeItem recursively calling itself (!). It was meant to call m_vector.remove(index)
not removeItem(index, ec). This bug is in SVN for quite some time now :-)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
harrison [Thu, 21 Dec 2006 01:29:17 +0000 (01:29 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4893376> REGRESSION: Crash occurs at WebCoreFrameBridge fontForSelection: when drag selecting from a line break

        No layout test added because crash only happens in path where editing window is key,
        which is never the case for the automated tests.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge fontForSelection:]):
        Add nil check of fontForSelection() result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Adam.
zimmermann [Thu, 21 Dec 2006 00:53:02 +0000 (00:53 +0000)]
Reviewed by Adam.

Adding new test js-update-style.svg, testing
dynamic style updates via JS (here: stroke-width change)

Setting eol-style native property for all the js-update*.svg
files, as requested by Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Beth.
zimmermann [Thu, 21 Dec 2006 00:26:38 +0000 (00:26 +0000)]
Reviewed by Beth.

Adding new test js-update-pattern.svg, testing
dynamic pattern updates via JS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Maciej.
zimmermann [Thu, 21 Dec 2006 00:13:42 +0000 (00:13 +0000)]
Reviewed by Maciej.

Fix dynamic gradient changes, via JS. It actually worked before, but it
wasn't repainted. Behave just like the pattern notifyAttributeChange() code now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Wed, 20 Dec 2006 23:57:05 +0000 (23:57 +0000)]
    Reviewed by Darin Adler.

        Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
        a Location to string.

        It's really a bug, and poor design, for objects to override toString.
        Subclasses that want custom toString implementations should add a toString
        function to their prototypes instead of overriding the JavaScript ToString
        operation. Following this design pattern would have avoided this bug in the
        first place.

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Sam.
zimmermann [Wed, 20 Dec 2006 23:09:40 +0000 (23:09 +0000)]
Reviewed by Sam.
Add a new set of SVG JavaScript testcases, mostly using SVG DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate computed style layout test results.
hyatt [Wed, 20 Dec 2006 22:30:47 +0000 (22:30 +0000)]
Update computed style layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix SVG stroking. Make strokeThickness() get pushed into CG immediately
hyatt [Wed, 20 Dec 2006 22:25:31 +0000 (22:25 +0000)]
    Fix SVG stroking.  Make strokeThickness() get pushed into CG immediately
        when set in the GraphicsContext.  Remove setLineWidth since it is
        redundant with setStrokeThickness now.

        Reviewed by mitz

        * html/CanvasRenderingContext2D.cpp:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 11893, white text on form controls. Just make sure that
hyatt [Wed, 20 Dec 2006 21:55:41 +0000 (21:55 +0000)]
    Fix for bug 11893, white text on form controls.  Just make sure that
        all form control drawing in RenderTheme is bracketed by save/restore

        Reviewed by adele

        * platform/mac/LocalCurrentGraphicsContext.h:
        * platform/mac/LocalCurrentGraphicsContext.mm:
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-20 Mark Rowe <bdash@webkit.org>
bdash [Wed, 20 Dec 2006 21:54:10 +0000 (21:54 +0000)]
2006-12-20  Mark Rowe  <bdash@webkit.org>

        Reviewed by Anders.

        Fix leak of CGContextRef from GraphicsContext::createImageBuffer.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::createImageBuffer): Release newly-created CGContextRef after passing it to GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Darin.
bdakin [Wed, 20 Dec 2006 21:28:57 +0000 (21:28 +0000)]
    Rubber-stamped by Darin.

        This test also needs updated results after my clone node check-in.
        Somehow, the fix to clone node eliminated the dummy spans in both
        of these tests. This is an improvement.

        * editing/style/remove-underline-expected.checksum:
        * editing/style/remove-underline-expected.png:
        * editing/style/remove-underline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * kjs/string_object.cpp:
andersca [Wed, 20 Dec 2006 20:25:51 +0000 (20:25 +0000)]
    * kjs/string_object.cpp:
        Another speculative Win32 fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * kjs/string_object.cpp:
andersca [Wed, 20 Dec 2006 20:20:20 +0000 (20:20 +0000)]
    * kjs/string_object.cpp:
        Speculative Win32 fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Wed, 20 Dec 2006 20:11:47 +0000 (20:11 +0000)]
    Reviewed by Darin.

        support String.localeCompare.

        Implement localeCompare.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/string_object.cpp:
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Wed, 20 Dec 2006 19:20:00 +0000 (19:20 +0000)]
    Reviewed by Mark Rowe.

        * JavaScriptCore.xcodeproj/project.pbxproj: use GCC 4.0 for all the other test targets

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Wed, 20 Dec 2006 18:54:38 +0000 (18:54 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/4871993> WebCore-421.31 build fails with "Public API change" error when gcc 3.3 is the default compiler

        * bindings/scripts/CodeGeneratorObjC.pm: ignore blank lines in the public API check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Darin.
bdakin [Wed, 20 Dec 2006 18:50:31 +0000 (18:50 +0000)]
    Rubber stamped by Darin.

        Updated results for this test after my clone node check-in

        * editing/style/remove-underline-across-paragraph-expected.checksum:
        * editing/style/remove-underline-across-paragraph-expected.png:
        * editing/style/remove-underline-across-paragraph-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated for Justin's checkin that added properties.
harrison [Wed, 20 Dec 2006 18:41:55 +0000 (18:41 +0000)]
    Updated for Justin's checkin that added properties.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Wed, 20 Dec 2006 18:36:23 +0000 (18:36 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/4871613> JavaScriptCore-421.31's dftables target needs to override default compiler and use gcc-4.0

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Wed, 20 Dec 2006 15:40:34 +0000 (15:40 +0000)]

        Reviewed by John Sullivan.

        Test for <rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

        * editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
        * editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
        * editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
        * editing/deleting/delete-to-end-of-paragraph.html: Added.


        Reviewed by John Sullivan.

        <rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

        * editing/deleting/delete-to-end-of-paragraph.html

        * editing/TypingCommand.cpp:
        If the selection was a caret at the end of the paragraph, extend selection so it wraps to the start of next paragraph (if any),

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix, reviewed by Mitz.
zimmermann [Wed, 20 Dec 2006 14:16:38 +0000 (14:16 +0000)]
Build fix, reviewed by Mitz.
Fix mac build, by using proper float -> int conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix warning on buildbot on mac.
hyatt [Wed, 20 Dec 2006 11:32:54 +0000 (11:32 +0000)]
Fix warning on buildbot on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure text decoration colors prefer stroke over fill (and honor both...
hyatt [Wed, 20 Dec 2006 11:16:20 +0000 (11:16 +0000)]
    Make sure text decoration colors prefer stroke over fill (and honor both of the new CSS properties added
        for these values over color).

        Reviewed by mitz

        Added fast/text/stroking-decorations.html

        * rendering/InlineFlowBox.cpp:
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Wed, 20 Dec 2006 11:05:35 +0000 (11:05 +0000)]

        Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11746
        REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

        * editing/selection/move-begin-end-expected.txt: Updated editing delegate results.
        * fast/forms/onselect-textarea-expected.txt: Updated selection start/end positions.
        * fast/forms/textarea-initial-caret-position-expected.txt: Added.
        * fast/forms/textarea-initial-caret-position.html: Added.
        * fast/forms/textarea-no-scroll-on-blur.html:
        Updated to position caret at end of text to match previous initial focus behavior for this test.
        * fast/forms/textarea-scrollbar.html: Ditto.
        * fast/forms/textarea-scrolled-endline-caret.html: Ditto.
        * fast/forms/textarea-scrolled-type.html: Ditto.


        Reviewed by Darin.

        REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

        Set caret at beginning of text on initial focus.

        Test: fast/forms/textarea-initial-caret-position.html

        * html/HTMLTextAreaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 11889, support stroking and filling of HTML text from CSS. This...
hyatt [Wed, 20 Dec 2006 10:31:33 +0000 (10:31 +0000)]
    Fix for bug 11889, support stroking and filling of HTML text from CSS.  This patch adds four new CSS properties:
        text-fill-color, text-stroke-color, text-stroke-width and text-stroke (a shorthand for the other two).  Text
        is filled and not stroked by default and does so using the text-fill-color.  If this property is not set, then
        color is used.

        Stroking is accomplished by setting a stroke width.  Stroke color, if omitted, will be picked up from the color
        property.  You can set either color to be transparent or partially transparent.  A fully transparent fill color is
        the way to achieve an "outline" effect where only stroking happens.

        Stroking and filling are both customizable inside the ::selection pseudo-element, and so when selecting you can
        vary colors and widths.

        text-shadow applies to both the stroke and the fill.

        text-decorations do not yet respect the stroke/fill colors.  This will follow in a later patch.

        Reviewed by mitz

        Added fast/text/stroking.html as a layout test.  Enhanced RenderTreeAsText.cpp to dump fill and stroke information.

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        * css/cssstyleselector.cpp:
        * platform/mac/FontMac.mm:
        * rendering/InlineFlowBox.cpp:
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded support to bind QObject's to JavaScript.
lars [Wed, 20 Dec 2006 10:05:24 +0000 (10:05 +0000)]
Added support to bind QObject's to JavaScript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Wed, 20 Dec 2006 07:18:26 +0000 (07:18 +0000)]

        Reviewed by Anders.

        Test for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

        * editing/selection/select-all-user-select-none-expected.txt: Added.
        * editing/selection/select-all-user-select-none.html: Added.


        Reviewed by Anders.

        - Fix for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

        Also made user-select:none work on new list boxes, and cleaned up the list box defaultEventHandler.

        Test: editing/selection/select-all-user-select-none.html

        * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Make sure canSelect is true on the root renderer.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::canSelectAll): Check canSelect here.
        (WebCore::HTMLSelectElement::selectAll): Added nil check for renderer.
        (WebCore::HTMLSelectElement::defaultEventHandler): Return early if the event has been handled.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Check canSelect here.
        * html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Wed, 20 Dec 2006 06:52:38 +0000 (06:52 +0000)]
    Reviewed by Geoff.

        Add -p option to testkjs which pretty prints the files instead of executing them.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix bug numbers (Thanks Mitz!)
andersca [Wed, 20 Dec 2006 06:22:28 +0000 (06:22 +0000)]
Fix bug numbers (Thanks Mitz!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
andersca [Wed, 20 Dec 2006 06:00:38 +0000 (06:00 +0000)]

        Reviewed by Adele.

        [9A255] Crash in WebCore::EventTargetNode::dispatchEvent

        * fast/dom/resources/script-element-gc.js: Added.
        * fast/dom/script-element-gc-expected.txt: Added.
        * fast/dom/script-element-gc.html: Added.


        Reviewed by Adele.

        [9A255] Crash in WebCore::EventTargetNode::dispatchEvent

        * html/HTMLScriptElement.cpp:
        Ref the script element while running the script since it can be freed
        when executing the script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Wed, 20 Dec 2006 01:49:03 +0000 (01:49 +0000)]
    Reviewed by Geoff.

        - <rdar://problem/4885227>
          frame resizing is now live and no longer does direct drawing

        * html/HTMLFrameSetElement.h: Made frameBorder() and noResize() const.
        Added rowLengths() and colLengths() getters so that we don't have to
        have RenderFrameSet as a friend. Stopped using bit fields.

        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::defaultEventHandler): Removed now-uneeded
        check for contextmenu events. Look at return value from userResize to
        decide whether to mark the event as "default handled". In the case where
        the event is handled, don't call through to the base class.

        * rendering/RenderFrameSet.h: No longer mark HTMLFrameSetElement as a
        friend. Made positionFrames and canResize private, and changed canResize
        to take an IntPoint. Added isResizingRow, isResizingColumn, canResizeRow,
        and canResizeColumn functions to be used soon for cursor feedback.
        Removed override of non-virtual element() function and replaced it with
        a private frameSet() inline function. Grouped all the data members for
        each axis into a GridAxis class, and made one called m_cols and one called
        m_rows. Used vectors for the resizable bits of this instead of new/delete
        arrays. Added a constant named "noSplit" so we don't have to use -1
        everywhere explicitly for this purpose. Renamed setResizing to
        setIsResizing and made it private. Eliminated resizing() function.
        Added new private helper functions, layOutAxis, findNonResizableSplits,
        splitPosition, hitTestSplit, startResizing, and continueResizing.
        Renamed m_resizing to m_isResizing, and m_clientResizing to

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::RenderFrameSet): Removed now-unneeded initialization
        that is handled by the GridAxis and Vector constructors.
        (WebCore::RenderFrameSet::~RenderFrameSet): Ditto (for destructors).
        (WebCore::RenderFrameSet::GridAxis::GridAxis): Added.
        (WebCore::RenderFrameSet::frameSet): Added. Inline function so we don't have
        to cast the result of node() or element() everywhere.
        (WebCore::RenderFrameSet::nodeAtPoint): Updated for name changes.
        (WebCore::RenderFrameSet::GridAxis::resize): Added. Helper function to be used
        in the layout function.
        (WebCore::RenderFrameSet::layOutAxis): Added. Factored out the part of the
        layout function that used to be inside a for loop for the two axes.
        The algorithm is otherwise unchanged.
        (WebCore::RenderFrameSet::findNonResizableSplits): Added. Factored out the
        code that set up the "split variable" arrays from the layout function.
        (WebCore::RenderFrameSet::layout): Moved the bulk of this function into the
        new helpers. This allowed me to remove the use of goto.
        (WebCore::RenderFrameSet::positionFrames): Updated for change to data structures.
        Also added some more local variables for clarity.
        (WebCore::RenderFrameSet::startResizing): Added. Code factored out of the
        userResize function that handles mousedown events that might begin a resize.
        (WebCore::RenderFrameSet::continueResizing): Added. Code factored out of the
        userResize function that handles mouse events that continue a resize already
        in progress, including mouseup events that end the resizing. Uses the new
        splitPosition function so it can be used over and over again while resizing.
        (WebCore::RenderFrameSet::userResize): Restructured to use the new helper
        functions. Removed the direct drawing of a gray bar during mouse movement;
        instead we do the resizing live.
        (WebCore::RenderFrameSet::setIsResizing): Updated for name changes.
        (WebCore::RenderFrameSet::isResizingRow): Added.
        (WebCore::RenderFrameSet::isResizingColumn): Added.
        (WebCore::RenderFrameSet::canResize): Changed to use hitTestSplit for clarity.
        (WebCore::RenderFrameSet::canResizeRow): Added.
        (WebCore::RenderFrameSet::canResizeColumn): Added.
        (WebCore::RenderFrameSet::splitPosition): Added.
        (WebCore::RenderFrameSet::hitTestSplit): Added. Contains the guts of the code
        that was used both in canResize and userResize before -- now it's shared.
        (WebCore::RenderFrameSet::dump): Updated for name changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 20 Dec 2006 01:16:17 +0000 (01:16 +0000)]

        Reviewed by harrison

        Added Selection::removeAllRanges() and ::addRange()

        * editing/selection/addRange-expected.checksum: Added.
        * editing/selection/addRange-expected.png: Added.
        * editing/selection/addRange-expected.txt: Added.
        * editing/selection/addRange.html: Added.
        * editing/selection/removeAllRanges-expected.txt: Added.
        * editing/selection/removeAllRanges.html: Added.


        Reviewed by harrison

        Added Selection::removeAllRanges() and ::addRange()

        * bindings/js/kjs_window.cpp:
        (KJS::SelectionFunc::callAsFunction): Added the bindings for
        the two new functions.
        * bindings/js/kjs_window.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::removeAllRanges): Equivalent
        to clear().
        (WebCore::SelectionController::addRange): Until we support
        discontiguous selections, the new selected range is the
        union of the old selected range and the passed range if
        the two intersect, and the old range if they don't.
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Wed, 20 Dec 2006 01:07:15 +0000 (01:07 +0000)]
    Reviewed by Darin

        - fix for unrepro infinite recursion bug:
        <rdar://problem/4448181> CrashTracer: 154 crashes in Safari at com.apple.AppKit:
        -[NSView isDescendantOf:] + 24; infinite recursion in makeFirstResponder logic

        * WebView/WebView.mm:
        added becomingFirstResponder BOOL to private struct
        (-[WebView becomeFirstResponder]):
        use _private->becomingFirstResponder to guard against infinite recursion; complain on
        debug builds if we run into this problem

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agom2006-12-19 Oliver Hunt <oliver@apple.com>
oliver [Wed, 20 Dec 2006 00:41:58 +0000 (00:41 +0000)]
m2006-12-19  Oliver Hunt  <oliver@apple.com>

        Fix expected output of layout test to not rely on ms fonts

        * svg/custom/js-font-test-expected.checksum:
        * svg/custom/js-font-test-expected.png:
        * svg/custom/js-font-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
bdakin [Wed, 20 Dec 2006 00:32:37 +0000 (00:32 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4860924> outerHTML gives an out-of-date
        result when applied to a clone

        We were only copying the m_inlineStyleDecl over to clones, but we
        need to copy m_isStyleAttributeValid and
        m_synchronizingStyleAttribute as well to know when we have to
        update style, etc.

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::copyNonAttributeProperties): Copy over all
        three member variables.
        * dom/StyledElement.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::cloneNode): No longer need to copy the
        inline style decl explicitly because copyNonAttributeProperties()
        will take care of it.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::copyNonAttributeProperties): Call into
        parent class implementation. This is important now that there is
        more than one implementation of this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Tue, 19 Dec 2006 23:39:03 +0000 (23:39 +0000)]
    Reviewed by Darin Adler.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=11880
        REGRESSION (r18304): Assertion failure in -[WebHTMLView _canProcessDragWithDraggingInfo:]
        when dragging over the window's a scroll bar (innerFrame)

        RenderLayer needs to check 'active,' when deciding what to do if hit testing
        hasn't hit anything, because we want the default hit testing mechanism to return the
        document when we hit a scrollbar.

        This problem shows that the idea of 'capturing' was a little too ambitious
        in hit testing, at least given the current state of things. So, I've replaced
        'capturing' with 'mouseUp,' the condition that provided the immediate need
        for the capturing flag in the first place.

        * page/EventHandler.cpp:
        * rendering/HitTestRequest.h: Removed 'capturing'
        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
beidson [Tue, 19 Dec 2006 23:08:10 +0000 (23:08 +0000)]

        Rubberstamped by Lou

        Removed unneccessary "else"

        * wtf/Assertions.cpp:


        Reviewed by Ada

        Added a logging channel for network activity for loader work

        * platform/Logging.cpp:
        * platform/Logging.h:
        * platform/mac/LoggingMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 19 Dec 2006 22:06:53 +0000 (22:06 +0000)]

        Reviewed by hyatt

        Docs & Spreadsheets: Comment fails to insert if text is selected in the document

        * fast/dom/Range/surroundContents-1-expected.checksum: Added.
        * fast/dom/Range/surroundContents-1-expected.png: Added.
        * fast/dom/Range/surroundContents-1-expected.txt: Added.
        * fast/dom/Range/surroundContents-1.html: Added.


        Reviewed by hyatt

        Docs & Spreadsheets: Comment fails to insert if text is selected in the document

        * dom/Range.cpp:
        (WebCore::Range::surroundContents): If startContainer is a text node,
        it will be split when the range is extracted, and it will be its parent
        that will have to accept newParent.  Also cleaned up some code with

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Tue, 19 Dec 2006 21:43:27 +0000 (21:43 +0000)]

        Reviewed by Darin.

        <rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

        * JavaScriptCore.xcodeproj/project.pbxproj:


        Reviewed by Darin.

        <rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

        * JavaScriptGlue.xcodeproj/project.pbxproj:


        Reviewed by Darin.

        <rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

        * WebCore.xcodeproj/project.pbxproj:


        Reviewed by Darin.

        <rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann [Tue, 19 Dec 2006 21:38:54 +0000 (21:38 +0000)]
Reviewed by Oliver.
Fix SVGList index validation (off-by-one error).

Adding new testcase js-font-test.svg, which uses SVGLengthList interface.
(This is a very old ksvg1 testcase, adopted for SVG1.1)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann [Tue, 19 Dec 2006 20:17:21 +0000 (20:17 +0000)]
Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11879
Fix pattern on stroke/fill of text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix
aliceli1 [Tue, 19 Dec 2006 19:58:46 +0000 (19:58 +0000)]
    Build fix

        * platform/graphics/ImageBuffer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Tue, 19 Dec 2006 18:56:45 +0000 (18:56 +0000)]
    Reviewed by Darin.

        JavaScript error not thrown when trying to set a CSS property to an invalid value

        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::put): When not in Dashboard compatibility mode,
        raise exception for invalid values. Also removed an unnecessary call to
        removeProperty(), which prevented the property value from being preserved in
        error case.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Moved the handling of
        empty property values here. Also removed an unnecessary call to removeProperty().

        * fast/block/positioning/relayout-on-position-change.html: This test was setting
        position property to an invalid value, expecting that it will be removed. Changed
        it to set the property to an empty value (now the test passes in Firefox, too).

        * fast/dom/css-set-property-exception-expected.txt:
        * fast/dom/css-set-property-exception.html:
        Updated the results, added a new case and made the output more verbose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Tue, 19 Dec 2006 18:45:12 +0000 (18:45 +0000)]
    Reviewed by Adam.

        * dom/Document.h:
        * page/EventHandler.h:
        Use correct forward declarations for HitTestRequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix, not reviewed.
zimmermann [Tue, 19 Dec 2006 15:09:04 +0000 (15:09 +0000)]
Build fix, not reviewed.

Fix Qt/Linux build. Missing GraphicsContext.h include.
Fix Mac build, by adding lroundf() (I swear this compiled w/o that, locally :-)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Sam. Previous attempts reviewed by Oliver & Eric.
zimmermann [Tue, 19 Dec 2006 14:51:13 +0000 (14:51 +0000)]
Reviewed by Sam. Previous attempts reviewed by Oliver & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11867

Bring back masking, by adding off-screen rendering functionality in GraphicsContext.
Add new "static GraphicsContext* createImageContext(const IntSize& size, bool grayScale)"
function, and implement it with CGBitmapContext in the GraphicsContextCG (stubs for Qt.)

Mask image sizes are dynamically calculated using the passed bounding box in applyMask,
as it was orignally planned. Gradient stroke mask image sizes aren't hardcoded to 2048x2048
anymore, but are as well dynamically calculated using getAbsoluteRepaintRect().

Add new ImageBuffer class encapsulating the size of the image, a platform-specific
handle (ie. CGImageRef for CG platform) plus the GraphicsContext pointer, obtained
via GraphicsContext::createImageBuffer. Offer a generic logic for rendering subtrees
of the rendering tree into a ImageBuffer (see renderSubtreeToImage function)
ImageBufferCG is completly implemented, ImageBufferQt is stubbed.

Also add correct default values for x/y/width/height of <mask>.
Fixes masking related LayoutTests, and speeds up gradient-on-stroke a lot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix spelling error in Cairo graphics context.
hyatt [Tue, 19 Dec 2006 11:22:53 +0000 (11:22 +0000)]
Fix spelling error in Cairo graphics context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove save()/restore()... forgot they are more expensive.
hyatt [Tue, 19 Dec 2006 11:07:56 +0000 (11:07 +0000)]
Remove save()/restore()... forgot they are more expensive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure to initialize the CG fill and stroke colors to our initial fill...
hyatt [Tue, 19 Dec 2006 11:04:18 +0000 (11:04 +0000)]
    Make sure to initialize the CG fill and stroke colors to our initial fill/stroke colors when first
        constructing a GraphicsContextCG.  Because Safari actually draws text in the bookmarks bar using GraphicsContext
        and sets a fill color, this could only really be seen in another WebKit app.

        Patched GraphicsContextQt as well, since it has the same pattern.

        Reviewed by bdash

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove an unnecessary cgsetfill in drawEllipse.
hyatt [Tue, 19 Dec 2006 10:47:28 +0000 (10:47 +0000)]
Remove an unnecessary cgsetfill in drawEllipse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix buildbot bustage with conversion of stroke thickness.
hyatt [Tue, 19 Dec 2006 10:26:03 +0000 (10:26 +0000)]
Fix buildbot bustage with conversion of stroke thickness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix drawing of image alt text..
hyatt [Tue, 19 Dec 2006 10:20:38 +0000 (10:20 +0000)]
Fix drawing of image alt text..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix stroking of error image borders.
hyatt [Tue, 19 Dec 2006 10:08:50 +0000 (10:08 +0000)]
Fix stroking of error image borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build and make sure it doesn't crash.
lars [Tue, 19 Dec 2006 09:53:45 +0000 (09:53 +0000)]
Fix the Qt build and make sure it doesn't crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Convert stroke thickness to a float. This allows the thickness argument...
hyatt [Tue, 19 Dec 2006 08:54:00 +0000 (08:54 +0000)]
    Convert stroke thickness to a float.  This allows the thickness argument to strokeArc to be eliminated.

        Reviewed by olliej

        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rename drawArc to strokeArc and remove its strange behavior of trying to...
hyatt [Tue, 19 Dec 2006 08:39:13 +0000 (08:39 +0000)]
    Rename drawArc to strokeArc and remove its strange behavior of trying to "fill" by stroking using the passed in
        thickness.  Now the method is purely about stroking an arc and always uses the passed in thickness.   Fix the
        border-radius code that calls the method so that it makes more sense now.  If stroke thickness is converted
        to a float, then even the extra argument can go away, and this method can be a clean stroke of an arc.

        Make sure to get square list markers right by setting both stroke and fill color properly.

        Reviewed by mitz, olliej

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * rendering/RenderListMarker.cpp:
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Tue, 19 Dec 2006 08:04:48 +0000 (08:04 +0000)]

        Reviewed by Beth Dakin.

        Test cases for capturing of mouse up events.

        * fast/events/mouseup-outside-button-expected.txt: Added.
        * fast/events/mouseup-outside-button.html: Added.
        * fast/events/mouseup-outside-document-expected.txt: Added.
        * fast/events/mouseup-outside-document.html: Added.


        Reviewed by Beth Dakin.

        Fixed <rdar://problem/4549745> REGRESSION: scrolling on Google maps
        continues after the mouse is released outside the window (8137)

        The RenderLayer hit testing code assumed that, when the mouse was outside
        the WebView, we only needed to capture mouse events while the mouse was
        down (in other words, mouse move events). We actually need to capture mouse
        up events, as well.

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent): To match EventHandler::prepareMouseEvent,
        I changed this function to take a HitTestRequest instead of the broken-out values of one.
        For clarity, I moved an assert to top of function.
        (WebCore::Document::addMarker): Removed stray character.
        * dom/Document.h:

        * page/EventHandler.cpp: Changed prepareMouseEvent to take a HitTestRequest,
        instead of the broken-out values of one. This simplified the code, and made
        the task of adding an extra, optional parameter to hit testing much easier.
        (WebCore::EventHandler::handleMouseMoveEvent): Set the 'capturing' flag
        if the move occurs while the mouse is down. This replaces RenderLayer's
        heavy-handed assumption that we should always capture if the mouse is down.
        (WebCore::EventHandler::handleMouseReleaseEvent): Set the 'capturing'
        flag, since we assume every mouse up follows a mouse down inside the WebView.
        (We'd like to ASSERT as much, but DRT's event sending mechanism is crazy, and
        violates this axiom.)
        * page/EventHandler.h:

        * rendering/HitTestRequest.h:
        (WebCore::HitTestRequest::HitTestRequest): Added 'capturing' data member,
        which specifies whether the hit test should capture mouse events that occur
        outside the WebView.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer): Moved misleading comment to where
        it actually applies. Changed 'active' test to new 'capturing' test, so
        the hit test requester can decide whether we need to capture mouse events
        that don't intersect any layer.


        Reviewed by Beth Dakin.

        Updated EventSender to be able to send mouse up events outside the WebView.
        This is a minor tweak to a hackish implementation. The real solution
        should be to use NSApplication's event sending model instead of rolling
        our own, but I don't have time for that right now.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseUp]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure a stroke style is set for list bullets.
hyatt [Tue, 19 Dec 2006 07:45:43 +0000 (07:45 +0000)]
    Make sure a stroke style is set for list bullets.

        Reviewed by mitz

        * rendering/RenderListMarker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-18 Ada Chan <adachan@apple.com>
adachan [Tue, 19 Dec 2006 06:15:09 +0000 (06:15 +0000)]
2006-12-18  Ada Chan  <adachan@apple.com>

        Reviewed by Adam.

        Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
        from WebCoreFrameBridge to Chrome.
        Moved implementation of Frame::scheduleClose to Frame.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
aliceli1 [Tue, 19 Dec 2006 05:30:46 +0000 (05:30 +0000)]

        Reviewed by Adam.

        Test case for <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

        * http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
        * http/tests/misc/location-test-xsl-style-sheet.xml: Added.
        * http/tests/misc/resources/location-test-xsl-style-sheet.xsl: Added.


        Reviewed by Adam.

        Fixed <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.
hyatt [Tue, 19 Dec 2006 05:23:52 +0000 (05:23 +0000)]
Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix spelling error in Qt code..
hyatt [Tue, 19 Dec 2006 05:18:33 +0000 (05:18 +0000)]
Fix spelling error in Qt code..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.
hyatt [Tue, 19 Dec 2006 05:17:43 +0000 (05:17 +0000)]
Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt build bustage by removing setPlatformPen.
hyatt [Tue, 19 Dec 2006 05:02:57 +0000 (05:02 +0000)]
Fix Qt build bustage by removing setPlatformPen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add save/restore calls around the painting of text areas on Mac, since the...
hyatt [Tue, 19 Dec 2006 04:58:05 +0000 (04:58 +0000)]
    Add save/restore calls around the painting of text areas on Mac, since the methods in question
        alter the current fill color in CG destructively.

        Reviewed by olliej

        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix list markers to properly stroke and fill. I screwed this up when changin...
hyatt [Tue, 19 Dec 2006 04:31:18 +0000 (04:31 +0000)]
    Fix list markers to properly stroke and fill.  I screwed this up when changing how text draws.

        Reviewed by olliej

        * rendering/RenderListMarker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Eliminate the Pen object in favor of separate stroke variables, since most...
hyatt [Tue, 19 Dec 2006 04:00:11 +0000 (04:00 +0000)]
    Eliminate the Pen object in favor of separate stroke variables, since most code just wants to set the
        stroke color.  This also makes it easier for us to push only stroke color through into CG synchronously
        while leaving the others alone.

        Reviewed by olliej

        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/mac/FontMac.mm:
        * rendering/InlineFlowBox.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderFrameSet.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderText.cpp:
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
darin [Tue, 19 Dec 2006 02:30:15 +0000 (02:30 +0000)]
    Reviewed by Adele.

        - fix <rdar://problem/4889565> REGRESSION (r17597): Command-clicking a submit
          button does not submit in a new tab/window

        - change DOMActivate events to be created as a part of default handling of
          click events instead of having the sender of the click event also send
          a DOMActivate event

        - fixed some edge cases in the slider thumb element handler; since this is
          inside a shadow DOM, it's likely none of these can arise in practice

        No easy way to test the command-click part since the behavior is in Safari.
        To make a test we'd have to provide JavaScript access to the modifiers passed
        to the policy delegate or have some way to query the underlying event from

        * dom/EventTargetNode.cpp: Change all assert to ASSERT.
        (WebCore::EventTargetNode::dispatchMouseEvent): Renamed some local variables
        for clarity. Added a RefPtr for relatedTarget since it might be deallocated
        by the handlers for the click event and is used in the code that creates the
        dblclick event. Removed the code to create a DOMActivate event, since that's
        now done in the default event handler for the click event.
        (WebCore::EventTargetNode::defaultEventHandler): Added code to check for a
        click event and dispatch a DOMActivate event using the click event as the
        underlying event. The part of this that fixes the bug is that we use the
        click event as the underlying event; the old code used the same underlying
        event as for the click event, not the click event itself. The underlying event
        for the click event is usually 0, since we propagate the key state to the click
        event instead of using an underlying event in the common case.

        * dom/Document.cpp: (WebCore::Document::defaultEventHandler): Added call
        to the base class's defaultEventHandler function, except in the case where
        the event is already handled.

        * html/HTMLInputElement.h: Removed clickX() and clickY().
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::appendFormData): Use xPos and yPos directly,
        so we can remove clickX() and clickY().
        (WebCore::HTMLInputElement::defaultEventHandler): Removed code that calls
        setDefaultHandled for click events since we are just recording the x and y
        coordinates of the events; that's not "handling" an event, and setting
        the flag prevents us from calling the base class's default event handler,
        which is now needed to submmit the form.

        * rendering/RenderSlider.cpp:
        Added some missing isMouseEvent checks in code that casts to a MouseEvent.
        Added check document()->frame() in code that manipulates the frame so that
        fake events, which might happen when there's no frame, can't cause a crash.
        Added an m_inDragMode check so we don't try to handle mouseup events when
        we are not handling a drag. Remove the setDefaultHandled call from the
        mousemove case, because mousemove events are observed, and not "handled"
        in the "nobody else should look at this event" sense. Added a call to the
        base class's default event handler, and some return statements so that we
        won't call it when the event has been handled.

        * html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
        Removed an unneeded "return" for a function that has no return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-18 Mark Rowe <bdash@webkit.org>
bdash [Tue, 19 Dec 2006 02:04:36 +0000 (02:04 +0000)]
2006-12-18  Mark Rowe  <bdash@webkit.org>

        Reviewed by Brady.

        Bug 11870: Bug 11866 caused layout test regression in fast/forms/input-value.html

        * fast/forms/input-value-expected.txt: Updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Tue, 19 Dec 2006 01:38:34 +0000 (01:38 +0000)]
        Fix for <rdar://problem/4749770> WebCore crashes on a blog website
        in WebCore::InlineBox::root() + 6

        We null-check inlineBoxWrapper everywhere else in the code except
        for these 3 spots. This patch adds them in. Only one of the checks
        is required to fix the crash. What we render for the test case now
        matches shipping Safari, but still seems wrong because we do not
        match Firefox. I will file a follow-up about the rendering problem.

        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker): This is the required
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::setSelectionState): Null-check for
        (WebCore::RenderListMarker::selectionRect): Same.

        Reviewed by Adele.

        Test case for <rdar://problem/4749770> WebCore crashes on a blog
        website in WebCore::InlineBox::root() + 6

        * fast/lists/inlineBoxWrapperNullCheck-expected.checksum: Added.
        * fast/lists/inlineBoxWrapperNullCheck-expected.png: Added.
        * fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
        * fast/lists/inlineBoxWrapperNullCheck.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18291 268f45cc-cd09-0410-ab3c-d52691b4dbfc