WebKit-https.git
5 years agoRun clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
joepeck@webkit.org [Mon, 20 Jan 2014 21:15:39 +0000 (21:15 +0000)]
Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=127206

Reviewed by Anders Carlsson.

Let clang-modernize add overrides.

* inspector/DOMEditor.cpp:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/PageDebuggerAgent.h:
* inspector/PageRuntimeAgent.h:
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerInspectorController.cpp:
* inspector/WorkerRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove WebAudio source code to std::unique_ptr
zandobersek@gmail.com [Mon, 20 Jan 2014 20:36:11 +0000 (20:36 +0000)]
Move WebAudio source code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127274

Reviewed by Eric Carlson.

Move from using OwnPtr and PassOwnPtr to using std::unique_ptr and move semantics
in the WebAudio module and the WebAudio code in the platform layer.

* Modules/webaudio/AsyncAudioDecoder.cpp:
* Modules/webaudio/AsyncAudioDecoder.h:
* Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
* Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
* Modules/webaudio/AudioBasicProcessorNode.h:
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::addInput):
(WebCore::AudioNode::addOutput):
(WebCore::AudioNode::checkNumberOfChannelsForInput):
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::createKernel):
(WebCore::BiquadProcessor::getFrequencyResponse):
* Modules/webaudio/BiquadProcessor.h:
* Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
* Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::uninitialize):
(WebCore::ConvolverNode::setBuffer):
* Modules/webaudio/ConvolverNode.h:
* Modules/webaudio/DefaultAudioDestinationNode.h:
* Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
* Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::createKernel):
* Modules/webaudio/DelayProcessor.h:
* Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):
(WebCore::DynamicsCompressorNode::uninitialize):
* Modules/webaudio/DynamicsCompressorNode.h:
* Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioDestinationNode.h:
* Modules/webaudio/MediaStreamAudioSource.cpp:
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::uninitialize):
(WebCore::PannerNode::setPanningModel):
* Modules/webaudio/PannerNode.h:
* Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::createBandLimitedTables):
* Modules/webaudio/PeriodicWave.h:
* Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::RealtimeAnalyser):
(WebCore::RealtimeAnalyser::setFftSize):
* Modules/webaudio/RealtimeAnalyser.h:
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
* Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
* Modules/webaudio/WaveShaperDSPKernel.h:
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
* Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::createKernel):
* Modules/webaudio/WaveShaperProcessor.h:
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::copyWithGainFrom):
* platform/audio/AudioBus.h:
* platform/audio/AudioChannel.cpp:
* platform/audio/AudioChannel.h:
(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set):
* platform/audio/AudioDSPKernelProcessor.h:
* platform/audio/AudioDestination.h:
* platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):
* platform/audio/AudioResampler.h:
* platform/audio/AudioSession.h:
* platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setNumberOfChannels):
* platform/audio/DynamicsCompressor.h:
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
* platform/audio/DynamicsCompressorKernel.h:
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::createInterpolatedFrame):
* platform/audio/FFTFrame.h:
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::HRTFDatabase):
* platform/audio/HRTFDatabase.h:
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::load):
* platform/audio/HRTFDatabaseLoader.h:
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::createForSubject):
(WebCore::HRTFElevation::createByInterpolatingSlices):
* platform/audio/HRTFElevation.h:
(WebCore::HRTFElevation::HRTFElevation):
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createImpulseResponse):
(WebCore::HRTFKernel::createInterpolatedKernel):
* platform/audio/HRTFKernel.h:
(WebCore::HRTFKernel::create):
(WebCore::HRTFKernel::HRTFKernel):
* platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
* platform/audio/MultiChannelResampler.h:
* platform/audio/Panner.cpp:
(WebCore::Panner::create):
* platform/audio/Panner.h:
* platform/audio/Reverb.cpp:
(WebCore::Reverb::initialize):
* platform/audio/Reverb.h:
* platform/audio/ReverbConvolver.h:
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
* platform/audio/ReverbConvolverStage.h:
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
* platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestination::create):
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::AudioSession):
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
* platform/audio/mac/AudioDestinationMac.h:
* platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::AudioSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build.
andersca@apple.com [Mon, 20 Jan 2014 20:26:08 +0000 (20:26 +0000)]
Fix build.

* heap/BlockAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegion based multicol: support explicit column breaks
commit-queue@webkit.org [Mon, 20 Jan 2014 19:55:59 +0000 (19:55 +0000)]
Region based multicol: support explicit column breaks
https://bugs.webkit.org/show_bug.cgi?id=123993

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.

Source/WebCore:

Merely supporting insertion of explicit (forced) column breaks in
the region based multicol implementation is really simple: just
hook up with what the CSS regions code is already doing.

However, there is one complication: column balancing. In order to
balance columns as nicely as possible when there are explicit
breaks, we need to figure out between which explicit breaks the
implicit breaks will occur (if there's room for any at all).

Tests: fast/multicol/newmulticol/break-after.html
       fast/multicol/newmulticol/break-before.html
       fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html
       fast/multicol/newmulticol/breaks-2-columns-3.html
       fast/multicol/newmulticol/breaks-3-columns-3.html
       fast/multicol/newmulticol/fixed-height-fill-balance-2.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak): Use the already
existing region breaking code when inserting breaks in region
based multicol.
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::relayoutForPagination): Avoid
re-balancing if the multicol's contents were not laid out. Apart
from being good for performance, this is now necessary because of
how explicit breaks are implemented.
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
Detect if the contents are going to be laid out, or skipped, so
that we can tell if we need to (re-)balance the columns
afterwards.
* rendering/RenderMultiColumnBlock.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):
Locate the appropriate multi-column set and call its
addForcedBreak().
* rendering/RenderMultiColumnFlowThread.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::findRunWithTallestColumns):
(WebCore::RenderMultiColumnSet::distributeImplicitBreaks): Figure
out how many implicit breaks each single "content run" should
contain. The taller the content run, the more implicit breaks.
(WebCore::RenderMultiColumnSet::calculateBalancedHeight): This is
now a const method that only does half of what the old
calculateBalancedHeight() did. The rest (such as actually storing
the new column height) is done by recalculateBalancedHeight().
(WebCore::RenderMultiColumnSet::clearForcedBreaks): Needs to be
called between each layout pass, to clear the list of "content
runs".
(WebCore::RenderMultiColumnSet::addForcedBreak): Only useful when
columns are to be balanced. It receives explicit (forced) breaks
and stores them as "content runs". When layout is done, we'll go
through the list of content runs, and see where implicit breaks
should be inserted (if there's room for any). The goal is to
insert implicit breaks in such a way that the final columns become
as short as possible.
(WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
Calculates and sets a new balanced column height. This used to be
done directly in calculateBalancedHeight(), but that method is now
const and it now only calculates the new height and returns it.
(WebCore::RenderMultiColumnSet::prepareForLayout):
* rendering/RenderMultiColumnSet.h: Remove old data members
intended for forced breaks (they were unused), and introduce a
"content run" vector instead. A new content run is triggered by an
explicit break. This is only used when column balancing is
enabled. When not balanced, RenderMultiColumnSet doesn't need to
do anything when explicit breaks are inserted.

LayoutTests:

* fast/multicol/newmulticol/break-after-expected.html: Added.
* fast/multicol/newmulticol/break-after.html: Added.
* fast/multicol/newmulticol/break-before-expected.html: Added.
* fast/multicol/newmulticol/break-before.html: Added.
* fast/multicol/newmulticol/breaks-2-columns-3-expected.html: Added.
* fast/multicol/newmulticol/breaks-2-columns-3-no-balancing-expected.html: Added.
* fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html: Added.
* fast/multicol/newmulticol/breaks-2-columns-3.html: Added.
* fast/multicol/newmulticol/breaks-3-columns-3-expected.html: Added.
* fast/multicol/newmulticol/breaks-3-columns-3.html: Added.
* fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html: Added.
* fast/multicol/newmulticol/fixed-height-fill-balance-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate style checker and tests to deal with override instead of OVERRIDE
darin@apple.com [Mon, 20 Jan 2014 19:39:15 +0000 (19:39 +0000)]
Update style checker and tests to deal with override instead of OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=127175

Reviewed by Anders Carlsson.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces): Use override instead of OVERRIDE.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_brace_at_begin_of_line): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop using ThreadCondition in BlockAllocator
andersca@apple.com [Mon, 20 Jan 2014 19:31:33 +0000 (19:31 +0000)]
Stop using ThreadCondition in BlockAllocator
https://bugs.webkit.org/show_bug.cgi?id=126313

Reviewed by Sam Weinig.

* heap/BlockAllocator.cpp:
(JSC::BlockAllocator::~BlockAllocator):
(JSC::BlockAllocator::waitForDuration):
(JSC::BlockAllocator::blockFreeingThreadMain):
* heap/BlockAllocator.h:
(JSC::BlockAllocator::deallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix jumping to a text position when showing a resource.
timothy@apple.com [Mon, 20 Jan 2014 19:25:01 +0000 (19:25 +0000)]
Fix jumping to a text position when showing a resource.

https://bugs.webkit.org/show_bug.cgi?id=127271

Reviewed by Joseph Pecoraro.

* UserInterface/FrameContentView.js:
(WebInspector.FrameContentView.prototype.showSourceCode): Just use showResponse's arguments
which already does the same logic to call revealPosition.
* UserInterface/ResourceClusterContentView.js:
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie): This was the bug.
lineNumber and columnNumber need honored here. They were only honored by FrameContentView.
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode): Use showContentViewForRepresentedObject
which also accepts a cookie and handles creating the content view for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAllow MediaSessionManager to restrict 'preload' behavior
eric.carlson@apple.com [Mon, 20 Jan 2014 19:23:40 +0000 (19:23 +0000)]
Allow MediaSessionManager to restrict 'preload' behavior
https://bugs.webkit.org/show_bug.cgi?id=127297

Reviewed by Jer Noble.

Source/WebCore:

Tests: media/video-restricted-no-preload-auto.html
       media/video-restricted-no-preload-metadata.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Apply restrictions to preload attribute before
    passing to media engine.
(WebCore::HTMLMediaElement::loadResource): Ditto.

* html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::effectivePreloadForElement): New, limit preload according to restrictions.
* html/HTMLMediaSession.h:

* platform/audio/MediaSessionManager.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::resetRestrictions): Limit preload to metadata only. Drive-by
    static deviceClass initialization cleanup.

* testing/Internals.cpp:
(WebCore::Internals::setMediaSessionRestrictions): Support MetadataPreloadingNotPermitted and
    AutoPreloadingNotPermitted.

LayoutTests:

* media/video-restricted-no-preload-auto-expected.txt: Added.
* media/video-restricted-no-preload-auto.html: Added.
* media/video-restricted-no-preload-metadata-expected.txt: Added.
* media/video-restricted-no-preload-metadata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix test expectations for css3/compositing/background-blend-mode-data-uri-svg-image...
commit-queue@webkit.org [Mon, 20 Jan 2014 18:53:00 +0000 (18:53 +0000)]
Fix test expectations for css3/compositing/background-blend-mode-data-uri-svg-image.html
https://bugs.webkit.org/show_bug.cgi?id=127298

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Mihnea Ovidenie.

* platform/efl/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEWS should provide better information to Dashboard via JSON
ap@apple.com [Mon, 20 Jan 2014 18:37:49 +0000 (18:37 +0000)]
EWS should provide better information to Dashboard via JSON
https://bugs.webkit.org/show_bug.cgi?id=127265

Reviewed by Ryosuke Niwa.

* QueueStatusServer/app.yaml: Updated version.

* QueueStatusServer/main.py:
* QueueStatusServer/handlers/queuelengthjson.py:
Added a way to cheaply get only the queue length, which is all the dashboard
needs unless a popover is opened.

* QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
that we will need. Changed some field names to be more meaningful. Fixed bot listing
to understand that a bot can be reprurposed and used in a different queue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake uploading results to EWS work despite robots.txt
ap@apple.com [Mon, 20 Jan 2014 18:24:34 +0000 (18:24 +0000)]
Make uploading results to EWS work despite robots.txt
https://bugs.webkit.org/show_bug.cgi?id=127296

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
checking robots.txt.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
Removed a comment saying that we would want to stop doing this. Not checking
robots.txt is more efficient than checking it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLet RenderImage construct its RenderImageResource.
akling@apple.com [Mon, 20 Jan 2014 17:27:08 +0000 (17:27 +0000)]
Let RenderImage construct its RenderImageResource.
<https://webkit.org/b/127290>

Everyone who creates a RenderImage immediately follows up with
creating a RenderImageResource and assigning it to the image.

Let the RenderImage constructor do this instead, and make the
imageResource() accessors return references. This exposed a
number of unnecessary null checks.

Also modernized the touched code with std::unique_ptr.

Reviewed by Antti Koivisto.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createElementRenderer):
(WebCore::HTMLImageElement::didAttachRenderers):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::parseAttribute):
* html/ImageInputType.cpp:
(WebCore::ImageInputType::createInputRenderer):
(WebCore::ImageInputType::attach):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::~RenderImage):
(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::minimumReplacedHeight):
(WebCore::RenderImage::computeIntrinsicRatioInformation):
(WebCore::RenderImage::embeddedContentBox):
* rendering/RenderImage.h:
(WebCore::RenderImage::imageResource):
(WebCore::RenderImage::cachedImage):
* rendering/RenderImageResource.h:
* rendering/RenderImageResourceStyleImage.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
* rendering/RenderSnapshottedPlugIn.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
* rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createContentRenderer):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::~RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::paintForeground):
* rendering/svg/RenderSVGImage.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::didAttachRenderers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove an unused member variable
andersca@apple.com [Mon, 20 Jan 2014 17:25:38 +0000 (17:25 +0000)]
Remove an unused member variable
https://bugs.webkit.org/show_bug.cgi?id=127295

Reviewed by Antti Koivisto.

* wtf/MainThread.cpp:
(WTF::FunctionWithContext::FunctionWithContext):
(WTF::FunctionWithContext::operator == ):
(WTF::dispatchFunctionsFromMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate overlay scrollbars in single pass
antti@apple.com [Mon, 20 Jan 2014 17:21:26 +0000 (17:21 +0000)]
Update overlay scrollbars in single pass
https://bugs.webkit.org/show_bug.cgi?id=127289

Reviewed by Anders Carlsson.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

    Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove MutexTryLocker
andersca@apple.com [Mon, 20 Jan 2014 17:19:22 +0000 (17:19 +0000)]
Remove MutexTryLocker
https://bugs.webkit.org/show_bug.cgi?id=127294

Reviewed by Antti Koivisto.

MutexTryLocker has been replaced with std::unique_lock with std::try_to_lock everywhere now.

* wtf/ThreadingPrimitives.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoConvert GCThreadSharedData over to STL threading primitives
andersca@apple.com [Mon, 20 Jan 2014 17:10:36 +0000 (17:10 +0000)]
Convert GCThreadSharedData over to STL threading primitives
https://bugs.webkit.org/show_bug.cgi?id=127256

Reviewed by Andreas Kling.

* heap/GCThread.cpp:
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
* heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::startNextPhase):
(JSC::GCThreadSharedData::endCurrentPhase):
(JSC::GCThreadSharedData::didStartMarking):
(JSC::GCThreadSharedData::didFinishMarking):
* heap/GCThreadSharedData.h:
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drainFromShared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNever send a non-http(s) referrer header even with a referrer policy
jochen@chromium.org [Mon, 20 Jan 2014 17:02:50 +0000 (17:02 +0000)]
Never send a non-http(s) referrer header even with a referrer policy
https://bugs.webkit.org/show_bug.cgi?id=127172

Reviewed by Alexey Proskuryakov.

This mirrors the code SecurityPolicy::shouldHideReferrer which is used
for ReferrerPolicyDefault.

No new tests, only affects an embedder that registers other schemes,
e.g. chrome://

* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade...
commit-queue@webkit.org [Mon, 20 Jan 2014 16:36:19 +0000 (16:36 +0000)]
Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw

https://bugs.webkit.org/show_bug.cgi?id=126887

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-crossfade-image.html

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.

LayoutTests: Reapply:
[CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Tests now use SVG rects, instead
of circles.

https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-crossfade-image-expected.html:
* css3/compositing/background-blend-mode-crossfade-image.html:
* platform/efl/TestExpectations: Pass efl as blendMode is not implemented.
* platform/mac/TestExpectations: Mark added test as ImageOnlyFailure due to slight differences between the result and the blending formula.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Simplify grid-columns-rows-get-set{-multiple}.html tests
svillar@igalia.com [Mon, 20 Jan 2014 16:34:04 +0000 (16:34 +0000)]
[CSS Grid Layout] Simplify grid-columns-rows-get-set{-multiple}.html tests
https://bugs.webkit.org/show_bug.cgi?id=127055

Reviewed by Andreas Kling.

The testing code was refactored in 4 new functions that allow us
to write each test case in a single line significantly reducing
the amount of boilerplate and improving maintenance.

* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/named-grid-line-get-set-expected.txt:
* fast/css-grid-layout/named-grid-line-get-set.html:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js: Added.
(testGridDefinitionsValues):
(testGridDefinitionsSetJSValues):
(testNonGridDefinitionsSetJSValues):
(checkGridDefinitionsSetJSValues): Helper function for testGridDefinitions*.
(testGridDefinitionsSetBadJSValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNull-pointer dereference in WebCore::CSSValue::isPrimitiveValue
svillar@igalia.com [Mon, 20 Jan 2014 16:28:41 +0000 (16:28 +0000)]
Null-pointer dereference in WebCore::CSSValue::isPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=124769

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/gradients/crash-on-no-position-separator.html

The function parseFillPosition() may not return valid values for
centerX and centerY if the input data is malformed. We need to
check that we get a valid pair of positions before checking that
they're actually valid primitive values in the assertions.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseRadialGradient):

LayoutTests:

Checks that invalid position declarations (like skiping the comma
separator) do not make the engine crash.

* fast/gradients/crash-on-no-position-separator-expected.txt: Added.
* fast/gradients/crash-on-no-position-separator.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: Background-blend-mode doesn't work for an element with an
commit-queue@webkit.org [Mon, 20 Jan 2014 16:15:45 +0000 (16:15 +0000)]
Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-data-uri-svg-image.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
* svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.

LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
Tests now use rectangles instead of circles for SVGs.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
* css3/compositing/background-blend-mode-data-uri-svg-image.html:
* platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
* platform/mac/TestExpectations: marking test as ImageOnlyFailure due to slight pixel inconsistencies between the result and the formula.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel layout: setSimpleLineLayoutEnabled() produces different layout when line...
zalan@apple.com [Mon, 20 Jan 2014 15:42:13 +0000 (15:42 +0000)]
Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when line position has CSS px fractions.
https://bugs.webkit.org/show_bug.cgi?id=126892

Reviewed by Antti Koivisto.

SimpleLineLayout needs to copy normal linebox layout's subpixel rounding strategy to produce
the same layout.

Source/WebCore:

Covered by existing tests.

* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):

LayoutTests:

* platform/mac/TestExpectations: Unskipping some SimpleLineLayout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Mon, 20 Jan 2014 14:09:21 +0000 (14:09 +0000)]
Unreviewed EFL gardening

Add test expectations for failing tests.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCol width is not honored when dynamically updated and it would make table narrower
commit-queue@webkit.org [Mon, 20 Jan 2014 11:59:14 +0000 (11:59 +0000)]
Col width is not honored when dynamically updated and it would make table narrower
https://bugs.webkit.org/show_bug.cgi?id=104711

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-20
Reviewed by Antti Koivisto.

Source/WebCore:

Increasing the table width by increasing the colgroup width
was working but decreasing the table width by decreasing the
colgroup width is not working.

Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html

* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
When colgroup width is defined table cell should adjust according to
that. On decreasing colgroup width the cells maxPreferredLogicalWidth
was still set to the earlier value. Setting the
setPreferredLogicalWidthsDirty to true so that cells pref width is
calculated again.

LayoutTests:

* fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
* fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
Added new test case to verify that table cell width decreases by
decreasing the colgroup width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics] Segmentation fault at CoordinatedGraphicsScene::clearImageBack...
commit-queue@webkit.org [Mon, 20 Jan 2014 11:14:04 +0000 (11:14 +0000)]
[CoordinatedGraphics] Segmentation fault at  CoordinatedGraphicsScene::clearImageBackingContents

https://bugs.webkit.org/show_bug.cgi?id=125776

Patch by Edit Balint <edbalint@inf.u-szeged.hu> on 2014-01-20
Reviewed by Csaba Osztrogonác.

Unexpected behavior occurs in some test cases which leads to segmentation fault.

* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::removeImageBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 20 Jan 2014 10:57:02 +0000 (10:57 +0000)]
Unreviewed GTK gardening.

Marked media/audio-concurrent-supported.html as flaky.
Marked js/dom/string-replacement-outofmemory.html as slow on the release configuration as well.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegion based multicol: tall line causes taller multicol container than necessary
commit-queue@webkit.org [Mon, 20 Jan 2014 08:58:36 +0000 (08:58 +0000)]
Region based multicol: tall line causes taller multicol container than necessary
https://bugs.webkit.org/show_bug.cgi?id=122550

Source/WebCore:

Detect and report all column breaks, also when there's no pagination strut involved.

This may end up becoming the overall smallest space shortage in some cases,
so we need to report it, to avoid column height over-stretching.

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.

Test: fast/multicol/newmulticol/balance10.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

LayoutTests:

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.

* fast/multicol/newmulticol/balance10-expected.txt: Added.
* fast/multicol/newmulticol/balance10.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Additional build fixes after r162276 and r163304.
zandobersek@gmail.com [Mon, 20 Jan 2014 08:28:33 +0000 (08:28 +0000)]
Unreviewed. Additional build fixes after r162276 and r163304.

* Platform/WorkQueue.h:
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::EventSource):
(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GLIB] GVariant floating references are not correctly handled by GRefPtr
carlosgc@webkit.org [Mon, 20 Jan 2014 08:01:16 +0000 (08:01 +0000)]
[GLIB] GVariant floating references are not correctly handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=127246

Reviewed by Martin Robinson.

Source/WebCore:

Do not adopt GVariant floating references, they will be converted
to a full reference by GRefPtr.

* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):
(WebCore::PasteboardHelper::fillDataObjectFromDropData):

Source/WTF:

GRefPtr should always use g_variant_ref_sink to deal with GVariant
floating references. In case of full references,
g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.

* wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Use g_variant_ref_sink().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse unsigned type for the size of CSSParserValueList
jinwoo7.song@samsung.com [Mon, 20 Jan 2014 07:25:19 +0000 (07:25 +0000)]
Use unsigned type for the size of CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=127211

Reviewed by Andreas Kling.

* css/CSSParser.cpp: Changed variable type from int to unsigned.
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK build fix after r162276.
zandobersek@gmail.com [Mon, 20 Jan 2014 07:03:57 +0000 (07:03 +0000)]
Unreviewed GTK build fix after r162276.

Updating the WorkQueue implementation to use std::function and std::chrono.

* Platform/WorkQueue.h:
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK1] Remove and refactor the APIs which use single and base keyword
ryuan.choi@samsung.com [Mon, 20 Jan 2014 06:44:59 +0000 (06:44 +0000)]
[EFL][WK1] Remove and refactor the APIs which use single and base keyword
https://bugs.webkit.org/show_bug.cgi?id=127214

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Since removed ewk_vie_tiled, we don't need to use single or base in the API name.
Removed them and clean up the code.

* ewk/ewk_view.cpp:
(ewk_view_smart_set):
(_ewk_view_smart_class_new):
(ewk_view_add):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
Removed the class names and macro to distinguish single or tiled.
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):

Tools:

Followed the changes of API.

* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(drtViewAdd):
* EWebLauncher/main.c:
(windowCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Add touch events option to MiniBrowser.
eunmi15.lee@samsung.com [Mon, 20 Jan 2014 06:34:52 +0000 (06:34 +0000)]
[EFL][WK2] Add touch events option to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=127262

Reviewed by Gyuyoung Kim.

As a default, touch events are disabled and mouse events are enabled.
If touch events option sets to true, touch events are enabled and mouse
events are disabled.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed debug build fix on EFL port after r162300.
jinwoo7.song@samsung.com [Mon, 20 Jan 2014 04:42:32 +0000 (04:42 +0000)]
Unreviewed debug build fix on EFL port after r162300.

* Platform/efl/DispatchQueueWorkItemEfl.h:
(TimerWorkItem::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] build fix after r162276
jinwoo7.song@samsung.com [Mon, 20 Jan 2014 04:13:16 +0000 (04:13 +0000)]
[EFL][WK2] build fix after r162276
https://bugs.webkit.org/show_bug.cgi?id=127259

Reviewed by Anders Carlsson.

* Platform/efl/DispatchQueueEfl.cpp:
(DispatchQueue::performTimerWork):
(DispatchQueue::getNextTimeOut):
* Platform/efl/DispatchQueueWorkItemEfl.h:
(WorkItem::create):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):
* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix after r162293
ljaehun.lim@samsung.com [Mon, 20 Jan 2014 01:18:13 +0000 (01:18 +0000)]
Unreviewed build fix after r162293

Fix debug build.

[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note:   no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: *** [all] Error 2

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
zalan@apple.com [Mon, 20 Jan 2014 00:07:21 +0000 (00:07 +0000)]
Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
https://bugs.webkit.org/show_bug.cgi?id=126080

Reviewed by Sam Weinig.

This changes the output of printing LayoutUnits to be in px but it also
preserves the original LayoutUnit value.

This will lead to lldb output like: (and it works even when subpixel is disabled)

(const WebCore::LayoutRect) $0 = {
    m_location = { x = 2.25px (144), y = 1px (64)}
    m_size = { width = 13.75px (880), height = 20px (1280) }

And gdb output like:

m_frameRect = {
    m_location = LayoutPoint(0px (0), 0px(0)),
    m_size = LayoutSize(8px (512), 5px (320))
}

This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.

* gdb/webkit.py:
(WebCoreLayoutUnitPrinter):
(WebCoreLayoutUnitPrinter.__init__):
(WebCoreLayoutUnitPrinter.to_string):
(WebCoreLayoutSizePrinter):
(WebCoreLayoutSizePrinter.__init__):
(WebCoreLayoutSizePrinter.to_string):
(WebCoreLayoutPointPrinter):
(WebCoreLayoutPointPrinter.__init__):
(WebCoreLayoutPointPrinter.to_string):
(add_pretty_printers):
* lldb/lldb_webkit.py:
(__lldb_init_module):
(WebCoreLayoutUnit_SummaryProvider):
(WebCoreLayoutSize_SummaryProvider):
(WebCoreLayoutPoint_SummaryProvider):
(WebCoreLayoutUnitProvider):
(WebCoreLayoutUnitProvider.__init__):
(WebCoreLayoutUnitProvider.to_string):
(WebCoreLayoutSizeProvider):
(WebCoreLayoutSizeProvider.__init__):
(WebCoreLayoutSizeProvider.get_width):
(WebCoreLayoutSizeProvider.get_height):
(WebCoreLayoutPointProvider):
(WebCoreLayoutPointProvider.__init__):
(WebCoreLayoutPointProvider.get_x):
(WebCoreLayoutPointProvider.get_y):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop using MutexTryLocker in WebCore
andersca@apple.com [Sun, 19 Jan 2014 20:37:53 +0000 (20:37 +0000)]
Stop using MutexTryLocker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=127254

Reviewed by Andreas Kling.

Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.

* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::setBuffer):
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelScheduledValues):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
* Modules/webaudio/AudioParamTimeline.h:
* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::process):
(WebCore::ConvolverNode::reset):
(WebCore::ConvolverNode::setBuffer):
* Modules/webaudio/ConvolverNode.h:
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):
* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
* Modules/webaudio/PannerNode.h:
* Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::setOversample):
(WebCore::WaveShaperProcessor::process):
* Modules/webaudio/WaveShaperProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDoes not build with SVG disabled
berto@igalia.com [Sun, 19 Jan 2014 19:13:10 +0000 (19:13 +0000)]
Does not build with SVG disabled
https://bugs.webkit.org/show_bug.cgi?id=127248

Reviewed by Sam Weinig.

Add missing #if ENABLE(SVG) guard.

* dom/ElementData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed Apple Windows port gardering.
zalan@apple.com [Sun, 19 Jan 2014 19:00:49 +0000 (19:00 +0000)]
Unreviewed Apple Windows port gardering.

A few more missing newlines.

* platform/win/svg/batik/masking/maskRegions-expected.txt:
* platform/win/svg/batik/text/textPosition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse a strong enum for HTMLTreeBuilder::InsertionMode
andersca@apple.com [Sun, 19 Jan 2014 19:00:27 +0000 (19:00 +0000)]
Use a strong enum for HTMLTreeBuilder::InsertionMode
https://bugs.webkit.org/show_bug.cgi?id=127252

Reviewed by Antti Koivisto.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::closeTheCell):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForInitial):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
* html/parser/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoConvert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives
andersca@apple.com [Sun, 19 Jan 2014 18:42:01 +0000 (18:42 +0000)]
Convert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives
https://bugs.webkit.org/show_bug.cgi?id=127251

Reviewed by Antti Koivisto.

Also add a condition to the loaderRunLoop() function to protect against spurious wake-ups.

* platform/ios/wak/WebCoreThreadRun.cpp:
* platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::loaderRunLoopMutex):
(WebCore::loaderRunLoopConditionVariable):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModernize ReverbConvolver
andersca@apple.com [Sun, 19 Jan 2014 18:20:51 +0000 (18:20 +0000)]
Modernize ReverbConvolver
https://bugs.webkit.org/show_bug.cgi?id=127250

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr and the STL threading primitives instead of the WTF ones.

* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::~ReverbConvolver):
(WebCore::ReverbConvolver::backgroundThreadEntry):
(WebCore::ReverbConvolver::process):
* platform/audio/ReverbConvolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build
aestes@apple.com [Sun, 19 Jan 2014 06:53:02 +0000 (06:53 +0000)]
[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build

InFilesCompiler.pm assumes that <interface name>.h exists for each
interface it processes. We renamed GestureEvent.h to GestureEventIOS.h
but kept the interface named GestureEvent, so a non-existant file was
being referenced by InFilesCompiler.pm (this was hard to detect since
GestureEvent.h still existed in the SDK due to not having submitted
WebKitAdditions recently).

Since we cannot rename the GestureEvent interface, and since there is
no conflicting GestureEvent in open source, we can just rename
GestureEventIOS.{cpp,h} back to GestureEvent.{cpp,h}.

* dom/ios/TouchEvents.cpp: Updated to include GestureEvent.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd robots.txt to http://webkit-queues.appspot.com
ap@apple.com [Sun, 19 Jan 2014 06:47:12 +0000 (06:47 +0000)]
Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240

* QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd robots.txt to http://webkit-queues.appspot.com
ap@apple.com [Sun, 19 Jan 2014 06:43:19 +0000 (06:43 +0000)]
Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240

Reviewed by Ryosuke Niwa.

* QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.

* QueueStatusServer/robots.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMemory leak in JSSubtleCrypto::wrapKey
ap@apple.com [Sun, 19 Jan 2014 06:39:30 +0000 (06:39 +0000)]
Memory leak in JSSubtleCrypto::wrapKey
https://bugs.webkit.org/show_bug.cgi?id=127241

Reviewed by Sam Weinig.

* bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):
Delete algorithmPtr and parametersPtr that aren't smart pointers because of lambdas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS Production build.
aestes@apple.com [Sun, 19 Jan 2014 05:16:43 +0000 (05:16 +0000)]
Fix the iOS Production build.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed Apple Windows port gardering.
zalan@apple.com [Sun, 19 Jan 2014 02:32:34 +0000 (02:32 +0000)]
Unreviewed Apple Windows port gardering.

Add missing newlines.

* platform/win/css1/box_properties/margin_right-expected.txt:
* platform/win/css1/box_properties/padding-expected.txt:
* platform/win/css1/box_properties/padding_left-expected.txt:
* platform/win/css1/box_properties/padding_right-expected.txt:
* platform/win/css1/box_properties/padding_top-expected.txt:
* platform/win/css1/font_properties/font-expected.txt:
* platform/win/css1/formatting_model/vertical_formatting-expected.txt:
* platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
* platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
* platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
* platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/win/fast/borders/bidi-012-expected.txt:
* platform/win/fast/css/empty-pseudo-class-expected.txt:
* platform/win/fast/css/fieldset-display-row-expected.txt:
* platform/win/fast/css/first-child-pseudo-class-expected.txt:
* platform/win/fast/css/last-child-pseudo-class-expected.txt:
* platform/win/fast/css/only-child-pseudo-class-expected.txt:
* platform/win/fast/forms/file/file-input-disabled-expected.txt:
* platform/win/fast/inline/inline-box-background-expected.txt:
* platform/win/fast/inline/inline-box-background-long-image-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/win/fast/lists/003-vertical-expected.txt:
* platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
* platform/win/svg/batik/filters/feTile-expected.txt:
* platform/win/svg/batik/masking/maskRegions-expected.txt:
* platform/win/svg/batik/paints/gradientLimit-expected.txt:
* platform/win/svg/batik/text/textDecoration-expected.txt:
* platform/win/svg/batik/text/textEffect-expected.txt:
* platform/win/svg/batik/text/textLength-expected.txt:
* platform/win/svg/batik/text/textPosition-expected.txt:
* platform/win/svg/batik/text/verticalText-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
akling@apple.com [Sun, 19 Jan 2014 01:11:56 +0000 (01:11 +0000)]
CodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
<https://webkit.org/b/127239>

Reviewed by Anders Carlsson.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::setNumberOfCallLinkInfos):

    Use resizeToFit() instead of grow() for these vectors, since
    we know the final size here.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):

    No need to shrink here anymore. We were not even shrinking
    m_byValInfo before!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
berto@igalia.com [Sat, 18 Jan 2014 23:59:57 +0000 (23:59 +0000)]
Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
https://bugs.webkit.org/show_bug.cgi?id=127217

Reviewed by Daniel Bates.

The syntax File::Temp->tempdir() was explicitly made invalid
following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
which was included in File::Temp v2.30, shipped with Perl v5.18.0.

Use File::Temp::tempdir() instead.

* Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed Apple Windows port gardering.
zalan@apple.com [Sat, 18 Jan 2014 23:55:43 +0000 (23:55 +0000)]
Unreviewed Apple Windows port gardering.

Rebaseline subpixel layout results.

* platform/win/TestExpectations:
* platform/win/css1/box_properties/margin_right-expected.txt: Added.
* platform/win/css1/box_properties/padding-expected.txt: Added.
* platform/win/css1/box_properties/padding_left-expected.txt: Added.
* platform/win/css1/box_properties/padding_right-expected.txt: Added.
* platform/win/css1/box_properties/padding_top-expected.txt: Added.
* platform/win/css1/font_properties/font-expected.txt:
* platform/win/css1/formatting_model/vertical_formatting-expected.txt: Added.
* platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
* platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
* platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
* platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
* platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
* platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/win/fast/borders/bidi-012-expected.txt:
* platform/win/fast/css/empty-pseudo-class-expected.txt: Added.
* platform/win/fast/css/fieldset-display-row-expected.txt: Added.
* platform/win/fast/css/first-child-pseudo-class-expected.txt: Added.
* platform/win/fast/css/last-child-pseudo-class-expected.txt: Added.
* platform/win/fast/css/only-child-pseudo-class-expected.txt: Added.
* platform/win/fast/forms/file/file-input-disabled-expected.txt:
* platform/win/fast/forms/range/slider-mouse-events-expected.txt:
* platform/win/fast/inline/inline-box-background-expected.txt:
* platform/win/fast/inline/inline-box-background-long-image-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/win/fast/lists/003-vertical-expected.txt:
* platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
* platform/win/svg/batik/filters/feTile-expected.txt: Added.
* platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
* platform/win/svg/batik/paints/gradientLimit-expected.txt:
* platform/win/svg/batik/text/textDecoration-expected.txt: Added.
* platform/win/svg/batik/text/textEffect-expected.txt: Added.
* platform/win/svg/batik/text/textLength-expected.txt: Added.
* platform/win/svg/batik/text/textPosition-expected.txt: Added.
* platform/win/svg/batik/text/verticalText-expected.txt: Added.
* platform/win/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCodeBlock: Size m_function{Exprs,Decls} to fit from creation.
akling@apple.com [Sat, 18 Jan 2014 23:35:34 +0000 (23:35 +0000)]
CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<https://webkit.org/b/127238>

Reviewed by Anders Carlsson.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

    Use resizeToFit() instead of grow() for m_functionExprs and
    m_functionDecls since we know they will never change size.

(JSC::CodeBlock::shrinkToFit):

    No need to shrink them here anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CodeGeneratorJS] Sort output of StructureFlags and function parameters
berto@igalia.com [Sat, 18 Jan 2014 23:31:06 +0000 (23:31 +0000)]
[CodeGeneratorJS] Sort output of StructureFlags and function parameters

https://bugs.webkit.org/show_bug.cgi?id=127226

Reviewed by Alexey Proskuryakov.

The order of the keys in a hash is undefined and subject to change
between different Perl versions, so we have to sort them to make
sure that the output is always the same.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateParametersCheckExpression):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
* bindings/scripts/test/JS/JSTestEventConstructor.h:
* bindings/scripts/test/JS/JSTestEventTarget.h:
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
* bindings/scripts/test/JS/JSTestNode.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestTypedefs.h:
* bindings/scripts/test/JS/JSattribute.h:
* bindings/scripts/test/JS/JSreadonly.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused CodeBlock::m_additionalIdentifiers member.
akling@apple.com [Sat, 18 Jan 2014 23:20:12 +0000 (23:20 +0000)]
Remove unused CodeBlock::m_additionalIdentifiers member.
<https://webkit.org/b/127237>

Reviewed by Anders Carlsson.

* bytecode/CodeBlock.h:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

    Remove m_additionalIdentifiers, nothing uses it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove two unused CodeBlock functions.
akling@apple.com [Sat, 18 Jan 2014 23:10:29 +0000 (23:10 +0000)]
Remove two unused CodeBlock functions.
<https://webkit.org/b/127235>

Kill copyPostParseDataFrom() and copyPostParseDataFromAlternative()
since they are not used.

Reviewed by Anders Carlsson.

* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCodeBlock: Size m_exceptionHandlers to fit from creation.
akling@apple.com [Sat, 18 Jan 2014 23:09:48 +0000 (23:09 +0000)]
CodeBlock: Size m_exceptionHandlers to fit from creation.
<https://webkit.org/b/127234>

Avoid allocation churn for CodeBlock::m_exceptionHandlers.

Reviewed by Anders Carlsson.

* bytecode/CodeBlock.h:

    Removed unused CodeBlock::allocateHandlers() function.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

    Use resizeToFit() instead of grow() for m_exceptionHandlers
    since we know it's never going to change size.

(JSC::CodeBlock::shrinkToFit):

    No need to shrink m_exceptionHandlers here since it's already
    the perfect size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReplace a couple of uses of WTF::Function with std::function
andersca@apple.com [Sat, 18 Jan 2014 23:00:21 +0000 (23:00 +0000)]
Replace a couple of uses of WTF::Function with std::function
https://bugs.webkit.org/show_bug.cgi?id=127218

Reviewed by Andreas Kling.

Source/WebCore:

* WebCore.exp.in:
* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
* page/scrolling/ScrollingThread.h:
* page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::initializeRunLoop):

Source/WebKit2:

* Platform/IPC/mac/ConnectionMac.cpp:
(IPC::createDataAvailableSource):
* Platform/WorkQueue.h:
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
* Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModernize HTML parser code
andersca@apple.com [Sat, 18 Jan 2014 22:48:46 +0000 (22:48 +0000)]
Modernize HTML parser code
https://bugs.webkit.org/show_bug.cgi?id=127236

Reviewed by Andreas Kling.

* html/parser/AtomicHTMLToken.h:
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):
* html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
* html/parser/HTMLMetaCharsetParser.h:
* html/parser/HTMLParserScheduler.h:
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
* html/parser/HTMLPreloadScanner.h:
* html/parser/HTMLResourcePreloader.cpp:
(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore::HTMLResourcePreloader::preload):
* html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::PreloadRequest):
* html/parser/HTMLScriptRunner.h:
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::releaseDoctypeData):
* html/parser/HTMLTokenizer.h:
* html/parser/HTMLTreeBuilder.h:
* html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
* html/parser/HTMLViewSourceParser.h:
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
* html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::XSSInfo):
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):
* loader/TextResourceDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake ElementData JIT friendly
benjamin@webkit.org [Sat, 18 Jan 2014 22:17:09 +0000 (22:17 +0000)]
Make ElementData JIT friendly
https://bugs.webkit.org/show_bug.cgi?id=127209

Reviewed by Geoffrey Garen.

The offsets of ElementData's flags were not accessible by the JIT. This patch
refactor ElementData to use explicit flags so that they can be used from
the code generators.

* dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttribute):
* dom/ElementData.cpp:
(WebCore::ElementData::destroy):
(WebCore::ElementData::ElementData):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::ElementData::arraySizeAndFlagsFromOther):
* dom/ElementData.h:
(WebCore::ElementData::hasName):
(WebCore::ElementData::isUnique):
(WebCore::ElementData::updateFlag):
(WebCore::ElementData::arraySize):
(WebCore::ElementData::setHasNameAttribute):
(WebCore::ElementData::styleAttributeIsDirty):
(WebCore::ElementData::setStyleAttributeIsDirty):
(WebCore::ElementData::presentationAttributeStyleIsDirty):
(WebCore::ElementData::setPresentationAttributeStyleIsDirty):
(WebCore::ElementData::animatedSVGAttributesAreDirty):
(WebCore::ElementData::setAnimatedSVGAttributesAreDirty):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):
* dom/StyledElement.cpp:
(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):
* svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):
* svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
zalan@apple.com [Sat, 18 Jan 2014 21:24:25 +0000 (21:24 +0000)]
Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
https://bugs.webkit.org/show_bug.cgi?id=126899

Reviewed by Tim Horton.

Use LayoutUnits when setting the infinite values on IntRect::infiniteRect() to ensure
it won't overflow later when the IntRect gets converted to LayoutRect.

Source/WebCore:

Covered by existing tests.

* platform/graphics/IntRect.h:
(WebCore::IntRect::infiniteRect):

LayoutTests:

* platform/mac/TestExpectations: Unskipping svg test (failed with subpixel on)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove support for the viewsource attribute
andersca@apple.com [Sat, 18 Jan 2014 21:15:19 +0000 (21:15 +0000)]
Remove support for the viewsource attribute
https://bugs.webkit.org/show_bug.cgi?id=127232

Reviewed by Andreas Kling.

Source/WebCore:

The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.

This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.

* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):

Source/WTF:

* wtf/FeatureDefines.h:

LayoutTests:

* .gitattributes:
* fast/frames/resources/viewsource-fake-image-file.png: Removed.
* fast/frames/resources/viewsource-frame-1.html: Removed.
* fast/frames/resources/viewsource-frame-2.html: Removed.
* fast/frames/resources/viewsource-frame-3.html: Removed.
* fast/frames/resources/viewsource-frame-4.html: Removed.
* fast/frames/resources/viewsource-frame-5.html: Removed.
* fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
* fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
* fast/frames/viewsource-attribute.html: Removed.
* fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
* fast/frames/viewsource-empty-attribute-value.html: Removed.
* fast/frames/viewsource-linebreak-expected.txt: Removed.
* fast/frames/viewsource-linebreak.html: Removed.
* fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
* fast/frames/viewsource-link-on-href-value.html: Removed.
* fast/frames/viewsource-on-image-file.html: Removed.
* fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
* fast/frames/viewsource-plain-text-tags.html: Removed.
* fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
* fast/frames/viewsource-unfinished-tags.html: Removed.
* fast/frames/viewsource-xml-expected.txt: Removed.
* fast/frames/viewsource-xml.html: Removed.
* http/tests/security/resources/view-source-no-refresh.php: Removed.
* http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
* http/tests/security/view-source-javascript-url-in-document.html: Removed.
* http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
* http/tests/security/view-source-no-javascript-url.html: Removed.
* http/tests/security/view-source-no-refresh-expected.txt: Removed.
* http/tests/security/view-source-no-refresh.html: Removed.
* platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
* platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
* platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
* platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
* platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
* platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
* platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
* platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFlesh out session APIs (still not enabled at API level).
commit-queue@webkit.org [Sat, 18 Jan 2014 21:14:42 +0000 (21:14 +0000)]
Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <mhock@apple.com> on 2014-01-18
Reviewed by Alexey Proskuryakov.

* CMakeLists.txt:
* GNUmakefile.list.am:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
* Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
(WebKit::SessionTracker::isEphemeralID):
* Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
* UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):
* UIProcess/APISession.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a hasBreakpointFlag arg to the op_debug bytecode.
mark.lam@apple.com [Sat, 18 Jan 2014 21:11:56 +0000 (21:11 +0000)]
Add a hasBreakpointFlag arg to the op_debug bytecode.
https://bugs.webkit.org/show_bug.cgi?id=127230.

Reviewed by Geoffrey Garen.

This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.

* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoXMLTreeViewer shouldn't use the view source mode
andersca@apple.com [Sat, 18 Jan 2014 20:35:07 +0000 (20:35 +0000)]
XMLTreeViewer shouldn't use the view source mode
https://bugs.webkit.org/show_bug.cgi?id=127229

Reviewed by Andreas Kling.

Add the relevant styles from view-source.css to XMLViewer.css.

* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLViewer.css:
(body):
(.comment):
(.tag):
(.attribute-name):
(.attribute-value):
* xml/XMLViewer.js:
(createComment):
(createTag):
(createAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix attempt for Windows and EFL WebKit1.
bburg@apple.com [Sat, 18 Jan 2014 20:32:14 +0000 (20:32 +0000)]
Another build fix attempt for Windows and EFL WebKit1.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint_contents):
* ewk/ewk_view.cpp:
(_ewk_view_smart_repaints_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix attempt for Windows.
bburg@apple.com [Sat, 18 Jan 2014 20:19:06 +0000 (20:19 +0000)]
Unreviewed build fix attempt for Windows.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
berto@igalia.com [Sat, 18 Jan 2014 19:41:58 +0000 (19:41 +0000)]
JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=99683

Reviewed by Anders Carlsson.

* jit/ThunkGenerators.cpp:
* tools/CodeProfile.cpp:
(JSC::symbolName):
(JSC::CodeProfile::sample):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused "touchDragDropEnabled" setting.
akling@apple.com [Sat, 18 Jan 2014 19:16:41 +0000 (19:16 +0000)]
Remove unused "touchDragDropEnabled" setting.
<https://webkit.org/b/127227>

Reviewed by Sam Weinig.

* page/Settings.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Page should use std::unique_ptr for InspectorController
bburg@apple.com [Sat, 18 Jan 2014 19:15:33 +0000 (19:15 +0000)]
Web Inspector: Page should use std::unique_ptr for InspectorController
https://bugs.webkit.org/show_bug.cgi?id=127068

Reviewed by Joseph Pecoraro.

Source/WebCore:

Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
and WorkerInspectorController. Store page references and return controller
references where possible.

Convert call sites to use an InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
Convert InspectorOverlay to keep Page references.

* WebCore.exp.in:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
* dom/Node.cpp:
(WebCore::Node::inspect):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::developerExtrasEnabled):
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::reset):
* inspector/InspectorOverlay.h:
* inspector/InstrumentingAgents.cpp:
(WebCore::instrumentationForPage): remove null checks.
(WebCore::instrumentationForWorkerGlobalScope): remove null checks.
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
* inspector/WorkerInspectorController.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
* page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(WebCore::Page::inspectorController):
* page/PageDebuggable.cpp:
(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::parentProcessIdentifier):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::syncDisplayState):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
(WebCore::Internals::setInspectorResourcesDataSizeLimits):
(WebCore::Internals::setJavaScriptProfilingEnabled):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
* workers/WorkerGlobalScope.h: remove clearInspector().
(WebCore::WorkerGlobalScope::workerInspectorController):
* workers/WorkerMessagingProxy.cpp:
(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):

Source/WebKit/efl:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::openInspectorFrontend):
* ewk/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):

Source/WebKit/gtk:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend):
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
(webkit_web_inspector_show):
(webkit_web_inspector_inspect_node):
(webkit_web_inspector_inspect_coordinates):
(webkit_web_inspector_close):
(webkit_web_inspector_execute_script):

Source/WebKit/mac:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(-[WebInspectorWindowController destroyInspectorView:]):
* WebInspector/WebInspector.mm:
(-[WebInspector showWindow]):
(-[WebInspector isJavaScriptProfilingEnabled]):
(-[WebInspector setJavaScriptProfilingEnabled:]):
(-[WebInspector close:]):
(-[WebInspector evaluateInFrontend:callId:script:]):
* WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):

Source/WebKit/win:

Convert call sites to use a InspectorController reference.

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::onClose):
* WebInspector.cpp:
(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):

Source/WebKit2:

Convert call sites to use a InspectorController reference.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebKit::WebInspectorFrontendClient::closeWindow):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobuild.webkit.org/dashboard should have image diff links in test results popovers
ap@apple.com [Sat, 18 Jan 2014 18:57:59 +0000 (18:57 +0000)]
build.webkit.org/dashboard should have image diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=127188

Reviewed by Timothy Hatcher.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestImagesURLForIteration):
(Buildbot.prototype.layoutTestImageDiffURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomedia/video-size.html is flaky
ap@apple.com [Sat, 18 Jan 2014 18:50:42 +0000 (18:50 +0000)]
media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932

* platform/efl/TestExpectations:
* platform/TestExpectations:
Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomedia/video-display-aspect-ratio.html fails
ap@apple.com [Sat, 18 Jan 2014 18:43:42 +0000 (18:43 +0000)]
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=35297

* platform/mac/TestExpectations: Marking as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove ENABLE_THREADED_HTML_PARSER defines everywhere
andersca@apple.com [Sat, 18 Jan 2014 18:42:28 +0000 (18:42 +0000)]
Remove ENABLE_THREADED_HTML_PARSER defines everywhere
https://bugs.webkit.org/show_bug.cgi?id=127225

Reviewed by Andreas Kling.

This concludes the removal of over 8.8 million lines of threaded parser code.

.:

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake WKRenderingProgressEvents a shareable API.
commit-queue@webkit.org [Sat, 18 Jan 2014 18:30:29 +0000 (18:30 +0000)]
Make WKRenderingProgressEvents a shareable API.
https://bugs.webkit.org/show_bug.cgi?id=127213

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-18
Reviewed by Dan Bernstein.

Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
could also use this enum when listening to layout milestones.

* Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.
(NS_OPTIONS):
* Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.
(renderingProgressEvents):
* UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
* UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add
    webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didLayout):
(setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the remaining threaded parser code
andersca@apple.com [Sat, 18 Jan 2014 18:25:30 +0000 (18:25 +0000)]
Remove the remaining threaded parser code
https://bugs.webkit.org/show_bug.cgi?id=127224

Reviewed by Andreas Kling.

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* html/parser/AtomicHTMLToken.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::textPosition):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLParserIdioms.cpp:
* html/parser/HTMLParserIdioms.h:
* html/parser/HTMLTokenizer.cpp:
* html/parser/HTMLTokenizer.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):
* page/Settings.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove threaded parser code from the preload scanners
andersca@apple.com [Sat, 18 Jan 2014 18:06:03 +0000 (18:06 +0000)]
Remove threaded parser code from the preload scanners
https://bugs.webkit.org/show_bug.cgi?id=127222

Reviewed by Andreas Kling.

* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
Use nullptr.

(WebCore::CSSPreloadScanner::scan):
Move scanCommon here and simplify the code.

* html/parser/CSSPreloadScanner.h:
Remove scanCommon.

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::initiatorFor):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::match):
Indent this.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::StartTagScanner::charset):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
Ditto.

(WebCore::TokenPreloadScanner::scan):
Merge scan and scanCommon.

* html/parser/HTMLPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
mark.lam@apple.com [Sat, 18 Jan 2014 17:55:07 +0000 (17:55 +0000)]
Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
https://bugs.webkit.org/show_bug.cgi?id=127127.

Reviewed by Geoffrey Garen.

In order to implement bytecode level breakpoints, we need a mechanism
for computing the best fit op_debug bytecode offset for any valid given
line and column value in the source. The "best fit" op_debug bytecode
in this case is defined below in the comment for
UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().

* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):
- Convert the line and column to unlinked line and column values and
  pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()
  to do the real work.

* bytecode/CodeBlock.h:
* bytecode/LineColumnInfo.h: Added.
(JSC::LineColumnInfo::operator <):
(JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
(JSC::LineColumnInfo::operator ==):
(JSC::LineColumnInfo::operator !=):
(JSC::LineColumnInfo::operator <=):
(JSC::LineColumnInfo::operator >):
(JSC::LineColumnInfo::operator >=):
* bytecode/LineInfo.h: Removed.

* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):
- Factored this out of expressionRangeForBytecodeOffset() so that it can
  be called from multiple places.
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):
- Some dumpers for debugging use only.
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):
- Finds the earliest op_debug bytecode whose line and column matches the
  specified line and column values. If an exact match is not found, then
  finds the nearest op_debug bytecode that precedes the specified line
  and column values. If there are more than one op_debug at that preceding
  line and column value, then the earliest of those op_debug bytecodes will
  be be selected. The offset of the selected bytecode will be returned.

  We want the earliest one because when we have multiple op_debug bytecodes
  that map to a given line and column, a debugger user would expect to break
  on the first one and step through the rest thereafter if needed.

(JSC::compareLineColumnInfo):
(JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):
- Creates the sorted opDebugLineColumnInfoList on demand. This list is
  stored in the UnlinkedCodeBlock's rareData.
* bytecode/UnlinkedCodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove Nix files from WebCore
akling@apple.com [Sat, 18 Jan 2014 17:19:38 +0000 (17:19 +0000)]
Remove Nix files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=127176

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2014-01-18
Reviewed by Anders Carlsson.

.:

* Source/cmake/OptionsNix.cmake: Removed.

Source/WebCore:

* PlatformNix.cmake: Removed.
* css/mediaControlsNix.css: Removed.
* css/mediaControlsNixFullscreen.css: Removed.
* editing/nix/EditorNix.cpp: Removed.
* page/nix/EventHandlerNix.cpp: Removed.
* platform/audio/nix/AudioBusNix.cpp: Removed.
* platform/audio/nix/AudioDestinationNix.cpp: Removed.
* platform/audio/nix/AudioDestinationNix.h: Removed.
* platform/audio/nix/FFTFrameNix.cpp: Removed.
* platform/graphics/nix/IconNix.cpp: Removed.
* platform/graphics/nix/ImageNix.cpp: Removed.
* platform/nix/CursorNix.cpp: Removed.
* platform/nix/DragDataNix.cpp: Removed.
* platform/nix/DragImageNix.cpp: Removed.
* platform/nix/ErrorsNix.cpp: Removed.
* platform/nix/ErrorsNix.h: Removed.
* platform/nix/FileSystemNix.cpp: Removed.
* platform/nix/GamepadsNix.cpp: Removed.
* platform/nix/LanguageNix.cpp: Removed.
* platform/nix/LocalizedStringsNix.cpp: Removed.
* platform/nix/MIMETypeRegistryNix.cpp: Removed.
* platform/nix/NixKeyboardUtilities.cpp: Removed.
* platform/nix/NixKeyboardUtilities.h: Removed.
* platform/nix/PasteboardNix.cpp: Removed.
* platform/nix/PlatformKeyboardEventNix.cpp: Removed.
* platform/nix/PlatformScreenNix.cpp: Removed.
* platform/nix/RenderThemeNix.cpp: Removed.
* platform/nix/RenderThemeNix.h: Removed.
* platform/nix/ScrollbarThemeNix.cpp: Removed.
* platform/nix/ScrollbarThemeNix.h: Removed.
* platform/nix/SharedTimerNix.cpp: Removed.
* platform/nix/SoundNix.cpp: Removed.
* platform/nix/TemporaryLinkStubs.cpp: Removed.
* platform/nix/WidgetNix.cpp: Removed.
* platform/nix/support/MultiChannelPCMData.cpp: Removed.
* platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove DocumentParser::pinToMainThread() and related code
andersca@apple.com [Sat, 18 Jan 2014 17:11:46 +0000 (17:11 +0000)]
Remove DocumentParser::pinToMainThread() and related code
https://bugs.webkit.org/show_bug.cgi?id=127221

Reviewed by Andreas Kling.

* dom/Document.cpp:
(WebCore::Document::setContent):
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
* html/parser/HTMLParserOptions.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove HTMLParserThread
andersca@apple.com [Sat, 18 Jan 2014 17:00:14 +0000 (17:00 +0000)]
Remove HTMLParserThread
https://bugs.webkit.org/show_bug.cgi?id=127220

Reviewed by Andreas Kling.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLParserThread.cpp: Removed.
* html/parser/HTMLParserThread.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGC soon after responding to fake memory pressure.
akling@apple.com [Sat, 18 Jan 2014 16:50:13 +0000 (16:50 +0000)]
GC soon after responding to fake memory pressure.
<https://webkit.org/b/127210>

Ask JSC to garbage collect "soon" after handling the fake memory
pressure signal on Mac. This seems to stabilize the post-pressure
numbers on Membuster3 a bit on my laptop. The difference is mostly
made up of JSC::CodeBlock objects.

Reviewed by Geoffrey Garen.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove files only used by the threaded HTML parser
andersca@apple.com [Sat, 18 Jan 2014 16:48:59 +0000 (16:48 +0000)]
Remove files only used by the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=127219
<rdar://problem/13331277>

Reviewed by Andreas Kling.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/AtomicHTMLToken.h:
* html/parser/BackgroundHTMLInputStream.cpp: Removed.
* html/parser/BackgroundHTMLInputStream.h: Removed.
* html/parser/BackgroundHTMLParser.cpp: Removed.
* html/parser/BackgroundHTMLParser.h: Removed.
* html/parser/CompactHTMLToken.cpp: Removed.
* html/parser/CompactHTMLToken.h: Removed.
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLIdentifier.cpp: Removed.
* html/parser/HTMLIdentifier.h: Removed.
* html/parser/HTMLParserIdioms.h:
* html/parser/HTMLPreloadScanner.h:
* html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
* html/parser/HTMLTreeBuilderSimulator.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInspector scripts are not compatible with Python v3
zandobersek@gmail.com [Sat, 18 Jan 2014 09:04:36 +0000 (09:04 +0000)]
Inspector scripts are not compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=127128

Reviewed by Benjamin Poulain.

* inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
* inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for
Python v2) or, on import error, import the class from the io module (which will work for Python v3).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Bump the minimum required Clang version to 3.3
zandobersek@gmail.com [Sat, 18 Jan 2014 08:22:23 +0000 (08:22 +0000)]
[GTK] Bump the minimum required Clang version to 3.3
https://bugs.webkit.org/show_bug.cgi?id=127178

Reviewed by Martin Robinson.

* Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to
build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r162237 and r162241.
commit-queue@webkit.org [Sat, 18 Jan 2014 06:27:51 +0000 (06:27 +0000)]
Unreviewed, rolling out r162237 and r162241.
http://trac.webkit.org/changeset/162237
http://trac.webkit.org/changeset/162241
https://bugs.webkit.org/show_bug.cgi?id=127216

Broke lots of API tests (Requested by ap on #webkit).

* CMakeLists.txt:
* GNUmakefile.list.am:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::privateBrowsingStorageSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
(WebKit::privateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
* NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
* Shared/SessionTracker.cpp: Removed.
* Shared/SessionTracker.h: Removed.
* UIProcess/APISession.cpp:
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
* UIProcess/APISession.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::privateSession):
(WebKit::identifierBase):
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix for the CMake GTK+ build
mrobinson@webkit.org [Sat, 18 Jan 2014 05:33:34 +0000 (05:33 +0000)]
Build fix for the CMake GTK+ build

* PlatformGTK.cmake: We need to include ProgressTrackerClientGtk in the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix on EFL port after r162237
ryuan.choi@samsung.com [Sat, 18 Jan 2014 05:06:32 +0000 (05:06 +0000)]
Unreviewed build fix on EFL port after r162237

The EFL port disabled NETWORK_PROCESS yet and use -Werror=unused-function.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Guarded legacySessionID with ENABLE(NETWORK_PROCESS)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMicro-optimize RenderBoxModelObject::computedCSSPadding().
akling@apple.com [Sat, 18 Jan 2014 02:31:25 +0000 (02:31 +0000)]
Micro-optimize RenderBoxModelObject::computedCSSPadding().
<https://webkit.org/b/127208>

Make computedCSSPadding() take the Length as a const reference
to avoid creating a temporary copy. This was showing up (0.2%)
on DoYouEvenBench.

Reviewed by Anders Carlsson.

* rendering/RenderBoxModelObject.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFlesh out session APIs (still not enabled at API level).
commit-queue@webkit.org [Sat, 18 Jan 2014 02:17:52 +0000 (02:17 +0000)]
Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <mhock@apple.com> on 2014-01-17
Reviewed by Alexey Proskuryakov.

* CMakeLists.txt:
* GNUmakefile.list.am:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
* Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
* Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
(WebKit::SessionTracker::isEphemeralID):
* UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):
* UIProcess/APISession.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobuild.webkit.org/dashboard should have diff links in test results popovers
ap@apple.com [Sat, 18 Jan 2014 02:08:49 +0000 (02:08 +0000)]
build.webkit.org/dashboard should have diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=126986

Reviewed by Tim Horton.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestCrashLogURLForIteration):
(Buildbot.prototype.layoutTestStderrURLForIteration):
(Buildbot.prototype.layoutTestDiffURLForIteration):
(Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a callOnMainThreadAndWait variant in SocketStreamHandle
andersca@apple.com [Sat, 18 Jan 2014 01:58:16 +0000 (01:58 +0000)]
Add a callOnMainThreadAndWait variant in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=127180

Reviewed by Geoffrey Garen.

Source/WebCore:

WTF::callOnMainThreadAndWait was only used inside SocketStreamHandleCFNet.cpp,
so add an improved version there which is implemented in terms of callOnMainThread and
with the bonus of handling spurious wake-ups correctly (the old version didn't).

* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::callOnMainThreadAndWait):
(WebCore::SocketStreamHandle::pacExecutionCallback):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):

Source/WTF:

Remove callOnMainThreadAndWait from WTF.

* wtf/MainThread.cpp:
* wtf/MainThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up PageCache classes
andersca@apple.com [Sat, 18 Jan 2014 01:47:19 +0000 (01:47 +0000)]
Clean up PageCache classes
https://bugs.webkit.org/show_bug.cgi?id=127202

Reviewed by Andreas Kling.

Source/WebCore:

* WebCore.exp.in:
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::setCachedFramePlatformData):
* history/CachedFrame.h:
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
* history/CachedPage.h:
* history/HistoryItem.h:
(WebCore::HistoryItem::isInPageCache):
* history/PageCache.cpp:
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::remove):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
* loader/HistoryController.cpp:
(WebCore::HistoryController::invalidateCurrentItemCachedPage):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebFrameLoaderClient::transitionToCommittedFromCachedFrame):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::savePlatformDataToCachedFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWork around a preprocessor warning in mediaControlsApple.js
aestes@apple.com [Sat, 18 Jan 2014 01:18:04 +0000 (01:18 +0000)]
Work around a preprocessor warning in mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=127204

Reviewed by Dan Bernstein.

* Modules/mediacontrols/mediaControlsApple.js: Changed '' to String().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build after <http://trac.webkit.org/changeset/162184>
dbates@webkit.org [Sat, 18 Jan 2014 00:36:25 +0000 (00:36 +0000)]
Fix the iOS build after <trac.webkit.org/changeset/162184>
(https://bugs.webkit.org/show_bug.cgi?id=126856)

Remove symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(unsigned short const*, int).
Add symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView).

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused TOUCH_ADJUSTMENT code.
akling@apple.com [Sat, 18 Jan 2014 00:34:08 +0000 (00:34 +0000)]
Remove unused TOUCH_ADJUSTMENT code.
<https://webkit.org/b/127181>

Source/WebCore:

There are no ports using the ENABLE(TOUCH_ADJUSTMENT) feature
anymore, so nuke it from orbit.

Reviewed by Anders Carlsson.

* page/EventHandler.cpp:
* page/EventHandler.h:
* page/Settings.in:
* page/TouchAdjustment.cpp: Removed.
* page/TouchAdjustment.h: Removed.
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Reviewed by Anders Carlsson.

* WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNeed a way to test the tile cache with margins enabled
bdakin@apple.com [Sat, 18 Jan 2014 00:05:59 +0000 (00:05 +0000)]
Need a way to test the tile cache with margins enabled
https://bugs.webkit.org/show_bug.cgi?id=127194
-and corresponding-
<rdar://problem/15571327>

Reviewed by Tim Horton.

Source/WebCore:

This patch adds a new function to InternalSettings that will allow layout tests to
flip the setting Settings::setBackgroundShouldExtendBeyondPage(). This patch also
makes changing that setting take effect immediately.

To make this setting dynamic, we can no longer generate the Setting function, so
we have to export the symbol manually.
* WebCore.exp.in:

This new function on FrameView will call into RenderLayerBacking to add or remove
margins.
* page/FrameView.cpp:
(WebCore::FrameView::setBackgroundExtendsBeyondPage):
* page/FrameView.h:

Again, we’re no longer using the boiler-plate generated Setting functions, so now
we can call into FrameView to make the background extend.
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):
* page/Settings.h:
(WebCore::Settings::backgroundShouldExtendBeyondPage):
* page/Settings.in:

Whenever tile margins are set, call setNeedsRevalidateTiles() to make the change
dynamic.
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setTileMargins):

Move the call to TiledBacking::setTileMargins() into a helper function so that the
same code can be used for FrameView.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
* rendering/RenderLayerBacking.h:

New InternalSetting.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setBackgroundShouldExtendBeyondPage):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

Attempt to keep Windows building.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

* platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build.
andersca@apple.com [Fri, 17 Jan 2014 23:49:10 +0000 (23:49 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd the bare minimum support for branches to the bot-watchers dashboard
matthew_hanson@apple.com [Fri, 17 Jan 2014 23:43:29 +0000 (23:43 +0000)]
Add the bare minimum support for branches to the bot-watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=127124

This patch simply introduces the notion of branches into the bot-watchers dashboard.
Subsequent patches will build functionality on top of this simple bit of infrastructure.

Reviewed by Timothy Hatcher.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue): store the branch property in the BuildbotQueue constructor
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
Initialize the Dashboard.Branch object

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove another unused FrameLoaderClient callback
andersca@apple.com [Fri, 17 Jan 2014 23:17:59 +0000 (23:17 +0000)]
Remove another unused FrameLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=127192

Reviewed by Dan Bernstein.

Source/WebCore:

FrameLoaderClient::dispatchDocumentElementAvailable() was only used by the Chromium port, so remove it.

* html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162227 268f45cc-cd09-0410-ab3c-d52691b4dbfc