WebKit-https.git
9 years ago2011-02-08 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 9 Feb 2011 07:16:31 +0000 (07:16 +0000)]
2011-02-08  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        WebKit2 GTK Fails to Build #include nested too deeply
        https://bugs.webkit.org/show_bug.cgi?id=52219

        * GNUmakefile.am: Removed the commands to create the directories
        for the forwarding headers, the script already does it for us.
        * config.h: Removed the config.h inclusion and added the
        autotoolsconfig.h directly, also added a condition to share the
        defines with QT.

2011-02-08  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        WebKit2 GTK Fails to Build #include nested too deeply
        https://bugs.webkit.org/show_bug.cgi?id=52219

        Removed the __STDC_FORMAT_MACROS definition, it is already defined
        in the file where PRIxx64 is used before the inclusion so we are
        safe.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 9 Feb 2011 06:42:36 +0000 (06:42 +0000)]
2011-02-08  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix toolbar anchoring in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54058

        Avoid the anchoring cycle of doom when on the cusp
        of whether the toolbar needs to be anchored and
        speculatively avoid the Firefox crash when resizing.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Feb 2011 06:09:59 +0000 (06:09 +0000)]
2011-02-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed some dead code from Heap
        https://bugs.webkit.org/show_bug.cgi?id=54064

        * runtime/MarkedSpace.cpp: Removed some now-unused constants and
        declarations.

        (JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
        by our caller. Removed redundant typedefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Feb 2011 05:59:03 +0000 (05:59 +0000)]
2011-02-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
        https://bugs.webkit.org/show_bug.cgi?id=54062

        SunSpider reports no change.

        * runtime/CollectorHeapIterator.h:
        (JSC::CollectorHeapIterator::isValid):
        (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To
        know if an object is live, you just need to test its mark bit.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from
        CollectorHeap into MarkedSpace, since they're global state. Removed call
        to memset since CollectorHeap is a true class with its own constructor now.

        (JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
        m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().

        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.

        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::clearMarkBits):
        (JSC::MarkedSpace::markedCells):
        (JSC::MarkedSpace::sweep):
        (JSC::MarkedSpace::objectCount):
        (JSC::MarkedSpace::capacity):
        (JSC::MarkedSpace::reset):
        (JSC::MarkedSpace::primaryHeapEnd):
        * runtime/MarkedSpace.h:
        (JSC::CollectorHeap::CollectorHeap):
        (JSC::MarkedSpace::highWaterMark):
        (JSC::MarkedSpace::setHighWaterMark):
        (JSC::MarkedSpace::contains): Same as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 9 Feb 2011 05:46:36 +0000 (05:46 +0000)]
2011-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        Skip some tests that fail in WebKit2 for obvious reasons
        https://bugs.webkit.org/show_bug.cgi?id=54055

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 9 Feb 2011 05:40:13 +0000 (05:40 +0000)]
2011-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        Crash when going back/forward when back/forward list is in a bad state.
        https://bugs.webkit.org/show_bug.cgi?id=54059
        <rdar://problem/8975244>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::goForward): Add a null check.
        (WebKit::WebPageProxy::goBack): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Wed, 9 Feb 2011 05:33:04 +0000 (05:33 +0000)]
2011-02-08  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        [NRWT] Pull up rebaseline code from compare_output() function defined
        in text_diff.py and image_diff.py into a SingleTestRunner.

        This patch is a first step for eliminating test_type/* classes.

        https://bugs.webkit.org/show_bug.cgi?id=53071

        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Wed, 9 Feb 2011 04:34:11 +0000 (04:34 +0000)]
2011-02-08  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Eric Seidel.

        Added include paths for QtScript.

        WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 9 Feb 2011 04:32:57 +0000 (04:32 +0000)]
2011-02-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        stop generating results.json files
        https://bugs.webkit.org/show_bug.cgi?id=53977

        We've only used incremental_results.json for a while now
        and there are plans to start generating a results.json file that matches
        the format of unexpected_results.json.

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 9 Feb 2011 04:17:36 +0000 (04:17 +0000)]
2011-02-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
        https://bugs.webkit.org/show_bug.cgi?id=53196

        The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
        and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
        before making the modification and not removing non-inheritable properties.

        Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
        by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
        and selectionStartCSSPropertyValue.

        Test: editing/style/query-typing-style.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles.
        (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that
        CSS values from xx-small through -webkit-xxx-large are not accounted.
        * editing/ApplyStyleCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue.
        (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style.
        No longer calls removeNonEditingProperties on the copied typing style so that background-color property
        is included when merged into the style.
2011-02-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
        https://bugs.webkit.org/show_bug.cgi?id=53196

        Added a test to ensure calling queryCommandValue returns the correct value for backColor
        and fontSize from typing style.

        * editing/style/query-typing-style-expected.txt: Added.
        * editing/style/query-typing-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Wed, 9 Feb 2011 03:30:30 +0000 (03:30 +0000)]
2011-02-08  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Kenneth Russell.

        Invalidate rect doesn't work for windowless plugins on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=53117

        Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.

        * plugins/invalidate_rect-expected.txt: Added.
        * plugins/invalidate_rect.html: Added.
2011-02-08  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Kenneth Russell.

        Invalidate rect doesn't work for windowless plugins on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=53117

        Invalidate rect for windowless plugins wasn't working if the web page was composited.

        The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.

        Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.

        Tested my fix on Windows and Mac and verified that the movie on http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::invalidateRect):
2011-02-08  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Kenneth Russell.

        Invalidate rect doesn't work for windowless plugins on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=53117

        Added two new utility methods.
        - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
        - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
        This is used to test that invalidating a rect correctly causes a repaint of the plugin.

        * DumpRenderTree/LayoutTestController.cpp:
        (displayInvalidatedRegionCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (invalidateRect):
        (pluginInvoke):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::displayInvalidatedRegion):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r76831): Subframes are printed blank
weinig@apple.com [Wed, 9 Feb 2011 02:59:19 +0000 (02:59 +0000)]
REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>

Reviewed by Maciej Stachowiak.

* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 9 Feb 2011 02:43:41 +0000 (02:43 +0000)]
2011-02-08  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
        since we now pass the test.

        * platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 9 Feb 2011 02:39:09 +0000 (02:39 +0000)]
2011-02-08  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed chromium-gpu-win rebaseline.

        * platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
        * platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
        * platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
        * platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
        * platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
        * platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
        * platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
        * platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
        * platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
        * platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
        * platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
        * platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
        * platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
        * platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
        * platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
        * platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
        * platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 02:27:13 +0000 (02:27 +0000)]
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 9 Feb 2011 02:14:11 +0000 (02:14 +0000)]
2011-02-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
        https://bugs.webkit.org/show_bug.cgi?id=53975

        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/request-event-propagation-expected.txt:
        * storage/indexeddb/request-event-propagation.html:
        * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
        * storage/indexeddb/transaction-and-objectstore-calls.html:
        * storage/indexeddb/transaction-basics.html:
        * storage/indexeddb/transaction-event-propagation-expected.txt: Added.
        * storage/indexeddb/transaction-event-propagation.html: Added.
2011-02-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
        https://bugs.webkit.org/show_bug.cgi?id=53975

        The third change in the series of overhauling IndexedDB's event model to match
        the spec (at least the version in our heads and bugs).

        Test: storage/indexeddb/transaction-event-propagation.html

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * dom/Event.cpp:
        (WebCore::Event::isIDBAbortEvent):
        (WebCore::Event::isIDBCompleteEvent):
        * dom/Event.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toIDBDatabase):
        * dom/EventTarget.h:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::create):
        (WebCore::IDBDatabase::IDBDatabase):
        (WebCore::IDBDatabase::scriptExecutionContext):
        (WebCore::IDBDatabase::eventTargetData):
        (WebCore::IDBDatabase::ensureEventTargetData):
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::toIDBDatabase):
        (WebCore::IDBDatabase::refEventTarget):
        (WebCore::IDBDatabase::derefEventTarget):
        * storage/IDBDatabase.idl:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::dispatchEvent):
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::backend):
        (WebCore::IDBTransaction::db):
        (WebCore::IDBTransaction::objectStore):
        (WebCore::IDBTransaction::scriptExecutionContext):
        (WebCore::IDBTransaction::dispatchEvent):
        (WebCore::IDBTransaction::enqueueEvent):
        * storage/IDBTransaction.h:
        (WebCore::IDBTransaction::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Feb 2011 02:02:34 +0000 (02:02 +0000)]
2011-02-08  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Add cache for GPU-accelerated path processing results
        https://bugs.webkit.org/show_bug.cgi?id=45519

        Adding a cache which holds the results of processing a path into
        interior and exterior triangle meshes, according to the path
        rendering algorithm from GPU Gems 3. No tests yet; will be tested
        in conjunction with later code.

        * platform/graphics/gpu/LoopBlinnPathCache.cpp: Added.
        (WebCore::LoopBlinnPathCache::LoopBlinnPathCache):
        (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache):
        (WebCore::LoopBlinnPathCache::addVertex):
        (WebCore::LoopBlinnPathCache::clear):
        (WebCore::LoopBlinnPathCache::addInteriorVertex):
        (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices):
        (WebCore::LoopBlinnPathCache::interiorEdgeVertices):
        (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
        * platform/graphics/gpu/LoopBlinnPathCache.h: Added.
        (WebCore::LoopBlinnPathCache::numberOfVertices):
        (WebCore::LoopBlinnPathCache::vertices):
        (WebCore::LoopBlinnPathCache::texcoords):
        (WebCore::LoopBlinnPathCache::numberOfInteriorVertices):
        (WebCore::LoopBlinnPathCache::interiorVertices):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNevermind
beidson@apple.com [Wed, 9 Feb 2011 01:55:37 +0000 (01:55 +0000)]
Nevermind

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago80,000
beidson@apple.com [Wed, 9 Feb 2011 01:54:57 +0000 (01:54 +0000)]
80,000

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 9 Feb 2011 01:46:38 +0000 (01:46 +0000)]
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Rename GraphicsContext3D::WebGLEnumType
        https://bugs.webkit.org/show_bug.cgi?id=45708

        * html/canvas/WebGLProgram.cpp:
        (WebCore::WebGLProgram::getAttachedShader):
        * html/canvas/WebGLProgram.h:
        * platform/graphics/GraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 01:17:02 +0000 (01:17 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: move the logic that starts and stops the
        servers from dump_render_tree_thread into single_test_runner
        so that we can reuse it in the new multiprocessing worker class
        as well.

        https://bugs.webkit.org/show_bug.cgi?id=53840

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
leviw@chromium.org [Wed, 9 Feb 2011 01:04:59 +0000 (01:04 +0000)]
2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77980.
        http://trac.webkit.org/changeset/77980
        https://bugs.webkit.org/show_bug.cgi?id=54043

        "Crashes on Windows and Linux..." (Requested by leviw on
        #webkit).

        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtNode:offset:affinity:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]):
2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77980.
        http://trac.webkit.org/changeset/77980
        https://bugs.webkit.org/show_bug.cgi?id=54043

        "Crashes on Windows and Linux..." (Requested by leviw on
        #webkit).

        * WebCore.exp.in:
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::startOfStyleRange):
        (WebCore::endOfStyleRange):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (objectAndOffsetUnignored):
        * dom/Position.cpp:
        (WebCore::Position::upstream):
        (WebCore::Position::downstream):
        * dom/Range.cpp:
        (WebCore::Range::editingStartPosition):
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::setSelectedRange):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::VisiblePosition):
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::canonicalPosition):
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::localCaretRect):
        (WebCore::makeRange):
        (WebCore::startVisiblePosition):
        (WebCore::endVisiblePosition):
        (WebCore::setStart):
        (WebCore::setEnd):
        (WebCore::isFirstVisiblePositionInNode):
        (WebCore::isLastVisiblePositionInNode):
        * editing/VisiblePosition.h:
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement):
        (WebCore::lastInSpecialElement):
        (WebCore::visiblePositionBeforeNode):
        (WebCore::visiblePositionAfterNode):
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::endPositionForLine):
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        (WebCore::endOfBlock):
        (WebCore::startOfDocument):
        (WebCore::endOfDocument):
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::collapse):
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::setPosition):
        (WebCore::DOMSelection::extend):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::visiblePositionForIndex):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selectSubString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 9 Feb 2011 01:00:42 +0000 (01:00 +0000)]
2011-02-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
        https://bugs.webkit.org/show_bug.cgi?id=54046
        <rdar://problem/8973960>

        DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
        in accelerated compositing mode. Similarly, it can be called with a null layer even when not
        in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise
        just call LayerTreeHost::setRootCompositingLayer.

        (WebKit::DrawingAreaImpl::setSize):
        Add an assert.

        (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
        Assert that we don't have a layer tree host.

        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        Assert that we do have a layer tree host.

        (WebKit::DrawingAreaImpl::display):
        If the call to display caused the page to enter accelerated compositing mode, we don't
        want to send back an Update message.

        * WebProcess/WebPage/LayerTreeHost.cpp:
        (WebKit::LayerTreeHost::create):
        * WebProcess/WebPage/LayerTreeHost.h:
        Create no longer takes a graphics layer.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::create):
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Create no longer takes a graphics layer.

        (WebKit::LayerTreeHostMac::setRootCompositingLayer):
        Set the new root compositing layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 9 Feb 2011 00:55:42 +0000 (00:55 +0000)]
2011-02-08  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        VisibleSelection::setWithoutValidation() should allow caret selection.
        https://bugs.webkit.org/show_bug.cgi?id=53943

        * editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
        * editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.
2011-02-08  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        VisibleSelection::setWithoutValidation() should allow caret selection.
        https://bugs.webkit.org/show_bug.cgi?id=53943

        Test: editing/undo/undo-paste-when-caret-is-not-in-range.html

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::setWithoutValidation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 00:48:35 +0000 (00:48 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: split out thread stack logging code into a sharable module

        This patch splits out the code used to find and log thread
        stacks from NRWT-specific packages to something generic and
        shareable by other python modules. It will be shared in the near
        future by the manager_worker_broker module, for example.

        https://bugs.webkit.org/show_bug.cgi?id=53656

        * Scripts/webkitpy/common/system/stack_utils.py: Added.
        * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 9 Feb 2011 00:45:22 +0000 (00:45 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Remove the last remnants of the Mozilla theme drawing code
        https://bugs.webkit.org/show_bug.cgi?id=54035

        Remove all Mozilla theme drawing code.

        No new tests. This change only removes dead code.

        * GNUmakefile.am: Remove Mozilla files from the source list.
        * platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods
        and add m_colormap to hold the current colormap of the widgets.
        * platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code.
        (WebCore::RenderThemeGtk::platformInit): Ditto.
        (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto.
        (WebCore::RenderThemeGtk::gtkContainer): Ditto.
        * platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
        * platform/gtk/WidgetRenderingContext.cpp: Ditto.
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
        * platform/gtk/WidgetRenderingContext.h: Ditto.
        * platform/gtk/gtk2drawing.c: Removed.
        * platform/gtk/gtkdrawing.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 00:40:37 +0000 (00:40 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: move a bunch of testing logic out of
        dump_render_tree_thread and into single_test_runner so that we
        will be able to reuse it in the new multiprocessing worker class as well.

        https://bugs.webkit.org/show_bug.cgi?id=53838

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 00:37:17 +0000 (00:37 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: remove no longer needed WatchableThread
        class.

        https://bugs.webkit.org/show_bug.cgi?id=53839

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 00:33:31 +0000 (00:33 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add stubs for the Manager objects that
        will abstract the concurrency implementation (inline / threads /
        processes). These classes do nothing yet and are not wired up to
        anything.

        https://bugs.webkit.org/show_bug.cgi?id=53477

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 9 Feb 2011 00:31:32 +0000 (00:31 +0000)]
2011-02-08  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add simplified message broker for new-style
        messaging. This change adds a very simple message broker that
        will be used to shuttle messages between the TestRunner2 manager
        thread and the Worker threads. For now the class is not used by
        anything, but the eventual usage can be seen in the patches
        attached to bug 49566.

        https://bugs.webkit.org/show_bug.cgi?id=53158

        * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 9 Feb 2011 00:25:53 +0000 (00:25 +0000)]
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        * fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-crash.html: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
        * fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        Frame flattening algorithm requires that layout always starts from the main frame, since layout of
        subframes impacts the layout of their parents.
        There are places in the code that call view->layout() not on the main frame.
        Instead of changing all the callsites, I changed FrameView::layout()
        to force layout from the main frame if frame flattening is enabled.
        In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
        Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
        because calling the from layout() leads to a crash in pages that have a selection in an iframe.

        Tests: fast/frames/flattening/iframe-flattening-crash.html
               fast/frames/flattening/iframe-flattening-selection-crash.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Feb 2011 00:25:09 +0000 (00:25 +0000)]
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        chromium-win builder shouldn't run python or perl tests
        https://bugs.webkit.org/show_bug.cgi?id=54032

        These tests don't pass on this builder because the builder isn't
        running in cygwin.  There isn't really any point in running them and
        making the bot red forever.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Radar URLs to a recent ChangeLog entry.
aestes@apple.com [Wed, 9 Feb 2011 00:07:50 +0000 (00:07 +0000)]
Add Radar URLs to a recent ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Andy Estes <aestes@apple.com>
aestes@apple.com [Tue, 8 Feb 2011 23:59:30 +0000 (23:59 +0000)]
2011-02-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
        https://bugs.webkit.org/show_bug.cgi?id=54041

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setContentEditable): Setting the contentEditable
        attribute to 'plaintext-only' should not throw an exception.
2011-02-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
        https://bugs.webkit.org/show_bug.cgi?id=54041

        * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
        * fast/dom/HTMLElement/set-value-caseinsensitive.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderRubyRun::m_beingDestroyed is redundant
mitz@apple.com [Tue, 8 Feb 2011 23:51:39 +0000 (23:51 +0000)]
RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042

Reviewed by Simon Fraser.

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().
* rendering/RenderRubyRun.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WorkQueue::scheduleWorkAfterDelay on Windows
aroben@apple.com [Tue, 8 Feb 2011 23:34:03 +0000 (23:34 +0000)]
Implement WorkQueue::scheduleWorkAfterDelay on Windows

Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.

Fixes <http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away

Reviewed by Anders Carlsson.

* Platform/WorkQueue.h: Added timerCallback and m_timerQueue.

* Platform/win/WorkQueueWin.cpp:
(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 23:15:47 +0000 (23:15 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Unskip a series of tests that seem to be passing locally. Also unskip
        a test that was mistakenly reskipped in r77979 due to what looks like a
        merge issue. Rebaseline two of these test which have results originating
        from long ago.

        * platform/gtk/Skipped: Unskip some tests.
        * platform/gtk/editing/selection/14971-expected.txt:
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 23:14:32 +0000 (23:14 +0000)]
2011-02-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Rename PluginProcess::initializeConnection to PluginProcess::initialize
        https://bugs.webkit.org/show_bug.cgi?id=54039

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::initialize):
        * PluginProcess/PluginProcess.h:
        * PluginProcess/mac/PluginProcessMainMac.mm:
        (WebKit::PluginProcessMain):
        * WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 8 Feb 2011 23:13:22 +0000 (23:13 +0000)]
2011-02-08  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Stop instantiating legacy editing Positions in VisiblePosition
        https://bugs.webkit.org/show_bug.cgi?id=52919

        Changing usage of legacy VisiblePosition constructor. Since we were dealing
        with positions from DOM Ranges, we're guaranteed a parent-anchored position.

        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtPosition:affinity:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]):
2011-02-08  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Stop instantiating legacy editing Positions in VisiblePosition
        https://bugs.webkit.org/show_bug.cgi?id=52919

        Changing VisiblePosition completely away from legacy positions.

        No new tests since this is functionaly equivalent.

        * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
        adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
        outside of WebCore, they should be parent anchored.
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::startOfStyleRange):
        (WebCore::endOfStyleRange):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (objectAndOffsetUnignored):
        * dom/Position.cpp:
        (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
        (WebCore::Position::downstream): ditto
        * dom/Range.cpp:
        (WebCore::Range::editingStartPosition):
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::setSelectedRange):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::canonicalPosition):
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::localCaretRect):
        (WebCore::makeRange):
        (WebCore::startVisiblePosition):
        (WebCore::endVisiblePosition):
        (WebCore::setStart):
        (WebCore::setEnd):
        (WebCore::isFirstVisiblePositionInNode):
        (WebCore::isLastVisiblePositionInNode):
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::VisiblePosition):
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement):
        (WebCore::lastInSpecialElement):
        (WebCore::visiblePositionBeforeNode):
        (WebCore::visiblePositionAfterNode):
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::endPositionForLine):
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        (WebCore::endOfBlock):
        (WebCore::startOfDocument):
        (WebCore::endOfDocument):
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::collapse):
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::setPosition):
        (WebCore::DOMSelection::extend):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::visiblePositionForIndex):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selectSubString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 8 Feb 2011 23:09:49 +0000 (23:09 +0000)]
2011-02-08  Michael Saboff  <msaboff@apple.com>

        JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
        https://bugs.webkit.org/show_bug.cgi?id=53716

        Changed ASSERT to be an if for the case where the RuntimeObject was
        GC'ed before RootObject::invalidate is called.  In that case there is
        no need to remove the RuntimeObject from the RootObject.  The isValid()
        call will be false in this case, but the RuntimeObject has already
        been removed from the RootObject.  Added similar defensive code
        in RootObject::removeRuntimeObject().

        * bridge/jsc/BridgeJSC.cpp:
        (JSC::Bindings::Instance::willDestroyRuntimeObject):
        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::removeRuntimeObject):
2011-02-08  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
        https://bugs.webkit.org/show_bug.cgi?id=53716

        Re-enabled tests that are fixed with the corresponding change in
        WebCore.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
beidson@apple.com [Tue, 8 Feb 2011 23:07:28 +0000 (23:07 +0000)]
<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed

Reviewed by Darin Adler.

Source/WebKit2:

Update the implementation of this API to include the new item (if any) and removed items (if any):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
* UIProcess/WebPageProxy.h:

Have WebBackForwardList pass the new items and/or removed items when calling the notifier:
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):

Tools:

* MiniBrowser/mac/BrowserWindowController.m:
(didChangeBackForwardList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 8 Feb 2011 23:03:12 +0000 (23:03 +0000)]
2011-02-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Give each MarkedBlock enough mark bits to cover the whole block
        https://bugs.webkit.org/show_bug.cgi?id=54029

        SunSpider reports no change.

        This simplifies access to mark bits, since any cell-aligned pointer
        into a block now has a valid mark bit to test.

        * runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra
        mark bits. This happens not to change its actual value.
        (JSC::MarkedBlock::cellNumber):
        (JSC::MarkedBlock::isMarked):
        (JSC::MarkedBlock::testAndSetMarked):
        (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to
        remove a cast from our caller, and to more accurately reflect the fact
        that MarkedBlock is agnostic about the types pointed to by the pointers
        you pass to it.

        (JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
        the null pointer to be a possible cell with a 0 (impossible) block. This
        removes a null check from marking.

        * runtime/MarkedSpace.cpp:
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::contains): Simplified the contains check, and inlined
        the whole thing, now that it's so simple.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSandbox violations visiting MobileMe.
weinig@apple.com [Tue, 8 Feb 2011 23:02:26 +0000 (23:02 +0000)]
Sandbox violations visiting MobileMe.
<rdar://problem/8961330>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 22:52:23 +0000 (22:52 +0000)]
2011-02-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
        https://bugs.webkit.org/show_bug.cgi?id=54037

        Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
        match the WebProcess initialization code, in preparation of sharing more code.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::initializePluginProcess):
        * PluginProcess/PluginProcess.h:
        * PluginProcess/PluginProcess.messages.in:
        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::didFinishLaunching):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWK2: Add ability to pass context to policy delegate methods
weinig@apple.com [Tue, 8 Feb 2011 22:48:31 +0000 (22:48 +0000)]
WK2: Add ability to pass context to policy delegate methods
https://bugs.webkit.org/show_bug.cgi?id=54031

Reviewed by Anders Carlsson.

Source/WebKit2:

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):
* Scripts/webkit2/messages.py:
Add ability to pass variadic messages to sync messages.

* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
Add WKBundleNavigation type.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
* UIProcess/WebPolicyClient.h:
Update policy client for new data.

* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.
(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):
* WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPolicyClient):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.
(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
* WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.
(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.

Tools:

* MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 8 Feb 2011 22:33:39 +0000 (22:33 +0000)]
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline for chromium-mac after r77952.
        Not sure why the previous rebase did not get the right results.
        https://bugs.webkit.org/show_bug.cgi?id=54026

        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 8 Feb 2011 22:31:34 +0000 (22:31 +0000)]
2011-02-08  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Martin Robinson.

        Rename enum ProtectionSeting [sic] to ProtectionSetting.

        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::reprotectRegion):
        * jit/ExecutableAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 22:25:36 +0000 (22:25 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
        https://bugs.webkit.org/show_bug.cgi?id=54033

        * platform/gtk/Skipped: Unskip a test that is now passing.
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
        https://bugs.webkit.org/show_bug.cgi?id=54033

        Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
        This is a likely candidate for a new API point.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * webkit/webkitglobals.cpp:
        (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead
        of initializing the database manually.
        (WebKit::setIconDatabaseEnabled): Added.
        * webkit/webkitglobalsprivate.h: Added declarations.
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
        https://bugs.webkit.org/show_bug.cgi?id=54033

        Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
        call DumpRenderTreeSupportGtk. Turn off the icon database between tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): Turn off the icon database.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
        method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8953365> CrashTracer: 14
bdakin@apple.com [Tue, 8 Feb 2011 22:11:34 +0000 (22:11 +0000)]
Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258

Reviewed by Darin Adler.

This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.

Remove scrollbarPainterDelegate() since it's not used anymore.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:

Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 22:00:16 +0000 (22:00 +0000)]
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Unreviewed, typo fix.

        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 21:51:38 +0000 (21:51 +0000)]
2011-02-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Crash calling -setFrame:andScrollBy: in windowDidResize
        https://bugs.webkit.org/show_bug.cgi?id=54030
        <rdar://problem/8969760>

        * Platform/mac/SharedMemoryMac.cpp:
        (WebKit::SharedMemory::create):
        Assert that size is not zero here; we never want to try to create shared memory with a zero size.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        Always invalidate the entire visible page when resizing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 21:09:53 +0000 (21:09 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Unskip some inspector tests that are passing locally. The bugs are
        missing test diffs, so we can either reskip them and get more information
        or have passing tests. Classify another failure.

        * platform/gtk/Skipped: Clean up the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 21:06:58 +0000 (21:06 +0000)]
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Kenji Imasaki <imasaki@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 20:54:03 +0000 (20:54 +0000)]
2011-02-08  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by Jian Li.

        [Chromium] Remove non-Flaky media tests from test expectation file
        https://bugs.webkit.org/show_bug.cgi?id=54021

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 8 Feb 2011 20:19:55 +0000 (20:19 +0000)]
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Unreviewed. Fix typo in rebaseline in r77961.

        * platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Feb 2011 20:17:08 +0000 (20:17 +0000)]
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        This code appears to be unused.

        * html/HTMLParserErrorCodes.cpp:
        * html/HTMLParserErrorCodes.h:
        * html/HTMLParserQuirks.h:
        * loader/EmptyClients.h:
        * page/ChromeClient.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * src/ChromeClientImpl.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/ChromeClientEfl.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/ChromeClientGtk.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/ChromeClientHaiku.cpp:
        * WebCoreSupport/ChromeClientHaiku.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/WebChromeClient.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/ChromeClientQt.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/WebChromeClient.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebCoreSupport/ChromeClientWinCE.cpp:
        * WebCoreSupport/ChromeClientWinCE.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebKitSupport/ChromeClientWx.h:
2011-02-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove orphan code from old parser
        https://bugs.webkit.org/show_bug.cgi?id=53984

        * WebProcess/WebCoreSupport/WebChromeClient.cpp
        * WebProcess/WebCoreSupport/WebChromeClient.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 19:36:01 +0000 (19:36 +0000)]
2011-02-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        UI process crashes if web process crashes while web inspector is focused
        https://bugs.webkit.org/show_bug.cgi?id=53965
        <rdar://problem/8961633>

        Make sure to close the web inspector web page proxy before calling platformClose, since
        platformClose can cause the web page proxy to try to send messages (such as SetActive)
        to the web process while it's in a bad state.

        The original fix, http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
        WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
        is in WebInspectorProxy::invalidate.

        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 8 Feb 2011 19:25:45 +0000 (19:25 +0000)]
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline after r77952.

        * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
        * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
        * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
        * platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
        * platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
        * platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
        * platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
        * platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 19:15:32 +0000 (19:15 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Move scrollbar rendering out of gtk2drawing.c
        https://bugs.webkit.org/show_bug.cgi?id=52836

        Replace gtk2drawing.c scrollbar rendering with our own version. This
        is the last use of the Mozilla theme drawing code.

        No new tests. This should not change the rendering of the default
        theme.

        * platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
        * platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
        * platform/gtk/RenderThemeGtk2.cpp:  Initialize and add getters for scrollbar widgets.
        (WebCore::RenderThemeGtk::platformInit): Ditto.
        (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto.
        (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
        * platform/gtk/ScrollbarThemeGtk.cpp:
        (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled
        window background if we are repainting a button or the thumb. In that
        case also repaint the track rect.
        * platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext.
        (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
        (WebCore::getWidgetForScrollbar): Ditto.
        (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto.
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
        (WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
        (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
        * platform/gtk/WidgetRenderingContext.cpp: Ditto.
        (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which
        also adjusts a widget allocation according to the paint rect. This is
        necessary to properly draw scrollbar buttons.
        * platform/gtk/WidgetRenderingContext.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo < zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 19:12:38 +0000 (19:12 +0000)]
2011-02-08 Zhenyao Mo < zmo@google.com>

     Unreviewed, test expectations update.

     * LauoutTests/platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 8 Feb 2011 18:57:00 +0000 (18:57 +0000)]
2011-02-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Inset shadow with large offset renders incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=53882

        Fix an issue with inset shadows, when the shadow offset
        was larger than the box size. In this case we'd fail to
        fill the box with the shadow color.

        Test: fast/box-shadow/inset-shadow-large-offset.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::areaCastingShadowInHole): Return a rect that covers the area
        which contributes to the inset shadow.

        (WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
        to compute the outerRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 8 Feb 2011 18:56:14 +0000 (18:56 +0000)]
2011-02-08  Tony Chang  <tony@chromium.org>

        Unreviewed, build fix for clobber builds of DRT on mac/linux.

        This file moved in chromium r73530 and this path wasn't changed.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 18:47:42 +0000 (18:47 +0000)]
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
        https://bugs.webkit.org/show_bug.cgi?id=54017

        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html:
2011-02-08  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
        https://bugs.webkit.org/show_bug.cgi?id=54017

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::drawElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 8 Feb 2011 18:37:15 +0000 (18:37 +0000)]
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Unreviewed. after r77952,
        skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
        set it as expect to fail in chromium.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 8 Feb 2011 18:35:22 +0000 (18:35 +0000)]
2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
        https://bugs.webkit.org/show_bug.cgi?id=53190

        This is the second part of refactoring the HTMLMediaElement to use new
        shadow DOM. The changes are mainly mechanical, except for needing to
        add a new method to RenderTheme, which indicates whether or not status
        display is being used by it. Previously, we relied on existence of a cached
        pseudo style.

        Refactoring, covered by existing tests.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId): Removed now-unused enum values.
        (WebCore::nameToPseudoTypeMap): Ditto.
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h: Ditto.
        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement.
        (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
            MediaControlCurrentTimeDisplayElement.
        (WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
                MediaControlTimeRemainingDisplayElement.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
            standard style resolution.
        (WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
        (WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
            that is no longer necessary.
        (WebCore::MediaControlElement::styleForElement): Changed to use the standard
            style resolution.
        (WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
        (WebCore::MediaControlPanelElement::create): Added.
        (WebCore::MediaControlPanelElement::displayType): Added.
        (WebCore::MediaControlPanelElement::shadowPseudoId): Added.
        (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
            Removed PseudoId constructor arg.
        (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
            Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
        (WebCore::MediaControlTimelineContainerElement::displayType): Added.
        (WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
        (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
            Removed PseudoId constructor arg.
        (WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
        (WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
        (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
            Removed PseudoId constructor arg.
        (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
            use the newly-plumbed usesMediaControlStatusDisplay helper.
        (WebCore::MediaControlStatusDisplayElement::displayType): Added.
        (WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
        (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
            Removed PseudoId constructor arg.
        (WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
        (WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
        (WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
        (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
        (WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
        (WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
        (WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
        (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
        * rendering/MediaControlElements.h: Added/changed defs accordingly.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
        * rendering/RenderThemeMac.h: Added def.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
        * rendering/style/RenderStyleConstants.h: Removed now-unused enum values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layou...
hyatt@apple.com [Tue, 8 Feb 2011 18:32:54 +0000 (18:32 +0000)]
<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed

Reviewed by Adam Roben.

Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken.  Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.

* WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
* WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 8 Feb 2011 18:22:15 +0000 (18:22 +0000)]
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix pop-up button text not rendered correctly according to its direction
        in <option>.
        https://bugs.webkit.org/show_bug.cgi?id=53642

        In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
        changes, set it needs layout.

        * fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
        * platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
        * platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
        * platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
2011-02-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix pop-up button text not rendered correctly according to its direction
        in <option>.
        https://bugs.webkit.org/show_bug.cgi?id=53642

        In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
        changes, set it needs layout.

        Test: fast/text/international/pop-up-button-text-alignment-and-direction.html

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::adjustInnerStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 8 Feb 2011 18:01:00 +0000 (18:01 +0000)]
2011-02-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for Qt-minimal.

        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::hasFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 8 Feb 2011 17:32:44 +0000 (17:32 +0000)]
2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

        https://bugs.webkit.org/show_bug.cgi?id=53169

        All the Inspector API for WebCore has two parts.
        The first one is InspectorInstrumentation for WebCore.
        The second is InspectorController for WebKit.
        InspectorAgent was produced by renaming original InspectorController.
        This patch extracts WebKit related methods from InspectorAgent to InspectorController.

        * WebCore.exp.in:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createParser):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::~InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::inspect):
        (WebCore::InspectorAgent::handleMousePress):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::resourceAgent):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::pushDataCollectedOffline):
        (WebCore::InspectorAgent::restoreProfiler):
        (WebCore::InspectorAgent::startTimelineProfiler):
        (WebCore::PostWorkerNotificationToFrontendTask::performTask):
        (WebCore::InspectorAgent::didOpenDatabase):
        (WebCore::InspectorAgent::didUseDOMStorage):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::enableDebugger):
        (WebCore::InspectorAgent::enabled):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::frontend):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::setInspectorFrontendClient):
        (WebCore::InspectorController::hasInspectorFrontendClient):
        (WebCore::InspectorController::didClearWindowObjectInWorld):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::disconnectFrontendImpl):
        (WebCore::InspectorController::show):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::evaluateForTestInFrontend):
        (WebCore::InspectorController::drawNodeHighlight):
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::enabled):
        (WebCore::InspectorController::showPanel):
        (WebCore::InspectorController::frontendLoaded):
        (WebCore::InspectorController::timelineProfilerEnabled):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::profilerEnabled):
        (WebCore::InspectorController::debuggerEnabled):
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        (WebCore::InspectorController::isRecordingUserInitiatedProfile):
        (WebCore::InspectorController::setInspectorExtensionAPI):
        (WebCore::InspectorController::resume):
        (WebCore::InspectorController::hideHighlight):
        (WebCore::InspectorController::dispatchMessageFromFrontend):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorClient):
        (WebCore::InspectorController::inspectedPage):
        (WebCore::InspectorController::hasFrontend):
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::setExtensionAPI):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::hasFrontend):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

        https://bugs.webkit.org/show_bug.cgi?id=53169

        Minor change enforced by major changes in WebCore/inspector/InspectorController.

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
        * src/WebViewImpl.h:

2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

        https://bugs.webkit.org/show_bug.cgi?id=53169

        Minor change enforced by major changes in WebCore/inspector/InspectorController.

        * WebCoreSupport/InspectorClientGtk.cpp:
        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_get_property):

2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

        https://bugs.webkit.org/show_bug.cgi?id=53169

        Minor change enforced by major changes in WebCore/inspector/InspectorController.

        * WebInspector/WebInspector.mm:
        (-[WebInspector isTimelineProfilingEnabled]):

2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

        https://bugs.webkit.org/show_bug.cgi?id=53169

        Minor change enforced by major changes in WebCore/inspector/InspectorController.

        * WebInspector.cpp:
        (WebInspector::isTimelineProfilingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 17:30:05 +0000 (17:30 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
        https://bugs.webkit.org/show_bug.cgi?id=53995

        Ensure to wait for the body to be loaded before running the test.

        * editing/selection/end-of-document.html: Call runEditingTest() on
        the body.onload event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 8 Feb 2011 17:27:54 +0000 (17:27 +0000)]
2011-02-08  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Should not always define USE_SYSTEM_MALLOC
        https://bugs.webkit.org/show_bug.cgi?id=54007

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Kundu Suchismita <suchi.kundu@nokia.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 17:21:44 +0000 (17:21 +0000)]
2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>

        Reviewed by Laszlo Gombos.

        Local Storage settings can be enable/disable from "Develop" menu
        https://bugs.webkit.org/show_bug.cgi?id=52296

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):
        (LauncherWindow::toggleLocalStorage):
        (LauncherWindow::toggleOfflineStorageDatabase):
        (LauncherWindow::toggleOfflineWebApplicationCache):
        (LauncherWindow::setOfflineStorageDefaultQuota):
        * QtTestBrowser/launcherwindow.h:
        (WindowOptions::WindowOptions):
        * QtTestBrowser/main.cpp:
        (LauncherApplication::handleUserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 George Wright <gwright@rim.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 17:16:52 +0000 (17:16 +0000)]
2011-02-08  George Wright  <gwright@rim.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=53949

        Ensure that we pack the colour byte order correctly for Skia using
        Skia's SkPackARGB32 function.

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageFrame::setRGBA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 George Wright <gwright@rim.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 17:05:50 +0000 (17:05 +0000)]
2011-02-08  George Wright  <gwright@rim.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=53951

        Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
        pass the full image dimensions.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 16:50:15 +0000 (16:50 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add missing includes and forward declarations for DownloadBundle
        https://bugs.webkit.org/show_bug.cgi?id=53881

        * platform/network/cf/DownloadBundle.h:
        * platform/network/win/DownloadBundleWin.cpp:
        (WebCore::DownloadBundle::appendResumeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 16:47:12 +0000 (16:47 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add missing include in WKCAImageQueue
        https://bugs.webkit.org/show_bug.cgi?id=53890

        * platform/graphics/win/WKCAImageQueue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after...
jberlin@webkit.org [Tue, 8 Feb 2011 16:28:16 +0000 (16:28 +0000)]
ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
https://bugs.webkit.org/show_bug.cgi?id=54005

Reviewed by Adam Roben.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 16:17:42 +0000 (16:17 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add missing forward declarations in WebKitSystemInterface.h
        https://bugs.webkit.org/show_bug.cgi?id=53889

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 16:08:56 +0000 (16:08 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Unskip a bunch of tests that are passing locally and move one
        timeout with the other timeouts.

        * platform/gtk/Skipped: Unskip some passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle WM_TIMER messages for stopped timers
aroben@apple.com [Tue, 8 Feb 2011 16:03:00 +0000 (16:03 +0000)]
Handle WM_TIMER messages for stopped timers

Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.

Fixes <http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired

Reviewed by Darin Adler.

* Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't mark a Connection as connected until open() is called on Windows
aroben@apple.com [Tue, 8 Feb 2011 16:01:13 +0000 (16:01 +0000)]
Don't mark a Connection as connected until open() is called on Windows

This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.

Fixes <http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows

Reviewed by Darin Adler.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 15:58:54 +0000 (15:58 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add missing includes and forward declarations for CFNetwork
        https://bugs.webkit.org/show_bug.cgi?id=53883

        * platform/network/cf/DNSCFNet.cpp:
        * platform/network/cf/LoaderRunLoopCF.cpp:
        * platform/network/cf/LoaderRunLoopCF.h:
        * platform/network/cf/ProxyServerCFNet.cpp:
        * platform/network/cf/SocketStreamHandle.h:
        * platform/network/cf/SocketStreamHandleCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 15:57:22 +0000 (15:57 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] EventSender.keyDown does not support non-array modifier arguments
        https://bugs.webkit.org/show_bug.cgi?id=53962

        * platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] EventSender.keyDown does not support non-array modifier arguments
        https://bugs.webkit.org/show_bug.cgi?id=53962

        Support handling either an array or a string for the modifier argument
        to EventSender.keyDown.

        * DumpRenderTree/gtk/EventSender.cpp:
        (gdkModifierFromJSValue): Added this helper which factors out the
        string comparison bits.
        (gdkModifersFromJSValue): Test up front whether the value is a string,
        to handle it specially.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 15:51:53 +0000 (15:51 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77870.

        * platform/DragImage.cpp: Compile createDragImageForLink on WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 15:48:58 +0000 (15:48 +0000)]
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Removing inspector tests from Skipped on [win].
        Resource tracking has been removed since then, maybe it'll help.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 15:46:55 +0000 (15:46 +0000)]
2011-02-08  Martin Robinson  <mrobinson@igalia.com>

        Clean up the skipped list slightly and unskip a test which should now be passing.

        * platform/gtk/Skipped: Clean up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 15:40:54 +0000 (15:40 +0000)]
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: open network resource url in new tab upon double click.
        https://bugs.webkit.org/show_bug.cgi?id=53930

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype.createCells):
        (WebInspector.NetworkDataGridNode.prototype._openInNewTab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 15:34:06 +0000 (15:34 +0000)]
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: $x: any node should work in optional context parameter.
        https://bugs.webkit.org/show_bug.cgi?id=50138

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 15:30:04 +0000 (15:30 +0000)]
2011-02-08  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77870.

        Remove the global namespace prefix from GlobalLock/GlobalUnlock.

        * platform/win/ClipboardUtilitiesWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 15:27:43 +0000 (15:27 +0000)]
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: re-apply r77924.

        Test: inspector/console-api-on-call-frame.html

        * inspector/InjectedScriptSource.js:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 8 Feb 2011 15:08:05 +0000 (15:08 +0000)]
2011-02-08  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        REGRESSION(r77312): Unbreak TiledBackingStore.

        Due to an off-by-one error, we were no longer rendering the
        rightmost column and bottom row of tiles.

        Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().

        * platform/graphics/TiledBackingStore.cpp:
        (WebCore::TiledBackingStore::invalidate):
        (WebCore::TiledBackingStore::updateTileBuffers):
        (WebCore::TiledBackingStore::paint):
        (WebCore::TiledBackingStore::createTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 14:26:47 +0000 (14:26 +0000)]
2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77924.
        http://trac.webkit.org/changeset/77924
        https://bugs.webkit.org/show_bug.cgi?id=53997

        Breaks inspector tests. (Requested by pfeldman on #webkit).

        * inspector/console-api-on-call-frame-expected.txt: Removed.
        * inspector/console-api-on-call-frame.html: Removed.
2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77924.
        http://trac.webkit.org/changeset/77924
        https://bugs.webkit.org/show_bug.cgi?id=53997

        Breaks inspector tests. (Requested by pfeldman on #webkit).

        * inspector/InjectedScriptSource.js:
        (.):
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Benjamin Poulain <ikipou@gmail.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 14:04:23 +0000 (14:04 +0000)]
2011-02-08  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Csaba Osztrogonác.

        openDatabaseSync() stop responding after too many call
        https://bugs.webkit.org/show_bug.cgi?id=53945

        Reset the database quota to a known state between each test.

        Define a quota for the known origins at each test run and delete
        all the databases.
        This way, the database related test do not depend on previous
        allocations.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        (WebCore::DumpRenderTree::dumpDatabaseQuota):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 8 Feb 2011 13:42:10 +0000 (13:42 +0000)]
2011-02-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
        https://bugs.webkit.org/show_bug.cgi?id=53789
         - perform UserAgent override via InspectorInstrumentation
         - move adding extra request headers to InspectorResourceAgent
         - simplified things in InspectorState

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::applyUserAgentOverride):
        * inspector/InspectorAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
        (WebCore::InspectorInstrumentation::willSendRequestImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::applyUserAgentOverride):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::setExtraHeaders):
        (WebCore::InspectorResourceAgent::willSendRequest):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        (WebCore::InspectorState::restoreFromInspectorCookie):
        (WebCore::InspectorState::updateCookie):
        (WebCore::InspectorState::setValue):
        (WebCore::InspectorState::getBoolean):
        (WebCore::InspectorState::getString):
        (WebCore::InspectorState::getLong):
        (WebCore::InspectorState::getObject):
        * inspector/InspectorState.h:
        (WebCore::InspectorState::setObject):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::userAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 13:29:18 +0000 (13:29 +0000)]
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not hide scope variables with command line api.
        https://bugs.webkit.org/show_bug.cgi?id=53497

        * inspector/console-api-on-call-frame-expected.txt: Added.
        * inspector/console-api-on-call-frame.html: Added.
2011-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not hide scope variables with command line api.
        https://bugs.webkit.org/show_bug.cgi?id=53497

        Test: inspector/console-api-on-call-frame.html

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 8 Feb 2011 13:03:00 +0000 (13:03 +0000)]
2011-02-08  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed build fix.

        [EFL] Fix when building with curl backend.

        * ewk/ewk_settings.cpp:
        (ewk_settings_proxy_uri_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 12:57:37 +0000 (12:57 +0000)]
2011-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
        https://bugs.webkit.org/show_bug.cgi?id=53914

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.reloadPage):
        * inspector/audits-panel-functional.html:
2011-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
        https://bugs.webkit.org/show_bug.cgi?id=53914

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::reloadPage):
        * inspector/InspectorAgent.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 12:45:32 +0000 (12:45 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test timing out on GTK 32-bit debug bot.

        fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
        https://bugs.webkit.org/show_bug.cgi?id=53992

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 11:26:39 +0000 (11:26 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK debug bots.

        fast/frames/sandboxed-iframe-storage.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53991

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip over sibling selectors when collecting descendant selector hashes
antti@apple.com [Tue, 8 Feb 2011 10:52:13 +0000 (10:52 +0000)]
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987

Reviewed by Cameron Zwarich.

Skip instead of bailing out. This will allow optimizing some sibling selector cases.

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77919 268f45cc-cd09-0410-ab3c-d52691b4dbfc