WebKit-https.git
9 years ago2010-04-20 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 21 Apr 2010 05:25:14 +0000 (05:25 +0000)]
2010-04-20  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed test skipping for Chromium Win.

        Skip editing/pasteboard/copy-backslash-with-euc.html for Chromium Win.
        https://bugs.webkit.org/show_bug.cgi?id=36419

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 21 Apr 2010 04:55:14 +0000 (04:55 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37776
        <rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes

        * platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping
        for Roman letters and punctuation.

        * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation
        of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak)
        also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult
        to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes
        to their keycodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a ChangeLog entry.
hamaji@chromium.org [Wed, 21 Apr 2010 04:11:37 +0000 (04:11 +0000)]
Fix a ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 21 Apr 2010 04:09:52 +0000 (04:09 +0000)]
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        Add editing/pasteboard/copy-backslash-with-euc into Gtk's skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 21 Apr 2010 03:54:47 +0000 (03:54 +0000)]
2010-04-20  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=37748

        Make Sheriffbot more inspirational.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 21 Apr 2010 03:31:42 +0000 (03:31 +0000)]
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Import Chromium image_diff as ImageDiff
        https://bugs.webkit.org/show_bug.cgi?id=37790

        ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/chromium/ImageDiff.cpp: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 01:13:49 +0000 (01:13 +0000)]
2010-04-20  Xan Lopez  <xlopez@igalia.com>

        Another attempt to fix the build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't paint the web page before we've blit the last update chunk to the backing store.
andersca@apple.com [Wed, 21 Apr 2010 01:13:23 +0000 (01:13 +0000)]
Don't paint the web page before we've blit the last update chunk to the backing store.

Reviewed by Sam Weinig.

* UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didReceiveMessage):
* UIProcess/win/DrawingAreaProxy.h:
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didUpdate):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 00:54:20 +0000 (00:54 +0000)]
2010-04-20  Xan Lopez  <xlopez@igalia.com>

        Build fix?

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix license on create_regex_tables
oliver@apple.com [Wed, 21 Apr 2010 00:50:54 +0000 (00:50 +0000)]
Fix license on create_regex_tables

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix gtk
oliver@apple.com [Wed, 21 Apr 2010 00:47:46 +0000 (00:47 +0000)]
Fix gtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Wed, 21 Apr 2010 00:09:00 +0000 (00:09 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::receivedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 20 Apr 2010 23:51:45 +0000 (23:51 +0000)]
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Alexey Proskuryakov.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        * editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
        * editing/execCommand/transpose-backslash-with-euc.html: Added.
        * editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
        * editing/pasteboard/copy-backslash-with-euc.html: Added.
        * editing/pasteboard/resources/copy-backslash-euc.html: Added.
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Alexey Proskuryakov.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        Tests: editing/execCommand/transpose-backslash-with-euc.html
               editing/pasteboard/copy-backslash-with-euc.html

        * editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls.
        (WebCore::Editor::addToKillRing):
        * editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version
        (WebCore::TextIterator::TextIterator):
        (WebCore::TextIterator::init):
        (WebCore::TextIterator::emitText):
        (WebCore::plainTextToMallocAllocatedBuffer):
        * editing/TextIterator.h:
        (WebCore::):
        * platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call.
        (WebCore::Pasteboard::writeSelection):
        * platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
        * rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::updateNeedsTranscoding):
        (WebCore::RenderText::styleDidChange):
        (WebCore::isInlineFlowOrEmptyText):
        (WebCore::RenderText::previousCharacter):
        (WebCore::RenderText::setTextInternal):
        (WebCore::RenderText::textWithoutTranscoding):
        (WebCore::RenderText::transformText):
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call.
        (WebCore::RenderTextControl::setInnerTextValue):
        (WebCore::RenderTextControl::finishText):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::previousCharacter):
        * rendering/RenderTextFragment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 20 Apr 2010 23:42:52 +0000 (23:42 +0000)]
2010-04-20  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating Chromium test_expectations for media/video-zoom.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 23:27:07 +0000 (23:27 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Update chromium expectations.  Also consolidate identical
        platform expectations for fast/dom/prototype-inheritance.html.

        * platform/chromium-linux/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix gtk
oliver@apple.com [Tue, 20 Apr 2010 23:22:57 +0000 (23:22 +0000)]
Fix gtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 23:18:52 +0000 (23:18 +0000)]
2010-04-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=37367

        Fix style violations in code generated by CodeGeneratorV8.pm.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/test/V8TestObj.cpp:
        * bindings/v8/test/V8TestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r57924.
ossy@webkit.org [Tue, 20 Apr 2010 22:57:31 +0000 (22:57 +0000)]
Unreviewed, rolling out r57924.
http://trac.webkit.org/changeset/57924
https://bugs.webkit.org/show_bug.cgi?id=37898

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-20
It broke 3-4 test on all bot (Requested by Ossy on #webkit).

WebCore:

* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::media):
* page/DOMWindow.h:
* page/DOMWindow.idl:

LayoutTests:

* fast/media/lifetime.html:
* fast/media/matchmedium-query-api.html:
* fast/media/print-restores-previous-mediatype-expected.txt:
* fast/media/print-restores-previous-mediatype.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 22:43:51 +0000 (22:43 +0000)]
2010-04-20  Dirk Pranke <dpranke@chromium.org>

        This patch to new-run-webkit-tests adds a --log 'trace' option
        that prints out detailed info about a given test as it executes
        (where the baselines are, what the expectation is, what we got,
        how long it took).

        https://bugs.webkit.org/show_bug.cgi?id=37726

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
          - use the newly exposed TestResult class and implement
            --log trace
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
          - rename TestStats to TestResult and make it more public, resulting
            in cleaner code
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
          - add expectation_to_string() as a separate callable function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Apr 2010 22:38:43 +0000 (22:38 +0000)]
2010-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't paint the web page before we've blit the last update chunk to the backing store
        https://bugs.webkit.org/show_bug.cgi?id=37896

        * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
        (DrawingAreaMessage::):
        * UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
        * UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
        (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
        (WebKit::DrawingAreaProxyUpdateChunk::update):
        (WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
        * WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
        (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
        (WebKit::DrawingAreaUpdateChunk::display):
        (WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
        (WebKit::DrawingAreaUpdateChunk::setSize):
        (WebKit::DrawingAreaUpdateChunk::didUpdate):
        (WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
        * WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
barraclough@apple.com [Tue, 20 Apr 2010 22:34:52 +0000 (22:34 +0000)]
JavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl

Reviewed by Oliver Hunt.

The implementation of StringImpl & UStringImpl is very similar.  Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RopeImpl.h:
(JSC::RopeImpl::RopeImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):
* wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.
(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):

JavaScriptGlue: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

* ForwardingHeaders/wtf/text/StringImplBase.h: Added.

WebCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

* ForwardingHeaders/wtf/text/StringImplBase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 20 Apr 2010 22:26:44 +0000 (22:26 +0000)]
2010-04-20  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix fro Chromium.

        * loader/DocumentWriter.cpp:

2010-04-20  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.

        * Api/qwebframe.cpp:
        (QWebFrame::setUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 20 Apr 2010 22:24:12 +0000 (22:24 +0000)]
2010-04-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.

        https://bugs.webkit.org/show_bug.cgi?id=37820

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptLine):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleDoubleClick):
        (WebInspector.TextViewer.prototype._cancelEditingLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 22:24:00 +0000 (22:24 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Test fix, no review.

        Disable compositing/iframes/composited-iframe.html because compositing is
        turned off at runtime on Leopard (based on QuickTime version), so we can't
        rely on the result.

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 22:19:02 +0000 (22:19 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Reviewed by dglazkov.

        Update chromium SVG baselines for r57886
        https://bugs.webkit.org/show_bug.cgi?id=37891

        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/filters/filterRegions-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textEffect-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textEffect3-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textProperties-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/non-opaque-filters-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/visibility-override-filter-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/big-sized-filter-2-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feMerge-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feOffset-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/filter-on-tspan-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/custom/empty-merge-expected.txt: Removed.
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.txt: Removed.
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
        * platform/chromium-win/svg/custom/text-filter-expected.txt:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.txt: Removed.
        * platform/chromium-win/svg/filters/big-sized-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
        * platform/chromium-win/svg/filters/feComposite-expected.txt:
        * platform/chromium-win/svg/filters/feDisplacementMap-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feMerge-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feMerge-wrong-input-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feOffset-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feTile-expected.txt: Removed.
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.txt: Removed.
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 20 Apr 2010 22:12:16 +0000 (22:12 +0000)]
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        This patch separates the begin/write/end cycle of decoding network
        bytes and putting them into a document from the rest of the loading
        machinery.  The code and state required to write bytes into a document
        doesn't interact very much with the rest of the loading machinery.

        No tests because there is no behavior change (hopefully!).

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::close):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::scriptCharset):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestPreload):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/DocumentWriter.cpp: Added.
        * loader/DocumentWriter.h: Added.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::setURL):
        (WebCore::FrameLoader::didBeginDocument):
        (WebCore::FrameLoader::didEndDocument):
        (WebCore::FrameLoader::willSetEncoding):
        (WebCore::FrameLoader::addData):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::writer):
        (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::createDocumentStructure):
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::dataEncoding):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::finishedLoading):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::commitDocumentData):
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebSearchableFormData.cpp:
        (WebCore::GetFormEncoding):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::pageEncoding):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::committedLoad):
        (WebKit::FrameLoaderClient::finishedLoading):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_encoding):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]):
        (-[WebFrame _receivedData:textEncodingName:]):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::finishedLoading):
        (WebCore::FrameLoaderClientQt::setMainDocumentError):
        (WebCore::FrameLoaderClientQt::committedLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::receivedData):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Tue, 20 Apr 2010 22:09:58 +0000 (22:09 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::chooseIconForFiles):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 20 Apr 2010 22:05:43 +0000 (22:05 +0000)]
2010-04-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Autogenerate yarr character tables
        https://bugs.webkit.org/show_bug.cgi?id=37877

        Use a python script to automatically generate character tables
        for the builtin YARR character classes.  This allows us to generate
        actual tables as well, by using these tables we can both increase
        performance of the check (for complex builtins) and reduce the actual
        code size.

        4-8% win on string-unpack-code, but lots of noise on other tests so
        i'm only confident saying its a 1% win overall.

        * DerivedSources.make:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::branchTest8):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::branchTest8):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::branchTest8):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::cmpb_im):
        (JSC::X86Assembler::testb_im):
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::dump):
        * create_regex_tables: Added.
        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::CharacterClassConstructor::charClass):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::matchCharacterClass):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
        * yarr/RegexPattern.h:
        (JSC::Yarr::CharacterClassTable::create):
        (JSC::Yarr::CharacterClassTable::CharacterClassTable):
        (JSC::Yarr::CharacterClass::CharacterClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename window.media to window.styleMedia
kenneth@webkit.org [Tue, 20 Apr 2010 22:04:59 +0000 (22:04 +0000)]
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Simon Fraser.

WebCore:

It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.

* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
* page/DOMWindow.idl:

LayoutTests:

Update layout tests.

* fast/media/lifetime.html:
* fast/media/matchmedium-query-api.html:
* fast/media/print-restores-previous-mediatype.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix matching of "file:///*" patterns by not trying to compare the host. The host is
timothy@apple.com [Tue, 20 Apr 2010 21:50:32 +0000 (21:50 +0000)]
Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.

Also fix comparisons to be case insensitive.

https://bugs.webkit.org/show_bug.cgi?id=37889

Reviewed by Dave Hyatt.

* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Justin Schuh <jschuh@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 21:42:20 +0000 (21:42 +0000)]
2010-04-20  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
        https://bugs.webkit.org/show_bug.cgi?id=37331

        Added a setting to enable/disable media per-page and have the SVGImage
        disable media for its dummy page. Also found and fixed a related bad
        cast in the V8 bindings (JSC had a custom wrapper for this already).

        Tests: media/svg-as-image-with-media-blocked.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut...
tonikitoo@webkit.org [Tue, 20 Apr 2010 21:32:24 +0000 (21:32 +0000)]
Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
https://bugs.webkit.org/show_bug.cgi?id=37802

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.

No behavior change, it is just a safe assignment shortcut.

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 20 Apr 2010 21:29:54 +0000 (21:29 +0000)]
2010-04-20  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57907.
        http://trac.webkit.org/changeset/57907
        https://bugs.webkit.org/show_bug.cgi?id=37765

        Appears to have broken MacEWS and possibly webkit-patch upload
        for svn users.  Needs further investigation.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/commitinfo.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:
        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/common/prettypatch.py:
        * Scripts/webkitpy/common/system/autoinstall.py:
        * Scripts/webkitpy/common/system/deprecated_logging.py:
        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:
        * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
        * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 21:24:10 +0000 (21:24 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Hook compositing layers together across iframes
        https://bugs.webkit.org/show_bug.cgi?id=37878

        First step: if an iframe's document goes into compositing mode, also throw the parent
        document into compositing mode (all the way up to the root). This is required both
        to preserve layering (since parent document content can obscure iframe content),
        and so that we can eventually hook the layer trees together.

        Test: compositing/iframes/composited-iframe.html

        * rendering/RenderIFrame.h:
        * rendering/RenderIFrame.cpp:
        (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have
        a RenderLayer, so must return |true| from requiresLayer().
        (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document
        is in compositing mode.
        (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check
        if a renderer is an iframe.
        (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when
        the compositing mode changes, so that the parent document can update its compositing status.
        (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame().
        (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe
        wants to be composited.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderIFrame): Base class returns false.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify
        its parent document that a recalcStyle is required, to update compositing state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 21:17:32 +0000 (21:17 +0000)]
2010-04-20  Nate Chapin  <japhet@chromium.org>

        Unreviewed.

        Update my irc handle in committers.py (natechapin -> japhet).

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* wtf/text/AtomicString.h:
barraclough@apple.com [Tue, 20 Apr 2010 21:13:16 +0000 (21:13 +0000)]
* wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix - missed a bit!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoworker-close.html is flaky on slow machines.
dimich@chromium.org [Tue, 20 Apr 2010 21:12:33 +0000 (21:12 +0000)]
worker-close.html is flaky on slow machines.
https://bugs.webkit.org/show_bug.cgi?id=37887

Reviewed by Adam Barth.

* fast/workers/worker-close.html: Move the start of the timer to terminate the test after an expected message is received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 21:03:43 +0000 (21:03 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Another round of chromium test expectation SVG updates.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* wtf/text/AtomicString.h:
barraclough@apple.com [Tue, 20 Apr 2010 20:58:03 +0000 (20:58 +0000)]
* wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 20:41:03 +0000 (20:41 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        backgroundColor is oddly indented in layer tree dump
        https://bugs.webkit.org/show_bug.cgi?id=37885

        The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
        to be written twice.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::dumpProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Add missing .def file entries.
barraclough@apple.com [Tue, 20 Apr 2010 20:33:56 +0000 (20:33 +0000)]
JavaScriptCore: Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

WebCore: Speculative tiger build fix.

Reviewed by NOBODY (build fix).

* WebCore.NPAPI.exp:
* WebCore.PluginHostProcess.exp:
* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative tiger build fix.
barraclough@apple.com [Tue, 20 Apr 2010 20:23:11 +0000 (20:23 +0000)]
Speculative tiger build fix.

Reviewed by NOBODY (build fix).

* WebCore.NPAPI.exp:
* WebCore.PluginHostProcess.exp:
* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 20:22:30 +0000 (20:22 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Fix typo in chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 20 Apr 2010 20:18:34 +0000 (20:18 +0000)]
2010-04-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add basic script editing capabilities to the front-end.

        https://bugs.webkit.org/show_bug.cgi?id=37875

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        (WebInspector.ScriptView.prototype._editLine):
        (WebInspector.ScriptView.prototype._editLineComplete):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype.canEditScripts):
        (WebInspector.ScriptsPanel.prototype.editScriptLine):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.updateContent):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.reset):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.copyRange):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype.set editCallback):
        (WebInspector.TextViewer.prototype._buildChunks):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype._handleDoubleClick):
        (WebInspector.TextViewer.prototype._commitEditingLine):
        (WebInspector.TextViewer.prototype._cancelEditingLine):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):
        (WebInspector.log.logMessage):
        (WebInspector.log):
        (WebInspector.isEditingAnyField):
        (WebInspector.startEditing.cleanUpAfterEditing):

2010-04-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add basic script editing capabilities to the front-end.

        https://bugs.webkit.org/show_bug.cgi?id=37875

        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.resolveScriptSource):
        (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.editScriptLine):
        (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
        * src/js/DevTools.js:
        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.editScriptLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing .def file entries.
barraclough@apple.com [Tue, 20 Apr 2010 20:06:38 +0000 (20:06 +0000)]
Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 20 Apr 2010 19:54:46 +0000 (19:54 +0000)]
2010-04-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
        https://bugs.webkit.org/show_bug.cgi?id=37765

        I fixed the queue to not ignore Tor as a reviwer in r57531,
        but instead it throws an exception every time his name is in a patch.

        This fixes our Executive.run_command code to work around a Popen
        bug http://bugs.python.org/issue5290 whereby python versions before 2.6
        do not correctly handle unicode objects as input or output to
        Popen.communicate.

        Following the advice of:
        http://farmdev.com/talks/unicode/
        I'm attempting to take the python unicode plunge and use unicode()
        objects as strings instead of str() objects everywhere in webkitpy.

        We do not have to use u"" instead of "" because u"a" == "a" as expected
        in Python.  Python will generate a warning to the console in cases where
        a unicode() == str() operation cannot be performed.

        I also cleaned up the input handling in run_command a little by adding
        a new _compute_input() method which can return early instead of having
        such a long/cluttered if-block.

        Executive.run* now correctly accept and return unicode() objects.
        I attempted to fix all the places that we call .write() to make sure we
        encode any unicode() objects into utf-8.

        All places which use StringIO need to be sure to pass StringIO a
        pre-encoded byte-array (str object) instead of unicode so that
        clients which read from the StringIO don't have encoding exceptions.
        To make this easier, I removed the patch_file_object support from
        add_patch_to_bug, and changed the 4 places which previously used
        StringIO to create a fake patch file.

        I attempted to document any places where we are not correctly converting
        to/from bytes (str() objects) to strings (unicode() objects).

        * Scripts/webkitpy/common/checkout/api_unittest.py:
         - Read/write utf-8 files instead of ascii.
         - Update the tests to use test for proper unicode() handling.
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
         - Use unicode() strings instead of str() byte arrays.
        * Scripts/webkitpy/common/checkout/scm.py:
         - Remove use of str().
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
         - Read/write utf-8 files and use unicode() strings in testing.
        * Scripts/webkitpy/common/config/committers.py:
         - Use \u instead of \x to make slightly clearer what we're doing.
        * Scripts/webkitpy/common/net/bugzilla.py:
         - Add a new _string_contents() method and explain why
           we have to call unicode() on the result of soup.string
           and why it's safe to do so w/o needing to pass a codec name.
         - Remove the (unused) support for passing a file object to add_patch_to_bug().
        * Scripts/webkitpy/common/net/buildbot.py:
         - Use unicode() instead of str() when needing to coax a
           NavigableString object into a unicode() object.
        * Scripts/webkitpy/common/net/statusserver.py:
         - Remove use of str()
        * Scripts/webkitpy/common/prettypatch.py:
         - Write out the patch file as utf-8.
        * Scripts/webkitpy/common/system/autoinstall.py:
         - Add a FIXME about encoding.
        * Scripts/webkitpy/common/system/deprecated_logging.py:
         - Document that tee() works on bytes, not strings.
        * Scripts/webkitpy/common/system/executive.py:
         - Make run* properly take and return unicode() objects.
        * Scripts/webkitpy/common/system/executive_unittest.py:
         - Added a unit test to make sure we don't break Tor again!
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
         - Write out the test list as utf-8.
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
         - Write out json files as utf-8.
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
         - Add FIXME about encoding handling.
        * Scripts/webkitpy/tool/commands/upload.py:
         - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
        * Scripts/webkitpy/tool/mocktool.py:
         - Rename add_patch_to_bug argument to match bugzilla.py
        * Scripts/webkitpy/tool/steps/postdiff.py:
         - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
        * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
        * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
         - Fixed spurious logging seen when running test-webkitpy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 19:52:18 +0000 (19:52 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed.  Update chromium test expectations to reflect changes
        in SVG tests from r57886.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Tue, 20 Apr 2010 19:34:05 +0000 (19:34 +0000)]
2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        For check-webkit-style, implemented __eq__() and __ne__() (the
        built-in equality and inequality methods) for the
        DefaultStyleErrorHandler class.

        https://bugs.webkit.org/show_bug.cgi?id=37850

        This will facilitate unit-testing for a subsequent patch,
        namely for https://bugs.webkit.org/show_bug.cgi?id=37850

        * Scripts/webkitpy/style/error_handlers.py:
          - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
            class.

        * Scripts/webkitpy/style/error_handlers_unittest.py:
          - Added unit tests for __eq__() and __ne__().
          - Also included a minor clean-up refactoring of combining the
            StyleErrorHandlerTestBase class (which has not needed to
            be separate due to previous changes) into the
            DefaultStyleErrorHandlerTest class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 37828 - Move WebCore's String classes to WTF
barraclough@apple.com [Tue, 20 Apr 2010 19:28:41 +0000 (19:28 +0000)]
Bug 37828 - Move WebCore's String classes to WTF

Reviewed by Geoff Garen.

Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).

As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").

JavaScriptCore:

Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.

* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* config.h:
* wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
* wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
* wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
* wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
* wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
* wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
* wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
* wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
* wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.
(WebCore::charactersToFloat):
* wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.

WebCore:

Moving the files, but leaving the classes logically in the WebCore namespace –
which is technically a layering violation – I'll come back and fix this up in a
subsequent patch.

* Android.mk:
* ForwardingHeaders/wtf/StaticConstructors.h: Added.
* ForwardingHeaders/wtf/text/AtomicString.h: Added.
* ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
* ForwardingHeaders/wtf/text/StringBuffer.h: Added.
* ForwardingHeaders/wtf/text/StringHash.h: Added.
* ForwardingHeaders/wtf/text/StringImpl.h: Added.
* ForwardingHeaders/wtf/text/WTFString.h: Added.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/MediaFeatureNames.cpp:
* dom/QualifiedName.cpp:
* dom/make_names.pl:
* platform/StaticConstructors.h: Removed.
* platform/text/AtomicString.cpp: Removed.
* platform/text/AtomicString.h:
* platform/text/AtomicStringImpl.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
* platform/text/StringHash.h:
* platform/text/StringImpl.cpp: Removed.
* platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 20 Apr 2010 19:20:10 +0000 (19:20 +0000)]
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
        to FileChooser*. Though an implementation of chooseIconForFiles()
        might have ownership of the FileChooser instance, we don't need to
        use PassRefPtr<> in this case.

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::chooseIconForFiles):
        * page/Chrome.cpp:
        (WebCore::Chrome::chooseIconForFiles):
        * page/Chrome.h:
        * page/ChromeClient.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::chooseIconForFiles):
        * src/ChromeClientImpl.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::chooseIconForFiles):
        * WebCoreSupport/ChromeClientGtk.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebCoreSupport/ChromeClientHaiku.cpp:
        (WebCore::ChromeClientHaiku::chooseIconForFiles):
        * WebCoreSupport/ChromeClientHaiku.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::chooseIconForFiles):
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::chooseIconForFiles):
        * WebCoreSupport/ChromeClientQt.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::chooseIconForFiles):
        * WebCoreSupport/WebChromeClient.h:
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Change a parameter type of chooseIconForFiles()
        https://bugs.webkit.org/show_bug.cgi?id=37504

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::chooseIconForFiles):
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Tue, 20 Apr 2010 19:08:14 +0000 (19:08 +0000)]
2010-04-20  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Implement ATK_ROLE_FORM.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_role):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Tue, 20 Apr 2010 18:52:44 +0000 (18:52 +0000)]
2010-04-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Move most of the PasteboardHelper logic into WebCore. This helps
        prepare for WebKit2 and leads to a clearer separation of concerns
        between the WebKit and WebCore layers.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::collapseSelection): Converted this logic to a GClosure callback.
        (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now.
        * WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore.
        (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list.
        (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list.
        (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids.
        (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard.
        * WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality.
2010-04-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Move most of the PasteboardHelper logic into WebCore. This helps
        prepare for WebKit2 and leads to a clearer separation of concerns
        between the WebKit and WebCore layers.

        No new tests as functionality has not changed.

        * GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
        * platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
        * platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming.
        (WebCore::clipboard_get_contents_cb): Ditto.
        (WebCore::Pasteboard::helper): Added, member is now private.
        (WebCore::Pasteboard::writeURL): Ditto.
        (WebCore::Pasteboard::documentFragment): Update to reflect method renaming.
        (WebCore::Pasteboard::plainText): Ditto.
        * platform/gtk/PasteboardHelper.cpp: Added.
        (WebCore::PasteboardHelper::PasteboardHelper): Added.
        (WebCore::PasteboardHelper::~PasteboardHelper): Added.
        (WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit.
        (WebCore::widgetFromFrame): Added helper function.
        (WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit.
        (WebCore::PasteboardHelper::getClipboard): Ditto.
        (WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto.
        (WebCore::PasteboardHelper::targetList): Ditto.
        (WebCore::PasteboardHelper::fillSelectionData): Ditto.
        (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
        (WebCore::getClipboardContentsCallback): Ditto.
        (WebCore::clearClipboardContentsCallback): Ditto.
        (WebCore::PasteboardHelper::writeClipboardContents): Ditto.
        * platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 18:22:59 +0000 (18:22 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dimitri Glazkov.

        Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
        https://bugs.webkit.org/show_bug.cgi?id=37741

        RenderPartObject is a useless intermediate class between RenderPart and
        RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
        applies to objects and embeds when the content is a FrameView, so can move
        to RenderEmbeddedObject.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
        (WebCore::RenderEmbeddedObject::requiresLayer):
        (WebCore::RenderEmbeddedObject::paint):
        (WebCore::RenderEmbeddedObject::viewCleared):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderFrameBase.h:
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::RenderPart):
        * rendering/RenderPart.h:
        * rendering/RenderPartObject.cpp: Removed.
        * rendering/RenderPartObject.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Sergey Ulanov <sergeyu@chromium.org>
scherkus@chromium.org [Tue, 20 Apr 2010 18:15:48 +0000 (18:15 +0000)]
2010-04-20  Sergey Ulanov <sergeyu@chromium.org>

        Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

        * platform/chromium-linux/media/video-replaces-poster-expected.checksum:
        * platform/chromium-linux/media/video-replaces-poster-expected.png:
        * platform/chromium-mac/media/video-replaces-poster-expected.checksum:
        * platform/chromium-mac/media/video-replaces-poster-expected.png:
        * platform/chromium-win/media/video-replaces-poster-expected.checksum:
        * platform/chromium-win/media/video-replaces-poster-expected.png:
        * platform/chromium-win/media/video-zoom-expected.checksum: Added.
        * platform/chromium-win/media/video-zoom-expected.png: Added.
        * platform/chromium-win/media/video-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Tue, 20 Apr 2010 18:00:41 +0000 (18:00 +0000)]
2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>

        Unreviewed.

        Add my IRC nick to the committers.py list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
hausmann@webkit.org [Tue, 20 Apr 2010 17:41:45 +0000 (17:41 +0000)]
[Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=37816

Patch by Kim Grönholm <kim.gronholm@nomovok.com> on 2010-04-20
Reviewed by Simon Hausmann.

Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955

* QtLauncher/main.cpp:
(LauncherWindow::eventFilter):
(LauncherWindow::initializeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Robin Cao <robin.webkit@gmail.com>
krit@webkit.org [Tue, 20 Apr 2010 17:31:43 +0000 (17:31 +0000)]
2010-04-20  Robin Cao  <robin.webkit@gmail.com>

        Reviewed by Dirk Schulze.

        SVG no AnimateColor for stroke or fill if they are set to none on target.
        https://bugs.webkit.org/show_bug.cgi?id=36718

        SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
        This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case
        the property type determined by base value may be different from the one determined by 'fromTo' values.

        No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
        Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
2010-04-20  Robin Cao  <robin.webkit@gmail.com>

        Reviewed by Dirk Schulze.

        Update expected results after bug fix: https://bugs.webkit.org/show_bug.cgi?id=36718
        now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Updated.
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Updated.
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Updated.
        * svg/custom/animation-currentColor.svg: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 16:09:52 +0000 (16:09 +0000)]
2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57892.
        http://trac.webkit.org/changeset/57892
        https://bugs.webkit.org/show_bug.cgi?id=37864

        Caused an assertion in Mac builds (Requested by smfr on
        #webkit).

        * WebCore.xcodeproj/project.pbxproj:
        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea):
        * page/Frame.cpp:
        (WebCore::Frame::ownerRenderer):
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::clear):
        (WebCore::FrameView::invalidateRect):
        (WebCore::FrameView::createScrollbar):
        * rendering/RenderFrameBase.h:
        * rendering/RenderObject.h:
2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57892.
        http://trac.webkit.org/changeset/57892
        https://bugs.webkit.org/show_bug.cgi?id=37864

        Caused an assertion in Mac builds (Requested by smfr on
        #webkit).

        * WebView/WebFrame.mm:
        (-[WebFrame _getVisibleRect:]):
        * WebView/WebFrameView.mm:
        (-[WebFrameView _install]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 20 Apr 2010 15:54:03 +0000 (15:54 +0000)]
2010-04-20  MORITA Hajime <morrita@google.com>

        Unreviewed, add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Tue, 20 Apr 2010 15:12:45 +0000 (15:12 +0000)]
2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>

        Reviewed by Darin Adler.

        RenderListItem: change enclosingList() to only traverse the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=37319

        This makes the function safe to use for items with nodes that are detached from
        the DOM tree and simplifies the code quite a bit.

        Covered by existing tests.

        * rendering/RenderListItem.cpp:
        (WebCore::enclosingList):
        (WebCore::previousListItem):
        (WebCore::RenderListItem::explicitValueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 15:06:28 +0000 (15:06 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
        https://bugs.webkit.org/show_bug.cgi?id=37741

        Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
        RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().

        * WebCore.xcodeproj/project.pbxproj:
        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea):
        * page/Frame.cpp:
        (WebCore::Frame::ownerRenderer):
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::clear):
        (WebCore::FrameView::invalidateRect):
        (WebCore::FrameView::createScrollbar):
        * rendering/RenderFrameBase.h:
        (WebCore::RenderFrameBase::isRenderFrameBase):
        (WebCore::toRenderFrameBase):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderFrameBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Tue, 20 Apr 2010 14:58:56 +0000 (14:58 +0000)]
2010-04-20  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Pressing tab now closes the select popup as it should.
        https://bugs.webkit.org/show_bug.cgi?id=37721

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::handleKeyEvent):
2010-04-20  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Tests that pressing tab now closes the select popup.
        https://bugs.webkit.org/show_bug.cgi?id=37721

        * tests/PopupMenuTest.cpp:
        (WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnskip xss-DENIED-mime-type-execute-as-html.html on Windows
aroben@apple.com [Tue, 20 Apr 2010 14:50:58 +0000 (14:50 +0000)]
Unskip xss-DENIED-mime-type-execute-as-html.html on Windows

This is essentially a rollout of r57729. I was hoping that skipping
this test would fix the spurious timeouts described in
<http://webkit.org/b/37714>, but that hasn't happened.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 20 Apr 2010 14:16:33 +0000 (14:16 +0000)]
2010-04-20  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Nate Chapin.

        Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
        https://bugs.webkit.org/show_bug.cgi?id=37810

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
        * bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
        * bindings/v8/test/V8TestObj.cpp:
        (WebCore::TestObjInternal::overloadedMethodCallback):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage): Added null checks.
        (WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
        * html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
        * html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Evan Stade <estade@chromium.org>
eric@webkit.org [Tue, 20 Apr 2010 13:44:32 +0000 (13:44 +0000)]
2010-04-20  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        [chromium] crash when dragging images
        https://bugs.webkit.org/show_bug.cgi?id=37715

        NULL check the return value of nativeImageForCurrentFrame(),
        and NULL check Image just for good measure.

        Tested by new DragImageTest unit test.

        * platform/chromium/DragImageChromiumSkia.cpp:
        (WebCore::createDragImageFromImage):
2010-04-20  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        [chromium] crash when dragging images
        https://bugs.webkit.org/show_bug.cgi?id=37715

        Added unit tests for DragImageChromiumSkia.

        * WebKit.gyp:
        * tests/DragImageTest.cpp: Added.
        (WebCore::TestImage::TestImage):
        (WebCore::TestImage::~TestImage):
        (WebCore::TestImage::size):
        (WebCore::TestImage::nativeImageForCurrentFrame):
        (WebCore::TestImage::destroyDecodedData):
        (WebCore::TestImage::decodedSize):
        (WebCore::TestImage::draw):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Tue, 20 Apr 2010 13:23:10 +0000 (13:23 +0000)]
2010-04-20  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by David Levin.

        Remove a workaround in plugin cursor setting that was obsoleted by
        the change in https://bugs.webkit.org/show_bug.cgi?id=35132
        https://bugs.webkit.org/show_bug.cgi?id=37811

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::ChromeClientImpl):
        (WebKit::ChromeClientImpl::setCursor):
        (WebKit::ChromeClientImpl::setCursorForPlugin):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 20 Apr 2010 12:52:54 +0000 (12:52 +0000)]
2010-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceFilter needs to be moved to under Renderers
        https://bugs.webkit.org/show_bug.cgi?id=35320

        This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
        from the SVGResources.
        A clean-up solves the dependencies between SVGFilterElement, the filter primitives
        and SVGResources. This shall make the filter code more readable and better maintable.
        The Filter primitives get dumped now, as long as they have externalRepresentation
        implemented.

        No behavior changes, so no new tests were added.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::selfWillPaint):
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGResource.h:
        (WebCore::):
        (WebCore::RenderSVGResource::postApplyResource):
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceFilter.cpp: Added.
        (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::invalidateClients):
        (WebCore::RenderSVGResourceFilter::invalidateClient):
        (WebCore::RenderSVGResourceFilter::buildPrimitives):
        (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/RenderSVGResourceFilter.h: Added.
        (WebCore::FilterData::FilterData):
        (WebCore::RenderSVGResourceFilter::renderName):
        (WebCore::RenderSVGResourceFilter::filterUnits):
        (WebCore::RenderSVGResourceFilter::primitiveUnits):
        (WebCore::RenderSVGResourceFilter::resourceType):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::applyResource):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::selfWillPaint):
        (WebCore::RenderSVGRoot::paint):
        * rendering/RenderSVGText.cpp:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        (WebCore::deregisterFromResources):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        (WebCore::writeSVGResource):
        (WebCore::writeResources):
        (WebCore::writeRenderResources):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::build):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::build):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::build):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::build):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::build):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::build):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::build):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::build):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::build):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::build):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:
        (WebCore::):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::createRenderer):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/graphics/SVGResource.cpp:
        * svg/graphics/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isPaintServer):
        * svg/graphics/SVGResourceFilter.cpp: Removed.
        * svg/graphics/SVGResourceFilter.h: Removed.
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::externalRepresentation):
        * svg/graphics/filters/SVGFilterBuilder.h:
        (WebCore::SVGFilterBuilder::namedEffects):
2010-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceFilter needs to be moved to under Renderers
        https://bugs.webkit.org/show_bug.cgi?id=35320

        All SVG tests with filters need an update. A new renderer for
        SVGFilterElement was created. This renderer also dumps filter
        primitives as long as they have externalRepresentation implemented.

        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textFeatures-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feComposite-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feGaussianBlur-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/sourceAlpha-expected.txt:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/filter-on-tspan-expected.txt:
        * platform/qt/svg/filters/filter-source-position-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:
        * platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
        * platform/win/svg/filters/feColorMatrix-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed speculative buildfix for WinCE after r57882
ossy@webkit.org [Tue, 20 Apr 2010 12:46:45 +0000 (12:46 +0000)]
[Qt] Unreviewed speculative buildfix for WinCE after r57882
https://bugs.webkit.org/show_bug.cgi?id=37701

* JavaScriptCore.pri: missing wince* case added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative Chromium/Win build fix, attempt #2.
barraclough@apple.com [Tue, 20 Apr 2010 11:33:56 +0000 (11:33 +0000)]
Speculative Chromium/Win build fix, attempt #2.

Reviewed by NOBODY (build fix).

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative Chromium/Win build fix.
barraclough@apple.com [Tue, 20 Apr 2010 11:19:14 +0000 (11:19 +0000)]
Speculative Chromium/Win build fix.

Reviewed by NOBODY (build fix).

* config.h: JS_EXPORTDATA should do nothing on !JSC builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
ossy@webkit.org [Tue, 20 Apr 2010 11:16:53 +0000 (11:16 +0000)]
[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37701

Reviewed by Simon Hausmann.

* JavaScriptCore.pri: dependency added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Tue, 20 Apr 2010 10:37:37 +0000 (10:37 +0000)]
2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57880.
        http://trac.webkit.org/changeset/57880
        https://bugs.webkit.org/show_bug.cgi?id=37846

        Broke several bots, FEDisplacmentMap dumps includes pointers,
        no one noticed. Dirk will upload a new patch later. (Requested
        by WildFox on #webkit).

        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textFeatures-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feComposite-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feGaussianBlur-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/sourceAlpha-expected.txt:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:
2010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57880.
        http://trac.webkit.org/changeset/57880
        https://bugs.webkit.org/show_bug.cgi?id=37846

        Broke several bots, FEDisplacmentMap dumps includes pointers,
        no one noticed. Dirk will upload a new patch later. (Requested
        by WildFox on #webkit).

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::selfWillPaint):
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGResource.h:
        (WebCore::):
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceFilter.cpp: Removed.
        * rendering/RenderSVGResourceFilter.h: Removed.
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::applyResource):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::selfWillPaint):
        (WebCore::RenderSVGRoot::paint):
        * rendering/RenderSVGText.cpp:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        (WebCore::deregisterFromResources):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        (WebCore::writeSVGResource):
        (WebCore::writeResources):
        (WebCore::writeRenderResources):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::build):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::build):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::build):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::build):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::build):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::build):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::build):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::build):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::build):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::build):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:
        (WebCore::):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::buildFilter):
        (WebCore::SVGFilterElement::canvasResource):
        * svg/SVGFilterElement.h:
        (WebCore::SVGFilterElement::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/graphics/SVGResource.cpp:
        * svg/graphics/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isFilter):
        * svg/graphics/SVGResourceFilter.cpp: Added.
        (WebCore::SVGResourceFilter::SVGResourceFilter):
        (WebCore::SVGResourceFilter::~SVGResourceFilter):
        (WebCore::SVGResourceFilter::filterBoundingBox):
        (WebCore::shouldProcessFilter):
        (WebCore::SVGResourceFilter::addFilterEffect):
        (WebCore::SVGResourceFilter::fitsInMaximumImageSize):
        (WebCore::SVGResourceFilter::prepareFilter):
        (WebCore::SVGResourceFilter::applyFilter):
        (WebCore::SVGResourceFilter::externalRepresentation):
        (WebCore::getFilterById):
        * svg/graphics/SVGResourceFilter.h: Added.
        (WebCore::SVGResourceFilter::create):
        (WebCore::SVGResourceFilter::resourceType):
        (WebCore::SVGResourceFilter::setFilterResolution):
        (WebCore::SVGResourceFilter::setHasFilterResolution):
        (WebCore::SVGResourceFilter::filterBoundingBoxMode):
        (WebCore::SVGResourceFilter::setFilterBoundingBoxMode):
        (WebCore::SVGResourceFilter::effectBoundingBoxMode):
        (WebCore::SVGResourceFilter::setEffectBoundingBoxMode):
        (WebCore::SVGResourceFilter::filterRect):
        (WebCore::SVGResourceFilter::setFilterRect):
        (WebCore::SVGResourceFilter::scaleX):
        (WebCore::SVGResourceFilter::scaleY):
        (WebCore::SVGResourceFilter::setFilterBoundingBox):
        (WebCore::SVGResourceFilter::builder):
        * svg/graphics/filters/SVGFilterBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 20 Apr 2010 09:45:09 +0000 (09:45 +0000)]
2010-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceFilter needs to be moved to under Renderers
        https://bugs.webkit.org/show_bug.cgi?id=35320

        This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
        from the SVGResources.
        A clean-up solves the dependencies between SVGFilterElement, the filter primitives
        and SVGResources. This shall make the filter code more readable and better maintable.
        The Filter primitives get dumped now, as long as they have externalRepresentation
        implemented.

        No behavior changes, so no new tests were added.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::selfWillPaint):
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGResource.h:
        (WebCore::):
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceFilter.cpp: Added.
        (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::invalidateClients):
        (WebCore::RenderSVGResourceFilter::invalidateClient):
        (WebCore::RenderSVGResourceFilter::buildPrimitives):
        (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize):
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/RenderSVGResourceFilter.h: Added.
        (WebCore::FilterData::FilterData):
        (WebCore::RenderSVGResourceFilter::renderName):
        (WebCore::RenderSVGResourceFilter::filterUnits):
        (WebCore::RenderSVGResourceFilter::primitiveUnits):
        (WebCore::RenderSVGResourceFilter::resourceType):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::applyResource):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::selfWillPaint):
        (WebCore::RenderSVGRoot::paint):
        * rendering/RenderSVGText.cpp:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        (WebCore::deregisterFromResources):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        (WebCore::writeSVGResource):
        (WebCore::writeResources):
        (WebCore::writeRenderResources):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::build):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::build):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::build):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::build):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::build):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::build):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::build):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::build):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::build):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::build):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:
        (WebCore::):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::createRenderer):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect):
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/graphics/SVGResource.cpp:
        * svg/graphics/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isPaintServer):
        * svg/graphics/SVGResourceFilter.cpp: Removed.
        * svg/graphics/SVGResourceFilter.h: Removed.
        * svg/graphics/filters/SVGFilterBuilder.h:
        (WebCore::SVGFilterBuilder::namedEffects):

2010-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceFilter needs to be moved to under Renderers
        https://bugs.webkit.org/show_bug.cgi?id=35320

        All SVG tests with filters need an update. A new renderer for
        SVGFilterElement was created. This renderer also dumps filter
        primitives as long as they have externalRepresentation implemented.

        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textFeatures-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feComposite-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feGaussianBlur-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/sourceAlpha-expected.txt:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber stamped by Maciej Stachowiak (relanding r57829).
barraclough@apple.com [Tue, 20 Apr 2010 08:30:12 +0000 (08:30 +0000)]
Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA

JavaScriptCore:

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
* runtime/Identifier.h:
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Copied from JavaScriptCore/wtf/WTFThreadData.cpp.
* wtf/WTFThreadData.h: Copied from JavaScriptCore/wtf/WTFThreadData.h.

JavaScriptGlue:

* ForwardingHeaders/wtf/WTFThreadData.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h.
* JSUtils.cpp:
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

* ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::eventNames):
* platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Tue, 20 Apr 2010 08:28:02 +0000 (08:28 +0000)]
2010-04-20  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216

        Remove LayoutTests/animations/fill-mode-transform.html from the skip list

        * platform/qt/Skipped:
2010-04-20  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216
        Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
        enables a key-frame animation to go to the animation's starting point before the delay,
        and/or to stay at the animation's ending point after its ended, without reverting to the default
        value.
        We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
        and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::AnimationQtBase::AnimationQtBase):
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::GraphicsLayerQt::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
tkent@chromium.org [Tue, 20 Apr 2010 07:30:11 +0000 (07:30 +0000)]
Unreviewed.
Attempt to fix fast/forms/interactive-validation-lost-focusable.html failures on non-Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 20 Apr 2010 07:15:03 +0000 (07:15 +0000)]
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix some unexpected results of editing
        https://bugs.webkit.org/show_bug.cgi?id=37843

        This change fixes about 70 unexpected results.
        The original test_webview_delegate.cc doesn't have this bug.
        The bug was introduced when I ported it to WebKit tree.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (printRangeDescription): Replace the latter startContainer() with endContainer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 20 Apr 2010 07:03:06 +0000 (07:03 +0000)]
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        More tests for interactive validation
        https://bugs.webkit.org/show_bug.cgi?id=37345

        Add tests for cases that event handlers modify DOM structures.
        These improve test coverage for r57346.

        * fast/forms/checkValidity-handler-updates-dom-expected.txt: Added.
        * fast/forms/checkValidity-handler-updates-dom.html: Added.
        * fast/forms/interactive-validation-lost-focusable-expected.txt: Added.
        * fast/forms/interactive-validation-lost-focusable.html: Added.
        * fast/forms/script-tests/checkValidity-handler-updates-dom.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Tue, 20 Apr 2010 06:39:58 +0000 (06:39 +0000)]
2010-04-19  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Expand testatkroles to test ATK form roles.

        * tests/testatkroles.c:
        (test_webkit_atk_get_role_check_box):
        (test_webkit_atk_get_role_entry):
        (test_webkit_atk_get_role_label):
        (test_webkit_atk_get_role_listbox):
        (test_webkit_atk_get_role_password_text):
        (test_webkit_atk_get_role_push_button):
        (test_webkit_atk_get_role_radio_button):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Tue, 20 Apr 2010 06:30:01 +0000 (06:30 +0000)]
2010-04-19  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by David Hyatt.

        Add missing dummy implementations in PluginPackageNone and PluginViewNone.
        http://webkit.org/b/37478

        * plugins/PluginPackageNone.cpp:
        (WebCore::PluginPackage::NPVersion): Add dummy implementation.
        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::handleFocusInEvent): Add dummy implementation.
        (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 06:18:08 +0000 (06:18 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Turn off some unit tests for now - the new-run-webkit-tests dryrun
        tests for chromium won't work if you don't have a chromium checkout.

        https://bugs.webkit.org/show_bug.cgi?id=37841

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 06:00:30 +0000 (06:00 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        (Re-)add dryrun.py; this was renamed from passing.py in the previous
        CL but apparently somehow didn't get checked in.

        https://bugs.webkit.org/show_bug.cgi?id=37841

        * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 20 Apr 2010 05:41:51 +0000 (05:41 +0000)]
2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        check-webkit-style: exits when encountering a deleted file
        https://bugs.webkit.org/show_bug.cgi?id=37122

        This reverts the quick fix done by r57119 and makes check_patch
        not call check_file for deleted files.

        Also this change fixes the behavior for "-", which should mean
        stdin.  Before this change, the style checker just ignored "-"
        with a warning message.

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 20 Apr 2010 05:10:51 +0000 (05:10 +0000)]
2010-04-19  Daniel Bates  <dbates@rim.com>

        No review, rolling out 57868.
        http://trac.webkit.org/changeset/57868
        https://bugs.webkit.org/show_bug.cgi?id=37748

        Sheriffbot wasn't very inspirational after this patch.
        Instead, he was silent when you said hi :-(. Rolling
        out this patch so that I can debug/test this some more.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 20 Apr 2010 04:34:10 +0000 (04:34 +0000)]
2010-04-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=37748

        Make Sheriffbot more inspirational.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 04:22:35 +0000 (04:22 +0000)]
2010-04-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Geoff Garen.

        Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
        https://bugs.webkit.org/show_bug.cgi?id=37741

        Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
        since it's only used for <object> fallback.

        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
        * rendering/RenderEmbeddedObject.h:
        (WebCore::RenderEmbeddedObject::hasFallbackContent):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::RenderPart):
        * rendering/RenderPart.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 04:02:54 +0000 (04:02 +0000)]
2010-04-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
        https://bugs.webkit.org/show_bug.cgi?id=37741

        Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
        between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
        and move code from RenderPart and RenderPartObject into these new classes.

        There should be no functionality difference with this change, so no new tests.

        Fixing up renderer names in the layout tests will be done in a later pass.

        Fix build systems to include the new files.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::createRenderer):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderFrame.cpp:
        (WebCore::RenderFrame::RenderFrame):
        * rendering/RenderFrame.h:
        * rendering/RenderFrameBase.cpp: Added.
        (WebCore::RenderFrameBase::RenderFrameBase):
        (WebCore::RenderFrameBase::layoutWithFlattening):
        * rendering/RenderFrameBase.h: Added.
        * rendering/RenderIFrame.cpp: Added.
        (WebCore::RenderIFrame::RenderIFrame):
        (WebCore::RenderIFrame::calcHeight):
        (WebCore::RenderIFrame::calcWidth):
        (WebCore::RenderIFrame::flattenFrame):
        (WebCore::RenderIFrame::layout):
        * rendering/RenderIFrame.h: Added.
        (WebCore::RenderIFrame::renderName):
        * rendering/RenderPart.cpp:
        * rendering/RenderPart.h:
        * rendering/RenderPartObject.cpp:
        * rendering/RenderPartObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBindings clean-up.
dumi@chromium.org [Tue, 20 Apr 2010 03:59:54 +0000 (03:59 +0000)]
Bindings clean-up.
https://bugs.webkit.org/show_bug.cgi?id=37833

Reviewed by Geoffrey Garen.

Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Mac builders for now by restoring the keepAlive function.
kevino@webkit.org [Tue, 20 Apr 2010 02:59:23 +0000 (02:59 +0000)]
Fix the Mac builders for now by restoring the keepAlive function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fixes for wx with latest trunk.
kevino@webkit.org [Tue, 20 Apr 2010 02:10:26 +0000 (02:10 +0000)]
Build fixes for wx with latest trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 01:43:25 +0000 (01:43 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an extra space in the getComputedStyle-with-psuedo-element test that was causi...
jberlin@webkit.org [Tue, 20 Apr 2010 00:56:17 +0000 (00:56 +0000)]
Remove an extra space in the getComputedStyle-with-psuedo-element test that was causing it to fail on the Chromium bots, and remove the platform-specific results that were landed in the meantime.

Reviewed by Dan Bernstein.

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
* platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
* platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 00:53:22 +0000 (00:53 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

         Reviewed by Adam Barth.

         new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
         that can be used to test platforms other than the one you are running
         on. This can be useful for checking baselines and testing code
         coverage.

         Note that running the code on the "wrong" port requires each
         port-specific implementation to actually not require any
         platform-specific python code (e.g., the chromium-win port must
         test for the existence of windows functions before calling them).

         https://bugs.webkit.org/show_bug.cgi?id=37782

         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
         * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
         * Scripts/webkitpy/layout_tests/port/factory.py:
         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch WebKit.idl to force generated interfaces to be rebuilt. Boo.
mrowe@apple.com [Tue, 20 Apr 2010 00:34:09 +0000 (00:34 +0000)]
Touch WebKit.idl to force generated interfaces to be rebuilt. Boo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 00:33:03 +0000 (00:33 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add --build (default) and --no-build
        options to make that step optional. This flag modifies what happens
        in port.check_build().

        https://bugs.webkit.org/show_bug.cgi?id=37786

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 00:24:02 +0000 (00:24 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out r57823.
mrowe@apple.com [Tue, 20 Apr 2010 00:16:42 +0000 (00:16 +0000)]
Roll out r57823.

It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
by shipping clients of WebKit on Windows.  Adding methods to a delegate interface in this
manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
methods are used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 23:35:49 +0000 (23:35 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        new-run-webkit-tests - fix a typo in r57480 that caused us to stop
        logging the actual list of unexpected results.

        https://bugs.webkit.org/show_bug.cgi?id=37831

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Mon, 19 Apr 2010 23:30:41 +0000 (23:30 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis broke windows.
barraclough@apple.com [Mon, 19 Apr 2010 23:26:29 +0000 (23:26 +0000)]
This broke windows.

Reviewed by NOBODY (rolling out r57829).

JavaScriptCore:

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Removed.
* wtf/WTFThreadData.h: Removed.

JavaScriptGlue:

* ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* JSUtils.cpp:
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

* ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::atomicStringTable):
* platform/text/AtomicString.cpp:
(WebCore::stringTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57853 268f45cc-cd09-0410-ab3c-d52691b4dbfc