WebKit-https.git
10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:24:56 +0000 (00:24 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33270

        These both rely on setTimeouts where they should be using events.

        * fast/css/transition-color-unspecified.html:
        * fast/dom/HTMLObjectElement/object-as-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:21:28 +0000 (00:21 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        platform/chromium/fast/dom/interval.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33274

        We're seeing the debug bots take >100000 microseconds to stop
        and Interval.

        * platform/chromium/fast/dom/interval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 00:16:00 +0000 (00:16 +0000)]
2010-01-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [v8] Let ScriptController have more than one windowShell
        https://bugs.webkit.org/show_bug.cgi?id=33243

        This patch lets ScriptController have more than one windowShell.  We're
        currently only using one of them (for the main world), but this patch
        lets us use other ones for isolated worlds soon.

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/js/ScriptController.cpp:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::createWorld):
        (WebCore::ScriptController::initScript):
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::globalObject):
        (WebCore::ScriptController::proxy):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 23:56:15 +0000 (23:56 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Rolling out r52869 and r52853 due to bot
        and local run-webkit-test failures

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Mac build.
mrowe@apple.com [Wed, 6 Jan 2010 23:20:53 +0000 (23:20 +0000)]
Fix the Mac build.

* WebCore.base.exp: Export symbols WebKit would like to use.
* plugins/PluginWidget.h:
(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix non-Snow Leopard Mac build.
weinig@apple.com [Wed, 6 Jan 2010 23:09:28 +0000 (23:09 +0000)]
Attempt to fix non-Snow Leopard Mac build.

* WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:25:27 +0000 (22:25 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed "build" fix.  Just adding missing include.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Eric Carlson.
kdecker@apple.com [Wed, 6 Jan 2010 22:23:39 +0000 (22:23 +0000)]
    Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.
        * WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
        * platform/Widget.h: Added isPluginWidget().
        (WebCore::Widget::isPluginWidget):
        * plugins/PluginWidget.h: Added.
        (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
        * plugins/mac/PluginWidgetMac.mm: Added.
        (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget

        Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.

        * WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:20:39 +0000 (22:20 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52862.
        http://trac.webkit.org/changeset/52862
        https://bugs.webkit.org/show_bug.cgi?id=33258

        Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
        Leopard Release builder.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:14:10 +0000 (22:14 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/bugzilla.py:
         - Make reopen_bug robust against the bug already being open.
        * Scripts/webkitpy/commands/download.py:
         - Remove dead code from Rollout.
        * Scripts/webkitpy/steps/completerollout.py:
         - Improve the rollout comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
eric@webkit.org [Wed, 6 Jan 2010 22:12:48 +0000 (22:12 +0000)]
2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Set isHttpdOpen to 0 if pidfile does not exist for some reason.
        Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 22:04:06 +0000 (22:04 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 6 Jan 2010 21:37:09 +0000 (21:37 +0000)]
2010-01-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate header declarations for V8 binding security checks
        and delete V8CustomBinding.cpp

        * Android.v8bindings.mk: Removed V8CustomBinding.cpp.
        * WebCore.gypi: Removed V8CustomBinding.cpp.
        * bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp.
        (WebCore::reportUnsafeJavaScriptAccess):
        (WebCore::V8DOMWindowShell::createNewContext):
        (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp.
        (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/custom/V8CustomBinding.cpp: Removed.
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::locationAccessorSetter):
        (WebCore::V8DOMWindow::namedSecurityCheck):
        (WebCore::V8DOMWindow::indexedSecurityCheck):
        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
        (WebCore::V8Document::locationAccessorSetter):
        * bindings/v8/custom/V8HistoryCustom.cpp:
        (WebCore::V8History::indexedSecurityCheck):
        (WebCore::V8History::namedSecurityCheck):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::V8Location::indexedSecurityCheck):
        (WebCore::V8Location::namedSecurityCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 21:26:59 +0000 (21:26 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it had many issues:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg
              svg/custom/marker-opacity.svg
              svg/custom/marker-strokeWidth-changes.svg

        * Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML.
        (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time.
        (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes.
        (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
        * rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency.
        (WebCore::RenderPath::path): Inline this accessor.
        * rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
        * rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated.
        (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code).
        (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
        * rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
        * rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights.
        (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo.
        (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker.
        (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout.
        (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values.
        (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method.
        (WebCore::SVGMarkerData::updateOutslope): Ditto.
        (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation.
        (WebCore::SVGMarkerData::updateInslope): Helper method.
        * rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles)
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers().
        (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers.
        (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix.
        (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers.
        (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto.
        (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
        * svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer()
        (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        * svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below.
        (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
        * svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
                                        and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
                                        ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
                                        per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
        (WebCore::resourceSet): Add global static HashSet<SVGResource*>.
        (WebCore::SVGResource::SVGResource): Add us to the resourceSet.
        (WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
        (WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
        (WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker.
        (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer.
        (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
        * svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values.
        (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker().
        (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef().
        (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 6 Jan 2010 21:10:35 +0000 (21:10 +0000)]
2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        This implements the SVG Filter effect feImage with support of fragment urls.
        It also includes a bug fix for feComposite. feComposite didn't cover values
        bigger than 255 correctly on composite oeprator arithmetic.

        Tests: There are already many feImage tests in trunk. They just needed updated
               pixel test results.
               The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
               and depends on feImage.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::arithmetic):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGImage.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::parseMappedAttribute):
        (WebCore::SVGFEImageElement::notifyFinished):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEImageElement.idl:
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::transformRect):
        * svg/SVGPreserveAspectRatio.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::FEImage):
        (WebCore::FEImage::create):
        (WebCore::FEImage::apply):
        * svg/graphics/filters/SVGFEImage.h:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        The implementation of feImage requires pixel test result updates of the already
        available tests.

        There is also an update for svg/filters/feComposite.svg, since the patch also
        fixed a bug in feComposite.

        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.png:
        * platform/mac/svg/filters/feComposite-expected.checksum:
        * platform/mac/svg/filters/feComposite-expected.png:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        Update SVG status page. We support feDisplacementMap and feImage now.

        * projects/svg/status.xml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded file James Robinson provided to go with his fix for
darin@apple.com [Wed, 6 Jan 2010 20:26:04 +0000 (20:26 +0000)]
Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295

* platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome script tests have wrappers that don't match their templates
darin@apple.com [Wed, 6 Jan 2010 20:24:29 +0000 (20:24 +0000)]
Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239

Reviewed by Eric Seidel.

* fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use
a standard test wrapper instead of a custom one.
* fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:
Changed test to not depend on a non-standard wrapper.
* fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated
results since I changed the test around.

* platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix
incorrect path in template that broke the test when we called
make-script-test-wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 20:15:35 +0000 (20:15 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Fix the bug in previous commit: we shouldn't finish
        decoding if "sizeOnly" is true.
        https://bugs.webkit.org/show_bug.cgi?id=33258

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShould be last part of Windows Build fix.
bweinstein@apple.com [Wed, 6 Jan 2010 19:59:57 +0000 (19:59 +0000)]
Should be last part of Windows Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 19:58:15 +0000 (19:58 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52855.
        http://trac.webkit.org/changeset/52855
        https://bugs.webkit.org/show_bug.cgi?id=33222

        Caused 6 layout tests to fail on Mac

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQT build fix.
barraclough@apple.com [Wed, 6 Jan 2010 19:51:26 +0000 (19:51 +0000)]
QT build fix.

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix part I.
barraclough@apple.com [Wed, 6 Jan 2010 19:45:14 +0000 (19:45 +0000)]
Windows build fix part I.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
mitz@apple.com [Wed, 6 Jan 2010 19:38:52 +0000 (19:38 +0000)]
Build fix

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=33236
barraclough@apple.com [Wed, 6 Jan 2010 19:33:29 +0000 (19:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString

Reviewed by Sam Weinig.

JavaScriptCore:

Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table.  By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

    - change the API shims to track the identifierTable of the current JSGlobalData.

* API/JSContextRef.cpp:
(JSContextGroupCreate):

    - update creation of JSGlobalData for API usage to use new create method.
    - fix shim instanciation bug in JSGlobalContextCreateInGroup.

* JavaScriptCore.exp:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):

    - add asserts to check the identifierTable is being tracked correctly.

* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):

    - Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
    - Define methods to access the thread specific identifier tables.

* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

    - Declare methods to access the thread specific identifier tables.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

    - creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.

* runtime/JSGlobalData.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):

    - destroy() method should be using isIdentifier().

* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):

    - replace m_identifierTable with a single m_isIdentifier bit.

* wtf/StringHashFunctions.h:
(WTF::stringHash):

    - change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.

JavaScriptGlue:

Add API shims similar to those used in the JSC API to track the current identifierTable.

* JSBase.cpp:
(JSBase::Release):
* JSUtils.cpp:
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
* JSUtils.h:
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
* JavaScriptGlue.cpp:
(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
* JavaScriptGlue.xcodeproj/project.pbxproj:
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 18:25:46 +0000 (18:25 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Let ReourceLoader deliver segmented data
        when loading resource from a SharedBuffer object.
        https://bugs.webkit.org/show_bug.cgi?id=33222

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveData):
        * loader/ResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial Qt build fix.
hausmann@webkit.org [Wed, 6 Jan 2010 11:14:48 +0000 (11:14 +0000)]
Unreviewed trivial Qt build fix.

Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).

* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
loki@webkit.org [Wed, 6 Jan 2010 10:02:41 +0000 (10:02 +0000)]
2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
        and remove the httpd's pidfile directory if httpd terminated.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 08:24:15 +0000 (08:24 +0000)]
2010-01-06  Darin Fisher  <darin@chromium.org>

        Fix release build bustage.

        * src/WebKit.cpp: Need to include Logging.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 07:56:06 +0000 (07:56 +0000)]
2010-01-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Expose more APIs to eliminate WebCore usage in Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=33249

        * WebKit.gyp:
        * public/WebFrame.h:
        * public/WebGlyphCache.h: Added.
        * public/WebKit.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrame::instanceCount):
        (WebKit::WebFrameImpl::WebFrameImpl):
        (WebKit::WebFrameImpl::~WebFrameImpl):
        * src/WebFrameImpl.h:
        * src/WebGlyphCache.cpp: Added.
        (WebKit::WebGlyphCache::pageCount):
        * src/WebKit.cpp:
        (WebKit::enableLogChannel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 6 Jan 2010 07:31:28 +0000 (07:31 +0000)]
2010-01-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        Moving v8::HandleScope up above declaration of v8::Local to fix a
        Chromium startup crash.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setContextDebugId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Wed, 6 Jan 2010 06:37:56 +0000 (06:37 +0000)]
2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Levin.

        Refactored check-webkit-style's argument parser to not rely
        on global state, and improved its error handling and unit
        test coverage.

        https://bugs.webkit.org/show_bug.cgi?id=32966

        * Scripts/check-webkit-style:
          - Adjusted to use new argument parser.

        * Scripts/webkitpy/cpp_style.py:
          - Changed _CppStyleState to accept an array of filter rules
            instead of a comma-delimited string.
          - Eliminated cpp_style._DEFAULT_FILTER_RULES.
          - Eliminated cpp_style._USAGE.

        * Scripts/webkitpy/cpp_style_unittest.py:
          - Updated test_filter() and test_default_filter().

        * Scripts/webkitpy/style.py:
          - Converted style._USAGE to create_usage().
          - Corrected usage instructions by removing 0 as a valid
            --verbose flag value.
          - Removed use_webkit_styles().
          - Added ProcessorOptions class.
          - Added ArgumentDefaults class.
          - Added ArgumentPrinter class.
          - Removed parse_arguments and added ArgumentParser class.
          - Moved exit_with_usage() and exit_with_categories() into
            ArgumentParser.
          - Refactored parse_arguments() as ArgumentParser.parse().
          - Improved parser error handling.

        * Scripts/webkitpy/style_unittest.py:
          - Added DefaultArgumentsTest class.
          - Addressed FIXME to check style.WEBKIT_FILTER_RULES
            against style.STYLE_CATEGORIES.
          - Added ArgumentPrinterTest class.
          - Added ArgumentParserTest class and rewrote parser unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable plug-in halting on Mac after r51953
mitz@apple.com [Wed, 6 Jan 2010 05:11:23 +0000 (05:11 +0000)]
Re-enable plug-in halting on Mac after r51953

Reviewed by Mark Rowe.

* WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled): Test for the correct selector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 6 Jan 2010 03:09:24 +0000 (03:09 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [v8] Move V8DOMWindowShell to ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=33232

        This patch moves V8DOMWindow shell to ScriptController, where the
        window shells live in JSC land.  The next step will be to allow for
        more than one window shell per script controller.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::~V8DOMWindowShell):
        * bindings/v8/V8DOMWindowShell.h:
        (WebCore::V8DOMWindowShell::localHandleForContext):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8IsolatedContext.cpp:
        (WebCore::V8IsolatedContext::V8IsolatedContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::~V8Proxy):
        (WebCore::V8Proxy::handleOutOfMemory):
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::currentContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::adjustedContext):
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [v8] Move V8DOMWindowShell to ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Update FrameLoaderClientImpl.cpp to call clearForClose on
        ScriptController instead of on V8Proxy.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Wed, 6 Jan 2010 02:57:02 +0000 (02:57 +0000)]
2010-01-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <header> and <footer> elements.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        These test:
        - <p> closing,
        - No nesting restriction,
        - Residual style, and
        - FormatBlock.

        * fast/html/footer-element-expected.txt: Added.
        * fast/html/footer-element.html: Added.
        * fast/html/header-element-expected.txt: Added.
        * fast/html/header-element.html: Added.
        * fast/html/script-tests/footer-element.js: Added.
        * fast/html/script-tests/header-element.js: Added.
2010-01-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <header> and <footer> elements.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        <header> and <footer> should behave the same as <nav>, <section>,
        <article>, and <aside>. The HTML parser doesn't need to restrict
        the nesting of header/footer elements.

        Tests: fast/html/footer-element.html
               fast/html/header-element.html

        * css/html.css: Add header/footer as block elements.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add headerTag and footerTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for headerTag and footerTag.
        (WebCore::blockTagList): Add headerTag and footerTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Rename isHeaderTag() to isHeadingTag()
        (WebCore::HTMLParser::getNode): Add headerTag and footerTag.
        (WebCore::HTMLParser::isHeadingTag): Renamed from isHeaderTag().
        * html/HTMLParser.h:
          - Rename isHeaderTag() to isHeadingTag()
          - Remove non-existing popNestedHeaderTag().
        * html/HTMLTagNames.in: Add header and footer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Rachel Petterson <rlp@google.com>
abarth@webkit.org [Wed, 6 Jan 2010 02:46:25 +0000 (02:46 +0000)]
2010-01-05  Rachel Petterson  <rlp@google.com>

        Reviewed by Adam Barth.

        Matches the texImage2D and texSubImage2D functions to their
        declarations. Elminates uncessary versions of those functions.
        https://bugs.webkit.org/show_bug.cgi?id=31562
        Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:07:04 +0000 (02:07 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:06:11 +0000 (02:06 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Darin Adler <darin@apple.com>
ojan@chromium.org [Wed, 6 Jan 2010 02:05:13 +0000 (02:05 +0000)]
2010-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        CDATA sections are merged into Text nodes when normalize() is used
        https://bugs.webkit.org/show_bug.cgi?id=33191

        * fast/dom/Node/normalize-with-cdata-expected.txt: Added.
        * fast/dom/Node/normalize-with-cdata.html: Added.
        * fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 6 Jan 2010 02:03:52 +0000 (02:03 +0000)]
2010-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        animations/animation-drt-api-multiple-keyframes.html and animations/animation-drt-api.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33244

        Both these tests have a race condition. They start looking
        for the animation start after the node is already rendered.
        Instead, set the animation just before looking for the animation
        start.

        * animations/animation-drt-api-multiple-keyframes.html:
        * animations/animation-drt-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCDATA sections are merged into Text nodes when normalize() is used
darin@apple.com [Wed, 6 Jan 2010 01:35:52 +0000 (01:35 +0000)]
CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/Node/normalize-with-cdata.html

* dom/Node.cpp:
(WebCore::Node::normalize): Use nodeType instead of isTextNode.

LayoutTests:

* fast/dom/Node/normalize-with-cdata-expected.txt: Added.
* fast/dom/Node/normalize-with-cdata.html: Added.
* fast/dom/Node/script-tests/normalize-with-cdata.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 James Robinson <jamesr@google.com>
eric@webkit.org [Wed, 6 Jan 2010 01:13:11 +0000 (01:13 +0000)]
2010-01-05  James Robinson  <jamesr@google.com>

        Reviewed by Eric Seidel.

        Typing in Google Wave repaints the whole screen
        https://bugs.webkit.org/show_bug.cgi?id=32295

        Add a repaint test to make sure that when mutations happen in a grandchild of a block element that has no in-flow children
        the entire block element is not unnecessarily repainted.
        The bug only shows up when running pixel tests.

        * fast/repaint/block-no-inflow-children.html: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.checksum: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
        * platform/mac/fast/repaint/block-no-inflow-children-expected.txt: Added.
2010-01-05  James Robinson  <jamesr@google.com>

        Reviewed by Eric Seidel.

        Typing in Google Wave repaints the whole screen
        https://bugs.webkit.org/show_bug.cgi?id=32295

        Marks a RenderBlock without block children for layout and painting when it has no line boxes only if it has inline immediate children.
        The existing logic uses the existence of line boxes as a dirty flag to indicate that line boxes need to be regenerated.  This heuristic
        fails when the RenderBlock does not have any in-flow children at all, causing the RenderBlock to get unnecessarily marked for layout and
        painting.  This is particularly bad for common scrollbar manipulation tricks like putting one positioned div inside another - this
        structure caused the entire outer div's bounds to get scheduled for a paint whenever there was any mutation of any descendant.

        Test: LayoutTests/fast/repaint/block-no-inline-children.html (only shows up in pixel tests)

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 James Robinson <jamesr@chromium.org>
eric@webkit.org [Wed, 6 Jan 2010 00:07:56 +0000 (00:07 +0000)]
2010-01-05  James Robinson  <jamesr@chromium.org>

        Reviewed by David Hyatt.

        Cleans up line box clearing when a RenderBlock loses its last child.
        https://bugs.webkit.org/show_bug.cgi?id=33228

        The 'fullLayout' flag in RenderBlock::layoutInlineChildren() is pretty vague, hopefully this will be easier for the next person to figure out.

        No new tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 5 Jan 2010 23:57:39 +0000 (23:57 +0000)]
2010-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        LayoutTests/animations/change-keyframes.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33233

        The timing calculation was just off. It was starting the
        second animation at 600ms and then checking to be half-way
        done with the 1 second animation at 1000ms. Instead, just
        modify the animation to run a bit earlier.

        * animations/change-keyframes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 5 Jan 2010 23:53:00 +0000 (23:53 +0000)]
2010-01-05  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Provide the "documentURL" property for documents and frame owner elements

        This is necessary to determine owner document URLs for nodes (all nodes have
        the top-level document set as ownerDocument).
        https://bugs.webkit.org/show_bug.cgi?id=33025

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed a bug in testcase. Passing an empty array to texImage2D
cmarrin@apple.com [Tue, 5 Jan 2010 23:51:00 +0000 (23:51 +0000)]
    Fixed a bug in testcase. Passing an empty array to texImage2D
        now must be done with 'null' not '0'.

        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/texImageTest-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago New test for texImage2d and texSubImage2d cases
cmarrin@apple.com [Tue, 5 Jan 2010 23:42:03 +0000 (23:42 +0000)]
    New test for texImage2d and texSubImage2d cases
        New test for texImage2d using ImageData which tests rendering.
        https://bugs.webkit.org/show_bug.cgi?id=31562
        Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPublic GIF decoder should stop decoding when allocation fails
pkasting@chromium.org [Tue, 5 Jan 2010 23:22:47 +0000 (23:22 +0000)]
Public GIF decoder should stop decoding when allocation fails
https://bugs.webkit.org/show_bug.cgi?id=33231

Reviewed by Adam Barth.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::output_row):
(GIFImageReader::do_lzw):
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing Radar numbers
aroben@apple.com [Tue, 5 Jan 2010 23:13:18 +0000 (23:13 +0000)]
Add missing Radar numbers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 23:08:32 +0000 (23:08 +0000)]
2010-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Make PNG image decoder work with segmented SharedBuffer
        https://bugs.webkit.org/show_bug.cgi?id=33213

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::isAllDataReceived):
        (WebCore::ImageDecoder::setData):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::PNGImageReader):
        (WebCore::PNGImageReader::close):
        (WebCore::PNGImageReader::currentBufferSize):
        (WebCore::PNGImageReader::setComplete):
        (WebCore::PNGImageReader::decode):
        (WebCore::PNGImageDecoder::decode):
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::pngComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake IWebView::close and destroying a WebView's HWND optional for WebKit clients
aroben@apple.com [Tue, 5 Jan 2010 23:07:33 +0000 (23:07 +0000)]
Make IWebView::close and destroying a WebView's HWND optional for WebKit clients

WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.

IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).

Fixes <http://webkit.org/b/32827> Crash when calling IWebView::close,
then releasing the WebView, without calling DestroyWindow

Fixes a few WebViewDestruction tests, too.

Reviewed by Steve Falkenburg.

* WebView.cpp:
(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it safe to call IWebView::close when IWebView::initWithFrame hasn't been called
aroben@apple.com [Tue, 5 Jan 2010 23:07:21 +0000 (23:07 +0000)]
Make it safe to call IWebView::close when IWebView::initWithFrame hasn't been called

Part of <http://webkit.org/b/32827> Crash when calling
IWebView::close, then releasing the WebView, without calling
DestroyWindow

Reviewed by Steve Falkenburg.

WebKit/win:

* WebView.cpp:
(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.

WebKitTools:

Test that it's safe to call IWebView::close when IWebView::initWithFrame
hasn't been called

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
without ever calling IWebView::initWithFrame and tests that we don't
crash or leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd assertions to catch double-destruction of WebViews earlier
aroben@apple.com [Tue, 5 Jan 2010 23:07:08 +0000 (23:07 +0000)]
Add assertions to catch double-destruction of WebViews earlier

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Fixes <http://webkit.org/b/33219>.

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove dead code in WebViewWndProc
aroben@apple.com [Tue, 5 Jan 2010 23:06:57 +0000 (23:06 +0000)]
Remove dead code in WebViewWndProc

Fixes <http://webkit.org/b/33218>.

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd more WebViewDestruction tests
aroben@apple.com [Tue, 5 Jan 2010 23:06:44 +0000 (23:06 +0000)]
Add more WebViewDestruction tests

Fixes <http://webkit.org/b/33216>.

Reviewed by Eric Seidel.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::NoInitWithFrame):
(WebKitAPITest::CloseThenDestroyViewWindow):
(WebKitAPITest::DestroyViewWindowThenClose):
(WebKitAPITest::DestroyHostWindow):
(WebKitAPITest::DestroyHostWindowThenClose):
(WebKitAPITest::CloseThenDestroyHostWindow):
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Tue, 5 Jan 2010 22:45:01 +0000 (22:45 +0000)]
2010-01-05  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT

        If you're working from a --minimal or --no-svg build and make changes to the
        DRT, then recompile, the build will fail.

        This is because the current behavior at build time is to assume that the
        previous Qt build supported SVG and consequently delete libQtWebKit.so.
        Unfortunately, just deleting libQtWebKit.so will not cause the library to
        re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
        linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
        results in a link failure on the DRT.

        Since re-linking libQtWebKit can take up to ten minutes and should be avoided
        in cases where not actually required, remove the assumption that
        the previous Qt build supported SVG, and amend the symbol detection to look for
        a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
        for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.

        https://bugs.webkit.org/show_bug.cgi?id=32992

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-25 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 5 Jan 2010 22:30:16 +0000 (22:30 +0000)]
2009-12-25 Patrick Gansterer <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Buildfix for WinCE + style fixes.
        https://bugs.webkit.org/show_bug.cgi?id=32939

        * jsc.cpp:
        (functionPrint):
        (functionQuit):
        (parseArguments):
        (fillBufferWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jan 2010 21:18:25 +0000 (21:18 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Dimitri Glazkov.

        Fix namespace indent for ScriptController.

        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::proxy):
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::xssAuditor):
        (WebCore::ScriptController::setProcessingTimerCallback):
        (WebCore::ScriptController::setPaused):
        (WebCore::ScriptController::isPaused):
        (WebCore::ScriptController::sourceURL):
        (WebCore::ScriptController::evaluateInWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 5 Jan 2010 20:48:14 +0000 (20:48 +0000)]
2010-01-05  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
        https://bugs.webkit.org/show_bug.cgi?id=33205

        * jit/ExecutableAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Implement most cases of texImage2D and texSubImage2D
cmarrin@apple.com [Tue, 5 Jan 2010 20:40:45 +0000 (20:40 +0000)]
    Implement most cases of texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=31562

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
bweinstein@apple.com [Tue, 5 Jan 2010 20:37:39 +0000 (20:37 +0000)]
Part of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Tim Hatcher.

Add context menus to handle the interaction with breakpoints in the Source Frame. Currently
we use left click to add/disable/remove breakpoints, and left click to edit (for conditional
breakpoints), but this is hard to discover and behaves differently than Xcode.

Change the behavior to be more like Xcode, left click adds a breakpoint if there isn't one, and
removes it if there is one.

On the context menu, if there is no breakpoint there, we have Add Breakpoint, and Add Conditional
Breakpoint. If there is a breakpoint there, we add entries for Edit Breakpoint (edit
the condition), Remove Breakpoint, and Enable/Disable Breakpoint (based on the current state).

* English.lproj/localizedStrings.js: Added localized context menu entries.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._documentContextMenu.addAndEditBreakpoint):
(WebInspector.SourceFrame.prototype._documentContextMenu): Added context menu entries and handlers.
(WebInspector.SourceFrame.prototype._documentMouseDown): Changed left click behavior (Add -> Remove).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: need a way to get the progress of a webpage load
cfleizach@apple.com [Tue, 5 Jan 2010 20:32:37 +0000 (20:32 +0000)]
AX: need a way to get the progress of a webpage load
https://bugs.webkit.org/show_bug.cgi?id=33221

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/estimated-progress.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::estimatedLoadingProgress):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

* platform/mac/accessibility/document-attributes-expected.txt:
* platform/mac/accessibility/estimated-progress-expected.txt: Added.
* platform/mac/accessibility/estimated-progress.html: Added.
* platform/mac/accessibility/frame-with-title-expected.txt:
* platform/mac/accessibility/frame-with-title.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping three new tests.
kov@webkit.org [Tue, 5 Jan 2010 20:17:32 +0000 (20:17 +0000)]
Skipping three new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Tue, 5 Jan 2010 19:51:32 +0000 (19:51 +0000)]
2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Kilzer.

        Switched to generating list of Perl unit test files dynamically,
        instead of explicitly.

        https://bugs.webkit.org/show_bug.cgi?id=33200

        * Scripts/test-webkitperl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Tue, 5 Jan 2010 19:44:02 +0000 (19:44 +0000)]
2010-01-05  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Reimplement EventSender::leapForward
        https://bugs.webkit.org/show_bug.cgi?id=33114

        Follow Windows implementation of leapForward. When leapForward is called,
        messages are queued and posted after the timeout. A new event loop is created to
        handle those messages and the additional messages that are created as a result.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::EventSender):
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        (EventSender::leapForward):
        (EventSender::sendOrQueueEvent):
        (EventSender::replaySavedEvents):
        (EventSender::eventFilter):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Tue, 5 Jan 2010 19:36:23 +0000 (19:36 +0000)]
2010-01-05  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Drag & drop layout tests fail even when run manually
        https://bugs.webkit.org/show_bug.cgi?id=33055

        No new tests. Fix 3 layout tests when run manually.
        fast/events/drag-and-drop.html
        fast/events/drag-and-drop-dataTransfer-types-nocrash.html
        fast/events/drag-and-drop-fire-drag-dragover.html
        Running these tests in DRT will be fixed in 31332.

        * page/qt/DragControllerQt.cpp:
        (WebCore::DragController::cleanupAfterSystemDrag):
        Cleanup the drag operation if it failed to complete,
        Otherwise, new drag operations will not be possible.
2010-01-05  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Drag & drop layout tests fail even when run manually
        https://bugs.webkit.org/show_bug.cgi?id=33055

        No new tests. Fix 3 layout tests when run manually.
        fast/events/drag-and-drop.html
        fast/events/drag-and-drop-dataTransfer-types-nocrash.html
        fast/events/drag-and-drop-fire-drag-dragover.html
        Running these tests in DRT will be fixed in 31332.

        * Api/qwebpage.cpp:
        (dropActionToDragOp):
        (dragOpToDropAction):
        (QWebPagePrivate::dragEnterEvent):
        (QWebPagePrivate::dragMoveEvent):
        (QWebPagePrivate::dropEvent):
        Accept drag events even if they are not over a drop target.
        This is to ensure that drag events will continue to be delivered.

        * Api/qwebpage_p.h:
        * WebCoreSupport/DragClientQt.cpp:
        (WebCore::dragOperationToDropActions):
        (WebCore::dropActionToDragOperation):
        (WebCore::DragClientQt::startDrag):
        Send dragEnd event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 5 Jan 2010 19:28:50 +0000 (19:28 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fix obscure queue crash in queueengine
        https://bugs.webkit.org/show_bug.cgi?id=33196

        Sometimes we get an exception that can't be stringified.  For example:

        AttributeError: 'ParseError' object has no attribute 'msg'

        In these cases, the whole queue dies because we're in the global
        exception handler.  Instead of dieing here, we should just print a less
        informative message to the console.  We're already printing the whole
        backtrace anyway, so there's not much point to stringifying the
        exception anyway.

        * Scripts/webkitpy/queueengine.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
kov@webkit.org [Tue, 5 Jan 2010 19:08:10 +0000 (19:08 +0000)]
    Reviewed by Xan Lopez.

        Based on idea and original patch by Evan Martin.

        Remove libWebCore intermediate library, to improve link time.

        [GTK] Build time must be reduced
        https://bugs.webkit.org/show_bug.cgi?id=32921

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Nate Chapin <japhet@chromium.org>
abarth@webkit.org [Tue, 5 Jan 2010 19:06:29 +0000 (19:06 +0000)]
2010-01-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Move allowSetting{Frame}SrcToJavascriptUrl from V8Custom to BindingSecurity and
        remove the v8-specific pieces.

        https://bugs.webkit.org/show_bug.cgi?id=33182

        * bindings/BindingSecurity.h:
        (WebCore::::allowSettingFrameSrcToJavascriptUrl): Moved from V8CustomBinding.cpp.
        (WebCore::::allowSettingSrcToJavascriptURL): Moved from V8CustomBinding.cpp.
        * bindings/v8/custom/V8AttrCustom.cpp:
        (WebCore::V8Attr::valueAccessorSetter):
        * bindings/v8/custom/V8CustomBinding.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::V8Element::setAttributeCallback):
        (WebCore::V8Element::setAttributeNodeCallback):
        (WebCore::V8Element::setAttributeNSCallback):
        (WebCore::V8Element::setAttributeNodeNSCallback):
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        (WebCore::V8HTMLFrameElement::srcAccessorSetter):
        (WebCore::V8HTMLFrameElement::locationAccessorSetter):
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
        (WebCore::V8HTMLIFrameElement::srcAccessorSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jan 2010 19:04:23 +0000 (19:04 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Separate DOMWrapperWorld from V8IsolatedWorld
        https://bugs.webkit.org/show_bug.cgi?id=33087

        This change separate DOMWrapperWorld and IsolatedWorld from
        V8IsolatedWorld.  I've also renamed V8IsolatedWorld to
        V8IsolatedContext in preparation for having more than one context in a
        single isolated world.

        This patch moves us closer to two goals:
        1) Matching the structure of the JSC implementation of isolated worlds.
        2) Letting scripts running in isolated contexts see into other iframes
           (which requires having more than one context in an isolated world.)

        * WebCore.gypi:
        * bindings/v8/DOMWrapperWorld.cpp: Added.
        (WebCore::DOMWrapperWorld::DOMWrapperWorld):
        (WebCore::mainThreadNormalWorld):
        * bindings/v8/DOMWrapperWorld.h: Added.
        (WebCore::DOMWrapperWorld::create):
        * bindings/v8/IsolatedWorld.cpp: Added.
        (WebCore::IsolatedWorld::IsolatedWorld):
        (WebCore::IsolatedWorld::~IsolatedWorld):
        * bindings/v8/IsolatedWorld.h: Added.
        (WebCore::IsolatedWorld::create):
        (WebCore::IsolatedWorld::count):
        (WebCore::IsolatedWorld::domDataStore):
        * bindings/v8/MainThreadDOMData.cpp:
        (WebCore::MainThreadDOMData::getMainThreadStore):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::currentScriptState):
        * bindings/v8/ScriptState.cpp:
        * bindings/v8/ScriptState.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/V8IsolatedContext.cpp: Copied from WebCore/bindings/v8/V8IsolatedWorld.cpp.
        (WebCore::V8IsolatedContext::contextWeakReferenceCallback):
        (WebCore::V8IsolatedContext::V8IsolatedContext):
        (WebCore::V8IsolatedContext::destroy):
        (WebCore::V8IsolatedContext::~V8IsolatedContext):
        (WebCore::V8IsolatedContext::scriptState):
        * bindings/v8/V8IsolatedContext.h: Copied from WebCore/bindings/v8/V8IsolatedWorld.h.
        (WebCore::V8IsolatedContext::getEntered):
        (WebCore::V8IsolatedContext::world):
        * bindings/v8/V8IsolatedWorld.cpp: Removed.
        * bindings/v8/V8IsolatedWorld.h: Removed.
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::context):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jan 2010 19:03:29 +0000 (19:03 +0000)]
2010-01-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Move createWindow into generic bindings so it can be shared with JSC
        https://bugs.webkit.org/show_bug.cgi?id=33201

        This patch moves createWindow from V8-specific code into the generic
        bindings so that is can be re-used by the JavaScriptCore bindings.  I
        haven't actually moved the JSC bindings over to using this yet.

        Also, I organized the generic bindings a bit more as it's becoming
        clearer how things are going to shape up.  There are still some
        question marks, but hopefully the answers will become clear as we
        progress.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * bindings/generic/BindingDOMWindow.h: Added.
        (WebCore::::createWindow):
        * bindings/generic/BindingSecurity.h: Renamed from WebCore/bindings/BindingSecurity.h.
        (WebCore::BindingSecurity::BindingSecurity):
        (WebCore::::canAccessWindow):
        (WebCore::::canAccessFrame):
        (WebCore::::checkNodeSecurity):
        * bindings/generic/BindingSecurityBase.cpp: Renamed from WebCore/bindings/BindingSecurityBase.cpp.
        (WebCore::BindingSecurityBase::getDOMWindow):
        (WebCore::BindingSecurityBase::getFrame):
        (WebCore::BindingSecurityBase::canAccess):
        * bindings/generic/BindingSecurityBase.h: Renamed from WebCore/bindings/BindingSecurityBase.h.
        * bindings/generic/GenericBinding.h: Renamed from WebCore/bindings/GenericBinding.h.
        (WebCore::):
        * bindings/v8/V8Binding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::showModalDialogCallback):
        (WebCore::V8DOMWindow::openCallback):
        * bindings/v8/specialization/V8BindingDOMWindow.h: Added.
        (WebCore::V8BindingDOMWindow::storeDialogArgs):
        * bindings/v8/specialization/V8BindingState.cpp: Renamed from WebCore/bindings/v8/V8BindingState.cpp.
        (WebCore::::Only):
        (WebCore::::getActiveWindow):
        (WebCore::::immediatelyReportUnsafeAccessTo):
        * bindings/v8/specialization/V8BindingState.h: Renamed from WebCore/bindings/v8/V8BindingState.h.
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Dominic Mazzoni <dmazzoni@google.com>
eric@webkit.org [Tue, 5 Jan 2010 19:00:29 +0000 (19:00 +0000)]
2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32571

        Added a test to make sure that ARIA checkboxes correctly handle the aria-checked attribute.

        * accessibility/aria-checkbox-checked-expected.txt: Added.
        * accessibility/aria-checkbox-checked.html: Added.
2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32571

        For an object with an aria role of "checkbox" or "radiobutton",
        Use the "aria-checked" attribute to determine if it's checked.

        Test: accessibility/aria-checkbox-checked.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isChecked):
2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32571

        For an object with an aria role of "checkbox" or "radiobutton",
        use the "aria-checked" attribute to determine if it's checked.
        These changes add an isChecked() method to AccessibilityUIElement
        so that we can check for this property from a layout test.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getIsCheckedCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isChecked):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isChecked):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isChecked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHaving a comment for the #endif for a header guard is not required WebKit style.
levin@chromium.org [Tue, 5 Jan 2010 18:43:36 +0000 (18:43 +0000)]
Having a comment for the #endif for a header guard is not required WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=33214

Reviewed by Darin Adler.

* Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
  early when it has all the needed information to continue.
* Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 5 Jan 2010 18:36:46 +0000 (18:36 +0000)]
2010-01-05  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Added compiler error for unsupported platforms.
        https://bugs.webkit.org/show_bug.cgi?id=33112

        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShare more code in the WebViewDestruction tests
aroben@apple.com [Tue, 5 Jan 2010 18:14:58 +0000 (18:14 +0000)]
Share more code in the WebViewDestruction tests

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::createAndInitializeWebView): Renamed from
createWebView. Now initializes the HostWindow and returns the
WebView's HWND via an out-parameter.
(WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
the CloseWithoutDestroyWindow test.
(WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
CloseWithoutDestroyWindow and changed to use the new functions.
(WebKitAPITest::MainFrameAfterClose): Changed to use the new
functions.
(WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
NoCloseOrDestroyWindow and changed to use the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't show HostWindows by default
aroben@apple.com [Tue, 5 Jan 2010 18:14:47 +0000 (18:14 +0000)]
Don't show HostWindows by default

This was making WebKitAPITest very flashy as windows appeared and
disappeared.

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/HostWindow.cpp:
(WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
from the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't hang in WebKitAPITest if no messages have been posted
aroben@apple.com [Tue, 5 Jan 2010 18:14:35 +0000 (18:14 +0000)]
Don't hang in WebKitAPITest if no messages have been posted

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix WebKitCreateInstance helper
aroben@apple.com [Tue, 5 Jan 2010 18:14:22 +0000 (18:14 +0000)]
Fix WebKitCreateInstance helper

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

* WebKitAPITest/tests/WebViewDestruction.cpp:
(WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
through, instead of taking its address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 17:54:27 +0000 (17:54 +0000)]
2010-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Adam Roben.

        Fix  build warnings blindly
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.cpp:
        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
mitz@apple.com [Tue, 5 Jan 2010 17:45:37 +0000 (17:45 +0000)]
Build fix

* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 16:24:40 +0000 (16:24 +0000)]
2010-01-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Darin Adler.

        Fix an obvious bug and build errors in previous commit (r52795)
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::isEmpty):
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::maybeTransferPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Tue, 5 Jan 2010 16:09:01 +0000 (16:09 +0000)]
2010-01-05  Gustavo Noronha Silva  <gns@gnome.org>

        Updated docs for 1.1.18 release.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollow r52729 in ARMAssembler.
loki@webkit.org [Tue, 5 Jan 2010 15:53:17 +0000 (15:53 +0000)]
Follow r52729 in ARMAssembler.
https://bugs.webkit.org/show_bug.cgi?id=33208

Reviewed by Maciej Stachowiak.

Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 5 Jan 2010 15:53:07 +0000 (15:53 +0000)]
2010-01-05  Xan Lopez  <xlopez@igalia.com>

        Bump for 1.1.18 release.

        * configure.ac:

WebKit/gtk:

2010-01-05  Xan Lopez  <xlopez@igalia.com>

        Update for 1.1.18 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 5 Jan 2010 15:14:00 +0000 (15:14 +0000)]
2010-01-04  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Let SharedBuffer use a group of memory segments internally.
        It will merge the segments into a flat consecutive buffer only when
        necessary.
        https://bugs.webkit.org/show_bug.cgi?id=33178

        * platform/SharedBuffer.cpp:
        (WebCore::allocateSegment):
        (WebCore::freeSegment):
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::~SharedBuffer):
        (WebCore::SharedBuffer::adoptVector):
        (WebCore::SharedBuffer::size):
        (WebCore::SharedBuffer::data):
        (WebCore::SharedBuffer::append):
        (WebCore::SharedBuffer::clear):
        (WebCore::SharedBuffer::copy):
        (WebCore::SharedBuffer::buffer):
        (WebCore::SharedBuffer::getSomeData):
        * platform/SharedBuffer.h:
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        * platform/haiku/SharedBufferHaiku.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/qt/SharedBufferQt.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Gtk+
mjs@apple.com [Tue, 5 Jan 2010 11:00:49 +0000 (11:00 +0000)]
Unreviewed build fix for Gtk+

Don't use // comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial Symbian build fix
hausmann@webkit.org [Tue, 5 Jan 2010 10:28:35 +0000 (10:28 +0000)]
Unreviewed trivial Symbian build fix

* plugins/symbian/PluginViewSymbian.cpp: Add missing HostWindow.h inclusion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix broken export macros in package builds.
hausmann@webkit.org [Tue, 5 Jan 2010 09:45:30 +0000 (09:45 +0000)]
[Qt] Fix broken export macros in package builds.

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=33202

Always define QT_MAKEDLL unless we're doing a static
build or we're building inside of Qt. When building
inside of Qt the correct define is pulled from qbase.pri.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 5 Jan 2010 08:58:28 +0000 (08:58 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        * wtf/Platform.h: Rename, reorganize and document OS() macros.

        Adapt to name changes. Also fixed a few incorrect OS checks.

        * API/JSContextRef.cpp:
        * assembler/MacroAssemblerARM.cpp:
        (JSC::isVFPPresent):
        * assembler/MacroAssemblerX86Common.h:
        * bytecode/SamplingTool.cpp:
        * config.h:
        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::~RegisterFile):
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        (JSC::RegisterFile::grow):
        * jit/ExecutableAllocator.h:
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        * jit/ExecutableAllocatorPosix.cpp:
        * jit/ExecutableAllocatorSymbian.cpp:
        * jit/ExecutableAllocatorWin.cpp:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JITStubs.cpp:
        * jsc.cpp:
        (main):
        * parser/Grammar.y:
        * profiler/ProfileNode.cpp:
        (JSC::getCount):
        * runtime/Collector.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlockPtr):
        (JSC::currentThreadStackBase):
        (JSC::getCurrentPlatformThread):
        (JSC::suspendThread):
        (JSC::resumeThread):
        (JSC::getPlatformThreadRegisters):
        (JSC::otherThreadStackPointer):
        * runtime/Collector.h:
        * runtime/DateConstructor.cpp:
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        * runtime/InitializeThreading.cpp:
        (JSC::initializeThreading):
        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):
        * runtime/MarkStackPosix.cpp:
        * runtime/MarkStackSymbian.cpp:
        * runtime/MarkStackWin.cpp:
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncLastIndexOf):
        * runtime/TimeoutChecker.cpp:
        (JSC::getCPUTime):
        * runtime/UString.cpp:
        (JSC::UString::from):
        * wtf/Assertions.cpp:
        * wtf/Assertions.h:
        * wtf/CurrentTime.cpp:
        (WTF::lowResUTCTime):
        * wtf/CurrentTime.h:
        (WTF::getLocalTime):
        * wtf/DateMath.cpp:
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_ThreadCache::InitModule):
        (WTF::TCMallocStats::):
        * wtf/FastMalloc.h:
        * wtf/MathExtras.h:
        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):
        * wtf/RandomNumberSeed.h:
        (WTF::initializeRandomNumberGenerator):
        * wtf/StringExtras.h:
        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * wtf/TCSystemAlloc.cpp:
        * wtf/ThreadSpecific.h:
        (WTF::::destroy):
        * wtf/Threading.h:
        * wtf/ThreadingPthreads.cpp:
        (WTF::initializeThreading):
        (WTF::isMainThread):
        * wtf/ThreadingWin.cpp:
        (WTF::wtfThreadEntryPoint):
        (WTF::createThreadInternal):
        * wtf/VMTags.h:
        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::Collator::userDefault):
        * wtf/win/MainThreadWin.cpp:
        (WTF::initializeMainThreadPlatform):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * src/ChromiumBridge.cpp:
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled):
        (WebKit::):
        (WebKit::EditorClientImpl::handleEditingKeyboardEvent):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):
        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::makeContextCurrent):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectionAsText):
        (WebKit::WebFrameImpl::printPage):
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::handleMouseEvent):
        (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::mouseContextMenu):
        (WebKit::WebViewImpl::mouseUp):
        (WebKit::WebViewImpl::keyEvent):
        (WebKit::WebViewImpl::sendContextMenuEvent):
        (WebKit::WebViewImpl::setScrollbarColors):
        (WebKit::WebViewImpl::navigationPolicyFromMouseEvent):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * webkit/webkitwebsettings.cpp:
        (webkit_get_user_agent):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes. Also fixed a few incorrect OS checks.

        * accessibility/AccessibilityObject.h:
        * config.h:
        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::platform):
        * loader/CachedFont.cpp:
        * loader/FTPDirectoryDocument.cpp:
        * loader/FTPDirectoryParser.cpp:
        * page/EventHandler.cpp:
        * page/Frame.cpp:
        (WebCore::Frame::setUseSecureKeyboardEntry):
        * page/NavigatorBase.cpp:
        (WebCore::NavigatorBase::platform):
        * page/Page.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * page/chromium/DragControllerChromium.cpp:
        (WebCore::DragController::isCopyKeyDown):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::accessKeyModifiers):
        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/FileSystem.h:
        * platform/KeyboardCodes.h:
        * platform/PurgeableBuffer.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeRange):
        * platform/chromium/ClipboardUtilitiesChromium.cpp:
        * platform/chromium/ClipboardUtilitiesChromium.h:
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformKeyboardEventChromium.cpp:
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
        (WebCore::PlatformKeyboardEvent::currentCapsLockState):
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenu::show):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontCache.cpp:
        (WebCore::alternateFamilyName):
        * platform/graphics/FontCache.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/ColorCG.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.h:
        * platform/graphics/chromium/FontPlatformData.h:
        * platform/graphics/opentype/OpenTypeUtilities.cpp:
        * platform/graphics/opentype/OpenTypeUtilities.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::PlatformContextSkia):
        (PlatformContextSkia::save):
        (PlatformContextSkia::restore):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::paint):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::filenameToString):
        (WebCore::filenameFromString):
        (WebCore::filenameForDisplay):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        * platform/network/curl/ResourceHandleManager.cpp:
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):
        * platform/text/String.cpp:
        (WebCore::String::format):
        (WebCore::String::number):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encode):
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        (WebCore::extendTextCodecMaps):
        * platform/text/TextStream.cpp:
        * platform/text/TextStream.h:
        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::decode):
        * platform/win/PlatformMouseEventWin.cpp:
        (WebCore::messageToEventType):
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/win/PlatformScreenWin.cpp:
        (WebCore::deviceInfoForWidget):
        (WebCore::screenIsMonochrome):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::paint):
        (WebCore::PopupMenu::registerClass):
        (WebCore::PopupMenu::PopupMenuWndProc):
        (WebCore::PopupMenu::wndProc):
        * platform/win/SystemTimeWin.cpp:
        (WebCore::userIdleTime):
        * platform/wx/FileSystemWx.cpp:
        (WebCore::unloadModule):
        * plugins/PluginDatabase.cpp:
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::compareFileVersion):
        * plugins/PluginPackage.h:
        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameRect):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::addWindowsMediaPlayerPluginDirectory):
        (WebCore::addMacromediaPluginDirectories):
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::load):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::registerPluginView):
        (WebCore::PluginView::wndProc):
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paintIntoTransformedContext):
        (WebCore::PluginView::paintWindowedPluginIntoContext):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::setParent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::platformStart):
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Fisher.

        Reorganize, document and rename OS() platform macros.
        https://bugs.webkit.org/show_bug.cgi?id=33198

        Adapt to name changes.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Tue, 5 Jan 2010 08:47:34 +0000 (08:47 +0000)]
2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Minor improvements to test-webkit-scripts, as suggested
        by an earlier review.

        https://bugs.webkit.org/show_bug.cgi?id=33125

        * Scripts/test-webkit-scripts:
          - Used OptionParser class instead of getopt.getopt().
          - Created main() method for __main__ block.
          - Enclosed functions in a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo review. Fix DRT breakage on Tiger/Leopard.
cfleizach@apple.com [Tue, 5 Jan 2010 08:06:07 +0000 (08:06 +0000)]
No review. Fix DRT breakage on Tiger/Leopard.

Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 5 Jan 2010 08:00:15 +0000 (08:00 +0000)]
2010-01-04  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Expose more DOM methods to support LayoutTests
        https://bugs.webkit.org/show_bug.cgi?id=33185

        * public/WebDocument.h: Adds documentElement method.
        * public/WebElement.h: Adds innerText method.
        * public/WebFrame.h: Adds renderTreeAsText and counterValueForElementById
        methods, and fixes a few whitespace issues.
        * src/WebDocument.cpp:
        (WebKit::WebDocument::documentElement):
        * src/WebElement.cpp:
        (WebKit::WebElement::innerText):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearName):
        (WebKit::WebFrameImpl::renderTreeAsText):
        (WebKit::WebFrameImpl::counterValueForElementById):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 5 Jan 2010 07:54:16 +0000 (07:54 +0000)]
2010-01-04  Darin Fisher  <darin@chromium.org>

        Fix Chromium build bustage.

        * src/WebAnimationControllerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ARIA "Live Region" support
cfleizach@apple.com [Tue, 5 Jan 2010 07:46:08 +0000 (07:46 +0000)]
Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

Reviewed by Darin Adler.

WebCore:

Tests: platform/mac/accessibility/aria-liveregions-attributes.html
       platform/mac/accessibility/aria-liveregions-notifications.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::contentChanged):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isChildOfARIALiveRegion):
(WebCore::AccessibilityObject::supportsARIALiveRegion):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::contentChanged):
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityObject::ariaLiveRegionBusy):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::areChildrenDirty):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AccessibilityObjectWrapper.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* html/HTMLAttributeNames.in:
* rendering/RenderText.cpp:
(WebCore::RenderText::setText):

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(indexOfChildCallback):
(boolAttributeValueCallback):
(stringAttributeValueCallback):
(addNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

* accessibility/aria-activedescendant-crash.html:
* platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
* platform/mac/accessibility/aria-liveregions-attributes.html: Added.
* platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
* platform/mac/accessibility/aria-liveregions-notifications.html: Added.
* platform/mac/accessibility/aria-menu-role-descriptions.html:
* platform/mac/accessibility/slider-supports-actions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 5 Jan 2010 05:33:22 +0000 (05:33 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool rollout should require a reason
        https://bugs.webkit.org/show_bug.cgi?id=30810

        * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
        * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
        * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
        * Scripts/webkitpy/commands/download_unittest.py: pass required reason
        * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Chris Evans <cevans@chromium.org>
abarth@webkit.org [Tue, 5 Jan 2010 05:19:56 +0000 (05:19 +0000)]
2010-01-04  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Test for https://bugs.webkit.org/show_bug.cgi?id=29820
        Adopt a more conservative approach for loading CSS cross-origin.

        * http/tests/security/cross-origin-css.html: Added.
        * http/tests/security/cross-origin-css-expected.txt: Added.
        * http/tests/security/cross-origin-css-in-xml.xml: Added.
        * http/tests/security/cross-origin-css-in-xml-expected.txt: Added.
        * http/tests/security/resources/xorigincss1.css: Added.
        * http/tests/security/resources/xorigincss2.css: Added.
        * http/tests/security/resources/xorigincss1.html: Added.
        * http/tests/security/resources/xorigincss2.html: Added.
        * http/tests/security/resources/xorigincss3.html: Added.
        * http/tests/security/resources/xorigincss4.html: Added.
        * http/tests/security/resources/xorigincss5.html: Added.
        * http/tests/security/resources/xorigincss6.html: Added.
2010-01-04  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Adopt a more conservative approach for loading CSS cross-origin. When
        loading CSS cross-origin, it must be start with valid CSS if the MIME
        type is broken.

        https://bugs.webkit.org/show_bug.cgi?id=29820

        Test: http/tests/security/cross-origin-css.html
        Test: http/tests/security/cross-origin-css-in-xml.xml

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::setCSSStyleSheet): Enforce stricter load
        requirements for cross-origin loads.
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet): Enforce stricter load
        requirements for cross-origin loads.
        * css/CSSStyleSheet.h:
        * css/CSSStyleSheet.cpp:
        * css/CSSParser.cpp:
        * css/CSSGrammar.y:
        * css/CSSParser.h:
        Add ability to tell whether the CSS parse started with a syntactically
        valid CSS rule.
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::sheetText): Add ability to return
        whether the MIME type was acceptable for CSS.
        (WebCore::CachedCSSStyleSheet::canUseSheet): If requested, return
        whether the MIME type was valid or not.
        * dom/ProcessingInstruction.cpp
        (WebCore::ProcessingInstruction::setCSSStyleSheet): Make use of strict
        mode explicit and add comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements...
mitz@apple.com [Tue, 5 Jan 2010 04:45:28 +0000 (04:45 +0000)]
<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements correctly
<rdar://problem/7397558> REGRESSION: AXImages inside of AXLink cause AXLink to have wrong bounds

Reviewed by Simon Fraser.

WebCore:

Test: accessibility/dimensions-include-descendants.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect): Use absoluteFocusRingQuads()
for non-text renderers. The focus ring encompasses descendants, which is
what we want for the accessibility indicator.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteFocusRingQuads): Added.
* rendering/RenderObject.h:

LayoutTests:

* accessibility/dimensions-include-descendants-expected.txt: Added.
* accessibility/dimensions-include-descendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-04 Ojan Vafai <ojan@ojanmacpro.sfo.corp.google.com>
ojan@chromium.org [Tue, 5 Jan 2010 03:53:28 +0000 (03:53 +0000)]
2010-01-04  Ojan Vafai  <ojan@ojanmacpro.sfo.corp.google.com>

        Reviewed by Dan Bernstein.

        Remove unnecessary division by a constant in SimpleFontDataMac.mm.
        https://bugs.webkit.org/show_bug.cgi?id=33189

        This was added in http://trac.webkit.org/changeset/8104 and seems like
        it was just there to match the previously private function which we no
        longer use.

        No new tests. No change in behavior.

        * platform/graphics/mac/SimpleFontDataMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: Accessibility role of <select> elements is wrong
jhoneycutt@apple.com [Tue, 5 Jan 2010 03:40:59 +0000 (03:40 +0000)]
MSAA: Accessibility role of <select> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33192

Reviewed by Sam Weinig.

WebKit/win:

* AccessibleBase.cpp:
(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.

LayoutTests:

* platform/win/accessibility/select-element-role-expected.txt: Added.
* platform/win/accessibility/select-element-role.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake distcheck build fixes.
kov@webkit.org [Tue, 5 Jan 2010 01:43:47 +0000 (01:43 +0000)]
Make distcheck build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build fix. Unreviewed.
jhoneycutt@apple.com [Tue, 5 Jan 2010 01:38:32 +0000 (01:38 +0000)]
Qt build fix. Unreviewed.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52779 268f45cc-cd09-0410-ab3c-d52691b4dbfc