WebKit-https.git
8 years ago2011-03-02 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Wed, 2 Mar 2011 22:23:58 +0000 (22:23 +0000)]
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
        * configure.ac:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Configurations/FeatureDefines.xcconfig:
        * wtf/Platform.h:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * features.gypi:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Configurations/FeatureDefines.xcconfig:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Scripts/build-webkit:
2011-03-02  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 22:14:13 +0000 (22:14 +0000)]
2011-03-02  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] Expectations update
        https://bugs.webkit.org/show_bug.cgi?id=55615

        * platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
        * platform/chromium-linux/fast/repaint/control-clip-expected.png:
        * platform/chromium-win/fast/repaint/control-clip-expected.checksum:
        * platform/chromium-win/fast/repaint/control-clip-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 21:56:49 +0000 (21:56 +0000)]
2011-03-02  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] Expectations to match r80157
        https://bugs.webkit.org/show_bug.cgi?id=55613

        * platform/chromium-linux/fast/invalid/residual-style-expected.txt:
        * platform/chromium-win/fast/invalid/residual-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 2 Mar 2011 21:47:15 +0000 (21:47 +0000)]
2011-03-02  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Rebaseline Chromium GPU results for Snow Leopard.

        * platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum:
        * platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
        * platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/generated-content-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/generated-content-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum:
        * platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png:
        * platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum:
        * platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
        * platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum:
        * platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum:
        * platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum:
        * platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png:
        * platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
        * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png:
        * platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum:
        * platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
        * platform/chromium-gpu-mac/compositing/sibling-positioning-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/sibling-positioning-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum:
        * platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png:
        * platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum:
        * platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
        * platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum:
        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 21:37:40 +0000 (21:37 +0000)]
2011-03-02  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update.

        [chromium] Update expectations to match those in r80151
        https://bugs.webkit.org/show_bug.cgi?id=55610

        * platform/chromium-win/fast/css-generated-content/005-expected.txt:
        * platform/chromium-win/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
        * platform/chromium-win/fast/css-generated-content/no-openclose-quote-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLook in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
aroben@apple.com [Wed, 2 Mar 2011 21:33:47 +0000 (21:33 +0000)]
Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer

ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
the former location, but was getting lucky on some SnowLeopard machines because symlinks
were being created there pointing into DiagnosticReports. For machines without these
symlinks, crash logs were not getting captured.

Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
SnowLeopard machines

Reviewed by Eric Seidel.

* Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Mar 2011 21:05:05 +0000 (21:05 +0000)]
2011-03-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Update location of media-file.js, which was moved in r79630.

        * manual-tests/media-controls.html: Updated location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 2 Mar 2011 21:02:33 +0000 (21:02 +0000)]
2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80156.
        http://trac.webkit.org/changeset/80156
        https://bugs.webkit.org/show_bug.cgi?id=55604

        "Broke SL compile" (Requested by tonyg-cr on #webkit).

        * bridge/jni/JNIBridge.h:
        (JSC::Bindings::JavaString::operator UString):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::eval):
        (JavaJSObject::getMember):
        (JavaJSObject::setMember):
        (JavaJSObject::removeMember):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::uString):
        * bridge/jni/v8/JavaStringV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete old .res files whenever any .vsprops file changes
aroben@apple.com [Wed, 2 Mar 2011 20:47:54 +0000 (20:47 +0000)]
Delete old .res files whenever any .vsprops file changes

Prospective fix for <http://webkit.org/b/55599> r80079 caused incremental Windows builds to
fail

Reviewed by Tony Chang.

* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Restructured code to loop over a set of file extensions, deleting any old files that
have that extension. Now deletes .res files, too. (We previously deleted any file matching
*.manifest*, but that turned out to just be the union of *.manifest and *.res.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 20:43:23 +0000 (20:43 +0000)]
2011-03-02  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations

        Updating expectations after r80151
        https://bugs.webkit.org/show_bug.cgi?id=55601

        * platform/mac/fast/invalid/residual-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 2 Mar 2011 20:22:45 +0000 (20:22 +0000)]
2011-03-02  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        JavaString API should be implementable by both JSC and V8
        https://bugs.webkit.org/show_bug.cgi?id=55567

        Remove JavaString's UString operator and replace it with a
        script-engine-independent impl() method, which returns a
        StringImpl and can be implemented with both JSC and V8.

        No new tests, refactoring only.

        * bridge/jni/JNIBridge.h:
        (JSC::Bindings::JavaString::impl):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::eval):
        (JavaJSObject::getMember):
        (JavaJSObject::setMember):
        (JavaJSObject::removeMember):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::impl):
        * bridge/jni/v8/JavaStringV8.h:
        (JSC::Bindings::JavaStringImpl::impl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 2 Mar 2011 19:56:10 +0000 (19:56 +0000)]
2011-03-02  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add CRASH() for CSSSelector double frees
        https://bugs.webkit.org/show_bug.cgi?id=55596

        To help track down bug 53045, add a CRASH call when the CSSSelector
        destructor is invoked more than once.

        Just a check, no new tests necessary.

        * css/CSSSelector.h:
        (WebCore::CSSSelector::CSSSelector):
        (WebCore::CSSSelector::~CSSSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 2 Mar 2011 19:54:22 +0000 (19:54 +0000)]
2011-03-02  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed expectations update.

        Add more Snow Leopard-only flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix remaining localization issues by piping all localized strings through WebCore's
weinig@apple.com [Wed, 2 Mar 2011 19:48:40 +0000 (19:48 +0000)]
Fix remaining localization issues by piping all localized strings through WebCore's
localization bottleneck.
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

../WebKit:

* WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
* Misc/WebKitErrors.m:
* Misc/WebLocalizableStringsInternal.h: Added.
* Misc/WebLocalizableStringsInternal.mm: Added.
(WebLocalizedStringInternal):
* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
* WebCoreSupport/WebEditorClient.mm:
(undoNameForEditAction):
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::updateWindowTitle):
(-[WebInspectorWindowController validateUserInterfaceItem:]):
* WebCoreSupport/WebKeyGenerator.m:
(-[WebKeyGenerator strengthMenuItemTitles]):
(-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
* WebCoreSupport/WebPlatformStrategies.mm:
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
* WebView/WebPDFView.mm:
(-[WebPDFView menuForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't try to capture crash logs on platforms that haven't implemented that feature
aroben@apple.com [Wed, 2 Mar 2011 19:45:35 +0000 (19:45 +0000)]
Don't try to capture crash logs on platforms that haven't implemented that feature

Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash

Reviewed by Joseph Pecoraro.

* Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Bail if we don't have a crash log glob.
(findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
strictly required to fix bug 55504, but seems worthwhile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocontent property doesn't support quotes
carol.szabo@nokia.com [Wed, 2 Mar 2011 19:34:00 +0000 (19:34 +0000)]
content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503

Patch by Carol Szabo <carol.szabo@nokia.com> on 2011-03-02
Reviewed by David Hyatt  <hyatt@apple.com>

Source/WebCore:

Added full support for quotes as defined by CSS 2.1.

Tests: fast/css/content/content-quotes-01.html
       fast/css/content/content-quotes-02.html
       fast/css/content/content-quotes-03.html
       fast/css/content/content-quotes-04.html
       fast/css/content/content-quotes-05.html
       fast/css/content/content-quotes-06.html

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):
* css/CSSParser.h:
Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.
* css/html.css:
(q:before):
(q:after):
replaced the '"' workaround with open/close-quote
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.
* rendering/RenderObject.h:
(WebCore::RenderObject::isQuote):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
Added support for Quote content.
* rendering/RenderQuote.cpp: Added.
(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::LanguageData::operator<):
(WebCore::defaultLanguageQuotes):
(WebCore::quotesMap):
(WebCore::quotesForLanguage):
(WebCore::defaultQuotes):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
* rendering/RenderQuote.h: Added.
(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):
* rendering/RenderingAllInOne.cpp:
Included RenderQuote.cpp
* rendering/style/StyleAllInOne.cpp:
Included QuotesData.cpp
* rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.
* rendering/style/ContentData.h:
(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):
* rendering/style/QuotesData.cpp: Added.
(WebCore::QuotesData::create):
(WebCore::QuotesData::operator==):
(WebCore::QuotesData::~QuotesData):
* rendering/style/QuotesData.h: Added.
(WebCore::QuotesData::data):
(WebCore::QuotesData::operator delete):
(WebCore::QuotesData::QuotesData):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setQuotes):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleAllInOne.cpp:
Added QuotesData.cpp to the included files list.
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.
* rendering/style/StyleRareInheritedData.h:
Added quotes

LayoutTests:

Added new tests for quotes. Fixed a few afected expected results.

* fast/css/content/content-quotes-01-expected.txt: Added.
* fast/css/content/content-quotes-01.html: Added.
* fast/css/content/content-quotes-02-expected.txt: Added.
* fast/css/content/content-quotes-02.html: Added.
* fast/css/content/content-quotes-03-expected.txt: Added.
* fast/css/content/content-quotes-03.html: Added.
* fast/css/content/content-quotes-04-expected.txt: Added.
* fast/css/content/content-quotes-04.html: Added.
* fast/css/content/content-quotes-05-expected.txt: Added.
* fast/css/content/content-quotes-05.html: Added.
* fast/css/content/content-quotes-06-expected.txt: Added.
* fast/css/content/content-quotes-06.html: Added.
* platform/mac/fast/css-generated-content/005-expected.txt:
* platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
* platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:
* platform/qt/fast/css-generated-content/005-expected.txt:
* platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
* platform/qt/fast/css-generated-content/no-openclose-quote-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSelector usage flags should not be set by the CSS parser
antti@apple.com [Wed, 2 Mar 2011 19:08:45 +0000 (19:08 +0000)]
Selector usage flags should not be set by the CSS parser
https://bugs.webkit.org/show_bug.cgi?id=55573

Reviewed by Dave Hyatt.

Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
we may parse stylesheets that are not actually used for document rendering. This is especially bad when
the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
triggered by complex selectors for no good reason.

- Use the selector traversal in style selector constructor to figure out which flags
  are actually needed for the currently active style sheets.
- Remove the selector flag related code from the CSS parser/grammar.
- Remove the usesDescendantRules flag completely. We have descendant rules in the default
  style sheet, every document uses them.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):
* css/CSSStyleSelector.cpp:
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::Features::Features):
(WebCore::CSSStyleSelector::Features::~Features):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
(WebCore::RuleSet::collectFeatures):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
* dom/Document.h:
(WebCore::Document::usesSiblingRules):
(WebCore::Document::setUsesSiblingRules):
(WebCore::Document::usesFirstLineRules):
(WebCore::Document::usesBeforeAfterRules):
(WebCore::Document::setUsesBeforeAfterRules):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWinCE build fix.
bweinstein@apple.com [Wed, 2 Mar 2011 18:57:14 +0000 (18:57 +0000)]
WinCE build fix.

* WebCoreSupport/PlatformStrategiesWinCE.h: Add a needed include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 18:52:38 +0000 (18:52 +0000)]
2011-03-02  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] svg/text/font-size-below-point-five.svg doesn't pass on mac release
        https://bugs.webkit.org/show_bug.cgi?id=55593

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWinCE build fix. Have PlatformStrategiesWinCE inherit from CookiesStrategy,
bweinstein@apple.com [Wed, 2 Mar 2011 18:52:07 +0000 (18:52 +0000)]
WinCE build fix. Have PlatformStrategiesWinCE inherit from CookiesStrategy,
and implement the needed methods.

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createCookiesStrategy):
(PlatformStrategiesWinCE::notifyCookiesChanged):
* WebCoreSupport/PlatformStrategiesWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix fallout from a last minute renaming.
bweinstein@apple.com [Wed, 2 Mar 2011 18:46:36 +0000 (18:46 +0000)]
Fix fallout from a last minute renaming.

* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Part of WebKit2: Need a way to send notifications to client when...
bweinstein@apple.com [Wed, 2 Mar 2011 18:44:50 +0000 (18:44 +0000)]
Source/WebCore: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add functions on CookieStorage that allow listening for changes in cookies. When
the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.

No change in behavior requiring tests.

* platform/CookiesStrategy.h: Added.
(WebCore::CookiesStrategy::~CookiesStrategy):

* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::cookiesStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):

* platform/network/CookieStorage.h: Add new function declarations.

* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
(WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
(WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
(WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.

* platform/network/mac/CookieStorageMac.mm:
(-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
(-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on
    the main thread.
(-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
(-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
(WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
(WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.

Add new file.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.

Source/WebKit/mac: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Mac WebKit1.

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

Source/WebKit/qt: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Qt WebKit1.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):
* WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Windows WebKit1.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):
* WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit2: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::dispatchDidModifyCookies): Add a stub with a FIXME to send a
    message to the UI process.

* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createCookiesStrategy):
(WebKit::WebPlatformStrategies::notifyCookiesChanged): Call WebCookieManager::dispatchDidModifyCookies.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>
jschuh@chromium.org [Wed, 2 Mar 2011 18:42:22 +0000 (18:42 +0000)]
2011-03-02  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
        https://bugs.webkit.org/show_bug.cgi?id=55488

        Test: fast/css/css-keyframe-parent.html

        * css/WebKitCSSKeyframesRule.cpp:
        (WebCore::WebKitCSSKeyframesRule::append):
2011-03-02  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
        https://bugs.webkit.org/show_bug.cgi?id=55488

        * fast/css/css-keyframe-parent-expected.txt: Added.
        * fast/css/css-keyframe-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 2 Mar 2011 18:03:02 +0000 (18:03 +0000)]
2011-03-02  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add support for external protocol handlers
        https://bugs.webkit.org/show_bug.cgi?id=55473

        Do not unconditionally create and replace the SoupRequester of the
        SoupSession if there is already one. No new tests needed as we
        just allow clients to create their our SoupRequesters.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ensureSessionIsInitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 2 Mar 2011 17:50:57 +0000 (17:50 +0000)]
2011-03-02  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by jknotten@chromium.org.

        Fix build-breakage when GEOLOCATION not enabled.
        https://bugs.webkit.org/show_bug.cgi?id=55586

        Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
        is not true.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 2 Mar 2011 17:39:48 +0000 (17:39 +0000)]
2011-03-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
        https://bugs.webkit.org/show_bug.cgi?id=55575

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::inspectedNode):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluateOn):
        (WebCore::InjectedScript::wrapObject):
        (WebCore::InjectedScript::wrapNode):
        (WebCore::InjectedScript::inspectNode):
        (WebCore::InjectedScript::nodeAsScriptValue):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::addInspectedNode):
        (WebCore::InjectedScriptHost::clearInspectedNodes):
        (WebCore::InjectedScriptHost::copyText):
        (WebCore::InjectedScriptHost::inspectedNode):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::addInspectedNode):
        (WebCore::InspectorDOMAgent::resolveNode):
        (WebCore::InspectorDOMAgent::injectedScriptForNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
        (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
        (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.resolveNode):
        (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
        (WebInspector.RemoteObject.prototype.evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some new tests to the WebKit2 Skipped file
aroben@apple.com [Wed, 2 Mar 2011 17:28:44 +0000 (17:28 +0000)]
Add some new tests to the WebKit2 Skipped file

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-16 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 2 Mar 2011 17:15:42 +0000 (17:15 +0000)]
2011-02-16  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Dmitry Titov.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Ensure that all geolocation permission requests are cancelled
        when the page is detached from its frame.

        * fast/dom/Geolocation/iframe-reparent-expected.txt: Added.
        * fast/dom/Geolocation/iframe-reparent.html: Added.
        * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
        * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
        * fast/dom/Geolocation/resources/iframe-reparent-page-iframe.html: Added.
        * fast/dom/Geolocation/resources/iframe-reparent-page.html: Added.
        * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
        * fast/dom/Geolocation/script-tests/iframe-reparent.js: Added.
        (window2Loaded):
        (firstWatchUpdate):
        (secondWatchUpdate):
        (firstWatchError):
        (secondWatchError):
        (maybeFinish):
        * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
        * platform/gtk/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/Skipped:
2011-01-21  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Dmitry Titov.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        On Page destruction, any outstanding Geolocation permission
        requests should be cancelled, because the Geolocation can only
        access the client indirectly via m_frame->page().

        Additionally, if the Frame is reparented to another page, the
        Geolocation should cancel watches, single-shots and requests on
        the old page.

        Page destruction is signalled by a call to the
        Frame::pageDestroyed() method. This calls Frame::detachFromPage,
        where we extend the call chain to Geolocation::detachFromPage()
        where we call Geolocation::reset() which detaches from the
        GeolocationController, cancels requests, watches and single shots,
        and sets the permission state back to Unknown.

        We also now call detachFromPage when the frame reparented in
        Frame::transferChildFrameToNewDocument.

        Frame::pageDestroyed() is also called by FrameLoader even though
        the page is not destroyed. We should still cancel permission
        requests, because the GeolocationClient will become inaccessible
        to the Geolocation object after this call.

        Since GeolocationController is owned by Page, and all Geolocation
        objects will now unsubscribe from the GeolocationController on
        pageDetached(), we no longer need to call stopUpdating() from the
        GeolocationController's destructor. Instead we can simply assert
        that there should be no no observers. See related bug
        https://bugs.webkit.org/show_bug.cgi?id=52216 .

        Introduced new method 'numberOfPendingPermissionRequests' on
        GeolocationClientMock to count the number of outstanding pending
        permission requests. This provides a reusable implementation for
        client-based implementations of the LayoutTestController's
        numberOfPendingGeolocationPermissionRequests method.

        Tests: fast/dom/Geolocation/iframe-reparent.html
               fast/dom/Geolocation/page-reload-cancel-permission-requests.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resetGeolocationPermissions):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::detachFromPage):
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::transferChildFrameToNewDocument):
        * page/Frame.h:
        * page/Geolocation.cpp:
        (WebCore::Geolocation::~Geolocation):
        (WebCore::Geolocation::page):
        (WebCore::Geolocation::reset):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::requestPermission):
        (WebCore::Geolocation::startUpdating):
        (WebCore::Geolocation::stopUpdating):
        * page/Geolocation.h:
        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
        * page/Navigator.cpp:
        (WebCore::Navigator::resetGeolocationPermissions):
        * page/Navigator.h:
        * platform/mock/GeolocationClientMock.cpp:
        (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
        * platform/mock/GeolocationClientMock.h:
2011-01-26  John Knottenbelt  <jknotten@chromium.org>

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Add accessors to the WebGeolocationClientMock to allow the number of
        pending geolocation permission requests to be queried.

        * public/WebGeolocationClientMock.h:
        * src/WebGeolocationClientMock.cpp:
        (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
2011-01-26  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Dmitry Titov.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Extend the layout test controller to expose the number of pending
        geolocation requests, so that we can test that the requests have
        been cancelled on page close.

        * DumpRenderTree/LayoutTestController.cpp:
        (numberOfPendingGeolocationPermissionRequestsCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/UIDelegate.h:
        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Martin Maly <mmaly@chromium.org>
commit-queue@webkit.org [Wed, 2 Mar 2011 17:11:10 +0000 (17:11 +0000)]
2011-03-02  Martin Maly  <mmaly@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Expectation updates for strict mode V8 features.
        https://bugs.webkit.org/show_bug.cgi?id=55538

        * platform/chromium/fast/js/mozilla/strict/15.10.7-expected.txt: Added.
        * platform/chromium/fast/js/mozilla/strict/15.3.5.1-expected.txt: Added.
        * platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Another rebaseline.
antonm@chromium.org [Wed, 2 Mar 2011 17:04:55 +0000 (17:04 +0000)]
Unreviewed.  Another rebaseline.

*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
*    platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
*    platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 2 Mar 2011 16:57:01 +0000 (16:57 +0000)]
2011-03-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] support in mac video fullscreen controller
        https://bugs.webkit.org/show_bug.cgi?id=52280

        Factored the code to configure the video overlay in a new private
        method of the controller and added GStreamer support to it.

        * WebView/WebVideoFullscreenController.h:
        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController setupVideoOverlay:]):
        (-[WebVideoFullscreenController windowDidLoad]):
        (-[WebVideoFullscreenController setMediaElement:WebCore::]):
        (-[WebVideoFullscreenController windowDidExitFullscreen]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 2 Mar 2011 16:45:37 +0000 (16:45 +0000)]
2011-03-02  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
        https://bugs.webkit.org/show_bug.cgi?id=55563

        This part adds implementations for data grids used to display
        different heap snapshots projections. We are almost done.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * bindings/v8/ScriptHeapSnapshot.cpp:
        (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
        * bindings/v8/ScriptHeapSnapshot.h:
        * inspector/Inspector.idl:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        (MixInSnapshotNodeFunctions):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotSortableDataGrid):
        (WebInspector.HeapSnapshotConstructorsDataGrid):
        (WebInspector.HeapSnapshotDiffDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid):
        (WebInspector.HeapSnapshotRetainingPathsList):
        (WebInspector.DetailedHeapshotView.profileCallback):
        (WebInspector.DetailedHeapshotView):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
        (WebInspector.HeapSnapshotEdge.prototype.toString):
        (WebInspector.HeapSnapshot.prototype._init):
        (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
        (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
        (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
        * inspector/front-end/Images/helpButtonGlyph.png: Added.
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.reset):
        * inspector/front-end/Popover.js:
        (WebInspector.Popover):
        (WebInspector.Popover.prototype.show):
        (WebInspector.Popover.prototype.hide):
        (WebInspector.Popover.prototype.get visible):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype.getProfile):
        * inspector/front-end/heapProfiler.css:
        * inspector/front-end/inspector.js:
        (WebInspector.resetFocusElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 16:30:50 +0000 (16:30 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another unreviewed Chromium rebaselines for r80121.

        * platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 16:14:20 +0000 (16:14 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Another unreviewed Chromium rebaselines for r80121.

        * platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt: Added.
        * platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 2 Mar 2011 16:01:41 +0000 (16:01 +0000)]
2011-03-02  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
        https://bugs.webkit.org/show_bug.cgi?id=55478

        On case insensitive systems the generated forwarding headers cause build problems.

        * Source/WebKit.pri: Adjust INCLUDEPATH for the project.
2011-03-02  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
        https://bugs.webkit.org/show_bug.cgi?id=55478

        On case insensitive systems the generated forwarding headers cause build problems.

        * Scripts/generate-forwarding-headers.pl: The generated header should
        also contain the framework name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip a crashing test on Windows
aroben@apple.com [Wed, 2 Mar 2011 15:54:55 +0000 (15:54 +0000)]
Skip a crashing test on Windows

<http://webkit.org/b/55069> tracks the failure.

* platform/win/Skipped: Added fast/text/international/text-combine-parser-test.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 2 Mar 2011 15:44:04 +0000 (15:44 +0000)]
Unreviewed.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

Remove unnecessary Qt specific expected result.

* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 15:36:53 +0000 (15:36 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines for r80121; Added the failing expectation for
        editing/input/setting-input-value-cancel-ime-composition.html due to the bug 55560.

        * platform/chromium/test_expectations.txt:
        * platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Updated.
        * platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Ditto.
        * platform/chromium-win/editing/ [...]: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 15:07:43 +0000 (15:07 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed GTK rebaselines for r80121; Also skip editing/input/setting-input-value-cancel-ime-composition.html
        because GTK port doesn't implement textInputController.hasMarkedText().

        * platform/gtk/Skipped:
        * platform/gtk/editing/ [...]: Updated.
        * platform/gtk/fast/dom/delete-contents-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to force a clean build on the Windows bots
aroben@apple.com [Wed, 2 Mar 2011 15:01:39 +0000 (15:01 +0000)]
Try to force a clean build on the Windows bots

Some of the bots are running into bogus linker errors due to MSVC's "minimal rebuild"
feature not rebuilding files it should. See <http://queues.webkit.org/results/8076907> for
an example.

* win/tools/vsprops/common.vsprops: Touched to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 2 Mar 2011 14:52:31 +0000 (14:52 +0000)]
2011-03-01  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Expose some selection state fields in WKPage
        https://bugs.webkit.org/show_bug.cgi?id=55541

        Added WKPageCanDelete(), WKPageHasSelectedRange(), and WKPageIsContentEditable() so we can enable some
        Edit menu items properly on Windows when using WebKit2.

        * UIProcess/API/C/WKPage.cpp:
        (WKPageCanDelete): Added.
        (WKPageHasSelectedRange): Added.
        (WKPageIsContentEditable): Added.
        * UIProcess/API/C/WKPage.h: Added new functions.
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::canDelete): Added.
        (WebKit::WebPageProxy::hasSelectedRange): Added.
        (WebKit::WebPageProxy::isContentEditable): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp
ddkilzer@apple.com [Wed, 2 Mar 2011 14:47:38 +0000 (14:47 +0000)]
<webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp

Reviewed by Darin Adler.

Change "#if GL_APPLE_vertex_array_object" macros to check that
GL_APPLE_vertex_array_object is both defined and non-zero.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
empty #else clause.
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
return check.  Remove #else clause that would never have
compiled (since array is not a WTF::String).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 2 Mar 2011 14:45:44 +0000 (14:45 +0000)]
Unreviewed.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

Update Qt specific expected results after r80121.

* platform/qt/Skipped: Add editing/input/setting-input-value-cancel-ime-composition.html because of missing feature.
* platform/qt/editing/ [...] : Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip new test added in r80121 on Windows
aroben@apple.com [Wed, 2 Mar 2011 14:40:04 +0000 (14:40 +0000)]
Skip new test added in r80121 on Windows

It depends on textInputController, which DRT doesn't have on Windows.

* platform/win/Skipped: Added editing/input/setting-input-value-cancel-ime-composition.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 13:57:53 +0000 (13:57 +0000)]
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Assertion failure after removing a selection in keydown handler
        https://bugs.webkit.org/show_bug.cgi?id=51389

        Added tests to ensure WebKit updates offset properly when deleting date
        to editing/selection/character-data-mutation.html.

        Added a test to ensure WebKit clears composition marks inside an input
        element when the value is set programatically.

        Many tests are rebaselined due to selection changed caused by the patch
        and additional respondToChangedSelection calls.

        * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
        * editing/deleting/delete-by-word-001-expected.txt:
        * editing/deleting/delete-by-word-002-expected.txt:
        * editing/deleting/delete-ligature-001-expected.txt:
        * editing/deleting/delete-ligature-002-expected.txt:
        * editing/deleting/delete-ligature-003-expected.txt:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/deleting/skip-virama-001-expected.txt:
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/hilitecolor-expected.txt:
        * editing/execCommand/outdent-nested-lists-1-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/input/setting-input-value-cancel-ime-composition-expected.txt: Added.
        * editing/input/setting-input-value-cancel-ime-composition.html: Added.
        * editing/inserting/insert-thai-characters-001-expected.txt:
        * editing/pasteboard/copy-in-password-field-expected.txt:
        * editing/pasteboard/paste-into-anchor-text-expected.txt:
        * editing/selection/character-data-mutation-expected.txt:
        * editing/selection/character-data-mutation.html:
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/style-3690704-fix-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/undo/redo-style-expected.txt:
        * platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
        * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
        * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-and-undo-expected.txt:
        * platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-br-007-expected.txt:
        * platform/mac/editing/deleting/delete-character-001-expected.txt:
        * platform/mac/editing/deleting/delete-hr-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-listitem-001-expected.txt:
        * platform/mac/editing/deleting/delete-listitem-002-expected.txt:
        * platform/mac/editing/deleting/delete-selection-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-002-expected.txt:
        * platform/mac/editing/deleting/delete-tab-003-expected.txt:
        * platform/mac/editing/deleting/delete-tab-004-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/deleting/list-item-1-expected.txt:
        * platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt:
        * platform/mac/editing/deleting/whitespace-pre-1-expected.txt:
        * platform/mac/editing/execCommand/find-after-replace-expected.txt:
        * platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/mac/editing/execCommand/paste-1-expected.txt:
        * platform/mac/editing/execCommand/paste-2-expected.txt:
        * platform/mac/editing/input/5576619-expected.txt:
        * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
        * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
        * platform/mac/editing/input/text-input-controller-expected.txt:
        * platform/mac/editing/inserting/4278698-expected.txt:
        * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
        * platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
        * platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/mac/editing/inserting/insert-br-003-expected.txt:
        * platform/mac/editing/inserting/insert-br-006-expected.txt:
        * platform/mac/editing/inserting/insert-br-007-expected.txt:
        * platform/mac/editing/inserting/insert-br-008-expected.txt:
        * platform/mac/editing/inserting/insert-br-009-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-006-expected.txt:
        * platform/mac/editing/inserting/insert-div-007-expected.txt:
        * platform/mac/editing/inserting/insert-div-008-expected.txt:
        * platform/mac/editing/inserting/insert-div-024-expected.txt:
        * platform/mac/editing/inserting/insert-div-025-expected.txt:
        * platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/mac/editing/inserting/insert-tab-003-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
        * platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
        * platform/mac/editing/inserting/redo-expected.txt:
        * platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
        * platform/mac/editing/inserting/typing-001-expected.txt:
        * platform/mac/editing/inserting/typing-002-expected.txt:
        * platform/mac/editing/inserting/typing-003-expected.txt:
        * platform/mac/editing/inserting/typing-around-br-001-expected.txt:
        * platform/mac/editing/inserting/typing-around-image-001-expected.txt:
        * platform/mac/editing/pasteboard/4076267-2-expected.txt:
        * platform/mac/editing/pasteboard/4076267-3-expected.txt:
        * platform/mac/editing/pasteboard/4076267-expected.txt:
        * platform/mac/editing/pasteboard/4700297-expected.txt:
        * platform/mac/editing/pasteboard/8145-3-expected.txt:
        * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/mac/editing/pasteboard/cut-text-001-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/mac/editing/pasteboard/interchange-newline-2-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-2-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-4-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-5-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-list-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-table-expected.txt:
        * platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
        * platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
        * platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
        * platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-pre-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-002-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-004-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-005-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-008-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-009-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:
        * platform/mac/editing/pasteboard/pasting-object-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
        * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
        * platform/mac/editing/selection/replace-selection-1-expected.txt:
        * platform/mac/editing/selection/select-all-iframe-expected.txt:
        * platform/mac/editing/spelling/spelling-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
        * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
        * platform/mac/editing/style/smoosh-styles-001-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-001-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-002-expected.txt:
        * platform/mac/editing/style/style-boundary-002-expected.txt:
        * platform/mac/editing/style/style-boundary-003-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.txt:
        * platform/mac/editing/style/typing-style-001-expected.txt:
        * platform/mac/editing/style/typing-style-002-expected.txt:
        * platform/mac/editing/style/unbold-in-bold-expected.txt:
        * platform/mac/editing/undo/4063751-expected.txt:
        * platform/mac/editing/undo/redo-typing-001-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:
        * platform/mac/editing/undo/undo-misspellings-expected.txt:
        * platform/mac/editing/undo/undo-typing-001-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-before-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-before-expected.txt:
        * platform/mac/fast/dom/delete-contents-expected.txt:
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Assertion failure after removing a selection in keydown handler
        https://bugs.webkit.org/show_bug.cgi?id=51389

        The bug was caused by textWillBeReplaced's not always updating selection, and
        shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
        at the end of replaced data.

        Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
        to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
        to setSelection instead of directly modifying m_selection to notify all the clients.
        Namely, the call to EditorClient::respondToChangedSelection is required for
        setting-input-value-cancel-ime-composition.html.

        Note that we must update layout before calling setSelection because setSelection calls
        setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
        such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.

        Test: editing/input/setting-input-value-cancel-ime-composition.html

        * editing/SelectionController.cpp:
        (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset
        of the selection end must be updated even if it was at the end of the replaced text.
        e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
        "hello  WebK[it". Note we don't move the offset if no text is removed because appending
        "world" to "hello ]" should result in "hello ]world" not "hello world]".
        (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update
        the selection instead of modifying m_selection directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 2 Mar 2011 13:48:03 +0000 (13:48 +0000)]
2011-03-02  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Replaced 2 tests in GTK Skipped list that were skipped by mistake
        by the ones that are actually failing.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Wed, 2 Mar 2011 13:46:04 +0000 (13:46 +0000)]
2011-03-02  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
        https://bugs.webkit.org/show_bug.cgi?id=54675

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._syncScroll):
        (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorGutterPanel):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set readOnly):
        (WebInspector.TextEditorMainPanel.prototype._getSelection):
        (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
        * inspector/front-end/textViewer.css:
        (.inner-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 13:14:52 +0000 (13:14 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; added the missing blank line at the end.

        * platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Oleg Romashin <romaxa@gmail.com>
commit-queue@webkit.org [Wed, 2 Mar 2011 13:02:02 +0000 (13:02 +0000)]
2011-03-02  Oleg Romashin  <romaxa@gmail.com>

        Reviewed by Andreas Kling.

        Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
        https://bugs.webkit.org/show_bug.cgi?id=55477

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::populateScriptObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 2 Mar 2011 13:00:46 +0000 (13:00 +0000)]
2011-03-02  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Adding 3 new tests to the skipped list waiting for better viewport
        error/warning messages.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 2 Mar 2011 12:41:18 +0000 (12:41 +0000)]
2011-03-02  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaselines for r80061.

        * platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Wed, 2 Mar 2011 12:35:18 +0000 (12:35 +0000)]
2011-03-02  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Rebaseline after r80061 and r80107.

        * platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
        * platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 2 Mar 2011 12:27:07 +0000 (12:27 +0000)]
Unreviewed.

REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323

Add Qt specific expected result for test introduced in r79934.

* platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
* platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
* platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnd another attempt to do proper GPU override.
antonm@chromium.org [Wed, 2 Mar 2011 12:18:06 +0000 (12:18 +0000)]
And another attempt to do proper GPU override.

*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Another attempt to propertly rebaseling GPU variant of fast/canvas/canva...
antonm@chromium.org [Wed, 2 Mar 2011 11:55:59 +0000 (11:55 +0000)]
Unreviewed.  Another attempt to propertly rebaseling GPU variant of fast/canvas/canvas-strokePath-gradient-shadow.html

*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselining for Chromium after http://trac.webkit.org/changeset/80061/
antonm@chromium.org [Wed, 2 Mar 2011 11:48:57 +0000 (11:48 +0000)]
Unreviewed.  Rebaselining for Chromium after trac.webkit.org/changeset/80061/

*    platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
*    platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
*    platform/chromium-win/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Remove invalid suppression.
antonm@chromium.org [Wed, 2 Mar 2011 11:45:48 +0000 (11:45 +0000)]
Unreviewed.  Remove invalid suppression.

*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Joseph Pecoraro <joepeck@webkit.org>
sergio@webkit.org [Wed, 2 Mar 2011 11:42:57 +0000 (11:42 +0000)]
2011-03-02  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed expectations update. This is a follow-up to r80061.

        Viewport tests were expected to produce new error, warning,
        and tip console messages. The current output is correct,
        but many of the warnings are wrong. Fixing the incorrect
        warnings will be handled by:
        https://bugs.webkit.org/show_bug.cgi?id=53707

        There are also a number of xsl tests that have extra warnings
        in qt when "Running an XSL-T 1.0 stylesheet with a 2.0 processor".
        These tests now have qt platform specific results.

        * fast/viewport/viewport-100-expected.txt:
        * fast/viewport/viewport-101-expected.txt:
        * fast/viewport/viewport-102-expected.txt:
        * fast/viewport/viewport-103-expected.txt:
        * fast/viewport/viewport-112-expected.txt:
        * fast/viewport/viewport-115-expected.txt:
        * fast/viewport/viewport-116-expected.txt:
        * fast/viewport/viewport-117-expected.txt:
        * fast/viewport/viewport-121-expected.txt:
        * fast/viewport/viewport-122-expected.txt:
        * fast/viewport/viewport-125-expected.txt:
        * fast/viewport/viewport-129-expected.txt:
        * fast/viewport/viewport-29-expected.txt:
        * fast/viewport/viewport-30-expected.txt:
        * fast/viewport/viewport-31-expected.txt:
        * fast/viewport/viewport-32-expected.txt:
        * fast/viewport/viewport-35-expected.txt:
        * fast/viewport/viewport-36-expected.txt:
        * fast/viewport/viewport-38-expected.txt:
        * fast/viewport/viewport-39-expected.txt:
        * fast/viewport/viewport-40-expected.txt:
        * fast/viewport/viewport-41-expected.txt:
        * fast/viewport/viewport-42-expected.txt:
        * fast/viewport/viewport-43-expected.txt:
        * fast/viewport/viewport-44-expected.txt:
        * fast/viewport/viewport-46-expected.txt:
        * fast/viewport/viewport-47-expected.txt:
        * fast/viewport/viewport-48-expected.txt:
        * fast/viewport/viewport-49-expected.txt:
        * fast/viewport/viewport-52-expected.txt:
        * fast/viewport/viewport-53-expected.txt:
        * fast/viewport/viewport-54-expected.txt:
        * fast/viewport/viewport-55-expected.txt:
        * fast/viewport/viewport-61-expected.txt:
        * fast/viewport/viewport-62-expected.txt:
        * fast/viewport/viewport-63-expected.txt:
        * fast/viewport/viewport-64-expected.txt:
        * fast/viewport/viewport-66-expected.txt:
        * fast/viewport/viewport-67-expected.txt:
        * fast/viewport/viewport-68-expected.txt:
        * fast/viewport/viewport-69-expected.txt:
        * fast/viewport/viewport-70-expected.txt:
        * fast/viewport/viewport-71-expected.txt:
        * fast/viewport/viewport-72-expected.txt:
        * fast/viewport/viewport-73-expected.txt:
        * fast/viewport/viewport-74-expected.txt:
        * fast/viewport/viewport-75-expected.txt:
        * fast/viewport/viewport-76-expected.txt:
        * fast/viewport/viewport-77-expected.txt:
        * fast/viewport/viewport-78-expected.txt:
        * fast/viewport/viewport-79-expected.txt:
        * fast/viewport/viewport-80-expected.txt:
        * fast/viewport/viewport-81-expected.txt:
        * fast/viewport/viewport-83-expected.txt:
        * fast/viewport/viewport-85-expected.txt:
        * fast/viewport/viewport-90-expected.txt:
        * platform/qt/fast/events/xsl-onload-expected.txt: Added.
        * platform/qt/fast/parser/xslt-with-html-expected.txt: Added.
        * platform/qt/fast/xsl/document-function-expected.txt:
        * platform/qt/fast/xsl/subframe-location-expected.txt: Added.
        * platform/qt/fast/xsl/transform-to-html-expected.txt: Added.
        * platform/qt/fast/xsl/utf8-chunks-expected.txt: Added.
        * platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt: Added.
        * platform/qt/fast/xsl/xslt-doc-noenc-expected.txt: Added.
        * platform/qt/fast/xsl/xslt-entity-enc-expected.txt: Added.
        * platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
        * platform/qt/fast/xsl/xslt-recursion-expected.txt: Added.
        * platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
        * platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
        * platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:
        * platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
        * platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreivewed. Temporary disabling fast/canvas/canvas-strokePath-gradient-shadow.html
antonm@chromium.org [Wed, 2 Mar 2011 11:35:28 +0000 (11:35 +0000)]
Unreivewed.  Temporary disabling fast/canvas/canvas-strokePath-gradient-shadow.html

*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 11:13:15 +0000 (11:13 +0000)]
2011-03-02  Kent Tamura  <tkent@chromium.org>

        Unreviewed, a trivial fix for r80096.

        REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
        https://bugs.webkit.org/show_bug.cgi?id=55562

        * platform/chromium/test_expectations.txt:
2011-03-02  Kent Tamura  <tkent@chromium.org>

        Unreviewed, a trivial fix for r80096.

        REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
        https://bugs.webkit.org/show_bug.cgi?id=55562

        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse()
          to reject strings with a valid number + extra letters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 10:02:19 +0000 (10:02 +0000)]
2011-03-02  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:
          Mark fast/forms/input-number-unacceptable-style.html as TEXT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 2 Mar 2011 09:49:39 +0000 (09:49 +0000)]
2011-03-02  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        JObjectWrapper should be moved to its own file
        https://bugs.webkit.org/show_bug.cgi?id=55384

        No new tests, refactoring only.

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bridge/jni/v8/JNIBridgeV8.cpp:
        (JavaField::JavaField):
        * bridge/jni/v8/JNIBridgeV8.h:
        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::JavaInstance):
        * bridge/jni/v8/JavaInstanceV8.h:
        * bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
        (JobjectWrapper::JobjectWrapper):
        (JobjectWrapper::~JobjectWrapper):
        * bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
        (JSC::Bindings::JobjectWrapper::instance):
        (JSC::Bindings::JobjectWrapper::setInstance):
        (JSC::Bindings::JobjectWrapper::ref):
        (JSC::Bindings::JobjectWrapper::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-25 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 2 Mar 2011 09:40:17 +0000 (09:40 +0000)]
2011-02-25  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: factor search logic out of inspector.js
        https://bugs.webkit.org/show_bug.cgi?id=54965

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.switchToAndFocus):
        (WebInspector.ElementsPanel.prototype._updateMatchesCount):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.searchCanceled):
        (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.searchCanceled):
        (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
        (WebInspector.ScriptsPanel.prototype.performSearch):
        * inspector/front-end/SearchController.js: Added.
        (WebInspector.SearchController):
        (WebInspector.SearchController.prototype.updateSearchMatchesCount):
        (WebInspector.SearchController.prototype.updateSearchLabel):
        (WebInspector.SearchController.prototype.cancelSearch):
        (WebInspector.SearchController.prototype.handleShortcut):
        (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
        (WebInspector.SearchController.prototype.activePanelChanged):
        (WebInspector.SearchController.prototype._updateSearchMatchesCount):
        (WebInspector.SearchController.prototype._focusSearchField):
        (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
        (WebInspector.SearchController.prototype._onKeyDown):
        (WebInspector.SearchController.prototype._onSearch):
        (WebInspector.SearchController.prototype._performSearch):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.set currentPanel):
        (WebInspector.set attached):
        (WebInspector.doLoadedDone):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 09:22:41 +0000 (09:22 +0000)]
2011-03-02  Kent Tamura  <tkent@chromium.org>

        Unreviewed.

        Update a test and test expectation for r80096.

        * fast/forms/input-number-unacceptable-style-expected.txt:
        * fast/forms/input-number-unacceptable-style.html:
          ICU seems to accept "-1+" as a number.  So change it to "-1a".
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Mar 2011 08:47:33 +0000 (08:47 +0000)]
2011-03-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Teach JavaScriptCore GYP build how to build minidom
        https://bugs.webkit.org/show_bug.cgi?id=55536

        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFEMorphologyElement changes doesn't require relayout
reni@webkit.org [Wed, 2 Mar 2011 08:40:07 +0000 (08:40 +0000)]
FEMorphologyElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55462

Reviewed by Andreas Kling.

When the FEMorphologyElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.

* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::setMorphologyOperator):
(WebCore::FEMorphology::setRadiusX):
(WebCore::FEMorphology::setRadiusY):
* platform/graphics/filters/FEMorphology.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):
* svg/SVGFEMorphologyElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Anna Cavender <annacc@chromium.org>
commit-queue@webkit.org [Wed, 2 Mar 2011 07:34:22 +0000 (07:34 +0000)]
2011-03-01  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Remove playing of video in media/video-replaces-poster.html and update text results.
        https://bugs.webkit.org/show_bug.cgi?id=54910

        * media/video-replaces-poster-expected.txt: Added.
        * media/video-replaces-poster.html:
        * platform/chromium-win/media/video-replaces-poster-expected.txt: Removed.
        * platform/gtk/media/video-replaces-poster-expected.txt: Removed.
        * platform/mac/media/video-replaces-poster-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 07:04:18 +0000 (07:04 +0000)]
2011-03-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails when a form validation bubble appears
        https://bugs.webkit.org/show_bug.cgi?id=55550

        * fast/forms/interactive-validation-attach-assertion-expected.txt: Added.
        * fast/forms/interactive-validation-attach-assertion.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails when a form validation bubble appears
        https://bugs.webkit.org/show_bug.cgi?id=55550

        Test: fast/forms/interactive-validation-attach-assertion.html

        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::buildBubbleTree):
         Just remove unnecessary attach().
2011-03-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails when a form validation bubble appears
        https://bugs.webkit.org/show_bug.cgi?id=55550

        Test: fast/forms/interactive-validation-attach-assertion.html

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo): Enable the interactive validation feature by
          default. This matches to Chromium browser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport localized numbers in <input type=number>
tkent@chromium.org [Wed, 2 Mar 2011 06:54:56 +0000 (06:54 +0000)]
Support localized numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42484

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change adds support of localized numbers in <input type=number>.
This affects only the UI, and not HTMLInputElement::value.

- Remove the keyboard input restriction feature because it is hard to
  retrieve characters usable for localized numbers in ICU.

- Separate convertFromVisibleValue() from sanitizeValue().
  sanitizeValue() is used for not only converting a renderer value to a
  DOM value.

- Implement LocalizedNumber functions for ICU and NSNumberFormatter.
  It is used only in Chromium for now.

Test: manual-tests/input-number-localization.html

* WebCore.gypi: Use LocalizedNumberICU.cpp.
* WebCore.xcodeproj/project.pbxproj:
  Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
* dom/InputElement.h: Introduce convertFromVisibleValue().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::convertFromVisibleValue):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::convertFromVisibleValue):
* html/InputType.h:
* html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
  isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
  remove the keyboard input restriction feature for type=number.
(WebCore::NumberInputType::convertFromVisibleValue):
(WebCore::NumberInputType::sanitizeValue):
* html/NumberInputType.h:
* manual-tests/input-number-localization.html: Add a manual test because
  the behavior depends on the current locale.
* platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
* platform/text/LocalizedNumberICU.cpp:
  Implement LocalizedNumber functions with ICU NumberFormat.
(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
* platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
* platform/text/mac/LocalizedNumberMac.mm:
  Implement LocalizedNumber functions with NSNumberFormatter.
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::convertFromVisibleValue):
  Implemented as a function doing nothing.

LayoutTests:

Update an existing test because of removing the keyboard input
restriction feature.

* fast/forms/input-number-keyoperation-expected.txt:
* fast/forms/script-tests/input-number-keyoperation.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 2 Mar 2011 06:28:45 +0000 (06:28 +0000)]
2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        Remove efl port style exception of Webcore/JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=55549

        WebCore and JavaScriptCore need to adhere WebKit coding style.

        * Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Mar 2011 06:14:11 +0000 (06:14 +0000)]
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        JavaScriptCore GYP build should copy some headers into the target framework
        https://bugs.webkit.org/show_bug.cgi?id=55524

        After this patch, all the framework headers are exported as public
        headers.  We need to teach GYP how to handle private headers.

        I struggled to determine how to store the information about whether a
        header was public, private, or project (i.e., not exported).
        Generally, the GYPI should just list the files, but it seemed siliy to
        have an almost duplicated list of files in the GYP file itself.  If
        this design doesn't scale, we might have to revisit it in the future.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 2 Mar 2011 06:08:32 +0000 (06:08 +0000)]
2011-03-01  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] clean up temp files on chromium-mac builder too
        https://bugs.webkit.org/show_bug.cgi?id=55525

        * BuildSlaveSupport/chromium/remove-crash-logs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 2 Mar 2011 06:06:10 +0000 (06:06 +0000)]
2011-03-01  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r78383): Failure to connect on websocketstest.com
        https://bugs.webkit.org/show_bug.cgi?id=54811

        After r78383, KURL::setPort() no longer appends ":port" part
        if that port is the default port for URL scheme. This broke
        SocketStreamHandleCFNet, whose code was based on an assumption
        that KURL::setPort() always inserts ":port" part.

        To fix this, KURL::port() call is removed from SocketStreamHandle
        and the port number is calculated on-the-fly.

        Unfortunately it is impossible to write a test; this bug only
        affects WebSockets connecting to the default port (port 80
        for ws, port 443 for wss), while we use different ports to test
        WebSockets in LayoutTests.

        * platform/network/cf/SocketStreamHandle.h:
        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::SocketStreamHandle):
        (WebCore::SocketStreamHandle::createStreams):
        (WebCore::SocketStreamHandle::port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Victoria Kirst <vrk@chromium.org>
commit-queue@webkit.org [Wed, 2 Mar 2011 05:49:16 +0000 (05:49 +0000)]
2011-03-01  Victoria Kirst  <vrk@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] videos are not painted for compositing/ tests
        https://bugs.webkit.org/show_bug.cgi?id=54694

        Videos are now painted for compositing tests. This patch uploads the
        expected layout results and enables the tests again.

        * platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum: Added.
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png: Added.
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png: Added.
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png: Added.
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png: Added.
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum: Added.
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.png: Added.
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Mar 2011 04:44:13 +0000 (04:44 +0000)]
2011-02-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        wrap json in a function call to afford cross-domain loading
        https://bugs.webkit.org/show_bug.cgi?id=55353

        Also delete the code that compacts the JSON. It turns out this
        breaks the rebaseline tool and is probably a premature optimization anyways.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHide the typeinfo name symbols for std::exception and std::bad_alloc too.
mrowe@apple.com [Wed, 2 Mar 2011 04:25:55 +0000 (04:25 +0000)]
Hide the typeinfo name symbols for std::exception and std::bad_alloc too.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 04:21:07 +0000 (04:21 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed expectations update. This is a follow-up to r80061.

        Leopard has a slightly different error message, so
        platform/mac-leopard needs its own expected results for the
        websocket test. Added platform specific expected results for
        the other tests which are consistently failing with an extra
        console message on the bots.

        * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
        * platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
        * platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 David Grogan <dgrogan@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 03:57:56 +0000 (03:57 +0000)]
2011-03-01  David Grogan  <dgrogan@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: public webkit interfaces for firing versionchange events to IDBDatabase objects
        https://bugs.webkit.org/show_bug.cgi?id=55548

        * WebKit.gyp:
        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::createObjectStore):
        (WebKit::WebIDBDatabase::open):
        * public/WebIDBDatabaseCallbacks.h: Added.
        (WebKit::WebIDBDatabaseCallbacks::~WebIDBDatabaseCallbacks):
        (WebKit::WebIDBDatabaseCallbacks::onVersionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Wed, 2 Mar 2011 03:22:59 +0000 (03:22 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * wtf/Platform.h:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * features.gypi:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80079.
        http://trac.webkit.org/changeset/80079
        https://bugs.webkit.org/show_bug.cgi?id=55547

        "Broke the Win debug build?" (Requested by dcheng on #webkit).

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 03:14:59 +0000 (03:14 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed expectations update. This is expected
        behavior after r80061, which enabled printing
        of more console messages.

        * http/tests/xmlviewer/dumpAsText/wml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Build fix after removal of Frame::isContentEditable.
kevino@webkit.org [Wed, 2 Mar 2011 03:05:55 +0000 (03:05 +0000)]
[wx] Build fix after removal of Frame::isContentEditable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 2 Mar 2011 02:54:12 +0000 (02:54 +0000)]
2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80078.
        http://trac.webkit.org/changeset/80078
        https://bugs.webkit.org/show_bug.cgi?id=55545

        underlying change was rolled out (Requested by tonyg-cr on
        #webkit).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 02:45:23 +0000 (02:45 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed new baselines

        [chromium] Add expectations for new tests in r80049
        https://bugs.webkit.org/show_bug.cgi?id=55543

        * platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
        * platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
        * platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-25 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 2 Mar 2011 02:35:44 +0000 (02:35 +0000)]
2011-02-25  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Abstract "pixels with a graphics context" into its own class
        https://bugs.webkit.org/show_bug.cgi?id=55259

        This creates new PlatformCanvas/PlatformImage classes which wrap
        all of the #ifdef Skia/Cg warts from the compositor.  All classes
        (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
        modified to use these abstractions.

        Tests: LayoutTests/compositing

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::updateTexture):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        (WebCore::ImageLayerChromium::updateTextureIfNeeded):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Added.
        (WebCore::PlatformCanvas::PlatformCanvas):
        (WebCore::PlatformCanvas::~PlatformCanvas):
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
        (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
        (WebCore::PlatformCanvas::Painter::Painter):
        (WebCore::PlatformCanvas::Painter::~Painter):
        * platform/graphics/chromium/PlatformCanvas.h: Added.
        (WebCore::PlatformCanvas::AutoLocker::pixels):
        (WebCore::PlatformCanvas::Painter::context):
        (WebCore::PlatformCanvas::size):
        * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
        (WebCore::PlatformImage::PlatformImage):
        (WebCore::PlatformImage::updateFromImage):
        * platform/graphics/chromium/PlatformImage.h: Added.
        (WebCore::PlatformImage::pixels):
        (WebCore::PlatformImage::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: Add verification scripts to WebKit2 project and fix the issues they...
mrowe@apple.com [Wed, 2 Mar 2011 02:24:24 +0000 (02:24 +0000)]
Source/WebKit2: Add verification scripts to WebKit2 project and fix the issues they reveal.

Reviewed by Sam Weinig.

* Configurations/Base.xcconfig: Add linker flags to prevent C++ standard
library functions from being exported as weak externals.
* Configurations/WebKit2.xcconfig: Inherit linker flags from the project level.
* Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem): Use DEFINE_STATIC_LOCAL.
* UIProcess/WebPageGroup.cpp:
(WebKit::webPageGroupMap): Ditto.
* WebKit2.xcodeproj/project.pbxproj: Don't copy .in files in to the framework.
Run verification scripts at the appropriate times.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didBeginEditing): Use DEFINE_STATIC_LOCAL.
(WebKit::WebEditorClient::respondToChangedContents): Ditto.
(WebKit::WebEditorClient::respondToChangedSelection): Ditto.
(WebKit::WebEditorClient::didEndEditing): Ditto.
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::idToHistoryItemMap): Ditto.
(WebKit::historyItemToIDMap): Ditto.

Tools: Update verification scripts to handle WebKit2.

Reviewed by Sam Weinig.

* Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
* Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Wed, 2 Mar 2011 02:15:26 +0000 (02:15 +0000)]
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * wtf/Platform.h:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * features.pri:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * features.gypi:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * Scripts/build-webkit:
2011-03-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add feature define for data transfer items
        https://bugs.webkit.org/show_bug.cgi?id=55510

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 02:10:30 +0000 (02:10 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations

        [chromium] Skip new viewport tests added by r80068
        https://bugs.webkit.org/show_bug.cgi?id=55539

        LayoutTestController doesn't implement dumpConfigurationForViewport() which is needed for this test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 02:04:19 +0000 (02:04 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 02:02:28 +0000 (02:02 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        IDBKeyRange.bound() should not use the optional options object
        https://bugs.webkit.org/show_bug.cgi?id=55419

        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        * storage/indexeddb/objectstore-cursor.html:
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        IDBKeyRange.bound() should not use the optional options object
        https://bugs.webkit.org/show_bug.cgi?id=55419

        http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept

        Added some code to existing tests to cover these cases.

        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::bound):
        * storage/IDBKeyRange.h:
        * storage/IDBKeyRange.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mitz@apple.com [Wed, 2 Mar 2011 01:46:15 +0000 (01:46 +0000)]
Build fix.

* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Mar 2011 01:39:22 +0000 (01:39 +0000)]
2011-03-01  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Apply sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 01:30:22 +0000 (01:30 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed, missed updating a call to WebCore::computeViewportAttributes
        who's prototype changed.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::viewportAttributesForSize): pass in a value for the document argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 2 Mar 2011 01:23:44 +0000 (01:23 +0000)]
2011-03-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by James Robinson.

        V8 code generator doesn't properly support a single SerializedScriptValue attribute
        https://bugs.webkit.org/show_bug.cgi?id=55530

        This is tested by the bindings tests changes.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
        (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
        (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
        (WebDOMTestSerializedScriptValueInterface::operator=):
        (WebDOMTestSerializedScriptValueInterface::impl):
        (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
        (WebDOMTestSerializedScriptValueInterface::value):
        (toWebCore):
        (toWebKit):
        * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
        (WebKit::kit):
        (webkit_dom_test_serialized_script_value_interface_get_value):
        (WebKit::core):
        (webkit_dom_test_serialized_script_value_interface_finalize):
        (webkit_dom_test_serialized_script_value_interface_set_property):
        (webkit_dom_test_serialized_script_value_interface_get_property):
        (webkit_dom_test_serialized_script_value_interface_constructed):
        (webkit_dom_test_serialized_script_value_interface_class_init):
        (webkit_dom_test_serialized_script_value_interface_init):
        (WebKit::wrapTestSerializedScriptValueInterface):
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
        (WebCore::JSTestInterface::JSTestInterface):
        * bindings/scripts/test/JS/JSTestInterface.h:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
        (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
        (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::JSTestObjConstructor::JSTestObjConstructor):
        (WebCore::JSTestObj::JSTestObj):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
        (WebCore::jsTestObjPrototypeFunctionSerializedValue):
        (WebCore::jsTestObjPrototypeFunctionIdbKey):
        (WebCore::jsTestObjPrototypeFunctionOptionsObject):
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
        (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
        (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
        (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
        (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
        (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
        (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
        (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
        (WebCore::jsTestSerializedScriptValueInterfaceValue):
        (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
        (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
        (WebCore::toJS):
        (WebCore::toTestSerializedScriptValueInterface):
        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
        (WebCore::JSTestSerializedScriptValueInterface::createStructure):
        (WebCore::JSTestSerializedScriptValueInterface::impl):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
        (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
        (-[DOMTestSerializedScriptValueInterface dealloc]):
        (-[DOMTestSerializedScriptValueInterface finalize]):
        (-[DOMTestSerializedScriptValueInterface value]):
        (core):
        (kit):
        * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
        * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
        * bindings/scripts/test/V8/V8TestInterface.cpp:
        (WebCore::ConfigureV8TestInterfaceTemplate):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
        (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
        (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
        (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
        (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
        (WebCore::V8TestSerializedScriptValueInterface::derefObject):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
        (WebCore::V8TestSerializedScriptValueInterface::toNative):
        (WebCore::V8TestSerializedScriptValueInterface::wrap):
        (WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 01:23:39 +0000 (01:23 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update

        [chromium] Expectations updates from r80061
        https://bugs.webkit.org/show_bug.cgi?id=55533

        * platform/chromium-linux/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
        * platform/chromium-linux/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
        * platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 2 Mar 2011 01:23:00 +0000 (01:23 +0000)]
2011-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Joseph Pecoraro.

        Misaligned memory access in CloneDeserializer on all ARM arch.
        https://bugs.webkit.org/show_bug.cgi?id=48742

        Add a CPU class for architectures that need aligned addresses
        for memory access.

        * wtf/Platform.h:
2011-03-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Joseph Pecoraro.

        Misaligned memory access in CloneDeserializer on all ARM arch.
        https://bugs.webkit.org/show_bug.cgi?id=48742

        Push platforms that need aligned memory access down the
        endian independent serialization and deserialization
        paths.

        * bindings/js/SerializedScriptValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Helder Correia <helder@sencha.com>
helder@sencha.com [Wed, 2 Mar 2011 01:16:30 +0000 (01:16 +0000)]
2011-03-01  Helder Correia  <helder@sencha.com>

        Unreviewed Qt skipped tests update.

        The manually committed patch didn't include the update to
        fast/canvas/canvas-strokePath-gradient-shadow.html by mistake:
        No shadow when stroking a path with a gradient
        https://bugs.webkit.org/show_bug.cgi?id=55436

        * platform/qt/Skipped: Skip new test since it fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 2 Mar 2011 00:59:59 +0000 (00:59 +0000)]
2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        Added tests specifically to test Console warnings.

        * fast/viewport/viewport-warnings-1.html: Added.
        * fast/viewport/viewport-warnings-2.html: Added.
        * fast/viewport/viewport-warnings-3.html: Added.
        * fast/viewport/viewport-warnings-4.html: Added.
        * fast/viewport/viewport-warnings-5.html: Added.
        * fast/viewport/viewport-warnings-6.html: Added.
        * fast/viewport/viewport-warnings-7.html: Added.

2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport Warning/Error Messages Are Now Inaccurate
        https://bugs.webkit.org/show_bug.cgi?id=53707

        Correct and improve the error messages for viewport
        parsing. Clarify the difference between incorrect
        keys, values, and when to use the device-width or
        device-height constants.

        * dom/ViewportArguments.cpp:
        (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
        (WebCore::numericPrefix):
        (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
        (WebCore::setViewportFeature): report a warning for an unrecognized key.
        (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
        (WebCore::viewportErrorMessageLevel):
        * dom/ViewportArguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Mar 2011 00:56:50 +0000 (00:56 +0000)]
2011-03-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WKPluginSiteDataManagerClearAllSiteData is not working
        https://bugs.webkit.org/show_bug.cgi?id=55528
        <rdar://problem/9071823>

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryGetSitesWithData):
        Remove version checks, checking that the function pointer is not null is enough.

        (WebKit::NetscapePluginModule::tryClearSiteData):
        Remove version checks, checking that the function pointer is not null is enough.
        Also, correctly convert a null String to a null CString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 2 Mar 2011 00:50:30 +0000 (00:50 +0000)]
2011-03-01  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed baseline

        [chromium] Add baseline for test added by r80040
        https://bugs.webkit.org/show_bug.cgi?id=55529

        * platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum: Added.
        * platform/chromium-mac/fast/table/table-and-parts-outline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Mar 2011 00:47:56 +0000 (00:47 +0000)]
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add pre- and post-build actions for JavaScriptCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=55507

        After this patch, we have all the steps for building the main
        JavaScriptCore framework except the "copy headers" step, which I'll do
        next.

        * gyp/JavaScriptCore.gyp:
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add pre- and post-build actions for JavaScriptCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=55507

        Remove the portion of this file that was split out into common.gypi.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80065 268f45cc-cd09-0410-ab3c-d52691b4dbfc