WebKit-https.git
10 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 09:44:42 +0000 (09:44 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Shinichiro Hamaji.

        wdiff_text throws ScriptError because wdiff returns non-zero when files differ
        https://bugs.webkit.org/show_bug.cgi?id=38246

        wdiff returns 0 when files are the same, 1 when they differ.
        run_command by default raises ScriptError if the return code is non-zero.
        Fixed this by adding a custom error handler which only raises if the
        return code is not 1.

        I broke up the huge wdiff_text() method into little pieces
        for easier unit testing.  There is only one functional change here
        and that is the addition of the custom error handler.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
ukai@chromium.org [Wed, 28 Apr 2010 09:21:59 +0000 (09:21 +0000)]
Unreviewed build fix.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest): too few arguments for format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSC's currentThreadStackBase is not reentrant on some platforms
hausmann@webkit.org [Wed, 28 Apr 2010 09:06:20 +0000 (09:06 +0000)]
JSC's currentThreadStackBase is not reentrant on some platforms
https://bugs.webkit.org/show_bug.cgi?id=37195

Patch by Simon Hausmann  <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28
Reviewed by Darin Adler.

This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.

This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.

* runtime/Collector.cpp:
(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix compilation with gcc 3.4.
hausmann@webkit.org [Wed, 28 Apr 2010 08:55:07 +0000 (08:55 +0000)]
Fix compilation with gcc 3.4.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor

* wtf/text/AtomicStringImpl.h:
(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.
* wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] WINS DEF file freeze
hausmann@webkit.org [Wed, 28 Apr 2010 08:31:59 +0000 (08:31 +0000)]
[Qt] WINS DEF file freeze

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28
Reviewed by Simon Hausmann <simon.hausmann@nokia.com>

Updated WINSCW def file with added and removed symbols.

* symbian/bwins/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix detection of Qt 4.7's multimedia libraries
hausmann@webkit.org [Wed, 28 Apr 2010 08:29:03 +0000 (08:29 +0000)]
[Qt] Fix detection of Qt 4.7's multimedia libraries

Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:49:12 +0000 (07:49 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed attempt to fix the chromium build.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Apr 2010 07:47:12 +0000 (07:47 +0000)]
2010-04-28  Daniel Bates  <dbates@rim.com>

        Unreviewed, rebase expected result of failing test.

        Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
        Following the landing of bug #37686, this test started failing despite
        being unrelated to this bug. From looking at the diff of the result,
        which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
        comment, we have decided to rebase this result.

        * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebView drawing code may access null backing store dirty region
sfalken@apple.com [Wed, 28 Apr 2010 07:33:09 +0000 (07:33 +0000)]
WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)

Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:30:16 +0000 (07:30 +0000)]
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Now we can test media queries with the new function because the
        render tree has the color information of the box.

        Note that the pixel test is currently failing. We'll need another
        patch to enable printing mode for pixel tests.

        * platform/mac/Skipped:
        * platform/mac/printing/media-queries-print-expected.checksum: Added.
        * platform/mac/printing/media-queries-print-expected.png: Added.
        * platform/mac/printing/media-queries-print-expected.txt: Added.
        * printing/media-queries-print.html:
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Added RenderAsTextPrintingMode as a behavior of externalRepresentation.

        Now ~PrintContext() calls end() automatically.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::~PrintContext):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):
        * rendering/RenderTreeAsText.h:
        (WebCore::):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setPrintingCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::isPrinting):
        (LayoutTestController::setIsPrinting):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 07:09:09 +0000 (07:09 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parsePage):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 06:45:35 +0000 (06:45 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dimitri Glazkov.

        Enhance CSS parser for Paged Media (Iteration 3)
        Implement size parameter parsing for Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35851

        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dimitri Glazkov.

        Enhance CSS parser for Paged Media (Iteration 3)
        Implement size parameter parsing for Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35851

        I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
        (2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
        Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseSize):
        (WebCore::CSSParser::parseSizeParameter):
        * css/CSSParser.h:
        (WebCore::CSSParser::):
        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 06:19:36 +0000 (06:19 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 2)
        Parse and hold paged media rules in CSSStyleSelector.

        fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.

        https://bugs.webkit.org/show_bug.cgi?id=35782

        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        * printing/page-rule-css-text-expected.txt: Added.
        * printing/page-rule-css-text.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 2)
        Parse and hold paged media rules in CSSStyleSelector.

        https://bugs.webkit.org/show_bug.cgi?id=35782

        Test: printing/page-rule-css-text.html

        * css/CSSGrammar.y:
        * css/CSSPageRule.cpp:
        (WebCore::CSSPageRule::CSSPageRule):
        (WebCore::CSSPageRule::selectorText):
        * css/CSSPageRule.h:
        (WebCore::CSSPageRule::create):
        (WebCore::CSSPageRule::isPageRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createPageRule):
        * css/CSSStyleRule.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::getPageRules):
        (WebCore::CSSRuleSet::CSSRuleSet):
        (WebCore::CSSRuleSet::~CSSRuleSet):
        (WebCore::CSSRuleSet::addPageRule):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/CSSStyleSelector.h:
        * css/StyleBase.h:
        (WebCore::StyleBase::isPageRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 06:00:03 +0000 (06:00 +0000)]
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Fix bug that prevents autosave of forms without action attribute
        https://bugs.webkit.org/show_bug.cgi?id=38014
        Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
        It needs a native unit test, which would go in the Chromium repo, not WebKit.

        * src/WebPasswordFormData.cpp:
        (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Apr 2010 05:42:51 +0000 (05:42 +0000)]
2010-04-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=37686

        Fixes an issue where the canvas method strokeRect will stroke a
        rectangle whose dimensions are 0 when lineWidth > 1.

        As per the definition of strokeRect in the HTML Canvas 2D Context
        spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
        this method should have no effect when both the height and width
        are zero.

        Tests: fast/canvas/canvas-clearRect.html
               fast/canvas/canvas-fillRect.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::validateRectForCanvas): Return false if height, width == 0.
2010-04-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=37686

        Tests that strokeRect does not paint any artifacts when the
        specified rectangle has height, width = 0 and lineWidth > 1.

        Also tests that clearRect, fillRect, and rect are ignored when
        height, width = 0.

        * fast/canvas/canvas-clearRect-expected.txt: Added.
        * fast/canvas/canvas-clearRect.html: Added.
        * fast/canvas/canvas-fillRect-expected.txt: Added.
        * fast/canvas/canvas-fillRect.html: Added.
        * fast/canvas/canvas-modify-emptyPath-expected.txt:
        * fast/canvas/canvas-strokeRect-expected.txt: Updated results.
        * fast/canvas/script-tests/canvas-clearRect.js: Added.
        * fast/canvas/script-tests/canvas-fillRect.js: Added.
        * fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
        * fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added
        debug statements so as to distinguish the results for each test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Michael Nordman <michaeln@google.com>
eric@webkit.org [Wed, 28 Apr 2010 05:40:23 +0000 (05:40 +0000)]
2010-04-27  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        [Chromium] Add two things to the webkit API to support appcaches in workers.
        1) WebURLRequest TargetTypes for worker and shared worker main resources.
        2) Factory method on class WebCommonWorkerClient to
           createApplicationCacheHost() for the associated worker.

        https://bugs.webkit.org/show_bug.cgi?id=38147

        * public/WebCommonWorkerClient.h: add the factory method
        * public/WebURLRequest.h: add the TargetTypes
        * src/WebWorkerBase.cpp: call the embedder's factory when needed
        (WebKit::WebWorkerBase::didCreateDataSource)
        (WebKit::WebWorkerBase::createApplicationCacheHost)
        * src/WebWorkerBase.h: ditto
        * src/WebWorkerClientImpl.h: add a stub impl of the factory method
        (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
2010-04-27  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        [Chromium] Add two things to the webkit API to support appcaches in workers.
        1) WebURLRequest TargetTypes for worker and shared worker main resources.
        2) Factory method on class WebCommonWorkerClient to
           createApplicationCacheHost() for the associated worker.

        https://bugs.webkit.org/show_bug.cgi?id=38147

        * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method
        (TestWebWorker::createApplicationCacheHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 05:31:03 +0000 (05:31 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove obsolete custom bindings file
        https://bugs.webkit.org/show_bug.cgi?id=38223

        We don't need these files anymore because they are empty.

        * Android.jscbindings.mk:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAbstractWorkerCustom.cpp: Removed.
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDocumentFragmentCustom.cpp: Removed.
        * bindings/js/JSEventSourceCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Daniel Cheng <dcheng@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 05:21:33 +0000 (05:21 +0000)]
2010-04-27  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
        https://bugs.webkit.org/show_bug.cgi?id=38227

        Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
        since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
        For now, we hack around the problem in the Chromium platform, but the proper long term
        solution is to change DragController::performDrag to check dragData::asFilenames().

        No new tests.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::getData):
        (WebCore::ClipboardChromium::types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 28 Apr 2010 04:53:19 +0000 (04:53 +0000)]
2010-04-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Enable Windows project generation
        https://bugs.webkit.org/show_bug.cgi?id=38103

        - Avoid platform.system(), which causes a crash with python.exe in
          depot_tools. Use sys.platform instead.
        - Process DumpRenderTree.gyp on all platforms.

        * gyp_webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 04:49:41 +0000 (04:49 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        run-bindings-tests doesn't work in an SVN checkout
        https://bugs.webkit.org/show_bug.cgi?id=38225

        Previously detect_scm_system needed an absolute path for SVN.  Now we
        accept a relative path.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 28 Apr 2010 04:20:55 +0000 (04:20 +0000)]
2010-04-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by the inimitable Dan Bernstein.

        SVG as background image renders incorrectly after zooming
        https://bugs.webkit.org/show_bug.cgi?id=38215

        When doing a partial redraw of an SVGImage used as a CSS background
        image, we're limited to drawing the entire Frame, clipped to the dirty rect.
        Because of this, we need to fix up the CTM so that the origin is at the
        top left of the unclipped image, rather than the top left of the
        portion being redrawn.

        Test: fast/images/svg-background-partial-redraw.html

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 03:42:15 +0000 (03:42 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Retry of: Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
        * fast/css/parsing-page-rule.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Retry of: Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        Test: fast/css/parsing-page-rule.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::createPageRule):
        (WebCore::CSSParser::createMarginAtRule):
        (WebCore::CSSParser::startDeclarationsForMarginBox):
        (WebCore::CSSParser::endDeclarationsForMarginBox):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out my changes as it rendered the Qt bot unreliable.
jchaffraix@webkit.org [Wed, 28 Apr 2010 03:37:30 +0000 (03:37 +0000)]
Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.

WebCore:

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):

LayoutTests:

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jchaffraix@webkit.org [Wed, 28 Apr 2010 03:08:17 +0000 (03:08 +0000)]
Unreviewed.

* platform/qt/Skipped: Add the 2 newly added test cases to the list
as they involve preflight requests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
jchaffraix@webkit.org [Wed, 28 Apr 2010 02:44:39 +0000 (02:44 +0000)]
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
       http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 02:29:23 +0000 (02:29 +0000)]
2010-04-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Makes clicking a select element close its associated popup if
        it is open.
        https://bugs.webkit.org/show_bug.cgi?id=38105

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 02:08:35 +0000 (02:08 +0000)]
2010-04-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Merged the WebView public method to close suggestion popups
        into a single method to close all popups (select and suggestions).
        That ensures select popups are closed when the browser window is moved
        or resized.
        https://bugs.webkit.org/show_bug.cgi?id=37837

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::hidePopups):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAlways build WebKit2 when building on SnowLeopard and later.
weinig@apple.com [Wed, 28 Apr 2010 01:45:21 +0000 (01:45 +0000)]
Always build WebKit2 when building on SnowLeopard and later.

Reviewed by Stephanie Lewis.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38238
weinig@apple.com [Wed, 28 Apr 2010 01:28:34 +0000 (01:28 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework

Reviewed by Maciej Stachowiak.

WebCore:

* Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.

WebKit2:

* Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't
need to set WebCore as a sub_umbrella of WebKit2, since we are not
reexporting any of its symbols.

WebKitTools:

* Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
WebCore for WebKit2, it is no longer necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
dumi@chromium.org [Wed, 28 Apr 2010 01:24:12 +0000 (01:24 +0000)]
WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
* platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

The expectations changed because of AUTO_VACUUM's overhead.

* platform/chromium/test_expectations.txt:
* storage/quota-tracking-expected.txt:
* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 28 Apr 2010 01:19:29 +0000 (01:19 +0000)]
2010-04-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Adler.

        Remove unnecessary header now that Chrome is updated
        https://bugs.webkit.org/show_bug.cgi?id=38211

        * public/win/WebThemeEngine.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 28 Apr 2010 01:15:29 +0000 (01:15 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix a typo in chromium.py that causes NRWT to fail in --verbose
        mode in a Chromium checkout.
        https://bugs.webkit.org/show_bug.cgi?id=38234

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 01:09:40 +0000 (01:09 +0000)]
2010-04-27  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Turn all of the touch event handlers into RuntimeEnabledFeatures, and
        modify the createEvent methond on Document so that it won't create a
        TouchEvent if the feature is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=37485

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::touchEnabled):
        (WebCore::RuntimeEnabledFeatures::setTouchEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchendEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Document.idl:
        * dom/Element.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:55:06 +0000 (00:55 +0000)]
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add some notifications and an accessor to WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=37625

        * dom/Node.cpp:
        (WebCore::Node::hasNonEmptyBoundingBox): New method.
        * dom/Node.h:
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add some notifications and an accessor to WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=37625

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didFirstLayout):
        (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
        * public/WebNode.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
        (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
        * src/WebElement.cpp:
        * src/WebNode.cpp:
        (WebKit::WebNode::hasNonEmptyBoundingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 00:41:17 +0000 (00:41 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] update test expectations for ancient linux bug
        https://bugs.webkit.org/show_bug.cgi?id=38229

        According to
        http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
        this hasn't crashed in a long time, so the CRASH annotation is superfluous.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:38:04 +0000 (00:38 +0000)]
2010-04-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Fix gyp build on Mac OS X with enable_svg=0.
        https://bugs.webkit.org/show_bug.cgi?id=38192

        * WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Darin Fisher <darin@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:28:28 +0000 (00:28 +0000)]
2010-04-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Remove deprecated form of didChangeLocationWithinPage
        https://bugs.webkit.org/show_bug.cgi?id=38178

        * public/WebFrameClient.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2010-04-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Remove deprecated form of didChangeLocationWithinPage
        https://bugs.webkit.org/show_bug.cgi?id=38178

        Switch over to implementing didNavigateWithinPage.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (TestWebViewDelegate::didNavigateWithinPage):
        (WebViewHost::didChangeLocationWithinPage):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Tiger build.
slewis@apple.com [Tue, 27 Apr 2010 23:56:17 +0000 (23:56 +0000)]
Fix Tiger build.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Carve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 23:42:07 +0000 (23:42 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Unreviewed.

        Adding myself to commmitters list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove more files I didn't intend to commit
slewis@apple.com [Tue, 27 Apr 2010 23:25:03 +0000 (23:25 +0000)]
Remove more files I didn't intend to commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 27 Apr 2010 23:24:21 +0000 (23:24 +0000)]
2010-04-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
        https://bugs.webkit.org/show_bug.cgi?id=38207

        No new tests.

        * WebCore.gyp/scripts/action_derivedsourcesallinone.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert Files I didn't intend to commit
slewis@apple.com [Tue, 27 Apr 2010 23:19:44 +0000 (23:19 +0000)]
Revert Files I didn't intend to commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 François Sausset <sausset@gmail.com>
eric@webkit.org [Tue, 27 Apr 2010 23:13:03 +0000 (23:13 +0000)]
2010-04-27  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Additional MathML mroot & msqrt tests.
        https://bugs.webkit.org/show_bug.cgi?id=37044

        * mathml/presentation/roots.xhtml: Added.
        * platform/mac/mathml/presentation/roots-expected.checksum: Added.
        * platform/mac/mathml/presentation/roots-expected.png: Added.
        * platform/mac/mathml/presentation/roots-expected.txt: Added.
2010-04-27  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Implementation of the MathML mroot & msqrt elements.
        https://bugs.webkit.org/show_bug.cgi?id=37044

        Test: mathml/presentation/roots.xhtml

        * WebCore.xcodeproj/project.pbxproj:
        * css/mathml.css:
        (mroot):
        (mroot > * + *):
        (mroot > * + mrow, mroot > * + mfenced):
        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::createRenderer):
        * mathml/RenderMathMLRoot.cpp: Added.
        (WebCore::RenderMathMLRoot::RenderMathMLRoot):
        (WebCore::RenderMathMLRoot::addChild):
        (WebCore::RenderMathMLRoot::paint):
        (WebCore::RenderMathMLRoot::layout):
        * mathml/RenderMathMLRoot.h: Added.
        * mathml/RenderMathMLSquareRoot.cpp: Added.
        (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
        (WebCore::RenderMathMLSquareRoot::paint):
        (WebCore::RenderMathMLSquareRoot::layout):
        * mathml/RenderMathMLSquareRoot.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Tue, 27 Apr 2010 23:02:55 +0000 (23:02 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Create new baseline for caret-rtl-2
        https://bugs.webkit.org/show_bug.cgi?id=38126

        http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
        test to start failing under Chromium.  Since we're the only ones who
        run pixel tests, it's possible that the actual baseline needs to be updated
        and not just the chromium baseline...but I'm not sure.

        I'm tracking the overall progress of figuring this out here:
        https://bugs.webkit.org/show_bug.cgi?id=38109

        * platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoI noticed an unused forwarding header.
darin@apple.com [Tue, 27 Apr 2010 22:56:54 +0000 (22:56 +0000)]
I noticed an unused forwarding header.

Reviewed by Maciej Stachowiak.

* ForwardingHeaders/runtime/PropertyMap.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
slewis@apple.com [Tue, 27 Apr 2010 22:55:22 +0000 (22:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.

Reviewed by Geoff Garen.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Apr 2010 22:51:27 +0000 (22:51 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
        https://bugs.webkit.org/show_bug.cgi?id=38153

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 22:48:31 +0000 (22:48 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Unreviewed, making the bots happy.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        Check in a baseline for Mac pulled from the bots.

        * platform/mac/fast/text/international/bold-bengali-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 22:04:42 +0000 (22:04 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58318.
        http://trac.webkit.org/changeset/58318
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Broke test on Tiger.  Might just need updated results,
        unclear.

        * http/tests/inspector/console-resource-errors-expected.txt: Removed.
        * http/tests/inspector/console-resource-errors.html: Removed.
        * http/tests/inspector/console-tests.js: Removed.
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontend_dumpConsoleMessages):
2010-04-27  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58318.
        http://trac.webkit.org/changeset/58318
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Broke test on Tiger.  Might just need updated results,
        unclear.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 21:53:54 +0000 (21:53 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        Add a layout test containing some bold Bengali text.

        * fast/text/international/bold-bengali.html: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        We must let Skia do font fallback, rather than picking a font name
        then handing that to Skia.  For example, if we have Bengali text and
        choose FreeSans + fake bold, and then later reuse the name, Skia will
        helpfully use FreeSansBold (which doesn't cover Bengali).

        Test: fast/text/international/bold-bengali.html

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        Roll forward Chrome DEPS so we get new Skia API.

        * DEPS: update Chrome to r45696.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Apr 2010 21:52:20 +0000 (21:52 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
        https://bugs.webkit.org/show_bug.cgi?id=38158

        Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
        and functions mixed in.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::adjustTextRenderMode):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::isCoordinateSkiaSafe):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 21:51:23 +0000 (21:51 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add test for NodeIterator prototype change behavior
        https://bugs.webkit.org/show_bug.cgi?id=38219

        In the process of remove the custom code from NodeIterator, we thought
        we fixed a subtle bug where iterating over nodes from another frame
        would get the wrong prototype chain.  This test documents that we
        didn't actually change the behavior and we still have the bug.

        * traversal/node-iterator-prototype-expected.txt: Added.
        * traversal/node-iterator-prototype.html: Added.
        * traversal/resources/node-iterator-prototype-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7911140> Hitting the "delete" key goes back twice
jhoneycutt@apple.com [Tue, 27 Apr 2010 21:35:45 +0000 (21:35 +0000)]
<rdar://problem/7911140> Hitting the "delete" key goes back twice

Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSending a package file using FormData crashes WebKit on Mac.
jianli@chromium.org [Tue, 27 Apr 2010 21:31:49 +0000 (21:31 +0000)]
Sending a package file using FormData crashes WebKit on Mac.
https://bugs.webkit.org/show_bug.cgi?id=37882

Reviewed by Darin Adler.

Can't add a layout test because DRT does not support generating the file name.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::navigateToDifferentDocument):
* platform/network/FormData.cpp:
(WebCore::FormData::appendDOMFormData):
* platform/network/FormData.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 27 Apr 2010 21:06:32 +0000 (21:06 +0000)]
2010-04-27  Ojan Vafai  <ojan@chromium.org>

        Unreviewed. Minor fix after goofup in http://trac.webkit.org/changeset/58331

        layoutTestController should have dumpAsMarkup
        https://bugs.webkit.org/show_bug.cgi?id=26501

        Forgot to reset the test results after doing the code review feedback
        of adding a newline.

        * editing/selection/dump-as-markup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 20:55:11 +0000 (20:55 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove custom NodeIterator bindings
        https://bugs.webkit.org/show_bug.cgi?id=38188

        Another example of CallWith=ScriptState.  This case shows us the right
        way to handle the interaction with exception codes.

        In my previous patch, I put the exception code handling after the
        ScriptState exception handling.  It turns out this was a mistake
        (although a harmless one at the time because no IDL caused us to
        generate that code).  Now that we're generating both kinds of exception
        handling, we need to generate them in the right order.

        * WebCore.gypi:
        * bindings/js/JSNodeIteratorCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_with_script_state_void_exception):
        (webkit_dom_test_obj_with_script_state_obj_exception):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj withScriptStateVoidException]):
        (-[DOMTestObj withScriptStateObjException]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::withScriptStateVoidCallback):
        (WebCore::TestObjInternal::withScriptStateObjCallback):
        (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback):
        (WebCore::TestObjInternal::withScriptStateObjExceptionCallback):
        (WebCore::):
        * bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
        * dom/NodeIterator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd comment about not using StringImpl::createCFString in WKStringCopyCFString.
weinig@apple.com [Tue, 27 Apr 2010 20:35:08 +0000 (20:35 +0000)]
Add comment about not using StringImpl::createCFString in WKStringCopyCFString.

Reviewed by Geoffrey Garen.

* UIProcess/API/C/cf/WKStringCF.cpp:
(WKStringCopyCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 27 Apr 2010 20:29:42 +0000 (20:29 +0000)]
2010-04-26  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        layoutTestController should have dumpAsMarkup
        https://bugs.webkit.org/show_bug.cgi?id=26501

        * editing/selection/dump-as-markup-expected.txt: Added.
        * editing/selection/dump-as-markup.html: Added.
        * resources/dump-as-markup.js: Added.
        (Markup.dump.get var):
        (Markup.dump.get catch):
        (Markup.dump):
        (Markup.waitUntilDone):
        (Markup.notifyDone):
        (Markup._spaces):
        (Markup._getAttributes):
        (Markup._getMarkupForTextNode):
        (Markup._getSelectionMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 20:26:16 +0000 (20:26 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove copy/paste addEventListener "custom" bindings via code generation
        https://bugs.webkit.org/show_bug.cgi?id=38210

        It's somewhat lame to special case addEventListener and
        removeEventListener in the code generator, but it saves a large amount
        of boilerplate "custom" bindings code.

        Idea shamelessly stolen from the V8 code generator.

        This patch points to some good refactoring opportunities in
        CodeGeneratorJS.pm, but I'm going to hold off on those for a future
        patch.  By generating test coverage for the code generator, we make
        these future refactorings easier.

        * bindings/js/JSAbstractWorkerCustom.cpp:
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        * bindings/js/JSDesktopNotificationsCustom.cpp:
        * bindings/js/JSEventSourceCustom.cpp:
        * bindings/js/JSMessagePortCustom.cpp:
        * bindings/js/JSNodeCustom.cpp:
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        * bindings/js/JSWebSocketCustom.cpp:
        * bindings/js/JSWorkerContextCustom.cpp:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionAddEventListener):
        (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj addEventListener:listener:useCapture:]):
        (-[DOMTestObj removeEventListener:listener:useCapture:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::addEventListenerCallback):
        (WebCore::TestObjInternal::removeEventListenerCallback):
        (WebCore::):
        * dom/MessagePort.idl:
        * dom/Node.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * notifications/Notification.idl:
        * page/EventSource.idl:
        * svg/SVGElementInstance.idl:
        * websockets/WebSocket.idl:
        * workers/AbstractWorker.idl:
        * workers/WorkerContext.idl:
        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestUpload.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 20:25:07 +0000 (20:25 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        run-bindings-tests should use --reset-results instead of --overwrite
        https://bugs.webkit.org/show_bug.cgi?id=38200

        As requested by Ojan.

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 20:22:22 +0000 (20:22 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION(r58261): webkit-patch edit-changelogs is broken
        https://bugs.webkit.org/show_bug.cgi?id=38204

        In 58261, we added code to abstract step that interrogates the squash
        and git_commit options, but it doesn't declare that it uses those
        options.  That means any command that doesn't happen to declare those
        options might be broken if it uses the cached_lookup mechanism.

        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/applypatch.py:
        * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
        * Scripts/webkitpy/tool/steps/build.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/closebug.py:
        * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
        * Scripts/webkitpy/tool/steps/commit.py:
        * Scripts/webkitpy/tool/steps/confirmdiff.py:
        * Scripts/webkitpy/tool/steps/createbug.py:
        * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
        * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
        * Scripts/webkitpy/tool/steps/obsoletepatches.py:
        * Scripts/webkitpy/tool/steps/postcodereview.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/update.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 20:16:01 +0000 (20:16 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
        https://bugs.webkit.org/show_bug.cgi?id=38212

        * Scripts/prepare-ChangeLog:
         - Pass --insecure to curl to work around CYGWIN missing certs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters
weinig@apple.com [Tue, 27 Apr 2010 20:05:50 +0000 (20:05 +0000)]
Remove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters
directly. StringImpl::createCFString only an optimization when called
from the thread that WebCore is running on, which is never the case for
WKStringCopyCFString. We should revisit this later, perhaps adding a
threadspecific allocator. We also now honor the passed in allocator.

Reviewed by Geoffrey Garen.

* UIProcess/API/C/cf/WKStringCF.cpp:
(WKStringCopyCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.
weinig@apple.com [Tue, 27 Apr 2010 19:51:25 +0000 (19:51 +0000)]
WebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.

Rubber-stamped by Beth Dakin.

* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):
* page/EventHandler.h:
* page/mac/DragControllerMac.mm:
* page/mac/EventHandlerMac.mm:
* platform/mac/PopupMenuMac.mm:

WebKitTools: It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
or WTF_USE_WEB_THREAD. Remove them.

Rubber-stamped by Beth Dakin.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Ben Murdoch <benm@google.com>
eric@webkit.org [Tue, 27 Apr 2010 19:45:30 +0000 (19:45 +0000)]
2010-04-27  Ben Murdoch  <benm@google.com>

        Reviewed by Simon Hausmann.

        The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
        https://bugs.webkit.org/show_bug.cgi?id=37609

        No new tests required, only updating documentation.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling
            the TouchStationary state as a result of discussions in bug 37609.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged Chris Jerdonek from committer to reviewer.
cjerdonek@webkit.org [Tue, 27 Apr 2010 19:44:20 +0000 (19:44 +0000)]
Changed Chris Jerdonek from committer to reviewer.

Reviewed by David Levin.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Tue, 27 Apr 2010 19:33:58 +0000 (19:33 +0000)]
2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
        https://bugs.webkit.org/show_bug.cgi?id=35834

        The scene should always have the size of the web view otherwhise it is
        possible to scroll the graphics view.

        * QtLauncher/webview.cpp:
        (WebViewGraphicsBased::resizeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Apr 2010 19:26:38 +0000 (19:26 +0000)]
2010-04-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler, Maciej Stachowiak.

        REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
        https://bugs.webkit.org/show_bug.cgi?id=38183

        Rather than sprinkle PLATFORM #ifdefs around, add a new method,
        RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
        an iframe with composited content should trigger compositing mode in the enclosing document
        (a behavior that differs between platforms).

        Use this new method to determine whether to trigger a style recalc in the parent document
        when an iframe becomes composited.

        Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().

        * manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
        * manual-tests/compositing/resources/flash-frame.html: Added.
        * manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode):
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent):
        (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
        * rendering/RenderLayerCompositor.h:
        * rendering/RenderView.cpp:
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
diegohcg@webkit.org [Tue, 27 Apr 2010 19:11:21 +0000 (19:11 +0000)]
Unreviewed.

Adding myself to committers.py

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Tue, 27 Apr 2010 18:47:44 +0000 (18:47 +0000)]
2010-04-27  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Moved console-tests.js to http tests. Added support for sorting
        console messages, in case order may vary.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        * http/tests/inspector/console-resource-errors-expected.txt: Added.
        * http/tests/inspector/console-resource-errors.html: Added.
        * http/tests/inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontend_dumpConsoleMessages):
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Removed.
2010-04-27  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Disable checking of mime-type consistency for failed resources.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Test: http/tests/inspector/console-resource-errors.html

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 27 Apr 2010 18:17:35 +0000 (18:17 +0000)]
2010-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add specialized thunks for a char code related string functions
        https://bugs.webkit.org/show_bug.cgi?id=38177

        This is a simple extension to my prior patch.  Basically hoist the
        existing character loading logic from the charCodeAt thunk and into
        a helper function, then add a helper to load strings from the small
        string cache.  This allows trivial implementations of fromCharCode
        and charAt.

        * create_hash_table:
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnJSCell):
        (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
        * jit/ThunkGenerators.cpp:
        (JSC::stringCharLoad):
        (JSC::charToString):
        (JSC::charCodeAtThunkGenerator):
        (JSC::charAtThunkGenerator):
        (JSC::fromCharCodeThunkGenerator):
        * jit/ThunkGenerators.h:
        * runtime/SmallStrings.h:
        (JSC::SmallStrings::singleCharacterStrings):
        * runtime/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 27 Apr 2010 17:58:56 +0000 (17:58 +0000)]
2010-04-27  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Fix XHR memory leak in GC controller.
        https://bugs.webkit.org/show_bug.cgi?id=38202

        http://trac.webkit.org/changeset/55798 simplified processing of
        active DOM objects but introduced a subtle bug in garbage
        collection of XHRs. ActiveDOMObject is not a direct base class of
        XHR and so upcasting changes pointer identity and breaks DOM
        maps. This leads to forever live persistent handles to XHR that
        had pending activity while V8 GC happened.

        * bindings/v8/V8GCController.cpp:
        (WebCore::GCEpilogueVisitor::visitDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 17:54:25 +0000 (17:54 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Regenerate reference bindings code generator output.

        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::withScriptStateVoidCallback):
        (WebCore::TestObjInternal::withScriptStateObjCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 17:50:03 +0000 (17:50 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
        https://bugs.webkit.org/show_bug.cgi?id=37987

        After further research, I believe the hang is caused by:
        http://bugs.python.org/issue2320
        Basically Popen() is not reentrant.
        The workaround is to pass close_fds=True to Popen() on Mac/Linux.

        I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
        when appropriate.

        I audited all places we call Popen() and either moved them to run_command
        or left a FIXME that they are not thread safe.  A few places I added the
        close_fds workaround there and left an explanitory note.

        * Scripts/webkitpy/common/checkout/scm_unittest.py:
         - Added note that this Popen use is not threadsafe.
        * Scripts/webkitpy/common/system/executive.py:
         - Fixed our Executive.run_* to workaround python bug 2320.
        * Scripts/webkitpy/common/system/user.py:
         _ Added note that this Popen use is not threadsafe.
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
        * Scripts/webkitpy/layout_tests/port/base.py:
         - Change wdiff back to using run_command now that we believe it
           to be threadsafe.
        * Scripts/webkitpy/layout_tests/port/chromium.py:
         - Fix to use Executive in places.
         - Pass self._executive down to the Driver for easier unit testing.
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
         - Re-factor to use a _kill_all method.
         - Made the _kill_all method use run_command to be threadsafe.
        * Scripts/webkitpy/layout_tests/port/http_server.py:
         - Add FIXME about using Executive.
        * Scripts/webkitpy/layout_tests/port/server_process.py:
         - Use Executive to be threadsafe.
        * Scripts/webkitpy/layout_tests/port/webkit.py:
         - Pass self._executive down to the Driver.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
         - Add note about Popen not being threadsafe.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
         - Move one caller to run_command add notes about moving others.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 27 Apr 2010 17:19:47 +0000 (17:19 +0000)]
2010-04-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Dan Bernstein.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        * fast/css/input-search-padding.html: Added.
        * platform/mac/fast/css/input-search-padding-expected.checksum: Added.
        * platform/mac/fast/css/input-search-padding-expected.png: Added.
        * platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Dan Bernstein.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        Test: fast/css/input-search-padding.html

        An <input type="search"> contains an inner block, which is explicitly
        centered in RenderTextControlSingleLine based on the height of the element.
        However, the clipping rect was not using the set location, and instead
        calculated off of the top border and padding alone. This also vertically
        centers the Caps Lock indicator.

        * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
        * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
        (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
        * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Andrey Kosyakov <caseq@chromium.org>
pfeldman@chromium.org [Tue, 27 Apr 2010 16:39:23 +0000 (16:39 +0000)]
2010-04-27  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Restore breakpoints associated with script's URL once
        script is parsed.
        https://bugs.webkit.org/show_bug.cgi?id=38132

        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.initUI):
        (devtools.DebuggerAgent.prototype.addBreakpoint):
        (devtools.DebuggerAgent.prototype.addScriptInfo_):
        (devtools.DebuggerAgent.prototype.restoreBreakpoints_):
        (devtools.BreakpointInfo):
        (devtools.BreakpointInfo.prototype.enabled):
        (devtools.BreakpointInfo.prototype.condition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 27 Apr 2010 14:48:19 +0000 (14:48 +0000)]
2010-04-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chrome Dev Tools: Further beautify themes.

        https://bugs.webkit.org/show_bug.cgi?id=38187

        * src/js/DevTools.js:
        (WebInspector.setToolbarColors):
        * src/js/devTools.css:
        (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.
hausmann@webkit.org [Tue, 27 Apr 2010 14:27:29 +0000 (14:27 +0000)]
[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

Disable thumb mode due to library size limitations, just like it's done
for the sbs/sbsv2 based build system.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec
hausmann@webkit.org [Tue, 27 Apr 2010 14:24:08 +0000 (14:24 +0000)]
[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec

Patch by Thomas Zander <t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

* JavaScriptCore.pri: It is necessary to specify the library search path
when linking against JavaScriptCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCompile fix for Visual Studio 2010
jocelyn.turcotte@nokia.com [Tue, 27 Apr 2010 13:56:53 +0000 (13:56 +0000)]
Compile fix for Visual Studio 2010
https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Simon Hausmann.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com>

* runtime/Structure.cpp:
(JSC::Structure::transitionTableAdd):
* wtf/MathExtras.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)
jocelyn.turcotte@nokia.com [Tue, 27 Apr 2010 13:56:19 +0000 (13:56 +0000)]
Rename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)

Reviewed by Simon Hausmann.

* config.h:
(JSC::Structure::transitionTableAdd):
* wtf/Assertions.h:
* wtf/Atomics.h:
* wtf/CurrentTime.h:
(WTF::getLocalTime):
* wtf/Platform.h:
* wtf/StaticConstructors.h:
* wtf/StringExtras.h:
* wtf/Vector.h:
(WTF::::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix Mac build break.
jocelyn.turcotte@nokia.com [Tue, 27 Apr 2010 13:55:36 +0000 (13:55 +0000)]
[Qt] Fix Mac build break.

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=37867
- Make sure JavaScriptCore's debug_and_release config follows that
  of WebCore.
- Use different name for JavaScriptCore target in debug and release
  since they might be written in the same path at the same time on
  parallel builds
- Consolidate the DESTDIR determination logic in JavaScriptCore.pri

* JavaScriptCore.pri:
* JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make sure WebKit is not compiled using C++0x.
jocelyn.turcotte@nokia.com [Tue, 27 Apr 2010 13:55:08 +0000 (13:55 +0000)]
[Qt] Make sure WebKit is not compiled using C++0x.
https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Kenneth Rohde Christiansen.

As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.

Patch by Thiago Macieira <thiago.macieira@nokia.com>

JavaScriptCore:

* JavaScriptCore.pro:

WebCore:

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 27 Apr 2010 12:56:59 +0000 (12:56 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed.  Previous disabling only did so via
        TIMEOUT failures.  Needs to ignore TEXT failures
        on quota-tracking.html as well.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 27 Apr 2010 12:05:49 +0000 (12:05 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed.  Disable quota-tracking in Chromium
        until Dumi can take a look.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 27 Apr 2010 11:18:59 +0000 (11:18 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed build fix.

        Revert 58274 and 58269 (WebSQLDatabase changes)
        https://bugs.webkit.org/show_bug.cgi?id=38191

        * storage/quota-tracking-expected.txt:
        * storage/quota-tracking.html:
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed build fix.

        Revert 58274 and 58269 (WebSQLDatabase changes)
        https://bugs.webkit.org/show_bug.cgi?id=38191

        Chromium bots are hitting ASSERTS when running layout tests.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::maximumSize):
        (WebCore::SQLiteDatabase::freeSpaceSize):
        * platform/sql/SQLiteDatabase.h:
        * platform/sql/SQLiteStatement.cpp:
        (WebCore::SQLiteStatement::prepare):
        * storage/Database.cpp:
        (WebCore::Database::performOpenAndVerify):
        * storage/Database.h:
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::postflightAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 10:54:45 +0000 (10:54 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, fix build breakage by reverting r58299.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Removed.
        * fast/css/parsing-page-rule.html: Removed.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, fix build breakage by reverting r58299.

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 09:53:27 +0000 (09:53 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
        This results in incorrect parsing.
        For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.

        https://bugs.webkit.org/show_bug.cgi?id=37787

        No new tests are added because the original behavior is accidentally OK.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::RareData::parseNth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 27 Apr 2010 09:35:16 +0000 (09:35 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
        * fast/css/parsing-page-rule.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        Test: fast/css/parsing-page-rule.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::lex):
        (WebCore::CSSParser::text):
        (WebCore::CSSParser::createPageRule):
        (WebCore::CSSParser::createMarginAtRule):
        (WebCore::CSSParser::startDeclarationsForMarginBox):
        (WebCore::CSSParser::endDeclarationsForMarginBox):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 09:12:18 +0000 (09:12 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove custom bindings for TreeWalker
        https://bugs.webkit.org/show_bug.cgi?id=38182

        This custom code is just CallWith=ScriptState.

        * WebCore.gypi:
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::markChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/TestObj.idl:
        * bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
        * dom/TreeWalker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 09:10:12 +0000 (09:10 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
        https://bugs.webkit.org/show_bug.cgi?id=38186

        Unfortunately, we don't have a good way of testing this change because
        our test coverage of the scm.py API is poor...

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 08:02:36 +0000 (08:02 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move code out of GenerateImplementation to make it more smaller
        https://bugs.webkit.org/show_bug.cgi?id=38176

        * bindings/scripts/CodeGeneratorJS.pm:
         - Move some code into a new GenerateAttributesHashTable method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 07:15:44 +0000 (07:15 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add CallWith=DynamicFrame to CodeGenerator
        https://bugs.webkit.org/show_bug.cgi?id=38174

        I've only used this in one instance, but this is infrastructure that I
        think will help remove a bunch of custom bindings code.  Also, added a
        few tests of tricky argument cases.

        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_with_dynamic_frame):
        (webkit_dom_test_obj_with_dynamic_frame_and_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
        (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj withDynamicFrame]):
        (-[DOMTestObj withDynamicFrameAndArg:]):
        (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
        (-[DOMTestObj withDynamicFrameAndUserGesture:]):
        (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::withDynamicFrameCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
        (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
        (WebCore::):
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * html/HTMLFormElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 27 Apr 2010 06:28:38 +0000 (06:28 +0000)]
2010-04-26  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Prepare to making WebThemeEngine cross-platform
        https://bugs.webkit.org/show_bug.cgi?id=38077

        * WebKit.gyp:
        * public/WebThemeEngine.h: Added.
        * public/win/WebThemeEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 06:19:44 +0000 (06:19 +0000)]
2010-04-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove unused code from text_diff.py
        https://bugs.webkit.org/show_bug.cgi?id=38170

        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
         - Remove is_render_tree_dump which appears unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 27 Apr 2010 06:10:33 +0000 (06:10 +0000)]
2010-04-26  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Crash after calling window.print() on a window object that has been closed.
        https://bugs.webkit.org/show_bug.cgi?id=38148

        It is unfortunately not possible to write a layout test for this as the
        crash occurs in an API that is only called by Chrome while showing a
        print dialog.

        * src/WebViewImpl.cpp:
        (WebKit::WebView::willEnterModalLoop):
        (WebKit::WebView::didExitModalLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:56:32 +0000 (05:56 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch pretty-diff is broken
        https://bugs.webkit.org/show_bug.cgi?id=38172

        We need to register for these options because they're used when we look
        up the diff.

        * Scripts/webkitpy/tool/steps/confirmdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:30:58 +0000 (05:30 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update comment to better reflect reality.

        * bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 05:01:44 +0000 (05:01 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add ObjC and GObject to run-bindings-test
        https://bugs.webkit.org/show_bug.cgi?id=38168

        Added expected results.

        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added.
        (WebKit::kit):
        (webkit_dom_test_obj_void_method):
        (webkit_dom_test_obj_void_method_with_args):
        (webkit_dom_test_obj_int_method):
        (webkit_dom_test_obj_int_method_with_args):
        (webkit_dom_test_obj_obj_method):
        (webkit_dom_test_obj_obj_method_with_args):
        (webkit_dom_test_obj_method_with_exception):
        (webkit_dom_test_obj_method_with_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
        (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
        (webkit_dom_test_obj_get_read_only_int_attr):
        (webkit_dom_test_obj_get_read_only_string_attr):
        (webkit_dom_test_obj_get_read_only_test_obj_attr):
        (webkit_dom_test_obj_get_int_attr):
        (webkit_dom_test_obj_set_int_attr):
        (webkit_dom_test_obj_get_string_attr):
        (webkit_dom_test_obj_set_string_attr):
        (webkit_dom_test_obj_get_test_obj_attr):
        (webkit_dom_test_obj_set_test_obj_attr):
        (webkit_dom_test_obj_get_attr_with_exception):
        (webkit_dom_test_obj_set_attr_with_exception):
        (webkit_dom_test_obj_get_attr_with_setter_exception):
        (webkit_dom_test_obj_set_attr_with_setter_exception):
        (webkit_dom_test_obj_get_attr_with_getter_exception):
        (webkit_dom_test_obj_set_attr_with_getter_exception):
        (WebKit::wrapTestObj):
        (WebKit::core):
        (webkit_dom_test_obj_finalize):
        (webkit_dom_test_obj_set_property):
        (webkit_dom_test_obj_get_property):
        (webkit_dom_test_obj_class_init):
        (webkit_dom_test_obj_init):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
        * bindings/scripts/test/ObjC/DOMTestObj.h: Added.
        * bindings/scripts/test/ObjC/DOMTestObj.mm: Added.
        (-[DOMTestObj dealloc]):
        (-[DOMTestObj finalize]):
        (-[DOMTestObj readOnlyIntAttr]):
        (-[DOMTestObj readOnlyStringAttr]):
        (-[DOMTestObj readOnlyTestObjAttr]):
        (-[DOMTestObj intAttr]):
        (-[DOMTestObj setIntAttr:]):
        (-[DOMTestObj stringAttr]):
        (-[DOMTestObj setStringAttr:]):
        (-[DOMTestObj testObjAttr]):
        (-[DOMTestObj setTestObjAttr:]):
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj setAttrWithSetterException:]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        (-[DOMTestObj customAttr]):
        (-[DOMTestObj setCustomAttr:]):
        (-[DOMTestObj voidMethod]):
        (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj intMethod]):
        (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj objMethod]):
        (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodWithException]):
        (-[DOMTestObj customMethod]):
        (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodWithOptionalArg:]):
        (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
        (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
        (core):
        (kit):
        * bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add ObjC and GObject to run-bindings-test
        https://bugs.webkit.org/show_bug.cgi?id=38168

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 04:49:45 +0000 (04:49 +0000)]
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add testing infrastructure for JSC bindings generator
        https://bugs.webkit.org/show_bug.cgi?id=38167

        This required moving the test files around a bit more.

        * bindings/scripts/test/JS/JSTestObj.cpp: Added.
        (WebCore::):
        (WebCore::JSTestObjConstructor::JSTestObjConstructor):
        (WebCore::JSTestObjConstructor::classInfo):
        (WebCore::JSTestObjConstructor::createStructure):
        (WebCore::JSTestObjConstructor::getOwnPropertySlot):
        (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
        (WebCore::JSTestObjPrototype::self):
        (WebCore::JSTestObjPrototype::getOwnPropertySlot):
        (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
        (WebCore::JSTestObj::JSTestObj):
        (WebCore::JSTestObj::~JSTestObj):
        (WebCore::JSTestObj::createPrototype):
        (WebCore::JSTestObj::getOwnPropertySlot):
        (WebCore::JSTestObj::getOwnPropertyDescriptor):
        (WebCore::jsTestObjReadOnlyIntAttr):
        (WebCore::jsTestObjReadOnlyStringAttr):
        (WebCore::jsTestObjReadOnlyTestObjAttr):
        (WebCore::jsTestObjIntAttr):
        (WebCore::jsTestObjStringAttr):
        (WebCore::jsTestObjTestObjAttr):
        (WebCore::jsTestObjAttrWithException):
        (WebCore::jsTestObjAttrWithSetterException):
        (WebCore::jsTestObjAttrWithGetterException):
        (WebCore::jsTestObjCustomAttr):
        (WebCore::jsTestObjConstructor):
        (WebCore::JSTestObj::put):
        (WebCore::setJSTestObjIntAttr):
        (WebCore::setJSTestObjStringAttr):
        (WebCore::setJSTestObjTestObjAttr):
        (WebCore::setJSTestObjAttrWithException):
        (WebCore::setJSTestObjAttrWithSetterException):
        (WebCore::setJSTestObjAttrWithGetterException):
        (WebCore::setJSTestObjCustomAttr):
        (WebCore::JSTestObj::getConstructor):
        (WebCore::jsTestObjPrototypeFunctionVoidMethod):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethod):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethod):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithException):
        (WebCore::jsTestObjPrototypeFunctionCustomMethod):
        (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
        (WebCore::toJS):
        (WebCore::toTestObj):
        * bindings/scripts/test/JS/JSTestObj.h: Added.
        (WebCore::JSTestObj::classInfo):
        (WebCore::JSTestObj::createStructure):
        (WebCore::JSTestObj::impl):
        (WebCore::JSTestObjPrototype::classInfo):
        (WebCore::JSTestObjPrototype::createStructure):
        (WebCore::JSTestObjPrototype::JSTestObjPrototype):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp.
        (WebCore::):
        (WebCore::TestObjInternal::V8_USE):
        (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
        (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrGetter):
        (WebCore::TestObjInternal::intAttrAttrSetter):
        (WebCore::TestObjInternal::stringAttrAttrGetter):
        (WebCore::TestObjInternal::stringAttrAttrSetter):
        (WebCore::TestObjInternal::testObjAttrAttrGetter):
        (WebCore::TestObjInternal::testObjAttrAttrSetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
        (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
        (WebCore::TestObjInternal::voidMethodCallback):
        (WebCore::TestObjInternal::voidMethodWithArgsCallback):
        (WebCore::TestObjInternal::intMethodCallback):
        (WebCore::TestObjInternal::intMethodWithArgsCallback):
        (WebCore::TestObjInternal::objMethodCallback):
        (WebCore::TestObjInternal::objMethodWithArgsCallback):
        (WebCore::TestObjInternal::methodWithExceptionCallback):
        (WebCore::TestObjInternal::methodWithOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
        (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
        (WebCore::TestObjInternal::overloadedMethod1Callback):
        (WebCore::TestObjInternal::overloadedMethod2Callback):
        (WebCore::TestObjInternal::overloadedMethod3Callback):
        (WebCore::TestObjInternal::overloadedMethod4Callback):
        (WebCore::TestObjInternal::overloadedMethodCallback):
        (WebCore::ConfigureV8TestObjTemplate):
        (WebCore::V8TestObj::GetRawTemplate):
        (WebCore::V8TestObj::GetTemplate):
        (WebCore::V8TestObj::toNative):
        (WebCore::V8TestObj::HasInstance):
        (WebCore::V8TestObj::wrap):
        (WebCore::toV8):
        (WebCore::V8TestObj::derefObject):
        * bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.
2010-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add testing infrastructure for JSC bindings generator
        https://bugs.webkit.org/show_bug.cgi?id=38167

        Add support for testing more than one bindings.  Also, converted the
        script to PEP8 style.

        * Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58288 268f45cc-cd09-0410-ab3c-d52691b4dbfc