WebKit-https.git
7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 22 Aug 2012 08:11:52 +0000 (08:11 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
commit-queue@webkit.org [Wed, 22 Aug 2012 07:50:35 +0000 (07:50 +0000)]
Web Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=91831

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-22
Reviewed by Vsevolod Vlasov.

InspectorAgent-side implementation of deleteEntry command.

Test will be added after JS-side implementation landed.

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::assertFrontend):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.deletionCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding myself to committers.py.
dominik.rottsches@intel.com [Wed, 22 Aug 2012 07:49:36 +0000 (07:49 +0000)]
Unreviewed, adding myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:42:19 +0000 (07:42 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126187 .
These are the same results as platform/mac-lion, which until
r126187 were the results of platform/mac. So this is "reverting"
r126187 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:31:42 +0000 (07:31 +0000)]
[Chromium] Unreviewed gardening.

Update image expectations for these tests. The 'x' to clear out a
text field is slightly brighter on chromium-mac; this is not
material to the intent of the tests.

* platform/chromium-mac/fast/css/text-overflow-input-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:24:58 +0000 (07:24 +0000)]
[Chromium] Unreviewed gardening.

Add failure expectations for a regression in r126257. See
https://bugs.webkit.org/show_bug.cgi?id=94675

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TabbedPane: measure tab widths in batches.
pfeldman@chromium.org [Wed, 22 Aug 2012 06:58:30 +0000 (06:58 +0000)]
Web Inspector: TabbedPane: measure tab widths in batches.
https://bugs.webkit.org/show_bug.cgi?id=94484

Reviewed by Vsevolod Vlasov.

Source/WebCore:

- Introduces global batch update schema
- Migrates Toolbar and TabbedPane to the new schema

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._updateTabElements):
(WebInspector.TabbedPane.prototype._innerUpdateTabElements):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._measureWidths):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.width):
(WebInspector.TabbedPaneTab.prototype.setWidth):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.prototype._innerUpdateDropdownButtonAndHideDropdown):
* inspector/front-end/UIUtils.js:
(WebInspector.startBatchUpdate):
(WebInspector.invokeOnceAfterBatchUpdate.get if):
(WebInspector.invokeOnceAfterBatchUpdate):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:

LayoutTests:

* inspector/start-end-batch-update-expected.txt: Added.
* inspector/start-end-batch-update.html: Added.
* inspector/tabbed-pane-tabs-to-show.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
commit-queue@webkit.org [Wed, 22 Aug 2012 06:47:38 +0000 (06:47 +0000)]
[GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
https://bugs.webkit.org/show_bug.cgi?id=94669

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Carlos Garcia Campos.

Fix memory leaks in DRT's EventSender code.

* DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
(contextClickCallback): Use GOwnPtr to manage memory of a
newly-allocated list automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 06:43:53 +0000 (06:43 +0000)]
[Chromium] Unreviewed gardening.

Restore expected results for Chromium after r126219. See
https://bugs.webkit.org/show_bug.cgi?id=94672 .

* platform/chromium/fast/text/emphasis-combined-text-expected.png: Added.
* platform/chromium/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:46:33 +0000 (05:46 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126183 .
These are the same results as platform/mac-lion, which until
r126183 where the results of platform/mac. So this is "reverting"
r126183 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:19:09 +0000 (05:19 +0000)]
[Chromium] Unreviewed gardening.

Fix TestExpectations syntax error WIN WIN7 => WIN.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:04:18 +0000 (05:04 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126225 .
These are the same results as platform/mac-lion, which until
r126225 where the results of platform/mac. So this is "reverting"
r126225 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.txt: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.txt: Added.
* platform/chromium-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move String related code in V8Binding to a separate file
haraken@chromium.org [Wed, 22 Aug 2012 04:42:25 +0000 (04:42 +0000)]
[V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571

Reviewed by Adam Barth.

This patch moves V8Parameter, V8ParameterBase and String related code
in V8Binding to a separate file.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8StringResource.cpp: Added.
* bindings/v8/V8StringResource.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 04:36:37 +0000 (04:36 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track
optimization of these baselines.

* platform/chromium-linux-x86/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-linux/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-mac-snowleopard/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-win-xp/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-win/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Added file somehow missed by garden-o-matic in last rebaseline.
kbr@google.com [Wed, 22 Aug 2012 04:19:59 +0000 (04:19 +0000)]
Unreviewed gardening. Added file somehow missed by garden-o-matic in last rebaseline.

* platform/chromium/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 03:58:46 +0000 (03:58 +0000)]
[Chromium] Unreviewed gardening.

Add test expectations for regression in r126250. See bug 94667.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement UndoManager's automatic DOM transactions
commit-queue@webkit.org [Wed, 22 Aug 2012 03:56:30 +0000 (03:56 +0000)]
Implement UndoManager's automatic DOM transactions
https://bugs.webkit.org/show_bug.cgi?id=91812

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch implements automatic DOM transactions in UndoManager
by recording changes in tree structure, attributes, and character data
of nodes under undo scope host.

Tests: editing/undomanager/automatic-transaction-attribute.html
       editing/undomanager/automatic-transaction-data.html
       editing/undomanager/automatic-transaction-node.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
* bindings/v8/DOMTransaction.cpp:
(DOMTransactionScope):
(WebCore::DOMTransactionScope::DOMTransactionScope):
(WebCore::DOMTransactionScope::~DOMTransactionScope):
(WebCore):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
* bindings/v8/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
* dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
* editing/DOMTransactionStep.cpp: Added.
(WebCore):
(WebCore::NodeInsertingDOMTransactionStep::NodeInsertingDOMTransactionStep):
(WebCore::NodeInsertingDOMTransactionStep::create):
(WebCore::NodeInsertingDOMTransactionStep::unapply):
(WebCore::NodeInsertingDOMTransactionStep::reapply):
(WebCore::NodeRemovingDOMTransactionStep::NodeRemovingDOMTransactionStep):
(WebCore::NodeRemovingDOMTransactionStep::create):
(WebCore::NodeRemovingDOMTransactionStep::unapply):
(WebCore::NodeRemovingDOMTransactionStep::reapply):
(WebCore::DataReplacingDOMTransactionStep::DataReplacingDOMTransactionStep):
(WebCore::DataReplacingDOMTransactionStep::create):
(WebCore::DataReplacingDOMTransactionStep::unapply):
(WebCore::DataReplacingDOMTransactionStep::reapply):
(WebCore::AttrChangingDOMTransactionStep::AttrChangingDOMTransactionStep):
(WebCore::AttrChangingDOMTransactionStep::create):
(WebCore::AttrChangingDOMTransactionStep::unapply):
(WebCore::AttrChangingDOMTransactionStep::reapply):
* editing/DOMTransactionStep.h: Added.
(WebCore):
(DOMTransactionStep):
(WebCore::DOMTransactionStep::~DOMTransactionStep):
(NodeInsertingDOMTransactionStep):
(NodeRemovingDOMTransactionStep):
(DataReplacingDOMTransactionStep):
(AttrChangingDOMTransactionStep):
* editing/UndoManager.cpp:
(WebCore):
(WebCore::UndoManager::isRecordingAutomaticTransaction):
(WebCore::UndoManager::addTransactionStep):
* editing/UndoManager.h:
(WebCore):
(WebCore::UndoManager::setRecordingDOMTransaction):
(UndoManager):

LayoutTests:

* editing/undomanager/automatic-transaction-attribute-expected.txt: Added.
* editing/undomanager/automatic-transaction-attribute.html: Added.
* editing/undomanager/automatic-transaction-data-expected.txt: Added.
* editing/undomanager/automatic-transaction-data.html: Added.
* editing/undomanager/automatic-transaction-node-expected.txt: Added.
* editing/undomanager/automatic-transaction-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix cross-direction stretch for replaced elements in row flexbox
commit-queue@webkit.org [Wed, 22 Aug 2012 03:35:38 +0000 (03:35 +0000)]
Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237

Patch by Shezan Baig <sbaig1@bloomberg.net> on 2012-08-21
Reviewed by Ojan Vafai.

Source/WebCore:

When stretching, don't take into account the instrinsic size of child
replaced elements. Only the fixed size, min size, and max size of the
child should be taken into account. The logic that computed this was
moved from RenderBox::computeLogicalHeight to a new helper method
called logicalHeightConstrainedByMinMax.  This helper method is now
used from RenderFlexibleBox::applyStretchAlignmentToChild, instead of
using RenderBox::computeLogicalHeight.

A similar change will need to be made for column-flowing flexboxes.
This will be addressed in https://webkit.org/b/94604.

No new tests.  The existing css3/flexbox/flexitem.html test was
extended to cover this case.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::logicalHeightConstrainedByMinMax): New helper
method that is used by RenderBox::computeLogicalHeight and also by
RenderFlexibleBox::applyStretchAlignmentToChild.
(WebCore):
(WebCore::RenderBox::computeLogicalHeight): Updated to use the new
logicalHeightConstrainedByMinMax helper method.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Use
logicalHeightConstrainedByMinMax instead of computeLogicalHeight.

LayoutTests:

Fix test cases for images stretching in the cross direction. Also,
added test cases for stretching/shrinking iframes, seamless iframes,
and also tests for vertically flowing flexboxes.

* css3/flexbox/flexitem-expected.txt:
* css3/flexbox/flexitem.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake an event object clonable to support an event propagation across seamless iframes.
hayato@chromium.org [Wed, 22 Aug 2012 03:11:50 +0000 (03:11 +0000)]
Make an event object clonable to support an event propagation across seamless iframes.
https://bugs.webkit.org/show_bug.cgi?id=93678

Reviewed by Dimitri Glazkov.

We should clone an event object when a event propagates across
seamless iframes.  Currently Event and MouseEvent are
supported. Support for other kinds of events will be addressed
later.

This is one of the pre-requirements to support an event
propagation across seamless iframes.

No new tests, no behavior change.

* dom/Event.cpp:
(WebCore::Event::cloneFor):
(WebCore):
* dom/Event.h:
(WebCore):
(Event):
* dom/MouseEvent.cpp:
(WebCore::adjustedClinetX):
(WebCore):
(WebCore::adjustedClinetY):
(WebCore::MouseEvent::cloneFor):
* dom/MouseEvent.h:
(MouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Rebaseline tests after http://trac.webkit.org/changese...
kbr@google.com [Wed, 22 Aug 2012 03:10:55 +0000 (03:10 +0000)]
Unreviewed Chromium gardening. Rebaseline tests after trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track optimization of these baselines.

* platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: IDBRequest can be GCd during event dispatch
jsbell@chromium.org [Wed, 22 Aug 2012 02:43:47 +0000 (02:43 +0000)]
IndexedDB: IDBRequest can be GCd during event dispatch
https://bugs.webkit.org/show_bug.cgi?id=94235

Reviewed by Ojan Vafai.

Source/WebCore:

Avoid a "race" where GC may attempt to reclaim IDB objects that are marked
"done" prior to the completion of the event dispatch. The script runtime
may decide to do a GC pass before calling the event handler, releasing the
object and turning the dispatch into a no-op.

This is a partial reversion (with renames, etc) of r123275, r124842,
and r121492. Added a new test, although it does not exercise the "race"
condition directly.

Test: storage/indexeddb/pending-activity.html
      storage/indexeddb/pending-activity-workers.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Let the IDBRequest know it this cursor won't
make it fire again.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest): Reintroduce "am I done?" flag.
(WebCore::IDBRequest::finishCursor): Cursors may fire events at the same
IDBRequest repeatedly, so we need to know when they're are really done.
(WebCore):
(WebCore::IDBRequest::hasPendingActivity): Test the flag.
(WebCore::IDBRequest::dispatchEvent): Set the flag.
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction): Reintroduce "am I done?" flag.
(WebCore::IDBTransaction::hasPendingActivity): Test the flag.
(WebCore::IDBTransaction::dispatchEvent): Set the flag.
* Modules/indexeddb/IDBTransaction.h:

LayoutTests:

Release references to IDBRequest and IDBTransaction objects and force GC,
to ensure that pending events are still fired. (Doesn't exercise race
condition where GC is triggered by script during dispatch itself, though.)

* storage/indexeddb/pending-activity-expected.txt: Added.
* storage/indexeddb/pending-activity-workers-expected.txt: Added.
* storage/indexeddb/pending-activity-workers.html: Added.
* storage/indexeddb/pending-activity.html: Added.
* storage/indexeddb/resources/pending-activity.js: Added.
(test):
(prepareDatabase.request.onsuccess.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess):
(prepareDatabase):
(testTransaction):
(transactionOnComplete):
(testRequest):
(requestOnSuccess):
(testCursorRequest):
(cursorRequestOnFirstSuccess):
(cursorRequestOnSecondSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [regression] Settings panel fails to open.
pfeldman@chromium.org [Wed, 22 Aug 2012 02:39:50 +0000 (02:39 +0000)]
Web Inspector: [regression] Settings panel fails to open.
https://bugs.webkit.org/show_bug.cgi?id=94647

Unreviewed: one line JS front-end fix.

* inspector/front-end/ScriptsSearchScope.js:
* inspector/front-end/Settings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorange-hit-test-with-padding.html fails unless subpixel layout is on
keishi@webkit.org [Wed, 22 Aug 2012 02:17:33 +0000 (02:17 +0000)]
range-hit-test-with-padding.html fails unless subpixel layout is on
https://bugs.webkit.org/show_bug.cgi?id=94585

Reviewed by Kent Tamura.

Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.

* fast/forms/range/range-hit-test-with-padding-expected.txt:
* fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderTableSection::setCellLogicalWidths
jchaffraix@webkit.org [Wed, 22 Aug 2012 02:16:02 +0000 (02:16 +0000)]
Crash in RenderTableSection::setCellLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=94291

Reviewed by Abhishek Arya.

Source/WebCore:

This issue was that splitAnonymousBoxesAroundChild would move a table section
into a newly created table *without* marking it as needing cell recalc. The table
would thus never build its structure to match its sections. The fix is to hop on
the new willBeRemovedFromTree signal so that the section invalidates itself properly.

Test: fast/table/crash-split-table-section-no-cell-recalc.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::willBeRemovedFromTree):
* rendering/RenderTableSection.h:
Replaced willBeDestroyed by willBeRemovedFromTree in RenderTableSection. This ensures that it is called
when moving sections in the tree to mark them as needing cell recalc.

LayoutTests:

* fast/table/crash-split-table-section-no-cell-recalc-expected.txt: Added.
* fast/table/crash-split-table-section-no-cell-recalc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] multiple fields time input UI should not have two focus ring.
yosin@chromium.org [Wed, 22 Aug 2012 02:05:51 +0000 (02:05 +0000)]
[Forms] multiple fields time input UI should not have two focus ring.
https://bugs.webkit.org/show_bug.cgi?id=94579

Reviewed by Hajime Morita.

Source/WebCore:

This patch adds CSS selectors to override focus style for multiple
fields time input UI.

No new tests. fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
is updated for including focus state appearance.

* css/html.css:
(input::-webkit-datetime-edit-ampm-field:focus): Override default focus appearance.
(input::-webkit-datetime-edit-hour-field:focus): ditto
(input::-webkit-datetime-edit-millisecond-field:focus): ditto
(input::-webkit-datetime-edit-minute-field:focus): ditto
(input::-webkit-datetime-edit-second-field:focus): ditto

LayoutTests:

This patch adds a test case of focus appearance multiple fields time
input UI.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Added script to make focus appearance.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Added script to set focus to input element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8 shouldn't have its own way of printing cross-origin error messages
abarth@webkit.org [Wed, 22 Aug 2012 01:50:40 +0000 (01:50 +0000)]
V8 shouldn't have its own way of printing cross-origin error messages
https://bugs.webkit.org/show_bug.cgi?id=94641

Reviewed by Eric Seidel.

Source/WebCore:

V8 used to re-implement (poorly) the code for printing out an error
message when a same-origin check failed. This patch deletes that code
in favor of just calling the WebCore version of the code. There more to
clean up here, but I had to stop before spidering over the whole
codebase.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
* bindings/js/BindingState.cpp:
* bindings/js/BindingState.h:
* bindings/v8/BindingState.cpp:
(WebCore::printErrorMessageForFrame):
* bindings/v8/BindingState.h:
(WebCore):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUnsafeJavaScriptAccess):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(V8Proxy):

LayoutTests:

Update these results to reflect the new error messages. These error
messages are both more correct and more like JavaScriptCore.

* platform/chromium/http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
    - We don't use the private browsing setting to implement private browsing.
* platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
* platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
* platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt:
* platform/chromium/http/tests/security/xss-eval-expected.txt:
    - Previously, we were incorrectly using the first script rather
      than the active script when printing the error message.
* platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
    - These results are now identical to JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA shadow element in ShadowDOM of a button element does not work.
shinyak@chromium.org [Wed, 22 Aug 2012 01:47:20 +0000 (01:47 +0000)]
A shadow element in ShadowDOM of a button element does not work.
https://bugs.webkit.org/show_bug.cgi?id=91486

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since a button element is extended from an HTMLFormControlElement, it creates a UserAgentShadowDOM
just before adding an AuthorShadowDOM. However, actually a button element does not need any UserAgentShadowDOM.
So we have to prevent it from creating UserAgentShadowDOM.

Test: fast/dom/shadow/shadowdom-for-button.html

* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willAddAuthorShadowRoot):
(WebCore):
* html/HTMLButtonElement.h:

LayoutTests:

* fast/dom/shadow/shadowdom-for-button-expected.html: Added.
* fast/dom/shadow/shadowdom-for-button.html: Added.
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt:
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html: a button element
does not have user agent shadow dom anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd mountain lion to perf-tests, layout tests
dpranke@chromium.org [Wed, 22 Aug 2012 01:45:48 +0000 (01:45 +0000)]
Add mountain lion to perf-tests, layout tests
https://bugs.webkit.org/show_bug.cgi?id=94553

Reviewed by Adam Barth.

This patch adds support for the 'mac-mountainlion' platform and
stamps out the last references to 'mac-leopard' as a supported
name.

This patch does a small amount of refactoring to try and make
things a little clearer how we treat the "most recent version"
specially for baselines and skipped files, and so you only
should have to touch the VERSION_FALLBACK_ORDER constants on the
ports, but unfortunately changing this list changes a bunch of
the unit tests which are doing exact matches for correctness, so
you have to touch more than a couple files :(. There's probably
still more refactoring that can be done so that we don't have to
do all of this functional testing to feel completely correct.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_version):
* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
(ApplePort):
(ApplePort._skipped_file_search_paths):
(ApplePort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_mac):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort._build_driver_flags):
(MacPort.should_retry_crashes):
(MacPort.default_baseline_search_path):
(MacPort.operating_system):
(MacPort.default_child_processes):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest):
(MacTest.test_skipped_file_search_paths):
(test_versions):
(test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Suppress crashes of new test.
kbr@google.com [Wed, 22 Aug 2012 01:45:26 +0000 (01:45 +0000)]
Unreviewed Chromium gardening. Suppress crashes of new test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove UndoManager's undoscope content attribute
commit-queue@webkit.org [Wed, 22 Aug 2012 01:42:43 +0000 (01:42 +0000)]
Remove UndoManager's undoscope content attribute
https://bugs.webkit.org/show_bug.cgi?id=94637

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. Covered by existing tests.

* bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
* dom/Document.cpp:
(WebCore::Document::undoManager):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore):
* dom/Element.h:
(Element):
* dom/Element.idl:
* dom/ElementRareData.h:
(ElementRareData):
* editing/UndoManager.cpp:
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
(WebCore):
* editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::document):
(WebCore::UndoManager::ownerNode):
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):

LayoutTests:

* editing/undomanager/undomanager-reenter-expected.txt: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free-expected.txt.
* editing/undomanager/undomanager-reenter.html: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free.html.
* editing/undomanager/undomanager-use-after-free-expected.txt: Removed.
* editing/undomanager/undomanager-use-after-free.html: Removed.
* editing/undomanager/undoscope-attribute-expected.txt: Removed.
* editing/undomanager/undoscope-attribute.html: Removed.
* editing/undomanager/undoscopehost-use-after-free.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkipping http/tests/inspector/console-resource-errors.html.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:40:27 +0000 (01:40 +0000)]
Skipping http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94646.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Brady Eidson.

Need to revert after https://bugs.webkit.org/show_bug.cgi?id=94640 is fixed.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] No accessible caret-moved events found in certain content
commit-queue@webkit.org [Wed, 22 Aug 2012 01:37:04 +0000 (01:37 +0000)]
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-21
Reviewed by Chris Fleizach.

Part of the bug is due to objects which should claim to implement AtkText
failed to do so as a result of containing a mixture of inline and block
spans.

An updated unit test was provided.

Source/WebCore:

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): New method to check if a role is one expected to have
implemented the AtkText interface. Currently that is defined as:
 - ParagraphRole
 - HeadingRole
 - DivRole
 - CellRole
(getInterfaceMaskFromObject): If a role is one of the text type roles,
automatically add WAI_TEXT to the accessible object's interface mask.

Source/WebKit/gtk:

* tests/testatk.c:
(testWebkitAtkCaretOffsets): Added instances of objects containing a
mixture of inline and block spans and tested that they implement AtkText
and contain the right textual contents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126216.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:29:22 +0000 (01:29 +0000)]
Unreviewed, rolling out r126216.
http://trac.webkit.org/changeset/126216
https://bugs.webkit.org/show_bug.cgi?id=94661

"Broke many Mac-WK2 tests" (Requested by bradee-oh on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForce XML comments to maintain whitespace
tony@chromium.org [Wed, 22 Aug 2012 01:26:49 +0000 (01:26 +0000)]
Force XML comments to maintain whitespace
https://bugs.webkit.org/show_bug.cgi?id=94620

Reviewed by Pavel Feldman.

Source/WebCore:

Fix a typo in XMLViewer.css for white-space formatting. This seems
like the desired behavior so you can see, e.g., code formatted in an
XML comment.

Covered by existing xmlviewer tests in http/tests/xmlviewer/dumpAsText

* xml/XMLViewer.css:
(.comment): Fix typo.
* xml/XMLViewer.js:
(createComment): Add style to comment nodes.

LayoutTests:

Update comments to include whitespace formatting.

* http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
* http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
* http/tests/xmlviewer/dumpAsText/xul-expected.txt:
* platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126202.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:11:05 +0000 (01:11 +0000)]
Unreviewed, rolling out r126202.
http://trac.webkit.org/changeset/126202
https://bugs.webkit.org/show_bug.cgi?id=94657

Causes assertion failures on Chromium Linux dbg compositing
layout tests (Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/WebCore:

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::CCResourceProvider):
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(CCResourceProvider):
(WebCore::CCResourceProvider::Resource::Resource):
(Resource):
(CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::~CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::textureId):
(CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::~CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::textureId):

Source/WebKit/chromium:

* tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(WebKit::CCResourceProviderTest::getResourcePixels):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Fire error at request when abort is called in upgradeneeded
dgrogan@chromium.org [Wed, 22 Aug 2012 01:08:45 +0000 (01:08 +0000)]
IndexedDB: Fire error at request when abort is called in upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=94402

Reviewed by Tony Chang.

Source/WebCore:

Tests - updated intversion-abort-in-initial-upgradeneeded-expected.txt

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
Now that second-half open calls don't get abandoned on the queue, we
can ASSERT that there's at most one of them at any time.

* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
Move setting m_didFireUpgradeNeededEvent before dispatching the event.
If abort is called in the event handler an error event will be
enqueued and ASSERT_WITH_MESSAGE(m_readyState == PENDING ||
m_didFireUpgradeNeededEvent, ...) needs to pass.

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

LayoutTests:

* storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
Only remaining error in this test is versions not being reset in
memory.

* storage/indexeddb/resources/intversion-abort-in-initial-upgradeneeded.js:
(deleteSuccess):
(upgradeNeeded):
(onAbort):
(onError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126233.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:05:09 +0000 (01:05 +0000)]
Unreviewed, rolling out r126233.
http://trac.webkit.org/changeset/126233
https://bugs.webkit.org/show_bug.cgi?id=94656

Broke Chromium Mac build (Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/mediaControls.css:
(video::-webkit-media-text-track-display):
* html/shadow/MediaControlElements.cpp:
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
* html/track/TextTrack.cpp:
* html/track/TextTrack.h:
(TextTrack):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::calculateComputedLinePosition):
(WebCore::TextTrackCue::calculateDisplayParameters):
(WebCore::TextTrackCue::getDisplayTree):
(WebCore::TextTrackCue::getPositionCoordinates):
* html/track/TextTrackCue.h:
(WebCore):
(TextTrackCue):
* rendering/RenderTextTrackCue.cpp: Removed.
* rendering/RenderTextTrackCue.h: Removed.

LayoutTests:

* media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Removed.
* media/track/track-cue-rendering-horizontal.html: Removed.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
* media/track/track-cue-rendering-vertical.html: Removed.
* media/video-test.js:
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/mac/media/track/track-cue-rendering-vertical-expected.png: Removed.
* platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove getToStringName() and getToStringTemplate() from V8Binding
haraken@chromium.org [Wed, 22 Aug 2012 00:32:46 +0000 (00:32 +0000)]
[V8] Remove getToStringName() and getToStringTemplate() from V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94573

Reviewed by Adam Barth.

- Remove V8Binding::getToStringName() and V8Binding::getToStringTemplate().

- Replace getToStringName() with String::NewSymbol("toString").

- Fix V8PerIsolateData::getToStringTemplate() so that it caches a persistent
handle of a created FunctionTemplate. Before this patch, a FunctionTemplate
had been created for each toString().

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::constructorToString):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::ConfigureV8TestNamedConstructorTemplate):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] WebGL Aquarium fails to render
anilsson@rim.com [Wed, 22 Aug 2012 00:25:52 +0000 (00:25 +0000)]
[BlackBerry] WebGL Aquarium fails to render
https://bugs.webkit.org/show_bug.cgi?id=94634

The aquarium leaves with a glColorMask(false, false, false, true) which
caused us to fail to blit the color components of the aquarium to the
EGLImage.

Fixed by setting an appropriate color mask for a blit operation.

Reviewed by Yong Li.

No new tests, tested manually.

* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisplay a TextTrackCue when snap-to-lines flag is set
victor@rosedu.org [Wed, 22 Aug 2012 00:19:48 +0000 (00:19 +0000)]
Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751

Reviewed by Tony Chang.

Source/WebCore:

This patch implements rendering functionality for a given text track,
following closer the exact WebVTT specification. There are two new classes
which have been added in order to succesfully cover rendering when of a text
track cue.

RenderTextTrackCue handles the specific rendering algorithm required,
by checking for overlaps with other boxes that are in the same
container (these can be any other boxes, not necessarily other cues,
the video controls, for example).

TextTrackCueBox extends HTMLDivElement and is an intermediate layer
between the renderer class and the actual cue object. Its purpose is
to instantiate the particular renderer and cover all the default CSS
styling that needs to be applied to the cue.

The layout is done in two steps:
  - Step 1: Layout the TextTrackCue with default CSS properties set (this is
the TextTrackCueBox decorated with the respective CSS elements)
  - Step 2: RenderTextTrackCue adjusts the box position depending on the
parameters of the TextTrackCue object and the overlaps that may occur with
previously positioned cues.

Tests: media/track/track-cue-rendering-horizontal.html
       media/track/track-cue-rendering-vertical.html

* CMakeLists.txt: Updated to include RenderTextTrackCue.
* GNUmakefile.list.am: Updated to include RenderTextTrackCue.
* Target.pri: Updated to include RenderTextTrackCue.
* WebCore.gypi: Updated to include RenderTextTrackCue.
* WebCore.vcproj/WebCore.vcproj: Updated to include RenderTextTrackCue.
* WebCore.xcodeproj/project.pbxproj: Updated to include RenderTextTrackCue.
* css/mediaControls.css: Removed unreliable CSS.
(video::-webkit-media-text-track-display): Removed properties.
* html/shadow/MediaControlElements.cpp: Updated to not use the new class.
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Simplified
the function by moving the check if track is rendered in TextTrack and used
the TextTrackCueBox for cues.
* html/track/TextTrack.cpp: Added a new method.
(WebCore::TextTrack::isRendered): Method that returns whether the track should
be rendered or not.
(WebCore):
* html/track/TextTrack.h: Added the isRendered method.
(TextTrack):
* html/track/TextTrackCue.cpp: Added several helper methods and
the TextTrackCueBox.
(WebCore):
(WebCore::TextTrackCueBox::TextTrackCueBox): The TextTrackCueBox extends
the HTMLDivElement and represents a bridge class between RenderTextTrackCue
and TextTrackCue. This is required as the layout is done in two steps, as
explained on top of the ChangeLog entry.
(WebCore::TextTrackCueBox::getCue): Returns the associated TextTrackCue object.
(WebCore::TextTrackCueBox::applyCSSProperties): Applies a part of the default CSS
properties, as defined by section 3.5.1 of the WebVTT specification.
(WebCore::TextTrackCueBox::shadowPseudoId): Moved the shadow pseudo id.
(WebCore::TextTrackCueBox::createRenderer): Creates the particular renderer.
(WebCore::TextTrackCue::TextTrackCue): Corrected the internal writing mode map.
(WebCore::TextTrackCue::calculateComputedLinePosition): Updated the compute line
position algorithm. This requires, however, a method to consider only rendered
tracks (and therefore will be addressed completely in subsequent changeset).
(WebCore::TextTrackCue::calculateDisplayParameters): Updated and corrected the
computed display parameters to match the current specification.
(WebCore::TextTrackCue::getDisplayTree): Update to use the TextTrackCueBox class
and moved CSS application to the respective class.
(WebCore::TextTrackCue::getPositionCoordinates): Added comment to specify in which
situation this method is used and change visibility to private.
(WebCore::TextTrackCue::getCSSWritingMode): Returns the CSS writing mode corresponding
to the cue writing mode.
(WebCore::TextTrackCue::getCSSSize): Returns the cue width / height (depending on the
writing direction.
(WebCore::TextTrackCue::getCSSPosition): Returns the default display position, that is
used in the first layout step.
* html/track/TextTrackCue.h:
(WebCore):
(TextTrackCueBox):
(WebCore::TextTrackCueBox::create): Initialization method.
(TextTrackCue):
(WebCore::TextTrackCue::getWritingDirection): Helper method to return the internal
values used to represent the writing direction.
* rendering/RenderTextTrackCue.cpp: Added.
(WebCore):
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
(WebCore::RenderTextTrackCue::layout): The rendering steps, as mentioned in
the WebVTT rendering rules. Currently, this treats only the snap-to-lines set
case. It is implemented following closely the spec, and might be subject to
change as discussions on various bugs evolve.
(WebCore::RenderTextTrackCue::initializeLayoutParameters): Steps 1 - 7.
(WebCore::RenderTextTrackCue::placeBoxInDefaultPosition): Steps 8 - 10.
(WebCore::RenderTextTrackCue::isOutside): Inline method to check if the cue is outside.
(WebCore::RenderTextTrackCue::isOverlapping): Inline method to check if the cue overlaps other boxes.
(WebCore::RenderTextTrackCue::shouldSwitchDirection): Step 12.
(WebCore::RenderTextTrackCue::moveBoxesByStep): Step 13.
(WebCore::RenderTextTrackCue::switchDirection): Steps 15 - 18.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Cue repositioning
for text track cue when the snap to lines flag is set.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Cue repositioning
for text track cue when the snap to lines flag is not set. Not implemented yet.
* rendering/RenderTextTrackCue.h: Added.
(WebCore):
(RenderTextTrackCue): Rendering class, handling the display of cues.

LayoutTests:

Test cases covering snap-to-lines horizontal and vertical positioning of cues.

* media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Added.
* media/track/track-cue-rendering-horizontal.html: Added.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Updated.
* media/track/track-cue-rendering-vertical.html: Added.
* media/video-test.js: Updated to support pixel test dumps.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium/TestExpectations: Marking these temporarily as IMAGE fail, as they will
anyway require new baselines.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/mac/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
commit-queue@webkit.org [Wed, 22 Aug 2012 00:18:43 +0000 (00:18 +0000)]
[BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
https://bugs.webkit.org/show_bug.cgi?id=94621

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-21
Reviewed by Yong Li.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::enableQnxJavaScriptObject):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Memory leaks in TestWebKitFindController
commit-queue@webkit.org [Wed, 22 Aug 2012 00:18:39 +0000 (00:18 +0000)]
[GTK] [WK2] Memory leaks in TestWebKitFindController
https://bugs.webkit.org/show_bug.cgi?id=94627

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Martin Robinson.

Fix memory leaks in TestWebKitFindController by using adoptGRef
instead of just getting new reference of GdkPixbuf.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add RSS content handling support
commit-queue@webkit.org [Wed, 22 Aug 2012 00:14:41 +0000 (00:14 +0000)]
[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496

Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.

Add code to filter RSS content, and properly convert them to HTML
content so they can display nicely, instead of as plain text.

Following modules are included:

RSSFilterStream: the code for detecting RSS content, and controlling
the handling of these content.

RSSParserBase: the base class for the following 3 RSS parser.
RSS10Parser: the code for decoding RSS 1.0 content.
RSS20Parser: the code for decoding RSS 2.0 content.
RSSAtomParser: the code for decoding Atom format RSS content.
RSSGenerator: the code for generating HTML content based on RSS feed.

No new tests as it's not changing how HTML content is handled.

* PlatformBlackBerry.cmake:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize):
* platform/network/blackberry/rss/RSS10Parser.cpp: Added.
(WebCore):
(WebCore::RSS10Parser::RSS10Parser):
(WebCore::RSS10Parser::parseBuffer):
(WebCore::RSS10Parser::parseXmlDoc):
(WebCore::RSS10Parser::parseItemBaseAttribute):
(WebCore::RSS10Parser::parseItem):
(WebCore::RSS10Parser::parseFeed):
* platform/network/blackberry/rss/RSS10Parser.h: Added.
(WebCore):
(RSS10Parser):
* platform/network/blackberry/rss/RSS20Parser.cpp: Added.
(WebCore):
(WebCore::RSS20Parser::RSS20Parser):
(WebCore::RSS20Parser::parseBuffer):
(WebCore::RSS20Parser::parseXmlDoc):
(WebCore::RSS20Parser::parseItemBaseAttribute):
(WebCore::RSS20Parser::parseItem):
(WebCore::RSS20Parser::parseFeed):
(WebCore::RSS20Parser::parseEnclosure):
* platform/network/blackberry/rss/RSS20Parser.h: Added.
(WebCore):
(RSS20Parser):
* platform/network/blackberry/rss/RSSAtomParser.cpp: Added.
(WebCore):
(WebCore::isRelativePath):
(WebCore::RSSAtomLink::relType):
(WebCore::RSSAtomParser::RSSAtomParser):
(WebCore::RSSAtomParser::parseBuffer):
(WebCore::RSSAtomParser::parseXmlDoc):
(WebCore::RSSAtomParser::parseItemBaseAttribute):
(WebCore::RSSAtomParser::parseItem):
(WebCore::RSSAtomParser::parseFeed):
(WebCore::RSSAtomParser::parseLink):
(WebCore::RSSAtomParser::enclosureFromLink):
(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):
(WebCore::RSSAtomParser::parseCategory):
* platform/network/blackberry/rss/RSSAtomParser.h: Added.
(WebCore):
(RSSAtomLink):
(WebCore::RSSAtomLink::RSSAtomLink):
(RSSAtomParser):
* platform/network/blackberry/rss/RSSFilterStream.cpp: Added.
(WebCore):
(WebCore::isASCIISpaceLowerByte):
(WebCore::stripWhiteSpace):
(WebCore::equalIgnoringCase):
(WebCore::isAtomMIMEType):
(WebCore::isRSSMIMEType):
(WebCore::isPotentialRSSMIMEType):
(WebCore::isRSSContent):
(WebCore::RSSTypeFromContentType):
(WebCore::RSSTypeFromContent):
(WebCore::createParser):
(WebCore::findXMLEncodingPosition):
(WebCore::findXMLLanguagePosition):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):
(WebCore::transcode):
(WebCore::transcodeContent):
(WebCore::RSSFilterStream::RSSFilterStream):
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::notifyDataReceived):
(WebCore::RSSFilterStream::notifyClose):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::handleRSSContent):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::encoding):
(WebCore::RSSFilterStream::saveHeaders):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
(WebCore::RSSFilterStream::sendSavedHeaders):
(WebCore::RSSFilterStream::appendData):
* platform/network/blackberry/rss/RSSFilterStream.h: Added.
(WebCore):
(RSSFilterStream):
* platform/network/blackberry/rss/RSSGenerator.cpp: Added.
(WebCore):
(WebCore::RSSGenerator::RSSGenerator):
(WebCore::RSSGenerator::~RSSGenerator):
(WebCore::RSSGenerator::generateHtml):
* platform/network/blackberry/rss/RSSGenerator.h: Added.
(WebCore):
(RSSGenerator):
* platform/network/blackberry/rss/RSSParserBase.cpp: Added.
(WebCore):
(WebCore::RSSEnclosure::RSSEnclosure):
(WebCore::RSSEnclosure::typeInEnum):
(WebCore::RSSEnclosure::suggestedName):
(WebCore::RSSFeed::RSSFeed):
(WebCore::RSSFeed::~RSSFeed):
(WebCore::RSSFeed::clear):
(WebCore::RSSItem::RSSItem):
(WebCore::RSSItem::~RSSItem):
(WebCore::RSSItem::clear):
(WebCore::RSSParserBase::RSSParserBase):
(WebCore::RSSParserBase::~RSSParserBase):
(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):
* platform/network/blackberry/rss/RSSParserBase.h: Added.
(WebCore):
(RSSEnclosure):
(RSSItemBase):
(RSSParserBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
zandobersek@gmail.com [Wed, 22 Aug 2012 00:14:20 +0000 (00:14 +0000)]
[GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
https://bugs.webkit.org/show_bug.cgi?id=94617

Reviewed by Martin Robinson.

Tools:

Set the 'enable-file-access-from-file-uris' setting to true when
resetting default values. The other ports do this as well, giving
documents with local security origin permission to load other
local resources.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

Remove failure expectation for fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
test as it now passes.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroducing the VMInspector for VM debugging use.
commit-queue@webkit.org [Wed, 22 Aug 2012 00:11:20 +0000 (00:11 +0000)]
Introducing the VMInspector for VM debugging use.
https://bugs.webkit.org/show_bug.cgi?id=94613.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Filip Pizlo.

Adding some utility functions for debugging the VM. This code is
presently #ifdef'd out by default.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* interpreter/CallFrame.h:
(ExecState):
* interpreter/VMInspector.cpp: Added.
(JSC):
(JSC::VMInspector::getTypeName):
(JSC::VMInspector::dumpFrame0):
(JSC::VMInspector::dumpFrame):
(JSC::VMInspector::countFrames):
* interpreter/VMInspector.h: Added.
(JSC):
(VMInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent...
commit-queue@webkit.org [Wed, 22 Aug 2012 00:07:56 +0000 (00:07 +0000)]
[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent to main thread
https://bugs.webkit.org/show_bug.cgi?id=94600

Patch by Andrew Lo <anlo@rim.com> on 2012-08-21
Reviewed by Rob Buis.

http://trac.webkit.org/changeset/116792 implements destroying
DisplayRefreshMonitor after the number of unscheduled frames exceeds 10.

Part of that change involves dispatching to the main thread whether
the frame was scheduled or not.

Make the corresponding change for the BlackBerry port that was made for
DisplayRefreshMonitorMac.cpp.

Tests covered by http://trac.webkit.org/changeset/116792

* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium/Skia] Filters should flush the SkCanvas
commit-queue@webkit.org [Wed, 22 Aug 2012 00:06:23 +0000 (00:06 +0000)]
[Chromium/Skia] Filters should flush the SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=94602

Patch by Brian Salomon <bsalomon@google.com> on 2012-08-21
Reviewed by Stephen White.

Adds a SkCanvas::flush call to FilterBufferState::swap() to ensure the textures are updated before they are consumed by the compositor.

Covered by existing css3/filters layout tests.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion that differ from the generic results.
beidson@apple.com [Tue, 21 Aug 2012 23:56:49 +0000 (23:56 +0000)]
Rebaseline various tests for Mountain Lion that differ from the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/fast/css/pseudo-any-expected.txt: Added.
* platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
* platform/mac/fast/css/pseudo-any-expected.txt: Added.
* platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css3-text] Add repaint tests for -webkit-text-decoration-line
commit-queue@webkit.org [Tue, 21 Aug 2012 23:55:27 +0000 (23:55 +0000)]
[css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-21
Reviewed by Julien Chaffraix.

Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line".
This patch adds repaint layout tests for this property.

* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line.html: Added.
Expected results generated from Chromium Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use new method to create socket handle
commit-queue@webkit.org [Tue, 21 Aug 2012 23:53:21 +0000 (23:53 +0000)]
[BlackBerry] Use new method to create socket handle
https://bugs.webkit.org/show_bug.cgi?id=89991

Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.

Update the way to create SocketStream as the platform API has changed.

No new tests as no change of behaviour, just API change adaptation.

* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move compileScript() from V8Proxy to ScriptSourceCode
haraken@chromium.org [Tue, 21 Aug 2012 23:51:39 +0000 (23:51 +0000)]
[V8] Move compileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94561

Reviewed by Adam Barth.

To kill V8Proxy, this patch moves compileScript() from V8Proxy
to ScriptSourceCode. This patch also removes fromWebCoreString().

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptSourceCode.cpp: Added.
(WebCore):
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
* bindings/v8/V8Binding.h:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion where Mountain Lion specific results overr...
beidson@apple.com [Tue, 21 Aug 2012 23:45:23 +0000 (23:45 +0000)]
Rebaseline various tests for Mountain Lion where Mountain Lion specific results override current Lion specific results,
or in some cases match the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Renamed from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.png: Renamed from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.png.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.txt.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.png: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.png.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.txt: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.txt.
* platform/mac-lion/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png.
* platform/mac-lion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.png.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.png.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.txt.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.png.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.png: Renamed from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.png.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/012-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/013-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt.
* platform/mac-lion/media/audio-repaint-expected.png: Renamed from LayoutTests/platform/mac/media/audio-repaint-expected.png.
* platform/mac-lion/media/audio-repaint-expected.txt: Added.
* platform/mac-lion/media/video-size-intrinsic-scale-expected.txt: Renamed from LayoutTests/platform/mac/media/video-size-intrinsic-scale-expected.txt.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Renamed from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt.
* platform/mac/css2.1/t1202-counter-04-b-expected.png:
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.png:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac/fast/text/emphasis-combined-text-expected.txt:
* platform/mac/fast/text/fallback-traits-fixup-expected.png:
* platform/mac/fast/text/fallback-traits-fixup-expected.txt:
* platform/mac/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.png:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
* platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move toV8Context() from V8Proxy to V8Binding
haraken@chromium.org [Tue, 21 Aug 2012 23:38:35 +0000 (23:38 +0000)]
[V8] Move toV8Context() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94597

Reviewed by Adam Barth.

To kill V8Proxy, we can move toV8Context() from V8Proxy to V8Binding.

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Further rebaselining following r126110.
leviw@chromium.org [Tue, 21 Aug 2012 23:37:43 +0000 (23:37 +0000)]
Unreviewed gardening. Further rebaselining following r126110.

* platform/chromium-linux-x86/editing/selection: Added.
* platform/chromium-linux-x86/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-win-xp/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/11241850> Block access to xpcd in WebProcess.sb
ap@apple.com [Tue, 21 Aug 2012 23:31:05 +0000 (23:31 +0000)]
    <rdar://problem/11241850> Block access to xpcd in WebProcess.sb

        Reviewed by Sam Weinig and Jon Honeycutt.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Embeddable Web Inspector
commit-queue@webkit.org [Tue, 21 Aug 2012 23:30:25 +0000 (23:30 +0000)]
Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528

Patch by Gabriel Peal <gpeal@google.com> on 2012-08-21
Reviewed by Pavel Feldman.

Adds functionality to the inspector such that it is better suited to run embedded in another webpage. It adds the ability to prepopulate the timeline panel with an existing recording among other controls.

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.dispatchQueryParameters):
(InspectorFrontendAPI.loadTimelineFromURL):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
* inspector/front-end/InspectorView.js:
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.loadFromURL.onDataReceived):
(WebInspector.TimelineModel.prototype.loadFromURL.parseAndImportData):
(WebInspector.TimelineModel.prototype.loadFromURL.onLoad):
(WebInspector.TimelineModel.prototype.loadFromURL):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.loadFromURL):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector.loaded):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA patchable GetById right after a watchpoint should have the appropriate nop padding
fpizlo@apple.com [Tue, 21 Aug 2012 23:30:19 +0000 (23:30 +0000)]
A patchable GetById right after a watchpoint should have the appropriate nop padding
https://bugs.webkit.org/show_bug.cgi?id=94635

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::padBeforePatch):
(AbstractMacroAssembler):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::moveWithPatch):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
(JSC::MacroAssemblerX86::storePtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::moveWithPatch):
* jit/JumpReplacementWatchpoint.cpp:
(JSC::JumpReplacementWatchpoint::fireInternal):

LayoutTests:

* fast/js/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Added.
* fast/js/dfg-patchable-get-by-id-after-watchpoint.html: Added.
* fast/js/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Added.
(foo):
(O):
(O.prototype.f):
(P1):
(P2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/8900275> Remove PubSub access from WebProcess, since it is...
ap@apple.com [Tue, 21 Aug 2012 23:29:21 +0000 (23:29 +0000)]
    <rdar://problem/8900275> Remove PubSub access from WebProcess, since it is no longer necessary

        Reviewed by Mark Rowe.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DRT produces wrong back-forward list
tkent@chromium.org [Tue, 21 Aug 2012 23:24:01 +0000 (23:24 +0000)]
[Chromium] DRT produces wrong back-forward list
https://bugs.webkit.org/show_bug.cgi?id=94575

Reviewed by Adam Barth.

DRT clears its history state before running every tests. However
HistoryController in WebCore isn't reset. So, it is possible that
'isNewNavigation' flag is false even though the navigation should be
handled as "new" for DRT.

This change might fix a problem of
fast/forms/select/select-state-restore.html (Bug 90207).

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):
Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
Without this change, a navigation entry for this loading won't be recorded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add support for getUserMedia
commit-queue@webkit.org [Tue, 21 Aug 2012 23:22:09 +0000 (23:22 +0000)]
[BlackBerry] Add support for getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=94591

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-21
Reviewed by George Staikos.

Implement getUserMedia feature using the platform API.

Source/WebCore:

Tests in fast/mediastream cover this.

PR #153571

Reviewed internally by George Staikos.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamSource):
(WebCore):
(WebCore::toWebMediaStreamDescriptor):
(WebCore::MediaPlayerPrivate::lookupMediaStream):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

Source/WebKit/blackberry:

PR #153571

Reviewed internally by George Staikos.

* WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore):
(WebCore::userMediaRequestsMap):
(WebCore::toMediaStreamSource):
(WebCore::toMediaStreamDescriptor):
(WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
(WebCore::WebUserMediaRequestClientImpl::requestFailed):
(WebCore::UserMediaClientImpl::UserMediaClientImpl):
(WebCore::UserMediaClientImpl::~UserMediaClientImpl):
(WebCore::UserMediaClientImpl::requestUserMedia):
(WebCore::UserMediaClientImpl::cancelUserMediaRequest):
(WebCore::UserMediaClientImpl::webUserMedia):
* WebCoreSupport/UserMediaClientImpl.h:
(BlackBerry):
(Platform):
(UserMediaClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor
pfeldman@chromium.org [Tue, 21 Aug 2012 23:19:11 +0000 (23:19 +0000)]
Web Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=94592

Reviewed by Yury Semikhatsky.

It seems to be not necessary.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.set expanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
commit-queue@webkit.org [Tue, 21 Aug 2012 23:16:52 +0000 (23:16 +0000)]
[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=94586

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-21
Reviewed by Kentaro Hara.

Source/WebKit/blackberry:

Fix build error in the DeviceOrientationClientBlackBerry.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
(DeviceOrientationClientBlackBerry::lastOrientation):

Source/WebKit/efl:

Fix build error in the DeviceOrientationClientEfl.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientEfl.cpp:
(WebCore::DeviceOrientationClientEfl::lastOrientation):

Source/WebKit/gtk:

Fix build error in the DeviceOrientationClientGtk.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientGtk.cpp:
(WebKit::DeviceOrientationClientGtk::lastOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF Threading leaks kernel objects on platforms that use pthreads
mhahnenberg@apple.com [Tue, 21 Aug 2012 23:16:24 +0000 (23:16 +0000)]
WTF Threading leaks kernel objects on platforms that use pthreads
https://bugs.webkit.org/show_bug.cgi?id=94636

Reviewed by Geoffrey Garen.

Source/WTF:

Creating lots of Web workers on Mac platforms leaks lots of Mach ports. Eventually, the
process can exhaust its allocation of Mach ports from the kernel, which can then cause
all sorts of badness, including the inability to allocate new virtual memory from the
kernel. ThreadingPthreads.cpp and ThreadIdentifierDataPthreads.cpp need to be refactored
so that we do not leak these kernel resources. I would assume that we also leak kernel
resources on other pthreads platforms as well.

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF):
(WTF::ThreadIdentifierData::~ThreadIdentifierData): Now calls the event threadDidExit, which
handles all relevant tear-down of the thread metadata in the thread map.
* wtf/ThreadingPthreads.cpp: Added a new class called PthreadState that encapsulates the
state of a thread and the possible transitions between those states.
(PthreadState):
(WTF::PthreadState::PthreadState):
(WTF::PthreadState::joinableState): Returns the current state of the pthread.
(WTF::PthreadState::pthreadHandle): Returns the pthread_t for this particular thread. This needs to
remain valid even after the thread has exited because somebody could come along at any time in the
future and call join on the thread.
(WTF::PthreadState::didBecomeDetached): Signals that the thread was detached.
(WTF::PthreadState::didExit): Signals that the thread's exit destructor (~ThreadIdentifierData) has run.
(WTF::PthreadState::didJoin): Signals that the thread has been joined on successfully.
(WTF::PthreadState::hasExited): Returns whether or not the thread's exit destructor has run.
(WTF):
(WTF::identifierByPthreadHandle): Changed to also check hasExited() on the threads it finds in the map. We
should only have one valid pthread_t in the map, but there are other pthread_t's that need to remain in the
thread map for when somebody joins on that thread id later.
(WTF::establishIdentifierForPthreadHandle): Changed to put the allocate the new PthreadState data structure and
put it in the map.
(WTF::pthreadHandleForIdentifierWithLockAlreadyHeld):
(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion): We now do the relevant cleanup after the specified thread has been
successfully joined on depending on if the joined thread has already exited.
(WTF::detachThread): Performs relevant cleanup if the thread has already exited. Otherwise signals to the
PthreadState that the thread has been detached.
(WTF::threadDidExit): Function called by ~ThreadIdentifierData to indicate that the thread has exited.
Only cleans up after itself if the thread isn't Joinable (i.e. Joined or Detached).

LayoutTests:

Added a test that creates a bunch of workers that immediately return. This should stress
the new WTF threading code on platforms that use pthreads, so any major regressions in correctness
will probably cause this test to fail since it creates both joinable and detached threads.

* fast/js/create-lots-of-workers-expected.txt: Added.
* fast/js/create-lots-of-workers.html: Added.
* fast/js/resources/empty-worker.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Some public API functions don't have their symbols exported
commit-queue@webkit.org [Tue, 21 Aug 2012 23:14:23 +0000 (23:14 +0000)]
[EFL] Some public API functions don't have their symbols exported
https://bugs.webkit.org/show_bug.cgi?id=94589

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.

Added missing export symbol macro to these public API functions.

* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCodeGeneratorInspector.py: Generate guards for type validators
commit-queue@webkit.org [Tue, 21 Aug 2012 23:09:56 +0000 (23:09 +0000)]
CodeGeneratorInspector.py: Generate guards for type validators
https://bugs.webkit.org/show_bug.cgi?id=94511

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Yury Semikhatsky.

Fix regression when building debug and one of the generated types is
disabled by a compile flag. We should generate guards for these type
validators the same way as we are doing on the include headers.

* inspector/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT triggered in SVGTRefTargetEventListener::handleEvent()
fmalita@chromium.org [Tue, 21 Aug 2012 23:07:54 +0000 (23:07 +0000)]
ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=94487

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The current way of tracking tref target elements by id can leave stale event listeners
under certain circumstances. This patch switches to storing a target RefPtr instead
to avoid an id lookup which may not return the original/attached element.

Test: svg/custom/tref-stale-listener-crash.html

* svg/SVGTRefElement.cpp:
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached): use m_target instead of an explicit bool.
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach): save a target RefPtr instead of an id.
(WebCore::SVGTRefTargetEventListener::detach): detach the target element directly without
going through a lookup.
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::updateReferencedText): use an explicit target pointer instead of
the id-based lookup.
(WebCore::SVGTRefElement::buildPendingResource):
* svg/SVGTRefElement.h:
(SVGTRefElement):

LayoutTests:

* svg/custom/tref-stale-listener-crash-expected.txt: Added.
* svg/custom/tref-stale-listener-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Find-in-page coordinates should use containingBlock
leandrogracia@chromium.org [Tue, 21 Aug 2012 23:06:06 +0000 (23:06 +0000)]
[Chromium] Find-in-page coordinates should use containingBlock
https://bugs.webkit.org/show_bug.cgi?id=94343

Reviewed by Julien Chaffraix.

The current implementation uses the container method to climb the render tree.
However, it would be more correct and convenient to use containingBlock instead.
Also, this patch introduces new tests for find-in-page coordinates in tables.

* src/FindInPageCoordinates.cpp:
(WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now.
(WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications.
* tests/WebFrameTest.cpp: add new tests for tables.
* tests/data/find_in_page.html:
* tests/data/find_in_page_frame.html: new tests for tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing fast/canvas tests for Mountain Lion
beidson@apple.com [Tue, 21 Aug 2012 23:04:19 +0000 (23:04 +0000)]
Rebaseline failing fast/canvas tests for Mountain Lion

Unreviewed (Bot gardening).

* platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add software bitmap resources to CCResourceProvider
commit-queue@webkit.org [Tue, 21 Aug 2012 23:00:12 +0000 (23:00 +0000)]
[chromium] Add software bitmap resources to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93677

Patch by Alexandre Elias <aelias@google.com> on 2012-08-21
Reviewed by Adrienne Walker.

This adds the ability to CCResourceProvider to use software bitmaps.
They are allocated as plain-old-memory, and exposed as Skia objects.

We want the ResourceProvider to be able to handle different resource
types at the same time.  In practice, a default resource type is
desired for most uses within a single compositor instance, which is
specified by the default resource type.  Default resource types are
expected to be mostly 1-to-1 with CCRenderer types.

New tests added by parametrizing existing CCResourceProvider tests.

Source/WebCore:

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
* platform/graphics/chromium/LayerRendererChromium.h:
(DrawingFrame):
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore):
(WebCore::CCResourceProvider::createGLTexture):
(WebCore::CCResourceProvider::createBitmap):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL):
(WebCore::CCResourceProvider::populateSkBitmapWithResource):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::~ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::CCResourceProvider):
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(WebCore::CCResourceProvider::setCreationPolicy):
(WebCore::CCResourceProvider::creationPolicy):
(CCResourceProvider):
(ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::textureId):
(ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::textureId):
(ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::skBitmap):
(ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::skCanvas):
(Resource):

Source/WebKit/chromium:

* tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::getResourcePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTrack -webkit property usage.
commit-queue@webkit.org [Tue, 21 Aug 2012 22:51:54 +0000 (22:51 +0000)]
Track -webkit property usage.
https://bugs.webkit.org/show_bug.cgi?id=93420

Patch by Tab Atkins <tabatkins@google.com> on 2012-08-21
Reviewed by Ojan Vafai.

First draft of an attempt to track all usage of -webkit prefixed properties across the web.
This attempt is dumb, but should provide useful data as a first-pass.
I plan to optimize this for better data collection in the future.

No tests added, as this is untestable currently.
It should have zero effect besides histogramming.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndD...
commit-queue@webkit.org [Tue, 21 Aug 2012 22:49:58 +0000 (22:49 +0000)]
[chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete.
https://bugs.webkit.org/show_bug.cgi?id=93724

Patch by Oli Lan <olilan@chromium.org> on 2012-08-21
Reviewed by Ryosuke Niwa.

This adds two new methods to WebViewImpl.

1) setCompositionFromExistingText creates a new composition from the existing text
in the currently focused input field. The new composition is between the two offsets
provided, relative to the rootEditableElement. The current selection is left unchanged.

2) extendSelectionAndDelete extends the selection by the specified number of characters
before and after, and then deletes the selection. If the selection is just a caret, the effect
is to delete the specified number of characters before and after the current editing point.

These methods will be used e.g. by the Android port to implement IME functionality.

New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText
test the two new methods.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setComposingRegion):
(WebKit):
(WebKit::extendSelectionAndDelete):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove old update/openCursor glue
commit-queue@webkit.org [Tue, 21 Aug 2012 22:41:32 +0000 (22:41 +0000)]
IndexedDB: remove old update/openCursor glue
https://bugs.webkit.org/show_bug.cgi?id=94378

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-21
Reviewed by Tony Chang.

Source/WebCore:

Remove old openCursor and update methods after landing
https://bugs.webkit.org/show_bug.cgi?id=91125 and removing
Chromium-side glue.

No new tests: this code is dead.

* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

Remove Chromium/WebKit API for old methods that have now been
removed from chromium proper.

* public/WebIDBObjectStore.h:
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the...
jamesr@google.com [Tue, 21 Aug 2012 22:35:41 +0000 (22:35 +0000)]
[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
https://bugs.webkit.org/show_bug.cgi?id=94631

Reviewed by Adrienne Walker.

Source/WebCore:

In the depths of time when dinosaurs roamed the earth, LayerChromium and CCLayerTreeHost were both reference
counted and there was a cycle between the root LayerChromium and CCLayerTreeHost. This required all users of
CCLayerTreeHost to manually break the cycle by calling setRootLayer(0) before dropping their reference to the
host. Nowadays, CCLayerTreeHost has a single owner and LayerChromiums only have a weak pointer to their host
so we should just do this cleanup ourselves instead of imposing it on callers.

Unit test added to LayerChromiumTest.cpp

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):

Source/WebKit/chromium:

Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable CSS Text Decoration by default
commit-queue@webkit.org [Tue, 21 Aug 2012 22:35:21 +0000 (22:35 +0000)]
[EFL] Enable CSS Text Decoration by default
https://bugs.webkit.org/show_bug.cgi?id=94483

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.

.:

By enabling this feature by default, it will get tested by the bots
and we can make sure no regressions will happen.

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove test that will now pass from the skip list.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed
commit-queue@webkit.org [Tue, 21 Aug 2012 22:32:32 +0000 (22:32 +0000)]
Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed
https://bugs.webkit.org/show_bug.cgi?id=92993

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-21
Reviewed by Kenneth Russell.

Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer
is constructed and destructed so that V8's garbage collection
heuristics can account for the memory held by these objects.

.:

* ManualTests/typed-array-memory.html: Added.

Source/WebCore:

* WebCore.gypi:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBufferDeallocationObserver::instance):
(WebCore):
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferCustom.h: Added.
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

Source/WTF:

* wtf/ArrayBuffer.h:
(WTF):
(ArrayBufferDeallocationObserver):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBuffer::setDeallocationObserver):
(WTF::ArrayBufferContents::~ArrayBufferContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Completion events of InspectorFileSystemAgent should be fired asynchro...
commit-queue@webkit.org [Tue, 21 Aug 2012 22:29:29 +0000 (22:29 +0000)]
Web Inspector: Completion events of InspectorFileSystemAgent should be fired asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93933

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Yury Semikhatsky.

InspectorFileSystemAgent fires completion event too early in error case. It should wait
until JS code is ready.

Source/WebCore:

Test: http/tests/inspector/filesystem/request-directory-content.html
      http/tests/inspector/filesystem/request-file-content.html
      http/tests/inspector/filesystem/request-metadata.html

* inspector/InspectorFileSystemAgent.cpp:
(WebCore): Add ReportErrorTask class

LayoutTests:

* http/tests/inspector/filesystem/request-directory-content-expected.txt:
* http/tests/inspector/filesystem/request-directory-content.html: Add more error case test.
* http/tests/inspector/filesystem/request-file-content-expected.txt:
* http/tests/inspector/filesystem/request-file-content.html: Add more error case test.
* http/tests/inspector/filesystem/request-filesystem-root-expected.txt:
* http/tests/inspector/filesystem/request-metadata-expected.txt:
* http/tests/inspector/filesystem/request-metadata.html: Add more error case test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlocking a resource via Content Security Policy should trigger an Error event.
commit-queue@webkit.org [Tue, 21 Aug 2012 22:23:00 +0000 (22:23 +0000)]
Blocking a resource via Content Security Policy should trigger an Error event.
https://bugs.webkit.org/show_bug.cgi?id=89440

Patch by Mike West <mkwst@chromium.org> on 2012-08-21
Reviewed by Jochen Eisinger.

Source/WebCore:

If a CSP directive is violated, CachedResourceLoader will trigger a
console error, and return a null image. In that case, we now dispatch
an error on the relevant element.

Adjusted http/tests/security/contentSecurityPolicy/image-blocked.html
and http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
to test the new behavior.

This has the side-effect of also generating errors for images blocked by
Chromium's content settings. Adjusted
platform/chromium/permissionclient/image-permissions.html to agree with
the new behavior.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):

LayoutTests:

* http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/image-blocked.html:
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt:
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html:
    Adjusting existing tests to use the error event, as opposed to
    hacking around the fact that it wasn't triggered.
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
    Error events are now also generated for images blocked by Chromium's
    content settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Split out crumb list part of styles from elementsPanel.css
commit-queue@webkit.org [Tue, 21 Aug 2012 22:05:33 +0000 (22:05 +0000)]
Web Inspector: Split out crumb list part of styles from elementsPanel.css
https://bugs.webkit.org/show_bug.cgi?id=94301

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Pavel Feldman.

As a preparation to use BreadcrumbList on FileSystem, introduce breadcrumbList.css and
move crumb-related style entries into it from elementsPanel.css.

No new tests. This change does not make functional change.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/breadcrumbList.css: Added.
(.crumbs):
(.crumbs .crumb):
(.crumbs .crumb.collapsed > *):
(.crumbs .crumb.collapsed::before):
(.crumbs .crumb.compact .extra):
(.crumbs .crumb.dimmed):
(.crumbs .crumb.start):
(.crumbs .crumb.end):
(.crumbs .crumb.selected):
(.crumbs .crumb.selected:hover):
(.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
(.crumbs .crumb:hover):
(.crumbs .crumb.dimmed:hover):
(.crumbs .crumb.end:hover):
* inspector/front-end/elementsPanel.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocanvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
commit-queue@webkit.org [Tue, 21 Aug 2012 22:02:13 +0000 (22:02 +0000)]
canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
https://bugs.webkit.org/show_bug.cgi?id=50797

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Andreas Kling.

Source/WebCore:

Add a check in fast-path parseAlphaValue() to return early
if the CSS <alphavalue> ended with an invalid digit.

Test: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html

* css/CSSParser.cpp:
(WebCore::parseAlphaValue):

LayoutTests:

Unskipped tests that are now passing after this fix and removed
wrong expectations.

* platform/chromium/TestExpectations:
* platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore CString data in the CStringBuffer to avoid the double indirection
benjamin@webkit.org [Tue, 21 Aug 2012 21:58:45 +0000 (21:58 +0000)]
Store CString data in the CStringBuffer to avoid the double indirection
https://bugs.webkit.org/show_bug.cgi?id=94562

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Darin Adler.

Source/Platform:

* chromium/src/WebCString.cpp:
(WebKit::WebCString::length): Update the length() computation following the changes
in CStringBuffer.

Source/WebCore:

* bindings/cpp/WebDOMCString.cpp:
(WebDOMCString::length): With the patch, CStringBuffer hold the real string length instead of the
size of the buffer including the terminating zero. WebDOMCString is updated accordingly.

Source/WTF:

Previously, any non-trivial CString would require two allocations:
1) CStringBuffer (ref-counted container for CString's data).
2) VectorBuffer's m_buffer (the actual char data).

This patches changes CStringBuffer to hold the data previously owned by
WTF::Vector and WTF::VectorBuffer. This makes CString more efficient
both in CPU time and memory use.

* wtf/text/CString.cpp:
(WTF::CStringBuffer::createUninitialized): This new method allocate the memory
for CStringBuffer and its data. We simply allocate more memory after CStringBuffer
to hold the data.

The extra memory needed to store the terminating zero is now handled by design.
(WTF::CString::CString): Move the test for "str" one level up the stack from CString::init().
This avoid double checking the pointer when using the other constructor.
(WTF::CString::init):
(WTF::CString::newUninitialized):
(WTF::CString::copyBufferIfNeeded):
* wtf/text/CString.h:
(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(CStringBuffer):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::length):

Tools:

Add test coverage for WTF::CString.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/CString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Rebaselines following r126110.
leviw@chromium.org [Tue, 21 Aug 2012 21:52:57 +0000 (21:52 +0000)]
Unreviewed gardening. Rebaselines following r126110.

* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-linux/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/4895428-3-expected.png:
* platform/chromium-mac/editing/selection/4975120-expected.png:
* platform/chromium-mac/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac/fast/css/input-search-padding-expected.png:
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/chromium-mac/fast/css/line-height-expected.png:
* platform/chromium-mac/fast/css/square-button-appearance-expected.png:
* platform/chromium-mac/fast/css/text-overflow-input-expected.png:
* platform/chromium-mac/fast/dom/isindex-001-expected.png:
* platform/chromium-mac/fast/dom/isindex-002-expected.png:
* platform/chromium-mac/fast/events/autoscroll-expected.png:
* platform/chromium-mac/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac/fast/forms/basic-buttons-expected.png:
* platform/chromium-mac/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/button-sizes-expected.png:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac/fast/forms/encoding-test-expected.png:
* platform/chromium-mac/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac/fast/forms/input-align-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac/fast/forms/input-baseline-expected.png:
* platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac/fast/forms/input-spaces-expected.png:
* platform/chromium-mac/fast/forms/input-table-expected.png:
* platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac/fast/forms/input-value-expected.png:
* platform/chromium-mac/fast/forms/input-width-expected.png:
* platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac/fast/forms/text-style-color-expected.png:
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac/fast/html/details-open2-expected.png:
* platform/chromium-mac/fast/html/details-open4-expected.png:
* platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
* platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac/fast/table/003-expected.png:
* platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
* platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-mac/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-win/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: ::first-letter pseudo-element is incorrectly sized
dpranke@chromium.org [Tue, 21 Aug 2012 21:39:43 +0000 (21:39 +0000)]
Text Autosizing: ::first-letter pseudo-element is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=94540

Reviewed by Ojan Vafai.

Revert the changes in bugs 94517 and 94396 so that we are
actually looking for stderr output from ImageDiff and doing
image compares on ref tests on the wk2 ports again.

Also, do an actual diff_image() call if the hash checks fail on
reftests, and only fail the test if we get real diffs (or don't,
for mismatches).

Lastly, clean up the log messages to be more helpful.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago_compare_image() swaps actual and expected images by mistake
dpranke@chromium.org [Tue, 21 Aug 2012 21:36:15 +0000 (21:36 +0000)]
_compare_image() swaps actual and expected images by mistake
https://bugs.webkit.org/show_bug.cgi?id=94567

Reviewed by Ojan Vafai.

Re-work the code so that we consistently pass (expected, actual)
across all of the compare/diff routines.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_compare_test):
(SingleTestRunner._compare_output):
(SingleTestRunner._compare_text):
(SingleTestRunner._compare_audio):
(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing fast/writing-mode tests for Mountain Lion
beidson@apple.com [Tue, 21 Aug 2012 21:30:42 +0000 (21:30 +0000)]
Rebaseline failing fast/writing-mode tests for Mountain Lion

Unreviewed (Bot gardening).

* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt.
* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.png.
* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt.
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png:
* platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.png:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate CSS color output string on 8 bits
benjamin@webkit.org [Tue, 21 Aug 2012 21:23:12 +0000 (21:23 +0000)]
Create CSS color output string on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=94625

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Andreas Kling.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
Previously, the output string for a CSS color was computed on 16 bits.
This was mainly forced by the use of String::number().

Since the double to string conversion is done on 8bits anyway, I changed
the code to use dtoa's numberToFixedPrecisionString directly instead of
String::number().
All the other parts were already on 8bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Move the commit-queue to building release only. Previously,
abarth@webkit.org [Tue, 21 Aug 2012 21:21:39 +0000 (21:21 +0000)]
Unreviewed. Move the commit-queue to building release only. Previously,
we built debug too, but for some reason the debug build doesn't work on
the bots. We can re-enable debug builds once we fix the underlying
problem.

* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.build_style):
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTestExpectationsParser doesn't warn about test files that don't exist.
rniwa@webkit.org [Tue, 21 Aug 2012 21:03:26 +0000 (21:03 +0000)]
TestExpectationsParser doesn't warn about test files that don't exist.
https://bugs.webkit.org/show_bug.cgi?id=94632

Reviewed by Dirk Pranke.

Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_line):
(TestExpectationParser._check_test_exists):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing editing/selection tests for mountain lion
beidson@apple.com [Tue, 21 Aug 2012 20:35:28 +0000 (20:35 +0000)]
Rebaseline failing editing/selection tests for mountain lion
https://bugs.webkit.org/show_bug.cgi?id=94629

Reviewed by Simon Fraser.

Move current Mac-specific results to platform/mac-lion and add Mountain Lion results to platform/mac

* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Using a native window for the WebView breaks GtkOverlay
mrobinson@webkit.org [Tue, 21 Aug 2012 20:29:16 +0000 (20:29 +0000)]
[GTK] Using a native window for the WebView breaks GtkOverlay
https://bugs.webkit.org/show_bug.cgi?id=90085

Reviewed by Alejandro G. Castro.

.:

* configure.ac: Parse xcomposite pkg-config file during configuration.

Source/WebCore:

No new tests. This will be covered by pixel test for accelerated
compositing when they are activated.

* GNUmakefile.am: Add XComposite libraries to the linker list.
* GNUmakefile.list.am: Add RedirectedXCompositeWindow files to the source list.
Make a new section for GLX specific files.
* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::sharedDisplay): Expose sharedDisplay as a static method
so that it can be called by other X11 specific code.
* platform/graphics/glx/GLContextGLX.h: Ditto.
* platform/gtk/RedirectedXCompositeWindow.cpp: Added. An implementation of a GL surface
that renders to an X-window which redirects to a pixmap.
* platform/gtk/RedirectedXCompositeWindow.h: Added.

Source/WebKit/gtk:

Rewrite AcceleratedCompositingContext for TextureMapperGL to be more similar to
the WebKit2 LayerTreeHost and switch from rendering directly to the widget window
to a window redirected to a pixmap via XComposite. The AcceleratedCompositingContext
now handles painting the non-composited content itself and no longer relies on the
ChromeClient backing store.

This fixes issues with using GtkOverlay WebKitWebView as well as making it possible
to run pixel tests with accelerated compositing turned on.

* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Rename some methods to make them more similar to LayerTreeHost. Now we wait to render
the OpenGL context to the window until the widget's draw signal. Escape out of all
methods early if accelerated compositing is disabled.
* WebCoreSupport/ChromeClientGtk.cpp: Always check if accelerated compositing is on
before calling into AcceleratedCompositingContext methods. When AC is on, never paint
the backing store, deferring immediately to the AcceleratedCompositingContext. When
AC is turned on the backing store now shrinks to a small size to save memory.
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): ChromeClient is now responsible for talking to the
AcceleratedCompositingContext directly.
(webkit_web_view_size_allocate): Exit early if the allocation is not a resize. This
makes some deeper logic a bit simpler and avoids accidentally doing too much work for
widget movement.
(webkit_web_view_realize): We no longer need a native window.

Source/WebKit2:

Add XComposite libraries to the linker list for WebKit2.

* GNUmakefile.am: Add XComposite

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] about:memory and about:memory-live should show numbers for the chrome...
zhajiang@rim.com [Tue, 21 Aug 2012 19:56:21 +0000 (19:56 +0000)]
[BlackBerry] about:memory and about:memory-live should show numbers for the chrome process
https://bugs.webkit.org/show_bug.cgi?id=94531

Reviewed by Rob Buis.
Patch by Jacky Jiang  <zhajiang@rim.com>

PR: 190504
Add total committed memory of chrome process into about:memory and add
its peak into about:memory-live.

Internally reviewed by Yong Li and George Staikos.

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::clear):
(MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfCurrentProcess):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfChromeProcess):
(BlackBerry::WebKit::MemoryTracker::MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] context-creation-and-destruction layout tests are slow
kbr@google.com [Tue, 21 Aug 2012 19:44:05 +0000 (19:44 +0000)]
[Chromium] context-creation-and-destruction layout tests are slow
https://bugs.webkit.org/show_bug.cgi?id=92287

Unreviewed; marked test slow on Linux as well.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/multicol/shrink-to-column-height-for-pagination.html fails on Mac WK2 bots
beidson@apple.com [Tue, 21 Aug 2012 19:17:02 +0000 (19:17 +0000)]
fast/multicol/shrink-to-column-height-for-pagination.html fails on Mac WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=94624

Unreviewed (Bot gardening).

* platform/mac-wk2/Skipped: Skip until we fix it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Layout tests gardening
rakuco@webkit.org [Tue, 21 Aug 2012 19:12:51 +0000 (19:12 +0000)]
[EFL] Layout tests gardening
https://bugs.webkit.org/show_bug.cgi?id=94594

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Make column rules paint properly.
hyatt@apple.com [Tue, 21 Aug 2012 18:15:39 +0000 (18:15 +0000)]
[New Multicolumn] Make column rules paint properly.
https://bugs.webkit.org/show_bug.cgi?id=94616

Reviewed by Simon Fraser.

Make the new multi-column code paint column rules and also prepare it for painting
the actual column contents.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
Remove the addRegionToThread call, since this is now done automatically in RenderRegion::insertedIntoTree.

* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::flowThread):
Make public so that RenderMultiColumnSet can access it.

(RenderMultiColumnBlock):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Add a column gap fetch method. It's identical to the one on RenderBlock (which will eventually go away
when we kill the old multi-column code).

(WebCore::RenderMultiColumnSet::columnRectAt):
Also identical to the RenderBlock version of this method. Gets the rect for the nth column.

(WebCore::RenderMultiColumnSet::paintReplaced):
Subclass paintReplaced in order to do column rules and contents painting.

(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::paintColumnContents):
Similar to the methods on RenderBlock. The former paints the rules and the latter paints the contents of
the flow thread into the columns.

* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Add the declarations of all the new methods.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::installFlowThread):
Added a new virtual function for installing flow threads when they didn't exist at construction time.
This only applies to actual CSS Regions, so the subclass of the method in RenderRegionSet just does
nothing.

(WebCore::RenderRegion::attachRegion):
Get the named flow thread code out of attachRegion, since it broke multi-column. Moved it into a
virtual function, installFlowThread, that is only used by actual CSS regions. Eventually we may
want a RenderRegion subclass that represents a region for a named flow thread only, but for now
let the code sit in installFlowThread in the base class.

* rendering/RenderRegion.h:
(RenderRegion):
Add installFlowThread declaration.

* rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::installFlowThread):
installFlowThread for region sets just does nothing, since we don't use named flow threads.

* rendering/RenderRegionSet.h:
(RenderRegionSet):
Add the override of installFlowThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove free functions in test_expectations to TestExpectations class
rniwa@webkit.org [Tue, 21 Aug 2012 18:10:22 +0000 (18:10 +0000)]
Move free functions in test_expectations to TestExpectations class
https://bugs.webkit.org/show_bug.cgi?id=94557

Reviewed by Dirk Pranke.

Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
to allow further refactoring.

* Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult.did_run_as_expected):
(JSONTestResult._tokenize):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.result_was_expected):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.matches_an_expected_result):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MockBugManager.create_bug):
(test_result_was_expected):
(test_remove_pixel_failures):
(test_suffixes_for_expectations):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._tests_to_rebaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Build fix for !ENABLE(DRAG_SUPPORT).
paroga@webkit.org [Tue, 21 Aug 2012 18:00:50 +0000 (18:00 +0000)]
[WIN] Build fix for !ENABLE(DRAG_SUPPORT).

* page/win/EventHandlerWin.cpp:
(WebCore):
(WebCore::EventHandler::passMouseMoveEventToSubframe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126170.
jamesr@google.com [Tue, 21 Aug 2012 17:52:00 +0000 (17:52 +0000)]
Unreviewed, rolling out r126170.
http://trac.webkit.org/changeset/126170
https://bugs.webkit.org/show_bug.cgi?id=94614

I spoke too soon

Source/Platform:

* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
* chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
* chromium/public/WebIOSurfaceLayer.h:
(WebCore):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* chromium/public/WebImageLayer.h:
(WebCore):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebScrollableLayer.h: Copied from Source/Platform/chromium/public/WebScrollbarLayer.h.
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
* chromium/public/WebScrollbarLayer.h:
(WebCore):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebScrollbarLayer):
* chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
* chromium/public/WebVideoLayer.h:
(WebCore):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):

Source/WebCore:

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

* WebKit.gypi:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
* src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
(WebKit):
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::clearClient):
(WebKit::WebContentLayer::setDoubleSided):
(WebKit::WebContentLayer::setContentsScale):
(WebKit::WebContentLayer::setUseLCDText):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
(WebKit):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* src/WebIOSurfaceLayerImpl.h: Removed.
* src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
* src/WebLayer.cpp: Added.
(WebKit):
(WebKit::WebLayer::create):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::invalidateRect):
(WebKit::WebLayer::invalidate):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::setChildren):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::setDrawsContent):
(WebKit::WebLayer::drawsContent):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setUseParentBackfaceVisibility):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::setAnimationDelegate):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::hasActiveAnimation):
(WebKit::WebLayer::transferAnimationsTo):
(WebKit::WebLayer::setForceRenderSurface):
(WebKit::WebLayer::clearRenderSurface):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
* src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
* src/WebScrollbarLayerImpl.h: Removed.
* src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h.
(WebKit):
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate run-bindings-tests results after http://trac.webkit.org/changeset/126165
abarth@webkit.org [Tue, 21 Aug 2012 17:47:23 +0000 (17:47 +0000)]
Update run-bindings-tests results after trac.webkit.org/changeset/126165

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd parsing logic for allow-pointer-lock to iframe sandbox attribute.
scheib@chromium.org [Tue, 21 Aug 2012 17:42:50 +0000 (17:42 +0000)]
Add parsing logic for allow-pointer-lock to iframe sandbox attribute.
https://bugs.webkit.org/show_bug.cgi?id=94513

Reviewed by Adam Barth.

Pointer lock was previously blocked from all sandboxed iframes.
Parsing the sandbox="allow-pointer-lock" attribute allows pages
to control the feature and enable it in sandboxed iframes.

Source/WebCore:

Tests: http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html
       http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html
       http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):

LayoutTests:

* http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed.html:
* http/tests/resources/pointer-lock/iframe-allows-inner-iframe.html: Added.
* http/tests/resources/pointer-lock/iframe-common.js:
(window.onmessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126169.
jamesr@google.com [Tue, 21 Aug 2012 17:39:24 +0000 (17:39 +0000)]
Unreviewed, rolling out r126169.
http://trac.webkit.org/changeset/126169
https://bugs.webkit.org/show_bug.cgi?id=94614

Crashes already fixed downstream

Source/Platform:

* chromium/public/WebContentLayer.h:
(WebContentLayer):
* chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
* chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
* chromium/public/WebImageLayer.h:
(WebImageLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
* chromium/public/WebScrollableLayer.h: Removed.
* chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
* chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
* chromium/public/WebVideoLayer.h:
(WebVideoLayer):

Source/WebCore:

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

* WebKit.gypi:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
* src/WebContentLayer.cpp: Removed.
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
* src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
(WebKit):
(WebExternalTextureLayerImpl):
* src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
* src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
* src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
* src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
* src/WebLayer.cpp: Removed.
* src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::id):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
* src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebScrollableLayer.cpp: Removed.
* src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
* src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
* src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
* src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
* src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126170 268f45cc-cd09-0410-ab3c-d52691b4dbfc