commit-queue@webkit.org [Wed, 25 Aug 2010 13:08:19 +0000 (13:08 +0000)]
2010-08-25 Zaheer Ahmad <zaheer.mot@gmail.com>
Reviewed by Xan Lopez.
[GTK] GTK port doesnt compile with video turned off
https://bugs.webkit.org/show_bug.cgi?id=44236
Generate the audio GObject DOM bindings only if video enabled
* WebCore/GNUMakefile.am
* WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
Make the audio code invocation conditional
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 25 Aug 2010 12:16:50 +0000 (12:16 +0000)]
2010-08-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44532
Test: inspector/dom-breakpoint.html
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/ElementsTreeOutline.js:
2010-08-25 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44532
* http/tests/inspector/debugger-test2.js:
(initialize_DebuggerTest.InspectorTest.waitUntilPaused.pausedScript):
(initialize_DebuggerTest.InspectorTest.waitUntilPaused):
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.):
(initialize_InspectorTest):
* inspector/dom-breakpoints-expected.txt:
* inspector/dom-breakpoints.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Wed, 25 Aug 2010 11:59:41 +0000 (11:59 +0000)]
2010-08-25 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Pass the element's bounds to embedder during speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=44427
The embedder would typically want to show a native UI with information, settings etc.
By passing the display bounds of the html element, the embedder can position the
native speech recognition UI appropriately.
* page/SpeechInput.cpp:
(WebCore::SpeechInput::startRecognition):
* page/SpeechInput.h:
* page/SpeechInputClient.h:
* platform/mock/SpeechInputClientMock.cpp:
(WebCore::SpeechInputClientMock::startRecognition):
* platform/mock/SpeechInputClientMock.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::detach):
2010-08-25 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Pass the element's bounds to embedder during speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=44427
* public/WebSpeechInputController.h:
(WebKit::WebSpeechInputController::startRecognition):
(WebKit::WebSpeechInputController::cancelRecognition):
(WebKit::WebSpeechInputController::stopRecording):
* src/SpeechInputClientImpl.cpp:
(WebKit::SpeechInputClientImpl::startRecognition):
* src/SpeechInputClientImpl.h:
* src/WebSpeechInputControllerMockImpl.cpp:
(WebKit::WebSpeechInputControllerMockImpl::startRecognition):
* src/WebSpeechInputControllerMockImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 11:52:32 +0000 (11:52 +0000)]
2010-08-25 Pawel Hajdan <phajdan.jr@chromium.org>
Reviewed by Darin Fisher.
Add an assertion to prevent re-initializing WebKit.
https://bugs.webkit.org/show_bug.cgi?id=44545
This will help prevent crashes like:
- http://code.google.com/p/chromium/issues/detail?id=52731
- http://code.google.com/p/chromium/issues/detail?id=52643
* src/WebKit.cpp:
(WebKit::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 11:36:54 +0000 (11:36 +0000)]
2010-08-25 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=44461
Assertion failure at WebCore/platform/network/CredentialStorage.cpp:85.
Remove the assertion at CredentialStorage.cpp:85 since it is legal to have
multiple forward slashes after the path component.
No test needed.
* platform/network/CredentialStorage.cpp:
(WebCore::protectionSpaceMapKeyFromURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 11:03:26 +0000 (11:03 +0000)]
2010-08-25 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Changed the initial and subsequent allocation of vector storage to
Array()s. The changes are to limit sparse arrays to 100000 entries
and fixed the sparse map to vector storage conversion to use the
minimum amount of memory needed to store the current number of entries.
These changes address https://bugs.webkit.org/show_bug.cgi?id=43707
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::getNewVectorLength):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Wed, 25 Aug 2010 10:41:29 +0000 (10:41 +0000)]
2010-08-25 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
Adding missing test files and reenabling the WebFrame unit-test.
https://bugs.webkit.org/show_bug.cgi?id=44492
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
* tests/data/iframes_test.html: Added.
* tests/data/invisible_iframe.html: Added.
* tests/data/visible_iframe.html: Added.
* tests/data/zero_sized_iframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 25 Aug 2010 10:06:06 +0000 (10:06 +0000)]
2010-08-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: search in Scripts panel brings ui back to original search view.
https://bugs.webkit.org/show_bug.cgi?id=44516
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.searchCanceled):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.searchCanceled):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 09:45:06 +0000 (09:45 +0000)]
<input type=number>: Support auto-repeat by mouse press
https://bugs.webkit.org/show_bug.cgi?id=44476
Reviewed by Shinichiro Hamaji
WebCore:
Like arrow button of scrollbars, spinbuttons of <input
type=number> should continue to increase/decrease their values
while the mouse button is pressed.
No new tests because the new behavior strongly depends on a timer.
* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
Initializes the timer.
(WebCore::SpinButtonElement::defaultEventHandler):
Starts the timer by a mousedown event.
(WebCore::SpinButtonElement::startRepeatingTimer):
(WebCore::SpinButtonElement::stopRepeatingTimer):
(WebCore::SpinButtonElement::repeatingTimerFired):
* rendering/TextControlInnerElements.h:
LayoutTests:
Update existing tests.
* fast/forms/script-tests/input-spinbutton-capturing.js:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 09:37:35 +0000 (09:37 +0000)]
2010-08-25 Kent Tamura <tkent@chromium.org>
Unreviewed, skip list update.
input-spinbutton-capturing.html should be skipped in platforms
without spinbutton implementation.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 25 Aug 2010 09:36:51 +0000 (09:36 +0000)]
Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963
Reviewed by Gavin Barraclough.
Fix alignment warnings on Qt.
WebCore:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
* platform/text/qt/TextCodecQt.cpp:
(WebCore::TextCodecQt::decode):
WebKit/qt:
* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 09:28:50 +0000 (09:28 +0000)]
2010-08-25 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement WebKit::Module for qt
https://bugs.webkit.org/show_bug.cgi?id=44527
* Platform/Module.h:
* Platform/qt/ModuleQt.cpp:
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 08:38:49 +0000 (08:38 +0000)]
Fix a bug that a spin-button doesn't release mouse capturing
https://bugs.webkit.org/show_bug.cgi?id=44411
Reviewed by Shinichiro Hamaji
WebCore:
- LeftButton should be checked only for clickEvent.
Note that this change doesn't change the behavior because
button() value is initialized with LeftButton even for
mousemoveEvent.
- Should pass a SpinButtonElement node to setCapturingMouseEventsNode().
Test: fast/forms/input-spinbutton-capturing.html
* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
LayoutTests:
* fast/forms/input-spinbutton-capturing-expected.txt: Added.
* fast/forms/input-spinbutton-capturing.html: Added.
* fast/forms/script-tests/input-spinbutton-capturing.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 08:25:27 +0000 (08:25 +0000)]
2010-08-25 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Change expectations on a test that now passes.
https://bugs.webkit.org/show_bug.cgi?id=44524
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 25 Aug 2010 08:23:58 +0000 (08:23 +0000)]
Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963
Reviewed by Gavin Barraclough.
Fix platform independent alignment warnings.
JavaScriptCore:
* wtf/ListHashSet.h:
(WTF::ListHashSetNodeAllocator::pool):
WebCore:
* loader/CachedMetadata.h:
(WebCore::CachedMetadata::readUnsigned):
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 08:06:58 +0000 (08:06 +0000)]
2010-08-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Add missing methods at ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=44453
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::prefetchDNS):
(WebCore::ResourceHandle::bufferedData):
(WebCore::ResourceHandle::supportsBufferedData):
(WebCore::ResourceHandle::loadsBlocked):
(WebCore::ResourceHandle::platformSetDefersLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 25 Aug 2010 07:52:16 +0000 (07:52 +0000)]
Enable truncated floating point feature on ARM
https://bugs.webkit.org/show_bug.cgi?id=44233
Reviewed by Gavin Barraclough.
Enable truncated floating point feature with the help of VCVTR.S32.F64
instruction. If VCVTR.S32.F64 can't fit the result into a 32-bit
integer/register, it saturates at INT_MAX or INT_MIN. Testing this
looks quicker than testing FPSCR for exception.
Inspired by Jacob Bramley's patch from JaegerMonkey
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::vcvtr_s32_f64_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 07:21:36 +0000 (07:21 +0000)]
2010-08-25 Adam Barth <abarth@webkit.org>
Second attempt to fix Qt build
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseDtd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 07:19:51 +0000 (07:19 +0000)]
2010-08-25 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
* DEPS: Roll Chromium revision to 57298 to fix upstream build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 06:57:14 +0000 (06:57 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove more DTD junk now that the LegacyHTMLDocumentParser is gone
https://bugs.webkit.org/show_bug.cgi?id=44588
Just removing dead code, thus no tests.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName):
* html/HTMLElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 06:53:30 +0000 (06:53 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Qt build fix.
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
(WebCore::XMLDocumentParser::parseCdata):
(WebCore::XMLDocumentParser::parseComment):
(WebCore::XMLDocumentParser::parseDtd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 06:52:01 +0000 (06:52 +0000)]
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix 26 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44580
* platform/chromium/drt_expectations.txt:
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix 26 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44580
- DRTDevToolsAgent has a reference to the main WebView. So we
should not clear it in closeDevTools() and should clear it in
~TestShell().
- DRTDevToolsClient has a reference to a DevTools WebView and no
way to update it. So we should delete DRTDevToolsClient instances
in closeDevTools().
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):
(TestShell::closeDevTools):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 06:46:43 +0000 (06:46 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Unskip XSSAuditor test and fix the source of flakiness. I'll make the
test pass again in the XSSAuditor redesign.
* http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
* http/tests/security/xssAuditor/dom-write-innerHTML.html:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 06:21:44 +0000 (06:21 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete HTMLElement::checkDTD
https://bugs.webkit.org/show_bug.cgi?id=44563
This function existed to service the LegacyHTMLTreeBuilder. The new
HTMLTreeBuilder has this logic internalized. Pulling on this thread
caused me to remove a legacyParserAddChild and to discover some code
that shouldn't be calling these parser-specific APIs.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserAddChild):
(WebCore::ContainerNode::deprecatedParserAddChild):
* dom/ContainerNode.h:
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* dom/Node.cpp:
(WebCore::Node::deprecatedParserAddChild):
* dom/Node.h:
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseCharacters):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
(WebCore::XMLDocumentParser::parseCdata):
(WebCore::XMLDocumentParser::parseComment):
(WebCore::XMLDocumentParser::parseDtd):
* html/HTMLDataGridElement.cpp:
* html/HTMLDataGridElement.h:
* html/HTMLDataGridRowElement.cpp:
* html/HTMLDataGridRowElement.h:
* html/HTMLDataListElement.cpp:
* html/HTMLDataListElement.h:
* html/HTMLDocument.cpp:
* html/HTMLDocument.h:
* html/HTMLElement.cpp:
* html/HTMLElement.h:
* html/HTMLFieldSetElement.cpp:
* html/HTMLFieldSetElement.h:
* html/HTMLFrameSetElement.cpp:
* html/HTMLFrameSetElement.h:
* html/HTMLHeadElement.cpp:
* html/HTMLHeadElement.h:
* html/HTMLHeadingElement.cpp:
* html/HTMLHeadingElement.h:
* html/HTMLHtmlElement.cpp:
* html/HTMLHtmlElement.h:
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMapElement.cpp:
* html/HTMLMapElement.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
* html/HTMLNoScriptElement.cpp:
* html/HTMLNoScriptElement.h:
* html/HTMLOptGroupElement.cpp:
* html/HTMLOptGroupElement.h:
* html/HTMLOptionElement.cpp:
* html/HTMLOptionElement.h:
* html/HTMLParagraphElement.cpp:
* html/HTMLParagraphElement.h:
* html/HTMLPlugInElement.cpp:
* html/HTMLPlugInElement.h:
* html/HTMLScriptElement.h:
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
* html/HTMLStyleElement.h:
* html/HTMLTableColElement.cpp:
* html/HTMLTableColElement.h:
* html/HTMLTableElement.cpp:
* html/HTMLTableElement.h:
* html/HTMLTableRowElement.cpp:
* html/HTMLTableRowElement.h:
* html/HTMLTableSectionElement.cpp:
* html/HTMLTableSectionElement.h:
* html/HTMLTextAreaElement.h:
* html/HTMLTitleElement.h:
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlElement::attachToParent):
(WebCore::MediaControlInputElement::attachToParent):
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::attachInnerElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 06:02:18 +0000 (06:02 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 spec changed to coalesce text nodes even when they were not created by the parser
https://bugs.webkit.org/show_bug.cgi?id=44586
See http://www.w3.org/Bugs/Public/show_bug.cgi?id=10221 for more info.
* html5lib/resources/adoption01.dat:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 05:53:35 +0000 (05:53 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
https://bugs.webkit.org/show_bug.cgi?id=44584
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Wed, 25 Aug 2010 05:41:36 +0000 (05:41 +0000)]
Build fix: Remove setHTML5ParserEnabled(), it's no longer used.
Reviewed by Adam Barth.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 05:38:36 +0000 (05:38 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove tagPriority
https://bugs.webkit.org/show_bug.cgi?id=44557
This code used to be used by the old parser. Now it's unused.
* html/HTMLAnchorElement.h:
* html/HTMLAppletElement.h:
* html/HTMLAreaElement.h:
* html/HTMLAudioElement.h:
* html/HTMLBRElement.h:
* html/HTMLBaseElement.h:
* html/HTMLBaseFontElement.h:
* html/HTMLBlockquoteElement.h:
* html/HTMLBodyElement.h:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:
* html/HTMLDListElement.h:
* html/HTMLDataGridCellElement.h:
* html/HTMLDataGridColElement.h:
* html/HTMLDataGridElement.h:
* html/HTMLDataGridRowElement.h:
* html/HTMLDirectoryElement.h:
* html/HTMLDivElement.h:
* html/HTMLElement.cpp:
* html/HTMLElement.h:
* html/HTMLEmbedElement.h:
* html/HTMLFieldSetElement.h:
* html/HTMLFontElement.h:
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.h:
* html/HTMLFrameElement.h:
* html/HTMLFrameSetElement.h:
* html/HTMLHRElement.h:
* html/HTMLHeadElement.h:
* html/HTMLHeadingElement.h:
* html/HTMLHtmlElement.h:
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.h:
* html/HTMLInputElement.h:
* html/HTMLIsIndexElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLLIElement.h:
* html/HTMLLabelElement.h:
* html/HTMLLinkElement.h:
* html/HTMLMapElement.h:
* html/HTMLMarqueeElement.h:
* html/HTMLMenuElement.h:
* html/HTMLMetaElement.h:
* html/HTMLModElement.h:
* html/HTMLOListElement.h:
* html/HTMLObjectElement.h:
* html/HTMLOptionElement.h:
* html/HTMLParagraphElement.h:
* html/HTMLParamElement.h:
* html/HTMLPreElement.h:
* html/HTMLQuoteElement.h:
* html/HTMLScriptElement.h:
* html/HTMLSelectElement.h:
* html/HTMLSourceElement.h:
* html/HTMLStyleElement.h:
* html/HTMLTableCaptionElement.h:
* html/HTMLTableCellElement.h:
* html/HTMLTableColElement.cpp:
* html/HTMLTableColElement.h:
* html/HTMLTableElement.h:
* html/HTMLTableRowElement.h:
* html/HTMLTableSectionElement.h:
* html/HTMLUListElement.h:
* html/HTMLVideoElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 05:35:19 +0000 (05:35 +0000)]
2010-08-24 Dumitru Daniliuc <dumi@chromium.org>
Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.
* platform/chromium/test_expectations.txt:
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix one more html5lib test case for button scoping
https://bugs.webkit.org/show_bug.cgi?id=44583
I <3 test driven development.
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Wed, 25 Aug 2010 05:21:42 +0000 (05:21 +0000)]
Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 05:11:56 +0000 (05:11 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue and EWS bots should report all failures
https://bugs.webkit.org/show_bug.cgi?id=41820
Right now commit-queue/EWS only report failures when the
patch under testing fails. We should report all failures
to the status server so that we can diagnose when the bots
are wedged w/o needing to log into the machines.
I also reduced the amount of data we upload since we've seen
timeouts during status upload.
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 05:01:57 +0000 (05:01 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove HTML5 parser testing infrastructure now that we don't need it
https://bugs.webkit.org/show_bug.cgi?id=44581
* html5lib/runner-expected-html5.txt: Removed.
* html5lib/webkit-resumer-expected-html5.txt: Removed.
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove HTML5 parser testing infrastructure now that we don't need it
https://bugs.webkit.org/show_bug.cgi?id=44581
Just removing dead code, no tests.
* dom/DocumentFragment.cpp:
* dom/DocumentFragment.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove HTML5 parser testing infrastructure now that we don't need it
https://bugs.webkit.org/show_bug.cgi?id=44581
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove HTML5 parser testing infrastructure now that we don't need it
https://bugs.webkit.org/show_bug.cgi?id=44581
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(initializeGlobalsFromCommandLineOptions):
* Scripts/old-run-webkit-tests:
* Scripts/test-html5-parser: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 04:47:22 +0000 (04:47 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove unneeded include in HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=44552
Slowly but steadily sweeping up the dust in the HTML parser.
* html/HTMLPreloadScanner.cpp:
* html/HTMLPreloadScanner.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 04:33:54 +0000 (04:33 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Unreviewed. Just adding test results.
XMLDocumentParser needs to implement DocumentParser::detach()
https://bugs.webkit.org/show_bug.cgi?id=44533
I was lame before and forgot to add results or mark this test
as dumpAsText().
* fast/css/font-face-svg-decoding-error-expected.txt: Added.
* fast/css/font-face-svg-decoding-error.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 25 Aug 2010 04:31:20 +0000 (04:31 +0000)]
2010-08-24 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement virtual path utilities for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44132
No new tests; tests will be added later. (Each DOMFilePath's method is briefly tested locally.)
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/DOMFilePath.cpp: Added.
* storage/DOMFilePath.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Wed, 25 Aug 2010 04:27:34 +0000 (04:27 +0000)]
Unreviewed, updating Chromium expectations.
* platform/chromium-mac/fast/js/kde/Number-expected.txt:
* platform/chromium-mac/fast/js/number-toExponential-expected.txt:
* platform/chromium-mac/fast/js/number-tofixed-expected.txt:
* platform/chromium-mac/fast/js/number-toprecision-expected.txt:
* platform/chromium-win/fast/js/kde/Number-expected.txt:
* platform/chromium-win/fast/js/number-toExponential-expected.txt:
* platform/chromium-win/fast/js/number-tofixed-expected.txt:
* platform/chromium-win/fast/js/number-toprecision-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 04:20:46 +0000 (04:20 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLParserScheduler::create
https://bugs.webkit.org/show_bug.cgi?id=44551
* html/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
* html/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 25 Aug 2010 04:18:36 +0000 (04:18 +0000)]
[chromium] WebBlobRegistry cleanup.
https://bugs.webkit.org/show_bug.cgi?id=44571
Reviewed by Darin Fisher.
Remove unneeded method from WebBlobRegistry interface.
Also remove unneeded WebBlobRegistryImpl.* files. They're already
excluded from gyp files.
* public/WebBlobRegistry.h:
* src/WebBlobRegistryImpl.cpp: Removed.
* src/WebBlobRegistryImpl.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 03:55:48 +0000 (03:55 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Add http/tests/security/xssAuditor/dom-write-location-inline-event.html
to the Skipped list. It's flaky after enabling the HTML5 fragment
parser. I need to investigate. However, I'm planning to redesign the
XSSAuditor to make use of the new parser, so it seems to make sense to
wait a bit.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 25 Aug 2010 03:16:55 +0000 (03:16 +0000)]
2010-08-24 Daniel Bates <dbates@rim.com>
Fix the change log date associated with changeset 65967
<http://trac.webkit.org/changeset/65967> in both the
LayoutTests and WebCore change log.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 25 Aug 2010 03:12:15 +0000 (03:12 +0000)]
2010-08-24 Daniel Bates <dbates@rim.com>
Fix code comment as per Darin Adler's suggestion in <https://bugs.webkit.org/show_bug.cgi?id=44486#c2>.
I inadvertently did not update this comment when I landed changeset 65967 <http://trac.webkit.org/changeset/65967>.
* rendering/RenderListMarker.cpp:
(WebCore::listMarkerSuffix):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 25 Aug 2010 03:10:12 +0000 (03:10 +0000)]
WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode
<rdar://problem/8348100>
https://bugs.webkit.org/show_bug.cgi?id=44537
Reviewed by Mark Rowe.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Use posix_spawnattr_setbinpref_np
to tell posix_spawn to launch the WebProcess in 32-bit mode when the UIProcess
is running in 32-bit mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 25 Aug 2010 03:05:10 +0000 (03:05 +0000)]
2010-08-23 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Suffix for CSS alphabetic list style types should fallback to
decimal for ordinals outside of their representable range
https://bugs.webkit.org/show_bug.cgi?id=44486
Test: fast/lists/w3-css3-list-styles-fallback-style.html
Fixes an issue where the decimal suffix is not used for
ordinals that cannot be represented by the alphabetic list
style type.
Currently, for ordinals that cannot be represented in the
alphabetic list style we use the suffix associated with the
list style. Instead, we should use the suffix for the decimal
list style ('.'). For instance, when the list style type is
Afar and the starting ordinal is 0, then we fallback to the
decimal list style suffix '.' because 0 cannot be represented
in Afar.
* rendering/RenderListMarker.cpp:
(WebCore::toRoman): Moved bounds check into WebCore::effectiveListMarkerType().
(WebCore::toAlphabetic): Ditto.
(WebCore::toHebrew): Ditto.
(WebCore::toArmenian): Ditto.
(WebCore::toGeorgian): Ditto.
(WebCore::toCJKIdeographic): Ditto.
(WebCore::effectiveListMarkerType): Added.
(WebCore::listMarkerSuffix): Added value parameter to prototype.
Modified to call WebCore::effectiveListMarkerType.
(WebCore::listMarkerText): Modified to call WebCore::effectiveListMarkerType().
(WebCore::RenderListMarker::paint): Modified to pass list item ordinal (i.e. m_listItem->value()) to WebCore::listMarkerSuffix().
(WebCore::RenderListMarker::calcPrefWidths): Ditto.
(WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
2010-08-23 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Suffix for CSS alphabetic list style types should fallback to
decimal for ordinals outside of their representable range
https://bugs.webkit.org/show_bug.cgi?id=44486
Tests that CSS list styles fallback to the decimal list style
for ordinals that cannot be represented. We need to implement
DRT support to test the actual suffix (see bug #44489).
Also, adds test for ordinal 0 for each numeric list style type.
* fast/lists/resources/w3-css3-list-styles-alphabetic.css: Added.
* fast/lists/w3-css3-list-styles-alphabetic.html: Moved CSS list styles to file w3-css3-list-styles-alphabetic.css,
* fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Added.
* fast/lists/w3-css3-list-styles-fallback-style.html: Added.
* fast/lists/w3-css3-list-styles-numeric-expected.txt: Added test for ordinal 0 for each list style type.
* fast/lists/w3-css3-list-styles-numeric.html: Rebased result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 02:59:44 +0000 (02:59 +0000)]
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Fix 28 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44574
* platform/chromium/drt_expectations.txt:
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Fix 28 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44574
Reset DevToolsClient and DevToolsAgent before closing a DevTools
WebView in order to avoid accessing to a deleted WebView instance.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::closeDevTools):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 25 Aug 2010 01:51:26 +0000 (01:51 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 25 Aug 2010 01:49:24 +0000 (01:49 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Hulu popups are blocked
https://bugs.webkit.org/show_bug.cgi?id=44572
We were blocking popups created by Flash Player because we were never
setting the UserGestureIndicator for events. Most WebKit ports handle
events through EventHandler, but Chromium is special (for some unknown
reason) and dispatches events directly. That means Chromium misses out
on some of the work done by EventHandler, including setting the
UserGestureIndicator.
I suspect this is covered by an existing LayoutTest, but I don't have
the ability to run the Chromium LayoutTests on this machine. :(
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 25 Aug 2010 01:34:49 +0000 (01:34 +0000)]
Windows build fix.
* ForwardingHeaders/wtf/DecimalNumber.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 25 Aug 2010 01:21:16 +0000 (01:21 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DecimalNumber.h:
(WTF::DecimalNumber::intPow10):
* wtf/dtoa.cpp:
* wtf/dtoa.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 25 Aug 2010 01:09:41 +0000 (01:09 +0000)]
2010-08-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
GC before running an iteration in the perf tests
https://bugs.webkit.org/show_bug.cgi?id=44570
This is a speculative attempt at reducing flakiness.
There definitely are a lot of collected for some tests,
so, having GC happen in the middle of a run may very well
be causing flakiness.
* resources/magnitude-perf.js:
(Magnitude._runIteration):
(Magnitude):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 25 Aug 2010 01:06:11 +0000 (01:06 +0000)]
2010-08-24 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] rebaseline chromium linux svg tests
https://bugs.webkit.org/show_bug.cgi?id=44562
These are anti-aliasing (rounding) differences on Linux.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: The number 600 has a few pixels of extra space between characters.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/chromium-linux/svg/custom/animate-path-morphing-expected.checksum:
* platform/chromium-linux/svg/custom/animate-path-morphing-expected.png:
* platform/chromium-linux/svg/custom/use-transform-expected.checksum:
* platform/chromium-linux/svg/custom/use-transform-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 25 Aug 2010 01:04:31 +0000 (01:04 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=44487
Reviewed by Oliver Hunt.
Number.toExponential/toFixed/toPrecision all contain a spaghetti of duplicated
code & unnecessary complexity. Add a new DecimalNumber class to encapsulate
double to string conversion, share the implementations of rounding &
decimal-fraction/exponential formatting.
* JavaScriptCore.exp:
Update exports.
* runtime/NumberPrototype.cpp:
(JSC::toThisNumber):
(JSC::getIntegerArgumentInRange):
Helper methods used in implementing toExponential/toFixed/toString.
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
Reimplemented using new DecimalNumber class.
* runtime/UString.cpp:
(JSC::UString::number):
Updated to call numberToString.
* wtf/DecimalNumber.h: Added.
(WTF::):
(WTF::DecimalNumber::DecimalNumber):
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):
(WTF::DecimalNumber::sign):
(WTF::DecimalNumber::exponent):
(WTF::DecimalNumber::significand):
(WTF::DecimalNumber::precision):
(WTF::DecimalNumber::init):
(WTF::DecimalNumber::isZero):
(WTF::DecimalNumber::roundToPrecision):
New class to perform double to string conversion.
Has three constructors, which allow conversion with no rounding,
rounding to significant-figures, or rounding to decimal-places,
and two methods for formatting strings, either using decimal
fraction or exponential encoding. Internal implementation uses
pre-rounding of the values before calling dtoa rather than
relying on dtoa to correctly round, which does not produce
fully accurate results. Hopefully we can address this in the
near future.
* wtf/dtoa.cpp:
(WTF::intPow10):
* wtf/dtoa.h:
intPow10 is used internally by DecimalNumber.
* wtf/text/WTFString.cpp:
(WTF::copyToString):
(WTF::nanOrInfToString):
Used internally in numberToString for NaN/Infinity handling.
(WTF::numberToString):
Added new method to convert doubles to strings.
* wtf/text/WTFString.h:
Added declaration for numberToString. This is here because
we should switch over to using this for all double to string
conversion in WebCore (see section 2.4.4.3 of the HTML5 spec).
JavaScriptGlue: https://bugs.webkit.org/show_bug.cgi?id=44487
Reviewed by Oliver Hunt.
* ForwardingHeaders/wtf/text/WTFString.h: Added.
WebCore: https://bugs.webkit.org/show_bug.cgi?id=44487
Reviewed by Oliver Hunt.
* html/LegacyHTMLTreeBuilder.cpp:
(WebCore::serializeForNumberType):
Update function call to numberToString.
LayoutTests: Bug 44487 - Clean up NumberPrototype.cpp
Reviewed by Oliver Hunt.
This patch changes some layout test results - in all these cases we were
not previously accurate to spec defined behaviour, and we are still not
- but overall this changes reduces the overall magnitude of error due to
rounding differences. The underlying problem is that we should be using
dtoa to generate results to a specified accuracy, rather than relying on
pre-rounding the input values. We should look at reenabling our dtoa
implementation to work in this fashion as a separate change.
* fast/js/kde/Number-expected.txt:
* fast/js/kde/script-tests/Number.js:
* fast/js/number-toExponential-expected.txt:
* fast/js/number-tofixed-expected.txt:
* fast/js/number-toprecision-expected.txt:
* fast/js/script-tests/number-toExponential.js:
* fast/js/script-tests/number-tofixed.js:
* fast/js/script-tests/number-toprecision.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 25 Aug 2010 00:40:18 +0000 (00:40 +0000)]
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
XMLDocumentParser needs to implement DocumentParser::detach()
https://bugs.webkit.org/show_bug.cgi?id=44533
Added a test which uses an image as an SVG font (decoding errors galore).
XML versions of one of the tests from
http://trac.webkit.org/changeset/65692
* fast/css/font-face-svg-decoding-error.html: Added.
* fast/frames/resources/set-src-to-javascript-url.xhtml: Added.
* fast/frames/set-parent-src-synchronously.xhtml: Added.
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
XMLDocumentParser needs to implement DocumentParser::detach()
https://bugs.webkit.org/show_bug.cgi?id=44533
Test: fast/frames/set-parent-src-synchronously.xhtml
In the example from the page we were accessing document()
after DocumentParser::detach() was called. To prevent this
I added an ASSERT(m_document) to document(), causing many
test cases to cover the bug shown in bug 44533.
To fix the bug, I implemented XMLDocumentParser::detach()
and had it call clearCurrentNodeStack(), thus making
it impossible for XMLDocumentParser to still have the Document
on the node stack after detach (which was what was causing this bug).
While fixing this, I noticed that XMLDocumentParser may have the
same trouble crashing that the HTMLDocumentParser did when
synchronously deleted from JS (for example by an iframe navigation).
I added a test case to cover this and protected the parser after
the two places it executes scripts.
* dom/DocumentParser.h:
(WebCore::DocumentParser::document):
(WebCore::DocumentParser::isDetached):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::finish):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
(WebCore::XMLDocumentParser::detach):
(WebCore::XMLDocumentParser::notifyFinished):
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::resumeParsing):
* html/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::willPumpLexer):
(WebCore::HTMLDocumentParser::didPumpLexer):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::endIfDelayed):
(WebCore::HTMLDocumentParser::script):
* html/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::updateTokenizerState):
* html/HTMLViewSourceParser.h:
(WebCore::HTMLViewSourceParser::document):
* loader/ImageDocument.cpp:
(WebCore::ImageDocumentParser::document):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 25 Aug 2010 00:39:01 +0000 (00:39 +0000)]
2010-08-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Add SynchronousLoader for ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=44452
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Wed, 25 Aug 2010 00:31:45 +0000 (00:31 +0000)]
Unreviewed, updating a chromium-linux expectation.
* platform/chromium-linux/svg/css/shadow-changes-expected.checksum: Added.
* platform/chromium-linux/svg/css/shadow-changes-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 25 Aug 2010 00:24:05 +0000 (00:24 +0000)]
2010-08-24 Kenneth Russell <kbr@google.com>
Unreviewed, test expectations update. Skip
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html while
root cause of failure is being investigated. See
https://bugs.webkit.org/show_bug.cgi?id=44459 .
* platform/mac-snowleopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 25 Aug 2010 00:22:17 +0000 (00:22 +0000)]
2010-08-24 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/drt_expectations.txt: Add inspector test failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 25 Aug 2010 00:10:30 +0000 (00:10 +0000)]
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: clean up code for test_types, test_failures
Add a bunch of unit tests for webkitpy.layout_tests.test_types and
webkitpy.layout_tests.layout_package.test_failures, and remove
some dead code and otherwise clean up things.
https://bugs.webkit.org/show_bug.cgi?id=44559
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Wed, 25 Aug 2010 00:09:54 +0000 (00:09 +0000)]
Reviewed by Steve Falkenburg.
<rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
https://bugs.webkit.org/show_bug.cgi?id=44564
* WebView.cpp:
(WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
if plugins are disabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 25 Aug 2010 00:02:27 +0000 (00:02 +0000)]
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: revise unit testing strategy for test failures
This change revamps the way we store test data for new-run-webkit-tests.
Previously we had a few copies of test files from the main test tree.
Now we have a bunch of completely fake test data and use the test
data to generate different kinds of test failures, getting
much better coverage.
https://bugs.webkit.org/show_bug.cgi?id=44556
* Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
* Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 24 Aug 2010 23:48:35 +0000 (23:48 +0000)]
2010-08-24 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Replaced soft tab indentation by hard tab indentation for LegacyWebArchive.h.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 24 Aug 2010 23:45:28 +0000 (23:45 +0000)]
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
speed up new-run-webkit-tests unit tests
Add a --no-record-results flag that turns off generating the JSON
results file on every test run. Generating the file requires us to
fetch the old results down from the bots, which can be slow. This
flag is off by default.
Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
These changes together shorten the test cycle from ~4.5s to ~1.5s
- a 3x speedup.
https://bugs.webkit.org/show_bug.cgi?id=44553
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Tue, 24 Aug 2010 23:17:21 +0000 (23:17 +0000)]
Unreviewed, more Chromium-specific expectations.
* platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/multicol-repaint-expected.png: Added.
* platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum: Added.
* platform/chromium-win/fast/repaint/multicol-repaint-expected.png: Added.
* platform/chromium-win/fast/repaint/multicol-repaint-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 24 Aug 2010 22:55:49 +0000 (22:55 +0000)]
2010-08-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Don't seed the JS random number generator from time()
https://bugs.webkit.org/show_bug.cgi?id=41868
<rdar://problem/8171025>
Switch to using the secure random number generator to
seed the fast random generator, and make the generator
be per global object.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::weakRandomNumber):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncRandom):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 24 Aug 2010 22:47:15 +0000 (22:47 +0000)]
[chromium] Update WebBlobData.
https://bugs.webkit.org/show_bug.cgi?id=44481
Reviewed by Darin Fisher.
Some changes to WebBlobData to match with chromium implementation.
1) Change to use WebCString for data, instead of WebData.
2) Separate path from URL.
* public/WebBlobData.h:
* src/WebBlobData.cpp:
(WebKit::WebBlobData::itemAt):
(WebKit::WebBlobData::appendData):
(WebKit::WebBlobData::appendBlob):
* src/WebBlobStorageData.cpp:
(WebKit::WebBlobStorageData::itemAt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Tue, 24 Aug 2010 22:41:19 +0000 (22:41 +0000)]
Unreviewed, updating Chromium-specific expectations.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
* platform/chromium-win/svg/css/shadow-changes-expected.checksum: Added.
* platform/chromium-win/svg/css/shadow-changes-expected.png: Added.
* platform/chromium-win/svg/css/shadow-changes-expected.txt: Added.
* platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.checksum: Added.
* platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 24 Aug 2010 22:37:39 +0000 (22:37 +0000)]
2010-08-24 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] fix the platform result fallback order on mac/win
https://bugs.webkit.org/show_bug.cgi?id=44483
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 24 Aug 2010 22:33:55 +0000 (22:33 +0000)]
2010-08-24 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Mark Rowe.
Web Inspector: RemoteInspectorFrontend can be renamed to InspectorFrontend
https://bugs.webkit.org/show_bug.cgi?id=44499
Follow-up. No longer generate the RemoteInspectorFrontend files, just
generate the required InspectorFrontend files.
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 24 Aug 2010 22:33:39 +0000 (22:33 +0000)]
2010-08-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Backend Should Provide Full Supported CSS Properties List
https://bugs.webkit.org/show_bug.cgi?id=40886
This allows the backend to send the front-end its complete list of
supported CSS Properties. This is used in CSS Autocompletion and
CSS Syntax Highlighting to show which styles are supported.
* css/makeprop.pl: moved CSS properties to the header file.
* inspector/Inspector.idl: expose getSupportedCSSProperties.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getSupportedCSSProperties):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions._firstIndexOfPrefix): handle a possible error case before properties have loaded.
(WebInspector.CSSCompletions._load): fill up the special array with the received properties.
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer): use the list of support properties from the backend.
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/inspector.js: request the list of supported CSS properties on load.
(WebInspector.doLoadedDone):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 22:27:36 +0000 (22:27 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete LegacyHTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=44554
There were some free functions in LegacyHTMLTreeBuilder that needed a
new home. I've put them in HTMLTreeBuilder, but they'll probably need
a better home eventually.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::shouldCreateImplicitHead):
* dom/DocumentParser.h:
* dom/ScriptableDocumentParser.h:
* html/HTMLConstructionSite.cpp:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::removedFromTree):
* html/HTMLInputElement.cpp:
* html/HTMLMeterElement.cpp:
* html/HTMLProgressElement.cpp:
* html/HTMLTreeBuilder.cpp:
(WebCore::serializeForNumberType):
(WebCore::parseToDoubleForNumberType):
* html/HTMLTreeBuilder.h:
* html/HTMLViewSourceParser.h:
* html/LegacyHTMLTreeBuilder.cpp: Removed.
* html/LegacyHTMLTreeBuilder.h: Removed.
* html/StepRange.cpp:
* html/ValidityState.cpp:
* rendering/RenderSlider.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 24 Aug 2010 22:22:14 +0000 (22:22 +0000)]
2010-08-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
perf tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=44199
Speculative fix for perf test flakiness. Use chromium.Interval
to get a microsecond granularity timer. If this does end up
reducing flakiness, then we can expose something similar for
JSC and/or layoutTestController.
* resources/magnitude-perf.js:
(Magnitude._runIteration):
(Magnitude):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Aug 2010 22:16:55 +0000 (22:16 +0000)]
2010-08-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: show DOM breakpoints in sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=44424
* inspector/dom-breakpoints.html:
2010-08-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: show DOM breakpoints in sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=44424
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._setBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointRemoved):
(WebInspector.BreakpointManager.prototype._setBreakpointOnBackend):
(WebInspector.Breakpoint.prototype.set enabled):
(WebInspector.Breakpoint.prototype.set condition):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane):
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired):
(WebInspector.BreakpointItem):
(WebInspector.BreakpointItem.prototype.element):
(WebInspector.BreakpointItem.prototype.remove):
(WebInspector.BreakpointItem.prototype._checkboxClicked):
(WebInspector.BreakpointItem.prototype._enableChanged):
(WebInspector.BreakpointItem.prototype._removed):
(WebInspector.JSBreakpointItem):
(WebInspector.JSBreakpointItem.prototype._textChanged):
(WebInspector.DOMBreakpointItem):
(WebInspector.DOMBreakpointItem.prototype.compareTo):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMBreakpointManager):
(WebInspector.DOMBreakpointManager.prototype.setBreakpoint):
(WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode):
(WebInspector.DOMBreakpointManager.prototype._breakpointRemoved):
(WebInspector.DOMBreakpoint):
(WebInspector.DOMBreakpoint.prototype.get enabled):
(WebInspector.DOMBreakpoint.prototype.set enabled):
(WebInspector.DOMBreakpoint.prototype.remove):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.reset):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype._breakpointRemoved):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype.updateLocalContent):
* inspector/front-end/inspector.js:
(WebInspector.createJSBreakpointsSidebarPane.breakpointAdded):
(WebInspector.createJSBreakpointsSidebarPane):
(WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded):
(WebInspector.createDOMBreakpointsSidebarPane):
(WebInspector.doLoadedDone):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 24 Aug 2010 21:51:47 +0000 (21:51 +0000)]
2010-08-24 Stephen White <senorblanco@chromium.org>
Reviewed by Dumitru Daniliuc.
Speculative fix for layout test failures on Chrome/Linux.
https://bugs.webkit.org/show_bug.cgi?id=44550
Tests fast/canvas/arc-crash.html, fast/canvas/canvas-state-intact-after-putImageData.html, and fast/canvas/toDataURL-supportedTypes.html are failing on Chrome/Linux. Can't repro the failure locally, but this fix can't hurt.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Tue, 24 Aug 2010 21:42:33 +0000 (21:42 +0000)]
WebCore: Fix the NodeFilter wrapper and the binding for acceptNode.
https://bugs.webkit.org/show_bug.cgi?id=44542
Reviewed by Dimitri Glazkov.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::wrapNativeNodeFilter): This function
should always create a filter. V8NodeFilterCondition::acceptNode()
will check if the given object can be used as a filter, and throw
an exception if it can't.
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode): Update this binding
to do the same thing that the JS binding does.
LayoutTests: acceptNode-filter.html should pass after this patch.
https://bugs.webkit.org/show_bug.cgi?id=44542
Reviewed by Dimitri Glazkov.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 24 Aug 2010 21:24:21 +0000 (21:24 +0000)]
2010-08-24 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] linux layout test results for svg tests
https://bugs.webkit.org/show_bug.cgi?id=44303
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
* platform/chromium-linux/svg/carto.net/slider-expected.checksum:
* platform/chromium-linux/svg/carto.net/slider-expected.png:
* platform/chromium-linux/svg/carto.net/textbox-expected.checksum:
* platform/chromium-linux/svg/carto.net/textbox-expected.png:
* platform/chromium-linux/svg/carto.net/window-expected.txt: Added.
* platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.checksum:
* platform/chromium-linux/svg/custom/coords-relative-units-transforms-expected.png: Added.
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
* platform/chromium-linux/svg/hixie/text/003b-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 24 Aug 2010 21:14:55 +0000 (21:14 +0000)]
2010-08-24 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] linux baselines for a few svg tests
https://bugs.webkit.org/show_bug.cgi?id=44286
These are all font differences from the windows and mac results. On
Linux, we have stronger anti-aliasing of fonts than windows although
we match the windows font metrics (which is why these are only pixel
results).
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 24 Aug 2010 21:01:16 +0000 (21:01 +0000)]
2010-08-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Tony Chang.
After r65681, caret no longer displays promptly while editing form fields
https://bugs.webkit.org/show_bug.cgi?id=44294
The caret no longer eagerly updates its rect on every paint, so we have
to manually update it after scrolling the selection into view when
the selection changes.
Tested by the pixel results of fast/forms/input-text-scroll-left-on-blur.html
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 20:55:02 +0000 (20:55 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove redundant call to OwnPtr::clear
https://bugs.webkit.org/show_bug.cgi?id=44548
As pointed out by Darin, this call to clear is not needed.
* editing/TextIterator.cpp:
(WebCore::plainTextToMallocAllocatedBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 20:49:16 +0000 (20:49 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTokenizer::create
https://bugs.webkit.org/show_bug.cgi?id=44477
* html/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
* html/HTMLPreloadScanner.cpp:
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processToken):
* html/HTMLPreloadScanner.h:
* html/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::create):
* html/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
(WebCore::HTMLViewSourceParser::pumpTokenizer):
(WebCore::HTMLViewSourceParser::updateTokenizerState):
* html/HTMLViewSourceParser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 20:43:28 +0000 (20:43 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove references to LegacyHTMLTreebuilder from HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=44544
* html/HTMLDocumentParser.cpp:
* html/HTMLDocumentParser.h:
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::finished):
* html/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 24 Aug 2010 20:38:41 +0000 (20:38 +0000)]
Set the install path of WebKit2.framework to the build directory for debug and release builds
to match our other frameworks.
Rubber-stamped by Sam Weinig.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 24 Aug 2010 20:26:41 +0000 (20:26 +0000)]
2010-08-24 Xan Lopez <xlopez@igalia.com>
Build fix, strike 2.
The unit tests are C files, so put the flag in global_cflags.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 24 Aug 2010 20:22:55 +0000 (20:22 +0000)]
2010-08-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Add test for a NodeFilter throwing
https://bugs.webkit.org/show_bug.cgi?id=44480
The TreeWalker DOM spec says that an exception thrown inside the NodeFilter should
propagate out to the caller. This tests that.
* fast/dom/TreeWalker/filter-throw-expected.txt: Added.
* fast/dom/TreeWalker/filter-throw.html: Added.
* fast/dom/TreeWalker/script-tests/filter-throw.js: Added.
(walker.document.createTreeWalker):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 24 Aug 2010 20:20:37 +0000 (20:20 +0000)]
2010-08-24 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
Move GTK_API_VERSION_2 define to here, since we want to use it
outside of WebCore/WebKit.
* GNUmakefile.am:
WebCore:
2010-08-24 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
Move GTK_API_VERSION_2 define out.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 24 Aug 2010 20:08:41 +0000 (20:08 +0000)]
2010-08-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
TreeWalker traversal order is wrong when skipping and rejecting
https://bugs.webkit.org/show_bug.cgi?id=44377
TreeWalker's nextSibling() and previousSibling() behaved incorrectly
when traversing down a subtree where all nodes are skipped; it backed all
the way up to the root of the subtree, then jump to the subtree's parentNode.
This would skip later siblings.
Fix by resetting 'node' when traversing to children so that node = node->parentNode()
gets the correct node later.
Test: fast/dom/TreeWalker/traversal-skip-most.html
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 24 Aug 2010 19:55:22 +0000 (19:55 +0000)]
WebKit/gtk:
2010-08-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Set a device to the event struct when building with GTK+ 3.x, it's
mandatory.
* tests/testcopyandpaste.c:
(runPasteTestCallback):
WebKitTools:
2010-08-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Set a device to the event struct when building with GTK+ 3.x, it's
mandatory.
* DumpRenderTree/gtk/EventSender.cpp:
(keyDownCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 24 Aug 2010 19:52:25 +0000 (19:52 +0000)]
2010-08-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Remove null-checks from DeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=44504
Remove checks for m_client being NULL from DeviceOrientationController.
It will never be NULL, and this is checked by an ASSERT on construction.
Will be covered by layout tests for device orientation.
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::addListener):
(WebCore::DeviceOrientationController::removeListener):
(WebCore::DeviceOrientationController::removeAllListeners):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 24 Aug 2010 19:39:06 +0000 (19:39 +0000)]
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+.
* tests/testkeyevents.c:
(key_press_event_cb):
(key_release_event_cb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 24 Aug 2010 19:26:40 +0000 (19:26 +0000)]
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
Fix an issue where a GdkEvent* is treated like a GdkEvent.
* tests/testkeyevents.c:
(key_press_event_cb):
(key_release_event_cb):
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
Fix two double-frees introduced in my previous commit.
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback): Copy the event before using it again.
(keyDownCallback): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 24 Aug 2010 19:17:19 +0000 (19:17 +0000)]
2010-08-24 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Fix accelerated 2d canvas with accelerated compositing off.
https://bugs.webkit.org/show_bug.cgi?id=44525
Tested by running with --enable-accelerated-2d-canvas with
--enable-accelerated-compositing off.
ImageBuffer::copyImage changes covered by
LayoutTests/fast/canvas/canvas-pattern-*.html.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
Extend the accelerated compositing check and the readback for
non-accelerated compositing to accelerated 2D canvas also.
* html/canvas/CanvasRenderingContext.cpp:
* html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer):
Move this logic from WebGL to common canvas context code.
* html/canvas/WebGLRenderingContext.h:
Remove implementation of paintsIntoCanvasBuffer.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
When copying the image for patterns, sync the software canvas.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::prepareForSoftwareDraw):
Use SkDevice::eraseColor() to clear the canvas for mixed mode rendering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 24 Aug 2010 19:00:56 +0000 (19:00 +0000)]
2010-08-24 Oliver Hunt <oliver@apple.com>
Reviewed by Beth Dakin.
Make overflow guards in UString::utf8 explicit
https://bugs.webkit.org/show_bug.cgi?id=44540
Add an explicit overflow check prior to allocating our buffer,
rather than implicitly relying on the guard in convertUTF16ToUTF8.
* runtime/UString.cpp:
(JSC::UString::utf8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 18:37:32 +0000 (18:37 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Deploy adoptPtr in WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=44501
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/TextIterator.cpp:
(WebCore::plainTextToMallocAllocatedBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 18:35:39 +0000 (18:35 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Deploy adoptPtr in WebCore/history
https://bugs.webkit.org/show_bug.cgi?id=44502
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::addRedirectURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 18:33:27 +0000 (18:33 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Partial deployment of adoptPtr to WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=44507
Deploy adoptPtr to some more places in WebCore/html. The big chunk
that I haven't done yet is createRenderer, but that's going to be a big
patch unto itself.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::formCollectionInfo):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::addElementAlias):
* html/HTMLInputElement.cpp:
(WebCore::createTypeMap):
(WebCore::HTMLInputElement::setInputType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::attach):
(WebCore::HTMLInputElement::preDispatchEventHandler):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::attach):
* html/HTMLToken.h:
(WebCore::HTMLToken::beginDOCTYPE):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::attach):
(WebCore::HTMLVideoElement::parseMappedAttribute):
* html/ValidityState.h:
(WebCore::ValidityState::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 24 Aug 2010 18:31:25 +0000 (18:31 +0000)]
2010-08-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Partial deployment of adoptPtr to WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=44507
There's a lot of places that need adoptPtr in WebCore/html. This patch
does some of them. More will follow.
* html/FileThreadTask.h:
(WebCore::FileThreadTask0::create):
(WebCore::FileThreadTask1::create):
(WebCore::FileThreadTask2::create):
(WebCore::FileThreadTask3::create):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::mapMouseEvent):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* html/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 24 Aug 2010 18:08:15 +0000 (18:08 +0000)]
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
* tests/testcopyandpaste.c:
(runPasteTestCallback): Switch to using gdk_event_new and also reference the GdkWindow.
when setting it on the event. It is dereferenced by gdk_event_free(...).
* tests/testhittestresult.c:
(load_status_cb): Switch to using gdk_event_new.
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
when setting it on the event. It is dereferenced by gdk_event_free(...).
(contextClickCallback): Ditto.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
(mouseMoveToCallback): Ditto.
(mouseWheelToCallback): Ditto.
(sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
(dispatchEvent): Ditto. Also free the event when we are done with it.
(keyDownCallback): Use gdk_event_new and reference the GdkWindow.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 24 Aug 2010 18:05:09 +0000 (18:05 +0000)]
2010-08-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
TreeWalker traversal order is wrong when skipping and rejecting
https://bugs.webkit.org/show_bug.cgi?id=44377
Add some tests for TreeWalker with node filters that skip and reject.
* fast/dom/TreeWalker/script-tests/traversal-reject.js: Added.
(rejectB1Filter.acceptNode):
(rejectB2Filter.acceptNode):
* fast/dom/TreeWalker/script-tests/traversal-skip.js: Added.
(skipB1Filter.acceptNode):
(skipB2Filter.acceptNode):
* fast/dom/TreeWalker/traversal-reject-expected.txt: Added.
* fast/dom/TreeWalker/traversal-reject.html: Added.
* fast/dom/TreeWalker/traversal-skip-expected.txt: Added.
* fast/dom/TreeWalker/traversal-skip.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 24 Aug 2010 18:03:45 +0000 (18:03 +0000)]
Improve comment for Simon.
Reviewed by Simon Fraser.
* editing/Editor.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 24 Aug 2010 17:59:22 +0000 (17:59 +0000)]
Paste event fires twice for mac WebKit
<rdar://problem/8094611>
https://bugs.webkit.org/show_bug.cgi?id=44535
Reviewed by Oliver Hunt.
WebCore:
The mac implementation of paste in WebKit was accidentally calling
Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
Use the new pasteAsPlainTextBypassingDHTML function to bypass the
second call.
Test: editing/pasteboard/paste-event-only-once.html
* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextBypassingDHTML):
* editing/Editor.h:
Expose a function which just pastes using from the general pasteboard,
bypassing all the checking and DHTML pasting.
WebKit/mac:
The mac implementation of paste in WebKit was accidentally calling
Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
Use the new pasteAsPlainTextBypassingDHTML function to bypass the
second call.
* WebView/WebHTMLView.mm:
(-[WebHTMLView paste:]):
LayoutTests:
* editing/pasteboard/paste-event-only-once-expected.txt: Added.
* editing/pasteboard/paste-event-only-once.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 24 Aug 2010 17:53:27 +0000 (17:53 +0000)]
2010-08-24 Nate Chapin <japhet@chromium.org>
Unreviewed.
Chromium build fix (add a #include missing in PingLoader.cpp)
* loader/PingLoader.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 24 Aug 2010 17:26:13 +0000 (17:26 +0000)]
2010-08-24 Nate Chapin <japhet@chromium.org>
Reviewed by David Levin.
Allow image loads triggered from unload handlers to run entirely
independently of any other loads or navigations.
https://bugs.webkit.org/show_bug.cgi?id=30457
Test: http/tests/navigation/image-load-in-unload-handler.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestImage): Use PingLoader for image
loads in unload handlers.
* loader/FrameLoader.h:
(WebCore::FrameLoader::pageDismissalEventBeingDispatched):
* loader/PingLoader.cpp: Added.
(WebCore::PingLoader::loadImage): Set the appropriate
headers for an image load in unload handler (since we're
not using SubresourceLoader, we need to do this manually here).
(WebCore::PingLoader::PingLoader):
* loader/PingLoader.h: Added.
(WebCore::PingLoader::~PingLoader):
(WebCore::PingLoader::didReceiveResponse):
(WebCore::PingLoader::didReceiveData):
(WebCore::PingLoader::didFinishLoading):
(WebCore::PingLoader::didFail):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log