WebKit-https.git
4 years agoWe should be able to inline getter/setter calls inside an inline cache even when...
sbarati@apple.com [Thu, 8 Oct 2015 19:37:28 +0000 (19:37 +0000)]
We should be able to inline getter/setter calls inside an inline cache even when the SpillRegistersMode is NeedsToSpill
https://bugs.webkit.org/show_bug.cgi?id=149601

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Before, if we had a PolymorphicAccess with and a StructureStubInfo
with a NeedToSpill spillMode, we wouldn't generate getter/setter
calls. This patch changes it such that we will generate the
getter/setter call and do the necessary register spilling/filling
around the getter/setter call to preserve any "usedRegisters".

This has an interesting story with how it relates to exception handling
inside the DFG. Because the GetById variants are considered a throwing call
site, we must make sure that we properly restore the registers spilled to the stack
in case of an exception being thrown inside the getter/setter call. We do
this by having the inline cache register itself as a new exception handling
call site. When the inline cache "catches" the exception (i.e, genericUnwind
will jump to this code), it will restore the registers it spilled that are
live inside the original catch handler, and then jump to the original catch
handler. We make sure to only generate this makeshift catch handler when we
actually need to do any cleanup. If we determine that we don't need to restore
any registers, we don't bother generating this makeshift catch handler.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::removeExceptionHandlerForCallSite):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::appendExceptionHandler):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::AccessGenerationState):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessGenerationState::preserveLiveRegistersToStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCallWithThrownException):
(JSC::AccessGenerationState::liveRegistersForCall):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandlingOrOriginal):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::AccessGenerationState::originalExceptionHandler):
(JSC::AccessGenerationState::numberOfStackBytesUsedForRegisterPreservation):
(JSC::AccessGenerationState::needsToRestoreRegistersIfException):
(JSC::AccessGenerationState::originalCallSiteIndex):
(JSC::AccessGenerationState::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::regenerate):
(JSC::PolymorphicAccess::aboutToDie):
* bytecode/PolymorphicAccess.h:
(JSC::AccessCase::doesCalls):
(JSC::AccessCase::isGetter):
(JSC::AccessCase::callLinkInfo):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):
* bytecode/StructureStubInfo.h:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isInJSValueRegs):
(JSC::ValueRecovery::fpr):
* dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addCodeOriginUnconditionally):
(JSC::DFG::CommonData::lastCallSite):
(JSC::DFG::CommonData::removeCallSiteIndex):
(JSC::DFG::CommonData::shrinkToFit):
* dfg/DFGCommonData.h:
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
* dfg/DFGOSRExit.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::validateReferences):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
* ftl/FTLJITCode.h:
(JSC::FTL::JITCode::handles):
(JSC::FTL::JITCode::dataSections):
* jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
(JSC::createJITStubRoutine):
* jit/GCAwareJITStubRoutine.h:
* jit/JITCode.cpp:
(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
* jit/JITCode.h:
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
* jit/JITInlineCacheGenerator.h:
(JSC::JITByIdGenerator::reportSlowPathCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/JITStubRoutine.h:
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::aboutToDie):
* jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForCall):
(JSC::RegisterSet::allGPRs):
* jit/RegisterSet.h:
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
* jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::usedRegistersForCall):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBufferForCall):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBufferForCall):
(JSC::ScratchRegisterAllocator::preserveRegistersToStackForCall):
(JSC::ScratchRegisterAllocator::restoreRegistersFromStackForCall):
* jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::usedRegisters):
* jsc.cpp:
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::Element::handleOwner):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionCreateCustomGetterObject):
(functionSetImpureGetterDelegate):
* tests/stress/try-catch-custom-getter-as-get-by-id.js: Added.
(assert):
(bar):
(foo):
* tests/stress/try-catch-getter-as-get-by-id-register-restoration.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
* tests/stress/try-catch-getter-as-get-by-id.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
* tests/stress/try-catch-setter-as-put-by-id.js: Added.
(assert):
(o1.set f):
(bar):
(foo):
* tests/stress/try-catch-stub-routine-replaced.js: Added.
(assert):
(arr):
(hello):
(foo):
(objChain.get f):
(fakeOut.get f):
(o.get f):

LayoutTests:

* js/regress/custom-setter-getter-as-put-get-by-id-expected.txt: Added.
* js/regress/custom-setter-getter-as-put-get-by-id.html: Added.
* js/regress/script-tests/custom-setter-getter-as-put-get-by-id.js: Added.
(assert):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFallback to the RenderView when repaint container is null.
zalan@apple.com [Thu, 8 Oct 2015 18:46:20 +0000 (18:46 +0000)]
Fallback to the RenderView when repaint container is null.
https://bugs.webkit.org/show_bug.cgi?id=149903

Reviewed by Simon Fraser.

Reduces code complexity at the calling sites.

No change in functionality.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agofast/events/scroll-after-click-on-tab-index.html is flaky
ap@apple.com [Thu, 8 Oct 2015 17:44:18 +0000 (17:44 +0000)]
fast/events/scroll-after-click-on-tab-index.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149859

Reviewed by Simon Fraser.

* fast/events/scroll-after-click-on-tab-index-expected.txt:
* fast/events/scroll-after-click-on-tab-index.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd NULL check for renderBox::layer() on applying zoom level change
commit-queue@webkit.org [Thu, 8 Oct 2015 17:40:09 +0000 (17:40 +0000)]
Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/zoom-on-nested-scroll-crash.html

This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):

LayoutTests:

* fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
* fast/css/zoom-on-nested-scroll-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate Inspector to only work with Legacy IDB (for now).
beidson@apple.com [Thu, 8 Oct 2015 17:35:25 +0000 (17:35 +0000)]
Update Inspector to only work with Legacy IDB (for now).
https://bugs.webkit.org/show_bug.cgi?id=149928.

Reviewed by Tim Horton.

* Modules/indexeddb/IDBAny.h:
(WebCore::IDBAny::isLegacy):

* Modules/indexeddb/legacy/LegacyAny.h:
* inspector/InspectorIndexedDBAgent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash-only queues on bot watcher's dashboard should not have non-crashing tests in...
ap@apple.com [Thu, 8 Oct 2015 17:07:37 +0000 (17:07 +0000)]
Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
https://bugs.webkit.org/show_bug.cgi?id=149848

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
commit-queue@webkit.org [Thu, 8 Oct 2015 16:32:16 +0000 (16:32 +0000)]
Marking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=149859

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-08
Reviewed by Darin Adler.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrol...
antti@apple.com [Thu, 8 Oct 2015 16:26:40 +0000 (16:26 +0000)]
CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

* css/SelectorCheckerTestFunctions.h:
(WebCore::isWindowInactive):

    Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

* svg/css/use-window-inactive-crash-expected.html: Added.
* svg/css/use-window-inactive-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: An error view doesn't get expanded by clicking on the expand arrow
nvasilyev@apple.com [Thu, 8 Oct 2015 15:33:36 +0000 (15:33 +0000)]
Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
https://bugs.webkit.org/show_bug.cgi?id=149917

Reviewed by Timothy Hatcher.

* UserInterface/Views/ErrorObjectView.css:
(.error-object > .formatted-error::before):
(.error-object.expanded > .formatted-error::before):
(.error-object::before): Deleted.
(.error-object.expanded::before): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issues in NetworkCache.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:29:47 +0000 (15:29 +0000)]
Format string issues in NetworkCache.cpp
https://bugs.webkit.org/show_bug.cgi?id=149867

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issues in LegacyRequest.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:27:36 +0000 (15:27 +0000)]
Format string issues in LegacyRequest.cpp
https://bugs.webkit.org/show_bug.cgi?id=149866

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::enqueueEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFormat string issue in WebResourceLoadScheduler.cpp
mcatanzaro@igalia.com [Thu, 8 Oct 2015 15:27:06 +0000 (15:27 +0000)]
Format string issue in WebResourceLoadScheduler.cpp
https://bugs.webkit.org/show_bug.cgi?id=149868

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190716.
commit-queue@webkit.org [Thu, 8 Oct 2015 15:23:24 +0000 (15:23 +0000)]
Unreviewed, rolling out r190716.
https://bugs.webkit.org/show_bug.cgi?id=149924

broke mac build from time to time (Requested by youenn on
#webkit).

Reverted changeset:

"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190716

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the WASM build on Linux
ossy@webkit.org [Thu, 8 Oct 2015 15:20:52 +0000 (15:20 +0000)]
Fix the WASM build on Linux
https://bugs.webkit.org/show_bug.cgi?id=149919

Reviewed by Mark Lam.

* inspector/ScriptCallStackFactory.cpp:
* wasm/JSWASMModule.cpp:
* wasm/WASMFunctionCompiler.h:
(JSC::sizeOfMemoryType):
* wasm/WASMFunctionLLVMIRGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Percentages of indefinite sizes to be resolved as auto
svillar@igalia.com [Thu, 8 Oct 2015 13:28:54 +0000 (13:28 +0000)]
[css-grid] Percentages of indefinite sizes to be resolved as auto
https://bugs.webkit.org/show_bug.cgi?id=149810

Reviewed by Darin Adler.

Specs mention that percentages in grid track sizes must be
resolved as 'auto' if the grid container has an indefinite
size in the corresponding axis.

The 'auto' keyword used to be resolved as
minmax(min-content,max-content) but since r189911 it's
resolved as minmax(auto,auto). Updated the implementation so
we properly resolve those percentages.

No new tests as the behavior does not change at all. That's
because 'auto' as min-track sizing function is the same as
min-content (unless we have a specified value for
min-{width|height}, but those cases were already handled in the
code), and as a max sizing function is works as max-content.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed CLOOP buildfix after r190718.
ossy@webkit.org [Thu, 8 Oct 2015 12:26:55 +0000 (12:26 +0000)]
Unreviewed CLOOP buildfix after r190718.

* jit/Repatch.h:
(JSC::resetGetByID): Deleted.
(JSC::resetPutByID): Deleted.
(JSC::resetIn): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove PageReservation.h clang fixme that has been fixed for a while
commit-queue@webkit.org [Thu, 8 Oct 2015 10:37:43 +0000 (10:37 +0000)]
Remove PageReservation.h clang fixme that has been fixed for a while
https://bugs.webkit.org/show_bug.cgi?id=149908

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-08
Reviewed by Csaba Osztrogonác.

* wtf/PageReservation.h:
(WTF::PageReservation::operator bool): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove references to removed class RepatchBuffer
commit-queue@webkit.org [Thu, 8 Oct 2015 10:33:04 +0000 (10:33 +0000)]
Remove references to removed class RepatchBuffer
https://bugs.webkit.org/show_bug.cgi?id=149909

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-08
Reviewed by Csaba Osztrogonác.

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARM64.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerSH4.h:
* assembler/MacroAssemblerX86.h:
* assembler/MacroAssemblerX86_64.h:
* jit/JITStubRoutine.h:
* jit/Repatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Stop using a nested main loop for popup menus
carlosgc@webkit.org [Thu, 8 Oct 2015 10:06:41 +0000 (10:06 +0000)]
[GTK] Stop using a nested main loop for popup menus
https://bugs.webkit.org/show_bug.cgi?id=149920

Reviewed by Sergio Villar Senin.

Source/WebKit2:

WebPageProxy used to expect the popup menus to run in a nested
main loop and invalidated the menu right after showing it. But
this is no longer the case, so there's no reason to keep using
the nested main loop.

* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
(WebKit::WebPopupMenuProxyGtk::menuItemActivated):
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): Deleted.
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Deleted.
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): Deleted.
(WebKit::WebPopupMenuProxyGtk::menuUnmapped): Deleted.
* UIProcess/gtk/WebPopupMenuProxyGtk.h:
(WebKit::WebPopupMenuProxyGtk::setActiveItem): Deleted.

LayoutTests:

Unskip platform/gtk/fast/forms/menulist-typeahead-find.html that
was timing out because of the nested main loop.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAutomate WebCore JS builtins generation and build system
youenn.fablet@crf.canon.fr [Thu, 8 Oct 2015 09:55:30 +0000 (09:55 +0000)]
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Source/JavaScriptCore:

* generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins.
Added auto generation of WebCoreJSBuiltinInternals.h which contain a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
Renamed WebCoreJSClientData to JSVMClientData.

The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.

Covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/streams/ByteLengthQueuingStrategy.js:
* Modules/streams/CountQueuingStrategy.js:
* Modules/streams/ReadableStream.js:
* Modules/streams/ReadableStreamInternals.js:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
* bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
* generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed GTK+ gardening. Mark several inspector tests as slow.
carlosgc@webkit.org [Thu, 8 Oct 2015 07:33:59 +0000 (07:33 +0000)]
Unreviewed GTK+ gardening. Mark several inspector tests as slow.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBinding generated JS constructors should use GlobalObject references
youenn.fablet@crf.canon.fr [Thu, 8 Oct 2015 07:30:23 +0000 (07:30 +0000)]
Binding generated JS constructors should use GlobalObject references
https://bugs.webkit.org/show_bug.cgi?id=149872

Reviewed by Darin Adler.

Updated binding generator to generate JS DOM constructors code with JSDOMGlobalOBject references.
Updated WebCore JS binding layer accordingly.

Covered by updated binding tests.

* bindings/js/DOMConstructorWithDocument.h:
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::createJSBuiltin):
(WebCore::createWrapper):
* bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::image):
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
(WebCore::JSImageConstructor::createStructure):
* bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createJSObject):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createJSObject):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getConstructor):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::create):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::createStructure):
(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):
(WebCore::JSTestCallback::getConstructor):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::createStructure):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getConstructor):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::create):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::create):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::createStructure):
(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getConstructor):
* bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::create):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):
(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::getConstructor):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::create):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getConstructor):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::create):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::getConstructor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructor::getNamedConstructor):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::create):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::createStructure):
(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):
(WebCore::JSTestNodeConstructor::finishCreation):
(WebCore::JSTestNode::JSTestNode):
(WebCore::JSTestNode::getConstructor):
* bindings/scripts/test/JS/JSTestNode.h:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::createStructure):
(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::JSTestNondeterministic::getConstructor):
* bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::create):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getConstructor):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getConstructor):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::create):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::createStructure):
(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getConstructor):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::create):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getConstructor):
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::create):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::createStructure):
(WebCore::JSattributeConstructor::JSattributeConstructor):
(WebCore::JSattributeConstructor::finishCreation):
(WebCore::JSattribute::JSattribute):
(WebCore::JSattribute::getConstructor):
* bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::create):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::createStructure):
(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):
(WebCore::JSreadonlyConstructor::finishCreation):
(WebCore::JSreadonly::JSreadonly):
(WebCore::JSreadonly::getConstructor):
* bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Add event names needed by updated RTCPeerConnection
commit-queue@webkit.org [Thu, 8 Oct 2015 07:21:41 +0000 (07:21 +0000)]
WebRTC: Add event names needed by updated RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=149875

Patch by Philippe Normand <pnormand@igalia.com> on 2015-10-08
Reviewed by Eric Carlson.

The track event name was recently added in the WebRTC spec. The
icegatheringstatechange event has been part of the spec for a while but
was not registered in our DOM events.

* dom/EventNames.h: Add track and icegatheringstatechange even names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoClean up Copied classes
commit-queue@webkit.org [Thu, 8 Oct 2015 03:48:20 +0000 (03:48 +0000)]
Clean up Copied classes
https://bugs.webkit.org/show_bug.cgi?id=149863

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-07
Reviewed by Saam Barati.

* heap/CopiedAllocator.h:
(JSC::CopiedAllocator::isValid):
* heap/CopiedBlock.h:
* heap/CopiedBlockInlines.h:
* heap/CopiedSpace.cpp:
* heap/CopiedSpace.h:
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::shouldDoCopyPhase):
* heap/CopiedSpaceInlines.h:
* heap/CopyToken.h:
* heap/CopyVisitor.cpp:
* heap/CopyVisitor.h:
* heap/CopyVisitorInlines.h:
* heap/CopyWorkList.h:
* heap/HandleBlock.h:
* heap/HandleSet.h:
* heap/HeapHelperPool.cpp:
* heap/HeapHelperPool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed race condition fix. Exit early when xScale or yScale is not defined.
rniwa@webkit.org [Thu, 8 Oct 2015 03:12:17 +0000 (03:12 +0000)]
Unreviewed race condition fix. Exit early when xScale or yScale is not defined.

* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateRangeBarRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoscript.text shouldn't include text from non-direct children of the script element
commit-queue@webkit.org [Thu, 8 Oct 2015 02:26:13 +0000 (02:26 +0000)]
script.text shouldn't include text from non-direct children of the script element
https://bugs.webkit.org/show_bug.cgi?id=148851
<rdar://problem/22587759>

Patch by Keith Rollin <krollin@apple.com> on 2015-10-07
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline several W3C HTML tests now that new checks are passing.

* web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-xhtml-expected.txt:

Source/WebCore:

Don't include text from non-direct children in script.text. Per:
https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
Chrome and Firefox behavior match the spec.

Test: fast/dom/script-subtext-in-script-elements.html

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptContent):

LayoutTests:

script-getElementById-during-insertion removed because it no longer
runs correctly with this change.

* fast/dom/script-getElementById-during-insertion-expected.txt: Removed.
* fast/dom/script-getElementById-during-insertion.html: Removed.
* fast/dom/script-subtext-in-script-elements-expected.txt: Added.
* fast/dom/script-subtext-in-script-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd a page that cycles through v2 dashboards
rniwa@webkit.org [Thu, 8 Oct 2015 02:06:40 +0000 (02:06 +0000)]
Add a page that cycles through v2 dashboards
https://bugs.webkit.org/show_bug.cgi?id=149907

Reviewed by Chris Dumez.

Add cycler.html that goes through each dashboard on v2 UI.

This allows the dashboards to be cycled through on a TV screen.

* public/cycler.html: Added.
(loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
at the end of body. We don't immediately show the new iframe since it might take a while to load.
(showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
charts are still in progress to be shown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPartial revert of r187626 as it caused a PLT regression
cdumez@apple.com [Thu, 8 Oct 2015 02:06:37 +0000 (02:06 +0000)]
Partial revert of r187626 as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898

Reviewed by Myles C. Maxfield.

Do a partial revert of r187626 as it caused a regression on PLT.

* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest font-variant-* and font-feature-settings with TrueType fonts
mmaxfield@apple.com [Thu, 8 Oct 2015 00:55:00 +0000 (00:55 +0000)]
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776

Unreviewed follow up to r190697.

* css3/font-variant-all-webfont-expected.html:
* css3/font-variant-all-webfont.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Follow up 2] Disable tail calls because it is breaking some sites.
mark.lam@apple.com [Thu, 8 Oct 2015 00:47:59 +0000 (00:47 +0000)]
[Follow up 2] Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Rubber stamped by Saam Barati.

Also need to surpress JSC tail call tests.

* tests/es6.yaml:
* tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
* tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-in-inline-cache.js:
(tail):
* tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-recognize.js:
(callerMustBeRun):
* tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Support 64-bit Build and Testing
bfulgham@apple.com [Thu, 8 Oct 2015 00:35:57 +0000 (00:35 +0000)]
[Win] Support 64-bit Build and Testing
https://bugs.webkit.org/show_bug.cgi?id=149904

Reviewed by Daniel Bates.

Extend our existing scripts to support 64-bit build and test operations on
Windows.

* Scripts/build-dumprendertree: We don't need to build DRT on its own;
Windows always builds the whole stack.
* Scripts/webkit-build-directory: Add an option to return the location of
the executable files produced by a specific configuration. This change is
actually useful for Gtk and EFL, too.
* Scripts/webkitdirs.pm:
(executableProductDir): Added. This function appends the proper binary
path to the productDir. This is useful for Windows, Gtk, and EFL ports.
(jscProductDir): Use the new 'executableProductDir' method.
(setPathForRunningWebKitApp): Ditto.
(runSafari): Ditto.
(runMiniBrowser): Ditto.
* Scripts/webkitpy/port/factory.py:
(configuration_options): Add a 64-bit option, used on Windows to specify
which binary target should be used for testing.
* Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
processes when needed.
(WinPort._build_path): Add the correct binary target path to _build_path.
(WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
64-bit paths for 64-bit tests.
(WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
NTSD debugger does not understand this argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest font-variant-* and font-feature-settings with TrueType fonts
mmaxfield@apple.com [Thu, 8 Oct 2015 00:33:55 +0000 (00:33 +0000)]
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776

Reviewed by Simon Fraser.

Tools:

This test extends our existing FontWithFeatures project to be able to generate a
TrueType font. This font is conceptually similar as the existing OpenType font,
except the feature -> character mapping is different.

The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.
The letter "A" always is a check mark.
The letter "B" always is an X.
Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when
"kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
mark.

Here are the mappings of font features to letters:
kLigaturesType / kCommonLigaturesOnSelector: C
kLigaturesType / kContextualLigaturesOnSelector: D
kLigaturesType / kRareLigaturesOnSelector: G
kLigaturesType / kHistoricalLigaturesOnSelector: I
kContextualAlternatesType / kContextualAlternatesOnSelector: L
kVerticalPositionType / kInferiorsSelector: O
kVerticalPositionType / kSuperiorsSelector: P
kLowerCaseType / kLowerCaseSmallCapsSelector: S
kUpperCaseType / kUpperCaseSmallCapsSelector: V
kLowerCaseType / kLowerCasePetiteCapsSelector: T
kUpperCaseType / kUpperCasePetiteCapsSelector: W
kLetterCaseType / 14: Y
kStyleOptionsType / kTitlingCapsSelector: a
kNumberCaseType / kUpperCaseNumbersSelector: c
kNumberCaseType / kLowerCaseNumbersSelector: d
kNumberSpacingType / kProportionalNumbersSelector: f
kNumberSpacingType / kMonospacedNumbersSelector: g
kFractionsType / kDiagonalFractionsSelector: i
kFractionsType / kVerticalFractionsSelector: j
kVerticalPositionType / kOrdinalsSelector: Q
kTypographicExtrasType / kSlashedZeroOnSelector: k
kLigaturesType / kHistoricalLigaturesOnSelector: K
kCharacterShapeType / kJIS1978CharactersSelector: m
kCharacterShapeType / kJIS1983CharactersSelector: n
kCharacterShapeType / kJIS1990CharactersSelector: o
kCharacterShapeType / kJIS2004CharactersSelector: p
kCharacterShapeType / kSimplifiedCharactersSelector: q
kCharacterShapeType / kTraditionalCharactersSelector: r
kTextSpacingType / kMonospacedTextSelector: t
kTextSpacingType / kProportionalTextSelector: u
kRubyKanaType / kRubyKanaOnSelector: v

* FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
* FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(GLYFBuilder::GLYFBuilder):
(GLYFBuilder::takeResult):
(GLYFBuilder::moveTo):
(GLYFBuilder::lineTo):
(GLYFBuilder::closePath):
(GLYFBuilder::writePoint):
(GLYFBuilder::append16):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(itemForGlyph):
(Generator::generate):
(Generator::insertSelector):
(Generator::insertFeature):
(Generator::generateFeatureDescription):
(Generator::appendCFFTable):
(Generator::appendGLYFTable):
(Generator::appendLOCATable):
(Generator::appendFEATTable):
(Generator::appendMetamorphosisChain):
(Generator::appendMORXTable):
(Generator::appendHEADTable):
(Generator::appendHMTXTable):
(Generator::appendNameSubtable):
(Generator::append2ByteASCIIString):
(Generator::appendNAMETable):
(generateFont):
(CFFBuilder::curveToCubic): Deleted.
(charStringForGlyph): Deleted.
* FontWithFeatures/FontWithFeatures/FontCreator.h:
* FontWithFeatures/FontWithFeatures/main.cpp:
(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
(drawTextWithFeature): Deleted.

LayoutTests:

* css3/font-feature-settings-rendering-2-expected.html:
* css3/font-feature-settings-rendering-2.html:
* css3/resources/FontWithFeatures.ttf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAllow custom revisions to be specified in A/B testing
rniwa@webkit.org [Thu, 8 Oct 2015 00:17:21 +0000 (00:17 +0000)]
Allow custom revisions to be specified in A/B testing
https://bugs.webkit.org/show_bug.cgi?id=149905

Reviewed by Chris Dumez.

Allow custom revision number on each "repository" when creating a test group.

* public/v2/app.css:
(form .analysis-group [name=customValue]): Added.

* public/v2/app.js:
(App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
Also added point labels such as (point 3) on "None" for when some points are missing revision info.
(App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
(App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
revision option is selected.

* public/v2/index.html: Added a text field for specifying a custom revision number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable tail calls because it is breaking some sites.
mark.lam@apple.com [Wed, 7 Oct 2015 23:34:41 +0000 (23:34 +0000)]
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Reviewed by Saam Barati.

Updating the expected test result because we disabled tail calls.

* js/caller-property-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling back in r190450
ggaren@apple.com [Wed, 7 Oct 2015 23:10:20 +0000 (23:10 +0000)]
Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

This time for sure?

The cause of the leak was an invalidated compilation.

There was vestigial manual memory management code that eagerly removed
a CodeBlock from the set of CodeBlocks if compilation was invalidated.
That's not cool since we rely on the set of CodeBlocks when we run
destructors.

The fix is to remove the vestigial code.

I ran the leaks, correctness, and performance tests locally and did not
see any problems.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd API for getting a group identifier from a bundle page
andersca@apple.com [Wed, 7 Oct 2015 22:56:21 +0000 (22:56 +0000)]
Add API for getting a group identifier from a bundle page
https://bugs.webkit.org/show_bug.cgi?id=149902

Reviewed by Tim Horton.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyGroupIdentifier):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable tail calls because it is breaking some sites.
mark.lam@apple.com [Wed, 7 Oct 2015 22:09:04 +0000 (22:09 +0000)]
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Reviewed by Saam Barati.

This is until we fix whatever the breakage is.

* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoURTBF after r190678 to fix GTK and EFL builds.
ossy@webkit.org [Wed, 7 Oct 2015 22:05:07 +0000 (22:05 +0000)]
URTBF after r190678 to fix GTK and EFL builds.

* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::setBundleParameters):
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setBundleParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd an LLVM IR generator for WebAssembly
sukolsak@gmail.com [Wed, 7 Oct 2015 21:57:22 +0000 (21:57 +0000)]
Add an LLVM IR generator for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149486

Reviewed by Mark Lam.

This patch adds initial support for an LLVM IR generator in WebAssembly
(polyfill-prototype-1 format). All the methods will be implemented in
subsequent patches.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wasm/WASMFunctionLLVMIRGenerator.h: Added.
(JSC::WASMFunctionLLVMIRGenerator::MemoryAddress::MemoryAddress):
(JSC::WASMFunctionLLVMIRGenerator::startFunction):
(JSC::WASMFunctionLLVMIRGenerator::endFunction):
(JSC::WASMFunctionLLVMIRGenerator::buildSetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildSetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildReturn):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateI32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF64):
(JSC::WASMFunctionLLVMIRGenerator::buildGetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildGetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildConvertType):
(JSC::WASMFunctionLLVMIRGenerator::buildLoad):
(JSC::WASMFunctionLLVMIRGenerator::buildStore):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalI32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF64):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxI32):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxF64):
(JSC::WASMFunctionLLVMIRGenerator::buildCallInternal):
(JSC::WASMFunctionLLVMIRGenerator::buildCallIndirect):
(JSC::WASMFunctionLLVMIRGenerator::buildCallImport):
(JSC::WASMFunctionLLVMIRGenerator::appendExpressionList):
(JSC::WASMFunctionLLVMIRGenerator::discard):
(JSC::WASMFunctionLLVMIRGenerator::linkTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTargetIf):
(JSC::WASMFunctionLLVMIRGenerator::startLoop):
(JSC::WASMFunctionLLVMIRGenerator::endLoop):
(JSC::WASMFunctionLLVMIRGenerator::startSwitch):
(JSC::WASMFunctionLLVMIRGenerator::endSwitch):
(JSC::WASMFunctionLLVMIRGenerator::startLabel):
(JSC::WASMFunctionLLVMIRGenerator::endLabel):
(JSC::WASMFunctionLLVMIRGenerator::breakTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueTarget):
(JSC::WASMFunctionLLVMIRGenerator::breakLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::buildSwitch):
* wasm/WASMFunctionParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190572, r190593, r190594, and
commit-queue@webkit.org [Wed, 7 Oct 2015 21:34:12 +0000 (21:34 +0000)]
Unreviewed, rolling out r190572, r190593, r190594, and
r190639.
https://bugs.webkit.org/show_bug.cgi?id=149897

Breaks Mavericks build (Requested by litherum on #webkit).

Reverted changesets:

"Allow WKRetainPtrs to be used as keys in hashing data
structures"
https://bugs.webkit.org/show_bug.cgi?id=149762
http://trac.webkit.org/changeset/190572

"REGRESSION(189668?): http/tests/notifications/events.html
flakily asserts or times out"
https://bugs.webkit.org/show_bug.cgi?id=149218
http://trac.webkit.org/changeset/190593

"Prospective Mavericks build fix."
http://trac.webkit.org/changeset/190594

"Post-review cleanup after r190572."
http://trac.webkit.org/changeset/190639

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, more Mac test gardening after r190629.
bburg@apple.com [Wed, 7 Oct 2015 21:25:58 +0000 (21:25 +0000)]
Unreviewed, more Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake the site name configurable in perf dashboard
rniwa@webkit.org [Wed, 7 Oct 2015 21:24:54 +0000 (21:24 +0000)]
Make the site name configurable in perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=149894

Reviewed by Chris Dumez.

Added "siteTitle" as a new configuration key to specify the site name.

* public/include/db.php:
(config): Now takes the default value as an argument.
* public/include/manifest.php:
(ManifestGenerator::generate): Include siteTitle in the manifest.
* public/index.html: Update the title and the heading when the manifest is loaded.
* public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
* public/v2/manifest.js:
(App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoProvide a way to get a WKFrameInfoRef from a WKFrameRef
andersca@apple.com [Wed, 7 Oct 2015 21:19:15 +0000 (21:19 +0000)]
Provide a way to get a WKFrameInfoRef from a WKFrameRef
https://bugs.webkit.org/show_bug.cgi?id=149896
rdar://problem/23016081

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameInfo):
* UIProcess/API/C/WKFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRenderObject::computeRectForRepaint/computeFloatRectForRepaint should return the...
zalan@apple.com [Wed, 7 Oct 2015 21:14:16 +0000 (21:14 +0000)]
RenderObject::computeRectForRepaint/computeFloatRectForRepaint should return the computed rectangle.
https://bugs.webkit.org/show_bug.cgi?id=149883

Reviewed by Simon Fraser.

Reduces code complexity at the calling sites.

No change in functionality.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderInline.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
* rendering/RenderObject.h:
(WebCore::RenderObject::computeAbsoluteRepaintRect):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
* rendering/svg/SVGRenderSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGet rid of LLInt inline/out-of-line storage helpers, they are unused
fpizlo@apple.com [Wed, 7 Oct 2015 21:12:15 +0000 (21:12 +0000)]
Get rid of LLInt inline/out-of-line storage helpers, they are unused
https://bugs.webkit.org/show_bug.cgi?id=149892

Reviewed by Mark Lam.

Just killing dead code.

* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd unreachable URL to _WKObservablePageState
andersca@apple.com [Wed, 7 Oct 2015 20:46:24 +0000 (20:46 +0000)]
Add unreachable URL to _WKObservablePageState
https://bugs.webkit.org/show_bug.cgi?id=149893
<rdar://problem/23017235>

Reviewed by Dan Bernstein.

* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState unreachableURL]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDon't setOutOfBounds in JIT code for PutByVal, since the C++ slow path already does it
fpizlo@apple.com [Wed, 7 Oct 2015 20:27:46 +0000 (20:27 +0000)]
Don't setOutOfBounds in JIT code for PutByVal, since the C++ slow path already does it
https://bugs.webkit.org/show_bug.cgi?id=149885

Reviewed by Geoffrey Garen.

This simplifies the slow path code, which will make it easier to put read barriers on all of
the butterflies.

* jit/JITOperations.cpp:
(JSC::getByVal):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGet rid of JIT::compilePutDirectOffset
fpizlo@apple.com [Wed, 7 Oct 2015 20:25:29 +0000 (20:25 +0000)]
Get rid of JIT::compilePutDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=149884

Reviewed by Andreas Kling.

I'm finding more dead code.

* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::compilePutDirectOffset): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement :host pseudo class
antti@apple.com [Wed, 7 Oct 2015 19:59:32 +0000 (19:59 +0000)]
Implement :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=149440
Source/WebCore:

rdar://problem/22731953

Reviewed by Ryosuke Niwa.

This implements the basic non-function :host syntax.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchUserRules):
* css/ElementRuleCollector.h:
* css/RuleSet.cpp:
(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):
* css/RuleSet.h:
(WebCore::RuleSet::cuePseudoRules):
(WebCore::RuleSet::hostPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

Reviewed by Ryosuke Niwa.

* fast/shadow-dom/css-scoping-shadow-host-rule.html:

    Fix and expand the test case.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHeap::isWriteBarrierEnabled is unused
commit-queue@webkit.org [Wed, 7 Oct 2015 19:41:28 +0000 (19:41 +0000)]
Heap::isWriteBarrierEnabled is unused
https://bugs.webkit.org/show_bug.cgi?id=149881

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-07
Reviewed by Geoffrey Garen.

* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::isWriteBarrierEnabled): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
andersca@apple.com [Wed, 7 Oct 2015 19:40:17 +0000 (19:40 +0000)]
Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
https://bugs.webkit.org/show_bug.cgi?id=149887

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]):
Copy the dictionary, archive it, and set the values on the UI side bundle parameter data struct.

* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Add new SPI.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParameter:forKey:]):
We can just call setValue:forKey: on the dictionary; it will do the right thing if value is nil.

(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Enumerate the dictionary and call setValue:forKey: on each key/value pair.

* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):
If we fail to unarchive a parameter, don't set it to null.

(WebKit::InjectedBundle::setBundleParameters):
Unarchive the dictionary and update the bundle parameters.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInjectedBundleParameters):
Call the injected bundle.

* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Add new message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, more Mac test gardening after r190629.
bburg@apple.com [Wed, 7 Oct 2015 19:28:29 +0000 (19:28 +0000)]
Unreviewed, more Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPerf dashboard doesn't show analysis tasks anchored at outliers
rniwa@webkit.org [Wed, 7 Oct 2015 18:38:07 +0000 (18:38 +0000)]
Perf dashboard doesn't show analysis tasks anchored at outliers
https://bugs.webkit.org/show_bug.cgi?id=149870

Reviewed by Chris Dumez.

The bug was caused by the computation of start and end times of analysis tasks being dependent on
time series provided to the interactive chart component even though they are already filtered.

Since the interactive chart component shouldn't be messing with the underlying data models, moved
the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
the unfiltered time series newly exposed on ChartData.

Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.

* public/admin/fetch-from-remote.php:
(.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
and Ember can start hanging browsers (took me three hours to debug this).

* public/v2/app.js:
(App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
(App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
Filter the results manually instead.
(App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
(App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
need to call a private method on it.
(App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
This will cause chartData to be modified so just exit early and wait for getting called again.

* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
to App.Pane.ranges.

* public/v2/manifest.js:
(App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
to compute the end points of analysis tasks when their end points are outliers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
fpizlo@apple.com [Wed, 7 Oct 2015 18:26:19 +0000 (18:26 +0000)]
JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
https://bugs.webkit.org/show_bug.cgi?id=149879

Reviewed by Saam Barati.

To simplify my work to insert barriers on loads of the butterfly, I want to reduce the amount
of abstraction we have around code that loads the butterfly.

* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: ARIA 1.1 @aria-placeholder
n_wang@apple.com [Wed, 7 Oct 2015 18:17:56 +0000 (18:17 +0000)]
AX: ARIA 1.1 @aria-placeholder
https://bugs.webkit.org/show_bug.cgi?id=148970

Reviewed by Chris Fleizach.

Source/WebCore:

Added support for aria-placeholder attribute.

Modified accessibility/placeholder.html test.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::placeholderValue):
* html/HTMLAttributeNames.in:

LayoutTests:

* accessibility/placeholder-expected.txt:
* accessibility/placeholder.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJIT::compileGetDirectOffset is useless
fpizlo@apple.com [Wed, 7 Oct 2015 18:04:54 +0000 (18:04 +0000)]
JIT::compileGetDirectOffset is useless
https://bugs.webkit.org/show_bug.cgi?id=149878

Reviewed by Mark Lam.

Two of the overloads of this method were never called. The other was called only from one
place, in a manner that rendered most of its code dead. This change removes the dead code and
folds the method into its one caller.

* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoInline caches should handle out-of-line offsets out-of-line
fpizlo@apple.com [Wed, 7 Oct 2015 17:28:38 +0000 (17:28 +0000)]
Inline caches should handle out-of-line offsets out-of-line
https://bugs.webkit.org/show_bug.cgi?id=149869

Reviewed by Saam Barati.

If we want to have a concurrent copying GC, then we need a read barrier on copied space
pointers. That makes the convertible load portion of the get_by_id/put_by_id inline caches
rather challenging. Currently we have a load instruction that we can turn into an add
instruction - the add case is when we have an inline offset, and the load case is when we
have an out-of-line offset and we need to load a copied space pointer. But if the load from
copied space requires a barrier, then there is no easy way to convert that back to the inline
case.

This patch removes the convertible load. The inline path of get_by_id/put_by_id only handles
the inline offsets. Out-of-line offsets are now handled using out-of-line stubs.

* bytecode/StructureStubInfo.h:
* ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
* jit/JITInlineCacheGenerator.h:
* jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
* runtime/JSObject.h:
(JSC::JSObject::butterflyTotalSize):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
(JSC::maxOffsetRelativeToBase):
(JSC::makeIdentifier):
(JSC::offsetRelativeToPatchedStorage): Deleted.
(JSC::maxOffsetRelativeToPatchedStorage): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoOops, did not mean to commit this.
andersca@apple.com [Wed, 7 Oct 2015 16:41:29 +0000 (16:41 +0000)]
Oops, did not mean to commit this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExpose the bundle parameter object on WKBundleRef
andersca@apple.com [Wed, 7 Oct 2015 16:39:49 +0000 (16:39 +0000)]
Expose the bundle parameter object on WKBundleRef
https://bugs.webkit.org/show_bug.cgi?id=149860

Reviewed by Tim Horton.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters description]):
Add a description that includes the parameters.

* WebProcess/InjectedBundle/API/c/mac/WKBundleMac.h:
* WebProcess/InjectedBundle/API/c/mac/WKBundleMac.mm:
(WKBundleGetParameters):
Add getter.

* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize):
Make sure to decode the bundle parameters before calling out to the bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoVersioning.
bshafiei@apple.com [Wed, 7 Oct 2015 16:29:18 +0000 (16:29 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190664.
commit-queue@webkit.org [Wed, 7 Oct 2015 16:11:46 +0000 (16:11 +0000)]
Unreviewed, rolling out r190664.
https://bugs.webkit.org/show_bug.cgi?id=149877

mac build is sometimes borken due to missing generated header
file (Requested by youenn on #webkit).

Reverted changeset:

"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190664

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agowill-change should trigger stacking context based purely on properties
simon.fraser@apple.com [Wed, 7 Oct 2015 15:09:02 +0000 (15:09 +0000)]
will-change should trigger stacking context based purely on properties
https://bugs.webkit.org/show_bug.cgi?id=148068

Reviewed by Zalan Bujtas.
Source/WebCore:

Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).

Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.

Test: fast/css/will-change/will-change-creates-stacking-context-inline.html

* rendering/RenderInline.cpp:
(WebCore::inFlowPositionedInlineAncestor):
* rendering/RenderInline.h:
(WebCore::RenderInline::willChangeCreatesStackingContext):
* rendering/style/WillChangeData.cpp:
(WebCore::propertyCreatesStackingContext):
(WebCore::WillChangeData::addFeature):
(WebCore::propertyCreatesStackingContextOnBoxesOnly): Deleted.
* rendering/style/WillChangeData.h:
(WebCore::WillChangeData::canCreateStackingContextOnInline): Deleted.

LayoutTests:

Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).

Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.

* platform/mac/TestExpectations: Fails on Mavericks because no backdrop-filter there.
* fast/css/will-change/resources/will-change-stacking-helper.js:
(makeStackingInline):
* fast/css/will-change/will-change-creates-stacking-context-inline-expected.html: Added.
* fast/css/will-change/will-change-creates-stacking-context-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] fast/repaint/block-inputrange-repaint.html is failed.
commit-queue@webkit.org [Wed, 7 Oct 2015 14:59:11 +0000 (14:59 +0000)]
[EFL] fast/repaint/block-inputrange-repaint.html is failed.
https://bugs.webkit.org/show_bug.cgi?id=149517

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-10-07
Reviewed by Zalan Bujtas.

EFL thumb size is different with mac port, it causes the difference of repaintRect.
So rebaseline the test with failure result.

* platform/efl/fast/repaint/block-inputrange-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CSS Grid Layout] Modify grid item height doesn't work
jfernandez@igalia.com [Wed, 7 Oct 2015 13:14:11 +0000 (13:14 +0000)]
[CSS Grid Layout] Modify grid item height doesn't work
https://bugs.webkit.org/show_bug.cgi?id=149840

Reviewed by Sergio Villar Senin.

Source/WebCore:

When computing the logical height of content-sized grid tracks we
need to clear grid item's override height if it needs to be laid
out again.

Currently we are doing so only in the case of percentage heights
or when the grid track's width has changed; these situations would
obviously mark grid items as needing layout.

However, there are other situations, like the one defined in this
bug, which would imply a new layout of the grid items; hence we
need to clear its override value if we want the layout logic to be
computed correctly.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):

LayoutTests:

Added new tests cases to verify content-sized grid tracks are resized
appropriately whenever grid item's height is changed.

* fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt: Added new test cases.
* fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html: Added new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAutomate WebCore JS builtins generation and build system
youenn.fablet@crf.canon.fr [Wed, 7 Oct 2015 12:52:33 +0000 (12:52 +0000)]
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Source/JavaScriptCore:

* generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins. Renamed WebCoreJSClientData to JSClientData.
Added auto generation of PrivateWebCoreJSBuiltins that is a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.

The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.

Covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/streams/ByteLengthQueuingStrategy.js:
* Modules/streams/CountQueuingStrategy.js:
* Modules/streams/ReadableStream.js:
* Modules/streams/ReadableStreamInternals.js:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
* bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
* generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Implement grid gutters
svillar@igalia.com [Wed, 7 Oct 2015 09:40:44 +0000 (09:40 +0000)]
[css-grid] Implement grid gutters
https://bugs.webkit.org/show_bug.cgi?id=149800

Reviewed by Darin Adler.

Source/WebCore:

Authors can now specify the gutters between grid lines, i.e.,
the space between two consecutive grid lines. This can be done
using the new '-webkit-grid-column-gap 'and
'-webkit-grid-row-gap' properties (or the '-webkit-grid-gap'
shorthand).

From the track sizing algorithm POV, gutters are treated as
fixed size columns. The primary consequence is that grids are
enlarged (depending on the number of tracks). Gutters also
affect the sizing of content-sized tracks and fr tracks as
long as the grid have spanning items. Those tracks will become
smaller as gutters will consume part of the item's size, so
the tracks won't need to grow as much as they used to.

Tests: fast/css-grid-layout/grid-gutters-and-alignment.html
       fast/css-grid-layout/grid-gutters-and-flex-content.html
       fast/css-grid-layout/grid-gutters-and-tracks.html
       fast/css-grid-layout/grid-gutters-get-set.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridGapShorthand):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):

LayoutTests:

Added several new test cases to verify that gutters are
properly considered when sizing and also to check that they do
not modify the current behavior. As many existing tests were
reused I took the chance to refactor some testing code related
to alignment so that it could be reused by many different
tests.

* fast/css-grid-layout/grid-align-content.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
* fast/css-grid-layout/grid-align.html:
* fast/css-grid-layout/grid-gutters-and-alignment-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-alignment.html: Added.
* fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-flex-content.html: Added.
* fast/css-grid-layout/grid-gutters-and-tracks-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-tracks.html: Added.
* fast/css-grid-layout/grid-gutters-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-get-set.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:
* fast/css-grid-layout/grid-justify-content.html:
* fast/css-grid-layout/resources/grid-alignment.css: Added.
(.alignSelfAuto):
(.alignSelfStretch):
(.alignSelfStart):
(.alignSelfEnd):
(.alignSelfCenter):
(.alignSelfRight):
(.alignSelfLeft):
(.alignSelfFlexStart):
(.alignSelfFlexEnd):
(.alignSelfSelfStart):
(.alignSelfSelfEnd):
(.alignItemsCenter):
(.alignContentBaseline):
(.alignContentLastBaseline):
(.alignContentStart):
(.alignContentEnd):
(.alignContentCenter):
(.alignContentLeft):
(.alignContentRight):
(.alignContentFlexStart):
(.alignContentFlexEnd):
(.justifyContentBaseline):
(.justifyContentLastBaseline):
(.justifyContentStart):
(.justifyContentEnd):
(.justifyContentCenter):
(.justifyContentLeft):
(.justifyContentRight):
(.justifyContentFlexStart):
(.justifyContentFlexEnd):
(.justifyContentSpaceBetween):
(.justifyContentSpaceAround):
(.justifyContentSpaceEvenly):
(.justifyContentStretch):
(.itemsCenter):
(.itemsEnd):
(.itemsLeft):
(.itemsRight):
(.itemsSelfStart):
(.itemsSelfEnd):
* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
(testGridGapDefinitionsValues):
* fast/css-grid-layout/resources/grid.css:
(.firstRowThirdColumn):
(.secondRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowFourthColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Progress bar is broken on recent GTK+
changseok.oh@collabora.com [Wed, 7 Oct 2015 07:32:14 +0000 (07:32 +0000)]
[GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.

Test: fast/dom/HTMLProgressElement/native-progress-bar.html

* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):

LayoutTests:

* fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Fix a typo in r190645.
rniwa@webkit.org [Wed, 7 Oct 2015 07:11:08 +0000 (07:11 +0000)]
Unreviewed. Fix a typo in r190645.

* public/include/db.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Add autocleanups
mcatanzaro@igalia.com [Wed, 7 Oct 2015 04:08:25 +0000 (04:08 +0000)]
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588

Reviewed by Darin Adler.

Source/WebCore:

* PlatformGTK.cmake:
* bindings/scripts/gobject-generate-headers.pl:

Source/WebKit2:

* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAutocleanups.h: Added.
* UIProcess/API/gtk/webkit2.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed iOS test gardening after r190629.
jhoneycutt@apple.com [Wed, 7 Oct 2015 03:35:26 +0000 (03:35 +0000)]
Unreviewed iOS test gardening after r190629.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPaint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
zalan@apple.com [Wed, 7 Oct 2015 02:51:29 +0000 (02:51 +0000)]
Paint artifacts when hovering on jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920

Reviewed by Simon Fraser.

When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.

When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.

Source/WebCore:

Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html

* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):

LayoutTests:

* css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
* fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
* fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
* fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMore unreviewed Windows test gardening after r190629.
jhoneycutt@apple.com [Wed, 7 Oct 2015 02:11:09 +0000 (02:11 +0000)]
More unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed Windows test gardening after r190629.
jhoneycutt@apple.com [Wed, 7 Oct 2015 02:07:19 +0000 (02:07 +0000)]
Unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
jer.noble@apple.com [Wed, 7 Oct 2015 01:24:54 +0000 (01:24 +0000)]
[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
https://bugs.webkit.org/show_bug.cgi?id=149845

Reviewed by Darin Adler.

When converting from time-as-double to MediaTime, a regression was introduced
when checking whether m_seekTo was set to a valid value or not. The clause
`time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed Mac test gardening after r190629.
jhoneycutt@apple.com [Wed, 7 Oct 2015 01:12:54 +0000 (01:12 +0000)]
Unreviewed Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename IDBRequestIdentifier to IDBResourceIdentifier.
beidson@apple.com [Wed, 7 Oct 2015 00:06:59 +0000 (00:06 +0000)]
Rename IDBRequestIdentifier to IDBResourceIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=149861

Reviewed by Alex Christensen.

No new tests (No change in behavior).

Turns out having an object representing a (connection ID + unique ID pair) is useful for more than just IDBRequests.

* CMakeLists.txt:
* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::IDBRequest):
* Modules/indexeddb/client/IDBRequestImpl.h:
(WebCore::IDBClient::IDBRequest::resourceIdentifier):
(WebCore::IDBClient::IDBRequest::requestIdentifier): Deleted.
* Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::requestIdentifier):
* Modules/indexeddb/shared/IDBResourceIdentifier.cpp: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.cpp.
(WebCore::nextResourceNumber):
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue):
* Modules/indexeddb/shared/IDBResourceIdentifier.h: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h.
(WebCore::IDBResourceIdentifier::isEmpty):
(WebCore::IDBResourceIdentifier::hash):
(WebCore::IDBResourceIdentifier::operator==):
(WebCore::IDBResourceIdentifier::connectionIdentifier):
(WebCore::IDBResourceIdentifierHash::hash):
(WebCore::IDBResourceIdentifierHash::equal):
(WebCore::IDBResourceIdentifierHashTraits::emptyValue):
(WebCore::IDBResourceIdentifierHashTraits::isEmptyValue):
(WebCore::IDBResourceIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBResourceIdentifierHashTraits::isDeletedValue):
* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
* Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::requestIdentifier):
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, try to fix the iOS 8 build after r190368.
bburg@apple.com [Wed, 7 Oct 2015 00:05:37 +0000 (00:05 +0000)]
Unreviewed, try to fix the iOS 8 build after r190368.

On older versions, IOHIDEventCreateForceEvent is not available.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Clicking on a stack trace link does not navigate to the corresponding...
nvasilyev@apple.com [Tue, 6 Oct 2015 23:22:39 +0000 (23:22 +0000)]
Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
https://bugs.webkit.org/show_bug.cgi?id=149405

lineNumber should be a number type but it was a string.

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.openURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
Keep lineNumber undefined when it isn't present in the string.
WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
when it wasn't found in the parsed string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd gmalloc option to run-javascriptcore-tests.
keith_miller@apple.com [Tue, 6 Oct 2015 22:40:45 +0000 (22:40 +0000)]
Add gmalloc option to run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=149858

Reviewed by Geoffrey Garen.

run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFactoring out op_sub baseline code generation into JITSubGenerator.
mark.lam@apple.com [Tue, 6 Oct 2015 22:29:27 +0000 (22:29 +0000)]
Factoring out op_sub baseline code generation into JITSubGenerator.
https://bugs.webkit.org/show_bug.cgi?id=149600

Reviewed by Geoffrey Garen.

We're going to factor out baseline code generation into snippet generators so
that we can later use them in the DFG and FTL to emit code for to perform the
JS operations where the operand types are predicted to be polymorphic.
We are starting in this patch with the implementation of op_sub.

What was done in this patch:
1. Created JITSubGenerator based on the baseline implementation of op_sub as
   expressed in compileBinaryArithOp() and compileBinaryArithOpSlowCase().
   I did not attempt to do write a more optimal version of op_sub.  I'll
   leave that to a later patch.

2. Convert the 32-bit op_sub baseline implementation to use the same
   JITSubGenerator which was based on the 64-bit implementation.  The
   pre-existing 32-bit baseline op_sub had handling for more optimization cases.
   However, a benchmark run shows that simply going with the 64-bit version
   (foregoing those extra optimizations) did not change the performance.

   Also, previously, the 32-bit version was able to move double results directly
   into the result location on the stack directly.  By using JITSubGenerator,
   we now always move that result into a pair of GPRs before storing it into
   the stack location.

3. Add some needed emitters to AssemblyHelpers that play nice with JSValueRegs.

* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::boxDouble):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::boxBooleanPayload):
* jit/JIT.h:
(JSC::JIT::linkDummySlowCase):
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_sub): Deleted.
(JSC::JIT::emitSub32Constant): Deleted.
(JSC::JIT::emitSlow_op_sub): Deleted.
* jit/JITInlines.h:
(JSC::JIT::linkSlowCaseIfNotJSCell):
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
(JSC::JIT::addSlowCase):
(JSC::JIT::emitLoad):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):
* jit/JITSubGenerator.h: Added.
(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::generateFastPath):
(JSC::JITSubGenerator::slowPathJumpList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements...
n_wang@apple.com [Tue, 6 Oct 2015 21:46:08 +0000 (21:46 +0000)]
AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
https://bugs.webkit.org/show_bug.cgi?id=132177

Reviewed by Chris Fleizach.

Source/WebCore:

Added role-specific defaults and changed general default to undefined.
Also added more elements to support aria-orientation on Mac.

Test: accessibility/mac/aria-orientation.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::isDescendantOfObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isColorWell):
(WebCore::AccessibilityObject::isSplitter):
(WebCore::AccessibilityObject::isToolbar):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::orientation):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::scrollBar):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

* accessibility/mac/aria-orientation-expected.txt: Added.
* accessibility/mac/aria-orientation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoV2 UI shouldn't sort dashboards lexicologically
rniwa@webkit.org [Tue, 6 Oct 2015 21:41:56 +0000 (21:41 +0000)]
V2 UI shouldn't sort dashboards lexicologically
https://bugs.webkit.org/show_bug.cgi?id=149856

Reviewed by Chris Dumez.

Don't sort the dashboards by name in App.Manifest.

* public/v2/app.js:
(App.IndexRoute.beforeModel): Don't transition to "undefined" (string) dashboard.
* public/v2/manifest.js:
(App.Manifest.._fetchedManifest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoV2 UI fails to show the data for the very first point in charts
rniwa@webkit.org [Tue, 6 Oct 2015 21:21:44 +0000 (21:21 +0000)]
V2 UI fails to show the data for the very first point in charts
https://bugs.webkit.org/show_bug.cgi?id=149857

Reviewed by Chris Dumez.

The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
Explicitly check the type of this property instead.

* public/v2/data.js:
(TimeSeries.prototype.seriesBetweenPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPerf dashboard should have the capability to test local UI with production data
rniwa@webkit.org [Tue, 6 Oct 2015 21:04:03 +0000 (21:04 +0000)]
Perf dashboard should have the capability to test local UI with production data
https://bugs.webkit.org/show_bug.cgi?id=149834

Reviewed by Chris Dumez.

Added tools/run-with-remote-server.py which runs a local httpd server and pulls data from a remote server.

* Install.md: Added the instruction on how to use the script. Also updated the remaining instructions
for El Capitan.
* config.json: Added remote server configurations.
* public/admin/fetch-from-remote.php: Added. This script fetches JSON from the remote server specified in
config.json and caches the results in the location specified as "cacheDirectory" in config.json.
(main):
(fetch_remote):
* public/include/db.php:
(config_path): Extracted from generate_data_file.
(generate_data_file):
* tools/remote-server-relay.conf: Added. Apache 2.4 configuration file for a local http server launched by
run-with-remote-server.py.
* tools/run-with-remote-server.py: Added. Launches Apache with the right set of directives.
(main):
(abspath_from_root):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
simon.fraser@apple.com [Tue, 6 Oct 2015 20:57:22 +0000 (20:57 +0000)]
Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
on iOS WK2.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WinCairo] GStreamer compile errors.
peavo@outlook.com [Tue, 6 Oct 2015 20:45:07 +0000 (20:45 +0000)]
[WinCairo] GStreamer compile errors.
https://bugs.webkit.org/show_bug.cgi?id=149839

Reviewed by Alex Christensen.

Help MSVC to resolve ambiguous calls.

* platform/graphics/MediaPlayer.h:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTake 2 on marking compositing/video/video-poster.html as flaky due to crashes.
commit-queue@webkit.org [Tue, 6 Oct 2015 20:43:36 +0000 (20:43 +0000)]
Take 2 on marking compositing/video/video-poster.html as flaky due to crashes.
https://bugs.webkit.org/show_bug.cgi?id=149819

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-06
Reviewed by Alexey Proskuryakov.

* platform/mac-elcapitan/TestExpectations: Removed.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRefactor TokenPreloadScanner::StartTagScanner::processAttribute()
cdumez@apple.com [Tue, 6 Oct 2015 20:40:52 +0000 (20:40 +0000)]
Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847

Reviewed by Antti Koivisto.

Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,
- We only process the charset parameter if the tag is a link or a script.
- We only process the sizes / srcset attributes if the tag is an img.

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Fix spacing of FindBanner prev/next buttons
commit-queue@webkit.org [Tue, 6 Oct 2015 20:28:25 +0000 (20:28 +0000)]
Web Inspector: Fix spacing of FindBanner prev/next buttons
https://bugs.webkit.org/show_bug.cgi?id=149717

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-10-06
Reviewed by Darin Adler.

The sizing and spacing of the previous and next buttons in the FindBanner
is slightly off and should be readjusted to ensure that both buttons are
the same size and have the same spacing.

* UserInterface/Views/FindBanner.css:
(.find-banner > button.segmented.right > .glyph):
(.find-banner > button.segmented):
(.find-banner > button.segmented > .glyph):
(.find-banner > button.segmented.left): Deleted.
(.find-banner > button.segmented.left > .glyph): Deleted.
(.find-banner > button.segmented.right): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPost-review cleanup after r190572.
mmaxfield@apple.com [Tue, 6 Oct 2015 20:26:32 +0000 (20:26 +0000)]
Post-review cleanup after r190572.

Unreviewed.

* TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTry to fix the 32-bit build.
andersca@apple.com [Tue, 6 Oct 2015 20:26:17 +0000 (20:26 +0000)]
Try to fix the 32-bit build.

* UIProcess/API/C/mac/WKPagePrivateMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBinding generator XXConstructor::finishCreation should take references as parameters
youenn.fablet@crf.canon.fr [Tue, 6 Oct 2015 20:14:08 +0000 (20:14 +0000)]
Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838

Reviewed by Darin Adler.

Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.

Covered by rebased binding tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed build correction.
bfulgham@apple.com [Tue, 6 Oct 2015 20:08:57 +0000 (20:08 +0000)]
[Win] Unreviewed build correction.

* TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
are soft-linked at runtime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
commit-queue@webkit.org [Tue, 6 Oct 2015 19:48:24 +0000 (19:48 +0000)]
Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/22747046>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003

Test: editing/style/apply-style-crash2.html
      editing/style/apply-style-crash3.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.

Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.

This CL also adds a few more assertions to catch similar issues
more easily in the future.

LayoutTests:

* editing/style/apply-style-crash2-expected.txt: Added.
* editing/style/apply-style-crash2.html: Added.
* editing/style/apply-style-crash3-expected.txt: Added.
* editing/style/apply-style-crash3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
jfernandez@igalia.com [Tue, 6 Oct 2015 19:23:52 +0000 (19:23 +0000)]
[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
https://bugs.webkit.org/show_bug.cgi?id=149764

Reviewed by Darin Adler.

Source/WebCore:

This patch implements a refactoring of the auto-margin alignment code for grid
items so it uses start/end and before/after margin logic terms.

I addition, it avoids resetting the auto-margin values, which requires an extra
layout, before applying the alignment logic.

No new tests because there is no behavior change.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeMarginLogicalHeightForChild): Computing margins if child needs layout.
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded): Using start/end logical margins.
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded): Using before/after logical margins.
(WebCore::RenderGrid::columnAxisOffsetForChild): Just added comment.
(WebCore::RenderGrid::rowAxisOffsetForChild): Just added comment.

LayoutTests:

Removed a duplicated layout tests.

* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt: Removed.
* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Simplify TimelineRecordBar a bit
commit-queue@webkit.org [Tue, 6 Oct 2015 19:13:46 +0000 (19:13 +0000)]
Web Inspector: Simplify TimelineRecordBar a bit
https://bugs.webkit.org/show_bug.cgi?id=149733

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-06
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.set records):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWKPage needs to expose a KVO-compliant object, similar to WKWebView
andersca@apple.com [Tue, 6 Oct 2015 19:11:24 +0000 (19:11 +0000)]
WKPage needs to expose a KVO-compliant object, similar to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=149851
rdar://problem/22382022

Reviewed by Dan Bernstein.

Move the PageLoadStateObserver object from WKBrowsingContextController out into a separate file and make it
work with any Objective-C object. Use it in WKObservablePageState and add a WKPageCreateObservableState function.

* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp.
(-[WKObservablePageState initWithPage:]):
(-[WKObservablePageState dealloc]):
(-[WKObservablePageState isLoading]):
(-[WKObservablePageState title]):
(-[WKObservablePageState URL]):
(-[WKObservablePageState hasOnlySecureContent]):
(-[WKObservablePageState estimatedProgress]):
(WKPageCreateObservableState):
(WKPageGetProcessIdentifier):
(WKPageIsURLKnownHSTSHost):
* UIProcess/API/Cocoa/PageLoadStateObserver.h: Added.
(WebKit::PageLoadStateObserver::PageLoadStateObserver):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a -...
keith_miller@apple.com [Tue, 6 Oct 2015 18:45:04 +0000 (18:45 +0000)]
Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
https://bugs.webkit.org/show_bug.cgi?id=149815

Reviewed by Filip Pizlo.

Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
so should just use one test runner.

* Scripts/run-javascriptcore-tests:
(runJSCStressTests):
(runMozillaTests): Deleted.
(defaultJsDriverArgsForMozillaTests): Deleted.
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImport some Blink layout tests.
jhoneycutt@apple.com [Tue, 6 Oct 2015 18:39:21 +0000 (18:39 +0000)]
Import some Blink layout tests.
https://bugs.webkit.org/show_bug.cgi?id=149768

These are a subset of tests that don't time out and whose expected
results in Blink match the results in WebKit when run under DRT and
WKTR.

Reviewed by Andy Estes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTile map shows a green rect when threaded scrolling is disabled
timothy_horton@apple.com [Tue, 6 Oct 2015 18:20:29 +0000 (18:20 +0000)]
Tile map shows a green rect when threaded scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=149716

Reviewed by Darin Adler.

Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190628 268f45cc-cd09-0410-ab3c-d52691b4dbfc