WebKit-https.git
13 years agoRemove reference to Unity. Reviewed by Zack.
staikos [Sun, 10 Dec 2006 03:57:00 +0000 (03:57 +0000)]
Remove reference to Unity.  Reviewed by Zack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon says : work with qmake shadow builds. Patch adds support
zack [Sun, 10 Dec 2006 03:27:14 +0000 (03:27 +0000)]
Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCrazy notion: make the font setting on widgets work.
zack [Sun, 10 Dec 2006 02:52:19 +0000 (02:52 +0000)]
Crazy notion: make the font setting on widgets work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoStop complaining about the nil renderer (granted the whole
zack [Sun, 10 Dec 2006 02:36:27 +0000 (02:36 +0000)]
Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix some rounding issues
zack [Sun, 10 Dec 2006 02:32:01 +0000 (02:32 +0000)]
Fix some rounding issues

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build for Qt 4.1 and less (for Qtopia mainly). By George.
zack [Sun, 10 Dec 2006 02:01:21 +0000 (02:01 +0000)]
Fix build for Qt 4.1 and less (for Qtopia mainly). By George.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCMake is too slow to make it the default build for us. This
zack [Sun, 10 Dec 2006 00:58:36 +0000 (00:58 +0000)]
CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThis is part of r 18111 commit - Use the Qt image
zack [Sun, 10 Dec 2006 00:44:17 +0000 (00:44 +0000)]
This is part of r 18111 commit - Use the Qt image
loading framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCompile after latest WebKit changes and don't depend on
zack [Sun, 10 Dec 2006 00:41:47 +0000 (00:41 +0000)]
Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUse the Qt image loading framework instead of the Mozilla
zack [Sun, 10 Dec 2006 00:37:02 +0000 (00:37 +0000)]
Use the Qt image loading framework instead of the Mozilla
loaders

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove an explicit ICU dependency (by lars)
zack [Sun, 10 Dec 2006 00:21:55 +0000 (00:21 +0000)]
Remove an explicit ICU dependency (by lars)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing the kde build after the icu Qt changes.
zack [Sun, 10 Dec 2006 00:19:25 +0000 (00:19 +0000)]
Fixing the kde build after the icu Qt changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
aroben [Sat, 9 Dec 2006 23:53:30 +0000 (23:53 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        Some updates in reaction to r18098.

        * wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all
        cases.
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::isDigit):
        (WTF::Unicode::isSpace):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isUpper):
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:

WebCore:

        Reviewed by Darin.

        Changed all ForwardingHeaders to use #include instead of #import.

        * ForwardingHeaders/kjs/JSLock.h:
        * ForwardingHeaders/kjs/SavedBuiltins.h:
        * ForwardingHeaders/kjs/collector.h:
        * ForwardingHeaders/kjs/dtoa.h:
        * ForwardingHeaders/kjs/internal.h:
        * ForwardingHeaders/kjs/interpreter.h:
        * ForwardingHeaders/kjs/lookup.h:
        * ForwardingHeaders/kjs/object.h:
        * ForwardingHeaders/kjs/property_map.h:
        * ForwardingHeaders/kjs/protect.h:
        * ForwardingHeaders/wtf/AlwaysInline.h:
        * ForwardingHeaders/wtf/Assertions.h:
        * ForwardingHeaders/wtf/FastMalloc.h:
        * ForwardingHeaders/wtf/GetPtr.h:
        * ForwardingHeaders/wtf/HashCountedSet.h:
        * ForwardingHeaders/wtf/HashMap.h:
        * ForwardingHeaders/wtf/HashSet.h:
        * ForwardingHeaders/wtf/HashTraits.h:
        * ForwardingHeaders/wtf/MathExtras.h:
        * ForwardingHeaders/wtf/Noncopyable.h:
        * ForwardingHeaders/wtf/OwnArrayPtr.h:
        * ForwardingHeaders/wtf/OwnPtr.h:
        * ForwardingHeaders/wtf/PassRefPtr.h:
        * ForwardingHeaders/wtf/Platform.h:
        * ForwardingHeaders/wtf/RefPtr.h:
        * ForwardingHeaders/wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).
staikos [Sat, 9 Dec 2006 22:40:10 +0000 (22:40 +0000)]
    Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).

        Reviewed by Darin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Sat, 9 Dec 2006 17:22:13 +0000 (17:22 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11625
        Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

        Add a class shared by both HTMLStyleElement and SVGStyleElement that
        encapsulates the common logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix WebKit forwarding headers for mac.
hyatt [Sat, 9 Dec 2006 08:52:11 +0000 (08:52 +0000)]
Fix WebKit forwarding headers for mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.
hyatt [Sat, 9 Dec 2006 08:35:46 +0000 (08:35 +0000)]
Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage (more still).
hyatt [Sat, 9 Dec 2006 08:34:27 +0000 (08:34 +0000)]
Fix mac bustage (more still).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage (maybe).
hyatt [Sat, 9 Dec 2006 08:33:40 +0000 (08:33 +0000)]
Fix mac bustage (maybe).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage (maybe).
hyatt [Sat, 9 Dec 2006 08:32:50 +0000 (08:32 +0000)]
Fix mac bustage (maybe).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage (maybe).
hyatt [Sat, 9 Dec 2006 08:29:42 +0000 (08:29 +0000)]
Fix mac bustage (maybe).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage.
hyatt [Sat, 9 Dec 2006 07:54:09 +0000 (07:54 +0000)]
Fix mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
hyatt [Sat, 9 Dec 2006 05:54:29 +0000 (05:54 +0000)]
JavaScriptCore:

        Land the new ICU abstraction layer.  Patch by Lars.

        Reviewed by me

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Platform.h:
        * wtf/unicode/UnicodeCategory.h: Removed.
        * wtf/unicode/UnicodeDecomposition.h: Removed.
        * wtf/unicode/UnicodeDirection.h: Removed.
        * wtf/unicode/icu/UnicodeIcu.h:
        (WTF::Unicode::):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::isDigit):
        (WTF::Unicode::isSpace):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::mirroredChar):
        (WTF::Unicode::category):
        (WTF::Unicode::direction):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isUpper):
        (WTF::Unicode::digitValue):
        (WTF::Unicode::combiningClass):
        (WTF::Unicode::decompositionType):
        (WTF::Unicode::strcasecmp):
        (WTF::Unicode::memset):
        * wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
        * wtf/unicode/qt4/UnicodeQt4.h:
        (WTF::Unicode::):
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::isPrintableChar):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isUpper):
        (WTF::Unicode::digitValue):
        (WTF::Unicode::combiningClass):
        (WTF::Unicode::decompositionType):
        (WTF::Unicode::strcasecmp):
        (WTF::Unicode::memset):
        (WTF::Unicode::direction):
        (WTF::Unicode::category):

WebCore:

        Land the new ICU abstraction layer (WTF::Unicode).  Patch
        by Lars with a couple of fixes thrown in by me.

        Reviewed by hyatt

        * ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
        * ForwardingHeaders/wtf/unicode/Unicode.h: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * css/cssparser.cpp:
        (WebCore::ParseString::lower):
        * dom/Document.cpp:
        (WebCore::isValidNameStart):
        (WebCore::isValidNamePart):
        * editing/TextIterator.cpp:
        (WebCore::CircularSearchBuffer::append):
        * html/HTMLFontElement.cpp:
        (WebCore::parseFontSizeNumber):
        * html/HTMLInputElement.cpp:
        (WebCore::numGraphemeClusters):
        (WebCore::numCharactersInGraphemeClusters):
        * html/HTMLSelectElement.cpp:
        (WebCore::stripLeadingWhiteSpace):
        * page/Frame.h:
        * platform/DeprecatedString.h:
        (WebCore::DeprecatedChar::isSpace):
        (WebCore::DeprecatedChar::lower):
        (WebCore::DeprecatedChar::upper):
        * platform/Font.cpp:
        (WebCore::WidthIterator::advance):
        (WebCore::WidthIterator::normalizeVoicingMarks):
        * platform/FontCache.h:
        * platform/FontData.h:
        * platform/GlyphMap.cpp:
        * platform/GlyphMap.h:
        * platform/GlyphWidthMap.h:
        * platform/KURL.cpp:
        (WebCore::encodeHostname):
        * platform/StringHash.h:
        (WTF::):
        * platform/StringImpl.cpp:
        (WebCore::isSpace):
        (WebCore::parseLength):
        (WebCore::StringImpl::isLower):
        (WebCore::StringImpl::lower):
        (WebCore::StringImpl::upper):
        (WebCore::StringImpl::secure):
        (WebCore::StringImpl::foldCase):
        (WebCore::StringImpl::capitalize):
        (WebCore::StringImpl::toInt):
        (WebCore::equalIgnoringCase):
        (WebCore::StringImpl::find):
        * platform/StringImpl.h:
        * platform/TextBoundaries.h:
        * platform/TextBreakIterator.h: Added.
        (WebCore::):
        * platform/TextBreakIteratorICU.cpp: Added.
        (WebCore::wordBreakIterator):
        (WebCore::characterBreakIterator):
        (WebCore::textBreakFirst):
        (WebCore::textBreakNext):
        (WebCore::textBreakPreceding):
        (WebCore::textBreakFollowing):
        (WebCore::textBreakCurrent):
        * platform/TextCodec.h:
        * platform/TextCodecLatin1.cpp:
        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::encode):
        * platform/TextEncoding.h:
        * platform/TextEncodingRegistry.cpp:
        (WebCore::buildTextEncodingNameMap):
        (WebCore::buildTextCodecMap):
        * platform/TextEncodingRegistry.h:
        * platform/UChar.h: Removed.
        * platform/graphics/GraphicsContext.h:
        * platform/qt/GlyphMapQt.cpp:
        * platform/qt/TextBreakIteratorQt.cpp: Added.
        (WebCore::TextBreakIterator::following):
        (WebCore::TextBreakIterator::preceding):
        (WebCore::WordBreakIteratorQt::first):
        (WebCore::WordBreakIteratorQt::next):
        (WebCore::WordBreakIteratorQt::previous):
        (WebCore::CharBreakIteratorQt::first):
        (WebCore::CharBreakIteratorQt::next):
        (WebCore::CharBreakIteratorQt::previous):
        (WebCore::wordBreakIterator):
        (WebCore::characterBreakIterator):
        (WebCore::textBreakFirst):
        (WebCore::textBreakNext):
        (WebCore::textBreakPreceding):
        (WebCore::textBreakFollowing):
        (WebCore::textBreakCurrent):
        * platform/qt/TextCodecQt.cpp: Added.
        (WebCore::getAtomicName):
        (WebCore::TextCodecQt::registerEncodingNames):
        (WebCore::newTextCodecQt):
        (WebCore::TextCodecQt::registerCodecs):
        (WebCore::TextCodecQt::TextCodecQt):
        (WebCore::TextCodecQt::~TextCodecQt):
        (WebCore::TextCodecQt::decode):
        (WebCore::TextCodecQt::encode):
        * platform/qt/TextCodecQt.h: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::previousOffset):
        (WebCore::RenderText::nextOffset):
        (WebCore::RenderText::widthFromCache):
        * rendering/RenderText.h:
        * rendering/bidi.cpp:
        (WebCore::BidiState::BidiState):
        (WebCore::BidiContext::BidiContext):
        (WebCore::bidiNext):
        (WebCore::bidiFirst):
        (WebCore::BidiIterator::direction):
        (WebCore::appendRun):
        (WebCore::embed):
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::RenderBlock::bidiReorderLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        * rendering/bidi.h:
        (WebCore::BidiStatus::BidiStatus):
        (WebCore::BidiContext::dir):
        (WebCore::BidiContext::basicDir):
        (WebCore::BidiRun::BidiRun):
        * rendering/break_lines.h:

WebKit:

        Land new ICU abstraction layer.  Patch by Lars.

        Reviewed by me

        * ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
        * ForwardingHeaders/wtf/unicode/Unicode.h: Added.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolling out r17865 because it caused a performance regression.
aroben [Sat, 9 Dec 2006 04:10:59 +0000 (04:10 +0000)]
    Rolling out r17865 because it caused a performance regression.

        * loader/TextResourceDecoder.cpp:
        (WebCore::findXMLEncoding):
        * platform/CString.cpp:
        (WebCore::CString::data):
        * platform/CString.h:
        * platform/TextStream.cpp:
        (WebCore::TextStream::operator<<):
        * platform/TextStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Maciej.
zack [Sat, 9 Dec 2006 01:27:19 +0000 (01:27 +0000)]
Reviewed by Maciej.

Patch fixes compile of all Qt/KDE code after
the recent API changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove stray conflict marker
bdash [Sat, 9 Dec 2006 01:25:30 +0000 (01:25 +0000)]
Remove stray conflict marker

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning
thatcher [Sat, 9 Dec 2006 01:07:31 +0000 (01:07 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolling out a change that broke Mail stationary.
thatcher [Sat, 9 Dec 2006 00:38:52 +0000 (00:38 +0000)]
    Rolling out a change that broke Mail stationary.
        <rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

        * WebView/WebUnarchivingState.m:
        (-[WebUnarchivingState archivedResourceForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
staikos [Sat, 9 Dec 2006 00:31:54 +0000 (00:31 +0000)]
    Reviewed by Maciej.

        Build Qt webkit on non-linux, and prefer it if $QTDIR is set

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis [Fri, 8 Dec 2006 23:40:05 +0000 (23:40 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=10188
        Form elements added via appendChild() are not accessible via form.element

        Make sure looking up form elements works when the form is not appended
        to the document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
rwlbuis [Fri, 8 Dec 2006 22:44:14 +0000 (22:44 +0000)]
    Reviewed by Adele.

        http://bugs.webkit.org/show_bug.cgi?id=11765
        REGRESSION: Clicking on a select with size other than 1 and no children results in a crash

        Make sure returned value is -1 for selects without children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed typo.
aroben [Fri, 8 Dec 2006 22:34:55 +0000 (22:34 +0000)]
    Fixed typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
aroben [Fri, 8 Dec 2006 22:34:07 +0000 (22:34 +0000)]
JavaScriptCore:

        Reviewed by Anders.

        This is a mo' better fix for ensuring we don't use macro definitiones
        of min/max.

        * kjs/config.h:
        * wtf/Vector.h:

WebCore:

        Reviewed by Anders.

        This is a mo' better fix for ensuring we don't use macro definitiones
        of min/max.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-08 Don Gibson <dgibson77@gmail.com>
ap [Fri, 8 Dec 2006 21:21:30 +0000 (21:21 +0000)]
2006-12-08  Don Gibson  <dgibson77@gmail.com>

        Reviewed and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=11759:
        Windows build bustage

WebCore:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/ContextMenuClientWin.h:
        * bridge/win/FrameWin.h:
        * loader/win/FrameLoaderWin.cpp:
        (WebCore::FrameLoader::submitForm):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::onRequestComplete):
        (WebCore::ResourceHandle::fileLoadTimer):
        (WebCore::ResourceHandle::cancel):
        * platform/win/MouseEventWin.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::inputElementAltText):
        (WebCore::copyCursor):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::ContextMenuClientWin::contextMenuItemSelected):
        (WebCore::ContextMenuClientWin::copyLinkToClipboard):
        (WebCore::ContextMenuClientWin::downloadURL):
        (WebCore::ContextMenuClientWin::copyImageToClipboard):
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::learnSpelling):
        (WebCore::Editor::isSelectionUngrammatical):
        (WebCore::Editor::isSelectionMisspelled):
        (WebCore::Editor::guessesForMisspelledSelection):
        (WebCore::Editor::guessesForUngrammaticalSelection):
        (WebCore::Editor::markMisspellingsInAdjacentWords):
        (WebCore::FrameLoader::load):
        (WebCore::FrameWin::scheduleClose):
        (WebCore::FrameWin::respondToChangedSelection):

WebKit:
        * COM/WebFrame.cpp:
        (WebFrame::loadDataSource):
        * COM/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Fri, 8 Dec 2006 21:12:48 +0000 (21:12 +0000)]
LayoutTests:

        Reviewed by Geoff.

        Testcases for http://bugs.webkit.org/show_bug.cgi?id=11777
        Crash when using XMLSerializer.serializeToString() on
        documentless, DocumentType nodes.

        * fast/dom/XMLSerializer-doctype-expected.txt: Added.
        * fast/dom/XMLSerializer-doctype.html: Added.
        * fast/dom/XMLSerializer-doctype2-expected.txt: Added.
        * fast/dom/XMLSerializer-doctype2.html: Added.

WebCore:

        Reviewed by Geoff.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11777
        Crash when using XMLSerializer.serializeToString() on
        documentless, DocumentType nodes.

        Test: fast/dom/XMLSerializer-doctype.html
        Test: fast/dom/XMLSerializer-doctype2.html

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument): set the document of the
        DocumentType node to the new document.
        * xml/XMLSerializer.cpp: Cleanup.
        (WebCore::XMLSerializer::serializeToString): now throws an exception
        for documentless nodes.
        * xml/XMLSerializer.h: cleanup
        * xml/XMLSerializer.idl: add exception

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Fri, 8 Dec 2006 19:29:40 +0000 (19:29 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/4836287>
        Cannot expand selection out of editable element when containing element is non-editable.

        * editing/selection/mixed-editability-6-expected.checksum: Added.
        * editing/selection/mixed-editability-6-expected.png: Added.
        * editing/selection/mixed-editability-6-expected.txt: Added.
        * editing/selection/mixed-editability-6.html: Added.
        * editing/selection/mixed-editability-7-expected.checksum: Added.
        * editing/selection/mixed-editability-7-expected.png: Added.
        * editing/selection/mixed-editability-7-expected.txt: Added.
        * editing/selection/mixed-editability-7.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4836287>
        Cannot expand selection out of editable element when containing element is non-editable.

        * editing/Selection.cpp:
        (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints
        to the same *highest* editable root.  This bug only happened when creating selections
        based in an editable region and extending into a higher editable root, so this change
        doesn't expose any new kinds of deletions, but we should start thinking about how
        those deletions should behave.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectAll): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
harrison [Fri, 8 Dec 2006 18:53:51 +0000 (18:53 +0000)]
    Reviewed by Brady.

        <rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

        * WebView/WebPreferences.m:
        (-[WebPreferences editableLinkBehavior]):
        Add nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTypo! Thanks Mitz!
bdakin [Fri, 8 Dec 2006 18:42:37 +0000 (18:42 +0000)]
Typo! Thanks Mitz!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
bdakin [Fri, 8 Dec 2006 18:37:05 +0000 (18:37 +0000)]
    Reviewed by Maciej.

        Add a new member variable to ContectMenuItem to hold on to the sub-
        menu. The new member variable is an OwnPtr<ContextMenu>

        * platform/ContextMenu.cpp: Because of the OwnPtr in
        ContextMenuItem, we have to separate the declaration of
        ContextMenuItems away from the calls to appendItem(). Not doing so
        causes a build failure because OwnPtr inherits from Noncopyable.
        (WebCore::createFontSubMenu): Same.
        (WebCore::createSpellingAndGrammarSubMenu): Same.
        (WebCore::createSpellingSubMenu): Same.
        (WebCore::createSpeechSubMenu): Same.
        (WebCore::createWritingDirectionSubMenu): Same.
        (WebCore::ContextMenu::populate): Same.
        * platform/ContextMenuItem.h:  New member variable m_subMenu.
        * platform/mac/ContextMenuItemMac.mm: Take care of setting
        m_subMenu in addition to setting the submenu of the NSMenuItem when
        we have a sub-menu.
        (WebCore::menuToArray):
        (WebCore::ContextMenuItem::ContextMenuItem): Same.
        (WebCore::ContextMenuItem::platformSubMenu): Same.
        (WebCore::ContextMenuItem::setSubMenu): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-08 MorganL <morganl.webkit@yahoo.com>
ap [Fri, 8 Dec 2006 18:35:19 +0000 (18:35 +0000)]
2006-12-08  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11778
        CString::data() should be documented as returning a null terminated char array

        * platform/CString.h:
        Add some basic documentation to CString.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap [Fri, 8 Dec 2006 18:31:53 +0000 (18:31 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=11718
        REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
        continues to scroll automatically.

        Test: manual-tests/autoscroll.html

        * manual-tests/autoscroll.html: Added.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        Assign to m_mousePressNode earlier, so that it is available in the superframe as well.
        Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value
        was only defined if the event was passed down to a widget or a subframe.

        (WebCore::EventHandler::stopAutoscrollTimer):
        If the mouse down event was in a subframe, stop the subframe's timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap [Fri, 8 Dec 2006 18:25:13 +0000 (18:25 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=6275
        XMLHttpRequest.getResponseHeader should return a null string for non-existent headers

WebCore:
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
        Convert null getResponseHeader strings to JS null, rather than undefined.

LayoutTests:
        * http/tests/xmlhttprequest/methods-async-expected.txt:
        * http/tests/xmlhttprequest/methods-expected.txt:
        * http/tests/xmlhttprequest/methods-lower-case-expected.txt:
        Updated the results.

        * http/tests/xmlhttprequest/web-apps/008-expected.txt:
        * http/tests/xmlhttprequest/web-apps/008-test.asis:
        * http/tests/xmlhttprequest/web-apps/008.html:
        Changed to test both missing and empty headers, also test case insensitivity
        of header names.
        Please note that neither Firefox nor IE passes this test now - the former returns
        null in both cases, and the latter returns empty strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Fri, 8 Dec 2006 18:19:51 +0000 (18:19 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=9854
        HTTP Refresh header with quotes is parsed incorrectly

        Test: http/tests/misc/redirect-with-quotes.php

        * WebCore.xcodeproj/project.pbxproj:
        Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::receivedFirstData):
        Use the new implementation in HTTPHeaders.

        * platform/network/HTTPParsers.cpp: Added.
        (WebCore::skipWhiteSpace):
        (WebCore::parseHTTPRefresh):
        * platform/network/HTTPParsers.h: Added.
        Merged and rewrote existing implementations for better Firefox compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
ap [Fri, 8 Dec 2006 18:03:12 +0000 (18:03 +0000)]
    Reviewed by Tim H.

        http://bugs.webkit.org/show_bug.cgi?id=11772
        REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes

        Test: fast/dom/serialize-cdata.html

        * editing/markup.cpp:
        (WebCore::startMarkup): Dump CDATA sections, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt.
rwlbuis [Fri, 8 Dec 2006 11:02:32 +0000 (11:02 +0000)]
    Reviewed by hyatt.

        Deleted misplaced comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Fri, 8 Dec 2006 08:02:35 +0000 (08:02 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=6074
        WebKit+SVG and FireFox disagree on invalid "transform" handling

        Test for parsing failure on transform attribute and clear the transform
        list upon failure to match FF behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Fri, 8 Dec 2006 07:05:53 +0000 (07:05 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Tests for the change and blur events in input elements.

        * fast/events/onchange-passwordfield-expected.txt: Added.
        * fast/events/onchange-passwordfield.html: Added.
        * fast/events/onchange-searchfield-expected.txt: Added.
        * fast/events/onchange-searchfield.html: Added.
        * fast/events/onchange-textfield-expected.txt: Added.
        * fast/events/onchange-textfield.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
        dispatches onchange event in response to enter key

        To match our old behavior and FF, we need to dispatch onchange in response to the
        ENTER key. The strategy here is just to dispatch a blur event, since that's how
        the search field always worked, and the DOM spec says onchange only fires
        as a precursor to blur.

        * ChangeLog:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
aroben [Fri, 8 Dec 2006 03:53:08 +0000 (03:53 +0000)]
    Reviewed by Oliver.

        Some small context menu-related fixes.

        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to
        resize on a contextmenuEvent.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event
        off to HTMLGenericFormElement if we haven't handled it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-07 Kevin Fyure <digdog@macports.org>
bdash [Fri, 8 Dec 2006 03:22:27 +0000 (03:22 +0000)]
2006-12-07  Kevin Fyure  <digdog@macports.org>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11545
        Disable the testcases do not follow the ECMA-262v3 specification.

        * tests/mozilla/expected.html: Update Results.
        * tests/mozilla/js1_2/String/concat.js:
        4 tests disabled. The result of concat Array object is not followinig
        ECMA 15.5.4.6
        * tests/mozilla/js1_2/function/Number.js:
        1 test disabled. The result of Array object to Number object conversion
        is not following ECMA 9.3. And the test was duplicated in
        ecma/TypeConversion/9.3-1.js
        * tests/mozilla/js1_2/function/String.js:
        2 tests disabled. The result of Object/Array object to String object
        conversion is not following ECMA 15.5.1.1 and ECMA 9.8

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
andersca [Fri, 8 Dec 2006 00:54:15 +0000 (00:54 +0000)]
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/4838778>
        DashboardClient crashing in WebCore::SubresourceLoader::didFail.

        * http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
        * http/tests/xmlhttprequest/abort-crash.html: Added.
        * http/tests/xmlhttprequest/hello-world.cgi: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/4838778>
        Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::stopLoading):
        * loader/SubresourceLoader.h:
        Add stopLoading method which currently just clears the client. This isn't the ideal fix,
        since it doesn't actually stop the load.

        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::willSendRequest):
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didReceiveData):
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::didFail):
        (WebCore::SubresourceLoader::didCancel):
        Add null-checks.

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::abort):
        Call stopLoading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geof.
kmccullo [Fri, 8 Dec 2006 00:23:36 +0000 (00:23 +0000)]
    Reviewed by Geof.

        - added the ability to set the auto repeating variable to force a keyPressed
        event from a keyDown event.

        * platform/PlatformKeyboardEvent.h:
        (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-07 Kirby White <KWhiteRight@gmail.com>
bdash [Fri, 8 Dec 2006 00:14:47 +0000 (00:14 +0000)]
2006-12-07  Kirby White  <KWhiteRight@gmail.com>

        Reviewed by Adele.

        http://bugs.webkit.org/show_bug.cgi?id=11771
        Bug 11771: Add a test for resetting a textarea form control

        * fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
        * fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
        * fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
        * fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-07 Don Gibson <dgibson77@gmail.com>
bdash [Fri, 8 Dec 2006 00:10:35 +0000 (00:10 +0000)]
2006-12-07  Don Gibson  <dgibson77@gmail.com>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11749
        Don't call updateThumbProportion() unnecessarily.

        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::setProportion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-06 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 7 Dec 2006 21:49:02 +0000 (21:49 +0000)]
2006-12-06  Steve Falkenburg  <sfalken@apple.com>

        Support C strings for localization

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
bdakin [Thu, 7 Dec 2006 20:47:58 +0000 (20:47 +0000)]
    Reviewed by Brady.

        Build fix for WebCore ContextMenus. It got broken by r18046.

        * WebView/WebHTMLView.m:
        (-[NSArray menuForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Thu, 7 Dec 2006 19:49:21 +0000 (19:49 +0000)]
WebCore:
        Reviewed by Brady.

        Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
        doing anything before, and now it works! Also some formatting
        changes, etc.

        * page/ContextMenuClient.h: Several of the parameters to several of
        the functions here should be const or const references. And now
        they are!
        * page/ContextMenuController.cpp:
        (WebCore::openNewWindow): Moved the open new window functionality
        into a helper function since it is used by several menu item tags.
        Now after calling chrome()->createWindow() we call chrome()->show()
        on the new window, and so it appears!
        (WebCore::ContextMenuController::contextMenuItemSelected): Call new
        openNewWindow function to do the right thing. Shift some
        formatting, use local variable for HitTestResult. Implement action
        for ContextMenuItemTagOpenLink.

WebKit:
        Reviewed by Brady.

        Make some parameters const and const references.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::contextMenuItemSelected):
        (WebContextMenuClient::copyLinkToClipboard):
        (WebContextMenuClient::downloadURL):
        (WebContextMenuClient::copyImageToClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed typos/misspellings.
ddkilzer [Thu, 7 Dec 2006 09:49:18 +0000 (09:49 +0000)]
Fixed typos/misspellings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by.
kmccullo [Thu, 7 Dec 2006 02:47:32 +0000 (02:47 +0000)]
    Reviewed by.

        - Removed a confilct marker

        * ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 7 Dec 2006 02:46:54 +0000 (02:46 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/4818134>
        Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

        * editing/selection/select-line-expected.txt: Added.
        * editing/selection/select-line.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/4818134>
        Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RebalanceWhitespaceCommand.*.
        * editing/visible_units.cpp:
        (WebCore::startOfLine): There are VisiblePositions at offset 0 in blocks without
        RootInlineBoxes, like empty editable blocks and bordered blocks.
        (WebCore::endOfLine): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by.
kmccullo [Thu, 7 Dec 2006 02:40:10 +0000 (02:40 +0000)]
    Reviewed by.

        - Removed a confilct marker

        * ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by john
kmccullo [Thu, 7 Dec 2006 02:24:59 +0000 (02:24 +0000)]
    Reviewed by john

        <rdar://problem/4854869>
        Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

        * editing/htmlediting.cpp:
        (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape
        from editable content.
        * editing/markup.cpp:
        (WebCore::createMarkup): A null commonAncestorBlock will happen
        if commonAncestor is inside an inline editable root that doesn't
        contain any blocks.  Removed an early return for this case: the
        code below the early return can and must handle it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 7 Dec 2006 01:01:13 +0000 (01:01 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/4854869>
        Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

        * editing/deleting/delete-mixed-editable-content-001-expected.txt:
        * editing/inserting/editable-inline-element-expected.checksum: Added.
        * editing/inserting/editable-inline-element-expected.txt: Added.
        * editing/inserting/editable-inline-element-expected.png: Added.
        * editing/inserting/editable-inline-element.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4854869>
        Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

        * editing/htmlediting.cpp:
        (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape
        from editable content.
        * editing/markup.cpp:
        (WebCore::createMarkup): A null commonAncestorBlock will happen
        if commonAncestor is inside an inline editable root that doesn't
        contain any blocks.  Removed an early return for this case: the
        code below the early return can and must handle it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan
beidson [Thu, 7 Dec 2006 00:41:17 +0000 (00:41 +0000)]
    Reviewed by John Sullivan

        Fixes http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
        Now we need to explicitly set the data source when loading from a page cache

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message
        (+[WebHistoryItem _releasePageCache:]): Ditto
        (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
        * WebView/WebHTMLView.m:
        (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Thu, 7 Dec 2006 00:22:54 +0000 (00:22 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/4843505> Fix cross-library ivar use for 64-bit Objective-C

        Adds a new WebCore.LP64.exp file that gets appended to the normal export file.
        This new file will have 64-bit only symbols we need to export.

        * WebCore.LP64.exp: Added.
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
andersca [Thu, 7 Dec 2006 00:08:55 +0000 (00:08 +0000)]
    Reviewed by Maciej.

        Change SubresourceLoader to use a ResourceHandle, and change ResourceHandle to use a NSURLConnection.

        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        (WebCore::SubresourceLoader::didReceiveData):
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::didFail):
        * loader/SubresourceLoader.h:
        (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge):
        (WebCore::SubresourceLoader::didCancelAuthenticationChallenge):
        (WebCore::SubresourceLoader::willStopBufferingData):
        (WebCore::SubresourceLoader::willCacheResponse):
        (WebCore::SubresourceLoader::receivedCredential):
        (WebCore::SubresourceLoader::receivedRequestToContinueWithoutCredential):
        (WebCore::SubresourceLoader::receivedCancellation):
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didFail):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didFail):
        * loader/icon/IconLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::didFail):
        * loader/loader.h:
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::resourceData):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::SubresourceLoader):
        (WebCore::SubresourceLoader::setDefersLoading):
        (WebCore::SubresourceLoader::resourceData):
        (WebCore::SubresourceLoader::load):
        (WebCore::SubresourceLoader::create):
        (WebCore::SubresourceLoader::willSendRequest):
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didReceiveData):
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::didFail):
        (WebCore::SubresourceLoader::didCancel):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::create):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didReceiveData):
        (WebCore::ResourceHandleClient::didFail):
        (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
        (WebCore::ResourceHandleClient::willStopBufferingData):
        (WebCore::ResourceHandleClient::willCacheResponse):
        (WebCore::ResourceHandleClient::receivedCredential):
        (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandleClient::receivedCancellation):
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (WebCore::ResourceHandle::setDefersLoading):
        (WebCore::ResourceHandle::delegate):
        (WebCore::ResourceHandle::releaseDelegate):
        (WebCore::ResourceHandle::supportsBufferedData):
        (WebCore::ResourceHandle::bufferedData):
        (-[WebCoreResourceHandleAsDelegate initWithHandle:]):
        (-[WebCoreResourceHandleAsDelegate detachHandle]):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
        (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
        (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::didFail):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam and Oliver
beidson [Wed, 6 Dec 2006 21:55:35 +0000 (21:55 +0000)]
    Reviewed by Adam and Oliver

        While working on http://bugs.webkit.org/show_bug.cgi?id=11675 I
        decided to fix much of the null-deref problems that creeped in via
        the loader refactoring.  This isn't changing behavior, just reintroducing
        the free nil checking we used to have with pure ObjC

        * WebView/WebHTMLView.m:
        (-[NSArray menuForEvent:]):  Explicitly check for null frames
        (-[NSArray mouseDown:]):  Ditto
        (-[NSArray mouseDragged:]):  Ditto
        (-[NSArray mouseUp:]):  Ditto
        (-[NSArray performKeyEquivalent:]):  Ditto
        (-[WebHTMLView elementAtPoint:allowShadowContent:]):  Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
bdakin [Wed, 6 Dec 2006 21:54:47 +0000 (21:54 +0000)]
    Reviewed by Adam.

        There are two bugs with WebCore ContextMenus due to the static
        ContextMenuItems. One bug is that we often crashed in
        NSAutoreleasePool upon quitting the browser. The other bug is that
        we were adding static NSMenuItems to multiple NSMenus, which is
        disallowed. To fix these bugs, the MenuItems are no longer static.
        This is in line with the current design in WebKit anyway. I made
        some re-arrangements in the code because I also removed the macro
        that was used to create the menu items since it was a bit
        confusing.

        * platform/ContextMenu.cpp:
        (WebCore::createFontSubMenu):
        (WebCore::createSpellingAndGrammarSubMenu):
        (WebCore::createSpellingSubMenu):
        (WebCore::createSpeechSubMenu):
        (WebCore::createWritingDirectionSubMenu):
        (WebCore::ContextMenu::populate):
        * platform/ContextMenuItem.h:
        * platform/mac/ContextMenuItemMac.mm:
        (WebCore::ContextMenuItem::ContextMenuItem): Use the NSMenuItem
        global separator item if we have SeparatorType.
        * platform/mac/ContextMenuMac.mm:
        (WebCore::setMenuItemTarget):  Change name of getNSMenuItem since
        that is no longer accurate.
        (WebCore::ContextMenu::appendItem): Above name change.
        (WebCore::ContextMenu::insertItem): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geof.
kmccullo [Wed, 6 Dec 2006 21:46:18 +0000 (21:46 +0000)]
    Reviewed by Geof.

        - Returned the semantic meaning of the mask to be the actual repeat count,
        and changed auto_repeat to correctly differnetiate between keypressed and keydown.

        * platform/win/KeyEventWin.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 6 Dec 2006 21:01:30 +0000 (21:01 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4753545>
        REGRESSION: Edited whitespace sequences are all nbsps (10636)

        * editing/inserting/edited-whitespace-1-expected.checksum: Added.
        * editing/inserting/edited-whitespace-1-expected.png: Added.
        * editing/inserting/edited-whitespace-1-expected.txt: Added.
        * editing/inserting/edited-whitespace-1.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4753545>
        REGRESSION: Edited whitespace sequences are all nbsps (10636)

        * WebCore.xcodeproj/project.pbxproj: Removed RebalanceWhitespaceCommand.* from the project.
        * editing/CompositeEditCommand.cpp:
        (WebCore::isWhitespace): Moved from htmlediting.
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Moved the work that was
        once done in its own command here.
        (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Prevents
        whitespace around a position from collapsing when it's pushed apart during Paste.
        This function can eventually be deployed to eliminate the need for leading/trailing
        whitespace handling in InsertParagraphSeparator, InsertLineBreak, Delete, and BreakBlockquote.
        (WebCore::CompositeEditCommand::rebalanceWhitespace): Cleaned up.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::doApply): Do rebalanceWhitespaceAt *before*
        saving the typing style, because whitespace rebalancing is no longer it's own
        command that claims to preserve the typing style.
        * editing/RebalanceWhitespaceCommand.cpp: Removed.
        * editing/RebalanceWhitespaceCommand.h: Removed.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Moved the code to prepare whitespace
        arond a position for being pushed aparat to its own method.
        * editing/htmlediting.cpp:
        (WebCore::stringWithRebalancedWhitespace): Added.  Returns a rebalanced string.
        Takes in whether or not the beginning of that string will be at the start of
        a paragraph, because a space at such a position must have be nbsp, even if
        that doesn't follow the nbsp/space pattern used.  Similar stuff for the end
        of a paragraph.
        * editing/htmlediting.h:
        * editing/markup.cpp:
        (WebCore::fillContainerFromString): Call stringWithRelabacedWhitespace.  Pass
        it the startOfParagraph/endOfParagraph bools.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
rwlbuis [Wed, 6 Dec 2006 20:39:23 +0000 (20:39 +0000)]
    Reviewed by Brady.

        http://bugs.webkit.org/show_bug.cgi?id=10254
        A few grammar and spelling corrections on the WebKit website

        Grammar and spelling corrections by Jonathan Johnsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan [Wed, 6 Dec 2006 18:50:27 +0000 (18:50 +0000)]
WebCore:

        Reviewed by Beth

        Moved spelling and grammar code from Frame to Editor

        * WebCore.exp:
        updated for these changes

        * page/Frame.h:
        removed declarations of spelling and grammar functions

        * bridge/mac/FrameMac.h:
        removed declarations of spelling and grammar functions

        * bridge/mac/FrameMac.mm:
        moved implementation of spelling and grammar functions from here
        (WebCore::FrameMac::respondToChangedSelection):
        updated for moved functions

        * editing/Editor.h:
        moved declarations of spelling and grammar functions to here

        * editing/mac/EditorMac.mm:
        moved implementation of spelling and grammar functions to here; changed
        only to make it compile (e.g. removing "editor()->" and adding "frame()->"
        where appropraite.
        (WebCore::findFirstMisspellingInRange):
        (WebCore::paragraphAlignedRangeForRange):
        (WebCore::findFirstGrammarDetailInRange):
        (WebCore::findFirstBadGrammarInRange):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::isSelectionMisspelled):
        (WebCore::isRangeUngrammatical):
        (WebCore::Editor::isSelectionUngrammatical):
        (WebCore::Editor::guessesForUngrammaticalSelection):
        (WebCore::core):
        (WebCore::Editor::guessesForMisspelledSelection):
        (WebCore::Editor::markMisspellingsInAdjacentWords):
        (WebCore::markAllMisspellingsInRange):
        (WebCore::markAllBadGrammarInRange):
        (WebCore::Editor::markMisspellings):

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        updated for moved functions

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping):
        updated for moved functions

WebKit:

        Reviewed by Beth

        Updated to match Frame -> Editor changes in WebCore

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        guessesForUngrammaticalSelection() is now in Editor

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _isSelectionUngrammatical]):
        isSelectionUngrammatical() is now in Editor
        (-[WebHTMLView _isSelectionMisspelled]):
        isSelectionMisspelled() is now in Editor

        (-[WebHTMLView checkSpelling:]):
        advanceToNextMisspelling() is now in Editor
        (-[WebHTMLView showGuessPanel:]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
andersca [Wed, 6 Dec 2006 02:09:30 +0000 (02:09 +0000)]
    Reviewed by Maciej.

        General cleanup, get rid of PlatformResponse (we have ResourceResponse now)
        and remove a couple of functions that were unused.

        * loader/CachedResource.h:
        * loader/LoaderFunctions.h:
        * loader/mac/LoaderFunctionsMac.mm:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::~ResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
kmccullo [Wed, 6 Dec 2006 02:01:03 +0000 (02:01 +0000)]
    Reviewed by John.

        - keydown is now a keydown event instead of a keypress event.
          Fixes some form submission odditties.

        * platform/win/KeyEventWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tiger build fix
sullivan [Wed, 6 Dec 2006 00:18:34 +0000 (00:18 +0000)]
    Tiger build fix

        * editing/mac/EditorMac.mm:
        declare -[NSSpellChecker learnWord:], on Tiger only (it's API on Leopard)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen
sullivan [Tue, 5 Dec 2006 23:48:04 +0000 (23:48 +0000)]
    Reviewed by Geoff Garen

        * page/Frame.h:
        remove declarations of ignoreSpelling() and learnSpelling()

        * bridge/mac/FrameMac.h:
        remove declarations of ignoreSpelling() and learnSpelling()
        * bridge/mac/FrameMac.mm:
        moved implementations of ignoreSpelling() and learnSpelling() from here

        * editing/Editor.h:
        added declarations of ignoreSpelling() and learnSpelling()

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::ignoreSpelling):
        moved here from FrameMac.mm
        (WebCore::Editor::learnSpelling):
        ditto

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        updated callers to use frame()->editor() rather than frame()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-04 Steve Falkenburg <sfalken@apple.com>
sfalken [Tue, 5 Dec 2006 23:15:09 +0000 (23:15 +0000)]
2006-12-04  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin.

        Make extract-localizable-strings compatible with cpp file extensions.

        * Scripts/extract-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan [Tue, 5 Dec 2006 22:34:54 +0000 (22:34 +0000)]
WebCore:

        Reviewed by Adam

        New context-menu mechanism fix for:
        <rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        Leave out "No Guesses Found" and separator for grammar-checking case.

WebKit:

        Reviewed by Adam

        Old context-menu mechanism fix for:
        <rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        Leave out "No Guesses Found" and separator for grammar-checking case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Tue, 5 Dec 2006 21:47:46 +0000 (21:47 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11686
        WebKit draws Carto.net tabgroup example completely incorrectly (ff does fine)

        Make sure the SVG render objects are laid out before measuring their
        dimensions using relativeBBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Tue, 5 Dec 2006 21:24:03 +0000 (21:24 +0000)]
    Reviewed by Darin

        Grammar/Spelling code re-homing, baby step one: put isGrammarCheckingEnabled in Editor
        since that's where isContinousSpellCheckingEnabled lives.

        * editing/Editor.h:
        * editing/Editor.cpp:
        (WebCore::Editor::isGrammarCheckingEnabled):
        new method, calls through to client a la isContinuousSpellCheckingEnabled

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::advanceToNextMisspelling):
        call editor() rather than editor()->client()
        (WebCore::FrameMac::markMisspellings):
        ditto

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Tue, 5 Dec 2006 21:08:55 +0000 (21:08 +0000)]
    Reviewed by Geoff.

        - a little cleanup

        * html/HTMLInputElement.h: Removed unneeded includes of RenderObject.h
        and RenderStyle.h.
        * html/HTMLSelectElement.h: Removed unneeded include of RenderStyle.h.
        * ksvg2/svg/SVGStyledElement.h: Removed unneeded include of RenderStyle.h.

        * ksvg2/svg/SVGSVGElement.h: Remove unneeded parameter to createSVGPoint.
        * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGPoint):
        Ditto.

        * ksvg2/scripts/generateJSBindings.pl: Removed unused script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * doc: Removed empty directory. It's not clear this is a good place for
darin [Tue, 5 Dec 2006 19:49:53 +0000 (19:49 +0000)]
    * doc: Removed empty directory. It's not clear this is a good place for
        documentation, so lets add it back later if we actually start using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady, Darin.
andersca [Tue, 5 Dec 2006 19:03:43 +0000 (19:03 +0000)]
    Reviewed by Brady, Darin.

        * loader/loader.cpp:
        (WebCore::Loader::receivedAllData):
        Remove ref() call that was left around by mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago build fix
sullivan [Tue, 5 Dec 2006 19:01:50 +0000 (19:01 +0000)]
    build fix

        * WebView/WebViewPrivate.h:
        * WebView/WebView.mm:
        (-[WebView isGrammarCheckingEnabled]):
        define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Tue, 5 Dec 2006 18:40:59 +0000 (18:40 +0000)]
    Reviewed by Tim H.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11758
        Don't compile custom SVG and XSLT bindings in non-svg build

        * bindings/js/JSSVGNumber.cpp:
        * bindings/js/JSSVGNumber.h:
        * bindings/js/JSSVGPoint.cpp:
        * bindings/js/JSSVGPoint.h:
        * bindings/js/JSSVGRect.cpp:
        * bindings/js/JSSVGRect.h:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan [Tue, 5 Dec 2006 18:36:06 +0000 (18:36 +0000)]
WebCore:

        Reviewed by Darin

        WebCore part of fix for:
        <rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

        The context menu mechanism is currently in flux; the old mechanism is still in place, but an
        up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
        test the new mechanism because it doesn't work well enough yet. Also, some of this code
        should move from Frame to Editor, but that will wait for another checkin.

        * page/Frame.h:
        added pure virtual function declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()

        * bridge/mac/FrameMac.h:
        added virtual functions declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::isSelectionMisspelled):
        now updates spelling panel (whether or not it's showing), since this is now needed to make -[NSSSpellChecker
        ignoreWord:inSpellDocumentWithTag:] work correctly
        (WebCore::isRangeUngrammatical):
        new function, helper used by both isSelectionUngrammatical() and guessesForUngrammaticalSelection()
        (WebCore::FrameMac::isSelectionUngrammatical):
        new function, calls isRangeUngrammatical
        (WebCore::FrameMac::guessesForUngrammaticalSelection):
        ditto

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        now considers bad grammar as well as misspellings

        * platform/ContextMenuItem.h:
        added ContextMenuItemTagIgnoreGrammar

WebKit:

        Reviewed by Darin

        WebKit part of fix for:
        <rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

        The context menu mechanism is currently in flux; the old mechanism is still in place, but an
        up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
        test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
        can be deleted when the new mechanism is in place.

        * WebView/WebUIDelegatePrivate.h:
        added WebMenuItemTagIgnoreGrammar

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
        added case for WebMenuItemTagIgnoreGrammar
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        now considers adding grammar-related items as well as spelling-related items

        * WebView/WebHTMLViewPrivate.h:
        declared _isSelectionUngrammatical

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _isSelectionUngrammatical]):
        new method, calls through to WebCore
        (-[WebHTMLView _ignoreGrammarFromMenu:]):
        new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both

        * English.lproj/Localizable.strings:
        updated for "Ignore Grammar" menu item title

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-05 Kirby White <KWhiteRight@gmail.com>
ap [Tue, 5 Dec 2006 12:31:52 +0000 (12:31 +0000)]
2006-12-05  Kirby White  <KWhiteRight@gmail.com>

        Reviewed, tweaked and landed by Alexey.

        <http://bugs.webkit.org/show_bug.cgi?id=11639> Form buttons don't look different when clicked

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::determineState): Moved test for active
        state before test for hover state, since active should override hover
        when both are true.

        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::determineState): Same fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-05 Kirby White <KWhiteRight@gmail.com>
ap [Tue, 5 Dec 2006 10:23:25 +0000 (10:23 +0000)]
2006-12-05  Kirby White  <KWhiteRight@gmail.com>

        Reviewed and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=11681
        Don't select the first option when resetting a listbox-style form
        control (i.e., a multi-select control or one with size > 1) that
        has no default selection.

        Test: fast/dom/HTMLSelectElement/listbox-select-reset.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Rob.
ap [Tue, 5 Dec 2006 08:51:18 +0000 (08:51 +0000)]
    Reviewed by Rob.

        Make this test pass on PowerPC, too (the calculation was giving 4.7e-16 instead of zero,
        now rounding it to 15 digits).

        * svg/custom/getTransformToElement.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-05 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
ap [Tue, 5 Dec 2006 08:26:38 +0000 (08:26 +0000)]
2006-12-05  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>

        Reviewed and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=11752
        [CSS 3] missing support for cursor selector 'copy'

        * Resources/copyCursor.png: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSValueKeywords.in:
        * manual-tests/cursor.html:
        * page/EventHandler.cpp:
        (WebCore::selectCursor):
        * platform/Cursor.h:
        * platform/mac/CursorMac.mm:
        (WebCore::copyCursor):
        * rendering/RenderStyle.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Tue, 5 Dec 2006 06:50:04 +0000 (06:50 +0000)]
    Reviewed by Geoff.

        Fix from last check-in. This line was badbad.

        * platform/mac/ContextMenuMac.mm:
        (WebCore::ContextMenu::~ContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Tue, 5 Dec 2006 06:33:03 +0000 (06:33 +0000)]
    Reviewed by Geoff.

        With the new changes to ContextMenuItems, WebCore context menus
        stopped appearing at all. And then when I got them to appear, they
        crashed. This fixes both of these problems.

        * platform/mac/ContextMenuItemMac.mm:
        (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot
        be nil. This was causing Obj-C to throw an exception preventing the
        menus from popping up at all.
        * platform/mac/ContextMenuMac.mm:
        (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static
        MenuTarget so that it is more clear that it is a static and shared
        WebCoreMenuTarget.
        (WebCore::ContextMenu::ContextMenu): Initialize the
        WebCoreMenuTarget's controller in the ContextMenu constructor
        instead of in getNSMenuItem since the controller will only possibly
        change when a new ContextMenu has been created.
        (WebCore::ContextMenu::~ContextMenu): Set the target's controller
        to 0.
        (WebCore::getNSMenuItem): A lot of this work is being done other
        places now. Call new class method on WebCoreMenuTarget to get the
        shared target.
        (WebCore::ContextMenu::appendItem): We should not be releasing the
        menuItem here! This caused the crashes I saw.
        (WebCore::ContextMenu::insertItem): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix the build.
andersca [Tue, 5 Dec 2006 03:37:31 +0000 (03:37 +0000)]
    Fix the build.

        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::~SubresourceLoader):
        Add back the destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Tue, 5 Dec 2006 03:07:16 +0000 (03:07 +0000)]
    Reviewed by Darin.

        Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
        make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a
        standalone class which doesn't need to know about SubresourceLoader.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::setDefersLoading):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::SubresourceLoader):
        (WebCore::SubresourceLoader::~SubresourceLoader):
        (WebCore::SubresourceLoader::create):
        (WebCore::SubresourceLoader::willSendRequest):
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didReceiveData):
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::didFailWithError):
        (WebCore::SubresourceLoader::receivedAllData):
        * loader/SubresourceLoader.h:
        (WebCore::SubresourceLoader::loaderAsResourceHandleClient):
        (WebCore::SubresourceLoader::handle):
        * loader/SubresourceLoaderClient.h: Added.
        (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient):
        (WebCore::SubresourceLoaderClient::willSendRequest):
        (WebCore::SubresourceLoaderClient::didReceiveResponse):
        (WebCore::SubresourceLoaderClient::didReceiveData):
        (WebCore::SubresourceLoaderClient::didFinishLoading):
        (WebCore::SubresourceLoaderClient::didFailWithError):
        (WebCore::SubresourceLoaderClient::receivedAllData):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading):
        (WebCore::IconLoader::stopLoading):
        (WebCore::IconLoader::didReceiveResponse):
        (WebCore::IconLoader::didReceiveData):
        (WebCore::IconLoader::didFailWithError):
        (WebCore::IconLoader::didFinishLoading):
        (WebCore::IconLoader::clearLoadingState):
        * loader/icon/IconLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::receivedAllData):
        (WebCore::Loader::didFailWithError):
        (WebCore::Loader::didReceiveResponse):
        (WebCore::Loader::didReceiveData):
        (WebCore::Loader::cancelRequests):
        * loader/loader.h:
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::SubresourceLoader):
        (WebCore::SubresourceLoader::create):
        (WebCore::SubresourceLoader::willSendRequest):
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didReceiveData):
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::didFail):
        (WebCore::SubresourceLoader::didCancel):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::create):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::finishJobAndHandle):
        (WebCore::ResourceHandle::loader):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::didFailWithError):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::willSendRequest):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Tue, 5 Dec 2006 01:29:07 +0000 (01:29 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test the part of http://bugs.webkit.org/show_bug.cgi?id=11628
          REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window
          that can easily be tested from the DOM -- this only checks that
          simulated mouse events from clicking on a link have the key state
          from the Enter key keyboard event, which is one part of the fix
          for the bug above

        * fast/events/simulated-key-state-expected.txt: Added.
        * fast/events/simulated-key-state.html: Added.

WebCore:

        Reviewed by Adele.

        - fix another part of http://bugs.webkit.org/show_bug.cgi?id=11628
          REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window

        This fixes command-return when the focus is on a link.
        Despite the title of the bug, Mitz wanted me to fix both, and I will not
        say no to him!

        Test: fast/events/simulated-key-state.html

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing
        false for all the key state in simulated mouse events, pass the state from the
        first underlying event in the chain that has key state; in the case in the bug,
        the keyboard event will be the underlying event itself and we'll propagate the
        alt key modifier to the mouse event, resulting in the effect we want. It's nice
        that JavaScript also gets to see the proper modifiers in the mouse event.

        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
        Added code to pass in an underlying event to dispatchSimulatedClick. After looking
        at all the other callers, this seems to be the only one that needs to pass an
        event that is currently passing 0. Also removed the code that only simulated a
        click when the event has a PlatformKeyboardEvent -- no reason for that and it
        prevented me from writing a layout test for the fix.

        * dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the
        underlyingEvent chain to find the first event that has key state. This already
        existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
        * dom/UIEventWithKeyState.cpp: Added.

        * CMakeLists.txt: Added UIEventWithKeyState.cpp.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
        * WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
        * WebCoreSources.bkl: Added UIEventWithKeyState.cpp.

        * WebCore.exp: Added findEventWithKeyState, used by WebKit.

WebKit:

        Reviewed by Adele.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::actionDictionary): Changed to use the new
        findEventWithKeyState function in WebCore instead of a local function
        in this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
kmccullo [Tue, 5 Dec 2006 00:49:16 +0000 (00:49 +0000)]
    Reviewed by Darin.

        - removed the guards for the "multiple forms submission" issue, which may not be
          an issue anymore and the guards prevent perfectly legitimate websites from
          working correctly.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setView):
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityPerformAction:]):
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::keyPress):
        * config.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm):
        * loader/FrameLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::receivedMainResourceError):
        * loader/qt/FrameLoaderQt.cpp:
        (WebCore::FrameLoader::submitForm):
        * page/Frame.cpp:
        (WebCore::Frame::setView):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::mouseDown):
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
ggaren [Tue, 5 Dec 2006 00:37:53 +0000 (00:37 +0000)]
    Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
        part of my last checkin.

        We have to turn on support for backward compatibility mode to avoid Dashboard
        regressions in the short term.

        * WebView/WebView.mm:
        (-[WebView _setDashboardBehavior:to:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Mon, 4 Dec 2006 23:54:29 +0000 (23:54 +0000)]
LayoutTests:

        Reviewed by Darin Adler.

        Removed Dashboard quirk from expected results. Now that we have a Dashboard
        quirks mode, there's no reason to keep the old, bad behavior in the browser.

        * http/tests/xmlhttprequest/exceptions-expected.txt:
        * http/tests/xmlhttprequest/exceptions.html:

WebCore:

        Reviewed by Darin Adler.

        Added support for Dashboard backward compatibility mode.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior
        of automatically clearing the stroke path buffer after a call to stroke().
        * html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas
        tag being self-closing.
        (WebCore::HTMLCanvasElement::endTagRequirement):
        (WebCore::HTMLCanvasElement::tagPriority):
        * html/HTMLCanvasElement.h:
        * html/HTMLParser.cpp: Ditto.
        (WebCore::HTMLParser::canvasCreateErrorCheck):
        * xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring
        a call to setRequestHeader() if it preceded a call to open() or followed a call
        to send().
        (WebCore::XMLHttpRequest::setRequestHeader):

WebKit:

        Reviewed by Darin Adler.

        Added SPI for enabling Dashboard backward compatibility mode. For now,
        we enable it unconditionally for Dashboard and Dashcode. Once they
        implement specific support for the backward compatibility mode behavior,
        we can change that.

        Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
        to YES in order to turn this code on.

        * WebView/WebView.mm:
        (-[WebView _setDashboardBehavior:to:]):
        (-[WebView _dashboardBehavior:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Mon, 4 Dec 2006 23:43:17 +0000 (23:43 +0000)]
WebCore:

        Reviewed by Alice.

        * bridge/EditorClient.h: Removed "_web_" prefix from
        C++ userVisibleString member function. Alice will probably change
        this so it's not on the editor client any more later.

        * editing/Editor.h: Removed "_web_" prefix from
        C++ userVisibleString member function.
        * editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific
        code from this file.

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable.
        (WebCore::Editor::userVisibleString): Moved this function here.

        * platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes.
        Made Pasteboard noncopyable. Removed use of "protected" where we should
        be using "private". Removed s_generalPasteboard.
        * platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the
        s_generalPasteboard global. Removed the unused destructor. Updated call
        to userVisibleString for name change. Tweaked formatting.

WebKit:

        Reviewed by Alice.

        * WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from
        C++ userVisibleString member function.
        * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString):
        Ditto.

        * WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
aliceli1 [Mon, 4 Dec 2006 23:30:19 +0000 (23:30 +0000)]
    Reviewed by Oliver.

        Moved some constants from EventHandlerMac.mm to EventHandler.cpp
        Added some platform-specific data members and functions.

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        * platform/PlatformMouseEvent.h:
        (WebCore::):
        (WebCore::PlatformMouseEvent::timestamp):
        (WebCore::PlatformMouseEvent::activatedWebView):
        (WebCore::PlatformMouseEvent::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin, Geoff.
andersca [Mon, 4 Dec 2006 23:26:05 +0000 (23:26 +0000)]
    Reviewed by Darin, Geoff.

        Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
        We use RefPtrs to ResourceHandle instead.

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::~IconLoader):
        (WebCore::IconLoader::stopLoading):
        (WebCore::IconLoader::didReceiveResponse):
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::jobForRequest):
        * loader/loader.h:
        * platform/network/ResourceHandle.cpp:
        * platform/network/ResourceHandle.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::finishJobAndHandle):
        (WebCore::ResourceHandle::reportError):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18006 268f45cc-cd09-0410-ab3c-d52691b4dbfc