WebKit-https.git
8 years agofix gtk breakage caused by changeset 96595
gavinp@chromium.org [Tue, 4 Oct 2011 20:56:39 +0000 (20:56 +0000)]
fix gtk breakage caused by changeset 96595
https://bugs.webkit.org/show_bug.cgi?id=69371

ews did not catch build breakage in the gtk WebKitPluginProcess target; this patch removes
the pretty printer on gtk, which should fix the build on that platform.

Reviewed by NOBODY, this is a build fix.

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate our copy of the HTML5 spec used for performance testing to match the latest...
eric@webkit.org [Tue, 4 Oct 2011 20:53:09 +0000 (20:53 +0000)]
Update our copy of the HTML5 spec used for performance testing to match the latest version
https://bugs.webkit.org/show_bug.cgi?id=69364

Unreviewed.  The patch is too large to post, so landing this unreviewed. :(

The copy of the html5 spec we were using for testing was over a year old
and didn't have any of the subresources with it (we were only using it
as an HTML parsing benchmark).  I'm about to use it for testing
the full load/render time of the benchmark, so I've updated to the latest
version of the spec (now 8mb instead of 5mb) and inlined two of the
CSS files.  (Inlining the CSS was necessary to make my testing consistent
as there seems to be a race with some timer fired after CSS load.)

Increasing from 5mb to 8mb showed a similar 30% slowdown in our parser
benchmarks as expected.

* Parser/resources/html5.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse const PlatformWheelEvent references where possible
andersca@apple.com [Tue, 4 Oct 2011 20:44:05 +0000 (20:44 +0000)]
Use const PlatformWheelEvent references where possible
https://bugs.webkit.org/show_bug.cgi?id=69367

Reviewed by Sam Weinig.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
* platform/ScrollableArea.h:
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink HTMLTableCellElement.
commit-queue@webkit.org [Tue, 4 Oct 2011 20:39:45 +0000 (20:39 +0000)]
Shrink HTMLTableCellElement.
https://bugs.webkit.org/show_bug.cgi?id=69347

Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Don't cache the rowspan and colspan attributes on the element.
This shrinks HTMLTableCellElement by one CPU word, reducing memory
consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.

* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::parseMappedAttribute):
* html/HTMLTableCellElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96630.
commit-queue@webkit.org [Tue, 4 Oct 2011 20:37:58 +0000 (20:37 +0000)]
Unreviewed, rolling out r96630.
http://trac.webkit.org/changeset/96630
https://bugs.webkit.org/show_bug.cgi?id=69368

Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04

Source/JavaScriptCore:

* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

Source/WebCore:

* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update Qt specific expected results.
ossy@webkit.org [Tue, 4 Oct 2011 20:24:35 +0000 (20:24 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected results.

* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable sub pixel text (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 20:20:13 +0000 (20:20 +0000)]
Enable sub pixel text (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69354
http://code.google.com/p/chromium/issues/detail?id=98165

Reviewed by Eric Seidel.

No new tests. Layout test pixel results have been
disabled and will be rebaselined once all Skia on Mac
changes are in.

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
Enable sub pixel text. This is set by default to enabled
by CoreGraphics, but by default disabled on Skia.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd loopsPerRun option to Parser performance test runner
eric@webkit.org [Tue, 4 Oct 2011 20:16:51 +0000 (20:16 +0000)]
Add loopsPerRun option to Parser performance test runner
https://bugs.webkit.org/show_bug.cgi?id=69363

Reviewed by Antti Koivisto.

Add loopsPerRun option and abstract out runLoop function (to make the UI more responsive).
No change in behavior in any of the tests.

* Parser/resources/runner.js:
(runLoop):
(run):
(start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove PlatformWheelEvent::m_isAccepted
andersca@apple.com [Tue, 4 Oct 2011 20:11:04 +0000 (20:11 +0000)]
Remove PlatformWheelEvent::m_isAccepted
https://bugs.webkit.org/show_bug.cgi?id=69357

Reviewed by Darin Adler.

../WebCore:

Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit/chromium:

* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
m_isAccepted has been removed.

* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::onMouseWheel):
Just return the value of handleWheelEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
cdn@chromium.org [Tue, 4 Oct 2011 19:47:32 +0000 (19:47 +0000)]
Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

Test: fast/css/counters/counter-after-style-crash.html

* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):

LayoutTests: Add test for crash when performing rich text mutations with counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

* fast/css/counters/counter-after-style-crash-expected.txt: Added.
* fast/css/counters/counter-after-style-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB add() should fail if key is NaN
commit-queue@webkit.org [Tue, 4 Oct 2011 19:35:23 +0000 (19:35 +0000)]
IndexedDB add() should fail if key is NaN
https://bugs.webkit.org/show_bug.cgi?id=62286

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/invalid-keys.html

Implement special case - numbers are valid keys, except for NaN.

* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):

LayoutTests:

Tests for NaN and other invalid IndexedDB keys.

* storage/indexeddb/invalid-keys-expected.txt: Added.
* storage/indexeddb/invalid-keys.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd static ClassInfo structs to classes that override JSCell::getCallData
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:22:00 +0000 (19:22 +0000)]
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:

getCallData was not marked as static is StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

Source/WebCore:

No new tests.

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeopard build fix after r96613.
rniwa@webkit.org [Tue, 4 Oct 2011 19:17:25 +0000 (19:17 +0000)]
Leopard build fix after r96613.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r94274): setting input.value erroneously triggers focus event
rniwa@webkit.org [Tue, 4 Oct 2011 19:02:44 +0000 (19:02 +0000)]
REGRESSION(r94274): setting input.value erroneously triggers focus event
https://bugs.webkit.org/show_bug.cgi?id=69315

Reviewed by Kent Tamura.

Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.

Added a manual test. Unfortunately, the test always passes in DRT.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/FrameSelection.h:
* manual-tests/mutate-unfocused-text-with-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplicitly add toString and valueOf to prototype when convertToType callback is provided
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:02:03 +0000 (19:02 +0000)]
Implicitly add toString and valueOf to prototype when convertToType callback is provided
https://bugs.webkit.org/show_bug.cgi?id=69156

Reviewed by Geoffrey Garen.

Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackFunction.h:
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/tests/testapi.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTML canvas strokes with dash and dashOffset
commit-queue@webkit.org [Tue, 4 Oct 2011 18:58:47 +0000 (18:58 +0000)]
HTML canvas strokes with dash and dashOffset
https://bugs.webkit.org/show_bug.cgi?id=63933

Patch by Young Han Lee <joybro201@gmail.com> on 2011-10-04
Reviewed by Simon Fraser.

Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
These attributes can be used to determine the dash-style of stroke in HTML Canvas.

As this kind of attributes are not specified in the HTML Canvas specification yet,
the 'webkit' prefix is added to its names.

Mozilla already implemented these attributes, mozDash and mozDashOffset [1], and this patch
is created by referring to the implementation. This patch is basically using the specified
behavior of stroke-dasharray and stroke-dashoffset in the SVG specification [2], except
that doesn't support units or percentages, just floating point numbers.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=662038
[2] http://www.w3.org/TR/SVG/painting.html#StrokeProperties

Source/WebCore:

Tests: fast/canvas/canvas-webkitLineDash-invalid.html
       fast/canvas/canvas-webkitLineDash.html

* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::webkitLineDash):
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::webkitLineDash):
(WebCore::CanvasRenderingContext2D::setWebkitLineDash):
(WebCore::CanvasRenderingContext2D::webkitLineDashOffset):
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

* fast/canvas/canvas-webkitLineDash-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid.html: Added.
* fast/canvas/canvas-webkitLineDash.html: Added.
* fast/canvas/script-tests/canvas-webkitLineDash-invalid.js: Added.
(trySettingLineDash):
(trySettingLineDashOffset):
* fast/canvas/script-tests/canvas-webkitLineDash.js: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdditional unreviewed Lion SVG pixel test rebaselining.
timothy_horton@apple.com [Tue, 4 Oct 2011 18:56:26 +0000 (18:56 +0000)]
Additional unreviewed Lion SVG pixel test rebaselining.

* platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/mac-snowleopard/svg/carto.net: Added.
* platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/mac/svg/carto.net/selectionlist-expected.png:
* platform/mac/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/mac/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow canvas backing store to be lazily allocated
mdelaney@apple.com [Tue, 4 Oct 2011 18:41:41 +0000 (18:41 +0000)]
Allow canvas backing store to be lazily allocated
https://bugs.webkit.org/show_bug.cgi?id=67054

Reviewed by Darin Adler.

No new tests; doesn't affect behavior.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer): Removed the setting of lineWidth
that caused the eager creation of ImageBuffer to use its GraphicsContext.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Added in default
line width setting along with other default context settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove font-fixup code in WebKitTestRunner to a better place
simon.fraser@apple.com [Tue, 4 Oct 2011 18:39:33 +0000 (18:39 +0000)]
Move font-fixup code in WebKitTestRunner to a better place
https://bugs.webkit.org/show_bug.cgi?id=69356

Reviewed by Sam Weinig.

Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
already contains font-related code.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartial unreviewed rebaselines for Lion SVG pixel tests.
timothy_horton@apple.com [Tue, 4 Oct 2011 18:35:29 +0000 (18:35 +0000)]
Partial unreviewed rebaselines for Lion SVG pixel tests.

* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
* platform/mac-snowleopard/svg/css: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png: Added.
* platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png: Added.
* platform/mac-snowleopard/svg/custom: Added.
* platform/mac-snowleopard/svg/custom/altglyph-expected.png: Added.
* platform/mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png: Added.
* platform/mac-snowleopard/svg/custom/junk-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/missing-xlink-expected.png: Added.
* platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
* platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
* platform/mac-snowleopard/svg/dom: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/hixie: Added.
* platform/mac-snowleopard/svg/hixie/error: Added.
* platform/mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/mac-snowleopard/svg/in-html: Added.
* platform/mac-snowleopard/svg/in-html/circle-expected.png: Added.
* platform/mac-snowleopard/svg/overflow: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/text/kerning-expected.png: Added.
* platform/mac-snowleopard/svg/text/multichar-glyph-expected.png: Added.
* platform/mac-snowleopard/svg/wicd: Added.
* platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/mac-snowleopard/svg/zoom: Added.
* platform/mac-snowleopard/svg/zoom/page: Added.
* platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/text: Added.
* platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
* platform/mac/svg/css/composite-shadow-example-expected.png:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
* platform/mac/svg/css/stars-with-shadow-expected.png:
* platform/mac/svg/custom/altglyph-expected.png:
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
* platform/mac/svg/custom/junk-data-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
* platform/mac/svg/custom/path-bad-data-expected.png:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac/svg/custom/use-font-face-crash-expected.png:
* platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
* platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
* platform/mac/svg/dom/SVGNumberList-basics-expected.png:
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGPointList-basics-expected.png:
* platform/mac/svg/dom/SVGStringList-basics-expected.png:
* platform/mac/svg/dom/SVGTransformList-basics-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
* platform/mac/svg/hixie/error/012-expected.png:
* platform/mac/svg/in-html/circle-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
* platform/mac/svg/text/kerning-expected.png:
* platform/mac/svg/text/multichar-glyph-expected.png:
* platform/mac/svg/wicd/rightsizing-grid-expected.png:
* platform/mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
* platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
* platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for the CSP connect-src directive
weinig@apple.com [Tue, 4 Oct 2011 18:30:32 +0000 (18:30 +0000)]
Add support for the CSP connect-src directive
https://bugs.webkit.org/show_bug.cgi?id=69353

Reviewed by Adam Barth.

Add CSP support for XMLHttpRequest, WebSockets and EventSource.

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html
       http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html
       http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowConnectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
Add connect-src directive parsing and predicate.

* page/EventSource.cpp:
(WebCore::EventSource::create):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Test allowConnectFromSource when establishing a connection.

LayoutTests:

* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=69317
hyatt@apple.com [Tue, 4 Oct 2011 18:17:04 +0000 (18:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69317

[CSS3 Regions] Make overflow:hidden/auto/scroll sections behave properly when split across regions. This
includes sizing and positioning independently in each region, clipping independently in each region, and
shifting to avoid floats in each region.

Reviewed by Anders Carlsson.

Source/WebCore:

Added many new tests in fast/regions.

* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
Patching a call to overflowClipRect, which now includes a region argument so that clipping can be adjusted
per-region.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Don't clear out the cached region information when the width changes. Instead make a new call to
the flow thread to check if widths changed in any region and set relayoutChildren to true if so.

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
This is a new function that has been split out from determineLogicalLeftPositionForChild so that it can
be called by region code to compute offsets independently in each region without altering the overall object's
logical left position.

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
Patched to call computeStartPositionDeltaForChildAvoidingFloats instead of doing the work of avoiding the floats
itself.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Fix the left clamping code to clamp to the left border in the correct region rather than always just clamping
to 0.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Tweaked to handle the new signature of borderBoxRectInRegion.

(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
Reworked not to return 0 on failure or when done, but to just return the current height. This is a more
fitting answer for the function to return when no more floats remain.

(WebCore::RenderBlock::getClearDelta):
Big changes to this function. It was never patched to support writing modes, so the new code is all
writing-mode-aware now. Also improved the computeLogicalWidth() call to make sure margins didn't get incorrectly changed.
The code computes transient information in each region as the object tries to find a place to fit, so that the
old widths are properly retained when layout of that child later checks to see if it needs to relayout children or not.

(WebCore::RenderBlock::nodeAtPoint):
Patched to call overflowClipRect with the region being hit tested.

(WebCore::inNormalFlow):
Tweaked to not need the initialBlock variable.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
Tweaked to use inRenderFlowThread() now that it exists. Also removing the regionsHaveUniformLogicalWidth()
optimization, since you can't rely on that when objects size differently depending on floats. In other words,
the future of pagination is variable width objects even in printing/columns.

(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
Renamed to make it more clear what logicalPageOffset() was. It's your offset from the top of the first page.

(WebCore::RenderBlock::regionAtBlockOffset):
New helper function for accessing the region at a given offset within your block.

(WebCore::RenderBlock::logicalWidthChangedInRegions):
New helper function that computes whether or not your logical width information changed in any regions. If so,
relayoutChildren gets set to true (just as it would have when computeLogicalWidth for the overall block changes
values).

(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
Tweaked because of const to take const arguments.

* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalLeftForChild):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::startOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Reworking these functions so versions exist that take regions and page offsets to avoid having to recalculate
where you are over and over again as you walk up a containing block chain.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitBelowFloats):
Changed to handle the better return value for nextFloatLogicalBottomBelow.

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
Removing the uniform logical width optimization.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
Changed to take a region and offset from the first page so that it doesn't have to be recomputed as you recur up
the containing block chain.

(WebCore::RenderBox::clearRenderBoxRegionInfo):
Changed to just use inRenderFlowThread().

(WebCore::RenderBox::pushContentsClip):
Changed for the new region-parameterized overflow clip function.

(WebCore::RenderBox::overflowClipRect):
Now takes a region so that a specific clip rect can be returned sized to the appropriate border box in that
region.

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Objects in flow threads no longer shrink to avoid floats when computing their overall widths. The region-specific
check now does the shrinking. It checks at the point where the region slices the object, or the top of the object if
it begins in the middle of the region.

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Push all the rest of the computeLogicalWidth code into computeLogicalWidthInRegion.

(WebCore::RenderBox::renderBoxRegionInfo):
Changed to take the region and the offset from the top of the first page to avoid recomputation.

* rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasVisualOverflow):
New helper used by the RenderLayer code to avoid having to check visual overflow when none exists.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the new region-specific overflow clip.

* rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::shiftLogicalLeft):
Helper used by the region code to shift a box over when floats cause it to move.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalWidth):
Remove the optimization to avoid creating box info for uniform widths.

(WebCore::RenderFlowThread::paintIntoRegion):
Make the clip rects used when painting the flow thread's layer tree temporary in each region.

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Removing the uniform logical width optimization

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
* rendering/RenderFlowThread.h:
New helper called to see if a block needs to relayout its children because its width changed in some
region.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
(WebCore::RenderLayer::repaintBlockSelectionGaps):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):
Changing all the layer clipping code to pass regions through to all of the helper functions involved. This is
so overflowClipRect can ultimately take a region. Eventually when we get positioned objects moving independently
in each region, we'll patch the "clip" property as well, and it will be much easier because all the plumbing has
been put in place here for overflow.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderFlowThread):
Optimized to not walk up the render tree if we're in layout and a currentRenderFlowThread() exists.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
Removing the optimization for uniform logical width regions. Changed remove to take so that the caller
can examine it before deleting.

(WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):
* rendering/RenderRegion.h:
Helper function that computes the region's offset from the top of the first page.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
Changed to pass the region to overflowClipRect.

* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Modified because the layer clip functions need regions now.

* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
Changed to use inRenderFlowThread over view()->hasRenderFlowThread.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
Patched to use the new overflowClipRect that is region-specific.

LayoutTests:

* fast/regions/floats-basic-in-variable-width-regions.html: Added.
* fast/regions/overflow-in-uniform-regions-dynamic.html: Added.
* fast/regions/overflow-in-uniform-regions.html: Added.
* fast/regions/overflow-in-variable-width-regions.html:
* fast/regions/overflow-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-rtl-in-variable-width-regions.html:
* fast/regions/overflow-size-change-in-variable-width-regions.html: Added.
* fast/regions/overflow-size-change-with-stacking-context.html: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKPreferences should allow control of application chrome mode
jeffm@apple.com [Tue, 4 Oct 2011 18:15:42 +0000 (18:15 +0000)]
WKPreferences should allow control of application chrome mode
https://bugs.webkit.org/show_bug.cgi?id=69344

Reviewed by Dan Bernstein.

* Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.

* UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set application chrome mode setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT: Add DumpRenderTree.cpp
commit-queue@webkit.org [Tue, 4 Oct 2011 18:15:30 +0000 (18:15 +0000)]
[EFL] DRT: Add DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=62034

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-04
Reviewed by Antonio Gomes.

This is the main implementation file for EFL's DumpRenderTree.

* DumpRenderTree/efl/DumpRenderTree.cpp: Added.
(dumpFramesAsText):
(dumpFrameScrollPosition):
(shouldLogFrameLoadDelegates):
(shouldDumpAsText):
(sendPixelResultsEOF):
(invalidateAnyPreviousWaitToDumpWatchdog):
(onEcoreEvasResize):
(onCloseWindow):
(useLongRunningServerMode):
(parseCommandLineOptions):
(getFinalTestURL):
(getExpectedPixelHash):
(createLayoutTestController):
(runTest):
(runTestingServerLoop):
(adjustOutputTypeByMimeType):
(dumpFrameContentsAsText):
(shouldDumpFrameScrollPosition):
(shouldDumpPixelsAndCompareWithExpected):
(shouldDumpBackForwardList):
(initEfl):
(shutdownEfl):
(displayWebView):
(dump):
(initEcoreEvas):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore work towards making PlatformWheelEvent immutable
andersca@apple.com [Tue, 4 Oct 2011 18:15:09 +0000 (18:15 +0000)]
More work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69348

Reviewed by Sam Weinig.

More work on getting rid of m_isAccepted from PlatformWheelEvent. Add more asserts
that the return value of handleWheelEvent is equal to m_isAccepted.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Implement default error pages in WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 4 Oct 2011 18:14:19 +0000 (18:14 +0000)]
[GTK] Implement default error pages in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69255

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitError.cpp:
(webkit_policy_error_quark): Add quark for policy errors.
(webkit_plugin_error_quark): Add quark for plugin errors.
* UIProcess/API/gtk/WebKitError.h: Add policy and plugin errors.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientLoadFailed): Load a custom error page when
load failed and signal has not been handled.
(webkit_web_loader_client_class_init): Add default implementation
for provisional_load_failed and load_failed virtual methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInset focus ring (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 18:12:58 +0000 (18:12 +0000)]
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956

This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.

Reviewed by Adam Barth.

No new tests. This platform is not enabled.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 4 Oct 2011 18:11:55 +0000 (18:11 +0000)]
[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69254

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_alternate_html):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadAlternateContentLoadFinished):
(loadAlternateContentLoadFailed):
(testLoadAlternateContent):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtend DOM WheelEvent to differentiate between physical and logical scroll directions
jonlee@apple.com [Tue, 4 Oct 2011 18:06:44 +0000 (18:06 +0000)]
Extend DOM WheelEvent to differentiate between physical and logical scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959
<rdar://problem/10036688>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* wtf/Platform.h: Added HAVE_INVERTED_WHEEL_EVENTS for Lion and later.

Source/WebCore:

Test: fast/events/wheelevent-direction-inverted-from-device.html

* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
* dom/WheelEvent.h:
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
* dom/WheelEvent.idl: Added the webkitDirectionInvertedFromDevice idl attribute.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::webkitDirectionInvertedFromDevice):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): if building on Lion or later, use
[NSEvent isDirectionInvertedFromDevice].
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

Source/WebKit2:

* Shared/WebEvent.h:
(WebKit::WebWheelEvent::directionInvertedFromDevice):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent): get the flag from the NSEvent.
* UIProcess/WebPageProxy.cpp:
(WebKit::coalesce):

LayoutTests:

* fast/events/wheelevent-direction-inverted-from-device-expected.txt: Added.
* fast/events/wheelevent-direction-inverted-from-device.html: Added.
* platform/mac-wk2/Skipped: WKTR does not support mouse scroll events yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
commit-queue@webkit.org [Tue, 4 Oct 2011 18:04:21 +0000 (18:04 +0000)]
[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
https://bugs.webkit.org/show_bug.cgi?id=69338

Unreviewed build fix

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-04

Source/WebCore:

* CMakeListsEfl.txt:

Source/WebKit/efl:

* CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
commit-queue@webkit.org [Tue, 4 Oct 2011 18:02:41 +0000 (18:02 +0000)]
[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
https://bugs.webkit.org/show_bug.cgi?id=69325

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Gustavo Noronha Silva.

Documentation generation for WebKit2-GTK+ APIs
using gtk-doc.

.:

* configure.ac:

Source/WebKit2:

* GNUmakefile.am: Added doc generation files to EXTRA_DIST.
* UIProcess/API/gtk/docs/GNUmakefile.am: Makefile for doc generation.
* UIProcess/API/gtk/docs/version.xml.in: Version information.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Document template.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Document sections added.
* UIProcess/API/gtk/docs/webkit2gtk.types: Added GObjects types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResource loader should block HTTP redirects to local resources
commit-queue@webkit.org [Tue, 4 Oct 2011 18:00:32 +0000 (18:00 +0000)]
Resource loader should block HTTP redirects to local resources
https://bugs.webkit.org/show_bug.cgi?id=68706

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-03
Reviewed by Adam Barth.

Source/WebCore:

Modified MainResourceLoader to add an extra security check on
HTTP redirects. Also, moved isFeedWithNestedProtocolInHTTPFamily
to SecurityOrigin.cpp.

* loader/FrameLoader.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::FrameLoader::loadFrameRequest):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
* page/SecurityOrigin.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::canDisplay):

LayoutTests:

Adding a test to attempt an HTTP redirect to a file: URL.

* http/tests/security/redirect-BLOCKED-to-localURL.html: Added.
* http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
* http/tests/security/resources/file-redirect-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApply color profile found to decoded bitmap (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 17:49:46 +0000 (17:49 +0000)]
Apply color profile found to decoded bitmap (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69144
This fixes http://code.google.com/p/chromium/issues/detail?id=97830

Reviewed by Stephen White.

No new tests. This platform is not enabled.

* platform/image-decoders/ImageDecoder.h:
Add color profile slot to Skia variation.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
Adjust the bitmap in place to use the supplied color space.

(WebCore::createColorSpace):
Create a CGColorSpace from a color profile.

(WebCore::ImageFrame::setColorProfile):
Save the image's color profile until the image is complete.

(WebCore::ImageFrame::setStatus):
Apply the color profile, if any, to the image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestore Linux baseline for this test. The Linux baseline got clobbered
abarth@webkit.org [Tue, 4 Oct 2011 17:47:29 +0000 (17:47 +0000)]
Restore Linux baseline for this test.  The Linux baseline got clobbered
when I updated the Windows baseline.

* platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.
leandro@webkit.org [Tue, 4 Oct 2011 17:44:49 +0000 (17:44 +0000)]
[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.

The Perl scripts in the css/ directory expect the definitions passed via
--defines to be a string of space-separated entries, however we were passing a
list of semicolon-separated strings, thus making all feature defines actually
be ignored.

Detected after r96433, which checked for some definitions in
CSSPropertyNames.in.

No new tests, this is a build fix.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
commit-queue@webkit.org [Tue, 4 Oct 2011 17:39:33 +0000 (17:39 +0000)]
[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
https://bugs.webkit.org/show_bug.cgi?id=69329

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Martin Robinson.

Added documentation for WebKitNetworkError enum and corrected few other
minor issues in WebKit2-GTK+ API documentation.

* UIProcess/API/gtk/WebKitError.h: Added documentation for WebKitNetworkError.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkit_web_loader_client_class_init): Corrected parameter name.
* UIProcess/API/gtk/WebKitWebView.cpp: Corrected annotation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 17:22:16 +0000 (17:22 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; rebaselines for GTK after r96509.

        * platform/gtk/fast/forms/file-input-disabled-expected.png:
        * platform/gtk/fast/forms/file-input-disabled-expected.txt:
        * platform/gtk/fast/invalid/017-expected.txt:
        * platform/gtk/fast/invalid/018-expected.txt:
        * platform/gtk/fast/invalid/020-expected.txt:
        * platform/gtk/fast/invalid/residual-style-expected.png:
        * platform/gtk/fast/invalid/residual-style-expected.txt:
        * platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
        * platform/gtk/fast/table/inline-form-assert-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug56405-expected.png:
        * platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug56563-expected.png:
        * platform/gtk/tables/mozilla/bugs/bug56563-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug9024-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make SourceFrame compile.
pfeldman@chromium.org [Tue, 4 Oct 2011 17:19:04 +0000 (17:19 +0000)]
Web Inspector: make SourceFrame compile.
https://bugs.webkit.org/show_bug.cgi?id=69345

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.inspectElement):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._inspectElementRequested):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrameDelegate.prototype.requestContent):
(WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.continueToLine):
(WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegate.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
* inspector/front-end/externs.js:
(WebInspector.log):
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
* inspector/front-end/utilities.js:
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 16:59:53 +0000 (16:59 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; new baselines for GTK after r96470

        * platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
        * platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate font shaping result after http://trac.webkit.org/changeset/96582.
abarth@webkit.org [Tue, 4 Oct 2011 16:53:29 +0000 (16:53 +0000)]
Update font shaping result after trac.webkit.org/changeset/96582.
This appears to be a progression, but I'll check with the authors of
that patch to be sure.

* platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate leopard results.
abarth@webkit.org [Tue, 4 Oct 2011 16:48:48 +0000 (16:48 +0000)]
Update leopard results.

* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug23994-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-object: Removed.
* platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Removed.
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 16:32:03 +0000 (16:32 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; new baselines for GTK after r96257, r96374 and r96404.

        * platform/gtk/fast/repaint/selection-clear-expected.png: Added.
        * platform/gtk/fast/repaint/selection-clear-expected.txt: Added.
        * platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
        * platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
        * platform/gtk/fast/text/line-initial-and-final-swashes-expected.png: Added.
        * platform/gtk/fast/text/line-initial-and-final-swashes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Factor out object properties popup.
mnaganov@chromium.org [Tue, 4 Oct 2011 16:17:43 +0000 (16:17 +0000)]
Web Inspector: Factor out object properties popup.
https://bugs.webkit.org/show_bug.cgi?id=69234

Also, for HTML elements, show a non-empty id value in the element name.

Reviewed by Pavel Feldman.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMinGW warning fix after r96286.
ossy@webkit.org [Tue, 4 Oct 2011 16:16:16 +0000 (16:16 +0000)]
MinGW warning fix after r96286.

Avoid redefining STDCALL, because STDCALL is also defined in mingw32/include/windef.h:

Reviewed by Tor Arne Vestbø.

* assembler/MacroAssemblerCodeRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: compile text editor.
pfeldman@chromium.org [Tue, 4 Oct 2011 16:11:59 +0000 (16:11 +0000)]
Web Inspector: compile text editor.
https://bugs.webkit.org/show_bug.cgi?id=69339

Drive-by compilation for color, database and dom storage entities.

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/Color.js:
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.makeKey):
(WebInspector.KeyboardShortcut.makeKeyFromEvent):
(WebInspector.KeyboardShortcut.makeDescriptor):
* inspector/front-end/SourceCSSTokenizer.js:
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.prototype._charAt):
(WebInspector.SourceTokenizer.prototype.createInitialCondition):
(WebInspector.SourceTokenizer.prototype.nextToken):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewerDelegate.prototype.doubleClick):
(WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegate.prototype.afterTextChanged):
(WebInspector.TextViewerDelegate.prototype.commitEditing):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegate.prototype.suggestedFileName):
(WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._createLink):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
* inspector/front-end/externs.js:
(WebInspector.completeURL):
(window.getComputedStyle):
(Event.prototype.initWebKitWheelEvent):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Timeline panel shortcut for filtering short records should have shorte...
vsevik@chromium.org [Tue, 4 Oct 2011 15:49:50 +0000 (15:49 +0000)]
Web Inspector: Timeline panel shortcut for filtering short records should have shorter description.
https://bugs.webkit.org/show_bug.cgi?id=69333

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago add more stack dumping methods
gavinp@chromium.org [Tue, 4 Oct 2011 15:39:46 +0000 (15:39 +0000)]
   add more stack dumping methods
       https://bugs.webkit.org/show_bug.cgi?id=69018

       In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
       WebKit programmatically retrieve the current stack.  This is useful if you need to add more
       reporting to field crash report uploads, if you're tracking down an irreproducable bug,
       for instance.

       Reviewed by Darin Adler.

       * wtf/Assertions.cpp:
       * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink StyleRareNonInheritedData.
commit-queue@webkit.org [Tue, 4 Oct 2011 15:13:45 +0000 (15:13 +0000)]
Shrink StyleRareNonInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69331

Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Rearrange the members and move all small types into the bitfield.
This shrinks StyleRareNonInheritedData by two CPU words, reducing memory
consumption by 140 kB (on 64-bit) when loading the full HTML5 spec.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
vsevik@chromium.org [Tue, 4 Oct 2011 15:02:25 +0000 (15:02 +0000)]
Web Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=69332

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/inspector/network/disabled-cache-crash-expected.txt: Removed.
* http/tests/inspector/network/disabled-cache-crash.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoallow failure of most Chromium-Mac-Skia tests while we clean up that port
commit-queue@webkit.org [Tue, 4 Oct 2011 14:45:39 +0000 (14:45 +0000)]
allow failure of most Chromium-Mac-Skia tests while we clean up that port
https://bugs.webkit.org/show_bug.cgi?id=69279

Patch by Elliot Poger <epoger@google.com> on 2011-10-04
Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make DataGrid compile
pfeldman@chromium.org [Tue, 4 Oct 2011 14:23:24 +0000 (14:23 +0000)]
Web Inspector: make DataGrid compile
https://bugs.webkit.org/show_bug.cgi?id=69334

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-04
Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype._startEditingConfig):
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeChildrenRecursive):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
(WebInspector.DataGridNode.prototype._attach):
* inspector/front-end/UIUtils.js:
(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.EditingConfig):
(WebInspector.startEditing.blurEventListener):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):
* inspector/front-end/externs.js:
(Array.prototype.remove):
(window.getComputedStyle):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Web Inspector: save inspector state into single string instead of string map
yurys@chromium.org [Tue, 4 Oct 2011 14:12:19 +0000 (14:12 +0000)]
[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335

Added explicit methods for saving and restoring agent runtime state.

Reviewed by Pavel Feldman.

* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
(WebKit::WebDevToolsAgentClient::saveAgentRuntimeState):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
* src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 4 Oct 2011 14:09:06 +0000 (14:09 +0000)]
2011-10-04  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] extension panel's toolbar icon is incorrect when inspector window is docked
        https://bugs.webkit.org/show_bug.cgi?id=69336

        Reviewed by Pavel Feldman.

        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: update call frame location when source mapping is changed.
podivilov@chromium.org [Tue, 4 Oct 2011 13:24:01 +0000 (13:24 +0000)]
Web Inspector: update call frame location when source mapping is changed.
https://bugs.webkit.org/show_bug.cgi?id=68997

Currently we use fake "debugger-paused" event hack to update execution line and call stack placards when source mapping is changed.
- add PresentationCallFrame.createPlacard method to create "live" placards that are updated on source mapping changes.
- remove PresentationCallFrame functionName, isInternalScript, and url getters.
- fire execution-line-changed event when selected call frame or source mapping is changed.

Reviewed by Pavel Feldman.

* inspector/compile-front-end.sh:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMappingPayload):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
* inspector/front-end/ContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.get rawSourceCode):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
* inspector/front-end/externs.js:
(WebInspector.displayNameForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Tue, 4 Oct 2011 12:58:27 +0000 (12:58 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip one more failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 4 Oct 2011 12:56:38 +0000 (12:56 +0000)]
2011-10-04  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: inspector tests fix.

        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionPanel):
        (WebInspector.ExtensionPanel.prototype.get toolbarItemLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add compiler source mapping support to RawSourceCode.
podivilov@chromium.org [Tue, 4 Oct 2011 12:32:51 +0000 (12:32 +0000)]
Web Inspector: add compiler source mapping support to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=68891

Reviewed by Pavel Feldman.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
* inspector/front-end/CompilerSourceMappingProvider.js: Added.
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/UISourceCodeContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: start adding UI components to the compilation process.
pfeldman@chromium.org [Tue, 4 Oct 2011 11:37:25 +0000 (11:37 +0000)]
Web Inspector: start adding UI components to the compilation process.
https://bugs.webkit.org/show_bug.cgi?id=69319

Patch by Pavel Feldman <pfeldman@google.com> on 2011-10-04
Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.resize):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.statusBarResized):
* inspector/front-end/EmptyView.js:
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.set get toolbarItemLabel):
(WebInspector.Panel.prototype.get statusBarItems):
(WebInspector.Panel.prototype.updateMainViewWidth):
(WebInspector.Panel.prototype.statusBarResized):
* inspector/front-end/PropertiesSection.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onKeyDown):
* inspector/front-end/Section.js:
(WebInspector.Section.prototype.set populated):
(WebInspector.Section.prototype.onpopulate):
(WebInspector.Section.prototype.expand):
* inspector/front-end/SidebarPane.js:
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/UIUtils.js: Added.
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
(WebInspector.animateStyle.cancel):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(WebInspector.extensionServer.notifyPanelShown):
(WebInspector.extensionServer.notifyPanelHidden):
(WebInspector.currentPanel):
(WebInspector.setCurrentPanel):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update expectations for svg/W3C-SVG-1.1/pservers-grad-06-b.svg
hans@chromium.org [Tue, 4 Oct 2011 11:03:42 +0000 (11:03 +0000)]
[Chromium] Update expectations for svg/W3C-SVG-1.1/pservers-grad-06-b.svg
https://bugs.webkit.org/show_bug.cgi?id=69330

Win rebaseline.

* platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Implement font shaping with font-feature-settings on Windows
bashi@chromium.org [Tue, 4 Oct 2011 10:16:05 +0000 (10:16 +0000)]
[Chromium] Implement font shaping with font-feature-settings on Windows
https://bugs.webkit.org/show_bug.cgi?id=65904

Reviewed by Kenneth Russell.

Source/WebCore:

Use Uniscribe's OpenType APIs to shape complex text to support -webkit-font-feature-settings property.

No new tests. css3/font-feature-settings-rendering.html should pass by this patch.

* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::loadOpenTypeFunctions):
(WebCore::UniscribeHelper::UniscribeHelper): Calls loadOpenTypeFunctions if needed.
(WebCore::UniscribeHelper::fillRuns): Uses ScriptItemizeOpenType() if possible.
(WebCore::UniscribeHelper::shape): Uses ScriptShapeOpenType() if possible.
(WebCore::UniscribeHelper::fillShapes): Adds OpenType script tag as an argument.
(WebCore::convertFeatureTag): Added.
(WebCore::UniscribeHelper::setRangeProperties): Added.
* platform/graphics/chromium/UniscribeHelper.h:
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): Calls setRangeProperties().

LayoutTests:

Adds expectations of css3/font-feature-settings-rendering.html for Chromium win port. Since Uniscirbe OpenType APIs are not available on WinXP by default, the test could fail on WinXP.

* platform/chromium-win/css3/font-feature-settings-rendering-expected.png: Added.
* platform/chromium-win/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt: VISTA and WIN7 should pass css3/font-feature-settings-rendering.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implement declared but missing functions.
ryuan.choi@samsung.com [Tue, 4 Oct 2011 10:07:39 +0000 (10:07 +0000)]
[EFL] Implement declared but missing functions.
https://bugs.webkit.org/show_bug.cgi?id=65368

Unreviewed build fix for WebKit/Efl builds after r96566.

* platform/efl/CursorEfl.cpp:
(WebCore::Cursor::operator=):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::localizedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move abstract panel search logic into the only view that is using it.
pfeldman@chromium.org [Tue, 4 Oct 2011 10:05:46 +0000 (10:05 +0000)]
Web Inspector: move abstract panel search logic into the only view that is using it.
https://bugs.webkit.org/show_bug.cgi?id=69328

Reviewed by Yury Semikhatsky.

* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.searchCanceled):
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCount):
(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCountSoon):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.performSearch.processChunk):
(WebInspector.ProfilesPanel.prototype.performSearch):
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 4 Oct 2011 09:51:47 +0000 (09:51 +0000)]
2011-10-04  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fixed poor inspector merge, drive-by front-endcompilation fix.

        * inspector/front-end/ContentProviders.js:
        (WebInspector.ScriptContentProvider.prototype.requestContent):
        (WebInspector.ScriptContentProvider.prototype.searchInContent):
        (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
        * inspector/front-end/DebuggerPresentationModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.
reni@webkit.org [Tue, 4 Oct 2011 09:30:03 +0000 (09:30 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-04

* platform/qt/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-saturate-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: remove dependency from GoToLine dialog from Panel.
pfeldman@chromium.org [Tue, 4 Oct 2011 09:17:08 +0000 (09:17 +0000)]
Web Inspector: remove dependency from GoToLine dialog from Panel.
https://bugs.webkit.org/show_bug.cgi?id=69327

Reviewed by Yury Semikhatsky.

* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.install):
(WebInspector.GoToLineDialog._show):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype._tabSelected):
(WebInspector.ResourceContentView.prototype.contentLoaded):
(WebInspector.ResourceContentView.prototype.canHighlightLine):
(WebInspector.ResourceContentView.prototype.highlightLine):
(set WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.viewGetter):
(WebInspector.NetworkPanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.registerShortcut):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.viewGetter):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.showResource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.viewGetter):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.canHighlightLine):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._hideTab):
(WebInspector.TabbedPane.prototype.canHighlightLine):
(WebInspector.TabbedPane.prototype.highlightLine):
* inspector/front-end/View.js:
(WebInspector.View.prototype.canHighlightLine):
(WebInspector.View.prototype.highlightLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96491.
commit-queue@webkit.org [Tue, 4 Oct 2011 09:03:51 +0000 (09:03 +0000)]
Unreviewed, rolling out r96491.
http://trac.webkit.org/changeset/96491
https://bugs.webkit.org/show_bug.cgi?id=69326

Breaks Slow Leopard inspector tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTreeTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTreeTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest):
* http/tests/inspector/search/resources/search-concatenated.html: Removed.
* http/tests/inspector/search/search-in-concatenated-script-expected.txt: Removed.
* http/tests/inspector/search/search-in-concatenated-script.html: Removed.
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-script-expected.txt: Removed.
* http/tests/inspector/search/search-in-script.html: Removed.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
pfeldman@chromium.org [Tue, 4 Oct 2011 08:37:04 +0000 (08:37 +0000)]
Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
https://bugs.webkit.org/show_bug.cgi?id=69269

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._messagesClicked):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):
* inspector/front-end/ContextMenu.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/HelpScreen.js:
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut):
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype._didFormatContent):
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/TextPrompt.js:
* inspector/front-end/externs.js:
(WebInspector.populateHrefContextMenu):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac rebaseline after r96510.
rniwa@webkit.org [Tue, 4 Oct 2011 07:21:48 +0000 (07:21 +0000)]
Mac rebaseline after r96510.

* platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac rebaseline after r96509.
rniwa@webkit.org [Tue, 4 Oct 2011 06:42:36 +0000 (06:42 +0000)]
Mac rebaseline after r96509.

* platform/mac/fast/forms/file-input-disabled-expected.txt:
* platform/mac/fast/invalid/017-expected.txt:
* platform/mac/fast/invalid/018-expected.txt:
* platform/mac/fast/invalid/020-expected.txt:
* platform/mac/fast/invalid/residual-style-expected.txt:
* platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/mac/fast/table/inline-form-assert-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9024-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.
ossy@webkit.org [Tue, 4 Oct 2011 06:22:14 +0000 (06:22 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.

* platform/qt/fast/invalid/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png.
* platform/qt/fast/invalid/017-expected.txt:
* platform/qt/fast/invalid/018-expected.png: Added.
* platform/qt/fast/invalid/018-expected.txt:
* platform/qt/fast/invalid/020-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.png.
* platform/qt/fast/invalid/020-expected.txt:
* platform/qt/fast/invalid/table-inside-stray-table-content-expected.png: Added.
* platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/qt/fast/table/inline-form-assert-expected.png:
* platform/qt/fast/table/inline-form-assert-expected.txt:
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug23994-expected.png:
* platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56405-expected.png:
* platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56563-expected.png:
* platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
* platform/qt/tables/mozilla/bugs/bug9024-expected.png: Added.
* platform/qt/tables/mozilla/bugs/bug9024-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug9024-expected.txt.
* platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
* platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac release build fix after r96561, and Leopard build fix after r96568.
rniwa@webkit.org [Tue, 4 Oct 2011 04:16:29 +0000 (04:16 +0000)]
Mac release build fix after r96561, and Leopard build fix after r96568.

* editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::textCharAt):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix after r96568.
rniwa@webkit.org [Tue, 4 Oct 2011 03:52:43 +0000 (03:52 +0000)]
Build fix after r96568.

* accessibility/AccessibilityObject.cpp:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
* editing/Editor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should inline Array.push and Array.pop
fpizlo@apple.com [Tue, 4 Oct 2011 03:20:05 +0000 (03:20 +0000)]
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Geoff Garen.

Fix 32-bit.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShould call checkTextOfParagraph() indirectly to make unifying spell-checking code...
commit-queue@webkit.org [Tue, 4 Oct 2011 03:10:54 +0000 (03:10 +0000)]
Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
https://bugs.webkit.org/show_bug.cgi?id=69241

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-03
Reviewed by Ryosuke Niwa.

WebCore has two different code paths for spell-checking:
  1) checkTextOfParagraph() for Snow Leopard or later
  2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

At the first step, this patch introduces an indirect wrapper to call
checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
other non-SL or non-Lion platform.

No new tests because this patch does not change a behavior.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling): ditto.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::checkTextOfParagraph): Added.
* editing/TextCheckingHelper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should inline Array.push and Array.pop
fpizlo@apple.com [Tue, 4 Oct 2011 02:55:54 +0000 (02:55 +0000)]
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Oliver Hunt.

1% speed-up in V8 due to 6% speed-up in V8-deltablue.

* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange cursor to hand over missing plug-in message
darin@apple.com [Tue, 4 Oct 2011 02:26:10 +0000 (02:26 +0000)]
Change cursor to hand over missing plug-in message
https://bugs.webkit.org/show_bug.cgi?id=69312

Reviewed by Sam Weinig.

No tests because we currently don't have any test machinery for cursors.

* page/EventHandler.cpp:
(WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
to represent either a cursor, or no cursor change.
(WebCore::OptionalCursor::isCursorChange): Added.
(WebCore::OptionalCursor::cursor): Added.
(WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
moved some special cases from handleMouseMoveEvent in here. Moved the logic
for plug-ins and framesets into the specific renderer classes for those.
Added a call to the new getCursor virtual function.
(WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
just be a call to selectCursor and then setCursor. Plug-in-specific code is now
in RenderWidget.

* page/EventHandler.h: Changed return type of selectCursor.

* page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
(WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
Yes, this has nothing to do with the rest of the patch, but it's good.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
(WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
Overloaded so it can be called with a point rather than an event.
(WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
the logic below.
(WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
Changed to use shouldMissingPluginMessageBeButton.
(WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
a hand when over the missing plug-in message.
* rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated
for other changes above.

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::selectCursor about cursors when over
resizable frame borders.
* rendering/RenderFrameSet.h: Added getCursor.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.
* rendering/RenderObject.h: Added getCursor.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
the cursor when the pointer is over a plug-in. This new code is much better,
because it only kicks in when there is actually a plug-in present. The old
was based on the HTML tag!
* rendering/RenderWidget.h: Added getCursor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should remove builders from the failure grid once they start to pass
abarth@webkit.org [Tue, 4 Oct 2011 02:00:14 +0000 (02:00 +0000)]
garden-o-matic should remove builders from the failure grid once they start to pass
https://bugs.webkit.org/show_bug.cgi?id=69309

Unreviewed.  dglazkov is on vacation.  I need to interest someone else
in reviewing these patches.

This patch follows the update/purge model from UpdateTracker.  This
patch is less awesome than it could be because it causes the UI to
flash slightly.  In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing.  However,
that's not such a big deal because this UI is hidden in the default
view.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC ASSERT Opening the Web Inspector
fpizlo@apple.com [Tue, 4 Oct 2011 01:37:19 +0000 (01:37 +0000)]
JSC ASSERT Opening the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=69293

Reviewed by Oliver Hunt.

If a polymorphic access structure list has a duplicated structure, then
don't crash.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOn X86, switch bucketCount into a register, timeoutCheck into memory
barraclough@apple.com [Tue, 4 Oct 2011 01:16:46 +0000 (01:16 +0000)]
On X86, switch bucketCount into a register, timeoutCheck into memory
https://bugs.webkit.org/show_bug.cgi?id=69299

Reviewed by Geoff Garen.

We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.

* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):
    - Added branchSub32 with AbsoluteAddress.
* jit/JIT.cpp:
(JSC::JIT::emitTimeoutCheck):
    - Keep timeout count in memory on X86.
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
    - remove X86 specific code, switch bucket count back into a register.
* jit/JITStubs.cpp:
    - Stop initializing esi (it is no longer the timeoutCheck!)
* jit/JSInterfaceJIT.h:
    - change definition of esi to be the bucketCountRegister.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
    - Add timeoutCount as a property to global data (the counter should be per-thread).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG backends don't have access to per-node predictions from the propagator
fpizlo@apple.com [Tue, 4 Oct 2011 01:05:38 +0000 (01:05 +0000)]
DFG backends don't have access to per-node predictions from the propagator
https://bugs.webkit.org/show_bug.cgi?id=69291

Reviewed by Oliver Hunt.

Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.

This is performance neutral.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWork towards making PlatformWheelEvent immutable
andersca@apple.com [Tue, 4 Oct 2011 00:29:13 +0000 (00:29 +0000)]
Work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69306

Reviewed by Sam Weinig.

Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
the event has been handled or not. For all other event types, that state is instead
tracked by the return value of the various event handlers.

As a first step, add return values to the various handleWheelEvent functions and
add an assertion in EventHandler::wheelEvent that the return value is the same as
the state of PlatformWheelEvent::isAccepted.

* Configurations/Base.xcconfig:
Don't warn when using C++11 extensions.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
Assert that isAccepted matches the return value.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
Return isAccepted.

* platform/ScrollAnimator.h:
HandleWheelEvent now returns a boolean.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
Return whether the event was handled or not.

* platform/ScrollView.h:
ScrollView::wheelEvent now returns a bool.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
* platform/ScrollableArea.h:
ScrollableArea::handleWheelEvent now returns a bool.

* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
Add return values, based on either the base class calls or the state of
PlatformWheelEvent::isAccepted().

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Expose cc_emails and comments from bug.py
levin@chromium.org [Tue, 4 Oct 2011 00:23:56 +0000 (00:23 +0000)]
webkitpy: Expose cc_emails and comments from bug.py
https://bugs.webkit.org/show_bug.cgi?id=69308

Reviewed by Adam Barth.

* Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
to comments being exposed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a microbenchmark for a full-page render of the HTML5 spec
eric@webkit.org [Tue, 4 Oct 2011 00:13:01 +0000 (00:13 +0000)]
Add a microbenchmark for a full-page render of the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=69285

Reviewed by Adam Barth.

This was designed to be a test for https://bugs.webkit.org/show_bug.cgi?id=68944
But it seems that by far our dominating cost for the HTML5 benchmark is
time spent laying out lines (which isn't actually that surprising).

I'm adding the performance test for posterity.

* Parser/html-parser.html:
 - Removed use of "about:blank" which abarth says is a no-op.  Made comment more accurate.
* Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the...
mitz@apple.com [Tue, 4 Oct 2011 00:10:38 +0000 (00:10 +0000)]
<rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
https://bugs.webkit.org/show_bug.cgi?id=69305

Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/custom/boundingBox.html

Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
bounding rects.

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer): Ditto.
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
(WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
box.
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.
* rendering/svg/SVGRenderSupport.h:

LayoutTests:

* svg/custom/boundingBox-expected.txt: Added.
* svg/custom/boundingBox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Tweak WebCompositor API for input event handling to express three possible...
jamesr@google.com [Mon, 3 Oct 2011 23:54:26 +0000 (23:54 +0000)]
[chromium] Tweak WebCompositor API for input event handling to express three possible states
https://bugs.webkit.org/show_bug.cgi?id=69304

Reviewed by Darin Fisher.

* public/WebCompositorClient.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself to the watchlist for platform/graphics/chromium
commit-queue@webkit.org [Mon, 3 Oct 2011 23:22:54 +0000 (23:22 +0000)]
Add myself to the watchlist for platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=69297

Patch by James Robinson <jamesr@chromium.org> on 2011-10-03
Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContent area does not return to the correct position after rubberbanding
andersca@apple.com [Mon, 3 Oct 2011 23:11:29 +0000 (23:11 +0000)]
Content area does not return to the correct position after rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=69302
<rdar://problem/10102886>

Reviewed by Sam Weinig.

Make sure to schedule a display after adding to the dirty region.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoA little more WebSQLDatabase thread safety.
michaeln@google.com [Mon, 3 Oct 2011 23:07:35 +0000 (23:07 +0000)]
A little more WebSQLDatabase thread safety.
https://bugs.webkit.org/show_bug.cgi?id=69277

- switch to using AtomicallyInitializedStatic where appropiate
- avoid using some Strings across threads

Reviewed by David Levin.

Existing tests apply.

* storage/AbstractDatabase.cpp:
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
* storage/AbstractDatabase.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::tracker):
* storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::instance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by...
rniwa@webkit.org [Mon, 3 Oct 2011 23:05:39 +0000 (23:05 +0000)]
Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
https://bugs.webkit.org/show_bug.cgi?id=68874

Reviewed by Enrica Casucci.

Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.

* editing/CompositeEditCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
the text node referenced by destination. This is tested by an existing layout test.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
by the existing layout tests in editing/pasteboard.
(WebCore::ReplaceSelectionCommand::updateNodesInserted):
* editing/ReplaceSelectionCommand.h:
* editing/htmlediting.cpp:
(WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
(WebCore::highestNodeToRemoveInPruning): Ditto.
* editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r94274): cloned text input loses value
rniwa@webkit.org [Mon, 3 Oct 2011 23:02:51 +0000 (23:02 +0000)]
REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

* fast/forms/clone-input-with-dirty-value-expected.txt: Added.
* fast/forms/clone-input-with-dirty-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeopard build fix after r96530.
rniwa@webkit.org [Mon, 3 Oct 2011 22:51:20 +0000 (22:51 +0000)]
Leopard build fix after r96530.

* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working...
weinig@apple.com [Mon, 3 Oct 2011 22:35:34 +0000 (22:35 +0000)]
Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
https://bugs.webkit.org/show_bug.cgi?id=69294

Reviewed by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.

* dom/Document.h:
Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::setContentSecurityPolicy):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
Add ContentSecurityPolicy member and getter/setter.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::parseReportURI):
(WebCore::ContentSecurityPolicy::createCSPDirective):
* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):
Replace Document with ScriptExecutionContext. Add temporary checked casts to document
where necessary.

* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
Add initialization of the ContentSecurityPolicy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove custom scrollbar painting hooks
andersca@apple.com [Mon, 3 Oct 2011 22:31:24 +0000 (22:31 +0000)]
Remove custom scrollbar painting hooks
https://bugs.webkit.org/show_bug.cgi?id=69163

Source/WebCore:

Reviewed by Alexey Proskuryakov.

The custom scrollbar and scroll corner painting hooks aren't used by anyone
so go ahead and remove them. This removes the setter/getter and ChromeClient functions.

* page/Chrome.cpp:
* page/ChromeClient.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):

Source/WebKit/chromium:

Reviewed by Alexey Proskuryakov.

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):

Source/WebKit/win:

Reviewed by Alexey Proskuryakov.

Remove now unused WebPreferences and ChromeClient overrides.

* Interfaces/IWebPreferences.idl:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::unused3):
(WebPreferences::unused4):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Remove overridden ChromeClient member functions.

Reviewed by Alexey Proskuryakov.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
No need to enable custom scrollbar painting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results again now that Leopard has finally cycled.
abarth@webkit.org [Mon, 3 Oct 2011 22:25:38 +0000 (22:25 +0000)]
Update results again now that Leopard has finally cycled.

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename many obviously-correct call sites in WebCore using releaseRef to use it by...
darin@apple.com [Mon, 3 Oct 2011 22:15:44 +0000 (22:15 +0000)]
Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
https://bugs.webkit.org/show_bug.cgi?id=68672

Reviewed by Daniel Bates.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
* css/CSSStyleSelector.cpp:
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::styleForElement):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/haiku/RenderThemeHaiku.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::resolve):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::releaseConnectionForDownload):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
* platform/text/BidiContext.cpp:
(WebCore::BidiContext::create):
* platform/wx/RenderThemeWx.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeMac.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/style/RenderStyle.cpp:
(WebCore::defaultStyle):
Call leakRef instead of releaseRef. I did this only in the cases where
it was obvious to me this was the right way to do it. I'll keep revisiting
sites still calling it releaseRef until they are all gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoremove dead code in flipForWritingMode
ojan@chromium.org [Mon, 3 Oct 2011 22:00:25 +0000 (22:00 +0000)]
remove dead code in flipForWritingMode
https://bugs.webkit.org/show_bug.cgi?id=68948

Reviewed by Hajime Morita.

ChildToParentFlippingAdjustment is never used, so the third argument
to flipForWritingMode always has the same value.

In addition, renamed to flipForWritingModeForChild to be more clear
that it's operating on the child and renamed flipFloatForWritingMode to match.

No new tests. This is just a code cleanup. No functional changes.

* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::flipFloatForWritingModeForChild):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::flipForWritingModeForChild):
(WebCore::RenderBox::topLeftLocation):
* rendering/RenderBox.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96526.
jer.noble@apple.com [Mon, 3 Oct 2011 21:57:53 +0000 (21:57 +0000)]
Unreviewed, rolling out r96526.
http://trac.webkit.org/changeset/96526
https://bugs.webkit.org/show_bug.cgi?id=68587

WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results to account for Windows Vista.
abarth@webkit.org [Mon, 3 Oct 2011 21:55:23 +0000 (21:55 +0000)]
Update results to account for Windows Vista.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex...
joepeck@webkit.org [Mon, 3 Oct 2011 21:50:04 +0000 (21:50 +0000)]
<webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values

Reviewed by Pavel Feldman.

Source/WebCore:

Previously we assumed rgb values were always in byte form,
but they could include percentage values. Ex. rgb(100%,0,0).
This patch fixes this, and in the process includes clamping
for invalid percentages, byte values, and alpha values.

Test: inspector/styles/styles-invalid-color-values.html

* inspector/front-end/Color.js:
(WebInspector.Color.prototype._clamp):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._individualRGBValueToHexValue):
(WebInspector.Color.prototype._rgbToHex):
(WebInspector.Color.prototype._rgbToHSL):
An individual rgb value can be either a decimal/float or a
percentage. Rewrite the conversion functions to handle either
input. Regardless of the type of input, always return a clamped
decimal/float value between 0 and 255.

(WebInspector.Color.prototype._rgbaToHSLA):
(WebInspector.Color.prototype._hslaToRGBA):
(WebInspector.Color.prototype._parse):
Clamp the alpha value between 0 and 1.

LayoutTests:

This test outputs all of the supported color format representations
for supplied CSS color values. We expect some of the CSS values
to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
that rgb percentages, such as rgb(100%,0,0), work correctly.

* inspector/styles/styles-invalid-color-values-expected.txt: Added.
* inspector/styles/styles-invalid-color-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium-cg-mac results after http://trac.webkit.org/changeset/96530.
abarth@webkit.org [Mon, 3 Oct 2011 21:45:40 +0000 (21:45 +0000)]
Update chromium-cg-mac results after trac.webkit.org/changeset/96530.

* platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96542 268f45cc-cd09-0410-ab3c-d52691b4dbfc