japhet@chromium.org [Mon, 9 Nov 2009 18:48:22 +0000 (18:48 +0000)]
2009-11-09 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
Starting upstreaming the Chromium WebKit API. public/ contains header files only.
https://bugs.webkit.org/show_bug.cgi?id=28394
* ChangeLog: First!!
* public: Added.
* public/WebAccessibilityCache.h: Added.
(WebKit::WebAccessibilityCache::WebAccessibilityCache):
(WebKit::WebAccessibilityCache::~WebAccessibilityCache):
* public/WebAccessibilityObject.h: Added.
(WebKit::WebAccessibilityObject::~WebAccessibilityObject):
(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::operator=):
(WebKit::WebAccessibilityObject::isNull):
* public/WebAccessibilityRole.h: Added.
(WebKit::):
* public/WebApplicationCacheHost.h: Added.
(WebKit::WebApplicationCacheHost::):
(WebKit::WebApplicationCacheHost::~WebApplicationCacheHost):
* public/WebApplicationCacheHostClient.h: Added.
(WebKit::WebApplicationCacheHostClient::~WebApplicationCacheHostClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 18:23:17 +0000 (18:23 +0000)]
2009-11-09 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Darin Adler.
Thunk to the main thread from ~Database to deref Database's m_document.
If the Database was the Document's last referrer, then ~Document occurs on the
Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
ASSERT in debug builds.
* storage/Database.cpp:
(WebCore::derefDocument):
(WebCore::Database::~Database):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 17:54:30 +0000 (17:54 +0000)]
2009-11-09 Mark Mentovai <mark@chromium.org>
Reviewed by Dan Bernstein.
rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.
rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
* fast/overflow/scrollbar-restored-expected.txt: Added.
* fast/overflow/scrollbar-restored.html: Added.
2009-11-09 Mark Mentovai <mark@chromium.org>
Reviewed by Dan Bernstein.
Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.
rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.
rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
Test: fast/overflow/scrollbar-restored.html
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::setCanHaveScrollbars):
(WebCore::FrameView::updateCanHaveScrollbars):
(WebCore::FrameView::layout):
* page/FrameView.h:
* platform/ScrollView.h:
2009-11-09 Mark Mentovai <mark@chromium.org>
Reviewed by Dan Bernstein.
Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.
rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.
rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
Test: fast/overflow/scrollbar-restored.html
* WebView/WebFrameView.mm:
(-[WebFrameView _install]):
2009-11-09 Mark Mentovai <mark@chromium.org>
Reviewed by Dan Bernstein.
Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.
rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.
rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
Test: fast/overflow/scrollbar-restored.html
* Api/qwebframe.cpp:
(QWebFrame::setScrollBarPolicy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 17:44:56 +0000 (17:44 +0000)]
2009-11-09 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257
* inspector/syntax-highlight-css-expected.txt:
* inspector/syntax-highlight-css.html:
2009-11-09 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257
* inspector/front-end/SourceFrame.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 17:37:19 +0000 (17:37 +0000)]
2009-11-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
https://bugs.webkit.org/show_bug.cgi?id=31252
Route F1-F12 keypresses in the Console view to the current panel if there is one.
Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._promptKeyDown):
* inspector/front-end/utilities.js:
():
* manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 9 Nov 2009 17:26:26 +0000 (17:26 +0000)]
2009-11-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Pass credentials provided by XMLHTTPRequest to the network request.
https://bugs.webkit.org/show_bug.cgi?id=31208
After r42483, the credentials are no longer passed to the network request
in the URL of the request.
Pass the credentials from XMLHTTPRequest to the network request, the same
way that other ports do.
After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 9 Nov 2009 17:22:39 +0000 (17:22 +0000)]
2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=30772
Add a non-const iterator to QWebElementCollection.
Move the two attributes of the iterator to private.
* Api/qwebelement.h:
(const_iterator::begin):
(const_iterator::end):
(const_iterator::constBegin):
(const_iterator::constEnd):
(const_iterator::iterator::iterator):
(const_iterator::iterator::operator*):
(const_iterator::iterator::operator==):
(const_iterator::iterator::operator!=):
(const_iterator::iterator::operator<):
(const_iterator::iterator::operator<=):
(const_iterator::iterator::operator>):
(const_iterator::iterator::operator>=):
(const_iterator::iterator::operator++):
(const_iterator::iterator::operator--):
(const_iterator::iterator::operator+=):
(const_iterator::iterator::operator-=):
(const_iterator::iterator::operator+):
(const_iterator::iterator::operator-):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::nonConstIterator):
(tst_QWebElement::constIterator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 9 Nov 2009 16:12:43 +0000 (16:12 +0000)]
Adding Kenneth to the reviewers list.
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 9 Nov 2009 15:38:30 +0000 (15:38 +0000)]
2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Christiansen.
[Qt] Remove the sessionStorage setting (per Page)
https://bugs.webkit.org/show_bug.cgi?id=31249
This setting allows to run sessionStorage on/off on a per page
basis. Remove this prematurely exposed API.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::database):
(tst_QWebPage::testOptionalJSObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 9 Nov 2009 15:34:23 +0000 (15:34 +0000)]
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=31161
Roll back r50657 because it breaks the MAC builds.
* loader/ImageLoader.cpp:
* loader/ProgressTracker.cpp:
* loader/RedirectScheduler.cpp:
* loader/Request.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCacheHost.h:
* loader/appcache/ApplicationCacheStorage.h:
* loader/icon/IconDatabaseClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 9 Nov 2009 15:22:01 +0000 (15:22 +0000)]
Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161
Reviewed by Darin Adler.
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:
class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
ThreadableLoaderClient's inheriting has been changed to public.
* loader/ImageLoader.cpp:
* loader/ProgressTracker.cpp:
* loader/RedirectScheduler.cpp:
* loader/Request.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCacheHost.h:
* loader/appcache/ApplicationCacheStorage.h:
* loader/icon/IconDatabaseClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 9 Nov 2009 14:59:03 +0000 (14:59 +0000)]
[Qt] Remove the QWebPage:webInspectorTriggered signal.
User customization of the communication between QWebPage
and QWebInspector will be properly designed in the next version.
https://bugs.webkit.org/show_bug.cgi?id=30773
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-09
Reviewed by Simon Hausmann.
* Api/qwebinspector.cpp:
* Api/qwebpage.cpp:
(QWebPagePrivate::getOrCreateInspector):
(QWebPage::triggerAction):
* Api/qwebpage.h:
* QtLauncher/main.cpp:
(MainWindow::MainWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 9 Nov 2009 14:27:00 +0000 (14:27 +0000)]
Allow custom memory allocation control for WebCore's DocLoader
https://bugs.webkit.org/show_bug.cgi?id=31163
Reviewed by Darin Adler.
Inherits DocLoader class from Noncopyable because it is
instantiated by 'new' in WebCore/dom/Document.cpp:370 and
it is no need to be copyable.
* loader/DocLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 9 Nov 2009 14:22:01 +0000 (14:22 +0000)]
Allow custom memory allocation control for WebCore's Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=31162
Reviewed by Darin Adler.
Inherits Tokenizer class from Noncopyable because (its child class)
ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
and it is no need to be copyable.
* dom/Tokenizer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 9 Nov 2009 14:14:00 +0000 (14:14 +0000)]
Allow custom memory allocation control for WebCore's DeleteButtonController
https://bugs.webkit.org/show_bug.cgi?id=31105
Reviewed by Darin Adler.
Inherits DeleteButtonController class from Noncopyable because it is
instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
it is no need to be copyable.
* editing/DeleteButtonController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 13:10:37 +0000 (13:10 +0000)]
Added a missing re-implementation of QGraphicsItem::inputMethodQuery().
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::inputMethodQuery):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 13:09:39 +0000 (13:09 +0000)]
Provide a dummy re-implementation of QGraphicsLayoutItem::sizeHint(),
similar to QWebView.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::sizeHint):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 13:08:31 +0000 (13:08 +0000)]
Removed zoomFactoryChanged() signal and added
linkClicked() to QGraphicsWebView, for consistency with
QWebView.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
(QGraphicsWebView::setZoomFactor):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 13:07:46 +0000 (13:07 +0000)]
Added QGraphicsWebView::findText() for convenience and consistency
with QWebView.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::findText):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 13:06:42 +0000 (13:06 +0000)]
Added QGraphicsWebView::pageAction() and triggerPageAction(), for
consistency with QWebView.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::pageAction):
(QGraphicsWebView::triggerPageAction):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 12:35:40 +0000 (12:35 +0000)]
Removed QGraphicsWebView::toHtml() after API review.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
That's consistent with QWebView and also based on the assumption that
toHtml() is called less frequently than setHtml().
* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 12:31:27 +0000 (12:31 +0000)]
Removed the interactive property of QGraphicsWebView.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
There are clearly use-cases for this feature, but it will require
more work to make this fully work with an enum to have fine-grained
control over the interactivity levels. For now it is easy to achieve
in user-code what the boolean property did.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::hoverMoveEvent):
(QGraphicsWebView::mouseMoveEvent):
(QGraphicsWebView::mousePressEvent):
(QGraphicsWebView::mouseReleaseEvent):
(QGraphicsWebView::mouseDoubleClickEvent):
(QGraphicsWebView::keyPressEvent):
(QGraphicsWebView::keyReleaseEvent):
(QGraphicsWebView::dragLeaveEvent):
(QGraphicsWebView::dragMoveEvent):
(QGraphicsWebView::dropEvent):
(QGraphicsWebView::wheelEvent):
(QGraphicsWebView::inputMethodEvent):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 9 Nov 2009 12:29:24 +0000 (12:29 +0000)]
Make the QGraphicsWebView constructor explicit.
Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 9 Nov 2009 11:08:58 +0000 (11:08 +0000)]
Rubber-stamped by Holger Hans Peter Freyther.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-09
[Qt] Skip new japanese ruby annotation tests because of missing japanese font support.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 9 Nov 2009 10:12:01 +0000 (10:12 +0000)]
Unreviewed trivial fix.
Removed previously (r50589) deleted test case from skiplists.
* platform/gtk/Skipped: fast/events/drag-and-drop-none.html removed.
* platform/qt/Skipped: fast/events/drag-and-drop-none.html removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 09:16:35 +0000 (09:16 +0000)]
2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482
Unskip fast/events/keypress-insert-tab.html as it now passes.
* platform/gtk/Skipped:
2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482
Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebView.
No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
* platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
(WebCore::singleCharacterString):
2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482
Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebSettings.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482
LayoutTestControllerGtk now uses the exposed
Page::tabKeyCyclesThroughElements API
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 08:18:03 +0000 (08:18 +0000)]
2009-11-09 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Fix a crasher that occurred with text which included newline
chars in the markup.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(convertUniCharToUTF8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Mon, 9 Nov 2009 07:34:17 +0000 (07:34 +0000)]
The XML tokenizer reports a parse error twice if it occurs before the document element is found.
https://bugs.webkit.org/show_bug.cgi?id=31144
XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
documents that end prematurely but are not considered invalid by QXmlStream.
This is to stay compatible with the libxml2 implementation.
However, that code path would be also hit in situations when it should not,
i.e. the error would have already been caught and handled. As a result, the
same error would be reported twice.
No new tests, because the problem is already covered by
fast/parser/xml-declaration-missing-ending-mark.html.
Add the Qt-specific result for that test and unskip it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 06:39:32 +0000 (06:39 +0000)]
2009-11-08 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector should support copy() in the command line
https://bugs.webkit.org/show_bug.cgi?id=31238
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::copyText): Added.
* inspector/InspectorBackend.h: Added copyText
* inspector/InspectorBackend.idl: Added copyText
* inspector/front-end/InjectedScript.js:
(InjectedScript._copy): Added.
(InjectedScript._ensureCommandLineAPIInstalled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 06:00:02 +0000 (06:00 +0000)]
2009-11-08 Drew Wilson <atwilson@chromium.org>
Reviewed by Dimitri Glazkov.
V8 WorkerContextExecutionProxy does not handle SharedWorkers
https://bugs.webkit.org/show_bug.cgi?id=31226
Now checks to see what type of context is active and creates the
appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
Added support for converting to SharedWorkers and SharedWorkerContexts.
Test: Existing layout tests cover this case (start passing in Chrome).
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
Now generates the right type of DOMWrapper for SharedWorkerContexts.
(WebCore::WorkerContextExecutionProxy::convertToV8Object):
Added support for SHAREDWORKERCONTEXT.
(WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
Added support for SharedWorker and SharedWorkerContext.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 05:52:39 +0000 (05:52 +0000)]
2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
* fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
* fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
* fast/dom/StyleSheet/script-tests: Added.
* fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.
2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
Test: fast/dom/StyleSheet/get-stylesheet-byname.html
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 9 Nov 2009 04:52:19 +0000 (04:52 +0000)]
Made the full-screen video HUD appear when playback stops, such as when
the end of the video is reached.
Reviewed by Eric Carlson.
* WebView/WebVideoFullscreenHUDWindowController.h: Cleaned up.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Updated
for the renaming of -updateRate to -updatePlayButton.
(-[WebVideoFullscreenHUDWindowController updatePlayButton]): Renamed
-updateRate to this.
(-[WebVideoFullscreenHUDWindowController updateRate]): This method now
responds to changes to the playback rate by updating the play button
and showing or hiding the HUD as necessary.
(-[WebVideoFullscreenHUDWindowController togglePlaying:]): Now only
toggles playing. UI updates are driven by -updateRate being called.
(-[WebVideoFullscreenHUDWindowController playing]): Cleaned up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Nov 2009 04:46:33 +0000 (04:46 +0000)]
2009-11-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: "Search again" on scripts panel switches
to the script this search started with.
https://bugs.webkit.org/show_bug.cgi?id=31243
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.jumpToNextSearchResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 9 Nov 2009 02:43:51 +0000 (02:43 +0000)]
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime):
Reviewed by NOBODY (speculative snow leopard and windows build fixes).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 9 Nov 2009 02:33:04 +0000 (02:33 +0000)]
JavaScriptCore: Hopefully, the last build fix.
Reviewed by NOBODY (chromium build fix).
Create better separation in DateMath about the JSC
and non-JSC portions. Also, only expose the non-JSC
version in the exports.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getUTCOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::gmtoffset):
JavaScriptGlue: Added the use jsc define for files that use
this config file and DateMath.h. This should
be able to go away when DateMath is properly
split into wtf and jsc portions which is this bug:
https://bugs.webkit.org/show_bug.cgi?id=31246
Reviewed by NOBODY (chromium build fix).
* config.h:
WebCore: * platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Changed this to not
use a date parser that needs ExecState passed.
Reviewed by NOBODY (chromium build fix).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Nov 2009 01:28:20 +0000 (01:28 +0000)]
2009-11-08 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Simplify Icon interface.
https://bugs.webkit.org/show_bug.cgi?id=31154
- Remove Icon::createIconForFile(). createIconForFiles() covers
createIconForFile()'s role.
- Remove FileChooser::chooseIcon()
- Change the parameter types of FileChooser constructor and the
factory method, String -> const Vector<String>&, in order to
support initialization with multiple files.
- Remove the icon loading code in IconChromiumWin.cpp, which
doesn't work because of the sandbox.
No tests because it's just a refactoring.
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::create):
(WebCore::FileChooser::chooseFile):
(WebCore::FileChooser::chooseFiles):
* platform/FileChooser.h:
* platform/graphics/Icon.h:
* platform/graphics/chromium/IconChromiumLinux.cpp:
* platform/graphics/chromium/IconChromiumMac.cpp:
* platform/graphics/chromium/IconChromiumWin.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/gtk/IconGtk.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/haiku/IconHaiku.cpp:
* platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForFiles):
* platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/wx/IconWx.cpp:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 9 Nov 2009 01:18:08 +0000 (01:18 +0000)]
2009-11-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=31098
Allows same-origin plugin-based content to load.
Test: http/tests/security/xssAuditor/object-src-inject.html
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
(WebCore::XSSAuditor::canLoadObject): Ditto.
(WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
(WebCore::XSSAuditor::isSameOriginResource): Added.
* page/XSSAuditor.h:
2009-11-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=31098
Tests that the XSSAuditor prevents loading plugin-based content that is not
from the same-origin as the enclosing page.
* http/tests/security/xssAuditor/object-src-inject-expected.txt: Added.
* http/tests/security/xssAuditor/object-src-inject.html: Added.
* http/tests/security/xssAuditor/resources/echo-object-src.pl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 8 Nov 2009 23:54:41 +0000 (23:54 +0000)]
Unreviewed build fix for chromium.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 8 Nov 2009 23:42:20 +0000 (23:42 +0000)]
Unreviewed build fix for chromium.
Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
Clean up GraphicsContext's current concept of ColorSpace
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 8 Nov 2009 21:02:20 +0000 (21:02 +0000)]
For the change in DateMath.
Reviewed by NOBODY (chromium build fix).
* config.h:
* wtf/DateMath.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sun, 8 Nov 2009 19:47:22 +0000 (19:47 +0000)]
2009-11-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] committing style edit
clears elements panel selection.
https://bugs.webkit.org/show_bug.cgi?id=31242
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.update):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 8 Nov 2009 19:09:41 +0000 (19:09 +0000)]
2009-11-08 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
Update texts in test description after test case change in r50579.
https://bugs.webkit.org/show_bug.cgi?id=31122
* editing/selection/shrink-selection-after-shift-pagedown-expected.txt:
* editing/selection/shrink-selection-after-shift-pagedown.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 8 Nov 2009 19:01:51 +0000 (19:01 +0000)]
2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Holger Freyther.
ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670
Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed all forward declarations of ResourceRequest to have class in the forward
declaration instead of struct and changed the definition of ResourceRequest to be class
and added access qualifiers where missing. Additionally two references of friend
struct ResourceRequestBase changed to class instead.
* history/HistoryItem.h:
* inspector/InspectorController.h:
* inspector/InspectorResource.h:
* loader/DocumentThreadableLoader.h:
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.h:
* loader/ResourceLoadNotifier.h:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
* loader/ThreadableLoader.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCache.h:
* loader/appcache/ApplicationCacheHost.h:
* platform/CrossThreadCopier.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceRequestBase.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.h:
* platform/network/chromium/ResourceRequest.h:
* platform/network/curl/ResourceRequest.h:
* platform/network/qt/ResourceRequest.h:
* platform/network/soup/ResourceRequest.h:
* xml/XMLHttpRequest.h:
2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Holger Freyther.
ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670
Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed forward declaration of ResourceRequest to have class in the forward
declaration instead of struct.
* WebDownload.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 8 Nov 2009 18:51:22 +0000 (18:51 +0000)]
2009-11-08 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
[Qt] Added support for key code 8 (backspace) in EventSenderQt.
This helps to pass the test case below. Also replaced hardcoded
code numbers with defined constants.
https://bugs.webkit.org/show_bug.cgi?id=31185
Test: editing/undo/undo-deleteWord.html
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::keyDown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 8 Nov 2009 17:32:07 +0000 (17:32 +0000)]
<rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
below FrameView::layout
https://bugs.webkit.org/show_bug.cgi?id=31093
Reviewed by Simon Fraser.
WebCore:
Test: fast/block/positioning/relative-positioned-inline-container.html
In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
to mark the object for layout, doing so without marking its ancestors.
However, RenderBlock::skipLeadingWhitespace and
RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
positioned inline container, causing it to be marked for layout without
ever going back to give it layout, and thus layout could end with a
dirty object still in the tree, leading to all sorts of badness.
The fix is to revert setStaticY() to not marking the object dirty, and
instead do it in the call sites that require it, which are in
RenderBlock and RenderFlexibleBox.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
(WebCore::RenderLayer::setStaticY):
LayoutTests:
* fast/block/positioning/relative-positioned-inline-container-expected.checksum: Added.
* fast/block/positioning/relative-positioned-inline-container-expected.png: Added.
* fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
* fast/block/positioning/relative-positioned-inline-container.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Sun, 8 Nov 2009 17:26:01 +0000 (17:26 +0000)]
[Qt] [DRT] Fix wrong logic in LayoutTestController processWork
https://bugs.webkit.org/show_bug.cgi?id=31164
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-05
Reviewed by Holger Freyther.
Fixed wrong logic to assume WorkQueue is done in QT's DRT.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::processWork):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Sun, 8 Nov 2009 17:25:31 +0000 (17:25 +0000)]
[Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
https://bugs.webkit.org/show_bug.cgi?id=31158
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-07
Reviewed by Holger Freyther.
By invoking a script queue'd by queueScript(), 'true' was beeing returned
always, which from WorkQueue prospective means that a load has been started
and the queue processing should stop and wait for the load to finish.
Spinning it off into a loading and a non-loading variants was the solution
adopted by Mac's DRT to work around this problem. The former keeps returning
'true' while the later executes the script synchronously and returns 'false'
making it possible to the WorkQueue to proceed right away.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::processWork):
(LayoutTestController::queueLoadingScript):
(LayoutTestController::queueNonLoadingScript):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/WorkQueueItem.h:
(LoadingScriptItem::LoadingScriptItem):
(LoadingScriptItem::invoke):
(NonLoadingScriptItem::NonLoadingScriptItem):
(NonLoadingScriptItem::invoke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 8 Nov 2009 03:59:33 +0000 (03:59 +0000)]
Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
Rubber-stamped by Cameron Zwarich.
* Scripts/commit-log-editor:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 8 Nov 2009 03:59:28 +0000 (03:59 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
commit-log-editor does not support all the email address configurations that prepare-Changelog supports
Reviewed by Darin Adler.
Move logic for determining the name and email address to use in a ChangeLog entry from
prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check
whether the author of the patch matches committer, and therefore needs access to the
email address that would be used in a ChangeLog entry.
Based on a patch by Pierre d'Herbemont.
* Scripts/VCSUtils.pm:
* Scripts/commit-log-editor:
* Scripts/prepare-ChangeLog:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 8 Nov 2009 02:31:48 +0000 (02:31 +0000)]
2009-11-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20780
Fixes an issue where the onchange event handler is not fired when the
input field is autocompleted.
We cannot test this using DRT since DRT cannot emulate autocompletion.
So, a manual-test is included.
Tests: manual-tests/autocompletion-fire-onchange.html
* manual-tests/autocompletion-fire-onchange.html: Added.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setInnerTextValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 7 Nov 2009 22:40:22 +0000 (22:40 +0000)]
2009-11-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Add in missing expectations.
* platform/mac/fast/forms/input-list-button-size-expected.checksum: Added.
* platform/mac/fast/forms/input-list-button-size-expected.png: Added.
* platform/mac/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
* platform/mac/fast/text/text-letter-spacing-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 7 Nov 2009 20:06:30 +0000 (20:06 +0000)]
2009-11-07 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
Mark redrawn areas on image surfaces as dirty.
This is required to conform to the Cairo API, but is currently only
used by debugging tools like cairo-trace.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::putImageData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 7 Nov 2009 09:03:23 +0000 (09:03 +0000)]
2009-11-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30878
[Gtk] atk_text_get_text() fails in entries when the end_offset is -1
If the end_offset is -1, use the String length as the end_offset.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_text):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 7 Nov 2009 08:00:12 +0000 (08:00 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
GraphicsContext's current concept of ColorSpace
Reviewed by Adele Peterson.
ColorSpace is now called ColorType. The variables on the state we
appropriately re-named as well. I removed strokeColorSpace() and
fillColorSpace() from GraphicsContext since they were never called.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
* platform/graphics/GraphicsContext.h:
(WebCore::):
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::calculateDrawingMode):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 7 Nov 2009 02:02:42 +0000 (02:02 +0000)]
Fixes <http://webkit.org/b/31177>.
Web Inspector: Bind backspace to delete cookies and DOM Storage.
Reviewed by Tim Hatcher.
Refactor editing code from DOMStorageDataGrid to DataGrid, so other
places in the inspector can use editing in DataGrid (added a FIXME for
some stuff that needs to be generalized).
Also added deleting functionality to DataGrid, and implemented it for
Cookies and DOM Storage. The reason this patch is so big is because of
the refactoring of editing code, which won't be used yet in a cross-datagrid
way, but should be able to.
Additionally, moved the callbacks members from DOMStorageDataGrid to
DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
make the architecture of DOM Storage look a lot more like the Cookies view.
Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
inspector from beeping at you when you delete an element.
* WebCore.gypi: Removed DOMStorageDataGrid.
* WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype.dataGridForCookies):
(WebInspector.CookieItemsView.prototype._deleteButtonClicked):
(WebInspector.CookieItemsView.prototype._deleteCookieCallback):
* inspector/front-end/DOMStorageDataGrid.js: Removed.
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._editingCancelled): Ditto.
(WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
* inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
* inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 7 Nov 2009 00:05:13 +0000 (00:05 +0000)]
Windows build fix: export some symbols.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 23:59:29 +0000 (23:59 +0000)]
Qt build fix: added an ExecState parameter.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 23:54:01 +0000 (23:54 +0000)]
Build fix: updated export file.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 23:48:38 +0000 (23:48 +0000)]
Build fix: added some #includes.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
* wtf/CurrentTime.h:
* wtf/DateMath.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 23:33:17 +0000 (23:33 +0000)]
Rolled back in r50590 with Windows build hopefully fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 23:00:44 +0000 (23:00 +0000)]
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
Added layout tests to test document.open and window.open calls issued
by NPAPI plugins without a calling javascript context. The associated
webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067, which
affects Chromium.
* plugins/document-open-expected.txt: Added.
* plugins/document-open.html: Added.
* plugins/window-open-expected.txt: Added.
* plugins/window-open.html: Added.
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
which affects Chromium only.
Changes to V8HTMLDocumentCustom.cpp are as below:-
1. The HTMLDocumentOpen function would cause a crash in Chromium if
there was no calling javascript context. We now check for this case
and pass in NULL to the HTMLDocument::open function which can handle
a NULL document parameter.
2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
had ASSERTS for a NULL caller frame, which was bogus as it would crash
anyway. We now check for this case and return a failure.
Changes to V8DOMWindowCustom.cpp are as below:-
1. Instead of failing the window.open call made by NPAPI for lack of a
calling javascript context, we now use the entered context as the calling
context.
Tests: plugins/document-open.html
plugins/window-open.html
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
Added functionality to the layout test plugin to invoke document.open and
window.open with default arguments. The associated webkit bug is
https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
work in Chromium (V8) if there is no calling javascript context. To achieve this
effect we invoke these functions in the layout test plugin in the NPP_SetWindow
for the window.open test case and in NPP_DestroyStream for the document.open test case.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testDocumentOpen):
(testWindowOpen):
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetWindow):
(NPP_DestroyStream):
* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 6 Nov 2009 22:58:05 +0000 (22:58 +0000)]
2009-11-06 Dirk Schulze <krit@webkit.org>
Rubber stamped by Eric Seidel.
Update SVG status page. We support feMorphology now.
Set lightning filters to unimplemented.
* projects/svg/status.xml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 21:36:31 +0000 (21:36 +0000)]
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184
Update test case of the value of the PositionError.UNKNOWN_ERROR constant in error.html.
Also remove redundant test cases of the value of all PositionError constants.
* fast/dom/Geolocation/resources/error.js: Modified. Update test of value of PositionError.UNKNOWN_ERROR constant.
* fast/dom/Geolocation/error-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/permission-denied-already-error.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/permission-denied-already-error-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/permission-denied-already-success.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/permission-denied-already-success-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/permission-denied.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/reentrant-error.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/timeout-zero.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Expected result for above test.
* fast/dom/Geolocation/resources/watch.js: Modified. Remove tests of the value of PositionError constants.
* fast/dom/Geolocation/watch-expected.txt: Modified. Expected result for above test.
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184
Remove this error code from PositionError, both for use from C++ code and from the JS object.
Updated fast/dom/Geolocation/error.html to test this.
* page/PositionError.h: Modified.
(WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
* page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
* platform/gtk/GeolocationServiceGtk.cpp: Modified.
(WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 6 Nov 2009 21:08:10 +0000 (21:08 +0000)]
2009-11-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMorphology filter is not implemented
[https://bugs.webkit.org/show_bug.cgi?id=5863]
The Implementation of feMorphology.
Test: We have allready a test for feMorphology
svg/W3C-SVG-1.1/filters-morph-01-f.svg
* svg/graphics/filters/SVGFEMorphology.cpp:
(WebCore::FEMorphology::apply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 20:01:14 +0000 (20:01 +0000)]
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
https://bugs.webkit.org/show_bug.cgi?id=31209
Build fix only. No new tests possible.
* bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 19:53:16 +0000 (19:53 +0000)]
2009-11-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool crashed with exception
https://bugs.webkit.org/show_bug.cgi?id=31092
* Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 18:32:17 +0000 (18:32 +0000)]
2009-11-06 Jeff Schiller <codedread@gmail.com>
Reviewed by Darin Adler.
SVG Status page update
https://bugs.webkit.org/show_bug.cgi?id=31179
* projects/svg/status.xml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 16:18:42 +0000 (16:18 +0000)]
2009-11-06 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
V8 bindings do not support SharedWorkers as event targets
https://bugs.webkit.org/show_bug.cgi?id=31199
No new tests because existing layout tests suffice (they currently
crash on Chromium)
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
Added clause to create a DOM wrapper for SharedWorkers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Fri, 6 Nov 2009 15:19:09 +0000 (15:19 +0000)]
Unreviewed trivial buildfix after r50595.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-06
Rename the remaining rshiftPtr calls to rshift32
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_rshift):
* jit/JITInlineMethods.h:
(JSC::JIT::emitFastArithImmToInt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 13:49:06 +0000 (13:49 +0000)]
2009-11-06 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not unnecessarly synchronzie in weak reference callbacks.
https://bugs.webkit.org/show_bug.cgi?id=31191
* bindings/v8/DOMData.h:
(WebCore::DOMData::handleWeakObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 13:41:34 +0000 (13:41 +0000)]
2009-11-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix resource content search.
https://bugs.webkit.org/show_bug.cgi?id=31202
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype.refresh):
(WebInspector.AbstractTimelinePanel.prototype.removeItem):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineGraph.prototype.refresh):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 6 Nov 2009 09:35:15 +0000 (09:35 +0000)]
2009-11-04 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
css2.1/t040304-c64-uri-00-a-g.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23271
This test isn't failing now because this test was fixed in
http://trac.webkit.org/changeset/47884
* platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.checksum:
* platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 6 Nov 2009 09:35:03 +0000 (09:35 +0000)]
Tidy up the shift methods on the macro-assembler interface.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-06
Reviewed by Oliver Hunt.
Currently behaviour of shifts of a magnitude > 0x1f is undefined.
Instead defined that all shifts are masked to this range. This makes a lot of
practical sense, both since having undefined behaviour is not particularly
desirable, and because this behaviour is commonly required (particularly since
it is required bt ECMA-262 for shifts).
Update the ARM assemblers to provide this behaviour. Remove (now) redundant
masks from JITArithmetic, and remove rshiftPtr (this was used in case that
could be rewritten in a simpler form using rshift32, only optimized JSVALUE32
on x86-64, which uses JSVALUE64!)
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::rshift32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::lshift32):
(JSC::MacroAssemblerARMv7::rshift32):
* assembler/MacroAssemblerX86_64.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 6 Nov 2009 08:47:47 +0000 (08:47 +0000)]
Rubber Stamped by Oliver Hunt.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-05
Remove a magic number (1) from the JIT, instead compute the value with OBJECT_OFFSET.
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::getArgument):
* jit/JITStubs.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 6 Nov 2009 07:28:56 +0000 (07:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31159
Fix branchDouble behaviour on ARM THUMB2 JIT.
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.
The x86 branchDouble behaviour is reworked, and all JIT
ports should follow the x86 port. See bug 31104 and 31151
This patch contains a fix for the traditional ARM port
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fmrs_r):
(JSC::ARMAssembler::ftosid_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 07:26:15 +0000 (07:26 +0000)]
2009-11-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Fix ASSERT(currentStyle = renderStyle()).
https://bugs.webkit.org/show_bug.cgi?id=31152
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 06:52:10 +0000 (06:52 +0000)]
Rolled out r50590 because it doesn't build on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Nov 2009 06:26:47 +0000 (06:26 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Reviewed by Oliver Hunt.
If the VM calculates the local timezone offset from UTC, it caches the
result until the end of the current VM invocation. (We don't want to cache
forever, because the user's timezone may change over time.)
This removes notify_* overhead on Mac, and, more significantly, removes
OS time and date call overhead on non-Mac platforms.
~8% speedup on Date microbenchmark on Mac. SunSpider reports maybe a tiny
speedup on Mac. (Speedup on non-Mac platforms should be even more noticeable.)
* JavaScriptCore.exp:
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Made the
DynamicGlobalObjectScope constructor responsible for checking whether a
dynamicGlobalObject has already been set. This eliminated some duplicate
client code, and allowed me to avoid adding even more duplicate client
code. Made DynamicGlobalObjectScope responsible for resetting the
local timezone cache upon first entry to the VM.
* runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::callDate):
(JSC::dateParse):
(JSC::dateUTC):
* runtime/DateConversion.cpp:
(JSC::parseDate):
* runtime/DateConversion.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
* runtime/DateInstance.h:
* runtime/DateInstanceCache.h:
* runtime/DatePrototype.cpp:
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/DateMath.cpp:
(WTF::getCurrentUTCTime):
(WTF::getCurrentUTCTimeWithMicroseconds):
(WTF::getLocalTime):
(JSC::getUTCOffset): Use the new cache. Also, see below.
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::initializeDates):
(JSC::parseDateFromNullTerminatedCharacters): Simplified the way this function
accounts for the local timezone offset, to accomodate our new caching API,
and a (possibly misguided) caller in WebCore. Also, see below.
* wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime): Moved most of the code in
DateMath.* into the JSC namespace. The code needed to move so it could
naturally interact with ExecState and JSGlobalData to support caching.
Logically, it seemed right to move it, too, since this code is not really
as low-level as the WTF namespace might imply -- it implements a set of
date parsing and conversion quirks that are finely tuned to the JavaScript
language. Also removed the Mac OS X notify_* infrastructure.
WebCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Updated for JavaScriptCore internal API change.
* platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
(This function probably shouldn't be using a JavaScript date parser
to begin with, but oh well.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Fri, 6 Nov 2009 06:25:44 +0000 (06:25 +0000)]
2009-11-05 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31193
Removed obsolete test case which was included in the patch for bug #30107.
This test case is already covered by the test case fast/events/drag-and-drop.html,
which was included in the patch for bug #24731.
* fast/events/drag-and-drop-none-expected.txt: Removed.
* fast/events/drag-and-drop-none.html: Removed.
* platform/win/Skipped: Removed entry for drag-and-drop-none.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Fri, 6 Nov 2009 06:19:28 +0000 (06:19 +0000)]
Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcEpilogue):
* bindings/v8/V8GCController.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 6 Nov 2009 06:05:31 +0000 (06:05 +0000)]
2009-11-05 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527
Test that a script cannot read cross-origin cssRules.
* http/tests/security/cannot-read-cssrules-expected.txt: Added.
* http/tests/security/cannot-read-cssrules-redirect-expected.txt: Added.
* http/tests/security/cannot-read-cssrules-redirect.html: Added.
* http/tests/security/cannot-read-cssrules.html: Added.
2009-11-05 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527
Check whether whether the current document can read the cssRules from
the style sheet. Firefox throws a security error here, but we return
null instead because that's what we usually do in these cases.
Test: http/tests/security/cannot-read-cssrules-redirect.html
http/tests/security/cannot-read-cssrules.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Fri, 6 Nov 2009 03:27:43 +0000 (03:27 +0000)]
Rubber stamped by Mark Rowe.
Adds some GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=31194
*.vcproj
*.rules
*.mk
*.scons
SConstruct
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 6 Nov 2009 02:46:05 +0000 (02:46 +0000)]
2009-11-05 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
If the Geolocation service fails to start, invoke the error callback asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=28276
All Geolocation callbacks must be invoked asynchronously.
See http://www.w3.org/TR/geolocation-API/#geolocation_interface
No new tests possible with current LayoutTestController.
* page/Geolocation.cpp:
(WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
(WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
(WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 6 Nov 2009 00:05:11 +0000 (00:05 +0000)]
Adding a resource that seems to be missing. Without it, several tests in
fast/dom/beforeload aren't really testing if the default event handling is
prevented, but instead are only testing if the beforeload event fires.
Rubber-stamped by Gavin Barraclough.
* fast/dom/beforeload/resources/fail.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 23:53:45 +0000 (23:53 +0000)]
2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.
https://bugs.webkit.org/show_bug.cgi?id=31167
The maintenance and architecture page in the project wiki lists
this as a task.
This change includes no changes or additions to test cases
since the change affects only comments.
* wtf/wince/FastMallocWince.h:
2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.
https://bugs.webkit.org/show_bug.cgi?id=31167
The maintenance and architecture page in the project wiki lists
this as a task.
This change includes no changes or additions to test cases
since the change affects only comments.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/IDLParser.pm:
* bindings/scripts/IDLStructure.pm:
* css/CSSInheritedValue.cpp:
* css/CSSInitialValue.cpp:
* css/CSSMediaRule.cpp:
* css/CSSNamespace.h:
* css/CSSProperty.cpp:
* css/CSSProperty.h:
* css/CSSRuleList.cpp:
* css/CSSRuleList.h:
* css/CSSSelector.h:
* css/CSSValueList.cpp:
* css/FontValue.cpp:
* css/MediaFeatureNames.cpp:
* css/MediaFeatureNames.h:
* css/Pair.h:
* css/SVGCSSStyleSelector.cpp:
* css/ShadowValue.cpp:
* css/StyleSheet.cpp:
* css/StyleSheetList.cpp:
* css/maketokenizer:
* dom/BeforeUnloadEvent.cpp:
* dom/BeforeUnloadEvent.h:
* dom/CSSMappedAttributeDeclaration.cpp:
* dom/EventNames.cpp:
* dom/EventTarget.cpp:
* dom/MappedAttributeEntry.h:
* dom/MouseRelatedEvent.h:
* dom/RangeException.h:
* dom/StyleElement.h:
* dom/Tokenizer.h:
* html/HTMLHeadElement.h:
* html/HTMLHeadingElement.cpp:
* html/HTMLHeadingElement.h:
* html/HTMLHtmlElement.h:
* html/HTMLImageLoader.h:
* html/HTMLMetaElement.h:
* html/HTMLModElement.cpp:
* html/HTMLModElement.h:
* html/HTMLOptionsCollection.cpp:
* html/HTMLPlugInElement.cpp:
* html/HTMLPreElement.cpp:
* html/HTMLPreElement.h:
* html/HTMLTableCellElement.cpp:
* html/HTMLTableCellElement.h:
* html/HTMLTableColElement.cpp:
* html/HTMLTableColElement.h:
* html/HTMLTablePartElement.cpp:
* html/HTMLTablePartElement.h:
* html/HTMLTitleElement.h:
* page/MouseEventWithHitTestResults.h:
* platform/StaticConstructors.h:
* platform/text/AtomicStringImpl.h:
* platform/text/qt/TextBreakIteratorQt.cpp:
* rendering/AutoTableLayout.h:
* rendering/CounterNode.cpp:
* rendering/EllipsisBox.cpp:
* rendering/EllipsisBox.h:
* rendering/FixedTableLayout.cpp:
* rendering/FixedTableLayout.h:
* rendering/HitTestRequest.h:
* rendering/HitTestResult.h:
* rendering/InlineRunBox.h:
* rendering/PointerEventsHitRules.cpp:
* rendering/PointerEventsHitRules.h:
* rendering/RenderBR.cpp:
* rendering/RenderBR.h:
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
* rendering/RenderFieldset.cpp:
* rendering/RenderFrameSet.cpp:
* rendering/RenderListItem.cpp:
* rendering/RenderTableRow.cpp:
* rendering/RenderView.h:
* rendering/RootInlineBox.h:
* rendering/SVGInlineTextBox.cpp:
* rendering/SVGInlineTextBox.h:
* rendering/TableLayout.h:
* rendering/break_lines.h:
* rendering/style/SVGRenderStyle.cpp:
* rendering/style/SVGRenderStyle.h:
* rendering/style/SVGRenderStyleDefs.cpp:
* rendering/style/SVGRenderStyleDefs.h:
* svg/GradientAttributes.h:
* svg/LinearGradientAttributes.h:
* svg/PatternAttributes.h:
* svg/RadialGradientAttributes.h:
* svg/SVGAElement.cpp:
* svg/SVGAngle.idl:
* svg/SVGAnimateColorElement.cpp:
* svg/SVGAnimateColorElement.h:
* svg/SVGAnimateElement.cpp:
* svg/SVGAnimateElement.h:
* svg/SVGAnimateTransformElement.h:
* svg/SVGAnimatedPathData.cpp:
* svg/SVGAnimatedPathData.h:
* svg/SVGAnimatedPoints.cpp:
* svg/SVGAnimatedPoints.h:
* svg/SVGAnimationElement.cpp:
* svg/SVGCircleElement.cpp:
* svg/SVGClipPathElement.cpp:
* svg/SVGColor.cpp:
* svg/SVGColor.idl:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGCursorElement.cpp:
* svg/SVGDefsElement.cpp:
* svg/SVGDescElement.cpp:
* svg/SVGDescElement.h:
* svg/SVGDocument.idl:
* svg/SVGElement.idl:
* svg/SVGElementInstanceList.cpp:
* svg/SVGElementInstanceList.h:
* svg/SVGEllipseElement.cpp:
* svg/SVGExternalResourcesRequired.cpp:
* svg/SVGFEBlendElement.cpp:
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFECompositeElement.h:
* svg/SVGFEFloodElement.cpp:
* svg/SVGFEFloodElement.h:
* svg/SVGFEFuncAElement.cpp:
* svg/SVGFEFuncAElement.h:
* svg/SVGFEFuncBElement.cpp:
* svg/SVGFEFuncBElement.h:
* svg/SVGFEFuncGElement.cpp:
* svg/SVGFEFuncGElement.h:
* svg/SVGFEFuncRElement.cpp:
* svg/SVGFEFuncRElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
* svg/SVGFEMergeElement.cpp:
* svg/SVGFEMergeElement.h:
* svg/SVGFEMergeNodeElement.cpp:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFEOffsetElement.h:
* svg/SVGFETileElement.cpp:
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterElement.cpp:
* svg/SVGGElement.cpp:
* svg/SVGGradientElement.cpp:
* svg/SVGHKernElement.idl:
* svg/SVGLangSpace.cpp:
* svg/SVGLangSpace.h:
* svg/SVGLength.cpp:
* svg/SVGLength.h:
* svg/SVGLength.idl:
* svg/SVGLengthList.cpp:
* svg/SVGLengthList.h:
* svg/SVGLineElement.cpp:
* svg/SVGLinearGradientElement.h:
* svg/SVGList.h:
* svg/SVGListTraits.h:
* svg/SVGLocatable.h:
* svg/SVGMaskElement.cpp:
* svg/SVGMatrix.idl:
* svg/SVGMetadataElement.cpp:
* svg/SVGMetadataElement.h:
* svg/SVGMetadataElement.idl:
* svg/SVGNumber.idl:
* svg/SVGNumberList.cpp:
* svg/SVGNumberList.h:
* svg/SVGPaint.cpp:
* svg/SVGPathElement.cpp:
* svg/SVGPathSeg.h:
* svg/SVGPathSegArc.cpp:
* svg/SVGPathSegArc.h:
* svg/SVGPathSegClosePath.cpp:
* svg/SVGPathSegClosePath.h:
* svg/SVGPathSegCurvetoCubic.cpp:
* svg/SVGPathSegCurvetoCubic.h:
* svg/SVGPathSegCurvetoCubicSmooth.cpp:
* svg/SVGPathSegCurvetoCubicSmooth.h:
* svg/SVGPathSegCurvetoQuadratic.cpp:
* svg/SVGPathSegCurvetoQuadratic.h:
* svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
* svg/SVGPathSegCurvetoQuadraticSmooth.h:
* svg/SVGPathSegLineto.cpp:
* svg/SVGPathSegLineto.h:
* svg/SVGPathSegLinetoHorizontal.cpp:
* svg/SVGPathSegLinetoHorizontal.h:
* svg/SVGPathSegLinetoVertical.cpp:
* svg/SVGPathSegLinetoVertical.h:
* svg/SVGPathSegMoveto.cpp:
* svg/SVGPathSegMoveto.h:
* svg/SVGPatternElement.cpp:
* svg/SVGPoint.idl:
* svg/SVGPointList.cpp:
* svg/SVGPointList.h:
* svg/SVGPolyElement.cpp:
* svg/SVGPolygonElement.cpp:
* svg/SVGPolygonElement.h:
* svg/SVGPolylineElement.cpp:
* svg/SVGPolylineElement.h:
* svg/SVGPreserveAspectRatio.cpp:
* svg/SVGPreserveAspectRatio.h:
* svg/SVGRadialGradientElement.h:
* svg/SVGRect.idl:
* svg/SVGRectElement.cpp:
* svg/SVGRenderingIntent.h:
* svg/SVGSVGElement.idl:
* svg/SVGScriptElement.cpp:
* svg/SVGSetElement.cpp:
* svg/SVGSetElement.h:
* svg/SVGStopElement.cpp:
* svg/SVGStringList.cpp:
* svg/SVGStringList.h:
* svg/SVGStylable.cpp:
* svg/SVGStylable.h:
* svg/SVGStyleElement.cpp:
* svg/SVGStyleElement.h:
* svg/SVGStyledElement.h:
* svg/SVGStyledLocatableElement.cpp:
* svg/SVGStyledLocatableElement.h:
* svg/SVGStyledTransformableElement.cpp:
* svg/SVGStyledTransformableElement.h:
* svg/SVGSwitchElement.cpp:
* svg/SVGSymbolElement.cpp:
* svg/SVGTRefElement.cpp:
* svg/SVGTSpanElement.cpp:
* svg/SVGTSpanElement.h:
* svg/SVGTests.h:
* svg/SVGTextElement.cpp:
* svg/SVGTextElement.h:
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPositioningElement.cpp:
* svg/SVGTextPositioningElement.h:
* svg/SVGTitleElement.cpp:
* svg/SVGTitleElement.h:
* svg/SVGTransform.cpp:
* svg/SVGTransform.h:
* svg/SVGTransform.idl:
* svg/SVGTransformList.cpp:
* svg/SVGTransformList.h:
* svg/SVGTransformable.h:
* svg/SVGURIReference.h:
* svg/SVGUnitTypes.h:
* svg/SVGUseElement.cpp:
* svg/SVGViewElement.cpp:
* svg/SVGZoomAndPan.cpp:
* svg/SVGZoomAndPan.h:
* svg/SVGZoomEvent.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 5 Nov 2009 23:28:42 +0000 (23:28 +0000)]
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: beautify layout tests.
https://bugs.webkit.org/show_bug.cgi?id=31189
* inspector/console-dir-expected.txt:
* inspector/console-dir.html:
* inspector/console-dirxml-expected.txt:
* inspector/console-dirxml.html:
* inspector/console-format-collections-expected.txt:
* inspector/console-format-collections.html:
* inspector/console-format-expected.txt:
* inspector/console-format.html:
* inspector/console-tests-expected.txt:
* inspector/console-tests.html:
* inspector/console-tests.js: Added.
(dumpConsoleMessages.callback):
(dumpConsoleMessages):
(dumpConsoleMessagesWithClasses.callback):
(dumpConsoleMessagesWithClasses):
(frontendScript_dumpConsoleMessages):
* inspector/css-syntax-highlight.html: Removed.
* inspector/elements-panel-structure-expected.txt:
* inspector/elements-panel-structure.html:
* inspector/elements-tests.js: Added.
(frontendScript_expandDOMSubtree.processChildren):
(frontendScript_expandDOMSubtree):
* inspector/evaluate-in-frontend.html:
* inspector/evaluate-in-frontend.js: Removed.
* inspector/inspector-test.js: Added.
():
(evaluateInWebInspector):
(notifyDone):
(output):
(window.didEvaluateForTestInFrontend):
* inspector/javascript-syntax-highlight.html: Removed.
* inspector/styles-iframe.html:
* inspector/syntax-highlight-css-expected.txt: Renamed from LayoutTests/inspector/css-syntax-highlight-expected.txt.
* inspector/syntax-highlight-css.html: Added.
* inspector/syntax-highlight-javascript-expected.txt: Renamed from LayoutTests/inspector/javascript-syntax-highlight-expected.txt.
* inspector/syntax-highlight-javascript.html: Added.
* inspector/syntax-highlight.js: Added.
(doit.callback):
(doit):
(frontendScript_dumpSyntaxHighlight):
* inspector/timeline-trivial.html:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 5 Nov 2009 23:25:47 +0000 (23:25 +0000)]
2009-11-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
REGRESSION Clean up security origin usage in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=31188
Clean up security origin usage in DOM Storage. This fixes a bug in my
refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
Instead of having StorageAreaSync's constructor (which is called in the
constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
database identifier, simply have StorageAreaImpl pass the identifier into
StorageAreaSync.
No test because there's no change in externally observable behavior.
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::StorageAreaImpl):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::create):
(WebCore::StorageAreaSync::StorageAreaSync):
* storage/StorageAreaSync.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 23:08:47 +0000 (23:08 +0000)]
2009-11-05 Scott Violet <sky@google.com>
Reviewed by Dimitri Glazkov.
Need notification of scrolling frame
https://bugs.webkit.org/show_bug.cgi?id=31145
Adds FrameLoaderClient::didChangeScrollOffset that is called when
the frame scrolls. This will be used to know when history state
needs to be updated.
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didChangeScrollOffset):
* page/FrameView.cpp:
(WebCore::FrameView::valueChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 22:46:56 +0000 (22:46 +0000)]
2009-11-05 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
The number of selected lines in textarea after a shift-PageDown
may differ. The test case is modified so that it will not depend
on the exact number of lines selected. This should resolve regression
on platforms like Qt and GTK.
https://bugs.webkit.org/show_bug.cgi?id=31122
* editing/selection/shrink-selection-after-shift-pagedown.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 22:17:40 +0000 (22:17 +0000)]
2009-11-05 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[V8] Update bindings to use new API for external arrays
https://bugs.webkit.org/show_bug.cgi?id=31181
No new tests; covered by existing WebGL tests.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
(WebCore::V8DOMWrapper::getTemplate):
(WebCore::V8DOMWrapper::convertToV8Object):
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/custom/V8CanvasArrayCustom.h:
(WebCore::constructCanvasArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Thu, 5 Nov 2009 21:59:58 +0000 (21:59 +0000)]
Not reviewed, Chromium build fix.
Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
50561 introduces a custom method for SVGMatrix, we need to implement
this in V8.
* bindings/v8/custom/V8CustomBinding.h:
Adding definition for V8SVGMatrixMultiply.
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Implement V8SVGMatrixMultiply according to the same method in JSC.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 5 Nov 2009 21:09:01 +0000 (21:09 +0000)]
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: empty line in expectations build fix.
* fast/events/event-listener-map-rehash-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 5 Nov 2009 20:42:50 +0000 (20:42 +0000)]
Revert 50569 since it broke QT. Build fix and just a revert, so no review.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-05
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageEnabled):
* page/Settings.h:
(WebCore::Settings::sessionStorageEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 5 Nov 2009 20:13:29 +0000 (20:13 +0000)]
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
https://bugs.webkit.org/show_bug.cgi?id=30884
Test: inspector/styles-iframe.html
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
* inspector/front-end/InjectedScript.js:
(InjectedScript.getStyles):
(InjectedScript.getComputedStyle):
(InjectedScript.addStyleSelector):
* inspector/front-end/TestController.js:
(WebInspector.TestController.prototype.notifyDone):
(WebInspector.TestController.prototype.runAfterPendingDispatches):
(WebInspector.evaluateForTestInFrontend.invokeMethod):
(WebInspector.evaluateForTestInFrontend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Nov 2009 20:09:12 +0000 (20:09 +0000)]
WebCore:
2009-11-05 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Geoffrey Garen and Dimitri Glazkov.
Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027
Tested by new fast/events/event-listener-map-rehash-crash.html.
EventListenerMap modified to store pointers to listener vectors:
* dom/EventTarget.cpp:
(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
* dom/EventTarget.h:
Usages updated after interface changes:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferEventListenersToShadowTree):
LayoutTests:
2009-11-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Geoffrey Garen.
Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027
* fast/events/event-listener-map-rehash-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 5 Nov 2009 20:05:24 +0000 (20:05 +0000)]
Rubber-stamped by Adam Roben.
Add ruby tests and failing accessibility test to Windows Skipped list,
we should be able to re-add ruby tests, but not sure the correct course
of action yet.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 19:57:05 +0000 (19:57 +0000)]
2009-11-05 Dan Kegel <dank@chromium.org>
Reviewed by Dmitri Titov.
Add missing initialization for m_createdByParser.
https://bugs.webkit.org/show_bug.cgi?id=31089
Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Nov 2009 19:33:48 +0000 (19:33 +0000)]
2009-11-04 Eric Seidel <eric@webkit.org>
No review, just add a line which got left out of the patch uploaded for commit.
commit-queue is crashing when trying to reject patches after unknown failures
https://bugs.webkit.org/show_bug.cgi?id=31091
* Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 5 Nov 2009 19:27:17 +0000 (19:27 +0000)]
2009-11-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602
Part 2/2.
Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
* page/DOMWindow.idl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* storage/Storage.cpp:
(WebCore::Storage::setLocalStorageAvailable):
(WebCore::Storage::localStorageAvailable):
(WebCore::Storage::setSessionStorageAvailable):
(WebCore::Storage::sessionStorageAvailable):
* storage/Storage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 5 Nov 2009 18:33:59 +0000 (18:33 +0000)]
Bug 31108 - [V8] REGRESSION: Pause on exception is broken
https://bugs.webkit.org/show_bug.cgi?id=31108
Reviewed by Pavel Feldman.
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* bindings/v8/V8Utilities.cpp:
(WebCore::reportException):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log