WebKit-https.git
5 years ago[Apple] Use Accelerate framework to speed-up FEGaussianBlur
dino@apple.com [Tue, 9 Dec 2014 01:31:37 +0000 (01:31 +0000)]
[Apple] Use Accelerate framework to speed-up FEGaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=139310
<rdar://problem/18434594>

PerformanceTests:

Reviewed by Simon Fraser.

Add an interactive performance test that measures the speed of a set
of blur operations on a generated images.

* Interactive/blur-filter-timing.html: Added.

Source/WebCore:

<rdar://problem/18434594>

Reviewed by Simon Fraser.

Using Apple's Accelerate framework provides faster blurs
than the parallel jobs approach, especially since r168577
which started performing retina-accurate filters.

Using Accelerate.framework to replace the existing box blur (what
we use to approximate Gaussian blurs) gets about a 20% speedup on
desktop class machines, but between a 2x-6x speedup on iOS hardware.
Obviously this depends on the size of the content being blurred,
but it is still good.

The change is to intercept the platformApply function on
FEGaussianBlur and send it off to Accelerate.

There is an interactive performance test: PerformanceTests/Interactive/blur-filter-timing.html

* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::kernelPosition): Move this to a file static function from the .h.
(WebCore::accelerateBoxBlur): The Accelerate implementation.
(WebCore::standardBoxBlur): The default generic/standard implementation.
(WebCore::FEGaussianBlur::platformApplyGeneric): Use accelerate or the default form.
(WebCore::FEGaussianBlur::platformApply): Don't try the parallelJobs approach if Accelerate is available.
* platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::kernelPosition): Deleted. Move into the .cpp.

Source/WTF:

<rdar://problem/18434594>

Reviewed by Simon Fraser.

Add a HAVE_ACCELERATE flag, true on Apple platforms.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCopy and Lookup menu items should be disabled when something is not copyable
bdakin@apple.com [Tue, 9 Dec 2014 01:29:56 +0000 (01:29 +0000)]
Copy and Lookup menu items should be disabled when something is not copyable
https://bugs.webkit.org/show_bug.cgi?id=139423

Reviewed by Tim Horton.

Source/WebCore:

New function allowCopy() indicates whether the HitTestResult would allow itself to
be copied onto the pasteboard.
* WebCore.exp.in:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::allowsCopy):
* rendering/HitTestResult.h:

Source/WebKit/mac:

Disable both lookup and copy when a HitTestResult does not allow copy.
* WebView/WebActionMenuController.mm:

Set autoenablesItems to NO. It’s messing with our ability to control the enable/
disable state otherwise.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

Add allowsCopy to the WebHitTestResult.
* Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
* Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::allowsCopy):

Set autoenablesItems to NO. It’s messing with our ability to control the enable/
disable state otherwise.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):

Disable both lookup and copy when a WebHitTestResult does not allow copy.
* UIProcess/mac/WKActionMenuController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVis...
cdumez@apple.com [Tue, 9 Dec 2014 01:28:26 +0000 (01:28 +0000)]
Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow()
https://bugs.webkit.org/show_bug.cgi?id=139420

Reviewed by Simon Fraser.

Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to
changeAffectsVisualOverflow(). This has no behavior change as
changeRequiresLayout() calls changeAffectsVisualOverflow(). However,
this is clearer as text-shadow affects the visual overflow (similarly
to box-shadow).

No new tests, no behavior change.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::changeRequiresLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r176979.
commit-queue@webkit.org [Tue, 9 Dec 2014 01:26:28 +0000 (01:26 +0000)]
Unreviewed, rolling out r176979.
https://bugs.webkit.org/show_bug.cgi?id=139424

"New JSC test in this patch is failing" (Requested by mlam on
#webkit).

Reverted changeset:

"Fixes operationPutByIds such that they check that the put
didn't"
https://bugs.webkit.org/show_bug.cgi?id=139196
http://trac.webkit.org/changeset/176979

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListFor...
mitz@apple.com [Tue, 9 Dec 2014 01:20:52 +0000 (01:20 +0000)]
<rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListForCurrentSwipe in ViewGestureController::endSwipeGesture
https://bugs.webkit.org/show_bug.cgi?id=138750

Reviewed by Tim Horton.

The snapshot for the current gesture was being removed mid-gesture by the callback from
dispatchAfterEnsuringDrawing scheduled by the previous gesture. The fix is to ignore the
callback for a gesture if it is made after the snapshot for that gesture has already been
removed (which can happen as a result of the watchdog timer firing).

* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController): Initialize new member variable.
(WebKit::addLogEntry): Fixed the log message format.
(WebKit::ViewGestureController::endSwipeGesture): When dispatchAfterEnsuringDrawing() calls
us back, bail out if the gesture snapshot has already been removed.
(WebKit::ViewGestureController::removeSwipeSnapshot): Increment
m_gesturePendingSnapshotRemoval.
* UIProcess/mac/ViewGestureController.h: Added m_gesturePendingSnapshotRemoval member
variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix typo.
andersca@apple.com [Tue, 9 Dec 2014 01:17:35 +0000 (01:17 +0000)]
Fix typo.

* storage/StorageNamespaceImpl.cpp:
(WebCore::localStorageNamespaceMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebStorageNamespaceProvider should create StorageNamespaceImpls
andersca@apple.com [Tue, 9 Dec 2014 00:28:25 +0000 (00:28 +0000)]
WebStorageNamespaceProvider should create StorageNamespaceImpls
https://bugs.webkit.org/show_bug.cgi?id=139419

Reviewed by Andreas Kling.

Source/WebCore:

* WebCore.exp.in:
Export new symbols.

* WebCore.xcodeproj/project.pbxproj:
Make StorageNamespaceImpl.h a private header.

* storage/StorageNamespaceImpl.cpp:
(WebCore::localStorageNamespaceMap):
Use NeverDestroyed.

(WebCore::StorageNamespaceImpl::createSessionStorageNamespace):
(WebCore::StorageNamespaceImpl::getOrCreateLocalStorageNamespace):
Add new functions for creating namespaces.

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
Call the new functions.

* storage/StorageNamespaceImpl.h:
Add new members, make sure to deprecate the ones we don't want anyone calling.

* storage/StorageNamespaceProvider.cpp:
(WebCore::StorageNamespaceProvider::localStorageNamespace):
(WebCore::StorageNamespaceProvider::transientLocalStorageNamespace):
* storage/StorageNamespaceProvider.h:
Pass the quota when creating storage namespaces.

Source/WebKit:

* Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::createLocalStorageNamespace):
(WebStorageNamespaceProvider::createTransientLocalStorageNamespace):
Create StorageNamespaceImpls.

(WebStorageNamespaceProvider::createSessionStorageNamespace): Deleted.
Delete this for now.

* Storage/WebStorageNamespaceProvider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdding user content to a group should force that group to be created
andersca@apple.com [Tue, 9 Dec 2014 00:23:22 +0000 (00:23 +0000)]
Adding user content to a group should force that group to be created
https://bugs.webkit.org/show_bug.cgi?id=139421
rdar://problem/19180108

Reviewed by Sam Weinig.

* WebCoreSupport/WebViewGroup.h:
Store the local storage database path in the group.

* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.

(WebViewGroup::WebViewGroup):
Initialize the new member variable.

(WebViewGroup::storageNamespaceProvider):
Create the namespace provider lazily.

* WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
Use getOrCreate instead of get.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (173394): Support for webcam is broken
ap@apple.com [Tue, 9 Dec 2014 00:16:38 +0000 (00:16 +0000)]
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313

Test by Antti Koivisto, reviewed and tweaked by Alexey Proskuryakov.

* http/tests/multipart/multipart-image-expected.html: Added.
* http/tests/multipart/multipart-image.html: Added.

* http/tests/multipart/resources/multipart.php: Multiopart boundary must start on
a new line, so make it so. In newwer OS versions, CFNetwork has a workaround that
makes invalid multipart response work, which is why the test was passing locally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the new :nth-child() and :nth-last-child() out of experimental
benjamin@webkit.org [Mon, 8 Dec 2014 23:57:38 +0000 (23:57 +0000)]
Move the new :nth-child() and :nth-last-child() out of experimental
https://bugs.webkit.org/show_bug.cgi?id=139329

Reviewed by Andreas Kling.

The code is stable.
Feedback has only been positive.
All the known issues have been reported to the CSS WG.

The #ifdef don't really work anymore anyway for :nth-child() and :nth-last-child().

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoA selector should not match anything if there is a subselector after a non-scrollbar...
benjamin@webkit.org [Mon, 8 Dec 2014 23:56:20 +0000 (23:56 +0000)]
A selector should not match anything if there is a subselector after a non-scrollbar pseudo element
https://bugs.webkit.org/show_bug.cgi?id=139336
Source/WebCore:

rdar://problem/19051623

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-08
Reviewed by Andreas Kling.

Tests: fast/css/duplicated-after-pseudo-element.html
       fast/css/duplicated-before-pseudo-element.html
       fast/css/simple-selector-after-pseudo-element.html

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragments):
The code filtering out simple selectors was only considering
the relation CSSSelector::SubSelector. That comes from SelectorChecker where
the relation considered is the one from the previous selector.

In this case, the relation is the extracted from the current simple selector,
which is the relation with the following selector.

When a single simple selector was following a pseudo element, the relation evaluated
to descendant/adjacent/direct-adjacent and we were skipping the early return.
That simple selector was evaluated as a regular filter on the element.

In the CSS JIT, we can just remove that test altogether. Fragments are built one after
the other. By definition, the evaluated simple selector belong to the current fragment.

LayoutTests:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-08
Reviewed by Andreas Kling.

* fast/css/duplicated-after-pseudo-element-expected.html: Added.
* fast/css/duplicated-after-pseudo-element.html: Added.
* fast/css/duplicated-before-pseudo-element-expected.html: Added.
* fast/css/duplicated-before-pseudo-element.html: Added.
* fast/css/simple-selector-after-pseudo-element-expected.html: Added.
* fast/css/simple-selector-after-pseudo-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the parsing of advanced :lang() after r176902
benjamin@webkit.org [Mon, 8 Dec 2014 23:55:04 +0000 (23:55 +0000)]
Fix the parsing of advanced :lang() after r176902
https://bugs.webkit.org/show_bug.cgi?id=139379

Reviewed by Andreas Kling.

Source/WebCore:

There were two mistakes that were only caught in debug:

The lexer was not calling isIdentifierStart() before parseIdentifier().
Some identifier we were parsing should have been invalid.
This was caught with an assertion in parseIdentifier().

The other issue is that we were accumulating pointer to freed memory.
The tokenizer for LANGRANGE was creating a new string with a StringBuilder.
The problem is that CSSParserString does not keep the source string alive.
Consequently, the list of language range was accumulating pointers to dead
StringImpls.

The fix there is to simply extend the token to take the original asterisk character
from the input. That is not elegant but that's efficient and we know
the buffer lifetime.

* css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
* css/CSSGrammar.y.in: Fix the indentation of a language range rule.

LayoutTests:

Unskip and update the tests.

All the interesting cases were covered, I just had to update
the expectations.

* TestExpectations:
* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/parsing-css-lang-expected.txt:
* fast/css/parsing-css-lang.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build after r176971.
mmaxfield@apple.com [Mon, 8 Dec 2014 23:34:03 +0000 (23:34 +0000)]
Fix iOS build after r176971.

I had previously modified the WTF forwarding header instead of modifying the real source.

* wtf/unicode/CharacterNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix the 32-bit build.
andersca@apple.com [Mon, 8 Dec 2014 23:14:41 +0000 (23:14 +0000)]
Try to fix the 32-bit build.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe website data store should know all its associated pages
andersca@apple.com [Mon, 8 Dec 2014 23:14:06 +0000 (23:14 +0000)]
The website data store should know all its associated pages
https://bugs.webkit.org/show_bug.cgi?id=139411

Reviewed by Tim Horton.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
* UIProcess/WebPageProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::addWebPage):
(WebKit::WebsiteDataStore::removeWebPage):
* UIProcess/WebsiteData/WebsiteDataStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFixes operationPutByIds such that they check that the put didn't
mmirman@apple.com [Mon, 8 Dec 2014 23:11:23 +0000 (23:11 +0000)]
Fixes operationPutByIds such that they check that the put didn't
change the structure of the object who's property access is being
cached.
https://bugs.webkit.org/show_bug.cgi?id=139196

Reviewed by Filip Pizlo.

* jit/JITOperations.cpp:
(JSC::operationGetByIdOptimize): changed get to getPropertySlot
(JSC::operationPutByIdStrictBuildList): saved the structure before the put.
(JSC::operationPutByIdNonStrictBuildList): ditto.
(JSC::operationPutByIdDirectStrictBuildList): ditto.
(JSC::operationPutByIdDirectNonStrictBuildList): ditto.
* jit/Repatch.cpp:
(JSC::tryCachePutByID): fixed structure() to use the existant vm.
(JSC::tryBuildPutByIdList): Added a check that the old structure's id
is the same as the new.
(JSC::buildPutByIdList): Added an argument
* jit/Repatch.h:
(JSC::buildPutByIdList): Added an argument
* tests/stress/put-by-id-build-list-order-recurse.js: Test that failed before the change
* tests/stress/put-by-id-strict-build-list-order.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInline elements whose parents have small line-height are laid out too low
mmaxfield@apple.com [Mon, 8 Dec 2014 23:10:53 +0000 (23:10 +0000)]
Inline elements whose parents have small line-height are laid out too low
https://bugs.webkit.org/show_bug.cgi?id=139375

Reviewed by Dave Hyatt.

Source/WebCore:

This is a port of the Blink patch at
https://src.chromium.org/viewvc/blink?revision=155253&view=revision.

When laying out inline elements, we try to align leaf children's parents'
baselines across the entire line. However, if you set line-height: 0px on a
span, the entire InlineBox which represents that span will have a height of
0, and therefore be laid out entirely on the baseline. In addition, we will
try to vertically center the leaf text in the span's InlineBox, which means
the leaf text will be vertically centered on the baseline. All the other
major browsers do not have this behavior; instead, they line up the boxes
as you would expect.

This bug led to a rendering problem on the front page of the New York Times.

Here is the ChangeLog from the Blink patch:

Fix baseline position when it is outside the element's box

Specifically, we shouldn't force the baseline to be inside the element. IE
and FF don't do this, and it's incompatible with the CSS spec:

"The baseline of an 'inline-block' is the baseline of its last line box in
the normal flow, unless it has either no in-flow line boxes or if its
'overflow' property has a computed value other than 'visible', in which case
the baseline is the bottom margin edge."
-- http://www.w3.org/TR/CSS21/visudet.html#leading

It doesn't have a special case for "baseline is outside of the element's
margin box".

Test: fast/text/small-line-height.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):

LayoutTests:

Add fast/text/small-line-height.html for a simple example. In addition, update
existing tests.

* fast/forms/textfield-overflow-by-value-update-expected.txt:
* fast/regions/cssom/client-rects-inline-complex.html:
* fast/regions/overflow/overflow-region-inline-expected.html:
* fast/text/small-line-height-expected.html: Added.
* fast/text/small-line-height.html: Added.
* platform/mac/fast/box-sizing/box-sizing-expected.png:
* platform/mac/fast/box-sizing/box-sizing-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.png:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
* platform/mac/fast/multicol/client-rects-expected.png:
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-complex-expected.png:
* platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-expected.png:
* platform/mac/fast/multicol/client-rects-spanners-expected.txt:
* platform/mac/fast/multicol/layers-split-across-columns-expected.png:
* platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
* platform/mac/fast/multicol/newmulticol/client-rects-expected.png:
* platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] YouTube plug-in replacement should support partial urls
eric.carlson@apple.com [Mon, 8 Dec 2014 22:56:06 +0000 (22:56 +0000)]
[iOS] YouTube plug-in replacement should support partial urls
https://bugs.webkit.org/show_bug.cgi?id=139400

Reviewed by Alexey Proskuryakov.

* Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::youTubeURL): Call Document::completeURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebStorageNamespaceProvider should know about its local storage database path
andersca@apple.com [Mon, 8 Dec 2014 22:39:27 +0000 (22:39 +0000)]
WebStorageNamespaceProvider should know about its local storage database path
https://bugs.webkit.org/show_bug.cgi?id=139413

Reviewed by Andreas Kling.

Source/WebKit:

* Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::create):
(WebStorageNamespaceProvider::WebStorageNamespaceProvider):
* Storage/WebStorageNamespaceProvider.h:

Source/WebKit/mac:

* WebCoreSupport/WebViewGroup.h:
* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView setGroupName:]):
(-[WebView groupName]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix.
andersca@apple.com [Mon, 8 Dec 2014 22:38:23 +0000 (22:38 +0000)]
Build fix.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteAllCookiesModifiedSince):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRoll out r175352.
akling@apple.com [Mon, 8 Dec 2014 22:17:55 +0000 (22:17 +0000)]
Roll out r175352.
<https://webkit.org/b/139146>

This change caused some unexpected assertions in line box teardown.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeRemovedFromTree):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::willBeDestroyed):
* rendering/RenderReplaced.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoChange WTF::currentCPUTime to return std::chrono::microseconds and get rid of current...
andersca@apple.com [Mon, 8 Dec 2014 22:17:03 +0000 (22:17 +0000)]
Change WTF::currentCPUTime to return std::chrono::microseconds and get rid of currentCPUTimeMS
https://bugs.webkit.org/show_bug.cgi?id=139410

Reviewed by Andreas Kling.

Source/JavaScriptCore:

* API/JSContextRef.cpp:
(JSContextGroupSetExecutionTimeLimit):
(JSContextGroupClearExecutionTimeLimit):
* runtime/Watchdog.cpp:
(JSC::Watchdog::setTimeLimit):
(JSC::Watchdog::didFire):
(JSC::Watchdog::startCountdownIfNeeded):
(JSC::Watchdog::startCountdown):
* runtime/Watchdog.h:
* runtime/WatchdogMac.cpp:
(JSC::Watchdog::startTimer):

Source/WTF:

* wtf/CurrentTime.cpp:
(WTF::currentCPUTime):
(WTF::currentCPUTimeMS): Deleted.
* wtf/CurrentTime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCFA wrongly assumes that a speculation for SlowPutArrayStorageShape disallows ArraySt...
mark.lam@apple.com [Mon, 8 Dec 2014 22:12:25 +0000 (22:12 +0000)]
CFA wrongly assumes that a speculation for SlowPutArrayStorageShape disallows ArrayStorageShape arrays.
<https://webkit.org/b/139327>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The code generator and runtime slow paths expects otherwise.  This patch fixes
CFA to match the code generator's expectation.

* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes):

LayoutTests:

* js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage-expected.txt: Added.
* js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.html: Added.
* js/script-tests/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.js: Added.
(foo):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Narrow non-breaking space does not fall back to a correct font
mmaxfield@apple.com [Mon, 8 Dec 2014 22:10:40 +0000 (22:10 +0000)]
[iOS] Narrow non-breaking space does not fall back to a correct font
https://bugs.webkit.org/show_bug.cgi?id=139335

Reviewed by Enrica Casucci.

Source/WebCore:

Test: fast/text/narrow-non-breaking-space.html

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::requiresCustomFallbackFont):
(WebCore::FontCache::getCustomFallbackFont):

LayoutTests:

* fast/text/narrow-non-breaking-space-expected.html: Added.
* fast/text/narrow-non-breaking-space.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Fix the WebKit build with the public SDK
dbates@webkit.org [Mon, 8 Dec 2014 22:06:02 +0000 (22:06 +0000)]
[iOS] Fix the WebKit build with the public SDK

Source/WebCore:

Include header UIKit.h.

* platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit/mac:

Include header NSURLDownloadSPI.h.

* WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/18046692> [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when...
mitz@apple.com [Mon, 8 Dec 2014 21:53:54 +0000 (21:53 +0000)]
<rdar://problem/18046692> [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab
https://bugs.webkit.org/show_bug.cgi?id=139408

Reviewed by Anders Carlsson.

* UIProcess/ios/WKContentView.mm:
(-[WKContentView undoManager]): Override to initialize if necessary and return a unique undo
manager for this instance. This ensures that undoable operations for this webview don’t get
put in other undo managers, and matches UIWebView behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRevert r176293 & r176275
cdumez@apple.com [Mon, 8 Dec 2014 20:40:27 +0000 (20:40 +0000)]
Revert r176293 & r176275

Unreviewed, revert r176293 & r176275 changing the Vector API to use unsigned type
instead of size_t. There is some disagreement regarding the long-term direction
of the API and we shouldn’t leave the API partly transitioned to unsigned type
while making a decision.

Source/JavaScriptCore:

* bytecode/PreciseJumpTargets.cpp:
* replay/EncodedValue.h:

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSDOMBinding.h:
(WebCore::jsArray):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
* cssjit/SelectorCompiler.cpp:
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
(WebCore::SearchBuffer::length):
* html/HTMLFormElement.cpp:
(WebCore::removeFromVector):
* html/parser/HTMLParserIdioms.h:
* html/parser/XSSAuditor.cpp:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):

Source/WebKit2:

* Platform/IPC/ArgumentCoders.h:
* Platform/IPC/DataReference.h:

Source/WTF:

* wtf/Forward.h:
* wtf/Vector.h:
(WTF::VectorTypeOperations::compare):
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::shouldReallocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::capacity):
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::VectorBuffer::shouldReallocateBuffer):
(WTF::VectorBuffer::reallocateBuffer):
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::operator[]):
(WTF::OverflowHandler>::find):
(WTF::OverflowHandler>::reverseFind):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::resizeToFit):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::reserveInitialCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::reverse):
(WTF::OverflowHandler>::checkConsistency):
* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
(WTF::equalIgnoringNullity):
* wtf/text/StringView.h:
(WTF::append):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake deleting all cookies after a given date a little more sane
andersca@apple.com [Mon, 8 Dec 2014 20:36:27 +0000 (20:36 +0000)]
Make deleting all cookies after a given date a little more sane
https://bugs.webkit.org/show_bug.cgi?id=139409

Reviewed by Antti Koivisto.

Source/WebCore:

* WebCore.exp.in:
Update exports.

* platform/network/PlatformCookieJar.h:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/curl/CookieJarCurl.cpp:
* platform/network/soup/CookieJarSoup.cpp:
Rename deleteAllCookiesModifiedAfterDate to deleteAllCookiesModifiedSince and change it
to take an std::chrono::system_clock::time_point instead.

* platform/network/mac/CookieJarMac.mm:
(WebCore::cookieStorage):
Helper function that returns an NSHTTPCookieStorage given a network session.

(WebCore::deleteAllCookiesModifiedSince):
Get the cookie storage from the network storage instead of just getting the global one.

Source/WebKit2:

Change all the doubles to std::chrono::system_clock::time_points instead.

* Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::encode):
(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::decode):
* Platform/IPC/ArgumentCoders.h:
* Scripts/webkit/messages.py:
(headers_for_type):
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
* UIProcess/API/C/WKCookieManager.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedAfterDate): Deleted.
* UIProcess/WebCookieManagerProxy.h:
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::deleteAllCookiesModifiedAfterDate): Deleted.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the callback invocation outside of the loop.
andersca@apple.com [Mon, 8 Dec 2014 20:07:20 +0000 (20:07 +0000)]
Move the callback invocation outside of the loop.

Rubber-stamped by Tim Horton.

* UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd action menu tests
timothy_horton@apple.com [Mon, 8 Dec 2014 19:40:27 +0000 (19:40 +0000)]
Add action menu tests
https://bugs.webkit.org/show_bug.cgi?id=139156

Reviewed by Dean Jackson.

* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
Add a mechanism allowing tests to provide their own WKView subclass.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
Add a file with lots of menu targets.

* TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
(-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
(-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
(-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.

(-[ActionMenusTestWKView _setOverrideActionMenuItems:]):

(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::didFinishDownloadCallback):
(TestWebKitAPI::didCreateDownloadDestinationCallback):
Watch downloads and ensure that they match the content we expect.

(TestWebKitAPI::watchPasteboardForString):
(TestWebKitAPI::watchPasteboardForImage):
(TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
(TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
(TestWebKitAPI::javaScriptStringCallback):
(TestWebKitAPI::javaScriptBoolCallback):
(TestWebKitAPI::callJavaScriptReturningString):
(TestWebKitAPI::callJavaScriptReturningBool):
(TestWebKitAPI::watchEditableAreaForString):
(TestWebKitAPI::waitForVideoReady):
(TestWebKitAPI::retrieveSelection):
(TestWebKitAPI::retrieveSelectionInElement):
(TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
(TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
Add many helpers for testing, especially to make asynchronous things synchronous.

(TestWebKitAPI::windowPointForTarget):
(TestWebKitAPI::inset8):
Hard-code points in action-menu-targets.html for hit testing.

(TestWebKitAPI::TEST):
Add a suite of tests for WebKit2 action menus.

* TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
(TestWebKitAPI::createActionContextForPhoneNumber):
(TestWebKitAPI::ActionMenuTest::ActionMenuTest):
(TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
(TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
(TestWebKitAPI::ActionMenuTest::drawRect):
(TestWebKitAPI::ActionMenuTest::didCreatePage):
Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
so that we can test that infrastructure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r176953, add an unreachable return to make GCC happy.
ossy@webkit.org [Mon, 8 Dec 2014 19:30:19 +0000 (19:30 +0000)]
URTBF after r176953, add an unreachable return to make GCC happy.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Grid items must set a new formatting context.
jfernandez@igalia.com [Mon, 8 Dec 2014 19:13:16 +0000 (19:13 +0000)]
[CSS Grid Layout] Grid items must set a new formatting context.
https://bugs.webkit.org/show_bug.cgi?id=139150

Reviewed by David Hyatt.

Source/WebCore:

Grid item's margins must not collapse even when they may be adjoining to
its content's margins. Also, setting a new formatting context prevents any
'float' protruding content on the adjoining grid items.

This patch also renames the expandsToEncloseOverhangingFloats to be more generic now,
determining whether a new formatting context is set or not. This affects not only to
how floats behave, but whether margins should collapse or not.

Tests: fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
       fast/css-grid-layout/grid-item-margins-not-collapse.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::avoidsFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): Deleted.
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::MarginInfo::MarginInfo): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::layoutBlock): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::computeOverflow): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::addOverhangingFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::needsLayoutAfterRegionRangeChange): Using the new createsNewFormattingContext function.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::createsNewFormattingContext): Added.
(WebCore::RenderBox::avoidsFloats): Removed checks already defined in the new createsNewFormattingContext function.
* rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem): Added.

LayoutTests:

Test to verify that grid items's margin don't collapese with its parent's margin
and there is no 'float' protruding content on the adjoining grid items.

I had to rebaseline the form-hides-table.html test because table-caption, which
is supposed to establish a new formatting context, does not allow margins collapsing.

* fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html: Added.
* fast/css-grid-layout/float-not-protruding-into-next-grid-item.html: Added.
* fast/css-grid-layout/grid-item-margins-not-collapse-expected.html: Added.
* fast/css-grid-layout/grid-item-margins-not-collapse.html: Added.
* platform/gtk/fast/forms/form-hides-table-expected.txt: Rebaseline needed.
* platform/mac/fast/forms/form-hides-table-expected.txt: Rebaseline needed.
* platform/efl/TestExpectations: Mark fast/forms/form-hides-table-expected as failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a stub implementation of WebsiteDataStore::removeDataModifiedSince
andersca@apple.com [Mon, 8 Dec 2014 18:50:39 +0000 (18:50 +0000)]
Add a stub implementation of WebsiteDataStore::removeDataModifiedSince
https://bugs.webkit.org/show_bug.cgi?id=139406

Reviewed by Antti Koivisto.

Change _WKWebsiteDataStore to call the newly added function.

* UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(toWebsiteDataTypes):
(toSystemClockTime):
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeDataModifiedSince):
* UIProcess/WebsiteData/WebsiteDataStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Attempt to fix the public SDK build after <https://trac.webkit.org/r176841>
dbates@webkit.org [Mon, 8 Dec 2014 18:47:53 +0000 (18:47 +0000)]
[iOS] Attempt to fix the public SDK build after <https://trac.webkit.org/r176841>
(https://bugs.webkit.org/show_bug.cgi?id=139227)

* platform/spi/ios/AVKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Let DrawingArea manages setAcceleratedCompositingWindowId
yoon@igalia.com [Mon, 8 Dec 2014 18:46:49 +0000 (18:46 +0000)]
[GTK] Let DrawingArea manages setAcceleratedCompositingWindowId
https://bugs.webkit.org/show_bug.cgi?id=117230

Reviewed by Anders Carlsson.

This is a preparation patch for Threaded Coordinated Graphics.

LayerTreeHostGtk uses a native window handle to make glContext for
accelerated compositing. Therefore it is natural for DrawingArea to take
responsibility for the native window handle. And, in Coordinated
Graphics case, WebPage creates LayerTreeHost before receiving a native
window handle from UIProcess. It means we need a method to pass the
native window handle to already created LayerTreeHost.

This patch uses DrawingAreaProxy::setNativeSurfaceHandleForCompositing
instead of WebCoreProxy::setAcceleratedCompositingWindowId to set window
ID for accelerated compositing.

Also, this patch renames the setAcceleratedCompositingWindowId with a
more generic name, setNativeSurfaceHandleForCompositing.

No new tests. No change in functionality.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setNativeSurfaceHandleForCompositing):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/WebPageProxy.h:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId): Deleted.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::nativeSurfaceHandleForCompositing):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::glContext):
(WebKit::LayerTreeHostGtk::initialize):
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::setAcceleratedCompositingWindowId): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()
cdumez@apple.com [Mon, 8 Dec 2014 18:42:12 +0000 (18:42 +0000)]
Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()
https://bugs.webkit.org/show_bug.cgi?id=139350

Reviewed by Antti Koivisto.

Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()
and use m_loadType instead. ResourceRequest::cachePolicy() is meant to be passed
to the network stack, and isn't supposed to be used as input inside WebCore.

No new tests, no behavior change.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] UserMedia Permission Request API
philn@webkit.org [Mon, 8 Dec 2014 18:14:19 +0000 (18:14 +0000)]
[GTK] UserMedia Permission Request API
https://bugs.webkit.org/show_bug.cgi?id=136449

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Very basic constraints validation support in the GStreamer
MediaStreamCenter. This is needed so the GTK C API tests using the
getUserMedia() API would not time out.

* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::~MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::validateRequestConstraints):
(WebCore::MediaStreamCenterGStreamer::createMediaStream):

Source/WebKit2:

* PlatformGTK.cmake: GTK-specific new files.
* UIProcess/API/gtk/WebKitUIClient.cpp:  DecidePolicy handler
implementation for UserMediaPermissionRequest.
* UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp: Added,
WebKitGTK API for UserMediaPermissionRequest, very similar to the
one used for Geolocation.
(webkitUserMediaPermissionRequestAllow):
(webkitUserMediaPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkitUserMediaPermissionRequestDispose):
(webkit_user_media_permission_get_media_types):
(webkitUserMediaPermissionRequestGetProperty):
(webkit_user_media_permission_request_class_init):
(webkitUserMediaPermissionRequestCreate):
* UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h: Added.
* UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Expose new API
in documentation.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
* UIProcess/API/gtk/webkit2.h: Expose UserMediaPermissionRequest API.

Tools:

The GTK version of the MiniBrowser has gained UserMedia permission
request support.

* MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
requires user permission to access audio/video devices.
(permissionRequestDialogCallback):
(webViewDecidePermissionRequest):
(geolocationRequestDialogCallback): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a stubbed out method for clearing out the website data store
andersca@apple.com [Mon, 8 Dec 2014 18:05:44 +0000 (18:05 +0000)]
Add a stubbed out method for clearing out the website data store
https://bugs.webkit.org/show_bug.cgi?id=139404

Reviewed by Antti Koivisto.

Source/WebKit2:

Add stubbed out method that just calls the completion handler.

* UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
* UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):

Tools:

Add a debug menu item for testing clearing of website data.

* MiniBrowser/mac/MainMenu.xib:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController clearWebsiteData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Change expectations for two accessibility layout tests.
commit-queue@webkit.org [Mon, 8 Dec 2014 17:27:48 +0000 (17:27 +0000)]
[EFL] Change expectations for two accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=139399

Unreviewed gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-12-08

* platform/efl/accessibility/roles-exposed-expected.txt:
* platform/efl/accessibility/table-sections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove ResourceHandle::loadsBlocked()
andersca@apple.com [Mon, 8 Dec 2014 16:57:42 +0000 (16:57 +0000)]
Remove ResourceHandle::loadsBlocked()
https://bugs.webkit.org/show_bug.cgi?id=139401

Reviewed by Daniel Bates.

This hasn't returned true since Leopard, so get rid of it.

* page/Chrome.cpp:
(WebCore::Chrome::canRunModalNow):
* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: iOS: VoiceOver gets hung on some websites consistently.
cfleizach@apple.com [Mon, 8 Dec 2014 16:12:39 +0000 (16:12 +0000)]
AX: iOS: VoiceOver gets hung on some websites consistently.
https://bugs.webkit.org/show_bug.cgi?id=139331

Reviewed by Mario Sanchez Prada.

iFrames are attachments on iOS, but they do not have attachment views. As a result,
WebCore would return incorrect information for the element count and index of children elements.

No tests. Bug only manifests itself when iOS accessibility frameworks call into WebCore.

* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::isDetachedFromParent):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDetachedFromParent):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (173394): Support for webcam is broken
antti@apple.com [Mon, 8 Dec 2014 12:59:41 +0000 (12:59 +0000)]
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313

Reviewed by Alexey Proskuryakov.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

    Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics] Move CoordinatedBackingStore and CoordinatedGraphicsScene to...
yoon@igalia.com [Mon, 8 Dec 2014 12:09:30 +0000 (12:09 +0000)]
[CoordinatedGraphics] Move CoordinatedBackingStore and CoordinatedGraphicsScene to Shared
https://bugs.webkit.org/show_bug.cgi?id=139385

Reviewed by Martin Robinson.

For the Threaded Compositor, CoordinatedBackingStore and
CoordinatedGraphicsScene should be placed at the Shared instead of
UIProcess because it can be used in the WebProcess also.

No new tests because there is no behavior change.

* PlatformEfl.cmake:
* Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
* Shared/CoordinatedGraphics/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp.
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebkit using Harfbuzz does not display Arabic script correctly
berto@igalia.com [Mon, 8 Dec 2014 11:34:48 +0000 (11:34 +0000)]
Webkit using Harfbuzz does not display Arabic script correctly
https://bugs.webkit.org/show_bug.cgi?id=136337

Patch by Doron Wloschowsky <doron_wloschowsky@scee.net> on 2014-12-08
Reviewed by Carlos Garcia Campos.

Using reinterpret_cast to convert hb_codepoint_t* into UChar*
doesn't work on big endian systems.

* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::harfBuzzGetGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[as] Updated Assamese translations of WebKitGtk+
berto@igalia.com [Mon, 8 Dec 2014 11:33:38 +0000 (11:33 +0000)]
[as] Updated Assamese translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=137487

Patch by Nilamdyuti Goswami <nilamdyuti@gmail.com> on 2014-12-08
Reviewed by Carlos Garcia Campos.

* as.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Major cleanup of AudioDestination implementation
commit-queue@webkit.org [Mon, 8 Dec 2014 09:34:25 +0000 (09:34 +0000)]
[GStreamer] Major cleanup of AudioDestination implementation
https://bugs.webkit.org/show_bug.cgi?id=139370

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Add an audioresample element before the audio sink. The audio sink
might not be able to handle our sampling rate.

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::stop):
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady): Deleted.
Don't use a wavparse element but directly link the raw audio from
the source to the audio sink.

(WebCore::AudioDestinationGStreamer::start):
Catch errors when going to PLAYING early, we might not get an error
message.

* platform/audio/gstreamer/AudioDestinationGStreamer.h:
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcChangeState):
Don't use a WAV encoder but directly output raw audio. Also don't
include a unneeded audioconvert element before the interleave.

(webKitWebAudioSrcLoop):
Add timestamps and durations to the output buffers, map them in
READWRITE mode and actually keep them mapped until we're sure
nothing is actually writing into them.

(webKitWebAudioSrcLoop):
Pause the task on errors instead of continuously calling it again
immediately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Use gst_message_parse_buffering()
commit-queue@webkit.org [Mon, 8 Dec 2014 09:28:32 +0000 (09:28 +0000)]
[GStreamer] Use gst_message_parse_buffering()
https://bugs.webkit.org/show_bug.cgi?id=139365

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
Use gst_message_parse_buffering() instead of manually getting
the percentage from the message's structure. While the latter
is supposed to work and part of the ABI stability guarantee,
it's just not nice and overly complicated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Minor cleanup of the AudioFileReader implementation
commit-queue@webkit.org [Mon, 8 Dec 2014 09:26:36 +0000 (09:26 +0000)]
[GStreamer] Minor cleanup of the AudioFileReader implementation
https://bugs.webkit.org/show_bug.cgi?id=139367

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
Don't call gst_bus_remove_signal_watch(), the source was already
destroyed together with the main context and doing it again here
will give a g_critical().

(WebCore::AudioFileReader::handleSample):
Calculate the number of samples from the actual buffer size
and the bytes-per-frame instead of the buffer duration. Using
the buffer duration can lead to rounding errors and might cause
too few samples to be copied over later.

(WebCore::AudioFileReader::handleMessage):
Set the pipeline to GST_STATE_NULL immediately when receiving
errors to prevent other follow-up error messages from propagating
through the bus and spamming the user's terminal with g_warnings().

(WebCore::AudioFileReader::handleNewDeinterleavePad):
Sync the state of the queue and sink after deinterleave with
the parent state instead of just setting them to READY. That
way we potentially go to PAUSED state a bit earlier already
and prevent a potential race condition that could cause buffers
to arrive in the new elements in READY state already (which would
fail).

(WebCore::AudioFileReader::plugDeinterleave):
Handle multiple decodebin source pads by ignoring all following
ones just in case there are multiple for whatever reason.

(WebCore::AudioFileReader::decodeAudioForBusCreation):
Catch errors from going to PAUSED state early. We might not
get a error message at all if we're unlucky.

(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::AudioFileReader::handleSample):
Downmix to mono if required instead of just using the front
left channel and claiming it is mono. Downmixing from stereo
to mono will mix both channels instead of just taking the left.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Handle CLOCK_LOST and LATENCY messages
commit-queue@webkit.org [Mon, 8 Dec 2014 09:25:01 +0000 (09:25 +0000)]
[GStreamer] Handle CLOCK_LOST and LATENCY messages
https://bugs.webkit.org/show_bug.cgi?id=139341

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Handle CLOCK_LOST message by shortly going back to PAUSED state
and then to PLAYING again to let the pipeline select a new clock
for us.
This can happen if the stream that ends in a sink that provides
the current clock disappears, for example if the audio sink
provides the clock and the audio stream is disabled. It also
happens relatively often with HTTP adaptive streams when switching
between different variants of a stream.

Also handle the LATENCY message by triggering the default GStreamer
mechanism to update the latency. This can happen if the latency of
live elements changes, or for one reason or another a new live element
is added or removed from the pipeline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Use audio-filter property on GStreamer >= 1.4.2
commit-queue@webkit.org [Mon, 8 Dec 2014 09:23:25 +0000 (09:23 +0000)]
[GStreamer] Use audio-filter property on GStreamer >= 1.4.2
https://bugs.webkit.org/show_bug.cgi?id=139360

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Since 1.4.0 there is an audio-filter property we can use to place
the pitch-preserving filter at a more canonical position inside
the pipeline. Since 1.4.2 this property also handles all necessary
conversions for us.
This simplifies our sink code a bit because we don't have to create
a custom sink bin anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Add video/flv to the list of supported mimetypes
commit-queue@webkit.org [Mon, 8 Dec 2014 09:22:02 +0000 (09:22 +0000)]
[GStreamer] Add video/flv to the list of supported mimetypes
https://bugs.webkit.org/show_bug.cgi?id=139344

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
Add video/flv additional to video/x-flv to the list of supported
mimetypes. It's used on some websites, e.g.
http://www.jwplayer.com/html5/formats/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Remove GStreamer 0.10 #ifdefs.
commit-queue@webkit.org [Mon, 8 Dec 2014 09:19:26 +0000 (09:19 +0000)]
[GStreamer] Remove GStreamer 0.10 #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=138921

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.

* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered):
Remove GStreamer 0.10 #ifdefs, we depend on >= 1.0.3 at least.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Add application/x-mpegurl to the list of supported mimetypes.
commit-queue@webkit.org [Mon, 8 Dec 2014 09:18:32 +0000 (09:18 +0000)]
[GStreamer] Add application/x-mpegurl to the list of supported mimetypes.
https://bugs.webkit.org/show_bug.cgi?id=139343

Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
It's an alternative mimetype for the already supported
application/vnd.apple.mpegurl (aka HLS) and adding it
allows all streams on http://www.jwplayer.com/html5/hls/
to be played.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build warning in WebKit2/UIProcess module.
commit-queue@webkit.org [Mon, 8 Dec 2014 09:15:36 +0000 (09:15 +0000)]
Fix build warning in WebKit2/UIProcess module.
https://bugs.webkit.org/show_bug.cgi?id=139386

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-08
Reviewed by Alexey Proskuryakov.

Fix build warning by removing unused parameter name from function

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics] Change the namespace of CoordinatedBackingStore and Coordinated...
yoon@igalia.com [Mon, 8 Dec 2014 03:50:34 +0000 (03:50 +0000)]
[CoordinatedGraphics] Change the namespace of CoordinatedBackingStore and CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=139372

Reviewed by Gyuyoung Kim.

CoordinatedBackingStore and CoordinatedGraphicsScene should be declared in the WebKit namespace
instead of WebCore namespace.

* UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(WebKit::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile):
(WebKit::CoordinatedBackingStore::rect):
(WebCore::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile): Deleted.
(WebCore::CoordinatedBackingStore::rect): Deleted.
* UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:
(WebKit::CoordinatedGraphicsScene::setViewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::viewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::layerByID):
(WebKit::CoordinatedGraphicsScene::rootLayer):
(WebCore::CoordinatedGraphicsScene::setViewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::viewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::layerByID): Deleted.
(WebCore::CoordinatedGraphicsScene::rootLayer): Deleted.
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):
* UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
(WebKit::toImpl):
(WebKit::toAPI):
(toImpl): Deleted.
(toAPI): Deleted.
* UIProcess/CoordinatedGraphics/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse more PassRef in AtomicString.
akling@apple.com [Sun, 7 Dec 2014 23:25:59 +0000 (23:25 +0000)]
Use more PassRef in AtomicString.
<https://webkit.org/b/139319>

Reviewed by Antti Koivisto.

Make a pass over AtomicString and convert functions that return PassRefPtr
into returning RefPtr (where it may be null) and PassRef otherwise.
This allows the compiler to skip null checks in many places.

* wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::AtomicString::add):
(WTF::AtomicString::addFromLiteralData):
(WTF::AtomicString::addSlowCase):
* wtf/text/AtomicString.h:
(WTF::AtomicString::add):
(WTF::AtomicString::addWithStringTableProvider):
* wtf/text/cf/AtomicStringCF.cpp:
(WTF::AtomicString::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the unused WTF_USE_GCC_COMPUTED_GOTO_WORKAROUND after r129453.
ossy@webkit.org [Sun, 7 Dec 2014 22:25:01 +0000 (22:25 +0000)]
Remove the unused WTF_USE_GCC_COMPUTED_GOTO_WORKAROUND after r129453.
https://bugs.webkit.org/show_bug.cgi?id=139373

Reviewed by Sam Weinig.

* interpreter/Interpreter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[TextureMapper] Normalize pattern transform for pattern compositing
yoon@igalia.com [Sun, 7 Dec 2014 22:00:59 +0000 (22:00 +0000)]
[TextureMapper] Normalize pattern transform for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=139374

Reviewed by Martin Robinson.

In CoordGfx/TexMapGL, pattern compositing (for background image) uses
the patternTransform shader uniform. However, current implementation
miscalculates its transform matrix. It uses simple rectToRect
transformationMatrix which produces unnormalized garbage term.
This causes unexpected behavior at the fragmentation stage in some
mobile GPUs.

It should calculate its scale based on tileSize and contentSize,
and its position based on tilePhase and contentSize.

No new tests because the bug only occurs on some mobile GPUs.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
commit-queue@webkit.org [Sun, 7 Dec 2014 20:05:17 +0000 (20:05 +0000)]
[Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
https://bugs.webkit.org/show_bug.cgi?id=128739

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-07
Reviewed by Martin Robinson.
Source/WebCore:

Removed UTF-8 conversion of HTTP header values (SOUP and CURL).
Removed unnecessary UTF-8 conversion of HTTP header names (SOUP).
Changed conversion of HTTP method from UTF-8 to ASCII (SOUP and CURL).
Added explicit UTF-8 conversion of Content-Disposition header to compute download suggested filename.

Test: http/tests/xmlhttprequest/response-special-characters.html

* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::headerCallback): Removed header conversion.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Changed HTTP method conversion to ASCI.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): Removed header conversion.
(WebCore::ResourceRequest::updateSoupMessage): Changed HTTP method conversion to ASCII.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage):
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Rmoved header conversion.
(WebCore::ResourceResponse::platformSuggestedFilename): Added explicit conversion of contentDisposition to UTF-8.

LayoutTests:

Tests that non ascii header & reason phrase values are correctly retrieved by the web application.
headers.php script sends a response that includes non ascii header value.
not-ascii-status.php sends a response that includes non ascii reason phrase.
Removed specific gtk/efl expectations as now aligned with regular expectation.

* http/tests/xmlhttprequest/resources/headers.php: Added.
* http/tests/xmlhttprequest/resources/not-ascii-status.php: Added.
* http/tests/xmlhttprequest/response-special-characters-expected.txt: Added.
* http/tests/xmlhttprequest/response-special-characters.html: Added.
* platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate style checker to deal with "const override"
yoon@igalia.com [Sun, 7 Dec 2014 19:58:13 +0000 (19:58 +0000)]
Update style checker to deal with "const override"
https://bugs.webkit.org/show_bug.cgi?id=139371

Reviewed by Csaba Osztrogonác.

check-webkit-style shouldn't complain about an open brace to start a
line after a function definition with const override.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_brace_at_begin_of_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] WebKit has a new required dependency on GnuTLS
berto@igalia.com [Sun, 7 Dec 2014 19:24:14 +0000 (19:24 +0000)]
[GTK] WebKit has a new required dependency on GnuTLS
https://bugs.webkit.org/show_bug.cgi?id=136158

Reviewed by Martin Robinson.

Detect if GnuTLS is installed and enable or disable subtle crypto
support accordingly.

* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agofast/borders/mixed-border-style2.html has missing results on Mac Yosemite.
ap@apple.com [Sun, 7 Dec 2014 18:57:14 +0000 (18:57 +0000)]
fast/borders/mixed-border-style2.html has missing results on Mac Yosemite.

Looking at the bots, Yosemite results are the same as Mavericks, so moving the file.

* platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Removed.
* platform/mac/fast/borders/mixed-border-style2-expected.txt: Copied from LayoutTests/platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove platform/mac-mavericks/TestExpectations file.
ap@apple.com [Sun, 7 Dec 2014 18:53:42 +0000 (18:53 +0000)]
Remove platform/mac-mavericks/TestExpectations file.

We don't need it, we should be using modifiers such as [ Mavericks ].

1. platform/mac/editing/input/undo-grouping-on-text-insertion.html was already
skipped on all OS versions in platform/mac, so this skip did nothing.
2. Moved css3/filters/backdrop expectation to platform/mac.
3. css3/viewport-percentage-lengths tests are now fixed by a configuration change
on a bot.

* platform/mac-mavericks/TestExpectations: Removed.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Fix GObject DOM bindings API break tests after r176920
carlosgc@webkit.org [Sun, 7 Dec 2014 18:11:22 +0000 (18:11 +0000)]
[GTK] Fix GObject DOM bindings API break tests after r176920
https://bugs.webkit.org/show_bug.cgi?id=139368

Reviewed by Gustavo Noronha Silva.

Remove the @version from the symbol name before comparing.

* gtk/check-for-webkitdom-api-breaks:
(read_expected_api):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIntroduce and deploy a function that allocates and returns an instance of a soft...
mitz@apple.com [Sun, 7 Dec 2014 17:28:01 +0000 (17:28 +0000)]
Introduce and deploy a function that allocates and returns an instance of a soft-linked class
https://bugs.webkit.org/show_bug.cgi?id=139348

Reviewed by Anders Carlsson.

In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
avoiding the ambiguity.

Source/WebCore:

* editing/mac/DataDetection.mm:
(WebCore::DataDetection::detectItemAroundHitTestResult):
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac): Cast the result of +alloc to an instance of the
expected class.

* platform/graphics/mac/FontMac.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
* platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::createPDFDocument):
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(SOFT_LINK_CONSTANT):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
* platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager initializeOnMainThread]):
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController init]):
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter):

* platform/mac/SoftLinking.h: Added alloc##className##instance().

* platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]):
* platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::setupCaptureSession):
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType):
* platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::setupSession):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setupCaptureSession):
* platform/network/ios/QuickLook.mm:
(WebCore::registerQLPreviewConverterIfNeeded):
(WebCore::QuickLookHandle::QuickLookHandle):

Source/WebKit/ios:

* Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider createLocationManager]):

Source/WebKit/mac:

* WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):

Source/WebKit2:

* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):
(-[WKAirPlayRoutePicker show:fromRect:]):
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[_WKVideoFileUploadItem displayImage]):
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectableLink]):
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the option to automatically update the GObject DOM bindings symbols file
carlosgc@webkit.org [Sun, 7 Dec 2014 16:23:31 +0000 (16:23 +0000)]
Remove the option to automatically update the GObject DOM bindings symbols file
https://bugs.webkit.org/show_bug.cgi?id=139366

Reviewed by Martin Robinson.

It's currently broken, because symbols now need to be in a
specific order. Now that the symbols file only contains stable
API, it's not a problem to manually update it every time new API
is added.

* gtk/check-for-webkitdom-api-breaks:
(read_expected_api):
(check_api):
(write_expected_api): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed GTK gardening.
clopez@igalia.com [Sun, 7 Dec 2014 16:11:01 +0000 (16:11 +0000)]
[GTK] Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Report and mark new failures.
* platform/gtk/svg/animations/animate-marker-orienttype-1-expected.txt: Added. Rebaseline after r175525.
* platform/gtk/svg/animations/animate-marker-orienttype-2-expected.txt: Added. Rebaseline after r175525.
* platform/gtk/svg/animations/animate-marker-orienttype-3-expected.txt: Added. Rebaseline after r175525.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use GMainLoopSource in WebKitTestRunner
carlosgc@webkit.org [Sun, 7 Dec 2014 14:08:09 +0000 (14:08 +0000)]
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831

Reviewed by Sergio Villar Senin.

* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Add Since tags to GObject DOM bindings documentation
carlosgc@webkit.org [Sun, 7 Dec 2014 13:40:56 +0000 (13:40 +0000)]
[GTK] Add Since tags to GObject DOM bindings documentation
https://bugs.webkit.org/show_bug.cgi?id=139356

Reviewed by Gustavo Noronha Silva.

Now that we have a small stable API, and new symbols are added
manually, we can also add the version to the symbols file, that
the code generator can ue to add Since tags to the gtk-doc.

* bindings/gobject/webkitdom.symbols: Add @2.8 to the new symbols
added for 2.8.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateConstants): Add Since tag to gtk-doc if there's a version
number for the symbol in the .symbols file.
(GenerateFunction): Ditto.
(ReadStableSymbols):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Missing API detected in GObject DOM bindings after r176630
carlosgc@webkit.org [Sun, 7 Dec 2014 10:02:52 +0000 (10:02 +0000)]
[GTK] Missing API detected in GObject DOM bindings after r176630
https://bugs.webkit.org/show_bug.cgi?id=139201

Reviewed by Gustavo Noronha Silva.

.:

Change GENERATE_BINDINGS macro to receive a list of optional
additional dependencies, so that we can add more dependecies
without having to change the macro.

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Bring back WebKitDOMDeprecated and add custom versions of the
removed symbols as deprecated in favor of the new ones. Also add
the new ones as stable API.

* CMakeLists.txt: Pass a list of additional dependencies to GENERATE_BINDINGS.
* PlatformGTK.cmake: Ditto.
* PlatformMac.cmake: Ditto.
* bindings/gobject/WebKitDOMDeprecated.cpp: Added.
(webkit_dom_html_element_get_inner_html):
(webkit_dom_html_element_set_inner_html):
(webkit_dom_html_element_get_outer_html):
(webkit_dom_html_element_set_outer_html):
* bindings/gobject/WebKitDOMDeprecated.h: Added.
* bindings/gobject/WebKitDOMDeprecated.symbols: Added.
* bindings/gobject/webkitdom.symbols:

Tools:

Handle deprecated symbols again when generating the GObject DOM
bindings documentation.

* gtk/webkitdom.py:
(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.is_deprecated_symbol_file):
(WebKitDOMDocGenerator.generate):
(WebKitDOMDocGeneratorSections.__init__):
(WebKitDOMDocGeneratorSections._find_deprecated_symbols):
(WebKitDOMDocGeneratorSections.write_section):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][jhbuild] Fix libsoup build with clang
ossy@webkit.org [Sun, 7 Dec 2014 09:17:10 +0000 (09:17 +0000)]
[EFL][jhbuild] Fix libsoup build with clang
https://bugs.webkit.org/show_bug.cgi?id=139088

Reviewed by Gyuyoung Kim.

* efl/jhbuild.modules:
* efl/patches/soup-clang-warning-fix1.patch: Added.
* efl/patches/soup-clang-warning-fix2.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] DumpRenderTree sets storage directory incorrectly
ap@apple.com [Sat, 6 Dec 2014 23:52:33 +0000 (23:52 +0000)]
[Mac] DumpRenderTree sets storage directory incorrectly
https://bugs.webkit.org/show_bug.cgi?id=139347

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
Don't use user defaults to pass per-instance paths, as user defaults are shared
across all instances.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r176915.
ossy@webkit.org [Sat, 6 Dec 2014 23:35:06 +0000 (23:35 +0000)]
URTBF after r176915.

DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.

That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
such as GTK, EFL, Apple Windows.

Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
guard, so there is no reason to define it for non COCOA platforms.

* platform/graphics/GraphicsLayerUpdater.cpp:
* platform/graphics/GraphicsLayerUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build with newer versions of clang.
andersca@apple.com [Sat, 6 Dec 2014 21:44:36 +0000 (21:44 +0000)]
Fix build with newer versions of clang.
rdar://problem/18978733

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
(WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll): Deleted.
* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
* platform/graphics/GraphicsLayerUpdater.h:
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::supportsControlTints): Deleted.
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): Deleted.
* rendering/RenderLayerCompositor.h:
* rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

Add missing overrides and casts.

* NetworkProcess/NetworkProcess.h:
* Shared/Downloads/DownloadAuthenticationClient.h:
(WebKit::DownloadAuthenticationClient::refAuthenticationClient): Deleted.
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient): Deleted.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration copyWithZone:]):
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterViewportChange): Deleted.
* UIProcess/WebPageProxy.h:
* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::WebContentProcessMainDelegate::getConnectionIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientProcessName): Deleted.
* WebProcess/IconDatabase/WebIconDatabaseProxy.h:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebBackForwardListProxy.h:
* WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::didClose): Deleted.
(WebKit::WebInspector::didReceiveInvalidMessage): Deleted.
* WebProcess/WebPage/WebInspectorUI.h:
(WebKit::WebInspectorUI::didClose): Deleted.
(WebKit::WebInspectorUI::didReceiveInvalidMessage): Deleted.
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebProcess.h:
* WebProcess/ios/WebVideoFullscreenManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOnly include TUCallSPI on Mac.
andersca@apple.com [Sat, 6 Dec 2014 21:43:22 +0000 (21:43 +0000)]
Only include TUCallSPI on Mac.

* Platform/mac/MenuUtilities.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a stubbed out version of WebStorageNamespaceProvider
andersca@apple.com [Sat, 6 Dec 2014 21:27:34 +0000 (21:27 +0000)]
Add a stubbed out version of WebStorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139213

Reviewed by Sam Weinig.

Source/WebKit:

* Storage/WebStorageNamespaceProvider.cpp: Added.
* Storage/WebStorageNamespaceProvider.h: Added.

* WebKit.vcxproj/WebKit/WebKit.vcxproj:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
* WebKit.xcodeproj/project.pbxproj:
Add new files.

Source/WebKit/mac:

* WebCoreSupport/WebViewGroup.h:
(WebViewGroup::storageNamespaceProvider):
* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
Give WebViewGroup a storage namespace provider.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build with newer versions of clang.
andersca@apple.com [Sat, 6 Dec 2014 21:23:57 +0000 (21:23 +0000)]
Fix build with newer versions of clang.
rdar://problem/18978687

Source/WebCore:

Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.

* html/HTMLElement.h:
* html/HTMLMediaElement.h:
* html/track/VTTCue.h:
* loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.
* loader/cache/CachedImage.h:
* page/SuspendableTimer.h:
* platform/Scrollbar.h:
* platform/graphics/InbandTextTrackPrivate.h:
* rendering/RenderBlockFlow.h:

Source/WebKit/ios:

Cast the result of +alloc to the right type.

* Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider createLocationManager]):
* WebCoreSupport/WebSelectionRect.m:
(+[WebSelectionRect selectionRect]):

Source/WebKit/mac:

Add missing overrides and missing casts.

* Storage/WebDatabaseManagerClient.h:
* Storage/WebStorageTrackerClient.h:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebInspectorClient.h:
* WebView/WebDataSource.mm:
(-[WebDataSource _makeRepresentation]):
* WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFollow-up build fix.
andersca@apple.com [Sat, 6 Dec 2014 21:10:23 +0000 (21:10 +0000)]
Follow-up build fix.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build with newer versions of clang.
andersca@apple.com [Sat, 6 Dec 2014 21:04:35 +0000 (21:04 +0000)]
Fix build with newer versions of clang.
rdar://problem/18978689

Disable the "inconsistent missing override" warning due to our use of macros in SVG where it's hard to
know whether we can add an override or not.

Also, cast return values of +alloc to the right type, and add some casts for vector iterator arithmetic.

* Configurations/Base.xcconfig:
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidForOriginAndName):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
* editing/cocoa/HTMLConverter.mm:
(_shadowForShadowStyle):
(HTMLConverter::_addTableForElement):
* platform/graphics/SVGGlyph.cpp:
(WebCore::isCompatibleArabicForm):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
* platform/graphics/mac/FontMac.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
* platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager initializeOnMainThread]):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build with newer versions of clang.
andersca@apple.com [Sat, 6 Dec 2014 21:04:31 +0000 (21:04 +0000)]
Fix build with newer versions of clang.
rdar://problem/18978716

* ftl/FTLJITCode.h:
Add missing overrides.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSkipping tests due to regression in r176902.
mark.lam@apple.com [Sat, 6 Dec 2014 19:36:35 +0000 (19:36 +0000)]
Skipping tests due to regression in r176902.
<https://webkit.org/b/139014>

Not reviewed.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Compile error, missing guard.
commit-queue@webkit.org [Sat, 6 Dec 2014 18:26:07 +0000 (18:26 +0000)]
[WinCairo] Compile error, missing guard.
https://bugs.webkit.org/show_bug.cgi?id=139338

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-06
Reviewed by Alex Christensen.

There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.

* css/CSSParser.cpp:
(WebCore::CSSParser::realLex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r176905.
commit-queue@webkit.org [Sat, 6 Dec 2014 11:50:29 +0000 (11:50 +0000)]
Unreviewed, rolling out r176905.
https://bugs.webkit.org/show_bug.cgi?id=139337

the test case is failing in bots (Requested by anttik on
#webkit).

Reverted changeset:

"REGRESSION (173394): Support for webcam is broken"
https://bugs.webkit.org/show_bug.cgi?id=139313
http://trac.webkit.org/changeset/176905

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (173394): Support for webcam is broken
antti@apple.com [Sat, 6 Dec 2014 10:39:51 +0000 (10:39 +0000)]
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

    Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.

LayoutTests:

We had no coverage for actually rendering multipart content.

* http/tests/multipart/multipart-image-expected.html: Added.
* http/tests/multipart/multipart-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: I cannot activate links on the mobile version of news.google.com
cfleizach@apple.com [Sat, 6 Dec 2014 05:44:10 +0000 (05:44 +0000)]
AX: I cannot activate links on the mobile version of news.google.com
https://bugs.webkit.org/show_bug.cgi?id=139330

Reviewed by Simon Fraser.

Source/WebCore:

This website only listens for touch events. VoiceOver normally dispatches click and mouse events,
so on iOS this falls and VoiceOver is not able to activate anything.

The solution here is to dispatch simulated touch down/up events.

Test: platform/ios-simulator/ios-accessibility/press-fires-touch-events.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::dispatchTouchEvent):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDetachedFromParent):
* page/EventHandler.h:
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchSimulatedTouchEvent):
* platform/ios/PlatformEventFactoryIOS.h:
* platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebCore::PlatformEventFactory::createPlatformSimulatedTouchEvent):

Tools:

Implement press for iOS.

* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::press):

LayoutTests:

* platform/ios-simulator/ios-accessibility: Added.
* platform/ios-simulator/ios-accessibility/press-fires-touch-events-expected.txt: Added.
* platform/ios-simulator/ios-accessibility/press-fires-touch-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDirectional single quotation marks are not rotated in vertical text
mmaxfield@apple.com [Sat, 6 Dec 2014 05:14:12 +0000 (05:14 +0000)]
Directional single quotation marks are not rotated in vertical text
https://bugs.webkit.org/show_bug.cgi?id=138526

Source/WebCore:

Reviewed by Darin Adler.

In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.

Test: fast/text/vertical-quotation-marks.html

* platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):

LayoutTests:

Compare vertical and horizontal renderings.

Reviewed by Darin Adler.

* fast/text/vertical-quotation-marks-expected.html: Added.
* fast/text/vertical-quotation-marks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement parser for :lang pseudo class selector arguments that contain wildcard...
commit-queue@webkit.org [Sat, 6 Dec 2014 05:09:11 +0000 (05:09 +0000)]
Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
https://bugs.webkit.org/show_bug.cgi?id=139014

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-05
Reviewed by Benjamin Poulain.

Source/WebCore:

Consider each language range in :lang() that consists of an asterisk
immediately followed by an identifier beginning with an ASCII hyphen
as a valid input for the selector as specified in [1].

[1] http://dev.w3.org/csswg/selectors4/#the-lang-pseudo

Test: fast/css/parsing-css-lang.html

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::realLex):

LayoutTests:

* fast/css/css-selector-text-expected.txt: Updated for asterisk containing input.
* fast/css/css-selector-text.html: Updated for asterisk containing input.
* fast/css/parsing-css-lang-expected.txt: Added.
* fast/css/parsing-css-lang.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a delegate method for didReceiveServerRedirectForProvisionalLoadForFrame.
commit-queue@webkit.org [Sat, 6 Dec 2014 02:04:13 +0000 (02:04 +0000)]
Add a delegate method for didReceiveServerRedirectForProvisionalLoadForFrame.
https://bugs.webkit.org/show_bug.cgi?id=139325

Add delegate method webProcessPlugInBrowserContextController:didReceiveServerRedirectForProvisionalLoadForFrame: into
WKWebProcessPlugInLoadDelegate to listen to server side redirect in injected bundle.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-12-05
Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didReceiveServerRedirectForProvisionalLoadForFrame):
(setUpPageLoaderClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoProgrammatic scrolling and content changes are not always synchronized
simon.fraser@apple.com [Sat, 6 Dec 2014 01:25:21 +0000 (01:25 +0000)]
Programmatic scrolling and content changes are not always synchronized
https://bugs.webkit.org/show_bug.cgi?id=139245
rdar://problem/18833612

Reviewed by Anders Carlsson.

Manual test that tries to sync layout with programmatic scrolling.

* ManualTests/programmatic-scroll-flicker.html: Added.

Source/WebCore:

For programmatic scrolls, AsyncScrollingCoordinator::requestScrollPositionUpdate()
calls updateScrollPositionAfterAsyncScroll(), then dispatches the requested
scroll position to the scrolling thread.

Once the scrolling thread commits, it calls back to the main thread via
scheduleUpdateScrollPositionAfterAsyncScroll(), which schedules a second
call to updateScrollPositionAfterAsyncScroll() on a timer. That's a problem,
because some other scroll may have happened in the meantime; when the timer
fires, it can sometimes restore a stale scroll position.

Fix by bailing early from scheduleUpdateScrollPositionAfterAsyncScroll()
for programmatic scrolls, since we know that requestScrollPositionUpdate()
already did the updateScrollPositionAfterAsyncScroll().

Test:
    ManualTests/programmatic-scroll-flicker.html

* page/FrameView.cpp:
(WebCore::FrameView::reset): nullptr.
(WebCore::FrameView::setScrollPosition): Ditto.
(WebCore::FrameView::setWasScrolledByUser): Ditto.
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate): Use a local variable for
isProgrammaticScroll just to make sure we use the same value for the duration of this function.
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll): Do nothing
if this is a programmatic scroll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix.
timothy_horton@apple.com [Sat, 6 Dec 2014 01:20:41 +0000 (01:20 +0000)]
Build fix.

* platform/spi/mac/TUCallSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
dbates@webkit.org [Sat, 6 Dec 2014 01:09:52 +0000 (01:09 +0000)]
[iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
https://bugs.webkit.org/show_bug.cgi?id=139326

Reviewed by Anders Carlsson.

Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
using the same scale factor as used in WebKit.

* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] proj files copying over too many resources..
roger_fong@apple.com [Sat, 6 Dec 2014 01:09:33 +0000 (01:09 +0000)]
[Win] proj files copying over too many resources..
https://bugs.webkit.org/show_bug.cgi?id=139315.
<rdar://problem/19148278>

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.proj: Don't copy over bin32 build output.
* WebKit.vcxproj/WebKit.proj: Only copy resource folders and WebKit.dll.
* JavaScriptCore.vcxproj/JavaScriptCore.proj: Only copy resource folders and JavaScriptCore.dll.
* WTF.vcxproj/WTF.proj: Only copy WTF.dll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse the system string for telephone number menu
timothy_horton@apple.com [Sat, 6 Dec 2014 01:07:12 +0000 (01:07 +0000)]
Use the system string for telephone number menu
https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>

* platform/spi/mac/TUCallSPI.h: Added.
Actually add the SPI header from the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse the system string for telephone number menu
timothy_horton@apple.com [Sat, 6 Dec 2014 01:01:48 +0000 (01:01 +0000)]
Use the system string for telephone number menu
https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>

Reviewed by Anders Carlsson.

* Platform/mac/MenuUtilities.mm:
(WebKit::menuItemTitleForTelephoneNumberGroup):
Make use of the SPI to retrieve the string if it exists.

* WebCore.xcodeproj/project.pbxproj:
* platform/spi/mac/TUCallSPI.h: Added.
Add an SPI header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF, EFL is happy now.
ossy@webkit.org [Sat, 6 Dec 2014 00:42:00 +0000 (00:42 +0000)]
URTBF, EFL is happy now.

* UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::defaultDataStoreConfiguration):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::createNonPersistent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of config.h includes and include config.h in the prefix header instead
andersca@apple.com [Sat, 6 Dec 2014 00:33:33 +0000 (00:33 +0000)]
Get rid of config.h includes and include config.h in the prefix header instead
https://bugs.webkit.org/show_bug.cgi?id=139323

Reviewed by Brent Fulgham.

This is making it easier to share code between WebKit1 for Mac and WebKit1 for Windows.

* AccessibleBase.cpp:
* AccessibleDocument.cpp:
* AccessibleImage.cpp:
* AccessibleTextImpl.cpp:
* CFDictionaryPropertyBag.cpp:
* DOMCSSClasses.cpp:
* DOMCoreClasses.cpp:
* DOMEventsClasses.cpp:
* DOMHTMLClasses.cpp:
* DefaultDownloadDelegate.cpp:
* DefaultPolicyDelegate.cpp:
* ForEachCoClass.cpp:
* FullscreenVideoController.cpp:
* MarshallingHelpers.cpp:
* MemoryStream.cpp:
* WebActionPropertyBag.cpp:
* WebArchive.cpp:
* WebBackForwardList.cpp:
* WebCache.cpp:
* WebCoreStatistics.cpp:
* WebCoreSupport/AcceleratedCompositingContext.cpp:
* WebCoreSupport/EmbeddedWidget.cpp:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebContextMenuClient.cpp:
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
* WebCoreSupport/WebDragClient.cpp:
* WebCoreSupport/WebEditorClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameNetworkingContext.cpp:
* WebCoreSupport/WebGeolocationClient.cpp:
* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorDelegate.cpp:
* WebCoreSupport/WebPlatformStrategies.cpp:
* WebCoreSupport/WebVisitedLinkStore.cpp:
* WebDataSource.cpp:
* WebDatabaseManager.cpp:
* WebDocumentLoader.cpp:
* WebDownload.cpp:
* WebDownloadCFNet.cpp:
* WebDownloadCurl.cpp:
* WebDropSource.cpp:
* WebElementPropertyBag.cpp:
* WebError.cpp:
* WebFrame.cpp:
* WebFramePolicyListener.cpp:
* WebGeolocationPolicyListener.cpp:
* WebGeolocationPosition.cpp:
* WebHTMLRepresentation.cpp:
* WebHistory.cpp:
* WebHistoryItem.cpp:
* WebIconDatabase.cpp:
* WebInspector.cpp:
* WebJavaScriptCollector.cpp:
* WebKitCOMAPI.cpp:
* WebKitClassFactory.cpp:
* WebKitDLL.cpp:
* WebKitGraphics.cpp:
* WebKitLogging.cpp:
* WebKitPrefix.h:
* WebKitStatistics.cpp:
* WebKitSystemBits.cpp:
* WebLocalizableStrings.cpp:
* WebMutableURLRequest.cpp:
* WebNavigationData.cpp:
* WebNodeHighlight.cpp:
* WebNotification.cpp:
* WebNotificationCenter.cpp:
* WebPreferences.cpp:
* WebResource.cpp:
* WebScriptObject.cpp:
* WebScriptWorld.cpp:
* WebSecurityOrigin.cpp:
* WebSerializedJSValue.cpp:
* WebTextRenderer.cpp:
* WebURLAuthenticationChallenge.cpp:
* WebURLAuthenticationChallengeSender.cpp:
* WebURLAuthenticationChallengeSenderCFNet.cpp:
* WebURLAuthenticationChallengeSenderCurl.cpp:
* WebURLCredential.cpp:
* WebURLProtectionSpace.cpp:
* WebURLResponse.cpp:
* WebUserContentURLPattern.cpp:
* WebView.cpp:
* WebWorkersPrivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGardening: one more build fix for GTK builds.
mark.lam@apple.com [Sat, 6 Dec 2014 00:31:17 +0000 (00:31 +0000)]
Gardening: one more build fix for GTK builds.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[JSC][FTL] Add the data layout to the module and fix the pass order.
commit-queue@webkit.org [Sat, 6 Dec 2014 00:29:18 +0000 (00:29 +0000)]
[JSC][FTL] Add the data layout to the module and fix the pass order.
https://bugs.webkit.org/show_bug.cgi?id=138748

Patch by Juergen Ributzka <juergen@apple.com> on 2014-12-05
Reviewed by Oliver Hunt.

This adds the data layout to the module, so it can be used by all
optimization passes in the LLVM optimizer pipeline. This also allows
FastISel to select more instructions, because less non-legal types are
generated.

Also fix the order of the alias analysis passes in the optimization
pipeline.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF, remove duplicated entry due to parallel buildfixing.
ossy@webkit.org [Sat, 6 Dec 2014 00:28:49 +0000 (00:28 +0000)]
URTBF, remove duplicated entry due to parallel buildfixing.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r176849.
ossy@webkit.org [Sat, 6 Dec 2014 00:25:24 +0000 (00:25 +0000)]
URTBF after r176849.

* CMakeLists.txt: Added WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176887 268f45cc-cd09-0410-ab3c-d52691b4dbfc