WebKit-https.git
11 years agoDisable animations/font-size-using-ems.html as it has been causing the following...
mrowe@apple.com [Sun, 12 Oct 2008 01:31:19 +0000 (01:31 +0000)]
Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig and Anders Carlsson.
mitz@apple.com [Sat, 11 Oct 2008 23:10:43 +0000 (23:10 +0000)]
    Reviewed by Sam Weinig and Anders Carlsson.

        - update Mac DumpRenderTree to use the new WebView SPI for forcing the
          complex text code path
        - add --complex-text support to Windows DumpRenderTree

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (createWebViewAndOffscreenWindow):
        (main):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 11 Oct 2008 22:53:28 +0000 (22:53 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
          and add a corresponding getter; add the same functions on Windows

        * WebCore.base.exp:
        * platform/graphics/Font.cpp:
        (WebCore::Font::setCodePath):
        (WebCore::codePath):
        (WebCore::Font::canUseGlyphCache):
        * platform/graphics/Font.h:
        * platform/mac/WebCoreTextRenderer.h:
        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreSetAlwaysUsesComplexTextCodePath):
        (WebCoreAlwaysUsesComplexTextCodePath):
        * platform/win/WebCoreTextRenderer.cpp:
        (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
        (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
        * platform/win/WebCoreTextRenderer.h:

WebKit/mac:

        Reviewed by Sam Weinig.

        - rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and
          update it for the renamed WebCoreTextRenderer method; keep the old
          method around for clients that use it

        * WebView/WebView.mm:
        (+[WebView _setAlwaysUseATSU:]):
        (+[WebView _setAlwaysUsesComplexTextCodePath:]):
        * WebView/WebViewPrivate.h:

WebKit/win:

        Reviewed by Sam Weinig.

        - add SPI for forcing the complex text code path to be used for all text

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::setAlwaysUsesComplexTextCodePath):
        (WebView::alwaysUsesComplexTextCodePath):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Oct 2008 22:20:09 +0000 (22:20 +0000)]
2008-10-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Stop leaking the event parameter names.  The protected strings were showing up
        in the caches window after one use.  No measurable performance loss.

        * bindings/js/JSEventListener.cpp:
        (WebCore::eventParameterName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Oct 2008 22:10:38 +0000 (22:10 +0000)]
2008-10-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Remove unused function getNodeEventListener.

        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-11 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 11 Oct 2008 20:58:35 +0000 (20:58 +0000)]
2008-10-11  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Sam Weinig.

        Bug 21525: 55 StructureID leaks on Wikitravel's main page
        <https://bugs.webkit.org/show_bug.cgi?id=21525>

        Bug 21533: Simple JavaScript code leaks StructureIDs
        <https://bugs.webkit.org/show_bug.cgi?id=21533>

        StructureID::getEnumerablePropertyNames() ends up calling back to itself
        via JSObject::getPropertyNames(), which causes the PropertyNameArray to
        be cached twice. This leads to a memory leak in almost every use of
        JSObject::getPropertyNames() on an object. The fix here is based on a
        suggestion of Sam Weinig.

        This patch also fixes every StructureID leaks that occurs while running
        the Mozilla MemBuster test.

        * kjs/PropertyNameArray.h:
        (JSC::PropertyNameArray::PropertyNameArray):
        (JSC::PropertyNameArray::setCacheable):
        (JSC::PropertyNameArray::cacheable):
        * kjs/StructureID.cpp:
        (JSC::StructureID::getEnumerablePropertyNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 07:50:03 +0000 (07:50 +0000)]
2008-10-11  David Hyatt  <hyatt@apple.com>

        Add support for both positive and negative margins to tracks and track pieces.

        Reviewed by Tim Hatcher

        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        (WebCore::ScrollbarThemeComposite::hitTest):
        (WebCore::ScrollbarThemeComposite::splitTrack):
        (WebCore::ScrollbarThemeComposite::trackPieceRects):
        (WebCore::ScrollbarThemeComposite::trackPosition):
        (WebCore::ScrollbarThemeComposite::trackLength):
        * platform/ScrollbarThemeComposite.h:
        (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::trackRect):
        (WebCore::RenderScrollbar::trackPieceRectWithMargins):
        * rendering/RenderScrollbar.h:
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::computeScrollbarWidth):
        (WebCore::RenderScrollbarPart::computeScrollbarHeight):
        * rendering/RenderScrollbarTheme.cpp:
        (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
        * rendering/RenderScrollbarTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate scrollbars layout tests to new syntax.
hyatt@apple.com [Sat, 11 Oct 2008 06:33:35 +0000 (06:33 +0000)]
Update scrollbars layout tests to new syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 06:30:47 +0000 (06:30 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
        the scrollbar pseudo-elements anyway.

        Reviewed by Tim Hatcher

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sat, 11 Oct 2008 06:26:59 +0000 (06:26 +0000)]
    Reviewed by Sam Weinig.

        - separate Cache::remove() into a private method and a public interface,
          then make Cache::pruneDeadResources() use the private method.

        * loader/Cache.cpp:
        (WebCore::Cache::pruneDeadResources):
        (WebCore::Cache::evict):
        * loader/Cache.h:
        (WebCore::Cache::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 06:12:14 +0000 (06:12 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Fix a math error when splitting a vertical track.  Clean up more of ScrollbarThemeComposite
        now that the track pieces meet under the thumb.

        Reviewed by Tim Hatcher

        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        (WebCore::ScrollbarThemeComposite::splitTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 06:04:02 +0000 (06:04 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).

        Reviewed by Tim Hatcher

        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::hitTest):
        (WebCore::ScrollbarThemeComposite::splitTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 05:54:35 +0000 (05:54 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.

        Reviewed by Tim Hatcher

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::createScrollbar):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::createCustomScrollbar):
        (WebCore::RenderScrollbar::RenderScrollbar):
        (WebCore::RenderScrollbar::setParent):
        (WebCore::RenderScrollbar::updateScrollbarParts):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderScrollbar.h:
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse fastcall calling convention on GCC > 4.0
oliver@apple.com [Sat, 11 Oct 2008 05:49:39 +0000 (05:49 +0000)]
Use fastcall calling convention on GCC > 4.0

Reviewed by Cameron Zwarich

Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 11 Oct 2008 05:30:39 +0000 (05:30 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Make sure scrollbar background images cause proper part invalidation to occur.

        Reviewed by Tim Hatcher

        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::setHoveredPart):
        (WebCore::RenderScrollbar::setPressedPart):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::styleDidChange):
        (WebCore::RenderScrollbarPart::imageChanged):
        * rendering/RenderScrollbarPart.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Sat, 11 Oct 2008 02:53:03 +0000 (02:53 +0000)]
JavaScriptCore:

2008-10-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        - Add a workaround for a bug in ceil in Darwin libc.
        - Remove old workarounds for JS math functions that are not needed
          anymore.

        The math functions are heavily tested by fast/js/math.html.

        * kjs/MathObject.cpp:
        (JSC::mathProtoFuncAbs): Remove workaround.
        (JSC::mathProtoFuncCeil): Ditto.
        (JSC::mathProtoFuncFloor): Ditto.
        * wtf/MathExtras.h:
        (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        - Update tests after fixing ceil(-0.1) behavior on darwin.

        * fast/js/math-expected.txt:
        * fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
        * fast/xpath/4XPath/Core/test_core_functions-expected.txt:
        * fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Oct 2008 02:05:08 +0000 (02:05 +0000)]
2008-10-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler

        Add Assertions to JSObject constructor.

        * kjs/JSObject.h:
        (JSC::JSObject::JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 11 Oct 2008 00:35:23 +0000 (00:35 +0000)]
2008-10-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=21538

        The blendFunc() for TransformOperations should never mess with the
        operation lists by replacing some ops with identity, otherwise the lists
        no longer match and transitions break.

        Test: transitions/matched-transform-functions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 11 Oct 2008 00:32:39 +0000 (00:32 +0000)]
2008-10-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=21537

        Fix re-targetting a running transition; if the target property
        changes, we do need to make a new ImplicitAnimation.

        Test: transitions/retargetted-transition.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimationPrivate::updateTransitions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion
oliver@apple.com [Fri, 10 Oct 2008 23:21:39 +0000 (23:21 +0000)]
Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion

Reviewed by Cameron Zwarich

When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging.  This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS.  The solution is just to
clear the exception state after attempting to record the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 22:24:15 +0000 (22:24 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Make textareas work with custom CSS scrollbars and resizers.  Need to access the correct renderer
        when looking for pseudo styles.

        Reviewed by Tim Hatcher

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::styleChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 10 Oct 2008 22:19:16 +0000 (22:19 +0000)]
2008-10-10  Dean Jackson  <dino@apple.com>

        Keyframe example had "0" rather than "0%".

        * WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 22:16:24 +0000 (22:16 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Add the ability to style the scroll corner and the resizer from CSS.

        Reviewed by Tim Hatcher

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::~RenderLayer):
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayer.h:
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::updateScrollbarPart):
        (WebCore::RenderScrollbar::paintPart):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::RenderScrollbarPart):
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderScrollbarPart.h:
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 21:05:07 +0000 (21:05 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Make CSS scrollbars respect the OS setting regarding where buttons should be placed.

        Reviewed by Sam Weinig

        No test case possible, since the OS setting can vary.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
        * platform/Scrollbar.h:
        (WebCore::Scrollbar::styleChanged):
        * platform/mac/ScrollbarThemeMac.mm:
        (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
        (WebCore::ScrollbarThemeMac::preferencesChanged):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::invalidateScrollbarRect):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::styleChanged):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderScrollbar.h:
        * rendering/RenderScrollbarTheme.h:
        (WebCore::RenderScrollbarTheme::buttonsPlacement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
adachan@apple.com [Fri, 10 Oct 2008 20:43:01 +0000 (20:43 +0000)]
    Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
        potentially hold onto stale instances of WebPreferences
        https://bugs.webkit.org/show_bug.cgi?id=21526

        webPreferencesInstances now keeps a reference to all the instances it holds.
        Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
        it after they have released their references to the WebPreferences objects.

        Reviewed by Adam Roben.

        * WebPreferences.cpp:
        (WebPreferences::getInstanceForIdentifier):
        (WebPreferences::removeReferenceForIdentifier):
        * WebView.cpp:
        (WebView::close):
        (WebView::setPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixes a regression with input search fields, where the placeholder text
timothy@apple.com [Fri, 10 Oct 2008 20:27:51 +0000 (20:27 +0000)]
    Fixes a regression with input search fields, where the placeholder text
        would not be updated when the value of the placeholder attribute changed.

        https://bugs.webkit.org/show_bug.cgi?id=21521

        Reviewed by Adele Peterson.

        Test: fast/forms/search-placeholder-value-changed.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
        placeholderValueChanged parameter of updatePlaceholderVisibility.
        (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
        for placeholderValueChanged that informs the method that the value changed.
        * html/HTMLInputElement.h: Add the placeholderValueChanged to the
        updatePlaceholderVisibility method. Made it default to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 20:12:14 +0000 (20:12 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Allow the track part to have negative margins so that it can slightly overlap buttons.  This
        is necessary to emulate the Aqua look in CSS.

        Reviewed by Sam Weinig

        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        (WebCore::ScrollbarThemeComposite::hitTest):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::setHoveredPart):
        (WebCore::RenderScrollbar::trackRect):
        * rendering/RenderScrollbar.h:
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::computeScrollbarWidth):
        (WebCore::RenderScrollbarPart::computeScrollbarHeight):
        * rendering/RenderScrollbarTheme.cpp:
        (WebCore::RenderScrollbarTheme::backButtonRect):
        (WebCore::RenderScrollbarTheme::forwardButtonRect):
        (WebCore::RenderScrollbarTheme::trackRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 19:32:52 +0000 (19:32 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21527

        Make CSS scrollbars support :not, :hover and :active.

        Reviewed by Adam Roben

        Added WebCore/manual-tests/scrollbar-hover-active.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::autoscrollPressedPart):
        (WebCore::Scrollbar::startTimerIfNeeded):
        (WebCore::Scrollbar::setHoveredPart):
        (WebCore::Scrollbar::setPressedPart):
        (WebCore::Scrollbar::mouseMoved):
        (WebCore::Scrollbar::mouseExited):
        (WebCore::Scrollbar::mouseUp):
        (WebCore::Scrollbar::mouseDown):
        * platform/Scrollbar.h:
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::setHoveredPart):
        (WebCore::RenderScrollbar::setPressedPart):
        (WebCore::RenderScrollbar::updateScrollbarParts):
        (WebCore::pseudoForScrollbarPart):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderScrollbar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 10 Oct 2008 18:43:47 +0000 (18:43 +0000)]
2008-10-10  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
        CSS transition with duration=0 and delay=0 doesn't override ongoing transition

        Test: transitions/interrupt-zero-duration.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateTransitions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 10 Oct 2008 18:04:20 +0000 (18:04 +0000)]
2008-10-09  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=21310

        Redesigned how animation events are sent in order to get rid of
        AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
        are now ref counted. While calling the event handler, I keep a
        reference to this class to avoid it getting destroyed out from under me.

        I also moved most of the functionality of CompositeAnimation to
        and internal class (CompositeAnimationPrivate) to reduce the exposure
        of the internals of the various animation classes.

        We have several transition and animation LayoutTests which verify that
        this fix works as expected and continues to avoid crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Add new scrollbar-related sources.
kevino@webkit.org [Fri, 10 Oct 2008 17:13:46 +0000 (17:13 +0000)]
wx build fix. Add new scrollbar-related sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 10 Oct 2008 16:59:20 +0000 (16:59 +0000)]
WebCore:

2008-10-10  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21522

        Support increment/decrement/start/end on scrollbars.  Allows a fully functional scrollbar to be
        created.  (Just :hover/:active left to finish it up.)

        Reviewed by Adam Roben

        Added scrollbars/scrollbar-buttons.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

LayoutTests:

2008-10-10  David Hyatt  <hyatt@apple.com>

        Add test for scrollbar buttons and track supporting increment/decrement/start/end.

        Reviewed by Adam Roben

        * platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
        * platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
        * platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
        * scrollbars/scrollbar-buttons.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand updated layout test after pseudoclass rename.
hyatt@apple.com [Fri, 10 Oct 2008 16:40:51 +0000 (16:40 +0000)]
Land updated layout test after pseudoclass rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 16:40:26 +0000 (16:40 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Rename some pseudoclasses.  Removing "-scrollbar-" from a bunch of the pseudoclasses.  Renaming
        back/forward to decrement/increment.  Adding start/end pseudoclasses.

        Reviewed by Eric Seidel

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 10 Oct 2008 07:18:48 +0000 (07:18 +0000)]
2008-10-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Remove now unused m_getterSetterFlag variable from PropertyMap.

        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::operator=):
        * kjs/PropertyMap.h:
        (JSC::PropertyMap::PropertyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
hyatt@apple.com [Fri, 10 Oct 2008 07:15:52 +0000 (07:15 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 07:15:04 +0000 (07:15 +0000)]
2008-10-10  David Hyatt  <hyatt@apple.com>

        Switch window-active to window-inactive, since that will work better as far as degrading in other
        browsers.

        Reviewed by Tim Hatcher

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoYet another Tiger build fix.
timothy@apple.com [Fri, 10 Oct 2008 07:06:08 +0000 (07:06 +0000)]
Yet another Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 10 Oct 2008 07:04:38 +0000 (07:04 +0000)]
WebCore:

2008-10-09  David Hyatt  <hyatt@apple.com>

        Add support for scrollbar orientation as a pseudoclass.  Add support for whether or not the scrollbar
        is active as well.

        Reviewed by Tim Hatcher

        Added scrollbars/scrollbar-orientation.html

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::isWindowActive):
        * platform/Scrollbar.h:
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::paint):
        (WebCore::RenderScrollbar::partForStyleResolve):
        * rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09  David Hyatt  <hyatt@apple.com>

        Add layout test for scrollbars honoring orientation and window active state.

        Reviewed by Tim Hatcher

        * platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
        * platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
        * platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
        * scrollbars/scrollbar-orientation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnother build fix.
timothy@apple.com [Fri, 10 Oct 2008 06:39:45 +0000 (06:39 +0000)]
Another build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFull build fix for the fail on Tiger.
timothy@apple.com [Fri, 10 Oct 2008 06:12:10 +0000 (06:12 +0000)]
Full build fix for the fail on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 10 Oct 2008 05:56:10 +0000 (05:56 +0000)]
WebCore:

2008-10-09  David Hyatt  <hyatt@apple.com>

        Add support for pseudo classes on scrollbar pseudo elements.  As an initial proof of concept only
        :enabled/:disabled are supported.  More pseudo classes will follow quickly now that this works.

        Reviewed by Tim Hatcher

        Added scrollbars/disabled-scrollbar.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
        * css/CSSStyleSelector.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getPseudoStyle):
        * rendering/RenderObject.h:
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::setEnabled):
        (WebCore::RenderScrollbar::scrollbarForStyleResolve):
        (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
        (WebCore::RenderScrollbar::paintPart):
        * rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09  David Hyatt  <hyatt@apple.com>

        Add test case for disabled scrollbars.

        Reviewed by Tim Hatcher

        * platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
        * platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
        * platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
        * scrollbars/disabled-scrollbar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix.
timothy@apple.com [Fri, 10 Oct 2008 04:34:30 +0000 (04:34 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 10 Oct 2008 04:04:15 +0000 (04:04 +0000)]
2008-10-09  Eric Carlson  <eric.carlson@apple.com>

        Media controls should not show when element is not visible

        https://bugs.webkit.org/show_bug.cgi?id=21155

        Reviewed by Adele Peterson.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
        in sync with visibility changes
        * html/HTMLMediaElement.h:
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
        (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
        if element is visible or not. Don't animate controller visibility when change triggered by
        showing or hiding media element.
        * rendering/RenderMedia.h: declare m_previousVisible

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Gtk bustage.
hyatt@apple.com [Fri, 10 Oct 2008 03:42:13 +0000 (03:42 +0000)]
Fix Gtk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt bustage.
hyatt@apple.com [Fri, 10 Oct 2008 03:41:34 +0000 (03:41 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows bustage.
hyatt@apple.com [Fri, 10 Oct 2008 03:37:21 +0000 (03:37 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix typo in my Changelog comment
hyatt@apple.com [Fri, 10 Oct 2008 03:25:37 +0000 (03:25 +0000)]
Fix typo in my Changelog comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnnotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availa...
timothy@apple.com [Fri, 10 Oct 2008 03:23:12 +0000 (03:23 +0000)]
Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availability macros and version macros.

WebCore:

2008-10-09  Timothy Hatcher  <timothy@apple.com>

        Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
        availability macros and version macros.

        https://bugs.webkit.org/show_bug.cgi?id=21496
        rdar://problem/6259225

        Reviewed by Sam Weinig.

        * bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
        * bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
        and add an #if around the enum.
        * bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
        comment to match the other headers.
        * bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
        * bindings/objc/DOMObject.h: Add a version #if around class interface.
        * bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
        and add a version #if around the enum.
        * bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
        * bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
        * bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
        when they where added to WebKit. Also annotate individual methods that are
        deprecated or where added after the class was added to WebKit.
        * bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
        since this header is included by most DOM headers. Annotate the JSObject method.

        * bindings/scripts/CodeGeneratorObjC.pm:
        (ReadPublicInterfaces): Parse out the availability macro for each function/property.
        And parse out the availability version for the class/protocol. Default to
        WEBKIT_VERSION_LATEST if the class is new.
        (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
        interface availability version check if the class has a required version. Create
        a public interface key (used to lookup in $publicInterfaces) and make a declaration
        suffix that includes the availability macro (if needed). Use the "available in 1.3
        and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
        the default availability macro for old style methods. Tweak line breaks in the generated
        headers to look good and not have too many extra lines.

WebKit/mac:

2008-10-09  Timothy Hatcher  <timothy@apple.com>

        Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
        back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
        JavaScriptCore from the VPATH.

        Reviewed by Sam Weinig.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Oct 2008 03:15:31 +0000 (03:15 +0000)]
2008-10-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=20947

        Refactor setStyle() methods into styleWillChange()
        and styleDidChange(), so most of the setStyle() overrides can
        be removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Oct 2008 03:13:07 +0000 (03:13 +0000)]
2008-10-09  David Hyatt  <hyatt@apple.com>

        Make sure to destroy a custom scrollbar's RenderObject's before the arena goes away.  When our widget
        parent is nulled out is a good time.

        Reviewed by Oliver Hunt

        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::~RenderScrollbar):
        (WebCore::RenderScrollbar::setParent):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderScrollbar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 10 Oct 2008 02:33:16 +0000 (02:33 +0000)]
WebCore:

2008-10-09  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21446

        This patch gets CSS scrollbars up and limping.  There's no way to distinguish between states or between
        orientation and back vs. forward on the buttons, but it's a start.

        Reviewed by Oliver Hunt

        Added scrollbars/basic-scrollbar.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * platform/ScrollTypes.h:
        (WebCore::):
        * platform/Scrollbar.h:
        (WebCore::Scrollbar::styleChanged):
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        (WebCore::ScrollbarThemeComposite::splitTrack):
        * platform/ScrollbarThemeComposite.h:
        (WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
        (WebCore::ScrollbarThemeComposite::paintTrackBackground):
        (WebCore::ScrollbarThemeComposite::paintTrackPiece):
        * platform/win/ScrollbarThemeSafari.cpp:
        (WebCore::ScrollbarThemeSafari::paintTrackBackground):
        * platform/win/ScrollbarThemeSafari.h:
        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarThemeWin::paintTrack):
        * platform/win/ScrollbarThemeWin.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderScrollbar.cpp: Added.
        (WebCore::RenderScrollbar::createCustomScrollbar):
        (WebCore::RenderScrollbar::RenderScrollbar):
        (WebCore::RenderScrollbar::~RenderScrollbar):
        (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
        (WebCore::RenderScrollbar::updateScrollbarParts):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        (WebCore::RenderScrollbar::paintPart):
        (WebCore::RenderScrollbar::buttonRect):
        (WebCore::RenderScrollbar::minimumThumbLength):
        * rendering/RenderScrollbar.h: Added.
        (WebCore::RenderScrollbar::styleChanged):
        (WebCore::RenderScrollbar::owningRenderer):
        * rendering/RenderScrollbarPart.cpp: Added.
        (WebCore::RenderScrollbarPart::RenderScrollbarPart):
        (WebCore::RenderScrollbarPart::~RenderScrollbarPart):
        (WebCore::RenderScrollbarPart::layout):
        (WebCore::RenderScrollbarPart::layoutHorizontalPart):
        (WebCore::RenderScrollbarPart::layoutVerticalPart):
        (WebCore::calcScrollbarThicknessUsing):
        (WebCore::RenderScrollbarPart::computeScrollbarWidth):
        (WebCore::RenderScrollbarPart::computeScrollbarHeight):
        (WebCore::RenderScrollbarPart::calcPrefWidths):
        (WebCore::RenderScrollbarPart::setStyle):
        * rendering/RenderScrollbarPart.h: Added.
        (WebCore::RenderScrollbarPart::renderName):
        (WebCore::RenderScrollbarPart::requiresLayer):
        * rendering/RenderScrollbarTheme.cpp: Added.
        (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
        (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
        (WebCore::RenderScrollbarTheme::hasButtons):
        (WebCore::RenderScrollbarTheme::hasThumb):
        (WebCore::RenderScrollbarTheme::minimumThumbLength):
        (WebCore::RenderScrollbarTheme::backButtonRect):
        (WebCore::RenderScrollbarTheme::forwardButtonRect):
        (WebCore::RenderScrollbarTheme::trackRect):
        (WebCore::RenderScrollbarTheme::paintScrollCorner):
        (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
        (WebCore::RenderScrollbarTheme::paintTrackBackground):
        (WebCore::RenderScrollbarTheme::paintTrackPiece):
        (WebCore::RenderScrollbarTheme::paintButton):
        (WebCore::RenderScrollbarTheme::paintThumb):
        * rendering/RenderScrollbarTheme.h: Added.
        (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
        (WebCore::RenderScrollbarTheme::scrollbarThickness):
        (WebCore::RenderScrollbarTheme::buttonsPlacement):
        (WebCore::RenderScrollbarTheme::supportsControlTints):
        (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
        (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
        (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
        (WebCore::RenderScrollbarTheme::registerScrollbar):
        (WebCore::RenderScrollbarTheme::unregisterScrollbar):
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::):

LayoutTests:

2008-10-09  David Hyatt  <hyatt@apple.com>

        Land layout test for CSS scrollbars.

        Reviewed by Oliver Hunt

        * platform/mac/scrollbars: Added.
        * platform/mac/scrollbars/basic-scrollbar-expected.checksum: Added.
        * platform/mac/scrollbars/basic-scrollbar-expected.png: Added.
        * platform/mac/scrollbars/basic-scrollbar-expected.txt: Added.
        * scrollbars: Added.
        * scrollbars/basic-scrollbar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Fri, 10 Oct 2008 02:27:52 +0000 (02:27 +0000)]
    Reviewed by Oliver Hunt.

        Test cases for https://bugs.webkit.org/show_bug.cgi?id=21498

        * fast/canvas/gradient-with-clip-expected.txt: Added.
        * fast/canvas/gradient-with-clip.html: Added.
        * fast/canvas/pattern-with-transform-expected.txt: Added.
        * fast/canvas/pattern-with-transform.html: Added.
        * fast/canvas/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/resources/TEMPLATE.html.
        * fast/canvas/resources/gradient-with-clip.js: Added.
        * fast/canvas/resources/pattern-with-transform.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Fri, 10 Oct 2008 02:26:54 +0000 (02:26 +0000)]
    Reviewed by Oliver Hunt.

        Fix Canvex DOOM Game
        Gradient clips were not getting cleared after filling the
        gradient, this was causing nothing to draw in Canvex
        https://bugs.webkit.org/show_bug.cgi?id=21498

        Tests forthcoming.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 10 Oct 2008 02:17:12 +0000 (02:17 +0000)]
2008-10-09  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Add StructureID.o to the exclusion list in the global initializers
        script to fix the Debug build.

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 10 Oct 2008 01:21:09 +0000 (01:21 +0000)]
2008-10-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Add leaks checking to StructureID.

        * kjs/StructureID.cpp:
        (JSC::StructureID::StructureID):
        (JSC::StructureID::~StructureID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 10 Oct 2008 00:50:25 +0000 (00:50 +0000)]
2008-10-09  Alp Toker  <alp@nuanti.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=20760
        Implement support for x86 Linux in CTI

        Prepare to enable CTI/WREC on supported architectures.

        Make it possible to use the CTI_ARGUMENT workaround with GCC as well
        as MSVC by fixing some preprocessor conditionals.

        Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
        don't actually enable it except when building with MSVC. GCC on Win32
        remains untested.

        Adapt inline ASM code to use the global symbol underscore prefix only
        on Darwin and to call the properly mangled Machine::cti_vm_throw
        symbol name depending on CTI_ARGUMENT.

        Also avoid global inclusion of the JIT infrastructure headers
        throughout WebCore and WebKit causing recompilation of about ~1500
        source files after modification to X86Assembler.h, CTI.h, WREC.h,
        which are only used deep inside JavaScriptCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Fri, 10 Oct 2008 00:08:44 +0000 (00:08 +0000)]
    Reviewed by Oliver Hunt.

        Fix transformed patterns
        https://bugs.webkit.org/show_bug.cgi?id=21498

        Test: fast/canvas/patternfill-repeat.html

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setStrokePattern):
        (WebCore::GraphicsContext::setFillPattern):
        (WebCore::GraphicsContext::setStrokeGradient):
        (WebCore::GraphicsContext::setFillGradient):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::applyStrokePattern):
        (WebCore::applyFillPattern):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/wx/GraphicsContextWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 10 Oct 2008 00:04:19 +0000 (00:04 +0000)]
2008-10-09  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Darin Adler.

        More testcases for animation using font metrics
        https://bugs.webkit.org/show_bug.cgi?id=21246

        * animations/font-size-using-ems-expected.txt: Added.
        * animations/font-size-using-ems.html: Added.
        * animations/width-using-ems-expected.txt: Added.
        * animations/width-using-ems.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 9 Oct 2008 23:59:49 +0000 (23:59 +0000)]
2008-10-09  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
        Animations assert when navigating from page

        Changed assertions to test the right flag for the paused state

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Thu, 9 Oct 2008 23:59:26 +0000 (23:59 +0000)]
JavaScriptCore:

2008-10-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Cameron Zwarich.

        Fix for bug #21160, x=0;1/(x*-1) == -Infinity

        * ChangeLog:
        * VM/CTI.cpp:
        (JSC::CTI::emitFastArithDeTagImmediate):
        (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::CTI::compileBinaryArithOp):
        (JSC::CTI::compileBinaryArithOpSlowCase):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        * VM/CTI.h:
        * masm/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::emitUnlinkedJs):

LayoutTests:

2008-10-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Cameron Zwarich.

        Correct results for -0 cases.

        * fast/js/math-transforms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fixes.
kevino@webkit.org [Thu, 9 Oct 2008 23:44:40 +0000 (23:44 +0000)]
wx build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 9 Oct 2008 23:04:07 +0000 (23:04 +0000)]
2008-10-09  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dan Bernstein.

        Fixed > 180 degree rotation bug
        Ensure that validateTransformFunctionList() is called after updating keyframe styles

        https://bugs.webkit.org/show_bug.cgi?id=21420

        Test: animations/big-rotation.html

        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::KeyframeAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 9 Oct 2008 21:47:31 +0000 (21:47 +0000)]
2008-10-09  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Oliver Hunt.

        Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
        <https://bugs.webkit.org/show_bug.cgi?id=21459>

        After r37324, an Arguments object does not mark an associated activation
        object. This change was made because Arguments no longer directly used
        the activation object in any way. However, if an activation is torn off,
        then the backing store of Arguments becomes the register array of the
        activation object. Arguments directly marks all of the arguments, but
        the activation object is being collected, which causes its register
        array to be freed and new memory to be allocated in its place.

        Unfortunately, it does not seem possible to reproduce this issue in a
        layout test.

        * kjs/Arguments.cpp:
        (JSC::Arguments::mark):
        * kjs/Arguments.h:
        (JSC::Arguments::setActivation):
        (JSC::Arguments::Arguments):
        (JSC::JSActivation::copyRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 9 Oct 2008 20:43:24 +0000 (20:43 +0000)]
2008-10-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things

        The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page,
          so perform a second null check on the page.  Bail if it has been cleared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 9 Oct 2008 16:21:43 +0000 (16:21 +0000)]
2008-10-09  Alp Toker  <alp@nuanti.com>

        Build fix for recent DOM generation Makefile changes when custom
        CFLAGS/CXXFLAGS are passed in.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>
alp@webkit.org [Thu, 9 Oct 2008 16:13:53 +0000 (16:13 +0000)]
2008-10-09  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=21390
        [Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformRemoveChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 9 Oct 2008 14:26:27 +0000 (14:26 +0000)]
2008-10-09  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Build fix for MinGW.

        * wtf/AlwaysInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 9 Oct 2008 08:37:04 +0000 (08:37 +0000)]
2008-10-09  Darin Adler  <darin@apple.com>

       - try to fix Qt build

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-09 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 9 Oct 2008 07:25:46 +0000 (07:25 +0000)]
2008-10-09  Darin Adler  <darin@apple.com>

        - checked in a missing expected result

        * fast/dom/css-RGBValue-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove restriction on version number ending in a 4.
mrowe@apple.com [Thu, 9 Oct 2008 05:36:02 +0000 (05:36 +0000)]
Remove restriction on version number ending in a 4.

Rubber-stamped by Jon Honeycutt.

* win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 9 Oct 2008 05:30:22 +0000 (05:30 +0000)]
2008-10-08  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak.

        Bug 21497: REGRESSION (r37433): Bytecode JSC tests are severely broken
        <https://bugs.webkit.org/show_bug.cgi?id=21497>

        Fix a typo in r37433 that causes the failure of a large number of JSC
        tests with the bytecode interpreter enabled.

        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Windows build after r37434.
mrowe@apple.com [Thu, 9 Oct 2008 05:19:36 +0000 (05:19 +0000)]
Fix the Windows build after r37434.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Update code to approximate valid C++ syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add SVGElementInstance to the list of exceptions that have
timothy@apple.com [Thu, 9 Oct 2008 04:34:27 +0000 (04:34 +0000)]
    Add SVGElementInstance to the list of exceptions that have
        global initializers in debug builds.

        Rubber-stamped by Mark Rowe.

        * Scripts/check-for-global-initializers: Add SVGElementInstance.o.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
mrowe@apple.com [Thu, 9 Oct 2008 04:05:45 +0000 (04:05 +0000)]
Windows build fix.

* VM/CTI.cpp:
(JSC::): Update type of argument to ctiTrampoline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect MIME types
mitz@apple.com [Thu, 9 Oct 2008 03:57:35 +0000 (03:57 +0000)]
Correct MIME types

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix Sams name :-)
zimmermann@webkit.org [Thu, 9 Oct 2008 03:54:25 +0000 (03:54 +0000)]
Not reviewed. Fix Sams name :-)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Oliver Hunt & Sam Weining.
zimmermann@webkit.org [Thu, 9 Oct 2008 03:34:43 +0000 (03:34 +0000)]
Reviewed by Oliver Hunt & Sam Weining.

 Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
 Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)

 Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
 Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
 use tree is rebuild.

 Make SVGElementInstance a real EventTarget, as the SVG specification demands.
 When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
 is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
 share an event listener list. Every event listener change on the SVGElementInstance object is forwared
 to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
 Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
 to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
 Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.

 Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
 see resources/use-instanceRoot-event-bubbling.js for details.

 Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
        svg/custom/use-elementInstance-methods.svg (reenabled)
        svg/custom/use-setAttribute-crash.svg (covers bug 20550)
        svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
        svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
        svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 9 Oct 2008 00:45:48 +0000 (00:45 +0000)]
2008-10-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        Avoid disconnect between DRT and run-webkit-tests
        about whether to expect PNG dumps by having DRT always
        print two blocks terminated by #EOF, the second of which
        may be empty.

        https://bugs.webkit.org/show_bug.cgi?id=21483

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (printPNG):
        (dumpWebViewAsPixelsAndCompareWithExpected):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dump):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Thu, 9 Oct 2008 00:40:43 +0000 (00:40 +0000)]
JavaScriptCore:

2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
        client over to the new name.

        Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
        as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
        accessor functions to get at things in the frame.

        Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
        JSGlobalData* and in other cases eliminating them entirely.

        * API/JSObjectRef.cpp:
        (JSObjectMakeFunctionWithCallback):
        (JSObjectMakeFunction):
        (JSObjectHasProperty):
        (JSObjectGetProperty):
        (JSObjectSetProperty):
        (JSObjectDeleteProperty):
        * API/OpaqueJSString.cpp:
        * API/OpaqueJSString.h:
        * VM/CTI.cpp:
        (JSC::CTI::getConstant):
        (JSC::CTI::emitGetArg):
        (JSC::CTI::emitGetPutArg):
        (JSC::CTI::getConstantImmediateNumericArg):
        (JSC::CTI::printOpcodeOperandTypes):
        (JSC::CTI::CTI):
        (JSC::CTI::compileOpCall):
        (JSC::CTI::compileBinaryArithOp):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompile):
        (JSC::CTI::privateCompileGetByIdProto):
        (JSC::CTI::privateCompileGetByIdChain):
        (JSC::CTI::compileRegExp):
        * VM/CTI.h:
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitEqualityOp):
        (JSC::CodeGenerator::emitLoad):
        (JSC::CodeGenerator::emitUnexpectedLoad):
        (JSC::CodeGenerator::emitConstruct):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::jsLess):
        (JSC::jsLessEq):
        (JSC::jsAddSlowCase):
        (JSC::jsAdd):
        (JSC::jsTypeStringForValue):
        (JSC::Machine::resolve):
        (JSC::Machine::resolveSkip):
        (JSC::Machine::resolveGlobal):
        (JSC::inlineResolveBase):
        (JSC::Machine::resolveBase):
        (JSC::Machine::resolveBaseAndProperty):
        (JSC::Machine::resolveBaseAndFunc):
        (JSC::Machine::slideRegisterWindowForCall):
        (JSC::isNotObject):
        (JSC::Machine::callEval):
        (JSC::Machine::dumpCallFrame):
        (JSC::Machine::dumpRegisters):
        (JSC::Machine::unwindCallFrame):
        (JSC::Machine::throwException):
        (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
        (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
        (JSC::Machine::execute):
        (JSC::Machine::debug):
        (JSC::Machine::createExceptionScope):
        (JSC::cachePrototypeChain):
        (JSC::Machine::tryCachePutByID):
        (JSC::Machine::tryCacheGetByID):
        (JSC::Machine::privateExecute):
        (JSC::Machine::retrieveArguments):
        (JSC::Machine::retrieveCaller):
        (JSC::Machine::retrieveLastCaller):
        (JSC::Machine::findFunctionCallFrame):
        (JSC::Machine::getArgumentsData):
        (JSC::Machine::tryCTICachePutByID):
        (JSC::Machine::getCTIArrayLengthTrampoline):
        (JSC::Machine::getCTIStringLengthTrampoline):
        (JSC::Machine::tryCTICacheGetByID):
        (JSC::Machine::cti_op_convert_this):
        (JSC::Machine::cti_op_end):
        (JSC::Machine::cti_op_add):
        (JSC::Machine::cti_op_pre_inc):
        (JSC::Machine::cti_timeout_check):
        (JSC::Machine::cti_op_loop_if_less):
        (JSC::Machine::cti_op_loop_if_lesseq):
        (JSC::Machine::cti_op_new_object):
        (JSC::Machine::cti_op_put_by_id):
        (JSC::Machine::cti_op_put_by_id_second):
        (JSC::Machine::cti_op_put_by_id_generic):
        (JSC::Machine::cti_op_put_by_id_fail):
        (JSC::Machine::cti_op_get_by_id):
        (JSC::Machine::cti_op_get_by_id_second):
        (JSC::Machine::cti_op_get_by_id_generic):
        (JSC::Machine::cti_op_get_by_id_fail):
        (JSC::Machine::cti_op_instanceof):
        (JSC::Machine::cti_op_del_by_id):
        (JSC::Machine::cti_op_mul):
        (JSC::Machine::cti_op_new_func):
        (JSC::Machine::cti_op_call_JSFunction):
        (JSC::Machine::cti_vm_compile):
        (JSC::Machine::cti_op_push_activation):
        (JSC::Machine::cti_op_call_NotJSFunction):
        (JSC::Machine::cti_op_create_arguments):
        (JSC::Machine::cti_op_tear_off_activation):
        (JSC::Machine::cti_op_tear_off_arguments):
        (JSC::Machine::cti_op_ret_profiler):
        (JSC::Machine::cti_op_ret_scopeChain):
        (JSC::Machine::cti_op_new_array):
        (JSC::Machine::cti_op_resolve):
        (JSC::Machine::cti_op_construct_JSConstruct):
        (JSC::Machine::cti_op_construct_NotJSConstruct):
        (JSC::Machine::cti_op_get_by_val):
        (JSC::Machine::cti_op_resolve_func):
        (JSC::Machine::cti_op_sub):
        (JSC::Machine::cti_op_put_by_val):
        (JSC::Machine::cti_op_put_by_val_array):
        (JSC::Machine::cti_op_lesseq):
        (JSC::Machine::cti_op_loop_if_true):
        (JSC::Machine::cti_op_negate):
        (JSC::Machine::cti_op_resolve_base):
        (JSC::Machine::cti_op_resolve_skip):
        (JSC::Machine::cti_op_resolve_global):
        (JSC::Machine::cti_op_div):
        (JSC::Machine::cti_op_pre_dec):
        (JSC::Machine::cti_op_jless):
        (JSC::Machine::cti_op_not):
        (JSC::Machine::cti_op_jtrue):
        (JSC::Machine::cti_op_post_inc):
        (JSC::Machine::cti_op_eq):
        (JSC::Machine::cti_op_lshift):
        (JSC::Machine::cti_op_bitand):
        (JSC::Machine::cti_op_rshift):
        (JSC::Machine::cti_op_bitnot):
        (JSC::Machine::cti_op_resolve_with_base):
        (JSC::Machine::cti_op_new_func_exp):
        (JSC::Machine::cti_op_mod):
        (JSC::Machine::cti_op_less):
        (JSC::Machine::cti_op_neq):
        (JSC::Machine::cti_op_post_dec):
        (JSC::Machine::cti_op_urshift):
        (JSC::Machine::cti_op_bitxor):
        (JSC::Machine::cti_op_new_regexp):
        (JSC::Machine::cti_op_bitor):
        (JSC::Machine::cti_op_call_eval):
        (JSC::Machine::cti_op_throw):
        (JSC::Machine::cti_op_get_pnames):
        (JSC::Machine::cti_op_next_pname):
        (JSC::Machine::cti_op_push_scope):
        (JSC::Machine::cti_op_pop_scope):
        (JSC::Machine::cti_op_typeof):
        (JSC::Machine::cti_op_to_jsnumber):
        (JSC::Machine::cti_op_in):
        (JSC::Machine::cti_op_push_new_scope):
        (JSC::Machine::cti_op_jmp_scopes):
        (JSC::Machine::cti_op_put_by_index):
        (JSC::Machine::cti_op_switch_imm):
        (JSC::Machine::cti_op_switch_char):
        (JSC::Machine::cti_op_switch_string):
        (JSC::Machine::cti_op_del_by_val):
        (JSC::Machine::cti_op_put_getter):
        (JSC::Machine::cti_op_put_setter):
        (JSC::Machine::cti_op_new_error):
        (JSC::Machine::cti_op_debug):
        (JSC::Machine::cti_vm_throw):
        * VM/Machine.h:
        * VM/Register.h:
        * VM/RegisterFile.h:
        * kjs/Arguments.h:
        * kjs/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::functionName):
        (JSC::DebuggerCallFrame::type):
        (JSC::DebuggerCallFrame::thisObject):
        (JSC::DebuggerCallFrame::evaluate):
        * kjs/DebuggerCallFrame.h:
        * kjs/ExecState.cpp:
        (JSC::CallFrame::thisValue):
        * kjs/ExecState.h:
        * kjs/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * kjs/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        (JSC::JSActivation::argumentsGetter):
        * kjs/JSActivation.h:
        * kjs/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * kjs/JSVariableObject.h:
        * kjs/Parser.cpp:
        (JSC::Parser::parse):
        * kjs/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * kjs/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncCompile):
        * kjs/Shell.cpp:
        (prettyPrintScript):
        * kjs/StringPrototype.cpp:
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        * kjs/identifier.cpp:
        (JSC::Identifier::checkSameIdentifierTable):
        * kjs/interpreter.cpp:
        (JSC::Interpreter::checkSyntax):
        (JSC::Interpreter::evaluate):
        * kjs/nodes.cpp:
        (JSC::ThrowableExpressionData::emitThrowError):
        (JSC::RegExpNode::emitCode):
        (JSC::ArrayNode::emitCode):
        (JSC::InstanceOfNode::emitCode):
        * kjs/nodes.h:
        * kjs/regexp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::create):
        * kjs/regexp.h:
        * profiler/HeavyProfile.h:
        * profiler/Profile.h:
        * wrec/WREC.cpp:
        * wrec/WREC.h:

WebKit/mac:

2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Thu, 9 Oct 2008 00:14:50 +0000 (00:14 +0000)]
WebCore:

2008-10-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
        REGRESSION (r36977): getRGBColorValue().red returning incorrect value

        Update JSRGBColor to use the new static function per getter approach.

        Test: fast/dom/css-RGBValue.html

        * bindings/js/JSRGBColor.cpp:
        (WebCore::):
        (jsRGBColorRed):
        (jsRGBColorGreen):
        (jsRGBColorBlue):
        * bindings/js/JSRGBColor.h:

LayoutTests:

2008-10-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Test for https://bugs.webkit.org/show_bug.cgi?id=21241
        REGRESSION (r36977): getRGBColorValue().red returning incorrect value

        * fast/dom/css-RGBValue.html: Added.
        * fast/dom/resources/css-RGBValue.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
eric@webkit.org [Wed, 8 Oct 2008 22:48:55 +0000 (22:48 +0000)]
    Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.

        svgElement.className.baseValue = "foo" does not work
        https://bugs.webkit.org/show_bug.cgi?id=20651

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::classAttributeChanged):
        (WebCore::StyledElement::parseMappedAttribute):
        * dom/StyledElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crash in fast/js/constant-folding.html with CTI disabled.
mrowe@apple.com [Wed, 8 Oct 2008 22:38:44 +0000 (22:38 +0000)]
Fix crash in fast/js/constant-folding.html with CTI disabled.

Typed by Maciej Stachowiak, reviewed by Mark Rowe.

* VM/Machine.cpp:
(JSC::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 8 Oct 2008 20:30:04 +0000 (20:30 +0000)]
2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed, trying to fix bot.

        Update -0 expectations better.

        * fast/xpath/4XPath/Core/test_numeric_expr-expected.txt:
        * fast/xpath/4XPath/Core/test_numeric_expr.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out r37427 because it causes an infinite recursion loading about:blank.
timothy@apple.com [Wed, 8 Oct 2008 17:50:42 +0000 (17:50 +0000)]
Roll out r37427 because it causes an infinite recursion loading about:blank.

https://bugs.webkit.org/show_bug.cgi?id=21476

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Wed, 8 Oct 2008 17:03:10 +0000 (17:03 +0000)]
JavaScriptCore:

2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
        client over to the new name.

        Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
        as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
        accessor functions to get at things in the frame.

        Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
        JSGlobalData* and in other cases eliminating them entirely.

        * API/JSObjectRef.cpp:
        (JSObjectMakeFunctionWithCallback):
        (JSObjectMakeFunction):
        (JSObjectHasProperty):
        (JSObjectGetProperty):
        (JSObjectSetProperty):
        (JSObjectDeleteProperty):
        * API/OpaqueJSString.cpp:
        * API/OpaqueJSString.h:
        * VM/CTI.cpp:
        (JSC::CTI::getConstant):
        (JSC::CTI::emitGetArg):
        (JSC::CTI::emitGetPutArg):
        (JSC::CTI::getConstantImmediateNumericArg):
        (JSC::CTI::printOpcodeOperandTypes):
        (JSC::CTI::CTI):
        (JSC::CTI::compileOpCall):
        (JSC::CTI::compileBinaryArithOp):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompile):
        (JSC::CTI::privateCompileGetByIdProto):
        (JSC::CTI::privateCompileGetByIdChain):
        (JSC::CTI::compileRegExp):
        * VM/CTI.h:
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitEqualityOp):
        (JSC::CodeGenerator::emitLoad):
        (JSC::CodeGenerator::emitUnexpectedLoad):
        (JSC::CodeGenerator::emitConstruct):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::jsLess):
        (JSC::jsLessEq):
        (JSC::jsAddSlowCase):
        (JSC::jsAdd):
        (JSC::jsTypeStringForValue):
        (JSC::Machine::resolve):
        (JSC::Machine::resolveSkip):
        (JSC::Machine::resolveGlobal):
        (JSC::inlineResolveBase):
        (JSC::Machine::resolveBase):
        (JSC::Machine::resolveBaseAndProperty):
        (JSC::Machine::resolveBaseAndFunc):
        (JSC::Machine::slideRegisterWindowForCall):
        (JSC::isNotObject):
        (JSC::Machine::callEval):
        (JSC::Machine::dumpCallFrame):
        (JSC::Machine::dumpRegisters):
        (JSC::Machine::unwindCallFrame):
        (JSC::Machine::throwException):
        (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
        (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
        (JSC::Machine::execute):
        (JSC::Machine::debug):
        (JSC::Machine::createExceptionScope):
        (JSC::cachePrototypeChain):
        (JSC::Machine::tryCachePutByID):
        (JSC::Machine::tryCacheGetByID):
        (JSC::Machine::privateExecute):
        (JSC::Machine::retrieveArguments):
        (JSC::Machine::retrieveCaller):
        (JSC::Machine::retrieveLastCaller):
        (JSC::Machine::findFunctionCallFrame):
        (JSC::Machine::getArgumentsData):
        (JSC::Machine::tryCTICachePutByID):
        (JSC::Machine::getCTIArrayLengthTrampoline):
        (JSC::Machine::getCTIStringLengthTrampoline):
        (JSC::Machine::tryCTICacheGetByID):
        (JSC::Machine::cti_op_convert_this):
        (JSC::Machine::cti_op_end):
        (JSC::Machine::cti_op_add):
        (JSC::Machine::cti_op_pre_inc):
        (JSC::Machine::cti_timeout_check):
        (JSC::Machine::cti_op_loop_if_less):
        (JSC::Machine::cti_op_loop_if_lesseq):
        (JSC::Machine::cti_op_new_object):
        (JSC::Machine::cti_op_put_by_id):
        (JSC::Machine::cti_op_put_by_id_second):
        (JSC::Machine::cti_op_put_by_id_generic):
        (JSC::Machine::cti_op_put_by_id_fail):
        (JSC::Machine::cti_op_get_by_id):
        (JSC::Machine::cti_op_get_by_id_second):
        (JSC::Machine::cti_op_get_by_id_generic):
        (JSC::Machine::cti_op_get_by_id_fail):
        (JSC::Machine::cti_op_instanceof):
        (JSC::Machine::cti_op_del_by_id):
        (JSC::Machine::cti_op_mul):
        (JSC::Machine::cti_op_new_func):
        (JSC::Machine::cti_op_call_JSFunction):
        (JSC::Machine::cti_vm_compile):
        (JSC::Machine::cti_op_push_activation):
        (JSC::Machine::cti_op_call_NotJSFunction):
        (JSC::Machine::cti_op_create_arguments):
        (JSC::Machine::cti_op_tear_off_activation):
        (JSC::Machine::cti_op_tear_off_arguments):
        (JSC::Machine::cti_op_ret_profiler):
        (JSC::Machine::cti_op_ret_scopeChain):
        (JSC::Machine::cti_op_new_array):
        (JSC::Machine::cti_op_resolve):
        (JSC::Machine::cti_op_construct_JSConstruct):
        (JSC::Machine::cti_op_construct_NotJSConstruct):
        (JSC::Machine::cti_op_get_by_val):
        (JSC::Machine::cti_op_resolve_func):
        (JSC::Machine::cti_op_sub):
        (JSC::Machine::cti_op_put_by_val):
        (JSC::Machine::cti_op_put_by_val_array):
        (JSC::Machine::cti_op_lesseq):
        (JSC::Machine::cti_op_loop_if_true):
        (JSC::Machine::cti_op_negate):
        (JSC::Machine::cti_op_resolve_base):
        (JSC::Machine::cti_op_resolve_skip):
        (JSC::Machine::cti_op_resolve_global):
        (JSC::Machine::cti_op_div):
        (JSC::Machine::cti_op_pre_dec):
        (JSC::Machine::cti_op_jless):
        (JSC::Machine::cti_op_not):
        (JSC::Machine::cti_op_jtrue):
        (JSC::Machine::cti_op_post_inc):
        (JSC::Machine::cti_op_eq):
        (JSC::Machine::cti_op_lshift):
        (JSC::Machine::cti_op_bitand):
        (JSC::Machine::cti_op_rshift):
        (JSC::Machine::cti_op_bitnot):
        (JSC::Machine::cti_op_resolve_with_base):
        (JSC::Machine::cti_op_new_func_exp):
        (JSC::Machine::cti_op_mod):
        (JSC::Machine::cti_op_less):
        (JSC::Machine::cti_op_neq):
        (JSC::Machine::cti_op_post_dec):
        (JSC::Machine::cti_op_urshift):
        (JSC::Machine::cti_op_bitxor):
        (JSC::Machine::cti_op_new_regexp):
        (JSC::Machine::cti_op_bitor):
        (JSC::Machine::cti_op_call_eval):
        (JSC::Machine::cti_op_throw):
        (JSC::Machine::cti_op_get_pnames):
        (JSC::Machine::cti_op_next_pname):
        (JSC::Machine::cti_op_push_scope):
        (JSC::Machine::cti_op_pop_scope):
        (JSC::Machine::cti_op_typeof):
        (JSC::Machine::cti_op_to_jsnumber):
        (JSC::Machine::cti_op_in):
        (JSC::Machine::cti_op_push_new_scope):
        (JSC::Machine::cti_op_jmp_scopes):
        (JSC::Machine::cti_op_put_by_index):
        (JSC::Machine::cti_op_switch_imm):
        (JSC::Machine::cti_op_switch_char):
        (JSC::Machine::cti_op_switch_string):
        (JSC::Machine::cti_op_del_by_val):
        (JSC::Machine::cti_op_put_getter):
        (JSC::Machine::cti_op_put_setter):
        (JSC::Machine::cti_op_new_error):
        (JSC::Machine::cti_op_debug):
        (JSC::Machine::cti_vm_throw):
        * VM/Machine.h:
        * VM/Register.h:
        * VM/RegisterFile.h:
        * kjs/Arguments.h:
        * kjs/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::functionName):
        (JSC::DebuggerCallFrame::type):
        (JSC::DebuggerCallFrame::thisObject):
        (JSC::DebuggerCallFrame::evaluate):
        * kjs/DebuggerCallFrame.h:
        * kjs/ExecState.cpp:
        (JSC::CallFrame::thisValue):
        * kjs/ExecState.h:
        * kjs/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * kjs/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        (JSC::JSActivation::argumentsGetter):
        * kjs/JSActivation.h:
        * kjs/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * kjs/JSVariableObject.h:
        * kjs/Parser.cpp:
        (JSC::Parser::parse):
        * kjs/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * kjs/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncCompile):
        * kjs/Shell.cpp:
        (prettyPrintScript):
        * kjs/StringPrototype.cpp:
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        * kjs/identifier.cpp:
        (JSC::Identifier::checkSameIdentifierTable):
        * kjs/interpreter.cpp:
        (JSC::Interpreter::checkSyntax):
        (JSC::Interpreter::evaluate):
        * kjs/nodes.cpp:
        (JSC::ThrowableExpressionData::emitThrowError):
        (JSC::RegExpNode::emitCode):
        (JSC::ArrayNode::emitCode):
        (JSC::InstanceOfNode::emitCode):
        * kjs/nodes.h:
        * kjs/regexp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::create):
        * kjs/regexp.h:
        * profiler/HeavyProfile.h:
        * profiler/Profile.h:
        * wrec/WREC.cpp:
        * wrec/WREC.h:

WebKit/mac:

2008-10-08  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21403
          Bug 21403: use new CallFrame class rather than Register* for call frame manipulation

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make the toolbar label text-shadow not disappear when clicking on the
timothy@apple.com [Wed, 8 Oct 2008 16:41:15 +0000 (16:41 +0000)]
    Make the toolbar label text-shadow not disappear when clicking on the
        search result count or around the search field.

        Reviewed by Timothy Hatcher.

        * inspector/front-end/inspector.css:
        (.toolbar-item:active .toolbar-label): Make this rule also require the
        toggleable class with the toolbar-item class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Matthias Ettrich <ettrich@nokia.com>
hausmann@webkit.org [Wed, 8 Oct 2008 13:30:07 +0000 (13:30 +0000)]
2008-10-08  Matthias Ettrich <ettrich@nokia.com>

        Reviewed by Simon.

        Make QWebView ignore focus changes with PopupFocusReason to avoid
        massive updates when menus open and close.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 13:13:24 +0000 (13:13 +0000)]
2008-10-08  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Updated the qrc file for the Web Inspector to contain the current set
        of images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 12:43:13 +0000 (12:43 +0000)]
2008-10-08  Prasanth Ullattil  <pullatti@trolltech.com>

        Reviewed by Simon.

        Fix the linking of applications against WebKit on Qt/Windows.

        The prl files that qmake creates are buggy on Unix, but we they're
        fine on Windows and we have to have them there in order to get the
        dependencies correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 12:20:41 +0000 (12:20 +0000)]
2008-10-08  Prasanth Ullattil  <pullatti@trolltech.com>

        Reviewed by Oliver Hunt.

        Avoid endless loops when compiling without the computed goto
        optimization.

        NEXT_OPCODE expands to "continue", which will not work inside
        loops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 12:11:44 +0000 (12:11 +0000)]
2008-10-08  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Speed up rectangle filling by not re-creating a QBrush all the time.

        This triggers faster path in QPainter where the brush is reused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Kavindra Palaraja <kdpalara@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 12:08:47 +0000 (12:08 +0000)]
2008-10-08  Kavindra Palaraja  <kdpalara@trolltech.com>

        Reviewed by Simon.

        Fixed a qdoc warning and adjusted some spacing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 8 Oct 2008 11:33:16 +0000 (11:33 +0000)]
2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - update for new -0 handling in shouldBe

        (I confirmed the correctness of this change against other browsers, too.)

        * fast/xpath/4XPath/Core/test_numeric_expr.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 8 Oct 2008 11:01:37 +0000 (11:01 +0000)]
2008-10-08  Dean Jackson  <dino@apple.com>

        Forgot to set the date on the spec documents with last commit.

        * CSSAnimations.html:
        * CSSTransforms.html:
        * CSSTransitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 8 Oct 2008 10:53:13 +0000 (10:53 +0000)]
2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        Re-landing the following fix with the crashing bug in it fixed (r37405):

        - optimize away multiplication by constant 1.0

        2.3% speedup on v8 RayTrace benchmark

        Apparently it's not uncommon for JavaScript code to multiply by
        constant 1.0 in the mistaken belief that this converts integer to
        floating point and that there is any operational difference.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for
        case where parameter is already number.
        (JSC::CTI::privateCompileSlowCases): ditto
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): ditto
        * kjs/grammar.y:
        (makeMultNode): Transform as follows:
        +FOO * BAR ==> FOO * BAR
        FOO * +BAR ==> FOO * BAR
        FOO * 1 ==> +FOO
        1 * FOO ==> +FOO
        (makeDivNode): Transform as follows:
        +FOO / BAR ==> FOO / BAR
        FOO / +BAR ==> FOO / BAR
        (makeSubNode): Transform as follows:
        +FOO - BAR ==> FOO - BAR
        FOO - +BAR ==> FOO - BAR
        * kjs/nodes.h:
        (JSC::ExpressionNode::stripUnaryPlus): Helper for above
        grammar.y changes
        (JSC::UnaryPlusNode::stripUnaryPlus): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 8 Oct 2008 10:27:08 +0000 (10:27 +0000)]
2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - update regression testing system to be able to tell 0 from -0

        * fast/js/resources/js-test-pre.js:

        Update tests and results appropriately.

        * fast/js/resources/constant-folding.js:
        * fast/js/constant-folding-expected.txt:
        * fast/js/math-transforms-expected.txt:
        * fast/js/resources/math-transforms.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
mjs@apple.com [Wed, 8 Oct 2008 09:18:08 +0000 (09:18 +0000)]
JavaScriptCore:

2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - correctly handle appending -0 to a string, it should stringify as just 0

        * kjs/ustring.cpp:
        (JSC::concatenate):

LayoutTests:

2008-10-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - added test case for: correctly handle appending -0 to a string, it should stringify as just 0
        (added to existing test)

        * fast/js/number-toString-expected.txt:
        * fast/js/resources/number-toString.js:

        - updated results in light of above fix

        * fast/js/math-transforms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Wed, 8 Oct 2008 09:10:44 +0000 (09:10 +0000)]
2008-10-08  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon.

        Fixes: Encoding of Qt URLs

        This encoding was added by Simon and I because QUrl's
        tolerant parser wasn't tolerant enough. Now it is, so we don't need
        this anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-10-08 Marius Storm-Olsen <marius@trolltech.com>
hausmann@webkit.org [Wed, 8 Oct 2008 09:10:32 +0000 (09:10 +0000)]
2008-10-08  Marius Storm-Olsen  <marius@trolltech.com>

        Reviewed by Simon.

        Fixes dependencies in qmake generated visual studio projects.

        Only add debug lib name if we're in the debug build_pass, else the release version.
        The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37413 268f45cc-cd09-0410-ab3c-d52691b4dbfc