WebKit-https.git
8 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Mar 2011 23:07:48 +0000 (23:07 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed a leak seen on the buildbot.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow passing a certificate chain as a user message
weinig@apple.com [Thu, 17 Mar 2011 23:07:14 +0000 (23:07 +0000)]
Allow passing a certificate chain as a user message
<rdar://problem/8951709>
https://bugs.webkit.org/show_bug.cgi?id=56605

Reviewed by Brady Eidson.

* Shared/API/c/mac/WKCertificateInfoMac.h:
* Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBlob URL should not be allow to get created from the code running from data URI
jianli@chromium.org [Thu, 17 Mar 2011 23:06:55 +0000 (23:06 +0000)]
Blob URL should not be allow to get created from the code running from data URI
https://bugs.webkit.org/show_bug.cgi?id=56600

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/fileapi/create-blob-url-from-data-url.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURI):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):

LayoutTests:

* http/tests/fileapi/create-blob-url-from-data-url-expected.txt: Added.
* http/tests/fileapi/create-blob-url-from-data-url.html: Added.
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix clang build.
andersca@apple.com [Thu, 17 Mar 2011 22:29:16 +0000 (22:29 +0000)]
Fix clang build.

Reviewed by Geoffrey Garen.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 22:21:19 +0000 (22:21 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Skip an editing test that hits assertion on non-Mac platforms.
        The bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=56599.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 22:18:24 +0000 (22:18 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80064.
        http://trac.webkit.org/changeset/80064
        https://bugs.webkit.org/show_bug.cgi?id=56588

        the original test was correct (Requested by rniwa on #webkit).

        * platform/mac/editing/input/selection-change-closes-typing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 17 Mar 2011 22:17:17 +0000 (22:17 +0000)]
2011-03-17  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Turn off accelerated compositing for RTL style pages.
        https://bugs.webkit.org/show_bug.cgi?id=56585

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::layout):
        (WebKit::WebViewImpl::pageHasRTLStyle):
        (WebKit::WebViewImpl::setRootGraphicsLayer):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Mar 2011 22:15:37 +0000 (22:15 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        1 Structure leaked beneath JSGlobalData::storeVPtrs()
        https://bugs.webkit.org/show_bug.cgi?id=56595

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need
        to explicitly run its destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Thu, 17 Mar 2011 22:14:15 +0000 (22:14 +0000)]
2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Videos look ugly when using QGraphicsWebView.
        https://bugs.webkit.org/show_bug.cgi?id=56580

        We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
        QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
        by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
        QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
        ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
        in addition of what could be set on the painter. In order to not break the rendering of all the items in the
        scene we set back the painter to its original state when QGraphicsWebView is rendered.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
        (QGraphicsWebView::paint):
        (QGraphicsWebView::renderHints):
        (QGraphicsWebView::setRenderHints):
        (QGraphicsWebView::setRenderHint):
        * Api/qgraphicswebview.h:
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::renderHints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Mar 2011 22:04:35 +0000 (22:04 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add PluginProcessShim hooks for when windows are shown and hidden
        https://bugs.webkit.org/show_bug.cgi?id=56597

        * Configurations/PluginProcessShim.xcconfig:
        Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::cocoaWindowShown):
        (WebKit::cocoaWindowHidden):
        (WebKit::carbonWindowShown):
        (WebKit::carbonWindowHidden):
        (WebKit::setModal):
        (WebKit::PluginProcess::initializeShim):
        Add empty stubs.

        * PluginProcess/mac/PluginProcessShim.h:
        * PluginProcess/mac/PluginProcessShim.mm:
        (WebKit::beginModal):
        (WebKit::endModal):
        Keep a modal count and call setModal accordingly.

        (WebKit::shim_NSApplication_RunModalForWindow):
        (WebKit::shimModalDialog):
        (WebKit::shimAlert):
        Call beginModal/endModal.

        (WebKit::shimShowWindow):
        (WebKit::shimHideWindow):
        Call the shim functions.

        (WebKit::WebKitPluginProcessShimInitialize):
        Listen for notifications and call the necessary shim functions.

        * WebKit2.xcodeproj/project.pbxproj:
        Link the plug-in process shim with AppKit and QuartzCore and WKSI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable http/tests/inspector/network tests
aroben@apple.com [Thu, 17 Mar 2011 22:02:05 +0000 (22:02 +0000)]
Disable http/tests/inspector/network tests

They are known to be flaky. <http://webkit.org/b/56578> tracks the issue.

* http/tests/inspector/network/network-size.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-size.html.
* http/tests/inspector/network/network-timing.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html.

* platform/mac/Skipped: Removed a now-disabled test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStart using PlatformSpecificScheduler for the Mac builders
aroben@apple.com [Thu, 17 Mar 2011 22:00:24 +0000 (22:00 +0000)]
Start using PlatformSpecificScheduler for the Mac builders

The current set of file/directory patterns should work for Mac builders. We may discover
that there are more files and directories we can exclude from the Mac builds, but they can
be added later.

Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
cleaned up patterns a little bit.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Fixed some expected results.
(ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse a consistent set of file patterns in the svn:ignore property for all .xcodeproj...
jeffm@apple.com [Thu, 17 Mar 2011 21:51:06 +0000 (21:51 +0000)]
Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:

*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata

Examples:

* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj: Modified property svn:ignore.

Source/JavaScriptGlue:

* JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj: Modified property svn:ignore.
* src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

* WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

* WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

* DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
* MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
* WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Mac build.
weinig@apple.com [Thu, 17 Mar 2011 21:45:46 +0000 (21:45 +0000)]
Fix Mac build.

* WebCore.exp.in:
Add missing symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKErrors need the PeerCertificateChain for certificate errors
weinig@apple.com [Thu, 17 Mar 2011 21:25:27 +0000 (21:25 +0000)]
WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
https://bugs.webkit.org/show_bug.cgi?id=56592

Reviewed by Anders Carlsson.

* Shared/WebCoreArgumentCoders.h:
Special case encoding/decoding of ResourceErrors for the mac.

* Shared/mac/PlatformCertificateInfo.h:
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on...
aroben@apple.com [Thu, 17 Mar 2011 21:21:08 +0000 (21:21 +0000)]
Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows

Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
mac-wk2

Reviewed by Anders Carlsson.

* Scripts/old-run-webkit-tests:
(expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
we're running in WebKit2 mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WKWindowWillOrderOffScreenNotification.
andersca@apple.com [Thu, 17 Mar 2011 21:03:53 +0000 (21:03 +0000)]
Add WKWindowWillOrderOffScreenNotification.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 20:49:11 +0000 (20:49 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adele Peterson and Enrica Casucci.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Debug build fix.

        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate
        a position inside the node. Call firstPositionInOrBeforeNode instead.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead
        of just when the node is br.
        * editing/htmlediting.cpp:
        (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element
        so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update test_expectations.txt
dimich@chromium.org [Thu, 17 Mar 2011 20:44:51 +0000 (20:44 +0000)]
[Chromium] Unreviewed, update test_expectations.txt

Mark some tests as SLOW in DEBUG since they are on a borderline of shorter timeout.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip a flaky test on Mac
aroben@apple.com [Thu, 17 Mar 2011 20:43:11 +0000 (20:43 +0000)]
Skip a flaky test on Mac

<http://webkit.org/b/56578> tracks the failure.

* platform/mac/Skipped: Added http/tests/inspector/network/network-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip some flaky tests on the SnowLeopard WebKit2 bot
aroben@apple.com [Thu, 17 Mar 2011 20:30:25 +0000 (20:30 +0000)]
Skip some flaky tests on the SnowLeopard WebKit2 bot

Tracked by <http://webkit.org/b/56530> and <http://webkit.org/b/56584>.

* platform/mac-wk2/Skipped: Added http/tests/inspector/resource-har-conversion.html and
inspector/debugger/debug-inlined-scripts.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReverting r81197, breaks JIT + INTERPRETER build.
barraclough@apple.com [Thu, 17 Mar 2011 20:22:10 +0000 (20:22 +0000)]
Reverting r81197, breaks JIT + INTERPRETER build.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):
* bytecode/Opcode.h:
* bytecode/StructureStubInfo.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 20:07:14 +0000 (20:07 +0000)]
2011-03-17  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        Add a COMPILER(SUNCC) define for Sun Studio 12.
        https://bugs.webkit.org/show_bug.cgi?56444
        derived from patch 1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 17 Mar 2011 19:50:50 +0000 (19:50 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 17 Mar 2011 19:49:26 +0000 (19:49 +0000)]
2011-03-17  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Adding a contains method to Vector.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * wtf/Vector.h:
        (WTF::::operator):
        (WTF::::contains):
2011-03-17  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Moving the method that is used to retrieve all the resources in
        a page from the Chromium code (dom_operations.cc) to WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * public/WebURL.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebVector.h:
        (WebKit::WebVector::contains):
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebPageSerializer.cpp:
        (WebCore::getSubResourceURLFromElement):
        (WebCore::retrieveResourcesForElement):
        (WebCore::retrieveResourcesForFrame):
        (WebKit::WebPageSerializer::retrieveAllResources):
        * tests/WebFrameTest.cpp:
        * tests/WebPageSerializerTest.cpp: Added.
        * tests/data/pageserialization: Added.
        * tests/data/pageserialization/awesome.png: Added.
        * tests/data/pageserialization/embed_iframe.html: Added.
        * tests/data/pageserialization/object_iframe.html: Added.
        * tests/data/pageserialization/simple_iframe.html: Added.
        * tests/data/pageserialization/simple_page.html: Added.
        * tests/data/pageserialization/top_frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 17 Mar 2011 19:14:58 +0000 (19:14 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Thu, 17 Mar 2011 19:05:34 +0000 (19:05 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81369.
        http://trac.webkit.org/changeset/81369
        https://bugs.webkit.org/show_bug.cgi?id=56579

        breaks debugger test (Requested by podivilov on #webkit).

        * inspector/debugger/debug-inlined-scripts.html:
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81369.
        http://trac.webkit.org/changeset/81369
        https://bugs.webkit.org/show_bug.cgi?id=56579

        breaks debugger test (Requested by podivilov on #webkit).

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._parsedScriptSource):
        (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource):
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        (WebInspector.ScriptsPanel.prototype._addScript):
        (WebInspector.ScriptsPanel.prototype._resourceForURL):
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 19:02:50 +0000 (19:02 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Added a test to ensure WebKit lets users edit contents inside a button element properly.

        * editing/execCommand/button-expected.txt: Added.
        * editing/execCommand/button.html: Added.
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
        places where we instantiate positions inside a node on which editingIgnoresContent returns true.

        Test: editing/execCommand/button.html

        * dom/Position.cpp:
        (WebCore::Position::Position): Added an assertion.
        (WebCore::Position::moveToPosition): Ditto.
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below
        a node whose content is ignored by editing. While this does not avoid creation of positions
        inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve
        the underlying problem. Without this change, the assertion hits in existing layout tests.
        cannot be tested directly.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode
        instead of firstPositionInNode because startNode may as well be a br element. Without this change,
        the assertion hits in existing layout tests.
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test
        for this.
        * editing/visible_units.cpp:
        (WebCore::previousBoundary): Added a FIXME.
        (WebCore::startPositionForLine): Because br can also have an inline text box, checking that
        startBox is an inline text box isn't an adequate to instantiate a position inside startNode.
        Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout
        tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip three tests that fail on one Windows WebKit2 slave but not the other
aroben@apple.com [Thu, 17 Mar 2011 18:45:12 +0000 (18:45 +0000)]
Skip three tests that fail on one Windows WebKit2 slave but not the other

The failures are tracked by <http://webkit.org/b/56550>.

* platform/win-wk2/Skipped: Added fast/events/tabindex-focus-blur-all.html,
fast/forms/button-align.html, and media/audio-mpeg4-supported.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=56574
sullivan@apple.com [Thu, 17 Mar 2011 18:41:03 +0000 (18:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow

Reviewed by Adam Roben.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename PluginProcessShim.cpp to PluginProcessShim.mm.
andersca@apple.com [Thu, 17 Mar 2011 18:39:32 +0000 (18:39 +0000)]
Rename PluginProcessShim.cpp to PluginProcessShim.mm.

Rubber-stamped by John Sullivan.

* PluginProcess/mac/PluginProcessShim.cpp: Removed.
* PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Mar 2011 18:28:52 +0000 (18:28 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Invalidate all NPObjects for a plug-in when that plug-in is destroyed
        https://bugs.webkit.org/show_bug.cgi?id=56511
        <rdar://problem/8993491>

        Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
        objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
        which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
        tried to invoke it on a already deallocated NPObject.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::initialize):
        If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.

        (WebKit::PluginControllerProxy::destroy):
        Pass the plug-in to removePluginControllerProxy.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::removePluginControllerProxy):
        Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

        (WebKit::WebProcessConnection::createPlugin):
        Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
        takes care of doing this.

        * Shared/Plugins/NPObjectMessageReceiver.cpp:
        (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
        (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
        * Shared/Plugins/NPObjectMessageReceiver.h:
        Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated
        by the time the NPObjectMessageReceiver is destroyed.

        (WebKit::NPObjectMessageReceiver::plugin):
        Add getter.

        * Shared/Plugins/NPObjectProxy.h:
        (WebKit::NPObjectProxy::plugin):
        Add getter.

        * Shared/Plugins/NPRemoteObjectMap.cpp:
        (WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
        Remove m_isInvalidating.

        (WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
        Simplify code.

        (WebKit::NPRemoteObjectMap::pluginDestroyed):
        Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.

        * Shared/Plugins/NPRemoteObjectMap.h:
        Remove m_isInvalidating.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::removePluginProxy):
        Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 17 Mar 2011 18:14:28 +0000 (18:14 +0000)]
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        * inspector/debugger/debug-inlined-scripts.html:
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        Encapsulate source files creation logic in debugger presentation model
        to support source mappings in a pluggable way.

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.sourceFile):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFileChanged):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Mar 2011 18:10:15 +0000 (18:10 +0000)]
2011-03-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add types markup to the IDL, remove Value types from the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=56562

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluate):
        (WebCore::InjectedScript::evaluateOn):
        (WebCore::InjectedScript::evaluateOnCallFrame):
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::setPropertyValue):
        (WebCore::InjectedScript::callFrames):
        (WebCore::InjectedScript::makeCall):
        (WebCore::InjectedScript::makeObjectCall):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.idl:
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
        * inspector/InspectorApplicationCacheAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode):
        (WebCore::InspectorCSSAgent::getInlineStyleForNode):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode):
        (WebCore::InspectorCSSAgent::getStyleSheet):
        (WebCore::InspectorCSSAgent::setPropertyText):
        (WebCore::InspectorCSSAgent::toggleProperty):
        (WebCore::InspectorCSSAgent::setRuleSelector):
        (WebCore::InspectorCSSAgent::addRule):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::buildInspectorArray):
        * inspector/ScriptCallStack.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._createResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochangelog
simonjam@chromium.org [Thu, 17 Mar 2011 18:07:09 +0000 (18:07 +0000)]
changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofirst changes
simonjam@chromium.org [Thu, 17 Mar 2011 18:07:04 +0000 (18:07 +0000)]
first changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 17 Mar 2011 17:53:28 +0000 (17:53 +0000)]
2011-03-17  Tony Chang  <tony@chromium.org>

        Reviewed by Pavel Feldman.

        [chromium] don't concatenate devtools files when debug_devtools=1
        https://bugs.webkit.org/show_bug.cgi?id=56572

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable http/tests/inspector/resource-parameters.html
aroben@apple.com [Thu, 17 Mar 2011 17:35:04 +0000 (17:35 +0000)]
Disable http/tests/inspector/resource-parameters.html

It is flaky. The flakiness is tracked by <http://webkit.org/b/55867>.

* http/tests/inspector/resource-parameters.html-disabled: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html.

* platform/qt/Skipped: Removed the test from this Skipped file since it has been disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Oleg Romashin <oleg.romashin@nokia.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 17:03:07 +0000 (17:03 +0000)]
2011-03-17  Oleg Romashin  <oleg.romashin@nokia.com>

        Reviewed by Anders Carlsson.

        Teach WebKit2 messages.py generator to ifdef headers include
        which are related to ifdef-ed methods/types
        https://bugs.webkit.org/show_bug.cgi?id=55658

        * Scripts/webkit2/messages.py:
        * Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 16:47:24 +0000 (16:47 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81350.
        http://trac.webkit.org/changeset/81350
        https://bugs.webkit.org/show_bug.cgi?id=56560

        "Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
        (Requested by apavlov on #webkit).

        * fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js:
        (shouldBeAround):
        * platform/chromium/test_expectations.txt:
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81350.
        http://trac.webkit.org/changeset/81350
        https://bugs.webkit.org/show_bug.cgi?id=56560

        "Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
        (Requested by apavlov on #webkit).

        * WebCore.gypi:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::State::State):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillPath):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::clipPath):
        (WebCore::GLES2Canvas::restore):
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::drawTexturedRectTile):
        (WebCore::GLES2Canvas::drawQuad):
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/gpu/BicubicShader.cpp: Removed.
        * platform/graphics/gpu/BicubicShader.h: Removed.
        * platform/graphics/gpu/ConvolutionShader.cpp: Removed.
        * platform/graphics/gpu/ConvolutionShader.h: Removed.
        * platform/graphics/gpu/DrawingBuffer.h:
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::create):
        (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::canAccelerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 17 Mar 2011 16:44:58 +0000 (16:44 +0000)]
2011-03-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Web Inspector tests timing out on Windows after r81222
        https://bugs.webkit.org/show_bug.cgi?id=56454

        Remove custom expectations for Chromium tests that consistently pass locally.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip some tests that only fail on apple-macpro-6
aroben@apple.com [Thu, 17 Mar 2011 16:39:57 +0000 (16:39 +0000)]
Skip some tests that only fail on apple-macpro-6

<http://webkit.org/b/56564> tracks the failures.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 17 Mar 2011 16:39:02 +0000 (16:39 +0000)]
2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Clean up Inspector strings.
        https://bugs.webkit.org/show_bug.cgi?id=56557

        * English.lproj/localizedStrings.js:

2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Clean up Inspector strings.
        https://bugs.webkit.org/show_bug.cgi?id=56557

        Modify the script to deal correctly with "\xNN" escapes, and to
        check strings in Chromium's DevTools.js.

        * Scripts/check-inspector-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip a test that is only failing on some Leopard slaves
aroben@apple.com [Thu, 17 Mar 2011 16:38:10 +0000 (16:38 +0000)]
Skip a test that is only failing on some Leopard slaves

svg/text/font-size-below-point-five.svg generates different results on apple-macpro-5 from
the other Leopard slaves. <http://webkit.org/b/56544> tracks this issue.

* platform/mac-leopard/Skipped: Skip svg/text/font-size-below-point-five.
* platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt: Reverted these
results to the results that all slaves except apple-macpro-5 generate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 17 Mar 2011 16:26:36 +0000 (16:26 +0000)]
2011-03-17  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed, bad expected results were added. This fixes
        the expected results and unskips the test on GTK.

        [GTK] fast/viewport/viewport-131.html fails
        https://bugs.webkit.org/show_bug.cgi?id=56556

        * fast/viewport/viewport-131-expected.txt:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 17 Mar 2011 15:46:27 +0000 (15:46 +0000)]
2011-03-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor event listener breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=56305

        * inspector/debugger/event-listener-breakpoints-expected.txt: Added.
        * inspector/debugger/event-listener-breakpoints.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor event listener breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=56305

        - restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
        - store event listener breakpoints in a separate separate setting
        - move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

        Test: inspector/debugger/event-listener-breakpoints.html

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype.setStatus):
        (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._clearInterface):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 17 Mar 2011 15:42:00 +0000 (15:42 +0000)]
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: timeline-paint.html is flaky on GTK 64-bit Debug.
        https://bugs.webkit.org/show_bug.cgi?id=56554

        It is not guaranteed that we receive exactly one paint event.

        * inspector/timeline/timeline-paint.html:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.stopTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Mar 2011 15:18:34 +0000 (15:18 +0000)]
2011-03-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip fast/reflections/abs-position-in-reflection.html on GTK
        affected by bug 56180.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Mar 2011 15:11:02 +0000 (15:11 +0000)]
2011-03-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky svg test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Mar 2011 14:00:26 +0000 (14:00 +0000)]
2011-03-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for fast/dynamic/text-combine.html added
        in r81251.

        * platform/gtk/fast/dynamic/text-combine-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 17 Mar 2011 13:57:43 +0000 (13:57 +0000)]
2011-03-16  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Implement GPU-accelerated shadows.
        https://bugs.webkit.org/show_bug.cgi?id=56476

        For hard shadows, we simply offset the CTM and draw in the shadow
        color.  For soft shadows, we use a separable Gaussian convolution,
        with a bilinear downsample and Mitchell-Netravali upsample in order to
        preserve quality.

        * WebCore.gypi:
        Add BicubicShader and ConvolutionShader to the build.
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::State::State):
        Add shadow-related members to the GLES2Canvas::State
        (WebCore::GLES2Canvas::State::shadowActive):
        Add a helper function to know if shadows are active.
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::scissorClear):
        Refactor the scissor clearing function out of clearRect().
        (WebCore::GLES2Canvas::fillPath):
        Add hook for shadow rendering in paths.  Bind framebuffer at this level.
        (WebCore::GLES2Canvas::fillRect):
        Add hook for shadow rendering in rects.  Bind framebuffer at this level.
        (WebCore::GLES2Canvas::fillRectInternal):
        Rename fillRect() -> fillRectInternal(), which does bind its vertex
        buffer, but does not bind the framebuffer.
        (WebCore::GLES2Canvas::setShadowColor):
        (WebCore::GLES2Canvas::setShadowOffset):
        (WebCore::GLES2Canvas::setShadowBlur):
        (WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
        Implement graphicsContext-style setters for shadow parameters.
        (WebCore::GLES2Canvas::clipPath):
        Call fillPathInternal(), not fillPath().
        (WebCore::GLES2Canvas::restore):
        (WebCore::GLES2Canvas::drawTexturedRect):
        Bind the framebuffer at this level.  Do not bind vertices here (will
        be done in drawTexturedQuad).
        (WebCore::GLES2Canvas::drawTexturedRectTile):
        drawQuad() -> drawTexturedQuad().
        (WebCore::GLES2Canvas::convolveRect):
        Implement one pass of a convolution filter (X or Y).
        (WebCore::gauss):
        (WebCore::buildKernel):
        Some helper functions to build a Gaussian convolution kernel.
        (WebCore::GLES2Canvas::drawTexturedQuad):
        Rename drawQuad() -> drawTexturedQuad(), to be more clear.  Do not
        bind the framebuffer at this level (it will be done higher).
        (WebCore::GLES2Canvas::drawTexturedQuadMitchell):
        Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
        (WebCore::GLES2Canvas::fillPathInternal):
        Rename fillPath() -> fillPathInternal(), which does use quad vertices,
        but does not bind the framebuffer or set the compositing mode.
        (WebCore::GLES2Canvas::flipRect):
        Implement a helper function to flip a rectangle in Y within the canvas.
        (WebCore::GLES2Canvas::clearBorders):
        Implement a helper function to clear an n-pixel border around a rect.
        (WebCore::GLES2Canvas::beginShadowDraw):
        Setup before drawing a primitive's shadow:  for hard shadows, just
        offset the CTM by the shadow offset.  For soft shadows, bind to an
        offscreen DrawingBuffer.
        (WebCore::GLES2Canvas::endShadowDraw):
        Tear-down after drawing a primitive's shadow:  for hard shadows, just
        restore the CTM.  For soft shadows, downsample (if necessary), then
        blur in X, blur in Y, upsample if necessary).
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/gpu/BicubicShader.cpp: Added.
        (WebCore::BicubicShader::BicubicShader):
        (WebCore::BicubicShader::create):
        (WebCore::BicubicShader::use):
        * platform/graphics/gpu/BicubicShader.h: Added.
        Implement a bicubic image filtering shader.
        * platform/graphics/gpu/ConvolutionShader.cpp: Added.
        (WebCore::ConvolutionShader::ConvolutionShader):
        (WebCore::ConvolutionShader::create):
        (WebCore::ConvolutionShader::use):
        * platform/graphics/gpu/ConvolutionShader.h: Added.
        Implement a 1-dimensional convolution shader.  In order to minimize
        texture samples, this shader is parameterized at compile time by the
        width of the convolution kernel.
        * platform/graphics/gpu/DrawingBuffer.h:
        (WebCore::DrawingBuffer::colorBuffer):
        Add an accessor to retrieve a DrawingBuffer's texture ID.
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::create):
        (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
        (WebCore::SharedGraphicsContext3D::useBicubicProgram):
        (WebCore::SharedGraphicsContext3D::useConvolutionProgram):
        Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
        each possible kernel width).
        (WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
        Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
        This is done to minimize the VRAM usage:  only 2 buffers are used for
        all canvases.
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        Add bicubic and convolution shader members, and useXXX() functions.
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        Hook into GraphicsContextSkia's platform shadow setters to set
        parameters on GLES2Canvas.
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::canAccelerate):
        Remove shadows (loopers) from the list of things we can't accelerate.
2011-03-16  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Canvas2D GPU acceleration should support shadows
        https://bugs.webkit.org/show_bug.cgi?id=56476

        * fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js:
        (shouldBeAround):
        Widen the threshold for this test, which doesn't seem to allow for
        a true Gaussian blur implementation.
        * platform/chromium/test_expectations.txt:
        Update some tests which are now passing on GPU, and some which time out
        due to Mesa slowness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 17 Mar 2011 13:32:06 +0000 (13:32 +0000)]
2011-03-17  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, update expectations

        * platform/chromium-mac/fast/forms/input-number-unacceptable-style-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 12:11:14 +0000 (12:11 +0000)]
2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Benjamin Poulain.

        Update autoinstall to install mechanize 0.2.4
        https://bugs.webkit.org/show_bug.cgi?id=56499

        Newer versions of mechanize support HTTPS proxies, which is necessary
        for people using webkit-patch behind firewalls.

        * Scripts/webkitpy/common/system/autoinstall.py:
        * Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 17 Mar 2011 12:00:34 +0000 (12:00 +0000)]
2011-03-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Andreas Kling.

        Tiled backing store should only request repaint for updated areas
        https://bugs.webkit.org/show_bug.cgi?id=56464

        Reuse updateBackBuffer's dirty rectangle calculations to only
        invalidate the necessary parts of the window.

        * platform/graphics/Tile.h:
        * platform/graphics/TiledBackingStore.cpp:
        (WebCore::TiledBackingStore::updateTileBuffers):
        * platform/graphics/qt/TileQt.cpp:
        (WebCore::Tile::updateBackBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Mar 2011 11:58:42 +0000 (11:58 +0000)]
2011-03-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip fast/profiler/window-dot-eval.html on GTK
        affected by bug 56180.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 17 Mar 2011 11:39:51 +0000 (11:39 +0000)]
2011-03-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] minor cleanup of devtools_files variable in WebKit.gyp
        https://bugs.webkit.org/show_bug.cgi?id=56503

        * WebKit.gyp: Moving duplicate variables out of a condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Mar 2011 11:02:01 +0000 (11:02 +0000)]
2011-03-17  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing viewport test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 17 Mar 2011 10:32:49 +0000 (10:32 +0000)]
2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
        https://bugs.webkit.org/show_bug.cgi?id=56395

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotRetainerEdge): Added
        (WebInspector.HeapSnapshotRetainerEdgeIterator): Added
        (WebInspector.HeapSnapshotNode.prototype.get retainers):
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype.hasId):
        (WebInspector.HeapSnapshot.prototype.retainers):
        (WebInspector.HeapSnapshot.prototype._buildRetainers):
        (WebInspector.HeapSnapshot.prototype._buildIdsList):
        (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
        (WebInspector.HeapSnapshot.prototype._findNodePositionInIndex):
        (WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
        (WebInspector.HeapSnapshot.prototype._getRetainerIndex):
        (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
        (WebInspector.HeapSnapshot.prototype._numbersComparator):
        (WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge):
        (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
        (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
        (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Thu, 17 Mar 2011 09:49:27 +0000 (09:49 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81243.
        http://trac.webkit.org/changeset/81243
        https://bugs.webkit.org/show_bug.cgi?id=56471

        Breaks GTK 64-bit Debug tests (Requested by podivilov on
        #webkit).

        * inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
        * inspector/debugger/event-listener-breakpoints.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81243.
        http://trac.webkit.org/changeset/81243
        https://bugs.webkit.org/show_bug.cgi?id=56471

        Breaks GTK 64-bit Debug tests (Requested by podivilov on
        #webkit).

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
        (WebInspector.EventListenerBreakpoint):
        (WebInspector.EventListenerBreakpoint.prototype._enable):
        (WebInspector.EventListenerBreakpoint.prototype._disable):
        (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
        (WebInspector.EventListenerBreakpointView):
        (WebInspector.EventListenerBreakpointView.eventNameForUI):
        (WebInspector.EventListenerBreakpointView.prototype.get eventName):
        (WebInspector.EventListenerBreakpointView.prototype.compareTo):
        (WebInspector.EventListenerBreakpointView.prototype.populateLabelElement):
        (WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement):
        (WebInspector.EventListenerBreakpointView.prototype._uiEventName):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
        (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
        (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._clearInterface):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 17 Mar 2011 09:17:28 +0000 (09:17 +0000)]
2011-03-17  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport test for user-scalable=yes
        https://bugs.webkit.org/show_bug.cgi?id=56527

        Provide tests for user-scalable no, yes, and default values.

        * fast/viewport/viewport-130-expected.txt: Added.
        * fast/viewport/viewport-130.html: Added.
        * fast/viewport/viewport-131-expected.txt: Added.
        * fast/viewport/viewport-131.html: Added.
        * fast/viewport/viewport-132-expected.txt: Copied from LayoutTests/fast/viewport/viewport-1-expected.txt.
        * fast/viewport/viewport-132.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 17 Mar 2011 08:49:08 +0000 (08:49 +0000)]
2011-03-17  Patrick Gansterer  <paroga@webkit.org>

        Fix the interpreter build.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute): Added globalData to inheritorID().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 08:35:28 +0000 (08:35 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add more ObjC++ files to the build
        https://bugs.webkit.org/show_bug.cgi?id=56548

        96 link errors.

        * WebCore.gypi:
        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd transitions/default-timing-function.html to the SnowLeopard WebKit2 Skipped list.
weinig@apple.com [Thu, 17 Mar 2011 08:14:00 +0000 (08:14 +0000)]
Add transitions/default-timing-function.html to the SnowLeopard WebKit2 Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=56531

Reviewed by Adam Roben.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 08:10:24 +0000 (08:10 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a few Objective-C++ files to the WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56547

        464 link errors.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd java/lc3/JavaObject/JavaObjectToDouble-001.html to the mac-leopard Skipped list.
weinig@apple.com [Thu, 17 Mar 2011 08:04:24 +0000 (08:04 +0000)]
Add java/lc3/JavaObject/JavaObjectToDouble-001.html to the mac-leopard Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=56545

Reviewed by Adam Roben.

- This test was getting different results on different slaves.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 17 Mar 2011 07:51:39 +0000 (07:51 +0000)]
2011-03-17  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed build fix.

        Non-ASCII characters in XMLTreeViewer.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=56549

        * xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
        * xml/XMLTreeViewer.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 07:42:06 +0000 (07:42 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add plugins and bridge to the WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56546

        506 link errors.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable fast/workers/storage/interrupt-database-sync.html due to flakiness on
weinig@apple.com [Thu, 17 Mar 2011 07:14:15 +0000 (07:14 +0000)]
Disable fast/workers/storage/interrupt-database-sync.html due to flakiness on
multiple platforms.
https://bugs.webkit.org/show_bug.cgi?id=49906

Reviewed by Adam Roben.

* fast/workers/storage/interrupt-database-sync.html: Removed.
* fast/workers/storage/interrupt-database-sync.html-disabled: Copied from fast/workers/storage/interrupt-database-sync.html.
* platform/qt/Skipped: Remove from qt Skipped list since it is now disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding new results for some failing tests on the Leopard Debug/Leopard Release Tester.
weinig@apple.com [Thu, 17 Mar 2011 07:04:45 +0000 (07:04 +0000)]
Adding new results for some failing tests on the Leopard Debug/Leopard Release Tester.

Reviewed by Adam Roben.

The following bugs were filed to track these issues:
    https://bugs.webkit.org/show_bug.cgi?id=56544
    https://bugs.webkit.org/show_bug.cgi?id=56545

* platform/mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
* platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding plugins/destroy-on-setwindow.html to the mac-leopard Skipped list.
weinig@apple.com [Thu, 17 Mar 2011 06:51:15 +0000 (06:51 +0000)]
Adding plugins/destroy-on-setwindow.html to the mac-leopard Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=56165 was filed to track this issue.

Reviewed by Adam Roben.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 06:39:19 +0000 (06:39 +0000)]
2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>

        Reviewed by Alexey Proskuryakov.

        Logic error in -[WebHTMLView close]
        https://bugs.webkit.org/show_bug.cgi?id=56445

        The function setDraggingImageURL() is no longer called and can be deleted.

        No new tests. Deleting dead code.

        * page/DragController.h:
2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>

        Reviewed by Alexey Proskuryakov.

        Logic error in -[WebHTMLView close]
        https://bugs.webkit.org/show_bug.cgi?id=56445

        Page is always nil at this point, because [self _webView] is nil,
        so the conditional code is never run.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding new results for some failing tests on the SnowLeopard WebKit2 Tester.
weinig@apple.com [Thu, 17 Mar 2011 06:34:06 +0000 (06:34 +0000)]
Adding new results for some failing tests on the SnowLeopard WebKit2 Tester.

Reviewed by Adam Roben; Dictated, but not read, by Adam Roben.

The following bugs were filed to track these issues:
    https://bugs.webkit.org/show_bug.cgi?id=56528
    https://bugs.webkit.org/show_bug.cgi?id=56530
    https://bugs.webkit.org/show_bug.cgi?id=56531
    https://bugs.webkit.org/show_bug.cgi?id=56532
    https://bugs.webkit.org/show_bug.cgi?id=56533
    https://bugs.webkit.org/show_bug.cgi?id=56537
    https://bugs.webkit.org/show_bug.cgi?id=56539

* platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Added.
* platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Added.
* platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
* platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Added.
* platform/mac-wk2/http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
* platform/mac-wk2/media/controls-without-preload-expected.txt: Added.
* platform/mac-wk2/transitions/default-timing-function-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 06:31:00 +0000 (06:31 +0000)]
2011-03-16  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Ryosuke Niwa.

        Textarea maxlength doesn't account for newlines
        https://bugs.webkit.org/show_bug.cgi?id=54443

        * fast/forms/script-tests/textarea-maxlength.js:
        (createFocusedTextAreaWithMaxLength3): Added two tests to make sure consecutive insertbreaks
        work correctly for textarea maxlength.
        * fast/forms/textarea-maxlength-expected.txt: Added two test results.
2011-03-16  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Ryosuke Niwa.

        Textarea maxlength doesn't account for newlines
        https://bugs.webkit.org/show_bug.cgi?id=54443

        When a user presses a return key, TypingCommand::insertLineBreak() is called.
        So before append a new line, check if we can add the new line.

        * editing/TypingCommand.cpp:
        (WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line.
        (WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line.
        (WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 17 Mar 2011 06:14:34 +0000 (06:14 +0000)]
2011-03-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56541

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::willSendRequestForFrame):
        Check for an empty host in addition to a null host.  This bug was introduced
        when porting off of the KURL code and onto the WKURLRef version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 06:12:15 +0000 (06:12 +0000)]
2011-03-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebCore GYP build should build more derived sources
        https://bugs.webkit.org/show_bug.cgi?id=56529

        This patch brings us down to 597 link errors.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 06:09:03 +0000 (06:09 +0000)]
2011-03-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebCore GYP should build (most) remaining source files
        https://bugs.webkit.org/show_bug.cgi?id=56515

        We're still not building all the files and we have 1305 link errors,
        but this patch is progress.

        * WebCore.gypi:
        * gyp/WebCore.gyp:
        * plugins/PluginStream.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd fast/workers/storage/interrupt-database-sync.html to the win-xp skipped list
alice.liu@apple.com [Thu, 17 Mar 2011 05:38:37 +0000 (05:38 +0000)]
Add fast/workers/storage/interrupt-database-sync.html to the win-xp skipped list
due to intermittent failure; tracked by https://bugs.webkit.org/show_bug.cgi?id=56534

* platform/win-xp/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Lucas Forschler to the list of WebKit committers.
weinig@apple.com [Thu, 17 Mar 2011 05:37:17 +0000 (05:37 +0000)]
Add Lucas Forschler to the list of WebKit committers.

Reviewed by Adam Roben.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd compositing/transitions/singular-scale-transition.html to the Skipped lists.
weinig@apple.com [Thu, 17 Mar 2011 05:22:33 +0000 (05:22 +0000)]
Add compositing/transitions/singular-scale-transition.html to the Skipped lists.
Seems to be the same assert that https://bugs.webkit.org/show_bug.cgi?id=56488 was
filed for.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed upon and dictated through Adam Roben.
weinig@apple.com [Thu, 17 Mar 2011 05:13:59 +0000 (05:13 +0000)]
Reviewed upon and dictated through Adam Roben.

Escape crashing function names in results.html. This fixes an issue
when a crash involves a type with templates.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the interpreter build.
weinig@apple.com [Thu, 17 Mar 2011 04:46:05 +0000 (04:46 +0000)]
Fix the interpreter build.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::privateExecute):
Remove .get()s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate the default navigator.vendor value
mitz@apple.com [Thu, 17 Mar 2011 04:36:16 +0000 (04:36 +0000)]
Update the default navigator.vendor value
https://bugs.webkit.org/show_bug.cgi?id=56449

Reviewed by Alexey Proskuryakov.

* page/NavigatorBase.cpp: Updated the default value of
WEBCORE_NAVIGATOR_VENDOR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 17 Mar 2011 04:27:35 +0000 (04:27 +0000)]
2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

        Follow-up patch to update GTK expected results.
        It looks like the GTK platform specific results for
        some viewport tests match regular results, and there
        were a few viewport tests that still needed expected
        results since other platforms skip them.

        Viewport no longer allows an auto value for "user-scalable"
        https://bugs.webkit.org/show_bug.cgi?id=55416

        * fast/viewport/viewport-58-expected.txt:
        * fast/viewport/viewport-6-expected.txt:
        * platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.
        * platform/gtk/fast/viewport/viewport-92-expected.txt: Removed.
        * platform/gtk/fast/viewport/viewport-93-expected.txt: Removed.
        * platform/gtk/fast/viewport/viewport-94-expected.txt: Removed.
        * platform/gtk/fast/viewport/viewport-95-expected.txt: Removed.
        * platform/gtk/fast/viewport/viewport-96-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Thu, 17 Mar 2011 03:56:13 +0000 (03:56 +0000)]
2011-03-16  John Bauman  <jbauman@chromium.org>

        Reviewed by James Robinson.

        texImage2D gets old contents of canvas
        https://bugs.webkit.org/show_bug.cgi?id=56414

        * platform/chromium/test_expectations.txt: premultiply-alpha test now works
2011-03-16  John Bauman  <jbauman@chromium.org>

        Reviewed by James Robinson.

        texImage2D gets old contents of canvas
        https://bugs.webkit.org/show_bug.cgi?id=56414

        Always update the canvas contents in copiedImage, as there's no reason
        to ask for an out-of-date image.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::copiedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 03:46:53 +0000 (03:46 +0000)]
2011-03-16  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Remove USE(BUILTIN_UTF8_CODEC)
        https://bugs.webkit.org/show_bug.cgi?id=56508

        We added this recently when we were unsure about the stability of the
        built-in UTF-8 codec.  However, the codec seems to be stable, so we
        don't need the macro.

        * wtf/Platform.h:
2011-03-16  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Remove USE(BUILTIN_UTF8_CODEC)
        https://bugs.webkit.org/show_bug.cgi?id=56508

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerEncodingNames):
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
2011-03-16  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Remove USE(BUILTIN_UTF8_CODEC)
        https://bugs.webkit.org/show_bug.cgi?id=56508

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCheck in new results for text-combine-image-test-expected.txt.
weinig@apple.com [Thu, 17 Mar 2011 03:46:00 +0000 (03:46 +0000)]
Check in new results for text-combine-image-test-expected.txt.

* platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix changelog.
weinig@apple.com [Thu, 17 Mar 2011 03:07:54 +0000 (03:07 +0000)]
Fix changelog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding new results for some failing tests on the Leopard Release Tester.
weinig@apple.com [Thu, 17 Mar 2011 03:04:18 +0000 (03:04 +0000)]
Adding new results for some failing tests on the Leopard Release Tester.

The following bugs were filed to track these issues:
    https://bugs.webkit.org/show_bug.cgi?id=56516
    https://bugs.webkit.org/show_bug.cgi?id=56517
    https://bugs.webkit.org/show_bug.cgi?id=56518
    https://bugs.webkit.org/show_bug.cgi?id=56519
    https://bugs.webkit.org/show_bug.cgi?id=56521
    https://bugs.webkit.org/show_bug.cgi?id=56522
    https://bugs.webkit.org/show_bug.cgi?id=56522
    https://bugs.webkit.org/show_bug.cgi?id=56525

* platform/mac-leopard/Skipped:
* platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt: Added.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
* platform/mac-leopard/fast/forms/input-number-unacceptable-style-expected.txt: Added.
* platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt: Added.
* platform/mac-leopard/fast/text/text-combine-image-test-expected.txt: Added.
* platform/mac-leopard/media/controls-without-preload-expected.txt: Added.
* platform/mac-leopard/platform/mac/accessibility: Added.
* platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
* platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 17 Mar 2011 02:48:27 +0000 (02:48 +0000)]
2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

        Follow-up patch landing updated expected results,
        which now include the userScalable value in output.

        Viewport no longer allows an auto value for "user-scalable"
        https://bugs.webkit.org/show_bug.cgi?id=55416

        * fast/viewport/viewport-1-expected.txt:
        * fast/viewport/viewport-10-expected.txt:
        * fast/viewport/viewport-100-expected.txt:
        * fast/viewport/viewport-101-expected.txt:
        * fast/viewport/viewport-102-expected.txt:
        * fast/viewport/viewport-103-expected.txt:
        * fast/viewport/viewport-104-expected.txt:
        * fast/viewport/viewport-105-expected.txt:
        * fast/viewport/viewport-106-expected.txt:
        * fast/viewport/viewport-107-expected.txt:
        * fast/viewport/viewport-108-expected.txt:
        * fast/viewport/viewport-109-expected.txt:
        * fast/viewport/viewport-11-expected.txt:
        * fast/viewport/viewport-110-expected.txt:
        * fast/viewport/viewport-111-expected.txt:
        * fast/viewport/viewport-112-expected.txt:
        * fast/viewport/viewport-113-expected.txt:
        * fast/viewport/viewport-114-expected.txt:
        * fast/viewport/viewport-115-expected.txt:
        * fast/viewport/viewport-116-expected.txt:
        * fast/viewport/viewport-117-expected.txt:
        * fast/viewport/viewport-118-expected.txt:
        * fast/viewport/viewport-119-expected.txt:
        * fast/viewport/viewport-12-expected.txt:
        * fast/viewport/viewport-120-expected.txt:
        * fast/viewport/viewport-121-expected.txt:
        * fast/viewport/viewport-122-expected.txt:
        * fast/viewport/viewport-123-expected.txt:
        * fast/viewport/viewport-124-expected.txt:
        * fast/viewport/viewport-125-expected.txt:
        * fast/viewport/viewport-129-expected.txt:
        * fast/viewport/viewport-13-expected.txt:
        * fast/viewport/viewport-14-expected.txt:
        * fast/viewport/viewport-15-expected.txt:
        * fast/viewport/viewport-16-expected.txt:
        * fast/viewport/viewport-17-expected.txt:
        * fast/viewport/viewport-18-expected.txt:
        * fast/viewport/viewport-19-expected.txt:
        * fast/viewport/viewport-2-expected.txt:
        * fast/viewport/viewport-20-expected.txt:
        * fast/viewport/viewport-21-expected.txt:
        * fast/viewport/viewport-22-expected.txt:
        * fast/viewport/viewport-23-expected.txt:
        * fast/viewport/viewport-24-expected.txt:
        * fast/viewport/viewport-25-expected.txt:
        * fast/viewport/viewport-26-expected.txt:
        * fast/viewport/viewport-27-expected.txt:
        * fast/viewport/viewport-28-expected.txt:
        * fast/viewport/viewport-29-expected.txt:
        * fast/viewport/viewport-3-expected.txt:
        * fast/viewport/viewport-30-expected.txt:
        * fast/viewport/viewport-31-expected.txt:
        * fast/viewport/viewport-32-expected.txt:
        * fast/viewport/viewport-33-expected.txt:
        * fast/viewport/viewport-34-expected.txt:
        * fast/viewport/viewport-35-expected.txt:
        * fast/viewport/viewport-36-expected.txt:
        * fast/viewport/viewport-37-expected.txt:
        * fast/viewport/viewport-38-expected.txt:
        * fast/viewport/viewport-39-expected.txt:
        * fast/viewport/viewport-4-expected.txt:
        * fast/viewport/viewport-40-expected.txt:
        * fast/viewport/viewport-41-expected.txt:
        * fast/viewport/viewport-42-expected.txt:
        * fast/viewport/viewport-43-expected.txt:
        * fast/viewport/viewport-44-expected.txt:
        * fast/viewport/viewport-46-expected.txt:
        * fast/viewport/viewport-47-expected.txt:
        * fast/viewport/viewport-48-expected.txt:
        * fast/viewport/viewport-49-expected.txt:
        * fast/viewport/viewport-5-expected.txt:
        * fast/viewport/viewport-50-expected.txt:
        * fast/viewport/viewport-51-expected.txt:
        * fast/viewport/viewport-52-expected.txt:
        * fast/viewport/viewport-53-expected.txt:
        * fast/viewport/viewport-54-expected.txt:
        * fast/viewport/viewport-55-expected.txt:
        * fast/viewport/viewport-56-expected.txt:
        * fast/viewport/viewport-57-expected.txt:
        * fast/viewport/viewport-59-expected.txt:
        * fast/viewport/viewport-60-expected.txt:
        * fast/viewport/viewport-61-expected.txt:
        * fast/viewport/viewport-62-expected.txt:
        * fast/viewport/viewport-63-expected.txt:
        * fast/viewport/viewport-64-expected.txt:
        * fast/viewport/viewport-66-expected.txt:
        * fast/viewport/viewport-67-expected.txt:
        * fast/viewport/viewport-68-expected.txt:
        * fast/viewport/viewport-69-expected.txt:
        * fast/viewport/viewport-7-expected.txt:
        * fast/viewport/viewport-70-expected.txt:
        * fast/viewport/viewport-71-expected.txt:
        * fast/viewport/viewport-72-expected.txt:
        * fast/viewport/viewport-73-expected.txt:
        * fast/viewport/viewport-74-expected.txt:
        * fast/viewport/viewport-75-expected.txt:
        * fast/viewport/viewport-76-expected.txt:
        * fast/viewport/viewport-77-expected.txt:
        * fast/viewport/viewport-78-expected.txt:
        * fast/viewport/viewport-79-expected.txt:
        * fast/viewport/viewport-8-expected.txt:
        * fast/viewport/viewport-80-expected.txt:
        * fast/viewport/viewport-81-expected.txt:
        * fast/viewport/viewport-83-expected.txt:
        * fast/viewport/viewport-85-expected.txt:
        * fast/viewport/viewport-86-expected.txt:
        * fast/viewport/viewport-88-expected.txt:
        * fast/viewport/viewport-9-expected.txt:
        * fast/viewport/viewport-90-expected.txt:
        * fast/viewport/viewport-91-expected.txt:
        * fast/viewport/viewport-92-expected.txt:
        * fast/viewport/viewport-93-expected.txt:
        * fast/viewport/viewport-94-expected.txt:
        * fast/viewport/viewport-95-expected.txt:
        * fast/viewport/viewport-96-expected.txt:
        * fast/viewport/viewport-warnings-1-expected.txt:
        * fast/viewport/viewport-warnings-2-expected.txt:
        * fast/viewport/viewport-warnings-3-expected.txt:
        * fast/viewport/viewport-warnings-4-expected.txt:
        * fast/viewport/viewport-warnings-5-expected.txt:
        * fast/viewport/viewport-warnings-6-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 17 Mar 2011 02:11:50 +0000 (02:11 +0000)]
2011-03-16  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Make JIT build for ARM Thumb-2 with RVCT
        https://bugs.webkit.org/show_bug.cgi?id=56440

        Derived from a patch by Dave Tapuska.

        Also, modify the RVCT stub template to indicate that it preserves 8 byte stack alignment.

        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 17 Mar 2011 02:10:19 +0000 (02:10 +0000)]
2011-03-16  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] include inspector gif files in the list of resources
        https://bugs.webkit.org/show_bug.cgi?id=56504

        * scripts/generate_devtools_grd.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 17 Mar 2011 01:53:36 +0000 (01:53 +0000)]
2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

    2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport no longer allows an auto value for "user-scalable"
            https://bugs.webkit.org/show_bug.cgi?id=55416

            This restores our behavior before r67376 the default "user-scalable"
            behavior can be defined by a WebKit client if a value was not
            explicitly provided in web content (via the viewport <meta> tag).
            Here, all WebKit ports default to "yes" after computing
            viewport arguments. However, in the future they may consider
            changing the default user-scalable value based on the type
            of the document being viewed, a user preference, or other reasons.

            Covered by existing tests. Should be no changes.

            * dom/ViewportArguments.cpp:
            (WebCore::computeViewportAttributes): be explicit about 0.
            (WebCore::findUserScalableValue): convert to return a float, the instance variable type.
            * dom/ViewportArguments.h:
            (WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to
            allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the
            WebKit client.

Source/WebKit/efl:

    2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport no longer allows an auto value for "user-scalable"
            https://bugs.webkit.org/show_bug.cgi?id=55416

            Make the default value for userScalable be true.

            * ewk/ewk_view.cpp:
            (ewk_view_viewport_attributes_get):

Source/WebKit/gtk:

    2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport no longer allows an auto value for "user-scalable"
            https://bugs.webkit.org/show_bug.cgi?id=55416

            Make the default value for userScalable be true.

            * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
            (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
            * webkit/webkitviewportattributes.cpp:
            (webkitViewportAttributesRecompute):

Source/WebKit/qt:

    2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport no longer allows an auto value for "user-scalable"
            https://bugs.webkit.org/show_bug.cgi?id=55416

            Make the default value for userScalable be true.

            * Api/qwebpage.cpp:
            (QWebPage::viewportAttributesForSize):
            * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
            (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.

Source/WebKit2:

    2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>

            Viewport no longer allows an auto value for "user-scalable"
            https://bugs.webkit.org/show_bug.cgi?id=55416

            Make the default value for userScalable be true.

            * UIProcess/API/qt/qwkpage.cpp:
            (QWKPage::viewportAttributesForSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 01:53:16 +0000 (01:53 +0000)]
2011-03-16  Chao-ying Fu  <fu@mips.com>

        Reviewed by Darin Adler.

        Fix MIPS build with const *void
        https://bugs.webkit.org/show_bug.cgi?id=56513

        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::load32):
        (JSC::MacroAssemblerMIPS::store32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew baselines because the play button is now a pause button due to r81300.
levin@chromium.org [Thu, 17 Mar 2011 01:46:44 +0000 (01:46 +0000)]
New baselines because the play button is now a pause button due to r81300.

* platform/chromium-linux/media/controls-after-reload-expected.checksum:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.checksum:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-win-xp/media/controls-after-reload-expected.checksum:
* platform/chromium-win-xp/media/controls-after-reload-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Mar 2011 01:05:00 +0000 (01:05 +0000)]
2011-03-16  Adam Barth  <abarth@webkit.org>

        Update the Skipped lists to reflect the new location of these tests.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit...
levin@chromium.org [Thu, 17 Mar 2011 00:57:43 +0000 (00:57 +0000)]
REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".

Reviewed by Dmitry Titov.

Conditional jump or move depends on uninitialised value(s)
    WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)

* page/Settings.cpp:
(WebCore::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
bdakin@apple.com [Thu, 17 Mar 2011 00:49:09 +0000 (00:49 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
regions does not work

Reviewed by Darin Adler.

Up until now, overlay scrollbars have always been treated in the Render Tree as if
they have a thickness of 0 because they should not affect layout. However, it is
important to consider their size when hit-testing because otherwise, we have this
bug! This patch adds a boolean parameter to overflowClipRect(),
RenderLayer::verticalScrollbarWidth(), and
RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
the actual overlay scrollbar thickness. It defaults to false and is only sent is
as true from RenderBloc::nodeAtPoint().

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::overflowClipRect):
* rendering/RenderBox.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
* rendering/RenderLayer.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::overflowClipRect):
* rendering/RenderTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Thu, 17 Mar 2011 00:45:10 +0000 (00:45 +0000)]
2011-03-16  Bill Budge  <bbudge@chromium.org>

        Reviewed by David Levin.

        AssociatedURLLoader does not support Cross Origin Requests
        https://bugs.webkit.org/show_bug.cgi?id=53925

        No new tests. Exposes no new functionality.

        * public/WebURLLoader.h:
        (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::isDocumentThreadableLoaderClient):
        (WebKit::AssociatedURLLoader::ClientAdapter::clearClient):
        (WebKit::AssociatedURLLoader::ClientAdapter::create):
        (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
        (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest):
        (WebKit::AssociatedURLLoader::ClientAdapter::didSendData):
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata):
        (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
        (WebKit::AssociatedURLLoader::ClientAdapter::didFail):
        (WebKit::AssociatedURLLoader::AssociatedURLLoader):
        (WebKit::AssociatedURLLoader::~AssociatedURLLoader):
        (WebKit::AssociatedURLLoader::loadSynchronously):
        (WebKit::AssociatedURLLoader::loadAsynchronously):
        (WebKit::AssociatedURLLoader::cancel):
        (WebKit::AssociatedURLLoader::setDefersLoading):
        * src/AssociatedURLLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-16 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 00:34:49 +0000 (00:34 +0000)]
2011-03-16  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Fix std::swap not found issue on mobile Qt devices.
        https://bugs.webkit.org/show_bug.cgi?id=56463

        Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
        on some Qt mobile devices.

        No new tests: No tests needed - compilation verified manually.

        * platform/text/qt/TextBreakIteratorQt.cpp:
        (WebCore::acquireLineBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expectations due to r81280 (media/controls-without-preload.html),
levin@chromium.org [Thu, 17 Mar 2011 00:26:05 +0000 (00:26 +0000)]
Update test expectations due to r81280 (media/controls-without-preload.html),
and r81285 (media-document-audio-repaint-expected).

* platform/chromium-linux/media/controls-without-preload-expected.checksum:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.checksum:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81301 268f45cc-cd09-0410-ab3c-d52691b4dbfc