WebKit-https.git
12 years agoRemove commented out fprintf's that were for debugging purposes only.
mrowe@apple.com [Sat, 15 Dec 2007 04:35:07 +0000 (04:35 +0000)]
Remove commented out fprintf's that were for debugging purposes only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and...
mrowe@apple.com [Sat, 15 Dec 2007 04:31:39 +0000 (04:31 +0000)]
Don't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and is currently untested on other platforms.

Reviewed by Maciej Stachowiak.

* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease): Return after releasing memory rather than potentially falling
through into another mechanism if multiple are supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 04:21:40 +0000 (04:21 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Build fix for GTK+/Qt and ports that don't use AllInOneFile.cpp.

        Include UnusedParam.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build on windows
oliver@apple.com [Sat, 15 Dec 2007 03:53:52 +0000 (03:53 +0000)]
Fix build on windows

Reviewd by Stephanie

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Windows build fix
mitz@apple.com [Sat, 15 Dec 2007 03:26:35 +0000 (03:26 +0000)]
    - Windows build fix

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - yet another build fix
mitz@apple.com [Sat, 15 Dec 2007 03:02:14 +0000 (03:02 +0000)]
    - yet another build fix

        * DOMHTMLClasses.cpp:
        (DOMHTMLDocument::URL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 03:00:45 +0000 (03:00 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Fix inconsistent indentation in the license header. Maciej was right!

        * WebCoreSupport/FrameLoaderClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 02:51:01 +0000 (02:51 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        GTK+/Qt build fix. Track added files in r28722.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5647272> Remove user agent string hack for flickr.com
ddkilzer@apple.com [Sat, 15 Dec 2007 02:16:20 +0000 (02:16 +0000)]
    <rdar://problem/5647272> Remove user agent string hack for flickr.com

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView _userAgentForURL:]): Removed hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5647261> Remove user agent string hack for yahoo.com
ddkilzer@apple.com [Sat, 15 Dec 2007 02:15:06 +0000 (02:15 +0000)]
    <rdar://problem/5647261> Remove user agent string hack for yahoo.com

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView _userAgentForURL:]): Removed hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try again to fix the Windows build
mitz@apple.com [Sat, 15 Dec 2007 02:09:16 +0000 (02:09 +0000)]
    - try again to fix the Windows build

        * wtf/TCSystemAlloc.cpp:
        (TCMalloc_SystemRelease):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix the Windows build
mitz@apple.com [Sat, 15 Dec 2007 02:00:08 +0000 (02:00 +0000)]
    - try to fix the Windows build

        * wtf/TCSystemAlloc.cpp:
        (TCMalloc_SystemRelease):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - build fix
mitz@apple.com [Sat, 15 Dec 2007 01:35:30 +0000 (01:35 +0000)]
    - build fix

        * WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix ChangeLog
weinig@apple.com [Sat, 15 Dec 2007 01:19:19 +0000 (01:19 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
weinig@apple.com [Sat, 15 Dec 2007 01:17:50 +0000 (01:17 +0000)]
    Reviewed by Geoff.

        Speed up getElementByClassName.
        - This makes getElementByClassName take 33% faster on the stress test
          linked to at http://bugs.webkit.org/show_bug.cgi?id=15760.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::foldCase): Optimize the case when all the characters are ASCII.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-14 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 15 Dec 2007 01:03:59 +0000 (01:03 +0000)]
2007-12-14  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=16432
        [GTK] Update license headers

        Consent has been given by the authors of these files to change license
        to the LGPL as outlined in the bug report.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd logic for TCMalloc to release memory to the system
oliver@apple.com [Sat, 15 Dec 2007 00:25:45 +0000 (00:25 +0000)]
Add logic for TCMalloc to release memory to the system

Reviewed by Maciej and Oliver.

Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
darin@apple.com [Fri, 14 Dec 2007 23:42:32 +0000 (23:42 +0000)]
    Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16442
          navigation policy delegate gets called twice for each load

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy.
        That's handled by FrameLoader.

        * loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy
        and continueAfterNavigationPolicy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
darin@apple.com [Fri, 14 Dec 2007 23:41:16 +0000 (23:41 +0000)]
    Reviewed by Adele.

        - http://bugs.webkit.org/show_bug.cgi?id=16443
          implement some missing Windows WebKit functions

        * DOMHTMLClasses.cpp:
        (DOMHTMLDocument::URL): Implemented.

        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - share the results of this test between Tiger and Leopard
mitz@apple.com [Fri, 14 Dec 2007 23:06:44 +0000 (23:06 +0000)]
    - share the results of this test between Tiger and Leopard

        * platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
        * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Fri, 14 Dec 2007 22:06:50 +0000 (22:06 +0000)]
WebCore:

        Reviewed by Brady.

        Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
        return nil in that case.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didExplicitOpen):

WebKitTools:

        Reviewed by Brady.

        Assert that a web frame that's loading a resource always has either a data source or
        a provisional data source.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

LayoutTests:

        Reviewed by Brady.

        Add test that calls window.open and then immediately writes into the document
        of the newly opened window.

        * http/tests/misc/resources/compass.jpg: Added.
        * http/tests/misc/window-open-then-write-expected.txt: Added.
        * http/tests/misc/window-open-then-write.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Fri, 14 Dec 2007 21:48:20 +0000 (21:48 +0000)]
WebCore:

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14955
          Implement getElementsByClassName.

        This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
        and takes advantage of admitting that it's class-specific to encapsulate class attribute
        parsing so it can be shared.  It also changes the class to use a Vector, rather than a linked
        list to store the class names.

        Tests: fast/dom/getElementsByClassName/001.html
               fast/dom/getElementsByClassName/002.html
               fast/dom/getElementsByClassName/003.html
               fast/dom/getElementsByClassName/004.html
               fast/dom/getElementsByClassName/005.html
               fast/dom/getElementsByClassName/006.html
               fast/dom/getElementsByClassName/007.html
               fast/dom/getElementsByClassName/008.html
               fast/dom/getElementsByClassName/009.html
               fast/dom/getElementsByClassName/010.xml
               fast/dom/getElementsByClassName/011.xml
               fast/dom/getElementsByClassName/012.html
               fast/dom/getElementsByClassName/013.html
               fast/dom/getElementsByClassName/014.html
               fast/dom/getElementsByClassName/array/001.html
               fast/dom/getElementsByClassName/array/002.html
               fast/dom/getElementsByClassName/array/003.html
               fast/dom/getElementsByClassName/array/004.html
               fast/dom/getElementsByClassName/dumpNodeList.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRules):
        (WebCore::CSSStyleSelector::checkOneSelector):
        * dom/AtomicStringList.h: Removed.
        * dom/ClassNames.cpp: Added.
        (WebCore::ClassNames::contains):
        (WebCore::ClassNames::parseClassAttribute):
        * dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h.
        (WebCore::ClassNames::ClassNames):
        (WebCore::ClassNames::size):
        (WebCore::ClassNames::clear):
        (WebCore::ClassNames::operator[]):
        (WebCore::isClassWhitespace):
        * dom/ClassNodeList.cpp: Added.
        (WebCore::ClassNodeList::ClassNodeList):
        (WebCore::ClassNodeList::length):
        (WebCore::ClassNodeList::item):
        (WebCore::ClassNodeList::nodeMatches):
        * dom/ClassNodeList.h: Added.
        * dom/Document.cpp:
        (WebCore::Document::getElementsByName):
        (WebCore::Document::getElementsByClassName):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Element.cpp:
        (WebCore::Element::getClassNames):
        (WebCore::Element::getElementsByClassName):
        * dom/Element.h:
        * dom/Element.idl:
        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList):
        (WebCore::NameNodeList::item):
        (WebCore::NameNodeList::nodeMatches):
        * dom/NameNodeList.h:
        * dom/NamedMappedAttrMap.cpp:
        (WebCore::NamedMappedAttrMap::clearAttributes):
        (WebCore::NamedMappedAttrMap::parseClassAttribute):
        * dom/NamedMappedAttrMap.h:
        (WebCore::NamedMappedAttrMap::getClassNames):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::getClassNames):
        * dom/StyledElement.h:

LayoutTests:

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14955
          Implement getElementsByClassName

        Tests added from http://tc.labs.opera.com/apis/getElementsByClassName/

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/getElementsByClassName: Added.
        * fast/dom/getElementsByClassName/001-expected.txt: Added.
        * fast/dom/getElementsByClassName/001.html: Added.
        * fast/dom/getElementsByClassName/002-expected.txt: Added.
        * fast/dom/getElementsByClassName/002.html: Added.
        * fast/dom/getElementsByClassName/003-expected.txt: Added.
        * fast/dom/getElementsByClassName/003.html: Added.
        * fast/dom/getElementsByClassName/004-expected.txt: Added.
        * fast/dom/getElementsByClassName/004.html: Added.
        * fast/dom/getElementsByClassName/005-expected.txt: Added.
        * fast/dom/getElementsByClassName/005.html: Added.
        * fast/dom/getElementsByClassName/006-expected.txt: Added.
        * fast/dom/getElementsByClassName/006.html: Added.
        * fast/dom/getElementsByClassName/007-expected.txt: Added.
        * fast/dom/getElementsByClassName/007.html: Added.
        * fast/dom/getElementsByClassName/008-expected.txt: Added.
        * fast/dom/getElementsByClassName/008.html: Added.
        * fast/dom/getElementsByClassName/009-expected.txt: Added.
        * fast/dom/getElementsByClassName/009.html: Added.
        * fast/dom/getElementsByClassName/010-expected.txt: Added.
        * fast/dom/getElementsByClassName/010.xml: Added.
        * fast/dom/getElementsByClassName/011-expected.txt: Added.
        * fast/dom/getElementsByClassName/011.xml: Added.
        * fast/dom/getElementsByClassName/012-expected.txt: Added.
        * fast/dom/getElementsByClassName/012.html: Added.
        * fast/dom/getElementsByClassName/013-expected.txt: Added.
        * fast/dom/getElementsByClassName/013.html: Added.
        * fast/dom/getElementsByClassName/014-expected.txt: Added.
        * fast/dom/getElementsByClassName/014.html: Added.
        * fast/dom/getElementsByClassName/array: Added.
        * fast/dom/getElementsByClassName/array/001-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/001.html: Added.
        * fast/dom/getElementsByClassName/array/002-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/002.html: Added.
        * fast/dom/getElementsByClassName/array/003-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/003.html: Added.
        * fast/dom/getElementsByClassName/array/004-expected.txt: Added.
        * fast/dom/getElementsByClassName/array/004.html: Added.
        * fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
        * fast/dom/getElementsByClassName/dumpNodeList.html: Added.
        * fast/dom/getElementsByClassName/resources: Added.
        * fast/dom/getElementsByClassName/resources/common.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Fri, 14 Dec 2007 20:50:30 +0000 (20:50 +0000)]
JavaScriptCore:

        Reviewed by Sam.

        - removed unnecessary includes of "Vector.h"

        * wtf/HashMap.h:
        (WTF::copyKeysToVector): Make the type of the vector be a template parameter.
        This allows copying keys into a vector of a base class or one with an inline capacity.
        (WTF::copyValuesToVector): Ditto.
        * wtf/HashSet.h:
        (WTF::copyToVector): Ditto.

WebCore:

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16351
          FontFallbackList.h doesn't include wtf/PassRefPtr.h

        * platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
        * platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix mistake causing nearly all tests to fail on Windows
darin@apple.com [Fri, 14 Dec 2007 20:42:24 +0000 (20:42 +0000)]
    - fix mistake causing nearly all tests to fail on Windows

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
        npos, not 0. Also pass URL in to URL function rather than passing the entire message.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
        than passing the entire message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix Tiger build
darin@apple.com [Fri, 14 Dec 2007 20:34:49 +0000 (20:34 +0000)]
    - fix Tiger build

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
        new-to-Leopard methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
darin@apple.com [Fri, 14 Dec 2007 20:25:33 +0000 (20:25 +0000)]
WebKit/mac:

        Reviewed by Brady.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16296
          <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called

        * WebView/WebView.mm:
        (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
        a didReceiveIcon method is present.

WebKitTools:

        * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
        since it now triggers unwanted icon loading. We only had it because we implemented "all"
        delegate methods here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Fri, 14 Dec 2007 20:03:16 +0000 (20:03 +0000)]
WebCore:

        Reviewed by Alexey.

        - http://bugs.webkit.org/show_bug.cgi?id=16420
          change regression tests to use document.execCommand instead of textInputController.doCommand

        Add a few more operations to document.execCommand.

        Finished up the transition to the new Editor::Command, including removing
        the Editor::execCommand function.

        * WebCore.base.exp: Added Editor::Command::isSupported.
        * editing/Editor.h: Removed execCommand.
        * editing/EditorCommand.cpp:
        (WebCore::expandSelectionToGranularity): Added.
        (WebCore::verticalScrollDistance): Added; replaces canScroll.
        (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView.
        (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
        (WebCore::executeDeleteForward): Ditto.
        (WebCore::executeDeleteToBeginningOfLine): Ditto.
        (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
        (WebCore::executeDeleteToEndOfLine): Ditto.
        (WebCore::executeDeleteToEndOfParagraph): Ditto.
        (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other
        Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by
        removing the explicit scrolling, and letting it be done automatically by code that makes
        the caret visible. In some cases the old code would scroll twice which was harmless but
        unnecessary.
        (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView.
        (WebCore::executeMovePageUp): See MovePageDown above.
        (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView.
        (WebCore::executeSelectLine): Ditto.
        (WebCore::executeSelectParagraph): Ditto.
        (WebCore::executeSelectSentence): Ditto.
        (WebCore::executeSelectWord): Ditto.
        (WebCore::executeSwapWithMark): Some small tweaks.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command()
        instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a
        bit more, but I didn't do that this time.

        - Removed some obsolete unused code.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for
        NSTextView. This was left over from when we used NSTextField and NSTextView for form
        elements and is no longer used at all.

        * page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side
        of the bridge or another. We really need to find a time to tear down the rest of the
        bridge, but that's not this patch.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly
        instead of using a method.
        (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        Took out obsolete comment about matching enums (we use a single enum now and have for some
        time).
        (-[WebCoreFrameBridge selectionGranularity]): Ditto.

WebKit:

        * StringsNotToBeLocalized.txt: Updated.

WebKit/gtk:

        Reviewed by Alexey.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command
        instead of Editor::execCommand.
        * WebView/webkitwebview.cpp: Ditto.

WebKit/mac:

        Reviewed by Alexey.

        - Changed a few more editing operations to use WebCore instead of WebKit.
        - Removed some obsolete unused code.

        * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
        defined and used on the WebKit side to here. These no longer belong on the bridge
        and should be moved to the WebFrame class (or elsewhere).
        * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.

        * WebView/WebFrameView.mm:
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
        (-[WebHTMLViewPrivate clear]): Ditto.
        (-[WebHTMLView _setMouseDownEvent:]): Ditto.
        (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
        pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
        to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
        disambiguated with the word "Move"). Added deleteBackward:,
        deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
        deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
        pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
        selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
        forwarded to WebCore.
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
        operations that we forward to WebCore. Instead, look up any command that WebCore can
        handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
        an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
        would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
        (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
        (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
        (-[WebHTMLView resignFirstResponder]): Ditto.
        (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.

        * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
        firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
        _willMakeFirstResponderForNodeFocus.

WebKit/qt:

        Reviewed by Alexey.

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction): Removed some use of Editor member functions we plan
        to eventually eliminate. Switch from Editor::execCommand to Editor::command.
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from
        MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret
        to MovePageDown.

WebKit/win:

        Reviewed by Alexey.

        * WebView.cpp:
        (WebView::execCommand): Switched from Editor::execCommand to Editor:command.
        Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from
        MoveDownByPageAndModifyCaret to MovePageDown.
        (WebView::copy): Switched from Editor::execCommand to Editor:command.
        (WebView::cut): Ditto.
        (WebView::paste): Ditto.
        (WebView::delete_): Ditto.

WebKit/wx:

        Reviewed by Alexey.

        * WebKitSupport/EditorClientWx.cpp:
        (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand
        to Edtor::command.

LayoutTests:

        Reviewed by Alexey.

        - http://bugs.webkit.org/show_bug.cgi?id=16420
          change regression tests to use document.execCommand instead of textInputController.doCommand

        To avoid changing results at this time, I didn't correct the many tests that now have
        misleading "this test cannot be run manually" text or references to "NSResponder" or
        uneeded instructions for running the test manually. We can do that on a later pass.

        * editing/deleting/5300379.html: Use execCommand instead of doCommand.
        * editing/deleting/delete-to-end-of-paragraph.html: Ditto.
        * editing/deleting/smart-delete-003.html: Ditto.
        * editing/deleting/smart-delete-004.html: Ditto.
        * editing/execCommand/nsresponder-indent.html: Ditto.
        * editing/execCommand/nsresponder-outdent.html: Ditto.
        * editing/selection/4947387.html: Ditto.
        * editing/selection/5195166-1.html: Ditto.
        * editing/selection/5195166-2.html: Ditto.
        * editing/selection/select-line.html: Ditto.
        * editing/selection/selection-actions.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Fri, 14 Dec 2007 19:55:37 +0000 (19:55 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
        * editing/CompositeEditCommand.h:
        * editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
        * editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between
        it and listNode, if they exists, so that moving listChildNode doesn't put it out
        of order.  Added a test case to cover each change.
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that
        tries to split a container at a bogus child, and an early return to avoid a
        hang in that case.

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

        * editing/execCommand/5575101-1-expected.txt: Added.
        * editing/execCommand/5575101-1.html: Added.
        * editing/execCommand/5575101-2-expected.txt: Added.
        * editing/execCommand/5575101-2.html: Added.
        * editing/execCommand/5575101-3-expected.txt: Added.
        * editing/execCommand/5575101-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
andersca@apple.com [Fri, 14 Dec 2007 19:47:16 +0000 (19:47 +0000)]
JavaScriptCore:

        Reviewed by Darin and Geoff.

        <rdar://problem/5619295>
        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.

        The way this used to work was that each NPObject that wrapped a JSObject would have a root object
        corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
        doing security checks).

        This would prevent a plug-in from accessing a frame's window object if it's security origin was different
        (some parts of the window, such as the location object, can be accessed from frames with different security
        origins, and those checks are being done in WebCore).

        Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
        Window JSObject being garbage collected and the NPObject pointing to freed memory.

        How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
        for a plug-in will have the root object of the containing frame of that plug-in.

        * bindings/NP_jsobject.cpp:
        (jsDeallocate):
        Don't free the origin root object.

        (_NPN_CreateScriptObject):
        Remove the origin root object parameter.

        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_Evaluate):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        (_NPN_Enumerate):
        Get rid of all security checks.

        * bindings/NP_jsobject.h:
        Remove originRootObject from the JavaScriptObject struct.

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant):
        Always use the root object from the ExecState.

WebCore:

        Reviewed by Darin and Geoff.

        <rdar://problem/5619295>
        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        _NPN_CreateScriptObject doesn't take an origin root object anymore.

        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::createNPObject):
        * page/Frame.cpp:
        (WebCore::Frame::windowScriptNPObject):

WebKitTools:

        Reviewed by Darin and Geoff.

        <rdar://problem/5619295>
        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Add property getting methods to the plug-in.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginInvoke):

LayoutTests:

        Reviewed by Darin and Geoff.

        <rdar://problem/5619295>
        REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

        Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
        top-level frame.

        * http/tests/plugins/cross-frame-object-access-expected.txt: Added.
        * http/tests/plugins/cross-frame-object-access.html: Added.
        * http/tests/plugins/resources/cross-frame-object-access.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 14 Dec 2007 19:37:12 +0000 (19:37 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5643663> text-shadow and box-shadow offsets 1px smaller than specified
          which is the root cause of:
          http://bugs.webkit.org/show_bug.cgi?id=12943
          box-shadow: small values don't affect shadow position
          http://bugs.webkit.org/show_bug.cgi?id=14736
          Safari implementation of text-shadow off by 1px

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude
        of the offsets passed to CGContextSetShadow* to ensure that the end
        result after truncation is the desired integer offsets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove layout test to mac skipped list until mac frt bug fixed.
oliver@apple.com [Fri, 14 Dec 2007 18:34:16 +0000 (18:34 +0000)]
Move layout test to mac skipped list until mac frt bug fixed.

Reviewed by Adam.

Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
kmccullough@apple.com [Fri, 14 Dec 2007 18:19:15 +0000 (18:19 +0000)]
    Reviewed by Darin.

        - Layout test fix for mac. When dumped to the console local file paths
        now only show the name of the resource not the whole path.  This is to
        make the results machine and OS independent.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:addMessageToConsole:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 14 Dec 2007 06:56:45 +0000 (06:56 +0000)]
2007-12-13  Alp Toker  <alp@atoker.com>

        curl backend build fix for breakage introduced in r28709.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Fri, 14 Dec 2007 05:32:35 +0000 (05:32 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        <rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element

        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Equip this function to
        handle editing positions, like [input, 0];
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Pass enclosingBlock a node peeled
        off of a non-editing position, to fix a bug where the enclosing block of [input, 0] was
        the input element itself.
        Insert a <br> when a <form> element is the enclosing block instead of splitting/cloning or
        nesting a <div>.

LayoutTests:

        Reviewed by Oliver Hunt.

        <rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element

        * editing/inserting/5607069-1-expected.checksum: Added.
        * editing/inserting/5607069-1-expected.png: Added.
        * editing/inserting/5607069-1-expected.txt: Added.
        * editing/inserting/5607069-1.html: Added.
        * editing/inserting/5607069-2.html: Added.
        * editing/inserting/5607069-3.html: Added.
        * platform/mac/editing/inserting/5607069-2-expected.checksum: Added.
        * platform/mac/editing/inserting/5607069-2-expected.png: Added.
        * platform/mac/editing/inserting/5607069-2-expected.txt: Added.
        * platform/mac/editing/inserting/5607069-3-expected.checksum: Added.
        * platform/mac/editing/inserting/5607069-3-expected.png: Added.
        * platform/mac/editing/inserting/5607069-3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 14 Dec 2007 03:37:49 +0000 (03:37 +0000)]
2007-12-13  Alp Toker  <alp@atoker.com>

        Reviewed by Oliver Hunt.

        http://bugs.webkit.org/show_bug.cgi?id=16365
        [cURL] Acid2 test segmentation fault

        This patch makes the Acid2 test pass.

        Defer the cleanup of cancelled jobs and halt further transfer as early
        as possible.

        Bug found by and initial patch provided by Luca Bruno.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::writeCallback):
        (WebCore::headerCallback):
        (WebCore::ResourceHandleManager::downloadTimerCallback):
        (WebCore::ResourceHandleManager::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
weinig@apple.com [Fri, 14 Dec 2007 03:32:18 +0000 (03:32 +0000)]
    Reviewed by Mark Rowe.

        Fix typos and rename InspectorController::moveByUnrestricted to InspectorController::moveWindowBy.

        * page/InspectorController.cpp:
        (WebCore::moveByUnrestricted):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::moveWindowBy):
        * page/InspectorController.h:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 14 Dec 2007 02:25:29 +0000 (02:25 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function

        Test: fast/css/transition-timing-function.html

        * css/CSSStyleSelector.cpp: Changed the HANDLE_MULTILAYER_VALUE macro to
        not reject non-primitive non-list values, and instead made sure that the
        mapping functions rejected them if necessary. This allows non-primitive
        timing functions to be mapped.
        (WebCore::CSSStyleSelector::mapBackgroundAttachment):
        (WebCore::CSSStyleSelector::mapBackgroundClip):
        (WebCore::CSSStyleSelector::mapBackgroundComposite):
        (WebCore::CSSStyleSelector::mapBackgroundOrigin):
        (WebCore::CSSStyleSelector::mapBackgroundImage):
        (WebCore::CSSStyleSelector::mapBackgroundRepeat):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        (WebCore::CSSStyleSelector::mapTransitionDuration):
        (WebCore::CSSStyleSelector::mapTransitionRepeatCount):
        (WebCore::CSSStyleSelector::mapTransitionTimingFunction):
        (WebCore::CSSStyleSelector::mapTransitionProperty):
        * css/CSSTimingFunctionValue.cpp:
        (WebCore::CSSTimingFunctionValue::cssText): Implemented for use in the
        regression test.
        * css/CSSTimingFunctionValue.h:
        (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue):
        Added. Returns true.
        * css/CSSValue.h:
        (WebCore::CSSValue::isTransitionTimingFunctionValue): Added. Returns
        false.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function

        * fast/css/transition-timing-function-expected.txt: Added.
        * fast/css/transition-timing-function.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
mjs@apple.com [Fri, 14 Dec 2007 02:14:58 +0000 (02:14 +0000)]
    Reviewed by Oliver.

        - Add some explanatory test and a dumb logo to SunSpider web hosted version

        * hosted/sunspider-driver.html:
        * hosted/sunspider-results.html:
        * hosted/sunspider.css:
        * hosted/sunspider.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
kmccullough@apple.com [Fri, 14 Dec 2007 02:07:18 +0000 (02:07 +0000)]
WebKitTools:

        Reviewed by Adam.

        - Layout tests fix.  We need a way to remove machine-dependent
        information from paths in layout test results. The UIDelegate now does
        this.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (urlSuitableForTestResult):
        * DumpRenderTree/win/DumpRenderTreeWin.h:
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::webViewAddMessageToConsole):

LayoutTests:

        Reviewed by Adam.

        - Layout tests fix.  Removed machine dependant results and generated new
        results without machine specific information.

        * fast/dom/frame-loading-via-document-write-expected.txt: Added.
        * http/tests/security/frame-loading-via-document-write-expected.txt: Added.
        * http/tests/security/local-CSS-from-remote-expected.txt:
        * http/tests/security/local-JavaScript-from-remote-expected.txt:
        * http/tests/security/local-iFrame-from-remote-expected.txt:
        * http/tests/security/local-image-from-remote-expected.txt:
        * platform/mac/fast/dom/frame-loading-via-document-write-expected.checksum: Removed.
        * platform/mac/fast/dom/frame-loading-via-document-write-expected.png: Removed.
        * platform/mac/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
        * platform/mac/http/tests/security: Removed.
        * platform/mac/http/tests/security/frame-loading-via-document-write-expected.checksum: Removed.
        * platform/mac/http/tests/security/frame-loading-via-document-write-expected.png: Removed.
        * platform/mac/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
        * platform/win/Skipped:
        * platform/win/http: Removed.
        * platform/win/http/tests: Removed.
        * platform/win/http/tests/security: Removed.
        * platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
sfalken@apple.com [Fri, 14 Dec 2007 01:23:11 +0000 (01:23 +0000)]
WebCore:

        Move source file generation into its own vcproj to fix build dependencies.

        Reviewed by Adam.

        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.submit.sln:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreGenerated.vcproj: Added.

WebKit/win:

        Move source file generation into its own vcproj to fix build dependencies.

        Reviewed by Adam.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/InterfacesGenerated.vcproj: Added.
        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.submit.sln:
        * WebKit.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build.
justin.garcia@apple.com [Fri, 14 Dec 2007 01:22:39 +0000 (01:22 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
justin.garcia@apple.com [Fri, 14 Dec 2007 01:12:02 +0000 (01:12 +0000)]
    Reviewed by Oliver Hunt.

        <rdar://problem/4145786> Undoing a color change of text in a compose window always changes it back to black

        Some of the operations performed in removeHTMLFontStyle were non-undoable.

        I'm having trouble writing a layout test for this because I can't get DRT to
        perform editing operations in separate Undo steps without adding unacceptably long
        wait times between operations.  I filed:

        <rdar://problem/5646779> Can't get DRT to perform editing operations in separate Undo steps

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeHTMLFontStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders.
weinig@apple.com [Fri, 14 Dec 2007 01:10:00 +0000 (01:10 +0000)]
    Reviewed by Anders.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16352
        Toolbar dragged inspector cannot be moved beyond screen edges

        * page/InspectorController.cpp:
        (WebCore::moveByUnrestricted):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::moveByUnrestricted):
        * page/InspectorController.h:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
aroben@apple.com [Fri, 14 Dec 2007 01:07:19 +0000 (01:07 +0000)]
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

WebCore:

        Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

        Windows Media Player has a modal message loop that will deliver
        messages to us at inappropriate times and we will crash if we handle
        them when they are delivered. In PluginViewWin, we add a quirk for
        Media Player to set a flag whenever we give the plugin a chance to
        execute code, and in SharedTimerWin we check if the plugin is
        executing code and repost messages if so.

        Reviewed by Anders.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::TimerWindowWndProc): Repost messages if we're calling a
        plugin.
        * plugins/win/PluginViewWin.cpp: Surround all calls to the plugin with
        setCallingPlugin(true/false).
        (WebCore::PluginViewWin::updateWindow):
        (WebCore::PluginViewWin::dispatchNPEvent):
        (WebCore::PluginViewWin::setNPWindowRect):
        (WebCore::PluginViewWin::start):
        (WebCore::PluginViewWin::stop):
        (WebCore::PluginViewWin::performRequest):
        (WebCore::PluginViewWin::bindingInstance):
        (WebCore::PluginViewWin::determineQuirks):
        (WebCore::PluginViewWin::setCallingPlugin): Added.
        (WebCore::PluginViewWin::isCallingPlugin): Added.
        * plugins/win/PluginViewWin.h: Added a new quirk.

WebKit/win:

        Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

        Reviewed by Anders.

        * WebView.cpp:
        (WebViewWndProc): Repost paint messages and ignore all other messages
        when we're calling a plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 14 Dec 2007 00:56:10 +0000 (00:56 +0000)]
2007-12-13  Alp Toker  <alp@atoker.com>

        Build fix for DRT breakage introduced in r28690.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pathToLocalResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 14 Dec 2007 00:32:23 +0000 (00:32 +0000)]
2007-12-13  Alp Toker  <alp@atoker.com>

        Add a missing DEPENDPATH. Fixes non-clean builds following networking
        header changes.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
sfalken@apple.com [Thu, 13 Dec 2007 23:48:14 +0000 (23:48 +0000)]
JavaScriptCore:

        Move source file generation into its own vcproj to fix build dependencies.

        Reviewed by Adam.

        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:

WebKit/win:

        Fix project dependencies based on JavaScriptCore change.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Thu, 13 Dec 2007 22:59:42 +0000 (22:59 +0000)]
    Reviewed by Anders Carlsson.

        - fix regression in fast/text/international/bidi-override on Tiger

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage): Add bidi overrides here
        too. I forgot to add them when I added them to treatAsZeroWidthSpace in
        an earlier patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
ap@webkit.org [Thu, 13 Dec 2007 22:17:13 +0000 (22:17 +0000)]
    Reviewed by Adele.

        http://bugs.webkit.org/show_bug.cgi?id=16421
        REGRESSION(r28669): Page scrolls down when you hit space key in text area

        Test: fast/events/space-scroll-event.html

        * WebView.cpp:
        (WebView::keyDown):
        (WebView::keyPress):
        Moved space handliing to keyPress() to fix this bug and to match IE. Scrolling via arrow keys is correctly handled
        in keyDown().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 13 Dec 2007 21:32:12 +0000 (21:32 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text

        The code that checks the selected Range to see if it's inside an anchor
        checks ancestors of the Range's commonAncestor() but not the
        commonAncestor() itself, and so we'd fail to add markup for the enclosing
        anchor to the pasteboard.

        Some enclosing element getters check the node passed to the getter and some
        don't.  There were a few places where we incorrectly assumed that enclosing
        element getters check the node passed to the getter, but this is the only
        case that I'm able to write a test case for at the moment.

        In this patch I've:
        Changed enclosingNodeWithType and enclosingNodeWithTag to take in positions,
        like the newer enclosing element getters.  This is important because we must
        soon add code to the getters so that they understand that some editing positions
        inside nodes don't actually refer to positions inside those nodes but positions
        before and after them.  Like [table, 0].
        Changed enclosingNodeWithType and enclosingNodeWithTag to check nodes starting with
        n where [n, o] is the position passed to the getter, instead of starting the the parent
        of n.  This makes all but a few of the enclosing element getters behave consistently.
        Changed enclosingNodeWithType and enclosingNodeWithTag to not return non-editable
        nodes if the input position was editable.  This fixes a bug that that the above change
        exposed.
        Changed enclosingTableCell to simply call enclosingNodeWithType.  We should do
        this for the rest of the getters, or simply remove them in favor of enclosingNodeWithType
        unless doing so would affect readability, like it would in the case of enclosingTableCell.
        Ditto for enclosingBlock.

        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::doApply):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionUnorderedListState):
        (WebCore::Editor::selectionOrderedListState):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMerge):
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
        (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
        * editing/TextIterator.cpp:
        * editing/htmlediting.cpp:
        (WebCore::enclosingBlock):
        (WebCore::enclosingNodeWithTag):
        (WebCore::enclosingNodeOfType):
        (WebCore::enclosingTableCell):
        (WebCore::isTableCell):
        * editing/htmlediting.h:
        * editing/markup.cpp:
        (WebCore::appendStartMarkup):
        (WebCore::createMarkup):

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text

        * editing/pasteboard/5601583-1.html: Added.
        * platform/mac/editing/pasteboard/5601583-1-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5601583-1-expected.png: Added.
        * platform/mac/editing/pasteboard/5601583-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 13 Dec 2007 20:40:29 +0000 (20:40 +0000)]
    Reviewed by Darin.

        Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 13 Dec 2007 19:38:13 +0000 (19:38 +0000)]
2007-12-13  Alp Toker  <alp@atoker.com>

        http://bugs.webkit.org/show_bug.cgi?id=16406
        [Gtk] JavaScriptCore needs -lpthread

        Build fix for Debian and any other platforms that don't implicitly
        link to pthread.

        Link to pthread on non-Windows platforms until this dependency is
        removed from JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - build fix
mitz@apple.com [Thu, 13 Dec 2007 19:36:57 +0000 (19:36 +0000)]
    - build fix

        * platform/network/cf/ResourceErrorCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
kmccullough@apple.com [Thu, 13 Dec 2007 19:07:39 +0000 (19:07 +0000)]
WebKitTools:

        Reviewed by Alice and Sam.

        - <rdar://5621435> Need a way to specify local resources (being loaded
        from HTTP tests) on Windows.
        - Implemented pathToLocalResource which exposes the functionality of
        converting a given unix path to the correct location on Windows.

        * DumpRenderTree/LayoutTestController.cpp:
        (pathToLocalResourceCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::pathToLocalResource):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::pathToLocalResource):

LayoutTests:

        Reviewed by Alice and Sam.

        - <rdar://5621435> Need a way to specify local resources (being loaded
        from HTTP tests) on Windows.
        - Updated the following tests to use the new layoutTestController
        function, pathToLocalResource to get a Windows viable path (when on
        Windows) to the local resources they are attempting to access.
        - Also clarified and updated some results.

        * fast/dom/frame-loading-via-document-write.html:
        * fast/loader/local-CSS-from-local-expected.txt:
        * fast/loader/local-CSS-from-local.html:
        * fast/loader/local-JavaScript-from-local-expected.txt:
        * fast/loader/local-JavaScript-from-local.html:
        * fast/loader/local-iFrame-source-from-local-expected.txt:
        * fast/loader/local-iFrame-source-from-local.html:
        * fast/loader/local-image-from-local-expected.txt:
        * fast/loader/local-image-from-local.html:
        * http/tests/security/frame-loading-via-document-write.html:
        * http/tests/security/local-CSS-from-remote-expected.txt:
        * http/tests/security/local-CSS-from-remote.html:
        * http/tests/security/local-JavaScript-from-remote-expected.txt:
        * http/tests/security/local-JavaScript-from-remote.html:
        * http/tests/security/local-iFrame-from-remote-expected.txt:
        * http/tests/security/local-iFrame-from-remote.html:
        * http/tests/security/local-image-from-remote-expected.txt:
        * http/tests/security/local-image-from-remote.html:
        * http/tests/security/local-user-CSS-from-remote.html:
        * platform/mac/fast/dom/frame-loading-via-document-write-expected.txt:
        * platform/win/Skipped:
        * platform/win/http: Added.
        * platform/win/http/tests: Added.
        * platform/win/http/tests/security: Added.
        * platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Hatcher.
antti@apple.com [Thu, 13 Dec 2007 18:55:28 +0000 (18:55 +0000)]
    Reviewed by Tim Hatcher.

        Fix <rdar://problem/5605674>
        Make <video> display WebKit context menu instead of the QTKit one.

        It doesn't really matter where the QTMovieView is.

        * ChangeLog:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView):
        (WebCore::MediaPlayerPrivate::setRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 13 Dec 2007 18:45:03 +0000 (18:45 +0000)]
WebCore:

        Reviewed by Adam Roben.

        - ensure that Unicode bidi control characters are rendered as zero width
          spaces

        Test: fast/text/international/bidi-control-chars-treated-as-ZWS.html

        * platform/graphics/Font.h:
        (WebCore::Font::treatAsZeroWidthSpace):
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage):
        * platform/text/CharacterNames.h:

LayoutTests:

        Reviewed by Adam Roben.

        - test that Unicode bidi control characters are rendered as zero width
          spaces

        * fast/text/international/bidi-control-chars-treated-as-ZWS.html: Added.
        * platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
        * platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
        * platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
mjs@apple.com [Thu, 13 Dec 2007 09:50:18 +0000 (09:50 +0000)]
    Reviewed by Oliver.

        - Make the web-hosted version of SunSpider look a little bit less drab.

        * hosted/sunspider-driver.html:
        * hosted/sunspider-results.html:
        * hosted/sunspider.css: Added.
        * hosted/sunspider.html:
        * resources/TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
beidson@apple.com [Thu, 13 Dec 2007 08:24:05 +0000 (08:24 +0000)]
    Build fix

        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
beidson@apple.com [Thu, 13 Dec 2007 07:55:20 +0000 (07:55 +0000)]
    Build fix

        * platform/gtk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
beidson@apple.com [Thu, 13 Dec 2007 07:51:56 +0000 (07:51 +0000)]
    Build fix

        * WebCore.pro:
        * history/qt/CachedPageQt.cpp: Removed. Whole purpose for this method being platform-specific has been removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
beidson@apple.com [Thu, 13 Dec 2007 07:28:42 +0000 (07:28 +0000)]
    Build fix

        * platform/win/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 13 Dec 2007 07:17:21 +0000 (07:17 +0000)]
WebCore:

        Reviewed by Sam Weinig

        Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

        All back/forward list and page cache related items used to be in WebKit.
        When they were pushed into WebCore, some sloppy compromises were made to keep the Back/Forward cache working on Mac.
        Namely, a WebCore::HistoryItem had to know how to keep a WebDocumentView alive.  We accomplished this via some #ifdefs
        in CachedPage and having the Mac-only CachedPageMac.mm

        To get rid of that nastiness and pave the way for adding Back/Forward cache on other platforms, this patch adds the
        concept of "CachedPagePlatformData" which can contain anything the platform API wants.

        I also took the opportunity to do other cleanup and renaming client methods to better fit their new purposes.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * history/CachedPage.cpp:
        (WebCore::CachedPage::~CachedPage): Combined "close()" and "clear()" to just "clear()" - call it from here.
        (WebCore::CachedPage::clear): Call clear() on the CachedPagePlatformData if it exists.  Also delete the CachedPagePlatformData.
        (WebCore::CachedPage::setCachedPagePlatformData):
        (WebCore::CachedPage::cachedPagePlatformData):
        * history/CachedPage.h:

        * history/CachedPagePlatformData.h: Added.
        (WebCore::CachedPagePlatformData::~CachedPagePlatformData): Virtual d'tor.
        (WebCore::CachedPagePlatformData::clear): Virtual method for platforms that need to do cleanup at the same time as CachedPage::clear().

        * history/PageCache.cpp:
        (WebCore::PageCache::releaseAutoreleasedPagesNow): Call "clear()" instead of "close()"

        * history/mac/CachedPageMac.mm: Removed. Functionality replaced with CachedPagePlatformData.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted): Call the new client methods.  Make some work previously done by WebKitMac cross platform
          (setting the cached DocumentLoader to the Frame).
        (WebCore::FrameLoader::cachePageForHistoryItem):  Renamed the client methods

        * loader/FrameLoaderClient.h:  The very Mac-centric "makeDocumentView", "setDocumentViewFromCachedPage", and "saveDocumentViewToCachedPage"
          become "transitionToCommittedForNewPage", "transitionToCommittedFromCachedPage", and "savePlatformDataToCachedPage" accordingly

        * svg/graphics/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::savePlatformDataToCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedForNewPage):

WebKit:

        Reviewed by Sam Weinig

                Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

        * WebKit.xcodeproj/project.pbxproj: Added a new file

WebKit/gtk:

        Reviewed by Sam Weinig

        As part of doing some CachedPage and client cleanup, keep GTK building

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::savePlatformDataToCachedPage):
        (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage):
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

        Reviewed by Sam Weinig

        Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

        * WebCoreSupport/WebCachedPagePlatformData.h: Added.
        (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
        (WebCachedPagePlatformData::clear):
        (WebCachedPagePlatformData::webDocumentView):

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::savePlatformDataToCachedPage):
        (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here,
          because that is now done in WebCore.
        (WebFrameLoaderClient::transitionToCommittedForNewPage):

WebKit/qt:

        Reviewed by Sam Weinig

        As part of doing some CachedPage and client cleanup, keep Qt building

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::savePlatformDataToCachedPage):
        (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedPage):
        (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

        Reviewed by Sam Weinig

        Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

        Even though this new code isn't exercised yet because the page cache is still turned off for Windows, local testing
        has indicated it works well.

        * WebCachedPagePlatformData.h: Added.
        (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes an IWebDataSource and the object retains it
        (WebCachedPagePlatformData::clear):
        (WebCachedPagePlatformData::webDataSource):

        * WebFrame.cpp:
        (WebFrame::savePlatformDataToCachedPage):
        (WebFrame::transitionToCommittedFromCachedPage):
        (WebFrame::transitionToCommittedForNewPage):
        * WebFrame.h:

        * WebKit.vcproj/WebKit.vcproj:

WebKit/wx:

        Reviewed by Sam Weinig

        As part of doing some CachedPage and client cleanup, keep Wx building

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::savePlatformDataToCachedPage):
        (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedPage):
        (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 13 Dec 2007 07:04:30 +0000 (07:04 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        - fix <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): When the font property is
        set to 'initial', set the font size to its initial value, 'medium',
        and the font family to the standard family.

LayoutTests:

        Reviewed by Oliver Hunt.

        - updated results and skipped tests file for
          <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

        * platform/mac-leopard/fast/text/font-initial-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.checksum.
        * platform/mac-leopard/fast/text/font-initial-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.png.
        * platform/mac/fast/text/font-initial-expected.checksum: Removed.
        * platform/mac/fast/text/font-initial-expected.png: Removed.
        * platform/mac/fast/text/font-initial-expected.txt:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 13 Dec 2007 06:56:28 +0000 (06:56 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
        Don't remove the table row that contained the end of the selection if it is where we are
        about to place the ending selection.
        Don't remove all empty rows after the row that contained the start of the selection,
        they might come after the row that contained the end of the selection.

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

        * editing/deleting/5433862-1-expected.txt: Added.
        * editing/deleting/5433862-1.html: Added.
        * editing/deleting/5433862-2.html: Added.
        * platform/mac/editing/deleting/5433862-2-expected.checksum: Added.
        * platform/mac/editing/deleting/5433862-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
mjs@apple.com [Thu, 13 Dec 2007 05:33:50 +0000 (05:33 +0000)]
    Reviewed by Sam.

        - Change sunspider-compare-results output from showing "% faster" values to "x as fast" values.

        A sample of what new-style results would look like:

        TEST                   COMPARISON            FROM                 TO             DETAILS
        ...
        ** TOTAL **:           1.41x as fast     6613.6ms +/- 0.1%   4703.0ms +/- 0.1%     significant
        ...
            3bit-bits-in-byte: *1.36x as slow*     88.8ms +/- 0.6%    121.1ms +/- 0.6%     significant

        * resources/sunspider-compare-results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
weinig@apple.com [Thu, 13 Dec 2007 01:47:30 +0000 (01:47 +0000)]
    Reviewed by Anders Carlsson.

        Add button to clear the Web Inspector's console.

        * English.lproj/InspectorLocalizedStrings.js:
        * page/inspector/ConsolePanel.js:
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam and Jon.
andersca@apple.com [Thu, 13 Dec 2007 00:44:21 +0000 (00:44 +0000)]
    Reviewed by Adam and Jon.

        <rdar://problem/5349282>
        popup blocking is not applied to plugins on Windows.

        Implement popup blocking. If the plug-in supports the new
        NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState API we just use that
        to determine if a plug-in request can open new windows.

        If a plug-in does not support the new API, we assume that a plug-in can open new windows
        in response to either mouse click or key press events.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginRequestWin::PluginRequestWin):
        (WebCore::PluginRequestWin::shouldAllowPopups):
        Add new shouldAllowPopups member.

        (WebCore::PluginViewWin::popPopupsStateTimerFired):
        Reset the popup state.

        (WebCore::isWindowsMessageUserGesture):
        New function that given a windows message id returns whether it's a user gesture or not.

        (WebCore::PluginViewWin::wndProc):
        Allow popups if the window message is a user gesture.

        (WebCore::PluginViewWin::dispatchNPEvent):
        New method that dispatches an NPEvent, turning on popups if necessary.

        (WebCore::PluginViewWin::paint):
        (WebCore::PluginViewWin::handleKeyboardEvent):
        (WebCore::PluginViewWin::handleMouseEvent):
        Call dispatchNPEvent().

        (WebCore::PluginViewWin::performRequest):
        (WebCore::PluginViewWin::load):
        Add calls to shouldAllowPopups().

        (WebCore::PluginViewWin::pushPopupsEnabledState):
        (WebCore::PluginViewWin::popPopupsEnabledState):
        New methods that maintain the popup state stack.

        (WebCore::PluginViewWin::arePopupsAllowed):
        New method that returns whether popups are allowed.

        (WebCore::PluginViewWin::PluginViewWin):
        * plugins/win/PluginViewWin.h:
        Add new instance variables.

        * plugins/win/npapi.cpp:
        (NPN_PushPopupsEnabledState):
        (NPN_PopPopupsEnabledState):
        Implement these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 13 Dec 2007 00:23:34 +0000 (00:23 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix a bug in debug builds only where selecting an earlier item in
          a popup selects the first item

        Test: fast/forms/menulist-selection-reset.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcListItems): Added an argument that
        tells that function whether it should update the selected state of
        option elements.
        (WebCore::HTMLSelectElement::checkListItems): Changed to pass false
        as the above argument.
        * html/HTMLSelectElement.h:

LayoutTests:

        Reviewed by John Sullivan.

        - test for a bug in debug builds only where selecting an earlier item in
          a popup selects the first item

        * fast/forms/menulist-selection-reset-expected.txt: Added.
        * fast/forms/menulist-selection-reset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOOPS!
bdakin@apple.com [Thu, 13 Dec 2007 00:02:21 +0000 (00:02 +0000)]
OOPS!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
adele@apple.com [Wed, 12 Dec 2007 23:56:03 +0000 (23:56 +0000)]
    Reviewed by Geoff.

        Fix for <rdar://problem/5643054> Remove cue point implementation for media elements

        When the specification for cue ranges is more final, we will implement those.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::~HTMLMediaElement):
        (WebCore::HTMLMediaElement::load):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::setEndTime):
        (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded):
        (WebCore::MediaPlayerPrivate::endPointTimerFired):
        (WebCore::MediaPlayerPrivate::timeChanged):
        (WebCore::MediaPlayerPrivate::didEnd):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded):
        (WebCore::MediaPlayerPrivate::endPointTimerFired):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Nico.
bdakin@apple.com [Wed, 12 Dec 2007 23:35:17 +0000 (23:35 +0000)]
    Reviewed by Nico.

        Updated pixel results from my recent SVG change.

        * svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
        * svg/custom/inline-svg-in-xhtml-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-12 MorganL <morganl.webkit@yahoo.com> -- http://bugs.webkit.org/show_bug...
oliver@apple.com [Wed, 12 Dec 2007 22:37:24 +0000 (22:37 +0000)]
2007-12-12  MorganL  <morganl.webkit@yahoo.com> -- bugs.webkit.org/show_bug.cgi?id=16408

        Reviewed by Maciej.

        Fixes:
        http://bugs.webkit.org/show_bug.cgi?id=16408

        When navigating back/forward to a http:// link, we should prefer to
        load from cache if possible.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Wed, 12 Dec 2007 22:15:40 +0000 (22:15 +0000)]
WebCore:

        Reviewed by Sam.

        <rdar://problem/5132003>
        dumpResourceLoadCallbacks is not implemented in DRT on Windows.

        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::unpackPlatformError):
        Handle kCFErrorDomainWinSock.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):
        Ignore willSendRequest calls where the redirect response is null, like we do in
        the Mac version.

WebKitTools:

        Reviewed by Sam.

        <rdar://problem/5132003>
        dumpResourceLoadCallbacks is not implemented in DRT on Windows.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):
        Set the resource load delegate.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

        * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
        * DumpRenderTree/win/ResourceLoadDelegate.h: Added.

LayoutTests:

        Reviewed by Sam.

        <rdar://problem/5132003>
        dumpResourceLoadCallbacks is not implemented in DRT on Windows.

        Remove now passing tests.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5643785> Fix iBench regression caused by mis-placed nested...
sfalken@apple.com [Wed, 12 Dec 2007 22:14:48 +0000 (22:14 +0000)]
    <rdar://problem/5643785> Fix iBench regression caused by mis-placed nested timer check.

        Reviewed by Anders.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::TimerWindowWndProc): Don't set high-resolution timer flag inside non-high-resolution timer proc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Wed, 12 Dec 2007 21:46:23 +0000 (21:46 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.make: Copy only what we need out of obj/bin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
bdakin@apple.com [Wed, 12 Dec 2007 21:24:23 +0000 (21:24 +0000)]
    Reviewed by Oliver.

        Fix for <rdar://problem/5643770> REGRESSION: Free-standing SVGs
        with width and height 100% clip to 300 x 150

        Though it was correct in an earlier iteration of my patch, it is
        not sufficient in the final, committed version to ask if the
        relativeWidthValue() or relativeHeightValue() is greater than 0
        just to determine if one has been set, for, they are now
        initialized to 300 and 150 respectively! This patch instead adds a
        bool to keep track of whether a container size has been set, and
        only used the relative value if it has.

        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcViewport):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::setContainerSize):
        (WebCore::SVGSVGElement::hasSetContainerSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Steve Falkenburg
beidson@apple.com [Wed, 12 Dec 2007 19:26:27 +0000 (19:26 +0000)]
    Reviewed by Steve Falkenburg

        <rdar://problem/5012636> - WebURLProtectionSpace::realm returns the hostname rather than the authentication realm

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::ProtectionSpace): Assign the realm to m_realm, instead of the host

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Wed, 12 Dec 2007 17:57:37 +0000 (17:57 +0000)]
    Reviewed by Adam Roben.

        Fix conversion from double to LPARAM in dispatchMessage().

        * DumpRenderTree/win/EventSender.cpp:
        (dispatchMessageCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 12 Dec 2007 17:34:01 +0000 (17:34 +0000)]
2007-12-12  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=16388
        [GTK] Widget::setCursor() gets called frequently

        Cache the current cursor to avoid calling gdk_window_set_cursor() when
        there's no change in cursor.

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::cursor):
        (WebCore::Widget::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-12 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Wed, 12 Dec 2007 17:27:05 +0000 (17:27 +0000)]
2007-12-12  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=16342
        Build Warning and Error fixes in WebCore GTK+

        Use C-style casts for casting function pointers to gpointer
        Use static_cast<int> to cast a float to int to fix a warning

        * platform/gtk/PlatformScrollBarGtk.cpp:
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::gtkValueChanged):
        * platform/gtk/ThreadingGtk.cpp:
        (callFunctionOnMainThread):
        (callOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 12 Dec 2007 16:59:30 +0000 (16:59 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - better fix for a crash when pressing a key that is not associated
          with a command

        * editing/EditorCommand.cpp:
        (WebCore::Editor::command): Return the empty command if the command name
        is empty.

WebKit/win:

        Reviewed by Darin Adler.

        - revert my earlier crash fix after making WebCore return the empty
          editor command for the empty command name.

        * WebView.cpp:
        (WebView::handleEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Wed, 12 Dec 2007 16:57:56 +0000 (16:57 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=16410
        Implement isKeypadEvent() on Windows

        Test: platform/win/fast/events/keyLocation-numpad.html

        * platform/win/KeyEventWin.cpp:
        (WebCore::isKeypadEvent): Added.
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Also fixed a mistake with autorepeat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 12 Dec 2007 16:27:35 +0000 (16:27 +0000)]
2007-12-12  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=16302
        [GTK] Compiler flags for optimization

        Use the compiler flags -fno-exceptions -fno-rtti.

        This patch does not add all the flags discussed in the bug report,
        only these two.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove an incorrect svn:executable property.
ap@webkit.org [Wed, 12 Dec 2007 16:25:27 +0000 (16:25 +0000)]
Remove an incorrect svn:executable property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
mrowe@apple.com [Wed, 12 Dec 2007 16:24:17 +0000 (16:24 +0000)]
Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.

Reviewed by Dave Kilzer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 12 Dec 2007 16:14:48 +0000 (16:14 +0000)]
2007-12-12  Alp Toker  <alp@atoker.com>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=15576
        [GTK] Printing support

        Add printing support.

        The API will be kept internal for the time being, but printing can now
        be triggered by Web pages or the JSC API using JavaScript.

        The print spooler and pagination code is fairly abstract and could be
        shared by other ports including Win and Qt once complete. It doesn't
        have header/footer support yet.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::print):
        * WebView/webkitprivate.h:
        * WebView/webkitwebframe.cpp:
        (PrintContext::begin_print):
        (PrintContext::draw_page):
        (PrintContext::end_print):
        (PrintContext::webkit_web_frame_print):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
ap@webkit.org [Wed, 12 Dec 2007 11:33:56 +0000 (11:33 +0000)]
    Reviewed by Oliver.

        http://bugs.webkit.org/show_bug.cgi?id=15248
        Can not enter accented characters using alt-numeric keypad

        * platform/win/fast/events/alt-numpad-expected.txt: Added.
        * platform/win/fast/events/alt-numpad.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5071781> window.mouseout events are not sent to window when mouse...
oliver@apple.com [Wed, 12 Dec 2007 10:57:15 +0000 (10:57 +0000)]
<rdar://problem/5071781> window.mouseout events are not sent to window when mouse moves out of window

Reviewed by Maciej.

Hook up the windows mouse tracking logic to allow us to detect the mouse leaving the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/gtk:
weinig@apple.com [Wed, 12 Dec 2007 08:41:12 +0000 (08:41 +0000)]
WebKit/gtk:

        Build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::didChangeTitle):

WebKit/qt:

        Build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::userAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Mac release build.
weinig@apple.com [Wed, 12 Dec 2007 08:40:37 +0000 (08:40 +0000)]
    Fix Mac release build.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Wed, 12 Dec 2007 08:13:01 +0000 (08:13 +0000)]
WebCore:

        Build fix for Qt, Gtk, and Wx.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * loader/win/FrameLoaderWin.cpp:
        (WebCore::FrameLoader::urlSelected):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):
        (WebCore::ResourceHandleManager::startJob):
        * platform/network/win/CookieJarWin.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::start):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeURL):

WebKit/gtk:

        Build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/qt:

        Build fix.

        * Api/qwebnetworkinterface.cpp:
        (QWebNetworkRequestPrivate::init):
        * Api/qwebpage.cpp:
        (QWebPage::url):
        (QWebPageContext::QWebPageContext):
        * Api/qwebpagehistory.cpp:
        (QWebHistoryItem::originalUrl):
        (QWebHistoryItem::currentUrl):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::cannotShowURLError):
        (WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
        (WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
        (WebCore::FrameLoaderClientQt::fileDoesNotExistError):
        (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
        (WebCore::FrameLoaderClientQt::createPlugin):

WebKit/wx:

        Build fix.

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::createWindow):
        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientWx::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad):
        (WebCore::FrameLoaderClientWx::postProgressFinishedNotification):
        (WebCore::FrameLoaderClientWx::didChangeTitle):
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey Proskuryakov.
mitz@apple.com [Wed, 12 Dec 2007 08:07:27 +0000 (08:07 +0000)]
    Reviewed by Alexey Proskuryakov.

        - fix a crash when pressing a key that is not associated with a command

        * WebView.cpp:
        (WebView::handleEditingKeyboardEvent): Check if the result of
        interpretKeyEvent() is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 12 Dec 2007 08:00:41 +0000 (08:00 +0000)]
WebCore:

        Reviewed by Maciej Stachowiak.

        - allow non-integer font sizes on Windows for small caps

        * platform/graphics/win/FontDataWin.cpp:
        (WebCore::FontData::smallCapsFontData):
        * platform/graphics/win/FontPlatformData.h:
        (WebCore::FontPlatformData::size):
        (WebCore::FontPlatformData::setSize):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

        Reviewed by Maciej Stachowiak.

        - removed now-passing tests

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix for Qt, Gtk, and Wx.
weinig@apple.com [Wed, 12 Dec 2007 07:44:02 +0000 (07:44 +0000)]
    Build fix for Qt, Gtk, and Wx.

        * platform/gtk/CookieJarGtk.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::writeURL):
        * platform/qt/CookieJarQt.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/wx/PasteboardWx.cpp:
        (WebCore::Pasteboard::writeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Wed, 12 Dec 2007 07:26:19 +0000 (07:26 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Scrub URL out of the tree in preparation for renaming KURL to URL.
            - Renames Document::URL() -> Document::url()
            - Renames DocumentLoader::URL() -> DocumentLoader::url()
            - Renames KURL::url() to KURL::string() and KURL::deprecatedString()
            - Remove FrameLoader::URL()
            - Various variable renames.

        The change from Document::URL() to Document::url() required changes
        to the bindings scripts as well, because URL() is the name of a DOM
        method.  The code generation scripts now have code to special case URL()
        to url().

        * WebCore.base.exp:
        * bindings/js/kjs_events.cpp:
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScript):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::put):
        (KJS::Window::allowsAccessFrom):
        (KJS::Location::put):
        (KJS::LocationProtoFuncReplace::callAsFunction):
        (KJS::LocationProtoFuncReload::callAsFunction):
        (KJS::LocationProtoFuncAssign::callAsFunction):
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorCOM.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseBackgroundImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createImportRule):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::setEncodedURL):
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        (WebCore::Document::cookie):
        (WebCore::Document::setCookie):
        (WebCore::Document::domain):
        (WebCore::Document::setDomain):
        (WebCore::Document::getImageMap):
        (WebCore::Document::completeURL):
        * dom/Document.h:
        (WebCore::Document::url):
        (WebCore::Document::baseURL):
        * dom/Element.cpp:
        (WebCore::Element::baseURI):
        * dom/ProcessingInstruction.h:
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSImageProperty):
        * dom/StyledElement.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::end):
        (WebCore::):
        * dom/XMLTokenizer.h:
        * editing/Editor.cpp:
        (WebCore::Editor::copy):
        * editing/markup.cpp:
        (WebCore::completeURLs):
        * history/CachedPage.h:
        (WebCore::CachedPage::url):
        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::setURL):
        (WebCore::HistoryItem::isCurrentDocument):
        * html/HTMLBaseElement.cpp:
        (WebCore::HTMLBaseElement::process):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::childrenChanged):
        (WebCore::HTMLScriptElement::insertedIntoDocument):
        (WebCore::HTMLScriptElement::evaluateScript):
        * html/HTMLScriptElement.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution):
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::requestResource):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedScript.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkForReload):
        (WebCore::DocLoader::requestResource):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::url):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::startLoadingMainResource):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FormSubmission::FormSubmission):
        (WebCore::ScheduledRedirection::ScheduledRedirection):
        (WebCore::FrameLoader::changeLocation):
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::loadSubframe):
        (WebCore::FrameLoader::submitFormAgain):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::didExplicitOpen):
        (WebCore::FrameLoader::replaceContentsWithScriptResult):
        (WebCore::FrameLoader::executeScript):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::startIconLoader):
        (WebCore::FrameLoader::commitIconURLToIconDatabase):
        (WebCore::FrameLoader::scheduleRefresh):
        (WebCore::FrameLoader::redirectionTimerFired):
        (WebCore::FrameLoader::loadPlugin):
        (WebCore::FrameLoader::didNotOpenURL):
        (WebCore::FrameLoader::updatePolicyBaseURL):
        (WebCore::FrameLoader::scrollToAnchor):
        (WebCore::FrameLoader::startRedirectionTimer):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::canLoad):
        (WebCore::FrameLoader::shouldHideReferrer):
        (WebCore::FrameLoader::shouldAllowNavigation):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::clientRedirected):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::didTellBridgeAboutLoad):
        (WebCore::FrameLoader::haveToldBridgeAboutLoad):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
        (WebCore::FrameLoader::createHistoryItem):
        (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
        (WebCore::FrameLoader::loadItem):
        (WebCore::FrameLoader::urlsMatchItem):
        (WebCore::FrameLoader::recursiveGoToItem):
        (WebCore::FrameLoader::updateHistoryForStandardLoad):
        (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::url):
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::createDocumentStructure):
        * loader/MainResourceLoader.cpp:
        (WebCore::shouldLoadAsEmptyDocument):
        (WebCore::MainResourceLoader::didFinishLoading):
        * loader/NavigationAction.cpp:
        (WebCore::NavigationAction::NavigationAction):
        * loader/NavigationAction.h:
        (WebCore::NavigationAction::url):
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::createDocumentStructure):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::load):
        (WebCore::SubresourceLoader::create):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading):
        (WebCore::IconLoader::finishLoading):
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * loader/mac/LoaderNSURLExtras.m:
        (urlOriginalData):
        * page/Chrome.cpp:
        (WebCore::Chrome::setToolTip):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/Frame.cpp:
        (WebCore::Frame::setUserStyleSheetLocation):
        * page/InspectorController.cpp:
        (WebCore::InspectorResource::type):
        (WebCore::addSourceToFrame):
        (WebCore::InspectorController::addScriptResource):
        (WebCore::InspectorController::updateScriptResourceRequest):
        (WebCore::InspectorController::didCommitLoad):
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        * platform/KURL.h:
        (WebCore::KURL::string):
        (WebCore::KURL::deprecatedString):
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::getData):
        * platform/mac/CookieJar.mm:
        (WebCore::cookies):
        (WebCore::setCookies):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeURL):
        (WebCore::fileWrapperForImage):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::plainText):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::portAllowed):
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::isNull):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):
        (WebCore::didReceiveResponse):
        (WebCore::didReceiveData):
        (WebCore::didFinishLoading):
        (WebCore::didFail):
        (WebCore::didReceiveChallenge):
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::ResourceHandle::start):
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::createGlobalData):
        (WebCore::urlToMarkup):
        * platform/win/ClipboardWin.cpp:
        (WebCore::writeURL):
        (WebCore::writeImageToDataObject):
        (WebCore::ClipboardWin::writeURL):
        (WebCore::ClipboardWin::writeRange):
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::PluginDatabaseWin::findPlugin):
        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::startStream):
        (WebCore::PluginStreamWin::destroyStream):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::scriptStringIfJavaScriptURL):
        (WebCore::PluginViewWin::performRequest):
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::updateFromElement):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getResponseXML):
        (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):
        (WebCore::xsltStylesheetPointer):
        (WebCore::xmlDocPtrFromNode):

WebKit/mac:

        Reviewed by Darin Adler.

        Scrub URL out of the tree in preparation for renaming KURL to URL.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::actionDictionary):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URL]):
        * WebView/WebView.mm:
        (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

WebKit/win:

        Reviewed by Darin Adler.

        Scrub URL out of the tree in preparation for renaming KURL to URL.

        * WebFrame.cpp:
        (WebFrame::url):
        (WebFrame::dispatchWillPerformClientRedirect):
        (WebFrame::setTitle):
        (WebFrame::updateGlobalHistoryForStandardLoad):
        (WebFrame::updateGlobalHistoryForReload):
        (WebFrame::cancelledError):
        (WebFrame::blockedError):
        (WebFrame::interruptForPolicyChangeError):
        (WebFrame::createPlugin):
        * WebView.cpp:
        (WebView::notifyDidAddIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
mitz@apple.com [Wed, 12 Dec 2007 05:04:27 +0000 (05:04 +0000)]
WebKitTools:

        Reviewed by Mark Rowe and Sam Weinig too!

        - added Helvetica Oblique and Helvetica Bold Oblique to the list of
          fonts DumpRenderTree registers.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (initialize):

LayoutTests:

        Reviewed by Mark Rowe and Sam Weinig too!

        - removed tests that pass when Helvetica Oblique and Helvetica
          Bold Oblique are available.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 12 Dec 2007 03:23:35 +0000 (03:23 +0000)]
WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5641255> SVGs with width and height 100%
        fail to render when used as background images

        CachedImage now has a setImageContainerSize function. It is only
        needed for SVG right now.
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::setImageContainerSize):
        * loader/CachedImage.h:

        Relatively sized SVGs have no intrinsic size. Because this call is
        low-level enough that we cannot pass in the container size and get
        the real size of the SVG, we need to know if it has relative
        dimensions, and if so, we need to get the size from scaledTileSize.
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        (WebCore::Image::setContainerSize):
        (WebCore::Image::hasRelativeWidth):
        (WebCore::Image::hasRelativeHeight):

        Re-factored calculateBackgroundSize a bit so that it returns an
        IntSize. Made it a member function so that it can send m_width and
        m_height along to setImageContainerSize.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::calculateBackgroundImageGeometry):
        * rendering/RenderBox.h:

        Need to account for relatively sized SVGs in calcViewport()
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcViewport):

        Added new member variables to store the size of the SVG container.
        relativeWidthValue() and relativeHeightValue() use the stored SVG
        container size to correctly calculate the width and height of a
        relatively sized SVG.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        (WebCore::SVGSVGElement::setContainerSize):
        (WebCore::SVGSVGElement::relativeWidthValue):
        (WebCore::SVGSVGElement::relativeHeightValue):
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::containerSize):

        Re-factored size calculations to use the size of the container.
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::setContainerSize):
        (WebCore::SVGImage::size):
        (WebCore::SVGImage::hasRelativeWidth):
        (WebCore::SVGImage::hasRelativeHeight):
        * svg/graphics/SVGImage.h:

LayoutTests:

        Reviewed by Darin.

        Tests for <rdar://problem/5641255> SVGs with width and height 100%
        fail to render when used as background images

        * fast/backgrounds/resources/balloon.svg: Added.
        * fast/backgrounds/resources/eyes.svg: Added.
        * fast/backgrounds/resources/hearts.svg: Added.
        * fast/backgrounds/resources/linguistics.svg: Added.
        * fast/backgrounds/resources/map.svg: Added.
        * fast/backgrounds/resources/mouse-repel.svg: Added.
        * fast/backgrounds/svg-as-background-1.html: Added.
        * fast/backgrounds/svg-as-background-2.html: Added.
        * fast/backgrounds/svg-as-background-3.html: Added.
        * fast/backgrounds/svg-as-background-4.html: Added.
        * fast/backgrounds/svg-as-background-5.html: Added.
        * fast/backgrounds/svg-as-background-6.html: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Wed, 12 Dec 2007 01:32:11 +0000 (01:32 +0000)]
    Reviewed by Sam Weinig.

        Build fix: Note some variables that are used only for ASSERTs.

        * API/testapi.c:
        (Base_finalize):
        (globalObject_initialize):
        (testInitializeFinalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ggaren@apple.com [Wed, 12 Dec 2007 00:30:04 +0000 (00:30 +0000)]
    Reviewed by Darin Adler.

        Fixed: All JS tests crash on Windows.

        NDEBUG wasn't defined when compiling testkjs in release builds, so the
        HashTable definition in HashTable.h included an extra data member.

        The solution was to add NDEBUG to the release testkjs configuration on
        Windows and Mac.

        For giggles, I also added other missing #defines to testkjs on Windows.

        * Configurations/Base.xcconfig:
        * Configurations/JavaScriptCore.xcconfig:
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/testkjs.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-12-11 George Wright <george.wright@collabora.co.uk>
alp@webkit.org [Wed, 12 Dec 2007 00:05:08 +0000 (00:05 +0000)]
2007-12-11  George Wright  <george.wright@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=14120
        [GDK] Support input methods

        This patch adds infrastructure for input method support.

        It also adds Hildon features for the Maemo mobile platform sufficient
        to support the virtual keyboard.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):
        (WebKit::EditorClient::EditorClient):
        (WebKit::EditorClient::~EditorClient):
        (WebKit::EditorClient::textFieldDidBeginEditing):
        (WebKit::EditorClient::textFieldDidEndEditing):
        * WebCoreSupport/EditorClientGtk.h:
        * WebView/webkitprivate.h:
        * WebView/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28634 268f45cc-cd09-0410-ab3c-d52691b4dbfc