WebKit-https.git
11 years agoWebCore: [V8] Make XMLHttpRequest.send handle File object.
jianli@chromium.org [Thu, 10 Sep 2009 17:39:26 +0000 (17:39 +0000)]
WebCore: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Test: http/tests/local/send-dragged-file.html

* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

LayoutTests: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Add a new layout test.

* http/tests/local/resources/file-for-drag-to-send.txt: Added.
* http/tests/local/resources/send-dragged-file.js: Added.
* http/tests/local/send-dragged-file-expected.txt: Added.
* http/tests/local/send-dragged-file.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 10 Sep 2009 17:33:51 +0000 (17:33 +0000)]
2009-09-10  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
        https://bugs.webkit.org/show_bug.cgi?id=25930

        FastAllocBase has been extended with fastDeleteSkippingDestructor function which
        releases memory without destructor call. fastDeleteAllValues has been implemented
        similar as deleteAllValues but it uses fastDelete function to release memory.

        * wtf/FastAllocBase.h:
        (WTF::fastDeleteSkippingDestructor):
        * wtf/HashSet.h:
        (WTF::fastDeleteAllValues):

2009-09-10  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Use fastNew and fastDelete instead of operator new and delete for CSSSelector class.
        https://bugs.webkit.org/show_bug.cgi?id=25930

        Change using of operator new to fastNew and operator delete to
        fastDeleteSkippingDestructor for CSSSelector class to avoid mismatched function call.

        This change fixes valgrind's 'mismatched free' notification.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::createFloatingSelector):
        * css/CSSSelectorList.cpp:
        (WebCore::CSSSelectorList::adoptSelectorVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Geolocation does not correctly handle reentrant calls from callbacks.
benm@google.com [Thu, 10 Sep 2009 17:16:39 +0000 (17:16 +0000)]
WebCore: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <steveblock@google.com> on 2009-09-10
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/reentrant-error.html
       fast/dom/Geolocation/reentrant-success.html

* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback.
* page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods.

LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

* fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK.
* fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test.
* fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test.
* fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK.
* fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test.
* fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test.
* platform/gtk/Skipped: Modified. Skips above tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Thu, 10 Sep 2009 17:03:51 +0000 (17:03 +0000)]
2009-09-10  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
        https://bugs.webkit.org/show_bug.cgi?id=27105

        * fast/events/blur-focus-window-should-blur-focus-element-expected.txt: Added.
        * fast/events/blur-focus-window-should-blur-focus-element.html: Added.
        * fast/events/resources/blur-focus-window-should-blur-focus-element.js: Added.
        (divElement.onfocus.divElement.onblur.window.onfocus.window.onblur.innerDiv.onfocus.innerDiv.onblur.iframe.onfocus.iframe.onblur):
        (testNextEvent):
        * fast/events/resources/tabindex-focus-blur-all.js:
        (test):
        * fast/events/tabindex-focus-blur-all-expected.txt:
2009-09-10  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
        https://bugs.webkit.org/show_bug.cgi?id=27105

        Test: fast/events/blur-focus-window-should-blur-focus-element.html

        * page/FocusController.cpp:
        (WebCore::dispatchEventsOnWindowAndFocusedNode):
        (WebCore::FocusController::setFocused):
        (WebCore::FocusController::setActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Sep 2009 16:41:46 +0000 (16:41 +0000)]
2009-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24205

        Added a test case for inserting a new line character into the
        request-uri.

        * http/tests/xmlhttprequest/newline-in-request-uri-expected.txt: Added.
        * http/tests/xmlhttprequest/newline-in-request-uri.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake the play/pause button in <video> controls indicate the button's action, not...
aroben@apple.com [Thu, 10 Sep 2009 15:56:39 +0000 (15:56 +0000)]
Make the play/pause button in <video> controls indicate the button's action, not the movie state

This matches the Mac behavior, iTunes, and many other media players.

No test possible.

Fixes <http://webkit.org/b/29126> Play/pause button in <video>
controls shows the wrong image

Reviewed by Eric Carlson.

* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): Reversed when
we show the play vs. pause artwork, so that the button reflects what
will happen when you click it, rather than the current state of the
movie.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 10 Sep 2009 15:34:00 +0000 (15:34 +0000)]
2009-09-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        Build fix for QtWebKit for Mac after r48219.

        qevent and qstyleoption are QtGui interfaces.

        * Api/qwebgraphicsitem.cpp:
        * Api/qwebgraphicsitem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Thu, 10 Sep 2009 14:04:32 +0000 (14:04 +0000)]
2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>

        [GTK] EventSender does not properly convert some keyDown strings
        https://bugs.webkit.org/show_bug.cgi?id=29119

        Add more keyDown string to character code conversions for GTK+ EventSender.

        * DumpRenderTree/gtk/EventSender.cpp:
        (keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Geolocation Coordinates::toString() prints bogus values for unspecified...
benm@google.com [Thu, 10 Sep 2009 13:26:40 +0000 (13:26 +0000)]
WebCore: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

Test: fast/dom/Geolocation/position-string.html

* GNUmakefile.am: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* WebCore.gypi: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* WebCore.pro: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* WebCore.vcproj/WebCore.vcproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* WebCore.xcodeproj/project.pbxproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* WebCoreSources.bkl: Modified. Removes Geoposition.cpp and Coordinates.cpp.
* page/Coordinates.cpp: Removed.
* page/Coordinates.h: Modified. Removes toString method.
* page/Coordinates.idl: Modified. Removes toString method.
* page/Geoposition.cpp: Removed.
* page/Geoposition.h: Modified. Removes toString method.
* page/Geoposition.idl: Modified. Removes toString method.

WebKitTools: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

* Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.

LayoutTests: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

* fast/dom/Geolocation/resources/position-string.js: Added. Tests output of position.toString().
* fast/dom/Geolocation/position-string.html: Added. Wrapper for above test.
* fast/dom/Geolocation/position-string-expected.txt: Added. Expected result for above test.
* platform/gtk/Skipped: Modified. Skips above test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 10 Sep 2009 12:45:54 +0000 (12:45 +0000)]
2009-09-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        ARM compiler does not understand GCC visibility attribute
        https://bugs.webkit.org/show_bug.cgi?id=29079

        * API/JSBase.h: Make the test more specific to hit only
        the GCC compiler

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 10 Sep 2009 11:59:50 +0000 (11:59 +0000)]
2009-09-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        Disable some ARM compiler warnings
        https://bugs.webkit.org/show_bug.cgi?id=29083

        The following ARM compiler warnings are disabled

        - #68-D: integer conversion resulted in a change of sign
        - #111-D: statement is unreachable
        - #177-D: variable XXX was declared but never referenced
        - #368-D: class XXX defines no constructor to initialize the following: YYY
        - #830-D: function XXX "XXX::operator new" has no corresponding operator delete
        - #1293-D: assignment in condition

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Correctly applies the Geolocation timeout property.
benm@google.com [Thu, 10 Sep 2009 11:32:47 +0000 (11:32 +0000)]
WebCore: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

If a timeout is specified, the timer is started as soon as the location acquistion process starts.
If a position fix is not obtained within the timeout interval, the position request is cancelled
and the error callback (if specified) is invoked. If a position fix is obtained within the timeout
interval, the timer is stopped. Permissions are then requested from the user if required. See
http://www.w3.org/TR/geolocation-API/#position-options.

Note that this logic means that the time required to obtain permissions from the user is not
included in the timeout interval.

Tests: fast/dom/Geolocation/timeout.html
       fast/dom/Geolocation/timeout-zero.html

* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Takes Geolocation object as parameter.
(WebCore::Geolocation::GeoNotifier::hasZeroTimeout): Added. Determines whether this request has a zero timeout.
(WebCore::Geolocation::GeoNotifier::startTimerIfNeeded): Renamed from startTimer. Starts the timer if a timeout was specified.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Calls the error callback if specified, and reports the timeout to the Geolocation object.
(WebCore::Geolocation::getCurrentPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::watchPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::requestTimedOut): Added. Cancels a request when it times out.
(WebCore::Geolocation::setIsAllowed): Modified. No longer starts timers.
(WebCore::Geolocation::sendPosition): Modified. No longer stops timers.
(WebCore::Geolocation::stopTimer): Added. Stops the timers for a vector of notifiers.
(WebCore::Geolocation::stopTimersForOneShots): Added. Stops the timers for all one-shots.
(WebCore::Geolocation::stopTimersForWatchers): Added. Stops the timers for all watchers.
(WebCore::Geolocation::stopTimers): Added. Stops the timers for all requests.
(WebCore::Geolocation::geolocationServicePositionChanged): Modfified. Stops the timers for all requests.
* page/Geolocation.h: Modified.
(WebCore::Geolocation::GeoNotifier::create): Modified. Takes Geolocation object as parameter.

LayoutTests: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

* fast/dom/Geolocation/resources/timeout.js: Added. Tests that when a non-zero timeout is used, the success callback is invoked as expected.
* fast/dom/Geolocation/timeout.html: Added. Wrapper for above test.
* fast/dom/Geolocation/timeout-expected.txt: Added. Expected result for above test.
* fast/dom/Geolocation/resources/timeout-zero.js: Added. Tests that when a zero timeout is used, the error callback is invoked with code TIMEOUT.
* fast/dom/Geolocation/timeout-zero.html: Added. Wrapper for above test.
* fast/dom/Geolocation/timeout-zero-expected.txt: Added. Expected result for above test.
* platform/gtk/Skipped: Modified. Skips the above tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Sep 2009 09:08:26 +0000 (09:08 +0000)]
2009-09-10  Adam Barth  <abarth@webkit.org>

        Unreviewed revert of the previous change.  It broke the tests.

        * wtf/dtoa.cpp:
        (WTF::dtoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-10 Ben Laurie <benl@google.com>
abarth@webkit.org [Thu, 10 Sep 2009 08:51:29 +0000 (08:51 +0000)]
2009-09-10  Ben Laurie  <benl@google.com>

        Reviewed by Adam Barth.

        <https://bugs.webkit.org/show_bug.cgi?id=26836>

        If dtoa was given a small buffer and the number was either infinite or
        NaN, then the buffer would be overflowed.

        * wtf/dtoa.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCall the right base class function QGraphicsWidget::event() instead
hausmann@webkit.org [Thu, 10 Sep 2009 06:58:00 +0000 (06:58 +0000)]
Call the right base class function QGraphicsWidget::event() instead
of skipping it and using QObject::event() instead.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.

* Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX notifications should be an ENUM type instead of strings
cfleizach@apple.com [Thu, 10 Sep 2009 06:47:24 +0000 (06:47 +0000)]
AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963

Build fix for Qt.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX notifications should be an ENUM type instead of strings
cfleizach@apple.com [Thu, 10 Sep 2009 06:38:31 +0000 (06:38 +0000)]
AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963

Reviewed by Darin Adler.

Moves AX notifications over to an ENUM type instead of
using the actual string values that are used on OS X.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* dom/Document.cpp:
(WebCore::Document::implicitClose):
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
* editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setInnerTextValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Sep 2009 05:25:00 +0000 (05:25 +0000)]
2009-09-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Carlson.

        reviewer/committer lookups are backwards
        https://bugs.webkit.org/show_bug.cgi?id=29113

        I also moved Eric Carlson from the committer list to the reviewer list now that he is one.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Thu, 10 Sep 2009 05:17:46 +0000 (05:17 +0000)]
2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        svn-unapply doesn't revert directories correctly
        https://bugs.webkit.org/show_bug.cgi?id=29065

        * Scripts/svn-unapply: Make svnStatus consistently return status
        lines including a newline.
        * Scripts/svn-apply: Keep svnStatus in sync with the one in
        svn-unapply, in lieu of moving it to a common file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update data/params parameters
ddkilzer@apple.com [Thu, 10 Sep 2009 04:52:07 +0000 (04:52 +0000)]
    Update data/params parameters

        * data/params: Updated 'attachment_base' parameter for secure
        attachments.  Updated 'mybugstemplate' parameter to search for
        bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to
        NEW status.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Sep 2009 02:54:32 +0000 (02:54 +0000)]
2009-09-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Missing checkout for getSVGDocument()
        https://bugs.webkit.org/show_bug.cgi?id=29064

        The V8 code generator didn't understand SVGCheckSecurityDocument.

        Tests: http/tests/security/xss-DENIED-getSVGDocument-iframe.html
               http/tests/security/xss-DENIED-getSVGDocument-object.html

        * bindings/scripts/CodeGeneratorV8.pm:
2009-09-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Missing checkout for getSVGDocument()
        https://bugs.webkit.org/show_bug.cgi?id=29064

        Add tests that getSVGDocument() has the proper checks.

        * http/tests/security/resources/flag.php: Added.
        * http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt: Added.
        * http/tests/security/xss-DENIED-getSVGDocument-iframe.html: Added.
        * http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt: Added.
        * http/tests/security/xss-DENIED-getSVGDocument-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Thu, 10 Sep 2009 00:55:33 +0000 (00:55 +0000)]
2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        Make SVGStyleElement inherit from SVGLangSpace
        https://bugs.webkit.org/show_bug.cgi?id=29058

        Required by SVG 1.1 Second Edition:
        http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

        * svg/dom/SVGStyleElement: Added.
        * svg/dom/SVGStyleElement/resources: Added.
        * svg/dom/SVGStyleElement/resources/TEMPLATE.html: Copied from
        LayoutTests/svg/dom/resources/TEMPLATE.html with some "../"s added.
        * svg/dom/SVGStyleElement/resources/style-langspace.js: Added.
        * svg/dom/SVGStyleElement/style-langspace-expected.txt: Added.
        * svg/dom/SVGStyleElement/style-langspace.html: Added.
2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        Make SVGStyleElement inherit from SVGLangSpace
        https://bugs.webkit.org/show_bug.cgi?id=29058

        Required by SVG 1.1 Second Edition:
        http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

        Test: svg/dom/SVGStyleElement/style-langspace.html

        * svg/SVGStyleElement.cpp: Drop methods xmlspace and setXmlspace.
        (WebCore::SVGStyleElement::SVGStyleElement): Add SVGLangSpace()
        initializer.
        (WebCore::SVGStyleElement::parseMappedAttribute): Call
        parseMappedAttribute on SVGLangSpace.
        * svg/SVGStyleElement.h: Drop xmlspace and setXmlspace declarations.
        * svg/SVGStyleElement.idl: Drop xmlspace attribute and add SVGLangSpace
        as a superinterface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Nate Chapin <japhet@chromium.org>
eric@webkit.org [Thu, 10 Sep 2009 00:39:18 +0000 (00:39 +0000)]
2009-09-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by David Levin.

        Remove unnecessary includes and forward declarations in V8Proxy.h

        https://bugs.webkit.org/show_bug.cgi?id=29111

        * bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 23:55:07 +0000 (23:55 +0000)]
2009-09-09  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Media layout tests should have a way to provide test files in different formats
        https://bugs.webkit.org/show_bug.cgi?id=28327

        Added media-file.js which has a findMediaFile(type, name) method
        to find a proper media file to load according to supported codecs.

        Also changed 10 layout tests to use above method to locate the test file.

        * media/controls-strict.html: Use findMediaFile(type, name).
        * media/controls-styling.html: ditto.
        * media/media-file.js: Added. Provide findMediaFile(type, name).
        * media/video-append-source.html: Use findMediaFile(type, name).
        * media/video-aspect-ratio.html: ditto.
        * media/video-autoplay.html: ditto.
        * media/video-buffered.html: ditto.
        * media/video-controls-rendering.html: ditto.
        * media/video-layer-crash.html: ditto.
        * media/video-transformed.html: Use findMediaFile(type, name).
        * media/video-zoom-controls.html: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Wed, 9 Sep 2009 23:41:43 +0000 (23:41 +0000)]
2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        svn-apply doesn't handle changes to files copied to new directories properly
        https://bugs.webkit.org/show_bug.cgi?id=29059

        * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
        additions if we know that we've just copied a file to this name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 9 Sep 2009 23:25:53 +0000 (23:25 +0000)]
2009-07-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add more position constructors
        positionBeforeNode, positionAfterNode
        firstPositionInNode, lastPositionInNode
        https://bugs.webkit.org/show_bug.cgi?id=25494

        I also added a lastOffsetInNode and deployed it to a couple places.

        There are no callers to these new constructors yet, but those
        will be coming in future patches.

        * dom/Position.cpp:
        (WebCore::Position::computeOffsetInContainerNode):
        * dom/Position.h:
        (WebCore::positionBeforeNode):
        (WebCore::positionAfterNode):
        (WebCore::lastOffsetInNode):
        (WebCore::firstPositionInNode):
        (WebCore::lastPositionInNode):
        * editing/ApplyStyleCommand.cpp:
        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        * editing/htmlediting.cpp:
        (WebCore::lastOffsetForEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 9 Sep 2009 23:25:47 +0000 (23:25 +0000)]
2009-07-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename positionBeforeNode to positionInParentBeforeNode
        and positionAfterNode to positionInParentAfterNode
        in preparation for adding a positionBeforeNode
        which returns a neighbor-anchored position.
        https://bugs.webkit.org/show_bug.cgi?id=25494

        No functional changes, thus no tests.

        * dom/PositionConstructors.h:
        (WebCore::positionInParentBeforeNode):
        (WebCore::positionInParentAfterNode):
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
        * editing/CreateLinkCommand.cpp:
        (WebCore::CreateLinkCommand::doApply):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::deleteTarget):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        (WebCore::updatePositionForNodeRemoval):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot):
        (WebCore::lastEditablePositionBeforePositionInRoot):
        (WebCore::rangeCompliantEquivalent):
        (WebCore::positionBeforeContainingSpecialElement):
        (WebCore::positionAfterContainingSpecialElement):
        (WebCore::positionBeforeTabSpan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 9 Sep 2009 23:25:40 +0000 (23:25 +0000)]
2009-07-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Re-organize position creation functions in preparation for adding more
        https://bugs.webkit.org/show_bug.cgi?id=25494

        Make position functions inline to avoid ref-churn.
        Remove startPosition/endPosition as they were only used in one place.

        No functional changes, thus no tests.

        * dom/Position.cpp:
        * dom/Position.h:
        (WebCore::positionBeforeNode):
        (WebCore::positionAfterNode):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::moveTo):
        * editing/TypingCommand.cpp:
        * editing/htmlediting.cpp:
        * editing/htmlediting.h:
        (WebCore::firstDeepEditingPositionForNode):
        (WebCore::lastDeepEditingPositionForNode):
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 9 Sep 2009 22:50:53 +0000 (22:50 +0000)]
Reviewed by Kevin Ollivier.

[wx] Add wxSize conversions for IntSize.
https://bugs.webkit.org/show_bug.cgi?id=29104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 22:35:57 +0000 (22:35 +0000)]
2009-09-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by David Levin.

        Chromium uses its own config.h file that was forked from webkit's config.h.
        By merging in Chromium's defines, Chromium would again be able to use webkit's
        config.h.

        https://bugs.webkit.org/show_bug.cgi?id=28882

        * config.h: Added chromium-specific defines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 9 Sep 2009 22:21:03 +0000 (22:21 +0000)]
2009-09-09  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue hangs if a builder has never built
        https://bugs.webkit.org/show_bug.cgi?id=29091

        * Scripts/modules/buildbot.py:
        * Scripts/modules/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 22:19:22 +0000 (22:19 +0000)]
2009-09-09  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        Initialize DataTransfer's effectAllowed and dropEffect properties correctly
        according to HTML5 spec (sec. 7.9.2-7.9.3).
        https://bugs.webkit.org/show_bug.cgi?id=26700

        * fast/events/drag-dropeffect-expected.txt: Added.
        * fast/events/drag-dropeffect.html: Added.
2009-09-09  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        Initialize DataTransfer's effectAllowed and dropEffect properties correctly
        according to HTML5 spec (sec. 7.9.2-7.9.3).
        https://bugs.webkit.org/show_bug.cgi?id=26700
        - At the start of a drag operation, the value of effectAllowed should be
          the string "uninitialized".
        - At end of dragstart handler, if effectAllowed hasn't been set yet, it
          should be set to "copy".
        - on dragenter and dragover event, dropEffect should be initialized to a
          default value based on the value of effectAllowed.
        - at end of dragenter and dragover the dropEffect should be set to "none"
          if the value set by the handler doesn't match the effectAllowed.
        - on dragleave event, dropEffect should be "none".
        - on drop event, dropEffect should be the previously negotiated value.

        Test: fast/events/drag-dropeffect.html

        * WebCore.base.exp:
            Added a parameter to EventHandler::dragSourceMovedTo.
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
            Initialize m_effectAllowed to "uninitialized".
        (WebCore::Clipboard::sourceOperation):
            Treat "uninitialized" as meaning no value has been set.
        * page/DragController.cpp:
        (WebCore::DragController::DragController):
            Initialize new member m_destinationDragOperation.
        (WebCore::DragController::dragExited):
            Set m_destinationDragOperation to none on dragExit.
        (WebCore::DragController::performDrag):
            Set m_destinationDragOperation to current dropEffect.
        (WebCore::DragController::dragEnteredOrUpdated):
            Make sure to clear the operation if drag source doesn't allow it.
        (WebCore::DragController::tryDHTMLDrag):
            Set a default value for the dst drag op before sending dragEnter/Over.
        (WebCore::DragController::startDrag):
            Clear m_destinationDragOperation at start of drag.
        * page/DragController.h:
        (WebCore::DragController::destinationDragOperation):
            Added new member m_destinationDragOperation, and its public getter.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateDragAndDrop):
            dropEffect should be 'none' during dropleave handler, per spec.
        (WebCore::EventHandler::dragSourceMovedTo):
            Added DragOperation parameter, so the handler sees the current dropEffect.
        (WebCore::EventHandler::handleDrag):
            Assume DragOperationEvery for non-DHTML drags.
        * page/EventHandler.h:
            Added DragOperation parameter to dragSourceMovedTo().
2009-09-09  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        Initialize DataTransfer's effectAllowed and dropEffect properties correctly
        according to HTML5 spec (sec. 7.9.2-7.9.3).
        https://bugs.webkit.org/show_bug.cgi?id=26700

        * WebView/WebFrame.mm:
        (-[WebFrame _dragSourceMovedTo:]):
            Pass current drag operation (if known) to EventHandler::dragSourceMovedTo().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Wed, 9 Sep 2009 22:10:00 +0000 (22:10 +0000)]
2009-09-09  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] DumpRenderTree needs eventSender object and implementation
        https://bugs.webkit.org/show_bug.cgi?id=25990

        Enable plenty of tests that now pass thanks to (only) partial
        EventSender implementation.

        * platform/gtk/Skipped:
2009-09-09  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] DumpRenderTree needs eventSender object and implementation
        https://bugs.webkit.org/show_bug.cgi?id=25990

        Creates a function that is accessible from the DumpRenderTree tool
        and calls the layout method on the frame view.

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_layout):
2009-09-09  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] DumpRenderTree needs eventSender object and implementation
        https://bugs.webkit.org/show_bug.cgi?id=25990

        Implements most of the EventSender object's functionality for
        the DumpRenderTree tool. Implementation still lacks support
        for drag and drop tests and forward leaps.

        Based on work by Holger Hans Peter Freyther.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest): Focus on the view before loading a new test.
        (webViewWindowObjectCleared):
        * DumpRenderTree/gtk/EventSender.cpp: Added.
        (getDragModeCallback):
        (setDragModeCallback):
        (leapForwardCallback):
        (contextClickCallback):
        (updateClickCount):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (beginDragWithFilesCallback):
        (replaySavedEvents):
        (keyDownCallback):
        (textZoomInCallback):
        (textZoomOutCallback):
        (zoomPageInCallback):
        (zoomPageOutCallback):
        (getClass):
        (makeEventSender):
        * DumpRenderTree/gtk/EventSender.h: Added.
        * GNUmakefile.am: Add build rules for EventSender.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 21:35:21 +0000 (21:35 +0000)]
2009-09-09  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding a test for the database authorizer.

        https://bugs.webkit.org/show_bug.cgi?id=28918

        * storage/test-authorizer-expected.txt: Added.
        * storage/test-authorizer.html: Added.
2009-09-09  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        1. Adding support/bindings for read-only transactions.
        2. Disallowing the SQLITE_*_VIEW and REINDEX operations in the
        private browsing mode.
        3. Adding an authorizer test.

        https://bugs.webkit.org/show_bug.cgi?id=28918

        Test: storage/test-authorizer.html

        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::createTransaction): Parses all arguments and executes a
        transaction.
        (WebCore::JSDatabase::transaction): Refactored to use
        createTransaction().
        (WebCore::JSDatabase::readTransaction): Added to execute read-only
        transactions using createTransaction().
        * bindings/v8/custom/V8CustomBinding.h: Added the binding for
        Database::readTransaction().
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        (WebCore::createTransaction): Parses all arguments and executes a
        transaction.
        (WebCore::transaction): Refactored to use createTransaction().
        (WebCore::readTransaction): Added to execute read-only
        transactions using createTransaction().
        * storage/Database.cpp:
        (WebCore::Database::transaction): Added support for read-only
        transactions.
        * storage/Database.h: Added support for read-only transactions.
        * storage/Database.idl: Added support for read-only transactions.
        * storage/DatabaseAuthorizer.cpp:
        (WebCore::DatabaseAuthorizer::createTempTable): Make it obvious
        that the statement will be denied in private browsing mode and
        read-only transactions.
        (WebCore::DatabaseAuthorizer::dropTempTable): Same.
        (WebCore::DatabaseAuthorizer::createTempIndex): Same.
        (WebCore::DatabaseAuthorizer::dropTempIndex): Same.
        (WebCore::DatabaseAuthorizer::createTempTrigger): Same.
        (WebCore::DatabaseAuthorizer::dropTempTrigger): Same.
        (WebCore::DatabaseAuthorizer::createView): Deny in private
        browsing mode and read-only transactions.
        (WebCore::DatabaseAuthorizer::createTempView): Same.
        (WebCore::DatabaseAuthorizer::dropView): Same.
        (WebCore::DatabaseAuthorizer::dropTempView): Same.
        (WebCore::DatabaseAuthorizer::allowReindex): Same.
        * storage/DatabaseAuthorizer.h:
        * storage/SQLTransaction.cpp: Added support for read-only
        transactions.
        (WebCore::SQLTransaction::create):
        (WebCore::SQLTransaction::SQLTransaction):
        (WebCore::SQLTransaction::executeSQL):
        (WebCore::SQLTransaction::acquireLock):
        * storage/SQLTransaction.h:
        * storage/SQLTransactionCoordinator.cpp:
        (WebCore::SQLTransactionCoordinator::acquireLock): Added a new
        parameter in preparation for a change that will allow multiple
        read-only transactions on the same DB to run concurrently.
        * storage/SQLTransactionCoordinator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd instructions to bug reporting guidlines on how and when
vestbo@webkit.org [Wed, 9 Sep 2009 21:28:36 +0000 (21:28 +0000)]
Add instructions to bug reporting guidlines on how and when
to apply port-specific keywords.

Reviewed by Mark Rowe.

* quality/bugwriting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix namespace typos.
hyatt@apple.com [Wed, 9 Sep 2009 21:21:45 +0000 (21:21 +0000)]
Fix namespace typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix namespace typos.
hyatt@apple.com [Wed, 9 Sep 2009 21:21:24 +0000 (21:21 +0000)]
Fix namespace typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix comment at Tor Arne Vestbø's request.
kenneth@webkit.org [Wed, 9 Sep 2009 21:18:13 +0000 (21:18 +0000)]
Fix comment at Tor Arne Vestbø's request.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09

* Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user styleshe...
hyatt@apple.com [Wed, 9 Sep 2009 21:12:10 +0000 (21:12 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

* WebCore.base.exp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::attach):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):
* page/PageGroup.h:
(WebCore::PageGroup::userStyleSheets):
* page/UserStyleSheet.h: Added.
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::source):
(WebCore::UserStyleSheet::url):
(WebCore::UserStyleSheet::patterns):
(WebCore::UserStyleSheet::worldID):
* page/UserStyleSheetTypes.h: Added.

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

* WebView/WebView.mm:
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):
* WebView/WebViewPrivate.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

* platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
* platform/mac/userscripts/simple-stylesheet-expected.png: Added.
* platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
* userscripts/simple-stylesheet.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement some virtual event methods so that we can fix
kenneth@webkit.org [Wed, 9 Sep 2009 21:11:35 +0000 (21:11 +0000)]
Implement some virtual event methods so that we can fix
event-related bugs in Qt patch releases.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.

* Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):
* Api/qwebgraphicsitem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Carol Szabo <carol.szabo@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 9 Sep 2009 20:40:47 +0000 (20:40 +0000)]
2009-09-09  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] CSS Style -webkit-box-shadow is not rendered correctly on
        Qt platform
        https://bugs.webkit.org/show_bug.cgi?id=23291

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
         Added the ability to draw shadows for all these curves.

2009-09-09  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] -webkit-box-shadow CSS Style is not rendered correctly on
        Qt platform
        https://bugs.webkit.org/show_bug.cgi?id=23291

        * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
        * platform/qt/fast/box-shadow/basic-shadows-expected.png:
        * platform/qt/fast/box-shadow/inset-expected.checksum:
        * platform/qt/fast/box-shadow/inset-expected.png:
        * platform/qt/fast/box-shadow/spread-expected.checksum:
        * platform/qt/fast/box-shadow/spread-expected.png:
          Updated to show the new shadows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.
kenneth@webkit.org [Wed, 9 Sep 2009 20:15:18 +0000 (20:15 +0000)]
.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

* WebKit.pro:

WebCore: Add the qwebgraphicsitem.cpp to the build system.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

* WebCore.pro:

WebKit/qt: Add a new QGraphicsWidget based version of the "QWebView"
under the name "QWebGraphicsItem".

Patch by Kenneth Rohde Christiansen  <kenneth@webkit.org>, Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

Includes an alternative Qt launcher using the QGraphicsView.

* Api/headers.pri:
* Api/qwebgraphicsitem.cpp: Added.
* Api/qwebgraphicsitem.h: Added.
* Api/qwebpage.h:
* QGVLauncher/QGVLauncher.pro: Copied from WebKit/qt/QtLauncher/QtLauncher.pro.
* QGVLauncher/main.cpp: Added.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 9 Sep 2009 18:41:35 +0000 (18:41 +0000)]
2009-09-09  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=28953

        Added pre- and post- build events so that on build failure, the file
        buildfailed is written to the directory $(WebKitOutputDir).

        * WinLauncher/WinLauncher.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 9 Sep 2009 18:09:29 +0000 (18:09 +0000)]
2009-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Change reinterpret_cast to static_cast in r48212.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 9 Sep 2009 17:56:23 +0000 (17:56 +0000)]
2009-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
        https://bugs.webkit.org/show_bug.cgi?id=29066

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
kenneth@webkit.org [Wed, 9 Sep 2009 17:42:40 +0000 (17:42 +0000)]
Unreviewed.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Add myself to list of committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 9 Sep 2009 17:36:44 +0000 (17:36 +0000)]
2009-09-08  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue gets stuck if a non-committer sets commit-queue+ or review+
        https://bugs.webkit.org/show_bug.cgi?id=28605
        https://bugs.webkit.org/show_bug.cgi?id=28916

        * Scripts/bugzilla-tool:
         - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
           comment now that it's used for rejecting patches for invalid committers too.
         - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
         - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
        * Scripts/modules/bugzilla.py:
         - Make _parse_attachment_element not validate reviewer/committer.
         - Share flag parsing code in _parse_attachment_flag.
         - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
         - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
         - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
        * Scripts/modules/bugzilla_unittest.py:
         - Update this test to no longer expect committer/reviewer validation.
        * Scripts/modules/committers.py:
         - Return None on failed lookups instead of raising Exceptions.
        * Scripts/modules/committers_unittest.py:
         - Update tests to expect None returns instead of exceptions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 9 Sep 2009 17:35:47 +0000 (17:35 +0000)]
Reviewed by Kevin Ollivier.

[wx port] Move functions in TemporaryLinkStubs.cpp out to files where
they belong.

https://bugs.webkit.org/show_bug.cgi?id=29088

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 9 Sep 2009 16:46:28 +0000 (16:46 +0000)]
2009-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        Implement flushing the instruction cache for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=29075

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush
        the instruction cache on Symbian

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 16:44:45 +0000 (16:44 +0000)]
2009-09-09  Erik Arvidsson  <arv@chromium.org>

        Reviewed by David Levin.

        Fix preference name in layout test.
        https://bugs.webkit.org/show_bug.cgi?id=29038

        * fast/events/click-focus-anchor.html:
        * fast/events/tab-focus-anchor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 9 Sep 2009 16:27:32 +0000 (16:27 +0000)]
2009-09-09  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Geolocation incorrectly calls error callback in case of exception in success callback.
        https://bugs.webkit.org/show_bug.cgi?id=27255

        * fast/dom/Geolocation/resources/callback-exception.js: Added. Tests that when an exception is thrown from the success callback, the error callback is not invoked.
        * fast/dom/Geolocation/callback-exception.html: Added. Wrapper for above test.
        * fast/dom/Geolocation/callback-exception-expected.txt: Added. Expected result for above test.
        * platform/gtk/Skipped: Modified. Adds the above tests to the skipped list.
2009-09-09  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Geolocation incorrectly calls error callback in case of exception in success callback.
        https://bugs.webkit.org/show_bug.cgi?id=27255

        Test: fast/dom/Geolocation/callback-exception.html

        * bindings/js/JSCustomPositionCallback.cpp: Modified.
        (WebCore::JSCustomPositionCallback::handleEvent): Modified. Removed raisedException out param.
        * bindings/js/JSCustomPositionCallback.h: Modified. Removed raisedException out param from handleEvent method and made handleEvent private.
        * bindings/js/JSCustomPositionErrorCallback.h: Modified. Made handleEvent private.
        * page/Geolocation.cpp: Modified.
        (WebCore::Geolocation::sendPosition): Modified. No longer call error callback in case of exception in success callback.
        * page/PositionCallback.h: Modified. Removed raisedException out param from handleEvent method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: When Geolocation permission is denied, stops watches as well as one-shots.
benm@google.com [Wed, 9 Sep 2009 15:59:18 +0000 (15:59 +0000)]
WebCore: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/watch.html
       fast/dom/Geolocation/permission-denied-stops-watches.html

* page/Geolocation.cpp: Modified.
(WebCore::Geolocation::setIsAllowed): Modified. Marks the permission error as fatal.
(WebCore::Geolocation::handleError): Modified. If the error is fatal, stops watchers as well as one-shots.
* page/PositionError.h: Modified.
(WebCore::PositionError::setIsFatal): Added. Marks an error as fatal.
(WebCore::PositionError::isFatal): Added. Determines whether an error is fatal.

LayoutTests: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

* fast/dom/Geolocation/resources/watch.js: Added. Tests that a watch correctly reports updates from the Geolocation service.
* fast/dom/Geolocation/watch.html: Added. Wrapper for above test.
* fast/dom/Geolocation/watch-expected.txt: Added. Expected result for above test.
* fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Added. Tests that when Geolocation permission is denied, watches are stopped, as well as one-shots.
* fast/dom/Geolocation/permission-denied-stops-watches.html: Added. Wrapper for above test.
* fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Added. Expected result for above test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-09 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Wed, 9 Sep 2009 15:15:32 +0000 (15:15 +0000)]
2009-09-09  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 28964 -  [Chromium] ChromiumDataObject should have getter/setter interface

        Added getter/setter methods and trivial inline implementations for each.
        (Note that they are not yet actually used.)
        Once the Chromium code is changed to use them instead of directly accessing the
        member variables, the member variables should be made private and cleaned up.

        No new tests (no functional behavior changed).

        * platform/chromium/ChromiumDataObject.h:
        (WebCore::ChromiumDataObject::mainURL):
        (WebCore::ChromiumDataObject::setMainURL):
        (WebCore::ChromiumDataObject::mainURLTitle):
        (WebCore::ChromiumDataObject::setMainURLTitle):
        (WebCore::ChromiumDataObject::textPlain):
        (WebCore::ChromiumDataObject::setTextPlain):
        (WebCore::ChromiumDataObject::textHTML):
        (WebCore::ChromiumDataObject::setTextHTML):
        (WebCore::ChromiumDataObject::htmlBaseURL):
        (WebCore::ChromiumDataObject::setHTMLBaseURL):
        (WebCore::ChromiumDataObject::content):
        (WebCore::ChromiumDataObject::releaseContent):
        (WebCore::ChromiumDataObject::setContent):
        (WebCore::ChromiumDataObject::contentFileExtension):
        (WebCore::ChromiumDataObject::setContentFileExtension):
        (WebCore::ChromiumDataObject::contentFileName):
        (WebCore::ChromiumDataObject::setContentFileName):
        (WebCore::ChromiumDataObject::fileNames):
        (WebCore::ChromiumDataObject::setFileNames):
        (WebCore::ChromiumDataObject::takeFileNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=29024
hausmann@webkit.org [Wed, 9 Sep 2009 14:56:12 +0000 (14:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL

Patch by Kent Hansen <khansen@trolltech.com> on 2009-09-09
Reviewed by Darin Adler.

These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.

* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSTypeInfo.h: Copied from JavaScriptCore/runtime/TypeInfo.h.
* runtime/Structure.h:
* runtime/TypeInfo.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIEl...
ddkilzer@apple.com [Wed, 9 Sep 2009 14:49:24 +0000 (14:49 +0000)]
    <webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()

        Reviewed by Mark Rowe.

        No change to layout test results.

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::clickPointY): Changed to return y value
        instead of x value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] locale date displays incorrect date format in symbian.
yael.aharon@nokia.com [Wed, 9 Sep 2009 13:26:08 +0000 (13:26 +0000)]
[Qt] locale date displays incorrect date format in symbian.
https://bugs.webkit.org/show_bug.cgi?id=29032

Patch by Pat Bradley <vincent.bradley@nokia.com> on 2009-09-08
Reviewed by Ariya Hidayat.

strftime() in Symbian does not support #
Layout tests cannot be run on Symbian yet, so they are not updated.

* runtime/DatePrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNPAPI Plugin NPP_AsFile not working on Qt Webkit
hausmann@webkit.org [Wed, 9 Sep 2009 09:53:18 +0000 (09:53 +0000)]
NPAPI Plugin NPP_AsFile not working on Qt Webkit
https://bugs.webkit.org/show_bug.cgi?id=29068

Patch by Rohini Ananth <rohini.ananth@nokia.com> on 2009-09-09
Reviewed by Simon Hausmann.

* platform/qt/FileSystemQt.cpp:
(WebCore::openTemporaryFile)
Autoremove property of QTemporaryFile has been set to false. Hence closeFile() just closes and does not delete the file.
This solves the deletion of created temp file in PluginStream::destroyStream() before passing to plugin in NPP_AsFile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdjust WinCairo-specific property sheet to use static versions of
bfulgham@webkit.org [Wed, 9 Sep 2009 07:13:05 +0000 (07:13 +0000)]
Adjust WinCairo-specific property sheet to use static versions of
libjpeg.lib and libpng.lib.  Change to libpng.lib required addition
of zlib.lib to link.

Reviewed by Dave Levin.

* win/tools/vsprops/WinCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJSON.stringify(Date) loses the milliseconds information
oliver@apple.com [Wed, 9 Sep 2009 07:02:24 +0000 (07:02 +0000)]
JSON.stringify(Date) loses the milliseconds information
https://bugs.webkit.org/show_bug.cgi?id=29063

Reviewed by Maciej Stachowiak.

Make sure we include milliseconds in the output of toISOString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by NOBODY (Build fix).
oliver@apple.com [Wed, 9 Sep 2009 05:55:54 +0000 (05:55 +0000)]
Reviewed by NOBODY (Build fix).

Remove a few incorrect changes I left in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSupport numeric index getters in bindings
oliver@apple.com [Wed, 9 Sep 2009 04:32:30 +0000 (04:32 +0000)]
Support numeric index getters in bindings
https://bugs.webkit.org/show_bug.cgi?id=29067

Reviewed by Sam Weinig.

Add HasNumericIndexGetter to indicate a non-custom getter that
returns a number.  The numeric index getter also uses PropertySlot's
setValue rather than setCustomIndex to avoid an additional indirect
call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 9 Sep 2009 03:03:18 +0000 (03:03 +0000)]
2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Mark Rowe.

        Reduce dglazkov's boboiness by properly concatenating revision value.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
            rather than "+".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowxWebKit Python extension build fix - get swig.py if it doesn't exist.
kevino@webkit.org [Wed, 9 Sep 2009 02:25:23 +0000 (02:25 +0000)]
wxWebKit Python extension build fix - get swig.py if it doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix for 2.8.
kevino@webkit.org [Wed, 9 Sep 2009 02:20:26 +0000 (02:20 +0000)]
wx build fix for 2.8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoshared-worker-exception.html needs to pause to let console messages get written out
atwilson@chromium.org [Wed, 9 Sep 2009 01:45:17 +0000 (01:45 +0000)]
shared-worker-exception.html needs to pause to let console messages get written out
https://bugs.webkit.org/show_bug.cgi?id=29043

Reviewed by Maciej Stachowiak.

* fast/workers/resources/shared-worker-exception.js:
(worker.onmessage):
Now invokes layoutTestController.notifyDone() via a timer so any pending ReportException tasks get a chance to fire.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 9 Sep 2009 00:29:09 +0000 (00:29 +0000)]
2009-09-08  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        In Mac Chromium, clicking below the last line of an editable area (textarea or
        contenteditable) should put the caret at the end of the last line, as in Mac Safari.

        Tests: LayoutTests/editing/selection/click-in-margins-inside-editable-div.html
               LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html

        * page/Settings.cpp:
        (WebCore::Settings::Settings): Change #if PLATFORM_MAC to be Mac-Chrome-inclusive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix an incorrect variable name in UpdateChromiumSource.
mrowe@apple.com [Wed, 9 Sep 2009 00:01:34 +0000 (00:01 +0000)]
Fix an incorrect variable name in UpdateChromiumSource.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't check for leaks on the release SnowLeopard builder.
mrowe@apple.com [Tue, 8 Sep 2009 22:51:32 +0000 (22:51 +0000)]
Don't check for leaks on the release SnowLeopard builder.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a SnowLeopard release builder.
mrowe@apple.com [Tue, 8 Sep 2009 22:39:43 +0000 (22:39 +0000)]
Add a SnowLeopard release builder.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake sure not to do an early return when a data URL stylesheet successfully loads...
hyatt@apple.com [Tue, 8 Sep 2009 22:17:21 +0000 (22:17 +0000)]
Make sure not to do an early return when a data URL stylesheet successfully loads.  We need to still
clear the old cached sheet out of all existing Frames.  Fixes the data URL stylesheet layout test failure.

Reviewed by Mark Rowe.

* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix windows build.
weinig@apple.com [Tue, 8 Sep 2009 22:14:51 +0000 (22:14 +0000)]
Fix windows build.

* dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore robust wx build fix for 2.9.
kevino@webkit.org [Tue, 8 Sep 2009 22:11:42 +0000 (22:11 +0000)]
More robust wx build fix for 2.9.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27046
weinig@apple.com [Tue, 8 Sep 2009 22:02:41 +0000 (22:02 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

Tests: fast/dom/Document/CaretRangeFromPoint/basic.html
       fast/dom/Document/CaretRangeFromPoint/replace-element.html

* dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
* dom/Document.h:
* dom/Document.idl:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

* fast/dom/Document/CaretRangeFromPoint: Added.
* fast/dom/Document/CaretRangeFromPoint/basic-expected.txt: Added.
* fast/dom/Document/CaretRangeFromPoint/basic.html: Added.
* fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt: Added.
* fast/dom/Document/CaretRangeFromPoint/replace-element.html: Added.
* fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove end of line whitespace check from check-webkit-style.
levin@chromium.org [Tue, 8 Sep 2009 21:46:12 +0000 (21:46 +0000)]
Remove end of line whitespace check from check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=29053

Patch by David Levin <levin@chromium.org> on 2009-09-08
Reviewed by Darin Adler.

* Scripts/modules/cpp_style.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, generate derived sources earlier in order to make sure
kevino@webkit.org [Tue, 8 Sep 2009 21:32:46 +0000 (21:32 +0000)]
wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 8 Sep 2009 21:11:56 +0000 (21:11 +0000)]
2009-09-08  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        <iterator> include in V8Proxy.h is spurious and causing ObjC compile issues for Chromium.

        Test: Chromium mac canary build is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 8 Sep 2009 21:05:26 +0000 (21:05 +0000)]
2009-09-08  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Updated results for media/audio-controls-rendering.html, and added 3 failing
        tests to the Skipped list to investigate further <http://webkit.org/b/29047>.

        * platform/win/Skipped:
        * platform/win/media/audio-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 8 Sep 2009 21:01:35 +0000 (21:01 +0000)]
2009-09-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=29044
        [GTK] Should update suggested-filename when the response is received

        Set suggested filename also when the response only comes after the
        download has started.

        * webkit/webkitdownload.cpp:
        (webkit_download_set_response):
        (webkit_download_set_suggested_filename):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_request_download):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 8 Sep 2009 20:34:54 +0000 (20:34 +0000)]
2009-09-08  Xan Lopez  <xlopez@igalia.com>

        Unreviewed attempt to fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's...
hyatt@apple.com [Tue, 8 Sep 2009 20:26:14 +0000 (20:26 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
parsed form.  Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.

Reviewed by Eric Seidel.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
* page/Settings.cpp:
(WebCore::Settings::setUserStyleSheetLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed buildfix.
kenneth@webkit.org [Tue, 8 Sep 2009 20:23:47 +0000 (20:23 +0000)]
Unreviewed buildfix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Fix Qt build after 48167, by adding the new cpp/h files
added to WebCore.gypi to WebCore.pro as well.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix.
kenneth@webkit.org [Tue, 8 Sep 2009 20:11:08 +0000 (20:11 +0000)]
Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Potential build fix for Qt 4.5

* Api/qwebpage.cpp:
(QWebPagePrivate::mousePressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 8 Sep 2009 20:06:05 +0000 (20:06 +0000)]
2009-09-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        should not pass URI fragments to libsoup
        https://bugs.webkit.org/show_bug.cgi?id=28687

        Strip the fragment from the URI before passing it to soup, since
        it forwards it to servers in some cases (like when using a proxy)
        which confuses them and makes them return 403/404.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Add QGraphicsScene events support to the Qt platform events.
kenneth@webkit.org [Tue, 8 Sep 2009 19:40:42 +0000 (19:40 +0000)]
WebCore: Add QGraphicsScene events support to the Qt platform events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

* platform/PlatformMouseEvent.h:
* platform/PlatformWheelEvent.h:
* platform/qt/PlatformMouseEventQt.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::applyDelta):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/qt: Add support for handling QGraphicsScene events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::handleClipboard):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
(QWebPage::event):
* Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate Security Group Members list.
weinig@apple.com [Tue, 8 Sep 2009 19:40:31 +0000 (19:40 +0000)]
Update Security Group Members list.

Reviewed by Adele Peterson.

* security/security-group-members.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Michael Nordman <michaeln@google.com>
eric@webkit.org [Tue, 8 Sep 2009 19:28:47 +0000 (19:28 +0000)]
2009-09-08  Michael Nordman  <michaeln@google.com>

        Reviewed by Eric Seidel.

        [Chromium] Cleanup: remove a few deprecated methods.
        https://bugs.webkit.org/show_bug.cgi?id=28960

        No new tests, just syntactic sugar.

        * platform/network/chromium/ResourceRequest.h:
        * platform/network/chromium/ResourceResponse.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Tue, 8 Sep 2009 19:21:14 +0000 (19:21 +0000)]
2009-09-08  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=28981

        [Qt] make npapi.h compile in winscw compiler.

        Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
        specific changes in npapi.h.
        Undefine XP_WIN when building for Symbian to avoid including Windows specific code.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Priit Laes <plaes@plaes.org>
kov@webkit.org [Tue, 8 Sep 2009 19:06:24 +0000 (19:06 +0000)]
2009-09-08  Priit Laes  <plaes@plaes.org>

        Reviewed by Gustavo Noronha.

        Fix up erroneus 'Since: @version@' tags in documentation.

        * webkit/webkitwebdatasource.cpp:
        * webkit/webkitwebresource.cpp:
        (webkit_web_resource_class_init):
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):
        * webkit/webkitwebwindowfeatures.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector assertion failure related to marking
oliver@apple.com [Tue, 8 Sep 2009 19:02:04 +0000 (19:02 +0000)]
Web Inspector assertion failure related to marking
https://bugs.webkit.org/show_bug.cgi?id=28997

Reviewed by Geoff Garen.

When wrapping the callback the JSInspectorCallbackWrapper creator was using
inheritorID for the prototype structure which is unsafe for anything other
than a pure JS object.  Instead we now create a new structure, which while
inefficient is not problematic as this code is not hit frequently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Kelly Norton <knorton@google.com>
dglazkov@chromium.org [Tue, 8 Sep 2009 18:34:48 +0000 (18:34 +0000)]
2009-09-08  Kelly Norton  <knorton@google.com>

        Reviewed by Dimitri Glazkov.

        Add missing extension to the file entry in WebCore.vcproj.

        * WebCore.vcproj/WebCore.vcproj: Added "cpp".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Tue, 8 Sep 2009 18:02:48 +0000 (18:02 +0000)]
2009-09-08  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        Fix DumpRenderTree build from clean tree on Tiger
        https://bugs.webkit.org/show_bug.cgi?id=28927

        * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
        DerivedSources/DumpRenderTree directory exists when
        building on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: dataTransfer.types() should not return Files if file list is empty in the...
jianli@chromium.org [Tue, 8 Sep 2009 18:02:11 +0000 (18:02 +0000)]
WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

We change the behavior to handle the empty file list in order to match the spec.

Tested by clipboard-file-access.html.

* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

Update the test script and expected result to reflect the behavior change.

* http/tests/security/clipboard/clipboard-file-access-expected.txt:
* http/tests/security/clipboard/resources/clipboard-file-access.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Steve VanDeBogart <vandebo@chromium.org>
japhet@chromium.org [Tue, 8 Sep 2009 17:58:05 +0000 (17:58 +0000)]
2009-09-08  Steve VanDeBogart  <vandebo@chromium.org>

        Reviewed by Eric Seidel.

        Handle middle click in Chromium like QT
        https://bugs.webkit.org/show_bug.cgi?id=28696

        Tested by middle-click-onpaste.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Kelly Norton <knorton@google.com>
eric@webkit.org [Tue, 8 Sep 2009 17:55:32 +0000 (17:55 +0000)]
2009-09-08  Kelly Norton  <knorton@google.com>

        Reviewed by Eric Seidel.

        WebInspector: Adds a timeline agent to InspectorController that collects
        high-level timing data about event dispatch, layout, painting and HTML
        parsing and makes it available to Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=25503

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * dom/Document.h:
        (WebCore::Document::inspectorTimelineAgent):
        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * inspector/DOMDispatchTimelineItem.cpp: Added.
        (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem):
        (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
        * inspector/DOMDispatchTimelineItem.h: Added.
        (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::enableTimeline):
        (WebCore::InspectorBackend::disableTimeline):
        (WebCore::InspectorBackend::timelineEnabled):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::enableTimeline):
        (WebCore::InspectorController::disableTimeline):
        (WebCore::InspectorController::timelineEnabled):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::timelineAgent):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::timelineWasEnabled):
        (WebCore::InspectorFrontend::timelineWasDisabled):
        (WebCore::InspectorFrontend::addItemToTimeline):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorTimelineAgent.cpp: Added.
        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::reset):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds):
        (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
        * inspector/InspectorTimelineAgent.h: Added.
        * inspector/TimelineItem.cpp: Added.
        (WebCore::TimelineItem::TimelineItem):
        (WebCore::TimelineItem::addToTimeline):
        (WebCore::TimelineItem::convertToScriptObject):
        (WebCore::TimelineItem::convertChildrenToScriptArray):
        (WebCore::TimelineItem::addChildItem):
        * inspector/TimelineItem.h: Added.
        (WebCore::):
        (WebCore::TimelineItem::~TimelineItem):
        (WebCore::TimelineItem::previous):
        (WebCore::TimelineItem::releasePrevious):
        (WebCore::TimelineItem::setEndTime):
        (WebCore::TimelineItem::type):
        * inspector/front-end/TimelineAgent.js: Added.
        (WebInspector.TimelineAgent):
        (WebInspector.addItemToTimeline):
        (WebInspector.timelineWasEnabled):
        (WebInspector.timelineWasDisabled):
        * inspector/front-end/inspector.html:
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::paintContents):
        * page/FrameView.h:
        (WebCore::FrameView::inspectorTimelineAgent):
        * page/Page.cpp:
        (WebCore::Page::inspectorTimelineAgent):
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Tue, 8 Sep 2009 17:44:17 +0000 (17:44 +0000)]
2009-09-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=29007
        Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 8 Sep 2009 17:37:10 +0000 (17:37 +0000)]
2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix unused variable warnings
        https://bugs.webkit.org/show_bug.cgi?id=29018

        No functional change, no tests.

        * history/qt/HistoryItemQt.cpp:
        (WebCore::HistoryItem::restoreState):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::putImageData):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMenuList):
2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix unused variable warnings
        https://bugs.webkit.org/show_bug.cgi?id=29018

        * Api/qwebpage.cpp:
        (QWebPagePrivate::keyPressEvent):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::startDownload):
        (WebCore::FrameLoaderClientQt::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 8 Sep 2009 17:30:05 +0000 (17:30 +0000)]
2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Use the declaration order in initializer lists
        https://bugs.webkit.org/show_bug.cgi?id=29017

        No functional change, no new tests.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Use the declaration order in initializer lists
        https://bugs.webkit.org/show_bug.cgi?id=29017

        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 8 Sep 2009 17:23:06 +0000 (17:23 +0000)]
2009-09-08  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Tests for ValidityState::typeMismatch() for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=28934

        * fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
        * fast/forms/ValidityState-typeMismatch-number.html: Added.
        * fast/forms/resources/ValidityState-typeMismatch-number.js: Added.
2009-09-08  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Implement ValidityState::typeMismatch() for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=28934

        Test: fast/forms/ValidityState-typeMismatch-number.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::formStringToDouble):
        * html/HTMLInputElement.h:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch):
        * html/ValidityState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix after introduction of platform/mock directory.
kevino@webkit.org [Tue, 8 Sep 2009 17:19:31 +0000 (17:19 +0000)]
wx build fix after introduction of platform/mock directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 8 Sep 2009 17:15:01 +0000 (17:15 +0000)]
2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
        https://bugs.webkit.org/show_bug.cgi?id=29011

        * wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for
        atomicIncrement and atomicDecrement

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48161 268f45cc-cd09-0410-ab3c-d52691b4dbfc