WebKit-https.git
8 years agorun-perf-tests should record indivisual value instead of statistics
rniwa@webkit.org [Thu, 20 Sep 2012 05:14:16 +0000 (05:14 +0000)]
run-perf-tests should record indivisual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155

Reviewed by Hajime Morita.

PerformanceTests:

Report the list of values as "values" so that run-perf-tests can parse them.

* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

Parse the list of indivisual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests:

The expected result now contains indivisual value.

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Print console warning about setVersion
dgrogan@chromium.org [Thu, 20 Sep 2012 04:49:43 +0000 (04:49 +0000)]
IndexedDB: Print console warning about setVersion
https://bugs.webkit.org/show_bug.cgi?id=96575

Reviewed by Tony Chang.

Source/WebCore:

setVersion has been out of the spec for almost a year but there are
still a lot of users.

We show the warning once per database object as an approximation for
once per page.

No new tests, but 150-something rebaselines.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):

LayoutTests:

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/resources-panel-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/createObjectStore-null-name-expected.txt:
* storage/indexeddb/cursor-added-bug-expected.txt:
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-continue-dir-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue-validity-expected.txt:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-overloads-expected.txt:
* storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update-value-argument-required-expected.txt:
* storage/indexeddb/cursor-value-expected.txt:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-close-expected.txt:
* storage/indexeddb/database-closepending-flag-expected.txt:
* storage/indexeddb/database-deletepending-flag-expected.txt:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
* storage/indexeddb/deleteObjectStore-null-name-expected.txt:
* storage/indexeddb/deleted-objects-expected.txt:
* storage/indexeddb/deletedatabase-transaction-expected.txt:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exceptions-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/index-duplicate-keypaths-expected.txt:
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/intversion-and-setversion-expected.txt:
* storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-sort-order-across-types-expected.txt:
* storage/indexeddb/key-sort-order-date-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-infinity-expected.txt:
* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-fetch-key-expected.txt:
* storage/indexeddb/keypath-intrinsic-properties-expected.txt:
* storage/indexeddb/lazy-index-population-expected.txt:
* storage/indexeddb/legacy-constants-expected.txt:
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/metadata-expected.txt:
* storage/indexeddb/mozilla/add-twice-failure-expected.txt:
* storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/delete-result-expected.txt:
* storage/indexeddb/mozilla/event-source-expected.txt:
* storage/indexeddb/mozilla/global-data-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-expected.txt:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/object-cursors-expected.txt:
* storage/indexeddb/mozilla/object-identity-expected.txt:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/objectstorenames-expected.txt:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/put-get-values-expected.txt:
* storage/indexeddb/mozilla/readonly-transactions-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/remove-index-expected.txt:
* storage/indexeddb/mozilla/remove-objectstore-expected.txt:
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/opencursor-key-expected.txt:
* storage/indexeddb/pending-activity-expected.txt:
* storage/indexeddb/pending-activity-workers-expected.txt:
* storage/indexeddb/pending-version-change-on-exit-expected.txt:
* storage/indexeddb/persistence-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/queued-commands-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/request-continue-abort-expected.txt:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/setVersion-null-expected.txt:
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/three-setversion-calls-expected.txt:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-active-flag-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-complete-workers-expected.txt:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/tutorial-expected.txt:
* storage/indexeddb/two-version-changes-expected.txt:
* storage/indexeddb/value-undefined-expected.txt:
* storage/indexeddb/values-odd-types-expected.txt:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-exclusive-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOSR exit sometimes neglects to create the arguments object
ggaren@apple.com [Thu, 20 Sep 2012 04:44:43 +0000 (04:44 +0000)]
OSR exit sometimes neglects to create the arguments object
https://bugs.webkit.org/show_bug.cgi?id=97162

Reviewed by Filip Pizlo.

../JavaScriptCore:

No performance change.

I don't know of any case where this is a real problem in TOT, but it
will become a problem if we start compiling eval, with, or catch, and/or
sometimes stop doing arguments optimizations in the bytecode.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
CreateArguments that has transformed into PhantomArguments. We used to
clear our reference to the CreateArguments node, but now we hold onto it,
so we need to account for it transforming.

Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
because that doesn't leave enough information behind for OSR exit to do
the right thing. Instead, maintain our reference to CreateArguments, and
rely on CreateArguments transforming into PhantomArguments after
optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
for OSR exit to create the arguments object.

Don't ASSERT that all PhantomArguments are unreferenced because we now
leave them in the graph as SetLocal(PhantomArguments), and that's harmless.

* dfg/DFGArgumentsSimplificationPhase.h:
(NullableHashTraits):
(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
for inline call frames so the OSR exit compiler can use it.

* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Don't load the 'arguments'
register to decide if we need to create the arguments object. Optimization
may have eliminated the initializing store to this register, in which
case we'll load garbage. Instead, use the global knowledge that all call
frames that optimized out 'arguments' now need to create it, and use a hash
table to make sure we do so only once per call frame.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): SetLocal(PhantomArguments) is unique
because we haven't just changed a value's format or elided a load or store;
instead, we've replaced an object with JSValue(). We could try to account
for this in a general way, but for now it's a special-case optimization,
so we give it a specific OSR hint instead.

../WTF:

* wtf/HashTraits.h:
(NullableHashTraits):
(WTF::NullableHashTraits::emptyValue):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd partial load test for PNG images with no alpha
noel.gordon@gmail.com [Thu, 20 Sep 2012 04:27:46 +0000 (04:27 +0000)]
Add partial load test for PNG images with no alpha
https://bugs.webkit.org/show_bug.cgi?id=96064

Reviewed by Simon Fraser.

Partial load test for a PNG image with no alpha: receive a partial number of image
bytes and stall forever. The partial image should be decoded and drawn and the green
<img> background should be visible.

* fast/images/resources/lenna.png: Added: this PNG image has no alpha.
* http/tests/images/png-partial-load-no-alpha-expected.png: Added.
* http/tests/images/png-partial-load-no-alpha-expected.txt: Added.
* http/tests/images/png-partial-load-no-alpha.html: Added.
* platform/chromium/http/tests/images/png-partial-load-no-alpha-expected.png: Added.
* platform/mac/TestExpectations: Add an IMAGE failure for the mac port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Basic authentication challenge credentials for stored credentials again...
commit-queue@webkit.org [Thu, 20 Sep 2012 02:34:43 +0000 (02:34 +0000)]
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-09-19
Reviewed by Rob Buis.

Source/WebCore:

This patch enable reading credentials from the persistent credential storage
when it is not private browsing mode and there is not a credential in the RAM
for the requested resource.

Since we don't load persistent stored credentials into RAM at the starting time,
even we have saved the credentials at the last browsing, after restarting the browser,
it will still challenge for credentials for the requesting resources.

No new tests, it uses the original authentication tests. There is no way to
clear all credentials or restarting browsers to test this feature.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::getProtectionSpace):
(WebCore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

Source/WebKit/blackberry:

Make the FrameLoaderClient use credential storage according to the macro
BLACKBERRY_CREDENTIAL_PERSIST

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] ButtonInputType of <input> element should have innerElement to make...
shinyak@chromium.org [Thu, 20 Sep 2012 02:07:27 +0000 (02:07 +0000)]
[Refactoring] ButtonInputType of <input> element should have innerElement to make <input> AuthorShadowDOM-ready
https://bugs.webkit.org/show_bug.cgi?id=95939

Reviewed by Dimitri Glazkov.

We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
as a child of RenderButton. <input type="button"> used the former one, and <button> used the latter one.
The former makes RenderButton a bit messy, and also prevents from making <input> AuthorShadowDOM ready.

So we remove RenderButton::setText() and refactor <input type="button"> to use a Shadow DOM to show text.

Since the text in <input type="button"> should create RenderTextFragment, we introduce TextForButtonInputType
class. RenderText will allow us to select the inner text of <input>, but it should not.

No new tests, existing tests should cover the change.

* html/BaseButtonInputType.cpp:
(TextForButtonInputType): Special Text node which creates RenderTextFragment.
(WebCore):
(WebCore::TextForButtonInputType::create):
(WebCore::TextForButtonInputType::TextForButtonInputType):
(WebCore::TextForButtonInputType::createRenderer):
(WebCore::BaseButtonInputType::BaseButtonInputType):
(WebCore::BaseButtonInputType::createShadowSubtree):
(WebCore::BaseButtonInputType::destroyShadowSubtree):
(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
the text node in ShadowDOM.
* html/BaseButtonInputType.h:
(BaseButtonInputType):
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
* html/InputType.cpp:
(WebCore::InputType::valueAttributeChanged):
(WebCore):
* html/InputType.h:
(InputType):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange): Removed unnecessary text related code.
* rendering/RenderButton.h:
(RenderButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove webkitPostMessage
abarth@webkit.org [Thu, 20 Sep 2012 02:05:09 +0000 (02:05 +0000)]
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

Actually disable webkitPostMessage. See
http://trac.webkit.org/changeset/128658 for more information.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
jason.liu@torchmobile.com.cn [Thu, 20 Sep 2012 02:05:05 +0000 (02:05 +0000)]
[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
https://bugs.webkit.org/show_bug.cgi?id=96994

Reviewed by Rob Buis.

We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.

No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix regex groups for bug matching in flakiness dashboard.
dpranke@chromium.org [Thu, 20 Sep 2012 01:52:02 +0000 (01:52 +0000)]
Fix regex groups for bug matching in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForBugs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Blob.webkitSlice
abarth@webkit.org [Thu, 20 Sep 2012 01:41:03 +0000 (01:41 +0000)]
Remove Blob.webkitSlice
https://bugs.webkit.org/show_bug.cgi?id=96715

Reviewed by Darin Fisher.

Based on these usage metrics, it appears that it is safe to remove
Blob.webkitSlice. Folks that were previously calling webkitSlice should
just call slice instead. They do the same thing.

Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
Ratio of Blob.webkitSlice calls to Document creation: 0.0053%

* fileapi/Blob.cpp:
(WebCore::Blob::slice):
* fileapi/Blob.h:
(Blob):
* fileapi/Blob.idl:
* fileapi/File.h:
(File):
* inspector/front-end/FileUtils.js:
(WebInspector.ChunkedFileReader.prototype._loadChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: print unexpected results using new TestExpectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 01:34:02 +0000 (01:34 +0000)]
nrwt: print unexpected results using new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97159

Unreviewed, build fix.

Change new-run-webkit-tests to print out failures using the new
syntax when there are unexpected results, e.g.:

52 tests ran as expected, 19 didn't:

Regressions: Unexpected failures : (2)
  failures/flaky/text.html [ Failure ]
  failures/unexpected/text-image-checksum.html [ Failure ]

and so forth

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_unexpected_results):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoupdate flakiness dashboard after cutover to new test expectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 01:13:32 +0000 (01:13 +0000)]
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(filterBugs):
(htmlForBugs):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoupdate flakiness dashboard after cutover to new test expectations syntax
dpranke@chromium.org [Thu, 20 Sep 2012 00:59:24 +0000 (00:59 +0000)]
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152

Reviewed by Ryosuke Niwa.

This change clones the TestExpectation parsing state machine
from python into javascript.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(parsedExpectations.lines.forEach):
(parsedExpectations):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe collapsing border code needs direction-aware border getters
jchaffraix@webkit.org [Thu, 20 Sep 2012 00:58:58 +0000 (00:58 +0000)]
The collapsing border code needs direction-aware border getters
https://bugs.webkit.org/show_bug.cgi?id=96710

Reviewed by Ojan Vafai.

This refactoring is needed to extend our collapsing border support for mixed directionality
at the table cell level (we currently wrongly ignore any direction below the row-group). For
now, the new helpers are dumb and return exactly the old result but they will be made
direction-aware in a follow-up change.

Refactoring covered by existing tests.

* rendering/RenderBox.h:
(WebCore::RenderBox::hasSameDirectionAs):
Added this helper function. For now, it's only used to compare against
the table direction but we will reuse it to compare the current cell
direction against the other table parts.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Transitioned those 2 functions to using the new direction-aware functions.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated those call sites to use RenderBox::hasSameDirectionAs.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningNextCell):
(WebCore::RenderTableCell::borderAdjoiningPreviousCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::borderAdjoiningCellStartBorder):
(WebCore::RenderTableCol::borderAdjoiningCellEndBorder):
(WebCore::RenderTableCol::borderAdjoiningCellBefore):
(WebCore::RenderTableCol::borderAdjoiningCellAfter):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
New direction-aware functions. Added some ASSERT to ensure
we don't call them with the wrong parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] ScriptController::compileAndRunScript() can crash
haraken@chromium.org [Thu, 20 Sep 2012 00:41:26 +0000 (00:41 +0000)]
[V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567

Reviewed by Adam Barth.

See chromium bug: http://code.google.com/p/chromium/issues/detail?id=146776

The root cause is that v8::PreCompile() can return 0 when the stack of
V8's parser overflows (c.f. http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/src/parser.cc&exact_package=chromium&q=kPreParseStackOverflow&type=cs&l=6021).

This patch adds the 0 check to the caller side. Given that precompileScript()
is just trying to speculatively precompile a script, it's OK to give up
precompiling for such edge cases.

Manually tested with the html generated by the following shell script:

  echo '<script language="JavaScript" type="text/javascript" src="asan-crash.js"></script>' > asan-crash.html
  echo 'if(wURLF.search("")>=0) {}' > asan-crash.js
  for i in `seq 14830`
  do
    echo 'else if(wURLF.search("")>=0) {}' >> asan-crash.js
  done

I didn't add the test because '14380' depends on an environment
and because we don't want to add a huge html test.

* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::precompileScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Pending call cleanup
jsbell@chromium.org [Thu, 20 Sep 2012 00:12:51 +0000 (00:12 +0000)]
IndexedDB: Pending call cleanup
https://bugs.webkit.org/show_bug.cgi?id=96952

Reviewed by Tony Chang.

Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
and replace queue of "second half open" calls with a single item.

No new tests - no functional changes.

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to unskip some tests by removing them from the Skipped list.
simon.fraser@apple.com [Thu, 20 Sep 2012 00:06:28 +0000 (00:06 +0000)]
Attempt to unskip some tests by removing them from the Skipped list.

Added new baselines for those that need them.

* platform/mac/Skipped:
* platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
* platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/mac/media/video-empty-source-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2509-expected.txt:
* platform/mac/tables/mozilla/bugs/bug34176-expected.txt:
* platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Improve glyph positioning of HarfBuzzShaper
bashi@chromium.org [Thu, 20 Sep 2012 00:00:45 +0000 (00:00 +0000)]
[Chromium] Improve glyph positioning of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97093

Reviewed by Tony Chang.

For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
Collect and shape HarfBuzzRuns, then set positions of glyphs.

No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
should close in the expectations. (not the identical, maybe there are subtle differences between
harfbuzz old and harfbuzz ng)

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
(WebCore):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
(HarfBuzzShaper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd backer@chromium.org as contributor
danakj@chromium.org [Wed, 19 Sep 2012 23:59:01 +0000 (23:59 +0000)]
Add backer@chromium.org as contributor
https://bugs.webkit.org/show_bug.cgi?id=97150

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html
dpranke@chromium.org [Wed, 19 Sep 2012 23:58:07 +0000 (23:58 +0000)]
[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html

Unreviewed, exepectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix v8 bug urls after syntax conversion
dpranke@chromium.org [Wed, 19 Sep 2012 23:55:02 +0000 (23:55 +0000)]
Fix v8 bug urls after syntax conversion

Unreviewed, expectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable resource load scheduling
simonjam@chromium.org [Wed, 19 Sep 2012 23:53:31 +0000 (23:53 +0000)]
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

* loader/ResourceLoadScheduler.cpp:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

* platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofix MISSING after TestExpectations conversion
dpranke@chromium.org [Wed, 19 Sep 2012 23:49:55 +0000 (23:49 +0000)]
fix MISSING after TestExpectations conversion
https://bugs.webkit.org/show_bug.cgi?id=97148

Tools:

Unreviewed, expectations change / build fix.

* Scripts/convert-test-expectations:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):

LayoutTests:

Unreviewed, expectations change.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen kerning is enabled, word spacing is doubly accounted for in RenderText::computeP...
mitz@apple.com [Wed, 19 Sep 2012 23:37:36 +0000 (23:37 +0000)]
When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=97146

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/word-space-with-kerning.html

* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
measured with their trailing space, if there is one, then the width of a space is subtracted.
Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
word spacing, since it is included in the result of widthFromCache().

LayoutTests:

* fast/text/word-space-with-kerning-expected.html: Added.
* fast/text/word-space-with-kerning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix lines missed (??) in mac-wk2/TestExpectations
dpranke@chromium.org [Wed, 19 Sep 2012 23:29:41 +0000 (23:29 +0000)]
Fix lines missed (??) in mac-wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Remove "current transaction" concept from backing store
jsbell@chromium.org [Wed, 19 Sep 2012 23:27:20 +0000 (23:27 +0000)]
IndexedDB: Remove "current transaction" concept from backing store
https://bugs.webkit.org/show_bug.cgi?id=96663

Reviewed by Tony Chang.

Source/WebCore:

IndexedDB should allow multiple transactions to run in parallel within and
across databases within an origin. As an initial step to enabling this, the
backing store should not hold a "current transaction" - instead, operations
should be done relative to a transaction managed by the database.

No new tests - no functional changes.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransaction):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update fake class with new method signatures.

* tests/IDBFakeBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r128802): It made some JS tests crash
fpizlo@apple.com [Wed, 19 Sep 2012 23:27:00 +0000 (23:27 +0000)]
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconvert chromium android TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:25:50 +0000 (23:25 +0000)]
convert chromium android TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97145

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/chromium-android/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: convert chromium TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:23:02 +0000 (23:23 +0000)]
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Reviewed by Ryosuke Niwa.

Actually land the file supposedly landed below :).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconvert apple win TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:19:44 +0000 (23:19 +0000)]
convert apple win TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97144

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/win-wk2/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconvert apple mac TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:17:44 +0000 (23:17 +0000)]
convert apple mac TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/mac-lion/TestExpectations:
* platform/mac-snowleopard/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconvert Efl TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:15:07 +0000 (23:15 +0000)]
convert Efl TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97142

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoconvert Gtk TestExpectations files to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:11:34 +0000 (23:11 +0000)]
convert Gtk TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97141

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: convert Qt TestExpectations to the new format
dpranke@chromium.org [Wed, 19 Sep 2012 23:02:43 +0000 (23:02 +0000)]
nrwt: convert Qt TestExpectations to the new format
https://bugs.webkit.org/show_bug.cgi?id=97140

Unreviewed, expectations change.

Files were converted using Tools/Scripts/convert-test-expectations.

* platform/qt-4.8/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: convert chromium TestExpectations to the new syntax
dpranke@chromium.org [Wed, 19 Sep 2012 23:00:37 +0000 (23:00 +0000)]
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139

Tools:

Reviewed by Ryosuke Niwa.

Add in a file temporarily that does the conversion of
test expectations formats

* Tools/Scripts/convert-test-expectations: Added.

LayoutTests:

Reviewed by Ryosuke Niwa.

This does a wholesale change of the file from

  BUGS MODIFIERS : test = EXPECTATIONS

to

  Bugs [ Modifiers] test [ Expectations ]

as per the new syntax.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed - remove debugging code from a pair of tests.
jsbell@chromium.org [Wed, 19 Sep 2012 22:53:20 +0000 (22:53 +0000)]
Unreviewed - remove debugging code from a pair of tests.

During development these tests had their own timers to terminate early
rather than timing out, so partial script output could be seen. Removing,
as it could cause the tests to flake under load.

* storage/indexeddb/lazy-index-population.html:
* storage/indexeddb/resources/cursor-finished.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: run-perf-tests no longer reports the total test time
rniwa@webkit.org [Wed, 19 Sep 2012 22:48:03 +0000 (22:48 +0000)]
REGRESSION: run-perf-tests no longer reports the total test time
https://bugs.webkit.org/show_bug.cgi?id=97138

Reviewed by Tony Chang.

Report the finished time as a info-level log as opposed to a debug level log.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Store the contents scale factor in PlatformContextSkia on initialization
commit-queue@webkit.org [Wed, 19 Sep 2012 22:43:51 +0000 (22:43 +0000)]
[chromium] Store the contents scale factor in PlatformContextSkia on initialization
https://bugs.webkit.org/show_bug.cgi?id=96137

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-09-19
Reviewed by Stephen White.

Source/WebCore:

When the compositor creates a PlatformContextSkia, the scale on |canvas| will
be equal to the content scale factor (which, without pinch-to-zoom, will be
the same as the device scale factor). Set this value as a member on PlatformContextSkia,
which will be used to correctly render glyphs when hinting is used and the device
scale factor is not 1.

Tests: added two new unit tests.

* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setHintingScaleFactor):
(WebCore::PlatformContextSkia::hintingScaleFactor):

Source/WebKit/chromium:

Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
for the skia patch here: https://codereview.appspot.com/6506099/.
Also added two new unit tests.

* features.gypi:
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::HintingScaleCallback::HintingScaleCallback):
(HintingScaleCallback):
(WebCore::HintingScaleCallback::operator()):
(WebCore::TEST_F):
* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

LayoutTests:

These tests will fail due to a font hinting/rasterization issue with
chromium DRT pixel tests having a page/device scale factor of 2.
See crbug.com/150682.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not assume that a ByVal access is generic just because it was unprofiled
fpizlo@apple.com [Wed, 19 Sep 2012 22:36:44 +0000 (22:36 +0000)]
DFG should not assume that a ByVal access is generic just because it was unprofiled
https://bugs.webkit.org/show_bug.cgi?id=97088

Reviewed by Geoffrey Garen.

We were not disambiguating between "Undecided" in the sense that the array profile
has no useful information versus "Undecided" in the sense that the array profile
knows that the access has not executed. That's an important distinction, since
the former form of "Undecided" means that we should consult value profiling, while
the latter means that we should force exit unless the value profiling indicates
that the access must be generic (base is not cell or property is not int).

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport new TestExpectations format alongside old one
dpranke@chromium.org [Wed, 19 Sep 2012 22:36:35 +0000 (22:36 +0000)]
Support new TestExpectations format alongside old one
https://bugs.webkit.org/show_bug.cgi?id=96588

Reviewed by Ojan Vafai.

This patch adds support for actually reading in lines formatted
in the new style, and when we re-serialize/write out the file,
all lines will be written in the new style. Note that reading in
the old style is still supported, and no updates are being made
to the actual TestExpectations files as part of this change.

This change updates most but not all of the unit tests to use
the new syntax. I will update the rest when (or before where
possible) I drop support for the old format.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.to_string):
(TestExpectationLine._format_line):
(TestExpectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):
(SkippedTests.test_skipped_entry_dont_exist):
(NewExpectationSyntaxTests.test_warnings):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(RebaseliningTest.test_no_get_rebaselining_failures):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_string_roundtrip):
(TestExpectationSerializationTests.test_list_roundtrip):
(TestExpectationSerializationTests.test_reconstitute_only_these):
(TestExpectationSerializationTests.test_string_whitespace_stripping):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_lint_test_files__errors):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations_noop):
(test_overrides_are_included_correctly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoimplement first part of support for the new TestExpectations syntax
dpranke@chromium.org [Wed, 19 Sep 2012 22:29:45 +0000 (22:29 +0000)]
implement first part of support for the new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=96569

Reviewed by Ryosuke Niwa.

This patch implements support for parsing a line of the new
format for the TestExpectations file and converting it back into
the old format for compatibility. This routine is not yet used
by anything.

The new format is documented at:
  http://trac.webkit.org/wiki/TestExpectations

but, in short:

  [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]

- Comments are indicated with "#" instead of "//"
- If no expectations are specified we default to Skip for
  compatibility with the Skipped files (these two changes make
  Skipped files a subset of TestExpectations files)

- All of the tokens are now CamelCase instead of ALLCAPS.
- FAIL -> Failure
- IMAGE -> ImageOnlyFailure
- WONTFIX -> WontFix
- modifiers refer to just the platforms and configurations
  (release/debug) that the line applies to.
- WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
  expectations
- expectations will typically be written out in lexicographic order
- We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
  instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_new_format):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(NewExpectationSyntaxTests):
(NewExpectationSyntaxTests.assert_exp):
(NewExpectationSyntaxTests.test_bare_name):
(NewExpectationSyntaxTests.test_bare_name_and_bugs):
(NewExpectationSyntaxTests.test_comments):
(NewExpectationSyntaxTests.test_config_modifiers):
(NewExpectationSyntaxTests.test_unknown_config):
(NewExpectationSyntaxTests.test_unknown_expectation):
(NewExpectationSyntaxTests.test_skip):
(NewExpectationSyntaxTests.test_slow):
(NewExpectationSyntaxTests.test_wontfix):
(NewExpectationSyntaxTests.test_blank_line):
(NewExpectationSyntaxTests.test_warnings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] HarfBuzzShaper should take into account combining characters
bashi@chromium.org [Wed, 19 Sep 2012 22:29:05 +0000 (22:29 +0000)]
[Chromium] HarfBuzzShaper should take into account combining characters
https://bugs.webkit.org/show_bug.cgi?id=97069

Reviewed by Tony Chang.

When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
combining character sequence if there are one or more mark characters are followed.
If there is no combined glyphs in the font, use fallback font for mark characters.

No new tests.
In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
U+0947 (devanagari vowel sign e) should be displayed.
In fast/text/wide-zero-width-space.html, &eacute; and e&#0301; should look identical.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore):
(WebCore::fontDataForCombiningCharacterSequence): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWarning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
psolanki@apple.com [Wed, 19 Sep 2012 22:23:25 +0000 (22:23 +0000)]
Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
https://bugs.webkit.org/show_bug.cgi?id=97137

Reviewed by Benjamin Poulain.

m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
#if ENABLE(WEB_PROCESS_SANDBOX).

* Shared/SandboxExtension.h:
(HandleArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable some failing IDB tests
dgrogan@chromium.org [Wed, 19 Sep 2012 22:01:09 +0000 (22:01 +0000)]
Disable some failing IDB tests
https://bugs.webkit.org/show_bug.cgi?id=97135

Reviewed by Nate Chapin.

They were broken in r129037.

* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
dpranke@chromium.org [Wed, 19 Sep 2012 21:51:57 +0000 (21:51 +0000)]
nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
https://bugs.webkit.org/show_bug.cgi?id=96845

Reviewed by Ojan Vafai.

In preparation for the new TestExpectations syntax, we replace
all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
make switching to the new syntax lossless (i.e., we lose
information now, not then).

Tools:

Note that we can still parse in results.json files that have the
old data for backwards compatibility.

* Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult._failure_types_from_actual_result):
* Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
(ResultsJSONParserTest):
(test_basic):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_bad_expectations):
(BasicTests):
(BasicTests.test_basic):
(MiscTests):
(MiscTests.test_multiple_results):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(test_get_expectations_string):
(test_parse_warning):
(test_error_on_different_platform):
(test_error_on_different_build_type):
(test_overrides):
(test_overrides__directory):
(test_overrides__duplicate):
(test_pixel_tests_flag):
(test_more_specific_override_resets_skip):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_test_expectations):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_does_not_include_overrides):
(test_overrides_are_included_correctly):

LayoutTests:

* platform/chromium-android/TestExpectations:
* platform/chromium/TestExpectations:
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
tony@chromium.org [Wed, 19 Sep 2012 21:47:40 +0000 (21:47 +0000)]
Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=97049

Reviewed by Ojan Vafai.

This is an incremental step in making updateLogicalHeight non-virtual so it's
possible to call computeLogicalHeight on any RenderBox and get the right
version of the function.

The code in RenderIFrame::layout was calling flattenFrame(), which would
query it's bounding box size.  Since we hadn't done a layout yet, the size
is unknown.  The fix is to only call flattenFrame() after calling
updateLogicalWidth and updateLogicalHeight. We can then fixup the size of
the iframe.

No new tests, existing tests in fast/frames/flattening should continue to pass.

* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
* rendering/RenderIFrame.h:
(RenderIFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not emit PutByVal hole case unless it has to
fpizlo@apple.com [Wed, 19 Sep 2012 21:43:10 +0000 (21:43 +0000)]
DFG should not emit PutByVal hole case unless it has to
https://bugs.webkit.org/show_bug.cgi?id=97080

Reviewed by Geoffrey Garen.

This causes us to generate less code for typical PutByVal's. But if profiling tells us
that the hole case is being hit, we generate the same code as we would have generated
before. This seems like a slight speed-up across the board.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):
* assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::store8):
* assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::store8):
* assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::movb_i8m):
* bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfMayStoreToHole):
(JSC::ArrayProfile::mayStoreToHole):
(ArrayProfile):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::mayStoreToHole):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.h:
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] After zooming into an input field, zoom out when focus is lost.
mifenton@rim.com [Wed, 19 Sep 2012 21:35:01 +0000 (21:35 +0000)]
[BlackBerry] After zooming into an input field, zoom out when focus is lost.
https://bugs.webkit.org/show_bug.cgi?id=97128

Reviewed by Rob Buis.

When the page has automatically zoomed in for input
focus, unzoom it when input focus is lost or keyboard hidden.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Clean up the SpellingLog output
commit-queue@webkit.org [Wed, 19 Sep 2012 21:10:14 +0000 (21:10 +0000)]
[BlackBerry] Clean up the SpellingLog output
https://bugs.webkit.org/show_bug.cgi?id=97129

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-19
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down...
commit-queue@webkit.org [Wed, 19 Sep 2012 21:09:01 +0000 (21:09 +0000)]
[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down test needs rebaseline for r129023.
https://bugs.webkit.org/show_bug.cgi?id=97130

Patch by Robert Flack <flackr@chromium.org> on 2012-09-19
Reviewed by Nate Chapin.

Rebaseline compositing/geometry/fixed-position-iframe-composited-page-scale-down.html.

* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix vertical positioning problem for 'X' in search field
rwlbuis@webkit.org [Wed, 19 Sep 2012 20:52:43 +0000 (20:52 +0000)]
[BlackBerry] Fix vertical positioning problem for 'X' in search field
https://bugs.webkit.org/show_bug.cgi?id=97126

Reviewed by Antonio Gomes.

We have the same problem as described in bug 30245, so integrate that code.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::convertToPaintingRect):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add SpellingLog for spell checking options request.
mifenton@rim.com [Wed, 19 Sep 2012 20:43:54 +0000 (20:43 +0000)]
[BlackBerry] Add SpellingLog for spell checking options request.
https://bugs.webkit.org/show_bug.cgi?id=97125

Reviewed by Rob Buis.

Add spell checking log to indicate the calculated
text position for spell checking option requests.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed. Build fix.
hclam@chromium.org [Wed, 19 Sep 2012 20:35:30 +0000 (20:35 +0000)]
[chromium] Unreviewed. Build fix.

Not building WebImageTest.cpp for component build.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Free up resources used by completed cursors earlier
jsbell@chromium.org [Wed, 19 Sep 2012 20:35:19 +0000 (20:35 +0000)]
IndexedDB: Free up resources used by completed cursors earlier
https://bugs.webkit.org/show_bug.cgi?id=97023

Reviewed by Tony Chang.

Source/WebCore:

Prior to this patch, IDBCursor objects are kept around by their parent
IDBTransaction until the transaction finishes. It's possible to release
references to them earlier, when the cursor has been "run to the end",
as no further events will fire and all calls to continue() etc should fail.

This change tells the cursor it's done when "null" finally comes through in
the IDBRequest, and the cursor then lets transaction know it can be
forgotten.

The added test doesn't distinguish the new behavior, but does exercise
"finished" cursors and apparently we didn't have tests for these before.

Test: storage/indexeddb/cursor-finished.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Make idempotent; notify transaction.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess): Tell cursor it's finished before releasing.
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::cursorFinished): New method for explicit notification.
* Modules/indexeddb/IDBTransaction.h:
(OpenCursorNotifier):

LayoutTests:

Test to exercise cursor methods after the cursor has been run to the end.

* storage/indexeddb/cursor-finished-expected.txt: Added.
* storage/indexeddb/cursor-finished.html: Added.
* storage/indexeddb/resources/cursor-finished.js: Added.
(test):
(prepareDatabase):
(onDeleteSuccess):
(onUpgradeNeeded):
(onOpenSuccess):
(onCursorSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: fire upgradeneeded even without an explicit integer version
dgrogan@chromium.org [Wed, 19 Sep 2012 20:28:35 +0000 (20:28 +0000)]
IndexedDB: fire upgradeneeded even without an explicit integer version
https://bugs.webkit.org/show_bug.cgi?id=96444

Reviewed by Tony Chang.

Source/WebCore:

Also of note:
- New databases now get a default version of 1 instead of
the empty string when they are opened.
- We now allow databases with an integer version to revert to a string
version by calling setVersion.

Implementation detail: we store both an integer version and string
version for a particular database. If both are set we give preference
to the integer version and assume the db is on the integer track.

Test: storage/indexeddb/intversion-two-opens-no-versions.html

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
Now that this can be called even after an int version is set we have
to make it revoke the int version.

(WebCore::IDBDatabaseBackendImpl::openConnection):
Nested ifs were getting deep, so refactor to return early instead.

(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::resetVersion):
Now that an int version could have been set before setVersion was
called we have to reset the int version on abort.

* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
0 is now a valid integer version to store to leveldb if an idb
database is reverting to a string version.

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
If the open request did not specify an integer version but
upgradeneeded is called, it means the database was given the default
version of 1.

LayoutTests:

Mostly updating expectations about getting an upgradeneeded on a new
database and the default version being 1 instead of "".

* http/tests/inspector/indexeddb/database-structure-expected.txt:
* storage/indexeddb/cursor-overloads-expected.txt:
* storage/indexeddb/cursor-overloads.html:
* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/intversion-and-setversion-expected.txt:
Remove test that setVersion fires an error if an int version is set.
Change it to testing that an int version can replace a string version
that replaced an int version.

* storage/indexeddb/intversion-bad-parameters-expected.txt:
* storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt: Removed.
setVersion is no longer invalid so this test can be deleted.

* storage/indexeddb/intversion-omit-parameter-expected.txt:
We now fully pass this test.

* storage/indexeddb/intversion-two-opens-no-versions-expected.txt: Added.
* storage/indexeddb/intversion-two-opens-no-versions.html: Renamed from LayoutTests/storage/indexeddb/intversion-invalid-setversion-has-no-side-effects.html.
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/open-during-transaction-expected.txt:
This test had a bug in it AND its behavior is changed. It was trying
to open one database twice and another once but was actually opening
three different databases. The behavior change is that now the
transaction finishes while the last call to open is firing
upgradeneeded.

* storage/indexeddb/pending-activity-expected.txt:
* storage/indexeddb/pending-activity-workers-expected.txt:
* storage/indexeddb/resources/intversion-and-setversion.js:
(deleteSuccess):
(initialUpgradeNeeded):
(openSuccess):
(firstUpgradeNeeded):
(transactionCompleted):
(firstOpenWithVersion):
(secondSetVersionCallback):
(setIntVersion2):
(versionChangeGoingFromStringToInt):
(version2ConnectionBlocked):
(version2ConnectionSuccess):
(errorWhenTryingLowVersion):
* storage/indexeddb/resources/intversion-invalid-setversion-has-no-side-effects.js: Removed.
* storage/indexeddb/resources/intversion-two-opens-no-versions.js: Added.
(test):
(deleteSuccess):
(connection1UpgradeNeeded):
(connection1OpenSuccess):
(connection2UpgradeNeeded):
(connection2OpenSuccess):
* storage/indexeddb/resources/list-ordering.js:
* storage/indexeddb/resources/open-during-transaction.js:
(startTransaction.trans.oncomplete):
(startTransaction):
(tryOpens.openreq3.onsuccess):
(tryOpens):
* storage/indexeddb/resources/pending-activity.js:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: A few control types are returning the wrong answer for isReadOnly
dmazzoni@google.com [Wed, 19 Sep 2012 19:55:19 +0000 (19:55 +0000)]
AX: A few control types are returning the wrong answer for isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html
       platform/mac/accessibility/form-control-value-settable.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

* platform/chromium/accessibility/readonly-expected.txt: Added.
* platform/chromium/accessibility/readonly.html: Added.
* platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
* platform/mac/accessibility/form-control-value-settable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 19:49:45 +0000 (19:49 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        Chromium gardening.

        A test is mistakenly marked as both SLOW and TIMEOUT.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed build correction to update Skipped list
bfulgham@webkit.org [Wed, 19 Sep 2012 19:33:51 +0000 (19:33 +0000)]
[WinCairo] Unreviewed build correction to update Skipped list
to match current Windows list.

* platform/wincairo/Skipped: Updated to match Apple build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebImage should use ImageDecoder directly
hclam@chromium.org [Wed, 19 Sep 2012 19:17:47 +0000 (19:17 +0000)]
[chromium] WebImage should use ImageDecoder directly
https://bugs.webkit.org/show_bug.cgi?id=96135

Reviewed by Adam Barth.

This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.

WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.

Tests: WebImageTest.PNGImage
       WebImageTest.ICOImage
       WebImageTest.BadImage

* WebKit.gypi:
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
* tests/WebImageTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
* tests/data/black-and-white.ico: Added.
* tests/data/white-1x1.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 19:15:28 +0000 (19:15 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        Chromium gardening.
        Mark a consistently passing test as such, tweak flakiness
        of several tests based on recent build results.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove unused PlatformSupport reference in V8GCController
pilgrim@chromium.org [Wed, 19 Sep 2012 19:12:49 +0000 (19:12 +0000)]
[Chromium] Remove unused PlatformSupport reference in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=97118

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8GCController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewIm...
commit-queue@webkit.org [Wed, 19 Sep 2012 19:07:39 +0000 (19:07 +0000)]
[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=96112

Patch by Oli Lan <olilan@chromium.org> on 2012-09-19
Reviewed by Adam Barth.

Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.

This will be used by the Android port to implement platform-specific gesture behaviour.

This is tested by the new test WebViewTest.ClientTapHandlers.

* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::didHandleGestureEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
pilgrim@chromium.org [Wed, 19 Sep 2012 18:56:31 +0000 (18:56 +0000)]
[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=97117

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8DOMWindowShell.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Remove WorkerContextExecutionProxy::runScript()
haraken@chromium.org [Wed, 19 Sep 2012 18:52:18 +0000 (18:52 +0000)]
[V8] Remove WorkerContextExecutionProxy::runScript()
https://bugs.webkit.org/show_bug.cgi?id=97060

Reviewed by Adam Barth.

To kill WorkerContextExecutionProxy, this patch removes
WorkerContextExecutionProxy::runScript() by replacing it
with ScriptRunner::runCompiledScript().

For the replacement, this patch moves TryCatch logic in
runCompiledScript() to the caller side. The reason why
we have to avoid nesting TryCatches is a V8 bug:
http://code.google.com/p/v8/issues/detail?id=2166

No tests. No change in behavior.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
* bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 18:04:16 +0000 (18:04 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        Chromium gardening, remove flaky tests that don't appear to
        actually be flaky.
        https://bugs.webkit.org/show_bug.cgi?id=78725

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove custom painting code for searchCancel
rwlbuis@webkit.org [Wed, 19 Sep 2012 18:03:48 +0000 (18:03 +0000)]
[BlackBerry] Remove custom painting code for searchCancel
https://bugs.webkit.org/show_bug.cgi?id=97119

Reviewed by Antonio Gomes.

Remove the dynamic painting code for searchCancel, we use a png file now.

* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Support high DPI scroll bar on top level web frame.
commit-queue@webkit.org [Wed, 19 Sep 2012 17:58:04 +0000 (17:58 +0000)]
[chromium] Support high DPI scroll bar on top level web frame.
https://bugs.webkit.org/show_bug.cgi?id=95134

Patch by Robert Flack <flackr@chromium.org> on 2012-09-19
Reviewed by Adrienne Walker.

Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.

* src/NonCompositedContentHost.cpp:
(WebKit::setScrollbarBoundsContainPageScale):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WTR] Memory leaks in TestRunner::deliverWebIntent()
commit-queue@webkit.org [Wed, 19 Sep 2012 17:57:29 +0000 (17:57 +0000)]
[WTR] Memory leaks in TestRunner::deliverWebIntent()
https://bugs.webkit.org/show_bug.cgi?id=97111

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Fix memory leaks in WKBundleIntentCreate() by adopting strings
created with WKStringCreateWithUTF8CString().

* WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
(WKBundleIntentCreate):

Tools:

Fix memory leaks in deliverWebIntent() by adopting strings
created with WKStringCreateWithUTF8CString().

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::deliverWebIntent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 17:56:34 +0000 (17:56 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        Chromium gardening.
        fast/filesystem/workers/detached-frame-crash.html does not appear to be
        flakily crashing anymore.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
pilgrim@chromium.org [Wed, 19 Sep 2012 17:53:48 +0000 (17:53 +0000)]
[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97116

Reviewed by Adam Barth.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
(FrameLoaderClient):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
commit-queue@webkit.org [Wed, 19 Sep 2012 17:52:14 +0000 (17:52 +0000)]
[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97082

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):

LayoutTests:

Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.

* platform/efl-wk2/TestExpectations:
* platform/efl/fast/forms/select-writing-direction-natural-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement 'mask-type' for <mask>
krit@webkit.org [Wed, 19 Sep 2012 17:50:26 +0000 (17:50 +0000)]
Implement 'mask-type' for <mask>
https://bugs.webkit.org/show_bug.cgi?id=97011

Reviewed by Andreas Kling.

Source/WebCore:

The CSS Masking specification defines the presentation attribute 'mask-type' to
switch between luminance and alpha masking. 'mask-type' just affects the SVG
mask element. The luminance masking is the current behavior of of SVG masking.
Alpha masking is simular to '-webkit-mask-image'.

This patch implements this property and make it possible to switch between both
masking modes. Since the default value is 'luminance', this does not break
exisiting content which is tested with exisiting tests.

http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type

Tests: svg/css/mask-type.html
       svg/masking/mask-type-alpha-expected.svg
       svg/masking/mask-type-alpha.svg
       svg/masking/mask-type-luminance-expected.svg
       svg/masking/mask-type-luminance.svg
       svg/masking/mask-type-not-set-expected.svg
       svg/masking/mask-type-not-set.svg

* css/CSSComputedStyleDeclaration.cpp: Add mask-type property.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EMaskType):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in: Add mask-type.
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/SVGCSSValueKeywords.in:
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialMaskType):
(WebCore::SVGRenderStyle::setMaskType):
(SVGRenderStyle):
(WebCore::SVGRenderStyle::maskType):
(WebCore::SVGRenderStyle::setBitDefaults):
* rendering/style/SVGRenderStyleDefs.h:
* rendering/svg/RenderSVGResourceMasker.cpp:

    Switch between the two masking modes according to the
    computed value of mask-type.

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):
* svg/svgattrs.in: Add the new attribute to the attribute list.

LayoutTests:

Added new tests for switching the masking mode on <mask> element with 'mask-type'.

* svg/css/mask-type-expected.txt: Added.
* svg/css/mask-type.html: Added.
* svg/masking/mask-type-alpha-expected.svg: Added.
* svg/masking/mask-type-alpha.svg: Added.
* svg/masking/mask-type-luminance-expected.svg: Added.
* svg/masking/mask-type-luminance.svg: Added.
* svg/masking/mask-type-not-set-expected.svg: Added.
* svg/masking/mask-type-not-set.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove unused popupsAllowed function from PlatformSupport
pilgrim@chromium.org [Wed, 19 Sep 2012 17:45:55 +0000 (17:45 +0000)]
[Chromium] Remove unused popupsAllowed function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96521

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 17:37:53 +0000 (17:37 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        chromium TestExpectations update.
        fast/filesystem/file-writer-write-overlapped.html and
        fast/filesystem/workers/file-writer-write-overlapped.html
        are flaky in WIN DEBUG only.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-09-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 19 Sep 2012 17:25:59 +0000 (17:25 +0000)]
2012-09-19  Nate Chapin  <japhet@chromium.org>

        TextExpectations update, remove entries for consistently passing tests.
        https://bugs.webkit.org/show_bug.cgi?id=74746

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 19 Sep 2012 17:14:00 +0000 (17:14 +0000)]
Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r128995.
commit-queue@webkit.org [Wed, 19 Sep 2012 16:49:05 +0000 (16:49 +0000)]
Unreviewed, rolling out r128995.
http://trac.webkit.org/changeset/128995
https://bugs.webkit.org/show_bug.cgi?id=97114

Causes the api tests to segfault. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-19

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::runTest):
* tests/UnitTestUtils/EWKTestBase.h:
(EWKUnitTests):
(EWKTestBase):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestEcoreEvas):
(EWKUnitTests):
(EWKTestView):
* tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
* tests/test_runner.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add function playerId() in class PageClientBlackBerry
commit-queue@webkit.org [Wed, 19 Sep 2012 15:54:15 +0000 (15:54 +0000)]
[BlackBerry] Add function playerId() in class PageClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=97099

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-09-19
Reviewed by Yong Li.

Source/WebCore:

Added function playerID() in class PageClientBlackBerry.

Internally reviewed by Charles Wei.

No new tests since there's no functional change.

* platform/blackberry/PageClientBlackBerry.h:

Source/WebKit/blackberry:

Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
and replaced the implementation of FrameLoaderClientBlackBerry::playerId().

Internally reviewed by Charles Wei.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::playerID):
(WebKit):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::playerId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is...
commit-queue@webkit.org [Wed, 19 Sep 2012 15:30:43 +0000 (15:30 +0000)]
[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
https://bugs.webkit.org/show_bug.cgi?id=96300

Patch by Raul Hudea <rhudea@adobe.com> on 2012-09-19
Reviewed by Yury Semikhatsky.

All CSS Regions APIs should be exposed only if CSS_REGIONS is enabled

No new tests because of no behavior changes.

* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage): Fix compile without CSS_REGIONS enabled and added an ASSERT_NOT_REACHED as in other functions
* dom/Element.cpp: Compile webkitRegionOverset only if CSS_REGIONS is enabled
(WebCore):
* dom/Element.h:
* dom/Element.idl: Expose webkitRegionOverset only if CSS_REGIONS is enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 19 Sep 2012 15:12:46 +0000 (15:12 +0000)]
Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

Adding platform-specific baselines after r128861.

* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Added.
* platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix incremental builds with all-in-one-files and gccdepends
hausmann@webkit.org [Wed, 19 Sep 2012 15:05:15 +0000 (15:05 +0000)]
[Qt] Fix incremental builds with all-in-one-files and gccdepends

Reviewed by Tor Arne Vestbø.

Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
are not only created for header files but also for .cpp files. AllInOne.cpp files
include other .cpp files, and when those are removed we need those dummy rules to
avoid a "No rule to make Foo.cpp required by AllInOne.o" error.

* qmake/config.tests/gccdepends/empty.cpp:
(main):
* qmake/config.tests/gccdepends/gccdepends.pro:
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
commit-queue@webkit.org [Wed, 19 Sep 2012 14:52:08 +0000 (14:52 +0000)]
[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Added a missing 'if' statement.
https://bugs.webkit.org/show_bug.cgi?id=96925

PR #180866

Internally Reviewed by Antonio Gomes.

Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)

Patch by Abbas Sherawala <asherawala@rim.com> on 2012-09-19
Reviewed by Antonio Gomes.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove all usages of M_PI from WebCore
paroga@webkit.org [Wed, 19 Sep 2012 14:42:52 +0000 (14:42 +0000)]
Remove all usages of M_PI from WebCore
https://bugs.webkit.org/show_bug.cgi?id=93109

Reviewed by Dirk Schulze.

<wtf/MathExtras.h> implements many functions dealing with M_PI.
Use them in WebCore instead of duplicating the functionality.

* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
* platform/graphics/wx/FontPlatformDataWxMac.mm:
* platform/mac/WebWindowAnimation.mm:
(-[WebWindowScaleAnimation currentValue]):
* platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp:
(DegToRad):
(RadToDeg):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
commit-queue@webkit.org [Wed, 19 Sep 2012 14:37:11 +0000 (14:37 +0000)]
[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
https://bugs.webkit.org/show_bug.cgi?id=97107

Unreviewed EFL rebaseline.

Rebaseline a few tables/mozilla/bugs tests that
were forgotten during my massive tables/mozilla
rebaseline.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19

* platform/efl/TestExpectations:
* platform/efl/tables/mozilla/bugs/45621-expected.png:
* platform/efl/tables/mozilla/bugs/bug9072-expected.png:
* platform/efl/tables/mozilla/bugs/bug9123-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug9123-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug92143-expected.png:
* platform/efl/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug9271-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug9271-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug92868-expected.png:
* platform/efl/tables/mozilla/bugs/bug93363-expected.png:
* platform/efl/tables/mozilla/bugs/bug963-expected.png:
* platform/efl/tables/mozilla/bugs/bug96334-expected.png:
* platform/efl/tables/mozilla/bugs/bug96343-expected.png:
* platform/efl/tables/mozilla/bugs/bug965-expected.png:
* platform/efl/tables/mozilla/bugs/bug97138-expected.png:
* platform/efl/tables/mozilla/bugs/bug98196-expected.png:
* platform/efl/tables/mozilla/bugs/bug9879-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug99923-expected.png:
* platform/efl/tables/mozilla/bugs/bug99948-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Network request headers text fallback has typo.
vsevik@chromium.org [Wed, 19 Sep 2012 14:26:34 +0000 (14:26 +0000)]
Web Inspector: Network request headers text fallback has typo.
https://bugs.webkit.org/show_bug.cgi?id=96280

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update test expectation for indexeddb test that is currently only run...
jochen@chromium.org [Wed, 19 Sep 2012 14:12:37 +0000 (14:12 +0000)]
[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests

Unreviewed gardening.

* storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] remove static_cast which will cause video crash
commit-queue@webkit.org [Wed, 19 Sep 2012 14:11:48 +0000 (14:11 +0000)]
[BlackBerry] remove static_cast which will cause video crash
https://bugs.webkit.org/show_bug.cgi?id=97070

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-09-19
Reviewed by Antonio Gomes.

Removed the static_cast to avoid layering violation which
will cause a runtime crash.
We won't create a real MediaPlayerPrivate object before we call
MediaPlayer::load(), so if we use player()->implementation()
before calling load() in some cases, it points to a
NullMediaPlayerPrivate object. Here we should not use static_cast,
instead we should use HTMLMediaElement::percentLoaded() to
avoid layering violation as we don't have the buffering bug which
the deleted comment refers to.

Internally reviewed by Max Feil.

Test case: media/video-size.html

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[gtk] add enable-media-stream to websettings
commit-queue@webkit.org [Wed, 19 Sep 2012 14:09:03 +0000 (14:09 +0000)]
[gtk] add enable-media-stream to websettings
https://bugs.webkit.org/show_bug.cgi?id=94361

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-09-19
Reviewed by Martin Robinson.

Applications should be allowed to enable/disable MediaStream on webkitwebsettings.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo touch adjustment on GestureTapDown
commit-queue@webkit.org [Wed, 19 Sep 2012 14:08:21 +0000 (14:08 +0000)]
Do touch adjustment on GestureTapDown
https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.
* DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use.  Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

* touchadjustment/resources/touchadjustment.js:
(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):
* touchadjustment/touch-links-active-expected.txt: Added.
* touchadjustment/touch-links-active.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
commit-queue@webkit.org [Wed, 19 Sep 2012 14:04:58 +0000 (14:04 +0000)]
[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
https://bugs.webkit.org/show_bug.cgi?id=97105

Unreviewed EFL gardening.

Add fast/dom/message-port-deleted-by-accessor.html to
TestExpectations because it sometimes crashes on debug
build bots after r128802.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed another follow up Apple Win build fix for r128992.
vsevik@chromium.org [Wed, 19 Sep 2012 14:03:52 +0000 (14:03 +0000)]
Unreviewed another follow up Apple Win build fix for r128992.

* inspector/InspectorAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
carlosgc@webkit.org [Wed, 19 Sep 2012 14:00:50 +0000 (14:00 +0000)]
[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092

Reviewed by Martin Robinson.

Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.

* platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][UT] Refactoring an implementation of testing framework for wk1.
commit-queue@webkit.org [Wed, 19 Sep 2012 13:53:47 +0000 (13:53 +0000)]
[EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.

The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize efl and test view.
(EWKUnitTests::EWKTestBase::TearDown):
TearDown is called as soon as test is completed.
Used this to properly shutdown efl and clean test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
* tests/UnitTestUtils/EWKTestBase.h:
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Initialize test view.
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
* tests/test_ewk_view.cpp:
(TEST_F):
* tests/test_runner.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed follow up Apple Win build fix for r128992.
vsevik@chromium.org [Wed, 19 Sep 2012 13:50:11 +0000 (13:50 +0000)]
Unreviewed follow up Apple Win build fix for r128992.

* inspector/InspectorAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
commit-queue@webkit.org [Wed, 19 Sep 2012 13:32:12 +0000 (13:32 +0000)]
[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
https://bugs.webkit.org/show_bug.cgi?id=97100

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add DumpRenderTree support method to set the
'WebKitCSSRegionsEnabled' preference.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
preference, in order to match WebKitTestRunner functionality.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):

LayoutTests:

Rebaseline and unskip several test cases now that EFL's DRT
supports overriding 'WebKitCSSRegionsEnabled' preference.

* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/efl/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
* platform/efl/fast/repaint/region-painting-via-layout-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
commit-queue@webkit.org [Wed, 19 Sep 2012 13:07:15 +0000 (13:07 +0000)]
Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
https://bugs.webkit.org/show_bug.cgi?id=96917

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScriptCanvasModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.cpp.
(WebCore):
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
(WebCore::InjectedScriptCanvasModule::moduleForState):
(WebCore::InjectedScriptCanvasModule::source):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
* inspector/InjectedScriptCanvasModule.h: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.h.
(WebCore):
(InjectedScriptCanvasModule):
* inspector/InjectedScriptCanvasModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js.
(.):
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCanvasAgent.cpp: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.cpp.
(WebCore):
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::setFrontend):
(WebCore::InspectorCanvasAgent::clearFrontend):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModuleForTraceLogId):
* inspector/InspectorCanvasAgent.h: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.h.
(WebCore):
(InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::create):
(WebCore::InspectorCanvasAgent::enabled):
* inspector/InspectorCanvasInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorWebGLInstrumentation.h.
(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
(InstrumentingAgents):
* inspector/compile-front-end.py:
* inspector/front-end/CanvasProfileView.js: Renamed from Source/WebCore/inspector/front-end/WebGLProfileView.js.
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.get statusBarItems):
(WebInspector.CanvasProfileView.prototype.get profile):
(WebInspector.CanvasProfileView.prototype.wasShown):
(WebInspector.CanvasProfileView.prototype.willHide):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get buttonTooltip):
(WebInspector.CanvasProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype.get treeItemTitle):
(WebInspector.CanvasProfileType.prototype.get description):
(WebInspector.CanvasProfileType.prototype.reset):
(WebInspector.CanvasProfileType.prototype.createTemporaryProfile):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CanvasProfileHeader.prototype.createView):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/canvasProfiler.css: Renamed from Source/WebCore/inspector/front-end/webGLProfiler.css.
(.canvas-profile-view):
(.canvas-trace-log):
(.canvas-trace-log div):
(#canvas-replay-image-container):
(#canvas-replay-image):

LayoutTests:

* inspector/profiler/webgl/webgl-profiler-get-error.html:
* inspector/profiler/webgl/webgl-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] tables/mozilla tests need rebaseline (Part 6)
commit-queue@webkit.org [Wed, 19 Sep 2012 12:56:40 +0000 (12:56 +0000)]
[EFL] tables/mozilla tests need rebaseline (Part 6)
https://bugs.webkit.org/show_bug.cgi?id=97098

Unreviewed EFL rebaseline.

Rebaseline remaining tables/mozilla tests.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19

* platform/efl/tables/mozilla/bugs/bug40828-expected.png:
* platform/efl/tables/mozilla/bugs/bug4093-expected.png:
* platform/efl/tables/mozilla/bugs/bug41890-expected.png:
* platform/efl/tables/mozilla/bugs/bug42187-expected.png:
* platform/efl/tables/mozilla/bugs/bug42443-expected.png:
* platform/efl/tables/mozilla/bugs/bug4284-expected.png:
* platform/efl/tables/mozilla/bugs/bug43039-expected.png:
* platform/efl/tables/mozilla/bugs/bug43204-expected.png:
* platform/efl/tables/mozilla/bugs/bug4382-expected.png:
* platform/efl/tables/mozilla/bugs/bug4385-expected.png:
* platform/efl/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug43854-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug4427-expected.png:
* platform/efl/tables/mozilla/bugs/bug4429-expected.png:
* platform/efl/tables/mozilla/bugs/bug44505-expected.png:
* platform/efl/tables/mozilla/bugs/bug44523-expected.png:
* platform/efl/tables/mozilla/bugs/bug4501-expected.png:
* platform/efl/tables/mozilla/bugs/bug45055-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug45055-expected.png:
* platform/efl/tables/mozilla/bugs/bug4520-expected.png:
* platform/efl/tables/mozilla/bugs/bug4523-expected.png:
* platform/efl/tables/mozilla/bugs/bug4527-expected.png:
* platform/efl/tables/mozilla/bugs/bug45350-expected.png:
* platform/efl/tables/mozilla/bugs/bug45486-expected.png:
* platform/efl/tables/mozilla/bugs/bug4576-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-expected.png:
* platform/efl/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug46623-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug46623-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug46924-expected.png:
* platform/efl/tables/mozilla/bugs/bug46944-expected.png:
* platform/efl/tables/mozilla/bugs/bug4739-expected.png:
* platform/efl/tables/mozilla/bugs/bug47432-expected.png:
* platform/efl/tables/mozilla/bugs/bug48028-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug48028-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug4803-expected.png:
* platform/efl/tables/mozilla/bugs/bug4849-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug4849-expected.png:
* platform/efl/tables/mozilla/bugs/bug48827-expected.png:
* platform/efl/tables/mozilla/bugs/bug50695-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug51037-expected.png:
* platform/efl/tables/mozilla/bugs/bug51140-expected.png:
* platform/efl/tables/mozilla/bugs/bug51727-expected.png:
* platform/efl/tables/mozilla/bugs/bug5188-expected.png:
* platform/efl/tables/mozilla/bugs/bug52505-expected.png:
* platform/efl/tables/mozilla/bugs/bug52506-expected.png:
* platform/efl/tables/mozilla/bugs/bug53690-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug53891-expected.png:
* platform/efl/tables/mozilla/bugs/bug54450-expected.png:
* platform/efl/tables/mozilla/bugs/bug5538-expected.png:
* platform/efl/tables/mozilla/bugs/bug55527-expected.png:
* platform/efl/tables/mozilla/bugs/bug55545-expected.png:
* platform/efl/tables/mozilla/bugs/bug55694-expected.png:
* platform/efl/tables/mozilla/bugs/bug55789-expected.png:
* platform/efl/tables/mozilla/bugs/bug56201-expected.png:
* platform/efl/tables/mozilla/bugs/bug56405-expected.png:
* platform/efl/tables/mozilla/bugs/bug56563-expected.png:
* platform/efl/tables/mozilla/bugs/bug57300-expected.png:
* platform/efl/tables/mozilla/bugs/bug57378-expected.png:
* platform/efl/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug57828-expected.png:
* platform/efl/tables/mozilla/bugs/bug5797-expected.png:
* platform/efl/tables/mozilla/bugs/bug5798-expected.png:
* platform/efl/tables/mozilla/bugs/bug5799-expected.png:
* platform/efl/tables/mozilla/bugs/bug5835-expected.png:
* platform/efl/tables/mozilla/bugs/bug5838-expected.png:
* platform/efl/tables/mozilla/bugs/bug58402-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug59354-expected.png:
* platform/efl/tables/mozilla/bugs/bug60013-expected.png:
* platform/efl/tables/mozilla/bugs/bug60749-expected.png:
* platform/efl/tables/mozilla/bugs/bug60804-expected.png:
* platform/efl/tables/mozilla/bugs/bug60807-expected.png:
* platform/efl/tables/mozilla/bugs/bug60992-expected.png:
* platform/efl/tables/mozilla/bugs/bug6184-expected.png:
* platform/efl/tables/mozilla/bugs/bug625-expected.png:
* platform/efl/tables/mozilla/bugs/bug6304-expected.png:
* platform/efl/tables/mozilla/bugs/bug63785-expected.png:
* platform/efl/tables/mozilla/bugs/bug6404-expected.png:
* platform/efl/tables/mozilla/bugs/bug641-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug641-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug650-expected.png:
* platform/efl/tables/mozilla/bugs/bug6674-expected.png:
* platform/efl/tables/mozilla/bugs/bug67864-expected.png:
* platform/efl/tables/mozilla/bugs/bug67915-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug68912-expected.png:
* platform/efl/tables/mozilla/bugs/bug68998-expected.png:
* platform/efl/tables/mozilla/bugs/bug69187-expected.png:
* platform/efl/tables/mozilla/bugs/bug69382-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug69382-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug709-expected.png:
* platform/efl/tables/mozilla/bugs/bug7112-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug7112-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug7121-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug72359-expected.png:
* platform/efl/tables/mozilla/bugs/bug727-expected.png:
* platform/efl/tables/mozilla/bugs/bug73321-expected.png:
* platform/efl/tables/mozilla/bugs/bug7342-expected.png:
* platform/efl/tables/mozilla/bugs/bug7471-expected.png:
* platform/efl/tables/mozilla/bugs/bug75250-expected.png:
* platform/efl/tables/mozilla/bugs/bug7714-expected.png:
* platform/efl/tables/mozilla/bugs/bug78162-expected.png:
* platform/efl/tables/mozilla/bugs/bug8032-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug80762-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug81934-expected.png:
* platform/efl/tables/mozilla/bugs/bug82946-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug8361-expected.png:
* platform/efl/tables/mozilla/bugs/bug83786-expected.png:
* platform/efl/tables/mozilla/bugs/bug8381-expected.png:
* platform/efl/tables/mozilla/bugs/bug8411-expected.png:
* platform/efl/tables/mozilla/bugs/bug86220-expected.png:
* platform/efl/tables/mozilla/bugs/bug86708-expected.png:
* platform/efl/tables/mozilla/bugs/bug88035-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug88035-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug88524-expected.png:
* platform/efl/tables/mozilla/bugs/bug8858-expected.png:
* platform/efl/tables/mozilla/bugs/bug8950-expected.png:
* platform/efl/tables/mozilla/other/body_col-expected.png:
* platform/efl/tables/mozilla/other/cell_widths-expected.png:
* platform/efl/tables/mozilla/other/cellspacing-expected.png:
* platform/efl/tables/mozilla/other/move_row-expected.png:
* platform/efl/tables/mozilla/other/ms-expected.png:
* platform/efl/tables/mozilla/other/nested2-expected.png:
* platform/efl/tables/mozilla/other/nestedTables-expected.png:
* platform/efl/tables/mozilla/other/padding-expected.png:
* platform/efl/tables/mozilla/other/test3-expected.png:
* platform/efl/tables/mozilla/other/test6-expected.png:
* platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] tables/mozilla tests need rebaseline (Part 5)
commit-queue@webkit.org [Wed, 19 Sep 2012 12:46:27 +0000 (12:46 +0000)]
[EFL] tables/mozilla tests need rebaseline (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=97096

Unreviewed EFL rebaseline.

Rebaseline part of tables/mozilla/bugs/ test cases
for EFL port.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-19

* platform/efl/tables/mozilla/bugs/bug10009-expected.png:
* platform/efl/tables/mozilla/bugs/bug100334-expected.png:
* platform/efl/tables/mozilla/bugs/bug10036-expected.png:
* platform/efl/tables/mozilla/bugs/bug10039-expected.png:
* platform/efl/tables/mozilla/bugs/bug101201-expected.png:
* platform/efl/tables/mozilla/bugs/bug101674-expected.png:
* platform/efl/tables/mozilla/bugs/bug102145-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug102145-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug102145-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug102145-4-expected.png:
* platform/efl/tables/mozilla/bugs/bug10269-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug10269-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug10296-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug1055-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug10565-expected.png:
* platform/efl/tables/mozilla/bugs/bug106158-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug106158-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug10633-expected.png:
* platform/efl/tables/mozilla/bugs/bug1067-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug1067-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug106816-expected.png:
* platform/efl/tables/mozilla/bugs/bug108340-expected.png:
* platform/efl/tables/mozilla/bugs/bug109043-expected.png:
* platform/efl/tables/mozilla/bugs/bug11026-expected.png:
* platform/efl/tables/mozilla/bugs/bug110566-expected.png:
* platform/efl/tables/mozilla/bugs/bug11321-expected.png:
* platform/efl/tables/mozilla/bugs/bug113235-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug113235-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug113424-expected.png:
* platform/efl/tables/mozilla/bugs/bug11384q-expected.png:
* platform/efl/tables/mozilla/bugs/bug11384s-expected.png:
* platform/efl/tables/mozilla/bugs/bug1163-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug1188-expected.png:
* platform/efl/tables/mozilla/bugs/bug11944-expected.png:
* platform/efl/tables/mozilla/bugs/bug119786-expected.png:
* platform/efl/tables/mozilla/bugs/bug12008-expected.png:
* platform/efl/tables/mozilla/bugs/bug120364-expected.png:
* platform/efl/tables/mozilla/bugs/bug1220-expected.png:
* platform/efl/tables/mozilla/bugs/bug1224-expected.png:
* platform/efl/tables/mozilla/bugs/bug12268-expected.png:
* platform/efl/tables/mozilla/bugs/bug12384-expected.png:
* platform/efl/tables/mozilla/bugs/bug123862-expected.png:
* platform/efl/tables/mozilla/bugs/bug1261-expected.png:
* platform/efl/tables/mozilla/bugs/bug126742-expected.png:
* platform/efl/tables/mozilla/bugs/bug12709-expected.png:
* platform/efl/tables/mozilla/bugs/bug127267-expected.png:
* platform/efl/tables/mozilla/bugs/bug128229-expected.png:
* platform/efl/tables/mozilla/bugs/bug12908-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug12910-expected.png:
* platform/efl/tables/mozilla/bugs/bug1296-expected.png:
* platform/efl/tables/mozilla/bugs/bug1302-expected.png:
* platform/efl/tables/mozilla/bugs/bug131020-expected.png:
* platform/efl/tables/mozilla/bugs/bug131020_iframe-expected.png:
* platform/efl/tables/mozilla/bugs/bug13105-expected.png:
* platform/efl/tables/mozilla/bugs/bug13118-expected.png:
* platform/efl/tables/mozilla/bugs/bug1318-expected.png:
* platform/efl/tables/mozilla/bugs/bug13196-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug13484-expected.png:
* platform/efl/tables/mozilla/bugs/bug13526-expected.png:
* platform/efl/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug138725-expected.png:
* platform/efl/tables/mozilla/bugs/bug139524-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug139524-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug139524-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug139524-4-expected.png:
* platform/efl/tables/mozilla/bugs/bug14159-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug14159-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug1430-expected.png:
* platform/efl/tables/mozilla/bugs/bug14323-expected.png:
* platform/efl/tables/mozilla/bugs/bug145572-expected.png:
* platform/efl/tables/mozilla/bugs/bug1474-expected.png:
* platform/efl/tables/mozilla/bugs/bug149275-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug149275-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug14929-expected.png:
* platform/efl/tables/mozilla/bugs/bug15247-expected.png:
* platform/efl/tables/mozilla/bugs/bug154780-expected.png:
* platform/efl/tables/mozilla/bugs/bug15544-expected.png:
* platform/efl/tables/mozilla/bugs/bug157890-expected.png:
* platform/efl/tables/mozilla/bugs/bug159108-expected.png:
* platform/efl/tables/mozilla/bugs/bug15933-expected.png:
* platform/efl/tables/mozilla/bugs/bug16012-expected.png:
* platform/efl/tables/mozilla/bugs/bug16252-expected.png:
* platform/efl/tables/mozilla/bugs/bug17130-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug17130-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug17138-expected.png:
* platform/efl/tables/mozilla/bugs/bug17168-expected.png:
* platform/efl/tables/mozilla/bugs/bug175455-4-expected.png:
* platform/efl/tables/mozilla/bugs/bug17548-expected.png:
* platform/efl/tables/mozilla/bugs/bug17587-expected.png:
* platform/efl/tables/mozilla/bugs/bug1800-expected.png:
* platform/efl/tables/mozilla/bugs/bug1802-expected.png:
* platform/efl/tables/mozilla/bugs/bug1802s-expected.png:
* platform/efl/tables/mozilla/bugs/bug1809-expected.png:
* platform/efl/tables/mozilla/bugs/bug1818-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug1828-expected.png:
* platform/efl/tables/mozilla/bugs/bug18359-expected.png:
* platform/efl/tables/mozilla/bugs/bug18558-expected.png:
* platform/efl/tables/mozilla/bugs/bug18664-expected.png:
* platform/efl/tables/mozilla/bugs/bug18955-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug19356-expected.png:
* platform/efl/tables/mozilla/bugs/bug194024-expected.png:
* platform/efl/tables/mozilla/bugs/bug19599-expected.png:
* platform/efl/tables/mozilla/bugs/bug2050-expected.png:
* platform/efl/tables/mozilla/bugs/bug20579-expected.png:
* platform/efl/tables/mozilla/bugs/bug2065-expected.png:
* platform/efl/tables/mozilla/bugs/bug20804-expected.png:
* platform/efl/tables/mozilla/bugs/bug2123-expected.png:
* platform/efl/tables/mozilla/bugs/bug21299-expected.png:
* platform/efl/tables/mozilla/bugs/bug215629-expected.png:
* platform/efl/tables/mozilla/bugs/bug21918-expected.png:
* platform/efl/tables/mozilla/bugs/bug22019-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug221784-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug221784-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug22246-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug22246-2a-expected.png:
* platform/efl/tables/mozilla/bugs/bug22246-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug22246-3a-expected.png:
* platform/efl/tables/mozilla/bugs/bug222846-expected.png:
* platform/efl/tables/mozilla/bugs/bug22513-expected.png:
* platform/efl/tables/mozilla/bugs/bug2267-expected.png:
* platform/efl/tables/mozilla/bugs/bug227123-expected.png:
* platform/efl/tables/mozilla/bugs/bug2296-expected.png:
* platform/efl/tables/mozilla/bugs/bug23072-expected.png:
* platform/efl/tables/mozilla/bugs/bug23151-expected.png:
* platform/efl/tables/mozilla/bugs/bug23235-expected.png:
* platform/efl/tables/mozilla/bugs/bug23299-expected.png:
* platform/efl/tables/mozilla/bugs/bug24200-expected.png:
* platform/efl/tables/mozilla/bugs/bug24503-expected.png:
* platform/efl/tables/mozilla/bugs/bug24627-expected.png:
* platform/efl/tables/mozilla/bugs/bug24661-expected.png:
* platform/efl/tables/mozilla/bugs/bug2469-expected.png:
* platform/efl/tables/mozilla/bugs/bug2479-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug2479-4-expected.png:
* platform/efl/tables/mozilla/bugs/bug24880-expected.png:
* platform/efl/tables/mozilla/bugs/bug25004-expected.png:
* platform/efl/tables/mozilla/bugs/bug25074-expected.png:
* platform/efl/tables/mozilla/bugs/bug25086-expected.png:
* platform/efl/tables/mozilla/bugs/bug2509-expected.png:
* platform/efl/tables/mozilla/bugs/bug2516-expected.png:
* platform/efl/tables/mozilla/bugs/bug25367-expected.png:
* platform/efl/tables/mozilla/bugs/bug25663-expected.png:
* platform/efl/tables/mozilla/bugs/bug2585-expected.png:
* platform/efl/tables/mozilla/bugs/bug26178-expected.png:
* platform/efl/tables/mozilla/bugs/bug26553-expected.png: Added.
* platform/efl/tables/mozilla/bugs/bug2684-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug275625-expected.png:
* platform/efl/tables/mozilla/bugs/bug2757-expected.png:
* platform/efl/tables/mozilla/bugs/bug2763-expected.png:
* platform/efl/tables/mozilla/bugs/bug2773-expected.png:
* platform/efl/tables/mozilla/bugs/bug278266-expected.png:
* platform/efl/tables/mozilla/bugs/bug278385-expected.png:
* platform/efl/tables/mozilla/bugs/bug27993-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug28341-expected.png:
* platform/efl/tables/mozilla/bugs/bug2886-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug2886-expected.png:
* platform/efl/tables/mozilla/bugs/bug28928-expected.png:
* platform/efl/tables/mozilla/bugs/bug29058-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug29058-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug29157-expected.png:
* platform/efl/tables/mozilla/bugs/bug29314-expected.png:
* platform/efl/tables/mozilla/bugs/bug29326-expected.png:
* platform/efl/tables/mozilla/bugs/bug29429-expected.png:
* platform/efl/tables/mozilla/bugs/bug2947-expected.png:
* platform/efl/tables/mozilla/bugs/bug2962-expected.png:
* platform/efl/tables/mozilla/bugs/bug2973-expected.png:
* platform/efl/tables/mozilla/bugs/bug2981-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug2997-expected.png:
* platform/efl/tables/mozilla/bugs/bug30273-expected.png:
* platform/efl/tables/mozilla/bugs/bug30332-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug30332-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug3037-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug3037-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug30418-expected.png:
* platform/efl/tables/mozilla/bugs/bug30559-expected.png:
* platform/efl/tables/mozilla/bugs/bug30692-expected.png:
* platform/efl/tables/mozilla/bugs/bug30985-expected.png:
* platform/efl/tables/mozilla/bugs/bug3103-expected.png:
* platform/efl/tables/mozilla/bugs/bug3191-expected.png:
* platform/efl/tables/mozilla/bugs/bug32205-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug32205-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug32205-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug32447-expected.png:
* platform/efl/tables/mozilla/bugs/bug3260-expected.png:
* platform/efl/tables/mozilla/bugs/bug3263-expected.png:
* platform/efl/tables/mozilla/bugs/bug32841-expected.png:
* platform/efl/tables/mozilla/bugs/bug3309-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug3309-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug33137-expected.png:
* platform/efl/tables/mozilla/bugs/bug33855-expected.png:
* platform/efl/tables/mozilla/bugs/bug34176-expected.png:
* platform/efl/tables/mozilla/bugs/bug34538-expected.png:
* platform/efl/tables/mozilla/bugs/bug3454-expected.png:
* platform/efl/tables/mozilla/bugs/bug35662-expected.png:
* platform/efl/tables/mozilla/bugs/bug3681-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug3681-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug3718-expected.png:
* platform/efl/tables/mozilla/bugs/bug38916-expected.png:
* platform/efl/tables/mozilla/bugs/bug39209-expected.png:
* platform/efl/tables/mozilla/bugs/bug3977-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+
carlosgc@webkit.org [Wed, 19 Sep 2012 11:32:29 +0000 (11:32 +0000)]
[GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=96497

Reviewed by Martin Robinson.

Source/WebCore:

* WebCore.exp.in: Add new exported symbols.

Source/WebKit2:

Add WebKitSecurityManager object associated to a WebKitWebContext
to get/set the security policy of a URI scheme.

* GNUmakefile.list.am: Add new files to compilation.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.
(WebKit::WebProcessCreationParameters::decode): Decode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters): Add new parameters to be able to
register schemes as Local, NoAccess, DisplayIsolated and
CORSEnabled.
* UIProcess/API/gtk/WebKitSecurityManager.cpp: Added.
(webkit_security_manager_init):
(webkitSecurityManagerFinalize):
(webkit_security_manager_class_init):
(webkitSecurityManagerCreate): Private function to create the
WebKitSecurityManager object associated to the given
WebKitWebContext.
(registerSecurityPolicyForURIScheme):
(checkSecurityPolicyForURIScheme):
(webkit_security_manager_register_uri_scheme_as_local):
(webkit_security_manager_uri_scheme_is_local):
(webkit_security_manager_register_uri_scheme_as_no_access):
(webkit_security_manager_uri_scheme_is_no_access):
(webkit_security_manager_register_uri_scheme_as_display_isolated):
(webkit_security_manager_uri_scheme_is_display_isolated):
(webkit_security_manager_register_uri_scheme_as_secure):
(webkit_security_manager_uri_scheme_is_secure):
(webkit_security_manager_register_uri_scheme_as_cors_enabled):
(webkit_security_manager_uri_scheme_is_cors_enabled):
(webkit_security_manager_register_uri_scheme_as_empty_document):
(webkit_security_manager_uri_scheme_is_empty_document):
* UIProcess/API/gtk/WebKitSecurityManager.h: Added.
* UIProcess/API/gtk/WebKitSecurityManagerPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_security_manager): Return the
WebKitSecurityManager object, creating it before if it doesn't exist.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitSecurityManager.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSecurityPolicy):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Add WebKitSecurityManager.h.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Copy new vector
schemes.
(WebKit::WebContext::registerURLSchemeAsLocal): Send a message to
WebProcess to register the given URL scheme as Local.
(WebKit::WebContext::registerURLSchemeAsNoAccess): Send a message
to WebProcess to register the given URL scheme as NoAccess.
(WebKit::WebContext::registerURLSchemeAsDisplayIsolated): Send a
message to WebProcess to register the given URL scheme as
DisplayIsolated.
(WebKit::WebContext::registerURLSchemeAsCORSEnabled): Send a
message to WebProcess to register the given URL scheme as
CORSEnabled.
* UIProcess/WebContext.h:
(WebContext):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::registerURLSchemeAsLocal): Register the
given URL scheme as Local in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsNoAccess): Register the
given URL scheme as NoAccess in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsDisplayIsolated): Register
the given URL scheme as DisplayIsolated in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsCORSEnabled): Register the
given URL scheme as CORSEnabled in the SchemeRegistry.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Add new messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WIN] Use BString in favour of BSTR to improve memory management
paroga@webkit.org [Wed, 19 Sep 2012 11:15:33 +0000 (11:15 +0000)]
[WIN] Use BString in favour of BSTR to improve memory management
https://bugs.webkit.org/show_bug.cgi?id=93128

Reviewed by Anders Carlsson.

BString automatically calls SysFreeString() in its destructor which helps
avoiding memory leaks. So it should be used instead of BSTR directly.
Add operator& to BString to allow its usage for out parameters too (like COMPtr).
This fixes already a few memory leaks in the existing code.

Source/WebCore:

* platform/win/BString.cpp:
(WebCore::BString::~BString):
(WebCore::BString::adoptBSTR):
(WebCore::BString::clear):
(WebCore):
* platform/win/BString.h:
(BString):
(WebCore::BString::operator&):

Source/WebKit/win:

* DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::decidePolicyForNavigationAction):
(DefaultPolicyDelegate::decidePolicyForMIMEType):
(DefaultPolicyDelegate::unableToImplementPolicyWithError):
* MarshallingHelpers.cpp:
(MarshallingHelpers::KURLToBSTR):
(MarshallingHelpers::CFStringRefToBSTR):
(MarshallingHelpers::stringArrayToSafeArray):
(MarshallingHelpers::safeArrayToStringArray):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runJavaScriptPrompt):
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::getGuessesForWord):
* WebFrame.cpp:
(WebFrame::canProvideDocumentSource):
* WebHistory.cpp:
(WebHistory::removeItem):
(WebHistory::addItem):
* WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotification):
* WebPreferences.cpp:
(WebPreferences::setStringValue):
* WebView.cpp:
(toAtomicString):
(toString):
(toKURL):
(PreferencesChangedOrRemovedObserver::onNotify):
(WebView::close):
(WebView::canShowMIMEType):
(WebView::initWithFrame):
(WebView::setApplicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::userAgentForURL):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setPreferences):
(WebView::searchFor):
(WebView::executeCoreCommandByName):
(WebView::markAllMatchesForText):
(WebView::setGroupName):
(WebView::registerURLSchemeAsLocal):
(WebView::replaceSelectionWithText):
(WebView::onNotify):
(WebView::notifyPreferencesChanged):
(WebView::MIMETypeForExtension):
(WebView::standardUserAgentWithApplicationName):
(WebView::addAdditionalPluginDirectory):
(WebView::registerEmbeddedViewMIMEType):
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::geolocationDidFailWithError):
(WebView::setDomainRelaxationForbiddenForURLScheme):
(WebView::setCompositionForTesting):
(WebView::confirmCompositionForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@128988 268f45cc-cd09-0410-ab3c-d52691b4dbfc