WebKit-https.git
6 years agoAdd the default video poster if it doesn't exist in video tag
commit-queue@webkit.org [Wed, 13 Mar 2013 21:16:50 +0000 (21:16 +0000)]
Add the default video poster if it doesn't exist in video tag
https://bugs.webkit.org/show_bug.cgi?id=110263

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-13
Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/video-default-poster.html
       media/video-no-default-poster.html

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an
   Element::imageSourceURL function that returns the imageSourceURL as a
   const AtomicString&. The body will be the same as before, it will just also
   include a call to getAttribute. Also will need to revise the four classes
   that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the
   default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster
   loading and display to call posterImageURL.

   1) HTMLVideoElement::imageSourceURL.
   2) HTMLVideoElement::setDisplayMode.
   3) HTMLVideoElement::updateDisplayState.
   4) HTMLMediaElement::getPluginProxyParams. Will need to cast to
      HTMLVideoElement after checking isVideo.

* dom/Element.cpp:
(WebCore::Element::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* dom/Element.h: Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLEmbedElement.h: Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getPluginProxyParams): Change to use posterImageURL
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLObjectElement.h: Replace imageSourceAttributeName with imageSourceURL
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::HTMLVideoElement): set m_defaultPosterURL if there is such settings
(WebCore::HTMLVideoElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
(WebCore::HTMLVideoElement::setDisplayMode): Use imageSourceURL()
(WebCore::HTMLVideoElement::updateDisplayState): Use imageSourceURL()
(WebCore::HTMLVideoElement::posterImageURL): Return image source's KURL
* html/HTMLVideoElement.h: Replace imageSourceAttributeName() with imageSourceURL() and add m_defaultPosterURL
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Use imageSourceURL()
* page/Settings.in: Add defaultVideoPosterURL setting.
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): use imageSourceURL()
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode): use imageSourceURL()
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL): use imageSourceURL()
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* svg/SVGImageElement.h: Replace imageSourceAttributeName() with imageSourceURL()
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): support backup defaultVideoPosterURL.
(WebCore::InternalSettings::Backup::restoreTo): support restore defaultVideoPosterURL.
(WebCore::InternalSettings::setDefaultVideoPosterURL): set defaultVideoPosterURL.
* testing/InternalSettings.h:
(Backup): support backup defaultVideoPosterURL.
(InternalSettings): Add setDefaultVidoePosterURL method.
* testing/InternalSettings.idl: Add setDefaultVideoPosterURL for test purpose.
* testing/Internals.cpp:
(WebCore::Internals::getImageSourceURL): Add getImageSourceURL method.
* testing/Internals.h: Add getImageSourceURL method.
* testing/Internals.idl: Add getImageSourceURL method.

LayoutTests:

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an
   Element::imageSourceURL function that returns the imageSourceURL as a
   const AtomicString&. The body will be the same as before, it will just also
   include a call to getAttribute. Also will need to revise the four classes
   that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the
   default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster
   loading and display to call posterImageURL.

   1) HTMLVideoElement::imageSourceURL.
   2) HTMLVideoElement::setDisplayMode.
   3) HTMLVideoElement::updateDisplayState.
   4) HTMLMediaElement::getPluginProxyParams. Will need to cast to
      HTMLVideoElement after checking isVideo.

* media/video-default-poster-expected.txt: Added.
* media/video-default-poster.html: Added.
* media/video-no-default-poster-expected.txt: Added.
* media/video-no-default-poster.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoForce clip in fast/regions/autoheight-break-after-expected.html to match test
jamesr@google.com [Wed, 13 Mar 2013 20:55:22 +0000 (20:55 +0000)]
Force clip in fast/regions/autoheight-break-after-expected.html to match test
https://bugs.webkit.org/show_bug.cgi?id=112283

Reviewed by David Hyatt.

Regions always set a clip rect when rendering their contents. On Mountain Lion, the Ahem glyphs very slightly
visually overflow their bounds if there's no clip set. This sets a clip in the reference file so we get the same
rendering.

* fast/regions/autoheight-break-after-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Add optimized version of StringImpl's equal(LChar*,LChar*) for Apple CPUs
benjamin@webkit.org [Wed, 13 Mar 2013 20:44:08 +0000 (20:44 +0000)]
[iOS] Add optimized version of StringImpl's equal(LChar*,LChar*) for Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112202

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-13
Reviewed by Gavin Barraclough.

* Source/WTF/wtf/Platform.h:
Make the macro WTF_ARM_ARCH_VERSION valid on any architecture.
* wtf/text/StringImpl.h:
(WTF::equal):
On ARMv7S, the new version is about 11% percent faster than the simple loop.
On ARMv7 classic, memcmp is a little faster than the simple loop on Apple A5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed prospective Windows build fix
hausmann@webkit.org [Wed, 13 Mar 2013 20:42:11 +0000 (20:42 +0000)]
[Qt] Unreviewed prospective Windows build fix

Do the usual thing, include the moc generated code in the .cpp file instead
of compiling it standalone, to ensure that config.h is included, too, and
NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.

* DumpRenderTree/qt/EventSenderQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake lint-test-expectations happy with the Apple-Windows TestExpectations files
timothy_horton@apple.com [Wed, 13 Mar 2013 20:38:51 +0000 (20:38 +0000)]
Make lint-test-expectations happy with the Apple-Windows TestExpectations files

Unreviewed.

accessibility/radio-button-checkbox-size.html was moved to platform/mac in http://trac.webkit.org/changeset/138124
fast/css/ignore-text-zoom.html was removed in http://trac.webkit.org/changeset/145168
inspector-protocol/layer-tree.html was removed in http://trac.webkit.org/changeset/144624
Remove a bunch of duplicate entries.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace static_casts with to* functions for document types.
inferno@chromium.org [Wed, 13 Mar 2013 20:29:08 +0000 (20:29 +0000)]
Replace static_casts with to* functions for document types.
https://bugs.webkit.org/show_bug.cgi?id=112225

Reviewed by Ryosuke Niwa.

Source/WebCore:

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::document):
....lot of files.

Source/WebKit2:

* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Remove the redundant helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Handle XHTML entities in XHTML Mobile Profile 1.1 and 1.2. We previou...
commit-queue@webkit.org [Wed, 13 Mar 2013 20:24:51 +0000 (20:24 +0000)]
Source/WebCore: Handle XHTML entities in XHTML Mobile Profile 1.1 and 1.2. We previously only handled them in XHTML Mobile Profile 1.0.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

Check for the 1.1 and 1.2 doctypes alongside the 1.0 doctype.

Tests: fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml
       fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::externalSubsetHandler):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseDtd):

LayoutTests: New tests to check that XHTML entities are supported in XHTML Mobile Profile 1.1 and 1.2.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

* fast/doctypes/xhtml-with-xhtmlmp11-doctype-expected.txt: Added.
* fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml: Added.
* fast/doctypes/xhtml-with-xhtmlmp12-doctype-expected.txt: Added.
* fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSchedulePair.cpp is CF-specific
commit-queue@webkit.org [Wed, 13 Mar 2013 20:23:27 +0000 (20:23 +0000)]
SchedulePair.cpp is CF-specific
https://bugs.webkit.org/show_bug.cgi?id=112204

Patch by James Robinson <jamesr@chromium.org> on 2013-03-13
Reviewed by Oliver Hunt.

This renames SchedulePair.cpp SchedulePairCF.cpp, since it depends on CF, and excludes it from chromium's gyp
files.

* WTF.gyp/WTF.gyp:
  Add CF to the exclusion filter for the Chromium port.
* WTF.gypi:
  Add SchedulePairCF.cpp
* WTF.xcodeproj/project.pbxproj:
  Update project file to point to new .cpp location
* wtf/SchedulePairCF.cpp: Renamed from Source/WTF/wtf/SchedulePair.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix a path in TestExpectations.
timothy_horton@apple.com [Wed, 13 Mar 2013 20:23:01 +0000 (20:23 +0000)]
Unreviewed, fix a path in TestExpectations.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Better error handling in NetworkStateNotifierEfl
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 20:10:05 +0000 (20:10 +0000)]
[EFL] Better error handling in NetworkStateNotifierEfl
https://bugs.webkit.org/show_bug.cgi?id=112184

Reviewed by Kenneth Rohde Christiansen.

Improve error handling in for system calls in NetworkStateNotifierEfl.
- EINTR errors are now properly handled for close() and recv() syscalls
- recv() errors are now correctly detected, for e.g. if the socket was
closed unexpectedly.
- Make sure m_fdHandler is reset when the callback returns
ECORE_CALLBACK_CANCEL to avoid double free in destructor. m_fdHandler
gets destroyed when the callback returns ECORE_CALLBACK_CANCEL.
- Keep netlink socket file descriptor as a class member so that we can
close() it in the class destructor, even if m_fdHandler has already
been destroyed.

No new tests, no behavior change for layout tests.

* platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
* platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::readSocketCallback):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] MediaStream API: Cleaning away deprecated and unused states
tommyw@google.com [Wed, 13 Mar 2013 19:58:06 +0000 (19:58 +0000)]
[chromium] MediaStream API: Cleaning away deprecated and unused states
https://bugs.webkit.org/show_bug.cgi?id=112258

Reviewed by Adam Barth.

* chromium/public/WebRTCPeerConnectionHandler.h:
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd new Skia code suppression flags
schenney@chromium.org [Wed, 13 Mar 2013 19:55:41 +0000 (19:55 +0000)]
Add new Skia code suppression flags

Unreviewed build update.

* skia_webkit.gyp: Add 'SK_DISABLE_BLUR_ROUNDING', 'SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX',
    'SK_IGNORE_PICTURE_RECORD_SAVE_LAYER_OPT', 'SK_IGNORE_FAST_RECT_BLUR', 'SK_IGNORE_CUBIC_STROKE_FIX'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build fixes after 145552
commit-queue@webkit.org [Wed, 13 Mar 2013 19:46:12 +0000 (19:46 +0000)]
[GTK] Build fixes after 145552
https://bugs.webkit.org/show_bug.cgi?id=112267

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-13
Reviewed by Gustavo Noronha Silva.

Source/Platform:

* GNUmakefile.am: Include the same-level GNUmakefile.list.am.
Fix a typo in the inline visibility compiler flag.

Source/WebKit2:

* GNUmakefile.am: Narrow down the dependency CFLAGS list to only ones that are actually needed
to build the platformgtk_sources into libPlatformGtk2.la. At the moment this means only
GTK+-2.0 CFLAGS are used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean out some stale chromium TestExpectations entries.
jamesr@google.com [Wed, 13 Mar 2013 19:32:18 +0000 (19:32 +0000)]
Clean out some stale chromium TestExpectations entries.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra...
tony@chromium.org [Wed, 13 Mar 2013 19:28:59 +0000 (19:28 +0000)]
Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding
https://bugs.webkit.org/show_bug.cgi?id=112047

Reviewed by Ojan Vafai.

Source/WebCore:

Add a new pass for computing the client bottom edge that runs after we've repositioned children
due to wrap-reverse, flex-end or vertical centering.

Test: css3/flexbox/negative-overflow.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Remove the code to use clientLogicalBottom() that was computed before
repositioning. The repositioning can change the edge.
(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning): Compute the new bottom based on the final position
of flex items.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/negative-overflow-expected.txt: Added.
* css3/flexbox/negative-overflow.html: Added.
* resources/check-layout.js: Add attributes for checking scroll width and scroll height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago.: Expose symbols for internals
japhet@chromium.org [Wed, 13 Mar 2013 19:14:31 +0000 (19:14 +0000)]
.: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

* Source/autotools/symbols.filter:

Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Test: http/tests/navigation/post-redirect-get-reload.php

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether
    we are in a redirect. Check redirectResponse.isNull() instead.
* testing/Internals.cpp:
(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.
    Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
    which makes it unsuitable for this case.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/win: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194.

Reviewed by Alexey Proskuryakov.

* http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
* http/tests/navigation/post-redirect-get-reload.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge MainResourceLoader's didFinishLoading and dataReceived into DocumentLoader
japhet@chromium.org [Wed, 13 Mar 2013 19:11:35 +0000 (19:11 +0000)]
Merge MainResourceLoader's didFinishLoading and dataReceived into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109952

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::maybeLoadEmpty):
* loader/DocumentLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Move content filtering to
    DocumentLoader.
(WebCore::MainResourceLoader::dataReceived): Mostly moved to DocumentLoader.
(WebCore::MainResourceLoader::didFinishLoading): Mostly moved to DocumentLoader.
* loader/MainResourceLoader.h: Expose some variables that haven't been moved
    to DocumentLoader yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCalling WebInspectorClient::highlight() during a fade-out animation of the PageOverla...
graouts@apple.com [Wed, 13 Mar 2013 18:47:34 +0000 (18:47 +0000)]
Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
https://bugs.webkit.org/show_bug.cgi?id=112271

Reviewed by Tim Horton.

Add a new stopFadeOutAnimation() on PageOverlay that we call when
WebInspectorClient::highlight() is called and a page overlay
is already available. This ensures that any fade-out animation
is cleared before proceeding with showing the page overlay
for the new highlight.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::stopFadeOutAnimation):
(WebKit):
* WebProcess/WebPage/PageOverlay.h:
(PageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Break after doesn't work correctly with auto-height regions
abucur@adobe.com [Wed, 13 Mar 2013 18:32:14 +0000 (18:32 +0000)]
[CSS Regions] Break after doesn't work correctly with auto-height regions
https://bugs.webkit.org/show_bug.cgi?id=112241

Reviewed by David Hyatt.

Source/WebCore:

The change correctly returns the break position during the normal layout phase for
auto-height regions. The problem doesn't exist during the constrained layout phase
so it only affects the size of the auto-height regions by incorrectly positioning
the content inside the flow.

Test: fast/regions/autoheight-break-after.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::applyAfterBreak): Include the margin offset in the returned break position.

LayoutTests:

This reference test verifies the correct break positioned is computed when there are auto-height regions during
the normal layout phase.
The test includes an auto-height region, a region with a specified size and an auto-height region. The first
region ends with a paragraph with a forced break after. During the normal layout phase, if the paragraph margin
is not included in the break offset, the next paragraph is incorrectly positioned and it will result in an
incorrectly sized last region.
In the constrained layout phase, the break position is returned correctly, the paragraph is positioned further down
causing overflow in the auto-height region.

* fast/regions/autoheight-break-after-expected.html: Added.
* fast/regions/autoheight-break-after.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: coalesce repeating timeline records
caseq@chromium.org [Wed, 13 Mar 2013 18:14:38 +0000 (18:14 +0000)]
Web Inspector: coalesce repeating timeline records
https://bugs.webkit.org/show_bug.cgi?id=112168

Reviewed by Vsevolod Vlasov.

- coalesce repeating top-level timeline events;
- drive-by: only show categories that actually took time in aggregated stats;

* English.lproj/localizedStrings.js:
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype._updateAncestorStats):
(WebInspector.TimelinePresentationModel.prototype._findCoalescedParent):
(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.adoptRecord):
(WebInspector.TimelinePresentationModel.insertRetrospectiveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix body background image geometry calculation
pdr@google.com [Wed, 13 Mar 2013 17:01:55 +0000 (17:01 +0000)]
Fix body background image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

    This change introduces clientForBackgroundImage in the background geometry calculation.
    This is very similar to how the client is looked up in paintFillLayerExtended.

* rendering/RenderBoxModelObject.h:

    The new signature for calculateBackgroundImageGeometry now mirrors
    paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

* svg/as-background-image/svg-as-background-body-expected.html: Added.
* svg/as-background-image/svg-as-background-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CodeMirror] Handle "enter" key in {|} situation
commit-queue@webkit.org [Wed, 13 Mar 2013 16:23:47 +0000 (16:23 +0000)]
Web Inspector: [CodeMirror] Handle "enter" key in {|} situation
https://bugs.webkit.org/show_bug.cgi?id=112153

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Add a keymap to handle "Enter" key and override it in case of {|}
situation.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.BlockIndentController):
(WebInspector.CodeMirrorTextEditor.BlockIndentController.prototype.Enter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CodeMirror] bug with LineWidgets
commit-queue@webkit.org [Wed, 13 Mar 2013 15:47:32 +0000 (15:47 +0000)]
Web Inspector: [CodeMirror] bug with LineWidgets
https://bugs.webkit.org/show_bug.cgi?id=111978

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Implement CodeMirrorTextEditor.beginUpdates and
CodeMirrorTextEditor.endUpdates and surround decoration creation
with the beginUpdates/endUpdates calls.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.beginUpdates):
(WebInspector.CodeMirrorTextEditor.prototype.endUpdates):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessageToSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][Introspection] Fix of gtk doc annotation warnings
commit-queue@webkit.org [Wed, 13 Mar 2013 15:38:43 +0000 (15:38 +0000)]
[GTK][Introspection] Fix of gtk doc annotation warnings
https://bugs.webkit.org/show_bug.cgi?id=109182

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-13
Reviewed by Martin Robinson.

Fixed some gtk doc annotation warnings that appears during
compiling. Also some white characters were removed and some restyling
was done - all the g_signal_new in webkit directory have now the same
style.

* webkit/webkitdownload.cpp:
(webkit_download_class_init):
* webkit/webkitfavicondatabase.cpp:
(webkit_favicon_database_class_init):
* webkit/webkitgeolocationpolicydecision.cpp:
* webkit/webkitglobals.cpp:
* webkit/webkithittestresult.h:
* webkit/webkiticondatabase.cpp:
(webkit_icon_database_class_init):
* webkit/webkitsecurityorigin.cpp:
* webkit/webkitsecurityorigin.h:
* webkit/webkitsoupauthdialog.cpp:
* webkit/webkitspellchecker.cpp:
* webkit/webkitviewportattributes.cpp:
(webkit_viewport_attributes_class_init):
* webkit/webkitwebdatabase.cpp:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
* webkit/webkitwebframe.h:
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_class_init):
* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):
* webkit/webkitwebplugindatabase.cpp:
* webkit/webkitwebpolicydecision.cpp:
* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init):
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
(webkit_web_view_apply_zoom_level):
* webkit/webkitwebwindowfeatures.cpp:
(webkit_web_window_features_equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup dead MediaSource code now that the Chromium-side refactor is complete.
acolwell@chromium.org [Wed, 13 Mar 2013 15:37:57 +0000 (15:37 +0000)]
Cleanup dead MediaSource code now that the Chromium-side refactor is complete.
https://bugs.webkit.org/show_bug.cgi?id=110371

Reviewed by Adam Barth.

* public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer): Remove old MediaSource methods and default MediaSource load() implementation.
* public/WebMediaPlayerClient.h: Remove old MediaSource methods.
* src/WebMediaPlayerClientImpl.cpp: Remove WebMediaSourceClientImpl & WebSourceBufferImpl classes that
                                    are no longer needed.
* src/WebMediaPlayerClientImpl.h: Remove old MediaSource methods.
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Touch Hold selection does not scroll text area or other subframe until...
commit-queue@webkit.org [Wed, 13 Mar 2013 15:34:34 +0000 (15:34 +0000)]
[BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=112259

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.

PR 267394

While selecting in a subframe, check that the selection reaches
the bottom of the current subframe instead of the page.

Internally Reviewed by Genevieve Mak.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
* WebKitSupport/SelectionHandler.h:
(BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Port TestRunner::findString to shared interface
hausmann@webkit.org [Wed, 13 Mar 2013 15:24:17 +0000 (15:24 +0000)]
[Qt] Port TestRunner::findString to shared interface
https://bugs.webkit.org/show_bug.cgi?id=112147

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Add new find options used by the DRT.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::findText):
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebpage.cpp:
* WidgetApi/qwebpage.h:

Tools:

This patch also removes DumpRenderTree and some other helper classes from
the WebCore namespace, to which they do not really belong.

* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::~DumpRenderTree):
(DumpRenderTree::instance):
(DumpRenderTree::setShouldTimeout):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::contextClick):
(EventSender::sendEvent):
(EventSender::postEvent):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender::isGraphicsBased):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::TestRunnerQt):
(TestRunner::findString):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: get rid of hiddenPanels filter
pfeldman@chromium.org [Wed, 13 Mar 2013 14:17:45 +0000 (14:17 +0000)]
Web Inspector: get rid of hiddenPanels filter
https://bugs.webkit.org/show_bug.cgi?id=112252

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.order:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
* testing/Internals.cpp:

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
* WebCoreSupport/InspectorClientGtk.h:
(InspectorFrontendClient):

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore):
* WebCoreSupport/InspectorClientQt.h:
(InspectorFrontendClientQt):

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNot reviewed: chromium baselines.
pfeldman@chromium.org [Wed, 13 Mar 2013 14:14:22 +0000 (14:14 +0000)]
Not reviewed: chromium baselines.

* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Rename android_build_type to android_webview_build in .gyp files.
mnaganov@chromium.org [Wed, 13 Mar 2013 14:13:13 +0000 (14:13 +0000)]
[Chromium] Rename android_build_type to android_webview_build in .gyp files.
https://bugs.webkit.org/show_bug.cgi?id=112129

Reviewed by Adam Barth.

Following Chromium
http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
this is being renamed to better explain what it does.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: convert workers inspection into capability
pfeldman@chromium.org [Wed, 13 Mar 2013 13:38:33 +0000 (13:38 +0000)]
Web Inspector: convert workers inspection into capability
https://bugs.webkit.org/show_bug.cgi?id=112251

Reviewed by Vsevolod Vlasov.

Source/WebCore:

It should be up to backend

* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::canInspectWorkers):
(WebCore):
* inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/Settings.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Start using evas object directly in Widget class
mikhail.pozdnyakov@intel.com [Wed, 13 Mar 2013 13:30:05 +0000 (13:30 +0000)]
[EFL] Start using evas object directly in Widget class
https://bugs.webkit.org/show_bug.cgi?id=111858

Reviewed by Antonio Gomes.

Based on a patch by Kenneth Rohde Christiansen.

EFL Widget class should use evas object pointer directly rather
than WidgetPrivate* m_data as platformWidget() is a Mac specific
implementation detail that they are moving away from with WebKit2.

This patch brings: firstly better compliance with other ports,
secondly it makes code cleaner.

Besides, the evasObject is only directly used in the ScrollbarEfl
subclass of Widget and not in Widget or ScrollView or any other subclass,
thus the evas_object code has now been concentrated in ScrollbarEfl.

No new tests as there are no behavioral changes.

* page/efl/EventHandlerEfl.cpp:
* platform/Widget.h:
(Widget):
(WebCore::Widget::evasObject):
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::~ScrollbarEfl):
(scrollbarEflEdjeMessage):
(ScrollbarEfl::show):
(ScrollbarEfl::hide):
(ScrollbarEfl::setParent):
(ScrollbarEfl::updateThumbPositionAndProportion):
(ScrollbarEfl::frameRectsChanged):
* platform/efl/ScrollbarEfl.h:
(ScrollbarEfl):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::frameRectsChanged):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setEvasObject):
* plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::platformGetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed trivial typo fix
hausmann@webkit.org [Wed, 13 Mar 2013 13:01:26 +0000 (13:01 +0000)]
[Qt] Unreviewed trivial typo fix

* DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
TextRunner.h. Thanks Zeno :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Prepare DRT for transition to shared TestRunner interface
hausmann@webkit.org [Wed, 13 Mar 2013 12:48:47 +0000 (12:48 +0000)]
[Qt] Prepare DRT for transition to shared TestRunner interface
https://bugs.webkit.org/show_bug.cgi?id=112144

Reviewed by Benjamin Poulain.

Prepare Qt's DRT for a transition from the QObject based TestRunner to
the JSC C API based one.

This is impplemented by instantiating the QObject based testRunner in
the global object, then instantiating the JSC C based TestRunner
separately and placing it "behind" the QObject based testRunner through
injection of the individual functions through proxies. (prototype
chaining doesn't work due to the this object and Function.prototype.bind
doesn't work due to the native function)

This allows for porting over method by method by removing the method
from the QObject TestRunnerQt and implementing it in the JSC C based
TestRunner.

In order for this to link and run dummy implementations of all the
necessary TestRunner functions are provided.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::initJSObjects):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::~TestRunner):
(TestRunner::addDisallowedURL):
(TestRunner::queueLoad):
(TestRunner::removeAllVisitedLinks):
(TestRunner::setAcceptsEditing):
(TestRunner::simulateLegacyWebNotificationClick):
(TestRunner::setWindowIsKey):
(TestRunner::setAlwaysAcceptCookies):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::setWebViewEditable):
(TestRunner::clearAllApplicationCaches):
(TestRunner::setTextDirection):
(TestRunner::notifyDone):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::overridePreference):
(TestRunner::pathToLocalResource):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::focusWebView):
(TestRunner::setBackingScaleFactor):
(TestRunner::removeChromeInputField):
(TestRunner::addChromeInputField):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteAllLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::syncLocalStorage):
(TestRunner::windowCount):
(TestRunner::setWaitToDump):
(TestRunner::waitForPolicyDelegate):
(TestRunner::webHistoryItemCount):
(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):
(TestRunner::setSerializeHTTPLoads):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setCustomPolicyDelegate):
(TestRunner::setDatabaseQuota):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::resetPageVisibility):
(TestRunner::keepWebHistory):
(TestRunner::goBack):
(TestRunner::originsWithApplicationCache):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::display):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::clearPersistentUserStyleSheet):
(TestRunner::callShouldCloseOnWebView):
(TestRunner::copyDecodedHostName):
(TestRunner::clearBackForwardList):
(TestRunner::clearAllDatabases):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::apiTestGoToCurrentBackForwardItem):
(TestRunner::authenticateSession):
(TestRunner::abortModal):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::setAsynchronousSpellCheckingEnabled):
(TestRunner::setXSSAuditorEnabled):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::setScrollbarPolicy):
(TestRunner::setJavaScriptCanAccessClipboard):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::setUserStyleSheetEnabled):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setUseDashboardCompatibilityMode):
(TestRunner::setTabKeyCyclesThroughElements):
(TestRunner::setSmartInsertDeleteEnabled):
(TestRunner::setSelectTrailingWhitespaceEnabled):
(TestRunner::setPrivateBrowsingEnabled):
(TestRunner::setPluginsEnabled):
(TestRunner::setPopupBlockingEnabled):
(TestRunner::setMockSpeechInputDumpRect):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMainFrameIsFirstResponder):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::setGeolocationPermission):
(TestRunner::setDefersLoading):
(TestRunner::setCacheModel):
(TestRunner::setAuthorAndUserStylesEnabled):
(TestRunner::setAllowFileAccessFromFileURLs):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setAllowUniversalAccessFromFileURLs):
(TestRunner::setApplicationCacheOriginQuota):
(TestRunner::denyWebNotificationPermission):
(TestRunner::grantWebNotificationPermission):
(TestRunner::setValueForUser):
(TestRunner::setViewModeMediaFeature):
(TestRunner::setPageVisibility):
(TestRunner::addMockSpeechInputResult):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::isCommandEnabled):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunner::copyEncodedHostName):
(TestRunner::addUserStyleSheet):
(TestRunner::findString):
(TestRunner::execCommand):
(TestRunner::localStorageDiskUsageForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CodeMirror] token highlight still has some problems
commit-queue@webkit.org [Wed, 13 Mar 2013 12:48:28 +0000 (12:48 +0000)]
Web Inspector: [CodeMirror] token highlight still has some problems
https://bugs.webkit.org/show_bug.cgi?id=112173

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Use pseudo elements with borders to draw token highlight.

No new tests.

* inspector/front-end/cm/cmdevtools.css:
(.cm-token-highlight):
(.cm-token-highlight:before):
(.cm-line-with-selection .cm-column-with-selection:before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] SimpleFontData: remove duplicate code
commit-queue@webkit.org [Wed, 13 Mar 2013 12:38:08 +0000 (12:38 +0000)]
[BlackBerry] SimpleFontData: remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=112149

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-13
Reviewed by Carlos Garcia Campos.

smallCapsFontData() and emphasisMarkFontData() were moved from
platform specific files into platform/graphics/SimpleFontData.cpp
in r133362, so the BlackBerry port no longer needs its own
implementation.

* platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNot reviewed: chromium baselines.
pfeldman@chromium.org [Wed, 13 Mar 2013 12:20:46 +0000 (12:20 +0000)]
Not reviewed: chromium baselines.

* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: throw an exception if the requested lazy loaded script does not exist.
loislo@chromium.org [Wed, 13 Mar 2013 12:18:06 +0000 (12:18 +0000)]
Web Inspector: throw an exception if the requested lazy loaded script does not exist.
https://bugs.webkit.org/show_bug.cgi?id=112237

Reviewed by Pavel Feldman.

* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLLINT C loop warning fix for GCC
ossy@webkit.org [Wed, 13 Mar 2013 12:13:23 +0000 (12:13 +0000)]
LLINT C loop warning fix for GCC
https://bugs.webkit.org/show_bug.cgi?id=112145

Reviewed by Filip Pizlo.

* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner...
jocelyn.turcotte@digia.com [Wed, 13 Mar 2013 11:27:00 +0000 (11:27 +0000)]
[WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner start
https://bugs.webkit.org/show_bug.cgi?id=112223

Reviewed by Simon Hausmann.

We need to only enable the cookie jar and the disk cache conditionally
in the web process since we removed default paths and WKTR doesn't provide
them.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport C++11 features in GCC <4.6
allan.jensen@digia.com [Wed, 13 Mar 2013 11:22:15 +0000 (11:22 +0000)]
Support C++11 features in GCC <4.6
https://bugs.webkit.org/show_bug.cgi?id=111553

Reviewed by Simon Hausmann.

Enable support for rvalue references from gcc 4.3, deleted functions
from gcc 4.4, explicit conversion from gcc 4.5, and strongly typed
enums from gcc 4.6.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd support for convenient conversion from JSStringRef to QString
hausmann@webkit.org [Wed, 13 Mar 2013 10:14:50 +0000 (10:14 +0000)]
Add support for convenient conversion from JSStringRef to QString
https://bugs.webkit.org/show_bug.cgi?id=109694

Reviewed by Allan Sandfeld Jensen.

Add JSStringCopyQString helper function that allows for the convenient
extraction of a QString out of a JSStringRef.

* API/JSStringRefQt.cpp: Added.
(JSStringCopyQString):
* API/JSStringRefQt.h: Added.
* API/OpaqueJSString.h:
(OpaqueJSString):
(OpaqueJSString::qString):
(OpaqueJSString::OpaqueJSString):
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskip now passing compositing tests.
kadam@inf.u-szeged.hu [Wed, 13 Mar 2013 09:58:27 +0000 (09:58 +0000)]
[Qt] Unreviewed gardening. Unskip now passing compositing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html...
mihnea@adobe.com [Wed, 13 Mar 2013 09:38:06 +0000 (09:38 +0000)]
[chromium] Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106097

Reviewed by Tony Chang.

After http://trac.webkit.org/changeset/138785, the content overflowing the last region in chain is
displayed properly in vertical-rl writing mode. This determined the failure of japanese-rl-selection-repaint-in-regions.html
test due to the overflowing content that now appears when rendered.

I modified the original test by decreasing the font size so that the content is not overflowing, because the purpose
of the original test was not to check the overflowed content anyway. I have generated new expected results for mac and chromium
and unskipped the test on chromium and mac.

* fast/repaint/japanese-rl-selection-repaint-in-regions.html:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/mac/TestExpectations:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPass the XSSAuditor's report URL to the XSSAuditorDelegate on the main thread.
mkwst@chromium.org [Wed, 13 Mar 2013 09:32:25 +0000 (09:32 +0000)]
Pass the XSSAuditor's report URL to the XSSAuditorDelegate on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=112179

Reviewed by Adam Barth.

Rather than relying on XSSInfo objects to move the XSSAuditor's report
URL into the XSSAuditorDelegate for reporting, we should be able to grab
the URL directly from XSSAuditor before it moves off the main thread,
and store it on the delegate.

This will enable us to drop the report URL properties from both
XSSAuditor and XSSInfo. Oh, happy day!

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
    We no longer need to check whether XSSInfo objects are thread safe,
    as we've dropped the only problematic bit.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
    When initializing the XSSAuditor, pass in an XSSAuditorDelegate*
    and assign the report URL directly onto that object.
(WebCore::XSSAuditor::filterToken):
    Drop the report URL parameter from XSSInfo objects we create in the
    Auditor, as they're now handled directly from the delegate.
(WebCore::XSSAuditor::isSafeToSendToAnotherThread):
    Drop the report URL property from XSSAuditor's threadsafeness check,
    as properties that do not exist are automatically thread-safe.
* html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
    Use the delegate's own report URL rather than the XSSInfo objects'.
* html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
    Drop the report URL property from XSSInfo.
(WebCore::XSSAuditorDelegate::setReportURL):
(XSSAuditorDelegate):
    Provide a public API for setting a delegate's report URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] http/tests/websocket/tests/hybi/close-on-navigate-new-location.html is failing
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 09:26:39 +0000 (09:26 +0000)]
[EFL] http/tests/websocket/tests/hybi/close-on-navigate-new-location.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112231

Reviewed by Kentaro Hara.

close-on-navigate-new-location.html tests that the websocket is closed when navigating
to a new location (handler_map.txt). However, handler_map.txt does not exist so we get
an HTTP 404 error and we end up not navigating. This patch fixes the navigation path
to "../handler_map.txt" since the file is actually in the parent folder.

* http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnsafe JavaScript attempt errors are ludicrously verbose and annoying
mkwst@chromium.org [Wed, 13 Mar 2013 09:13:15 +0000 (09:13 +0000)]
Unsafe JavaScript attempt errors are ludicrously verbose and annoying
https://bugs.webkit.org/show_bug.cgi?id=112042

Reviewed by Timothy Hatcher.

Source/WebCore:

This patch attempts to make the most common case of error message less
ludicrous by adjusting it to include only an origin as opposed to full
URLs for the active and target frames. It now reads: "Blocked a frame
with origin 'http://127.0.0.1:8000' from accessing a frame with origin
'http://localhost:8000'. Protocols, domains, and ports must match."

In the interest of keeping the patch size down, I'll follow up on the
other cases (sandboxed access, 'document.domain' mismatches, etc) in
future patches.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):

LayoutTests:

* fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
* http/tests/history/cross-origin-replace-history-object-child-expected.txt:
* http/tests/history/cross-origin-replace-history-object-expected.txt:
* http/tests/inspector-protocol/access-inspected-object-expected.txt:
* http/tests/plugins/cross-frame-object-access-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
* http/tests/security/cross-frame-access-call-expected.txt:
* http/tests/security/cross-frame-access-custom-expected.txt:
* http/tests/security/cross-frame-access-delete-expected.txt:
* http/tests/security/cross-frame-access-enumeration-expected.txt:
* http/tests/security/cross-frame-access-first-time-expected.txt:
* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt:
* http/tests/security/cross-frame-access-get-expected.txt:
* http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
* http/tests/security/cross-frame-access-history-get-expected.txt:
* http/tests/security/cross-frame-access-history-put-expected.txt:
* http/tests/security/cross-frame-access-location-get-expected.txt:
* http/tests/security/cross-frame-access-location-put-expected.txt:
* http/tests/security/cross-frame-access-name-getter-expected.txt:
* http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
* http/tests/security/cross-frame-access-object-prototype-expected.txt:
* http/tests/security/cross-frame-access-port-expected.txt:
* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/security/cross-frame-access-selection-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
* http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
* http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
* http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
* http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
* http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
* http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
* http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
* http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
* http/tests/security/xss-DENIED-assign-location-hash-expected.txt:
* http/tests/security/xss-DENIED-assign-location-host-expected.txt:
* http/tests/security/xss-DENIED-assign-location-hostname-expected.txt:
* http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
* http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt:
* http/tests/security/xss-DENIED-assign-location-pathname-expected.txt:
* http/tests/security/xss-DENIED-assign-location-protocol-expected.txt:
* http/tests/security/xss-DENIED-assign-location-reload-expected.txt:
* http/tests/security/xss-DENIED-assign-location-search-expected.txt:
* http/tests/security/xss-DENIED-defineProperty-expected.txt:
* http/tests/security/xss-DENIED-frame-name-expected.txt:
* http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt:
* http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt:
* http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt:
* http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
* http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
* http/tests/security/xss-DENIED-javascript-with-spaces-expected.txt:
* http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
* http/tests/security/xss-DENIED-synchronous-form-expected.txt:
* http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt:
* http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt:
* http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt:
* http/tests/security/xss-DENIED-window-open-parent-expected.txt:
* http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
* http/tests/security/xss-eval-expected.txt:
* http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
* platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
* platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt:
* platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
* platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt:
* platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement :scope for element.querySelector[All]()
tasak@google.com [Wed, 13 Mar 2013 09:09:47 +0000 (09:09 +0000)]
Implement :scope for element.querySelector[All]()
https://bugs.webkit.org/show_bug.cgi?id=81069

Reviewed by Dimitri Glazkov.

Source/WebCore:

Implemented :scope for element.querySelector[All]().
Reuse scope in SelectorCheckingContext and added a new value to
enum BehaviorAtBoundary.
:scope spec is http://dev.w3.org/csswg/selectors4/#scope-pseudo.

Test: fast/selectors/querySelector-scope.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
Added :scope pseudo type.
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):
Added PseudoScope case and modified "scope" meaning when
behaviorAtBoundary is equal to StaysWithinTreeScope.
If so, "scope" is just a contextual reference node.
* css/SelectorChecker.h:
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::execute):
Use rootNode as a contextual reference node.
* dom/SelectorQuery.h:
(SelectorDataList):

LayoutTests:

* fast/selectors/querySelector-scope-expected.txt: Added.
* fast/selectors/querySelector-scope.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoToken 'not' is ignored in the offlineasm.
commit-queue@webkit.org [Wed, 13 Mar 2013 09:07:42 +0000 (09:07 +0000)]
Token 'not' is ignored in the offlineasm.
https://bugs.webkit.org/show_bug.cgi?id=111568

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-13
Reviewed by Filip Pizlo.

* offlineasm/parser.rb: Build the Not AST node if the 'not' token is found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Wed, 13 Mar 2013 09:06:44 +0000 (09:06 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] FontPlatformData: remove TextOrientation parameter
commit-queue@webkit.org [Wed, 13 Mar 2013 09:06:13 +0000 (09:06 +0000)]
[BlackBerry] FontPlatformData: remove TextOrientation parameter
https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-13
Reviewed by Rob Buis.

This doesn't exist since r136520.

* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/blackberry/FontCustomPlatformData.h:
(FontCustomPlatformData):
* platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::applyState):
* platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::createScaledFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed rebaseline.
mikhail.pozdnyakov@intel.com [Wed, 13 Mar 2013 08:58:12 +0000 (08:58 +0000)]
[EFL] Unreviewed rebaseline.

* platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt:

    Rebaseline after r145422.

* platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/efl/css3/flexbox/flexbox-baseline-expected.txt:
* platform/efl/fast/css-generated-content/015-expected.txt:
* platform/efl/fast/css/h1-in-section-elements-expected.txt:
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/efl/tables/mozilla/bugs/bug126742-expected.txt:
* platform/efl/tables/mozilla/bugs/bug69187-expected.txt:

    Rebaseline after r145242.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEFL rebaseline after r145242.
mikhail.pozdnyakov@intel.com [Wed, 13 Mar 2013 08:13:58 +0000 (08:13 +0000)]
EFL rebaseline after r145242.

* platform/efl/css1/basic/inheritance-expected.txt:
* platform/efl/css1/box_properties/clear_float-expected.txt:
* platform/efl/css1/box_properties/margin-expected.txt:
* platform/efl/css1/box_properties/margin_bottom-expected.txt:
* platform/efl/css1/box_properties/margin_top-expected.txt:
* platform/efl/css1/box_properties/padding-expected.txt:
* platform/efl/css1/box_properties/padding_bottom-expected.txt:
* platform/efl/css1/box_properties/padding_top-expected.txt:
* platform/efl/css1/color_and_background/background_attachment-expected.txt:
* platform/efl/css1/font_properties/font_weight-expected.txt:
* platform/efl/css1/formatting_model/vertical_formatting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Wed, 13 Mar 2013 07:52:09 +0000 (07:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Adding failure expectation for the SVG test after r145541.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskipp some passing compositing tests.
kadam@inf.u-szeged.hu [Wed, 13 Mar 2013 07:43:19 +0000 (07:43 +0000)]
[Qt] Unreviewed gardening. Unskipp some passing compositing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Added.
* platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.png: Added.
* platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
* platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
* platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/overflow-overlay-with-touch-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/scrolling-without-painting-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/overflow/updating-scrolling-content-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/plugins/no-backing-store-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
* platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/self-painting-layers-expected.png: Added.
* platform/qt-5.0-wk1/compositing/self-painting-layers-expected.txt: Added.
* platform/qt-5.0-wk1/compositing/video/video-poster-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 13 Mar 2013 07:12:05 +0000 (07:12 +0000)]
Unreviewed GTK gardening.

Adding expectations for a couple of flaky crashers on the debug builder.
Adding flaky failure expectations for a couple of SVG animations tests.
Adding failure expectation for the SVG test introduced in 145541, failing due to disabled subpixel layout.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed inspector test fix.
vsevik@chromium.org [Wed, 13 Mar 2013 05:44:03 +0000 (05:44 +0000)]
Unreviewed inspector test fix.

* http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html:
* inspector/datagrid-autosize.html:
* inspector/debugger/breakpoint-manager-listeners-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBasic child obscuration test for backgrounds
antti@apple.com [Wed, 13 Mar 2013 04:55:11 +0000 (04:55 +0000)]
Basic child obscuration test for backgrounds
https://bugs.webkit.org/show_bug.cgi?id=111701

Source/WebCore:

Reviewed by Simon Fraser.

Test: fast/repaint/obscured-background-no-repaint.html

We can easily detect some simple cases where a background image is fully obscured by an opaque child.

This avoids unncessary painting and image decoding. It is especially helpful for cases like about.com home
page where a fully obscured 'loading' spinner keeps triggering frequent complex repaints (gif animations
progress by getting painted and stop if they are not).

This could be made way more sophisticated. The checking could also be done per-layout rather per-paint.
Even this simple approach gets hit surprisingly often in real world sites.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsObscured):

    Before painting background test if any single child renderer fully obscures it.

(WebCore::RenderBox::backgroundIsOpaqueInRect):
* rendering/RenderBox.h:

LayoutTests:

Reviewed by Simon Fraser.

* fast/repaint/obscured-background-no-repaint-expected.txt: Added.
* fast/repaint/obscured-background-no-repaint.html: Added.
* fast/repaint/resources/animated.gif: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup: Move flatten-trie to loader.
jparent@chromium.org [Wed, 13 Mar 2013 04:14:17 +0000 (04:14 +0000)]
Cleanup: Move flatten-trie to loader.
https://bugs.webkit.org/show_bug.cgi?id=112196

Reviewed by Dirk Pranke.

flatten-trie is used only by the loader, so move it there and make it
private, rather than global in dashbaord_base. Moved the corresponding
unit test from flakiness_dashboard_unittests to loader_unittests.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.
ggaren@apple.com [Wed, 13 Mar 2013 03:59:32 +0000 (03:59 +0000)]
Unreviewed attempted Windows build fix after trac.webkit.org/changeset/145592.

* wtf/SchedulePair.cpp:
* wtf/SchedulePair.h:
(WTF::SchedulePair::SchedulePair): Since linking is failing,
try inlining this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Crash] Touch Events retargeting causes crashes on chrome on android.
hayato@chromium.org [Wed, 13 Mar 2013 03:51:39 +0000 (03:51 +0000)]
[Crash] Touch Events retargeting causes crashes on chrome on android.
https://bugs.webkit.org/show_bug.cgi?id=112210

Reviewed by Dimitri Glazkov.

Added null-check for TouchEvent's touches(), targetTouches() and changedTouches().

No new tests - no new functionality.

* dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustTouchList):
* dom/EventRetargeter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] ewk_popup_menu_close() does not work as intended
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 03:46:58 +0000 (03:46 +0000)]
[EFL][WK2] ewk_popup_menu_close() does not work as intended
https://bugs.webkit.org/show_bug.cgi?id=110209

Reviewed by Laszlo Gombos.

ewk_popup_menu_close() is called by the browser to notify WebKit that
the popup menu was closed. However, the implementation was calling
EwkView::closePopupMenu() which was asking the browser to close the
popup menu via an Evas smart function. This patch fixes the behavior
and ewk_popup_menu_close() now calls WKPopupMenuListenerSetSelection()
C API so that the WebProcess is notified that the popup menu was
hidden.

* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r187688. Requested by
commit-queue@webkit.org [Wed, 13 Mar 2013 03:07:47 +0000 (03:07 +0000)]
Unreviewed.  Rolled Chromium DEPS to r187688.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2013-03-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 13 Mar 2013 02:59:08 +0000 (02:59 +0000)]
2013-03-12  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.

        * platform/RunLoopTimer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate test expectation for the bug 111521.
rniwa@webkit.org [Wed, 13 Mar 2013 02:14:31 +0000 (02:14 +0000)]
Update test expectation for the bug 111521.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer().
commit-queue@webkit.org [Wed, 13 Mar 2013 01:51:16 +0000 (01:51 +0000)]
Coordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer().
https://bugs.webkit.org/show_bug.cgi?id=111835

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-12
Reviewed by Luiz Agostini.

Source/WebCore:

This patch removes CoordinatedGraphicsLayer::setRootLayer() because
CoordinatedGraphicsScene already knows which layer is root.

No new tests, no behavior change.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

Source/WebKit2:

Amend CoordinatedLayerTreeHost because
CoordinatedGraphicsLayer::setRootLayer() is removed.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelera...
commit-queue@webkit.org [Wed, 13 Mar 2013 01:47:39 +0000 (01:47 +0000)]
Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use
https://bugs.webkit.org/show_bug.cgi?id=111126

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

In texImage2D() for HTMLVideoElement in WebGL, it is possible to do a GPU-GPU texture copy instead of CPU readback
and upload when videoFrame is in the form of textures. Each platform port needs to implement the interface
copyVideoTextureToPlatformTexture() defined in MediaPlayer.h to make it work.

Already covered by current tests.

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture):
* html/HTMLVideoElement.h:
(HTMLVideoElement):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::videoFrameToImage): Move some security check to upper level.
(WebCore::WebGLRenderingContext::texImage2D): Add the fast GPU-GPU textures copy path for HTMLVideoElement and some security check.
(WebCore::WebGLRenderingContext::texSubImage2D): Add some security check.
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::isValid): Added to check if the texture is defined at the given level.
* html/canvas/WebGLTexture.h:
(WebGLTexture):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::copyVideoTextureToPlatformTexture): Added to do the GPU-GPU textures copy.
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::copyVideoTextureToPlatformTexture):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::copyVideoTextureToPlatformTexture):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::copyVideoTextureToPlatformTexture): do a GPU-GPU textures copy if possible.
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate a few chromium test expectations.
jamesr@google.com [Wed, 13 Mar 2013 01:46:27 +0000 (01:46 +0000)]
Update a few chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTypo in earlier Windows build fix. Unreviewed.
timothy_horton@apple.com [Wed, 13 Mar 2013 01:25:00 +0000 (01:25 +0000)]
Typo in earlier Windows build fix. Unreviewed.

* WTF.vcproj/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWTF uses macros for exports. Try to fix the Windows build. Unreviewed.
timothy_horton@apple.com [Wed, 13 Mar 2013 01:20:51 +0000 (01:20 +0000)]
WTF uses macros for exports. Try to fix the Windows build. Unreviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] WebFrame event listener APIs are unused and can be removed
abarth@webkit.org [Wed, 13 Mar 2013 01:19:05 +0000 (01:19 +0000)]
[Chromium] WebFrame event listener APIs are unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=112189

Reviewed by Darin Fisher.

As far as I can tell, there are no callers for these APIs. They appear
to have been added for out-of-process postMessages, but those are now
implemented using a different mechanism.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r145280.
commit-queue@webkit.org [Wed, 13 Mar 2013 01:14:34 +0000 (01:14 +0000)]
Unreviewed, rolling out r145280.
http://trac.webkit.org/changeset/145280
https://bugs.webkit.org/show_bug.cgi?id=112217

This patch broke chromium WebGL conformance tests (Requested
by shawnsingh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnbreak api tests
oliver@apple.com [Wed, 13 Mar 2013 01:06:15 +0000 (01:06 +0000)]
Unbreak api tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't send events to plugins that are being snapshotted
dino@apple.com [Wed, 13 Mar 2013 00:56:52 +0000 (00:56 +0000)]
Don't send events to plugins that are being snapshotted
https://bugs.webkit.org/show_bug.cgi?id=112215
<rdar://problem/13386224>

Reviewed by Tim Horton.

If a plugin is in the process of being snapshotted, do not forward it
any events. This avoids the case where we can accidentally capture some
custom mouse pointers, as well as trigger a plugin menu.

The next step will be to detect if the event should stop the snapshotting
(restart the plugin).

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Return early if the plugin is snapshotting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPrimary plugin hit detection needs to run after plugin creation
dino@apple.com [Wed, 13 Mar 2013 00:56:32 +0000 (00:56 +0000)]
Primary plugin hit detection needs to run after plugin creation
https://bugs.webkit.org/show_bug.cgi?id=112206

Reviewed by Tim Horton.

On some pages, the plugins are created after the page has loaded, and
thus our heuristic to determine the primary plugin fails. Run this
heuristic more often: after each PluginView is created. It already exits
early if it has found a primary. But we also need to make sure that it
doesn't run before load.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addPluginView): Run detection when view is added.
(WebKit::WebPage::didFinishLoad): Remember that we have loaded.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Look at the PluginViews to see if we have a plugin.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn): Reset both flags.
* WebProcess/WebPage/WebPage.h:
(WebPage): New member variable, m_readyToFindPrimarySnapshottedPlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.
timothy_horton@apple.com [Wed, 13 Mar 2013 00:43:44 +0000 (00:43 +0000)]
Unreviewed attempted Windows build fix after trac.webkit.org/changeset/145592.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
commit-queue@webkit.org [Wed, 13 Mar 2013 00:25:45 +0000 (00:25 +0000)]
Fix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
https://bugs.webkit.org/show_bug.cgi?id=89510

Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

WTF::Vector::begin() returns 0 when the vector has length zero. On windows, the debug implementation of
std::copy() is unhappy with 0 as a third parameter even when the first and second parameters are equal.

Covered by gamepad/gamepad-polling-access.html

* Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):

LayoutTests:

Remove expectation now that test passes.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoArray.prototype.sort should at least try to be PTIME even when the array is in some...
fpizlo@apple.com [Wed, 13 Mar 2013 00:17:38 +0000 (00:17 +0000)]
Array.prototype.sort should at least try to be PTIME even when the array is in some bizarre mode
https://bugs.webkit.org/show_bug.cgi?id=112187
<rdar://problem/13393550>

Source/JavaScriptCore:

Reviewed by Michael Saboff and Gavin Barraclough.

If we have an array-like object in crazy mode passed into Array.prototype.sort, and its length is large,
then first copy all elements into a separate, compact, un-holy array and sort that. Then copy back.
This means that sorting will be at works O(n^2) in the actual number of things in the array, rather than
O(n^2) in the array's length.

* runtime/ArrayPrototype.cpp:
(JSC::attemptFastSort):
(JSC::performSlowSort):
(JSC):
(JSC::arrayProtoFuncSort):

LayoutTests:

Reviewed by Michael Saboff and Gavin Barraclough.

If your Array.prototype.sort is not sufficiently smart, this test will never complete.
But if it is, it'll complete instantly.

* fast/js/array-sort-small-sparse-array-with-large-length-expected.txt: Added.
* fast/js/array-sort-small-sparse-array-with-large-length.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/array-sort-small-sparse-array-with-large-length.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is
bdakin@apple.com [Wed, 13 Mar 2013 00:09:55 +0000 (00:09 +0000)]
WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is
passed in
https://bugs.webkit.org/show_bug.cgi?id=112212
-and corresponding-
<rdar://problem/12994883>

Reviewed by Anders Carlsson.

We should call [NSPrintOperation printOperationWithView: printInfo:] to use the
printInfo parameter instead of [NSPrintOperation printOperationWithView:] which
will just use the sharedPrintInfo.
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Remove last vestigates of WEBKIT_USING_V8
abarth@webkit.org [Wed, 13 Mar 2013 00:03:42 +0000 (00:03 +0000)]
[Chromium] Remove last vestigates of WEBKIT_USING_V8
https://bugs.webkit.org/show_bug.cgi?id=112203

Reviewed by James Robinson.

These macros are no longer referenced anywhere and can be removed.

* chromium/public/WebCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate chromium pixel baselines for mesa blend fix in chromium r187688
jamesr@google.com [Wed, 13 Mar 2013 00:02:54 +0000 (00:02 +0000)]
Update chromium pixel baselines for mesa blend fix in chromium r187688

* platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Removed.
* platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Removed.
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-linux/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-linux/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-linux/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Removed.
* platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Removed.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png:
* platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
* platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
* platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac-lion/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac-lion/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac-lion/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac-lion/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-lion/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac-lion/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-lion/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac/compositing/self-painting-layers-expected.png:
* platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png:
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
* platform/chromium-mac/css3/filters/filter-change-repaint-composited-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-change-repaint-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png:
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
* platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
* platform/chromium/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
* platform/efl-wk2/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build.
timothy_horton@apple.com [Tue, 12 Mar 2013 23:49:12 +0000 (23:49 +0000)]
Try to fix the Windows build.

Not reviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove TextIterator.cpp's isAllCollapsibleWhitespace
esprehn@chromium.org [Tue, 12 Mar 2013 23:43:47 +0000 (23:43 +0000)]
Remove TextIterator.cpp's isAllCollapsibleWhitespace
https://bugs.webkit.org/show_bug.cgi?id=112200

Reviewed by Ryosuke Niwa.

Remove isAllCollapsibleWhitespace since nothing uses it.

* editing/TextIterator.cpp: Remove isAllCollapsibleWhitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
betravis@adobe.com [Tue, 12 Mar 2013 23:27:35 +0000 (23:27 +0000)]
[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.
* rendering/RenderBlock.h:
(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member. Move the struct
declaration to be public, so that the OwnPtr reference can properly delete it.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, disabling tests for Win EWS.
timothy_horton@apple.com [Tue, 12 Mar 2013 23:15:04 +0000 (23:15 +0000)]
Unreviewed, disabling tests for Win EWS.

win-ews obviously cannot keep up with running tests, it's >300 behind.
Probably doesn't help that its (likely) running tests serially.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build.
ggaren@apple.com [Tue, 12 Mar 2013 23:14:51 +0000 (23:14 +0000)]
Try to fix the Windows build.

Not reviewed.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Export a thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for r145592 - update gyp files to refer to new file locations.
jamesr@google.com [Tue, 12 Mar 2013 22:49:56 +0000 (22:49 +0000)]
Build fix for r145592 - update gyp files to refer to new file locations.

Source/WebCore:

* WebCore.gypi:

Source/WTF:

* WTF.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a single character cache to WidthCache
benjamin@webkit.org [Tue, 12 Mar 2013 22:39:02 +0000 (22:39 +0000)]
Add a single character cache to WidthCache
https://bugs.webkit.org/show_bug.cgi?id=112084

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-12
Reviewed by Geoffrey Garen.

More than half of the values stored in WidthCache are values
for a single character.

Previously, we were creating a new SmallStringKey for each one of
them, causing a lot of extra memory operations even for the simple
cases.

This patch adds a second map, m_singleCharMap, to simplify the
computation for the common case of a single char TextRun.

* platform/graphics/WidthCache.h:
(WebCore::WidthCache::clear):
(WidthCache):
(WebCore::WidthCache::addSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a --build-directory argument to delete-stale-build-files
timothy_horton@apple.com [Tue, 12 Mar 2013 22:38:45 +0000 (22:38 +0000)]
Add a --build-directory argument to delete-stale-build-files
https://bugs.webkit.org/show_bug.cgi?id=112198

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/delete-stale-build-files:
(main): Add --build-directory argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace static_casts for SVG transformable and locatable elements
pdr@google.com [Tue, 12 Mar 2013 22:26:07 +0000 (22:26 +0000)]
Replace static_casts for SVG transformable and locatable elements
https://bugs.webkit.org/show_bug.cgi?id=111651

Reviewed by Abhishek Arya.

toSVGStyledTransformableElement and toSVGStyledLocatableElement are preferred over
static_casts because bad casts can be caught on our testing infrastructure. This patch
replaces all static_casts for SVGStyledTransformableElement and SVGStyledLocatableElement
with toSVGStyledTransformableElement and toSVGStyledLocatableElement, respectively.

No new tests as this is covered with existing tests.

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
* rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::calculateDistance):

    This was an unnecessary cast and has been removed.

* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGStyledLocatableElement.h:
(WebCore):
(WebCore::toSVGStyledLocatableElement):
* svg/SVGStyledTransformableElement.h:
(WebCore):
(WebCore::toSVGStyledTransformableElement):

    It makes the code cleaner to pass Node* in here, rather than converting the Node*
    to an SVGElement* before calling this function. The same was not necessary for
    SVGStyledLocatable.

* svg/SVGSVGElement.h:
(WebCore):
(WebCore::toSVGSVGElement):

    This code has been cleaned up. During the review of this patch, a similar cleanup
    was done in toSVGStyledTransformableElement.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r187660. Requested by
abarth@webkit.org [Tue, 12 Mar 2013 22:21:38 +0000 (22:21 +0000)]
Unreviewed.  Rolled Chromium DEPS to r187660.  Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace static_casts with to* helper functions.
inferno@chromium.org [Tue, 12 Mar 2013 22:21:28 +0000 (22:21 +0000)]
Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112164

Reviewed by Philip Rogers.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
(WebCore::Pasteboard::writeImage):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::checkMultiple):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::hitTest):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::valueChanged):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::requiresAcceleratedCompositing):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::checkRegionStyle):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isEnabled):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isHovered):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
(WebCore::RenderTheme::paintSliderTicks):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
* rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAppease MSVC
oliver@apple.com [Tue, 12 Mar 2013 22:17:28 +0000 (22:17 +0000)]
Appease MSVC

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHarden JSStringJoiner
oliver@apple.com [Tue, 12 Mar 2013 22:15:54 +0000 (22:15 +0000)]
Harden JSStringJoiner
https://bugs.webkit.org/show_bug.cgi?id=112093

Reviewed by Filip Pizlo.

Harden JSStringJoiner, make it use our CheckedArithmetic
class to simplify everything.

* runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::build):
* runtime/JSStringJoiner.h:
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd one more test expectation per bug 112176.
rniwa@webkit.org [Tue, 12 Mar 2013 22:04:22 +0000 (22:04 +0000)]
Add one more test expectation per bug 112176.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMoved RunLoopTimer and SchedulePair to WTF
ggaren@apple.com [Tue, 12 Mar 2013 22:04:06 +0000 (22:04 +0000)]
Moved RunLoopTimer and SchedulePair to WTF
https://bugs.webkit.org/show_bug.cgi?id=112171

Reviewed by Oliver Hunt.

This will allow us to use timers in lower level primitives without
duplicating all the code.

../WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.h:
(WTF):
(WebCore):
(DocumentLoader):
* loader/MainResourceLoader.h:
* page/Page.h:
* platform/AutodrainedPool.h: Removed.
* platform/cf/RunLoopTimerCF.cpp: Removed.
* platform/cf/SchedulePair.cpp: Removed.
* platform/cf/SchedulePair.h: Removed.
* platform/mac/AutodrainedPool.mm: Removed.
* platform/mac/SchedulePairMac.mm: Removed.
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandle.h:
(WTF):
(WebCore):
(ResourceHandle):
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/mac/ResourceHandleMac.mm:

../WebKit/mac:

* WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):

../WebKit2:

* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):

../WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/AutodrainedPool.h: Copied from Source/WebCore/platform/AutodrainedPool.h.
(AutodrainedPool):
* wtf/AutodrainedPoolMac.mm: Copied from Source/WebCore/platform/mac/AutodrainedPool.mm.
* wtf/RunLoopTimer.h: Copied from Source/WebCore/platform/RunLoopTimer.h.
* wtf/RunLoopTimerCF.cpp: Copied from Source/WebCore/platform/cf/RunLoopTimerCF.cpp.
* wtf/SchedulePair.cpp: Copied from Source/WebCore/platform/cf/SchedulePair.cpp.
* wtf/SchedulePair.h: Copied from Source/WebCore/platform/cf/SchedulePair.h.
(SchedulePair):
* wtf/SchedulePairMac.mm: Copied from Source/WebCore/platform/mac/SchedulePairMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove stray .gitmodules file
abarth@webkit.org [Tue, 12 Mar 2013 21:58:01 +0000 (21:58 +0000)]
Remove stray .gitmodules file
https://bugs.webkit.org/show_bug.cgi?id=112186

Reviewed by Tony Chang.

Apparently I imported this together with the jquery tests by mistake.

* jquery/resources/src/sizzle/.gitmodules: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
abarth@webkit.org [Tue, 12 Mar 2013 21:54:11 +0000 (21:54 +0000)]
[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112120

Reviewed by Tony Chang.

Chromium always uses V8. This macro has outlived it's usefulness. It's
now just noise.

* README:
* public/WebArrayBuffer.h:
(WebArrayBuffer):
* public/WebArrayBufferView.h:
(WebArrayBufferView):
* public/WebBindings.h:
(WebBindings):
* public/WebBlob.h:
(WebBlob):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
* public/WebSerializedScriptValue.h:
(WebSerializedScriptValue):
* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
* src/WebBindings.cpp:
(WebKit::WebBindings::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
* src/WebFrameImpl.cpp:
(WebKit::WebFrame::frameForContext):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::serialize):
(WebKit::WebSerializedScriptValue::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac: Incorrect rendering of <audio> controls
commit-queue@webkit.org [Tue, 12 Mar 2013 21:53:19 +0000 (21:53 +0000)]
Mac: Incorrect rendering of <audio> controls
https://bugs.webkit.org/show_bug.cgi?id=110913

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-12
Reviewed by Tony Chang.

Source/WebCore:

Covered by existing tests under media/.

* css/mediaControls.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
The timeline container and the timeline need min-width: 0 so that they can shrink if needed.
* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
The timeline container also needs flex-start to ensure that it never overlaps
the play/rewind buttons. The current-time and remaining-time displays need min-width: 0 so that the hack
in RenderMediaControls.cpp works correctly - otherwise, RenderFlexibleBox tries to use the preferred width
of the time displays, which is wrong when they try to hide themselves.

LayoutTests:

* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/controls-without-preload-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd more Checked<> tests
oliver@apple.com [Tue, 12 Mar 2013 21:51:39 +0000 (21:51 +0000)]
Add more Checked<> tests
https://bugs.webkit.org/show_bug.cgi?id=112190

Reviewed by Geoffrey Garen.

Source/WTF:

Export the CheckedState enum type

* wtf/CheckedArithmetic.h:

Tools:

Tests!

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145587 268f45cc-cd09-0410-ab3c-d52691b4dbfc