WebKit-https.git
10 years agoUnreviewed, build fix.
ukai@chromium.org [Thu, 17 Dec 2009 07:17:55 +0000 (07:17 +0000)]
Unreviewed, build fix.

[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233

* public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
* src/AssertMatchingEnums.cpp: Added matching compile assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDel...
ossy@webkit.org [Thu, 17 Dec 2009 07:05:26 +0000 (07:05 +0000)]
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().

* platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 MORITA Hajime <morrita@gmail.com>
hamaji@chromium.org [Thu, 17 Dec 2009 06:30:20 +0000 (06:30 +0000)]
2009-12-15 MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        Test: editing/selection/doubleclick-beside-cr-span.html

        * editing/TextIterator.cpp:
        (WebCore::collapsedSpaceLength):
        (WebCore::maxOffsetIncludingCollapsedSpaces):
        (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16  MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        * editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
        * editing/selection/doubleclick-beside-cr-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 06:19:05 +0000 (06:19 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix flakiness in WebSocket handshake console message.
        https://bugs.webkit.org/show_bug.cgi?id=32598

        In chromium, LayoutTests/websocket/tests/handshake-error.html is
        flaky, because it outputs the following console message several times:
          CONSOLE MESSAGE: line 0: Unexpected response code:101
        Update m_mode in WebSocketHandshake correctly: Once it finds
        error in handshake message, set m_mode to Failed and don't try
        reading handshake message again.  If handshake message is not yet
        fully received, set m_mode to Incomplete, so next didReceiveData()
        will try to check handshake message again.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Dec 2009 05:58:00 +0000 (05:58 +0000)]
2009-12-16  Jon Honeycutt  <jhoneycutt@apple.com>

        MSAA: Accessibility role of text nodes is wrong

        https://bugs.webkit.org/show_bug.cgi?id=32631
        <rdar://problem/7369084>

        Reviewed by Alice Liu.

        Test: platform/win/accessibility/text-role.html

        WebCore/:
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        Add a new role to the enum.
        (WebCore::AccessibilityObject::roleValueForMSAA):
        Declare a function to return the accessibility role for MSAA; the base
        implementation returns the old role value.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        Initialize m_roleForMSAA.
        (WebCore::AccessibilityRenderObject::roleValueForMSAA):
        If m_roleForMSAA has been set, return it. If the renderer is a
        RenderText, set the role to EditableTextRole to match IE and Firefox.
        Otherwise, set the role for MSAA to the old role value.

        * accessibility/AccessibilityRenderObject.h:
        Add a member to hold the role for MSAA, and declare an override of
        roleValueForMSAA().

        WebKit/win/:
        * AccessibleBase.cpp:
        (MSAARole):
        If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
        (AccessibleBase::role):
        Call roleValueForMSAA().

        LayoutTests/:
        * platform/win/accessibility/text-role-expected.txt: Added.
        * platform/win/accessibility/text-role.html: Added.
        Check that the role of the text node that is the first child of the
        <a> tag has the "editable text" role.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Dec 2009 05:30:45 +0000 (05:30 +0000)]
2009-12-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by David Levin.

        check-webkit-style supports for TAB check against text files.
        https://bugs.webkit.org/show_bug.cgi?id=32538

        * Scripts/check-webkit-style:
          Move process_patch() to style.py.
        * Scripts/modules/cpp_style.py:
          Add can_handle().
        * Scripts/modules/cpp_style_unittest.py:
          Add tests for can_handle().
        * Scripts/modules/style.py:
          Added. This is a front-end of cpp_style and text_style. It dispatches
          files to an appropriate linter.
        * Scripts/modules/text_style.py:
          Added. This is a linter module for generic text files. It supports
          only for TAB checking at this moment.
        * Scripts/modules/text_style_unittest.py:
          Added. Tests for text_style.py.
        * Scripts/run-webkit-unittests:
          Add text_style_unittest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
ggaren@apple.com [Thu, 17 Dec 2009 03:50:37 +0000 (03:50 +0000)]
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code

Reviewed by Oliver Hunt.

This patch cuts Interpreter stack use by about a third.

* bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.

(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 00:44:10 +0000 (00:44 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
        https://bugs.webkit.org/show_bug.cgi?id=32606

        It should test with /websocket/tests/no-query

        * websocket/tests/script-tests/url-with-query-for-no-query.js:
        * websocket/tests/url-with-query-for-no-query-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:41:04 +0000 (00:41 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52206.
        http://trac.webkit.org/changeset/52206
        https://bugs.webkit.org/show_bug.cgi?id=31187

        This broke pixel tests on Mac.  Presumably the code in
        ImageCG is wrong here.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:40:10 +0000 (00:40 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        Centralize our import logic.

        * Scripts/modules/bugzilla.py: use webkit_mechanize
        * Scripts/modules/statusbot.py: use webkit_mechanize
        * Scripts/modules/webkit_mechanize.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
ossy@webkit.org [Thu, 17 Dec 2009 00:31:39 +0000 (00:31 +0000)]
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

Test was refactored by r52226, and now it passes.

* platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevised version of the test for:
enrica@apple.com [Thu, 17 Dec 2009 00:15:52 +0000 (00:15 +0000)]
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Adele Peterson.

* editing/selection/empty-cell-right-click-expected.txt:
* editing/selection/empty-cell-right-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Thu, 17 Dec 2009 00:07:03 +0000 (00:07 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

* platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Dec 2009 00:03:49 +0000 (00:03 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=32637
        [V8] Generate most named property getters.

        Covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 16 Dec 2009 23:52:38 +0000 (23:52 +0000)]
2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement combobox delegate for Qt
        https://bugs.webkit.org/show_bug.cgi?id=32550

        Abstract popup menu factory.

        A static method from QtAbstractPopupMenu is used to create its instances. If a factory
        has been suplied to class QtAbstractPopupMenu the factory will be used to create the
        objects. If not an instance of QtFallbackPopupMenu will be created.

        The objective is to make it easy to replace the combobox popup at WebCore layer providing
        support to the combobox popup delegation API. Future patches will make it possible to
        replace the combobox popup at WebKit layer.

        No behavior changes.

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::setFactory):
        (WebCore::QtAbstractWebPopup::create):
        * platform/qt/QtAbstractWebPopup.h:
        * platform/qt/QtFallbackWebPopup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Disable debug variants of WebKit frameworks.
mrowe@apple.com [Wed, 16 Dec 2009 23:39:35 +0000 (23:39 +0000)]
Build fix.  Disable debug variants of WebKit frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 22:19:54 +0000 (22:19 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Generalize commit-queue recent status page for all queues
        https://bugs.webkit.org/show_bug.cgi?id=32633

        * QueueStatusServer/index.html:
         - Generalize to support other queues.
        * QueueStatusServer/queue_status.py:
         - Generalize MainPage to support other queues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Right clicking in a table cell creates a selection that extends into the...
enrica@apple.com [Wed, 16 Dec 2009 22:02:03 +0000 (22:02 +0000)]
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

Avoid extending the selection to the next cell if we start from an empty cell.

Test: editing/selection/empty-cell-right-click.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
* editing/htmlediting.h: Added isEmptyTableCell declaration.

LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

* editing/selection/empty-cell-right-click-expected.txt: Added.
* editing/selection/empty-cell-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 21:56:54 +0000 (21:56 +0000)]
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        The previous test only checked if feMerge works on empty node
        without a last effect. In this case we get a source image and
        everything works fine. This test also covers the case if there
        is a last effect.

        * platform/mac/svg/custom/empty-merge-expected.checksum:
        * platform/mac/svg/custom/empty-merge-expected.png:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * svg/custom/empty-merge.svg:
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        SVGFEMergeElement only stored pointers to all effects of it's nodes
        in a list. But it should store the RefPtr otherwise the effects get
        dereferenced and WebKit crashes.
        I also made a short clean-up in SVGFilterBuilder. No change in
        functionality.

        Test: I updated svg/custom/empty-merge.svg to cover this problem.

        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::FEMerge):
        (WebCore::FEMerge::create):
        (WebCore::FEMerge::mergeInputs):
        (WebCore::FEMerge::setMergeInputs):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 21:24:08 +0000 (21:24 +0000)]
2009-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Early warning system server should display output as UTF-8.

        https://bugs.webkit.org/show_bug.cgi?id=32625

        * QueueStatusServer/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <http://webkit.org/b/32568>.
bweinstein@apple.com [Wed, 16 Dec 2009 21:17:08 +0000 (21:17 +0000)]
Part of <http://webkit.org/b/32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Timothy Hatcher.

Add a context menu entry in the console to clear the console. This
is only shown when there is no user selection of text, because if
there is selection of the text, then we want to give the user the Copy +
Spell Check context menu that they are used to.

* English.lproj/localizedStrings.js: Added "Clear Console".
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 21:17:00 +0000 (21:17 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Add error handling to the early warning system
        https://bugs.webkit.org/show_bug.cgi?id=32594

        This should be the last step in making the EWS operational.  When we
        have a build error, we post the log to QueueStatusServer and add a link
        to the bug.

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/executive.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Wed, 16 Dec 2009 21:15:34 +0000 (21:15 +0000)]
2009-12-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        Deprecate the old loading signals load-started, load-committed,
        load-finished, load-progress-changed and change unit tests to use
        load-status instead.

        * tests/testmimehandling.c:
        (idle_quit_loop_cb):
        (test_mime_type): use notify::load-status
        * tests/testwebdatasource.c:
        (notify_load_status_unreachable_cb):
        (notify_load_status_cb):
        (test_webkit_web_data_source):
        (test_webkit_web_data_source_unreachable_uri): Remove uses of
        g_main_loop_is_running. It's an error if the loop is wrongly terminated.
        * tests/testwebresource.c:
        (notify_load_status_cb):
        (test_web_resource_loading):
        (notify_load_status_sub_cb):
        (test_web_resource_sub_resource_loading): use notify::load-status
        * tests/testwebview.c:
        (idle_quit_loop_cb):
        (test_webkit_web_view_icon_uri):
        * tests/testwindow.c:
        (notify_load_status_cb):
        (test_webkit_window_scrollbar_policy): use notify::load-status
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init): Deprecate old load signals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
bweinstein@apple.com [Wed, 16 Dec 2009 20:59:04 +0000 (20:59 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching
from / to resources panel.

Reviewed by Pavel Feldman.

Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
to cover the scope bar.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Dec 2009 20:14:34 +0000 (20:14 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Switch all indexers to be generated.
        https://bugs.webkit.org/show_bug.cgi?id=32569

        Covered by existing tests.

        * WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
            as they are now generated.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
            FileList, and DataGridColumnList templates.
        * bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
        * bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
        * bindings/v8/custom/V8FileListCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 anton muhin <antonm@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 19:34:00 +0000 (19:34 +0000)]
2009-12-16  anton muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
        https://bugs.webkit.org/show_bug.cgi?id=32617

        * dom/Node.cpp:
        (WebCore::Node::dumpStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Dec 2009 19:25:09 +0000 (19:25 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] There is no such thing as HTMLSelectElementCollection.
        https://bugs.webkit.org/show_bug.cgi?id=32616

        Refactoring, covered by existing tests.

        * WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
        * bindings/v8/V8Collection.h: Removed one-off template.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
            to HTMLSelectElement.
        * bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
        * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
            V8HTMLSelectElementCollectionCustom.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing bug number in ChangeLog
kov@webkit.org [Wed, 16 Dec 2009 19:20:25 +0000 (19:20 +0000)]
Fixing bug number in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBrought this file up to date, sans review.
sullivan@apple.com [Wed, 16 Dec 2009 19:15:54 +0000 (19:15 +0000)]
Brought this file up to date, sans review.

* StringsNotToBeLocalized.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dan Winship <danw@gnome.org>
eric@webkit.org [Wed, 16 Dec 2009 19:14:36 +0000 (19:14 +0000)]
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * configure.ac: require libsoup 2.28.2 for SoupContentDecoder
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp): Don't force "Accept-Encoding: identity" any
        more
2009-12-16  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha Silva.

        Content-Encoding support

        https://bugs.webkit.org/show_bug.cgi?id=522772

        * webkit/webkitprivate.cpp:
        (webkit_init): add a SoupContentDecoder feature to the session

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Wed, 16 Dec 2009 19:03:50 +0000 (19:03 +0000)]
2009-12-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        Take into account favicon.ico in the webresource test.

        * tests/testwebresource.c:
        (test_web_resource_sub_resource_loading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Benjamin Otte <otte@gnome.org>
eric@webkit.org [Wed, 16 Dec 2009 19:00:25 +0000 (19:00 +0000)]
2009-12-16  Benjamin Otte  <otte@gnome.org>

        Reviewed by Darin Adler.

        Get rid of the phase argument to Image::drawPattern.
        https://bugs.webkit.org/show_bug.cgi?id=31187

        The argument can be expressed equally well as part of the
        patternTransform. All backends but the Qt one did exactly that
        manually anyway.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Kenneth Russell <kbr@google.com>
eric@webkit.org [Wed, 16 Dec 2009 18:50:55 +0000 (18:50 +0000)]
2009-12-16  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Performance problems with index validation code for drawElements
        https://bugs.webkit.org/show_bug.cgi?id=32466

        Added a cache of the maximum index for each element type to
        WebGLBuffer, querying it before iterating through the indices in
        the client-side copy of the buffer's data. Hoisted checks of the
        size of the element array itself into validateElementArraySize to
        avoid duplicating code.

        The performance improvement has been measured with manual tests.
        Existing layout tests cover the index validation functionality
        and continue to pass as before.

        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::WebGLBuffer):
        (WebCore::WebGLBuffer::associateBufferData):
        (WebCore::WebGLBuffer::associateBufferSubData):
        (WebCore::WebGLBuffer::getCachedMaxIndex):
        (WebCore::WebGLBuffer::setCachedMaxIndex):
        (WebCore::WebGLBuffer::clearCachedMaxIndices):
        * html/canvas/WebGLBuffer.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateElementArraySize):
        (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
        (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
        (WebCore::WebGLRenderingContext::validateRenderingState):
        (WebCore::WebGLRenderingContext::drawElements):
        * html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Zelidrag Hornung <zelidrag@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 18:43:27 +0000 (18:43 +0000)]
2009-12-16  Zelidrag Hornung  <zelidrag@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32261
        Added ability to separate the autocomplete suggestion previewing from
        the actual accepting of the suggested value in HTMLInputElement.
        This element (it's single line text incarnation) can now
        be put in suggestion mode where renderer might display the suggested
        value without making it automatically exposed to JavaScript.

        No new tests. This new methods are not exposed yet. It's use will be
        platform specific. PopupMenu and Chromium specific changes will be
        separated based on Darin Adler's comments.

        * dom/InputElement.h:
        (WebCore::InputElementData::suggestedValue):
        (WebCore::InputElementData::setSuggestedValue):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::suggestedValue):
        (WebCore::HTMLInputElement::setSuggestedValue):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setValueFromRenderer):
        * html/HTMLInputElement.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::suggestedValue):
        * wml/WMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 16 Dec 2009 18:24:59 +0000 (18:24 +0000)]
2009-12-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Make Elements tree, properties section and resources
        view monospace.

        https://bugs.webkit.org/show_bug.cgi?id=32609

        * inspector/front-end/ElementsPanel.js:
        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 18:12:55 +0000 (18:12 +0000)]
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
        https://bugs.webkit.org/show_bug.cgi?id=32575

        Check if the GraphicsContex get adjusted, if the source rect is clipped
        to the filter rect.

        * platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
        * platform/mac/svg/filters/filter-source-position-expected.png: Added.
        * platform/mac/svg/filters/filter-source-position-expected.txt: Added.
        * svg/filters/filter-source-position.svg: Added.
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
        https://bugs.webkit.org/show_bug.cgi?id=32575

        On SVG Filters, the rest of the source graphic gets clipped to the filter
        rest. This helps us to minimize the size of intermediate ImageBuffers. If
        the position moves to the right or to the bottom, we have to adjust the
        GraphicContext of this intermediate ImageBuffer.
        This patch fixes the adjustment of the context, according to the clipping.

        Test: svg/filters/filter-source-position.svg

        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::prepareFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVis...
enrica@apple.com [Wed, 16 Dec 2009 17:59:58 +0000 (17:59 +0000)]
CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
<rdar://problem/7467108>
https://bugs.webkit.org/show_bug.cgi?id=32590

Reviewed by Adele Peterson.

WebCore:

If the element is a button there is no need to look at the children to calculate the caret position.

Test: editing/selection/button-right-click.html

* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
when starting from a button element.

LayoutTests:

* editing/selection/button-right-click-expected.txt: Added.
* editing/selection/button-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Xan Lopez.
kov@webkit.org [Wed, 16 Dec 2009 17:37:03 +0000 (17:37 +0000)]
Rubber-stamped by Xan Lopez.

Add tab_key_cycles_through_elements to copies of
WebKitWebSettings.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 16 Dec 2009 17:27:09 +0000 (17:27 +0000)]
2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement combobox delegate for Qt
        https://bugs.webkit.org/show_bug.cgi?id=32550

        Refactoring of class QWebPopup.

        Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
        Both new classes are now in corresponding files and files QWebPopup.* have been removed.

        Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
        in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
        public QtWebKit combobox popup delegation API.

        Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
        It needs to be improved to provide standard features that are missing like style or indentation.

        No behavior changes.

        * WebCore.pro:
        * platform/PopupMenu.h:
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        * platform/qt/QWebPopup.cpp: Removed.
        * platform/qt/QWebPopup.h: Removed.
        * platform/qt/QtAbstractWebPopup.cpp: Added.
        (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::client):
        * platform/qt/QtAbstractWebPopup.h: Added.
        * platform/qt/QtFallbackWebPopup.cpp: Added.
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):
        (WebCore::QtFallbackWebPopup::showPopup):
        (WebCore::QtFallbackWebPopup::hidePopup):
        (WebCore::QtFallbackWebPopup::activeChanged):
        * platform/qt/QtFallbackWebPopup.h: Added.
        (WebCore::QtFallbackWebPopup::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Wed, 16 Dec 2009 17:04:39 +0000 (17:04 +0000)]
2009-12-16  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] webkit_web_navigation_action_get_button() documentation
        https://bugs.webkit.org/show_bug.cgi?id=25555

        Small documentation improvement for webkit_web_navigation_action_get_button.

        * webkit/webkitwebnavigationaction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Wed, 16 Dec 2009 14:21:58 +0000 (14:21 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31332

[Qt] After http://trac.webkit.org/changeset/52192
there are a failing and a timeouter test.

* platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
* platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Wed, 16 Dec 2009 10:42:06 +0000 (10:42 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
of DumpRenderTree. The previously wrong expected file updated.

* platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping a new test, and a test that fails only on the release bot,
kov@webkit.org [Wed, 16 Dec 2009 10:25:52 +0000 (10:25 +0000)]
Skipping a new test, and a test that fails only on the release bot,
apparently because of rouding errors.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools: Fix crash with tests that use custom font faces.
hausmann@webkit.org [Wed, 16 Dec 2009 10:06:45 +0000 (10:06 +0000)]
WebKitTools: Fix crash with tests that use custom font faces.

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=32600

In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
that custom font faces between tests don't influence each other. Calling this
function in Qt however also invalidates all existing handles with QFontDatabase.

In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
which implies a call to WebCore::FontCache::fontCache()->invalidate().

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):

LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.

Reviewed by Holger Freyther.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 16 Dec 2009 10:05:29 +0000 (10:05 +0000)]
2009-12-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: beautify HTTP info section.

        https://bugs.webkit.org/show_bug.cgi?id=32583

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype._refreshURL):
        (WebInspector.ResourceView.prototype._refreshHTTPInformation):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Wed, 16 Dec 2009 09:54:34 +0000 (09:54 +0000)]
2009-12-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Maintain button state between mouse events.

        This allows eventSender to generate drag events.

        https://bugs.webkit.org/show_bug.cgi?id=32601

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r52085, because it causes crashes on media tests in the release
kov@webkit.org [Wed, 16 Dec 2009 09:52:25 +0000 (09:52 +0000)]
Revert r52085, because it causes crashes on media tests in the release
bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/css/font-face-unused-source-loaded.html crashes
ossy@webkit.org [Wed, 16 Dec 2009 08:56:37 +0000 (08:56 +0000)]
[Qt] fast/css/font-face-unused-source-loaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=32600

Reviewed by Simon Hausmann.

The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.

* platform/qt/Skipped: fast/css/font-face-multiple-families.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com>
tkent@chromium.org [Wed, 16 Dec 2009 07:54:20 +0000 (07:54 +0000)]
2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Levin.

        Code clean-up in check-webkit-style as described below.
        The only functional changes are minor improvements to the
        script's help output.

        https://bugs.webkit.org/show_bug.cgi?id=32487

        * Scripts/check-webkit-style:
          - Added the module docstring from cpp_style.py.
          - Improved wording of the --help output and added some of the
            default values as substitution strings.
          - Called cpp_style.exit_with_usage instead of sys.stderr.write
            in main function.
          - Made changes caused by changes to cpp_style.py.

        * Scripts/modules/cpp_style.py:
          - Removed module docstring, as well as redundant _USAGE string
            and main() function obsoleted by check-webkit-style.
          - Moved specification of default script values from within a
            function definition to global variables.
          - Moved the default webkit filter rules to be near the other
            global variables.
          - Renamed "FILTER" global variables to "FILTER_RULES" to
            establish unambiguous terminology.
          - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
          - Changed _STYLE_CATEGORIES from a string to a list.
          - Added default webkit filter rules to --filter= output.
          - Renamed "print_" methods to "exit_with_" since they exist
            and added a temporary display_help parameter.
          - Added a temporary display_help parameter to parse_arguments.

        * Scripts/modules/cpp_style_unittest.py:
          - Made changes caused by changes to cpp_style.py.
          - Lower-cased ErrorCollector's ERROR_CATEGORIES instance
            variables since they are not global.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for the style-queue.
abarth@webkit.org [Wed, 16 Dec 2009 07:21:56 +0000 (07:21 +0000)]
Unreviewed fix for the style-queue.
Typo: _updates_status -> _update_status

We need to improve our testing infrastructure for the queues.

* Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for the style-queue. I suspect this is a recent
abarth@webkit.org [Wed, 16 Dec 2009 07:05:06 +0000 (07:05 +0000)]
Unreviewed fix for the style-queue.  I suspect this is a recent
regression from Eric's change below.

* Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 16 Dec 2009 03:12:36 +0000 (03:12 +0000)]
2009-12-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adele Peterson.

        Make SunSpider version more prominent in the title
        https://bugs.webkit.org/show_bug.cgi?id=32574

        * hosted/sunspider.html:
        * hosted/versions.html:
        * resources/driver-TEMPLATE.html:
        * resources/results-TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 16 Dec 2009 02:26:21 +0000 (02:26 +0000)]
2009-12-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Make SunSpider refuse to compare results across content versions
        https://bugs.webkit.org/show_bug.cgi?id=32573

        The results URL now includes a version indicator, and compare mode
        will refuse to compare between versions.

        * resources/driver-TEMPLATE.html:
        * resources/results-TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix crash when encountering illegal HTML within a continuation inside <ruby>.
rolandsteiner@chromium.org [Wed, 16 Dec 2009 02:02:12 +0000 (02:02 +0000)]
Fix crash when encountering illegal HTML within a continuation inside <ruby>.
(https://bugs.webkit.org/show_bug.cgi?id=32316)

Reviewed by Adam Barth.

Avoid having the anonymous blocks utilized in the ruby renderers being
re-used as continuation blocks.
Avoid having ruby runs collected as "leftover blocks".

Test: fast/ruby/ruby-illegal.html

WebCore:

* rendering/RenderRuby.h:
(WebCore::RenderRubyAsInline::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsInline::isRuby): made private
(WebCore::RenderRubyAsInline::renderName): made private
(WebCore::RenderRubyAsInline::createsAnonymousWrapper): return true
(WebCore::RenderRubyAsBlock::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsBlock::isRuby): made private
(WebCore::RenderRubyAsBlock::renderName): made private
(WebCore::RenderRubyAsBlock::createsAnonymousWrapper): return true
* rendering/RenderRubyRun.h:
(WebCore::RenderRubyRun::removeLeftoverAnonymousBlock): avoid
(WebCore::RenderRubyRun::isRubyRun): made private
(WebCore::RenderRubyRun::renderName): made private
(WebCore::RenderRubyRun::createsAnonymousWrapper): return true

LayoutTests:

* fast/ruby/ruby-illegal-expected.txt: Added.
* fast/ruby/ruby-illegal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 00:51:47 +0000 (00:51 +0000)]
2009-12-15  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        update-webkit-chromium to auto-install gclient

        https://bugs.webkit.org/show_bug.cgi?id=32587

        * Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=32498
ggaren@apple.com [Wed, 16 Dec 2009 00:04:50 +0000 (00:04 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=32498
<rdar://problem/7471495>
REGRESSION(r51978-r52039): AJAX "Mark This Forum Read" function no longer
works

Reviewed by Sam "r=me" Weinig.

Fixed a tyop.

* runtime/Operations.h:
(JSC::jsAdd): Use the '&&' operator, not the ',' operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd delay load of QuartzCore.dll and QuartzCoreInterface.dll to fix Windows build
cmarrin@apple.com [Tue, 15 Dec 2009 23:53:24 +0000 (23:53 +0000)]
Add delay load of QuartzCore.dll and QuartzCoreInterface.dll to fix Windows build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 23:47:58 +0000 (23:47 +0000)]
2009-12-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
        https://bugs.webkit.org/show_bug.cgi?id=32546

        You can see an example of this working in:
        https://bugs.webkit.org/show_bug.cgi?id=32585#c3

        * QueueStatusServer/queue_status.py:
         - Output the id of the newly created status.
        * Scripts/modules/commands/queues.py:
         - Tweak the commit-queue logging to include a full status link.
        * Scripts/modules/statusbot.py:
         - update_status should return the newly created status id.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the windows build: don't export this inlined function.
ggaren@apple.com [Tue, 15 Dec 2009 23:44:37 +0000 (23:44 +0000)]
Try to fix the windows build: don't export this inlined function.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInlined JSCell's operator new.
ggaren@apple.com [Tue, 15 Dec 2009 23:33:40 +0000 (23:33 +0000)]
Inlined JSCell's operator new.

Reviewed by Beth Dakin.

3.7% speedup on bench-allocate-nonretained.js.

* JavaScriptCore.exp:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::operator new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 15 Dec 2009 23:02:11 +0000 (23:02 +0000)]
2009-12-15  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Adler.

        Rename skipCanLoadCheck to skipSecurityCheck in a bunch of places in WebCore/loader.

        https://bugs.webkit.org/show_bug.cgi?id=32529

        * loader/Cache.cpp:
        (WebCore::Cache::requestUserCSSStyleSheet):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::load):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::load):
        * loader/CachedResource.h:
        (WebCore::CachedResource::load):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
        (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
        (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
        (WebCore::DocumentThreadableLoader::preflightSuccess):
        (WebCore::DocumentThreadableLoader::loadRequest):
        * loader/DocumentThreadableLoader.h:
        * loader/FrameLoaderTypes.h:
        (WebCore::):
        * loader/Request.cpp:
        (WebCore::Request::Request):
        * loader/Request.h:
        (WebCore::Request::shouldDoSecurityCheck):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * loader/SubresourceLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::load):
        (WebCore::Loader::Host::servePendingRequests):
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved the number heap, replacing it with a one-item free list for
ggaren@apple.com [Tue, 15 Dec 2009 22:40:00 +0000 (22:40 +0000)]
Removed the number heap, replacing it with a one-item free list for
numbers, taking advantage of the fact that two number cells fit inside
the space for one regular cell, and number cells don't require destruction.

Reviewed by Oliver Hunt.

SunSpider says 1.6% faster in JSVALUE32 mode (the only mode that
heap-allocates numbers).

SunSpider says 1.1% faster in JSVALUE32_64 mode. v8 says 0.8% faster
in JSVALUE32_64 mode. 10% speedup on bench-alloc-nonretained.js. 6%
speedup on bench-alloc-retained.js.

There's a lot of formulaic change in this patch, but not much substance.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlockPtr):
(JSC::Heap::freeBlocks):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
(JSC::Heap::sweep):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics):
(JSC::Heap::isBusy):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
* runtime/Collector.h:
(JSC::): Removed all code pertaining to the number heap, and changed all
heap template functions and classes to non-template functions and classes.

(JSC::Heap::allocateNumber): A new optimization to replace the number
heap: allocate half-sized number cells in pairs, returning the first
cell and caching the second cell for the next allocation.

* runtime/CollectorHeapIterator.h:
(JSC::LiveObjectIterator::LiveObjectIterator):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::DeadObjectIterator):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::ObjectIterator):
(JSC::ObjectIterator::operator++):
* runtime/JSCell.h:
(JSC::JSCell::isNumber): Removed all code pertaining to the number heap,
and changed all heap template functions and classes to non-template functions
and classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoupdated WebGL demos to latest spec
cmarrin@apple.com [Tue, 15 Dec 2009 22:18:15 +0000 (22:18 +0000)]
updated WebGL demos to latest spec

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
mitz@apple.com [Tue, 15 Dec 2009 22:12:50 +0000 (22:12 +0000)]
<rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
https://bugs.webkit.org/show_bug.cgi?id=32257

Reviewed by Darin Adler.

WebCore:

Test: fast/css/font-face-unused-source-loaded.html

The loading of a font resource caused a CSSFontFace that had the resource in one of its
sources, but wasn’t using it (due to using an earlier source) to invalidate its
CSSSegmentedFontFaces. This caused FontData for the active source (the one that did not just
finish loading) to be deleted, but that went unnoticed by Font::operator==(), since the
corresponding FontFallbackLists were not in the loading state. The fix is for CSSFontFace to
ignore loads from unused sources.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Bail out if the loaded source is not the active source.
(WebCore::CSSFontFace::getFontData): Set m_activeSource to the source that supplied the
    FontData.
* css/CSSFontFace.h:
(WebCore::CSSFontFace::CSSFontFace): Initialize m_activeSource.

LayoutTests:

* fast/css/font-face-unused-source-loaded-expected.txt: Added.
* fast/css/font-face-unused-source-loaded.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGetting rid of out of date WebGL tests
cmarrin@apple.com [Tue, 15 Dec 2009 22:12:46 +0000 (22:12 +0000)]
Getting rid of out of date WebGL tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Tue, 15 Dec 2009 22:07:49 +0000 (22:07 +0000)]
2009-12-15  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Cannot load flash files from a local file.
        https://bugs.webkit.org/show_bug.cgi?id=32572

        When loading the main resource and its mime type is application/octet-stream,
        use the file extenstion to check if it is a supported plugin.

        No new tests were added since any existing swf file can be used as a manual test.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveResponse):
        * loader/MainResourceLoader.h:
        * plugins/PluginDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 21:55:05 +0000 (21:55 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for WeakGCMap class
        https://bugs.webkit.org/show_bug.cgi?id=32547

        Inherits WeakGCMap from FastAllocBase because it is instantiated by
        'new' at: WebCore/dom/Document.cpp:512.

        * runtime/WeakGCMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
bweinstein@apple.com [Tue, 15 Dec 2009 21:52:40 +0000 (21:52 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
REGRESSION: Tips are not shown for resources anymore.

Reviewed by Timothy Hatcher.

As discussed in the bug, Tips are not coming back, and the feature
will be moved to the audits panel. This patch is to remove the Tips
code and the resources that it needed.

* WebCore.gypi: Removed tips files.
* inspector/front-end/Images/tipBalloon.png: Removed.
* inspector/front-end/Images/tipBalloonBottom.png: Removed.
* inspector/front-end/Images/tipIcon.png: Removed.
* inspector/front-end/Images/tipIconPressed.png: Removed.
* inspector/front-end/Resource.js: Removed tips code.
(WebInspector.Resource.prototype.set finished):
* inspector/front-end/WebKit.qrc: Removed tips files.
* inspector/front-end/inspector.css: Removes tips style rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 15 Dec 2009 21:44:52 +0000 (21:44 +0000)]
2009-12-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Display request headers for main resource
        having redirects.

        https://bugs.webkit.org/show_bug.cgi?id=32577

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::appendRedirect):
        (WebCore::InspectorResource::createCached):
        (WebCore::InspectorResource::updateRequest):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
bweinstein@apple.com [Tue, 15 Dec 2009 21:35:56 +0000 (21:35 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
Web Inspector: No Need for ?="" now that we have context menus.

Reviewed by Timothy Hatcher.

Remove the toggleNewAttributeButton function and callers to it, as
we don't need this behavior anymore, now that we have context menus.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.set hovered):
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
(WebInspector.ElementsTreeElement.prototype._startEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed typos
mitz@apple.com [Tue, 15 Dec 2009 20:15:46 +0000 (20:15 +0000)]
Fixed typos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 15 Dec 2009 19:55:33 +0000 (19:55 +0000)]
2009-12-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        [V8] Generate trivial named property getters.
        https://bugs.webkit.org/show_bug.cgi?id=32562

        Covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationNamedPropertyGetter.
        * bindings/v8/V8Collection.h:
        (WebCore::getNamedPropertyOfCollection): Fixed a booboo by using AtomicString like we're supposed to.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed code that's now generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <http://webkit.org/b/32568>.
bweinstein@apple.com [Tue, 15 Dec 2009 19:51:27 +0000 (19:51 +0000)]
Part of <http://webkit.org/b/32568>.
New Web Inspector: The Context Menu should be used in more places.

Reviewed by Timothy Hatcher.

Add support for context menu entries for editing and deleting elements
in the datagrid. This gives support to deleting cookies, and editing and
deleting session storage and local storage.

* English.lproj/localizedStrings.js: Added "Edit" and "Add New" entries (delete was already there)
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid): Added context menu listener.
(WebInspector.DataGrid.prototype._contextMenuInDataTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Kenneth Russell <kbr@google.com>
eric@webkit.org [Tue, 15 Dec 2009 19:08:14 +0000 (19:08 +0000)]
2009-12-15  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Don't allow default framebuffer to be mutated
        https://bugs.webkit.org/show_bug.cgi?id=32391

        * fast/canvas/webgl/error-reporting-expected.txt:
        * fast/canvas/webgl/null-object-behaviour-expected.txt:
        * fast/canvas/webgl/script-tests/error-reporting.js:
        * fast/canvas/webgl/script-tests/null-object-behaviour.js:
2009-12-15  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Don't allow default framebuffer to be mutated
        https://bugs.webkit.org/show_bug.cgi?id=32391

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
        (WebCore::WebGLRenderingContext::framebufferTexture2D):
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::bindFramebuffer):
2009-12-15  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Don't allow default framebuffer to be mutated
        https://bugs.webkit.org/show_bug.cgi?id=32391

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::reshape):
        (WebCore::GraphicsContext3DInternal::beginPaint):
        (WebCore::GraphicsContext3DInternal::bindFramebuffer):
        (WebCore::GraphicsContext3D::bindFramebuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 18:50:54 +0000 (18:50 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for FontPlatformDataCacheKey class
        https://bugs.webkit.org/show_bug.cgi?id=32552

        Inherits the following struct from FastAllocBase because it is instantiated by 'new':

        struct name                     - instantiated at: WebCore/'location'
        struct FontPlatformDataCacheKey - platform/graphics/FontCache.cpp:118

        * platform/graphics/FontCache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 18:43:09 +0000 (18:43 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for dtoa's P5Node struct
        https://bugs.webkit.org/show_bug.cgi?id=32544

        Inherits P5Node struct from Noncopyable because it is instantiated by
        'new' at wtf/dtoa.cpp:588 and don't need to be copyable.

        * wtf/dtoa.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 15 Dec 2009 18:14:45 +0000 (18:14 +0000)]
2009-12-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        [Chromium] Add TreeGridRole to catch up with
        http://trac.webkit.org/changeset/52159.

        * public/WebAccessibilityRole.h:
        (WebKit::): Added WebAccessibilityRoleTreeGrid.
        * src/AssertMatchingEnums.cpp: Added matching compile assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
jianli@chromium.org [Tue, 15 Dec 2009 18:13:36 +0000 (18:13 +0000)]
Bug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
https://bugs.webkit.org/show_bug.cgi?id=31090

Reviewed by Dmitry Titov.

The proposal to whatwg can be found here:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022118.html

WebCore:

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::setData):

WebKit/chromium:

* public/WebDragData.h:
* src/WebDragData.cpp:
(WebKit::WebDragData::downloadURL):
(WebKit::WebDragData::setDownloadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWAI-ARIA: implement treegrid
cfleizach@apple.com [Tue, 15 Dec 2009 18:07:26 +0000 (18:07 +0000)]
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-treegrid.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
* accessibility/AccessibilityARIAGridRow.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isARIATreeGridRow):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

LayoutTests:

* platform/mac-leopard/Skipped:
* platform/mac/accessibility/aria-treegrid-expected.txt: Added.
* platform/mac/accessibility/aria-treegrid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 17:09:50 +0000 (17:09 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for EmptyEditorClient and EmptyInspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=32557

        Inherits the following classes from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class name                 - instantiated at: WebCore/'location'
        class EmptyEditorClient    - svg/graphics/SVGImage.cpp:230
        class EmptyInspectorClient - svg/graphics/SVGImage.cpp:241

        * loader/EmptyClients.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 17:02:33 +0000 (17:02 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for WebCore/inspector directory's classes
        https://bugs.webkit.org/show_bug.cgi?id=32556

        Inherits the following class from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class name                   - instantiated at: WebCore/'location'
        class InspectorFrontend      - inspector/InspectorController.cpp:538
        class InspectorTimelineAgent - inspector/InspectorController.cpp:1097

        * inspector/InspectorFrontend.h:
        * inspector/InspectorTimelineAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 16:54:49 +0000 (16:54 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for WebCore/platform/network directory's classes
        https://bugs.webkit.org/show_bug.cgi?id=32553

        Inherits the following class from Noncopyable because it is instantiated
        by 'new' and no need to be copyable:

        class/struct name                      - instantiated at: WebCore/'location'

        struct CrossThreadResourceResponseData - platform/network/ResourceResponseBase.cpp:109

        Inherits the following classes from FastAllocBase because these are
        instantiated by 'new':

        class ResourceResponseBase - (its child class) platform/network/ResourceResponseBase.cpp:90
        class ResourceRequestBase  - (its child class) loader/DocumentThreadableLoader.cpp:88

        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceResponseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 16:44:08 +0000 (16:44 +0000)]
2009-12-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
        https://bugs.webkit.org/show_bug.cgi?id=32549

        Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
        classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:

        class/struct name              - instantiated at: WebCore/'location'

        AnimationControllerPrivate     - page/animation/AnimationController.cpp:439
        FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464

        * page/animation/AnimationBase.cpp:
        * page/animation/AnimationControllerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 15 Dec 2009 16:36:24 +0000 (16:36 +0000)]
2009-12-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Do not lose HTTP redirect information, display it
        in the Resources Panel.

        https://bugs.webkit.org/show_bug.cgi?id=32551

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::appendRedirect):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::releaseScriptObject):
        (WebCore::InspectorResource::type):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::):
        (WebCore::InspectorResource::Changes::setAll):
        * inspector/front-end/inspector.js:
        (WebInspector._addResource):
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
zecke@webkit.org [Tue, 15 Dec 2009 16:17:56 +0000 (16:17 +0000)]
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler

https://bugs.webkit.org/show_bug.cgi?id=32113

For Qt versions prior to 4.6.1 we will need to use QueuedConnection
for the signal and slot connection to avoid running into a bug in.

Add a comment that we want to remove one signal to forward
queued items when moving our minimum requirements.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix JavaScript prompt behavior for empty/null strings.
zecke@webkit.org [Tue, 15 Dec 2009 16:17:46 +0000 (16:17 +0000)]
[Qt] Fix JavaScript prompt behavior for empty/null strings.

https://bugs.webkit.org/show_bug.cgi?id=30914

The patch is based on the work done by Gupta Manish.

In the default implementation of the JavaScript prompt
we are using a QInputDialog to get the text and this has
one quirk with regard to not entering any text.

In other WebKit ports and in Firefox an empty string is
returned but in the Qt case it is a null string.

Change the API documentation in QWebPage to mention we want to
have a non null string but do the fixup in the ChromeClientQt
to support existing code.

WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::javaScriptPrompt): Change API documentation
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fixup null QString

WebCore:
* manual-tests/qt/java-script-prompt.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Tue, 15 Dec 2009 16:13:51 +0000 (16:13 +0000)]
2009-12-15  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Moving list populate methods from PopupMenuQt to QWebPopup.

        In preparation to future implementation of a delegation API for the combobox.

        * platform/PopupMenu.h:
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        * platform/qt/QWebPopup.cpp:
        (WebCore::QWebPopup::show):
        (WebCore::QWebPopup::populate):
        * platform/qt/QWebPopup.h:
        (WebCore::QWebPopup::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Rename Qt DRT components to match other ports' naming convention and to be more...
ossy@webkit.org [Tue, 15 Dec 2009 14:18:47 +0000 (14:18 +0000)]
[Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-15
Reviewed by Tor Arne Vestbø.

* DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
* DumpRenderTree/qt/DumpRenderTree.h: Removed.
* DumpRenderTree/qt/DumpRenderTree.pro: Updated.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
* DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
* DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
(GCController::GCController):
* DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/WorkQueueItem.h: Removed.
* DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
* DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
* DumpRenderTree/qt/jsobjects.cpp: Removed.
* DumpRenderTree/qt/jsobjects.h: Removed.
* DumpRenderTree/qt/main.cpp: Updated includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 15 Dec 2009 11:29:08 +0000 (11:29 +0000)]
2009-12-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Extract WebInspector.Section from WebInspector.PropertiesSection.
        https://bugs.webkit.org/show_bug.cgi?id=32523

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection):
        * inspector/front-end/Section.js: Added.
        (WebInspector.Section):
        (WebInspector.Section.prototype.get title):
        (WebInspector.Section.prototype.set title):
        (WebInspector.Section.prototype.get subtitle):
        (WebInspector.Section.prototype.set subtitle):
        (WebInspector.Section.prototype.get expanded):
        (WebInspector.Section.prototype.set expanded):
        (WebInspector.Section.prototype.get populated):
        (WebInspector.Section.prototype.set populated):
        (WebInspector.Section.prototype.expand):
        (WebInspector.Section.prototype.collapse):
        (WebInspector.Section.prototype.toggleExpanded):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 15 Dec 2009 11:12:22 +0000 (11:12 +0000)]
2009-12-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        We have two mark-fixed commands
        https://bugs.webkit.org/show_bug.cgi?id=32073

        * Scripts/mark-bug-fixed: Removed.
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 10:39:10 +0000 (10:39 +0000)]
2009-12-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
        https://bugs.webkit.org/show_bug.cgi?id=28286

        * QueueStatusServer/index.html:
         - Show [results] links if a results log was uploaded.
        * QueueStatusServer/queue_status.py:
         - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
        * Scripts/modules/commands/queues.py:
         - Post to the status bot when a patch fails and include the failure log as a results file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 10:18:15 +0000 (10:18 +0000)]
2009-12-15  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52140.
        http://trac.webkit.org/changeset/52140
        https://bugs.webkit.org/show_bug.cgi?id=31299

        The commit broke the Leopard bots and unfortunately
        Chris wasn't around to fix them, so I'm rolling the change
        out after 3 hours so that the bots can roll green again. :)

        * platform/mac/accessibility/aria-treegrid-expected.txt: Removed.
        * platform/mac/accessibility/aria-treegrid.html: Removed.
2009-12-15  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52140.
        http://trac.webkit.org/changeset/52140
        https://bugs.webkit.org/show_bug.cgi?id=31299

        The commit broke the Leopard bots and unfortunately
        Chris wasn't around to fix them, so I'm rolling the change
        out after 3 hours so that the bots can roll green again. :)

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::getOrCreate):
        * accessibility/AccessibilityARIAGrid.h:
        * accessibility/AccessibilityARIAGridRow.cpp:
        * accessibility/AccessibilityARIAGridRow.h:
        * accessibility/AccessibilityObject.cpp:
        (WebCore::createARIARoleMap):
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isMultiSelect):
        (WebCore::AccessibilityRenderObject::setIsExpanded):
        (WebCore::AccessibilityRenderObject::setSelectedRows):
        (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
        (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
        (WebCore::AccessibilityRenderObject::selectedChildren):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilityTable.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 15 Dec 2009 10:07:17 +0000 (10:07 +0000)]
2009-12-15  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queue sub-commands need --status-host so they can report status
        https://bugs.webkit.org/show_bug.cgi?id=32313

        Make --status-bot a global option and make
        run_bugzilla_tool pass --status-bot to sub-commands.

        * Scripts/bugzilla-tool:
         - Rename _status to status_bot and make it non-lazy.
        * Scripts/modules/commands/queues.py:
         - Move status updates out of WorkQueue and into individual queues.
        * Scripts/modules/commands/queues_unittest.py:
         - Test that --status-host is passed to bugzilla-tool when run as subcommand.
        * Scripts/modules/mock_bugzillatool.py:
         - Add a MockStatusBot
        * Scripts/modules/workqueue.py:
         - Remove status_host and work_work_logs_directory callbacks.
         - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
        * Scripts/modules/workqueue_unittest.py:
         - Update unit tests to reflect new callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Do not disable the inspector on show and hide
zecke@webkit.org [Tue, 15 Dec 2009 09:29:35 +0000 (09:29 +0000)]
[Qt] Do not disable the inspector on show and hide

https://bugs.webkit.org/show_bug.cgi?id=31851

On Qt/X11 with some window managers the window will be
hidden when switching windows. In this case all the results
are gone when coming back to the window.

Attempt to use the CloseEvent to figure out if the window
was closed and withdrawn as this is more friendly to the
user of the inspector client.

* Api/qwebinspector.cpp:
(QWebInspector::hideEvent):
(QWebInspector::closeEvent):
* Api/qwebinspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove dead code from FontPlatformDataQt.cpp
zecke@webkit.org [Tue, 15 Dec 2009 09:29:19 +0000 (09:29 +0000)]
[Qt] Remove dead code from FontPlatformDataQt.cpp

https://bugs.webkit.org/show_bug.cgi?id=32540

In r51758 the code that used familyNames was removed
and we should remove the creation of the familyNames
as well.

* platform/graphics/qt/FontPlatformDataQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 15 Dec 2009 08:57:31 +0000 (08:57 +0000)]
2009-12-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        scm_unittest.py is too slow
        https://bugs.webkit.org/show_bug.cgi?id=31818

        Now we don't run the SCM unit tests unless we get the --all flag on the
        command line.  Eric and I were commenting out this test because it was
        too painful to run.

        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 15 Dec 2009 08:17:24 +0000 (08:17 +0000)]
    Reviewed by Adam Roben.

WebCore:
        WebCore part of <rdar://problem/7173515> Use LOGFONT support in Core
        Graphics when available

        When using a version of Core Graphics with LOGFONT support, this fixes
        <rdar://problem/5764844> First-time launch is painfully slow due to font
        plist creation
        and <rdar://problem/6576281> 12px synthetic-italics Tahoma text is less
        readable in Safari than in Firefox/IE due to poorly-spaced letters

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): No longer call drawGDIGlyphs for stroked
        text.
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::createGDIFont): Added a synthesizeItalic parameter. When set
        to true, if italics are desired but the best match lacks italics,
        creates and returns a synthetic italics font.
        (WebCore::FontCache::createFontPlatformData): Ask to synthesize italics
        if needed.
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData): Updated an
        assertion, and changed to create the CGFont from the LOGFONT.
        (WebCore::createFontCustomPlatformData): Changed cgFont to be a
        RetainPtr. Do not create a CGFont from the font data if it can be
        created from the LOGFONT in fontPlatformData().
        * platform/graphics/win/FontDatabase.cpp:
        (WebCore::populateFontDatabase): Avoid font database work if fonts are
        not going to be looked up by name.
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::platformDataInit): Create the CGFont from
        a LOGFONT based on the HFONT.

WebKitLibraries:
        WebKitSystemInterface part of <rdar://problem/7173515> Use LOGFONT support in
        Core Graphics when available

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Declared
            wkCanCreateCGFontWithLOGFONT().
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWAI-ARIA: implement treegrid
cfleizach@apple.com [Tue, 15 Dec 2009 07:31:37 +0000 (07:31 +0000)]
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-treegrid.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
* accessibility/AccessibilityARIAGridRow.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isARIATreeGridRow):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

LayoutTests:

* platform/mac/accessibility/aria-treegrid-expected.txt: Added.
* platform/mac/accessibility/aria-treegrid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 15 Dec 2009 06:44:34 +0000 (06:44 +0000)]
2009-12-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Some Browser-hosted SunSpider files are not valid HTML5
        https://bugs.webkit.org/show_bug.cgi?id=32536

        Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
        close tags and adding a meta charset declaration).

        * hosted/sunspider.html:
        * hosted/versions.html:
        * resources/TEMPLATE.html:
        * resources/driver-TEMPLATE.html:
        * resources/results-TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 15 Dec 2009 06:25:37 +0000 (06:25 +0000)]
2009-12-14  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fix failing unittest.

        * Scripts/modules/bugzilla_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52138 268f45cc-cd09-0410-ab3c-d52691b4dbfc