WebKit-https.git
8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 25 Sep 2012 06:32:23 +0000 (06:32 +0000)]
Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnexpected reftest passes are only reported when pixel testing is enabled in results...
zandobersek@gmail.com [Tue, 25 Sep 2012 06:17:58 +0000 (06:17 +0000)]
Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures):
(summarize_results):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_interpret_test_failures):
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.run):
(SingleTestRunner._run_reftest):
* Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

* fast/harness/resources/results-test.js:
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug in numeric accessors on global environment
barraclough@apple.com [Tue, 25 Sep 2012 06:12:11 +0000 (06:12 +0000)]
Bug in numeric accessors on global environment
https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):
    - Add missing toThisObject calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSerializedScriptValue isn't aware of indexed storage, but should be
fpizlo@apple.com [Tue, 25 Sep 2012 05:27:33 +0000 (05:27 +0000)]
SerializedScriptValue isn't aware of indexed storage, but should be
https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSObject.h:
(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):

LayoutTests:

* fast/js/post-message-numeric-property-expected.txt: Added.
* fast/js/post-message-numeric-property.html: Added.
* fast/js/script-tests/post-message-numeric-property.js: Added.
(window.onmessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
barraclough@apple.com [Tue, 25 Sep 2012 04:52:26 +0000 (04:52 +0000)]
Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

* runtime/JSGlobalObject.cpp:
    - Call globalObject() instead of unwrappedGlobalObject().
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
    - Changed to compare this object values, instead of globalObjects -
      this means we only need to be able to map globalObject -> this,
      and not vice versa.
* runtime/JSObject.cpp:
(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):
    - Call globalObject() instead of unwrappedGlobalObject().
* runtime/JSObject.h:
(JSObject):
    - Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::setWindow):
    - Update the JSDOMWindowShell's structure's globalObject when the
      window changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] We should remove DateTimeEditElement::valueAsDouble()
yosin@chromium.org [Tue, 25 Sep 2012 04:40:48 +0000 (04:40 +0000)]
[Forms] We should remove DateTimeEditElement::valueAsDouble()
https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
* html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.
(DateTimeEditElement):
* html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
* html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.
(DateTimeFieldElement):
* html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
* html/shadow/DateTimeFieldElements.h:
(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKProcessGroup can't load injected bundle with file URL
weinig@apple.com [Tue, 25 Sep 2012 04:33:25 +0000 (04:33 +0000)]
WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeleting the classic interpreter and cleaning up some build options.
mark.lam@apple.com [Tue, 25 Sep 2012 04:30:20 +0000 (04:30 +0000)]
Deleting the classic interpreter and cleaning up some build options.
https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h:
(AbstractPC):
* interpreter/CallFrame.h:
(ExecState):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcodeID):
(Interpreter):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* offlineasm/asm.rb:
* offlineasm/offsets.rb:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
* runtime/Options.cpp:
(JSC::Options::initialize):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't use StyleSheetList internally.
antti@apple.com [Tue, 25 Sep 2012 04:25:35 +0000 (04:25 +0000)]
Don't use StyleSheetList internally.
https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

    Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
    When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):
* css/StyleSheetList.h:

    Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.

(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):
* dom/Document.h:
(Document):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollec

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse NSUserDefaults rather than an environment variable to control whether to use...
weinig@apple.com [Tue, 25 Sep 2012 04:09:02 +0000 (04:09 +0000)]
Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

* GNUmakefile.list.am:
* PlatformEfl.cmake:
* Target.pri:
Add new files.

* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

* UIProcess/WebProcessProxy.h:
* UIProcess/efl/WebProcessProxyEfl.cpp: Added.
Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):
* UIProcess/gtk/WebProcessProxyGtk.cpp: Added.
Add stub.

(WebKit::WebProcessProxy::platformConnect):
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

* UIProcess/qt/WebProcessProxyQt.cpp: Added.
(WebKit::WebProcessProxy::platformConnect):
Add stub.

* UIProcess/win/WebProcessProxyWin.cpp:
(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

* Scripts/webkitdirs.pm:
(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [GTK][EFL] Remove cairo prefix from include statements
commit-queue@webkit.org [Tue, 25 Sep 2012 03:55:25 +0000 (03:55 +0000)]
Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

* platform/cairo/WidgetBackingStoreCairo.cpp:
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
* plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

* UIProcess/cairo/BackingStoreCairo.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][EFL] Make sure cairo is built with fontconfig support
commit-queue@webkit.org [Tue, 25 Sep 2012 03:53:12 +0000 (03:53 +0000)]
[GTK][EFL] Make sure cairo is built with fontconfig support
https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument::adoptNode for multiple fields time input UI should not crash
yosin@chromium.org [Tue, 25 Sep 2012 03:26:31 +0000 (03:26 +0000)]
Document::adoptNode for multiple fields time input UI should not crash
https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:
 - fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
 - fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
 - fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.

* dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

* fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
* fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and...
commit-queue@webkit.org [Tue, 25 Sep 2012 03:22:13 +0000 (03:22 +0000)]
[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

* CMakeLists.txt:
Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Blackberry] Add a software rendering path for media player
commit-queue@webkit.org [Tue, 25 Sep 2012 03:13:21 +0000 (03:13 +0000)]
[Blackberry] Add a software rendering path for media player
https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWe should not expect percent-escaped hostname for invalid URLs
benjamin@webkit.org [Tue, 25 Sep 2012 02:56:35 +0000 (02:56 +0000)]
We should not expect percent-escaped hostname for invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

* fast/url/invalid-urls-utf8-expected.txt:
* fast/url/invalid-urls-utf8.html:
Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

* fast/url/ipv4-expected.txt:
* fast/url/ipv6-expected.txt:
* fast/url/script-tests/ipv4.js:
* fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.
Invalid URLs should not be escaped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Geolocation error reporting in the test support
benjamin@webkit.org [Tue, 25 Sep 2012 02:30:01 +0000 (02:30 +0000)]
Fix Geolocation error reporting in the test support
https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):
* platform/mock/GeolocationClientMock.h:
(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
* WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* public/WebGeolocationClientMock.h:
(WebGeolocationClientMock):
* src/WebGeolocationClientMock.cpp:
(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebView/WebView.mm:
(-[WebView _geolocationDidFailWithMessage:]):
* WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

* DumpRenderTree/TestRunner.cpp:
(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/mac/MockGeolocationProvider.h:
* DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider resetError]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider timerFired]):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):
* DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::setMockGeolocationPositionUnavailableError):

LayoutTests:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

Update the tests to use setMockGeolocationPositionUnavailableError() instead
of setMockGeolocationError().

Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
anything for the test coverage.

* fast/dom/Geolocation/error-clear-watch.html:
* fast/dom/Geolocation/error-expected.txt:
* fast/dom/Geolocation/maximum-age-expected.txt:
* fast/dom/Geolocation/reentrant-error-expected.txt:
* fast/dom/Geolocation/script-tests/error.js:
* fast/dom/Geolocation/script-tests/maximum-age.js:
(checkError):
(testNonZeroMaximumAge):
* fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
* fast/dom/Geolocation/script-tests/reentrant-error.js:
* fast/dom/Geolocation/script-tests/watch.js:
(checkError):
* fast/dom/Geolocation/watch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Implement ValidationMessageClient for Chromium
tkent@chromium.org [Tue, 25 Sep 2012 02:16:07 +0000 (02:16 +0000)]
[Chromium] Implement ValidationMessageClient for Chromium
https://bugs.webkit.org/show_bug.cgi?id=97167

Reviewed by Hajime Morita.

Source/WebCore:

* page/ValidationMessageClient.h:
Add forward declaration for WTF::String.

Source/WebKit/chromium:

Introduce ValidationMessageClientImpl. However actual popup
implementation should be done in WebViewClient.

* WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
* public/WebViewClient.h:
(WebKit::WebViewClient::showValidationMessage): Added.
(WebKit::WebViewClient::hideValidationMessage): Added.
* src/ValidationMessageClientImpl.cpp: Added.
(WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
(WebKit::ValidationMessageClientImpl::create):
(WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
Make sure that a popup is closed.
(WebKit::ValidationMessageClientImpl::showValidationMessage):
Implementataion of ValidationMessageClient::showValidationMessage.
minimumSecondToShowValidationMessage and secondPerCharacter are same as
the corresponding values in the current Shadow DOM implementation.
(WebKit::ValidationMessageClientImpl::hideValidationMessage):
Implementataion of ValidationMessageClient::hideValidationMessage.
(WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
Implementataion of ValidationMessageClient::isValidationMessageVisible.
(WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
This is a callback function for the timer.
* src/ValidationMessageClientImpl.h: Added.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
 - Initialize m_validationMessage.
 - Add a comment for PageClients.
* src/WebViewImpl.h:
Add m_validationMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
mihaip@chromium.org [Tue, 25 Sep 2012 02:07:14 +0000 (02:07 +0000)]
[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with http://crrev.com/155205.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] DateTimeEditElement should return string value for ease of implementing other...
yosin@chromium.org [Tue, 25 Sep 2012 01:48:49 +0000 (01:48 +0000)]
[Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=97303

Reviewed by Kent Tamura.

This patch introduces a function DateTimeEditElement::value() for
setting internal text value of TimeInputType with new function
EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
in other date time input types.

We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
to make string value then setting internal text value of multiple
fields time input UI. Although, this steps doesn't work well for
other date/time input types.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/DateTimeFieldsState.cpp:
(WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.
* html/DateTimeFieldsState.h:
(DateTimeFieldsState): Added declaration of hour23().
* html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
(WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
* html/TimeInputType.h:
(DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::value): Added.
* html/shadow/DateTimeEditElement.h:
(EditControlOwner): Added a declaration of formatDateTimeFieldsState().
(DateTimeEditElement): Added a declaration of value().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNested try/finally should not confuse the finally unpopper in BytecodeGenerator:...
fpizlo@apple.com [Tue, 25 Sep 2012 01:26:28 +0000 (01:26 +0000)]
Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
https://bugs.webkit.org/show_bug.cgi?id=97508
<rdar://problem/12361132>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
(like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
context stack afterwards.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexJumpScopes):

LayoutTests:

* fast/js/jsc-test-list:
* fast/js/script-tests/try-try-return-finally-finally.js: Added.
(foo):
* fast/js/try-try-return-finally-finally-expected.txt: Added.
* fast/js/try-try-return-finally-finally.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] Intel Mac needs built-in function emulation
dino@apple.com [Tue, 25 Sep 2012 01:14:48 +0000 (01:14 +0000)]
[WebGL] Intel Mac needs built-in function emulation
https://bugs.webkit.org/show_bug.cgi?id=96140

Reviewed by Sam Weinig.

Temporarily turn on built-in function emulation for Intel GPUs
on OS X. This is a work-around for a driver bug, and
will be removed once the driver is updated:
https://bugs.webkit.org/show_bug.cgi?id=97503

This can be tested using the Khronos WebGL conformance
suite, in particular:

conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html

Note that the faceforward built-in will still cause
problems on Intel GPUs, but this would require an unnecessary
change in the ANGLE project (remember, we're going to
remove this code once the driver is fixed).

* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
    Temporarily add "Intel" to the list of GPUs we do translation
    for in the shader compiler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThere is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
commit-queue@webkit.org [Tue, 25 Sep 2012 01:05:43 +0000 (01:05 +0000)]
There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
https://bugs.webkit.org/show_bug.cgi?id=97450

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Yury Semikhatsky.

The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
no-worker thread.

No new test case.

* inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::recompileScript):
(PageProfilerAgent):
(WebCore::WorkerProfilerAgent::recompileScript):
(WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] TestRunner needs touch events support.
commit-queue@webkit.org [Tue, 25 Sep 2012 00:54:11 +0000 (00:54 +0000)]
[EFL][WK2] TestRunner needs touch events support.
https://bugs.webkit.org/show_bug.cgi?id=96465

Patch by Nikhil Bansal <n.bansal@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

Tools:

Simulate touch events in WebkitTestRunner for touch related
layout tests. This patch uses ewk_view_feed_touch_event() to
generate touch events.

* WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR):
(WTR::setEvasModifiers):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Touch events support added in WebKitTestRunner for layout tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValueToInt32 bool case does bad things to registers
fpizlo@apple.com [Tue, 25 Sep 2012 00:46:45 +0000 (00:46 +0000)]
ValueToInt32 bool case does bad things to registers
https://bugs.webkit.org/show_bug.cgi?id=97505
<rdar://problem/12356331>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

LayoutTests:

* fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
* fast/js/dfg-bool-to-int32-reuse.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd cloopDo instruction for debugging the llint C++ backend.
mark.lam@apple.com [Tue, 25 Sep 2012 00:38:51 +0000 (00:38 +0000)]
Add cloopDo instruction for debugging the llint C++ backend.
https://bugs.webkit.org/show_bug.cgi?id=97502.

Reviewed by Geoffrey Garen.

* offlineasm/cloop.rb:
* offlineasm/instructions.rb:
* offlineasm/parser.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove String::operator+=()
paroga@webkit.org [Tue, 25 Sep 2012 00:28:51 +0000 (00:28 +0000)]
Remove String::operator+=()
https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

* wtf/Platform.h:
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSArray::putByIndex asserts with readonly property on prototype
fpizlo@apple.com [Tue, 25 Sep 2012 00:20:13 +0000 (00:20 +0000)]
JSArray::putByIndex asserts with readonly property on prototype
https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Boy, there were some problems:

- putDirectIndex() should know that it can set the index quickly even if it's a hole and we're
  in SlowPut mode, since that's the whole point of PutDirect.

- We should have a fast path for putByIndex().

- The LiteralParser should not use push(), since that may throw if we're having a bad time.

* interpreter/Interpreter.cpp:
(JSC::eval):
* runtime/JSObject.h:
(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):
* runtime/LiteralParser.cpp:
(JSC::::parse):

LayoutTests:

* fast/js/concat-while-having-a-bad-time.html: Added.
* fast/js/concat-while-having-a-bad-time-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/concat-while-having-a-bad-time.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
roger_fong@apple.com [Tue, 25 Sep 2012 00:12:22 +0000 (00:12 +0000)]
Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=95803

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] TestRunner does not support overridePreference with value "0"
commit-queue@webkit.org [Tue, 25 Sep 2012 00:05:03 +0000 (00:05 +0000)]
[WK2] TestRunner does not support overridePreference with value "0"
https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium][Mac] Remove loadFont from PlatformSupport
pilgrim@chromium.org [Mon, 24 Sep 2012 23:57:24 +0000 (23:57 +0000)]
[Chromium][Mac] Remove loadFont from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
mark.lam@apple.com [Mon, 24 Sep 2012 23:53:11 +0000 (23:53 +0000)]
Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace 2 uses of updateLogicalHeight with computeLogicalHeight
tony@chromium.org [Mon, 24 Sep 2012 23:43:28 +0000 (23:43 +0000)]
Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804.  This is just a refactoring.

No new tests, behavior should be the same as before.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):
* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInlined activation tear-off in the DFG
ggaren@apple.com [Mon, 24 Sep 2012 23:12:00 +0000 (23:12 +0000)]
Inlined activation tear-off in the DFG
https://bugs.webkit.org/show_bug.cgi?id=97487

Reviewed by Filip Pizlo.

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h: Activation tear-off is always inlined now, so I
removed its out-of-line implementation.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
of JSVariableObject::m_registers. This usually turns into < 10 instructions,
which is close to pure win as compared to the operation function call.

* runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC):
(JSC::JSActivation::storageOffset):
(JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
share the pointer math helper functions we use internally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin...
roger_fong@apple.com [Mon, 24 Sep 2012 22:23:38 +0000 (22:23 +0000)]
Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExte...
kbr@google.com [Mon, 24 Sep 2012 22:18:04 +0000 (22:18 +0000)]
[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
https://bugs.webkit.org/show_bug.cgi?id=96703

Reviewed by Adam Barth.

Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.

No tests because it is not guaranteed that buffers this large can actually be allocated.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit stylesheet related code out from Document
antti@apple.com [Mon, 24 Sep 2012 22:14:47 +0000 (22:14 +0000)]
Split stylesheet related code out from Document
https://bugs.webkit.org/show_bug.cgi?id=97353

Reviewed by Andreas Kling.

Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.

The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
DocumentStyleSheetCollection class. There are no functional changes.

The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.

* WebCore.xcodeproj/project.pbxproj:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(WebCore::StyleResolver::usesBeforeAfterRules):
(Features):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore):
(WebCore::Document::createStyleResolver):
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore::Document::didRemoveAllPendingStylesheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::styleSheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::reportMemoryUsage):
(WebCore::Document::haveStylesheetsLoaded):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::styleSheetCollection):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
(WebCore::Document::inStyleRecalc):
* dom/DocumentStyleSheetCollection.cpp: Added.
(WebCore):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.h: Added.
(WebCore):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::authorStyleSheets):
(WebCore::DocumentStyleSheetCollection::documentUserSheets):
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::addPendingSheet):
(WebCore::DocumentStyleSheetCollection::hasPendingSheets):
(WebCore::DocumentStyleSheetCollection::usesSiblingRules):
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesRemUnits):
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* dom/StyleElement.cpp:
(WebCore::StyleElement::insertedIntoDocument):
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearDocumentData):
(WebCore::StyleElement::createSheet):
(WebCore::StyleElement::sheetLoaded):
(WebCore::StyleElement::startLoadingDynamicSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
* page/PageGroup.cpp:
(WebCore::PageGroup::resetUserStyleCacheInAllFrames):
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::lineHeight):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):
* rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::updateBeforeAndAfterContent):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
roger_fong@apple.com [Mon, 24 Sep 2012 22:06:29 +0000 (22:06 +0000)]
Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
https://bugs.webkit.org/show_bug.cgi?id=97485

This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reverting implementation for 407 error pages
commit-queue@webkit.org [Mon, 24 Sep 2012 21:59:03 +0000 (21:59 +0000)]
[BlackBerry] Reverting implementation for 407 error pages
https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Source/WebCore:

Revert "[BlackBerry] Reverting implementation for 407 error pages"
This reverts commit fda0a1b6ac40c06c03bb6293b4a7d7353c3ca238.

This revert also reverts commit 0cffe01961fb80204138505bcec29a83818efb73
due to dependency issues.

* PlatformBlackBerry.cmake:
* platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
* platform/blackberry/AuthenticationChallengeManager.h:
* platform/blackberry/PageClientBlackBerry.h:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

Source/WebKit/blackberry:

Revert "[BlackBerry] Really fix bug 95488 that user can get the
authentication challenge dialog while the other tab has focus."
https://bugs.webkit.org/show_bug.cgi?id=97348

This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
crogers@google.com [Mon, 24 Sep 2012 21:55:42 +0000 (21:55 +0000)]
[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97439

Reviewed by Kenneth Russell.

Fixes uninitialized member variable.

This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html

* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNarrow Chromium TestExpectations for some hidpi failures to be Linux-only.
dpranke@chromium.org [Mon, 24 Sep 2012 21:52:06 +0000 (21:52 +0000)]
Narrow Chromium TestExpectations for some hidpi failures to be Linux-only.
crbug.com/150682

Unreviewed, expectations change.

Also remove a no-longer-failing Mac expectation for
compositing/overflow/overflow-scaled-descendant-overlapping.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoflex-grow should be 1 when omitted from flex shorthand
tony@chromium.org [Mon, 24 Sep 2012 21:35:13 +0000 (21:35 +0000)]
flex-grow should be 1 when omitted from flex shorthand
https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html
       css3/flexbox/flex-algorithm.html: New test case.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

* css3/flexbox/flex-algorithm-expected.txt:
* css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
* css3/flexbox/flex-property-parsing-expected.txt:
* css3/flexbox/flex-property-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for query encoding to WTFURL
benjamin@webkit.org [Mon, 24 Sep 2012 21:32:45 +0000 (21:32 +0000)]
Add support for query encoding to WTFURL
https://bugs.webkit.org/show_bug.cgi?id=97422

Reviewed by Adam Barth.

Source/WebCore:

Add the Charset conversion on WebCore side.

* platform/KURLWTFURL.cpp:
(WebCore::KURL::KURL):
(CharsetConverter):
(WebCore::CharsetConverter::CharsetConverter):
* platform/mac/KURLMac.mm:
(WebCore::KURL::KURL):

Source/WTF:

Expose character conversion through the new abstract class URLQueryCharsetConverter.
URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.

Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
to mitigate that later when moving WTFURL to more templates.

The change fixes 2 of the URL layout tests.

* WTF.xcodeproj/project.pbxproj:
* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
* wtf/url/api/ParsedURL.h:
(ParsedURL):
ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
That was a mistake on my part, I did not intend that, fixed it now :)

* wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
* wtf/url/api/URLQueryCharsetConverter.h: Added.
(URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):
* wtf/url/src/URLCanon.h:
(URLCanonicalizer):
* wtf/url/src/URLCanonFilesystemurl.cpp:
(WTF::URLCanonicalizer::canonicalizeFileSystemURL):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):
* wtf/url/src/URLCanonFileurl.cpp:
(WTF::URLCanonicalizer::CanonicalizeFileURL):
(WTF::URLCanonicalizer::ReplaceFileURL):
* wtf/url/src/URLCanonInternal.h:
(URLCanonicalizer):
* wtf/url/src/URLCanonQuery.cpp:
(WTF::URLCanonicalizer::CanonicalizeQuery):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
* wtf/url/src/URLCanonRelative.cpp:
(WTF::URLCanonicalizer::resolveRelativeURL):
* wtf/url/src/URLCanonStdURL.cpp:
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):
* wtf/url/src/URLUtil.cpp:
(URLUtilities):
(WTF::URLUtilities::canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
* wtf/url/src/URLUtil.h:
(URLUtilities):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntegrate most of GoogleURL in WTFURL
benjamin@webkit.org [Mon, 24 Sep 2012 21:30:52 +0000 (21:30 +0000)]
Integrate most of GoogleURL in WTFURL
https://bugs.webkit.org/show_bug.cgi?id=97405

Reviewed by Adam Barth.

Source/WebCore:

Loosen KURLWTFURL to be able to run most tests in Debug.

* platform/KURLWTFURL.cpp:
(WebCore::KURL::KURL):
(WebCore::KURL::hasPort):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::query):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::fileSystemPath):

Source/WTF:

This patch brings almost all of the implementatation of Google-URL in WTFURL
with only minor changes.

The changes from the original code are mostly:
-Code cleaning.
-Replace url_parse::Parsed by URLSegments.
-Replace url_parse::Component by URLComponent
-More code cleaning.
-Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
-Use URLCharacterTypes instead of the litany of characters functions.
-Some more code cleaning.
-Fix the style to match WebKit as much as possible.
-Rename the files to match WebKit style.

* WTF.xcodeproj/project.pbxproj:
* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::segment):
* wtf/url/api/ParsedURL.h:
(WTF::ParsedURL::isValid):
* wtf/url/src/RawURLBuffer.h:
* wtf/url/src/URLCanon.h: Added.
(URLCanonicalizer):
(CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
(CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
(WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
(URLComponentSource):
(WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
(Replacements):
(WTF::URLCanonicalizer::Replacements::Replacements):
(WTF::URLCanonicalizer::Replacements::SetScheme):
(WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
(WTF::URLCanonicalizer::Replacements::SetUsername):
(WTF::URLCanonicalizer::Replacements::ClearUsername):
(WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
(WTF::URLCanonicalizer::Replacements::SetPassword):
(WTF::URLCanonicalizer::Replacements::ClearPassword):
(WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
(WTF::URLCanonicalizer::Replacements::SetHost):
(WTF::URLCanonicalizer::Replacements::ClearHost):
(WTF::URLCanonicalizer::Replacements::IsHostOverridden):
(WTF::URLCanonicalizer::Replacements::SetPort):
(WTF::URLCanonicalizer::Replacements::ClearPort):
(WTF::URLCanonicalizer::Replacements::IsPortOverridden):
(WTF::URLCanonicalizer::Replacements::SetPath):
(WTF::URLCanonicalizer::Replacements::ClearPath):
(WTF::URLCanonicalizer::Replacements::IsPathOverridden):
(WTF::URLCanonicalizer::Replacements::SetQuery):
(WTF::URLCanonicalizer::Replacements::ClearQuery):
(WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
(WTF::URLCanonicalizer::Replacements::SetRef):
(WTF::URLCanonicalizer::Replacements::ClearRef):
(WTF::URLCanonicalizer::Replacements::IsRefOverridden):
(WTF::URLCanonicalizer::Replacements::sources):
(WTF::URLCanonicalizer::Replacements::components):
(WTF::URLCanonicalizer::Replacements::Placeholder):
* wtf/url/src/URLCanonEtc.cpp: Added.
(WTF::URLCanonicalizer::removeURLWhitespace):
(URLCanonicalizer):
(WTF::URLCanonicalizer::canonicalSchemeChar):
(WTF::URLCanonicalizer::CanonicalizeScheme):
(WTF::URLCanonicalizer::CanonicalizeUserInfo):
(WTF::URLCanonicalizer::CanonicalizePort):
(WTF::URLCanonicalizer::CanonicalizeRef):
* wtf/url/src/URLCanonFilesystemurl.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):
* wtf/url/src/URLCanonFileurl.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeFileURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::FileCanonicalizePath):
(WTF::URLCanonicalizer::ReplaceFileURL):
* wtf/url/src/URLCanonHost.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeHost):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeHostVerbose):
* wtf/url/src/URLCanonICU.cpp: Added.
(WTF::URLCanonicalizer::IDNToASCII):
(URLCanonicalizer):
(WTF::URLCanonicalizer::readUTFChar):
* wtf/url/src/URLCanonIP.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeIPAddress):
(URLCanonicalizer):
* wtf/url/src/URLCanonInternal.cpp: Added.
(URLCanonicalizer):
(WTF::URLCanonicalizer::AppendInvalidNarrowString):
(WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
(WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
(WTF::URLCanonicalizer::SetupOverrideComponents):
(WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):
* wtf/url/src/URLCanonInternal.h: Added.
(URLCanonicalizer):
(WTF::URLCanonicalizer::hexCharToValue):
(WTF::URLCanonicalizer::isDot):
(WTF::URLCanonicalizer::appendURLEscapedCharacter):
(WTF::URLCanonicalizer::doAppendUTF8):
(WTF::URLCanonicalizer::AppendCharToOutput):
(WTF::URLCanonicalizer::AppendUTF8Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedValue):
(WTF::URLCanonicalizer::AppendUTF16Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedChar):
(WTF::URLCanonicalizer::Is8BitChar):
(WTF::URLCanonicalizer::DecodeEscaped):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):
(WTF::URLCanonicalizer::_strtoui64):
* wtf/url/src/URLCanonMailto.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeMailtoURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceMailtoURL):
* wtf/url/src/URLCanonPath.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizePath):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizePartialPath):
* wtf/url/src/URLCanonPathurl.cpp: Added.
(WTF::URLCanonicalizer::canonicalizePathURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplacePathURL):
* wtf/url/src/URLCanonQuery.cpp: Added.
(WTF::URLCanonicalizer::CanonicalizeQuery):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
* wtf/url/src/URLCanonRelative.cpp: Added.
(WTF::URLCanonicalizer::isRelativeURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::resolveRelativeURL):
* wtf/url/src/URLCanonStdURL.cpp: Added.
(WTF::URLCanonicalizer::DefaultPortForScheme):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):
* wtf/url/src/URLCharacterTypes.cpp:
* wtf/url/src/URLCharacterTypes.h:
(WTF::URLCharacterTypes::isComponentChar):
(WTF::URLCharacterTypes::isHexChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isCharacterOfType):
(URLCharacterTypes):
* wtf/url/src/URLEscape.cpp: Removed.
* wtf/url/src/URLFile.h: Added.
(URLParser):
(WTF::URLParser::isWindowsDriveSeparator):
(WTF::URLParser::isWindowsDriveLetter):
(WTF::URLParser::findNextSlash):
(WTF::URLParser::doesBeginWindowsDriveSpec):
(WTF::URLParser::doesBeginUNCPath):
* wtf/url/src/URLParse.cpp: Added.
(WTF::URLParser::ExtractScheme):
(URLParser):
(WTF::URLParser::IsAuthorityTerminator):
(WTF::URLParser::ExtractFileName):
(WTF::URLParser::ExtractQueryKeyValue):
(WTF::URLParser::ParseAuthority):
(WTF::URLParser::ParsePort):
(WTF::URLParser::ParseStandardURL):
(WTF::URLParser::ParsePathURL):
(WTF::URLParser::ParseFileSystemURL):
(WTF::URLParser::ParseMailtoURL):
(WTF::URLParser::parsePathInternal):
(WTF::URLParser::ParseAfterScheme):
* wtf/url/src/URLParse.h: Added.
(URLParser):
* wtf/url/src/URLParseFile.cpp: Added.
(WTF):
(WTF::URLParser::ParseFileURL):
(URLParser):
* wtf/url/src/URLParseInternal.h: Added.
(URLParser):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::countConsecutiveSlashes):
* wtf/url/src/URLParser.h: Removed.
* wtf/url/src/URLQueryCanonicalizer.h: Removed.
* wtf/url/src/URLSegments.cpp:
* wtf/url/src/URLSegments.h:
(WTF::URLSegments::URLSegments):
(URLSegments):
(WTF::URLSegments::operator=):
(WTF::URLSegments::innerURLSegments):
(WTF::URLSegments::setInnerURLSegments):
(WTF::URLSegments::clearInnerURLSegments):
* wtf/url/src/URLUtil.cpp: Added.
(URLUtilities):
(WTF::URLUtilities::IsStandard):
(WTF::URLUtilities::FindAndCompareScheme):
(WTF::URLUtilities::Canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
(WTF::URLUtilities::LowerCaseEqualsASCII):
(WTF::URLUtilities::DecodeURLEscapeSequences):
(WTF::URLUtilities::EncodeURIComponent):
(WTF::URLUtilities::CompareSchemeComponent):
* wtf/url/src/URLUtil.h: Added.
(URLUtilities):
* wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.
(URLUtilities):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] ExclusionShape API should use logical coordinates for input/output
commit-queue@webkit.org [Mon, 24 Sep 2012 21:18:54 +0000 (21:18 +0000)]
[CSS Exclusions] ExclusionShape API should use logical coordinates for input/output
https://bugs.webkit.org/show_bug.cgi?id=96156

Patch by Hans Muller <hmuller@adobe.com> on 2012-09-24
Reviewed by Dirk Schulze.

Source/WebCore:

Correct how ExclusionShapes deal with logical coordinates and enable
shape-inside exclusion layout for vertical writing-modes.

BasicShape's are defined in physical cooordinates, incoming line and box
dimensions are logical coordinates, and the ExclusionShape internals assume
that lines are aligned with the Y axis. The createExclusionShape() method
is responsible for converting the BasicShape to the internal coordinate
system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
methods are responsible for converting their logical line parameters to Y
values in the internal coordinate system. The min,maxYForLogicalLine()
methods do the conversion, based on the WritingMode the ExclusionShape
was created with. The getInclude,ExcludedIntervals() methods return the
logical left and right edges of line segments. No transformation is needed for this.

The ExclusionShape's internal coordinate system is essentially the
"logical" one, except that top/bottom always map to Y, no matter what
the writing-mode is.  This is just to simplify writing geometrical shape
algorithms, notably the complex ones for polygons. The bug report includes a
pair of diagrams that clarify how internal coordinates are related to logical
and physical coordinates.

Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html

* rendering/ExclusionRectangle.cpp:
(WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
(WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version
* rendering/ExclusionRectangle.h:
* rendering/ExclusionShape.cpp:
(WebCore):
(WebCore::ExclusionShape::createExclusionShape):
* rendering/ExclusionShape.h:
(LineSegment):
(WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
(WebCore):
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):
* rendering/WrapShapeInfo.cpp:
(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
(WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
(WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes
* rendering/WrapShapeInfo.h:
(WebCore):

LayoutTests:

Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.

* fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for r129389
commit-queue@webkit.org [Mon, 24 Sep 2012 21:13:31 +0000 (21:13 +0000)]
Rebaseline for r129389
https://bugs.webkit.org/show_bug.cgi?id=97473

Unreviewed.

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-24

* platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/chromium-mac/fast/text/emphasis-expected.png:
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
tony@chromium.org [Mon, 24 Sep 2012 21:11:48 +0000 (21:11 +0000)]
Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97475

Reviewed by Ojan Vafai.

Using RenderMeter::computeLogicalHeight is part of bug 96804.
Also fix some code to be vertical writing mode aware. This doesn't actually cause
a behavioral difference because we use percentage heights/widths which don't depend on
updateLogicalWidth or computeLogicalHeight.  You can still see bugs if you try to set
the min-width on a <meter> node in a vertical writing mode.

No new tests, no behavioral changes.

* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
(WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.
* rendering/RenderMeter.h:
(RenderMeter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unbaked support for :scope pseudo-class.
dglazkov@chromium.org [Mon, 24 Sep 2012 20:58:47 +0000 (20:58 +0000)]
Remove unbaked support for :scope pseudo-class.
https://bugs.webkit.org/show_bug.cgi?id=97467

Reviewed by Antti Koivisto.

It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
http://dev.w3.org/csswg/selectors4/#the-scope-pseudo

Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
time/energy to fully implement it.

Source/WebCore:

No new tests, removing half-baked feature.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Ditto.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Ditto.

LayoutTests:

* fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
* fast/css/style-scoped/scope-pseudo.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r129343.
ossy@webkit.org [Mon, 24 Sep 2012 20:47:45 +0000 (20:47 +0000)]
Unreviewed, rolling out r129343.
http://trac.webkit.org/changeset/129343
https://bugs.webkit.org/show_bug.cgi?id=97479

It broke the build (Requested by Ossy_NIGHT on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-24

.:

* Source/api.pri:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosuspend/resumeWidgetHierarchyUpdates should be a RAII object
rniwa@webkit.org [Mon, 24 Sep 2012 20:34:35 +0000 (20:34 +0000)]
suspend/resumeWidgetHierarchyUpdates should be a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

* WebCore.exp.in: Export new symbols.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* rendering/RenderWidget.cpp:
(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):
* rendering/RenderWidget.h:
(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role...
roger_fong@apple.com [Mon, 24 Sep 2012 20:23:25 +0000 (20:23 +0000)]
Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role which hasn't been properly implemented on Windows.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reverting implementation for 407 error pages
commit-queue@webkit.org [Mon, 24 Sep 2012 20:21:35 +0000 (20:21 +0000)]
[BlackBerry] Reverting implementation for 407 error pages
https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r129388.
commit-queue@webkit.org [Mon, 24 Sep 2012 20:07:13 +0000 (20:07 +0000)]
Unreviewed, rolling out r129388.
http://trac.webkit.org/changeset/129388
https://bugs.webkit.org/show_bug.cgi?id=97477

Caused an assertion in a WebKit2 unit test (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-24

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
(WebCore::CachedImage::stillNeedsLoad):
(CachedImage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
* loader/cache/CachedResource.h:
(WebCore):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* page/Settings.cpp:
(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def:

LayoutTests:

* fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
* fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
* fast/loader/resources/image1.html: Removed.
* fast/loader/resources/image2.html: Removed.
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/chromium/permissionclient/resources/image.html:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOM4 remove method
arv@chromium.org [Mon, 24 Sep 2012 20:04:01 +0000 (20:04 +0000)]
DOM4 remove method
https://bugs.webkit.org/show_bug.cgi?id=73885

Reviewed by Ojan Vafai.

This adds the DOM 4 remove method.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove

The remove method removes the node from its parent if it has a parent.

Source/WebCore:

Tests: fast/dom/Comment/remove.html
       fast/dom/DocumentType/remove.html
       fast/dom/Element/remove.html
       fast/dom/Text/remove.html

* dom/CharacterData.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Node.cpp:
(WebCore::Node::remove): The spec says to do nothing if the node has no parent.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.

LayoutTests:

* fast/dom/Comment/remove-expected.txt: Added.
* fast/dom/Comment/remove.html: Added.
* fast/dom/DocumentType/remove-expected.txt: Added.
* fast/dom/DocumentType/remove.html: Added.
* fast/dom/Element/remove-expected.txt: Added.
* fast/dom/Element/remove.html: Added.
* fast/dom/Text/remove-expected.txt: Added.
* fast/dom/Text/remove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add Select All method to WebKit2 GTK+ API
commit-queue@webkit.org [Mon, 24 Sep 2012 19:53:40 +0000 (19:53 +0000)]
[GTK] Add Select All method to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97460

Patch by Simon Pena <spena@igalia.com> on 2012-09-24
Reviewed by Martin Robinson.

Following the same approach used when added Cut, Copy and Paste,
the Select All method is added to the WebKit2 GTK+ API.

This introduces a new macro in the WebKitEditingCommands,
updates the documentation, and includes a new unit test.

* UIProcess/API/gtk/WebKitEditingCommands.h: Add a new macro for
the Select All command.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the Select All
command in the documentation.
* UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Cover the new command
with a unit test.
(testWebViewEditorSelectAll):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Removing Windows specific results for fast/text/international/float-as...
roger_fong@apple.com [Mon, 24 Sep 2012 19:12:29 +0000 (19:12 +0000)]
Unreviewed. Removing Windows specific results for fast/text/international/float-as-only-child-of-isolate-crash that were added in https://bugs.webkit.org/show_bug.cgi?id=87998.
Test now passes properly.

* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed.
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded...
tommyw@google.com [Mon, 24 Sep 2012 18:56:19 +0000 (18:56 +0000)]
MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
https://bugs.webkit.org/show_bug.cgi?id=97456

Reviewed by Adam Barth.

Renamed onnegotationneeded to onnegotiationneeded.

Source/WebCore:

Existing test updated.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::negotiationNeeded):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):

LayoutTests:

* fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
tony@chromium.org [Mon, 24 Sep 2012 18:52:21 +0000 (18:52 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Enable Regions support
dominik.rottsches@intel.com [Mon, 24 Sep 2012 18:49:40 +0000 (18:49 +0000)]
[EFL][DRT] Enable Regions support
https://bugs.webkit.org/show_bug.cgi?id=83897

Reviewed by Kenneth Rohde Christiansen.

.:

Default build setting for CSS regions set to on.

* Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

Activating CSS regions by default for EWK views.

* ewk/ewk_view.cpp: Switch CSS regions on by default.
(_ewk_view_priv_new):

LayoutTests:

New baselines for CSS regions, some CSS regions test still in TestExpectations.

* platform/efl-wk2/TestExpectations: fast/regions/css-regions-disabled.html still failing on wk2.
* platform/efl/TestExpectations: Some remaining CSS regions cases still skipped.
* platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
* platform/efl/fast/regions/autoheight-regions-mark-expected.png: Added.
* platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Added.
* platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Added.
* platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
* platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
* platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
* platform/efl/fast/regions/element-region-overset-state-expected.txt: Added.
* platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
* platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
* platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
* platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
* platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
* platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Added.
* platform/efl/fast/regions/flow-anonymous-children-expected.txt: Added.
* platform/efl/fast/regions/flow-content-basic-expected.png: Added.
* platform/efl/fast/regions/flow-content-basic-expected.txt: Added.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Added.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
* platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Added.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
* platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
* platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Added.
* platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
* platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Added.
* platform/efl/fast/regions/get-regions-by-content2-expected.txt: Added.
* platform/efl/fast/regions/hit-test-float-expected.txt: Added.
* platform/efl/fast/regions/hit-test-region-expected.txt: Added.
* platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
* platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Added.
* platform/efl/fast/regions/moved-content-node-crash-expected.txt: Added.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/no-split-line-box-expected.txt: Added.
* platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
* platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Added.
* platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Added.
* platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
* platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
* platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
* platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
* platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
* platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
* platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
* platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
* platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
* platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
* platform/efl/fast/regions/region-element-display-change-expected.txt: Added.
* platform/efl/fast/regions/region-element-display-restriction-expected.txt: Added.
* platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
* platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
* platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Added.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Added.
* platform/efl/fast/regions/region-style-block-background-color-expected.png: Added.
* platform/efl/fast/regions/region-style-block-background-color-expected.txt: Added.
* platform/efl/fast/regions/region-style-block-background-color2-expected.png: Added.
* platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Added.
* platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Added.
* platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
* platform/efl/fast/regions/select-in-region-crash-expected.txt: Added.
* platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Added.
* platform/efl/fast/regions/svg-root-element-collected-expected.txt: Added.
* platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
* platform/efl/fast/regions/text-region-breaks-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Added.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-vertical-expected.txt: Added.
* platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
* platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
* platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
* platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
* platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Added.
* platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
* platform/efl/fast/regions/webkit-region-rule-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAndroid's mock scrollbars shows up as a difference in layout test results
peter@chromium.org [Mon, 24 Sep 2012 18:42:22 +0000 (18:42 +0000)]
Android's mock scrollbars shows up as a difference in layout test results
https://bugs.webkit.org/show_bug.cgi?id=96382

Reviewed by Adam Barth.

Remove the exceptions made for layout tests in Android's scrollbar theme.
This will make our actual scrollbars show up in layout test pixel results,
bringing the tests closer to what we actually ship.

An important difference with other platforms is that scrollbars do not
take any width on Android, they're rendered on top of the content. Therefore
each test that has a visible scrollbar does not just need a new pixel
result, but will also need a new text result. This will be handled as part
of a larger rebaselining process.

Will be exercised by every layout test that has a scrollbar.

* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. [Win] Failing test http/tests/inspector/network/network-xhr-replay.html
roger_fong@apple.com [Mon, 24 Sep 2012 18:39:24 +0000 (18:39 +0000)]
Unreviewed. [Win] Failing test http/tests/inspector/network/network-xhr-replay.html
https://bugs.webkit.org/show_bug.cgi?id=96942

* platform/win/Skipped: Skipping a test for the newly added feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Basic authentication challenge credentials for stored credentials again...
commit-queue@webkit.org [Mon, 24 Sep 2012 18:34:15 +0000 (18:34 +0000)]
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Rob Buis.

Fix a mistake of the commit 11fdc73c7c74bbd736ed4160248ff59636a01864
Trunk has been changed during reviewing that patch.

No new tests, this is to correct a build error.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::getProtectionSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Unskip the Shadow DOM layout tests
zandobersek@gmail.com [Mon, 24 Sep 2012 18:32:04 +0000 (18:32 +0000)]
[Gtk] Unskip the Shadow DOM layout tests
https://bugs.webkit.org/show_bug.cgi?id=90776

Reviewed by Ryosuke Niwa.

Source/WebKit/gtk:

Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

Unskip Shadow DOM layout tests, adding two required baselines and failure
expectations for tests that still fail.

* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
* platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening - re-enable IDB test that's now passing.
jsbell@chromium.org [Mon, 24 Sep 2012 18:29:02 +0000 (18:29 +0000)]
[Chromium] Unreviewed gardening - re-enable IDB test that's now passing.
https://bugs.webkit.org/show_bug.cgi?id=92776

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Reverted r129176, the fix for <http://webkit.org/b/97269>, because...
mitz@apple.com [Mon, 24 Sep 2012 18:18:05 +0000 (18:18 +0000)]
Source/WebCore: Reverted r129176, the fix for <webkit.org/b/97269>, because it introduced a
discrepancy between line breaking and max width computation.

Rubber-stamped by Anders Carlsson.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests: Reveted r129176 and r129185.

Rubber-stamped by Anders Carlsson.

* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/mac/fast/text/emphasis-expected.png:
* platform/mac/fast/text/emphasis-expected.txt:
* platform/mac/fast/text/sticky-typesetting-features-expected.png:
* platform/mac/fast/text/sticky-typesetting-features-expected.txt:
* platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
* platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
commit-queue@webkit.org [Mon, 24 Sep 2012 18:13:34 +0000 (18:13 +0000)]
Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html
       fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
       fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
* loader/cache/CachedResource.h:
(WebCore):
(WebCore::CachedResource::stillNeedsLoad):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* page/Settings.cpp:
(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def:

LayoutTests:

* fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
* fast/loader/display-image-unset-allows-cached-image-load.html: Added.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
* fast/loader/resources/image1.html: Added.
* fast/loader/resources/image2.html: Added.
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/chromium/permissionclient/resources/image.html:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Implement GraphicsLayer using Clutter
commit-queue@webkit.org [Mon, 24 Sep 2012 17:45:12 +0000 (17:45 +0000)]
[GTK] Implement GraphicsLayer using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73767

Source/WebCore:

Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

No new tests. This will be covered by pixel tests for Qt/GTK+ accelerated
compositing and 3D transforms.

* GNUmakefile.list.am:
* platform/clutter/GRefPtrClutter.cpp: Removed.
* platform/clutter/GRefPtrClutter.h: Removed.
* platform/graphics/clutter/PlatformClutterLayerClient.h: Added.
(WebCore):
(PlatformClutterLayerClient):
(WebCore::PlatformClutterLayerClient::~PlatformClutterLayerClient):
* platform/graphics/clutter/TransformationMatrixClutter.cpp: Added to convert CoglMatrix to
TransformationMatrix.
(WebCore):
(WebCore::TransformationMatrix::operator CoglMatrix):
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):

Source/WebKit/gtk:

Patch by Joone Hur <joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
(WebKit):

Source/WebKit2:

Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

Fixed link errors by adding Clutter library and header to WebKit2 build.

* GNUmakefile.am:

Source/WTF:

Patch by Joone Hur <joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

Add ClutterActor and GraphicsLayerActor to GTypedefs.h.

* wtf/gobject/GTypedefs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium linux/windows rebaseline for r129370.
eae@chromium.org [Mon, 24 Sep 2012 17:18:37 +0000 (17:18 +0000)]
Unreviewed chromium linux/windows rebaseline for r129370.

* platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
* platform/chromium-win/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnprefix IndexedDB
dgrogan@chromium.org [Mon, 24 Sep 2012 17:17:22 +0000 (17:17 +0000)]
Unprefix IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=96548

Reviewed by Adam Barth.

Source/WebCore:

We are largely compatible with the FF implementation and the w3c test
suite submitted by MS. The w3c test suite doesn't yet check
for lack of prefix; this is mostly to signal to devs that we think our
implementation is stable.

This patch uses the new FeatureObserver to get data about prefixed
vs unprefixed usage.

Tests: storage/indexeddb/unprefix-workers.html
       storage/indexeddb/unprefix.html

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
* Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
* Modules/indexeddb/DOMWindowIndexedDatabase.idl:
* Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
(WebCore::WorkerContextIndexedDatabase::indexedDB):
* Modules/indexeddb/WorkerContextIndexedDatabase.h:
(WorkerContextIndexedDatabase):
* Modules/indexeddb/WorkerContextIndexedDatabase.idl:
* bindings/generic/RuntimeEnabledFeatures.h:
Making the auxiliary objects RuntimeEnabled didn't make much sense as
they are useless without the factory, so always enable them.

(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* page/FeatureObserver.h:

LayoutTests:

* storage/indexeddb/resources/unprefix.js: Added.
(test):
* storage/indexeddb/unprefix-expected.txt: Added.
* storage/indexeddb/unprefix-workers-expected.txt: Added.
* storage/indexeddb/unprefix-workers.html: Added.
* storage/indexeddb/unprefix.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline gesture highlight test expectation images.
wjmaclean@chromium.org [Mon, 24 Sep 2012 17:10:53 +0000 (17:10 +0000)]
[chromium] Rebaseline gesture highlight test expectation images.
https://bugs.webkit.org/show_bug.cgi?id=97248

Reviewed by Yuta Kitamura.

Updating image baselines for gesture highlight tests. There are subtle changes in the rendering of
text in the target links, impercetable to the eye but ImageDiff picks them up.

* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png:
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script
commit-queue@webkit.org [Mon, 24 Sep 2012 16:59:18 +0000 (16:59 +0000)]
Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script
https://bugs.webkit.org/show_bug.cgi?id=96746

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

First step towards the 2D canvas instrumentation from the WebGL injected script module side.
We trace and save all calls that affect the 2D canvas context state and it's resources (Gradient and Pattern)
so that we could replay the context and resources states later.
The 2D canvas context state consists of:
- current transformation matrix
- current default path
- current clipping region (affected by the "clip" command)
- current values of the context attributes (like strokeStyle, fillStyle, etc.)
- a stack of saved drawing states (affected by the "save" and "restore" commands)

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 24 Sep 2012 16:36:47 +0000 (16:36 +0000)]
[EFL] Unreviewed gardening.

Skip a few tests unskipped in r129372 and r129375 that still fail
on the bots.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [TextEditor] conditional breakpoint popup not showing up the first...
commit-queue@webkit.org [Mon, 24 Sep 2012 16:36:20 +0000 (16:36 +0000)]
Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time
https://bugs.webkit.org/show_bug.cgi?id=97442

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

1) The conditional breakpoint popup may not show up the first time we click on the gutter.
This was the case because the popup decoration element would be deleted from the line while
it was being highlighted and appended afterwards. Now we do not remove decorations from the
DOM while highlighting.

2) Also the popup will close itself on any mouse click event, even if it's targeted to the
input box itself. This was due to pointer-events: none; CSS style for the parent element.
Now we just override this style for the input box.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._insertTextNodeBefore):
* inspector/front-end/inspector.css:
(.source-frame-breakpoint-condition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link...
carlosgc@webkit.org [Mon, 24 Sep 2012 16:32:05 +0000 (16:32 +0000)]
[GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link clicked navigation action
https://bugs.webkit.org/show_bug.cgi?id=97458

Reviewed by Xan Lopez.

WebKitWebView:is-loading is set to TRUE when the load is started
by using the API. We want to make sure that both URI and
is-loading are updated before load-started is emitted, so we can
update both right before emitting load-started.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewEmitLoadChanged): Update both uri and is-loading
properties before emitting load-changed signal with
WEBKIT_LOAD_STARTED.
(webkit_web_view_load_uri): Don't call
webkitWebViewSetIsLoading().
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 24 Sep 2012 16:25:16 +0000 (16:25 +0000)]
[EFL] Unreviewed gardening.

Move some inspector tests from Skipped to TestExpectations with a
proper explanation and related bug report.

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Modernize some esoteric tests
jsbell@chromium.org [Mon, 24 Sep 2012 16:19:55 +0000 (16:19 +0000)]
IndexedDB: Modernize some esoteric tests
https://bugs.webkit.org/show_bug.cgi?id=97368

Reviewed by Tony Chang.

Change the logging - but not the flow or assertions - of some of our
more complex tests, to take advantage of our newer helper functions.

* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/resources/factory-deletedatabase-interactions.js:
* storage/indexeddb/resources/open-close-version.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium rebaseline for video-zoom-controls for r129370.
eae@chromium.org [Mon, 24 Sep 2012 16:15:21 +0000 (16:15 +0000)]
Unreviewed chromium rebaseline for video-zoom-controls for r129370.

* platform/chromium-linux/media/video-zoom-controls-expected.txt: Added.
* platform/chromium-mac/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 24 Sep 2012 16:02:29 +0000 (16:02 +0000)]
[EFL] Unreviewed gardening.

Move a test that is failing on both WK1 and WK2 to the common
TestExpectations file.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 24 Sep 2012 15:58:41 +0000 (15:58 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Unskip passing inspector test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable...
commit-queue@webkit.org [Mon, 24 Sep 2012 15:47:15 +0000 (15:47 +0000)]
Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command
https://bugs.webkit.org/show_bug.cgi?id=97331

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.

* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add setters to WebFilterOperation for IPC pickling
danakj@chromium.org [Mon, 24 Sep 2012 15:46:53 +0000 (15:46 +0000)]
[chromium] Add setters to WebFilterOperation for IPC pickling
https://bugs.webkit.org/show_bug.cgi?id=97147

Reviewed by James Robinson.

Source/Platform:

These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.

Test: WebFilterOperationsTest.saveAndRestore

* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):
* chromium/src/WebFilterOperation.cpp:

Source/WebKit/chromium:

* tests/FilterOperationsTest.cpp:
(WebKit):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 24 Sep 2012 15:44:46 +0000 (15:44 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/Skipped: Unskip a few inspector-related tests which
are currently passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
paroga@webkit.org [Mon, 24 Sep 2012 15:38:03 +0000 (15:38 +0000)]
Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
https://bugs.webkit.org/show_bug.cgi?id=97412

Reviewed by Adam Barth.

Source/WebCore:

* css/StylePropertySet.cpp: Removed useless define.

Source/WebKit/chromium:

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
(WebKit::WebPageSerializerImpl::endTagToString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosnapToSize rounds the incorrectly for negative locations
eae@chromium.org [Mon, 24 Sep 2012 15:35:12 +0000 (15:35 +0000)]
snapToSize rounds the incorrectly for negative locations
https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

* platform/FractionalLayoutUnit.h:
(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

* fast/sub-pixel/snap-negative-location-expected.html: Added.
* fast/sub-pixel/snap-negative-location.html: Added.
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow robots to index bugs on Bugzilla
peter@chromium.org [Mon, 24 Sep 2012 15:33:42 +0000 (15:33 +0000)]
Allow robots to index bugs on Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=95688

Reviewed by Eric Seidel.

This allows robots to access show_bug.cgi, thus granting them access to
index contents and discussion on WebKit bugs. All other pages, except
for the site index itself, still have indexing disabled.

* robots.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMIPS: store8 functions added to MacroAssembler.
commit-queue@webkit.org [Mon, 24 Sep 2012 15:05:25 +0000 (15:05 +0000)]
MIPS: store8 functions added to MacroAssembler.

MIPS store8 functions
https://bugs.webkit.org/show_bug.cgi?id=97243

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-09-24
Reviewed by Oliver Hunt.

Add MIPS store8 functions.

* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::lhu): New function.
(MIPSAssembler):
(JSC::MIPSAssembler::sb): New function.
(JSC::MIPSAssembler::sh): New function.
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::store8): New function.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::store16): New function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash...
zandobersek@gmail.com [Mon, 24 Sep 2012 14:53:08 +0000 (14:53 +0000)]
REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=97404

Reviewed by Philippe Normand.

Tools:

Print out the 'didReceiveTitle' information when dumping frame load callbacks.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewTitleChanged):

LayoutTests:

Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse unsigned char for bitfield instead of unsigned.
commit-queue@webkit.org [Mon, 24 Sep 2012 14:40:16 +0000 (14:40 +0000)]
Use unsigned char for bitfield instead of unsigned.
https://bugs.webkit.org/show_bug.cgi?id=97447

Patch by Jonathan Liu <net147@gmail.com> on 2012-09-24
Reviewed by Andreas Kling.

Not all compilers will pad an unsigned bitfield to the smallest size.
Use unsigned char instead of unsigned to reduce padding for compilers
that pad to the underlying type.

No new tests. There is already a compile-time assertion.

* css/CSSRule.cpp:
(SameSizeAsCSSRule):
* css/CSSRule.h:
(CSSRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rebaseline several test cases in Skipped list
commit-queue@webkit.org [Mon, 24 Sep 2012 14:28:12 +0000 (14:28 +0000)]
[EFL] Rebaseline several test cases in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97452

Unreviewed EFL rebaseline.

Rebaseline several test cases in the EFL Skipped file
and unskip them.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24

* platform/efl/Skipped:
* platform/efl/fast/table/prepend-in-anonymous-table-expected.png:
* platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/efl/fast/text/basic/011-expected.png:
* platform/efl/fast/text/basic/011-expected.txt:
* platform/efl/fast/text/basic/013-expected.png:
* platform/efl/fast/text/basic/013-expected.txt:
* platform/efl/fast/text/bidi-embedding-pop-and-push-same-expected.png:
* platform/efl/fast/text/capitalize-boundaries-expected.png:
* platform/efl/fast/text/capitalize-boundaries-expected.txt:
* platform/efl/fast/text/cg-fallback-bolding-expected.png:
* platform/efl/fast/text/drawBidiText-expected.png:
* platform/efl/fast/text/emphasis-vertical-expected.png:
* platform/efl/fast/text/emphasis-vertical-expected.txt:
* platform/efl/fast/text/fallback-traits-fixup-expected.png:
* platform/efl/fast/text/fallback-traits-fixup-expected.txt:
* platform/efl/fast/text/firstline/001-expected.png:
* platform/efl/fast/text/firstline/001-expected.txt:
* platform/efl/fast/text/firstline/002-expected.png:
* platform/efl/fast/text/firstline/003-expected.png:
* platform/efl/fast/text/format-control-expected.png:
* platform/efl/fast/text/format-control-expected.txt:
* platform/efl/fast/text/hyphens-expected.png:
* platform/efl/fast/text/hyphens-expected.txt:
* platform/efl/fast/text/in-rendered-text-rtl-expected.png:
* platform/efl/fast/text/international/001-expected.png:
* platform/efl/fast/text/international/001-expected.txt:
* platform/efl/fast/text/international/002-expected.png:
* platform/efl/fast/text/international/002-expected.txt:
* platform/efl/fast/text/international/003-expected.png:
* platform/efl/fast/text/international/003-expected.txt:
* platform/efl/fast/text/international/bidi-L2-run-reordering-expected.png:
* platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/efl/fast/text/international/bidi-european-terminators-expected.png:
* platform/efl/fast/text/international/bidi-explicit-embedding-expected.png:
* platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/efl/fast/text/international/bidi-innertext-expected.png:
* platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/efl/fast/text/international/bidi-listbox-expected.png:
* platform/efl/fast/text/international/bidi-listbox-expected.txt: Added.
* platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
* platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/efl/fast/text/international/bidi-override-expected.png:
* platform/efl/fast/text/international/bidi-override-expected.txt: Added.
* platform/efl/fast/text/international/rtl-caret-expected.png:
* platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.png:
* platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
* platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
* platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/efl/fast/text/international/wrap-CJK-001-expected.png:
* platform/efl/fast/text/international/wrap-CJK-001-expected.txt:
* platform/efl/fast/text/midword-break-hang-expected.png:
* platform/efl/fast/text/midword-break-hang-expected.txt:
* platform/efl/fast/text/trailing-white-space-2-expected.png:
* platform/efl/fast/text/trailing-white-space-expected.png:
* platform/efl/fast/text/whitespace/024-expected.png:
* platform/efl/fast/text/whitespace/024-expected.txt:
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/efl/fast/writing-mode/border-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/fallback-orientation-expected.png:
* platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
* platform/efl/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
* platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt:
* platform/efl/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/efl/svg/as-border-image/svg-as-border-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: don't allow exception in front-end when expanding function scope
commit-queue@webkit.org [Mon, 24 Sep 2012 14:10:10 +0000 (14:10 +0000)]
Web Inspector: don't allow exception in front-end when expanding function scope
https://bugs.webkit.org/show_bug.cgi?id=97346

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

A missing guard condition is added.

* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviwed gardening. Skip new failing test.
rgabor@webkit.org [Mon, 24 Sep 2012 14:01:26 +0000 (14:01 +0000)]
[Qt] Unreviwed gardening. Skip new failing test.
https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-24

* platform/qt/Skipped: Skip inspector-protocol/css-getSupportedCSSProperties.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Mark fast/forms/select/select-state-restore.html as flaky
commit-queue@webkit.org [Mon, 24 Sep 2012 13:39:36 +0000 (13:39 +0000)]
[EFL][WK2] Mark fast/forms/select/select-state-restore.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=97449

Unreviewed EFL gardening.

fast/forms/select/select-state-restore.html sometimes times out on
the WebKit2 EFL debug build bot. Add it to TestExpectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add cookie database API
anilsson@rim.com [Mon, 24 Sep 2012 13:34:15 +0000 (13:34 +0000)]
[BlackBerry] Add cookie database API
https://bugs.webkit.org/show_bug.cgi?id=97102

Reviewed by Antonio Gomes.

Source/WebCore:

Add a CookieManager method that takes a list of strings to parse
instead of just one string. Expose CookieParser::parseOneCookie.

Reviewed internally by Otto D. Cheung.

No change in behavior, no new tests.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
(WebCore):
* platform/blackberry/CookieParser.h:
(CookieParser):

Source/WebKit:

Add cookie database file to build system.

Reviewed internally by Otto D. Cheung.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The cookie database is exposed through WebCookieJar, which has only two
methods: cookies() and setCookies().

Also add a new WebString::fromUTF8 overload that takes a const char*
and a length, in order to avoid a strlen call when converting from
other string classes to WebString. This is useful for callers of the
new cookie API when converting cookies to WebString.

Reviewed internally by Otto D. Cheung.

PR 209282

* Api/WebCookieJar.cpp: Added.
(WebKit):
(BlackBerry::WebKit::WebCookieJar::WebCookieJar):
(BlackBerry::WebKit::WebCookieJar::cookies):
(BlackBerry::WebKit::WebCookieJar::setCookies):
* Api/WebCookieJar.h: Added.
(WebKit):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::cookieJar):
(WebKit):
* Api/WebPage.h:
(WebKit):
* Api/WebPage_p.h:
(WebKit):
(WebPagePrivate):
* Api/WebString.cpp:
(BlackBerry::WebKit::WebString::fromUtf8):
(WebKit):
* Api/WebString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Open resource dialog has too many false positive matches.
vsevik@chromium.org [Mon, 24 Sep 2012 13:17:23 +0000 (13:17 +0000)]
Web Inspector: Open resource dialog has too many false positive matches.
https://bugs.webkit.org/show_bug.cgi?id=97332

Reviewed by Alexander Pavlov.

Source/WebCore:

Improved open resource dialog filtering to make the amount of false
positive search results less.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rebaseline several test cases in Skipped list
commit-queue@webkit.org [Mon, 24 Sep 2012 13:14:57 +0000 (13:14 +0000)]
[EFL] Rebaseline several test cases in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97448

Unreviewed EFL rebaseline.

Rebaseline several test cases in the Skipped file and unskip
them.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24

* platform/efl/Skipped:
* platform/efl/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/efl/svg/as-image/animated-svg-as-image-expected.txt:
* platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
* platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt:
* platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
* platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
* platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
* platform/efl/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/efl/svg/as-image/same-image-two-instances-expected.txt:
* platform/efl/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/efl/svg/as-image/svg-image-change-content-size-expected.txt:
* platform/efl/svg/batik/masking/maskRegions-expected.png: Added.
* platform/efl/svg/batik/masking/maskRegions-expected.txt:
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
* platform/efl/svg/css/path-gradient-stroke-shadow-expected.png: Added.
* platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt:
* platform/efl/svg/dom/css-transforms-expected.png: Added.
* platform/efl/svg/dom/css-transforms-expected.txt: Added.
* platform/efl/svg/hixie/error/012-expected.png: Added.
* platform/efl/svg/hixie/error/012-expected.txt:
* platform/efl/svg/hixie/error/013-expected.png: Added.
* platform/efl/svg/hixie/error/013-expected.txt:
* platform/efl/svg/hixie/mixed/003-expected.png: Added.
* platform/efl/svg/hixie/mixed/003-expected.txt:
* platform/efl/svg/hixie/mixed/004-expected.png: Added.
* platform/efl/svg/hixie/mixed/004-expected.txt:
* platform/efl/svg/hixie/mixed/005-expected.png: Added.
* platform/efl/svg/hixie/mixed/005-expected.txt:
* platform/efl/svg/hixie/mixed/006-expected.png: Added.
* platform/efl/svg/hixie/mixed/006-expected.txt:
* platform/efl/svg/hixie/mixed/007-expected.png: Added.
* platform/efl/svg/hixie/mixed/007-expected.txt:
* platform/efl/svg/hixie/mixed/008-expected.png: Added.
* platform/efl/svg/hixie/mixed/008-expected.txt:
* platform/efl/svg/hixie/mixed/009-expected.png: Added.
* platform/efl/svg/hixie/mixed/009-expected.txt:
* platform/efl/svg/hixie/mixed/010-expected.png: Added.
* platform/efl/svg/hixie/mixed/010-expected.txt:
* platform/efl/svg/hixie/mixed/011-expected.png: Added.
* platform/efl/svg/hixie/mixed/011-expected.txt:
* platform/efl/svg/hixie/perf/007-expected.png: Added.
* platform/efl/svg/hixie/perf/007-expected.txt:
* platform/efl/svg/hixie/processing-model/003-expected.png: Added.
* platform/efl/svg/hixie/processing-model/003-expected.txt:
* platform/efl/svg/hixie/processing-model/004-expected.png: Added.
* platform/efl/svg/hixie/processing-model/004-expected.txt:
* platform/efl/svg/hixie/rendering-model/003-expected.png: Added.
* platform/efl/svg/hixie/rendering-model/003-expected.txt:
* platform/efl/svg/hixie/rendering-model/004-expected.png: Added.
* platform/efl/svg/hixie/rendering-model/004-expected.txt:
* platform/efl/svg/hixie/text/003-expected.png: Added.
* platform/efl/svg/hixie/text/003-expected.txt:
* platform/efl/svg/in-html/by-reference-expected.png: Added.
* platform/efl/svg/in-html/by-reference-expected.txt:
* platform/efl/svg/in-html/circle-expected.png: Added.
* platform/efl/svg/in-html/circle-expected.txt:
* platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt:
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
* platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
* platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
* platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt:
* platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
* platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt:
* platform/efl/svg/transforms/svg-css-transforms-expected.png: Added.
* platform/efl/svg/transforms/svg-css-transforms-expected.txt:
* platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
* platform/efl/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/efl/svg/wicd/rightsizing-grid-expected.txt:
* platform/efl/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/efl/svg/wicd/test-rightsizing-a-expected.txt:
* platform/efl/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/efl/svg/wicd/test-rightsizing-b-expected.txt:
* platform/efl/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/efl/svg/wicd/test-scalable-background-image1-expected.txt:
* platform/efl/svg/wicd/test-scalable-background-image2-expected.png: Added.
* platform/efl/svg/wicd/test-scalable-background-image2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++...
commit-queue@webkit.org [Mon, 24 Sep 2012 13:01:29 +0000 (13:01 +0000)]
Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so.
commit-queue@webkit.org [Mon, 24 Sep 2012 12:31:54 +0000 (12:31 +0000)]
[EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so.
https://bugs.webkit.org/show_bug.cgi?id=97302

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

libewk2UnitTestInjectedBundleSample.so file is created under the
Source directory.
Change install directory for the library to under the build directory.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
pfeldman@chromium.org [Mon, 24 Sep 2012 12:14:16 +0000 (12:14 +0000)]
Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unskip proper shadow dom test case
commit-queue@webkit.org [Mon, 24 Sep 2012 12:09:17 +0000 (12:09 +0000)]
[EFL] Unskip proper shadow dom test case
https://bugs.webkit.org/show_bug.cgi?id=97445

Unreviewed EFL gardening.

Skip again fast/dom/shadow/shadowdom-for-object-without-shadow.html
and unskip fast/dom/shadow/shadowdom-for-object-only-shadow.html
instead.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when...
apavlov@chromium.org [Mon, 24 Sep 2012 11:55:46 +0000 (11:55 +0000)]
Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.enterInspectElementMode):
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129348 268f45cc-cd09-0410-ab3c-d52691b4dbfc