WebKit-https.git
8 years ago[Gtk] Several tests launch g_object_ref/unref assertion messages
zandobersek@gmail.com [Tue, 2 Oct 2012 17:00:24 +0000 (17:00 +0000)]
[Gtk] Several tests launch g_object_ref/unref assertion messages
https://bugs.webkit.org/show_bug.cgi?id=95062

Reviewed by Martin Robinson.

Only increase and decrease reference count of the accessibility
UI element if it actually exists.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove comments from the Apache config files to start avoiding useless duplication.
rakuco@webkit.org [Tue, 2 Oct 2012 16:57:05 +0000 (16:57 +0000)]
Remove comments from the Apache config files to start avoiding useless duplication.
https://bugs.webkit.org/show_bug.cgi?id=98152

Reviewed by Laszlo Gombos.

This is the first step towards getting rid of the multiple, almost
identical Apache httpd.conf files we have in the tree.

Before anything else, remove the default comments from them to
reduce the diff in later commits.

* http/conf/apache2-debian-httpd.conf:
* http/conf/apache2-httpd.conf:
* http/conf/apache2-msys-httpd.conf:
* http/conf/cygwin-httpd.conf:
* http/conf/fedora-httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix after r130135. Dromaeo tests only report single memory value,
rniwa@webkit.org [Tue, 2 Oct 2012 16:52:09 +0000 (16:52 +0000)]
Build fix after r130135. Dromaeo tests only report single memory value,
and computeStatistics should report variance as 0 in such cases.

* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add field to WebRenderingStats to track if we have impl-thread scrolled
commit-queue@webkit.org [Tue, 2 Oct 2012 16:49:44 +0000 (16:49 +0000)]
[chromium] Add field to WebRenderingStats to track if we have impl-thread scrolled
https://bugs.webkit.org/show_bug.cgi?id=97919

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-02
Reviewed by James Robinson.

Add two new members |numImplThreadScrolls| and |numMainThreadScrolls| to track
the total number of times we have impl-thread scrolled and main-thread scrolled,
respectively.

* chromium/public/WebRenderingStats.h:
(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
(WebKit::WebRenderingStats::enumerateFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] running layout tests on mountainlion should use chromium TestExpectations
commit-queue@webkit.org [Tue, 2 Oct 2012 16:49:03 +0000 (16:49 +0000)]
[chromium] running layout tests on mountainlion should use chromium TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98119

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-02
Reviewed by Adam Barth.

Some basic support for mountainlion has already been committed but it failed to refer
to the chromium TestExpectations.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_all_test_configurations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove call to FinishAllRendering when in force-compositing-mode.
vangelis@chromium.org [Tue, 2 Oct 2012 16:45:23 +0000 (16:45 +0000)]
Remove call to FinishAllRendering when in force-compositing-mode.
https://bugs.webkit.org/show_bug.cgi?id=98111

It's not needed and makes the renderer synchronously wait for a glFinish
to happen in the gpu process.

Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] ShadowRoot should know whether <shadow> in its treescope
commit-queue@webkit.org [Tue, 2 Oct 2012 16:28:43 +0000 (16:28 +0000)]
[Shadow] ShadowRoot should know whether <shadow> in its treescope
https://bugs.webkit.org/show_bug.cgi?id=97184

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-02
Reviewed by Dimitri Glazkov.

Source/WebCore:

To quickly know whether some shadow dom subtree has any shadow element
or not, added hasShadowRootInsertionPoint, registerShadowElement and
unregisterShadowElement to class ShadowRoot. The register method or
unregister method is used when a shadow element is inserted into
document or removed from document. hasShadowInsertionPoint returns true
if any shadow element is still registered with the given shadow root.
Otherwise returns false. To test hasShadowInsertionPoint, added
hasShadowInsertionPoint to Internals.

Test: fast/dom/shadow/has-shadow-insertion-point.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
Initializes number of shadow elements.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::registerShadowElement):
Increases number of shadow elements in shadow dom subtree by 1.
(WebCore::ShadowRoot::unregisterShadowElement):
Decreases number of shadow elements in shadow dom subtree by 1.
(WebCore::ShadowRoot::hasShadowInsertionPoint):
If number of shadow elements in shadow dom subtree is not equal to 0,
returns true. Otherwise, returns false.
* html/shadow/HTMLShadowElement.cpp:
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::insertedInto):
If a shadow element is inserted into document, register the shadow
element with its shadow root.
(WebCore::HTMLShadowElement::removedFrom):
 If a shadow element is removed from document, unregister the shadow
element with its shadow root.
* html/shadow/HTMLShadowElement.h:
Added a new member variable which has information about whether
this shadow element has been already registered with its shadow root
or not.
* testing/Internals.cpp:
(WebCore::Internals::hasShadowInsertionPoint):
Added a new testing method which returns whether the given shadow
root has any shadow element or not.
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/has-shadow-insertion-point-expected.txt: Added.
* fast/dom/shadow/has-shadow-insertion-point.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Stop listening on port 8081 when using Apache.
rakuco@webkit.org [Tue, 2 Oct 2012 16:22:55 +0000 (16:22 +0000)]
webkitpy: Stop listening on port 8081 when using Apache.
https://bugs.webkit.org/show_bug.cgi?id=98155

Reviewed by Eric Seidel.

No test currently uses this port, and the lighttpd configuration
does not open it.

This helps the efforts of bringing some consistency to the Apache
configuration at the moment by opening the same ports in the
webkitpy side and in the httpd.conf side (the idea is to remove
the httpd.conf side later), and also makes the behavior consistent
across the two servers we currently support.

* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit: [EFL] Add file EWKTestEnvironment.cpp to build system.
commit-queue@webkit.org [Tue, 2 Oct 2012 15:59:51 +0000 (15:59 +0000)]
Source/WebKit: [EFL] Add file EWKTestEnvironment.cpp to build system.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
Reviewed by Gyuyoung Kim.

Change is related to modifications in wk1 unit tests.

* PlatformEfl.cmake:

Source/WebKit/efl: [EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
Reviewed by Gyuyoung Kim.

The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase):
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
* tests/UnitTestUtils/EWKTestBase.h:
* tests/UnitTestUtils/EWKTestEnvironment.cpp:
Used to have global SetUp and TearDown.
Global SetUp starts initialization of webkit wherease
global TearDown shuts it down. Generally we would like to have
only one initialization of webkit while tests are executed.
(EWKUnitTests):
(EWKUnitTests::EWKTestEnvironment::EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::SetUp): Starts initialization of webkit.
(EWKUnitTests::EWKTestEnvironment::TearDown): Shuts down of webkit.
* tests/UnitTestUtils/EWKTestEnvironment.h:
(EWKUnitTests):
(EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::useX11Window):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Starts initialization of test view.
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
* tests/test_ewk_view.cpp: adjusted current unit tests to new implementation.
(TEST_F):
* tests/test_runner.cpp: entry point of all tests.
(parseCustomArguments):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r130167 and r130171.
vsevik@chromium.org [Tue, 2 Oct 2012 15:45:04 +0000 (15:45 +0000)]
Unreviewed, rolling out r130167 and r130171.
http://trac.webkit.org/changeset/130167
http://trac.webkit.org/changeset/130171
https://bugs.webkit.org/show_bug.cgi?id=98165

Breaks test (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] inspector/extensions/extensions-network.html times out
michael.bruning@digia.com [Tue, 2 Oct 2012 15:43:29 +0000 (15:43 +0000)]
[Qt][WK2] inspector/extensions/extensions-network.html times out
https://bugs.webkit.org/show_bug.cgi?id=98136

Unreviewed gardening.

WebInspectorProxy::platformCreateInspectorPage() is not implemented for
the Qt 5.0 WK2 port.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] DevToolsExtensionTest.TestContentScriptIsPresent fails
vsevik@chromium.org [Tue, 2 Oct 2012 15:22:40 +0000 (15:22 +0000)]
Web Inspector: [Regression] DevToolsExtensionTest.TestContentScriptIsPresent fails
https://bugs.webkit.org/show_bug.cgi?id=98161

Reviewed by Pavel Feldman.

Content scripts should be also added by NetworkUISourceCodeProvider. This patch fixes that.

* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip one more failing test.
ossy@webkit.org [Tue, 2 Oct 2012 15:04:44 +0000 (15:04 +0000)]
[Qt] Unreviewed gardening, skip one more failing test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new crashing tests to paint the bots green.
ossy@webkit.org [Tue, 2 Oct 2012 14:53:19 +0000 (14:53 +0000)]
[Qt] Unreviewed gardening, skip new crashing tests to paint the bots green.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] PageViewportControllerClient.h uses WebCore class without declaring them
hugo.lima@openbossa.org [Tue, 2 Oct 2012 14:51:56 +0000 (14:51 +0000)]
[WK2] PageViewportControllerClient.h uses WebCore class without declaring them
https://bugs.webkit.org/show_bug.cgi?id=98070

Reviewed by Kenneth Rohde Christiansen.

This patch just add forward declarations for code correctness.

* UIProcess/PageViewportControllerClient.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix tst_QQuickWebView::scrollRequest after r130029
jocelyn.turcotte@digia.com [Tue, 2 Oct 2012 14:37:21 +0000 (14:37 +0000)]
Fix tst_QQuickWebView::scrollRequest after r130029
https://bugs.webkit.org/show_bug.cgi?id=98045

Reviewed by Simon Hausmann.

The test needs to show the window and wait for the loadVisuallyCommitted()
signal like did in the QML API auto tests.

* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):
* UIProcess/API/qt/tests/util.cpp:
(waitForViewportReady):
* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed inspector test fix.
vsevik@chromium.org [Tue, 2 Oct 2012 14:23:32 +0000 (14:23 +0000)]
Unreviewed inspector test fix.

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Use correct gtest macro for testing true/false
commit-queue@webkit.org [Tue, 2 Oct 2012 14:05:57 +0000 (14:05 +0000)]
[EFL][WK2] Use correct gtest macro for testing true/false
https://bugs.webkit.org/show_bug.cgi?id=98142

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-02
Reviewed by Laszlo Gombos.

Using EXPECT_EQ(true/false, ...) makes clang trip when it tries to convert
true/false to a pointer. Tests should use EXPECT_TRUE/FALSE instead.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(showPopupMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WINCE] Remove FontPlatformData::averageCharWidth()
paroga@webkit.org [Tue, 2 Oct 2012 13:36:02 +0000 (13:36 +0000)]
[WINCE] Remove FontPlatformData::averageCharWidth()
https://bugs.webkit.org/show_bug.cgi?id=97883

Reviewed by Andreas Kling.

Use SimpleFontData::avgCharWidth() instead to remove duplicated code.

* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
* platform/graphics/wince/FontPlatformData.h:
(FontPlatformData):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Removed erroneously added custom expectation.
caseq@chromium.org [Tue, 2 Oct 2012 13:32:35 +0000 (13:32 +0000)]
Unreviewed. Removed erroneously added custom expectation.

* platform/chromium-win/inspector/console/command-line-api-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] REGRESSION(r128623): It made layout tests extremely slow
ossy@webkit.org [Tue, 2 Oct 2012 13:30:07 +0000 (13:30 +0000)]
[WK2] REGRESSION(r128623): It made layout tests extremely slow
https://bugs.webkit.org/show_bug.cgi?id=96862

Reviewed by Simon Hausmann.

Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: Rebaselined failing inspector test.
pfeldman@chromium.org [Tue, 2 Oct 2012 13:21:03 +0000 (13:21 +0000)]
Not reviewed: Rebaselined failing inspector test.

* inspector/console/command-line-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test rebaseline.
caseq@chromium.org [Tue, 2 Oct 2012 13:14:57 +0000 (13:14 +0000)]
Unreviewed test rebaseline.

* platform/chromium-win/inspector/console/command-line-api-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor WebCore::FontData handling to clarify pointer ownership
schenney@chromium.org [Tue, 2 Oct 2012 13:03:18 +0000 (13:03 +0000)]
Refactor WebCore::FontData handling to clarify pointer ownership
https://bugs.webkit.org/show_bug.cgi?id=95866

Reviewed by Eric Seidel.

Re-commit for a rolled-out original, now with Chromium Windows build fix.

This patch makes all FontData and derived classes ref-counted in all
code paths that lead to caching or other retention of a
pointer. The goal is to avert crashes and memory leaks, and to bring
the code more in line with current WebKit practices.

Specifically, this patch allows us to use ref pointers for all the
FontData stored in FontFallbackList objects. The FontFallbackList can
then own custom font data and manage its lifetime (forthcoming patch).
Currently Document owns custom font data and does an end run around
FontFallbackList in deleting glyph pages and custom font data, leaving
FontFallbackList with invalid pointers.

All FontData derived classes have been switched to use static create
methods with private constructors.

All caches that hold FontData now use RefPtrs.

All methods that construct new font data now return PassRefPtr, with the
exception of code only used to generate temporary data for text run layout.

All methods that handle FontData in a call stack that passes through
FontFallbackList::fontDataAt return PassRefPtr.

Performance tested with both WebKit Perf-o-matic, which showed
performance changes in the noise, and Chrome's page cycling tests with
the acid3 benchmark set, which showed no performance difference at all.

No new tests as this is refactoring code only and has no impact on functionality.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::getFontData):
* css/CSSFontFace.h:
(CSSFontFace):
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
(CSSFontFaceSource):
* css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):
* css/CSSSegmentedFontFace.h:
(CSSSegmentedFontFace):
* dom/Document.cpp:
(WebCore::Document::registerCustomFont):
* dom/Document.h:
(Document):
* platform/graphics/Font.h:
(WebCore):
* platform/graphics/FontCache.cpp:
(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):
* platform/graphics/FontCache.h:
(FontCache):
* platform/graphics/FontData.h:
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/FontFallbackList.h:
(FontFallbackList):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
* platform/graphics/FontSelector.h:
(FontSelector):
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
* platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
* platform/graphics/SegmentedFontData.h:
(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(WebCore::SegmentedFontData::create):
(SegmentedFontData):
(WebCore::SegmentedFontData::SegmentedFontData):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::create):
(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):
* platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Value not returned warning with geolocation disabled
commit-queue@webkit.org [Tue, 2 Oct 2012 12:52:30 +0000 (12:52 +0000)]
[GTK] Value not returned warning with geolocation disabled
https://bugs.webkit.org/show_bug.cgi?id=98148

Patch by Adrian Perez de Castro <aperez@igalia.com> on 2012-10-02
Reviewed by Xan Lopez.

With geolocation disabled in the build, return a sensible value from
DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests.
This also avoids a compiler warning.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[XMLHttpRequest] overrideMimeType(mime) does not update the response's "Content-Type...
commit-queue@webkit.org [Tue, 2 Oct 2012 12:46:38 +0000 (12:46 +0000)]
[XMLHttpRequest] overrideMimeType(mime) does not update the response's "Content-Type" header
https://bugs.webkit.org/show_bug.cgi?id=98137

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-02
Reviewed by Kentaro Hara.

Source/WebCore:

According to the XMLHttpRequest specification, overrideMimeType(mime) sets the
"Content-Type" header for the response to mime. However, with the current
implementation, calling overrideMimeType(mime) does not affect the value
returned by client.getResponseHeader("Content-Type"). This patch makes sure
the response's "Content-Type" header is properly updated with the override
MIME type.

Test: http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReceiveResponse):

LayoutTests:

Add layout test to check that calling overrideMimeType(mime) properly
sets the response's "Content-Type" header to mime.

* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
caseq@chromium.org [Tue, 2 Oct 2012 12:41:04 +0000 (12:41 +0000)]
Unreviewed gardening.
Remove entry for bidi-layout-across-linebreak.html, reinstated meter-optimiums.html as flaky on Mac.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed inspector test fix on JSC.
vsevik@chromium.org [Tue, 2 Oct 2012 12:34:51 +0000 (12:34 +0000)]
Unreviewed inspector test fix on JSC.
https://bugs.webkit.org/show_bug.cgi?id=98145

* inspector/debugger/script-snippet-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Move UISourceCode creation out from ResourceScriptMapping.
vsevik@chromium.org [Tue, 2 Oct 2012 12:13:00 +0000 (12:13 +0000)]
Web Inspector: Move UISourceCode creation out from ResourceScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=97680

Reviewed by Pavel Feldman.

Source/WebCore:

UISourceCodes for scripts having sourceURL are now created by NetworkUISourceCodeProvider.
UISourceCodes for anonymous, dynamic and concatenated scripts are now created on demand only.
All UISourceCodes created by ResourceScriptMapping are now "temporary".
Temporary UISourceCodes are not stored in workspace and removed when a normal UISourceCode with the same url is available.
UISourceCodeReplaced event was replaced with TemporaryUISourceCodeAdded/Removed events.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.Breakpoint.prototype.remove):
* inspector/front-end/NavigatorView.js:
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
(WebInspector.ResourceScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._isDynamicScript):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode.get if):
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
* inspector/front-end/UISourceCode.js:
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype.addTemporaryUISourceCode):
(WebInspector.Project.prototype.removeTemporaryUISourceCode):

LayoutTests:

* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent.temporaryUISourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent.temporaryUISourceCodeRemoved):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent):
* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/resource-script-mapping.html:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix front-end compilation
pfeldman@chromium.org [Tue, 2 Oct 2012 12:09:30 +0000 (12:09 +0000)]
Web Inspector: fix front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=98135

Reviewed by Vsevolod Vlasov.

Fixing front-end compilation errors.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/DOMExtension.js:
(Element.prototype.pruneEmptyTextNodes):
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/ExtensionAPI.js:
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/RuntimeModel.js:
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.expandRecursively):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 2 Oct 2012 11:44:06 +0000 (11:44 +0000)]
Unreviewed GTK gardening.

Rebaselining MathML tests as required after r129695 and r130097.
Adding a missing baseline expectation for accessibility/svg-bounds.html.
The baseline will be added soon-ish.

* platform/gtk/TestExpectations:
* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/tables-expected.png:
* platform/gtk/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] ASSERT that the embedder has set a default locale
jochen@chromium.org [Tue, 2 Oct 2012 11:41:17 +0000 (11:41 +0000)]
[chromium] ASSERT that the embedder has set a default locale
https://bugs.webkit.org/show_bug.cgi?id=98001

Reviewed by Adam Barth.

The callsites assume that the default language is always defined, e.g.
Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
doesn't have to guess what they did wrong.

* platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Fix JavaScriptSource error found by compiler
vsevik@chromium.org [Tue, 2 Oct 2012 11:33:12 +0000 (11:33 +0000)]
Web Inspector: Fix JavaScriptSource error found by compiler
https://bugs.webkit.org/show_bug.cgi?id=98143

Reviewed by Pavel Feldman.

* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd call stacks to Content Security Policy checks when relevant.
mkwst@chromium.org [Tue, 2 Oct 2012 11:29:33 +0000 (11:29 +0000)]
Add call stacks to Content Security Policy checks when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94433

Reviewed by Adam Barth.

Source/WebCore:

Previously, we generated stack traces only for eval-related CSP
violations. As it turns out, we can call createScriptCallStack from
practically anywhere. This patch takes advantage of that to generate
stack traces whenever a warning is logged to the console. If we're in
a JavaScript stack, brilliant: we get a detailed warning. If not, the
stack trace is empty, and we don't pass it into the console logging
method.

This has the advantage of giving us good developer-facing logging for
any and all violations that result from script-based injection of
resources. Yay!

Tests: http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html
       http/tests/inspector/csp-inline-warning-contains-stacktrace.html
       http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html
       http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html

* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
    Replacing the generated stack trace with the current script state,
    which will enable us to generate the stack trace inside
    ContentSecurityPolicy::reportViolation if it's relevant.
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
(WebCore):
* bindings/v8/ScriptCallStackFactory.h:
(WebCore):
    Adding a dummy interface to createScriptCallStackForConsole that
    allows ScriptState to be passed in, which matches JSC's interface.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
    Dropping stack trace from call to ContentSecurityPolicy::allowEval.
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowEval):
    Piping script state through from CSPDirectiveList::allowEval rather
    than a full stack trace.
(WebCore):
(WebCore::isAllowedByAll):
(WebCore::isAllowedByAllWithState):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):
    Piping script state through from ContentSecurityPolicy::allowEval
    rather than a full stack trace. Now, we can simply generate the
    stack trace just before logging it, and only pass it into
    addConsoleMessage if it's non-empty.
* page/ContentSecurityPolicy.h:
(JSC):
(WebCore):
    Including 'ScriptState.h' to normalize V8 and JSC's JS state objects.

LayoutTests:

* http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval-expected.txt: Removed.
* http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html: Removed.
* http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout-expected.txt: Removed.
* http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html: Removed.
    Moved these tests to http/test/inspector, and rewrote them for consistency.
* http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
* http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html: Added.
* http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
* http/tests/inspector/csp-inline-warning-contains-stacktrace.html: Added.
* http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
* http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html: Added.
* http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.
* http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html: Added.
* http/tests/inspector/resources/csp-inline-test.js: Added.
(thisTest):
* http/tests/inspector/resources/csp-test.js: Added.
(test.addMessage):
(test):
    Two new tests for the functionality.
* platform/chromium/http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
* platform/chromium/http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
* platform/chromium/http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
* platform/chromium/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.
    The stacktrace looks slightly different under JSC than V8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: migrate from WebInspector.Foo.prototype.__proto__ = to __proto__:...
pfeldman@chromium.org [Tue, 2 Oct 2012 11:02:36 +0000 (11:02 +0000)]
Web Inspector: migrate from WebInspector.Foo.prototype.__proto__ = to __proto__: syntax
https://bugs.webkit.org/show_bug.cgi?id=98127

Reviewed by Vsevolod Vlasov.

Converted with the regex matcher.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/compile-front-end.py:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype._onAction):
(WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):
* inspector/front-end/ApplicationCacheItemsView.js:
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
* inspector/front-end/AuditCategories.js:
(WebInspector.AuditCategories.PagePerformance.prototype.initialize):
(WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditResultView.js:
(WebInspector.AuditCategoryResultPane.prototype._appendResult):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._clearButtonClicked):
(WebInspector.AuditsSidebarTreeElement.prototype.refresh):
(WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
(WebInspector.XHRBreakpointsSidebarPane.prototype.set _restoreBreakpoints):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.set _restoreBreakpoints):
* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
(WebInspector.CPUProfileHeader.prototype.createView):
* inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
(WebInspector.FlowTreeElement.prototype.setOverset):
* inspector/front-end/CSSNamedFlowView.js:
(WebInspector.CSSNamedFlowView.prototype._update):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorDataGridNode.prototype.createCell):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSProfileHeader.prototype.createView):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._keyDown):
(WebInspector.CallStackSidebarPane.Placard.prototype._restartFrame):
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader.prototype.createView):
* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.clone):
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype._consoleCleared):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._dumpMemory):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* inspector/front-end/ContentProviders.js:
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem.prototype._buildDescriptor):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._contextMenu):
(WebInspector.SimpleCookiesTable.prototype.setCookies):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._onDeleteFromGrid):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.redo):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.set restoreBreakpoints):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel.prototype.storages):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.CreationDataGridNode.prototype.makeNormal):
* inspector/front-end/Database.js:
(WebInspector.DatabaseModel.prototype._addDatabase):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):
* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.callStackModified):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorGutterPanel.prototype.removeDecoration):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
* inspector/front-end/Dialog.js:
(WebInspector.DialogDelegate.prototype.willHide):
* inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView.prototype._sort):
(WebInspector.DirectoryContentView.Node.prototype._metadataReceived):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.appendApplicableItems):
* inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorateAncestor):
* inspector/front-end/EmptyView.js:
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype):
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.show):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionNotifierView.prototype.willHide):
* inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype.refresh):
* inspector/front-end/FileManager.js:
(WebInspector.FileManager.prototype.appendedToURL):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.Directory.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.prototype._delete):
(WebInspector.FileSystemView.EntryTreeElement.prototype._deletionCompleted):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._itemElementInViewport):
(WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
(WebInspector.OpenResourceDialog.prototype.rewriteQuery):
* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype.updateFontPreviewSize):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype.onEnter):
* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype._appendHrefItems):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotRealWorker.prototype.terminate):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
(WebInspector.HeapSnapshotWorker.prototype._postMessage):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
(WebInspector.HeapSnapshotProxy.prototype.get uid):
(WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
(WebInspector.HeapProfileHeader.prototype._createFileReader):
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype._onBlur):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._requestData):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype.clear):
(WebInspector.IDBDataGridNode.prototype._formatValue):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.ClipboardAccessDeniedScreen):
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype.showPanelForAnchorNavigation):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
* inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
* inspector/front-end/NativeBreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemorySnapshotView.prototype.get profile):
(WebInspector.NativeMemoryProfileType.prototype.createProfile):
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
(WebInspector.NativeMemoryPieChart.prototype._clear):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype.set request):
(WebInspector.RequestContentView.prototype.highlightLine):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._userAgentSettingChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNode):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):
* inspector/front-end/NetworkPanelDescriptor.js:
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._pushFrame):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._updateHTMLId):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.ScopeTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement.prototype.onattach):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.unregisterShortcut):
* inspector/front-end/PanelEnablerView.js:
(WebInspector.PanelEnablerView.prototype.get alwaysEnabled):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype._merge):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype.profileFinished):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.appendApplicableItems):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
(WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
* inspector/front-end/ProgressIndicator.js:
(WebInspector.ProgressIndicator.prototype.worked):
* inspector/front-end/PropertiesSection.js:
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update):
* inspector/front-end/RequestCookiesView.js:
(WebInspector.RequestCookiesView.prototype._refreshCookies):
* inspector/front-end/RequestHTMLView.js:
(WebInspector.RequestHTMLView.prototype._createIFrame):
* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._createHeadersToggleButton):
* inspector/front-end/RequestJSONView.js:
(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.prototype._initialize):
* inspector/front-end/RequestPreviewView.js:
(WebInspector.RequestPreviewView.prototype._createPreviewView):
* inspector/front-end/RequestResponseView.js:
(WebInspector.RequestResponseView.prototype.contentLoaded):
* inspector/front-end/RequestTimingView.js:
(WebInspector.RequestTimingView.prototype._refresh):
(WebInspector.RequestTimingView.createTimingTable):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.prototype.hasContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isHidden):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.prototype.hasContent):
(WebInspector.ResourceSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ResourceWebSocketFrameView.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._onmouseout):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
(WebInspector.FrameTreeElement.prototype._insertInPresentationOrder):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.DatabaseTreeElement.prototype._updateChildren):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.clear):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
(WebInspector.CookieTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
(WebInspector.StorageCategoryView.prototype.setText):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._reset):
(WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):
* inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype._reportCompletions):
(WebInspector.FrameExecutionContextList.prototype.get displayName):
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
(WebInspector.ScopeVariableTreeElement.prototype.get propertyPath):
* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.dispose):
* inspector/front-end/ScriptFormatterWorker.js:
(HTMLScriptFormatter.prototype.styleSheetEnded):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._projectDidReset):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
* inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype.willHide):
(WebInspector.SettingsTab.prototype._createCustomSetting):
(WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceOrientationOverrideElement):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):
* inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode.prototype.dispose):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane.prototype._onTitleKeyDown):
* inspector/front-end/SidebarTreeElement.js:
(WebInspector.SidebarSectionTreeElement.prototype.onreveal):
(WebInspector.SidebarTreeElement.prototype.onreveal):
* inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
* inspector/front-end/SnippetStorage.js:
(WebInspector.Snippet.prototype.serializeToObject):
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._commitEditing):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype._onKeyDown):
* inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype.set elementsToRestoreScrollPositionsFor):
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype._showOptions):
* inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):
* inspector/front-end/StyleSource.js:
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.currentFile):
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._insertBefore):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype._stopped):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.recordOffsetInSeconds):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
(WebInspector.TimelineFrameOverview.prototype.getWindowTimes):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.performSearch):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.isVisible):
(WebInspector.TimelineCategory.prototype.set hidden):
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridNode.prototype._exclude):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setSourceMapping):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/View.js:
(WebInspector.View.prototype.focus):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
(WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._disconnectedFromWorker):
(WebInspector.WorkerTerminatedScreen.prototype.willHide):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.uiSourceCodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed r130146 follow-up, added method was not called.
vsevik@chromium.org [Tue, 2 Oct 2012 10:27:19 +0000 (10:27 +0000)]
Unreviewed r130146 follow-up, added method was not called.

* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Multiple fields datetime/datetime-local input UI
yosin@chromium.org [Tue, 2 Oct 2012 10:21:37 +0000 (10:21 +0000)]
[Forms] Multiple fields datetime/datetime-local input UI
https://bugs.webkit.org/show_bug.cgi?id=97997

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces multiple fields "datetime" and "datetime-local"
input UI in DRT. We'll enable these features once we add tests.

No new tests. To reduce size of this patch, other patches add tests
for multiple fields datetime/datetime-local input UI.

Note: Actual outputs of four tests
  - fast/forms/datetime/datetime-input-visible-string.html
  - fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html
  - fast/forms/datetimelocal/datetimelocal-input-visible-string.html
  - fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html
are different.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* css/html.css:
(input::-webkit-datetime-edit-day-field): Added for field appearance.
(input::-webkit-datetime-edit-day-field:focus):  Added to remove focus ring.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::DateTimeInputType::setupLayoutParameters): Added to set layout of multiple fields.
* html/DateTimeInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeInputType typedef.
(WebCore::DateTimeInputType::DateTimeInputType): Changed base class name to BaseDateTimeInputType.
(DateTimeInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::DateTimeLocalInputType::setupLayoutParameters):  Added to set layout of multiple fields.
* html/DateTimeLocalInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeLocalInputType typedef.
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType): Changed base class name to BaseDateTimeLocalInputType.
(DateTimeLocalInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Changed to add member variable m_placeholderForDay.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed to initialize m_placeholderForDay.
(WebCore::DateTimeEditBuilder::visitField): Changed to support week field.
* html/shadow/DateTimeEditElement.h:
(LayoutParameters): Changed to add placeholderForDay member variable.

LayoutTests:

This patch adds Chromium port specific expectations for "datetime" and
"datetime-local" input type tests for multiple fields datetime input UI.

* platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Added. Multiple fields datetime input UI doesn't have selection.
* platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime input UI, step down/up decrement/increment a field rather than whole value.
* platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Added. Multiple fields datetime-local input UI doesn't have selection.
* platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime-local input UI, step down/up decrement/increment a field rather than whole value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] Breakpoints restored from storage are not set in debugger.
vsevik@chromium.org [Tue, 2 Oct 2012 10:18:05 +0000 (10:18 +0000)]
Web Inspector: [Regression] Breakpoints restored from storage are not set in debugger.
https://bugs.webkit.org/show_bug.cgi?id=98132

Reviewed by Pavel Feldman.

Added hasDivergedFromVM attribute to UISourceCode for breakpoint
manager to know if breakpoints should be set in the debugger.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.hasDivergedFromVM):
(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 2 Oct 2012 10:12:44 +0000 (10:12 +0000)]
Unreviewed GTK gardening.

Rebaselining fast/canvas/canvas-render-layer.html after r130056.
Changing one calendar picker expectation after r130113.
Marking fast/css/sticky/sticky-writing-mode-vertical-rl.html as flaky.

* platform/gtk/TestExpectations:
* platform/gtk/fast/canvas/canvas-render-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI make String* instrumentation non intrusive
loislo@chromium.org [Tue, 2 Oct 2012 09:43:36 +0000 (09:43 +0000)]
Web Inspector: NMI make String* instrumentation non intrusive
https://bugs.webkit.org/show_bug.cgi?id=97964

Reviewed by Yury Semikhatsky.

Source/WebCore:

MemoryInstrumentationString.h include was added.

* dom/WebCoreMemoryInstrumentation.h:

Source/WebKit/chromium:

The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.

* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):

Source/WTF:

MemoryInstrumentationString.h was added.
Intrusive instrumentation was removed.

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/MemoryInstrumentation.h:
(WTF):
* wtf/MemoryInstrumentationString.h: Added.
(WTF):
(WTF::reportMemoryUsage):
* wtf/text/AtomicString.cpp:
(WTF):
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/CString.h:
(WTF::CStringBuffer::length):
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(WTF::StringImpl::usesInternalBuffer):
(WTF::StringImpl::baseString):
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: inspector/debugger/script-snippet-model.html fails
vsevik@chromium.org [Tue, 2 Oct 2012 09:35:38 +0000 (09:35 +0000)]
Web Inspector: inspector/debugger/script-snippet-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=98129

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._runScript):
(WebInspector.ScriptSnippetModel.prototype._printRunScriptResult):

LayoutTests:

* inspector/debugger/script-snippet-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove anonymous namespace from StyleBuilder.cpp for better debugging experience
yurys@chromium.org [Tue, 2 Oct 2012 09:29:14 +0000 (09:29 +0000)]
Remove anonymous namespace from StyleBuilder.cpp for better debugging experience
https://bugs.webkit.org/show_bug.cgi?id=98124

Reviewed by Alexander Pavlov.

* css/StyleBuilder.cpp: removed anonymous namespace.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse correct gtest macros for tests for true/false
jochen@chromium.org [Tue, 2 Oct 2012 09:29:01 +0000 (09:29 +0000)]
Use correct gtest macros for tests for true/false

Unreviewed build-fix.

Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert
true to a pointer. Tests should use EXPECT_TRUE instead.

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CSS property names autocomplete: Suggest most used rather than alphabe...
commit-queue@webkit.org [Tue, 2 Oct 2012 08:59:39 +0000 (08:59 +0000)]
Web Inspector: CSS property names autocomplete: Suggest most used rather than alphabeticaly first
https://bugs.webkit.org/show_bug.cgi?id=96763

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-02
Reviewed by Alexander Pavlov.

Implement selection of non-first item in WebInspector.TextPrompt.SuggestBox.

* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.Weight): Collect most used CSS property names. Rarely used properties are not presented.
(WebInspector.CSSCompletions.prototype.firstStartsWith): Remove unused function.
(WebInspector.CSSCompletions.prototype.mostUsedOf):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
(WebInspector.TextPrompt.SuggestBox): Introduce _length and _selectedIndex to remove unnecessary DOM traversals.
    Simplify canShowForSingleItem logic.
(WebInspector.TextPrompt.SuggestBox.prototype._selectClosest): _onPreviousItem and _onNextItem had some logic
    duplication so I replaced them with this method.
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._selectItem):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Modifications in a shadow tree don't update the Elements panel.
keishi@webkit.org [Tue, 2 Oct 2012 08:36:49 +0000 (08:36 +0000)]
Web Inspector: Modifications in a shadow tree don't update the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=97056

Reviewed by Pavel Feldman.

Source/WebCore:

Send characterDataModified event for shadow dom nodes too so they update the elements panel.

Test: inspector/elements/shadow-dom-modify-chardata.html

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

* inspector/elements/shadow-dom-modify-chardata-expected.txt: Added.
* inspector/elements/shadow-dom-modify-chardata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Provide a way to distinguish scripts having sourceURL from standalone...
vsevik@chromium.org [Tue, 2 Oct 2012 08:28:02 +0000 (08:28 +0000)]
Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts.
https://bugs.webkit.org/show_bug.cgi?id=97231

Reviewed by Pavel Feldman.

Source/WebCore:

DebuggerAgent now scans scripts for sourceURL comment and provides
hasSourceURL flag for each non-inline script with such a comment.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/Script.js:
(WebInspector.Script):

LayoutTests:

* inspector/debugger/source-url-comment-expected.txt:
* inspector/debugger/source-url-comment.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r130129.
caseq@chromium.org [Tue, 2 Oct 2012 08:25:19 +0000 (08:25 +0000)]
Unreviewed, rolling out r130129.
http://trac.webkit.org/changeset/130129
https://bugs.webkit.org/show_bug.cgi?id=98125

broke 4 webkit_unit_tests
(MemoryInstrumentationTest.hashMapWith*) (Requested by caseq
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02

Source/WebCore:

* dom/WebCoreMemoryInstrumentation.h:
* platform/KURL.cpp:
* platform/KURLGoogle.cpp:
* platform/PlatformMemoryInstrumentation.h:

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:

Source/WTF:

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/MemoryInstrumentation.h:
(WTF):
* wtf/MemoryInstrumentationString.h: Removed.
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::reportMemoryUsage):
(WTF):
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/CString.h:
(WTF::CStringBuffer::length):
(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reportMemoryUsage):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):
* wtf/text/WTFString.cpp:
(WTF::String::reportMemoryUsage):
(WTF):
* wtf/text/WTFString.h:
(String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move runScript into the snippets model
pfeldman@chromium.org [Tue, 2 Oct 2012 08:20:47 +0000 (08:20 +0000)]
Web Inspector: move runScript into the snippets model
https://bugs.webkit.org/show_bug.cgi?id=98122

Reviewed by Vsevolod Vlasov.

- Moves runScript into the SnippetsModel
- Drive-by: annotates more RuntimeModel methods
- common, sdk, ui, components, elements, network, resources, network,
  scripts, console, timeline, workers, tests
  modules now compile with no errors in dedicated compilation mode.

* inspector/compile-front-end.py:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.completionsForTextPrompt):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._runScript):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
* inspector/front-end/externs.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix PerfTest standard deviation calculation.
pdr@google.com [Tue, 2 Oct 2012 08:10:47 +0000 (08:10 +0000)]
Fix PerfTest standard deviation calculation.
https://bugs.webkit.org/show_bug.cgi?id=98115

Reviewed by Ryosuke Niwa.

Previously our standard deviation calculation was incorrect. This patch
updates perftest.py's algorithm to calculate the sample standard deviation
(with Bessel's correction) using Knuth's online algorithm:
http://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Online_algorithm
An existing test has been modified to prove our new results.

This patch also updates runner.js to use Bessel's correction in
its sample standard deviation calculation, which is more accurate
for small sample sizes.

Additionally, runner.js has been modified to not calculate
the 'sum' statistic, which was not very useful.

PerformanceTests:

* resources/runner.js:
(PerfTestRunner.computeStatistics):

Tools:

* Scripts/webkitpy/performance_tests/perftest.py:

    The unused variable valueSum has also been removed.

(PageLoadingPerfTest.run):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:

    This test calculates the stdev of {2000, 3000, ..., 20000} which
    was hand-calculated using a spreadsheet.

(TestPageLoadingPerfTest.test_run):

LayoutTests:

* fast/harness/perftests/perf-runner-compute-statistics-expected.txt:
* fast/harness/perftests/perf-runner-compute-statistics.html:
* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Adding DateTimeDayFieldElement for multiple fields "date", "datetime", "datet...
yosin@chromium.org [Tue, 2 Oct 2012 08:10:08 +0000 (08:10 +0000)]
[Forms] Adding DateTimeDayFieldElement for multiple fields "date", "datetime", "datetime-local" input UI
https://bugs.webkit.org/show_bug.cgi?id=97998

Reviewed by Kent Tamura.

This patch introduces DateTimeDayFieldElement class for implementing
multiple fields "date", "datetime", and "datetime-local" input UI.

No new tests. This patch doesn't change behavior.

* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement): Added.
(WebCore::DateTimeDayFieldElement::create): Added.
(WebCore::DateTimeDayFieldElement::populateDateTimeFieldsState): Added.
(WebCore::DateTimeDayFieldElement::setValueAsDate): Added.
(WebCore::DateTimeDayFieldElement::setValueAsDateTimeFieldsState): Added.
* html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening -- rebaselined canvas-render-layer and 4 week-multiple-fields...
caseq@chromium.org [Tue, 2 Oct 2012 08:09:10 +0000 (08:09 +0000)]
Unreviewed gardening -- rebaselined canvas-render-layer and 4 week-multiple-fields-appearance tests.

* platform/chromium-linux/fast/canvas/canvas-render-layer-expected.png: Removed.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-render-layer-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-mac/fast/canvas/canvas-render-layer-expected.png:
* platform/chromium-mac/fast/canvas/canvas-render-layer-expected.txt:
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Removed.
* platform/chromium-win-xp/fast/canvas/canvas-render-layer-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.
* platform/chromium-win/fast/canvas/canvas-render-layer-expected.png:
* platform/chromium-win/fast/canvas/canvas-render-layer-expected.txt:
* platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
* platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
* platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Removed.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLocalzeNone::dateFormat() should have right date format.
yosin@chromium.org [Tue, 2 Oct 2012 08:03:59 +0000 (08:03 +0000)]
LocalzeNone::dateFormat() should have right date format.
https://bugs.webkit.org/show_bug.cgi?id=98123

Reviewed by Kent Tamura.

This patch changes date format in LocaleNone for multiple fields
date/datetime/datetime-local input UI.

No new tests. Other patch for ports which use LocaleNone and multiple
fields date/time input UI will have tests.

* platform/text/LocaleNone.cpp:
(WebCore::LocaleNone::dateFormat): Changed month specifier to "MM".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move cookies model out of the items view (into sdk component).
pfeldman@chromium.org [Tue, 2 Oct 2012 07:48:02 +0000 (07:48 +0000)]
Web Inspector: move cookies model out of the items view (into sdk component).
https://bugs.webkit.org/show_bug.cgi?id=98022

Reviewed by Yury Semikhatsky.

Otherwise Audits require code that belongs to the resources component.

* inspector/front-end/CookieItemsView.js:
* inspector/front-end/CookieParser.js:
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.Cookies.buildCookiesFromString):
(WebInspector.Cookies.cookieMatchesResourceURL):
(WebInspector.Cookies.cookieDomainMatchesResourceDomain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI make String* instrumentation non intrusive
loislo@chromium.org [Tue, 2 Oct 2012 07:44:47 +0000 (07:44 +0000)]
Web Inspector: NMI make String* instrumentation non intrusive
https://bugs.webkit.org/show_bug.cgi?id=97964

Reviewed by Yury Semikhatsky.

Source/WebCore:

MemoryInstrumentationString.h include was added.

* dom/WebCoreMemoryInstrumentation.h:

Source/WebKit/chromium:

The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.

* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):

Source/WTF:

MemoryInstrumentationString.h was added.
Intrusive instrumentation was removed.

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/MemoryInstrumentation.h:
(WTF):
* wtf/MemoryInstrumentationString.h: Added.
(WTF):
(WTF::reportMemoryUsage):
* wtf/text/AtomicString.cpp:
(WTF):
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/CString.h:
(WTF::CStringBuffer::length):
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(WTF::StringImpl::usesInternalBuffer):
(WTF::StringImpl::baseString):
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the Safari 2 -> Safari 3 icon database import code.
beidson@apple.com [Tue, 2 Oct 2012 07:05:17 +0000 (07:05 +0000)]
Remove the Safari 2 -> Safari 3 icon database import code.
https://bugs.webkit.org/show_bug.cgi?id=98113

Reviewed by Maciej Stachowiak.

Source/WebCore:

Remove notions of "importing an old database format" from the IconDatabase.

No new tests - Feature removed, and no previous tests covered it.

* loader/icon/IconDatabase.cpp:
(DefaultIconDatabaseClient):
(WebCore::IconDatabase::IconDatabase):
(WebCore):
(WebCore::IconDatabase::iconDatabaseSyncThread):
* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
* loader/icon/IconDatabaseClient.h:
* WebCore.exp.in:

Source/WebKit/blackberry:

Nuke the performImport() IconDatabaseClient method.

* WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
* WebCoreSupport/IconDatabaseClientBlackBerry.h:
(IconDatabaseClientBlackBerry):

Source/WebKit/efl:

Nuke the performImport() IconDatabaseClient method.

* WebCoreSupport/IconDatabaseClientEfl.cpp:
* WebCoreSupport/IconDatabaseClientEfl.h:

Source/WebKit/gtk:

Nuke the performImport() IconDatabaseClient method.

* webkit/webkitfavicondatabase.cpp:
(IconDatabaseClientGtk):

Source/WebKit/mac:

Nuke the performImport() IconDatabaseClient method, as well as the supporting methods.

* Misc/WebIconDatabase.mm:
* Misc/WebIconDatabaseInternal.h:
* Misc/WebIconDatabasePrivate.h:
* WebCoreSupport/WebIconDatabaseClient.h:
* WebCoreSupport/WebIconDatabaseClient.mm:
* WebKit.exp:

Source/WebKit/qt:

Nuke the performImport() IconDatabaseClient method.

* WebCoreSupport/IconDatabaseClientQt.cpp:
* WebCoreSupport/IconDatabaseClientQt.h:
(IconDatabaseClientQt):

Source/WebKit/win:

Nuke the performImport() IconDatabaseClient method.

* WebIconDatabase.cpp:
* WebIconDatabase.h:
(WebIconDatabase):

Source/WebKit2:

Nuke the performImport() IconDatabaseClient method.

* UIProcess/WebIconDatabase.cpp:
(WebKit):
* UIProcess/WebIconDatabase.h:
(WebIconDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding Localizer::dateFormat() for multiple fields date/datetime input UI
yosin@chromium.org [Tue, 2 Oct 2012 06:48:59 +0000 (06:48 +0000)]
Adding Localizer::dateFormat() for multiple fields date/datetime input UI
https://bugs.webkit.org/show_bug.cgi?id=98109

Reviewed by Kent Tamura.

This patch introduces Localizer::dateFormat() function for multiple
fields date/datetime/datetime-local input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

We'll have platform specific implementations in LocaleICU, LocaleMac,
and LocaleWin.

No new tests. Other patches will add tests for this change.

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::dateFormat): Added a stub.
* platform/text/LocaleICU.h:
(LocaleICU):  Changed to add a declaration of dateFormat().
* platform/text/LocaleNone.cpp:
(LocaleNone):  Changed to add a declaration of dateFormat().
(WebCore::LocaleNone::dateFormat): Added.
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Added.
* platform/text/LocaleWin.h:
(LocaleWin): Changed to add a declaration of dateFormat().
* platform/text/Localizer.h: Updates Unicode TR35 URI in a comment.
(Localizer): Changed to add a declaration of dateFormat().
* platform/text/mac/LocaleMac.h:
(LocaleMac): Changed to add a declaration of dateFormat().
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::dateFormat): Added a stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r130116): Need to update DateTimeFormatTest
yosin@chromium.org [Tue, 2 Oct 2012 06:42:51 +0000 (06:42 +0000)]
REGRESSION(r130116): Need to update DateTimeFormatTest
https://bugs.webkit.org/show_bug.cgi?id=98120

Reviewed by Kent Tamura.

This patch updates test cases for week of month and week of year type
specifiers in DateTimeFormat class. This tests should be updated
within r130116.

* tests/DateTimeFormatTest.cpp:
(TEST_F): Changed test cases for changes of enum field value changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix ASSERT introduced in
abarth@webkit.org [Tue, 2 Oct 2012 06:32:08 +0000 (06:32 +0000)]
Unreviewed. Fix ASSERT introduced in
http://trac.webkit.org/changeset/130103. It turns out this case can
occur. This patch causes us to handle it the same way we did
previously.

* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] DOMSelection should not use shadowAncestorNode
shinyak@chromium.org [Tue, 2 Oct 2012 06:22:33 +0000 (06:22 +0000)]
[Refactoring] DOMSelection should not use shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=97872

Reviewed by Ryosuke Niwa.

Since Node::shadowAncestorNode is deprecated, it should not be used.
Here, we should use TreeScope::ancestorInThisScope instead.

No new tests, covered by existing test.

* page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoScrollView::setScrollPosition is overridden by FrameView, but is not virtual
timothy_horton@apple.com [Tue, 2 Oct 2012 06:20:55 +0000 (06:20 +0000)]
ScrollView::setScrollPosition is overridden by FrameView, but is not virtual
https://bugs.webkit.org/show_bug.cgi?id=98064

Reviewed by Simon Fraser.

Virtualize ScrollView::setScrollPosition, and override it in FrameView.

No new tests, this causes subtle behavior differences in currently-untestable code.

* page/FrameView.h:
(FrameView):
* platform/ScrollView.h:
(ScrollView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestore WebCore/ChangeLog lines deleted in r130097
dbarton@mathscribe.com [Tue, 2 Oct 2012 06:17:53 +0000 (06:17 +0000)]
Restore WebCore/ChangeLog lines deleted in r130097
https://bugs.webkit.org/show_bug.cgi?id=98112

Reviewed by Eric Seidel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTreeScope should not use node->shadowAncetorNode()
shinyak@chromium.org [Tue, 2 Oct 2012 06:15:33 +0000 (06:15 +0000)]
TreeScope should not use node->shadowAncetorNode()
https://bugs.webkit.org/show_bug.cgi?id=97869

Reviewed by Ryosuke Niwa.

TreeScope uses shadowAncestorNode(), but we should use shadowHost() here. shadowAncestorNode() is deprecated.

No new tests, simple refactoring.

* dom/TreeScope.cpp:
(WebCore::TreeScope::ancestorInThisScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move completions calculation into RuntimeModel (part 1)
pfeldman@chromium.org [Tue, 2 Oct 2012 06:10:21 +0000 (06:10 +0000)]
Web Inspector: move completions calculation into RuntimeModel (part 1)
https://bugs.webkit.org/show_bug.cgi?id=98053

Reviewed by Yury Semikhatsky.

Source/WebCore:

- moves current execution context state into runtime model
- moves completionsForTextPrompt and its private helpers into runtime model
- makes text prompt use generic expression stop characters by default

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameChanged):
(WebInspector.ConsoleView.prototype._appendContextOption):
(WebInspector.ConsoleView.prototype._contextChanged):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyPrompt):
* inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.setCurrentExecutionContext):
(WebInspector.RuntimeModel.prototype.currentExecutionContext):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeModel.prototype.evaluate.evalCallback):
(WebInspector.RuntimeModel.prototype.evaluate):
(WebInspector.RuntimeModel.prototype.completionsForTextPrompt):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated.getCompletions):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNamesFromEval):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):
(WebInspector.RuntimeModel.prototype._reportCompletions):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):

LayoutTests:

* http/tests/inspector/console-cd-completions.html:
* http/tests/inspector/network/network-initiator-from-console.html:
* inspector/debugger/debugger-completions-on-call-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerfTestRunner: Move all functions into the closure and always use double quotation...
rniwa@webkit.org [Tue, 2 Oct 2012 04:57:33 +0000 (04:57 +0000)]
PerfTestRunner: Move all functions into the closure and always use double quotation for string literals
https://bugs.webkit.org/show_bug.cgi?id=98093

Reviewed by Ojan Vafai.

Move all methods of PerfTestRunner into the closure that defines it.
Also always use double quotations for string literals for consistency.

* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe static function 'deleteFileSystem' in the LocalFileSystem.cpp should have another...
commit-queue@webkit.org [Tue, 2 Oct 2012 04:42:14 +0000 (04:42 +0000)]
The static function 'deleteFileSystem' in the LocalFileSystem.cpp should have another name.
https://bugs.webkit.org/show_bug.cgi?id=98106

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-01
Reviewed by Yuta Kitamura.

A build error occurs because there are two functions which have same name in the LocalFileSystem.cpp file.
One is member function of the class, and the other is a static function which is called by the member function.
So, I've tried to change the name of the static function from 'deleteFileSystem' to 'performDeleteFileSystem'.

No new functionality, no new test.

* Modules/filesystem/LocalFileSystem.cpp:
(WebCore::performDeleteFileSystem): The name of function is changed from 'deleteFileSystem'.
(WebCore::LocalFileSystem::requestFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeek specifiers defined in DateTimeFormat class are wrong.
yosin@chromium.org [Tue, 2 Oct 2012 04:22:55 +0000 (04:22 +0000)]
Week specifiers defined in DateTimeFormat class are wrong.
https://bugs.webkit.org/show_bug.cgi?id=98104

Reviewed by Kent Tamura.

This patch changes week of year and week of month format specifiers
defined in DateTimeFormat class to match with Unicode technical
standard 35, LDML, Locale Data Markup Language, (http://www.unicode.org/reports/tr35/).

No new tests. Following existing tests cover this change:
  - fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html
  - fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html
  - fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html
  - fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html

* html/WeekInputType.cpp:
(WebCore::WeekInputType::setupLayoutParameters): Changed to use 'w' instead of 'W'.
* platform/text/DateTimeFormat.cpp: Changed elements in lowerCaseToFieldTypeMap and upperCaseToFieldTypeMap.
* platform/text/DateTimeFormat.h: Changed FieldTypeWeekOfMonth to 'W' and FieldTypeWeekOfYear to 'w'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
jpetsovits@rim.com [Tue, 2 Oct 2012 03:47:07 +0000 (03:47 +0000)]
[BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
https://bugs.webkit.org/show_bug.cgi?id=98107
RIM PR 173292

Reviewed by George Staikos.

This method is not referenced anywhere anymore,
so we should stop requiring it from WebPageClient
implementations.

* Api/WebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd other <string> typed tokens to YYDEBUG token output
commit-queue@webkit.org [Tue, 2 Oct 2012 03:11:50 +0000 (03:11 +0000)]
Add other <string> typed tokens to YYDEBUG token output
https://bugs.webkit.org/show_bug.cgi?id=98102

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-01
Reviewed by Simon Fraser.

Add other <string> typed tokens to YYPRINT macro expansion. Minor cleanup of cast.

No new tests. For CSS lexer/parser debug usage only.

* css/CSSGrammar.y:
Add other <string> typed tokens to YYPRINT macro expansion.
Change C-type cast to function-call style cast (per darin).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCalendar picker should use zero as default step base
keishi@webkit.org [Tue, 2 Oct 2012 02:37:27 +0000 (02:37 +0000)]
Calendar picker should use zero as default step base
https://bugs.webkit.org/show_bug.cgi?id=97976

Reviewed by Kent Tamura.

.:

* ManualTests/forms/calendar-picker.html: Added stepBase parameters.

Source/WebCore:

Calendar picker should be using zero as default step base for input type=date.
The spec says to use zero unless specified otherwise.
Since input type=week has another default step base, I am adding step base
to DateTimeChooserParameters.

Test: fast/forms/date/calendar-picker-with-step.html

* Resources/pagepopups/calendarPicker.js:
(handleArgumentsTimeout):
(CalendarPicker):
(CalendarPicker.prototype.stepMismatch): Use the new this.stepBase.
* html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::openPopup): Gets step base from step range.
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added stepBase.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): stepBase needs 11 digits of precision when setting maximum possible date.

LayoutTests:

* fast/forms/date/calendar-picker-with-step-expected.txt: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt.
* fast/forms/date/calendar-picker-with-step.html: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html. Renamed because this does not test apeparance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix expected result name.
roger_fong@apple.com [Tue, 2 Oct 2012 02:07:22 +0000 (02:07 +0000)]
Unreviewed. Fix expected result name.

* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd more tests for calendar picker
keishi@webkit.org [Tue, 2 Oct 2012 01:55:29 +0000 (01:55 +0000)]
Add more tests for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=98034

Reviewed by Kent Tamura.

This adds basic tests for all key bindings and simple mouse operations.

* fast/forms/date/calendar-picker-common.js: Added.
(currentMonth): Returns month that the picker is currently showing.
(selectedDate):
(openPicker): Opens the calendar picker and updates popupWindow.
(sendKey):
* fast/forms/date/calendar-picker-key-operations-expected.txt:
* fast/forms/date/calendar-picker-key-operations.html:
* fast/forms/date/calendar-picker-mouse-operations-expected.txt: Added.
* fast/forms/date/calendar-picker-mouse-operations.html: Added.
* fast/forms/resources/common.js:
(cumulativeOffset):
(hoverOverElement):
(clickElement):
* platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:
* platform/gtk/TestExpectations: Added calendar-picker-mouse-operations.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoflexbox does wrong baseline item alignment in columns
tony@chromium.org [Tue, 2 Oct 2012 01:51:22 +0000 (01:51 +0000)]
flexbox does wrong baseline item alignment in columns
https://bugs.webkit.org/show_bug.cgi?id=97948

Reviewed by Ojan Vafai.

Source/WebCore:

For columns, baseline alignment should just be flex-start.  We were previously
moving the logical left edge by the ascent.

Test: css3/flexbox/align-baseline.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children.
(WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment.
* rendering/RenderFlexibleBox.h:

LayoutTests:

Update test cases with new baseline alignment for column.

* css3/flexbox/align-baseline-expected.html: Added.
* css3/flexbox/align-baseline.html: Added.
* css3/flexbox/flex-align-baseline-expected.txt:
* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/multiline-align-self.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSArray::unshiftCountSlowCase needs to clear array slots when adding space to end...
msaboff@apple.com [Tue, 2 Oct 2012 01:21:17 +0000 (01:21 +0000)]
JSArray::unshiftCountSlowCase needs to clear array slots when adding space to end of array
https://bugs.webkit.org/show_bug.cgi?id=98101

Reviewed by Filip Pizlo.

Cleared new array entries when adding to end due to shifting contents to lower memory.  Also
checnaged the order of moving array contents and metadata in the shift left case to avoid
clobbering the metadata with array contents.  Optimized the to only make a memmove if the
count is non-zero.

* runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::unshiftCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] crash when accelerated composition is turned off
commit-queue@webkit.org [Tue, 2 Oct 2012 01:14:07 +0000 (01:14 +0000)]
[Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-01
Reviewed by Martin Robinson.

frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.

This bug is handled by LayoutTests/compositing/toggle-compositing.html

* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding appearance tests for multiple fields week input UI
yosin@chromium.org [Tue, 2 Oct 2012 01:03:58 +0000 (01:03 +0000)]
Adding appearance tests for multiple fields week input UI
https://bugs.webkit.org/show_bug.cgi?id=98006

Reviewed by Kent Tamura.

This patch adds tests for multiple fields week input UI and disables
these tests on ports which don't enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

Note: We need to do rebaseline tests to update images for Chromium-Mac
and Chromium-Win.

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

* fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html:  Added for checking basic appearance.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Added for checking appearance of applying CSS pseudo classes, e.g. :enabled, :invalid, and so on.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Added for checking appearance of applying CSS pseudo elements, e.g. :after, :before, and so on.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Added for checking appearance of applying CSS styles
* platform/chromium-android/TestExpectations: Changed to disable tests for multiple fields week input UI.
* platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
* platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
* platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
* platform/chromium/TestExpectations: Changed to disable tests for multiple fields week input UI of Mac and Win for rebaseline.
* platform/efl/TestExpectations: Changed to disable tests for multiple fields week input UI.
* platform/gtk/TestExpectations: ditto
* platform/mac/TestExpectations: ditto
* platform/qt/TestExpectations: ditto
* platform/win/TestExpectations: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename CalendarPickerElement to PickerIndicatorElement
keishi@webkit.org [Tue, 2 Oct 2012 00:55:41 +0000 (00:55 +0000)]
Rename CalendarPickerElement to PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=98096

Reviewed by Kent Tamura.

Renaming CalendarPickerElement to PickerIndicatorElement because we want to use it for other input types like time, week, month, datetime.

No new tests. Just a rename.

* GNUmakefile.list.am:
* WebCore.gypi:
* html/DateInputType.cpp:
(WebCore::DateInputType::createShadowSubtree):
* html/DateInputType.h:
(WebCore):
(DateInputType):
* html/shadow/PickerIndicatorElement.cpp: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.cpp.
(WebCore):
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
(WebCore::PickerIndicatorElement::create):
(WebCore::PickerIndicatorElement::~PickerIndicatorElement):
(WebCore::PickerIndicatorElement::createRenderer):
(WebCore::PickerIndicatorElement::hostInput):
(WebCore::PickerIndicatorElement::defaultEventHandler):
(WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
(WebCore::PickerIndicatorElement::didChooseValue):
(WebCore::PickerIndicatorElement::didEndChooser):
(WebCore::PickerIndicatorElement::openPopup):
(WebCore::PickerIndicatorElement::closePopup):
(WebCore::PickerIndicatorElement::detach):
* html/shadow/PickerIndicatorElement.h: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.h.
(WebCore):
(PickerIndicatorElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r130079.
ojan@chromium.org [Tue, 2 Oct 2012 00:28:32 +0000 (00:28 +0000)]
Unreviewed, rolling out r130079.
http://trac.webkit.org/changeset/130079
https://bugs.webkit.org/show_bug.cgi?id=95866

Broke the chomium windows compile.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::getFontData):
* css/CSSFontFace.h:
(CSSFontFace):
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
(CSSFontFaceSource):
* css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):
* css/CSSSegmentedFontFace.h:
(CSSSegmentedFontFace):
* dom/Document.cpp:
(WebCore::Document::registerCustomFont):
* dom/Document.h:
(Document):
* platform/graphics/Font.h:
(WebCore):
* platform/graphics/FontCache.cpp:
(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):
* platform/graphics/FontCache.h:
(FontCache):
* platform/graphics/FontData.h:
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/FontFallbackList.h:
(FontFallbackList):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
* platform/graphics/FontSelector.h:
(FontSelector):
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
* platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
* platform/graphics/SegmentedFontData.h:
(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(SegmentedFontData):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):
* platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/wince/FontCacheWinCE.cpp:
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative GTK build fix after http://trac.webkit.org/changeset/130091
bdakin@apple.com [Tue, 2 Oct 2012 00:26:56 +0000 (00:26 +0000)]
Speculative GTK build fix after trac.webkit.org/changeset/130091

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-traverse...
abarth@webkit.org [Tue, 2 Oct 2012 00:16:05 +0000 (00:16 +0000)]
[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-traverse gets 4% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974

Reviewed by Kentaro Hara.

Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-traverse by about 4%.

We were using the extra layer of indirection in IntrusiveDOMWrapperMap
to make removal more efficient. Rather than using a chunked table, we
now use a HashSet, which also lets us remove elements quickly.

* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAddress a FIXME in JSArray::sort
fpizlo@apple.com [Tue, 2 Oct 2012 00:14:33 +0000 (00:14 +0000)]
Address a FIXME in JSArray::sort
https://bugs.webkit.org/show_bug.cgi?id=98080
<rdar://problem/12407844>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Get rid of fast sorting of sparse maps. I don't know that it's broken but I do know that we don't
have coverage for it. Then also address the FIXME in JSArray::sort regarding side-effecting
compare functions.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
* runtime/JSArray.cpp:
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
* runtime/JSArray.h:
(JSArray):
* runtime/JSObject.h:
(JSC::JSObject::hasSparseMap):
(JSObject):

LayoutTests:

* fast/js/jsc-test-list:
* fast/js/script-tests/sort-with-side-effecting-comparisons.js: Added.
* fast/js/sort-with-side-effecting-comparisons-expected.txt: Added.
* fast/js/sort-with-side-effecting-comparisons.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r130062.
ojan@chromium.org [Tue, 2 Oct 2012 00:14:18 +0000 (00:14 +0000)]
Unreviewed, rolling out r130062.
http://trac.webkit.org/changeset/130062
https://bugs.webkit.org/show_bug.cgi?id=98001

Causes a ton of gtest failures on the chromium bots.

* platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipping flaky test on Windows: inspector/debugger/dynamic-script-tag...
roger_fong@apple.com [Tue, 2 Oct 2012 00:12:16 +0000 (00:12 +0000)]
Unreviewed. Skipping flaky test on Windows: inspector/debugger/dynamic-script-tag.html.
https://bugs.webkit.org/show_bug.cgi?id=98095

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEncapsulate private properties in PerfTestRunner better
rniwa@webkit.org [Mon, 1 Oct 2012 23:48:17 +0000 (23:48 +0000)]
Encapsulate private properties in PerfTestRunner better
https://bugs.webkit.org/show_bug.cgi?id=97833

Reviewed by Ojan Vafai.

PerformanceTests:

This patch moves "private" methods and properties of PerfTestRunner into a closure so that they're
inaccssible from outside. Also catch exceptions from test.run, test.done, and other runner code
to ensure we call notifyDone() even if we broke tests. Otherwise DRT will timeout and we end up
waiting for 10 minutes per each broken test on bots.

* resources/runner.js:
(PerfTestRunner.gc):
(logInDocument): Extracted from PerfTestRunner.log.
(PerfTestRunner.log): Moved.
(logFatalError): Added.
(start): Renamed from PerfTestRunner._start.
(scheduleNextRun): Extracted from PerfTestRunner._runLoop. Also catch any exceptions that happen
in the runner and ignoreWarmUpAndLog so that we don't end up timing out. We call logFatalError in
such cases, which in turn ensures notifyDone() is called.
(ignoreWarmUpAndLog): Renamed from PerfTestRunner._ignoreWarmUpAndLog.
(finish): Extracted from PerfTestRunner._runLoop.
(PerfTestRunner.measureTime): Moved. The initialization of runCount is moved into start().
(measureTimeOnce): Renamed from PerfTestRunner._measureTimeOnce.
(PerfTestRunner.runPerSecond): Moved. Ditto about runCount.
(measureRunsPerSecondOnce): Renamed from PerfTestRunner._measureRunsPerSecondOnce.
(callRunAndMeasureTime): Renamed from PerfTestRunner._perSecondRunnerIterator.

LayoutTests:

Override PerfTestRunner.now instead of PerfTestRunner._perSecondRunnerIterator since the latter
is no longer exposed.

* fast/harness/perftests/runs-per-second-iterations-expected.txt:
* fast/harness/perftests/runs-per-second-iterations.html: Increase the runtime of the last 4 runs
since test.timeToRun is no longer supported by PerfTestRunner.
* fast/harness/perftests/runs-per-second-log-expected.txt:
* fast/harness/perftests/runs-per-second-log.html: Avoid use numbers that contain primes other
than 2 and 5 as runs because they cause rouding errors in PerfTestRunner.measureRunsPerSecondOnce
and make the output dependent on the underlying floating number implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolling out changes from http://trac.webkit.org/changeset/119130.
roger_fong@apple.com [Mon, 1 Oct 2012 23:43:10 +0000 (23:43 +0000)]
Unreviewed. Rolling out changes from trac.webkit.org/changeset/119130.
Tests match older results.

* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MathML] Baseline wrong for fractions or munder/mover with padding
dbarton@mathscribe.com [Mon, 1 Oct 2012 23:20:04 +0000 (23:20 +0000)]
[MathML] Baseline wrong for fractions or munder/mover with padding
https://bugs.webkit.org/show_bug.cgi?id=97990

Reviewed by Eric Seidel.

Source/WebCore:

We include any border or padding in our baseline computation. We also take this opportunity
to quit adding extra left & right padding to numerators and denominators, making our output
tighter and also more compatible with Firefox and TeX, since we are rebaselining some
fraction pixel tests now anyway.

Tests added to LayoutTests/mathml/presentation/{over,row-alignment}.xhtml

* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::firstLineBoxBaseline):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::firstLineBoxBaseline):

LayoutTests:

We handle any border and padding correctly, and quit adding extra left and right padding
to numerators and denominators.

* mathml/presentation/over.xhtml:
* mathml/presentation/row-alignment.xhtml:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipped on other platforms in http://trac.webkit.org/changeset/129897.
roger_fong@apple.com [Mon, 1 Oct 2012 23:18:26 +0000 (23:18 +0000)]
Unreviewed. Skipped on other platforms in trac.webkit.org/changeset/129897.
Skipping on Windows as well.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: IndexedDB: Fire error rather than raising on request creation if...
jsbell@chromium.org [Mon, 1 Oct 2012 23:14:13 +0000 (23:14 +0000)]
Source/WebCore: IndexedDB: Fire error rather than raising on request creation if transaction aborts asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93054

Reviewed by Tony Chang.

All IDB data operations are asynchronous, producing IDBRequest objects. This was implemented
by passing all data from the front-end to the back-end synchronously, and synchronously
returning an exception code back if the request was invalid. Previous changes have moved
request validation to the front-end except for the case of the back-end transaction having
asynchronously aborted in the mean time.

To eliminate that case (which would allow front-end to back-end communication to be
asynchronous in multi-process ports), change from returning an exception code to relying on
the front-end to abort the request when the abort event finally arrives.

The difference would be noticeable in scripts - in a multi-process environment:

var request1 = store.get(0);
request1.onerror = errorHandler; // (A)
// (B)
var request2 = store.get(0); // (C)
request2.onerror = errorHandler; // (D)

If the transaction back-end were to asynchronously abort at exactly point (B), then prior to
this patch an exception would be thrown at (C). With this patch, no exception but (D) would
fire, same as (A).

The back-end explicitly fires an error callback as well, as intermediate layers may rely on
this to stop tracking the pending callback.

No new layout tests - change is not observable in single-process ports.
Added webkit_unit_test IDBRequestTest.AbortErrorAfterAbort to verify that IDBRequest
is resilient to this pattern, but it was previous.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance): Back end should never fail a request.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto, and also move "is key cursor" test
here from back-end.
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunction): Change from EC to firing error.
(WebCore::IDBCursorBackendImpl::advance): Ditto.
(WebCore::IDBCursorBackendImpl::deleteFunction): Ditto, and remove test moved to FE.
(WebCore::IDBCursorBackendImpl::prefetchContinue): Ditto.
* Modules/indexeddb/IDBDatabaseError.cpp:
(WebCore::IDBDatabaseError::create): Add overload that looks up message via code.
(WebCore::IDBDatabaseError::IDBDatabaseError): Look up message via exception table.
* Modules/indexeddb/IDBDatabaseException.h: Add getErrorDescription.
* Modules/indexeddb/IDBDatabaseException.cpp: Implementation of getErrorDescription.
* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor): Back end should never fail a request.
(WebCore::IDBIndex::count): Ditto.
(WebCore::IDBIndex::openKeyCursor): Ditto.
(WebCore::IDBIndex::get): Ditto.
(WebCore::IDBIndex::getKey): Ditto.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursor): Change from EC to firing error.
(WebCore::IDBIndexBackendImpl::openKeyCursor): Ditto.
(WebCore::IDBIndexBackendImpl::count): Ditto.
(WebCore::IDBIndexBackendImpl::get): Ditto.
(WebCore::IDBIndexBackendImpl::getKey): Ditto.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get): Back end should never fail a request.
(WebCore::IDBObjectStore::put): Ditto.
(WebCore::IDBObjectStore::deleteFunction): Ditto.
(WebCore::IDBObjectStore::clear): Ditto.
(WebCore): Ditto.
(WebCore::IDBObjectStore::openCursor): Ditto.
(WebCore::IDBObjectStore::count): Ditto.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get): Change from EC to firing error.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction): Ditto.
(WebCore::IDBObjectStoreBackendImpl::clear): Ditto.
(WebCore::IDBObjectStoreBackendImpl::openCursor): Ditto.
(WebCore::IDBObjectStoreBackendImpl::count): Ditto.

Source/WebKit/chromium: IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
https://bugs.webkit.org/show_bug.cgi?id=94757

Reviewed by Tony Chang.

* tests/IDBRequestTest.cpp: Ensure IDBRequest can handle Error after abort.
(WebCore::TEST): Added AbortAfter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some flaky tests to match what's happening on the bots.
ojan@chromium.org [Mon, 1 Oct 2012 23:14:02 +0000 (23:14 +0000)]
Add some flaky tests to match what's happening on the bots.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Clearly, these objects could be instantiated in worker threads.
rniwa@webkit.org [Mon, 1 Oct 2012 23:12:27 +0000 (23:12 +0000)]
Build fix. Clearly, these objects could be instantiated in worker threads.
Not sure why my patch asserted that we're in the main thread.

* dom/ContainerNode.h:
(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update results again after r130080.
rakuco@webkit.org [Mon, 1 Oct 2012 23:08:52 +0000 (23:08 +0000)]
[EFL] Update results again after r130080.

* platform/efl/fast/canvas/canvas-render-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=97365
bdakin@apple.com [Mon, 1 Oct 2012 23:05:40 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=97365
ScrollingTreeState needs to be a tree of nodes

Reviewed by Simon Fraser.

This patch should not change any behavior.

Prior to this patch, ScrollingTreeState attempted to contain all of
the state information needed for the whole scrolling tree in one
object. But in the future when there are multiple nodes in the
scrolling tree, a single state object will not be sufficient.
ScrollingState should also be represented by a tree. This patch makes
scrolling state into a tree. The old ScrollingTreeState class has
become the ScrollingStateScrollingNode class since the majority of
the class represents scroll state that is specific to ScrollableAreas
and will not be applicable to fixed or sticky layers.

Some new files and some moved files.
* WebCore.xcodeproj/project.pbxproj:

Everything that used to refer to the ScrollingTreeState should now
refer to the ScrollingStateTree instead. Right now, all of this code
continues to deal with only the root node of the tree. In the future,
it will have to deal with all of the nodes.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::scrollingStateTreeCommitterTimerFired):
(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinator::commitTreeState):
* page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):

This is a new abstract base class for the nodes in the
ScrollingStateTree.
* page/scrolling/ScrollingStateNode.cpp: Added.
(WebCore):
(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::~ScrollingStateNode):
(WebCore::ScrollingStateNode::appendChild):
(WebCore::ScrollingStateNode::cloneChildNodes):
(WebCore::ScrollingStateNode::traverseNext):
* page/scrolling/ScrollingStateNode.h: Added.
(WebCore):
(ScrollingStateNode):
(WebCore::ScrollingStateNode::scrollLayerDidChange):
(WebCore::ScrollingStateNode::setScrollLayerDidChange):
(WebCore::ScrollingStateNode::scrollingStateTree):
(WebCore::ScrollingStateNode::parent):
(WebCore::ScrollingStateNode::firstChild):
(WebCore::ScrollingStateNode::nextSibling):
(WebCore::ScrollingStateNode::setParent):
(WebCore::ScrollingStateNode::setFirstChild):
(WebCore::ScrollingStateNode::setNextSibling):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
* page/scrolling/mac/ScrollingStateNodeMac.mm: Copied from page/scrolling/mac/ScrollingTreeStateMac.mm.
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollLayer):
(WebCore):

Right now, the ScrollingStateScrollingNode is the only type of
ScrollingStateNode. In the future there will be, for example,
ScrollingStateFixedNodes that will have a different set of state
information to keep track of.
* page/scrolling/ScrollingStateScrollingNode.cpp: Copied from page/scrolling/ScrollingTreeState.cpp.
(WebCore::ScrollingStateScrollingNode::create):
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore):
(WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::cloneNode):
(WebCore::ScrollingStateScrollingNode::setViewportRect):
(WebCore::ScrollingStateScrollingNode::setContentsSize):
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
* page/scrolling/ScrollingStateScrollingNode.h: Copied from page/scrolling/ScrollingTreeState.h.
(ScrollingStateScrollingNode):
* page/scrolling/ScrollingStateTree.cpp: Added.
(WebCore):
(WebCore::ScrollingStateTree::create):
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::~ScrollingStateTree):
(WebCore::ScrollingStateTree::commit):

The ScrollingStateTree manages the nodes in the tree via the root
node. It is responsible for cloning the tree and sending it over to
the scrolling thread.
* page/scrolling/ScrollingStateTree.h: Added.
(WebCore):
(ScrollingStateTree):
(WebCore::ScrollingStateTree::rootStateNode):
(WebCore::ScrollingStateTree::setHasChangedProperties):
(WebCore::ScrollingStateTree::hasChangedProperties):
(WebCore::ScrollingStateTree::setRootStateNode):

Everything that used to refer to the ScrollingTreeState should now
refer to the ScrollingStateTree instead. Right now, all of this code
continues to deal with only the root node of the tree. In the future,
it will have to deal with all of the nodes.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
* page/scrolling/ScrollingTree.h:
(WebCore):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(WebCore):
(ScrollingTreeNode):
* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):

ScrollingTreeState.cpp --> ScrollingStateScrollingNode.cpp
* page/scrolling/ScrollingTreeState.cpp: Removed.

ScrollingTreeState.h --> ScrollingStateScrollingNode.h
* page/scrolling/ScrollingTreeState.h: Removed.

ScrollingTreeStateMac.mm --> ScrollingStateNodeMac.mm
* page/scrolling/mac/ScrollingTreeStateMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipping http/tests/security/cross-origin-local-storage-wk1.html since...
roger_fong@apple.com [Mon, 1 Oct 2012 22:55:18 +0000 (22:55 +0000)]
Unreviewed. Skipping http/tests/security/cross-origin-local-storage-wk1.html since support for the feature on Windows has not been added yet.
https://bugs.webkit.org/show_bug.cgi?id=98079

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoKill transitive effects of SelectorChecker::checkOneSelector.
dglazkov@chromium.org [Mon, 1 Oct 2012 22:54:29 +0000 (22:54 +0000)]
Kill transitive effects of SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=97953

Reviewed by Eric Seidel.

The dynamicPseudo/hasUnknownPseudoelements by-ref parameters that are passed into checkOneSelector make the logic harder to understand and aren't needed. Refactor the code to rid of them, replacing them instead with two flags in SelectorCheckingContext.

No change in behavior, covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Rolled pseudo-element-checking code out of checkOneSelector into here, since that is where t
(WebCore::SelectorChecker::checkOneSelector): Changed to use SelectorCheckingContext rather than transitive params.
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added two new flags.
(SelectorCheckingContext): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago349kB below SelectorDataList::initialize() on Membuster3.
kling@webkit.org [Mon, 1 Oct 2012 22:41:30 +0000 (22:41 +0000)]
349kB below SelectorDataList::initialize() on Membuster3.
<http://webkit.org/b/98072>
<rdar://problem/12408605>

Reviewed by Anders Carlsson.

Make a separate pass over the CSSSelectorList to figure out the capacity needed for SelectorDataList::m_selectors.
Reduces memory consumption by 322kB on Membuster3.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-baseline after r130080 for Mac.
jonlee@apple.com [Mon, 1 Oct 2012 22:38:52 +0000 (22:38 +0000)]
Re-baseline after r130080 for Mac.

* platform/mac/fast/canvas/canvas-render-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd failing geolocation test to Mac WK2 TestExpectations
jonlee@apple.com [Mon, 1 Oct 2012 22:36:47 +0000 (22:36 +0000)]
Add failing geolocation test to Mac WK2 TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98081

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a GraphicsLayerFactory getter to ChromeClient
andersca@apple.com [Mon, 1 Oct 2012 22:31:40 +0000 (22:31 +0000)]
Add a GraphicsLayerFactory getter to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=98069

Reviewed by Andreas Kling.

* page/ChromeClient.h:
(WebCore::ChromeClient::graphicsLayerFactory):
New function that can be overridden by ports to customize the layer type created for a page.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::graphicsLayerFactory):
* rendering/RenderLayerCompositor.h:
Add helper getter that's unused for now but will be called by RenderLayerBacking when creating graphics layers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename AssertNoEventDispatch to NoEventDispatchAssertion
rniwa@webkit.org [Mon, 1 Oct 2012 22:24:20 +0000 (22:24 +0000)]
Rename AssertNoEventDispatch to NoEventDispatchAssertion
https://bugs.webkit.org/show_bug.cgi?id=98075

Reviewed by Abhishek Arya.

Renamed the class.

* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/ContainerNode.h:
(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
* dom/Document.cpp:
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy should accept a different httpd.conf specified by the user
rakuco@webkit.org [Mon, 1 Oct 2012 22:22:00 +0000 (22:22 +0000)]
webkitpy should accept a different httpd.conf specified by the user
https://bugs.webkit.org/show_bug.cgi?id=98071

Reviewed by Dirk Pranke.

The existing httpd.conf variants (or lighttpd.conf, for that
matter) we have do not always suit the user's system. This is
particularly true on Linux/Unix, where Apache can be installed in
a plethora of ways and the LoadModule calls can fail to specify
the proper module paths.

For now, we start accepting the WEBKIT_HTTP_SERVER_CONF_PATH
environment variable, which allows the user to specify the
absolute path to another http server configuration file that might
work on the user's system.

In the long term, we should try to generate our configuration file
and stop requiring all the different httpd.conf files we have as
well as this hack.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._path_to_apache_config_file):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_path_to_apache_config_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename Font::m_fontList to avoid confusion
schenney@chromium.org [Mon, 1 Oct 2012 22:18:28 +0000 (22:18 +0000)]
Rename Font::m_fontList to avoid confusion
https://bugs.webkit.org/show_bug.cgi?id=95867

Reviewed by Eric Seidel.

       Renames Font::m_fontList to Font::m_fontFallbackList to avoid confusion
       with FontFallbackList::m_fontList.

No new tests as behavior is absolutely not different.

* platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::operator==):
(WebCore::Font::update):
* platform/graphics/Font.h:
(WebCore::Font::fontList):
(WebCore::Font::loadingCustomFonts):
(Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130082 268f45cc-cd09-0410-ab3c-d52691b4dbfc