WebKit-https.git
7 years agoTurn PageLoad tests into simple performancetests, commit #6
zoltan@webkit.org [Fri, 26 Oct 2012 21:20:33 +0000 (21:20 +0000)]
Turn PageLoad tests into simple performancetests, commit #6
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #6 commit of the whole patch.

* PageLoad/svg/files/gearflowers.svg: Removed.
* PageLoad/svg/files/hereGear4.svg: Removed.
* PageLoad/svg/files/worldcup.svg: Removed.
* SVG/GearFlowers.html: Added.
* SVG/HereGear.html: Added.
* SVG/Worldcup.html: Added.
* SVG/resources/GearFlowers.svg: Copied from PerformanceTests/PageLoad/svg/files/gearflowers.svg.
* SVG/resources/HereGear.svg: Copied from PerformanceTests/PageLoad/svg/files/hereGear4.svg.
* SVG/resources/Worldcup.svg: Copied from PerformanceTests/PageLoad/svg/files/worldcup.svg.
* Skipped: Rename the files on the skipped list also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the windows build
commit-queue@webkit.org [Fri, 26 Oct 2012 21:16:11 +0000 (21:16 +0000)]
Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=100556

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Eric Seidel.

Touch files by adding whitespace to try and make the windows
build bot regenerate files.

No new tests, just kick the bot.

* dom/DOMAllInOne.cpp:
* html/HTMLElementsAllInOne.cpp:
* html/shadow/TextControlInnerElements.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of (<X%) failing output for old-run-webkit-tests.
roger_fong@apple.com [Fri, 26 Oct 2012 20:41:25 +0000 (20:41 +0000)]
Get rid of (<X%) failing output for old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=100447

Reviewed by Jessie Berlin.

Not a particularly useful piece of information. It's pretty much never above 1%.
new-run-webkit-tests does not output this either.

* Scripts/old-run-webkit-tests:
(printResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an operator& to RetainPtr
andersca@apple.com [Fri, 26 Oct 2012 20:36:40 +0000 (20:36 +0000)]
Add an operator& to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100549

Reviewed by Dan Bernstein.

This is useful for APIs that return references using out parameters.

* wtf/RetainPtr.h:
(WTF::RetainPtr::operator&):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Platform Abstraction for WebKit Resource/Image Loading
rwlbuis@webkit.org [Fri, 26 Oct 2012 20:12:25 +0000 (20:12 +0000)]
[BlackBerry] Platform Abstraction for WebKit Resource/Image Loading
https://bugs.webkit.org/show_bug.cgi?id=100518

PR 231732

Reviewed by Yong Li.

.:

Remove RESOURCE_PATH from webkit, this is now abstracted in our platform layer.

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

Use the new resource/image loading abstraction ResourceStore.

* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches...
zhajiang@rim.com [Fri, 26 Oct 2012 20:02:41 +0000 (20:02 +0000)]
[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
https://bugs.webkit.org/show_bug.cgi?id=100421

Reviewed by Yong Li.
Patch by Jacky Jiang  <zhajiang@rim.com>.

PR: 231173
When leaving fullscreen, we need to suspend screen and backing store
updates before setting scroll position and changing transformation and
resume after they are done. In which way, we can get rid of a noticeable
glitch during the transition.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add additional memory management fields to WebGraphicsContext3D
commit-queue@webkit.org [Fri, 26 Oct 2012 19:58:01 +0000 (19:58 +0000)]
[chromium] Add additional memory management fields to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=99703

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-10-26
Reviewed by James Robinson.

Add new fields to WebGraphicsMemoryAllocation to allow for specifying
limits for when visible and not, and to allow for specifying priority
cutoffs (e.g, to allow specifying that backgrounded tabs should
retain only their visible textures).

Add sendManagedMemoryStatsCHROMIUM to WebGraphicsContext3D, and
add WebGraphicsManagedMemoryStats structure, to allow the GPU memory
manager to make more informed choices.

* chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::sendManagedMemoryStatsCHROMIUM):
* chromium/public/WebGraphicsMemoryAllocation.h:
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):
(WebKit):
(WebGraphicsManagedMemoryStats):
(WebKit::WebGraphicsManagedMemoryStats::WebGraphicsManagedMemoryStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Block children have incorrect offset when shape-inside element lays...
commit-queue@webkit.org [Fri, 26 Oct 2012 19:57:52 +0000 (19:57 +0000)]
[CSS Exclusions] Block children have incorrect offset when shape-inside element lays out below other elements
https://bugs.webkit.org/show_bug.cgi?id=98189

Patch by Bear Travis <betravis@adobe.com> on 2012-10-26
Reviewed by Dirk Schulze.

Source/WebCore:

The initial code assumed that each block created a new layout state, such that
LayoutState::layoutOffset would be specific to each block child of a shape-inside.
Typically, however, block children of a shape-inside do not create a new layout state,
and therefore we use the current element's offset instead.

Test: fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified to use only logicalTop
rather than LayoutState::layoutOffset::width/height and logicalTop.

LayoutTests:

Test that block content in subsequent shape-insides lays out correctly. Introducing a script
that can eventually be used to simplify the rectangle cases.

* fast/exclusions/resources/simple-rectangle.js: Added.
(createRectangleTest): Generate a shape-inside rectangle test using the given parameters.
(createRectangleTestResult): Generate a shape-inside rectangle expected result using
the given parameters.
* fast/exclusions/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove setRenderStyle in favor of callbacks on HTMLOptionElement and HTMLOptGroupElement
commit-queue@webkit.org [Fri, 26 Oct 2012 19:28:43 +0000 (19:28 +0000)]
Remove setRenderStyle in favor of callbacks on HTMLOptionElement and HTMLOptGroupElement
https://bugs.webkit.org/show_bug.cgi?id=100397

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Ojan Vafai.

Use Node custom callbacks to support the non-renderer style caching for option
and optgroup eliminating the need for setRenderStyle.

setRenderStyle only existed to support HTMLOptionElement and HTMLOptGroupElement
so they could store their RenderStyle even though they have no renderer. This
means all style setting went through the virtual call to setRenderStyle, and it
also hid the if statement protecting against null renderers meaning we end up
checking if the renderer is null repeatedly in recalcStyle. This refactor cleans
up recalcStyle to be more clear about what's going on.

No new tests needed, this is just a refactor.

* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
(WebCore::Element::recalcStyle):
* dom/Node.cpp:
(WebCore::Node::createRenderer):
(WebCore::Node::setRenderStyle):
    Removed this method because it was only here to support HTMLOptionElement
    and HTMLOptGroupElement. Instead we can use node custom callbacks.
* dom/Node.h:
(WebCore::Node::nonRendererStyle): Renamed from nonRendererRenderStyle to match other style methods.
* dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptGroupElement::nonRendererStyle):
(WebCore::HTMLOptGroupElement::customStyleForRenderer):
* html/HTMLOptGroupElement.h:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptionElement::nonRendererStyle):
(WebCore::HTMLOptionElement::customStyleForRenderer):
(WebCore::HTMLOptionElement::didRecalcStyle): Requests the repaint of the select like setRenderStyle used to.
* html/HTMLOptionElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
danakj@chromium.org [Fri, 26 Oct 2012 19:15:39 +0000 (19:15 +0000)]
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
https://bugs.webkit.org/show_bug.cgi?id=100435

Reviewed by James Robinson.

This is similar to other Web geometry types, but the WebFloatPoint is
missing it.

* chromium/public/WebFloatPoint.h:
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator gfx::PointF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-webkit-clip-path property should just reference clipPath
krit@webkit.org [Fri, 26 Oct 2012 19:06:00 +0000 (19:06 +0000)]
-webkit-clip-path property should just reference clipPath
https://bugs.webkit.org/show_bug.cgi?id=100531

Reviewed by Eric Seidel.

Source/WebCore:

The -webkit-clip-path property should just reference clipPath. Added a check for that.

Test: css3/masking/clip-path-reference-of-fake-clipPath.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Check that anther SVG resource like mask can not be referenced as clipPath.

* css3/masking/clip-path-reference-of-fake-clipPath-expected.txt: Added.
* css3/masking/clip-path-reference-of-fake-clipPath.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the circular reference between TextTrack and TextTrackCue
commit-queue@webkit.org [Fri, 26 Oct 2012 18:51:21 +0000 (18:51 +0000)]
Remove the circular reference between TextTrack and TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=100300

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Eric Carlson.

Changed TextTrackCue.m_track to a normal pointer to break the circular
reference that was keeping both objects from ever getting deleted.

No new tests. This simply fixes a memory leak.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::~TextTrackCue):
(WebCore::TextTrackCue::track):
(WebCore::TextTrackCue::setTrack):
* html/track/TextTrackCue.h:
(TextTrackCue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Breakpoints are not managed correctly when editing uiSourceCode that...
vsevik@chromium.org [Fri, 26 Oct 2012 18:47:29 +0000 (18:47 +0000)]
Web Inspector: Breakpoints are not managed correctly when editing uiSourceCode that was bound to ScriptFile after JavaScriptSourceFrame creation.
https://bugs.webkit.org/show_bug.cgi?id=100535

Reviewed by Pavel Feldman.

Added SourceMappingChanged event to UISourceCode and made
JavaScriptSourceFrame update ScriptFile events listeners on it.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onSourceMappingChanged):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setSourceMapping):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild bot gives incorrect link to EWS build failure
wangxianzhu@chromium.org [Fri, 26 Oct 2012 18:44:40 +0000 (18:44 +0000)]
Build bot gives incorrect link to EWS build failure
https://bugs.webkit.org/show_bug.cgi?id=100436

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.__init__):
(MockCommitQueue.command_failed): Return incremental failure_status_id
(CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
rakuco@webkit.org [Fri, 26 Oct 2012 18:41:10 +0000 (18:41 +0000)]
webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602

Reviewed by Dirk Pranke.

Tools:

Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.

The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that. Plus, perform a socket.getaddrinfo() call
the same way Apache itself does so we are sure we only enable IPV6
when setting that up in the httpd server is not going to fail.

* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_cygwin):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):
* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.__init__):

LayoutTests:

* http/conf/apache2-debian-httpd.conf: Remove the `Listen'
directive and related comments, it is passed to httpd by webkitpy
now.
* http/conf/apache2-httpd.conf: Ditto.
* http/conf/cygwin-httpd.conf: Ditto.
* http/conf/fedora-httpd.conf: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update my IRC nickname to a registered one.
dbarton@mathscribe.com [Fri, 26 Oct 2012 18:18:14 +0000 (18:18 +0000)]
Unreviewed. Update my IRC nickname to a registered one.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132644.
scheib@chromium.org [Fri, 26 Oct 2012 17:49:23 +0000 (17:49 +0000)]
Unreviewed, rolling out r132644.
http://trac.webkit.org/changeset/132644
https://bugs.webkit.org/show_bug.cgi?id=100497

Causes webkit_unit_tests
MemoryInstrumentationTest.ImageObserver to fail.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
* platform/network/chromium/ResourceRequest.cpp:
* platform/network/chromium/ResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocompositing/tiling/huge-layer* flakey
simon.fraser@apple.com [Fri, 26 Oct 2012 17:30:23 +0000 (17:30 +0000)]
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

Reviewed by Dan Bernstein.

In r131009 I fixed layerTreeAsText() to not be flakey with tiled layers, by ensuring that
we flush layer state before dumping the layer tree. That makes these tests non-flakey. I was
also able to remove all the setTimeouts() from these tests.

The 'usingTiledLayer' property is only dumped on Mac, so made cross-platform results without
this flag, and added Mac-specific results with it.

Unskipped some tests on non-Mac platforms that should now pass.

* compositing/tiling/backface-preserve-3d-tiled-expected.txt:
* compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* compositing/tiling/huge-layer-add-remove-child-expected.txt:
* compositing/tiling/huge-layer-add-remove-child.html: Added.
* compositing/tiling/huge-layer-add-remove-child.html-disabled: Removed.
* compositing/tiling/huge-layer-expected.txt:
* compositing/tiling/huge-layer-img-expected.txt:
* compositing/tiling/huge-layer-img.html: Renamed from LayoutTests/compositing/tiling/huge-layer-img.html-disabled.
* compositing/tiling/huge-layer-resize-expected.txt:
* compositing/tiling/huge-layer-with-layer-children-expected.txt:
* compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* compositing/tiling/huge-layer-with-layer-children-resize.html: Added.
* compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Removed.
* compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html-disabled.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Copied from LayoutTests/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
* platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Copied from LayoutTests/compositing/tiling/crash-reparent-tiled-layer-expected.txt.
* platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child-expected.txt.
* platform/mac/compositing/tiling/huge-layer-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-expected.txt.
* platform/mac/compositing/tiling/huge-layer-img-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.txt.
* platform/mac/compositing/tiling/huge-layer-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-resize-expected.txt.
* platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-expected.txt.
* platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable fast/images/exif-orientation.html
thakis@chromium.org [Fri, 26 Oct 2012 17:30:01 +0000 (17:30 +0000)]
[chromium] Enable fast/images/exif-orientation.html
https://bugs.webkit.org/show_bug.cgi?id=100534

Unreviewed, TestExpecations change.

The baselines for this test landed yesterday.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] MiniBrowser segfaults on exit after using WebGL.
zeno.albisser@digia.com [Fri, 26 Oct 2012 17:19:10 +0000 (17:19 +0000)]
[Qt] MiniBrowser segfaults on exit after using WebGL.
https://bugs.webkit.org/show_bug.cgi?id=100523

The display connection must not be closed before
destroying the offscreen window.
Therefore opening the connection is moved to the
getXWindow() function. And closing the connection
is being moved to the destructor of the offscreen window.

Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::getXWindow):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn PageLoad tests into simple performancetests, commit #5
zoltan@webkit.org [Fri, 26 Oct 2012 16:31:33 +0000 (16:31 +0000)]
Turn PageLoad tests into simple performancetests, commit #5
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #5 commit of the whole patch.

* PageLoad/svg/files/Harvey_Rayner.svg: Removed.
* PageLoad/svg/files/Sierpinski_carpet_6.svg: Removed.
* PageLoad/svg/files/mtsthelens.svg: Removed.
* PageLoad/svg/files/mtsthelens0.jpg: Removed.
* SVG/HarveyRayner.html: Added.
* SVG/MtSaintHelens.html: Added.
* SVG/SierpinskiCarpet.html: Added.
* SVG/resources/HarveyRayner.svg: Copied from PerformanceTests/PageLoad/svg/files/Harvey_Rayner.svg.
* SVG/resources/MtSaintHelens.svg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens.svg.
* SVG/resources/SierpinskiCarpet.svg: Copied from PerformanceTests/PageLoad/svg/files/Sierpinski_carpet_6.svg.
* SVG/resources/mtsthelens0.jpg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens0.jpg.
* Skipped: Rename the files on the skipped list also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
commit-queue@webkit.org [Fri, 26 Oct 2012 16:25:52 +0000 (16:25 +0000)]
[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100529

Patch by Parth Patel <parpatel@rim.com> on 2012-10-26
Reviewed by Yong Li.

No new tests added as there was no behavioural change.

* platform/network/blackberry/NetworkManager.cpp:
(WebCore):
* platform/network/blackberry/NetworkManager.h:
(NetworkManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix log-type icon alignment.
mkwst@chromium.org [Fri, 26 Oct 2012 16:12:36 +0000 (16:12 +0000)]
Web Inspector: Fix log-type icon alignment.
https://bugs.webkit.org/show_bug.cgi?id=100520

Reviewed by Yury Semikhatsky.

The icons are just a pixel or two off, and it's driving me nuts.

* inspector/front-end/inspector.css:
(.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
(.console-warning-level::before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplaceable attributes should also have readonly
arv@chromium.org [Fri, 26 Oct 2012 16:09:57 +0000 (16:09 +0000)]
Replaceable attributes should also have readonly
https://bugs.webkit.org/show_bug.cgi?id=91768

Reviewed by Adam Barth.

This updates the code generators for JSC and V8 to handle this case correctly.

* Modules/intents/DOMWindowIntents.idl:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear m_orientation in FrameData::clear() for skia
thakis@chromium.org [Fri, 26 Oct 2012 15:58:42 +0000 (15:58 +0000)]
Clear m_orientation in FrameData::clear() for skia
https://bugs.webkit.org/show_bug.cgi?id=100456

Reviewed by Stephen White.

clear() is only called by the FrameData destructor and for multi-image
images in BitmapImage::destroyDecodedData(). Multi-frame images don't
have exif data, so this patch should have no effect in practice. It
makes the skia code match the CG code in BitmapImageCG.cpp though.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash on loading SVG filter resource on HTML element
fmalita@chromium.org [Fri, 26 Oct 2012 15:57:08 +0000 (15:57 +0000)]
Crash on loading SVG filter resource on HTML element
https://bugs.webkit.org/show_bug.cgi?id=100491

Reviewed by Dirk Schulze.

Source/WebCore:

Skip non-filter elements referenced via -webkit-filter.

Test: svg/filters/filter-reference-crash.html

* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):

LayoutTests:

* svg/filters/filter-reference-crash-expected.txt: Added.
* svg/filters/filter-reference-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences
antti@apple.com [Fri, 26 Oct 2012 15:49:30 +0000 (15:49 +0000)]
Lots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences
https://bugs.webkit.org/show_bug.cgi?id=100514

Reviewed by Anders Carlsson.

DNSResolveQueue::platformProxyIsEnabledInSystemPreferences gets called for every link in
the document. The function is relatively slow.

This patch caches the result of the last check for 5 seconds. Based on code comments
prefetching is disabled with proxies due to regressing performance with some configurations.
Proxy status changes rarely and a slight reaction delay shoudn't cause practical problems.

* platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):

    Add constructor. Also fixes a bug, m_requestsInFlight was not initialized.

(WebCore):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::fired):
* platform/network/DNSResolveQueue.h:
(DNSResolveQueue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132662.
loislo@chromium.org [Fri, 26 Oct 2012 15:42:49 +0000 (15:42 +0000)]
Unreviewed, rolling out r132662.
http://trac.webkit.org/changeset/132662
https://bugs.webkit.org/show_bug.cgi?id=100528

It is not necessary any more. (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for Qt builders.
loislo@chromium.org [Fri, 26 Oct 2012 15:36:58 +0000 (15:36 +0000)]
Unreviewed build fix for Qt builders.

* platform/qt/MemoryUsageSupportQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132658.
ossy@webkit.org [Fri, 26 Oct 2012 15:33:27 +0000 (15:33 +0000)]
Unreviewed, rolling out r132658.
http://trac.webkit.org/changeset/132658
https://bugs.webkit.org/show_bug.cgi?id=100515

It broke the Qt build

* inspector/InspectorMemoryAgent.cpp:
(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
* platform/MemoryUsageSupport.h:
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
* platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
* platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Remove empty buggy directories.
ossy@webkit.org [Fri, 26 Oct 2012 15:21:31 +0000 (15:21 +0000)]
Unreviewed. Remove empty buggy directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Some context menu items are duplicated on Resources and Sources panels.
vsevik@chromium.org [Fri, 26 Oct 2012 15:13:52 +0000 (15:13 +0000)]
Web Inspector: Some context menu items are duplicated on Resources and Sources panels.
https://bugs.webkit.org/show_bug.cgi?id=100522

Reviewed by Pavel Feldman.

Method appendApplicableItems now receives event as a parameter.
HandlerRegistry now makes sure that it is not called more than once for certain context menu event.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):
* inspector/front-end/ConsoleView.js:
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.prototype.show):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
(WebInspector.ContextMenu.Provider.prototype.appendApplicableItems):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._contextMenu):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._contextMenu):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
* inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._contextMenu):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.handleContextMenu):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
* inspector/front-end/NetworkPanelDescriptor.js:
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
* inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._contextMenu):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: instrument chromium GlyphCache. It keeps ~2mb data on gmail.
loislo@chromium.org [Fri, 26 Oct 2012 15:07:46 +0000 (15:07 +0000)]
Web Inspector: instrument chromium GlyphCache. It keeps ~2mb data on gmail.
https://bugs.webkit.org/show_bug.cgi?id=100515

Reviewed by Yury Semikhatsky.

I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
* platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
* platform/chromium/MemoryUsageSupportChromium.cpp:
(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Get rid of C'ism in text checker API
commit-queue@webkit.org [Fri, 26 Oct 2012 14:58:31 +0000 (14:58 +0000)]
[EFL][WK2] Get rid of C'ism in text checker API
https://bugs.webkit.org/show_bug.cgi?id=100513

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Text_Checker a C++ class and move the
WebKitTextChecker code to this new class. This
gets rid of the C'ism in the text checker code
and make it consistent with other Ewk classes.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
* UIProcess/API/efl/ewk_settings.cpp:
(spellCheckingLanguagesSetUpdate):
(ewk_settings_continuous_spell_checking_enabled_set):
(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_get):
* UIProcess/API/efl/ewk_text_checker.cpp:
(ClientCallbacks):
(textCheckerEnchant):
(clientCallbacks):
(isContinuousSpellCheckingEnabled):
(setContinuousSpellCheckingEnabled):
(uniqueSpellDocumentTag):
(closeSpellDocumentWithTag):
(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):
(Ewk_Text_Checker):
(Ewk_Text_Checker::availableSpellCheckingLanguages):
(Ewk_Text_Checker::updateSpellCheckingLanguages):
(Ewk_Text_Checker::loadedSpellCheckingLanguages):
(Ewk_Text_Checker::initialize):
* UIProcess/API/efl/ewk_text_checker_private.h:
(Ewk_Text_Checker):
* UIProcess/efl/WebKitTextChecker.cpp: Removed.
* UIProcess/efl/WebKitTextChecker.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Build fix for r132650.
tkent@chromium.org [Fri, 26 Oct 2012 14:58:17 +0000 (14:58 +0000)]
[Chromium] Build fix for r132650.
https://bugs.webkit.org/show_bug.cgi?id=100482

* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::timeFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Memory instrumentation: don't count memory of WrapperTypeInfo
yurys@chromium.org [Fri, 26 Oct 2012 14:49:20 +0000 (14:49 +0000)]
[v8] Memory instrumentation: don't count memory of WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=100517

Reviewed by Alexander Pavlov.

* bindings/v8/V8PerIsolateData.cpp: when estimating bindings memory size skip
pointers to WrapperTypeInfo objects as they are static fields and belong to
the data segment.
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] should enable two postredirect tests
commit-queue@webkit.org [Fri, 26 Oct 2012 14:43:32 +0000 (14:43 +0000)]
[WK2] should enable two postredirect tests
https://bugs.webkit.org/show_bug.cgi?id=100508

Unreviewed gardening.

The EFL results for these tests seem to have been wrong from the beginning.
Update expected results, enable tests for WK2 (based on comment in
TestExpectations these were skipped because efl failed).

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-26

* platform/efl/http/tests/navigation/postredirect-basic-expected.png:
* platform/efl/http/tests/navigation/postredirect-basic-expected.txt:
* platform/efl/http/tests/navigation/postredirect-goback1-expected.png:
* platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateS...
commit-queue@webkit.org [Fri, 26 Oct 2012 14:30:12 +0000 (14:30 +0000)]
[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
https://bugs.webkit.org/show_bug.cgi?id=100504

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-26
Reviewed by Yong Li.

PR #232038 The similar PR # 200724.
Reviewed internally by Petter Wang.

This issue is same as bug 95492, and this patch is same as its patch.
Hold the JSLock for the current thread before we call toRef to avoid
the ASSERT failure.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor Localizer-related classes.
tkent@chromium.org [Fri, 26 Oct 2012 14:22:53 +0000 (14:22 +0000)]
Refactor Localizer-related classes.
https://bugs.webkit.org/show_bug.cgi?id=100482

Reviewed by Kentaro Hara.

- Localizer has unused code
 Localizer should have function implementations only if they are used in
 multiple subclasses.
- Some Localizer subclasses hide Localizer data members
- Should use String::isNull to check initialization-or-not

No new tests. This should not change any behavior.

* platform/text/Localizer.h:
(Localizer):
- timeFormat, shortTimeFormat, and timeAMPMLabels should be pure virtual.
- Remove m_localizedDateFormatText, m_localizedShortTimeFormatText, and
  m_timeAMPMLabels
* platform/text/Localizer.cpp:
Remove implementations of timeFormat, shortTimeFormat, and timeAMPMLabels.

* platform/text/LocaleICU.h:
(LocaleICU): Introduce m_timeFormatWithSeconds and m_timeFormatWithoutSeconds.
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat):
Use new data members instead of Localizer data members.
(WebCore::LocaleICU::dateFormat): Use isNull.

* platform/text/LocaleNone.cpp:
(LocaleNone): Add timeFormat, shortTimeFormat, timeAMPMLabels
implementations, and m_timeAMPMLabels.
(WebCore::LocaleNone::timeFormat): Returns the HTML time format.
(WebCore::LocaleNone::shortTimeFormat): Returns the HTML time format.
(WebCore::LocaleNone::timeAMPMLabels): Returns "AM" and "PM".

* platform/text/LocaleWin.h:
(LocaleWin): Add m_timeFormatWithSeconds.
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Use isNull.
(WebCore::LocaleWin::timeFormat): Use m_timeFormatWithSeconds.

* platform/text/mac/LocaleMac.h:
(LocaleMac): Rename m_localized*TimeFormatText to m_timeFormatWith*Seconds.
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::timeFormat): Follow the renaming.
(WebCore::LocaleMac::shortTimeFormat): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip a few tests which produce wrong pixel expectations.
rakuco@webkit.org [Fri, 26 Oct 2012 14:19:47 +0000 (14:19 +0000)]
[EFL] Skip a few tests which produce wrong pixel expectations.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in PagePopupController by events after WebPagePopupImpl::closePopup
tkent@chromium.org [Fri, 26 Oct 2012 14:07:49 +0000 (14:07 +0000)]
Crash in PagePopupController by events after WebPagePopupImpl::closePopup
https://bugs.webkit.org/show_bug.cgi?id=100454

Reviewed by Hajime Morita.

No new tests. The bug is timing-dependent.

* page/DOMWindowPagePopup.cpp:
(WebCore::DOMWindowPagePopup::~DOMWindowPagePopup):
Calls clearPagePopupClient for the associalated PagePopupController object.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::setValueAndClosePopup):
Do nothing if m_popupClient is 0.
(WebCore::PagePopupController::localizeNumberString): Ditto.
(WebCore::PagePopupController::clearPagePopupClient): Added.
* page/PagePopupController.h:
(PagePopupController): Declare clearPagePopupClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Clean up construction/destruction code in Ewk_view
commit-queue@webkit.org [Fri, 26 Oct 2012 13:43:35 +0000 (13:43 +0000)]
[EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Simplified a lot of initialization and destruction code of Ewk_view and EwkViewImpl
put all the impl stuff to its constructor and destructor, also made EwkViewImpl member
variables private.

* UIProcess/API/efl/EwkViewImpl.cpp:
(pageViewMap):
(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::wkPage):
(EwkViewImpl::title):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onFaviconChanged):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
(EwkViewImpl::ewkContext):
(EwkViewImpl::backForwardList):
* UIProcess/API/efl/ewk_settings.cpp:
(Ewk_Settings::preferences):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(createEwkViewSmartClass):
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_feed_touch_event):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add custom expectation for test added in r131557.
rakuco@webkit.org [Fri, 26 Oct 2012 13:32:32 +0000 (13:32 +0000)]
[EFL] Add custom expectation for test added in r131557.

* platform/efl/fast/replaced/border-radius-clip-content-edge-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Bring device geolocation and orientation emulation from behind the...
apavlov@chromium.org [Fri, 26 Oct 2012 13:27:53 +0000 (13:27 +0000)]
Web Inspector: Bring device geolocation and orientation emulation from behind the experiment
https://bugs.webkit.org/show_bug.cgi?id=100220

Reviewed by Yury Semikhatsky.

* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: report memory occupied by ResourceRequest instead of its...
yurys@chromium.org [Fri, 26 Oct 2012 13:20:38 +0000 (13:20 +0000)]
Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497

Reviewed by Alexander Pavlov.

Added memory reporting method to Chromium implementation of ResourceRequest.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase): Renamed reportMemoryUsage
on ResourceRequestBase to reportMemoryUsageBase and made it protected. I'd
rather make ResourceRequestBase::reportMemoryUsage virtual and override it
in the descendant but ResourceRequestBase doesn't have any virtual methods
and shouldn't be used directly (ResourceRequest should be used instead).
* platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
(WebCore):
* platform/network/chromium/ResourceRequest.h:
(ResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Initialize Ewk_Context class members in initialization list
commit-queue@webkit.org [Fri, 26 Oct 2012 13:17:51 +0000 (13:17 +0000)]
[EFL][WK2] Initialize Ewk_Context class members in initialization list
https://bugs.webkit.org/show_bug.cgi?id=100503

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move Ewk_Context class members initialization from the
constructor body to the initialization list for
efficiency.

* UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove the on-hover highlighting of console messages
apavlov@chromium.org [Fri, 26 Oct 2012 13:14:50 +0000 (13:14 +0000)]
Web Inspector: Remove the on-hover highlighting of console messages
https://bugs.webkit.org/show_bug.cgi?id=100511

Reviewed by Pavel Feldman.

This clashes with the hovered element highlight in console messages.

* inspector/front-end/inspector.css:
(ol.watch-expressions > li.hovered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132612.
commit-queue@webkit.org [Fri, 26 Oct 2012 13:13:00 +0000 (13:13 +0000)]
Unreviewed, rolling out r132612.
http://trac.webkit.org/changeset/132612
https://bugs.webkit.org/show_bug.cgi?id=100512

Crashes fast/events/tabindex-focus-blur-all.html in debug mode
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

Source/WebCore:

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):
* rendering/RenderTableCol.h:
(RenderTableCol):

LayoutTests:

* fast/table/col-span-change-relayout-expected.txt: Removed.
* fast/table/col-span-change-relayout.html: Removed.
* fast/table/simplified-layout-table-expected.html: Removed.
* fast/table/simplified-layout-table.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayerTreeCoordinator: Make sure that dependent layers are deleted before their direct...
jocelyn.turcotte@digia.com [Fri, 26 Oct 2012 12:55:57 +0000 (12:55 +0000)]
LayerTreeCoordinator: Make sure that dependent layers are deleted before their directly composited image
https://bugs.webkit.org/show_bug.cgi?id=100495

Reviewed by Kenneth Rohde Christiansen.

Since r128980 layers removals are delayed until we flush the layer tree.
This causes a crash if such a layer had a directly composited image since
the image is now deleted while the layer is still active in the UI process
and tries to access a deleted backing store.

Fix it by delaying the directly composited image removal as well.

Fixes a crash in tst_QQuickWebView::basicRenderingSanity since showWebView is
called first and loads direct-image-compositing.html.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer): Remove unused variable.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fast return upon setting the same dock side.
pfeldman@chromium.org [Fri, 26 Oct 2012 12:55:27 +0000 (12:55 +0000)]
Web Inspector: fast return upon setting the same dock side.
https://bugs.webkit.org/show_bug.cgi?id=100510

Reviewed by Vsevolod Vlasov.

Added fast return.

* inspector/front-end/DockController.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Apple Win gardening.
dominik.rottsches@intel.com [Fri, 26 Oct 2012 12:54:40 +0000 (12:54 +0000)]
Unreviewed Apple Win gardening.

* platform/win/TestExpectations: Skipping XHR timeout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGerman de.po translation needs update
kov@webkit.org [Fri, 26 Oct 2012 12:48:54 +0000 (12:48 +0000)]
German de.po translation needs update
https://bugs.webkit.org/show_bug.cgi?id=91349

Patch by Christian Kirbach <Christian.Kirbach@gmail.com> on 2012-10-26
Rubber-stamped by Gustavo Noronha.

* de.po: updated with proof-read version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the LLInt build on Windows
commit-queue@webkit.org [Fri, 26 Oct 2012 12:48:36 +0000 (12:48 +0000)]
[Qt] Fix the LLInt build on Windows
https://bugs.webkit.org/show_bug.cgi?id=97648

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

The main change for the port on Windows is changing the way offsets are extracted
and the LLIntAssembly.h is generated to accomodate release and debug configurations.

Firstly the LLIntOffsetsExtractor binary is now built as-is (no DESTDIR set) and
placed into debug\LLIntOffsetsExtractor.exe and release\LLIntOffsetsExtractor.exe
on Windows debug_and_release builds. On other patforms it remainds in the regular
out directory.

Secondly the LLIntAssembly.h files must be different for different build types,
so the LLIntAssembly.h generator in DerivedSources.pri operates no on the extractor
binary files as input. Using a simple exists() check we verify the presence of either
a regular, a debug\LLIntOffsetsExtractor and a release\LLIntOffsetsExtractor binary
and process all of them. The resulting assembly files consequently end up in
generated\debug\LLIntAssembly.h and generated\release\LLIntAssembly.h.

In Target.pri we have to also make sure that those directories are in the include
path according to the release or debug configuration.

Lastly a small tweak - swapping WTF.pri and JSC.pri inclusions - in the
LLIntOffsetsExtractor build was needed to make sure that we include
JavaScriptCore/config.h instead of WTF/config.h, required to fix the
build issues originally pasted in bug #97648.

* DerivedSources.pri:
* JavaScriptCore.pro:
* LLIntOffsetsExtractor.pro:
* Target.pri:

Tools:

Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
executable programs on Windows. Empty otherwise. Also added support for force_build_all
to allow overriding us disabling build_all for TEMPLATE = app.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's
zandobersek@gmail.com [Fri, 26 Oct 2012 12:40:09 +0000 (12:40 +0000)]
Unreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's
positioned after the IEND PNG chunk.

* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial build fix: It's glXGetCurrentContext not glxGetCurrentContext :)
hausmann@webkit.org [Fri, 26 Oct 2012 12:38:47 +0000 (12:38 +0000)]
Unreviewed trivial build fix: It's glXGetCurrentContext not glxGetCurrentContext :)

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrinting should use use high resolution images when available
kenneth@webkit.org [Fri, 26 Oct 2012 12:27:15 +0000 (12:27 +0000)]
Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100488

Reviewed by Antti Koivisto.

The images loaded using -webkit-device-pixel-ratio depends on
the display type (deviceScaleFactor) and thus affects which
images are being used for printing. Printing should always
use the higher resolution images (aka 'retina' images).

Source/WebCore:

Test: fast/media/mq-pixel-ratio-print.html

* css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):

LayoutTests:

Added a test testing -webkit-device-pixel-ratio media query
in conjuntion with 'print' media type.

* fast/media/mq-pixel-ratio-print-expected.txt: Added.
* fast/media/mq-pixel-ratio-print.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI instrument InspectorResourceAgent. it caches resources for the...
loislo@chromium.org [Fri, 26 Oct 2012 12:25:27 +0000 (12:25 +0000)]
Web Inspector: NMI instrument InspectorResourceAgent. it caches resources for the front-end.
https://bugs.webkit.org/show_bug.cgi?id=100496

Reviewed by Yury Semikhatsky.

It is plain instrumentation for InspectorResourceAgent and NetworkResourceData which is used by the agent.

* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
(WebCore):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
* inspector/NetworkResourcesData.h:
(XHRReplayData):
(ResourceData):
(NetworkResourcesData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] ... And another pixel rebaseline after r131941 and r131991.
rakuco@webkit.org [Fri, 26 Oct 2012 12:25:26 +0000 (12:25 +0000)]
[EFL] ... And another pixel rebaseline after r131941 and r131991.

* platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132493.
dominik.rottsches@intel.com [Fri, 26 Oct 2012 12:24:15 +0000 (12:24 +0000)]
Unreviewed, rolling out r132493.
http://trac.webkit.org/changeset/132493
https://bugs.webkit.org/show_bug.cgi?id=100509

It didn't fix the tests on the bot as we had hoped. (Requested
by drott on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.
hausmann@webkit.org [Fri, 26 Oct 2012 12:19:46 +0000 (12:19 +0000)]
[Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100493

Once QXcbNativeInterface::nativeResourceForContext() can provide the
GLXContext for an existing QOpenGLContext, this patch shall be reverted.

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Simon Hausmann.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
hausmann@webkit.org [Fri, 26 Oct 2012 12:19:21 +0000 (12:19 +0000)]
[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100492

This patch removes most of the QOpenGLContext related code
from GraphicsSurfaceGLX. This allows sharing almost all
GraphicsSurfaceGLX code with EFL, by relying on pure GLX.

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Enable WebGL
hausmann@webkit.org [Fri, 26 Oct 2012 12:18:57 +0000 (12:18 +0000)]
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652

Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.

.:

Use Graphics Surface to enable WebGL for WebKit2 EFL.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.

No new tests. Covered by existing tests.

* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
* platform/graphics/surfaces/efl: Added.
* platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Source/WebKit2:

Set WebGLEnabled to true when WebGL is enabled.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: chromium baselines for selection-after-remove updated.
pfeldman@chromium.org [Fri, 26 Oct 2012 12:16:10 +0000 (12:16 +0000)]
Not reviewed: chromium baselines for selection-after-remove updated.

* platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
* platform/chromium-win/fast/repaint/selection-after-remove-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132607.
kbalazs@webkit.org [Fri, 26 Oct 2012 12:05:03 +0000 (12:05 +0000)]
Unreviewed, rolling out r132607.
http://trac.webkit.org/changeset/132607
https://bugs.webkit.org/show_bug.cgi?id=100502

"SOS! More wrong paths." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Removed.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Removed.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Removed.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Removed.
* platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Removed.
* platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Removed.
* platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132604.
kbalazs@webkit.org [Fri, 26 Oct 2012 11:58:05 +0000 (11:58 +0000)]
Unreviewed, rolling out r132604.
http://trac.webkit.org/changeset/132604
https://bugs.webkit.org/show_bug.cgi?id=100501

"SOS! Wrong paths." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
* platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Removed.
* platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Removed.
* platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Removed.
* platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Removed.
* platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Removed.
* platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Removed.
* platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Removed.
* platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Removed.
* platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Removed.
* platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Removed.
* platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Removed.
* platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Overrides] Do not persist the User Agent "master switch"
apavlov@chromium.org [Fri, 26 Oct 2012 11:55:53 +0000 (11:55 +0000)]
Web Inspector: [Overrides] Do not persist the User Agent "master switch"
https://bugs.webkit.org/show_bug.cgi?id=100484

Reviewed by Yury Semikhatsky.

The User Agent override state is managed in the front-end, just like for other override-able parameters.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
* inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement):
* inspector/front-end/UserAgentSupport.js:
(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleUserAgentOverride):
(WebInspector.UserAgentSupport.prototype._userAgentChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] More pixel rebaselines after r131941 and r131991.
rakuco@webkit.org [Fri, 26 Oct 2012 11:53:11 +0000 (11:53 +0000)]
[EFL] More pixel rebaselines after r131941 and r131991.

* platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
* platform/efl/fast/dynamic/containing-block-change-expected.png:
* platform/efl/fast/forms/listbox-clip-expected.png:
* platform/efl/fast/frames/inline-object-inside-frameset-expected.png:
* platform/efl/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
* platform/efl/fast/layers/inline-dirty-z-order-lists-expected.png:
* platform/efl/fast/layers/layer-content-visibility-change-expected.png:
* platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.png:
* platform/efl/fast/reflections/inline-crash-expected.png:
* platform/efl/fast/replaced/width100percent-textarea-expected.png:
* platform/efl/fast/text/font-initial-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow]: removing styles in shadow dom subtree causes crash.
tasak@google.com [Fri, 26 Oct 2012 11:42:54 +0000 (11:42 +0000)]
[Shadow]: removing styles in shadow dom subtree causes crash.
https://bugs.webkit.org/show_bug.cgi?id=100455

Reviewed by Hajime Morita.

Source/WebCore:

To quickly check whether shadow roots or elements have any scoped
styles or not, elements have hasStyleScoped flag. If elements have
any scoped styles, the styles are direct children of the element.
The original code just sees how many chilren are scoped style or not.
However styles in shadow dom subtree are registered with the shadow
root but are not always direct children of shadow roots. So to check
whether shadow roots have any scoped styles, modified to count
number of styles registered with the shadow root.

Test: fast/dom/shadow/remove-styles-in-shadow-crash.html

* dom/Node.cpp:
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
Made the above two method virtual. class ShadowRoot overrides these
methods.
(WebCore::Node::numberOfScopedHTMLStyleChildren):
Moved HTMLStyleElement.cpp to Node.cpp, because the above two methods
are moved into Node.cpp.
* dom/Node.h:
(Node):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::registerScopedHTMLStyleChild):
(WebCore::ShadowRoot::unregisterScopedHTMLStyleChild):
Modify to count how many styles are registered with the shadow root.
The "counting" is done when styles are registered and unregistered
with the shadow root, i.e. style element is inserted into document or
removed from document. When unregister some style, there are no more
styles registered with the shadow root. Set style scoped flag false.
* dom/ShadowRoot.h:
(ShadowRoot):
* html/HTMLStyleElement.cpp:
* html/HTMLStyleElement.h:
(WebCore::HTMLStyleElement::isRegisteredAsScoped):
Now isRegisteredAsScoped is used in Node.cpp, so removed inline and
moved .cpp to .h.

LayoutTests:

* fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt: Added.
* fast/dom/shadow/remove-styles-in-shadow-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132589.
commit-queue@webkit.org [Fri, 26 Oct 2012 11:40:16 +0000 (11:40 +0000)]
Unreviewed, rolling out r132589.
http://trac.webkit.org/changeset/132589
https://bugs.webkit.org/show_bug.cgi?id=100498

Breaks font-face layout tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening to make the bots green
commit-queue@webkit.org [Fri, 26 Oct 2012 11:39:36 +0000 (11:39 +0000)]
[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=100481

Unreviewed EFL gardening.

Skip failing test and also unskip tests that are
consistently passing.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-26

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM] Needs @host rule for ShadowDOM styling
tasak@google.com [Fri, 26 Oct 2012 11:33:22 +0000 (11:33 +0000)]
[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Reviewed by Hajime Morita.

Source/WebCore:

Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit

Test: fast/dom/shadow/athost-atrules.html

* css/CSSGrammar.y.in:
Added rules for parsing @host @-rules.
* css/CSSParser.cpp:
(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):
* css/CSSParser.h:
Added a declaration of the above new method: createHostRule.
* css/CSSPropertySourceData.h:
Added HOST_RULE to enum Type.
* css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.
* css/RuleSet.h:
(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):
* css/StyleResolver.cpp:
(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.
* css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):
* css/StyleRule.h:
(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleScopeResolver.h:
(WebCore):
(StyleScopeResolver):
* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

* fast/dom/shadow/athost-atrules-expected.txt: Added.
* fast/dom/shadow/athost-atrules.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add Ewk_Color_Picker API
commit-queue@webkit.org [Fri, 26 Oct 2012 11:32:25 +0000 (11:32 +0000)]
[EFL][WK2] Add Ewk_Color_Picker API
https://bugs.webkit.org/show_bug.cgi?id=100472

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move the color picker code out of EwkViewImpl and into
a new Ewk_Color_Picker class to avoid cluttering the
view code.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_color_picker.cpp: Added.
(Ewk_Color_Picker::Ewk_Color_Picker):
(Ewk_Color_Picker::setColor):
(Ewk_Color_Picker::color):
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):
* UIProcess/API/efl/ewk_color_picker.h: Added.
* UIProcess/API/efl/ewk_color_picker_private.h: Added.
(Ewk_Color_Picker):
(Ewk_Color_Picker::create):
* UIProcess/API/efl/ewk_view.cpp:
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Added.
(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(hideColorPickerByRemovingElement):
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::showColorPicker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix test pixel expectation.
rakuco@webkit.org [Fri, 26 Oct 2012 11:26:28 +0000 (11:26 +0000)]
[EFL] Fix test pixel expectation.

* platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
commit-queue@webkit.org [Fri, 26 Oct 2012 11:21:25 +0000 (11:21 +0000)]
[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
https://bugs.webkit.org/show_bug.cgi?id=82315

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

This patch implements accelerated-compositing-related functions
to enter accelerated-compositing mode and sync layers
in ChromeClientEfl and ewkView.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_accelerated_compositing_cb):
Sync and render layers.
(_ewk_view_accelerated_compositing_context_create_if_needed):
Create a new AcceleratedCompositingContext.
(ewk_view_accelerated_compositing_object_create):
Create a new evas_image_object act as render target surface.
(ewk_view_accelerated_compositing_context_get):
Return the GraphicsContext3D for accelerated compositing.
(ewk_view_root_graphics_layer_set):
Set the root layer to AcceleratedCompositingContext.
(ewk_view_mark_for_sync):
Mark the evas_image_object for accelerated compositing as dirty to make it update.
* ewk/ewk_view_private.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pixel tests need rebaseline
kbalazs@webkit.org [Fri, 26 Oct 2012 11:21:08 +0000 (11:21 +0000)]
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 5 (svg/dynamic-updates).

* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Add TextAutosizer.cpp in WebCore/CMakeLists.txt
commit-queue@webkit.org [Fri, 26 Oct 2012 11:17:22 +0000 (11:17 +0000)]
[CMAKE] Add TextAutosizer.cpp in WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100476

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Kentaro Hara.

ENABLE_TEXT_AUTOSIZING option is added in CMAKE,
but the source file for that feature is omitted.

No new tests. Covered by existing tests.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never...
jchaffraix@webkit.org [Fri, 26 Oct 2012 11:13:46 +0000 (11:13 +0000)]
RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861

Reviewed by Ojan Vafai.

Source/WebCore:

RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.

Tests: fast/table/col-span-change-relayout.html
       fast/table/simplified-layout-table.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.

* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.

(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called when it was possible.

(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.

* rendering/RenderTableCol.h:
Made the function that we are not expected to be called private.

LayoutTests:

Added 2 tests:
- 1 to cover the code in RenderTableCol::updateFromElement.
- 1 to cover simplified layout on a table.

* fast/table/col-span-change-relayout-expected.txt: Added.
* fast/table/col-span-change-relayout.html: Added.
* fast/table/simplified-layout-table-expected.html: Added.
* fast/table/simplified-layout-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pixel tests need rebaseline
kbalazs@webkit.org [Fri, 26 Oct 2012 11:08:26 +0000 (11:08 +0000)]
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 4 (svg/dynamic-updates).

* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Support pixel tests for BlackBerry DRT
commit-queue@webkit.org [Fri, 26 Oct 2012 11:07:59 +0000 (11:07 +0000)]
[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.

(The following 2 files are missed in previous patch(r132582), adding them
again.)

* DumpRenderTree/blackberry/build: Added.
* DumpRenderTree/blackberry/src.pro: Added.
Adds 2 files for building ImageDiff, by Christopher Wells.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pixel tests need rebaseline
kbalazs@webkit.org [Fri, 26 Oct 2012 11:00:40 +0000 (11:00 +0000)]
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 3 (svg/dynamic-updates).

* platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
* platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132601.
ossy@webkit.org [Fri, 26 Oct 2012 10:52:27 +0000 (10:52 +0000)]
Unreviewed, rolling out r132601.
http://trac.webkit.org/changeset/132601
https://bugs.webkit.org/show_bug.cgi?id=100494

It broke the Qt build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

.:

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):

Source/WebKit:

* PlatformEfl.cmake:

Source/WebKit2:

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pixel tests need rebaseline
kbalazs@webkit.org [Fri, 26 Oct 2012 10:51:48 +0000 (10:51 +0000)]
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 1.

* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Added.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Added.
* platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Added.
* platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Added.
* platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Added.
* platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable JSC's disassembler on x86, x86_64 Linux
kkristof@inf.u-szeged.hu [Fri, 26 Oct 2012 10:50:56 +0000 (10:50 +0000)]
[Qt] Enable JSC's disassembler on x86, x86_64 Linux
https://bugs.webkit.org/show_bug.cgi?id=100386

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-10-26
Reviewed by Simon Hausmann.

It works fine on Linux x86, x86_64 just needs to be enabled in the
QtWebKit build system.

Source/JavaScriptCore:

* DerivedSources.pri:
* JavaScriptCore.pri:
* Target.pri:

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: do not report memory occupied by v8::String
yurys@chromium.org [Fri, 26 Oct 2012 10:50:46 +0000 (10:50 +0000)]
Memory instrumentation: do not report memory occupied by v8::String
https://bugs.webkit.org/show_bug.cgi?id=100487

Reviewed by Alexander Pavlov.

Pointers to v8::String are skipped when reporting memory usage of V8 bindings'
string cache.

* bindings/v8/V8Binding.cpp:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Pixel tests need rebaseline
kbalazs@webkit.org [Fri, 26 Oct 2012 10:45:37 +0000 (10:45 +0000)]
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 1.

* platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
* platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
* platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
* platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
* platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
* platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening, skip a new failing test.
ossy@webkit.org [Fri, 26 Oct 2012 10:40:51 +0000 (10:40 +0000)]
[Qt][WK2] Unreviewed gardening, skip a new failing test.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Add support for auto-height regions with region-breaks
mihnea@adobe.com [Fri, 26 Oct 2012 10:31:04 +0000 (10:31 +0000)]
[CSSRegions] Add support for auto-height regions with region-breaks
https://bugs.webkit.org/show_bug.cgi?id=99952

Reviewed by David Hyatt.

Source/WebCore:

This patch takes region breaks into account when computing the height for auto logical height regions.
When a region break is encountered before/after an element from within a flow thread and we are in the layout
phase in which we lay out the flow threads in regions unconstrained, we use the region break to
compute the region override logical content height if the region break fits inside an auto logical height region.
A region break inside an auto logical height region determines the region override logical content height, taking
min/max height into account.

Tests: fast/regions/autoheight-allregions-nobreaks.html
       fast/regions/autoheight-allregions.html
       fast/regions/autoheight-breakafteralways-maxheight.html
       fast/regions/autoheight-breakbeforealways.html
       fast/regions/autoheight-firstregion-breakalways.html
       fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
       fast/regions/autoheight-lastregion-overflowauto.html
       fast/regions/autoheight-middleregion.html
       fast/regions/autoheight-secondregion-breakoutside.html
       fast/regions/autoheight-secondregion.html
       fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
       fast/regions/autoheight-singleregion-breakafteralways.html
       fast/regions/autoheight-singleregion-breakaftermargin.html
       fast/regions/autoheight-singleregion-breakbeforealways-minheight.html
       fast/regions/autoheight-singleregion-breakbeforealways.html
       fast/regions/autoheight-singleregion-multiplebreaks.html
       fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
       fast/regions/autoheight-singleregion-overflowauto.html

* rendering/RenderBlock.cpp: When encounter a region break before/after an element inside a flow thread,
try to use it to determine the override logical content height for auto logical height regions.
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
Simulate a region break at the end of the flow thread content.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::clearOverrideLogicalContentHeightInRegions):
Helper method used to clear the overrideLogicalContentHeight for auto logical height regions.
(WebCore::RenderFlowThread::addForcedRegionBreak):
Extend the method to process region breaks. The method returns true if at least one auto logical height region
has its override logical content height computed.
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp: Make these methods work with auto logical height regions.
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):

LayoutTests:

Add tests for auto logical height regions with content having region breaks.

* fast/regions/autoheight-allregions-expected.html: Added.
* fast/regions/autoheight-allregions-nobreaks-expected.html: Added.
* fast/regions/autoheight-allregions-nobreaks.html: Added.
* fast/regions/autoheight-allregions.html: Added.
* fast/regions/autoheight-breakafteralways-maxheight-expected.html: Added.
* fast/regions/autoheight-breakafteralways-maxheight.html: Added.
* fast/regions/autoheight-breakbeforealways-expected.html: Added.
* fast/regions/autoheight-breakbeforealways.html: Added.
* fast/regions/autoheight-firstregion-breakalways-expected.html: Added.
* fast/regions/autoheight-firstregion-breakalways.html: Added.
* fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html: Added.
* fast/regions/autoheight-lastregion-overflowauto-breaksignored.html: Added.
* fast/regions/autoheight-lastregion-overflowauto-expected.html: Added.
* fast/regions/autoheight-lastregion-overflowauto.html: Added.
* fast/regions/autoheight-middleregion-expected.html: Added.
* fast/regions/autoheight-middleregion.html: Added.
* fast/regions/autoheight-secondregion-breakoutside-expected.html: Added.
* fast/regions/autoheight-secondregion-breakoutside.html: Added.
* fast/regions/autoheight-secondregion-expected.html: Added.
* fast/regions/autoheight-secondregion.html: Added.
* fast/regions/autoheight-singleregion-breakafteralways-expected.html: Added.
* fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html: Added.
* fast/regions/autoheight-singleregion-breakafteralways-maxheight.html: Added.
* fast/regions/autoheight-singleregion-breakafteralways.html: Added.
* fast/regions/autoheight-singleregion-breakaftermargin-expected.html: Added.
* fast/regions/autoheight-singleregion-breakaftermargin.html: Added.
* fast/regions/autoheight-singleregion-breakbeforealways-expected.html: Added.
* fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html: Added.
* fast/regions/autoheight-singleregion-breakbeforealways-minheight.html: Added.
* fast/regions/autoheight-singleregion-breakbeforealways.html: Added.
* fast/regions/autoheight-singleregion-multiplebreaks-expected.html: Added.
* fast/regions/autoheight-singleregion-multiplebreaks.html: Added.
* fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html: Added.
* fast/regions/autoheight-singleregion-overflowauto-breaksignored.html: Added.
* fast/regions/autoheight-singleregion-overflowauto-expected.html: Added.
* fast/regions/autoheight-singleregion-overflowauto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Enable WebGL
commit-queue@webkit.org [Fri, 26 Oct 2012 10:22:02 +0000 (10:22 +0000)]
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652

Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.

.:

Use Graphics Surface to enable WebGL for WebKit2 EFL.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.

No new tests. Covered by existing tests.

* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
* platform/graphics/surfaces/efl: Added.
* platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Source/WebKit2:

Set WebGLEnabled to true when WebGL is enabled.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd feature flags for CSS Device Adaptation
commit-queue@webkit.org [Fri, 26 Oct 2012 10:20:33 +0000 (10:20 +0000)]
Add feature flags for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95960

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.features.am:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/forms/file/input-file-write-files.html should cover correct setting value
commit-queue@webkit.org [Fri, 26 Oct 2012 10:18:15 +0000 (10:18 +0000)]
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085

Patch by Li Yin <li.yin@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.

Source/WebCore:

From Spec: http://dev.w3.org/html5/spec/single-page.html#dom-input-value-filename
On setting, if the new value is the empty string, it must empty the list of selected
files; otherwise, it must throw an InvalidStateError exception.

Test: fast/forms/file/input-file-value.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLInputElement.idl:

LayoutTests:

The test input-file-value.html is split from input-file-write-test.html.
And add correct setting value for files attribute, verify the files attribute
is writable or not.

* fast/forms/file/input-file-value-expected.txt: Added.
* fast/forms/file/input-file-value.html: Added.
* fast/forms/file/input-file-write-files-expected.txt:
* fast/forms/file/input-file-write-files.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after bug 99824
commit-queue@webkit.org [Fri, 26 Oct 2012 10:09:01 +0000 (10:09 +0000)]
[EFL] Gardening after bug 99824
https://bugs.webkit.org/show_bug.cgi?id=100469

Unreviewed, EFL gardening.

Unskip following 3 test cases after bug 99824 is resolved.
 - fast/lists/w3-css3-list-styles-alphabetic.html
 - fast/lists/w3-css3-list-styles-fallback-style.html
 - fast/lists/w3-list-styles.html

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132552.
commit-queue@webkit.org [Fri, 26 Oct 2012 10:00:27 +0000 (10:00 +0000)]
Unreviewed, rolling out r132552.
http://trac.webkit.org/changeset/132552
https://bugs.webkit.org/show_bug.cgi?id=100486

Makes typeahead tests crash in debug. (Requested by pfeldman
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTTestRunner.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(webkit_support):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestInterfaces::Internal):
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor calendar picker to remove _x/_y from DaysTable
keishi@webkit.org [Fri, 26 Oct 2012 09:56:23 +0000 (09:56 +0000)]
Refactor calendar picker to remove _x/_y from DaysTable
https://bugs.webkit.org/show_bug.cgi?id=100460

Reviewed by Kent Tamura.

_x/_y properties keep the coordinates for the selection but when we add
week and month picking capabilities, the selection can't be expressed as
a set of coordinates. This change will remove it.

No new tests. Covered by calendar-picker-*.html tests.

* Resources/pagepopups/calendarPicker.js:
(DaysTable): Removed _x/_y properties.
(DaysTable.prototype._hasSelection): Changed to refer to the DOM to see if we have a selection.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Lookup the selection position.
(DaysTable.prototype.selectDate): Deselect first so we don't have two selections.
(DaysTable.prototype._selectRangeContainingNode): Selects date/week/month containing the given day node.
(DaysTable.prototype._selectRangeAtPosition): Selects date/week/month at the given position.
(DaysTable.prototype._firstNodeInSelectedRange): Returns first selected day node.
(DaysTable.prototype._deselect): Deselects all selections.
(DaysTable.prototype._handleMouseOver): Use _selectRangeContainingNode so we don't have many places handling the selection.
(DaysTable.prototype._handleMouseOut): Use _deselect.
(DaysTable.prototype._handleKey): Lookup the selection position.
(DaysTable.prototype.updateSelection): Use _selectRangeAtPosition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html
commit-queue@webkit.org [Fri, 26 Oct 2012 09:40:37 +0000 (09:40 +0000)]
[EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html
https://bugs.webkit.org/show_bug.cgi?id=100467

Unreviewed, EFL gardening.

Removing a test failure expectations, the test was fixed in r132548.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Move input method code out of EwkViewImpl
commit-queue@webkit.org [Fri, 26 Oct 2012 09:40:21 +0000 (09:40 +0000)]
[EFL][WK2] Move input method code out of EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100468

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move input method code out of EwkViewImpl and into
a new InputMethodContextEfl class to avoid cluttering
the view code.

* PlatformEfl.cmake:
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::inputMethodContext):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_key_down):
* UIProcess/efl/InputMethodContextEfl.cpp: Added.
(WebKit):
(WebKit::InputMethodContextEfl::InputMethodContextEfl):
(WebKit::InputMethodContextEfl::~InputMethodContextEfl):
(WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
(WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
(WebKit::InputMethodContextEfl::createIMFContext):
(WebKit::InputMethodContextEfl::handleMouseUpEvent):
(WebKit::InputMethodContextEfl::handleKeyDownEvent):
(WebKit::InputMethodContextEfl::updateTextInputState):
* UIProcess/efl/InputMethodContextEfl.h: Added.
(WebKit):
(InputMethodContextEfl):
(WebKit::InputMethodContextEfl::create):
* UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::updateTextInputState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance...
tkent@chromium.org [Fri, 26 Oct 2012 09:39:21 +0000 (09:39 +0000)]
[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html fails every 3 days
https://bugs.webkit.org/show_bug.cgi?id=100480

Reviewed by Pavel Feldman.

Because the date field in the test has step=3, the availability of
[Today] button depends on the current date. We make the test stable by
specifying max attribute.

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFileReader abort case causes Chromium renderer crash
commit-queue@webkit.org [Fri, 26 Oct 2012 09:37:55 +0000 (09:37 +0000)]
FileReader abort case causes Chromium renderer crash
https://bugs.webkit.org/show_bug.cgi?id=99142

Patch by Ningxin Hu <ningxin.hu@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.

Before dispatching load event, FileReader should check if it is
in aborting.

Test: manually launch fast/files/file-reader-abort.html in Chromium
browser and compare the result with
fast/files/file-reader-abort-expected.txt.

* fileapi/FileReader.cpp:
(WebCore::FileReader::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate less repaint calls during subtree detaching
jchaffraix@webkit.org [Fri, 26 Oct 2012 09:34:07 +0000 (09:34 +0000)]
Generate less repaint calls during subtree detaching
https://bugs.webkit.org/show_bug.cgi?id=99741

Reviewed by Eric Seidel.

Source/WebCore:

Following bug 98336, detach is now a subtree top-down operation. Because we
track visual overflow from our children during layout for most cases, we can
generate a repaint only on the subtree root.

On http://dglazkov.github.com/performance-tests/redraw.html, this ups the FPS to
26 fps from 22 fps on my MBP (+ 15%). On PerformanceTests/layout/subtree-detach.html,
it decreases the time by 35%. This is due to being the best case and we now generate
only one repaint per detach phase.

Covered by existing pixels tests (including but not limited to repaint ones).

* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Changed the function not to be recursive anymore to generate one painting for
our root only. Added a FIXME about using our RenderLayer for repainting to avoid
the cost of computing our absolute repaint rectangle.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the logic for repainting in the general case. However we still force a repaint
if we have a RenderLayer as we don't track their overflow in some cases (e.g. positioned
objects). This check is conservative and could be narrowed down (e.g overflow RenderLayers
are properly accounted for in our clipppedOverflowRectForRepaint).

LayoutTests:

* platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
Rebaselined this test after the change. It is progressing as we still properly repaint
the selection, but repaint less (ie don't repaint the top border which didn't change).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Make LLInt offsets extractor work on Windows
commit-queue@webkit.org [Fri, 26 Oct 2012 09:33:48 +0000 (09:33 +0000)]
[WIN] Make LLInt offsets extractor work on Windows
https://bugs.webkit.org/show_bug.cgi?id=100369

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
it's a text mode file that needs even new line conversions. The binary mode parameter is
ignored on other platforms.

* offlineasm/offsets.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agolocal(Helvetica) in src descriptor prevent fallback
bashi@chromium.org [Fri, 26 Oct 2012 09:09:09 +0000 (09:09 +0000)]
local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446

Reviewed by Dan Bernstein.

FontCache::getCachedFontData() has a mechanism that aliases a few pairs
of font family names, so that if the family name specified in the font-family
property is not available on the system, but the its alias is available,
it will be used instead. This is appropriate for the font-family property,
but not for font family names specified in the local() function of the src
descriptor in a @font-face rule.

This patch disables the mechanism while checking src descriptor of @font-face.

No new tests. It's difficult to test the change because 'Helvetica' can
be mapped any other font. For example, chromium DRT uses FontConfig to
map Helvetica to Times New Roman. Other ports may map Helvetica to other
fonts. We can't define the expected result.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
Call fontCache()->getCachedFontData() with checkingAlternateName = true.
This disables aliasing font family names in FontCache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132589 268f45cc-cd09-0410-ab3c-d52691b4dbfc