WebKit-https.git
7 years agoAX: aria-hidden on container does not hide descendant popup buttons
cfleizach@apple.com [Sat, 16 Mar 2013 08:51:52 +0000 (08:51 +0000)]
AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373

Reviewed by Ryosuke Niwa.

Source/WebCore:

There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.

This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.

Test: accessibility/aria-hidden-hides-all-elements.html

* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isImageMapLink):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
* accessibility/AccessibilityListBox.cpp:
(WebCore):
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControlsContainer):
* accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::roleValue):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMockObject.cpp:
(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):
* accessibility/AccessibilityMockObject.h:
(AccessibilityMockObject):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
* accessibility/AccessibilitySlider.cpp:
(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
* accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):

LayoutTests:

* accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
* accessibility/aria-hidden-hides-all-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r145977.
rniwa@webkit.org [Sat, 16 Mar 2013 07:43:38 +0000 (07:43 +0000)]
Mac rebaseline after r145977.

* platform/chromium-mac/platform/mac/fast: Added.
* platform/chromium-mac/platform/mac/fast/forms: Added.
* platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
* platform/chromium/platform/mac/fast/forms: Removed.
* platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark two media/track tests as flakey. Tracked by webkit.org/b/112492
simon.fraser@apple.com [Sat, 16 Mar 2013 06:16:59 +0000 (06:16 +0000)]
Mark two media/track tests as flakey. Tracked by webkit.org/b/112492

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove result in platform/mac/platform/mac
simon.fraser@apple.com [Sat, 16 Mar 2013 05:58:15 +0000 (05:58 +0000)]
Remove result in platform/mac/platform/mac

* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in TestExpectations file.
simon.fraser@apple.com [Sat, 16 Mar 2013 05:06:41 +0000 (05:06 +0000)]
Fix typo in TestExpectations file.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReflected video elements hit assertion on Lion
simon.fraser@apple.com [Sat, 16 Mar 2013 04:56:50 +0000 (04:56 +0000)]
Reflected video elements hit assertion on Lion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable the new reflected video functionality added in r145915
on Lion because of a nasty re-entrancy problem. Tracked by bug 112490.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
commit-queue@webkit.org [Sat, 16 Mar 2013 04:40:04 +0000 (04:40 +0000)]
[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
https://bugs.webkit.org/show_bug.cgi?id=98673

Source/WebCore:

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-03-15
Reviewed by Dirk Schulze.

Enable circles and ellipses for shape-outside on floats. Most of the
code already supports them, just needed to turn them on and add tests.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html

* rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable circles and
    ellipses. Also add a check for if the RenderBox is floating, since
    that test should have been there all along, as shape outside is
    only supported on floats for now.

LayoutTests:

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-03-15
Reviewed by Dirk Schulze.

Tests for circles and ellipses on floats.

* fast/exclusions/resources/rounded-rectangle.js:
(defined): Helper function to test and see if a js value is defined.
(convertToRoundedRect): Convert a circle or ellipse dimensions to a rounded rect.
(generateShapeOutsideOnFloat): Add ability to generate circles and
    ellipses, since they are just special cases of rounded rectangles.
(generateSimulatedShapeOutsideOnFloat): Add ability to simulate
    circles and ellipses, by treating them as rounded rectangles. Also
    fix minor style issue with an if statement.
(xOutset): Remove unneeded condition in if statement.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
simon.fraser@apple.com [Sat, 16 Mar 2013 04:37:48 +0000 (04:37 +0000)]
REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
https://bugs.webkit.org/show_bug.cgi?id=112205

Disable this API test until Geoff can fix it.

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r145977.
simon.fraser@apple.com [Sat, 16 Mar 2013 03:49:13 +0000 (03:49 +0000)]
Rebaseline after r145977.

* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r145977.
simon.fraser@apple.com [Sat, 16 Mar 2013 03:47:16 +0000 (03:47 +0000)]
Rebaseline after r145977.

* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed new baselines after r145977.
kbr@google.com [Sat, 16 Mar 2013 03:25:55 +0000 (03:25 +0000)]
Unreviewed new baselines after r145977.
https://bugs.webkit.org/show_bug.cgi?id=110837

* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert old flexbox uses in html.css to new flexbox (non-<select>)
commit-queue@webkit.org [Sat, 16 Mar 2013 02:27:56 +0000 (02:27 +0000)]
Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
After we set our descendants' heights, we need to mark them for
layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox style setters.

* css/html.css:
(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(textarea):
(input[type="file"]):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
* css/themeWin.css:
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
Convert -webkit-box to -webkit-flex and adjust related properties.
Notably switch to auto margins for centering the speech button as well
as the search result and cancel buttons to stay compatible with the
previous centering behaviour. This does not produce visible
differences but eliminates the render tree dump changes.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerContainer::createRenderer):
* html/shadow/TextControlInnerElements.h:
(TextControlInnerContainer):
(WebCore):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
(WebCore):
(WebCore::RenderTextControlInnerContainer::~RenderTextControlInnerContainer):
* rendering/RenderTextControl.h:
(WebCore):
(RenderTextControlInnerContainer):
Create a new DOM element & renderer type for the textfield-decoration
div (the direct child of the <input> in the shadow dom if we have a
special input field). This is necessary because new-flexbox uses a
different algorithm for calculating the baseline, which would
otherwise cause an <input> and an <input type=search> to not be
aligned with each other.
The new renderer just calls back to RenderBlock for calculating the
baseline.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Make sure to mark renderers as needing layout when we change their
style. This didn't use to be necessary because old-flexbox relayouts
children even when they are not marked for needing layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox CSS properties.
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::decorate):
Use new-flexbox CSS properties.

LayoutTests:

* fast/forms/placeholder-position-expected.txt:
* platform/chromium-linux/fast/css/input-search-padding-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium-mac/fast/css/text-overflow-input-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/search-rtl-expected.txt:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-mac/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/css/input-search-padding-expected.txt:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium-win/fast/css/text-overflow-input-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium-win/fast/forms/search-rtl-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
* platform/chromium/fast/css/input-search-padding-expected.txt:
* platform/chromium/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/chromium/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/chromium/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium/fast/forms/search-rtl-expected.txt:
* platform/chromium/fast/forms/search-styled-expected.txt:
* platform/chromium/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium/fast/speech/speech-bidi-rendering-expected.txt:
* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/efl/fast/forms/search-rtl-expected.txt:
* platform/efl/fast/forms/search-styled-expected.txt:
* platform/efl/fast/forms/search-vertical-alignment-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/forms/validation-message-appearance-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt:
* platform/gtk/fast/repaint/search-field-cancel-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/mac/fast/css/input-search-padding-expected.txt:
* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/mac/fast/forms/search-rtl-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/repaint/search-field-cancel-expected.txt:
* platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/css/input-search-padding-expected.txt:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/forms/box-shadow-override-expected.txt:
* platform/qt/fast/forms/control-restrict-line-height-expected.txt:
* platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-rtl-expected.txt:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt:
Automated search & replace of RenderDeprecatedFlexibleBox ->
RenderFlexibleBox
* platform/mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt:
* platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png:
This test shows a minor layout difference (less spacing between
paragraphs with an <input type=color>). The underlying reason is
alignment/baseline-differences with the new flexbox code, and the new
behaviour makes more sense in general (this becomes obvious when
putting text or a <input type=text> next to an <input type=color>).
* platform/chromium/TestExpectations:
Mark input-appearance-color as needing rebaseline on Mac/Win. All
non-Chromium ports ignore fast/forms/color because the feature isn't
enabled, so their TestExpectations need no update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r188504. Requested by
commit-queue@webkit.org [Sat, 16 Mar 2013 02:22:07 +0000 (02:22 +0000)]
Unreviewed.  Rolled Chromium DEPS to r188504.  Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempted build fix for Chromium Windows after r145929.
kbr@google.com [Sat, 16 Mar 2013 02:13:47 +0000 (02:13 +0000)]
Unreviewed attempted build fix for Chromium Windows after r145929.
Verified this fix builds and works on Linux.
https://bugs.webkit.org/show_bug.cgi?id=96798

* bindings/v8/V8Binding.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded some expected results that should be the same across platforms.
simon.fraser@apple.com [Sat, 16 Mar 2013 01:22:05 +0000 (01:22 +0000)]
Added some expected results that should be the same across platforms.
Removed some tests needing rebaseline from Mac TestExpectations.

* compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
* compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge MainResourceLoader::willSendRequest into DocumentLoader
japhet@chromium.org [Sat, 16 Mar 2013 01:20:44 +0000 (01:20 +0000)]
Merge MainResourceLoader::willSendRequest into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109757

This is one of the steps to merging MainResourceLoader entirely into
DocumentLoader, given the lack of clear division of responsibility
between the two.

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::callContinueAfterNavigationPolicy):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):
* loader/MainResourceLoader.h:
(WebCore::MainResourceLoader::takeIdentifierFromResourceLoader): Temporarily
    exposed for moving from a normal load to SubstituteData load on redirect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable EXT_draw_buffers WebGL extension on Mac
zmo@google.com [Sat, 16 Mar 2013 01:11:00 +0000 (01:11 +0000)]
Disable EXT_draw_buffers WebGL extension on Mac
https://bugs.webkit.org/show_bug.cgi?id=112486

Reviewed by Kenneth Russell.

* html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::supported):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed addition of expectations for test added in r145915.
kbr@google.com [Sat, 16 Mar 2013 00:54:23 +0000 (00:54 +0000)]
Unreviewed addition of expectations for test added in r145915.

* platform/chromium-mac-lion/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
* platform/chromium-win/compositing/video/video-reflection-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove the background filter blur layout tests
danakj@chromium.org [Sat, 16 Mar 2013 00:43:24 +0000 (00:43 +0000)]
[chromium] Remove the background filter blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=112372

Reviewed by James Robinson.

Source/WebCore:

Remove the now-unused hacks to regression test the background
filter blur compositor feature.

* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Given that we now have the ability to write pixel tests directly against
the compositor, these tests are no longer needed to guard against
regressions, and have been duplicated for the compositor as pixel tests
in https://codereview.chromium.org/12518026/ and
https://codereview.chromium.org/12518026/.

* platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
* platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
* platform/chromium/compositing/filters/background-filter-blur.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark fast/frames/sandboxed-iframe-scripting as flakey.
simon.fraser@apple.com [Sat, 16 Mar 2013 00:37:35 +0000 (00:37 +0000)]
Mark fast/frames/sandboxed-iframe-scripting as flakey.

webkit.org/b/104848 supposedly fixed fast/frames/sandboxed-iframe-parsing-space-characters.html,
so remove it.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related...
anilsson@rim.com [Sat, 16 Mar 2013 00:36:12 +0000 (00:36 +0000)]
[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
https://bugs.webkit.org/show_bug.cgi?id=112467

Reviewed by Rob Buis.

PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Mike Lattanzio
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Filip Spacek

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::tileSize):
* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
* Api/WebOverlay.h:
* Api/WebOverlayClient.h:
* Api/WebOverlay_p.h:
(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
(WebOverlayPrivateCompositingThread):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::paintBackground):
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
* WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
* WebKitSupport/SurfacePool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct...
jochen@chromium.org [Sat, 16 Mar 2013 00:20:08 +0000 (00:20 +0000)]
plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=112478

Reviewed by Tony Chang.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):

LayoutTests:

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
* plugins/netscape-plugin-setwindow-size-2.html:
* plugins/netscape-plugin-setwindow-size.html:
* plugins/pass-different-npp-struct.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark some more sputnik tests as slow in debug.
simon.fraser@apple.com [Fri, 15 Mar 2013 23:52:18 +0000 (23:52 +0000)]
Mark some more sputnik tests as slow in debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Reduce amount of platform specific code in MessagePortChannel
ap@apple.com [Fri, 15 Mar 2013 23:40:32 +0000 (23:40 +0000)]
    Reduce amount of platform specific code in MessagePortChannel
        https://bugs.webkit.org/show_bug.cgi?id=112469

        Reviewed by Sam Weinig.

        * dom/MessagePortChannel.h: Ifdefed out an unused channel() function, except for
        Chromium, where it is used. We certainly don't want to expose this implementation
        detail as a public function.

        * dom/default/PlatformMessagePortChannel.h: Removed functions that are no longer
        delegated. Made class contents all public, as it's now basically a data storage
        for MessagePortChannel.

        * dom/default/PlatformMessagePortChannel.cpp:
        (WebCore::MessagePortChannel::createChannel):
        (WebCore::MessagePortChannel::~MessagePortChannel):
        (WebCore::MessagePortChannel::entangleIfOpen):
        (WebCore::MessagePortChannel::disentangle):
        (WebCore::MessagePortChannel::postMessageToRemote):
        (WebCore::MessagePortChannel::tryGetMessageFromRemote):
        (WebCore::MessagePortChannel::close):
        (WebCore::MessagePortChannel::isConnectedTo):
        (WebCore::MessagePortChannel::hasPendingActivity):
        (WebCore::MessagePortChannel::locallyEntangledPort):
        (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
        (WebCore::PlatformMessagePortChannel::entangledChannel):
        Moved code from PlatformMessagePortChannel to MessagePortChannel. Added some
        FIXMEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew baseline for this test on Lion.
simon.fraser@apple.com [Fri, 15 Mar 2013 23:36:00 +0000 (23:36 +0000)]
New baseline for this test on Lion.

* platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable suppressesIncrementalRendering for the Web Inspector.
timothy@apple.com [Fri, 15 Mar 2013 23:30:13 +0000 (23:30 +0000)]
Disable suppressesIncrementalRendering for the Web Inspector.

This ends up causing the Inspector to show blank for a couple seconds before
it does its first paint. During that time the bare window chrome is showing
when the Inspector's background and other simple elements count be painting.
This causes the Inspector to look like it is loading slower than reality.

Source/WebKit/mac:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering.

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Disable suppressesIncrementalRendering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
anilsson@rim.com [Fri, 15 Mar 2013 23:30:03 +0000 (23:30 +0000)]
[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
https://bugs.webkit.org/show_bug.cgi?id=112255

Reviewed by Rob Buis.

PR 308284.
Reviewed internally by Yongxin Dai.

Source/WebCore:

Add a getter for the layer renderer of a compositing thread layer.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::layerRenderer):

Source/WebKit/blackberry:

The cached draw rectangle is useful for hit testing. Add a getter for
this compositing thread layer property to the public WebOverlay API.
We name this getter using terminology familiar from the
ViewportAccessor interface, to clarify which coordinate system the
getter uses (pixel coordinates relative to the viewport).

Note that WebKit-thread flavor of WebOverlay is not currently used by
any API client and is marked obsolete. It is used internally in WebKit,
but for that case using GraphicsLayer directly works well. This will
allow the complexity of WebOverlay to be significantly reduced in the
future, by removing the WebKit-thread flavor entirely.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlay::pixelViewportRect):
(WebKit):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
* Api/WebOverlay.h:
(WebKit):
* Api/WebOverlay_p.h:
(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelay creating the Inspector window so we don't cause a CoreIPC deadlock.
timothy@apple.com [Fri, 15 Mar 2013 23:29:58 +0000 (23:29 +0000)]
Delay creating the Inspector window so we don't cause a CoreIPC deadlock.

Other changes include:
* Create the Inspector WKView at the correct size so it does not need to
  resize later when added to the window.
* Update the minimum and initial window sizes to better match the new UI.
* Store the Inspector window frame in WebKit preferences so each page group
  can have different saved window frames. Handy for inspecting the Inspector.

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

* Shared/WebPreferencesStore.cpp:
(WebKit::defaultValueForKey):
Added FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE.

* Shared/WebPreferencesStore.h:
(FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE):
Added. Needed to keep WebPage::updatePreferences for trying to set WebCore::Settings.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::minimumWindowWidth):
(WebKit::WebInspectorProxy::initialWindowWidth):
Bumped the values to work better with the new UI.

* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::windowFrameDidChange):
Added.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter windowDidMove:]):
(-[WKWebInspectorProxyObjCAdapter windowDidResize:]):
Call WebInspectorProxy::windowFrameDidChange.

(WebKit::WebInspectorProxy::createInspectorWindow):
Use the preferences for the page group to get the window frame.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Stop calling platformAttach or createInspectorWindow, do it in platformOpen.

(WebKit::WebInspectorProxy::platformOpen):
Call platformAttach or createInspectorWindow here instead.

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added. Store the frame in the page group's preferences.

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
Remove code that called setHidden:. We don't need to do that anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert <select> to new-flexbox
commit-queue@webkit.org [Fri, 15 Mar 2013 23:14:55 +0000 (23:14 +0000)]
Convert <select> to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112395

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Covered by existing tests.

* css/html.css:
(select):
(select[size][multiple]):
(select[size="1"]):
Use new-style flexbox properties.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::createInnerBlock):
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::removeChild):
RenderDeprecatedFlexibleBox -> RenderFlexibleBox, and use the
new-style flexbox properties. Use margin:auto for centering to get
the old safe-centering behavior.
* rendering/RenderMenuList.h:
(RenderMenuList):
Inherit from RenderFlexibleBox. Override baseline methods to call the
RenderBlock methods

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPl...
aestes@apple.com [Fri, 15 Mar 2013 23:11:20 +0000 (23:11 +0000)]
REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=112474

Reviewed by Simon Fraser.

Transfer ownership of m_cfData to the local variable rather than leaking a reference.

* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::maybeTransferPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Focus Plugin on TouchStart
fsamuel@chromium.org [Fri, 15 Mar 2013 23:01:22 +0000 (23:01 +0000)]
[Chromium] Focus Plugin on TouchStart
https://bugs.webkit.org/show_bug.cgi?id=112385

Reviewed by Adam Barth.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleMouseEvent):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew context extensions restored improperly
commit-queue@webkit.org [Fri, 15 Mar 2013 22:54:25 +0000 (22:54 +0000)]
New context extensions restored improperly
https://bugs.webkit.org/show_bug.cgi?id=112156

Patch by Rajeev Sarvaria <rsarvaria@blackberry.com> on 2013-03-15
Reviewed by Rob Buis.

Sets up extensions after new context is created for restoration.
Previous extensions set up is lost when context is initially lost.

Cannot create a test as change is not visible from the web. When a context
is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
object is created without available extensions initialized. Calling isEnabled
within setupFlags leads to the eventual initialization of extensions for the
new context.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextIterator emits LF for a br element inside an empty input element
commit-queue@webkit.org [Fri, 15 Mar 2013 22:22:23 +0000 (22:22 +0000)]
TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html
      editing/text-iterator/basic-iteration-shadowdom.html

* editing/TextIterator.cpp:
(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):
* editing/TextIterator.h:
(SimplifiedBackwardsTextIterator):

LayoutTests:

* editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
* editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
* editing/text-iterator/basic-iteration-shadowdom.html: Added.
* editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Allow an embedder to position child windows using window coordinates
anilsson@rim.com [Fri, 15 Mar 2013 22:19:49 +0000 (22:19 +0000)]
[BlackBerry] Allow an embedder to position child windows using window coordinates
https://bugs.webkit.org/show_bug.cgi?id=112236

Reviewed by Rob Buis.

PR 232752

Source/WebCore:

The LayerCompositingThread can now position the video window using
either document or window coordinates.

The LayerRenderer class gets a new client interface. This allows us to
avoid state duplication by delegating decisions directly to the client,
which can then be in charge of the (one and only) state.

The context is moved over to the client, as well as delegation of the
decision on whether to clear the surface every frame.

Also, the decision on which coordinate system to use for positioning
child windows is delegated to the client interface.

No new tests, not testable using DRT.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::makeContextCurrent):
* platform/graphics/blackberry/LayerRenderer.h:
(WebCore):
(LayerRenderer):
(WebCore::LayerRenderer::client):
* platform/graphics/blackberry/LayerRendererClient.h: Added.
(Graphics):
(WebCore):
(LayerRendererClient):
(WebCore::LayerRendererClient::~LayerRendererClient):

Source/WebKit/blackberry:

Child windows used to always be positioned in document coordinates,
which requires the
BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
window to be kept in sync with the document visible content rect.
This is easy if there's a one-to-one correspondence between windows
and scrollable frames.

However, for an embedder that can display an entire scene graph (where
the web page is just one of the nodes) in one window, several
scrollable nodes may be present in that window, and it's difficult to
know which scrollable node to sync the virtualRect with. It could also
lead to conflicts, if two scrollable nodes have child windows.

For the latter scenario, it makes more sense to use window coordinates
to place child windows.

The internal default is to use document coordinates, for legacy
reasons.

When an external WebPageCompositor is attached, we switch to using
window coordinates instead of document coordinates by default. The
behavior is still configurable using the new public
setChildWindowPlacement method.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):
* Api/WebPageCompositor.h:
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enforce the C++11 standard when compiling WebKit2
zandobersek@gmail.com [Fri, 15 Mar 2013 22:12:56 +0000 (22:12 +0000)]
[GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): Ditto.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::inspectorFilesBasePath): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs
benjamin@webkit.org [Fri, 15 Mar 2013 22:09:25 +0000 (22:09 +0000)]
[iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112400

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Michael Saboff.

* wtf/text/StringImpl.h:
(WTF::equal):
Tweak the code to make it work on older Apple CPUs:
-Use external "ouput" variable instead of the registers R9 and R12. This gets rid
 of some register pressure previously imposed on the compiler. (Clang nicely
 choose R9 and R12 when needed, following iOS ABI).
-Instead of using "R3" for storing the length / 4, update the length by -4 on
 each iteration and work in the negative space for the tail. This frees one register
 which is then used for isEqual.
-Get rid of the unconditional branch from the loop. By using subs and working in the
 negative space, we can test for the Carry flag to jump back to the next LDR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHave the mac port support per_test_timeout in webkitpy
simon.fraser@apple.com [Fri, 15 Mar 2013 22:05:36 +0000 (22:05 +0000)]
Have the mac port support per_test_timeout in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112466

Reviewed by Dirk Pranke.

Both WTR and DRT handle --timeout arguments, so we can
have the scripts pass the timeout values down to the tools.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.supports_per_test_timeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't also clone StructureRareData when cloning Structure.
akling@apple.com [Fri, 15 Mar 2013 21:57:55 +0000 (21:57 +0000)]
Don't also clone StructureRareData when cloning Structure.
<http://webkit.org/b/111672>

Reviewed by Mark Hahnenberg.

We were cloning a lot of StructureRareData with only the previousID pointer set since
the enumerationCache is not shared between clones.

Let the Structure copy constructor decide whether it wants to clone the rare data.
The decision is made by StructureRareData::needsCloning() and will currently always
return false, since StructureRareData only holds on to caches at present.
This may change in the future as more members are added to StructureRareData.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::cloneRareDataFrom):
* runtime/StructureInlines.h:
(JSC::Structure::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 15 Mar 2013 21:55:27 +0000 (21:55 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for IDB tests that regressed with r145929.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll out r145838
mhahnenberg@apple.com [Fri, 15 Mar 2013 21:52:35 +0000 (21:52 +0000)]
Roll out r145838
https://bugs.webkit.org/show_bug.cgi?id=112458

Unreviewed. Requested by Filip Pizlo.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* dfg/DFGOperations.cpp:
* interpreter/CallFrame.h:
(JSC::ExecState::objectPrototypeTable):
* jit/JITStubs.cpp:
(JSC::getByVal):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
* runtime/CommonIdentifiers.h:
* runtime/JSCell.cpp:
(JSC):
* runtime/JSCell.h:
(JSCell):
* runtime/JSCellInlines.h:
(JSC):
(JSC::JSCell::fastGetOwnProperty):
* runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSObject.cpp:
(JSC):
* runtime/JSObject.h:
(JSObject):
(JSC):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/ObjectPrototype.cpp:
(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
(ObjectPrototype):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::findWithString):
* runtime/Structure.h:
(Structure):
* runtime/StructureInlines.h:
(JSC::Structure::get):

LayoutTests:

* fast/js/regress/script-tests/string-lookup-hit-identifier.js: Removed.
* fast/js/regress/script-tests/string-lookup-hit.js: Removed.
* fast/js/regress/script-tests/string-lookup-miss.js: Removed.
* fast/js/regress/string-lookup-hit-expected.txt: Removed.
* fast/js/regress/string-lookup-hit-identifier-expected.txt: Removed.
* fast/js/regress/string-lookup-hit-identifier.html: Removed.
* fast/js/regress/string-lookup-hit.html: Removed.
* fast/js/regress/string-lookup-miss-expected.txt: Removed.
* fast/js/regress/string-lookup-miss.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose whether a UserGestureToken still has gestures via WebKit API
jochen@chromium.org [Fri, 15 Mar 2013 21:52:19 +0000 (21:52 +0000)]
Expose whether a UserGestureToken still has gestures via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112342

Reviewed by Adam Barth.

Source/WebCore:

* dom/UserGestureIndicator.cpp:
* dom/UserGestureIndicator.h:
(UserGestureToken):

Source/WebKit/chromium:

* public/WebUserGestureToken.h:
(WebUserGestureToken):
* src/WebUserGestureToken.cpp:
(WebKit::WebUserGestureToken::hasGestures):
(WebKit):
* tests/WebUserGestureTokenTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert inspector to new-flexbox
commit-queue@webkit.org [Fri, 15 Mar 2013 21:50:42 +0000 (21:50 +0000)]
Convert inspector to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112399

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

No new tests, refactoring.

* inspector/front-end/auditsPanel.css:
(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.audit-launcher-view div.button-container > button):
* inspector/front-end/dialog.css:
(.dialog):
* inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite .metrics):
* inspector/front-end/helpScreen.css:
(.help-window-main):
(.help-content):
* inspector/front-end/inspector.css:
(#toolbar):
(#toolbar-controls):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(.toolbar-item.close-left, .toolbar-item.close-right):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-pie-chart-container):
(.memory-pie-chart):
* inspector/front-end/networkPanel.css:
(.network-item-view.visible):
* inspector/front-end/panelEnablerView.css:
(.panel-enabler-view .flexible-space):
* inspector/front-end/profilesPanel.css:
(.profile-launcher-view-content):
(.control-profiling):
* inspector/front-end/splitView.css:
(.sidebar-overlay):
* inspector/front-end/tabbedPane.css:
(.tabbed-pane):
(.tabbed-pane-content):
Replace -webkit-box with -webkit-flex, -webkit-box-orient with
-webkit-flex-direction, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Remove unused unified textchecker variable
commit-queue@webkit.org [Fri, 15 Mar 2013 21:28:38 +0000 (21:28 +0000)]
Source/WebCore: Remove unused unified textchecker variable
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

The variable m_originalUnifiedSpellCheckerEnabled is never used. The generated
code from Settings.in already backs up and restores unified textchecker setting.

* testing/InternalSettings.h: Remove unusued m_originalUnifiedSpellCheckerEnabled variable.

Tools: Remove setAsynchronousSpellCheckingEnabled from test runners
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
in internals.settings, so all ports can share it.

* DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
* DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.

LayoutTests: Move setAsynchronousSpellCheckingEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Changed the tests from using testRunner.setAsynchronousSpellCheckingEnabled(bool)
with port-specific implementations to use internals.settings.setAsynchronousSpellCheckingEnabled(bool)
with one common implementation, similar to internals.settings.setUnifiedTextCheckerEnabled(bool).
Changed the tests to not reset these settings when they finish, because the test harness resets
the settings automatically.

* editing/spelling/grammar-markers-hidpi.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/grammar-markers.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/grammar-paste.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/resources/util.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/script-tests/spellcheck-paste.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-async-mutation.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-async-remove-frame.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-async.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-paste-disabled.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-queue.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spellcheck-sequencenum.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* editing/spelling/spelling-marker-description.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* platform/chromium/editing/spelling/delete-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
* platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAuto height column flexboxes with border and padding are too short
ojan@chromium.org [Fri, 15 Mar 2013 21:13:46 +0000 (21:13 +0000)]
Auto height column flexboxes with border and padding are too short
https://bugs.webkit.org/show_bug.cgi?id=112398

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/auto-height-column-with-border-and-padding.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
computeLogicalHeight expects that you pass in the border-box logicalHeight, not
the contentLogicalHeight. Since we subtract the border, padding and scrollbar height from
the returned m_extent, if we pass in the contentLogicalHeight and the flexbox is auto-sized
then we end up incorrectly subtracting border, padding and scrollbar height from the
contentLogicalHeight.

LayoutTests:

* css3/flexbox/auto-height-column-with-border-and-padding-expected.html: Added.
* css3/flexbox/auto-height-column-with-border-and-padding.html: Added.
* css3/flexbox/resources/flexbox.css:
(.flex-one-one-auto):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fix. Also gather translatable strings from WebKit2 files.
kov@webkit.org [Fri, 15 Mar 2013 21:06:25 +0000 (21:06 +0000)]
Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

* POTFILES.in: added WebKit2GTK+ files that have translatable strings.
* ar.po: regenerated.
* as.po: ditto.
* bg.po: ditto.
* cs.po: ditto.
* de.po: ditto.
* el.po: ditto.
* en_CA.po: ditto.
* en_GB.po: ditto.
* eo.po: ditto.
* es.po: ditto.
* et.po: ditto.
* eu.po: ditto.
* fr.po: ditto.
* gl.po: ditto.
* gu.po: ditto.
* he.po: ditto.
* hi.po: ditto.
* hu.po: ditto.
* id.po: ditto.
* it.po: ditto.
* ko.po: ditto.
* lt.po: ditto.
* lv.po: ditto.
* mr.po: ditto.
* nb.po: ditto.
* nl.po: ditto.
* pa.po: ditto.
* pl.po: ditto.
* pt.po: ditto.
* pt_BR.po: ditto.
* ro.po: ditto.
* ru.po: ditto.
* sl.po: ditto.
* sr.po: ditto.
* sr@latin.po: ditto.
* sv.po: ditto.
* uk.po: ditto.
* vi.po: ditto.
* zh_CN.po: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] Fix the length pass to memcmp in the fallback versions of String's equal
benjamin@webkit.org [Fri, 15 Mar 2013 20:34:52 +0000 (20:34 +0000)]
[iOS] Fix the length pass to memcmp in the fallback versions of String's equal
https://bugs.webkit.org/show_bug.cgi?id=112463

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Ryosuke Niwa.

* wtf/text/StringImpl.h:
(WTF::equal): It might be a good idea to compare the full UChar strings...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderSnapshottedPlugIn can't be a RenderBlock (what if it's display: inline?)
timothy_horton@apple.com [Fri, 15 Mar 2013 20:33:50 +0000 (20:33 +0000)]
RenderSnapshottedPlugIn can't be a RenderBlock (what if it's display: inline?)
https://bugs.webkit.org/show_bug.cgi?id=112432
<rdar://problem/13187211>

Reviewed by Simon Fraser and Dean Jackson.

Re-use code from PLUGIN_PROXY_FOR_VIDEO to allow RenderEmbeddedObject to lay out its children,
and make RenderSnapshottedPlugIn a RenderEmbeddedObject subclass once again. This will ensure that
RenderSnapshottedPlugIn lays itself out in the page the same as the RenderEmbeddedObject it replaces did,
preventing snapshotted plug-ins from breaking the layout when they are display: inline.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
RenderSnapshottedPlugIn is a RenderEmbeddedObject subclass again, so we need to check
for it when we have a RenderEmbeddedObject, instead of when we don't.

* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
Ditto.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::canHaveChildren):
Allow RenderEmbeddedObject to have and lay out children if it is a RenderSnapshottedPlugIn.
Also, preserve the code that allows children if it is a media element and PLUGIN_PROXY_FOR_VIDEO is enabled.
Don't call addWidgetToUpdate for instances which will never have a widget, like RenderSnapshottedPlugIn.

* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):
We need canHaveChildren() and children() and m_children now.
Add canHaveWidget(), which returns true. Subclasses can override if need be.

* rendering/RenderSnapshottedPlugIn.h: Add canHaveWidget(), which is false for RenderSnapshottedPlugIn.
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::layout):
(WebCore::RenderSnapshottedPlugIn::getCursor):
Make RenderSnapshottedPlugIn a RenderEmbeddedObject.

(WebCore::RenderSnapshottedPlugIn::paint):
Paint our children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup of DFG and Baseline JIT debugging code
msaboff@apple.com [Fri, 15 Mar 2013 20:24:39 +0000 (20:24 +0000)]
Cleanup of DFG and Baseline JIT debugging code
https://bugs.webkit.org/show_bug.cgi?id=111871

Reviewed by Geoffrey Garen.

Fixed various debug related issue in baseline and DFG JITs. See below.

* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.
* dfg/DFGScratchRegisterAllocator.h: Now use ScratchBuffer::activeLengthPtr() to get
pointer to scratch register length.
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkConsistency): Added missing case labels for DataFormatOSRMarker,
DataFormatDead, and DataFormatArguments and made them RELEASE_ASSERT_NOT_REACHED();
* jit/JITCall.cpp:
(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.
* jit/JITCall32_64.cpp:
(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.
* runtime/JSGlobalData.h:
(JSC::ScratchBuffer::ScratchBuffer): Fixed buffer allocation alignment to
be on a double boundary.
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Custom Elements] Any HTMLElement subclass should become a superclass of custom element
morrita@google.com [Fri, 15 Mar 2013 20:12:15 +0000 (20:12 +0000)]
[Custom Elements] Any HTMLElement subclass should become a superclass of custom element
https://bugs.webkit.org/show_bug.cgi?id=110436

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change introduces "type extension" concept of custom elements.
With the type extension, each custom elements are able to inherit
from not only HTMLElement, but also any HTML element. To make it work,
this change extends the plumbing.

This change does following changes:

= Data structure:

- Let CustomElementConstructor objects being keyed by pair of (element
  name, local name) as the standard requries, instead of just using
  single name. See CustomElementRegistry::ConstructorMap and CustomElementRegistry::find().

- Creates mapping from WrapperTypeInfo to element name.  This map
  can be looked-up by generated functions like
  findHTMLTagNameOfV8Type().  With this table, WebKit can determine
  the custom element local name of given prototype object. See  make_names.pl.
  Note that V8 prototype object knows associated WrapperTypeInfo. See r144865.

= Hooking up element lifecyle:

- Create appropriate C++ instance for each custom element.  Before
  this change, the C++ backend of custom elements were always
  HTMLUnknownElements or HTMLElement.  See
  CustomElementConstructor::createElement() and ElementFactories in
  make_names.pl.

- Hooks up element construction and element wrapper creation for
  custom element "before" non-custom case instead of "after"
  that. We do this because custom element needs to
  override non-custom case when @is attribute is given for
  otherwise-non-custom elements like <div is=x-bar>.
  See make_names.pl.

- Gives @is attributes to elements if needed. See setTypeExtension() call sites
  like Document::createElement(), Document::createElementtNS() and CustomElementConstructor::createElementt()

Test: fast/dom/custom/document-register-type-extensions.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
* bindings/scripts/test/V8/V8TestEventConstructor.h:
* bindings/scripts/test/V8/V8TestEventTarget.h:
* bindings/scripts/test/V8/V8TestException.h:
* bindings/scripts/test/V8/V8TestInterface.h:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
* bindings/scripts/test/V8/V8TestNode.h:
* bindings/scripts/test/V8/V8TestObj.h:
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
* bindings/scripts/test/V8/V8TestTypedefs.h:
* bindings/v8/CustomElementHelpers.cpp:
(WebCore::hasValidPrototypeChain):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::findLocalName):
(WebCore):
(WebCore::CustomElementHelpers::findWrapperType):
* bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
* bindings/v8/V8CustomElement.cpp:
(WebCore::V8CustomElement::createWrapper):
* bindings/v8/V8CustomElement.h:
(V8CustomElement):
(WebCore::V8CustomElement::wrap):
(WebCore::V8CustomElement::constructorOf):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeTraits): Added.
* bindings/v8/custom/V8CustomElementConstructorCustom.cpp:
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
* dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
(WebCore::setTypeExtension):
* dom/CustomElementConstructor.h:
(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::typeName):
(WebCore::CustomElementConstructor::localName):
* dom/CustomElementRegistry.cpp:
(WebCore::nameIncludesHyphen):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::findFor):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):
* dom/CustomElementRegistry.h:
(CustomElementRegistry):
* dom/Document.cpp:
(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):
* dom/Document.h:
(Document):
(WebCore::Document::registry): Moved from Document.cpp to be inlined.
* dom/Document.idl:
* dom/make_names.pl:
(printFactoryCppFile):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
* html/HTMLAttributeNames.in: Added @is attribute

LayoutTests:

* fast/dom/custom/document-register-basic-expected.txt:
* fast/dom/custom/document-register-basic.html:
* fast/dom/custom/document-register-type-extensions-expected.txt: Added.
* fast/dom/custom/document-register-type-extensions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd runtime check for improper register allocations in DFG
msaboff@apple.com [Fri, 15 Mar 2013 19:33:25 +0000 (19:33 +0000)]
Add runtime check for improper register allocations in DFG
https://bugs.webkit.org/show_bug.cgi?id=112380

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added framework to check for register allocation within a branch source - target range.  All register allocations
are saved using the offset in the code stream where the allocation occurred.  Later when a jump is linked, the
currently saved register allocations are checked to make sure that they didn't occur in the range of code that was
jumped over.  This protects against the case where an allocation could have spilled register contents to free up
a register and that spill only occurs on one path of a many through the code.  A subsequent fill of the spilled
register may load garbage.  See https://bugs.webkit.org/show_bug.cgi?id=111777 for one such bug.
This code is protected by the compile time check of #if ENABLE(DFG_REGISTER_ALLOCATION_VALIDATION).
The check is only done during the processing of SpeculativeJIT::compile(Node* node) and its callees.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link): Invoke register allocation checks using source and target of link.
(JSC::AbstractMacroAssembler::Jump::linkTo): Invoke register allocation checks using source and target of link.
(AbstractMacroAssembler):
(RegisterAllocationOffset): New helper class to store the instruction stream offset and compare against a
jump range.
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::RegisterAllocationOffset):
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::check):
(JSC::AbstractMacroAssembler::addRegisterAllocationAtOffset):
(JSC::AbstractMacroAssembler::clearRegisterAllocationOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::allocate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Source/WTF:

* wtf/Platform.h: Added new ENABLE_DFG_REGISTER_ALLOCATION_VALIDATION compilation flag to
enable generation of register allocation checking.  This is on for debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Minor cleanup in worker code
ap@apple.com [Fri, 15 Mar 2013 19:03:39 +0000 (19:03 +0000)]
    Minor cleanup in worker code
        https://bugs.webkit.org/show_bug.cgi?id=112455

        Reviewed by Anders Carlsson.

        - Added OVERRIDE keywords.
        - Toned down FIXMEs about single MessagePort versions of functions. It's not a given
        that we'll want to get rid of them even when implementing array versions.
        - Explicitly marked virtual destructors as virtual.

        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * workers/Worker.cpp:
        * workers/Worker.h:
        Removed an unused version of postMessage() that took no MessagePorts. This makes
        it less confusing why MessagePortArray is passed by pointer, and not by reference.

        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
        * workers/DedicatedWorkerContext.h:
        Added a destructor instead of an implicit one.
        Removed an unused version of postMessage() that took no MessagePorts.

        * workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)

        * dom/MessagePort.cpp:
        * dom/MessagePort.h:
        * loader/WorkerThreadableLoader.h:
        * page/DOMWindow.h:
        * workers/AbstractWorker.h:
        * workers/DedicatedWorkerThread.h:
        * workers/SharedWorkerContext.h:
        * workers/SharedWorkerThread.h:
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerObjectProxy.h:
        * workers/WorkerScriptLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
jsbell@chromium.org [Fri, 15 Mar 2013 18:58:05 +0000 (18:58 +0000)]
[V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
https://bugs.webkit.org/show_bug.cgi?id=96798

Reviewed by Kentaro Hara.

Source/WebCore:

Implement [EnforceRange] attribute for V8 bindings, which specifies throwing behavior
on conversions outside int/uint 32/64 ranges and edge cases like NaNs and Infinities.
Conversely, conversions without this attribute should *not* throw.

Tests: fast/js/webidl-type-mapping.html:
       fast/dom/non-numeric-values-numeric-parameters.html
       fast/js/script-tests/select-options-add.html
       storage/indexeddb/intversion-bad-parameters.html

* Modules/indexeddb/IDBCursor.cpp: Remove custom range enforcement for advance()
* Modules/indexeddb/IDBCursor.h: Adjust type to match WebIDL.
* Modules/indexeddb/IDBCursor.idl: Specify [EnforceRange] and type matches spec WebIDL.
* Modules/indexeddb/IDBFactory.cpp: Remove custom range enforcement for open()
* Modules/indexeddb/IDBFactory.h: Adjust type to match WebIDL.
* Modules/indexeddb/IDBFactory.idl: Specify [EnforceRange] and type matches spec WebIDL.
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative): Add FIXME to support [EnforceRange]
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter): Handle [EnforceRange] in attribute setters
(GenerateParametersCheck): Handle [EnforceRange] in parameters.
(JSValueToNative): Pass EnforceRange to toInt() functions as appropriate.
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestObj.idl: Tests w/ [EnforceRange]
* bindings/scripts/test/V8/V8TestObj.cpp: Updated expectations
* bindings/scripts/test/V8/V8TestTypedefs.cpp: Updated expectations.
* bindings/v8/V8Binding.cpp: Overloads for toInt() variants that handle constraints.
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):
* bindings/v8/V8Binding.h: Ditto, plus helpers for callers not expecting errors.
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):
* bindings/v8/V8BindingMacros.h: Helper macros for type conversions that may throw.
* testing/TypeConversions.h: Added new members with EnforceRange constraint.
* testing/TypeConversions.idl: Ditto.

LayoutTests:

Some of the tests for HTMLOptionsCollection.add() assumed it should throw for
Infinities and NaNs, but this is not what the DOM+WebIDL specs say. (Firefox doesn't throw
so this does not appear to be a web-compat issue.) This updates the tests/expectations so
that V8 passes. JSC expectations are FAIL in a few places since it still incorrectly throws
on Infinity/NaN -> int32 conversion (existing tests) and does not implement EnforceRange
(new tests).

Tne non-numeric-values-numeric-parameters test was also broken for NaN testing, reporting
incorrect results which hid some of this behavior.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt: Failing behavior for JSC.
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js: HTMLOptionsCollection.add()
should not throw on NaNs/Infinities.
* fast/js/script-tests/select-options-add.js: Ditto.
* fast/js/select-options-add-expected.txt: Failing behavior for JSC.
* fast/js/webidl-type-mapping-expected.txt: Ditto.
* fast/js/webidl-type-mapping.html: Added test cases for [EnforceRange]
* platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added - passing behavior for V8.
* platform/chromium/fast/js/select-options-add-expected.txt: Ditto.
* platform/chromium/fast/js/webidl-type-mapping-expected.txt: Added.
* storage/indexeddb/intversion-bad-parameters-expected.txt: Added non-finite test cases.
* storage/indexeddb/resources/intversion-bad-parameters.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarking sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.8_Arguments_O...
simon.fraser@apple.com [Fri, 15 Mar 2013 18:52:27 +0000 (18:52 +0000)]
Marking sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.8_Arguments_Object/S10.1.8_A3_T2.html
as a Slow test.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] Refine JSDocs in NetworkRequest.js
eustas@chromium.org [Fri, 15 Mar 2013 18:47:18 +0000 (18:47 +0000)]
Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
https://bugs.webkit.org/show_bug.cgi?id=112412

Reviewed by Vsevolod Vlasov.

Return types for some members are confusing (Object).

* inspector/front-end/NetworkManager.js: Fixed JSDocs.
* inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the stupid unit tests.
simon.fraser@apple.com [Fri, 15 Mar 2013 18:43:51 +0000 (18:43 +0000)]
Fix the stupid unit tests.

* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_sample_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
aestes@apple.com [Fri, 15 Mar 2013 18:26:18 +0000 (18:26 +0000)]
REGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
https://bugs.webkit.org/show_bug.cgi?id=112436

Reviewed by Michael Saboff.

Source/WebCore:

r127277 modified the CSS parser to use 8-bit strings when possible.
However, it failed to handle URIs that contain Unicode escape sequences
that expand to multi-byte characters. Not only would the URI fail to
parse, but so would the remainder of the input string.

Fix this by producing a 16-bit result when we detect a URI with a
multi-byte Unicode escape, like we do for identifiers and other strings.

Test: fast/css/url-with-multi-byte-unicode-escape.html

* css/CSSParser.cpp:
(WebCore::checkAndSkipString): Changed to be a free function since it
doesn't access CSSParser's internal state.
(WebCore::CSSParser::findURI): Added a function that consolidates the
logic of finding the start and end pointers of the URI and the quote
character (if encountered), starting at the current character.
(WebCore::CSSParser::parseURIInternal): Removed duplicated logic for
finding the URI bounds (this now lives in findURI()) and logic for
setting the token type and updating the current character (this now
lives in parseURI()).
(WebCore::CSSParser::parseURI): Find the URI and parse it. If a
multi-byte Unicode escape is encountered, rewind to the beginning of
the URI and re-parse with a 16-bit string as the destination.
* css/CSSParser.h:

LayoutTests:

* fast/css/url-with-multi-byte-unicode-escape-expected.txt: Added.
* fast/css/url-with-multi-byte-unicode-escape.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r188418. Requested by
commit-queue@webkit.org [Fri, 15 Mar 2013 18:16:54 +0000 (18:16 +0000)]
Unreviewed.  Rolled Chromium DEPS to r188418.  Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Remove custom WebAudio mark functions that we can generate instead.
akling@apple.com [Fri, 15 Mar 2013 18:10:30 +0000 (18:10 +0000)]
[JSC] Remove custom WebAudio mark functions that we can generate instead.
<http://webkit.org/b/110976>

Reviewed by Eric Carlson.

Remove custom JSC mark functions for AudioContext and ScriptProcessorNode since they
are trivial to generate.

* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/ScriptProcessorNode.idl:
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioContextCustom.cpp:
* bindings/js/JSScriptProcessorNodeCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix. Rename local variable which was colliding with class method.
jer.noble@apple.com [Fri, 15 Mar 2013 18:03:42 +0000 (18:03 +0000)]
Unreviewed build fix. Rename local variable which was colliding with class method.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Handle success events arriving after context stopped
jsbell@chromium.org [Fri, 15 Mar 2013 18:00:03 +0000 (18:00 +0000)]
IndexedDB: Handle success events arriving after context stopped
https://bugs.webkit.org/show_bug.cgi?id=112451

Reviewed by Tony Chang.

Source/WebCore:

In multiprocess ports, events from the back-end can arrive in the form of
onXXX() calls after the script execution context has stopped. These need to
be ignored. This was already done in most cases, but missing for two overloads
of IDBRequest::onSuccess() - void and int64_t.

Test: webkit_unit_test IDBRequestTest.EventsAfterStopping

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess): Early return if context has stopped.
(WebCore::IDBRequest::onSuccessInternal): ASSERT() that callers have checked context.

Source/WebKit/chromium:

* tests/IDBRequestTest.cpp:
(WebKit::TEST_F): Add cases for onSuccess() and onSuccess(int64_t)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCollect samples for unresponsive web processes
simon.fraser@apple.com [Fri, 15 Mar 2013 17:59:44 +0000 (17:59 +0000)]
Collect samples for unresponsive web processes
https://bugs.webkit.org/show_bug.cgi?id=112409

Tools:

Reviewed by Tim Horton.

When we detect that a subprocess was unresponsive, run the 'sample'
tool on that process, for the Mac port.

The sample will be linked to from the results.html page, next
to the crash log link.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._look_for_new_crash_logs): Before looking for crash logs,
look for samples on disk.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter):
(TestResultWriter.copy_sample_file): Teach TestResultWriter about
-sample.txt files, and have it copy their contents to a new file
next to the test that spawned them (as we do for crash logs).
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.look_for_new_samples): Base class does nothing for sampling.
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver._check_for_driver_crash): Kick off a sample if we detected
that the subprocess was unresponsive.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.sample_file_path): Utility to generate the file path
to the generated sample files at the top level of layout-test-results.
(MacPort.look_for_new_crash_logs): Fix typo
(MacPort.look_for_new_samples): New function to find sample files.
(MacPort.sample_process): Use the utility function to get the file path.

LayoutTests:

Reviewed by Tim Horton.

Add links for samples, which some platforms will show for unresponsive WebProcess timeouts.

* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: -webkit-box-reflect does not show on video elements
jer.noble@apple.com [Fri, 15 Mar 2013 17:58:07 +0000 (17:58 +0000)]
REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/video/video-reflection.html

Support cloning specific CALayer subtypes in PlatformCALayer,
which allows reflections to work correctly for those layer types.
Specifically, add support for cloning AVPlayerLayer layers.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::cloneLayer): Moved most of the
    implementation to PlatformCALayer::clone().
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer): Set the layerType to
    LayerTypeAVPlayerLayer if the PlatformLayer parameter is an
    AVPlayerLayer.
(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().
    Copy the player value to the new layer, if the current layer is
    a LayerTypeAVPlayerLayer.
(PlatformCALayer::playerLayer):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().
    May want to add support for AVCFPlayerLayers in the future.

LayoutTests:

* compositing/video/video-reflection-expected.png: Added.
* compositing/video/video-reflection-expected.txt: Added.
* compositing/video/video-reflection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHide MainResourceLoader from the outside world
japhet@chromium.org [Fri, 15 Mar 2013 17:45:06 +0000 (17:45 +0000)]
Hide MainResourceLoader from the outside world
https://bugs.webkit.org/show_bug.cgi?id=109971

Reviewed by Adam Barth.

Source/WebCore:

No new tests, refactor only.

* WebCore.exp.in:
* dom/Document.cpp:
* html/HTMLEmbedElement.cpp:
* html/MediaDocument.cpp:
* html/PluginDocument.cpp:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
* loader/DocumentLoader.h:
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.cpp:
* loader/appcache/ApplicationCacheGroup.cpp:
* loader/appcache/ApplicationCacheHost.cpp:

Source/WebKit/blackberry:

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::convertMainResourceLoadToDownload):
* WebFrame.h:

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientWinCE.h:
(FrameLoaderClientWinCE):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertMainResourceLoadToDownload):
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace static_casts with to* helper functions.
inferno@chromium.org [Fri, 15 Mar 2013 17:31:20 +0000 (17:31 +0000)]
Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112401

Reviewed by Stephen Chenney.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

* accessibility/AccessibilityObject.cpp:
(WebCore::appendAccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObjectFromPluginViewBase):
* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::appendFormData):
* page/EventHandler.cpp:
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::passGestureEventToWidget):
* page/Frame.cpp:
(WebCore::Frame::frameForWidget):
* page/FrameView.cpp:
(WebCore::collectFrameViewChildren):
(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::removeChild):
* page/FrameView.h:
(WebCore::toFrameView):
(WebCore):
* page/Page.cpp:
(WebCore::Page::collectPluginViews):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::passWheelEventToWidget):
* platform/ScrollView.h:
(WebCore::toScrollView):
(WebCore):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::axObjectCache):
* platform/Widget.h:
(WebCore::Widget::isScrollView):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::toUserSpace):
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::setParent):
* platform/qt/PlatformSupportQt.cpp:
(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):
* plugins/IFrameShimSupport.cpp:
(WebCore::getPluginOcclusions):
* plugins/PluginView.h:
(WebCore::toPluginView):
(WebCore):
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::isPluginViewBase):
(PluginViewBase):
(WebCore::toPluginViewBase):
(WebCore):
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::updateBuffer):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleScrollEvent):
(WebCore::PluginView::calculateClipRect):
(WebCore::PluginView::handleFullScreenAllowedEvent):
(WebCore::PluginView::handleFullScreenExitEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setBackgroundPlay):
* plugins/blackberry/PluginViewPrivateBlackBerry.cpp:
(WebCore::PluginViewPrivate::setVisibleRects):
(WebCore::PluginViewPrivate::showKeyboard):
(WebCore::PluginViewPrivate::requestFullScreen):
(WebCore::PluginViewPrivate::requestCenterFitZoom):
(WebCore::PluginViewPrivate::lockOrientation):
(WebCore::PluginViewPrivate::unlockOrientation):
(WebCore::PluginViewPrivate::preventIdle):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::snapshot):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::viewCleared):
(WebCore::RenderEmbeddedObject::nodeAtPoint):
(WebCore::RenderEmbeddedObject::scroll):
* rendering/RenderFlexibleBox.h:
(WebCore::toRenderFlexibleBox):
(WebCore):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::viewCleared):
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::contentRootRenderer):
(WebCore::RenderIFrame::layoutSeamlessly):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::requiresAcceleratedCompositing):
(WebCore::RenderPart::embeddedContentBox):
(WebCore::RenderPart::nodeAtPoint):
* rendering/RenderRuby.cpp:
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::setOverlapTestResult):
(WebCore::RenderWidget::updateWidgetPosition):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::frameForNode):
(BlackBerry::WebKit::needsLayoutRecursive):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):

Source/WebKit/chromium:

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollRect):
(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit::WebPluginContainerImpl::handleMouseEvent):
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/mac:

* WebView/WebRenderNode.mm:
(copyRenderNode):
* WebView/WebView.mm:
(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

* Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] acceleration_backend_description does not concatenate "(gles2"
commit-queue@webkit.org [Fri, 15 Mar 2013 17:11:23 +0000 (17:11 +0000)]
[GTK] acceleration_backend_description does not concatenate "(gles2"
https://bugs.webkit.org/show_bug.cgi?id=112405

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-03-15
Reviewed by Martin Robinson.

In FindDependencies.m4, acceleration_backend_description string does not
concatenate if there is a space between the operator and the operand.

* Source/autotools/FindDependencies.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Texmap] REGRESSION (r144190): Failure at style with preserve-3d...
commit-queue@webkit.org [Fri, 15 Mar 2013 17:07:34 +0000 (17:07 +0000)]
Source/WebCore: [Texmap] REGRESSION (r144190): Failure at style with preserve-3d and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

According to spec, we avoid masking and clipping when preserves-3d is enabled.
However, opacity should still work.
Allowing opacity when preserves-3d is on.

Patch by No'am Rosenthal <noam@webkit.org> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

Test: compositing/overlap-blending/preserves3d-opacity.html

* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintRecursive):

LayoutTests: [Texmap] REGRESSION (r144190): Failure at style with webkit-transform and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

Patch by No'am Rosenthal <noam@webkit.org> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

New ref-test for opacity+preserves-3d.

* compositing/overlap-blending/preserves3d-opacity-expected.html: Added.
* compositing/overlap-blending/preserves3d-opacity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of useless forward declaration.
commit-queue@webkit.org [Fri, 15 Mar 2013 16:51:15 +0000 (16:51 +0000)]
Get rid of useless forward declaration.
https://bugs.webkit.org/show_bug.cgi?id=112449

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-03-15
Reviewed by Stephen Chenney.

No behavioural change

* svg/SVGRectElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make CPU profiler show timings using the same time unit [ms]
commit-queue@webkit.org [Fri, 15 Mar 2013 16:26:47 +0000 (16:26 +0000)]
Web Inspector: make CPU profiler show timings using the same time unit [ms]
https://bugs.webkit.org/show_bug.cgi?id=112356

That makes it much easier to compare values when looking at the data.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-15
Reviewed by Yury Semikhatsky.

* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement support for nullable types in the bindings generator
peter@chromium.org [Fri, 15 Mar 2013 16:24:00 +0000 (16:24 +0000)]
Implement support for nullable types in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=111728

Reviewed by Kentaro Hara.

This patch adds support for nullable types in the bindings
generator, as described in section 3.10.22 of WebIDL:
    http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type

interface MyInterface {
    readonly attribute boolean? value; // true, false or null.
};

The IDL Parser has been modified to record whether attributes are
nullable. Question marks from the type will always be stripped
from the domAttribute->signature->type field. Once support for
this has been completely implemented, we'll be able to remove a
bunch of custom bindings, i.e. those of Device Orientation.

Any getter for an attribute which returns a nullable type will be
called with an additional attribute (passed by reference) named
"isNull". This will be the last argument passed to the method,
unless an exception code (ec) argument will be passed as well.

The CPP, GObject and ObjC bindings will not change behavior following
this patch, although they have been modified to call the WebCore
methods for nullable attributes with the correct signature. The
V8 and JS binding generators do have modified behavior, in that they
will actually return v8Null/jsNull when isNull == true.

Tested by existing binding tests and the new nullable attribute
tests in the bindings/scripts/test/ directory.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateFunction):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
* bindings/scripts/IDLParser.pm:
(typeHasNullableSuffix):
(typeRemoveNullableSuffix):
(parseAttributeRest):
(parseOptionalOrRequiredArgument):
(parseAttributeRestOld):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::nullableDoubleAttribute):
(WebDOMTestObj::nullableLongAttribute):
(WebDOMTestObj::nullableBooleanAttribute):
(WebDOMTestObj::nullableStringAttribute):
(WebDOMTestObj::nullableLongSettableAttribute):
(WebDOMTestObj::setNullableLongSettableAttribute):
(WebDOMTestObj::nullableStringValue):
(WebDOMTestObj::setNullableStringValue):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_nullable_double_attribute):
(webkit_dom_test_obj_get_nullable_long_attribute):
(webkit_dom_test_obj_get_nullable_boolean_attribute):
(webkit_dom_test_obj_get_nullable_string_attribute):
(webkit_dom_test_obj_get_nullable_long_settable_attribute):
(webkit_dom_test_obj_set_nullable_long_settable_attribute):
(webkit_dom_test_obj_get_nullable_string_value):
(webkit_dom_test_obj_set_nullable_string_value):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj nullableDoubleAttribute]):
(-[DOMTestObj nullableLongAttribute]):
(-[DOMTestObj nullableBooleanAttribute]):
(-[DOMTestObj nullableStringAttribute]):
(-[DOMTestObj nullableLongSettableAttribute]):
(-[DOMTestObj setNullableLongSettableAttribute:]):
(-[DOMTestObj nullableStringValue]):
(-[DOMTestObj setNullableStringValue:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetterCallback):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Store main world and non-main world templates separately.
commit-queue@webkit.org [Fri, 15 Mar 2013 15:37:27 +0000 (15:37 +0000)]
[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore):
(WebCore::V8Float64Array::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
(WebCore):
(WebCore::V8TestActiveDOMObject::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore):
(WebCore::V8TestCustomNamedGetter::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore):
(WebCore::V8TestEventConstructor::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
(WebCore):
(WebCore::V8TestEventTarget::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore):
(WebCore::V8TestException::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
(WebCore):
(WebCore::V8TestInterface::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
(WebCore):
(WebCore::V8TestMediaQueryListListener::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore):
(WebCore::V8TestNamedConstructor::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
(WebCore):
(WebCore::V8TestNode::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore):
(WebCore::V8TestObj::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore):
(WebCore::V8TestOverloadedConstructors::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore):
(WebCore::V8TestTypedefs::HasInstanceInAnyWorld):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toRefPtrNativeArray):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageMethodCustom):
* bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addMethodCustom):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
* src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145802.
commit-queue@webkit.org [Fri, 15 Mar 2013 14:14:13 +0000 (14:14 +0000)]
Unreviewed, rolling out r145802.
http://trac.webkit.org/changeset/145802
https://bugs.webkit.org/show_bug.cgi?id=112444

This broke Chrome. (Requested by marja____ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

Source/WebCore:

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
* bindings/v8/V8Binding.h:
(WebCore::toRefPtrNativeArray):
(WebCore):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageMethodCustom):
* bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addMethodCustom):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
* src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145896.
commit-queue@webkit.org [Fri, 15 Mar 2013 14:05:16 +0000 (14:05 +0000)]
Unreviewed, rolling out r145896.
http://trac.webkit.org/changeset/145896
https://bugs.webkit.org/show_bug.cgi?id=112443

Chrome broken by r145802 and this builds on top of it.
(Requested by marja____ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(WebCore):
* bindings/v8/DOMDataStore.h:
(DOMDataStore):
* bindings/v8/V8DOMConfiguration.cpp:
* bindings/v8/V8DOMConfiguration.h:
(V8DOMConfiguration):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8EventTargetCustom.cpp:
* bindings/v8/custom/V8IDBAnyCustom.cpp:
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove PlatformSupport
commit-queue@webkit.org [Fri, 15 Mar 2013 13:52:17 +0000 (13:52 +0000)]
[BlackBerry] Remove PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=112438

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

This class only contains getFontFamilyForCharacters(), which was
moved from PlatformSupport to FontCache in r129257.

This patch does the same for the BlackBerry port.

* platform/graphics/FontCache.h:
(FontCache):
* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getFontFamilyForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/blackberry/PlatformSupport.cpp: Removed.
* platform/graphics/blackberry/PlatformSupport.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FontPlatformData: remove TextOrientation parameter
commit-queue@webkit.org [Fri, 15 Mar 2013 13:50:32 +0000 (13:50 +0000)]
[BlackBerry] FontPlatformData: remove TextOrientation parameter
https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

I forgot to remove the #include "TextOrientation.h" line as
well. This file no longer exists.

* platform/graphics/blackberry/FontCustomPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDataGrid should reveal and select next/previous DataGridNode upon deletion of selecte...
commit-queue@webkit.org [Fri, 15 Mar 2013 13:35:13 +0000 (13:35 +0000)]
DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
https://bugs.webkit.org/show_bug.cgi?id=112404

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2013-03-15
Reviewed by Vsevolod Vlasov.

No new tests as this is a UI related change.

While deleting the entries of the data grid by clicking on 'Delete'
status bar button, deletion of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype.changeNodeAfterDeletion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. Draw timeline grid over flame chart items.
loislo@chromium.org [Fri, 15 Mar 2013 13:29:01 +0000 (13:29 +0000)]
Web Inspector: Flame Chart. Draw timeline grid over flame chart items.
https://bugs.webkit.org/show_bug.cgi?id=112439

Reviewed by Pavel Feldman.

I've used WebInspector.TimelineGrid

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.Calculator.prototype.formatTime):
(WebInspector.FlameChart.Calculator.prototype.maximumBoundary):
(WebInspector.FlameChart.Calculator.prototype.minimumBoundary):
(WebInspector.FlameChart.Calculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build error with building with Qt 5.1
allan.jensen@digia.com [Fri, 15 Mar 2013 12:48:01 +0000 (12:48 +0000)]
[Qt] Build error with building with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=112435

Reviewed by Noam Rosenthal.

QAccessibleWidget has moved to private.

.:

* Source/widgetsapi.pri:

Source/WebKit/qt:

* WidgetApi/qwebviewaccessible_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Compositor is applying scroll offset using 'programmatic' API
jknotten@chromium.org [Fri, 15 Mar 2013 12:32:55 +0000 (12:32 +0000)]
[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed -- remove test expectations for timeline-receive-response-event and remove
caseq@chromium.org [Fri, 15 Mar 2013 12:21:01 +0000 (12:21 +0000)]
Unreviewed -- remove test expectations for timeline-receive-response-event and remove
another source of flakiness in the test.

* inspector/timeline/timeline-receive-response-event.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add machinery for generating specialized bindings for the main world
commit-queue@webkit.org [Fri, 15 Mar 2013 11:14:28 +0000 (11:14 +0000)]
[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters.

No new tests (updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterForMainWorld):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterForMainWorld):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallbackForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetterForMainWorld):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::nameAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterForMainWorld):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterForMainWorld):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterForMainWorld):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::addToTemplate):
(WebCore):
* bindings/v8/V8DOMConfiguration.h:
(V8DOMConfiguration):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8EventTargetCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed trivial DRT ASSERT fix
hausmann@webkit.org [Fri, 15 Mar 2013 11:07:12 +0000 (11:07 +0000)]
[Qt] Unreviewed trivial DRT ASSERT fix

r145805 erroneously added setController calls for device orientation/motion
mock clients. Those ASSERT, the controller ctor already calls setController
on the client.

* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::initializeWebCorePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. xOffset calculates incorrectly when chart width less...
loislo@chromium.org [Fri, 15 Mar 2013 10:46:10 +0000 (10:46 +0000)]
Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width less that canvas.width.
https://bugs.webkit.org/show_bug.cgi?id=112423

Reviewed by Yury Semikhatsky.

I extracted xOffset assigment procedure into a separate function.

Drive by fix: size and posion of anchor element was adjusted.
Drive by fix: we will not paint item if it is not visible.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._maxXOffset):
(WebInspector.FlameChart.prototype._setXOffset):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Change brightness filter to match new spec
commit-queue@webkit.org [Fri, 15 Mar 2013 10:40:29 +0000 (10:40 +0000)]
[Texmap] Change brightness filter to match new spec
https://bugs.webkit.org/show_bug.cgi?id=112422

New filters spec specifies an intercept of 0 instead of 1.
This is already done for the software version in http://trac.webkit.org/changeset/139770.
This patch adjusts the value for the accelerated version.

Patch by Noam Rosenthal <noam@webkit.org> on 2013-03-15
Reviewed by Allan Sandfeld Jensen.

Filter tests are currently disabled on Qt/GTK/EFL, but they would need to be rebaselined once enabled.

* platform/graphics/texmap/TextureMapperShaderProgram.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall release() when a RefPtr is returned.
commit-queue@webkit.org [Fri, 15 Mar 2013 10:22:33 +0000 (10:22 +0000)]
Call release() when a RefPtr is returned.
https://bugs.webkit.org/show_bug.cgi?id=112420

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-15
Reviewed by Eric Seidel.

release() should be called on a RefPtr to convert it to a PassRefPtr.

No new tests needed, no behavior changes.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
eustas@chromium.org [Fri, 15 Mar 2013 10:18:51 +0000 (10:18 +0000)]
Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
https://bugs.webkit.org/show_bug.cgi?id=112341

Reviewed by Vsevolod Vlasov.

When both objects do not have initiator: f(a, b) = f(b, a) = -1
Furthermore: redirected responses are mixed with "other".

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Remember "displayed" initiator type.
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Recall "diaplayed" initiator type for more precise comparison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove simple getters and setters from TestRunnerQt
zeno.albisser@digia.com [Fri, 15 Mar 2013 10:17:14 +0000 (10:17 +0000)]
[Qt] Remove simple getters and setters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112343

Reviewed by Benjamin Poulain.

The removed functions and boolean members
are being replaced by the implementations in the
generic TestRunner.h.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::dumpFrameScrollPosition):
(DumpRenderTree::dumpFramesAsText):
(DumpRenderTree::dump):
(DumpRenderTree::titleChanged):
(DumpRenderTree::dumpDatabaseQuota):
(DumpRenderTree::dumpApplicationCacheQuota):
(DumpRenderTree::statusBarMessage):
(DumpRenderTree::createWindow):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: show image decode performed off main thread on timeline
caseq@chromium.org [Fri, 15 Mar 2013 10:08:21 +0000 (10:08 +0000)]
Web Inspector: show image decode performed off main thread on timeline
https://bugs.webkit.org/show_bug.cgi?id=111159

Reviewed by Pavel Feldman.

- add handling of Decode Image event to TimelineTraceEventProcessorr;
- only log platform events for the main thread;
- extract constants for trace events produced by platform instrumentation.

* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
* inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
* inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onImageDecodeBegin):
(WebCore):
(WebCore::TimelineTraceEventProcessor::onImageDecodeEnd):
* inspector/TimelineTraceEventProcessor.h:
(TimelineTraceEventProcessor):
* platform/PlatformInstrumentation.cpp:
(WebCore):
* platform/PlatformInstrumentation.h:
(PlatformInstrumentation):
(WebCore):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. When user zooms the chart, the point under cursor has...
loislo@chromium.org [Fri, 15 Mar 2013 08:38:07 +0000 (08:38 +0000)]
Web Inspector: Flame Chart. When user zooms the chart, the point under cursor has to be the zooming center.
https://bugs.webkit.org/show_bug.cgi?id=112417

Reviewed by Yury Semikhatsky.

It converts the cursor position into time,
changes the scale factor and calculates the new offset for the canvas.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 15 Mar 2013 08:33:14 +0000 (08:33 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding a failure expectation for the reftest added in r145847
that is failing due to disabled subpixel layout on the GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] Sort columns context menu items alphabetically.
eustas@chromium.org [Fri, 15 Mar 2013 08:28:39 +0000 (08:28 +0000)]
Web Inspector: [Network] Sort columns context menu items alphabetically.
https://bugs.webkit.org/show_bug.cgi?id=112321

Reviewed by Pavel Feldman.

Problem: columns are presented in "natural" order,
so it is hard to find specific item.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
Generate list of column IDs sorted alphabetically.
(WebInspector.NetworkLogView.prototype._contextMenu):
Use alphabetically sorted list of column IDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash at RenderStyle::inheritFrom reported by fuzzer
tasak@google.com [Fri, 15 Mar 2013 08:24:19 +0000 (08:24 +0000)]
Crash at RenderStyle::inheritFrom reported by fuzzer
https://bugs.webkit.org/show_bug.cgi?id=112322

Reviewed by Hajime Morrita.

Source/WebCore:

pseudoStyleForElement should check whether a parent style of a given
element is available or not. If a given element's parent is
an insertion point whose reset-style-inheritance is true, the parent
style is not available. Need to use defaultStyleForElement.

Test: fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement):
Removed cloneForParent. Instead, made m_state own parentStyle, i.e.
changed m_parentStyle in class State from RenderStyle* to
RefPtr<RenderStyle>.
(WebCore::StyleResolver::pseudoStyleForElement):
If an actual parent style of a given element is not available, use
defaultStyleForElement. This is the same logic as styleForElement.
* css/StyleResolver.h:
(WebCore::StyleResolver::State::setParentStyle):
Modified the parameter to use PassRefPtr<RenderStyle>.
(WebCore::StyleResolver::State::parentStyle):
(State):

LayoutTests:

* fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash-expected.txt: Added.
* fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Selecting text inside an empty region causes selection outside the...
mihnea@adobe.com [Fri, 15 Mar 2013 08:08:07 +0000 (08:08 +0000)]
[CSS Regions] Selecting text inside an empty region causes selection outside the region area
https://bugs.webkit.org/show_bug.cgi?id=107752

Reviewed by David Hyatt.

Source/WebCore:

When performing hit testing inside a flow thread, we need to make sure that
we actually hit some node from the flow thread content and not the flow thread
itself (which would set the hit test result node to the document node, allowing
wrong selection of content outside the empty region).

Test: fast/regions/selecting-text-in-empty-region.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

LayoutTests:

Add test showing that you cannot select content outside a empty region (without flow thread content).

* fast/regions/selecting-text-in-empty-region-expected.txt: Added.
* fast/regions/selecting-text-in-empty-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] layerRect should be used instead of contents rect for scrollable layer hit...
commit-queue@webkit.org [Fri, 15 Mar 2013 08:06:34 +0000 (08:06 +0000)]
[Texmap] layerRect should be used instead of contents rect for scrollable layer hit tests.
https://bugs.webkit.org/show_bug.cgi?id=112413

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-15
Reviewed by Noam Rosenthal.

Using layerRect() instead of m_state.contentsRect for scrollable layer hit test.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the link on build.webkit.org to refer to perf.webkit.org
rniwa@webkit.org [Fri, 15 Mar 2013 08:04:42 +0000 (08:04 +0000)]
Update the link on build.webkit.org to refer to perf.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=112416

Reviewed by Philip Rogers.

Updated the link. Also updated the template to use HTML5 DOCTYPE.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
commit-queue@webkit.org [Fri, 15 Mar 2013 07:13:51 +0000 (07:13 +0000)]
Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

* GtkLauncher/main.c:
(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Get rid of WebPageProxy::viewWidget() method
mikhail.pozdnyakov@intel.com [Fri, 15 Mar 2013 07:13:28 +0000 (07:13 +0000)]
[WK2][EFL] Get rid of WebPageProxy::viewWidget() method
https://bugs.webkit.org/show_bug.cgi?id=112289

Reviewed by Alexey Proskuryakov.

Web page should not be aware of platform-specific view.

* UIProcess/API/efl/EwkView.cpp:
(wkPageToEvasObjectMap):
(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::toEvasObject):

    EwkView::toEvasObject() relies on static map rather than on
    removed WebPageProxy::viewWidget() method.

* UIProcess/API/efl/EwkView.h:
* UIProcess/API/efl/ewk_text_checker.cpp:
(uniqueSpellDocumentTag):
* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):

    Now uses EwkView::toEvasObject().

* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/efl/WebPageProxyEfl.cpp:

    Removed WebPageProxy::viewWidget() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Fri, 15 Mar 2013 06:28:21 +0000 (06:28 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRedundant if statement in RenderTextControlSingleLine::layout should be removed
dominicc@chromium.org [Fri, 15 Mar 2013 06:22:48 +0000 (06:22 +0000)]
Redundant if statement in RenderTextControlSingleLine::layout should be removed
https://bugs.webkit.org/show_bug.cgi?id=112406

Reviewed by Andreas Kling.

Covered by existing tests added in r145239.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145864.
commit-queue@webkit.org [Fri, 15 Mar 2013 06:01:08 +0000 (06:01 +0000)]
Unreviewed, rolling out r145864.
http://trac.webkit.org/changeset/145864
https://bugs.webkit.org/show_bug.cgi?id=112408

should fix XMLDocumentParser instead of CSSDefaultStyleSheet
(Requested by tasak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-14

Source/WebCore:

* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

* fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
* fast/css/ensure-default-style-sheets-crash.xhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [DataGrid] Specify columns with array of descriptors.
eustas@chromium.org [Fri, 15 Mar 2013 05:29:01 +0000 (05:29 +0000)]
Web Inspector: [DataGrid] Specify columns with array of descriptors.
https://bugs.webkit.org/show_bug.cgi?id=112338

Reviewed by Pavel Feldman.

Currently columns are specified by Object that maps
column identifiers to column descriptors. Iteration order over
Object keys is not guaranteed.

Array should be used to specify column order.

* inspector/front-end/DataGrid.js: Change consrtructor parameter type.
* inspector/front-end/ApplicationCacheItemsView.js: Adopt changes.
* inspector/front-end/CPUProfileView.js: Ditto.
* inspector/front-end/CSSSelectorProfileView.js: Ditto.
* inspector/front-end/CanvasProfileView.js: Ditto.
* inspector/front-end/CookieItemsView.js: Ditto.
* inspector/front-end/CookiesTable.js: Ditto.
* inspector/front-end/DOMStorageItemsView.js: Ditto.
* inspector/front-end/DirectoryContentView.js: Ditto.
* inspector/front-end/HeapSnapshot.js: Ditto.
* inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
* inspector/front-end/IndexedDBViews.js: Ditto.
* inspector/front-end/NativeMemorySnapshotView.js: Ditto.
* inspector/front-end/NetworkPanel.js: Ditto.
* inspector/front-end/ResourceWebSocketFrameView.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145875 268f45cc-cd09-0410-ab3c-d52691b4dbfc