WebKit-https.git
14 years agoJavaScriptCore:
darin [Sun, 11 Dec 2005 02:06:17 +0000 (02:06 +0000)]
JavaScriptCore:

        Rubber stamped by Maciej.

        - did long-promised KJS renaming:

            ValueImp -> JSValue
            ObjectImp -> JSObject
            AllocatedValueImp -> JSCell

        A renaming to get a class out of the way

            KJS::Bindings::JSObject -> JavaJSObject

        and some other "imp-reduction" renaming

            *InstanceImp -> *Instance
            *ProtoFuncImp -> *ProtoFunc
            *PrototypeImp -> *Prototype
            ArgumentsImp -> Arguments
            RuntimeArrayImp -> RuntimeArray
            RuntimeMethodImp -> RuntimeMethod

        * most files and functions

WebCore:

        Rubber stamped by Maciej.

        - updated for KJS class renaming

        * many files and functions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin and Eric.
mjs [Sun, 11 Dec 2005 01:44:29 +0000 (01:44 +0000)]
    Reviewed by Darin and Eric.

        * Makefile.am: Support --enable-svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Sun, 11 Dec 2005 00:38:07 +0000 (00:38 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

        Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

        * bindings/NP_jsobject.cpp:
        (_NPN_Evaluate):
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod):
        (KJS::Bindings::CInstance::invokeDefaultMethod):
        * bindings/c/c_runtime.cpp:
        (CField::valueFromInstance):
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        (JavaInstance::invokeDefaultMethod):
        * bindings/jni/jni_jsobject.cpp:
        (JSObject::eval):
        (JSObject::convertJObjectToValue):
        * bindings/jni/jni_runtime.cpp:
        (JavaArray::convertJObjectToArray):
        (JavaField::valueFromInstance):
        (JavaArray::valueAt):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject webScriptValueAtIndex:]):
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):
        (ObjcInstance::getValueOfUndefinedField):
        * bindings/objc/objc_runtime.mm:
        (ObjcField::valueFromInstance):
        (ObjcFallbackObjectImp::callAsFunction):
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertNSStringToString):
        (KJS::Bindings::convertObjcValueToValue):
        * bindings/runtime.h:
        (KJS::Bindings::Class::fallbackObject):
        (KJS::Bindings::Instance::getValueOfUndefinedField):
        (KJS::Bindings::Instance::valueOf):
        * bindings/runtime_array.cpp:
        (RuntimeArrayImp::lengthGetter):
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::lengthGetter):
        (RuntimeMethodImp::callAsFunction):
        (RuntimeMethodImp::execute):
        * kjs/array_object.cpp:
        (ArrayInstanceImp::lengthGetter):
        (CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments):
        (ArrayPrototypeImp::ArrayPrototypeImp):
        (ArrayProtoFuncImp::ArrayProtoFuncImp):
        (ArrayProtoFuncImp::callAsFunction):
        (ArrayObjectImp::ArrayObjectImp):
        * kjs/bool_object.cpp:
        (BooleanPrototypeImp::BooleanPrototypeImp):
        (BooleanProtoFuncImp::callAsFunction):
        (BooleanObjectImp::BooleanObjectImp):
        (BooleanObjectImp::callAsFunction):
        * kjs/error_object.cpp:
        (ErrorPrototypeImp::ErrorPrototypeImp):
        (ErrorProtoFuncImp::ErrorProtoFuncImp):
        (ErrorProtoFuncImp::callAsFunction):
        (ErrorObjectImp::ErrorObjectImp):
        (NativeErrorImp::NativeErrorImp):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::argumentsGetter):
        (KJS::FunctionImp::lengthGetter):
        (KJS::DeclaredFunctionImp::execute):
        (KJS::encode):
        (KJS::decode):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function_object.cpp:
        (FunctionPrototypeImp::FunctionPrototypeImp):
        (FunctionPrototypeImp::callAsFunction):
        (FunctionProtoFuncImp::callAsFunction):
        (FunctionObjectImp::FunctionObjectImp):
        * kjs/internal.cpp:
        (KJS::InterpreterImp::initGlobalObject):
        * kjs/interpreter.h:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        (MathObjectImp::getValueProperty):
        (MathFuncImp::callAsFunction):
        * kjs/nodes.cpp:
        (Node::setExceptionDetailsIfNeeded):
        (NullNode::evaluate):
        (PropertyNode::evaluate):
        (FunctionCallBracketNode::evaluate):
        (FunctionCallDotNode::evaluate):
        (PostfixBracketNode::evaluate):
        (PostfixDotNode::evaluate):
        (VoidNode::evaluate):
        (PrefixBracketNode::evaluate):
        (PrefixDotNode::evaluate):
        (ShiftNode::evaluate):
        (valueForReadModifyAssignment):
        (AssignDotNode::evaluate):
        (AssignBracketNode::evaluate):
        (VarDeclNode::evaluate):
        (VarDeclNode::processVarDecls):
        (VarDeclListNode::evaluate):
        (ReturnNode::execute):
        (CaseClauseNode::evalStatements):
        (ParameterNode::evaluate):
        (FuncDeclNode::processFuncDecl):
        * kjs/nodes.h:
        (KJS::StatementNode::evaluate):
        * kjs/number_object.cpp:
        (NumberPrototypeImp::NumberPrototypeImp):
        (NumberProtoFuncImp::callAsFunction):
        (NumberObjectImp::NumberObjectImp):
        (NumberObjectImp::getValueProperty):
        (NumberObjectImp::callAsFunction):
        * kjs/object.cpp:
        (KJS::ObjectImp::get):
        (KJS::Error::create):
        * kjs/object_object.cpp:
        (ObjectPrototypeImp::ObjectPrototypeImp):
        (ObjectProtoFuncImp::callAsFunction):
        (ObjectObjectImp::ObjectObjectImp):
        * kjs/property_slot.cpp:
        (KJS::PropertySlot::undefinedGetter):
        * kjs/regexp_object.cpp:
        (RegExpPrototypeImp::RegExpPrototypeImp):
        (RegExpProtoFuncImp::callAsFunction):
        (RegExpObjectImp::RegExpObjectImp):
        (RegExpObjectImp::arrayOfMatches):
        (RegExpObjectImp::getBackref):
        (RegExpObjectImp::getLastMatch):
        (RegExpObjectImp::getLastParen):
        (RegExpObjectImp::getLeftContext):
        (RegExpObjectImp::getRightContext):
        (RegExpObjectImp::getValueProperty):
        (RegExpObjectImp::construct):
        * kjs/string_object.cpp:
        (StringInstanceImp::StringInstanceImp):
        (StringPrototypeImp::StringPrototypeImp):
        (replace):
        (StringProtoFuncImp::callAsFunction):
        (StringObjectImp::StringObjectImp):
        (StringObjectImp::callAsFunction):
        (StringObjectFuncImp::StringObjectFuncImp):
        (StringObjectFuncImp::callAsFunction):
        * kjs/testkjs.cpp:
        (TestFunctionImp::callAsFunction):
        (VersionFunctionImp::callAsFunction):
        * kjs/value.h:

WebCore:

        Reviewed by Maciej.

        - eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

        Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

        * khtml/ecma/domparser.cpp:
        (KJS::DOMParserProtoFunc::callAsFunction):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::jsStringOrNull):
        (KJS::setDOMException):
        * khtml/ecma/kjs_binding.h:
        (KJS::DOMFunction::toPrimitive):
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::indexGetter):
        (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
        (KJS::DOMCSSStyleDeclaration::getValueProperty):
        (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
        (KJS::DOMStyleSheet::getValueProperty):
        (KJS::getDOMStyleSheet):
        (KJS::DOMStyleSheetList::getValueProperty):
        (KJS::getDOMStyleSheetList):
        (KJS::DOMStyleSheetListFunc::callAsFunction):
        (KJS::DOMMediaList::getValueProperty):
        (KJS::DOMMediaList::indexGetter):
        (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
        (KJS::DOMCSSStyleSheet::getValueProperty):
        (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
        (KJS::DOMCSSRuleList::getValueProperty):
        (KJS::DOMCSSRuleListFunc::callAsFunction):
        (KJS::DOMCSSRule::getValueProperty):
        (KJS::DOMCSSRuleFunc::callAsFunction):
        (KJS::CSSRuleConstructor::getValueProperty):
        (KJS::DOMCSSValue::getValueProperty):
        (KJS::getDOMCSSValue):
        (KJS::CSSValueConstructor::getValueProperty):
        (KJS::DOMCSSPrimitiveValue::getValueProperty):
        (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
        (KJS::CSSPrimitiveValueConstructor::getValueProperty):
        (KJS::DOMCSSValueList::getValueProperty):
        (KJS::DOMCSSValueListFunc::callAsFunction):
        (KJS::DOMCounter::getValueProperty):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::getValueProperty):
        (KJS::DOMNode::toPrimitive):
        (KJS::DOMNode::getListener):
        (KJS::DOMNodeProtoFunc::callAsFunction):
        (KJS::DOMNodeList::toPrimitive):
        (KJS::DOMNodeList::getValueProperty):
        (KJS::DOMNodeList::callAsFunction):
        (KJS::DOMAttr::getValueProperty):
        (KJS::DOMDocument::getValueProperty):
        (KJS::DOMDocumentProtoFunc::callAsFunction):
        (KJS::DOMElement::getValueProperty):
        (KJS::DOMElement::attributeGetter):
        (KJS::DOMElementProtoFunc::callAsFunction):
        (KJS::DOMDOMImplementationProtoFunc::callAsFunction):
        (KJS::DOMDocumentType::getValueProperty):
        (KJS::DOMNamedNodeMap::lengthGetter):
        (KJS::DOMNamedNodeMapProtoFunc::callAsFunction):
        (KJS::DOMProcessingInstruction::getValueProperty):
        (KJS::DOMNotation::getValueProperty):
        (KJS::DOMEntity::getValueProperty):
        (KJS::getDOMNode):
        (KJS::NodeConstructor::getValueProperty):
        (KJS::DOMExceptionConstructor::getValueProperty):
        (KJS::DOMNamedNodesCollection::lengthGetter):
        (KJS::DOMCharacterData::getValueProperty):
        (KJS::DOMCharacterDataProtoFunc::callAsFunction):
        (KJS::DOMTextProtoFunc::callAsFunction):
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSLazyEventListener::parseCode):
        (KJS::EventConstructor::getValueProperty):
        (KJS::DOMEvent::getValueProperty):
        (KJS::DOMEventProtoFunc::callAsFunction):
        (KJS::getDOMEvent):
        (KJS::EventExceptionConstructor::getValueProperty):
        (KJS::DOMUIEvent::getValueProperty):
        (KJS::DOMUIEventProtoFunc::callAsFunction):
        (KJS::DOMMouseEvent::getValueProperty):
        (KJS::DOMMouseEventProtoFunc::callAsFunction):
        (KJS::DOMKeyboardEvent::getValueProperty):
        (KJS::DOMKeyboardEventProtoFunc::callAsFunction):
        (KJS::MutationEventConstructor::getValueProperty):
        (KJS::DOMMutationEvent::getValueProperty):
        (KJS::DOMMutationEventProtoFunc::callAsFunction):
        (KJS::DOMWheelEvent::getValueProperty):
        (KJS::DOMWheelEventProtoFunc::callAsFunction):
        (KJS::stringOrUndefined):
        (KJS::Clipboard::getValueProperty):
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLDocFunction::callAsFunction):
        (KJS::HTMLDocument::getValueProperty):
        (KJS::HTMLElement::framesetNameGetter):
        (KJS::HTMLElement::frameWindowPropertyGetter):
        (KJS::HTMLElement::runtimeObjectPropertyGetter):
        (KJS::KJS::HTMLElement::callAsFunction):
        (KJS::HTMLElement::htmlGetter):
        (KJS::HTMLElement::headGetter):
        (KJS::HTMLElement::linkGetter):
        (KJS::HTMLElement::titleGetter):
        (KJS::HTMLElement::metaGetter):
        (KJS::HTMLElement::baseGetter):
        (KJS::HTMLElement::isIndexGetter):
        (KJS::HTMLElement::styleGetter):
        (KJS::HTMLElement::bodyGetter):
        (KJS::HTMLElement::formGetter):
        (KJS::HTMLElement::selectGetter):
        (KJS::HTMLElement::optGroupGetter):
        (KJS::HTMLElement::optionGetter):
        (KJS::getInputSelectionStart):
        (KJS::getInputSelectionEnd):
        (KJS::HTMLElement::inputGetter):
        (KJS::HTMLElement::textAreaGetter):
        (KJS::HTMLElement::buttonGetter):
        (KJS::HTMLElement::labelGetter):
        (KJS::HTMLElement::fieldSetGetter):
        (KJS::HTMLElement::legendGetter):
        (KJS::HTMLElement::uListGetter):
        (KJS::HTMLElement::oListGetter):
        (KJS::HTMLElement::dListGetter):
        (KJS::HTMLElement::dirGetter):
        (KJS::HTMLElement::menuGetter):
        (KJS::HTMLElement::liGetter):
        (KJS::HTMLElement::divGetter):
        (KJS::HTMLElement::paragraphGetter):
        (KJS::HTMLElement::headingGetter):
        (KJS::HTMLElement::blockQuoteGetter):
        (KJS::HTMLElement::quoteGetter):
        (KJS::HTMLElement::preGetter):
        (KJS::HTMLElement::brGetter):
        (KJS::HTMLElement::baseFontGetter):
        (KJS::HTMLElement::fontGetter):
        (KJS::HTMLElement::hrGetter):
        (KJS::HTMLElement::modGetter):
        (KJS::HTMLElement::anchorGetter):
        (KJS::HTMLElement::imageGetter):
        (KJS::HTMLElement::objectGetter):
        (KJS::HTMLElement::paramGetter):
        (KJS::HTMLElement::appletGetter):
        (KJS::HTMLElement::mapGetter):
        (KJS::HTMLElement::areaGetter):
        (KJS::HTMLElement::scriptGetter):
        (KJS::HTMLElement::tableGetter):
        (KJS::HTMLElement::tableCaptionGetter):
        (KJS::HTMLElement::tableColGetter):
        (KJS::HTMLElement::tableSectionGetter):
        (KJS::HTMLElement::tableRowGetter):
        (KJS::HTMLElement::tableCellGetter):
        (KJS::HTMLElement::frameSetGetter):
        (KJS::HTMLElement::frameGetter):
        (KJS::HTMLElement::iFrameGetter):
        (KJS::HTMLElement::marqueeGetter):
        (KJS::HTMLElement::getValueProperty):
        (KJS::HTMLElementFunction::HTMLElementFunction):
        (KJS::KJS::HTMLElementFunction::callAsFunction):
        (KJS::HTMLCollection::lengthGetter):
        (KJS::KJS::HTMLCollection::callAsFunction):
        (KJS::KJS::HTMLCollection::getNamedItems):
        (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction):
        (KJS::HTMLSelectCollection::selectedIndexGetter):
        (KJS::HTMLSelectCollection::getOwnPropertySlot):
        (KJS::OptionConstructorImp::OptionConstructorImp):
        (KJS::Image::getValueProperty):
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::Context2D::getValueProperty):
        (KJS::Context2D::Context2D):
        (KJS::GradientFunction::callAsFunction):
        (KJS::Gradient::getValueProperty):
        (KJS::ImagePattern::getValueProperty):
        (KJS::getSelectHTMLCollection):
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty):
        (KJS::Plugins::getValueProperty):
        (KJS::Plugins::nameGetter):
        (KJS::MimeTypes::getValueProperty):
        (KJS::MimeTypes::nameGetter):
        (KJS::Plugin::getValueProperty):
        (KJS::Plugin::nameGetter):
        (KJS::MimeType::getValueProperty):
        (KJS::PluginsFunc::callAsFunction):
        (KJS::NavigatorFunc::callAsFunction):
        * khtml/ecma/kjs_proxy.cpp:
        (TestFunctionImp::callAsFunction):
        * khtml/ecma/kjs_range.cpp:
        (KJS::DOMRange::getValueProperty):
        (KJS::DOMRangeProtoFunc::callAsFunction):
        (KJS::RangeConstructor::getValueProperty):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIterator::getValueProperty):
        (KJS::DOMNodeIteratorProtoFunc::callAsFunction):
        (KJS::NodeFilterConstructor::getValueProperty):
        (KJS::DOMNodeFilterProtoFunc::callAsFunction):
        (KJS::DOMTreeWalker::getValueProperty):
        (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractViewProtoFunc::callAsFunction):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Screen::getValueProperty):
        (KJS::Window::retrieve):
        (KJS::showModalDialog):
        (KJS::Window::getValueProperty):
        (KJS::Window::getListener):
        (KJS::WindowFunc::callAsFunction):
        (KJS::FrameArray::getValueProperty):
        (KJS::FrameArray::indexGetter):
        (KJS::FrameArray::nameGetter):
        (KJS::Location::getValueProperty):
        (KJS::Location::toPrimitive):
        (KJS::LocationFunc::callAsFunction):
        (KJS::Selection::getValueProperty):
        (KJS::Selection::toPrimitive):
        (KJS::SelectionFunc::callAsFunction):
        (KJS::BarInfo::getValueProperty):
        (KJS::History::getValueProperty):
        (KJS::HistoryFunc::callAsFunction):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty):
        (KJS::XMLHttpRequest::getAllResponseHeaders):
        (KJS::XMLHttpRequest::getResponseHeader):
        (KJS::XMLHttpRequest::getStatus):
        (KJS::XMLHttpRequest::getStatusText):
        (KJS::XMLHttpRequestProtoFunc::callAsFunction):
        * khtml/ecma/xmlserializer.cpp:
        (KJS::XMLSerializerProtoFunc::callAsFunction):
        * ksvg2/ecma/Ecma.cpp:
        (KSVG::getSVGPathSeg):
        * ksvg2/ecma/GlobalObject.cpp:
        (GlobalObject::get):
        * kwq/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin and Tim Hatcher.
mjs [Sun, 11 Dec 2005 00:07:25 +0000 (00:07 +0000)]
    Reviewed by Darin and Tim Hatcher.

        - fix WebCore SVG build for gcc 3.3 (don't know why it has these complaints)

        * kcanvas/KCanvasFilters.h:
        (QPointF::QPointF): Add a default constructor
        (KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): ditto
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFEBlendQuartz::getCIFilter): Move a variable declaration
instead exception blocking
        (KCanvasFECompositeQuartz::getCIFilter): ditto
        (KCanvasFEMergeQuartz::getCIFilter): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Sat, 10 Dec 2005 20:40:35 +0000 (20:40 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6032
          REGRESSION: Uncaught exception when image is dragged out of webpage

        * WebCore.exp: Export the new WebCoreElementImageRendererKey and remove the old
        WebCoreElementImageKey.
        * kwq/WebCoreBridge.h: Add WebCoreElementImageRendererKey, remove WebCoreElementImageKey.
        * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Pass the image renderer in the
        dictionary, but not the NSImage.

WebKit:

        Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6032
          REGRESSION: Uncaught exception when image is dragged out of webpage

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        Pass the image renderer, not the NSImage.
        (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from
        WebCore with only an image renderer.
        * WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
        Pass the image renderer, not the NSImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 10 Dec 2005 20:34:45 +0000 (20:34 +0000)]
LayoutTests:

        Reviewed and landed by Darin.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
        plainText() returns a partial result when the node contains RTL text

        * fast/dom/inner-text-rtl-expected.txt: Added.
        * fast/dom/inner-text-rtl.html: Added.

WebCore:

        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
          plainText() returns a partial result when the node contains RTL text

        Test: fast/dom/inner-text-rtl.html

        * khtml/editing/visible_text.cpp:
        (khtml::TextIterator::handleTextBox): Avoid advancing m_sortedTextBoxes if textBoxEnd wasn't reached.
        * kwq/KWQListImpl.h:
        * kwq/KWQListImpl.mm:
        (KWQListImpl::getNext): Added.
        (KWQListImpl::getPrev): Added.
        * kwq/KWQPtrList.h:
        (QPtrList::getNext): Added.
        (QPtrList::getPrev): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 10 Dec 2005 20:21:58 +0000 (20:21 +0000)]
LayoutTests:

        New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5826

        * fast/overflow/overflow-rtl-expected.checksum: Added.
        * fast/overflow/overflow-rtl-expected.png: Added.
        * fast/overflow/overflow-rtl-expected.txt: Added.
        * fast/overflow/overflow-rtl.html: Added.

WebCore:

        Reviewed by Hyatt, landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5826
          Blocks with direction:rtl and overflow:auto or scroll have incorrect scrollbars

        * khtml/rendering/render_block.cpp: (khtml::RenderBlock::leftmostPosition):
        * khtml/rendering/render_layer.cpp:
        (khtml::RenderLayer::RenderLayer): Initialize
        (khtml::RenderLayer::scrollOffset):
        (khtml::RenderLayer::subtractScrollOffset):
        (khtml::RenderLayer::scrollToOffset):
        (khtml::RenderLayer::scrollRectToVisible):
        (khtml::RenderLayer::updateScrollPositionFromScrollbars):
        (khtml::RenderLayer::computeScrollDimensions):
        (khtml::RenderLayer::updateScrollInfoAfterLayout):
        * khtml/rendering/render_layer.h:
        (khtml::RenderLayer::scrollXOffset):
        (khtml::RenderLayer::scrollToYOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 10 Dec 2005 19:56:11 +0000 (19:56 +0000)]
LayoutTests:

        New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3983

        * fast/css/outline-auto-location-expected.checksum: Added.
        * fast/css/outline-auto-location-expected.png: Added.
        * fast/css/outline-auto-location-expected.txt: Added.
        * fast/css/outline-auto-location.html: Added.

WebCore:

        Reviewed by Hyatt, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3983
          outline:auto improperly puts outline around contained elements, not the actual div

        * khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects):
        Only add the rect if this is a RenderBlock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Sat, 10 Dec 2005 19:05:22 +0000 (19:05 +0000)]
JavaScriptCore:

        Reviewed by Maciej, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3539
          Array join and toString methods do not support circular references

        * kjs/array_object.cpp: (ArrayProtoFuncImp::callAsFunction):
        Added set of visited objects -- don't recurse if item is already in the set.

LayoutTests:

        New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

        * fast/js/cyclic-ref-toString-expected.txt: Added.
        * fast/js/cyclic-ref-toString.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 10 Dec 2005 18:56:00 +0000 (18:56 +0000)]
LayoutTests:

        New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5784

        * fast/parser/duplicate-html-body-element-IDs-expected.txt: Added.
        * fast/parser/duplicate-html-body-element-IDs.html: Added.

WebCore:

        Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5784
          Assertion failure in DocumentImpl::removeElementById() (idCount > 0)
          Another symptom is that getElementById doesn't work when the ID is on a duplicate
          <html> or <body> element.

        Added a new layout test that checks for at least one symptom of the bug.

        * khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use setAttribute here instead
        of using insertAttribute and calling recalcStyle explicitly. That's because setAttribute
        does other things that are needed to change an attribute in an attribute map that's
        already connected to an element, including updating the ID map if the attribute is
        the ID attribute.

        * khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::insertAttribute):
        Assert that this parser-only function is only used on attribute maps that aren't yet
        attached to elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric and Tim Omernick.
darin [Sat, 10 Dec 2005 17:14:38 +0000 (17:14 +0000)]
    Reviewed by Eric and Tim Omernick.

        - speed up timers by using CFTimerRunLoopRef instead of NSTimer
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5677

        * kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and
        restartTimer. Made KWQObjectSenderScope functions be inline.
        * kwq/KWQObject.mm:
        (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the
        deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent
        on the target.
        (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new
        timer ID and calls restartTimer.
        (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary.
        That includes creating a CFRunLoopTimer and scheduling it on the current run loop.
        (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to
        fire and the "fire again" interval.
        (deleteTimer): Added. Invalidates and then removes a timer.
        (QObject::killTimer): Changed to use deleteTimer to do most of its work.
        (deleteOneTimer): Added. Calls deleteTimer.
        (QObject::killTimers): Changed to use deleteOneTimer to do most of its work.
        (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target.
        (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers.
        (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.

        * kwq/KWQTimer.h:
        (QTimer::QTimer): Made constructor inline and removed the optional parameter.
        (QTimer::isActive): Made inline.
        (QTimer::fireDate): Added. Inline function.
        Got rid of the NSTimer and added a CFRunLoopTimer.
        * kwq/KWQTimer.mm:
        (timerFired): Added. Calls fire on the QTimer object.
        (QTimer::start): Changed to create a CFRunLoopTimer.
        (QTimer::stop): Changed to use CFRunLoopTimer functions.
        (QTimer::fire): Ditto.

        * khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the
        file so it can be used inline in the implementation of the Window class, and changed to
        use the PausedTimeouts class intead of a QMap to store the paused timeouts.
        * khtml/ecma/kjs_window.cpp:
        (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces
        a check in the caller and a check partway down this function (after the part was
        already dereferenced). Fixed message handling so the message is not converted to ascii
        and back. Added an isObject() check so we won't crash if the passed function is a value
        that's not an object. Changed check for function vs. script to check for a function
        of nil instead of using a separate boolean.
        (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object,
        using the new QObject::timerIntervals function rather than the old QObject::pauseTimer
        function. This means that the paused timers are entirely stored in the PausedTimeouts
        object instead of being half in a QMap and the other half inside the QObject itself.
        (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function.
        (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including
        the scheduled actions, unless the timeouts have already been resumed (in which case the
        m_array field will be 0).

        * kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them
        use the PausedTimeouts class and no longer take a key parameter.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than
        the old getNSTimer() function to get the fire date.
        (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter.
        (KWQKHTMLPart::resumeTimeouts): Remove the key parameter.
        (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead
        of a QMap for the paused timeouts.

        * kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts.
        Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
        * kwq/KWQPageState.mm:
        (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]):
        Added code where it sets the pausedTimouts.
        (-[KWQPageState pausedTimeouts]): Added.
        (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode.
        (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0.
        (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method.
        (-[KWQPageState finalize]): Set document to 0 after deref for consistency.

        * kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the
        paused timeouts using the new pauseTimeouts function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Was getting build failures related to "count" methods.
darin [Sat, 10 Dec 2005 15:27:57 +0000 (15:27 +0000)]
    Was getting build failures related to "count" methods.
        Made Tim's build fix Leopard-only.

        * WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele Peterson.
sullivan [Sat, 10 Dec 2005 04:52:03 +0000 (04:52 +0000)]
    Reviewed by Adele Peterson.

        - fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit

        * WebView.subproj/WebView.m:
        (-[WebView _frameForCurrentSelection]):
        I removed this method many moons ago when restructuring the code involving frames and selection.
        Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should
        become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's
        just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4370209> Reproducible crash when pasting over whitespace...
justing [Sat, 10 Dec 2005 02:59:31 +0000 (02:59 +0000)]
    <rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
        <rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections
        Some preparation for a fix for:
        <radar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

        There were a few bugs in endOfParagraph's and endOfLine's handling of IncludeLineBreak.
        The IncludeLinebreak concept also doesn't make sense: when asked to
        IncludeLineBreak, "endOfParagraph" would return the start of the next paragraph.
        Callers that want this funtionality should just call endOfParagraph and then get next()
        if it exists.
        In endOfParagraph's whitespace:pre handling, when the input visible position
        was at the end of a text node with whitespace:pre, that text node was searched
        for '/n'.  It should be skipped.

        Reviewed by harrison

        Added new layout tests in editing/pasting and editing/selection

        * khtml/editing/SelectionController.cpp:
        (khtml::SelectionController::validate):
        * khtml/editing/composite_edit_command.cpp:
        (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        * khtml/editing/visible_units.cpp:
        (khtml::endOfLine):
        (khtml::isEndOfLine):
        (khtml::endOfParagraph):
        (khtml::isEndOfParagraph):
        * khtml/editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New layout tests for:
justing [Sat, 10 Dec 2005 02:59:14 +0000 (02:59 +0000)]
    New layout tests for:
        <rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
        <rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections

        Reviewed by harrison

        * editing/pasteboard/paste-pre-002-expected.checksum: Added.
        * editing/pasteboard/paste-pre-002-expected.png: Added.
        * editing/pasteboard/paste-pre-002-expected.txt: Added.
        * editing/pasteboard/paste-pre-002.html: Added.
        * editing/selection/triple-click-in-pre-expected.checksum: Added.
        * editing/selection/triple-click-in-pre-expected.png: Added.
        * editing/selection/triple-click-in-pre-expected.txt: Added.
        * editing/selection/triple-click-in-pre.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Sat, 10 Dec 2005 02:13:13 +0000 (02:13 +0000)]
    Reviewed by John Sullivan.

        * Carbon.subproj/HIWebView.m:
        (UpdateCommandStatus):
Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
-performSelector:withObject:'s return value should only be checked if the method returns an object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 9 Dec 2005 23:48:57 +0000 (23:48 +0000)]
    Reviewed by Darin.

<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

        * kwq/KWQScrollView.mm:
        (QScrollView::setContentsPos):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by nobody, build fix.
thatcher [Fri, 9 Dec 2005 18:59:39 +0000 (18:59 +0000)]
    Reviewed by nobody, build fix.

        Using <PDFKit/PDFKit.h> was causing build failures for the Mail team.
        The comment about getting an ambiguous signature conflict anywhere the
        method "count" is used seems to no longer be an issue.

        * WebView.subproj/WebPreferencesPrivate.h: Use <Quartz/Quartz.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
sullivan [Fri, 9 Dec 2005 02:12:34 +0000 (02:12 +0000)]
    Reviewed by Tim Hatcher.

        Some cleanup of how selection rects are associated with NSViews.

        * WebView.subproj/WebDocumentPrivate.h:
        Added a -selectionView method to <WebDocumentSelection>, and clarified that the
        selectionRect is in the coordinate system of this view.

        * Misc.subproj/WebSearchableTextView.m:
        (-[WebSearchableTextView selectionView]):
        new method, returns self

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView selectionView]):
        new method, returns self

        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView selectionRect]):
        translate result into coordinate system of [PDFSubview documentView]
        (-[WebPDFView selectionView]):
        new method, returns [PDFSubview documentView]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
tomernic [Fri, 9 Dec 2005 02:10:02 +0000 (02:10 +0000)]
    Reviewed by Maciej.

<rdar://problem/4311703> Crash in NPN_Invoke receiving contents of http://www.woodieschilidogs.com/ in Mail.app

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::windowScriptNPObject):
        The window script object can be 0 if JavaScript is disabled.  However, callers (like plugins) expect us to
        always return a window script object here.  By substituting a plain ObjectImp for the window's ObjectImp,
        we can satisfy callers' assumptions and let them try to manipulate the dummy object when JavaScript is
        disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Fri, 9 Dec 2005 00:06:45 +0000 (00:06 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        - fixed these semi-legendary bugs:
        <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking
        <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)

        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView becomeFirstResponder]):
        Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now
        passes the focus down to that view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
harrison [Thu, 8 Dec 2005 22:22:50 +0000 (22:22 +0000)]
    Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)"
crashed when going from the "Open a template" menu to "Select recent
Document" in the "Welcome to Corel XI!" window.

These are the parts of that bug fix that were not already fixed in TOT.

        * kwq/KWQComboBox.mm:
        (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
Retain the event because it is the [NSApp currentEvent], which can
change and therefore be released during [super trackMouse:...]

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
sullivan [Thu, 8 Dec 2005 19:44:15 +0000 (19:44 +0000)]
    Reviewed by Tim O.

        - Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy,
        in order to start addressing keyboard focus and selection highlight issues. Unfortunately this
        doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.

        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView acceptsFirstResponder]):
        Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level.
        (-[WebPDFView becomeFirstResponder]):
        With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same
        way as NSScrollView and NSClipView.
        (-[WebPDFView setNextKeyView:]):
        With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same
        way as NSScrollView and NSClipView.
        (-[WebPDFView resignFirstResponder]):
        Removed this method because the WebPDFView itself is never first responder except transiently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
mjs [Thu, 8 Dec 2005 18:33:56 +0000 (18:33 +0000)]
    Reviewed by John.

- some small changes towards frame tree refactoring

Renamed WebViewSets to WebFrameNamespaces, and put the method for
performing a selector on all extant WebViews to WebView itself,
with a separate set tracking live WebViews. This should allow
moving the storage of this info down to WebCore more easily.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge closeWindowSoon]):
        (-[WebBridge runModal]):
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory refreshPlugins:]):
        * WebView.subproj/WebControllerSets.h:
        * WebView.subproj/WebControllerSets.m:
        (+[WebFrameNamespaces addWebView:toFrameNamespace:]):
        (webView::if):
        (+[WebFrameNamespaces webViewsInFrameNamespace:]):
        * WebView.subproj/WebView.m:
        (+[WebView _makeAllWebViewsPerformSelector:]):
        (-[WebView _removeFromAllWebViewsSet]):
        (-[WebView _addToAllWebViewsSet]):
        (-[WebView _close]):
        (-[WebView _findFrameNamed:sourceFrame:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView setGroupName:]):
        * WebView.subproj/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
mjs [Thu, 8 Dec 2005 18:19:28 +0000 (18:19 +0000)]
    Reviewed by John.

- fix major memory leak and resultant slowdown on JavaScript iBench from
my PassRefPtr changes

        * kjs/ustring.cpp:
        (KJS::UString::Rep::create): I forgot to change one of the two overloads to create
with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of
changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt
to adopt the initial refcount, this may be a hair more efficient.

- made the assignment operators for smart pointers inline because Shark said so

        * kxmlcore/PassRefPtr.h:
        (KXMLCore::::operator=):
        * kxmlcore/RefPtr.h:
        (KXMLCore::::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5997
eseidel [Thu, 8 Dec 2005 10:20:41 +0000 (10:20 +0000)]
Bug #: 5997
Submitted by: mitz
Reviewed by: eseidel
        No test possible since this fixes random behavior.

        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5997
        REGRESSION: Focus rings around links are not erased when focus is lost

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::NodeImpl): Initialize m_inDetach to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5987
eseidel [Thu, 8 Dec 2005 09:30:29 +0000 (09:30 +0000)]
Bug #: 5987
Submitted by: eseidel
Reviewed by: darin
        Fixes <applet> in xhtml, as well as <use> in SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5987
eseidel [Thu, 8 Dec 2005 09:17:05 +0000 (09:17 +0000)]
Bug #: 5987
Submitted by: eseidel
Reviewed by: darin
        No applet test (mjs says DRT has kittens in that case)
        SVG is covered by <use> test cases (5 tests).

        Fixes <applet> in xhtml, as well as <use> in SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

        * khtml/xml/xml_tokenizer.cpp:
        (khtml::XMLTokenizer::endElementNs): call closeRenderer()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Thu, 8 Dec 2005 08:54:40 +0000 (08:54 +0000)]
    Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5686
          make Shared::deref faster by eliminating multiple branches

        * khtml/misc/shared.h: Rewrote both Shared and TreeShared to be functionally
        the same, but used signed reference counts and remove the extra
        check inside deref that handles the case of extra derefs (a programming
        mistake in any case). This elimnates a branch from a hot code path.
        Also added license header. New versions have private data members, unlike
        the old ones that used protected.

        * khtml/rendering/render_replaced.h: Removed private inheritance from
        Shared, and instead just declared a variable that holds a reference count,
        because that's the only thing that was being used from Shared.
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::RenderWidget): Initialized m_refCount.
        (RenderWidget::~RenderWidget): Use m_refCount.
        (RenderWidget::eventFilter): Ditto.
        (RenderWidget::deref): Use m_refCount and the new faster idiom (although here
        it's not important becaue the function isn't even inlined).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Thu, 8 Dec 2005 08:44:48 +0000 (08:44 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none, svg build fix only.
        * ksvg2/css/KSVGCSSParser.cpp:
        (DOM::CSSParser::parseSVGValue): parseShorthand rename
        * ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: missing header
        * ksvg2/svg/SVGFELightElementImpl.cpp: missing header
        * ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: missing header

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Thu, 8 Dec 2005 08:40:33 +0000 (08:40 +0000)]
WebCore:

        Reviewed by Eric.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5689
          add support for CSS "custom cursors" (cursor images)

        * khtml/css/css_computedstyle.cpp:
        (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code to the
        CSS_PROP_CURSOR case to handle cursor images.
        * khtml/css/cssparser.cpp: (CSSParser::parseValue): Allow and parse a URL for the
        cursor for the image case.
        * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Do
        the appropriate inherit and initial for CSS_PROP_CURSOR, and allow either an
        identifier or a URL for the value.
        * khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler):
        Removed inappropriate call to resetCursor. We don't change the cursor shape just
        because we're following a link.
        * khtml/khtmlview.cpp:
        (selectCursor): Added. New function that chooses the appropriate cursor.
        Includes new logic to handle image cursors.
        (KHTMLView::viewportMouseMoveEvent): Refactored to use selectCursor to choose
        the appropriate cursor.
        * kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Call the function to get an
        image renderer by its new name, imageRenderer().
        * kwq/KWQCursor.mm:
        (createCustomCursor): Added.
        (QCursor::QCursor): Changed constructor that takes a QPixmap to call createCustomCursor.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::khtmlMouseMoveEvent): Replaced a call to resetCursor with a call to
        setCursor(QCursor()).
        (KWQKHTMLPart::fileWrapperForElement): Fixed code that assumed the render object is always
        a RenderImage. Call TIFFRepresentation on the image renderer instead of incorrectly assuming
        it's always an NSImage.
        * kwq/KWQPainter.mm:
        (QPainter::drawFloatPixmap): Call imageRenderer function instead of getting right at the
        data member.
        (QPainter::drawTiledPixmap): Ditto.
        (QPainter::drawScaledAndTiledPixmap): Ditto.
        * kwq/KWQPixmap.h: Removed convertToImage(), renamed image() to imageRenderer().
        * kwq/KWQPixmap.mm: Similar name changes.
        * kwq/KWQWidget.mm: (QWidget::setCursor): To workaround extra work done by AppKit when you set
        the cursor to the same one, check if the cursor is already set before calling setDocumentCursor.
        * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Call the image method on the image
        renderer instead of incorrectly assuming the renderer itself is an image.

        * kwq/WebCoreImageRenderer.h: Added a TIFFRepresentation method to this protocol.

WebKit:

        Reviewed by Eric.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5689
          add support for CSS "custom cursors" (cursor images)

        * WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and
        image methods since both are required by the WebCoreImageRenderer protocol now and we don't
        have to re-declare them.

        * Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file
        since we need to use methods inherited from that protocol.
        * Misc.subproj/WebNSViewExtras.m: Ditto.
        * WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Landed by Darin.
darin [Thu, 8 Dec 2005 07:42:12 +0000 (07:42 +0000)]
    Landed by Darin.

        - added regression test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5878
          REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path

        * fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
        * fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
        * fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
        * fast/text/atsui-pointtooffset-calls-cg.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej, landed by Darin.
darin [Thu, 8 Dec 2005 07:41:21 +0000 (07:41 +0000)]
    Reviewed by Maciej, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5878
          REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]):
        Added the missing "return".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
sullivan [Thu, 8 Dec 2005 00:19:20 +0000 (00:19 +0000)]
    Reviewed by Tim Omernick.

        - <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView]
        @ home.netscape.com

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray nextValidKeyView]):
        Removed assert that I added a while back. In this case at least, the assertion is
        overzealous, and I can't recreate the tortured chain of logic that led me to adding
        this assertion in the first place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd Radar bug # to an old commit.
hyatt [Wed, 7 Dec 2005 23:19:13 +0000 (23:19 +0000)]
Add Radar bug # to an old commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for Radar bug #4333923, typing tab character into empty
hyatt [Wed, 7 Dec 2005 22:48:56 +0000 (22:48 +0000)]
Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work.  This was just a silly regression
from my pre-wrap/pre-line implementation.  I accidentally changed
code to examine the wrong style().

        Reviewed by harrison

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects...
hyatt [Wed, 7 Dec 2005 21:24:59 +0000 (21:24 +0000)]
Fix the DHTML menus on monster.com.  offsetParent should only return RenderObjects that
have corresponding DOM elements.

        Reviewed by Eric Seidel

        * khtml/rendering/render_object.cpp:
        (RenderObject::offsetParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Wed, 7 Dec 2005 10:31:04 +0000 (10:31 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.
        Removing unused files.

        * kcanvas/KCanvasRegistry.cpp: Removed.
        * kcanvas/KCanvasRegistry.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved change marker.
darin [Wed, 7 Dec 2005 01:16:29 +0000 (01:16 +0000)]
Removed change marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for more methods for exposing more useful style information.
hyatt [Wed, 7 Dec 2005 01:12:38 +0000 (01:12 +0000)]
Add support for more methods for exposing more useful style information.

getMatchedCSSRules can be used to obtain the matched sheet rules for an element.  In Obj-C
it will also include user/user agent sheet rules.

Also add support for tracking the original shorthand in which a property was declared, as well
as whether the property was just implicitly set rather than explicitly mentioned (e.g., if it was
an omitted piece of a shorthand).  The new methods on CSSStyleDeclaration are getPropertyShorthand
and isPropertyImplicit.

        Reviewed by mjs

        Test: fast/inspector/style.html

        * khtml/css/css_computedstyle.h:
        (DOM::CSSComputedStyleDeclarationImpl::getPropertyShorthand):
        (DOM::CSSComputedStyleDeclarationImpl::isPropertyImplicit):
        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSStyleDeclarationImpl::getPropertyShorthand):
        (DOM::CSSStyleDeclarationImpl::isPropertyImplicit):
        (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority):
        (DOM::CSSMutableStyleDeclarationImpl::getPropertyShorthand):
        (DOM::CSSMutableStyleDeclarationImpl::isPropertyImplicit):
        (DOM::CSSProperty::cssText):
        (DOM::operator==):
        * khtml/css/css_valueimpl.h:
        (DOM::CSSProperty::CSSProperty):
        (DOM::CSSProperty::operator=):
        (DOM::CSSProperty::~CSSProperty):
        (DOM::CSSProperty::setValue):
        (DOM::CSSProperty::shorthandID):
        (DOM::CSSProperty::isImportant):
        (DOM::CSSProperty::isImplicit):
        * khtml/css/cssparser.cpp:
        (CSSParser::CSSParser):
        (CSSParser::addProperty):
        (CSSParser::parseValue):
        (CSSParser::parseBackgroundShorthand):
        (CSSParser::parseShorthand):
        (CSSParser::parse4Values):
        (CSSParser::parseBackgroundPosition):
        (CSSParser::parseBackgroundProperty):
        * khtml/css/cssparser.h:
        (DOM::CSSParser::enterShorthand):
        (DOM::CSSParser::exitShorthand):
        (DOM::CSSParser::inShorthand):
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::CSSStyleSelector):
        (khtml::CSSStyleSelector::matchRules):
        (khtml::CSSStyleSelector::matchRulesForList):
        (khtml::CSSStyleSelector::initForStyleResolve):
        (khtml::CSSStyleSelector::styleRulesForElement):
        (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
        * khtml/css/cssstyleselector.h:
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
        * khtml/ecma/kjs_css.h:
        (KJS::DOMCSSStyleDeclaration::):
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractViewProtoFunc::callAsFunction):
        * khtml/ecma/kjs_views.h:
        (KJS::DOMAbstractView::):
        * khtml/xml/dom2_viewsimpl.cpp:
        (DOM::AbstractViewImpl::getComputedStyle):
        (DOM::AbstractViewImpl::getMatchedCSSRules):
        * khtml/xml/dom2_viewsimpl.h:
        * kwq/DOM-CSS.mm:
        (-[DOMCSSStyleDeclaration getPropertyShorthand:]):
        (-[DOMCSSStyleDeclaration isPropertyImplicit:]):
        (-[DOMDocument getMatchedCSSRules::]):
        * kwq/DOMPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand layout test for style inspection.
hyatt [Wed, 7 Dec 2005 01:11:14 +0000 (01:11 +0000)]
Land layout test for style inspection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 6 Dec 2005 22:12:07 +0000 (22:12 +0000)]
Reviewed by Darin.

- fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView hitTest:]): check for NSFlagsChanged event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Dec 2005 21:54:55 +0000 (21:54 +0000)]
    Reviewed by Darin Adler.

        * Scripts/prepare-ChangeLog:
        Remove special-case handling for nib files. This avoided trouble with cvs diff
        when we were using wrappers for nib files. Now that we aren't using wrappers,
        there's no reason to avoid adding the modified nib files to the file list that
        gets diffed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-06 Anders Carlsson <andersca@mac.com>
andersca [Tue, 6 Dec 2005 19:38:52 +0000 (19:38 +0000)]
2005-12-06  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - fix build when using gcc 4

        * kjs/ustring.h:
        Make Rep public.

        * kxmlcore/PassRefPtr.h:
        (KXMLCore::::operator):
        Fix a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Tue, 6 Dec 2005 09:21:15 +0000 (09:21 +0000)]
JavaScriptCore:

        Reviewed by Eric.

- add PassRefPtr, a smart pointer class that works in conjunction
with RefPtr but has transfer-of-ownership semantics
- apply RefPtr and PassRefPtr to UString
- cleaned up UString a little so that it doesn't need to have so many friend classes

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/identifier.cpp:
        (KJS::Identifier::add):
        * kjs/identifier.h:
        (KJS::Identifier::Identifier):
        (KJS::Identifier::equal):
        * kjs/property_map.cpp:
        (KJS::PropertyMap::get):
        (KJS::PropertyMap::getLocation):
        (KJS::PropertyMap::put):
        (KJS::PropertyMap::remove):
        * kjs/ustring.cpp:
        (KJS::UCharReference::operator=):
        (KJS::UCharReference::ref):
        (KJS::UString::Rep::createCopying):
        (KJS::UString::Rep::create):
        (KJS::UString::usedCapacity):
        (KJS::UString::usedPreCapacity):
        (KJS::UString::expandCapacity):
        (KJS::UString::expandPreCapacity):
        (KJS::UString::UString):
        (KJS::UString::spliceSubstringsWithSeparators):
        (KJS::UString::append):
        (KJS::UString::operator=):
        (KJS::UString::toStrictUInt32):
        (KJS::UString::substr):
        (KJS::UString::copyForWriting):
        (KJS::operator==):
        * kjs/ustring.h:
        (KJS::UString::UString):
        (KJS::UString::~UString):
        (KJS::UString::data):
        (KJS::UString::isNull):
        (KJS::UString::isEmpty):
        (KJS::UString::size):
        (KJS::UString::rep):
        * kxmlcore/RefPtr.h:
        (KXMLCore::RefPtr::RefPtr):
        (KXMLCore::RefPtr::operator*):
        (KXMLCore::::operator):
        (KXMLCore::operator==):
        (KXMLCore::operator!=):
        (KXMLCore::static_pointer_cast):
        (KXMLCore::const_pointer_cast):

WebCore:

        Reviewed by Eric.

- add PassRefPtr, a smart pointer class that works in conjunction
with RefPtr but has transfer-of-ownership semantics
- apply RefPtr and PassRefPtr to UString

        * khtml/ecma/kjs_binding.cpp:
        (KJS::UString::UString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Tue, 6 Dec 2005 07:20:43 +0000 (07:20 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Script updates for SVG files move (remove references to SVGSupport)

        * Scripts/build-webkit: remove SVGSupport
        * Scripts/run-webkit-tests: Resources -> resources for --svg
        * Scripts/update-webkit: remove SVGSupport

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Tue, 6 Dec 2005 06:29:25 +0000 (06:29 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Changed "Resources" to "resources" to match other layout tests.

        * svg/W3C-SVG-1.1/color-prof-01-f.svg:
        * svg/W3C-SVG-1.1/filters-conv-01-f.svg:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
        * svg/W3C-SVG-1.1/filters-displace-01-f.svg:
        * svg/W3C-SVG-1.1/filters-image-01-b.svg:
        * svg/W3C-SVG-1.1/filters-light-01-f.svg:
        * svg/W3C-SVG-1.1/filters-specular-01-f.svg:
        * svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
        * svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
        * svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
        * svg/W3C-SVG-1.1/interact-order-02-b.svg:
        * svg/W3C-SVG-1.1/interact-order-03-b.svg:
        * svg/W3C-SVG-1.1/linking-a-01-b.svg:
        * svg/W3C-SVG-1.1/linking-a-02-b.svg:
        * svg/W3C-SVG-1.1/linking-a-03-b.svg:
        * svg/W3C-SVG-1.1/linking-a-04-t.svg:
        * svg/W3C-SVG-1.1/linking-uri-02-b.svg:
        * svg/W3C-SVG-1.1/linking-uri-03-t.svg:
        * svg/W3C-SVG-1.1/masking-path-04-b.svg:
        * svg/W3C-SVG-1.1/render-groups-01-b.svg:
        * svg/W3C-SVG-1.1/render-groups-03-t.svg:
        * svg/W3C-SVG-1.1/struct-image-01-t.svg:
        * svg/W3C-SVG-1.1/struct-image-02-b.svg:
        * svg/W3C-SVG-1.1/struct-image-03-t.svg:
        * svg/W3C-SVG-1.1/struct-image-05-b.svg:
        * svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
        * svg/W3C-SVG-1.1/text-tref-01-b.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Tue, 6 Dec 2005 06:08:58 +0000 (06:08 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Updating all the SVG tests with their latest post-merger results.
        There are still issues which will prevent these from passing on
        all machines:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4515
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5962

        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
        * svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
        * svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
        * svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-frag-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
        * svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
        * svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
        * svg/custom/fill-update-expected.checksum:
        * svg/custom/fill-update-expected.png:
        * svg/custom/path-bad-data-expected.checksum:
        * svg/custom/path-bad-data-expected.png:
        * svg/custom/path-update-expected.checksum:
        * svg/custom/path-update-expected.png:
        * svg/custom/simpleCDF-expected.checksum:
        * svg/custom/simpleCDF-expected.png:
        * svg/custom/use-forward-refs-expected.checksum:
        * svg/custom/use-forward-refs-expected.png:
        * svg/custom/use-forward-refs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New layout tests for:
justing [Tue, 6 Dec 2005 04:29:56 +0000 (04:29 +0000)]
    New layout tests for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
        REGRESSION: selection keeps growing after double-click
        Also filed as <rdar://problem/4364425>

        Reviewed by darin, harrsion

        * editing/selection/paragraph-granularity-expected.checksum: Added.
        * editing/selection/paragraph-granularity-expected.png: Added.
        * editing/selection/paragraph-granularity-expected.txt: Added.
        * editing/selection/paragraph-granularity.html: Added.
        * editing/selection/word-granularity-expected.checksum: Added.
        * editing/selection/word-granularity-expected.png: Added.
        * editing/selection/word-granularity-expected.txt: Added.
        * editing/selection/word-granularity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
justing [Tue, 6 Dec 2005 04:29:24 +0000 (04:29 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=5936>
        REGRESSION: selection keeps growing after double-click
        Also filed as <rdar://problem/4364425>

        Reviewed by darin, harrison

        Rolled back previous change, simplified expansion, fixed
        adjustForEditableContent to work in cases where start/end are
        distinct from base/extent, renamed m_baseIsStart to m_baseIsFirst.

        Added two new layout tests in editing/selection to test
        modifying selections created with double and triple clicks.

        * khtml/editing/SelectionController.cpp:
        (khtml::SelectionController::SelectionController):
        (khtml::SelectionController::init):
        (khtml::SelectionController::operator=):
        (khtml::SelectionController::expandUsingGranularity):
        (khtml::SelectionController::adjustForEditableContent):
        (khtml::SelectionController::validate):
        * khtml/editing/SelectionController.h:
        * khtml/khtml_part.cpp:
        (KHTMLPart::handleMouseMoveEventSelection):
        (KHTMLPart::khtmlMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Tue, 6 Dec 2005 02:41:47 +0000 (02:41 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        * WebCore.xcodeproj/project.pbxproj: updated paths for SVG move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Tue, 6 Dec 2005 02:16:56 +0000 (02:16 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        * checkout: remove --svg support, SVG is now checked out by default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5747
eseidel [Tue, 6 Dec 2005 02:04:03 +0000 (02:04 +0000)]
Bug #: 5747
Submitted by: eseidel
Reviewed by: timo
        Updated results for KCanvaPath changes:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

        * svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5942, 5943
eseidel [Tue, 6 Dec 2005 01:53:17 +0000 (01:53 +0000)]
Bug #: 5942, 5943
Submitted by: eseidel
Reviewed by: darin
        No test cases possible/necessary.

        Removing unused ForwardingHeaders, as well as header cleanup in SVG
        Fixed KSVG2 files to include proper KDOM headers.
        Fixed KDOM forwarding headers to point to correct khtml headers.
        Added DataRef.h to hold khtml::DataRef.
        Made SVGRenderStyle a DataRef on RenderStyle.
        (Landing two bugs at once as their project file changes intertwine)

        http://bugzilla.opendarwin.org/show_bug.cgi?id=5942
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5943

        * ForwardingHeaders/kdom/DOMString.h:
        * ForwardingHeaders/kdom/KDOMSettings.h:
        * ForwardingHeaders/kdom/cache/KDOMCachedDocument.h:
        * ForwardingHeaders/kdom/cache/KDOMCachedImage.h:
        * ForwardingHeaders/kdom/cache/KDOMCachedObject.h:
        * ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h:
        * ForwardingHeaders/kdom/cache/KDOMCachedScript.h:
        * ForwardingHeaders/kdom/cache/KDOMLoader.h:
        * ForwardingHeaders/kdom/core/AttrImpl.h:
        * ForwardingHeaders/kdom/core/CDFInterface.h: Removed.
        * ForwardingHeaders/kdom/core/DOMImplementationImpl.h:
        * ForwardingHeaders/kdom/core/DOMStringImpl.h:
        * ForwardingHeaders/kdom/core/DocumentImpl.h:
        * ForwardingHeaders/kdom/core/ElementImpl.h:
        * ForwardingHeaders/kdom/core/NodeImpl.h:
        * ForwardingHeaders/kdom/core/XMLElementImpl.h:
        * ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h:
        * ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h:
        * ForwardingHeaders/kdom/css/CSSStyleSelector.h:
        * ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h:
        * ForwardingHeaders/kdom/css/CSSValueImpl.h:
        * ForwardingHeaders/kdom/css/KDOMCSSParser.h:
        * ForwardingHeaders/kdom/css/RGBColorImpl.h:
        * ForwardingHeaders/kdom/events/UIEventImpl.h:
        * ForwardingHeaders/kdom/events/kdomevents.h:
        * ForwardingHeaders/kdom/kdom.h:
        * ForwardingHeaders/ksvg2/KSVGPart.h:
        * ForwardingHeaders/ksvg2/KSVGView.h:
        * WebCore+SVG/KDOMHeaders.h:
        * WebCore+SVG/KDOMStubClasses.h: Removed.
        * WebCore+SVG/kdomcss.h: Removed.
        * WebCore+SVG/kdomls.h: Removed.
        * WebCore+SVG/kdomrange.h: Removed.
        * WebCore+SVG/kdomtraversal.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasTreeDebug.cpp:
        (writeStyle):
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::drawMarkersIfNeeded):
        * khtml/rendering/DataRef.h: Added.
        (khtml::DataRef::DataRef):
        (khtml::DataRef::~DataRef):
        (khtml::DataRef::operator->):
        (khtml::DataRef::get):
        (khtml::DataRef::access):
        (khtml::DataRef::init):
        (khtml::DataRef::operator=):
        (khtml::DataRef::operator == ):
        (khtml::DataRef::operator != ):
        * khtml/rendering/render_style.cpp:
        (m_affectedByAttributeSelectors):
        (RenderStyle::RenderStyle):
        (RenderStyle::inheritFrom):
        (RenderStyle::~RenderStyle):
        (RenderStyle::operator==):
        (RenderStyle::inheritedNotEqual):
        (RenderStyle::diff):
        * khtml/rendering/render_style.h:
        (khtml::RenderStyle::svgStyle):
        (khtml::RenderStyle::accessSVGStyle):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (KDOM::CSSStyleSelector::applySVGProperty):
        * ksvg2/css/SVGRenderStyle.cpp:
        (SVGRenderStyle::SVGRenderStyle):
        (SVGRenderStyle::inheritedNotEqual):
        * ksvg2/css/SVGRenderStyle.h:
        (KSVG::SVGRenderStyle::operator!=):
        * ksvg2/css/SVGRenderStyleDefs.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/svg/SVGAElementImpl.cpp:
        (SVGAElementImpl::defaultEventHandler):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        * ksvg2/svg/SVGClipPathElementImpl.cpp:
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.h:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.h:
        * ksvg2/svg/SVGFEFloodElementImpl.cpp:
        (SVGFEFloodElementImpl::filterEffect):
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        * ksvg2/svg/SVGURIReferenceImpl.h:
        * ksvg2/svg/SVGZoomAndPanImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Dec 2005 01:46:39 +0000 (01:46 +0000)]
    Reviewed by Darin Adler.

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]):
        one more tweak: moved jumpToSelection: to be validated the same way as
        centerSelectionInVisibleArea:, since it now calls the same code. Might not
        make a difference in any real code, but you never know.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5747
eseidel [Tue, 6 Dec 2005 01:23:25 +0000 (01:23 +0000)]
Bug #: 5747
Submitted by: eseidel
Reviewed by: timo
        5 test cases updated, no additional tests needed.

        Removed KCPathData, KCPathDataList and KCanvasUserData.
        Added KCanvasPath and KCanvasPathQuartz instead.
        Updated methods to expect KCanvasPath* types and use RefPtr.
        Removed no longer needed KCPathDataList -> KCanvasUserData routines
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

        * WebCore.xcodeproj/project.pbxproj: added KCanvasPath(Quartz)
        * kcanvas/KCanvasCreator.cpp:
        (KCanvasCreator::createRoundedRectangle): updated to KCanvasPath*
        (KCanvasCreator::createRectangle): updated to KCanvasPath*
        (KCanvasCreator::createEllipse): updated to KCanvasPath*
        (KCanvasCreator::createCircle): updated to KCanvasPath*
        (KCanvasCreator::createLine): updated to KCanvasPath*
        * kcanvas/KCanvasCreator.h:
        * kcanvas/KCanvasItem.cpp:
        (RenderPath::Private::Private): updated to KCanvasPath*
        (RenderPath::~RenderPath):
        (RenderPath::changePath):
        (RenderPath::path): updated to KCanvasPath*
        * kcanvas/KCanvasItem.h:
        * kcanvas/KCanvasMatrix.cpp:
        * kcanvas/KCanvasMatrix.h:
        * kcanvas/KCanvasPath.cpp:
        (operator<<): updated to call device->stringForPath()
        * kcanvas/KCanvasPath.h:
        (KCanvasPath::~KCanvasPath):
        (KCClipDataList::addPath): updated to KCanvasPath*
        * kcanvas/KCanvasResources.cpp:
        (KCanvasClipper::addClipData): updated to KCanvasPath*
        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasTypes.h:
        * kcanvas/device/KRenderingDevice.cpp:
        (KCanvasCommonArgs::path): updated to KCanvasPath*
        (KCanvasCommonArgs::setPath): updated to KCanvasPath*
        (KRenderingDevice::KRenderingDevice):
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::paint): updated to KCanvasPath*
        (KCanvasItemQuartz::bboxForPath): updated to KCanvasPath*
        (KCanvasItemQuartz::hitsPath): updated to KCanvasPath*
        * kcanvas/device/quartz/KCanvasPathQuartz.h: Added.
        (KCanvasPathQuartz::cgPath): updated to KCanvasPath*
        * kcanvas/device/quartz/KCanvasPathQuartz.mm: Added.
        (KCanvasPathQuartz::KCanvasPathQuartz): added
        (KCanvasPathQuartz::~KCanvasPathQuartz): added
        (KCanvasPathQuartz::isEmpty): added
        (KCanvasPathQuartz::moveTo): added
        (KCanvasPathQuartz::lineTo): added
        (KCanvasPathQuartz::curveTo): added
        (KCanvasPathQuartz::closeSubpath): added
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (KCanvasClipperQuartz::applyClip): updated to KCanvasPath*
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceQuartz::createPath): added
        (KRenderingDeviceQuartz::stringForPath): updated to KCanvasPath*
        (KRenderingDeviceQuartz::createItem): updated to KCanvasPath*
        * kcanvas/device/quartz/QuartzSupport.h:
        * kcanvas/device/quartz/QuartzSupport.mm:
        * ksvg2/svg/SVGCircleElementImpl.cpp:
        (SVGCircleElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGCircleElementImpl.h:
        * ksvg2/svg/SVGClipPathElementImpl.cpp:
        (SVGClipPathElementImpl::canvasResource): updated to KCanvasPath*
        * ksvg2/svg/SVGEllipseElementImpl.cpp:
        (KSVG::SVGEllipseElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGEllipseElementImpl.h:
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::createRenderer): updated to KCanvasPath*
        * ksvg2/svg/SVGLineElementImpl.cpp:
        (SVGLineElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGLineElementImpl.h:
        * ksvg2/svg/SVGPathElementImpl.cpp:
        (KSVG::SVGPathElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGPathElementImpl.h:
        * ksvg2/svg/SVGPolygonElementImpl.cpp:
        (SVGPolygonElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGPolygonElementImpl.h:
        * ksvg2/svg/SVGPolylineElementImpl.cpp:
        (SVGPolylineElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGPolylineElementImpl.h:
        * ksvg2/svg/SVGRectElementImpl.cpp:
        (SVGRectElementImpl::toPathData): updated to KCanvasPath*
        * ksvg2/svg/SVGRectElementImpl.h:
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        (SVGStyledElementImpl::createRenderer): updated to KCanvasPath*
        (SVGStyledElementImpl::updateCanvasItem): updated to KCanvasPath*
        (SVGStyledElementImpl::pushAttributeContext):
        * ksvg2/svg/SVGStyledElementImpl.h:
        (KSVG::SVGStyledElementImpl::toPathData): updated to KCanvasPath*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Tue, 6 Dec 2005 01:10:37 +0000 (01:10 +0000)]
    Reviewed by Eric.

        - fixed <rdar://problem/4364374> Denver Regression: ModBlog.com user menus don't stay visible due to extra mouseout events (5668)
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5668

        * khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Do the same "skip text node"
        logic for the "oldUnder" variable as for the "targetNode" variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Dec 2005 00:23:49 +0000 (00:23 +0000)]
    Reviewed by Darin Adler.

        Fixed a problem from the patch to fix <rdar://problem/4365690>. After that checkin, KWQKHTMLPart was
        inadvertently left with both centerSelectionInVisibleArea() and centerSelectionInVisibleArea() const.

        * kwq/KWQKHTMLPart.h:
        renamed centerSelectionInVisibleArea() to revealSelection(). This is the method that
        was named jumpToSelection() before my recent checkin.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::findString):
        call revealSelection() rather than centerSelectionInVisibleArea(); this restores the
        behavior from before my recent checkin.
        (KWQKHTMLPart::revealSelection):
        renamed from centerSelectionInVisibleArea()
        (KWQKHTMLPart::advanceToNextMisspelling):
        call revealSelection() rather than centerSelectionInVisibleArea(); this restores the
        behavior from before my recent checkin.

        * kwq/WebCoreBridge.h:
        removed one of the two declarations of centerSelectionInVisibleArea()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Dec 2005 00:14:08 +0000 (00:14 +0000)]
    Reviewed by Darin Adler.

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]):
        removed double handling of centerSelectionInVisibleArea

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
sullivan [Mon, 5 Dec 2005 23:48:32 +0000 (23:48 +0000)]
    Reviewed by Tim Omernick.

        - WebKit part of fix for
        <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView jumpToSelection:]):
        Reimplement jumpToSelection: to call centerSelectionInVisibleArea:, and added a comment explaining why
        jumpToSelection: exists at all. Note that centerSelectionInVisibleArea: was already implemented here; it
        was added as part of HTML editing implementation without us realizing that it was the API replacement
        for jumpToSelection:.
        (-[WebHTMLView validateUserInterfaceItem:]):
        validate centerSelectionInVisibleArea: the same way we validate jumpToSelection: (we should have done
        this when centerSelectionInVisibleArea: was implemented)

        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView centerSelectionInVisibleArea:]):
        new method, same code that jumpToSelection: used to have
        (-[WebPDFView jumpToSelection:]):
        now calls centerSelectionInVisibleArea:, and there's now a comment about why it exists at all.
        (-[WebPDFView validateUserInterfaceItem:]):
        validate centerSelectionInVisibleArea: the same way we validate jumpToSelection:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Harrison, John Sullivan.
tomernic [Mon, 5 Dec 2005 22:31:15 +0000 (22:31 +0000)]
    Reviewed by Dave Harrison, John Sullivan.

<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)

I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
initialized.  Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
has been "committed" (inserted into the view hierarchy).

My fix is to ensure that the plugin is initialized where we previously would have created that second
WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.

        * Plugins.subproj/WebPluginDocumentView.m:
        (-[WebPluginDocumentView setDataSource:]):
Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy.
We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView
has been committed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
sullivan [Mon, 5 Dec 2005 22:19:10 +0000 (22:19 +0000)]
    Reviewed by Tim Omernick.

        Removed some dead code I happened to stumble across. No test cases added.

        * kwq/KWQTimer.h:
        removed unused immediateSingleShotOnMainThread()
        * kwq/KWQTimer.mm:
        removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget
        that was used to implement it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
sullivan [Mon, 5 Dec 2005 22:01:30 +0000 (22:01 +0000)]
    Reviewed by Tim Omernick.

        - WebCore part of fix for
        <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)

        No behavioral changes here. This patch just eliminates the name "jumpToSelection" in favor of
        "centerSelectionInVisibleArea" to match WebKit and AppKit.

        * kwq/KWQKHTMLPart.h:
        eliminate jumpToSelection(); add centerSelectionInVisibleArea()

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::findString):
        use centerSelectionInVisibleArea() instead of jumpToSelection()
        (KWQKHTMLPart::centerSelectionInVisibleArea):
        renamed from jumpToSelection
        (KWQKHTMLPart::advanceToNextMisspelling):
        use centerSelectionInVisibleArea() instead of jumpToSelection()

        * kwq/WebCoreBridge.h:
        eliminate jumpToSelection; add centerSelectionInVisibleArea
        * kwq/WebCoreBridge.mm:
        eliminate jumpToSelection. We had been implementing both jumpToSelection and
        centerSelectionInVisibleArea here, but jumpToSelection now has no more callers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
vicki [Mon, 5 Dec 2005 17:40:57 +0000 (17:40 +0000)]
    Reviewed by John.

- fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links
in wacky frameset at directory.apple.com

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to
accommodate any scrolling

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update test results to match Anders's last checkin.
ggaren [Sun, 4 Dec 2005 23:45:49 +0000 (23:45 +0000)]
    Update test results to match Anders's last checkin.

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-04 Anders Carlsson <andersca@mac.com>
andersca [Sun, 4 Dec 2005 23:30:29 +0000 (23:30 +0000)]
2005-12-04  Anders Carlsson  <andersca@mac.com>

        Reviewed by Geoffrey.

        Add new tests for
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

        * fast/js/test-propertyIsEnumerable-expected.txt: Added.
        * fast/js/test-propertyIsEnumerable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-04 Anders Carlsson <andersca@mac.com>
andersca [Sun, 4 Dec 2005 23:28:56 +0000 (23:28 +0000)]
2005-12-04  Anders Carlsson  <andersca@mac.com>

        Reviewed by Geoffrey.

        - Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

        * kjs/object.cpp:
        (KJS::ObjectImp::canPut):
        Refactor to use getPropertyAttributes.

        (KJS::ObjectImp::propertyIsEnumerable):
        New function which checks if a property is enumerable.

        (KJS::ObjectImp::getPropertyAttributes):
        * kjs/object.h:
        Add getPropertyAttributes and propertyIsEnumerable.

        * kjs/object_object.cpp:
        (ObjectPrototypeImp::ObjectPrototypeImp):
        (ObjectProtoFuncImp::callAsFunction):
        * kjs/object_object.h:
        (KJS::ObjectProtoFuncImp::):
        Add propertyIsEnumerable to the Object prototype.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5930
eseidel [Sun, 4 Dec 2005 23:14:27 +0000 (23:14 +0000)]
Bug #: 5930
Submitted by: eseidel
Reviewed by: ggaren
        No additional test cases needed (or possible).

        Further dom/* cleanup, also removing extra forwarding headers
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5930

        * ForwardingHeaders/dom/dom2_views.h: Removed.
        * ForwardingHeaders/dom/dom_core.h: Removed.
        * ForwardingHeaders/dom/dom_doc.h: Removed.
        * ForwardingHeaders/dom/dom_element.h: Removed.
        * ForwardingHeaders/dom/dom_misc.h: Removed.
        * ForwardingHeaders/dom/dom_text.h: Removed.
        * ForwardingHeaders/dom/dom_xml.h: Removed.
        * ForwardingHeaders/dom/html_base.h: Removed.
        * ForwardingHeaders/dom/html_block.h: Removed.
        * ForwardingHeaders/dom/html_document.h: Removed.
        * ForwardingHeaders/dom/html_element.h: Removed.
        * ForwardingHeaders/dom/html_form.h: Removed.
        * ForwardingHeaders/dom/html_head.h: Removed.
        * ForwardingHeaders/dom/html_image.h: Removed.
        * ForwardingHeaders/dom/html_inline.h: Removed.
        * ForwardingHeaders/dom/html_list.h: Removed.
        * ForwardingHeaders/dom/html_misc.h: Removed.
        * ForwardingHeaders/dom/html_object.h: Removed.
        * ForwardingHeaders/dom/html_table.h: Removed.
        * ForwardingHeaders/ecma/kjs_css.h: Removed.
        * ForwardingHeaders/ecma/kjs_html.h: Removed.
        * ForwardingHeaders/ecma/kjs_html.lut.h: Removed.
        * ForwardingHeaders/ecma/kjs_views.h: Removed.
        * ForwardingHeaders/ecma/kjs_views.lut.h: Removed.
        * ForwardingHeaders/ecma/kjs_window.h: Removed.
        * ForwardingHeaders/html/dtd.h: Removed.
        * ForwardingHeaders/kdom/KDOMPart.h: Removed.
        * ForwardingHeaders/kdom/KDOMView.h: Removed.
        * ForwardingHeaders/kdom/core/NodeListImpl.h: Removed.
        * ForwardingHeaders/kdom/css/CSSMediaRuleImpl.h: Removed.
        * ForwardingHeaders/kdom/css/CSSRuleImpl.h: Removed.
        * ForwardingHeaders/kdom/css/CSSRuleListImpl.h: Removed.
        * ForwardingHeaders/kdom/css/cssproperties.h: Removed.
        * ForwardingHeaders/kdom/css/cssvalues.h: Removed.
        * ForwardingHeaders/kdom/events/DocumentEventImpl.h: Removed.
        * ForwardingHeaders/kdom/parser/KDOMDocumentBuilder.h: Removed.
        * ForwardingHeaders/kdomcssproperties.h: Removed.
        * ForwardingHeaders/kdomcssvalues.h: Removed.
        * ForwardingHeaders/kinstance.h: Removed.
        * ForwardingHeaders/kjs/identifier.h: Removed.
        * ForwardingHeaders/kjs/property_map.h: Removed.
        * ForwardingHeaders/kjs/protected_object.h: Removed.
        * ForwardingHeaders/kjs/scope_chain.h: Removed.
        * ForwardingHeaders/kjs/ustring.h: Removed.
        * ForwardingHeaders/kjs/value.h: Removed.
        * ForwardingHeaders/ksvg2/svg/svgtags.h: Removed.
        * ForwardingHeaders/q3intdict.h: Removed.
        * ForwardingHeaders/q3memarray.h: Removed.
        * ForwardingHeaders/q3ptrcollection.h: Removed.
        * ForwardingHeaders/q3ptrdict.h: Removed.
        * ForwardingHeaders/qcstring.h: Removed.
        * ForwardingHeaders/qcursor.h: Removed.
        * ForwardingHeaders/qintdict.h: Removed.
        * ForwardingHeaders/qpair.h: Removed.
        * ForwardingHeaders/qprinter.h: Removed.
        * ForwardingHeaders/qptrcollection.h: Removed.
        * ForwardingHeaders/qsize.h: Removed.
        * ForwardingHeaders/qsortedlist.h: Removed.
        * ForwardingHeaders/qvaluevector.h: Removed.
        * ForwardingHeaders/xml/dom_positioniterator.h: Removed.
        * khtml/css/css_ruleimpl.cpp:
        * khtml/dom/css_value.h:
        * khtml/dom/dom2_events.cpp:
        * khtml/dom/dom2_events.h:
        * khtml/dom/dom2_range.h:
        * khtml/dom/dom2_traversal.cpp:
        * khtml/dom/dom_exception.h:
        * khtml/dom/dom_node.h:
        * khtml/dom/dom_string.cpp:
        * khtml/ecma/kjs_traversal.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-04 Anders Carlsson <andersca@mac.com>
andersca [Sun, 4 Dec 2005 20:55:47 +0000 (20:55 +0000)]
2005-12-04  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin and Geoffrey.

        - Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=4194>

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::setFocusNode):
        Don't send onblur to a node if m_inDetach is true.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::detach):
        Set m_inDetach to true while calling RenderObject::destroy.

        * khtml/xml/dom_nodeimpl.h:
  Add m_inDetach flag.

        * manual-tests/onblur-remove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5929
eseidel [Sun, 4 Dec 2005 13:08:19 +0000 (13:08 +0000)]
Bug #: 5929
Submitted by: eseidel
Reviewed by: No review needed, WebCore+SVG build fix only.
        I broke the WebCore+SVG build when removing dom_misc.h, fixing.

        * WebCore+SVG/KDOMHeaders.h: remove reference to dom_misc.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5929
eseidel [Sun, 4 Dec 2005 12:43:15 +0000 (12:43 +0000)]
Bug #: 5929
Submitted by: eseidel
Reviewed by: darin
        No functionality changes, no test cases possible or necessary.

        Removed dom_misc.* and changed to use Shared instead of DOMShared.
        Also removed FilterNode typedef, now using NodeImpl* directly.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5929

        * WebCore.xcodeproj/project.pbxproj:
        * khtml/css/css_base.h:
        * khtml/dom/dom2_events.h:
        * khtml/dom/dom2_traversal.cpp:
        (DOM::NodeFilterCondition::acceptNode):
        * khtml/dom/dom2_traversal.h:
        * khtml/dom/dom_exception.h:
        * khtml/dom/dom_misc.cpp: Removed.
        * khtml/dom/dom_misc.h: Removed.
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::JSNodeFilterCondition::acceptNode):
        * khtml/ecma/kjs_traversal.h:
        * kwq/DOM.mm:
        (ObjCNodeFilterCondition::acceptNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 5877
eseidel [Sun, 4 Dec 2005 11:35:09 +0000 (11:35 +0000)]
Bug #: 5877
Submitted by: eseidel
Reviewed by: mjs
        No test cases needed/possible, only removing dead code.

        Remove rotten #ifdef'd code from the source:
        APPLE_CHANGES & KHTML_NO_CPLUSPLUS_DOM
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

        * khtml/dom/css_rule.h:
        (DOM::CSSRule::):
        * khtml/dom/css_stylesheet.h:
        * khtml/dom/css_value.h:
        (DOM::CSSValue::):
        (DOM::CSSPrimitiveValue::):
        * khtml/dom/dom2_events.cpp:
        (DOM::EventListener::handleEventImpl):
        * khtml/dom/dom2_events.h:
        (DOM::Event::):
        (DOM::EventException::):
        (DOM::MutationEvent::):
        * khtml/dom/dom2_range.h:
        (DOM::RangeException::):
        (DOM::Range::):
        * khtml/dom/dom2_traversal.cpp:
        * khtml/dom/dom2_traversal.h:
        (DOM::NodeFilter::):
        * khtml/dom/dom_exception.h:
        (DOM::DOMException::):
        * khtml/dom/dom_misc.cpp:
        (DOM::DomShared::~DomShared):
        * khtml/dom/dom_misc.h:
        (DOM::DomShared::deleteMe):
        * khtml/dom/dom_node.h:
        (DOM::Node::):
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::JSNodeFilterCondition::acceptNode):
        * khtml/khtml_part.cpp:
        (KHTMLPart::stopLoading):
        * khtml/khtml_part.h:
        * khtml/khtmlview.cpp:
        (KHTMLView::viewportMousePressEvent):
        (KHTMLView::focusNextPrevNode):
        * kwq/KWQKConfigBase.h:
        * kwq/KWQKHTMLPageCache.h:
        * kwq/KWQPointArray.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Layout test for <rdar://problem/4364302> leftmargin and topmargin
ggaren [Sun, 4 Dec 2005 01:22:26 +0000 (01:22 +0000)]
    Layout test for <rdar://problem/4364302> leftmargin and topmargin
        should match marginwidth and marginheight respectively

        * fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
        * fast/block/positioning/leftmargin-topmargin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ggaren [Sun, 4 Dec 2005 01:21:09 +0000 (01:21 +0000)]
    Reviewed by Darin.

        Fixed <rdar://problem/4364302> leftmargin and topmargin should match
        marginwidth and marginheight respectively

        Layout test added:
        positioning/leftmargin-topmargin-expected.txt
        positioning/leftmargin-topmargin.html

        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::parseMappedAttribute): Merged
        leftmargin/marginwidth, topmargin/marginheight

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New layout tests for:
justing [Sun, 4 Dec 2005 00:53:19 +0000 (00:53 +0000)]
    New layout tests for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
        Selection based in an editable block can extend outside

        Reviewed by darin

        * editing/selection/expanding-selections-expected.checksum: Added.
        * editing/selection/expanding-selections-expected.png: Added.
        * editing/selection/expanding-selections-expected.txt: Added.
        * editing/selection/expanding-selections.html: Added.
        * editing/selection/expanding-selections2-expected.checksum: Added.
        * editing/selection/expanding-selections2-expected.png: Added.
        * editing/selection/expanding-selections2-expected.txt: Added.
        * editing/selection/expanding-selections2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
justing [Sun, 4 Dec 2005 00:48:05 +0000 (00:48 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=5856>
        Selection based in an editable block can extend outside

        validate() used to do expansion of the selection.  The expansion
        itself wasn't validated, so it could create a selection
        that extended outside an editable area.  Also m_base and
        m_extent weren't updated with the results of the expansion.

        Reviewed by darin

        Layout tests added:
        * editing/selection/expanding-selections
        * editing/selection/expanding-selections2

        * khtml/editing/SelectionController.cpp:
        (khtml::SelectionController::expandUsingGranularity): Does the expansion.
        (khtml::SelectionController::validate): Removed the granularity parameter.
        * khtml/editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin.
ggaren [Sun, 4 Dec 2005 00:32:34 +0000 (00:32 +0000)]
    Reviewed by Kevin.

        Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
        show up wrong size (with scroll bars)

        We had the wrong default features for new windows. The IE rule is:
        all features except for channelmode and fullscreen default to YES, but
        if the user specifies a feature string, all features default to NO.
        (There is no public standard that applies to this method.)

        <http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

        No test case because testing requires a call to window.open, which
        DumpRenderTree can't simulate.

        * khtml/ecma/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        * kwq/KWQKPartsBrowserExtension.h:
        (KParts::WindowArgs::WindowArgs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDidn't mean to commit this.
andersca [Sat, 3 Dec 2005 20:26:01 +0000 (20:26 +0000)]
Didn't mean to commit this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-01 Anders Carlsson <andersca@mac.com>
andersca [Sat, 3 Dec 2005 20:16:43 +0000 (20:16 +0000)]
2005-12-01  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=4340>
        Safari not supporting disabled in multi select option tag.

        * khtml/rendering/render_form.cpp:
        (RenderSelect::updateFromElement):
        Update calls to append functions to set the enabled state of items.

        * kwq/KWQComboBox.h:
        (QComboBox::appendItem):
        (QComboBox::appendGroupLabel):
        (QComboBox::appendSeparator):
        Add enabled parameter to append functions.

        * kwq/KWQComboBox.mm:
        (QComboBox::QComboBox):
        Don't autoenable menu items on the popup button since that's handled
        manually now.

        (QComboBox::setTitle):
        Set enabled state on menu items.

        (QComboBox::appendItem):
        Add enabled parameter.

        * kwq/KWQListBox.h:
        (KWQListBoxItem::KWQListBoxItem):
        Add enabled variable to item struct.

        (QListBox::appendItem):
        (QListBox::appendGroupLabel):
        Add enabled parameter to append functions.

        * kwq/KWQListBox.mm:
        (QListBox::appendItem):
        Add enabled parameter.

        (-[KWQTableView tableView:shouldSelectRow:]):
        Only select the row if the item is enabled.

        (-[KWQTableView drawRow:clipRect:]):
        Draw using the disabled color if the row is disabled.

        * manual-tests/disabled-option-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImproved ChangeLog comment.
darin [Sat, 3 Dec 2005 16:56:44 +0000 (16:56 +0000)]
Improved ChangeLog comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #:
bdakin [Sat, 3 Dec 2005 02:33:53 +0000 (02:33 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Sat, 3 Dec 2005 01:44:16 +0000 (01:44 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: tim h
        Added ending newlines to files missing them.

        * ForwardingHeaders/kjs/property_map.h:
        * khtml/rendering/break_lines.cpp:
        * khtml/xbl/xbl_binding.h:
        * khtml/xbl/xbl_protobinding.h:
        * khtml/xbl/xbl_protohandler.h:
        * kwq/DOM-compat.h:
        * kwq/KWQTextUtilities.h:
        * kwq/WebCoreKeyboardAccess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Sat, 3 Dec 2005 01:32:43 +0000 (01:32 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.
        SVG Build fix after SharedPtr -> RefPtr changes.

        * ksvg2/events/SVGZoomEventImpl.h:
        * ksvg2/svg/SVGAElementImpl.h:
        * ksvg2/svg/SVGAnimateColorElementImpl.h:
        * ksvg2/svg/SVGAnimateTransformElementImpl.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::parseMappedAttribute):
        * ksvg2/svg/SVGAnimationElementImpl.h:
        * ksvg2/svg/SVGCircleElementImpl.h:
        * ksvg2/svg/SVGClipPathElementImpl.h:
        * ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
        * ksvg2/svg/SVGCursorElementImpl.h:
        * ksvg2/svg/SVGEllipseElementImpl.h:
        * ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
        * ksvg2/svg/SVGFEBlendElementImpl.h:
        * ksvg2/svg/SVGFEColorMatrixElementImpl.h:
        * ksvg2/svg/SVGFEComponentTransferElementImpl.h:
        * ksvg2/svg/SVGFECompositeElementImpl.h:
        * ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
        * ksvg2/svg/SVGFEFloodElementImpl.h:
        * ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
        * ksvg2/svg/SVGFEImageElementImpl.h:
        * ksvg2/svg/SVGFELightElementImpl.h:
        * ksvg2/svg/SVGFEMergeNodeElementImpl.h:
        * ksvg2/svg/SVGFEOffsetElementImpl.h:
        * ksvg2/svg/SVGFESpecularLightingElementImpl.h:
        * ksvg2/svg/SVGFETileElementImpl.h:
        * ksvg2/svg/SVGFETurbulenceElementImpl.h:
        * ksvg2/svg/SVGFilterElementImpl.h:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
        * ksvg2/svg/SVGFitToViewBoxImpl.h:
        * ksvg2/svg/SVGGradientElementImpl.h:
        * ksvg2/svg/SVGHelper.h:
        (KSVG::lazy_create):
        * ksvg2/svg/SVGImageElementImpl.h:
        * ksvg2/svg/SVGLineElementImpl.h:
        * ksvg2/svg/SVGLinearGradientElementImpl.h:
        * ksvg2/svg/SVGMarkerElementImpl.h:
        * ksvg2/svg/SVGPathElementImpl.h:
        * ksvg2/svg/SVGPatternElementImpl.h:
        * ksvg2/svg/SVGPolyElementImpl.h:
        * ksvg2/svg/SVGRadialGradientElementImpl.h:
        * ksvg2/svg/SVGRectElementImpl.h:
        * ksvg2/svg/SVGSVGElementImpl.h:
        * ksvg2/svg/SVGStopElementImpl.h:
        * ksvg2/svg/SVGStyleElementImpl.h:
        * ksvg2/svg/SVGStyledElementImpl.h:
        * ksvg2/svg/SVGStyledTransformableElementImpl.h:
        * ksvg2/svg/SVGTestsImpl.h:
        * ksvg2/svg/SVGTextContentElementImpl.h:
        * ksvg2/svg/SVGTextPositioningElementImpl.h:
        * ksvg2/svg/SVGTransformImpl.h:
        * ksvg2/svg/SVGURIReferenceImpl.h:
        * ksvg2/svg/SVGUseElementImpl.h:
        * ksvg2/svg/SVGViewElementImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Sat, 3 Dec 2005 01:30:26 +0000 (01:30 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none needed.
        No review needed.

        * ksvg2/scripts/make_names.pl: Add standard license header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 3 Dec 2005 01:06:45 +0000 (01:06 +0000)]
LayoutTests:

        Updating test for latest changes in:
        <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * fast/replaced/width100percent.html:

WebCore:

        Reviewed by Hyatt.

        - fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

        We're backing out the fix for <rdar://problem/3952698>.
        With the new button implementation, the buttons will
        not overlap for the telia webmail case.  We may need to address
        the minWidth behavior for other elements at a later time.

        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::calcMinMaxWidth):
        (RenderTextArea::calcMinMaxWidth):
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY (OOPS!).
ggaren [Fri, 2 Dec 2005 23:19:39 +0000 (23:19 +0000)]
    Reviewed by NOBODY (OOPS!).

        Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
        cannot tab to next input field after tab-completing an email address in
        gmail.

        Implemented work-around to conceal the selectionEnd property if the
        document is on the gmail domain. We'll remove this code once Google
        fixes its site.

        No testcase because this is a domain-specific work-around.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::textAreaGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4345030>
justing [Fri, 2 Dec 2005 22:53:31 +0000 (22:53 +0000)]
    <rdar://problem/4345030>
        Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

        Before checking the navigation policy for a request, the request is compared
        against the last checked request.  If the two are the same, no check is done.
        In the bug, the two requests are identical except for the boolean on
        NSURLRequests that tells Foundation to support multipart loads for that request.
        One request was the one that was used to start servicing "Back" operation, and
        the second was being used to start loading the page (it needed to be reloaded
        because it was the result of a form submission). Set the boolean on all
        NSURLRequests, not just one's that are about to be used to start a load.

        Reviewed by harrison

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _startLoading:]):
        (-[WebDataSource initWithRequest:]):
        * WebView.subproj/WebDataSourcePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago SVG build fix, not reviewed.
mjs [Fri, 2 Dec 2005 22:44:27 +0000 (22:44 +0000)]
    SVG build fix, not reviewed.

- land the ksvg2 part of my SharedPtr --> RefPtr change, which I
forgot about before.

        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (KSVG::SVGTimer::notifyAll):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
        (SVGAnimateTransformElementImpl::handleTimerEvent):
        (SVGAnimateTransformElementImpl::parseTransformValue):
        (SVGAnimateTransformElementImpl::initialMatrix):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::parseMappedAttribute):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::~SVGDocumentImpl):
        (SVGDocumentImpl::dispatchZoomEvent):
        (SVGDocumentImpl::dispatchScrollEvent):
        (SVGDocumentImpl::dispatchKeyEvent):
        (SVGDocumentImpl::executeScripts):
        (SVGDocumentImpl::dispatchUIEvent):
        (SVGDocumentImpl::dispatchMouseEvent):
        * ksvg2/svg/SVGLocatableImpl.cpp:
        (SVGLocatableImpl::getCTM):
        (SVGLocatableImpl::getScreenCTM):
        * ksvg2/svg/SVGMarkerElementImpl.cpp:
        (SVGMarkerElementImpl::canvasResource):
        * ksvg2/svg/SVGPatternElementImpl.cpp:
        (SVGPatternElementImpl::drawPatternContentIntoTile):
        (SVGPatternElementImpl::getCTM):
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (SVGSVGElementImpl::viewport):
        (SVGSVGElementImpl::checkIntersection):
        (SVGSVGElementImpl::checkEnclosure):
        (SVGSVGElementImpl::getCTM):
        (SVGSVGElementImpl::getScreenCTM):
        * ksvg2/svg/SVGScriptElementImpl.cpp:
        (SVGScriptElementImpl::executeScript):
        * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
        (SVGStyledTransformableElementImpl::updateLocalTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Fri, 2 Dec 2005 21:17:59 +0000 (21:17 +0000)]
    Reviewed by Darin.

- fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad
doesn't work for nested framesets at gmail.com

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::passWheelEventToChildWidget):
        * manual-tests/resources/lorem-text.html: Added.
        * manual-tests/resources/nestedframesets.html: Added.
        * manual-tests/scrolling-nestedframesets.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
vicki [Fri, 2 Dec 2005 21:13:55 +0000 (21:13 +0000)]
    Reviewed by Darin.

- fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad
doesn't work for nested framesets at gmail.com

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::passWheelEventToChildWidget):
        * manual-tests/resources/lorem-text.html: Added.
        * manual-tests/resources/nestedframesets.html: Added.
        * manual-tests/scrolling-nestedframesets.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by rjw.
aboule [Fri, 2 Dec 2005 20:58:02 +0000 (20:58 +0000)]
    Reviewed by rjw.

        Added #else for XSLT ifdef to make sure switch case
        doesn't fall through when feature turned off.

* khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd layout test for new clipping behavior.
hyatt [Fri, 2 Dec 2005 20:32:58 +0000 (20:32 +0000)]
Add layout test for new clipping behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for overflow clipping bug when a positioned element is
hyatt [Fri, 2 Dec 2005 20:23:41 +0000 (20:23 +0000)]
Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

        Reviewed by beth

        fast/clip/018.html

        * khtml/rendering/render_layer.cpp:
        (khtml::RenderLayer::calculateClipRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2005-12-02 Anders Carlsson <andersca@mac.com>
andersca [Fri, 2 Dec 2005 09:19:05 +0000 (09:19 +0000)]
2005-12-02  Anders Carlsson  <andersca@mac.com>

        Reviewed by Timothy.

        * WebCore.xcodeproj/project.pbxproj:
        Remove KWQRefPtr.h

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::paint):
        Remove a call to notNull here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
thatcher [Fri, 2 Dec 2005 09:13:26 +0000 (09:13 +0000)]
    Reviewed by Maciej.

        Cache the lastItem and lastItemOffset for fast retrieval of the
        same index or indeicies greater than lastItemOffset. Also cache
        the length. Like other node lists these cached values rest when the
        subtree under the root node changes.

        * khtml/xml/dom_nodeimpl.cpp:
        (ChildNodeListImpl::length): Use cachedLength when possible.
        (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by justin
justing [Fri, 2 Dec 2005 09:00:52 +0000 (09:00 +0000)]
    Reviewed by justin

        Updated/added tests for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
        contentEditable div cannot be edited if it starts out with empty or <p/>

        * editing/deleting/delete-3775172-fix-expected.txt: Fixed.
        * editing/inserting/editing-empty-divs-expected.checksum: Added.
        * editing/inserting/editing-empty-divs-expected.png: Added.
        * editing/inserting/editing-empty-divs-expected.txt: Added.
        * editing/inserting/editing-empty-divs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
justing [Fri, 2 Dec 2005 09:00:29 +0000 (09:00 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=4003>
        contentEditable div cannot be edited if it starts out with empty or <p/>

        Reviewed/tweaked/landed by justin

        * khtml/editing/visible_position.cpp:
        (khtml::VisiblePosition::init): A position at the original block
        shouldn't be considered 'outside' the original block.
        (khtml::hasRenderedChildrenWithHeight): Added.
        (khtml::VisiblePosition::isCandidate): A block flow element with
        rendered children may be considered a candidate for a visible
        position, as long as its children do not have a positive height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove duplicate entry
andersca [Fri, 2 Dec 2005 08:33:47 +0000 (08:33 +0000)]
Remove duplicate entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Fri, 2 Dec 2005 03:48:15 +0000 (03:48 +0000)]
JavaScriptCore:

        Reviewed by Tim Hatcher.

- removed deprecated reset, isNull and nonNull methods

        * kxmlcore/RefPtr.h:

WebCore:

        Reviewed by Tim Hatcher.

- removed deprecated reset, isNull and nonNull methods
- replaced use of KWQRefPtr with RefPtr

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::toBoolean):
        (KJS::DOMNode::toPrimitive):
        (KJS::DOMNode::toString):
        (KJS::DOMNodeList::toPrimitive):
        * khtml/ecma/kjs_html.cpp:
        (KJS::OptionConstructorImp::construct):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty):
        (KJS::XMLHttpRequest::putValueProperty):
        (KJS::XMLHttpRequest::mark):
        (KJS::XMLHttpRequest::changeState):
        (KJS::XMLHttpRequest::open):
        * khtml/editing/edit_command.cpp:
        * khtml/html/html_tableimpl.cpp:
        (DOM::HTMLTableSectionElementImpl::insertRow):
        (DOM::HTMLTableSectionElementImpl::deleteRow):
        (DOM::HTMLTableRowElementImpl::insertCell):
        (DOM::HTMLTableRowElementImpl::deleteCell):
        * khtml/khtml_part.cpp:
        (KHTMLPart::scheduleScript):
        (KHTMLPart::executeScheduledScript):
        (KHTMLPart::clear):
        (KHTMLPart::khtmlMousePressEvent):
        * khtml/khtmlview.cpp:
        (KHTMLViewPrivate::reset):
        (KHTMLView::updateDragAndDrop):
        (KHTMLView::cancelDragAndDrop):
        (KHTMLView::performDragAndDrop):
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::updateFirstLetter):
        * khtml/rendering/render_text.cpp:
        (RenderText::setStyle):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::prepareMouseEvent):
        * khtml/xml/dom_elementimpl.cpp:
        (NamedAttrMapImpl::setNamedItem):
        * khtml/xml/dom_nodeimpl.h:
        (DOM::NodeImpl::MouseEvent::MouseEvent):
        * kwq/KWQArrayImpl.h:
        * kwq/KWQArrayImpl.mm:
        (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate):
        (KWQArrayImpl::duplicate):
        (KWQArrayImpl::detach):
        * kwq/KWQClipboard.mm:
        (KWQClipboard::setDragImage):
        (KWQClipboard::dragNSImage):
        * kwq/KWQFontMetrics.h:
        * kwq/KWQFontMetrics.mm:
        (QFontMetricsPrivate::QFontMetricsPrivate):
        (QFontMetrics::setFont):
        (QFontMetrics::ascent):
        (QFontMetrics::descent):
        (QFontMetrics::lineSpacing):
        (QFontMetrics::xHeight):
        (QFontMetrics::width):
        (QFontMetrics::floatWidth):
        (QFontMetrics::checkSelectionPoint):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::paint):
        (KWQKHTMLPart::openURLFromPageCache):
        (KWQKHTMLPart::khtmlMousePressEvent):
        (KWQKHTMLPart::khtmlMouseMoveEvent):
        (KWQKHTMLPart::dragSourceMovedTo):
        (KWQKHTMLPart::dragSourceEndedAt):
        (KWQKHTMLPart::mouseDown):
        (KWQKHTMLPart::snapshotDragImage):
        (KWQKHTMLPart::markMisspellings):
        (KWQKHTMLPart::setMarkedTextRange):
        * kwq/KWQMapImpl.h:
        * kwq/KWQMapImpl.mm:
        (KWQMapImpl::KWQMapPrivate::KWQMapPrivate):
        (KWQMapImpl::copyOnWrite):
        (KWQMapImpl::swap):
        * kwq/KWQRefPtr.h: Removed.
        * kwq/KWQRegExp.h:
        * kwq/KWQRegExp.mm:
        (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate):
        (QRegExp::operator=):
        * kwq/KWQValueListImpl.h:
        * kwq/KWQValueListImpl.mm:
        (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate):
        (KWQValueListImpl::operator=):
        (KWQValueListImpl::copyOnWrite):
        * kwq/KWQVariant.h:
        * kwq/KWQVariant.mm:
        (QVariant::QVariantPrivate::):
        (QVariant::QVariantPrivate::QVariantPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
thatcher [Thu, 1 Dec 2005 23:50:36 +0000 (23:50 +0000)]
    Reviewed by Beth.

        Another fix for 4098083 to apply to sliders.

        <rdar://problem/4098083> REGRESSION (125-312): crash
        in [KWQTableView resignFirstResponder] selecting from JS menu
        (car4you.at, etc.)

        Since it is possible that a render widget's eventFilterObject
        has been destroyed even though the render widget is still ref-ed,
        we need to nil-check the eventFilterObject before we use it to get
        the eventFilter.

        * kwq/KWQSlider.mm:
        (-[KWQSlider becomeFirstResponder]): Added nil check.
        (-[KWQSlider resignFirstResponder]): Added nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11386 268f45cc-cd09-0410-ab3c-d52691b4dbfc