WebKit-https.git
9 years ago[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
benjamin.poulain@nokia.com [Fri, 25 Mar 2011 17:25:34 +0000 (17:25 +0000)]
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::create):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::initializeGTK):
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
(tst_QGraphicsWKView::loadEmptyPage):
(tst_QGraphicsWKView::loadEmptyUrl):
* UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:
(tst_QWKPage::loadEmptyUrl):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
(WebKit::WebProcessMainQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
benjamin.poulain@nokia.com [Fri, 25 Mar 2011 17:21:41 +0000 (17:21 +0000)]
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
(JSC::Bindings::QtPixmapInstance::valueOf):
* platform/qt/LanguageQt.cpp:
(WebCore::platformDefaultLanguage):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
* plugins/qt/PluginPackageQt.cpp:
(WebCore::initializeGtk):
* plugins/qt/PluginViewQt.cpp:
(WebCore::getPluginDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect project file missing $(WebKitVSPropsRedirectionDir)s
bfulgham@webkit.org [Fri, 25 Mar 2011 16:28:26 +0000 (16:28 +0000)]
Correct project file missing $(WebKitVSPropsRedirectionDir)s
after r81924.

* win/WebKit2.vcproj: Restore lost $(WebKitVSPropsRedirectionDir)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Fri, 25 Mar 2011 16:21:30 +0000 (16:21 +0000)]
2011-03-25  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        rename Node::isContentEditable and all call sites to rendererIsEditable
        https://bugs.webkit.org/show_bug.cgi?id=54290

        This is part of the effort to separate JS API HTMLElement isContentEditable from
        internal Node::rendererIsEditable.

        Code refactoring. No new tests.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        * dom/Document.cpp:
        (WebCore::acceptsEditingFocus):
        * dom/Node.cpp:
        (WebCore::Node::rendererIsEditable):
        (WebCore::Node::shouldUseInputMethod):
        (WebCore::Node::canStartSelection):
        (WebCore::Node::rootEditableElement):
        * dom/Node.h:
        (WebCore::Node::isContentEditable):
        (WebCore::Node::rendererIsEditable):
        (WebCore::Node::rendererIsRichlyEditable):
        * dom/Position.cpp:
        (WebCore::nextRenderedEditable):
        (WebCore::previousRenderedEditable):
        (WebCore::Position::atEditingBoundary):
        (WebCore::Position::parentEditingBoundary):
        (WebCore::Position::upstream):
        (WebCore::Position::downstream):
        (WebCore::Position::isCandidate):
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::isCandidate):
        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::AppendNodeCommand):
        (WebCore::AppendNodeCommand::doApply):
        (WebCore::AppendNodeCommand::doUnapply):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::containsNonEditableRegion):
        (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        (WebCore::enclosingDeletableElement):
        * editing/DeleteFromTextNodeCommand.cpp:
        (WebCore::DeleteFromTextNodeCommand::doApply):
        (WebCore::DeleteFromTextNodeCommand::doUnapply):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removeNode):
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange):
        (WebCore::Editor::markMisspellingsOrBadGrammar):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * editing/FormatBlockCommand.cpp:
        (WebCore::enclosingBlockToSplitTreeTo):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertIntoTextNodeCommand.cpp:
        (WebCore::InsertIntoTextNodeCommand::doApply):
        (WebCore::InsertIntoTextNodeCommand::doUnapply):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
        (WebCore::InsertNodeBeforeCommand::doApply):
        (WebCore::InsertNodeBeforeCommand::doUnapply):
        * editing/JoinTextNodesCommand.cpp:
        (WebCore::JoinTextNodesCommand::doApply):
        (WebCore::JoinTextNodesCommand::doUnapply):
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::doApply):
        (WebCore::MergeIdenticalElementsCommand::doUnapply):
        * editing/RemoveNodeCommand.cpp:
        (WebCore::RemoveNodeCommand::doApply):
        (WebCore::RemoveNodeCommand::doUnapply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::setSelectionFromNone):
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::executeApply):
        (WebCore::SplitElementCommand::doUnapply):
        * editing/SplitTextNodeCommand.cpp:
        (WebCore::SplitTextNodeCommand::doApply):
        (WebCore::SplitTextNodeCommand::doUnapply):
        (WebCore::SplitTextNodeCommand::doReapply):
        * editing/SplitTextNodeContainingElementCommand.cpp:
        (WebCore::SplitTextNodeContainingElementCommand::doApply):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):
        * editing/WrapContentsInDummySpanCommand.cpp:
        (WebCore::WrapContentsInDummySpanCommand::doUnapply):
        (WebCore::WrapContentsInDummySpanCommand::doReapply):
        * editing/htmlediting.cpp:
        (WebCore::highestEditableRoot):
        (WebCore::lowestEditableAncestor):
        (WebCore::isEditablePosition):
        (WebCore::isRichlyEditablePosition):
        (WebCore::firstEditablePositionAfterPositionInRoot):
        (WebCore::extendRangeToWrappingNodes):
        (WebCore::enclosingNodeWithTag):
        (WebCore::enclosingNodeOfType):
        (WebCore::highestEnclosingNodeOfType):
        (WebCore::canMergeLists):
        * editing/visible_units.cpp:
        (WebCore::previousLeafWithSameEditability):
        (WebCore::previousLinePosition):
        (WebCore::nextLeafWithSameEditability):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::supportsFocus):
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::setActive):
        (WebCore::HTMLAnchorElement::canStartSelection):
        (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::supportsFocus):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::supportsFocus):
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::contentEditable):
        * html/HTMLElement.h:
        * page/DragController.cpp:
        (WebCore::DragController::operationForLoad):
        (WebCore::DragController::canProcessDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::EventHandler::selectCursor):
        * page/FocusController.cpp:
        (WebCore::relinquishesEditingFocus):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::isContentEditable):
        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointRespectingEditingBoundaries):
        (WebCore::RenderBlock::hasLineIfEmpty):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::addOverflowFromInlineChildren):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::canBeProgramaticallyScrolled):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition):
        * rendering/RootInlineBox.cpp:
        (WebCore::isEditableLeaf):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::supportsFocus):
2011-03-25  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        rename Node::isContentEditable and all call sites to rendererIsEditable
        https://bugs.webkit.org/show_bug.cgi?id=54290

        This is part of the effort to separate JS API HTMLElement isContentEditable from
        internal Node::rendererIsEditable.

        * src/WebNode.cpp:
        (WebKit::WebNode::isContentEditable):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::setComposition):
        (WebKit::WebViewImpl::confirmComposition):
2011-03-25  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        rename Node::isContentEditable and all call sites to rendererIsEditable
        https://bugs.webkit.org/show_bug.cgi?id=54290

        This is part of the effort to separate JS API HTMLElement isContentEditable from
        internal Node::rendererIsEditable.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-03-25  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        rename Node::isContentEditable and all call sites to rendererIsEditable
        https://bugs.webkit.org/show_bug.cgi?id=54290

        This is part of the effort to separate JS API HTMLElement isContentEditable from
        internal Node::rendererIsEditable.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 25 Mar 2011 16:11:57 +0000 (16:11 +0000)]
2011-03-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        Crash when a wbr element is inserted inside mroot
        https://bugs.webkit.org/show_bug.cgi?id=56352

        * mathml/wbr-in-mroot-crash-expected.txt: Added.
        * mathml/wbr-in-mroot-crash.html: Added.
2011-03-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        Crash when a wbr element is inserted inside mroot
        https://bugs.webkit.org/show_bug.cgi?id=56352

        Test: mathml/wbr-in-mroot-crash.html

        * rendering/mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first
        child, instead of just assuming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe
benjamin.poulain@nokia.com [Fri, 25 Mar 2011 15:28:09 +0000 (15:28 +0000)]
[Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe
https://bugs.webkit.org/show_bug.cgi?id=56098

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-03-25
Reviewed by Ariya Hidayat.

Need to link advapi32.lib for jsc.exe since wtf/OSRandomSource.cpp uses the Win32 Crypto API

* jsc.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Fri, 25 Mar 2011 15:10:32 +0000 (15:10 +0000)]
2011-03-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML Viewer: extensions can't render original XML
        https://bugs.webkit.org/show_bug.cgi?id=56263

        Added source xml to transformed document, renamed onload function.

        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt:
        * fast/encoding/dumpAsText/utf-16-no-bom-expected.txt:
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt:
        * http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt:
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt:
        * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
        * http/tests/xmlviewer/dumpAsText/xul-expected.txt:
        * platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt:
        * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
        * svg/hixie/error/dumpAsText/004-expected.txt:
        * svg/hixie/error/dumpAsText/005-expected.txt:
        * xmlviewer/extensions-api-expected.txt: Added.
        * xmlviewer/extensions-api.html_disabled: Added.
        * xmlviewer/resources/sample.xml: Added.
2011-03-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML Viewer: extensions can't render original XML
        https://bugs.webkit.org/show_bug.cgi?id=56263

        Added source xml to transformed document, renamed onload function.

        * xml/XMLTreeViewer.cpp:
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
        * xml/XMLViewer.xsl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Fri, 25 Mar 2011 15:02:31 +0000 (15:02 +0000)]
2011-03-25  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Get rid of the invalid string conversion with ::fromAscii()
        https://bugs.webkit.org/show_bug.cgi?id=57102

        Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/qt/CookieJarQt.cpp:
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Fri, 25 Mar 2011 14:17:02 +0000 (14:17 +0000)]
2011-03-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        SVG <use> element performance improvement
        https://bugs.webkit.org/show_bug.cgi?id=57077

        Add a manual test case which is from
        http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg
        for svg <use> element performance test.

        * PageLoad/svg/files/Sierpinski_carpet_6.svg: Added.
        * PageLoad/svg/svg.pltsuite:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Fri, 25 Mar 2011 14:15:16 +0000 (14:15 +0000)]
2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] The keyboard shortcuts during fullscreen playback do not work.
        https://bugs.webkit.org/show_bug.cgi?id=57095

        We need to explicitely set the focus on the widget in order to receive the keyboard events.

        * WebCoreSupport/FullScreenVideoWidget.cpp:
        (WebCore::FullScreenVideoWidget::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove no-longer-necessary Windows results
aroben@apple.com [Fri, 25 Mar 2011 13:58:15 +0000 (13:58 +0000)]
Remove no-longer-necessary Windows results

r81925 made Windows match Mac on this test. New Windows results were checked in, but they
were generated using the wrong fonts. Since we match Mac now, we don't need Windows-specific
results at all.

* platform/win/fast/css/percentage-non-integer-expected.checksum: Removed.
* platform/win/fast/css/percentage-non-integer-expected.png: Removed.
* platform/win/fast/css/percentage-non-integer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 13:39:16 +0000 (13:39 +0000)]
2011-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81953.
        http://trac.webkit.org/changeset/81953
        https://bugs.webkit.org/show_bug.cgi?id=57096

        "inspector test breakage: part 2/2" (Requested by apavlov on
        #webkit).

        * inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
        * inspector/styles/get-set-stylesheet-text.html: Removed.
        * inspector/styles/styles-new-API.html:
2011-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81953.
        http://trac.webkit.org/changeset/81953
        https://bugs.webkit.org/show_bug.cgi?id=57096

        "inspector test breakage: part 2/2" (Requested by apavlov on
        #webkit).

        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getAllStyles):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleSheet):
        (WebInspector.CSSStyleSheet.prototype.setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 12:48:17 +0000 (12:48 +0000)]
2011-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81954.
        http://trac.webkit.org/changeset/81954
        https://bugs.webkit.org/show_bug.cgi?id=57094

        "inspector test breakage: part 1/2" (Requested by apavlov on
        #webkit).

        * inspector/styles/resources/get-set-stylesheet-text.css: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 25 Mar 2011 12:00:42 +0000 (12:00 +0000)]
2011-03-25  Mikhail Naganov  <mnaganov@chromium.org>

        Roll forward Chromium deps to r79379 to pick up V8 3.2.4.2.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 25 Mar 2011 11:59:02 +0000 (11:59 +0000)]
2011-03-25  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, build fix. Add file missing from r81953

        * inspector/styles/resources/get-set-stylesheet-text.css: Added.
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-15 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 25 Mar 2011 11:11:32 +0000 (11:11 +0000)]
2011-03-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
        https://bugs.webkit.org/show_bug.cgi?id=56310

        * inspector/styles/get-set-stylesheet-text-expected.txt: Added.
        * inspector/styles/get-set-stylesheet-text.html: Added.
        * inspector/styles/resources/get-set-stylesheet-text.css: Added.
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        * inspector/styles/styles-new-API.html:
2011-03-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
        https://bugs.webkit.org/show_bug.cgi?id=56310

        Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
        "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
        by CSSAgent.getStyleSheet() anymore.

        Test: inspector/styles/get-set-stylesheet-text.html

        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getAllStyleSheets):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleSheet):
        (WebInspector.CSSStyleSheet.prototype.setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Priit Laes <plaes@plaes.org>
commit-queue@webkit.org [Fri, 25 Mar 2011 10:33:21 +0000 (10:33 +0000)]
2011-03-25  Priit Laes  <plaes@plaes.org>

        Reviewed by Martin Robinson.

        [GTK] [PATCH] Avoid critical warning when free-ing list of plugins
        https://bugs.webkit.org/show_bug.cgi?id=57025

        * webkit/webkitwebplugindatabase.cpp:
        (webkit_web_plugin_database_plugins_list_free):
        Use regular check and return instead of g_return_if_fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 25 Mar 2011 10:05:24 +0000 (10:05 +0000)]
2011-03-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extension server should not convert all resources to HAR when there are no extensions.
        https://bugs.webkit.org/show_bug.cgi?id=57044

        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
        (WebInspector.ExtensionServer.prototype._hasSubscribers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Fri, 25 Mar 2011 09:19:55 +0000 (09:19 +0000)]
2011-03-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        SVG <use> element performance improvement
        https://bugs.webkit.org/show_bug.cgi?id=57077

        SVG <use> element was expanding nesting <use> and <symbol> elements
        in an inefficient way. After it expanded an <use> or a <symbol>
        element it would restart expanding from the shadow tree root.
        This behavior was leading about 160 millions of calls to
        expandUseElementInShadowTree or expandSymbolElementInShadowTree for
        a single shadow tree which is illustrated by
        http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg.
        But the effective calls, which really expand <use> or <symbol>
        elements, were about 5200; others were passing-by calls, which are
        recursively down to the children.

        This patch is altering the expanding path to reduce the passing-by
        calls. It will expand elements in sibling chain where there is an
        effective call, because the effective call replaces element which is
        expanded and the replacement results lose of the sibling chain of
        the replaced on the upper recursion stack. With this patch the
        passing-by calls are reduced from about 160 millions to about 30
        thousands.

        No functionality change, no new tests.

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::expandUseElementsInShadowTree):
        (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 25 Mar 2011 09:19:22 +0000 (09:19 +0000)]
2011-03-25  Sergio Villar Senin  <svillar@igalia.com>

        Rebaseline GTK+ tests results after r81887

        * platform/gtk/editing/pasteboard/5065605-expected.txt:
        * platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-011-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 25 Mar 2011 08:29:15 +0000 (08:29 +0000)]
2011-03-25  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [WK2] Consider .c files in the generate-forwarding-headers script
        https://bugs.webkit.org/show_bug.cgi?id=56680

        * Scripts/generate-forwarding-headers.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-25 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 08:18:34 +0000 (08:18 +0000)]
2011-03-25  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        Adds a regression test for keygen autofocus.
        https://bugs.webkit.org/show_bug.cgi?id=57091

        * fast/forms/autofocus-keygen-expected.txt: Added.
        * fast/forms/autofocus-keygen.html: Added.
2011-03-25  Dominic Cooney  <dominicc@google.com>

        Reviewed by Kent Tamura.

        Makes keygen support autofocus attribute.
        https://bugs.webkit.org/show_bug.cgi?id=57091

        Test: fast/forms/autofocus-keygen.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 25 Mar 2011 07:29:28 +0000 (07:29 +0000)]
2011-03-24  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Add tests for HeapSnapshot module.
        https://bugs.webkit.org/show_bug.cgi?id=56835

        * http/tests/inspector/heap-snapshot-test.js: Added.
        (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
        (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
        (initialize_HeapSnapshotTest):
        * inspector/profiler/heap-snapshot-expected.txt: Added.
        * inspector/profiler/heap-snapshot.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 25 Mar 2011 07:17:45 +0000 (07:17 +0000)]
2011-03-24  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of testing framework.
        https://bugs.webkit.org/show_bug.cgi?id=57006

        * http/tests/inspector/profiler-test.js: Added.
        (initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
        (initialize_ProfilerTest.InspectorTest.startProfilerTest):
        (initialize_ProfilerTest.InspectorTest.completeProfilerTest):
        (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite.runner):
        (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite):
        (initialize_ProfilerTest):
        * inspector/cpu-profiler-profiling-expected.txt: Removed.
        * inspector/cpu-profiler-profiling.html: Removed.
        * inspector/profiler/cpu-profiler-profiling-expected.txt: Added.
        * inspector/profiler/cpu-profiler-profiling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 25 Mar 2011 06:56:57 +0000 (06:56 +0000)]
2011-03-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Add sound / mute button to MediaControl UI
        https://bugs.webkit.org/show_bug.cgi?id=56726

        Add sound / mute button to MediaControl UI.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::edjeGroupFromFormType):
        (WebCore::RenderThemeEfl::emitMediaButtonSignal):
        (WebCore::RenderThemeEfl::paintMediaMuteButton):
        * platform/efl/RenderThemeEfl.h:
2011-03-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Add sound / mute button to MediaControl UI
        https://bugs.webkit.org/show_bug.cgi?id=56726

        Add sound / mute button to MediaControl UI.

        * DefaultTheme/default.edc:
        * DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Added.
        * DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Added.
        * DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 25 Mar 2011 06:35:51 +0000 (06:35 +0000)]
2011-03-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        Introduce WTF HexNumber.h
        https://bugs.webkit.org/show_bug.cgi?id=56099

        Introduce a set of functions that ease converting from a bye or a number to a hex string,
        replacing several of these conversions and String::format("%x") usages all over WebCore.

        * GNUmakefile.am: Add HexNumber.h to build.
        * JavaScriptCore.exp: Export StringBuilder::reserveCapacity.
        * JavaScriptCore.gypi: Add HexNumber.h to build.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export StringBuilder::reserveCapacity.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Add HexNumber.h to build.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * wtf/CMakeLists.txt: Ditto.
        * wtf/HexNumber.h: Added.
        (WTF::Internal::hexDigitsForMode): Internal helper.
        (WTF::appendByteAsHex): Free function, that appends a byte as hex string into a destination.
        (WTF::placeByteAsHex): Ditto, but places the result using *foo++ = '..' or foo[index++] = '..'
        (WTF::appendUnsignedAsHex): Free function, that appends a number as hex string into a destination.
2011-03-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        Introduce WTF HexNumber.h
        https://bugs.webkit.org/show_bug.cgi?id=56099

        Introduce a set of functions that ease converting from a bye or a number to a hex string,
        replacing several of these conversions and String::format("%x") usages all over WebCore.

        * ForwardingHeaders/wtf/HexNumber.h: Added.
        * css/CSSOMUtils.cpp:
        (WebCore::serializeCharacterAsCodePoint):
        * css/CSSParser.cpp:
        (WebCore::quoteCSSString):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::createReadableStringFromBinary):
        * platform/FileSystem.cpp:
        (WebCore::encodeForFileName):
        * platform/KURL.cpp:
        (WebCore::appendEscapedChar):
        * platform/UUID.cpp:
        (WebCore::createCanonicalUUIDString):
        * platform/graphics/Color.cpp:
        (WebCore::Color::serialized):
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::encodeStringAsFormData):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::quoteAndEscapeNonPrintables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 25 Mar 2011 06:31:52 +0000 (06:31 +0000)]
2011-03-24  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, rebaseline Chromium test results for Mac Leopard.

        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
        * platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
jer.noble@apple.com [Fri, 25 Mar 2011 06:27:50 +0000 (06:27 +0000)]
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81939.
        http://trac.webkit.org/changeset/81939
        https://bugs.webkit.org/show_bug.cgi?id=57084

        Rolling out 81939, as it's causing a number of app cache test
        failures. (Requested by jernoble on #webkit).

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] A couple build fixes after recent changes.
kevino@webkit.org [Fri, 25 Mar 2011 06:05:11 +0000 (06:05 +0000)]
[wx] A couple build fixes after recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-23 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 25 Mar 2011 05:33:53 +0000 (05:33 +0000)]
2011-03-23  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Application Cache should save audio/ and video/ mime types as flat files
        https://bugs.webkit.org/show_bug.cgi?id=53784
        <rdar://problem/8932473>

        No new tests.

        Initialize the AppCache Total size quotas with the values for WebKitPreferences
        upon startup.

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 25 Mar 2011 05:06:30 +0000 (05:06 +0000)]
2011-03-24  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Roben.

        Implement layoutTestController.setAutoFilled in DRT on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56828

        * platform/chromium/fast/forms/input-autofilled-expected.txt: Removed.
        * platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed.
        * platform/win/fast/forms/input-autofilled-expected.txt: Removed.
        * platform/win/fast/forms/reset-autofilled-expected.txt: Removed.
2011-03-24  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Roben.

        Implement layoutTestController.setAutoFilled in DRT on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56828

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAutofilled): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57073
slewis@apple.com [Fri, 25 Mar 2011 04:10:59 +0000 (04:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57073
Rework the AtomicHTMLConstructor to reserve space for attributes based on the size of the attribute list.
Saves 1.5 MB on Membuster.

Reviewed by Geoff Garen.

No new tests because there was no change in behavior.  Current tests pass.

* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 25 Mar 2011 03:23:33 +0000 (03:23 +0000)]
2011-03-24  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Rebaseline Chromium test results for fast/css/percentage-non-integer.html.

        * platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.png:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 02:54:18 +0000 (02:54 +0000)]
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * fast/images/embed-image-plugins-disabled.html: Removed.
        * platform/mac/fast/images/embed-image-expected.checksum:
        * platform/mac/fast/images/embed-image-expected.png:
        * platform/mac/fast/images/embed-image-expected.txt:
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.checksum: Removed.
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.png: Removed.
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.txt: Removed.
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::HTMLEmbedElement):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::parametersForPlugin):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
        (WebCore::HTMLPlugInImageElement::isImageType):
        (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
        * html/HTMLPlugInImageElement.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::objectContentType):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::defaultObjectContentType):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::resourceWillUsePlugin):
        (WebCore::SubframeLoader::requestObject):
        (WebCore::SubframeLoader::shouldUsePlugin):
        * loader/SubframeLoader.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::objectContentType):
        * src/FrameLoaderClientImpl.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::objectContentType):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::objectContentType):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::objectContentType):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::objectContentType):
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::objectContentType):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebFrame.cpp:
        (WebFrame::objectContentType):
        * WebFrame.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::objectContentType):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::objectContentType):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81916 and r81917.
        http://trac.webkit.org/changeset/81916
        http://trac.webkit.org/changeset/81917
        https://bugs.webkit.org/show_bug.cgi?id=57071

        broke a test on platforms that do not have QuickTime installed
        (Requested by estes on #webkit).

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::objectContentType):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 25 Mar 2011 02:34:30 +0000 (02:34 +0000)]
2011-03-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Eliminate Node::dispatchGenericEvent.
        https://bugs.webkit.org/show_bug.cgi?id=57045

        No functional change, covered by existing tests.

        * dom/Node.cpp:
        (WebCore::Node::dispatchEvent): Combined with the body of dispatchGenericEvent,
            removed unnecessary extra refs and a stale comment.
        * dom/Node.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent): Changed to use dispatchEvent.
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::dispatchEvent): Ditto. The code here still
            works thanks to SVG-aware retargeting in Node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 25 Mar 2011 02:13:36 +0000 (02:13 +0000)]
2011-03-24  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        web audio: Properly sample-rate convert audio assets in chromium port
        https://bugs.webkit.org/show_bug.cgi?id=56980

        No new tests since audio API is not yet implemented.

        * WebCore.gypi:
        * platform/audio/AudioBus.cpp:
        (WebCore::AudioBus::createBySampleRateConverting):
        (WebCore::AudioBus::createByMixingToMono):
        * platform/audio/AudioBus.h:
        * platform/audio/HRTFKernel.cpp:
        (WebCore::extractAverageGroupDelay):
        (WebCore::HRTFKernel::HRTFKernel):
        * platform/audio/SincResampler.cpp:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::AudioBus::loadPlatformResource):
        (WebCore::createBusFromInMemoryAudioFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Min Qin <qinmin@google.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 02:09:03 +0000 (02:09 +0000)]
2011-03-24  Min Qin  <qinmin@google.com>

        Reviewed by James Robinson.

        Allow WebMediaPlayerClient to notify MediaPlayer that the playback state has changed

        https://bugs.webkit.org/show_bug.cgi?id=56837

        * public/WebMediaPlayerClient.h:
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::playbackStateChanged):
        * src/WebMediaPlayerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Vincent Scheib <scheib@chromium.org>
scheib@chromium.org [Fri, 25 Mar 2011 01:57:07 +0000 (01:57 +0000)]
2011-03-24  Vincent Scheib  <scheib@chromium.org>

        Update Chromium baselines for 81887

        * platform/chromium-win/editing/pasteboard/5065605-expected.txt:
        * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57069
beidson@apple.com [Fri, 25 Mar 2011 01:34:50 +0000 (01:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57069
Add WKIconDatabase api to the project files, and expose accessor on WKContext.

Reviewed by Darin Adler.

Project file stuffs:
* GNUmakefile.am:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

* Shared/API/c/WKBase.h:
* UIProcess/API/C/WKAPICast.h:

* UIProcess/API/C/WKContext.cpp:
(WKContextGetIconDatabase):
* UIProcess/API/C/WKContext.h:

* UIProcess/API/C/WKIconDatabase.cpp: Added.
(WKIconDatabaseGetTypeID):
* UIProcess/API/C/WKIconDatabase.h: Added.

* UIProcess/WebContext.h:
(WebKit::WebContext::iconDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-23 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 25 Mar 2011 01:29:20 +0000 (01:29 +0000)]
2011-03-23  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Get rid of WEB_TEXT_CHECKING_RESULT_IS_A_STRUCT since it&apos;s not needed anymore
        https://bugs.webkit.org/show_bug.cgi?id=56955

        * DEPS:
        * public/WebTextCheckingResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Bill Budge <bbudge@chromium.org>
dimich@chromium.org [Fri, 25 Mar 2011 01:10:38 +0000 (01:10 +0000)]
2011-03-24  Bill Budge  <bbudge@chromium.org>

        Reviewed by Eric Seidel.

        Change a forward declaration of WebURLLoaderOptions to struct to prevent a build break in Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57064

        No tests. Exposes no new functionality.

        * public/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Rik Cabanier <cabanier@adobe.com>
commit-queue@webkit.org [Fri, 25 Mar 2011 01:09:19 +0000 (01:09 +0000)]
2011-03-24  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56829

        * platform/win/fast/css/percentage-non-integer-expected.checksum:
        * platform/win/fast/css/percentage-non-integer-expected.png:
        * platform/win/fast/css/percentage-non-integer-expected.txt:
2011-03-24  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56829

        Test: fast/css/percentage-non-integer.html

        * platform/Length.h:
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        (WebCore::Length::calcFloatValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild correction.
bfulgham@webkit.org [Fri, 25 Mar 2011 01:08:21 +0000 (01:08 +0000)]
Build correction.

Disable the CA Layer stuff when building with Cairo.

* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Mar 2011 00:22:21 +0000 (00:22 +0000)]
2011-03-24  Mihai Parparita  <mihaip@chromium.org>

        Add Chromium Snow Leopard baselines for fast/css/bidi-override-in-anonymous-block.html.

        * platform/chromium-mac-leopard/fast/css/bidi-override-in-anonymous-block-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum.
        * platform/chromium-mac-leopard/fast/css/bidi-override-in-anonymous-block-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png.
        * platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum:
        * platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction.
bfulgham@webkit.org [Fri, 25 Mar 2011 00:18:18 +0000 (00:18 +0000)]
Unreviewed build correction.

Correct vsprops file for Debug variant of the CFLite build.
Disable a CFNETWORK-specific test when building for CFLite.

* TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Mar 2011 00:17:08 +0000 (00:17 +0000)]
2011-03-24  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        [Chromium] Vertical Japanese text is not displayed on Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=56962

        Pixel rebaselines after r80582 (vertical text was shifted by one pixel
        vertical).

        Make Snow Leopard check added by r80740 into a runtime check for
        Chromium, since it uses the same binary on both Leopard and Snow Leopard.

        * platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
        * platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
        * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
        * platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
        * platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
        * platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
        * platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
        * platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png:
        * platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
        * platform/chromium-mac/fast/dynamic/text-combine-expected.checksum:
        * platform/chromium-mac/fast/dynamic/text-combine-expected.png:
        * platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
        * platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
        * platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
        * platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
        * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
        * platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
        * platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
        * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
        * platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/border-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/broken-ideographic-font-expected.checksum:
        * platform/mac/fast/blockflow/broken-ideographic-font-expected.png:
        * platform/mac/fast/blockflow/japanese-lr-selection-expected.checksum:
        * platform/mac/fast/blockflow/japanese-lr-selection-expected.png:
        * platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/mac/fast/blockflow/japanese-lr-text-expected.png:
        * platform/mac/fast/blockflow/japanese-rl-selection-expected.checksum:
        * platform/mac/fast/blockflow/japanese-rl-selection-expected.png:
        * platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
        * platform/mac/fast/blockflow/japanese-rl-text-expected.png:
        * platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
        * platform/mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
        * platform/mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
        * platform/mac/fast/blockflow/vertical-align-table-baseline-expected.png:
        * platform/mac/fast/blockflow/vertical-baseline-alignment-expected.checksum:
        * platform/mac/fast/blockflow/vertical-baseline-alignment-expected.png:
        * platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
        * platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
        * platform/mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
        * platform/mac/fast/repaint/japanese-rl-selection-clear-expected.png:
        * platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
        * platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
        * platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
        * platform/mac/fast/ruby/base-shorter-than-text-expected.checksum:
        * platform/mac/fast/ruby/base-shorter-than-text-expected.png:
        * platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
        * platform/mac/fast/text/justify-ideograph-vertical-expected.png:
2011-03-24  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        [Chromium] Vertical Japanese text is not displayed on Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=56962

        Make Snow Leopard check added by r80740 into a runtime check for
        Chromium, since it uses the same binary on both Leopard and Snow Leopard.

        * platform/graphics/mac/FontMac.mm:
        (WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
        (WebCore::showGlyphsWithAdvances):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57058
beidson@apple.com [Thu, 24 Mar 2011 23:58:35 +0000 (23:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57058
Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation

Reviewed by Sam Weinig.

../WebCore:

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL): Only add the DocumentLoader to the set if it's non-zero.
(WebCore::IconDatabase::IconDatabase): Add more logging.
(WebCore::IconDatabase::performURLImport): Dispatch the "didFinishURLImport" client callback using the following 3 methods.
(WebCore::FinishedURLImport::FinishedURLImport):
(WebCore::FinishedURLImport::performWork):
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):

* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): Expose a PassOwnPtr<> creator.

* WebCore.exp.in:

../WebKit2:

* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::setDatabasePath): Create a new WebCore::IconDatabase and open it to this path.
(WebKit::WebIconDatabase::retainIconForPageURL): Actually retain the url, using the impl.
(WebKit::WebIconDatabase::releaseIconForPageURL): Actually release the url, using the impl.
(WebKit::WebIconDatabase::setIconURLForPageURL): Actually set the url, using the impl.
(WebKit::WebIconDatabase::setIconDataForIconURL): Actually set the data, using the impl.
(WebKit::WebIconDatabase::getLoadDecisionForIconURL): Actually ask for a load decision to call back with.
(WebKit::WebIconDatabase::performImport):
(WebKit::WebIconDatabase::didImportIconURLForPageURL):
(WebKit::WebIconDatabase::didImportIconDataForPageURL):
(WebKit::WebIconDatabase::didChangeIconForPageURL):
(WebKit::WebIconDatabase::didRemoveAllIcons):
(WebKit::WebIconDatabase::didFinishURLImport): Notify all the pending callbacks what their load decisions
  are now that they're available.
* UIProcess/WebIconDatabase.h:

Add an IconDatabase logging channel:
* Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary):
* Platform/Logging.h:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::setIconDatabasePath): Pass the new path on to the WebIconDatabase, possibly
  opening it.
* UIProcess/WebContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-23 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 24 Mar 2011 23:57:46 +0000 (23:57 +0000)]
2011-03-23  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Application Cache should save audio/ and video/ mime types as flat files
        https://bugs.webkit.org/show_bug.cgi?id=53784
        <rdar://problem/8932473>

        No new tests.

        ApplicationCacheResource::create() now takes an additional "path" parameter.  To facilitate
        extracting this path information, two functions in ApplicationCacheHost have been made public.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveResponse): Pass along new "path" parameter.
        (WebCore::ApplicationCacheGroup::didFail): Ditto.
        * loader/appcache/ApplicationCacheHost.h:
        (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Made public.
        (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource): Made public.
        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::ApplicationCacheResource): Add new "path" parameter.
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::create): Ditto.
        (WebCore::ApplicationCacheResource::path): New accessor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 24 Mar 2011 23:44:17 +0000 (23:44 +0000)]
2011-03-24  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        fix regressions introduced in 81908 - there were a couple of
        code paths that only fired under python 2.5 that I missed.

        Also change a couple of 'python' references to sys.executable
        in order to handle runing test-webkitpy with a binary other than
        something called 'python'.

        https://bugs.webkit.org/show_bug.cgi?id=57063

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/test/cat.py:
        * Scripts/webkitpy/test/echo.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the chromium build.
aestes@apple.com [Thu, 24 Mar 2011 23:37:25 +0000 (23:37 +0000)]
Fix the chromium build.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 24 Mar 2011 23:34:53 +0000 (23:34 +0000)]
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        * fast/images/embed-image-plugins-disabled.html: Added.
        * platform/mac/fast/images/embed-image-expected.checksum:
        * platform/mac/fast/images/embed-image-expected.png:
        * platform/mac/fast/images/embed-image-expected.txt:
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.checksum: Added.
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.png: Added.
        * platform/mac/fast/images/embed-image-plugins-disabled-expected.txt: Added.
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::objectContentType):
        * src/FrameLoaderClientImpl.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::objectContentType):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::objectContentType):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebFrame.cpp:
        (WebFrame::objectContentType):
        * WebFrame.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::objectContentType):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::objectContentType):
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::objectContentType):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::objectContentType):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::objectContentType):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
        QuickTime plug-in in web pages. r70748 removed our mapping of classids
        to MIME types, which causes WebKit to fall back from the object to the
        embed tag when QuickTime is embedded by this script. The script emits
        the following embed tag to embed a QuickTime movie with a poster frame:

        <embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">

        The expectation is that a QuickTime plug-in is instantiated to display the
        poster frame, since QuickTime registers for many common image MIME
        types. This is how Gecko behaves for embed. However, WebKit prefers to
        use its native image rendering for image embeds, in which case no movie
        is played when the poster frame is clicked.

        Fix this by changing embed to check for a plug-in that can handle the
        image type before rendering the image natively. This matches Gecko.

        Test: fast/images/embed-image-plugins-disabled.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parametersForPlugin):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
        (WebCore::HTMLPlugInImageElement::isImageType):
        (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
        * html/HTMLPlugInImageElement.h:
        (WebCore::HTMLPlugInImageElement::preferPluginsForImages):
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::objectContentType):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::defaultObjectContentType):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::resourceWillUsePlugin):
        (WebCore::SubframeLoader::requestPlugin):
        (WebCore::SubframeLoader::requestObject):
        (WebCore::SubframeLoader::shouldUsePlugin):
        * loader/SubframeLoader.h:
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
        https://bugs.webkit.org/show_bug.cgi?id=49016

        Update objectContentType() implementation to handle the
        shouldPreferPlugInsForImages flag.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::objectContentType):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Mike Reed <reed@google.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 23:12:18 +0000 (23:12 +0000)]
2011-03-24  Mike Reed  <reed@google.com>

        Reviewed by James Robinson.

        Move lifetime management of grContext from a global to being
        per-SharedGraphicsContext3D, which correctly is 1:1 with the
        underlying opengl context.
        https://bugs.webkit.org/show_bug.cgi?id=54330

        No new tests. Existing <canvas> tests exercise this:

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        (WebCore::DrawingBuffer::~DrawingBuffer):
        (WebCore::DrawingBuffer::publishToPlatformLayer):
        (WebCore::DrawingBuffer::setGrContext):
        * platform/graphics/gpu/DrawingBuffer.h:
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
        (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
        (WebCore::SharedGraphicsContext3D::getGrContext):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction.
bfulgham@webkit.org [Thu, 24 Mar 2011 22:59:23 +0000 (22:59 +0000)]
Unreviewed build correction.

Add a stub implementation of the TestInvocation dumping logic.
Update project files to reflect new file.

* WebKitTestRunner/cairo: Added.
* WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/win/WebKitTestRunner.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 22:54:05 +0000 (22:54 +0000)]
2011-03-24  Bill Budge  <bbudge@chromium.org>

        Reviewed by Dmitry Titov.

        Add an overloaded WebFrame::createAssociatedURLLoader method that takes WebURLLoaderOptions, so clients can specify CORS options to allow cross-origin requests.
        https://bugs.webkit.org/show_bug.cgi?id=56885

        No new tests. Exposes no new functionality.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::createAssociatedURLLoader):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStart compiling LayerTreeHostCA on Windows
aroben@apple.com [Thu, 24 Mar 2011 22:51:27 +0000 (22:51 +0000)]
Start compiling LayerTreeHostCA on Windows

Fixes <http://webkit.org/b/57060> WebKit2.vcproj should compile LayerTreeHostCA

Reviewed by Anders Carlsson.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: Added.
(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Stubbed out.

* win/WebKit2.vcproj: Added new files. Let VS reorder existing files.

* win/WebKit2Apple.vsprops: Added WebProcess\WebPage\ca to the include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
jer.noble@apple.com [Thu, 24 Mar 2011 22:42:52 +0000 (22:42 +0000)]
Unreviewed build fix.

Remove reference to LayerTreeHostMac.h from WebFullScreenManagerMac.mm.

* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 24 Mar 2011 22:24:22 +0000 (22:24 +0000)]
2011-03-24  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix take 2: Add new symobl.

        (I should have used the EWS bots for this!)

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Mar 2011 22:20:17 +0000 (22:20 +0000)]
2011-03-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Untangle dependency between event ancestor chain computation and InspectorDOMAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57050

        Inspector's list of event listeners does not need to invoke Node::getEventListeners,
        because it simply wants to collect all ancestors and never uses EventContext bits.

        No functional change, covered by existing tests.

        * dom/Node.cpp:
        (WebCore::getEventAncestors): Converted into a static function.
        (WebCore::Node::dispatchGenericEvent): Changed to pass node to getEventAncestors.
        * dom/Node.h: Removed decl, moved EventDispatchBehavior enum inside.
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getEventListenersForNode): Replaced the call
            to getEventAncestors with a simple ancestor traversal loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 24 Mar 2011 22:14:02 +0000 (22:14 +0000)]
2011-03-24  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: clean up worker model defaults. This
        changes the default behavior to 'threads' instead of
        'old-threads', and clarifies that chromium-win-* and
        chromium-mac-leopard are exceptions.

        https://bugs.webkit.org/show_bug.cgi?id=56971

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 24 Mar 2011 22:13:27 +0000 (22:13 +0000)]
2011-03-24  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix take 1: Removed old symobl.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 22:13:13 +0000 (22:13 +0000)]
2011-03-24  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Make FileError and FileException accessible from WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=57041

        Fixed some test expectations related to FileError/FileExcetion and
        exposed while testing this change under Chromium.

        * http/tests/filesystem/workers/resolve-url-sync-expected.txt:
2011-03-24  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Make FileError and FileException accessible from WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=57041

        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Mar 2011 22:11:23 +0000 (22:11 +0000)]
2011-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove legacy version of findPlainText.
        https://bugs.webkit.org/show_bug.cgi?id=57056

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::scopeStringMatches):
        Replace use of legacy findPlainText with a version that
        takes an options parameter.
2011-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove legacy version of findPlainText.
        https://bugs.webkit.org/show_bug.cgi?id=57056

        * editing/TextIterator.cpp:
        * editing/TextIterator.h:
        Remove legacy overload of findPlainText that doesn't
        take an options parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 24 Mar 2011 22:02:57 +0000 (22:02 +0000)]
2011-03-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Ensure that all compilation takes place within a dynamic global object scope
        https://bugs.webkit.org/show_bug.cgi?id=57054
        <rdar://problem/9083011>

        Otherwise, entry to the global object scope might throw away the code
        we just compiled, causing a crash.

        * JavaScriptCore.exp: Updated for signature change.

        * debugger/Debugger.cpp:
        (JSC::evaluateInGlobalCallFrame):
        * debugger/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::evaluate): Removed explicit compilation calls
        here because (a) they took place outside a dynamic global object scope
        and (b) they were redundant.

        * interpreter/CachedCall.h:
        (JSC::CachedCall::CachedCall): Updated for signature change.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct): Declare our dynamic global object
        scope earlier, to ensure that compilation takes place within it.

        * runtime/Completion.cpp:
        (JSC::evaluate): Removed explicit compilation calls here because (a)
        they took place outside a dynamic global object scope and (b) they were
        redundant.

        * runtime/Executable.h:
        (JSC::EvalExecutable::compile):
        (JSC::ProgramExecutable::compile):
        (JSC::FunctionExecutable::compileForCall):
        (JSC::FunctionExecutable::compileForConstruct): Added an ASSERT to
        verify our new invariant that all compilation takes place within a
        dynamic global object scope.

        * runtime/JSGlobalObject.cpp:
        (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
        * runtime/JSGlobalObject.h: Changed the signature of DynamicGlobalObjectScope
        to require a JSGlobalData instead of an ExecState* since it is often
        easier to provide the former, and the latter was not necessary.
2011-03-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Ensure that all compilation takes place within a dynamic global object scope
        https://bugs.webkit.org/show_bug.cgi?id=57054

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
2011-03-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Ensure that all compilation takes place within a dynamic global object scope
        https://bugs.webkit.org/show_bug.cgi?id=57054

        * bindings/js/JSErrorHandler.cpp:
        (WebCore::JSErrorHandler::handleEvent):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent): Updated for signature change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit Mac-specific parts of LayerTreeHostCA into LayerTreeHostCAMac.mm
aroben@apple.com [Thu, 24 Mar 2011 21:50:02 +0000 (21:50 +0000)]
Split Mac-specific parts of LayerTreeHostCA into LayerTreeHostCAMac.mm

Fixes <http://webkit.org/b/57046> LayerTreeHostMac's code should be shareable with Windows

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.mm.
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some Mac-specific code to
LayerTreeHostCAMac.mm.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Wrapped some Mac-specific code in
PLATFORM(MAC).

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
Moved some Mac-specific code to LayerTreeHostCAMac.mm.

(WebKit::LayerTreeHostCA::performScheduledLayerFlush): Renamed from
flushPendingLayerChangesRunLoopObserverCallback. Moved some code from here...
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush): ...to here. Moved some
Mac-specific code to LayerTreeHostCAMac.mm.

* WebProcess/WebPage/ca/LayerTreeHostCA.h: Added new functions, wrapped some Mac-specific
declarations in PLATFORM(MAC).

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: Added.
(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::flushPendingLayerChangesRunLoopObserverCallback):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Code was extracted from LayerTreeHostCA.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename LayerTreeHostMac to LayerTreeHostCA
aroben@apple.com [Thu, 24 Mar 2011 21:49:33 +0000 (21:49 +0000)]
Rename LayerTreeHostMac to LayerTreeHostCA

This is the first step toward sharing code with Windows.

Fixes <http://webkit.org/b/57051>.

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
Updated for rename.

* WebProcess/WebPage/ca/LayerTreeHostCA.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h.
* WebProcess/WebPage/ca/LayerTreeHostCA.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 24 Mar 2011 21:45:04 +0000 (21:45 +0000)]
2011-03-17  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKit2: Cancelling full screen early leaves full screen window up.
        https://bugs.webkit.org/show_bug.cgi?id=56589

        No new tests, as WebKitTestRunner does not currently support the new Full Screen API.

        Notify the UIProcess when it needs to tear down its layer hosting view, turn off
        the background layer when not in accelerated rendering mode and don't swap out
        the web view unnecessarily

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Check before swapping _webView.
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:]): Add the _layerHostingView
            to the full screen window's animationView, not its contentsView.
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Hide the background layer.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): If given a null rootLayer, tell
            the client to exit accelerated mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 24 Mar 2011 21:44:58 +0000 (21:44 +0000)]
2011-03-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        REGRESSION (r79987-r80210): Crash in JSWeakObjectMapClear
        https://bugs.webkit.org/show_bug.cgi?id=55671

        This is no longer necessary, and it seems that with the new weakmap
        model it's simply unsafe, so this reduces it to a no-op.

        * API/JSWeakObjectMapRefPrivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 21:40:43 +0000 (21:40 +0000)]
2011-03-24  John Bauman  <jbauman@chromium.org>

        Reviewed by Kenneth Russell.

        preserveDrawingBuffer=true is ignored
        https://bugs.webkit.org/show_bug.cgi?id=56987

        Add code to the V8 and JSC bindings to support grabbing the value of
        preserveDrawingBuffer from the input context attributes. Also, in
        WebGLRenderingContext use the WebGLContextAttributes that were input
        directly, not those from the GraphicsContext3D which could have been
        changed.

        No new tests, as this can't be tested with DRT. However, this works
        when tested manually.

        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::clearIfComposited):
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text...
enrica@apple.com [Thu, 24 Mar 2011 21:22:21 +0000 (21:22 +0000)]
WebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
https://bugs.webkit.org/show_bug.cgi?id=56975
<rdar://problem/8915066>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Adding support in WebCore to implement readSelectionFromPasteboard
to support Mac OS X services from WebKit2.

* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Added entry point
to call the paste functions with the specified pasteboard.

Source/WebKit2:

Adding missing entry point to support Mac OS X services in WebKit2.

* UIProcess/API/mac/WKView.mm:
(-[WKView readSelectionFromPasteboard:]): Added.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::readSelectionFromPasteboard): Added.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added synchronous
message.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::readSelectionFromPasteboard): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 21:17:58 +0000 (21:17 +0000)]
2011-03-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not show correct transfer size for synchronous requests
        https://bugs.webkit.org/show_bug.cgi?id=56951

        Fixed transfer size for synchronous load.

        * http/tests/inspector/network/network-size-sync-expected.txt: Added.
        * http/tests/inspector/network/network-size-sync.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not show correct transfer size for synchronous requests
        https://bugs.webkit.org/show_bug.cgi?id=56951

        Fixed transfer size for synchronous load.

        Test: http/tests/inspector/network/network-size-sync.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willLoadMediaElementURL):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 21:14:25 +0000 (21:14 +0000)]
2011-03-24  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Dismissed reversion suggestion is incorrectly learned.
        https://bugs.webkit.org/show_bug.cgi?id=57039

        CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
        [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
        is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
        incorrect automatic learning.

        * WebCoreSupport/CorrectionPanel.mm:
        (CorrectionPanel::dismissInternal):
2011-03-24  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Dismissed reversion suggestion is incorrectly learned.
        https://bugs.webkit.org/show_bug.cgi?id=57039

        CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
        [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
        is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
        incorrect automatic learning.

        * UIProcess/mac/CorrectionPanel.mm:
        (WebKit::CorrectionPanel::dismissInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Add Trackpoint driver hack to support IBM trackpads
bweinstein@apple.com [Thu, 24 Mar 2011 20:47:49 +0000 (20:47 +0000)]
WebKit2: Add Trackpoint driver hack to support IBM trackpads
https://bugs.webkit.org/show_bug.cgi?id=49830
<rdar://problem/8705951>

Reviewed by Adam Roben.

Copy code from WebKit1 to WebKit2 to handle initializing fake scrollbars so
IBM machines with a trackpad send us WM_VSCROLL and WM_HSCROLL messages.

Listen for the WM_VSCROLL and WM_HSCROLL messages, and turn the values into
ScrollDirection and ScrollGranularity, and send a scroll command to the
WebProcess.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scrollBy): Send a message to the WebProcess.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_VSCROLL and WM_HSCROLL message handling.
(WebKit::WebView::initialize): Call shouldInitializeTrackPointHack.
(WebKit::WebView::onHorizontalScroll): Turn wParam into a ScrollDirection and ScrollGranularity.
(WebKit::WebView::onVerticalScroll): Ditto.
(WebKit::WebView::shouldInitializeTrackPointHack): Check the registry for keys that indicate
    the machine has a IBM Trackpoint driver.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scrollBy): Call scroll method.
(WebKit::WebPage::scroll): Moved from WebPageMac and WebPageWin.
(WebKit::WebPage::logicalScroll): Ditto.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new scrollBy message.
* WebProcess/WebPage/mac/WebPageMac.mm: Remove scroll and logicalScroll, they are now in WebPage.cpp.
* WebProcess/WebPage/win/WebPageWin.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdating tests results for QT after changeset 81887.
enrica@apple.com [Thu, 24 Mar 2011 20:26:17 +0000 (20:26 +0000)]
Updating tests results for QT after changeset 81887.

* platform/qt/editing/pasteboard/5065605-expected.txt:
* platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=57030
beidson@apple.com [Thu, 24 Mar 2011 20:22:33 +0000 (20:22 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=57030
REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's
web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message

Reviewed by Adam Roben.

The callback objects had some bogus ASSERTs and missed a relevant null check. If a callback was waiting on
a message back from the UIProcess, but was invalidated from within the WebProcess in the meantime, it's
perfectly valid to attempt to performCallback() after the callback function pointer has been cleared.

* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):

LayoutTests: Resolving https://bugs.webkit.org/show_bug.cgi?id=57030, unskip the busted test.

Reviewed by Adam Roben.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDictionary text extraction is not correctly detecting word boundaries on bing.com
weinig@apple.com [Thu, 24 Mar 2011 20:06:00 +0000 (20:06 +0000)]
Dictionary text extraction is not correctly detecting word boundaries on bing.com
<rdar://problem/9078569>
https://bugs.webkit.org/show_bug.cgi?id=56995

Reviewed by Darin Adler.

../WebCore:

* WebCore.exp.in:
Add some editing related exports needed by WebKit2.

../WebKit2:

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add options dictionary.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Add path that can pass options through.

* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Use the new performDictionaryLookupForSelection which can extract context
if supported.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::characterRangeAtPositionForPoint):
(WebKit::characterRangeAtPoint):
Split functionality out of characterRangeAtPoint and into
characterRangeAtPositionForPoint to avoid doing duplicate work
if you already have the position.

(WebKit::isPositionInRange):
(WebKit::shouldUseSelection):
Add predicate to determine if we should use the selection instead
of expanding to find the word we are over.

(WebKit::WebPage::performDictionaryLookupAtLocation):
If available, use the surrounding paragraph as context to get better extraction
and to get lexicographical information about the word. Also, clean up and use
editing APIs to make the code more concise and understandable.

(WebKit::WebPage::performDictionaryLookupForSelection):
Use similar logic as in performDictionaryLookupAtLocation to extract additional
details from a selection for use in the dictionary popup.

(WebKit::WebPage::performDictionaryLookupForRange):
Pass options to WebProcess if available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 24 Mar 2011 19:58:35 +0000 (19:58 +0000)]
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
        https://bugs.webkit.org/show_bug.cgi?id=56836

        During fragment parsing, HTMLConstructionSite holds a reference to the
        fragment context's closest form ancestor. If a misnested form end tag is
        then encountered as the first node of the fragment, we will check to see
        if a corresponding form start tag is in scope even though no such tag
        exists. This led to isScope() walking the HTMLElementStack all the way
        to the root DocumentFragment and attempting to cast it to Element*.

        Fix this by ensuring that the inScope() family of functions operate in
        terms of ContainerNodes to account for the fragment case.

        Test: fast/parser/fragment-closest-form-ancestor.html

        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isRootNode):
        (WebCore::HTMLNames::isScopeMarker):
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLNames::isTableBodyScopeMarker):
        (WebCore::HTMLNames::isTableRowScopeMarker):
        (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
        (WebCore::HTMLElementStack::inScope):
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
        https://bugs.webkit.org/show_bug.cgi?id=56836

        * fast/parser/fragment-closest-form-ancestor-expected.txt: Added.
        * fast/parser/fragment-closest-form-ancestor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Repeated copy and paste-in-place operation results in increasingly...
enrica@apple.com [Thu, 24 Mar 2011 19:46:43 +0000 (19:46 +0000)]
Source/WebCore: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874

Reviewed by Darin Adler.

When we calculate the style to apply at the insertion point we compare the initial
style at the insertion point against the style calculated at the span we wrap the
copied markup fragment with. We could end up with a series of unnecessary spans
to remove the initial style that simply grow our markup.
The consists in moving the insertion point outside any inline element that could
affect the fragment being inserted when we are not pasting and matching the style.

Test: editing/pasteboard/paste-text-with-style.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle): Added.
(WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
point according to the new rules.

LayoutTests: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874

Reviewed by Darin Adler.

* editing/pasteboard/paste-text-with-style-expected.txt: Added.
* editing/pasteboard/paste-text-with-style.html: Added.
The following are new results for existing tests that now produce
a different markup.
* platform/mac/editing/pasteboard/5065605-expected.txt:
* platform/mac/editing/pasteboard/display-block-on-spans-expected.txt:
* platform/mac/editing/pasteboard/paste-text-011-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 24 Mar 2011 19:34:51 +0000 (19:34 +0000)]
2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
        https://bugs.webkit.org/show_bug.cgi?id=40884

        The software fallback is now only needed for corner cases like a manual rendering
        of the page to QImage.

        Keeping the image with the last pixel values is no longer needed. Removing it reduce the
        performance for real-time rendering on software surface, but this case should no longer be
        supported.

        The conversion from OpenGL color space and coordinates is done manually for performance. This
        also fix the bug of the inverted X axis due to the transformation.

        The tests and benchmarks are done through Qt API tests.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::swapBgrToRgb):
        (WebCore::GraphicsContext3DInternal::paint):
        (WebCore::GraphicsContext3D::reshape):
2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
        https://bugs.webkit.org/show_bug.cgi?id=40884

        Add tests and benchmarks for the software fallback of WebGL.

        * tests/benchmarks/webgl/10000_triangles.html: Added.
        * tests/benchmarks/webgl/tst_webgl.cpp: Added.
        (GraphicsView::GraphicsView):
        (GraphicsView::resizeEvent):
        (tst_WebGlPerformance::init):
        (tst_WebGlPerformance::cleanup):
        (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
        (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
        (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
        (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
        (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
        * tests/benchmarks/webgl/tst_webgl.qrc: Added.
        * tests/benchmarks/webgl/webgl.pro: Added.
        * tests/qgraphicswebview/qgraphicswebview.pro:
        * tests/qgraphicswebview/resources/pointing_right.html: Added.
        * tests/qgraphicswebview/resources/pointing_up.html: Added.
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (compareImagesFuzzyPixelCount):
        (GraphicsView::GraphicsView):
        (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
        (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
        (tst_QGraphicsWebView::compareCanvasToImage):
        * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
        * tests/tests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 19:17:51 +0000 (19:17 +0000)]
2011-03-24  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Remove bool that forces compositor HUD to always be enabled
        https://bugs.webkit.org/show_bug.cgi?id=57034

        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::enabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0...
ddkilzer@apple.com [Thu, 24 Mar 2011 19:14:13 +0000 (19:14 +0000)]
<webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X

Reviewed by Joseph Pecoraro.

* Plugins/WebPluginContainerPrivate.h: Changed value of
ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 19:14:09 +0000 (19:14 +0000)]
2011-03-24  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=20302
        Correct implementation of signbit on Solaris

        * wtf/MathExtras.h:
        (signbit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 19:02:29 +0000 (19:02 +0000)]
2011-03-24  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add traceEvents to compositor
        https://bugs.webkit.org/show_bug.cgi?id=56965

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h: Added.
        (WebCore::internal::ScopeTracer::ScopeTracer):
        (WebCore::internal::ScopeTracer::~ScopeTracer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::finish):
        (WebCore::LayerRendererChromium::present):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):
2011-03-24  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add traceEvents to compositor
        https://bugs.webkit.org/show_bug.cgi?id=56965

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 18:57:33 +0000 (18:57 +0000)]
2011-03-24  Jon Lee  <jonlee@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state
        <rdar://problem/8553962>

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setFocused): When the page loses focus, clear out any selection in the frame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a typo in the VK_LEFT case of performDefaultBehaviorForKeyEvent.
bweinstein@apple.com [Thu, 24 Mar 2011 18:11:57 +0000 (18:11 +0000)]
Fix a typo in the VK_LEFT case of performDefaultBehaviorForKeyEvent.

Rubber-stamped by Sam Weinig.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): It should be a logical or,
    not a bitwise or.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Mar 2011 18:11:07 +0000 (18:11 +0000)]
2011-03-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: render XHRs matching JSON regex as JSON.
        https://bugs.webkit.org/show_bug.cgi?id=57035

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.LocalJSONObject.prototype.get description.switch.case):
        (WebInspector.LocalJSONObject.prototype.get description):
        (WebInspector.LocalJSONObject.prototype._concatenate):
        (WebInspector.LocalJSONObject.prototype.getProperties):
        (WebInspector.LocalJSONObject.prototype._children):
        * inspector/front-end/ResourceJSONView.js: Added.
        (WebInspector.ResourceJSONView):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.hasContent):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.show):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.resource-view.json):
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo - USE(CF_NETWORK) should be USE(CFNETWORK).
jeffm@apple.com [Thu, 24 Mar 2011 17:51:41 +0000 (17:51 +0000)]
Fix typo - USE(CF_NETWORK) should be USE(CFNETWORK).

* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): USE(CF_NETWORK) should be USE(CFNETWORK)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 17:47:42 +0000 (17:47 +0000)]
2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Benjamin Poulain.

        Avoided ASCII-cast warnings for WebKit.

        Normally they won't be enabled anyway, but if you build webkit from
        within the Qt mother repository it will pick up Qt's default build
        settings, which do enable it. We need to disable them because
        warnings are treated as errors and there are way too many of them in
        the WebKit code.

        [Qt] Avoid ASCII-cast warnings for WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=57016

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 17:21:13 +0000 (17:21 +0000)]
2011-03-24  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Dimitri Glazkov.

        Add accessibilityObject accessor to WebDocument (needed for
        building an accessibility tree that includes iframes).
        https://bugs.webkit.org/show_bug.cgi?id=56984

        * public/WebDocument.h:
        * src/WebDocument.cpp:
        (WebKit::WebDocument::accessibilityObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some flaky tests to the mac-wk2 and win-wk2 Skipped files
aroben@apple.com [Thu, 24 Mar 2011 17:03:54 +0000 (17:03 +0000)]
Add some flaky tests to the mac-wk2 and win-wk2 Skipped files

The failures are tracked by <http://webkit.org/b/57027> and <http://webkit.org/b/57030>.

* platform/mac-wk2/Skipped: Added http/tests/inspector/extensions-resources-redirect.html.
* platform/win-wk2/Skipped: Added inspector/debugger/source-frame.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 17:03:28 +0000 (17:03 +0000)]
2011-03-24  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Dimitri Glazkov.

        Expose Node::isFocusable() in the Chromium WebKit API
        In service of https://code.google.com/p/chromium/issues/detail?id=72918
        https://bugs.webkit.org/show_bug.cgi?id=56809

        * public/WebNode.h:
        * src/WebNode.cpp:
        (WebKit::WebNode::isFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Mar 2011 16:58:16 +0000 (16:58 +0000)]
2011-03-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Move media controls subtree creation into one method.
        https://bugs.webkit.org/show_bug.cgi?id=56969

        Mechanical move, no changes in functionality.

        The purpose of this patch is to align existing code closer with its
        future version, when MediaControls is an element whose tree is created
        at the instantiation.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place.
        (WebCore::MediaControls::update): Replaced methods with one call.
        * html/shadow/MediaControls.h: Updated decls.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::create): Moved setting of attributes here.
        (WebCore::MediaControlVolumeSliderElement::create): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse proper string method to generate webloc string.
sfalken@apple.com [Thu, 24 Mar 2011 16:53:13 +0000 (16:53 +0000)]
Use proper string method to generate webloc string.
https://bugs.webkit.org/show_bug.cgi?id=57028
<rdar://problem/9181955>

Reviewed by Darin Adler.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows WebKit2 results for fast/css/pseudo-any.html
aroben@apple.com [Thu, 24 Mar 2011 16:27:38 +0000 (16:27 +0000)]
Add Windows WebKit2 results for fast/css/pseudo-any.html

This test passes on Windows but fails on Mac. <http://webkit.org/b/56988> tracks the Mac
failure.

* platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Thu, 24 Mar 2011 16:08:34 +0000 (16:08 +0000)]
2011-03-24  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=32821
        Fix conditionals which had an int for one case and a pointer for another.
        Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198

        No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::valueForShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Thu, 24 Mar 2011 15:30:30 +0000 (15:30 +0000)]
2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
        https://bugs.webkit.org/show_bug.cgi?id=29595

        Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
        ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
        prepending the current directory.

        By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
        will end up loading "about:blank", but keeping it as a requested URL.

        This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
        is filled for the loaded URLs as well, we can use it in every case.

        Three new autotests were added, to better cover the expected behavior of setting
        the QUrl() in a QWebFrame.

        * Api/qwebframe.cpp:
        (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
        (QWebFrame::requestedUrl): always use m_lastRequestedUrl.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
        anymore, since we always rely on it even for loaded frames.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
        the reduction of the bug report.
        (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
        (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 24 Mar 2011 14:57:03 +0000 (14:57 +0000)]
2011-03-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide live edit callback to source frame delegate.
        https://bugs.webkit.org/show_bug.cgi?id=57003

        * inspector/debugger/live-edit.html:
2011-03-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide live edit callback to source frame delegate.
        https://bugs.webkit.org/show_bug.cgi?id=57003

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.SourceFrameDelegateForScriptsPanel):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Some Unicode tests fail with Qt version >= 4.7.0
ossy@webkit.org [Thu, 24 Mar 2011 14:23:44 +0000 (14:23 +0000)]
[Qt] Some Unicode tests fail with Qt version >= 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=46251

Patch by Joe Wild <joseph.wild@nokia.com> on 2011-03-24
Reviewed by Csaba Osztrogon√°c.

Updated tests the print out character 0xFFFF for Qt Platform.
QString.toUtf8() converts non-defined Unicode char values, like
0xFFFF to a replacement character ('?') as documented.  Other
platforms leave the character as 0xFFFF (but utf8 encoded).
Converting to a real printable char seems reasonable and may
be more reliable.

* platform/qt/Skipped:
* platform/qt/fast/js/regexp-range-bound-ffff-expected.txt: Added.
* platform/qt/fast/js/switch-behaviour-expected.txt: Added.
* platform/qt/fast/url: Added.
* platform/qt/fast/url/anchor-expected.txt: Added.
* platform/qt/fast/url/path-expected.txt: Added.
* platform/qt/http/tests/websocket: Added.
* platform/qt/http/tests/websocket/tests: Added.
* platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Mar 2011 14:07:54 +0000 (14:07 +0000)]
2011-03-24  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: removing newly added inspector test that fails on release bots.

        * http/tests/inspector/network/network-redirect-expected.txt: Removed.
        * http/tests/inspector/network/network-redirect.html: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Mar 2011 13:59:26 +0000 (13:59 +0000)]
2011-03-24  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updated chromium expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 24 Mar 2011 13:48:15 +0000 (13:48 +0000)]
2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        Regression: WebKit does not build with Python 3 following 56807
        https://bugs.webkit.org/show_bug.cgi?id=56923

        The module string does not have the function replace in Python 3. The str.replace function
        can do the same operation in this case and works with the versions 2 and 3.

        * inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81863 268f45cc-cd09-0410-ab3c-d52691b4dbfc