WebKit-https.git
12 years ago * fast/replaced/image-map.html: Disabled this until bug 16782 is
aroben@apple.com [Wed, 9 Jan 2008 00:35:46 +0000 (00:35 +0000)]
    * fast/replaced/image-map.html: Disabled this until bug 16782 is
        fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix fast/dom/Window/window-properties.html on Windows
aroben@apple.com [Wed, 9 Jan 2008 00:35:21 +0000 (00:35 +0000)]
Fix fast/dom/Window/window-properties.html on Windows

WebCore:

        * bindings/scripts/CodeGeneratorJS.pm: Touch this so the bindings will
        rebuild on Windows now that the media elements are enabled.

LayoutTests:

        Fix fast/dom/Window/window-properties.html on Windows

        Windows now has the same results as other platforms.

        * platform/win/fast/dom/Window/window-properties-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - remove a test from the skipped list
mitz@apple.com [Wed, 9 Jan 2008 00:17:19 +0000 (00:17 +0000)]
    - remove a test from the skipped list

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
antti@apple.com [Wed, 9 Jan 2008 00:12:57 +0000 (00:12 +0000)]
WebCore:

        Reviewed by Weinig.

        Add security check for Audio constructor.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):

LayoutTests:

        Reviewed by Weinig.

        Test cross-frame access to media properties.

        * http/tests/security/cross-frame-access-get-expected.txt:
        * http/tests/security/cross-frame-access-get.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 8 Jan 2008 23:51:28 +0000 (23:51 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5676515> List of scripts and images missing when opening Web Inspector from new window (16567)

        InspectorController::didLoadResourceFromMemoryCache was not being called for
        resources that loaded from the memory cache that the FrameLoader's client
        has already been notified about. This fix always calls the InspectorController
        when loading a memory cached resource. No test possible for the Web Inspector.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkCacheObjectStatus): Moved most of the logic to
        FrameLoader::loadedResourceFromMemoryCache so the InspectorController can always be notified.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didTellClientAboutLoad): Renamed from didTellBridgeAboutLoad.
        (WebCore::FrameLoader::haveToldClientAboutLoad): Renamed from haveToldBridgeAboutLoad.
        (WebCore::FrameLoader::loadResourceSynchronously): Call the renamed didTellClientAboutLoad.
        (WebCore::FrameLoader::loadedResourceFromMemoryCache): Only takes a CachedResource now.
        Always call InspectorController. If the resource's sendResourceLoadCallbacks is false or
        didTellClientAboutLoad is true, do an early return. Otherwise call the client and call
        didTellClientAboutLoad.
        (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Removed, work now done
        in FrameLoader::loadedResourceFromMemoryCache.
        * loader/FrameLoader.h: Renamed {didTell,haveTold}BridgeAboutLoad to {didTell,haveTold}ClientAboutLoad.
        Made loadedResourceFromMemoryCache only take a CachedResource. Renamed m_urlsBridgeKnowsAbout to
        m_urlsClientKnowsAbout.
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::load): Call the renamed didTellClientAboutLoad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by Darin.
antti@apple.com [Tue, 8 Jan 2008 22:11:09 +0000 (22:11 +0000)]
    Rubber stamped by Darin.

        Enable media tests on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Tue, 8 Jan 2008 21:47:52 +0000 (21:47 +0000)]
    Rubber-stamped by Sam Weinig.

        - prefix all member variables in CSSStyleSelector with m_

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::setEncodedURL):
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::matchRules):
        (WebCore::CSSStyleSelector::matchRulesForList):
        (WebCore::CSSStyleSelector::initElementAndPseudoState):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        (WebCore::CSSStyleSelector::updateFont):
        (WebCore::CSSStyleSelector::cacheBorderAndBackground):
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::checkOneSelector):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundImage):
        (WebCore::CSSStyleSelector::mapBackgroundSize):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::):
        (WebCore::CSSRuleData::CSSRuleData):
        (WebCore::CSSRuleDataList::CSSRuleDataList):
        (WebCore::CSSRuleDataList::append):
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::isStyleAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Removed unnecessary files from Copy Bundle Resources build phase.
ddkilzer@apple.com [Tue, 8 Jan 2008 21:43:04 +0000 (21:43 +0000)]
    Removed unnecessary files from Copy Bundle Resources build phase.

        Reviewed by Sam.

        * WebCore.xcodeproj/project.pbxproj: Files removed from build phase:
        DOMCoreException.idl
        EventException.idl
        MessageEvent.idl
        SVGAElement.idl
        SVGAngle.idl
        SVGAnimateColorElement.idl
        SVGAnimateElement.idl
        SVGAnimateTransformElement.idl
        SVGAnimatedAngle.idl
        SVGAnimatedBoolean.idl
        SVGAnimatedEnumeration.idl
        SVGAnimatedInteger.idl
        SVGAnimatedLength.idl
        SVGAnimatedLengthList.idl
        SVGAnimatedNumber.idl
        SVGAnimatedNumberList.idl
        SVGAnimatedPathData.idl
        SVGAnimatedPoints.idl
        SVGAnimatedPreserveAspectRatio.idl
        SVGAnimatedRect.idl
        SVGAnimatedString.idl
        SVGAnimatedTransformList.idl
        SVGAnimationElement.idl
        SVGCSSPropertyNames.in
        SVGCSSValueKeywords.in
        SVGCircleElement.idl
        SVGClipPathElement.idl
        SVGColor.idl
        SVGComponentTransferFunctionElement.idl
        SVGCursorElement.idl
        SVGDefinitionSrcElement.idl
        SVGDefsElement.idl
        SVGDescElement.idl
        SVGDocument.idl
        SVGElement.idl
        SVGElementInstance.idl
        SVGElementInstanceList.idl
        SVGEllipseElement.idl
        SVGException.idl
        SVGExternalResourcesRequired.idl
        SVGFEBlendElement.idl
        SVGFEColorMatrixElement.idl
        SVGFEComponentTransferElement.idl
        SVGFECompositeElement.idl
        SVGFEDiffuseLightingElement.idl
        SVGFEDisplacementMapElement.idl
        SVGFEDistantLightElement.idl
        SVGFEFloodElement.idl
        SVGFEFuncAElement.idl
        SVGFEFuncBElement.idl
        SVGFEFuncGElement.idl
        SVGFEFuncRElement.idl
        SVGFEGaussianBlurElement.idl
        SVGFEImageElement.idl
        SVGFEMergeElement.idl
        SVGFEMergeNodeElement.idl
        SVGFEOffsetElement.idl
        SVGFEPointLightElement.idl
        SVGFESpecularLightingElement.idl
        SVGFESpotLightElement.idl
        SVGFETileElement.idl
        SVGFETurbulenceElement.idl
        SVGFilterElement.idl
        SVGFilterPrimitiveStandardAttributes.idl
        SVGFitToViewBox.idl
        SVGFontElement.idl
        SVGFontFaceElement.idl
        SVGFontFaceFormatElement.idl
        SVGFontFaceNameElement.idl
        SVGFontFaceSrcElement.idl
        SVGFontFaceUriElement.idl
        SVGForeignObjectElement.idl
        SVGGElement.idl
        SVGGlyphElement.idl
        SVGGradientElement.idl
        SVGImageElement.idl
        SVGLangSpace.idl
        SVGLength.idl
        SVGLengthList.idl
        SVGLineElement.idl
        SVGLinearGradientElement.idl
        SVGLocatable.idl
        SVGMarkerElement.idl
        SVGMaskElement.idl
        SVGMatrix.idl
        SVGMetadataElement.idl
        SVGMissingGlyphElement.idl
        SVGNumber.idl
        SVGNumberList.idl
        SVGPaint.idl
        SVGPathElement.idl
        SVGPathSeg.idl
        SVGPathSegArcAbs.idl
        SVGPathSegArcRel.idl
        SVGPathSegClosePath.idl
        SVGPathSegCurvetoCubicAbs.idl
        SVGPathSegCurvetoCubicRel.idl
        SVGPathSegCurvetoCubicSmoothAbs.idl
        SVGPathSegCurvetoCubicSmoothRel.idl
        SVGPathSegCurvetoQuadraticAbs.idl
        SVGPathSegCurvetoQuadraticRel.idl
        SVGPathSegCurvetoQuadraticSmoothAbs.idl
        SVGPathSegCurvetoQuadraticSmoothRel.idl
        SVGPathSegLinetoAbs.idl
        SVGPathSegLinetoHorizontalAbs.idl
        SVGPathSegLinetoHorizontalRel.idl
        SVGPathSegLinetoRel.idl
        SVGPathSegLinetoVerticalAbs.idl
        SVGPathSegLinetoVerticalRel.idl
        SVGPathSegList.idl
        SVGPathSegMovetoAbs.idl
        SVGPathSegMovetoRel.idl
        SVGPatternElement.idl
        SVGPoint.idl
        SVGPointList.idl
        SVGPolygonElement.idl
        SVGPolylineElement.idl
        SVGPreserveAspectRatio.idl
        SVGRadialGradientElement.idl
        SVGRect.idl
        SVGRectElement.idl
        SVGRenderingIntent.idl
        SVGSVGElement.idl
        SVGScriptElement.idl
        SVGSetElement.idl
        SVGStopElement.idl
        SVGStringList.idl
        SVGStylable.idl
        SVGStyleElement.idl
        SVGSwitchElement.idl
        SVGSymbolElement.idl
        SVGTRefElement.idl
        SVGTSpanElement.idl
        SVGTests.idl
        SVGTextContentElement.idl
        SVGTextElement.idl
        SVGTextPathElement.idl
        SVGTextPositioningElement.idl
        SVGTitleElement.idl
        SVGTransform.idl
        SVGTransformList.idl
        SVGTransformable.idl
        SVGURIReference.idl
        SVGUnitTypes.idl
        SVGUseElement.idl
        SVGViewElement.idl
        SVGViewSpec.idl
        SVGZoomAndPan.idl
        SVGZoomEvent.idl
        XMLHttpRequestException.idl
        XPathException.idl
        character-sets.txt
        mac-encodings.txt
        make-charset-table.pl
        svgattrs.in
        svgtags.in
        xlinkattrs.in

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-08 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Tue, 8 Jan 2008 21:34:52 +0000 (21:34 +0000)]
2008-01-08  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        Support copying the selected URL to the clipboard.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL): implemented

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Renamed CharacterData::m_str to m_data
ddkilzer@apple.com [Tue, 8 Jan 2008 21:27:13 +0000 (21:27 +0000)]
    Renamed CharacterData::m_str to m_data

        Rubber-stamped by Adam again.

        No test cases added since there is no change in behavior.

        * dom/CDATASection.cpp:
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData):
        (WebCore::CharacterData::setData):
        (WebCore::CharacterData::substringData):
        (WebCore::CharacterData::appendData):
        (WebCore::CharacterData::insertData):
        (WebCore::CharacterData::deleteData):
        (WebCore::CharacterData::replaceData):
        (WebCore::CharacterData::nodeValue):
        (WebCore::CharacterData::containsOnlyWhitespace):
        (WebCore::CharacterData::dispatchModifiedEvent):
        (WebCore::CharacterData::checkCharDataOperation):
        (WebCore::CharacterData::dump):
        * dom/CharacterData.h:
        * dom/Comment.cpp:
        * dom/Text.cpp:
        (WebCore::Text::splitText):
        (WebCore::Text::createRenderer):
        (WebCore::Text::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a couple of compiler warnings.
sfalken@apple.com [Tue, 8 Jan 2008 20:52:38 +0000 (20:52 +0000)]
    Fix a couple of compiler warnings.

        Reviewed by Mitz.

        * platform/win/ThreadingWin.cpp:
        * platform/win/UniscribeController.cpp: Remove unused function.
        (WebCore::UniscribeController::advance): Fix bogus warning about un-initialized variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 8 Jan 2008 20:50:58 +0000 (20:50 +0000)]
WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257

        * rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
          After fixing a bug in EventHandler to make sure events always go to the capturing node, this bug was exposed.
          MouseMove and MouseUp events were going to the thumb element, but not to the slider input element.
          This change makes the input element the capturing node, and then the input element forwards the mouse events to the thumb element.
          I also added a missing call to setDefaultHandled for the mousemove event.

LayoutTests:

        Reviewed by Darin.

        Updated test for:
        <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257

        * fast/forms/slider-mouse-events-expected.txt:
        * fast/forms/slider-mouse-events.html: Now tests mousemove events too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
adele@apple.com [Tue, 8 Jan 2008 20:27:38 +0000 (20:27 +0000)]
    Reviewed by Adam.

        * rendering/RenderThemeSafari.cpp: Use the SafariTheme version number to decide whether or not to
        paint the media controls in RenderThemeSafari.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after draggin...
oliver@apple.com [Tue, 8 Jan 2008 20:25:45 +0000 (20:25 +0000)]
Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after dragging file into window that contains web page ( econocraft.com/flood_arch.htm )

Reviewed by Adele and John.

We hit this crash if the page reloads between DragController::dragUpdated
and DragController::performDrag, meaning that m_document starts pointing to
a now viewless document.  This is picked up by an assertion in performDrag
which I have now replaced with an assignment given that the assertion is
invalid -- it is possible for m_document to be changed between dragUpdated
performDrag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing spaces in ChangeLog.
ap@webkit.org [Tue, 8 Jan 2008 19:55:17 +0000 (19:55 +0000)]
Fixing spaces in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Tue, 8 Jan 2008 19:52:24 +0000 (19:52 +0000)]
    Reviewed by Darin.

        <rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
        WebCore::Node::setChanged + 96

        Test: fast/dom/cssTarget-crash.html

        * dom/Node.cpp: (WebCore::Node::removedFromDocument):
        Check to see if the node being removed is currently set as the Document's cssTarget.
Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * svg/svgtags.in: Touch this again for the sake of the Windows bots.
aroben@apple.com [Tue, 8 Jan 2008 19:42:44 +0000 (19:42 +0000)]
    * svg/svgtags.in: Touch this again for the sake of the Windows bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 8 Jan 2008 19:40:13 +0000 (19:40 +0000)]
    Reviewed by Adam Roben.

        Use JSRetainPtr in the Web Inspector everywhere we own a JSStringRef.
        Also added some #pragma marks to help find places in the file.

        * page/InspectorController.cpp:
        (WebCore::callSimpleFunction): Use JSRetainPtr<JSStringRef>.
        And return the result of JSObjectCallAsFunction.
        (WebCore::search): Use JSRetainPtr<JSStringRef>.
        (WebCore::databaseTableNames): Ditto.
        (WebCore::localizedStrings): Ditto.
        (WebCore::InspectorController::~InspectorController): Ditto.
        (WebCore::InspectorController::focusNode): Ditto.
        (WebCore::InspectorController::windowScriptObjectAvailable): Ditto.
        (WebCore::InspectorController::scriptObjectReady): Ditto.
        (WebCore::addHeaders): Ditto.
        (WebCore::InspectorController::addScriptResource): Ditto.
        (WebCore::InspectorController::removeScriptResource): Ditto.
        (WebCore::InspectorController::updateScriptResourceRequest): Ditto.
        (WebCore::InspectorController::updateScriptResourceResponse): Ditto.
        (WebCore::InspectorController::updateScriptResource): Ditto.
        (WebCore::InspectorController::addDatabaseScriptResource): Ditto.
        (WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
        (WebCore::InspectorController::addScriptConsoleMessage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Tue, 8 Jan 2008 19:14:52 +0000 (19:14 +0000)]
    Rubber-stamped by Sam Weinig.

        - rename FontDataBaseClass.{cpp,h} back to FontData.{cpp,h}

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * editing/Editor.cpp:
        * platform/graphics/FontData.cpp: Copied from WebCore/platform/graphics/FontDataBaseClass.cpp.
        * platform/graphics/FontData.h: Copied from WebCore/platform/graphics/FontDataBaseClass.h.
        * platform/graphics/FontDataBaseClass.cpp: Removed.
        * platform/graphics/FontDataBaseClass.h: Removed.
        * platform/graphics/SegmentedFontData.h:
        * platform/graphics/SimpleFontData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix build.
sfalken@apple.com [Tue, 8 Jan 2008 18:51:44 +0000 (18:51 +0000)]
    Fix build.

        * DOMCoreClasses.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
andersca@apple.com [Tue, 8 Jan 2008 18:32:18 +0000 (18:32 +0000)]
    Reviewed by Mitz.

        <rdar://problem/5667286>
        plugins/createScriptableObject-before-start.html is failing due to denied cross-frame access

        Use our own test plug-in instead of the Flash plug-in. The Flash plug-in tries to get the URL of the top frame
        which will cause a security exception.

        * platform/win/Skipped:
        * plugins/createScriptableObject-before-start.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a Wx build error.
mitz@apple.com [Tue, 8 Jan 2008 17:56:30 +0000 (17:56 +0000)]
    Fix a Wx build error.

        * platform/graphics/wx/GlyphMapWx.cpp:
        (WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a Qt build error.
mitz@apple.com [Tue, 8 Jan 2008 17:48:44 +0000 (17:48 +0000)]
    Fix a Qt build error.

        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::fontDataForCharacter):
        (WebCore::SimpleFontData::isSegmented):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
aroben@apple.com [Tue, 8 Jan 2008 17:43:23 +0000 (17:43 +0000)]
    Windows build fix.

        Touch config.h to force a rebuild (apparently changing preprocessor
        definitions in the .vcproj doesn't force a rebuild).

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a Wx build failure.
mitz@apple.com [Tue, 8 Jan 2008 17:31:11 +0000 (17:31 +0000)]
    Fix a Wx build failure.

        * webcore-wx.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a Qt build failure.
mitz@apple.com [Tue, 8 Jan 2008 17:27:28 +0000 (17:27 +0000)]
    Fix a Qt build failure.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben
sullivan@apple.com [Tue, 8 Jan 2008 17:21:43 +0000 (17:21 +0000)]
    Reviewed by Adam Roben

        - fixed <rdar://problem/5671668> REGRESSION (r28711-r28730): With caret in an empty form field,
          Delete menu item is enabled but shouldn't be

        The enabled logic was incorrect for the Delete menu item. To fix this, I added an EditorCommandSource
        parameter to the enabled functions so that they can have parallel logic to the execute functions.

        * editing/EditorCommand.cpp:
        added EditorCommandSource parameter to isEnabled function prototype
        (WebCore::enabled):
        added unused EditorCommandSource parameter to these isEnabled functions:
        (WebCore::enabledAnySelection):
        (WebCore::enabledAnySelectionAndMark):
        (WebCore::enableCaretInEditableText):
        (WebCore::enabledCopy):
        (WebCore::enabledCut):

        (WebCore::enabledDelete):
        new function, uses logic previously used by Delete command for DOM sources; uses logic in enabledCut
        for menu source

        added unused EditorCommandSource parameter to these isEnabled functions:
        (WebCore::enabledInEditableText):
        (WebCore::enabledInRichlyEditableText):
        (WebCore::enabledPaste):
        (WebCore::enabledRangeInEditableText):
        (WebCore::enabledRangeInRichlyEditableText):
        (WebCore::enabledRedo):
        (WebCore::enabledUndo):

        (WebCore::CommandEntry::):
        wire up new enabledDelete function as delete function for Delete command

        (WebCore::Editor::Command::isEnabled):
        pass EditorCommandSource parameter to isEnabled function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Visual C++ Express build fix
aroben@apple.com [Tue, 8 Jan 2008 17:10:43 +0000 (17:10 +0000)]
    Visual C++ Express build fix

        * WebCore.vcproj/QTMovieWin.vcproj: Explicitly link against user32.lib
        and advapi32.lib. VS implicitly links against these, VC++ Express
        doesn't.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - add bug number
mitz@apple.com [Tue, 8 Jan 2008 16:45:26 +0000 (16:45 +0000)]
    - add bug number

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Try to fix the Qt build.
mitz@apple.com [Tue, 8 Jan 2008 15:34:06 +0000 (15:34 +0000)]
    Try to fix the Qt build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Try to fix Qt builds after Timothy's inspector changes.
zimmermann@webkit.org [Tue, 8 Jan 2008 15:07:02 +0000 (15:07 +0000)]
Not reviewed. Try to fix Qt builds after Timothy's inspector changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark.
mjs@apple.com [Tue, 8 Jan 2008 13:31:39 +0000 (13:31 +0000)]
    Reviewed by Mark.

        - remove duplicate definition of getElementById from HTMLDocument IDL (and ObjC bindings)

        * bindings/objc/PublicDOMInterfaces.h:
        * html/HTMLDocument.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Renamed CharacterData::str to m_str to match coding style
ddkilzer@apple.com [Tue, 8 Jan 2008 13:02:46 +0000 (13:02 +0000)]
    Renamed CharacterData::str to m_str to match coding style

        Rubber-stamped by Adam.

        No test cases added since there is no change in behavior.

        * dom/CDATASection.cpp:
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData):
        (WebCore::CharacterData::setData):
        (WebCore::CharacterData::substringData):
        (WebCore::CharacterData::appendData):
        (WebCore::CharacterData::insertData):
        (WebCore::CharacterData::deleteData):
        (WebCore::CharacterData::replaceData):
        (WebCore::CharacterData::nodeValue):
        (WebCore::CharacterData::containsOnlyWhitespace):
        (WebCore::CharacterData::dispatchModifiedEvent):
        (WebCore::CharacterData::checkCharDataOperation):
        (WebCore::CharacterData::dump):
        * dom/CharacterData.h:
        * dom/Comment.cpp:
        * dom/Text.cpp:
        (WebCore::Text::splitText):
        (WebCore::Text::createRenderer):
        (WebCore::Text::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTurn testIsInteger assertions into compile-time asserts and move them into HashTraits...
mrowe@apple.com [Tue, 8 Jan 2008 11:33:49 +0000 (11:33 +0000)]
Turn testIsInteger assertions into compile-time asserts and move them into HashTraits.h where possible.

Reviewed by Maciej Stachowiak.

* kjs/testkjs.cpp:
* wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the ENABLE_SVG_FONTS flag in Windows build, now builds.
oliver@apple.com [Tue, 8 Jan 2008 09:25:19 +0000 (09:25 +0000)]
Set the ENABLE_SVG_FONTS flag in Windows build, now builds.

I'm not sure if it just caused the right files to regenerate,
or if there's some configuration weirdness in the non-SVG-fonts
build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady.
mjs@apple.com [Tue, 8 Jan 2008 09:11:35 +0000 (09:11 +0000)]
    Reviewed by Brady.

        - fixed <rdar://problem/5644300> Back/Forward Cache should not include pages with databases

        Track whether a document has ever opened a database; if so, exclude it from b/f caching (for now)

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::setHasOpenDatabases):
        (WebCore::Document::hasOpenDatabases):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):
        * storage/Database.cpp:
        (WebCore::Database::openDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Tue, 8 Jan 2008 08:04:16 +0000 (08:04 +0000)]
    Reviewed by Oliver Hunt.

        - fix leaks seen on the build bot

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Avoid creating a
        CSSFontFaceSource for SVG font-face elements going into an
        SVGCSSFontFace because it just leaks them. Avoid adding SVG font-
        face elements to a CSSFontFace because it will not work as expected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
eric@webkit.org [Tue, 8 Jan 2008 07:32:17 +0000 (07:32 +0000)]
    Reviewed by Mark Rowe.

        * projects/svg/status.xml: remove fixed bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTry to fix the Windows build.
antti@apple.com [Tue, 8 Jan 2008 07:27:30 +0000 (07:27 +0000)]
Try to fix the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix.
mrowe@apple.com [Tue, 8 Jan 2008 04:13:31 +0000 (04:13 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Steve.
antti@apple.com [Tue, 8 Jan 2008 04:07:38 +0000 (04:07 +0000)]
    Reviewed by Steve.

        Re-enable media support in Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-07 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 8 Jan 2008 03:56:49 +0000 (03:56 +0000)]
2008-01-07  Steve Falkenburg  <sfalken@apple.com>

        Add version resource to QTMovieWin.dll

        Reviewed by Adam.

        * WebCore.vcproj/PRODUCTVERSION: Copied from ../WebKit/win/WebKit.vcproj/PRODUCTVERSION.
        * WebCore.vcproj/QTMovieWin.rc: Added.
        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/VERSION: Copied from ../WebKit/win/WebKit.vcproj/VERSION.
        * WebCore.vcproj/auto-version.sh: Copied from ../WebKit/win/WebKit.vcproj/auto-version.sh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
mitz@apple.com [Tue, 8 Jan 2008 03:48:52 +0000 (03:48 +0000)]
    Build fix.

        * platform/graphics/qt/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added.
        Calls QFontDatabase::removeApplicationFont().
        * platform/graphics/qt/FontCustomPlatformData.h:
        * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
        (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): Removed the
        implementation because Qt does not use the WebCore glyph cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Tue, 8 Jan 2008 03:38:11 +0000 (03:38 +0000)]
    Reviewed by Oliver Hunt.

        - fix an assertion failure in svg/W3C-SVG-1.1/fonts-elem-03-b.svg on
          Tiger and multiple SVG layout test failures on Leopard.

        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::getFontData): Avoid returning an
        empty SegmentedFontData.
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Avoid creating a font that
        contains no glyphs. On Leopard, ATS might create such a font given
        data in an unsupported format (such as SVG).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
sfalken@apple.com [Tue, 8 Jan 2008 02:37:39 +0000 (02:37 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Tue, 8 Jan 2008 02:29:33 +0000 (02:29 +0000)]
    Build fix.

        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.submit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/win/Skipped:
alice.liu@apple.com [Tue, 8 Jan 2008 02:26:14 +0000 (02:26 +0000)]
    * platform/win/Skipped:
        removing fixed test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Temporary results until I fix:
adele@apple.com [Tue, 8 Jan 2008 02:23:00 +0000 (02:23 +0000)]
    Temporary results until I fix:
        <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257

        * fast/forms/slider-mouse-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix painting of SVG <image> when the image must be scaled to retain aspect ratio
oliver@apple.com [Tue, 8 Jan 2008 02:20:55 +0000 (02:20 +0000)]
Fix painting of SVG <image> when the image must be scaled to retain aspect ratio

Reviewed by Niko

Also added new layout test for this bug, and corrected old expected output

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
mitz@apple.com [Tue, 8 Jan 2008 01:53:17 +0000 (01:53 +0000)]
    Build fix.

        * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
        (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Tue, 8 Jan 2008 01:49:54 +0000 (01:49 +0000)]
    Build fix.

        * WebKit.vcproj/InterfacesGenerated.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add missing newline.
adele@apple.com [Tue, 8 Jan 2008 01:49:09 +0000 (01:49 +0000)]
    Add missing newline.

        * rendering/MediaControlElements.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-07 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 8 Jan 2008 01:37:21 +0000 (01:37 +0000)]
2008-01-07  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Hyatt.

        <rdar://problem/5673489> Safari does not render windowless plugins in an
        iframe when opacity < 1.0

        Plugins in transparency layers handle their own world transforms, so
        only apply the horizontal/vertical transform if we are not in a
        transparency layer.

        * platform/graphics/GraphicsContext.h: Add a Windows-platform-only
        inTransparencyLayer() function
        * platform/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContext::getWindowsContext): Use inTransparencyLayer()
        (WebCore::GraphicsContext::inTransparencyLayer):
        (WebCore::GraphicsContext::releaseWindowsContext): Use
        inTransparencyLayer()
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::paint): When retrieving the HDC, use the rect
        relative to the window. Pass m_isTransparent to
        get/releaseWindowsContext(). Only set the world transform if we are not
        in a transparency layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix. Need to wrap these classes in #if ENABLE(VIDEO)
adele@apple.com [Tue, 8 Jan 2008 01:35:44 +0000 (01:35 +0000)]
    Build fix.  Need to wrap these classes in #if ENABLE(VIDEO)

        * rendering/MediaControlElements.cpp:
        * rendering/MediaControlElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark.
zimmermann@webkit.org [Tue, 8 Jan 2008 01:34:22 +0000 (01:34 +0000)]
Reviewed by Mark.
Enable SVG_FONTS by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
mitz@apple.com [Tue, 8 Jan 2008 01:32:30 +0000 (01:32 +0000)]
    Build fix.

        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::~SimpleFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 8 Jan 2008 01:30:27 +0000 (01:30 +0000)]
WebCore:

        Reviewed by Sam Weinig

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=16523
        <rdar://problem/5657447>

        When a frame is created with the URL "about:blank" or "", it should
        inherit its SecurityOrigin from its opener.  However, once it has
        decided on that SecurityOrigin, it should not change its mind.
        Prior to this patch, several events could induce the frame to change
        its SecurityOrigin, permitting an attacker to inject script into an
        arbitrary SecurityOrigin.

        This patch makes several changes:

        1) Documents refuse to change from one SecurityOrigin to another
           unless explicitly instructed to do so.

        2) Navigating to a JavaScript URL that produces a value
           preserves the current SecurityOrigin explicitly instead of
           relying on the URL to preserve the origin (which fails for
           about:blank URLs and SecurityOrigins with document.domain set).

           Ideally, we should not preserve the URL at all.  Instead, the
           frame's URL should be the JavaScript URL, as in Firefox, but this
           would require changes that are too risky for this patch.  I'll
           file this as a separate issue.

        3) Various methods of navigating to JavaScript URLs were not
           properly handling JavaScript that returned a value (and should
           therefore replace the current document).  This patch unifies
           those code paths with the path that works.

           There are still a handful of bugs relating to the handling of
           JavaScript URLs, but I'll file those as separate issues.

        Tests: http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
               http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
               http/tests/security/aboutBlank/xss-DENIED-set-opener.html

        * dom/Document.cpp:
        (WebCore::Document::initSecurityOrigin):
        * dom/Document.h:
        (WebCore::Document::setSecurityOrigin):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation):
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::executeIfJavaScriptURL):
        (WebCore::FrameLoader::begin):
        * loader/FrameLoader.h:
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::setForURL):
        (WebCore::SecurityOrigin::createForFrame):
        * platform/SecurityOrigin.h:

LayoutTests:

        Reviewed by Sam Weinig.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=16523

        Adds new LayoutTests for scripting from about:blank windows.  These
        windows should inherit its SecurityOrigin from its opener and should
        refuse to change their origins when their opener changes exogenously
        (the navigate-opener tests) or explicitly (the set-opener test).

        * http/tests/security/aboutBlank: Added.
        * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
        * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html: Added.
        * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
        * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html: Added.
        * http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
        * http/tests/security/aboutBlank/xss-DENIED-set-opener.html: Added.
        * http/tests/security/resources/innocent-victim-with-notify.html: Added.
        * http/tests/security/resources/innocent-victim.html: Added.
        * http/tests/security/resources/libwrapjs.js: Added.
        * http/tests/security/resources/open-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Forgot to check in these changes in my last checkin.
adele@apple.com [Tue, 8 Jan 2008 01:21:15 +0000 (01:21 +0000)]
    Forgot to check in these changes in my last checkin.

        * rendering/RenderThemeSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fixes.
mitz@apple.com [Tue, 8 Jan 2008 01:19:42 +0000 (01:19 +0000)]
    Build fixes.

        * WebCore.pro:
        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontCache::getCachedFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate Tiger library to a G3-friendly version.
mrowe@apple.com [Tue, 8 Jan 2008 00:51:24 +0000 (00:51 +0000)]
Update Tiger library to a G3-friendly version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John Sullivan.
timothy@apple.com [Tue, 8 Jan 2008 00:48:11 +0000 (00:48 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/5674119> Make the Web Inspector toolbar the normal size when not docked

        * page/inspector/inspector.css: Changed CSS rules to have the toolbar and buttons be
          normal height when not docked, and small when docked. Also added some cursor properties
          prevent showing the text cursor over areas that are not selectable.
        * page/inspector/Images: A few images added and old ones removed or renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-07 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 8 Jan 2008 00:42:10 +0000 (00:42 +0000)]
2008-01-07  Alp Toker  <alp@atoker.com>

        Prospective GTK+ autotools/qmake VIDEO build fix for breakage
        introduced in r29257.

        * GNUmakefile.am:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix reviwer of my last commit. It was the other Mark after all.
zimmermann@webkit.org [Tue, 8 Jan 2008 00:40:04 +0000 (00:40 +0000)]
Fix reviwer of my last commit. It was the other Mark after all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark.
zimmermann@webkit.org [Tue, 8 Jan 2008 00:37:40 +0000 (00:37 +0000)]
Reviewed by Mark.
Build fix affecting all builds - again related to the unicode-range addition.
Note: There is still a crasher (svg/W3C-SVG-1.1/fonts-elem-03-b.svg) that Dan is about to fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 8 Jan 2008 00:28:55 +0000 (00:28 +0000)]
WebCore:

        Reviewed by Antti, Adam, and Mitz.

        WebCore part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebCore.base.exp: Added symbols for WebKitSystemInterface drawing methods.
        * WebCore.xcodeproj/project.pbxproj: Added MediaControlElements.h/cpp
        * WebCore.vcproj/WebCore.vcproj: ditto.

        * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added cases for new appearances.
        * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added cases for new types.
        * css/CSSSelector.h: (WebCore::CSSSelector::): Added new pseudo elements.
        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): ditto.
        * css/CSSValueKeywords.in: Added keywords for new control appearance styles.
        * css/html4.css: Added new styles for new controls.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlay): Added. Takes loading state into account.
        * html/HTMLMediaElement.h:

        * page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Make sure the events always go to the capturing node, if there is one.

        * platform/mac/WebCoreSystemInterface.h: Added drawing methods for controls.
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * rendering/MediaControlElements.cpp: Added.
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Moved from RenderMedia.  Made this relatively positioned, instead of absolute.
        (WebCore::MediaControlInputElement::MediaControlInputElement): Moved from RenderMedia.  Removed call to updateFromElement,
         since its too early to do this here, and causes crashes for the slider.
        (WebCore::MediaControlInputElement::attachToParent): Moved from RenderMedia.
        (WebCore::MediaControlInputElement::update): ditto.
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Added.
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Moved from RenderMedia.
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Added.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::seekTimerFired): ditto.
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Moved from RenderMedia.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): ditto.
        (WebCore::MediaControlTimelineElement::update): ditto.
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Added.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
        * rendering/MediaControlElements.h: Added. Moved from RenderMedia.
        (WebCore::MediaControlShadowRootElement::isShadowNode):
        (WebCore::MediaControlShadowRootElement::shadowParentNode):
        (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot):
        (WebCore::RenderMediaControlShadowRoot::setParent):

        * rendering/RenderMedia.cpp: Moved control element classes to MediaControlElements files.
        (WebCore::RenderMedia::RenderMedia): No need to initialize RefPtrs.
        (WebCore::RenderMedia::layout): Set the position for the controlsRenderer.
        (WebCore::RenderMedia::createPanel): Added nil check for the renderer.
        (WebCore::RenderMedia::createMuteButton): Added.
        (WebCore::RenderMedia::createSeekBackButton): ditto.
        (WebCore::RenderMedia::createSeekForwardButton): ditto.
        (WebCore::RenderMedia::createTimeDisplay): Added nil check for the renderer.
        (WebCore::RenderMedia::createFullscreenButton): Added.
        (WebCore::RenderMedia::updateControls): Create, delete, and update new controls when appropriate.
        (WebCore::RenderMedia::updateControlVisibility): Don't fade controls for audio controls.
        (WebCore::RenderMedia::forwardEvent): Forward events for new controls.
        * rendering/RenderMedia.h: Added new methods for creating new controls.

        * rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): Updated special case for media elements, which are replaced elements,
          but also can contain children (the controls' container) that may need to look for the containing block.

        * rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Added case for MediaSliderAppearance.

        * rendering/RenderStyle.h: Added appearance constants and pseudo ids for new controls.
        (WebCore::):
        (WebCore::RenderStyle::):

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle): Added cases for new appearances.
        (WebCore::RenderTheme::paint): ditto.
        * rendering/RenderTheme.h: Added new methods for painting new appearances.
        (WebCore::RenderTheme::paintMediaBackground):
        (WebCore::RenderTheme::paintMediaFullscreenButton):
        (WebCore::RenderTheme::paintMediaPlayButton):
        (WebCore::RenderTheme::paintMediaMuteButton):
        (WebCore::RenderTheme::paintMediaSeekBackButton):
        (WebCore::RenderTheme::paintMediaSeekForwardButton):
        (WebCore::RenderTheme::paintMediaSliderThumb):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_mediaControlBackgroundImage.
        (WebCore::RenderThemeMac::~RenderThemeMac): Delete m_mediaControlBackgroundImage.
        (WebCore::RenderThemeMac::paintCapsLockIndicator): Use LocalCurrentGraphicsContext here too, since we use it in all other painting methods.
        (WebCore::RenderThemeMac::paintSliderTrack): Added case for MediaSliderAppearance.
        (WebCore::RenderThemeMac::adjustSliderThumbSize): Added case for MediaSliderThumbAppearance.
        (WebCore::RenderThemeMac::paintMediaBackground): Draws the new artwork for the controls.
        (WebCore::RenderThemeMac::paintMediaFullscreenButton): ditto.
        (WebCore::RenderThemeMac::paintMediaMuteButton): ditto.
        (WebCore::RenderThemeMac::paintMediaPlayButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSeekBackButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSeekForwardButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSliderThumb): ditto.
        * rendering/RenderThemeSafari.cpp: Draws the new artwork on Windows.
        (WebCore::RenderThemeSafari::paintSliderTrack):
        (WebCore::RenderThemeSafari::adjustSliderThumbSize):
        (WebCore::RenderThemeSafari::paintMediaBackground):
        (WebCore::RenderThemeSafari::paintMediaFullscreenButton):
        (WebCore::RenderThemeSafari::paintMediaMuteButton):
        (WebCore::RenderThemeSafari::paintMediaPlayButton):
        (WebCore::RenderThemeSafari::paintMediaSeekBackButton):
        (WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
        (WebCore::RenderThemeSafari::paintMediaSliderThumb):
        * rendering/RenderThemeSafari.h:

WebKit/mac:

        Reviewed by Antti, Adam, and Mitz.

        WebKit part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

        Reviewed by Antti, Adam, and Mitz.

        WebKitLibraries part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

LayoutTests:

        Reviewed by Antti, Adam, and Mitz.

        Updated results for:
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
timothy@apple.com [Tue, 8 Jan 2008 00:12:55 +0000 (00:12 +0000)]
    Reviewed by Darin Adler.

        Fix ASSERTION FAILED: dstOffset + srcSegmentLength == static_cast<int>(data.size())
        when the replacment string is a different length.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::replace): Move the parenthesis to be around only the subtraction in
        the Vector size calculation, correcting the order of math operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition...
zimmermann@webkit.org [Tue, 8 Jan 2008 00:04:30 +0000 (00:04 +0000)]
Reviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition. NSInteger not available there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
alice.liu@apple.com [Tue, 8 Jan 2008 00:03:51 +0000 (00:03 +0000)]
    Reviewed by Sam.

        checking in platform-specific results. addresses <rdar://5137719>

        * platform/win/Skipped:
        * platform/win/fast/dom/Window/window-screen-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch...
zimmermann@webkit.org [Mon, 7 Jan 2008 23:54:13 +0000 (23:54 +0000)]
Reviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch & enabling SVG_FONTS by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Next try to fix wx/mac leopard build.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:46:50 +0000 (23:46 +0000)]
Not reviewed. Next try to fix wx/mac leopard build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
kmccullough@apple.com [Mon, 7 Jan 2008 23:36:44 +0000 (23:36 +0000)]
    Reviewed by Adele.

        - <rdar://problem/5667022> fast/events/mousemove-after-drag-over-scrollbar.html
        failing (missing a mousemove event)
        - Updated test to reflect it's original intention and filed a different
        bug about the issue that caused the test to fail on Windows.

        * fast/events/mousemove-after-drag-over-scrollbar-expected.txt:
        * fast/events/mousemove-after-drag-over-scrollbar.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 7 Jan 2008 23:32:55 +0000 (23:32 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/objc/DOM.mm:
        * bridge/mac/WebCoreAXObject.mm:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSFontFace.cpp:
        (WebCore::CSSFontFace::fontLoaded): Changed to call the owning segmented
        font face.
        (WebCore::CSSFontFace::getFontData):
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::CSSFontFace):
        (WebCore::CSSFontFace::setSegmentedFontFace):
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::pruneTable): Removed the calls to
        GlyphPageTreeNode::pruneTreeCustomFontData because the fonts in the
        font table are not exposed in the glyph page tree. Only the segmented
        font is, and that is taken care of by the segmented font face.
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontFaceSource.h:
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to collect
        @font-face rules with the same family and traits into a single
        segmented font face, instead of just retaining the most recent one.
        (WebCore::CSSFontSelector::fontLoaded):
        (WebCore::CSSFontSelector::getFontData):
        * css/CSSFontSelector.h:
        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFontFaceUnicodeRange): Added. Parses a unicode
        range value.
        * css/CSSParser.h:
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):
        * css/CSSPropertyNames.in:
        * css/CSSSegmentedFontFace.cpp: Added.
        (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
        (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace):
        (WebCore::CSSSegmentedFontFace::pruneTable):
        (WebCore::CSSSegmentedFontFace::isLoaded):
        (WebCore::CSSSegmentedFontFace::isValid):
        (WebCore::CSSSegmentedFontFace::fontLoaded):
        (WebCore::CSSSegmentedFontFace::overlayRange):
        (WebCore::CSSSegmentedFontFace::getFontData):
        * css/CSSSegmentedFontFace.h: Added.
        (WebCore::FontFaceRange::FontFaceRange):
        (WebCore::FontFaceRange::from):
        (WebCore::FontFaceRange::to):
        (WebCore::FontFaceRange::fontFace):
        (WebCore::CSSSegmentedFontFace::fontSelector):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSUnicodeRangeValue.cpp: Added.
        (WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue):
        (WebCore::CSSUnicodeRangeValue::cssText):
        * css/CSSUnicodeRangeValue.h: Added.
        (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):
        (WebCore::CSSUnicodeRangeValue::from):
        (WebCore::CSSUnicodeRangeValue::to):
        * css/SVGCSSFontFace.cpp:
        (WebCore::SVGCSSFontFace::getFontData):
        * css/SVGCSSFontFace.h:
        * editing/Editor.cpp:
        (WebCore::Editor::fontForSelection):
        * editing/Editor.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge fontForSelection:]):
        * platform/graphics/Font.cpp:
        (WebCore::WidthIterator::advance):
        (WebCore::Font::glyphDataForCharacter):
        (WebCore::Font::primaryFont): Changed to return the simple font data
        used for the space character.
        (WebCore::Font::fontDataAt):
        (WebCore::Font::fontDataForCharacters):
        (WebCore::Font::drawGlyphBuffer):
        * platform/graphics/Font.h:
        * platform/graphics/FontCache.cpp:
        (WebCore::FontCache::getCachedFontData):
        (WebCore::FontCache::getFontData):
        * platform/graphics/FontCache.h:
        * platform/graphics/FontData.cpp: Renamed to SimpleFontData.cpp
        * platform/graphics/FontData.h: Renamed to SimpleFontData.cpp.
        * platform/graphics/FontDataBaseClass.cpp: Added. This will be renamed
        FontData.cpp.
        (WebCore::FontData::~FontData):
        * platform/graphics/FontDataBaseClass.h: Added. This will be renamed
        FontData.h.
        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::determinePitch):
        (WebCore::FontFallbackList::fontDataAt):
        (WebCore::FontFallbackList::fontDataForCharacters):
        * platform/graphics/FontFallbackList.h:
        (WebCore::FontFallbackList::primaryFont):
        * platform/graphics/FontSelector.h:
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::fontDataAt):
        (WebCore::GlyphBuffer::swap):
        (WebCore::GlyphBuffer::add):
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
        (WebCore::GlyphPageTreeNode::initializePage): Added code to initialize
        pages for segmented font data.
        (WebCore::GlyphPageTreeNode::getChild):
        (WebCore::GlyphPageTreeNode::pruneCustomFontData):
        * platform/graphics/GlyphPageTreeNode.h:
        (WebCore::GlyphPage::setGlyphDataForCharacter):
        (WebCore::GlyphPage::setGlyphDataForIndex):
        (WebCore::GlyphPageTreeNode::getRootChild):
        * platform/graphics/SegmentedFontData.cpp: Added.
        (WebCore::SegmentedFontData::~SegmentedFontData):
        (WebCore::SegmentedFontData::fontDataForCharacter):
        (WebCore::SegmentedFontData::containsCharacters):
        (WebCore::SegmentedFontData::isCustomFont):
        (WebCore::SegmentedFontData::isLoading):
        (WebCore::SegmentedFontData::isSegmented):
        * platform/graphics/SegmentedFontData.h: Added.
        (WebCore::FontDataRange::FontDataRange):
        (WebCore::FontDataRange::from):
        (WebCore::FontDataRange::to):
        (WebCore::FontDataRange::fontData):
        (WebCore::SegmentedFontData::appendRange):
        (WebCore::SegmentedFontData::numRanges):
        (WebCore::SegmentedFontData::rangeAt):
        * platform/graphics/SimpleFontData.cpp: Copied from WebCore/platform/graphics/FontData.cpp.
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::~SimpleFontData):
        (WebCore::SimpleFontData::ascent):
        (WebCore::SimpleFontData::descent):
        (WebCore::SimpleFontData::widthForGlyph):
        (WebCore::SimpleFontData::fontDataForCharacter):
        (WebCore::SimpleFontData::isSegmented):
        * platform/graphics/SimpleFontData.h: Copied from WebCore/platform/graphics/FontData.h.
        (WebCore::SimpleFontData::isCustomFont):
        (WebCore::SimpleFontData::isLoading):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::setPlatformFont):
        * platform/graphics/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/gtk/FontDataGtk.cpp: Renamed to
        SimpleFontDataGtk.cpp.
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
        (WebCore::GlyphPage::fill):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp: Copied from WebCore/platform/graphics/gtk/FontDataGtk.cpp.
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):
        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/mac/FontDataMac.mm: Renamed to SimpleFontDataMac.mm.
        * platform/graphics/mac/FontMac.mm:
        (WebCore::initializeATSUStyle):
        (WebCore::overrideLayoutOperation):
        (WebCore::ATSULayoutParameters::initialize):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
        (WebCore::GlyphPage::fill):
        * platform/graphics/mac/SimpleFontDataMac.mm: Copied from WebCore/platform/graphics/mac/FontDataMac.mm.
        (WebCore::initFontData):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::checkShapesArabic):
        * platform/graphics/qt/FontDataQt.cpp: Renamed to SimpleFontDataQt.cpp.
        * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
        (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
        * platform/graphics/qt/SimpleFontDataQt.cpp: Copied from WebCore/platform/graphics/qt/FontDataQt.cpp.
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/win/FontDataWin.cpp: Renamed to
        SimpleFontDataWin.cpp.
        * platform/graphics/win/FontWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/GlyphPageTreeNodeWin.cpp:
        (WebCore::GlyphPage::fill):
        * platform/graphics/win/SimpleFontDataWin.cpp: Copied from WebCore/platform/graphics/win/FontDataWin.cpp.
        (WebCore::SimpleFontData::setShouldApplyMacAscentHack):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::scriptFontProperties):
        * platform/graphics/wx/FontCacheWx.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/wx/FontDataWx.cpp: Renamed to SimpleFontDataWx.cpp.
        * platform/graphics/wx/FontWx.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/wx/GlyphMapWx.cpp:
        (WebCore::GlyphPage::fill):
        * platform/graphics/wx/SimpleFontDataWx.cpp: Copied from WebCore/platform/graphics/wx/FontDataWx.cpp.
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/mac/FileChooserMac.mm:
        * platform/mac/PopupMenuMac.mm:
        * platform/mac/WebCoreTextRenderer.mm:
        * platform/win/PopupMenuWin.cpp:
        * platform/win/UniscribeController.cpp:
        (WebCore::UniscribeController::advance):
        (WebCore::UniscribeController::itemizeShapeAndPlace):
        (WebCore::UniscribeController::shapeAndPlaceItem):
        (WebCore::UniscribeController::shape):
        * platform/win/UniscribeController.h:
        * svg/SVGFont.cpp:
        (WebCore::Font::drawGlyphsWithSVGFont):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::collectGlyphs):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::createFontData):
        * svg/SVGFontFaceElement.h:
        * svg/SVGGlyphElement.cpp:

WebKit/mac:

        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * Misc/WebNSAttributedStringExtras.mm:

WebKit/win:

        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * WebView.cpp:
        (WebView::setShouldApplyMacFontAscentHack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Try to fix mac build by forcing SVGNames regeneration.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:15:59 +0000 (23:15 +0000)]
Not reviewed. Try to fix mac build by forcing SVGNames regeneration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Proposed build fix for wx.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:10:38 +0000 (23:10 +0000)]
Not reviewed. Proposed build fix for wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago 64-bit build fix
mitz@apple.com [Mon, 7 Jan 2008 23:03:18 +0000 (23:03 +0000)]
    64-bit build fix

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData): Have to use a
        cast here since FMGetFontFromATSFontRef() is not available on 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
zimmermann@webkit.org [Mon, 7 Jan 2008 22:56:54 +0000 (22:56 +0000)]
Reviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15741 (REGRESSION: svg/W3C-SVG-1.1/fonts-elem-03-b.svg shows worse behavior on TOT)

Display SVG Fonts, fill svg/SVGFont.cpp with life by adding all needed code to
measure & render glyphs contained in SVG Fonts, including ligature lookup support.

Fixes dozens of testcases, see ChangeLog for details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by David Kilzer.
darin@apple.com [Mon, 7 Jan 2008 22:10:54 +0000 (22:10 +0000)]
    Rubber stamped by David Kilzer.

        - get rid of empty fpconst.cpp

        * GNUmakefile.am: Remove fpconst.cpp.
        * JavaScriptCore.pri: Ditto.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * JavaScriptCoreSources.bkl: Ditto.

        * kjs/fpconst.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Oliver.
zimmermann@webkit.org [Mon, 7 Jan 2008 22:01:17 +0000 (22:01 +0000)]
Rubberstamped by Oliver.

Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.

Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by David Kilzer.
darin@apple.com [Mon, 7 Jan 2008 21:50:51 +0000 (21:50 +0000)]
    Reviewed by David Kilzer.

        - fix alignment problem with NaN and Inf globals

        * kjs/fpconst.cpp: Move the contents of this file from here back to
        value.cpp. The reason this was in a separate file is that the DARWIN
        version of this used a declaration of the globals with a different
        type to avoid creating "init routines". That's no longer necessary for
        DARWIN and was never necessary for the non-DARWIN code path.
        To make this patch easy to merge, I didn't actually delete this file
        yet. We'll do that in a separate changeset.

        * kjs/value.cpp: If C99's NAN and INFINITY are present, then use them,
        othrewise use the union trick from fpconst.cpp. I think it would be
        better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY
        directly or std::numeric_limits<double>::quiet_nan() and
        std::numeric_limits<double>::infinity(). But when I tried that, it
        slowed down SunSpider. Someone else could do that cleanup if they
        could do it without slowing down the engine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Updated to run a test whose failure was only a build bot state issue.
kmccullough@apple.com [Mon, 7 Jan 2008 21:46:39 +0000 (21:46 +0000)]
    - Updated to run a test whose failure was only a build bot state issue.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.
hyatt@apple.com [Mon, 7 Jan 2008 21:15:47 +0000 (21:15 +0000)]
    Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.

        Reviewed by Dan

        * rendering/RenderBox.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/win/Skipped: Skip the culprit, not the victim.
aroben@apple.com [Mon, 7 Jan 2008 20:50:03 +0000 (20:50 +0000)]
    * platform/win/Skipped: Skip the culprit, not the victim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Mon, 7 Jan 2008 20:43:10 +0000 (20:43 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
        JavaScript.h to the project.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        Copy JavaScript.h to WEBKITOUTPUTDIR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
timothy@apple.com [Mon, 7 Jan 2008 20:37:03 +0000 (20:37 +0000)]
    Reviewed by Darin.

        Fix Mac build.

        * API/JSNode.c:
        * API/JSNode.h:
        * API/JSNodeList.c:
        * API/JSNodeList.h:
        * API/JavaScript.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/win/Skipped: Added a few more failures.
aroben@apple.com [Mon, 7 Jan 2008 20:22:23 +0000 (20:22 +0000)]
    * platform/win/Skipped: Added a few more failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove a now incorrect Windows-specific result
aroben@apple.com [Mon, 7 Jan 2008 20:02:04 +0000 (20:02 +0000)]
    Remove a now incorrect Windows-specific result

        This should have been done as part of r29187

        * platform/win/fast/dom/wrapper-classes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes: http://bugs.webkit.org/show_bug.cgi?id=16244
zimmermann@webkit.org [Mon, 7 Jan 2008 19:58:24 +0000 (19:58 +0000)]
Fixes: bugs.webkit.org/show_bug.cgi?id=16244
DRT doesn't handle platform specific pixel test results correctly.

<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-07 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 7 Jan 2008 19:30:40 +0000 (19:30 +0000)]
2008-01-07  Alp Toker  <alp@atoker.com>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=16029
        JavaScriptCore.h is not suitable for platforms other than Mac OS X

        Introduce a new JavaScriptCore/JavaScript.h public API header. This
        should be used by all new portable code using the JavaScriptCore API.

        JavaScriptCore/JavaScriptCore.h will remain for compatibility with
        existing applications that depend on it including JSStringRefCF.h
        which isn't portable.

        Also add minidom to the GTK+/autotools build since we can now support
        it on all platforms.

        * API/JSNode.h:
        * API/JSNodeList.h:
        * API/JavaScript.h: Added.
        * API/JavaScriptCore.h:
        * ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
        * GNUmakefile.am:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Fix indention
zecke@webkit.org [Mon, 7 Jan 2008 19:16:24 +0000 (19:16 +0000)]
* Fix indention

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* The ContextMenuController is going to live longer than the ContextMenu. It is
zecke@webkit.org [Mon, 7 Jan 2008 19:15:58 +0000 (19:15 +0000)]
* The ContextMenuController is going to live longer than the ContextMenu. It is
  going to live as long as the WebCore::Page is around where the ContextMenu, specially
  in the case of a SubMenu, is gone before we popup the menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Fix SubMenu handling
zecke@webkit.org [Mon, 7 Jan 2008 19:15:31 +0000 (19:15 +0000)]
* Fix SubMenu handling
* Do not connect to the activated signal if we are a separator or submenu
* Change our type from ActionType to SubMenuType when we have a submenu
* Initialize the SubMenu

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemTy...
zecke@webkit.org [Mon, 7 Jan 2008 19:14:58 +0000 (19:14 +0000)]
* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable
  actions.
* Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
* Update the ContextMenuController to accept CheckableActionTypes as well.
* Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable
  was extracted from ContextMenu::checkOrEnableIfNeeded.
* Update the Qt and Windows port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
kmccullough@apple.com [Mon, 7 Jan 2008 18:04:17 +0000 (18:04 +0000)]
WebKitTools:

        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
        DRT did not correctly handle printing the '\0' char.  Now it does.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dumpFramesAsText):
        (dump):

LayoutTests:

        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing.
        Since they pass now, the two tests are removed from the Skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-01-07 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Mon, 7 Jan 2008 16:23:06 +0000 (16:23 +0000)]
2008-01-07  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16745
        [GTK] Context menu doesn't feel or look native - no icons

        Use GTK+ stock icons for menu items where possible.

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        (WebCore::ContextMenuItem::createNativeMenuItem):
        (WebCore::ContextMenuItem::setAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John Sullivan.
mitz@apple.com [Mon, 7 Jan 2008 15:16:41 +0000 (15:16 +0000)]
    Reviewed by John Sullivan.

        - make the ATSUI code path work with custom fonts rather than crash

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::initializeATSUStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for the Windows build. MSVC wants to see the full
hausmann@webkit.org [Mon, 7 Jan 2008 13:29:00 +0000 (13:29 +0000)]
Build fix for the Windows build. MSVC wants to see the full
declaration of arguments even when just passing them through.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded the missing parameters to make it possible to do POST operations from the publi...
hausmann@webkit.org [Mon, 7 Jan 2008 11:38:00 +0000 (11:38 +0000)]
Added the missing parameters to make it possible to do POST operations from the public API.

This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoabort() now emits the signals, so disconnect them before you abort()
hausmann@webkit.org [Mon, 7 Jan 2008 11:36:34 +0000 (11:36 +0000)]
abort() now emits the signals, so disconnect them before you abort()

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse a faster and safer way of flattening the form data.
hausmann@webkit.org [Mon, 7 Jan 2008 11:36:16 +0000 (11:36 +0000)]
Use a faster and safer way of flattening the form data.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPorted of the network backend of the Qt platform to Qt 4.4's new networking API.
hausmann@webkit.org [Mon, 7 Jan 2008 11:35:55 +0000 (11:35 +0000)]
Ported of the network backend of the Qt platform to Qt 4.4's new networking API.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29222 268f45cc-cd09-0410-ab3c-d52691b4dbfc