WebKit-https.git
9 months ago[iOS] Implement safe browsing in WebKit
achristensen@apple.com [Tue, 13 Nov 2018 01:08:07 +0000 (01:08 +0000)]
[iOS] Implement safe browsing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=191441

Reviewed by Tim Horton.

Source/WebKit:

In r237863 I implemented this for Mac.  This refines the UI and implements it for iOS.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextHandlesSafeBrowsing):
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _clearSafeBrowsingWarning]):
(-[WKWebView layoutSubviews]):
(-[WKWebView setFrameSize:]):
(+[WKWebView _handlesSafeBrowsing]):
(-[WKWebView _safeBrowsingWarningForTesting]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/Cocoa/PageClientImplCocoa.h:
* UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::allocFileWrapperInstance const):
(WebKit::PageClientImplCocoa::serializableFileWrapperClasses const):
* UIProcess/Cocoa/WKSafeBrowsingWarning.h:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(confirmMalwareSentinel):
(visitUnsafeWebsiteSentinel):
(colorForItem):
(addLinkAndReplace):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(makeButton):
(makeTitleLabel):
(setBackground):
(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingResult:completionHandler:]):
(-[WKSafeBrowsingWarning addContent]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(-[WKSafeBrowsingWarning layoutText]):
(-[WKSafeBrowsingWarning textView:clickedOnLink:atIndex:]):
(-[WKSafeBrowsingWarning layout]):
(-[WKSafeBrowsingWarning layoutSubviews]):
(-[WKSafeBrowsingWarning textView:shouldInteractWithURL:inRange:interaction:]):
(-[WKSafeBrowsingWarning didMoveToWindow]):
(-[WKSafeBrowsingWarning clickedOnLink:]):
(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
(-[WKSafeBrowsingTextView intrinsicContentSize]):
(colorNamed): Deleted.
(+[WKSafeBrowsingTextView viewWithAttributedString:linkTarget:]): Deleted.
(+[WKSafeBrowsingTextView viewWithString:]): Deleted.
(-[WKSafeBrowsingTextView clickedOnLink:atIndex:]): Deleted.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):
(WebKit::PageClientImpl::requestPasswordForQuickLookDocument):
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::showShareSheet):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(checkTitleAndClick):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[css-grid] Refactoring to make more explicit the orthogonal items' pre-layout logic
jfernandez@igalia.com [Tue, 13 Nov 2018 00:31:51 +0000 (00:31 +0000)]
[css-grid] Refactoring to make more explicit the orthogonal items' pre-layout logic
https://bugs.webkit.org/show_bug.cgi?id=191358

Reviewed by Manuel Rego Casasnovas.

These changes are just a refactoring to ease the integration of the new Baseline Alignment
logic in a follow up patch.

We need to properly estimate the grid area size of orthogonal items so that we can perform
an accurate pre-layout. This is important because orthogonal items will synthesize their baseline
if they participate in any baseline alignment context.

No new tests, since no behavior change has been introduced in this patch.

* rendering/Grid.cpp:
(WebCore::Grid::setNeedsItemsPlacement):
* rendering/Grid.h:
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::isRelativeGridLengthAsAuto const):
(WebCore::GridTrackSizingAlgorithm::isRelativeSizedTrackAsAuto const):
(WebCore::GridTrackSizingAlgorithm::gridTrackSize const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::run):
(WebCore::GridTrackSizingAlgorithm::reset):
* rendering/GridTrackSizingAlgorithm.h:
(WebCore::GridTrackSizingAlgorithmStrategy::gridTrackSize const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::overrideSizeChanged):
(WebCore::hasRelativeBlockAxisSize):
(WebCore::RenderGrid::updateGridAreaLogicalSize const):
(WebCore::RenderGrid::layoutGridItems):
* rendering/RenderGrid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoAdd HTTPS git remote to ReadMe.md
rniwa@webkit.org [Mon, 12 Nov 2018 23:42:49 +0000 (23:42 +0000)]
Add HTTPS git remote to ReadMe.md
https://bugs.webkit.org/show_bug.cgi?id=191561

Reviewed by Zalan Bujtas.

* ReadMe.md:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoimported/w3c/web-platform-tests/IndexedDB/keygenerator-explicit.html crashing on...
sihui_liu@apple.com [Mon, 12 Nov 2018 23:34:29 +0000 (23:34 +0000)]
imported/w3c/web-platform-tests/IndexedDB/keygenerator-explicit.html crashing on iOS device
https://bugs.webkit.org/show_bug.cgi?id=191500

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

* web-platform-tests/IndexedDB/keygenerator-explicit-expected.txt:

Source/WebCore:

When double value is bigger than maximum unsigned int, converting double to unsigned int has
different behaviors on macOS and iOS. On macOS, the result would be 0 while on iOS it would be
maximum unsigned int.

Covered by existing test.

* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):

LayoutTests:

The test should not crash now.

* platform/ios-device/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Curl] Add API Test for Curl cookie backend.
basuke.suzuki@sony.com [Mon, 12 Nov 2018 23:18:44 +0000 (23:18 +0000)]
[Curl] Add API Test for Curl cookie backend.
https://bugs.webkit.org/show_bug.cgi?id=191493

Reviewed by Youenn Fablet.

Source/WebCore:

Refactoring for cookie backend interface.

Tests: TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp

* platform/FileSystem.h:
* platform/network/curl/CookieJarCurlDatabase.cpp:
(WebCore::cookiesForSession):
(WebCore::CookieJarCurlDatabase::setCookiesFromDOM const):
(WebCore::CookieJarCurlDatabase::setCookiesFromHTTPResponse const):
(WebCore::CookieJarCurlDatabase::getRawCookies const):
* platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::openDatabase):
(WebCore::CookieJarDB::checkSQLiteReturnCode):
(WebCore::CookieJarDB::isEnabled const):
(WebCore::CookieJarDB::searchCookies):
(WebCore::CookieJarDB::setCookie):
(WebCore::CookieJarDB::deleteCookie):
(WebCore::CookieJarDB::deleteCookieInternal):
(WebCore::CookieJarDB::deleteCookies):
(WebCore::CookieJarDB::deleteAllCookies):
(WebCore::CookieJarDB::executeSimpleSql):
(WebCore::CookieJarDB::isEnabled): Deleted.
* platform/network/curl/CookieJarDB.h:
* platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::parseCookieHeader):
* platform/network/curl/CookieUtil.h:
* platform/win/FileSystemWin.cpp:
(WebCore::FileSystem::generateTemporaryPath):
(WebCore::FileSystem::openTemporaryFile):
(WebCore::FileSystem::createTemporaryDirectory):
(WebCore::FileSystem::deleteNonEmptyDirectory):

Tools:

Add unit test to TestWebCore.

* TestWebKitAPI/PlatformWin.cmake:
* TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed. Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
sbarati@apple.com [Mon, 12 Nov 2018 22:10:38 +0000 (22:10 +0000)]
Unreviewed. Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
https://bugs.webkit.org/show_bug.cgi?id=191555

* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
* bytecode/UnlinkedFunctionExecutable.h:
* parser/SourceCodeKey.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):
* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
* runtime/CodeCache.h:
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/FunctionExecutable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMake it possible to edit images inline
timothy_horton@apple.com [Mon, 12 Nov 2018 22:04:47 +0000 (22:04 +0000)]
Make it possible to edit images inline
https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html
       editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

* page/Settings.yaml:
Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

* html/HTMLImageElement.h:
Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::nextEmbeddedViewID):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

* rendering/RenderImage.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):
* rendering/RenderLayerCompositor.h:
Make editable images require compositing implicitly.

Source/WebKit:

* Platform/spi/ios/PencilKitSPI.h: Added.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
* WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):
* WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Add a preference to enable editable images.

* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.
(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

* UIProcess/ios/WKDrawingView.h: Added.
* UIProcess/ios/WKDrawingView.mm: Added.
(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

* WebKit.xcodeproj/project.pbxproj:
* SourcesCocoa.txt:
Add the new files.

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* TestRunnerShared/spi/PencilKitTestSPI.h: Added.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

* TestExpectations:
* editing/images/basic-editable-image-expected.txt: Added.
* editing/images/basic-editable-image.html: Added.
* editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
* editing/images/reparent-editable-image-maintains-strokes.html: Added.
* platform/ios-wk2/TestExpectations:
* resources/ui-helper.js:
(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MediaStream] Screen capture should be an experimental feature on OSX only
ryanhaddad@apple.com [Mon, 12 Nov 2018 21:42:51 +0000 (21:42 +0000)]
[MediaStream] Screen capture should be an experimental feature on OSX only
https://bugs.webkit.org/show_bug.cgi?id=191552

Unreviewed test gardening.

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoShipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
don.olmstead@sony.com [Mon, 12 Nov 2018 21:41:20 +0000 (21:41 +0000)]
Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
https://bugs.webkit.org/show_bug.cgi?id=189230
<rdar://problem/44050379>

Reviewed by Joseph Pecoraro.

Runs all png images through zopflipng. This results in a smaller file
size and takes care of this issue as a byproduct.

Source/WebCore:

* Modules/modern-media-controls/images/iOS/airplay-placard@1x.png:
* Modules/modern-media-controls/images/iOS/airplay-placard@2x.png:
* Modules/modern-media-controls/images/iOS/airplay-placard@3x.png:
* Modules/modern-media-controls/images/iOS/invalid-placard@1x.png:
* Modules/modern-media-controls/images/iOS/invalid-placard@2x.png:
* Modules/modern-media-controls/images/iOS/invalid-placard@3x.png:
* Modules/modern-media-controls/images/iOS/pip-placard@1x.png:
* Modules/modern-media-controls/images/iOS/pip-placard@2x.png:
* Modules/modern-media-controls/images/iOS/pip-placard@3x.png:
* Modules/modern-media-controls/images/macOS/airplay-placard@1x.png:
* Modules/modern-media-controls/images/macOS/airplay-placard@2x.png:
* Modules/modern-media-controls/images/macOS/invalid-placard@1x.png:
* Modules/modern-media-controls/images/macOS/invalid-placard@2x.png:
* Modules/modern-media-controls/images/macOS/pip-placard@1x.png:
* Modules/modern-media-controls/images/macOS/pip-placard@2x.png:
* Resources/AttachmentPlaceholder.png:
* Resources/AttachmentPlaceholder@2x.png:
* Resources/ListButtonArrow.png:
* Resources/ListButtonArrow@2x.png:
* Resources/missingImage.png:
* Resources/missingImage@2x.png:
* Resources/missingImage@3x.png:
* Resources/moveCursor.png:
* Resources/northEastSouthWestResizeCursor.png:
* Resources/northSouthResizeCursor.png:
* Resources/northWestSouthEastResizeCursor.png:
* Resources/nullPlugin.png:
* Resources/nullPlugin@2x.png:
* Resources/panIcon.png:
* Resources/textAreaResizeCorner.png:
* Resources/textAreaResizeCorner@2x.png:
* Resources/urlIcon.png:

Source/WebInspectorUI:

* UserInterface/Images/ApplicationCache.png:
* UserInterface/Images/ApplicationCache@2x.png:
* UserInterface/Images/ApplicationCacheManifest.png:
* UserInterface/Images/ApplicationCacheManifest@2x.png:
* UserInterface/Images/Breakpoint.png:
* UserInterface/Images/Breakpoint@2x.png:
* UserInterface/Images/BreakpointInactive.png:
* UserInterface/Images/BreakpointInactive@2x.png:
* UserInterface/Images/ClippingCSS.png:
* UserInterface/Images/ClippingCSS@2x.png:
* UserInterface/Images/ClippingCSSLarge.png:
* UserInterface/Images/ClippingCSSLarge@2x.png:
* UserInterface/Images/ClippingGeneric.png:
* UserInterface/Images/ClippingGeneric@2x.png:
* UserInterface/Images/ClippingGenericLarge.png:
* UserInterface/Images/ClippingGenericLarge@2x.png:
* UserInterface/Images/ClippingJS.png:
* UserInterface/Images/ClippingJS@2x.png:
* UserInterface/Images/ClippingJSLarge.png:
* UserInterface/Images/ClippingJSLarge@2x.png:
* UserInterface/Images/ColorIcon.png:
* UserInterface/Images/ColorIcon@2x.png:
* UserInterface/Images/Cookie.png:
* UserInterface/Images/Cookie@2x.png:
* UserInterface/Images/Database.png:
* UserInterface/Images/Database@2x.png:
* UserInterface/Images/DatabaseTable.png:
* UserInterface/Images/DatabaseTable@2x.png:
* UserInterface/Images/DocumentCSS.png:
* UserInterface/Images/DocumentCSS@2x.png:
* UserInterface/Images/DocumentCSSLarge.png:
* UserInterface/Images/DocumentCSSLarge@2x.png:
* UserInterface/Images/DocumentFont.png:
* UserInterface/Images/DocumentFont@2x.png:
* UserInterface/Images/DocumentFontLarge.png:
* UserInterface/Images/DocumentFontLarge@2x.png:
* UserInterface/Images/DocumentGL.png:
* UserInterface/Images/DocumentGL@2x.png:
* UserInterface/Images/DocumentGeneric.png:
* UserInterface/Images/DocumentGeneric@2x.png:
* UserInterface/Images/DocumentGenericLarge.png:
* UserInterface/Images/DocumentGenericLarge@2x.png:
* UserInterface/Images/DocumentImage.png:
* UserInterface/Images/DocumentImage@2x.png:
* UserInterface/Images/DocumentImageLarge.png:
* UserInterface/Images/DocumentImageLarge@2x.png:
* UserInterface/Images/DocumentJS.png:
* UserInterface/Images/DocumentJS@2x.png:
* UserInterface/Images/DocumentJSLarge.png:
* UserInterface/Images/DocumentJSLarge@2x.png:
* UserInterface/Images/DocumentMarkup.png:
* UserInterface/Images/DocumentMarkup@2x.png:
* UserInterface/Images/DocumentMarkupLarge.png:
* UserInterface/Images/DocumentMarkupLarge@2x.png:
* UserInterface/Images/FolderGeneric.png:
* UserInterface/Images/FolderGeneric@2x.png:
* UserInterface/Images/GradientStop.png:
* UserInterface/Images/GradientStop@2x.png:
* UserInterface/Images/GradientStopSelected.png:
* UserInterface/Images/GradientStopSelected@2x.png:
* UserInterface/Images/HoverMenuButton.png:
* UserInterface/Images/HoverMenuButton@2x.png:
* UserInterface/Images/InstructionPointer.png:
* UserInterface/Images/InstructionPointer@2x.png:
* UserInterface/Images/LocalStorage.png:
* UserInterface/Images/LocalStorage@2x.png:
* UserInterface/Images/SessionStorage.png:
* UserInterface/Images/SessionStorage@2x.png:
* UserInterface/Images/SliderThumb.png:
* UserInterface/Images/SliderThumb@2x.png:
* UserInterface/Images/SliderThumbPressed.png:
* UserInterface/Images/SliderThumbPressed@2x.png:
* UserInterface/Images/WebSocket.png:
* UserInterface/Images/WebSocket@2x.png:
* UserInterface/Images/WebSocketLarge.png:
* UserInterface/Images/WebSocketLarge@2x.png:
* UserInterface/Images/WorkerScript.png:
* UserInterface/Images/WorkerScript@2x.png:
* UserInterface/Images/WorkerScriptLarge.png:
* UserInterface/Images/WorkerScriptLarge@2x.png:

Source/WebKit:

* Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/StartPictureInPictureButton@1x.png:
* Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/StartPictureInPictureButton@2x.png:
* Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/StartPictureInPictureButton@3x.png:
* Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/StopPictureInPictureButton@1x.png:
* Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/StopPictureInPictureButton@2x.png:
* Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/StopPictureInPictureButton@3x.png:

Source/WebKitLegacy/win:

* WebKit.resources/deleteButton.png:
* WebKit.resources/deleteButtonPressed.png:
* WebKit.resources/fsVideoAudioVolumeHigh.png:
* WebKit.resources/fsVideoAudioVolumeLow.png:
* WebKit.resources/fsVideoExitFullscreen.png:
* WebKit.resources/fsVideoPause.png:
* WebKit.resources/fsVideoPlay.png:
* WebKit.resources/missingImage.png:
* WebKit.resources/nullplugin.png:
* WebKit.resources/panEastCursor.png:
* WebKit.resources/panIcon.png:
* WebKit.resources/panNorthCursor.png:
* WebKit.resources/panNorthEastCursor.png:
* WebKit.resources/panNorthWestCursor.png:
* WebKit.resources/panSouthCursor.png:
* WebKit.resources/panSouthEastCursor.png:
* WebKit.resources/panSouthWestCursor.png:
* WebKit.resources/panWestCursor.png:
* WebKit.resources/searchCancel.png:
* WebKit.resources/searchCancelPressed.png:
* WebKit.resources/searchMagnifier.png:
* WebKit.resources/searchMagnifierResults.png:
* WebKit.resources/textAreaResizeCorner.png:
* WebKit.resources/verticalTextCursor.png:
* WebKit.resources/zoomInCursor.png:
* WebKit.resources/zoomOutCursor.png:

Tools:

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[css-grid] Import additional grid layout tests and update TestExpectations
jfernandez@igalia.com [Mon, 12 Nov 2018 21:25:07 +0000 (21:25 +0000)]
[css-grid] Import additional grid layout tests and update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=191515

Reviewed by Dean Jackson.

Imported several tests from Blink and update TextExpectaions.

* TestExpectations: Adding specific bugs for the expected failures.
* fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash-expected.txt: Added.
* fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash.html: Added.
* fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html: Added.
* fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html: Added.
* fast/css-grid-layout/crash-large-positions-expected.txt: Added.
* fast/css-grid-layout/crash-large-positions.html: Added.
* fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid-expected.txt: Added.
* fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html: Added.
* fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt: Added.
* fast/css-grid-layout/floating-not-effect-on-grid-items.html: Added.
* fast/css-grid-layout/grid-align-baseline-expected.txt: Added.
* fast/css-grid-layout/grid-align-baseline-vertical-expected.txt: Added.
* fast/css-grid-layout/grid-align-baseline-vertical.html: Added.
* fast/css-grid-layout/grid-align-baseline.html: Added.
* fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash-expected.txt: Added.
* fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash.html: Added.
* fast/css-grid-layout/grid-auto-repeat-positioned-container-expected.html: Added.
* fast/css-grid-layout/grid-auto-repeat-positioned-container.html: Added.
* fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.txt: Added.
* fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html: Added.
* fast/css-grid-layout/grid-container-percentage-columns-expected.txt:
* fast/css-grid-layout/grid-container-percentage-columns.html:
* fast/css-grid-layout/grid-container-percentage-rows-expected.txt: Added.
* fast/css-grid-layout/grid-container-percentage-rows.html: Added.
* fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin-expected.html: Added.
* fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin.html: Added.
* fast/css-grid-layout/grid-container-scroll-accounts-for-sizing-expected.html:
* fast/css-grid-layout/grid-container-scroll-accounts-for-sizing.html:
* fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width-expected.txt: Added.
* fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html: Added.
* fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content-expected.txt: Added.
* fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content.html: Added.
* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt: Added.
* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html: Added.
* fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt:
* fast/css-grid-layout/grid-crash-remove-positioned-item.html:
* fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Added.
* fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Added.
* fast/css-grid-layout/grid-item-border-overflow-paint-expected.html: Added.
* fast/css-grid-layout/grid-item-border-overflow-paint.html: Added.
* fast/css-grid-layout/grid-item-change-alignment-from-stretch-expected.txt: Added.
* fast/css-grid-layout/grid-item-change-alignment-from-stretch.html: Added.
* fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html: Added.
* fast/css-grid-layout/grid-item-grid-container-percentage-rows.html: Added.
* fast/css-grid-layout/grid-item-overflow-expected.html: Added.
* fast/css-grid-layout/grid-item-overflow-paint-expected.html: Added.
* fast/css-grid-layout/grid-item-overflow-paint.html: Added.
* fast/css-grid-layout/grid-item-overflow.html: Added.
* fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Added.
* fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Added.
* fast/css-grid-layout/grid-item-scroll-position-expected.txt: Added.
* fast/css-grid-layout/grid-item-scroll-position.html: Added.
* fast/css-grid-layout/grid-margins-not-collapse-expected.html: Added.
* fast/css-grid-layout/grid-margins-not-collapse.html: Added.
* fast/css-grid-layout/grid-painting-item-overflow-expected.html: Added.
* fast/css-grid-layout/grid-painting-item-overflow.html: Added.
* fast/css-grid-layout/grid-painting-items-only-once-expected.html: Added.
* fast/css-grid-layout/grid-painting-items-only-once.html: Added.
* fast/css-grid-layout/grid-painting-respect-dom-order-expected.html: Added.
* fast/css-grid-layout/grid-painting-respect-dom-order.html: Added.
* fast/css-grid-layout/grid-painting-rtl-expected.html: Added.
* fast/css-grid-layout/grid-painting-rtl.html: Added.
* fast/css-grid-layout/grid-self-baseline-01-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-01.html: Added.
* fast/css-grid-layout/grid-self-baseline-02-b-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-02-b.html: Added.
* fast/css-grid-layout/grid-self-baseline-02-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-02.html: Added.
* fast/css-grid-layout/grid-self-baseline-03-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-03.html: Added.
* fast/css-grid-layout/grid-self-baseline-04-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-04.html: Added.
* fast/css-grid-layout/grid-self-baseline-05-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-05.html: Added.
* fast/css-grid-layout/grid-self-baseline-06-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-06.html: Added.
* fast/css-grid-layout/grid-self-baseline-07-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-07.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-01-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-01.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-02-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-02.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-03-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-03.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-04-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-04.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-05-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-05.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-06.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-horiz-07.html: Added.
* fast/css-grid-layout/grid-self-baseline-two-dimensional-expected.txt: Added.
* fast/css-grid-layout/grid-self-baseline-two-dimensional.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-01-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-02-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-03-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-04-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-05-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-06-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-07-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-01-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-02-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-03-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-04-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-05-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-06-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-07-expected.html: Added.
* fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html: Added.
* fast/css-grid-layout/grid-shorthands-style-format-expected.txt: Added.
* fast/css-grid-layout/grid-shorthands-style-format.html: Added.
* fast/css-grid-layout/grid-strict-ordering-crash-2-expected.txt: Added.
* fast/css-grid-layout/grid-strict-ordering-crash-2.html: Added.
* fast/css-grid-layout/named-grid-areas-dynamic-with-media-query-expected.html: Added.
* fast/css-grid-layout/named-grid-areas-dynamic-with-media-query.html: Added.
* fast/css-grid-layout/negative-growth-share-as-infinity-crash-expected.txt: Added.
* fast/css-grid-layout/negative-growth-share-as-infinity-crash.html: Added.
* fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area-expected.html: Added.
* fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area.html: Added.
* fast/css-grid-layout/positioned-grid-container-item-percentage-size-expected.html: Added.
* fast/css-grid-layout/positioned-grid-container-item-percentage-size.html: Added.
* fast/css-grid-layout/positioned-grid-container-percentage-tracks-expected.txt: Added.
* fast/css-grid-layout/positioned-grid-container-percentage-tracks.html: Added.
* fast/css-grid-layout/preferred-width-computed-after-layout-expected.txt: Added.
* fast/css-grid-layout/preferred-width-computed-after-layout.html: Added.
* fast/css-grid-layout/quirks-mode-percent-resolution-grid-item-expected.txt: Added.
* fast/css-grid-layout/quirks-mode-percent-resolution-grid-item.html: Added.
* fast/css-grid-layout/resources/blue-100x50.png: Added.
* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
(testGridPositionDefinitionsValues):
* fast/css-grid-layout/scrolled-grid-painting-expected.html: Added.
* fast/css-grid-layout/scrolled-grid-painting-overflow-expected.html: Added.
* fast/css-grid-layout/scrolled-grid-painting-overflow.html: Added.
* fast/css-grid-layout/scrolled-grid-painting.html: Added.
* fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash-expected.txt: Added.
* fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash.html: Added.
* fast/css-grid-layout/stale-grid-layout-2-expected.txt: Added.
* fast/css-grid-layout/stale-grid-layout-expected.txt: Added.
* fast/css-grid-layout/vertical-align-do-not-effect-grid-items-expected.html: Added.
* fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoModernize WebKit Tools Xcode projects for localization's sake
timothy_horton@apple.com [Mon, 12 Nov 2018 21:19:49 +0000 (21:19 +0000)]
Modernize WebKit Tools Xcode projects for localization's sake
https://bugs.webkit.org/show_bug.cgi?id=191495

Reviewed by Alexey Proskuryakov.

* ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
* FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
* ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
These are less important because they're not localized, but since
I made the style checker complain, it now complains any time anyone
touches any of these projects... so upgrade them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agowebkitpy: Check for specific process instead of using data migrator
jbedard@apple.com [Mon, 12 Nov 2018 19:59:34 +0000 (19:59 +0000)]
webkitpy: Check for specific process instead of using data migrator
https://bugs.webkit.org/show_bug.cgi?id=191551
<rdar://problem/45993156>

Rubber-stamped by Aakash Jain.

It's possible for the data migrator process to be stuck, but for a simulator to be
usable. Use device-specific processes to detect when a device is usable.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._wait_until_device_is_usable):
(SimulatedDeviceManager):
(SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
since this implies that a device is booted.
(SimulatedDeviceManager.swap): Ditto.
(SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
process indicating the device is usable can be found.
(SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
* Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
it triggers the logic in is_usable()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRealtimeOutgoing A/V sources should observe their sources only if having a sink
youenn@apple.com [Mon, 12 Nov 2018 19:49:13 +0000 (19:49 +0000)]
RealtimeOutgoing A/V sources should observe their sources only if having a sink
https://bugs.webkit.org/show_bug.cgi?id=191490

Reviewed by Eric Carlson.

Source/WebCore:

Observe the source that generates media based on the sinks:
- Do not observe at creation time
- For first sink, start observing
- When no more sink, stop observing
Apply this principle for both outgoing audio and video sources.
Add locks for the sinks to ensure thread-safety.
Make sinks HashSet which is more robust.

Do some refactoring to better isolate generic outgoing sources from Cocoa/GTK implementations.

Covered by existing tests and updated webrtc/remove-track.html.

* platform/mediastream/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::~RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::stop):
(WebCore::RealtimeOutgoingAudioSource::AddSink):
(WebCore::RealtimeOutgoingAudioSource::RemoveSink):
(WebCore::RealtimeOutgoingAudioSource::sendAudioFrames):
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::~RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::observeSource):
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::stop):
(WebCore::RealtimeOutgoingVideoSource::AddOrUpdateSink):
(WebCore::RealtimeOutgoingVideoSource::RemoveSink):
* platform/mediastream/RealtimeOutgoingVideoSource.h:
(WebCore::RealtimeOutgoingVideoSource::isSilenced const):
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:
(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceCocoa::pullAudioData):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
(WebCore::RealtimeOutgoingVideoSourceCocoa::sampleBufferUpdated):

LayoutTests:

* webrtc/remove-track-expected.txt:
* webrtc/remove-track.html:
Add tests and fixed some flakiness issues on existing tests in the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MediaStream] Screen capture should be an experimental feature on OSX only
eric.carlson@apple.com [Mon, 12 Nov 2018 19:23:04 +0000 (19:23 +0000)]
[MediaStream] Screen capture should be an experimental feature on OSX only
https://bugs.webkit.org/show_bug.cgi?id=191552
<rdar://problem/45994142>

Reviewed by Youenn Fablet.

* Shared/WebPreferences.yaml: Make ScreenCaptureEnabled.condition ENABLE(MEDIA_STREAM) && PLATFORM(MAC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSupport setting stream ids when adding a transceiver
youenn@apple.com [Mon, 12 Nov 2018 19:12:28 +0000 (19:12 +0000)]
Support setting stream ids when adding a transceiver
https://bugs.webkit.org/show_bug.cgi?id=191307

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
* web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Add support for streams in RTCTransceiverInit.
Add plumbing down to libwebrtc.
Covered by rebased tests.

* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::fromRtpTransceiverInit):

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoResurrect WebKitTestRunner for Windows port
commit-queue@webkit.org [Mon, 12 Nov 2018 18:58:01 +0000 (18:58 +0000)]
Resurrect WebKitTestRunner for Windows port
https://bugs.webkit.org/show_bug.cgi?id=189257

Patch by Takashi Komori <Takashi.Komori@sony.com> on 2018-11-12
Reviewed by Fujii Hironori.

.:

* Source/cmake/OptionsWin.cmake:

Source/WebKit:

* PlatformWin.cmake:

Tools:

Implement WebKitTestRunner for WinCairo.

* PlatformWin.cmake:
* Scripts/build-webkittestrunner:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::rangeToStr):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
(WTR::AccessibilityController::resetToConsistentState):
(WTR::AccessibilityController::accessibleElementById):
(WTR::AccessibilityController::platformName):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
* WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex const):
(WTR::AccessibilityUIElement::selectedChildrenCount const):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::uiElementAttributeValue const):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::computedRoleString):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation const):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue const):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isPressActionSupported):
(WTR::AccessibilityUIElement::isIncrementActionSupported):
(WTR::AccessibilityUIElement::isDecrementActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired const):
(WTR::AccessibilityUIElement::isFocused const):
(WTR::AccessibilityUIElement::isSelected const):
(WTR::AccessibilityUIElement::isSelectedOptionActive const):
(WTR::AccessibilityUIElement::isExpanded const):
(WTR::AccessibilityUIElement::isChecked const):
(WTR::AccessibilityUIElement::isIndeterminate const):
(WTR::AccessibilityUIElement::hierarchicalLevel const):
(WTR::AccessibilityUIElement::speakAs):
(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::ariaDropEffects const):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild const):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
(WTR::AccessibilityUIElement::removeSelectionAtIndex const):
(WTR::AccessibilityUIElement::clearSelectedChildren const):
(WTR::AccessibilityUIElement::accessibilityValue const):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable const):
(WTR::AccessibilityUIElement::isSelectable const):
(WTR::AccessibilityUIElement::isMultiSelectable const):
(WTR::AccessibilityUIElement::isVisible const):
(WTR::AccessibilityUIElement::isOffScreen const):
(WTR::AccessibilityUIElement::isCollapsed const):
(WTR::AccessibilityUIElement::isIgnored const):
(WTR::AccessibilityUIElement::isSingleLine const):
(WTR::AccessibilityUIElement::isMultiLine const):
(WTR::AccessibilityUIElement::hasPopup const):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::supportedActions const):
(WTR::AccessibilityUIElement::pathDescription const):
(WTR::AccessibilityUIElement::mathPostscriptsDescription const):
(WTR::AccessibilityUIElement::mathPrescriptsDescription const):
(WTR::AccessibilityUIElement::classList const):
(WTR::AccessibilityUIElement::characterAtOffset):
(WTR::AccessibilityUIElement::wordAtOffset):
(WTR::AccessibilityUIElement::lineAtOffset):
(WTR::AccessibilityUIElement::sentenceAtOffset):
* WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
(WTR::activateFonts):
(WTR::installFakeHelvetica):
(WTR::uninstallFakeHelvetica):
* WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
* WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
* WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::inspectorTestStubURL):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::installFakeHelvetica):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/PlatformWin.cmake: Added.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::createTestURL):
* WebKitTestRunner/TestInvocation.cpp:
* WebKitTestRunner/WebKitTestRunnerPrefix.h:
* WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):
* WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
(WTR::registerWindowClass):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::didInitializeClients):
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::makeWebViewFirstResponder):
(WTR::generateCairoSurfaceFromBitmap):
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::changeWindowScaleIfNeeded):
(WTR::PlatformWebView::setNavigationGesturesEnabled):
(WTR::PlatformWebView::forceWindowFramesChanged):
(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):
* WebKitTestRunner/win/TestControllerWin.cpp: Added.
(WTR::exceptionFilter):
(WTR::runRunLoopUntil):
(WTR::TestController::notifyDone):
(WTR::TestController::setHidden):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformPreferences):
(WTR::TestController::platformDestroy):
(WTR::toWK):
(WTR::TestController::platformInitializeContext):
(WTR::TestController::platformRunUntil):
(WTR::TestController::platformDidCommitLoadForFrame):
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
(WTR::TestController::runModal):
(WTR::TestController::platformContext):
(WTR::TestController::platformLibraryPathForTesting):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::platformResetPreferencesToConsistentValues):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
* WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
* WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
(dllLauncherEntryPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSupport dynamic pseudo-classes on elements with display: contents
antti@apple.com [Mon, 12 Nov 2018 18:55:17 +0000 (18:55 +0000)]
Support dynamic pseudo-classes on elements with display: contents
https://bugs.webkit.org/show_bug.cgi?id=181640
<rdar://problem/36605415>

Reviewed by Dean Jackson.

Source/WebCore:

The code for :hover and :active style invalidation assumes that only elements with renderer need invalidation.

This patch fixes '.display-content-element:hover span' case but not '.display-content-element:hover' case but
includes tests for both. The latter is not super useful anyway (as it only affects rendering with inherited
text properties).

Test: fast/css/display-contents-hover-active.html

* dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):

    Traverse up in composed tree instead of render tree when invalidating. This has the same order as render tree
    but also includes display:content elements. This also allows removing the special display:none case.

* dom/Element.cpp:
(WebCore::Element::setActive):
(WebCore::Element::setHovered):

    Also look into display:contents style for invalidation checks.

(WebCore::Element::renderOrDisplayContentsStyle const):

    Make this helper an Element member.

* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::parentElementInComposedTree const):

    Support starting from a PseudoElement. This is consistent with ComposedTreeAncestorIterator.

* rendering/updating/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::nextSiblingRenderer const):
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::shouldResolveElement):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::renderOrDisplayContentsStyle): Deleted.

    Use the Element::renderOrDisplayContentsStyle() instead.

LayoutTests:

* fast/css/display-contents-hover-active-expected.txt: Added.
* fast/css/display-contents-hover-active.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Styles: Pressing Tab or Enter should start editing focused property
nvasilyev@apple.com [Mon, 12 Nov 2018 18:09:23 +0000 (18:09 +0000)]
Web Inspector: Styles: Pressing Tab or Enter should start editing focused property
https://bugs.webkit.org/show_bug.cgi?id=191510
<rdar://problem/45970897>

Reviewed by Dean Jackson.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Web Animations] Turn Web Animations experimental
commit-queue@webkit.org [Mon, 12 Nov 2018 18:00:12 +0000 (18:00 +0000)]
[Web Animations] Turn Web Animations experimental
https://bugs.webkit.org/show_bug.cgi?id=191543

Patch by Antoine Quint <graouts@apple.com> on 2018-11-12
Reviewed by Dean Jackson.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:

Source/WebKit:

* Shared/WebPreferences.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agofeFlood with alpha color doesn't work correctly
simon.fraser@apple.com [Mon, 12 Nov 2018 17:58:56 +0000 (17:58 +0000)]
feFlood with alpha color doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=163666

Reviewed by Zalan Bujtas.
Source/WebCore:

FEFlood::platformApplySoftware() erroneously used colorWithOverrideAlpha()
rather than multiplying the flood color with the flood opacity as other browsers do.

Test: svg/filters/feFlood-with-alpha-color.html

* platform/graphics/Color.cpp:
(WebCore::Color::colorWithAlpha const): I tried using colorWithAlphaMultipliedBy() elsewhere,
and it triggered a behavior change, so add a comment.
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::platformApplySoftware):
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::stopColorIncludingOpacity const):

LayoutTests:

* svg/filters/feFlood-with-alpha-color-expected.html: Added.
* svg/filters/feFlood-with-alpha-color.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRequire <iframe allow="display"> for an iframe to use getDisplayMedia
eric.carlson@apple.com [Mon, 12 Nov 2018 17:18:48 +0000 (17:18 +0000)]
Require <iframe allow="display"> for an iframe to use getDisplayMedia
https://bugs.webkit.org/show_bug.cgi?id=191505
<rdar://problem/45968811>

Reviewed by Jer Noble.

LayoutTests/imported/w3c:

* web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt:

Source/WebCore:

Test: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html

* Modules/mediastream/MediaDevicesRequest.cpp:
(WebCore::MediaDevicesRequest::start):
* Modules/mediastream/UserMediaController.cpp:
(WebCore::isAllowedToUse):
(WebCore::UserMediaController::canCallGetUserMedia):
(WebCore::UserMediaController::logGetUserMediaDenial):
* Modules/mediastream/UserMediaController.h:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):

LayoutTests:

* http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
* http/tests/media/media-stream/get-display-media-iframe-allow-attribute-expected.txt: Added.
* http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html: Added.
* http/tests/media/media-stream/resources/get-display-media-devices-iframe.html: Added.
* http/tests/ssl/media-stream/get-user-media-different-host-expected.txt:
* http/tests/ssl/media-stream/get-user-media-nested-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMake compositing updates incremental
simon.fraser@apple.com [Mon, 12 Nov 2018 17:14:05 +0000 (17:14 +0000)]
Make compositing updates incremental
https://bugs.webkit.org/show_bug.cgi?id=90342

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, updating compositing layers required two full RenderLayer tree traversals,
and all the work was done for every RenderLayer on each composting update. This could be expensive
on pages with lots of RenderLayers.

These changes make compositing updates more incremental. Compositing updates still require
two tree traversals. The first determines which RenderLayers need to be composited (of those which
weren't already made composited at style-change time), because of reasons that can only be determined
post-layout, and indirect reasons including overlap. The second traversal updates the configuration, geometry
and GraphicsLayer tree for the composited layers. Dependencies on both descendant and ancestor state make
it hard to fold these two traversals together.

In order to minimize the work done during these traversals, dirty bits are stored on RenderLayers,
and propagated to ancestor layers in paint order. There are two sets of bits: those related to the first
"compositing requirements" traversal, and those related to the second "update backing and hierarchy" traversal.
When a RenderLayer gets a dirty bit set, bits are propagated to ancestors to indicate that children need
to be visited.

Sadly entire subtrees can't be skipped during the "compositing requirements" traversal becaue we still have
to accumulate overlap rects, but RenderLayerCompositor::traverseUnchangedSubtree() is used to minimize
work in that case. Subtrees can be skipped in the "update backing and hierarchy" traveral. Entire traversals can
be skipped if no change has triggered the need for that traversal.

These changes fix a correctness issue where transform changes now trigger overlap re-evaluation, which causes
more layer geometry updates than before. This regressed the MotionMark "Focus" test, when geometry updates
triggered layer resizes as the filter blur radius changed, which then triggered repaints. This is fixed by
excluding composited filters from the composited bounds (but still taking them into account for overlap).

Care is taken to avoid triggering traversals in non-composited documents (tested by no-updates-in-non-composited-iframe.html).

Code to set the dirty bits is added in various places that change properties that compositing depends on.

These changes also subsume the patch in 176196; we now never consult properties that rely on layout from the
style change code path, and the only call stack for geometry updates is from the "update backing and hierarchy"
traversal, which is always a pre-order traversal.

Tests: compositing/geometry/stacking-context-change-layer-reparent.html
       compositing/layer-creation/change-to-overlap.html
       compositing/updates/no-updates-in-non-composited-iframe.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::markContextChanged): Need to differentiate between a canvas becoming composited
for the first time, and its pixels changing with a new 'CanvasPixelsChanged' value.
* page/FrameView.cpp:
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackdropFilters): If we just made a layer for backdrops, we need to update sublayers.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::shouldBeStackingContext const):
(WebCore::RenderLayer::stackingContext const):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::setAncestorsHaveCompositingDirtyFlag):
(WebCore::RenderLayer::contentChanged):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::enclosingCompositingLayer const):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint const):
(WebCore::RenderLayer::clippingRootForPainting const):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):
(WebCore::compositingContainer): Deleted.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::clearZOrderLists):
(WebCore::RenderLayer::paintOrderParent const):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::setRequiresBackgroundLayer):
(WebCore::RenderLayerBacking::updateMaskingLayer):
(WebCore::RenderLayerBacking::paintsContent const):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::setCompositedBounds):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::CompositingState::CompositingState):
(WebCore::RenderLayerCompositor::enableCompositingMode):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlagsAfterLayout):
(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::clippingChanged):
(WebCore::styleAffectsLayerGeometry):
(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::RenderLayerCompositor::needsCompositingUpdateForStyleChangeOnNonCompositedLayer const):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer const):
(WebCore::RenderLayerCompositor::computeExtent const):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::rootLayerConfigurationChanged):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::needsToBeComposited const):
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::clippedByAncestor const):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo const):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters const):
(WebCore::RenderLayerCompositor::requiresCompositingForWillChange const):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin const):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
(WebCore::RenderLayerCompositor::styleChangeMayAffectIndirectCompositingReasons):
(WebCore::RenderLayerCompositor::fixedLayerIntersectsViewport const):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::rootOrBodyStyleChanged):
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
(WebCore::operator<<):
(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): Deleted.
(WebCore::checkIfDescendantClippingContextNeedsUpdate): Deleted.
(WebCore::isScrollableOverflow): Deleted.
(WebCore::styleHasTouchScrolling): Deleted.
(WebCore::styleChangeRequiresLayerRebuild): Deleted.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Deleted.
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged): Deleted.
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Deleted.
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): Deleted.
* rendering/RenderLayerCompositor.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):

Source/WebKitLegacy/mac:

Fix spelling error.

* WebView/WebView.mm:
(-[WebView _setMediaLayer:forPluginView:]):

LayoutTests:

Add some new tests for issues discovered during development.

Filter tests get new results because composited layer bounds are no longer affected
by pixel-moving filters.

* compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
* compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
* compositing/geometry/stacking-context-change-layer-reparent-expected.html: Added.
* compositing/geometry/stacking-context-change-layer-reparent.html: Added.
* compositing/layer-creation/change-to-overlap-expected.txt: Added.
* compositing/layer-creation/change-to-overlap.html: Added.
* compositing/updates/no-updates-in-non-composited-iframe-expected.txt: Added.
* compositing/updates/no-updates-in-non-composited-iframe.html: Added.
* compositing/updates/resources/non-composited.html: Added.
* compositing/video/video-clip-change-src.html: This test was timing-sensitive; the behavior differed bases on whether we
happened to do a compositing flush between the first and second video load.
* platform/mac-wk1/TestExpectations: Mark compositing/layer-creation/fixed-overlap-extent.html as flakey; it depends on the
timing of various AppKit-related things that aren't consistent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoCSSCalcOperation constructor wastes 6KB of Vector capacity on cnn.com
commit-queue@webkit.org [Mon, 12 Nov 2018 16:49:50 +0000 (16:49 +0000)]
CSSCalcOperation constructor wastes 6KB of Vector capacity on cnn.com
https://bugs.webkit.org/show_bug.cgi?id=190839

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-12
Reviewed by Frédéric Wang.

The CSSCalcOperation ctor that takes a leftSide and rightSide parameter
wastes memory since it will always have size 2 but claims the
default Vector size. So make sure to reserve an initial capacity of 2.

* css/CSSCalculationValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWTFMove(xxx) is used in arguments while other arguments touch xxx
yusukesuzuki@slowstart.org [Mon, 12 Nov 2018 16:48:22 +0000 (16:48 +0000)]
WTFMove(xxx) is used in arguments while other arguments touch xxx
https://bugs.webkit.org/show_bug.cgi?id=191544

Reviewed by Alex Christensen.

The order of the evaluation of C++ arguments is undefined. If we use WTFMove(xxx),
xxx should not be touched in the other arguments. This patch fixes such uses in
IDB code.

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::scheduleOperation):
* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):
* Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::registerIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][IFC] Construct dedicated runs when the inline element requires it.
zalan@apple.com [Mon, 12 Nov 2018 16:18:08 +0000 (16:18 +0000)]
[LFC][IFC] Construct dedicated runs when the inline element requires it.
https://bugs.webkit.org/show_bug.cgi?id=191509

Reviewed by Antti Koivisto.

In certain cases, a run can overlap multiple inline elements like this:

<span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span>

The content above generates one long run <normal text contentbut this one needs dedicated runend of text> <- input to line breaking.
However, since the middle run is positioned, it needs to be moved independently from the rest of the content, hence it needs a dedicated inline run.

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::contentRequiresSeparateRun):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
* layout/inlineformatting/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::inlineFormattingState const):
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::InlineLineBreaker::nextRun): mid-word breaking is not implemented yet.
* layout/inlineformatting/InlineRun.h:
(WebCore::Layout::InlineRun::overlapsMultipleInlineItems const):
* layout/inlineformatting/InlineRunProvider.cpp:
(WebCore::Layout::InlineRunProvider::processInlineTextItem):
* layout/inlineformatting/InlineRunProvider.h:
(WebCore::Layout::InlineRunProvider::Run::TextContext::expand):
(WebCore::Layout::InlineRunProvider::Run::textContext):
(WebCore::Layout::InlineRunProvider::Run::TextContext::setStart): Deleted.
(WebCore::Layout::InlineRunProvider::Run::TextContext::setLength): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MSE] Frame re-ordering can cause iframes to never be enqueued
jer.noble@apple.com [Mon, 12 Nov 2018 15:12:35 +0000 (15:12 +0000)]
[MSE] Frame re-ordering can cause iframes to never be enqueued
https://bugs.webkit.org/show_bug.cgi?id=191485

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-dropped-iframe.html

Some frame re-ordering techniques result in files where the first frame has a
decode timestamp < 0, but a presentation timestamp >= 0. When appending these
samples to existing content, we can fail to enqueue the first frame because its
DTS overlaps an existing sample, but the presentation timestamp does not.
Rather than try to only enqueue samples whose decode timestamps are > than the
greatest decode end timestamp (minus some fudge factor), allow all frames to be
added to the decode queue if they are strictly ordered greater than the last
enqueued frame.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::provideMediaData):
(WebCore::SourceBuffer::reenqueueMediaForTime):

LayoutTests:

* media/media-source/media-source-dropped-iframe-expected.txt: Added.
* media/media-source/media-source-dropped-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoIDBTransaction does not use "RefPtr<IDBTransaction> self"
yusukesuzuki@slowstart.org [Mon, 12 Nov 2018 14:55:03 +0000 (14:55 +0000)]
IDBTransaction does not use "RefPtr<IDBTransaction> self"
https://bugs.webkit.org/show_bug.cgi?id=190436

Reviewed by Alex Christensen.

It seems that `RefPtr<IDBTransaction> self;` is not effective since it does not capture anything.
Use `protectedThis = makeRef(*this)` instead.

No behavior change.

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MSE][GStreamer] Introduce AbortableTaskQueue
aboya@igalia.com [Mon, 12 Nov 2018 14:40:26 +0000 (14:40 +0000)]
[MSE][GStreamer] Introduce AbortableTaskQueue
https://bugs.webkit.org/show_bug.cgi?id=190902

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

A new synchronization primitive is introduced: AbortableTaskQueue,
which allows to send work to the main thread from a background thread
with the option to perform two-phase cancellation (startAborting() and
finishAborting()).

This new primitive has been used to overhaul GstBus messaging in
AppendPipeline. A lot of code made redundant has been deleted in the
process and lots of internal functions were now able to be made
private. As part of the refactor all glib signals in AppendPipeline
now use lambdas. All usages of WTF::isMainThread() in AppendPipeline
have been replaced by isMainThread() for consistency with the rest of
WebKit.

Two-phase cancellation is still not used in AppendPipeline as of this
patch, but it will be used in a future patch that makes use of
GStreamer flushes to implement correct MSE abort semantics. There are
unit tests to ensure it works correctly, even if it's still not used.

* WebCore.xcodeproj/project.pbxproj:
* platform/AbortableTaskQueue.h: Added.
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::dumpAppendState):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe):
(WebCore::AppendPipeline::handleAppsinkNewSampleFromAnyThread):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::sourceBufferPrivate):
(WebCore::AppendPipeline::appsinkCaps):
(WebCore::AppendPipeline::track):
(WebCore::AppendPipeline::demuxerSrcPadCaps):
(WebCore::AppendPipeline::playerPrivate):

Tools:

Tests for AbortableTaskQueue are included.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
(TestWebKitAPI::TEST):
(TestWebKitAPI::FancyResponse::FancyResponse):
(TestWebKitAPI::FancyResponse::operator=):
(TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[GStreamer][EME] waitingforkey event should consider decryptors' waiting status
calvaris@igalia.com [Mon, 12 Nov 2018 12:40:12 +0000 (12:40 +0000)]
[GStreamer][EME] waitingforkey event should consider decryptors' waiting status
https://bugs.webkit.org/show_bug.cgi?id=191459

Reviewed by Carlos Garcia Campos.

The new cross platform architecture to report waitingforkey and
recover from it requires a more accurate knowledge of what is
going on with the decryptors because events are reported only once
(per key exchange run) and crossplatform only continues if we are
actually ready to continue, meaning that no decryptors are
waiting.

* platform/graphics/gstreamer/GUniquePtrGStreamer.h: Added
GstIterator deleter.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::setWaitingForKey): Bail
out if we are requested to not wait anymore but there are still
waiting decryptors.
(WebCore::MediaPlayerPrivateGStreamerBase::waitingForKey const):
Query the pipeline, just a query after pipeline is built and
manual inspection during build. The query is optimal but sometimes
we can get this request when the pipeline is under construction so
queries do not arrive at the decryptors and we have to deliver it
by ourselves.
(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:
Deleted because it is now inlined.
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorDecrypt): Fixed small compiler warning.
* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkit_media_common_encryption_decrypt_class_init): Override
query method.
(webkitMediaCommonEncryptionDecryptTransformInPlace): When the
decryptor is going to block to wait, report before. When the
decryptor receives the key, report it got it.
(webkitMediaCommonEncryptionDecryptSinkEventHandler): Do not
handle waitingforkey here.
(webkitMediaCommonEncryptionDecryptorQueryHandler): Report if the
decryptor is waiting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[GTK] Silence ATK_XY_PARENT warnings
mcatanzaro@igalia.com [Mon, 12 Nov 2018 09:05:49 +0000 (09:05 +0000)]
[GTK] Silence ATK_XY_PARENT warnings
https://bugs.webkit.org/show_bug.cgi?id=191504

Reviewed by Carlos Garcia Campos.

* accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
(atkToContents):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textExtents):
* accessibility/atk/WebKitAccessibleUtil.cpp:
(contentsRelativeToAtkCoordinateType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agorun-bindings-tests is timing out in some WinCairo bots
Hironori.Fujii@sony.com [Mon, 12 Nov 2018 02:00:59 +0000 (02:00 +0000)]
run-bindings-tests is timing out in some WinCairo bots
https://bugs.webkit.org/show_bug.cgi?id=191348

Reviewed by Alex Christensen.

BuildBot kills run-bindings-tests if it outputs nothing for 20
minutes. run-bindings-tests runs very slowly in WinCairo Docker,
and it takes more than 30 minutes to finish. And, Windows Python
buffers the progress output.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.detect_changes): Call sys.stdout.flush() after the
test case result is output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoImplement a new edit command to change the enclosing list type
wenson_hsieh@apple.com [Mon, 12 Nov 2018 01:39:27 +0000 (01:39 +0000)]
Implement a new edit command to change the enclosing list type
https://bugs.webkit.org/show_bug.cgi?id=191487
<rdar://problem/45955922>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for a new edit command that changes the type of the enclosing list element around the selection from
unordered to ordered list and vice versa. This new edit command is exposed only to internal WebKit2 clients, via
SPI on WKWebView (`-_changeListType:`).

This is currently intended for use in Mail compose, but may also be adopted by legacy Notes in the future. As
such, the behavior of this editing command mostly matches shipping behavior in Mail compose (which is currently
implemented entirely by Mail). See below for more details.

Test:   editing/execCommand/change-list-type.html
        WKWebViewEditActions.ChangeListType

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* editing/ChangeListTypeCommand.cpp: Added.
(WebCore::listConversionTypeForSelection):
(WebCore::ChangeListTypeCommand::listConversionType):

Helper that returns a potential list conversion command that may be executed at the given document's selection,
if any exists. We also use existing logic from Mail here to determine which list to change, by walking up the
DOM from the lowest common ancestor container of the current selection until we hit the first list element.

(WebCore::ChangeListTypeCommand::createNewList):

Helper method to create a new list element to replace the given list, and then clone element data from the given
list to the new list. This addresses an existing bug in Mail, wherein changing list type for an enclosing list
which contains inline style properties drops the inline styles, because existing logic in Mail that implements
this editing command only copies the `class` attribute of the old list to the new list.

(WebCore::ChangeListTypeCommand::doApply):

Apply the edit command by running the following steps:
-   Find the enclosing list element, if any (see above).
-   Create a new list element of the opposite type as the enclosing list, and clone over element data from the
    list element being replaced.
-   Insert the new list next to the original list.
-   Move all children of the original list to the new list.
-   Remove the original list.
-   Set the selection to the end of the new list.

* editing/ChangeListTypeCommand.h: Added.
* editing/EditAction.h:

Add a pair of new edit actions for conversion from unordered list to ordered list and vice versa.

* editing/Editor.cpp:
(WebCore::Editor::changeSelectionListType):

Implement this by creating and applying a new ChangeListTypeCommand.

(WebCore::Editor::canChangeSelectionListType): Deleted.

Remove this for now, since there's no need for it until full support for edit command validation is implemented.

* editing/Editor.h:
* testing/Internals.cpp:
(WebCore::Internals::changeSelectionListType):
* testing/Internals.h:
* testing/Internals.idl:

Add internal hooks to change list type from layout tests.

Source/WebKit:

* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::nameForEditAction):

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Remove preflight checks for these list editing commands. These are not necessary because these commands fall
back to being noops if these checks return false. This avoids an extraneous ancestor walk to determine the
enclosing list element when changing list type.

Source/WebKitLegacy/mac:

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

* WebCoreSupport/WebEditorClient.mm:
(undoNameForEditAction):

Tools:

Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
(-[TestWKWebView setPosition:offset:]):
(-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
(TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.

LayoutTests:

Add a new layout test to verify that the list change type editing command can be used to swap between enclosing
ordered and unordered lists. Also exercises undo, redo, changing list types under `pre` and `table` elements,
and handling selection within nested list elements.

* editing/execCommand/change-list-type-expected.txt: Added.
* editing/execCommand/change-list-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[css-grid] Import additional grid layout test from the WPT suite
jfernandez@igalia.com [Sun, 11 Nov 2018 22:22:33 +0000 (22:22 +0000)]
[css-grid] Import additional grid layout test from the WPT suite
https://bugs.webkit.org/show_bug.cgi?id=191369

Reviewed by Manuel Rego Casasnovas.

New Grid Layout tests from the WPT suite.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* web-platform-tests/css/css-grid/META.yml: Added.
* web-platform-tests/css/css-grid/OWNERS: Removed.
* web-platform-tests/css/css-grid/abspos/support/grid.css:
(.thirdRowThirdColumn):
* web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html: Added.
* web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:
* web-platform-tests/css/css-grid/alignment/support/style-change.js:
(evaluateStyleChangeMultiple):
* web-platform-tests/css/css-grid/alignment/support/w3c-import.log:
* web-platform-tests/css/css-grid/alignment/test-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/w3c-import.log:
* web-platform-tests/css/css-grid/grid-definition/support/grid.css:
(.thirdRowThirdColumn):
* web-platform-tests/css/css-grid/grid-definition/support/w3c-import.log:
* web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html: Added.
* web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001.html: Added.
* web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html: Added.
* web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width-expected.html: Added.
* web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width.html: Added.
* web-platform-tests/css/css-grid/grid-items/support/grid.css:
(.thirdRowThirdColumn):
* web-platform-tests/css/css-grid/grid-items/support/w3c-import.log:
* web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width-expected.html: Added.
* web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width.html: Added.
* web-platform-tests/css/css-grid/grid-items/w3c-import.log:
* web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html: Added.
* web-platform-tests/css/css-grid/grid-model/support/grid.css:
(.thirdRowThirdColumn):
* web-platform-tests/css/css-grid/grid-model/support/w3c-import.log:
* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
* web-platform-tests/css/css-grid/implicit-grids/w3c-import.log:
* web-platform-tests/css/css-grid/inheritance-expected.txt: Added.
* web-platform-tests/css/css-grid/inheritance.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001-expected.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001-expected.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001-expected.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001-expected.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
* web-platform-tests/css/css-grid/parsing/grid-area-invalid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-area-invalid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-area-valid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid.html: Added.
* web-platform-tests/css/css-grid/parsing/grid-template-areas-valid-expected.txt: Added.
* web-platform-tests/css/css-grid/parsing/grid-template-areas-valid.html: Added.
* web-platform-tests/css/css-grid/parsing/w3c-import.log: Added.
* web-platform-tests/css/css-grid/placement/w3c-import.log:
* web-platform-tests/css/css-grid/test-plan/w3c-import.log:
* web-platform-tests/css/css-grid/w3c-import.log:
* web-platform-tests/css/support/META.yml: Added.
* web-platform-tests/css/support/OWNERS: Removed.
* web-platform-tests/css/support/computed-testcommon.js: Added.
(test_computed_value):
* web-platform-tests/css/support/grid.css:
(.thirdRowThirdColumn):
* web-platform-tests/css/support/inheritance-testcommon.js: Added.
(assert_initial):
* web-platform-tests/css/support/parsing-testcommon.js: Added.
(test_valid_value):
* web-platform-tests/css/support/support/w3c-import.log:
* web-platform-tests/css/support/w3c-import.log:

LayoutTests:

* TestExpectations: Added bugs and ImageOnlyFailure for 3 tests that are failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Draw caps lock indicator in password fields
dbates@webkit.org [Sun, 11 Nov 2018 21:32:53 +0000 (21:32 +0000)]
[iOS] Draw caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Source/WebCore:

Reviewed by Dean Jackson.

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac.

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

* WebCore.xcodeproj/project.pbxproj:
* page/EventHandler.cpp:
(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().
* page/EventHandler.h:
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.
* platform/ios/KeyEventIOS.mm:
(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.
* platform/ios/WebEvent.h:
* platform/ios/WebEvent.mm:
(+[WebEvent modifierFlags]): Added.
* platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
* rendering/RenderThemeCocoa.h:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Reviewed by Dean Jackson.

Forward declare some more SPI.

* pal/spi/ios/GraphicsServicesSPI.h:
* pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Reviewed by Dean Jackson.

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Reviewed by Dean Jackson.

Update the caps lock state when a hardware keyboard is attached or detached.

* WebView/WebHTMLView.mm:
(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Reviewed by Dean Jackson.

Expose some more symbols.

* WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

LayoutTests:

Unreviewed.

Update expected results now that iOS supports showing the caps lock indictor.

* platform/ios/fast/css/text-overflow-input-expected.txt:
* platform/ios/fast/forms/basic-inputs-expected.txt:
* platform/ios/fast/forms/input-appearance-height-expected.txt:
* platform/ios/fast/forms/input-value-expected.txt:
* platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/ios/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][BFC] In-flow positioned logic is really formatting context dependent.
zalan@apple.com [Sun, 11 Nov 2018 21:29:12 +0000 (21:29 +0000)]
[LFC][BFC] In-flow positioned logic is really formatting context dependent.
https://bugs.webkit.org/show_bug.cgi?id=191512

Reviewed by Simon Fraser.

Move block formatting context specific code from FormattingContext to BlockFormattingContext.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.
* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.
* layout/inlineformatting/InlineFormattingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
mitz@apple.com [Sun, 11 Nov 2018 20:00:01 +0000 (20:00 +0000)]
ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
https://bugs.webkit.org/show_bug.cgi?id=191514

Reviewed by Geoffrey Garen.

Source/WebKit:

Test: WebKitCocoa/WKProcessPoolConfiguration.mm

* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoAddress post-review comments after r237955
mmaxfield@apple.com [Sun, 11 Nov 2018 17:13:40 +0000 (17:13 +0000)]
Address post-review comments after r237955
https://bugs.webkit.org/show_bug.cgi?id=191496

Reviewed by Darin Adler.

Source/WebCore:

* rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
* style/InlineTextBoxStyle.cpp:
(WebCore::computeUnderlineOffset):
* style/InlineTextBoxStyle.h:

LayoutTests:

* fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
benjamin@webkit.org [Sun, 11 Nov 2018 08:27:32 +0000 (08:27 +0000)]
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename file.

* API/JSValue.mm:

Source/WebCore:

Rename file.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* page/mac/EventHandlerMac.mm:
* platform/mac/URLMac.mm:
* platform/mac/WebCoreNSURLExtras.mm:
* platform/mac/WebCoreObjCExtras.mm:
* rendering/RenderThemeMac.mm:

Source/WebKit:

* Platform/mac/StringUtilities.mm:
* UIProcess/ApplicationStateTracker.mm:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

* Carbon/HIWebView.mm:
* Misc/WebNSFileManagerExtras.mm:
* Misc/WebNSURLExtras.mm:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebPluginContainerCheck.mm:
* WebCoreSupport/WebCachedFramePlatformData.h:
* WebCoreSupport/WebDeviceOrientationClient.mm:
* WebView/WebDelegateImplementationCaching.mm:
* WebView/WebHTMLView.mm:
* WebView/WebPDFRepresentation.mm:
* WebView/WebPolicyDelegate.mm:
* WebView/WebView.mm:

Tools:

Update file name.

* DumpRenderTree/mac/DumpRenderTree.mm:
* WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
* WebKitTestRunner/mac/TestControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
benjamin@webkit.org [Sun, 11 Nov 2018 06:16:22 +0000 (06:16 +0000)]
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

* API/JSValue.mm:

Source/WebCore:

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* page/mac/EventHandlerMac.mm:
* platform/mac/URLMac.mm:
* platform/mac/WebCoreNSURLExtras.mm:
* platform/mac/WebCoreObjCExtras.mm:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):

Source/WebKit:

* Platform/mac/StringUtilities.mm:
* UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::applicationDidEnterBackground):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):
(WebKit::ApplicationStateTracker::applicationWillEnterForeground):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

* Carbon/HIWebView.mm:
(UpdateCommandStatus):
* Misc/WebNSFileManagerExtras.mm:
* Misc/WebNSURLExtras.mm:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebPluginContainerCheck.mm:
(-[WebPluginContainerCheck _continueWithPolicy:]):
* WebCoreSupport/WebCachedFramePlatformData.h:
(WebCachedFramePlatformData::clear):
* WebCoreSupport/WebDeviceOrientationClient.mm:
(WebDeviceOrientationClient::getProvider const):
* WebView/WebDelegateImplementationCaching.mm:
(CallDelegate):
(CallDelegateReturningBoolean):
(CallResourceLoadDelegateReturningBoolean):
(CallFormDelegate):
(CallFormDelegateReturningBoolean):
* WebView/WebHTMLView.mm:
* WebView/WebPDFRepresentation.mm:
* WebView/WebPolicyDelegate.mm:
(-[WebPolicyDecisionListener _usePolicy:]):
* WebView/WebView.mm:

Source/WTF:

Because renaming ObjcRuntimeExtras.h to ObjCRuntimeExtras.h only changes
the cases, some systems have issues with applying this patch.

To work around the problem, the change is made is two patches, first rename to
WTFObjCRuntimeExtras.h, then back to ObjCRuntimeExtras.h.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/WTFObjCRuntimeExtras.h: Renamed from Source/WTF/wtf/ObjcRuntimeExtras.h.
(wtfObjCMsgSend):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
* WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
* WebKitTestRunner/mac/TestControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix build for 32bit Mac
megan_gardner@apple.com [Sun, 11 Nov 2018 06:13:33 +0000 (06:13 +0000)]
Fix build for 32bit Mac
https://bugs.webkit.org/show_bug.cgi?id=191511

Unreviewed Build Fix.

Build fix, not tests needed.

Make the apporiate delecrations for 32-bit mac support.

* editing/mac/DictionaryLookup.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRemove support for -webkit-svg-shadow
simon.fraser@apple.com [Sun, 11 Nov 2018 00:26:15 +0000 (00:26 +0000)]
Remove support for -webkit-svg-shadow
https://bugs.webkit.org/show_bug.cgi?id=187429
Source/WebCore:

<rdar://problem/41920735>

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSProperties.json:
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue):
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitSvgShadow): Deleted.
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::didAttachChild):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::RenderSVGModelObject):
* rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::hasSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Deleted.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::updateCachedBoundaries):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateRepaintBoundingBox):
* rendering/svg/RenderSVGShape.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::styleChanged):
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Deleted.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Deleted.
(WebCore::SVGRenderSupport::childAdded): Deleted.
* rendering/svg/SVGRenderSupport.h:

LayoutTests:

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

* css3/blending/svg-blend-layer-shadow.html: Removed.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* fast/repaint/moving-shadow-on-container-expected.png: Removed.
* fast/repaint/moving-shadow-on-container.html: Removed.
* fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* fast/repaint/moving-shadow-on-path.html: Removed.
* legacy-animation-engine/fast/css/getComputedStyle/resources/property-names.js:
* platform/gtk/TestExpectations:
* platform/gtk/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
* platform/gtk/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
* platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
* platform/gtk/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/gtk/svg/css/arrow-with-shadow-expected.png: Removed.
* platform/gtk/svg/css/composite-shadow-example-expected.png: Removed.
* platform/gtk/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
* platform/gtk/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/gtk/svg/css/composite-shadow-with-opacity-expected.png: Removed.
* platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/gtk/svg/css/group-with-shadow-expected.png: Removed.
* platform/gtk/svg/css/shadow-changes-expected.png: Removed.
* platform/gtk/svg/css/shadow-changes-expected.txt: Removed.
* platform/gtk/svg/css/stars-with-shadow-expected.png: Removed.
* platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
* platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
* platform/gtk/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
* platform/gtk/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
* platform/ios/TestExpectations:
* platform/ios/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
* platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/ios/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/ios/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/ios/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/ios/svg/css/getComputedStyle-basic-expected.txt:
* platform/ios/svg/css/group-with-shadow-expected.txt: Removed.
* platform/ios/svg/css/shadow-changes-expected.txt: Removed.
* platform/ios/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/ios/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
* platform/mac-sierra/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac-sierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac-sierra/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
* platform/mac/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
* platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/mac/svg/css/arrow-with-shadow-expected.png: Removed.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
* platform/mac/svg/css/clippath-with-shadow-expected.png: Removed.
* platform/mac/svg/css/composite-shadow-example-expected.png: Removed.
* platform/mac/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Removed.
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/svg/css/group-with-shadow-expected.png: Removed.
* platform/mac/svg/css/group-with-shadow-expected.txt: Removed.
* platform/mac/svg/css/mask-with-shadow-expected.png: Removed.
* platform/mac/svg/css/path-with-shadow-expected.png: Removed.
* platform/mac/svg/css/shadow-and-opacity-expected.png: Removed.
* platform/mac/svg/css/shadow-changes-expected.png: Removed.
* platform/mac/svg/css/shadow-changes-expected.txt: Removed.
* platform/mac/svg/css/shadow-with-large-radius-expected.png: Removed.
* platform/mac/svg/css/shadow-with-negative-offset-expected.png: Removed.
* platform/mac/svg/css/stars-with-shadow-expected.png: Removed.
* platform/mac/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
* platform/mac/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
* platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
* platform/win/TestExpectations:
* platform/win/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
* platform/win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
* platform/win/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/win/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/win/svg/css/group-with-shadow-expected.txt: Removed.
* platform/win/svg/css/shadow-changes-expected.txt: Removed.
* platform/win/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* platform/wincairo/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
* platform/wincairo/fast/repaint/moving-shadow-on-path-expected.png: Removed.
* platform/wincairo/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/wincairo/svg/css/shadow-changes-expected.txt: Removed.
* platform/wincairo/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
* platform/wpe/svg/css/composite-shadow-text-expected.txt: Removed.
* platform/wpe/svg/css/shadow-changes-expected.txt: Removed.
* platform/wpe/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/wpe/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* platform/wpe/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
* svg/css/arrow-with-shadow-expected.txt: Removed.
* svg/css/arrow-with-shadow.svg: Removed.
* svg/css/circle-in-mask-with-shadow-expected.png: Removed.
* svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* svg/css/circle-in-mask-with-shadow.svg: Removed.
* svg/css/clippath-with-shadow-expected.png: Removed.
* svg/css/clippath-with-shadow-expected.txt: Removed.
* svg/css/clippath-with-shadow.svg: Removed.
* svg/css/composite-shadow-example-expected.txt: Removed.
* svg/css/composite-shadow-example.html: Removed.
* svg/css/composite-shadow-text-expected.png: Removed.
* svg/css/composite-shadow-text.svg: Removed.
* svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* svg/css/composite-shadow-with-opacity.html: Removed.
* svg/css/getComputedStyle-basic-expected.txt:
* svg/css/group-with-shadow-expected.txt: Removed.
* svg/css/group-with-shadow.svg: Removed.
* svg/css/mask-with-shadow-expected.txt: Removed.
* svg/css/mask-with-shadow.svg: Removed.
* svg/css/parent-shadow-offscreen-expected.svg: Removed.
* svg/css/parent-shadow-offscreen.svg: Removed.
* svg/css/path-with-shadow-expected.png: Removed.
* svg/css/path-with-shadow-expected.txt: Removed.
* svg/css/path-with-shadow.svg: Removed.
* svg/css/root-shadow-offscreen-expected.svg: Removed.
* svg/css/root-shadow-offscreen.svg: Removed.
* svg/css/shadow-and-opacity-expected.txt: Removed.
* svg/css/shadow-and-opacity.svg: Removed.
* svg/css/shadow-changes.svg: Removed.
* svg/css/shadow-with-large-radius-expected.png: Removed.
* svg/css/shadow-with-large-radius-expected.txt: Removed.
* svg/css/shadow-with-large-radius.svg: Removed.
* svg/css/shadow-with-negative-offset-expected.png: Removed.
* svg/css/shadow-with-negative-offset-expected.txt: Removed.
* svg/css/shadow-with-negative-offset.svg: Removed.
* svg/css/stars-with-shadow-expected.txt: Removed.
* svg/css/stars-with-shadow.html: Removed.
* svg/custom/simple-text-double-shadow-expected.png: Removed.
* svg/custom/simple-text-double-shadow-expected.txt: Removed.
* svg/custom/simple-text-double-shadow.svg: Removed.
* svg/custom/transform-with-shadow-and-gradient.svg: Removed.
* svg/filters/shadow-on-filter-expected.txt: Removed.
* svg/filters/shadow-on-filter.svg: Removed.
* svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
* svg/filters/shadow-on-rect-with-filter.svg: Removed.
* svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Removed.
* svg/repaint/repaint-webkit-svg-shadow-container.html: Removed.
* svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
* svg/repaint/repaint-webkit-svg-shadow.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, rolling out r238065.
ryanhaddad@apple.com [Sat, 10 Nov 2018 21:01:36 +0000 (21:01 +0000)]
Unreviewed, rolling out r238065.

Breaks internal builds.

Reverted changeset:

"Make it possible to edit images inline"
https://bugs.webkit.org/show_bug.cgi?id=191352
https://trac.webkit.org/changeset/238065

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
mcatanzaro@igalia.com [Sat, 10 Nov 2018 20:12:06 +0000 (20:12 +0000)]
[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191221

Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
that it is disabled, but we're testing that it is enabled, because I failed to update this
line.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, fix typo in r238066.
cdumez@apple.com [Sat, 10 Nov 2018 19:52:32 +0000 (19:52 +0000)]
Unreviewed, fix typo in r238066.

* accessibility/ios-simulator/form-control-validation-message.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, silence -Wunused-variable warning
mcatanzaro@igalia.com [Sat, 10 Nov 2018 19:27:27 +0000 (19:27 +0000)]
Unreviewed, silence -Wunused-variable warning

* bytecode/Opcode.h:
(JSC::padOpcodeName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed attempt to deflake accessibility/ios-simulator/form-control-validation...
cdumez@apple.com [Sat, 10 Nov 2018 17:43:31 +0000 (17:43 +0000)]
Unreviewed attempt to deflake accessibility/ios-simulator/form-control-validation-message.html

* accessibility/ios-simulator/form-control-validation-message.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMake it possible to edit images inline
timothy_horton@apple.com [Sat, 10 Nov 2018 09:58:01 +0000 (09:58 +0000)]
Make it possible to edit images inline
https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html
       editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

* page/Settings.yaml:
Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

* html/HTMLImageElement.h:
Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::nextEmbeddedViewID):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

* rendering/RenderImage.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):
* rendering/RenderLayerCompositor.h:
Make editable images require compositing implicitly.

Source/WebKit:

* Platform/spi/ios/PencilKitSPI.h: Added.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
* WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):
* WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Add a preference to enable editable images.

* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.
(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

* UIProcess/ios/WKDrawingView.h: Added.
* UIProcess/ios/WKDrawingView.mm: Added.
(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

* WebKit.xcodeproj/project.pbxproj:
* SourcesCocoa.txt:
Add the new files.

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* TestRunnerShared/spi/PencilKitTestSPI.h: Added.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

* TestExpectations:
* editing/images/basic-editable-image-expected.txt: Added.
* editing/images/basic-editable-image.html: Added.
* editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
* editing/images/reparent-editable-image-maintains-strokes.html: Added.
* platform/ios-wk2/TestExpectations:
* resources/ui-helper.js:
(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
zalan@apple.com [Sat, 10 Nov 2018 06:39:20 +0000 (06:39 +0000)]
[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

1. Improve visuallyNonEmpty milestone confidence level.
    Ignore whitespace and non visible text content.
    Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
    Check if the html/body is actually visible.

2. Issue initial paint soon after the milestone fires.
    Use a 0ms timer to flush the initial paint.
    Throttle additional flushes for 500ms and 1.5s (original behaviour).

3. Suspend optional style recalcs and layouts while painting is being throttled.
   When parsing yields we initiate a 0ms style recalc/layout timer.
   These optional layouts produce content that we have no intention to paint.

* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.
* platform/graphics/FontCascade.h:
* rendering/RenderText.cpp: Check whether the text is actually visible at this point.
(WebCore::RenderText::RenderText):

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):
* WebProcess/WebPage/AcceleratedDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::layerFlushThrottlingIsActive const):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoAdd ability to configure document.cookie lifetime cap through user defaults
wilander@apple.com [Sat, 10 Nov 2018 04:50:03 +0000 (04:50 +0000)]
Add ability to configure document.cookie lifetime cap through user defaults
https://bugs.webkit.org/show_bug.cgi?id=191480
<rdar://problem/45240871>

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. Existing test makes sure we don't regress.

This change makes the capped lifetime in seconds configurable through
user defaults.

* platform/network/NetworkStorageSession.h:
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
(WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted.
    Renamed setAgeCapForClientSideCookies().
* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::filterCookies):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):

Source/WebKit:

This change makes the capped lifetime in seconds configurable through
user defaults.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setAgeCapForClientSideCookies):
(WebKit::NetworkProcess::setShouldCapLifetimeForClientSideCookies): Deleted.
    Renamed setAgeCapForClientSideCookies().
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm:
(WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::didSetAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::setShouldCapLifetimeForClientSideCookies): Deleted.
    Renamed setAgeCapForClientSideCookies().
(WebKit::NetworkProcessProxy::didSetShouldCapLifetimeForClientSideCookies): Deleted.
    Renamed didSetAgeCapForClientSideCookies().
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::setAgeCapForClientSideCookies):
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):
(WebKit::ResourceLoadStatisticsMemoryStore::didCreateNetworkProcess):
    New function that handles all the things that need to be done when a network
    process has been created.
* UIProcess/ResourceLoadStatisticsMemoryStore.h:
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess):
    Now just calls the corresponding function on its memory store where all the
    configuration parameters are available.
* UIProcess/WebResourceLoadStatisticsStore.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setAgeCapForClientSideCookies):
(WebKit::WebsiteDataStore::setShouldCapLifetimeForClientSideCookies): Deleted.
    Renamed setAgeCapForClientSideCookies().
* UIProcess/WebsiteData/WebsiteDataStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, rolling out r238047.
ryanhaddad@apple.com [Sat, 10 Nov 2018 01:40:18 +0000 (01:40 +0000)]
Unreviewed, rolling out r238047.

Introduced layout test failures on iOS simulator.

Reverted changeset:

"[iOS] Draw caps lock indicator in password fields"
https://bugs.webkit.org/show_bug.cgi?id=190565
https://trac.webkit.org/changeset/238047

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSuspended page persists even after back/forward list item is gone
cdumez@apple.com [Sat, 10 Nov 2018 00:24:08 +0000 (00:24 +0000)]
Suspended page persists even after back/forward list item is gone
https://bugs.webkit.org/show_bug.cgi?id=191488
<rdar://problem/45953006>

Reviewed by Geoffrey Garen.

Source/WebKit:

Currently, the WebProcessPool owns the SuspendedPageProxy objects and makes sure we cap how
many we can have. The WebBackForwardListItem merely has a WeakPtr to its associated
SuspendedPageProxy. However, there is no point in having the WebProcessPool keeping a
SuspendedPageProxy object alive if there is no longer any WebBackForwardListItem pointing
to it.

To address the issue, WebBackForwardListItem nows tells the WebProcessPool to destroy
its SuspendedPageProxy when necessary. WebBackForwardList also takes care of nulling
out the WebBackForwardListItem's SuspendedPageProxy after the item has been removed
from the list (in case somebody keeps the item alive).

* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setSuspendedPage):
(WebKit::WebBackForwardListItem::suspendedPageIsNoLongerNeeded):
* Shared/WebBackForwardListItem.h:
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::didRemoveItem):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::removeSuspendedPageProxy):
* UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix Test Expectations for Reveal Test
megan_gardner@apple.com [Fri, 9 Nov 2018 23:10:47 +0000 (23:10 +0000)]
Fix Test Expectations for Reveal Test
https://bugs.webkit.org/show_bug.cgi?id=191476

Unreviewed test gardening.

Put the test expectation in the correct location to deal with
the different behaviour old platforms.

* platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed Windows build fix for r238049.
ross.kirsling@sony.com [Fri, 9 Nov 2018 23:04:58 +0000 (23:04 +0000)]
Unreviewed Windows build fix for r238049.

* WebView.cpp:
(WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoNormal-flow-only flex items don't correctly respect z-index
timothy_horton@apple.com [Fri, 9 Nov 2018 22:57:31 +0000 (22:57 +0000)]
Normal-flow-only flex items don't correctly respect z-index
https://bugs.webkit.org/show_bug.cgi?id=191486

Reviewed by Simon Fraser.

Source/WebCore:

Test: css3/flexbox/z-index-with-normal-flow-only.html

* rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
r125693 did not ensure that flex items which would otherwise be
normal-flow-only would be put into the z-order tree when necessary.
Fix by respecting the same trigger we use to make layers for flex items;
namely, not having auto z-index.

LayoutTests:

* css3/flexbox/z-index-with-normal-flow-only-expected.html: Added.
* css3/flexbox/z-index-with-normal-flow-only.html: Added.
Add a test that a <canvas> with z-index 50 correctly stacks below
a <canvas> that is a flex-item with z-index 100.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
wenson_hsieh@apple.com [Fri, 9 Nov 2018 22:50:47 +0000 (22:50 +0000)]
[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
https://bugs.webkit.org/show_bug.cgi?id=191471
<rdar://problem/45952472>

Reviewed by Tim Horton.

Source/WebCore:

Add new method stubs for changing the list type for the current selection (to be implemented in a future patch).

* editing/Editor.cpp:
(WebCore::Editor::canChangeSelectionListType):
(WebCore::Editor::changeSelectionListType):
* editing/Editor.h:

Source/WebKit:

Implement these method stubs by calling into Editor.

Test: WKWebViewEditActions.ModifyListLevel

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Tools:

Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.

* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoClean-up stray whitespace in theme files
jond@apple.com [Fri, 9 Nov 2018 22:34:47 +0000 (22:34 +0000)]
Clean-up stray whitespace in theme files
https://bugs.webkit.org/show_bug.cgi?id=191430

Reviewed by Dean Jackson.

* wp-content/themes/webkit/css-status.php:
* wp-content/themes/webkit/footer.php:
* wp-content/themes/webkit/front-page.php:
* wp-content/themes/webkit/includes.php:
* wp-content/themes/webkit/nightly-start.php:
* wp-content/themes/webkit/nightly-survey.php:
* wp-content/themes/webkit/page.php:
* wp-content/themes/webkit/scripts/global.js:
* wp-content/themes/webkit/scripts/searchbuilds.js:
(initsearch):
(initsearch.displayError):
* wp-content/themes/webkit/single.php:
* wp-content/themes/webkit/sitemap.php:
* wp-content/themes/webkit/team.php:
* wp-content/themes/webkit/widgets/icon.php:
* wp-content/themes/webkit/widgets/page.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324
krollin@apple.com [Fri, 9 Nov 2018 22:32:12 +0000 (22:32 +0000)]
Unreviewed build fix after https://bugs.webkit.org/show_bug.cgi?id=191324

Remove the use of .xcfilelists until their side-effects are better
understood.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSourceBuffer throws an error when appending a second init segment after changeType().
jer.noble@apple.com [Fri, 9 Nov 2018 21:59:22 +0000 (21:59 +0000)]
SourceBuffer throws an error when appending a second init segment after changeType().
https://bugs.webkit.org/show_bug.cgi?id=191474

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-changetype-second-init.html

When encountering an initialization segment after changeType(), add the parsed codec types
to the list of allowed codecs.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::validateInitializationSegment):
* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::supportsType):
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::canSwitchToType):
* platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

* media/media-source/media-source-changetype-second-init-expected.txt: Added.
* media/media-source/media-source-changetype-second-init.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
eric.carlson@apple.com [Fri, 9 Nov 2018 21:26:16 +0000 (21:26 +0000)]
[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
https://bugs.webkit.org/show_bug.cgi?id=191479
<rdar://problem/45952201>

Reviewed by Jer Noble.

No new tests, tested manually.

* platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::standardVideoSizes): Drive-by fix: add a few more standard
video frame sizes, correct a typo.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate): Drive-by fix: don't consider
rescaled sized when we already have an exact or aspect ratio match because it won't be used.

* platform/mediastream/mac/AVVideoCaptureSource.h:
(WebCore::AVVideoCaptureSource::width const): Deleted.
(WebCore::AVVideoCaptureSource::height const): Deleted.
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset): Delete m_requestedSize.
(WebCore::AVVideoCaptureSource::shutdownCaptureSession): Delete m_width and m_height.
(WebCore::AVVideoCaptureSource::processNewFrame): Don't call setSize with captured size,
the frame may be resized before deliver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed MSVC build fix after r238039 (and r238046).
ross.kirsling@sony.com [Fri, 9 Nov 2018 21:10:26 +0000 (21:10 +0000)]
Unreviewed MSVC build fix after r238039 (and r238046).

Source/WebCore:

* bindings/js/JSWorkerGlobalScopeBase.cpp:
* bindings/js/JSWorkerGlobalScopeBase.h:

Source/WebKitLegacy/win:

* WebDocumentLoader.h:
* WebView.cpp:
(WebView::setShouldApplyMacFontAscentHack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Curl][WebKit] Implement Proxy configuration API.
basuke.suzuki@sony.com [Fri, 9 Nov 2018 20:43:23 +0000 (20:43 +0000)]
[Curl][WebKit] Implement Proxy configuration API.
https://bugs.webkit.org/show_bug.cgi?id=189053

Reviewed by Youenn Fablet.

Source/WebCore:

Added API to set proxy from the app.

No new tests because there's no behaviour change in WebCore.

* platform/network/NetworkStorageSession.h:
* platform/network/curl/CurlContext.h:
(WebCore::CurlContext::setProxySettings):
* platform/network/curl/CurlProxySettings.h:
* platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::setProxySettings const):

Source/WebKit:

Added proxy configuration API to WebsiteDataStore. Three API were added in WKWebsiteDataStoreRefCurl.h:
- WKWebsiteDataStoreEnableDefaultNetworkProxySettings(WKWebsiteDataStoreRef)
- WKWebsiteDataStoreEnableCustomNetworkProxySettings(WKWebsiteDataStoreRef, WKURLRef, WKStringRef ignoreHosts)
- WKWebsiteDataStoreDisableNetworkProxySettings(WKWebsiteDataStoreRef)

* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkSessionCreationParameters.h:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::setNetworkProxySettings):
* NetworkProcess/curl/NetworkSessionCurl.cpp:
(WebKit::NetworkSessionCurl::NetworkSessionCurl):
* NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* PlatformWin.cmake:
* Shared/WebCoreArgumentCoders.h:
* Shared/curl/WebCoreArgumentCodersCurl.cpp:
(IPC::ArgumentCoder<CurlProxySettings>::encode):
(IPC::ArgumentCoder<CurlProxySettings>::decode):
* UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp:
  Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.
(WKWebsiteDataStoreEnableDefaultNetworkProxySettings):
(WKWebsiteDataStoreEnableCustomNetworkProxySettings):
(WKWebsiteDataStoreDisableNetworkProxySettings):
* UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.h:
  Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::networkProxySettings const):
* UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp:
  Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.
(WebKit::WebsiteDataStore::platformSetParameters):
(WebKit::WebsiteDataStore::setNetworkProxySettings):

Tools:

Added Proxy Settings dialog to call newly added API.

* MiniBrowser/win/BrowserWindow.h:
* MiniBrowser/win/Common.cpp:
(askProxySettings):
(askCredential):
(authDialogProc): Deleted.
* MiniBrowser/win/Common.h:
* MiniBrowser/win/DialogHelper.h: Added.
(Dialog::run):
(Dialog::doalogProc):
(Dialog::handle):
(Dialog::setup):
(Dialog::update):
(Dialog::validate):
(Dialog::updateOkButton):
(Dialog::command):
(Dialog::ok):
(Dialog::cancel):
(Dialog::close):
(Dialog::hDlg):
(Dialog::item):
(Dialog::setEnabled):
(Dialog::setText):
(Dialog::getText):
(Dialog::getTextLength):
(Dialog::RadioGroup::RadioGroup):
(Dialog::RadioGroup::set):
(Dialog::RadioGroup::get):
(Dialog::radioGroup):
* MiniBrowser/win/MainWindow.cpp:
(MainWindow::WndProc):
* MiniBrowser/win/MiniBrowserLib.rc:
* MiniBrowser/win/MiniBrowserLibResource.h:
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(createWKURL):
(WebKitBrowserWindow::WebKitBrowserWindow):
(WebKitBrowserWindow::updateProxySettings):
(WebKitBrowserWindow::loadURL):
(WebKitBrowserWindow::loadHTMLString):
(WebKitBrowserWindow::openProxySettings):
* MiniBrowser/win/WebKitBrowserWindow.h:
* MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
(WebKitLegacyBrowserWindow::openProxySettings):
* MiniBrowser/win/WebKitLegacyBrowserWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
wenson_hsieh@apple.com [Fri, 9 Nov 2018 20:16:32 +0000 (20:16 +0000)]
[Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
https://bugs.webkit.org/show_bug.cgi?id=191410
<rdar://problem/45898610>

Reviewed by Dean Jackson.

Source/WebKit:

Prefixes a few iOS-only SPI methods declared on WKWebView in r236867 with underscores, and also exposes some
more cross-platform Cocoa editing SPI. Once the unprefixed SPI methods are no longer used by internal clients,
these will need to be removed (see followup bug: webkit.org/b/191450). See below for more details.

Covered by new and existing API tests in WKWebViewEditActions.

* UIProcess/API/Cocoa/WKWebView.mm:

Hoist the definition (and undefinition) of `FORWARD_ACTION_TO_WKCONTENTVIEW` to encompass both the WKWebView
implementation and the WKWebView (WKPrivate) implementation. This allows us to use this macro when implementing
SPI methods in the WKPrivate category, as well as methods that are part of the main WKWebView implementation.

(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):

Add forwarding for the new editing commands in -canPerformAction: and -targetForAction:.

(-[WKWebView _toggleStrikeThrough:]):
(-[WKWebView _increaseListLevel:]):
(-[WKWebView _decreaseListLevel:]):
(-[WKWebView _changeListType:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):

Add definitions for the new editing methods on WKWebView, using macros (`WEBCORE_PRIVATE_COMMAND` on macOS and
`FORWARD_ACTION_TO_WKCONTENTVIEW` on iOS) to help reduce the code duplication.

(-[WKWebView _pasteAsQuotation:]): Deleted.

Remove this method definition, which is now replaced by macros on iOS and macOS.

* UIProcess/API/Cocoa/WKWebViewPrivate.h:

Introduce the new SPI to WKWebView (WKPrivate), and add FIXMEs to remove old, unprefixed variants of the SPI.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::increaseListLevel):
(WebKit::WebPageProxy::decreaseListLevel):
(WebKit::WebPageProxy::changeListType):

Add plumbing for these list editing commands.

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _increaseListLevelForWebView:]):
(-[WKContentView _decreaseListLevelForWebView:]):
(-[WKContentView _changeListTypeForWebView:]):
(-[WKContentView _toggleStrikeThroughForWebView:]):
(-[WKContentView _setFontForWebView:sender:]):
(-[WKContentView _setFontSizeForWebView:sender:]):
(-[WKContentView _setTextColorForWebView:sender:]):
(-[WKContentView toggleStrikeThroughForWebView:]):
(-[WKContentView setFontForWebView:sender:]):
(-[WKContentView setFontSizeForWebView:sender:]):
(-[WKContentView setTextColorForWebView:sender:]):
(-[WKContentView canPerformActionForWebView:withSender:]):

Check for the new action selectors here, and additionally add validation for `_pasteAsQuotation:`. Let the
unprefixed versions of these methods simply call the prefixed versions (these method implementations will be
removed in a followup once doing so would not affect any clients of WebKit).

* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Add stubs for several list editing commands that are yet to be hooked up to WebCore. These will be implemented
in a future patch.

Tools:

Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
hooked up to their respective editing commands.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
(-[TestWKWebView querySelectorExists:]):
(-[TestWKWebView insertString:]):

Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
invoking the WKWebView directly on macOS and calling on the content view on iOS.

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUse OptionSet for layout milestones
antti@apple.com [Fri, 9 Nov 2018 19:47:15 +0000 (19:47 +0000)]
Use OptionSet for layout milestones
https://bugs.webkit.org/show_bug.cgi?id=191470

Reviewed by Dean Jackson.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyFrameLoaderClient.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didReachLayoutMilestone):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::addPaintPendingMilestones):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::firePaintRelatedMilestonesIfNeeded):
* page/FrameView.h:
* page/LayoutMilestone.h: Copied from Source/WebCore/page/LayoutMilestones.h.

Renamed to appease WK2 IPC code generation.

* page/LayoutMilestones.h: Removed.
* page/Page.cpp:
(WebCore::Page::addLayoutMilestones):
(WebCore::Page::removeLayoutMilestones):
(WebCore::Page::isCountingRelevantRepaintedObjects const):
* page/Page.h:
(WebCore::Page::requestedLayoutMilestones const):

Source/WebKit:

* Shared/API/Cocoa/_WKRenderingProgressEventsInternal.h:
(renderingProgressEvents):
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):
* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones const):
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didReachLayoutMilestone):
* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::renderingProgressDidChange):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient):
* UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
(pageRenderingProgressEvents):
* UIProcess/API/Cocoa/WKWebView.mm:
(layoutMilestones):
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::renderingProgressDidChange):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::listenForLayoutMilestones):
(WebKit::WebPageProxy::didLayoutForCustomContentProvider):
(WebKit::WebPageProxy::didReachLayoutMilestone):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
* WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
(API::InjectedBundle::PageLoaderClient::didReachLayoutMilestone):
(API::InjectedBundle::PageLoaderClient::layoutMilestones const):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone):
(WebKit::InjectedBundlePageLoaderClient::layoutMilestones const):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::dispatchDidReachLayoutMilestone):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
(WebKit::WebPage::listenForLayoutMilestones):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedLayoutMilestones):
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
* WebView/WebView.mm:
(coreLayoutMilestones):
(kitLayoutMilestones):
(-[WebView _cacheFrameLoadDelegateImplementations]):
* WebView/WebViewInternal.h:

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
* WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Start moving toward better multi-target support
joepeck@webkit.org [Fri, 9 Nov 2018 19:23:42 +0000 (19:23 +0000)]
Web Inspector: Start moving toward better multi-target support
https://bugs.webkit.org/show_bug.cgi?id=191345

Reviewed by Devin Rousso.

This change continues the move toward better multi-target support
by explicitly using explicit target agents in more places, and
converting generalized feature checks into target agnostic versions
that use the new InspectorBackend.domains, which does not vary based
on the connected targets / debuggable type.

I also audited uses of RuntimeAgent, ConsoleAgent, and DebuggerAgent
for better multi-target support since these agents should already
have complete multi-target support.

* UserInterface/Protocol/Target.js:
(WI.Target.prototype.initialize):
Move explicitly to target.Agent feature checks with a known target.

* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Move explicitly to target.DebuggerAgent for feature checks with a known target.

* UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.initializeTarget):
Move explicitly to target.NetworkAgent for feature checks with a known target.

* UserInterface/Controllers/RuntimeManager.js:
(WI.RuntimeManager.prototype.initializeTarget):
(WI.RuntimeManager.prototype.saveResult):
* UserInterface/Protocol/RemoteObject.js:
(WI.RemoteObject.prototype.updatePreview):
(WI.RemoteObject.prototype.getDisplayablePropertyDescriptors):
(WI.RemoteObject.prototype.deprecatedGetDisplayableProperties):
* UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
(WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
Move explicitly to target.RuntimeAgent for feature checks with a known target.

* UserInterface/Models/CSSCompletions.js:
(WI.CSSCompletions.initializeCSSCompletions):
Move explicitly to target.CSSAgent for feature checks with a known target.

* UserInterface/Views/ContextMenuUtilities.js:
Use the DebuggerAgent from the target associated with the DOMNode's
remote object instead of assuming the main target.

* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Update the ConsoleAgent setting on all targets that support it.

* UserInterface/Views/BreakpointActionView.js:
(WI.BreakpointActionView):
All backends support BreakpointActionType, the assertion can go away.

* UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.get navigationItems):
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype.get navigationItems):
Include additional `window.FooAgent` checks for these since they will need
to be revisited in the future.

* UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype.get domains):
(InspectorBackendClass.prototype.activateDomain):
Expose InspectorBackend.domains.<Domain> for feature checking.

* UserInterface/Controllers/BreakpointPopoverController.js:
(WI.BreakpointPopoverController.prototype._createPopoverContent):
* UserInterface/Controllers/CSSManager.js:
(WI.CSSManager):
(WI.CSSManager.prototype._mainResourceDidChange):
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype._attemptAutoCapturingForFrame):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
(WI.TimelineManager):
* UserInterface/Models/Canvas.js:
(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingFinished):
* UserInterface/Models/ScriptSyntaxTree.js:
(WI.ScriptSyntaxTree.functionReturnDivot):
* UserInterface/Protocol/DebuggerObserver.js:
(WI.DebuggerObserver):
* UserInterface/Protocol/NetworkObserver.js:
(WI.NetworkObserver.prototype.requestWillBeSent):
* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointClicked):
* UserInterface/Views/NetworkTimelineView.js:
(WI.NetworkTimelineView):
* UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
* UserInterface/Views/WebSocketContentView.js:
(WI.WebSocketContentView):
(WI.NetworkManager.prototype.webSocketWillSendHandshakeRequest):
(WI.DebuggerManager.prototype.debuggerDidResume):
Feature check in a target agnostic way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Draw caps lock indicator in password fields
dbates@webkit.org [Fri, 9 Nov 2018 19:10:27 +0000 (19:10 +0000)]
[iOS] Draw caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Reviewed by Dean Jackson.

Source/WebCore:

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac. For now, we only draw the
indicator when caps locks is enabled via the hardware keyboard. We will look to support the software
keyboard in a subsequent commit (see <https://bugs.webkit.org/show_bug.cgi?id=191475>).

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

* WebCore.xcodeproj/project.pbxproj:
* page/EventHandler.cpp:
(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().
* page/EventHandler.h:
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.
* platform/ios/KeyEventIOS.mm:
(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.
* platform/ios/WebEvent.h:
* platform/ios/WebEvent.mm:
(+[WebEvent modifierFlags]): Added.
* platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
* rendering/RenderThemeCocoa.h:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Forward declare some more SPI.

* pal/spi/ios/GraphicsServicesSPI.h:
* pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Update the caps lock state when a hardware keyboard is attached or detached.

* WebView/WebHTMLView.mm:
(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Expose some more symbols.

* WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed attempt to fix WinCairo build after r238039.
cdumez@apple.com [Fri, 9 Nov 2018 19:04:01 +0000 (19:04 +0000)]
Unreviewed attempt to fix WinCairo build after r238039.

* bindings/js/JSWorkerGlobalScopeBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMake use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
timothy_horton@apple.com [Fri, 9 Nov 2018 18:58:08 +0000 (18:58 +0000)]
Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
https://bugs.webkit.org/show_bug.cgi?id=191449
<rdar://problem/45884977>

Reviewed by Eric Carlson.

UIRemoteView has some nice process assertion management that it would
be nice to not duplicate. So, we can just use it instead of CALayerHost!

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::page const):
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(-[WKUIRemoteView hitTest:withEvent:]):
(-[WKUIRemoteView description]):
(createRemoteView):
(WebKit::RemoteLayerTreeHost::createLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoExtensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but...
Hironori.Fujii@sony.com [Fri, 9 Nov 2018 18:42:24 +0000 (18:42 +0000)]
Extensions3DOpenGLES.h:  warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
https://bugs.webkit.org/show_bug.cgi?id=191451

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback): Deleted unused method.
* platform/graphics/opengl/Extensions3DOpenGLES.h: Marked 'override'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MediaStream] Make screen capture an experimental feature
eric.carlson@apple.com [Fri, 9 Nov 2018 18:35:43 +0000 (18:35 +0000)]
[MediaStream] Make screen capture an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=191472
<rdar://problem/45946499>

Reviewed by Jer Noble.

* Shared/WebPreferences.yaml: Make ScreenCaptureEnabled an experimental feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Payment Request] canMakePayment() should not consider serialized payment method...
aestes@apple.com [Fri, 9 Nov 2018 18:27:35 +0000 (18:27 +0000)]
[Payment Request] canMakePayment() should not consider serialized payment method data
https://bugs.webkit.org/show_bug.cgi?id=191432

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

* web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.

Source/WebCore:

In https://github.com/w3c/payment-request/pull/806, we're changing the specification of
canMakePayment() to not consider serialized payment method data when deciding if a payment
method is supported. For Apple Pay, this means we resolve to true for
"https://apple.com/apple-pay", even if an ApplePayRequest is omitted or is missing required
fields.

Added test cases to
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html and
http/tests/paymentrequest/payment-request-show-method.https.html.

* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Updated with
changes from imported/w3c/web-platform-tests/payment-request/. Modified two tests to use
user_activation_test() rather than test_driver.bless().
* http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
* http/tests/paymentrequest/payment-request-show-method.https.html: Now that canMakePayment
does not convert payment method data, added a test that ensures show() rejects with a
TypeError when Apple Pay's payment method data is invalid.
* platform/ios-wk2/TestExpectations: Un-skipped payment-request-canmakepayment-method.https.html.
* platform/mac-wk2/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSource/WebCore:
aestes@apple.com [Fri, 9 Nov 2018 18:22:14 +0000 (18:22 +0000)]
Source/WebCore:
[Payment Request] PaymentResponse.details should be updated when the user accepts a retried payment
https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

PaymentResponse.details was being initialized in the PaymentResponse constructor and never
updated when the user accepts a retried payment. We need to update it.

Added a test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::accept):
* Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::setDetailsFunction):
* Modules/paymentrequest/PaymentResponse.h:

LayoutTests:
[Payment Request] PaymentResponse.details should be updated when the user accepts a rpayment retry
https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

* http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
* http/tests/paymentrequest/payment-response-retry-method.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member functio...
Hironori.Fujii@sony.com [Fri, 9 Nov 2018 18:19:07 +0000 (18:19 +0000)]
MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
https://bugs.webkit.org/show_bug.cgi?id=191453

Reviewed by Per Arne Vollan.

No new tests because there is no behavior change.

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: Marked with 'override' and removed 'virtual'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed attempt to fix internal build on macOS.
cdumez@apple.com [Fri, 9 Nov 2018 17:48:37 +0000 (17:48 +0000)]
Unreviewed attempt to fix internal build on macOS.

'Export' is defined in several headers.

* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bridge/jsc/BridgeJSC.cpp:
* bridge/jsc/BridgeJSC.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoHTML form validation bubble disappears
cdumez@apple.com [Fri, 9 Nov 2018 17:37:52 +0000 (17:37 +0000)]
HTML form validation bubble disappears
https://bugs.webkit.org/show_bug.cgi?id=191418

Reviewed by Simon Fraser.

Source/WebCore:

If we validate a form and find an invalid form control, we'll scroll it into view and show
the validation bubble. However, scrolling the element into view may be an asynchronous
operation, in which case it would discard the validation bubble prematurely because scrolling
hides the validation bubble. To address the issue, we now show the validation message
asynchronously after focusing the element (and potentially scrolling it into view).

Test: fast/forms/scroll-into-view-and-show-validation-message.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::focusAndShowValidationMessage):

LayoutTests:

Add API test coverage and update existing tests to use form-validation.js and
avoid code duplication.

* fast/forms/form-validation.js: Added.
(getValidationBubbleContents):
(getValidationBubble.return.new.Promise.):
(getValidationBubble):
* fast/forms/ios/validation-bubble-dismiss-on-tap-expected.txt:
* fast/forms/ios/validation-bubble-dismiss-on-tap.html:
* fast/forms/navigation-dismisses-validation-bubbles-expected.txt: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt.
* fast/forms/navigation-dismisses-validation-bubbles.html: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html.
* fast/forms/resources/check-validation-bubble-not-visible.html: Renamed from LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html.
* fast/forms/scroll-into-view-and-show-validation-message-expected.txt: Added.
* fast/forms/scroll-into-view-and-show-validation-message.html: Added.
* fast/forms/validation-bubble-disappears-when-input-detached-expected.txt:
* fast/forms/validation-bubble-disappears-when-input-detached.html:
* fast/forms/validation-bubble-disappears-when-input-moved-expected.txt:
* fast/forms/validation-bubble-disappears-when-input-moved.html:
* fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt:
* fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html:
* fast/forms/validation-bubble-escape-key-dismiss-expected.txt:
* fast/forms/validation-bubble-escape-key-dismiss.html:
* fast/forms/validation-custom-message-expected.txt:
* fast/forms/validation-custom-message.html:
* fast/forms/validation-message-detached-iframe-expected.txt:
* fast/forms/validation-message-detached-iframe.html:
* fast/forms/validation-message-detached-iframe2-expected.txt:
* fast/forms/validation-message-detached-iframe2.html:
* fast/forms/validation-message-minimum-font-size-expected.txt:
* fast/forms/validation-message-minimum-font-size.html:
* fast/forms/validation-messages-expected.txt:
* fast/forms/validation-messages.html:
* platform/gtk/TestExpectations:
* platform/ios-wk1/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
bfulgham@apple.com [Fri, 9 Nov 2018 17:32:32 +0000 (17:32 +0000)]
[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
https://bugs.webkit.org/show_bug.cgi?id=191452
<rdar://problem/45933964>

Reviewed by Zalan Bujtas.

Do a better job of balancing the BeginFigure/EndFigure calls in
the PathDirect2D implementation. Failure to do so puts the Geometry sink
into an error state that prevents it from producing drawing output.

* platform/graphics/Path.h:
* platform/graphics/win/GraphicsContextDirect2D.cpp:
(WebCore::GraphicsContext::drawPath): Flush is needed here.
(WebCore::GraphicsContext::fillPath): Ditto.
(WebCore::GraphicsContext::strokePath): Ditto.
* platform/graphics/win/PathDirect2D.cpp:
(WebCore::Path::drawDidComplete):
(WebCore::Path::closeAnyOpenGeometries):
(WebCore::Path::transform):
(WebCore::Path::openFigureAtCurrentPointIfNecessary):
(WebCore::Path::moveTo):
(WebCore::Path::closeSubpath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRemove legacy storage tracker database file after r237330
sihui_liu@apple.com [Fri, 9 Nov 2018 17:27:34 +0000 (17:27 +0000)]
Remove legacy storage tracker database file after r237330
https://bugs.webkit.org/show_bug.cgi?id=191423

Reviewed by Geoffrey Garen.

r237330 changed the file name of storage tracker database, but it did not remove the old
file before using the new one.

* Storage/StorageTracker.cpp:
(WebKit::StorageTracker::internalInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changety...
jer.noble@apple.com [Fri, 9 Nov 2018 17:24:50 +0000 (17:24 +0000)]
[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
https://bugs.webkit.org/show_bug.cgi?id=191396

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Modify the changetype test suite to include a HEVC version.

* web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4: Added.
* web-platform-tests/media-source/mediasource-changetype-util.js:
(findSupportedChangeTypeTestTypes):

Source/WebCore:

When changeType() is called, exempt video and text tracks (in addition to just audio tracks)
from "same codec" requirements.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::validateInitializationSegment):

LayoutTests:

* platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoClean up test expectations after r237942
ryanhaddad@apple.com [Fri, 9 Nov 2018 17:16:01 +0000 (17:16 +0000)]
Clean up test expectations after r237942
https://bugs.webkit.org/show_bug.cgi?id=191448

Unreviewed test gardening.

Add test expectation files for Sierra WK1.

* platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added.
* platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Pressing forward delete key in text field does nothing and we should not invoke...
dbates@webkit.org [Fri, 9 Nov 2018 17:06:50 +0000 (17:06 +0000)]
[iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
action when forward delete is pressed outside a text field
https://bugs.webkit.org/show_bug.cgi?id=190566
<rdar://problem/45262367>

Reviewed by Wenson Hsieh.

Source/WebKit:

Override -_deleteForwardAndNotify to perform a forward deletion and remove the dead code that
expected UIKit to send us a character string with 0xF728 for the forward delete key. UIKit
ceased doing this many years ago. We may revist this decision once <rdar://problem/45772078>
is fixed.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView _deleteForwardAndNotify:]):

Source/WebKitLegacy/mac:

Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):

LayoutTests:

Add a test to ensure that pressing the forward delete key deletes the next character.

* fast/events/ios/forward-delete-in-editable-expected.txt: Added.
* fast/events/ios/forward-delete-in-editable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked...
Hironori.Fujii@sony.com [Fri, 9 Nov 2018 16:42:49 +0000 (16:42 +0000)]
WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
https://bugs.webkit.org/show_bug.cgi?id=191455

Reviewed by Brent Fulgham.

* WebHistory.h: Marked with 'override' and removed 'virtual'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoLLInt VectorSizeOffset should be based on offset extraction
keith_miller@apple.com [Fri, 9 Nov 2018 16:40:07 +0000 (16:40 +0000)]
LLInt VectorSizeOffset should be based on offset extraction
https://bugs.webkit.org/show_bug.cgi?id=191468

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This patch also adds some usings to LLIntOffsetsExtractor that
make it possible to use the bare names of Vector/RefCountedArray
in offsets extraction.

* llint/LLIntOffsetsExtractor.cpp:
* llint/LowLevelInterpreter.asm:

Source/WTF:

Make things friends with LLIntOffsetsExtractor.

* wtf/RefCountedArray.h:
* wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoREGRESSION(r236365): [GTK] Many form-related tests are failing
carlosgc@webkit.org [Fri, 9 Nov 2018 16:15:04 +0000 (16:15 +0000)]
REGRESSION(r236365): [GTK] Many form-related tests are failing
https://bugs.webkit.org/show_bug.cgi?id=189993

Reviewed by Michael Catanzaro.

Source/WebCore:

Only the first form data element is added to the message body due to a return added by mistake in r236365.

* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.

LayoutTests:

Remove expectations for tests that are passing now.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WTF] Changes in bug 188867 break non-Linux Unix builds
commit-queue@webkit.org [Fri, 9 Nov 2018 15:30:43 +0000 (15:30 +0000)]
[WTF] Changes in bug 188867 break non-Linux Unix builds
https://bugs.webkit.org/show_bug.cgi?id=191380

The intention of 188867 was to split out platform-specific
heap query/release code.  Any unsupported platform
would use a generic, no-op stub.  However, wtf/PlatformGTK.cmake
ended up sending all non-Linux platforms through the Linux
implementation, which breaks the build for those platforms.
This includes any user of the GTK target which is not Linux,
such as the *BSDs, Solaris, etc.

Patch by Jim Mason <jmason@ibinx.com> on 2018-11-09
Reviewed by Yusuke Suzuki.

* wtf/PlatformGTK.cmake: Updated to include Linux-specific
code only for Linux; all other platforms use the generic stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingConte...
zalan@apple.com [Fri, 9 Nov 2018 15:28:55 +0000 (15:28 +0000)]
[LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry
https://bugs.webkit.org/show_bug.cgi?id=191445

Reviewed by Antti Koivisto.

The idea here is that Line should not have to deal with all the post processig tasks like the runs final aligments.
(The line class would eventually turn into a collection of random things).

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
* layout/inlineformatting/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalLeft const):
(WebCore::Layout::InlineFormattingContext::Line::lastRunType const):
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::adjustedLineLogicalLeft):
(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):
(WebCore::Layout::InlineFormattingContext::Geometry::computeExpansionOpportunities):
* layout/inlineformatting/Line.cpp:
(WebCore::Layout::InlineFormattingContext::Line::Line):
(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight const):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):
(WebCore::Layout::adjustedLineLogicalLeft): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::computeExpansionOpportunities): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::justifyRuns): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, GStreamer build warning fix
philn@webkit.org [Fri, 9 Nov 2018 15:05:42 +0000 (15:05 +0000)]
Unreviewed, GStreamer build warning fix

* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::newSampleCallback): Timesamp()
returns a uint32_t, fix format string accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, rolling in CodeCache in r237254
yusukesuzuki@slowstart.org [Fri, 9 Nov 2018 11:32:43 +0000 (11:32 +0000)]
Unreviewed, rolling in CodeCache in r237254
https://bugs.webkit.org/show_bug.cgi?id=190340

Land the CodeCache part, which uses DefaultHash<>::Hash instead of computeHash.

* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
* bytecode/UnlinkedFunctionExecutable.h:
* parser/SourceCodeKey.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):
* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
* runtime/CodeCache.h:
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/FunctionExecutable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Flatpak] Refactoring and drive-by fixes
philn@webkit.org [Fri, 9 Nov 2018 10:53:33 +0000 (10:53 +0000)]
[Flatpak] Refactoring and drive-by fixes
https://bugs.webkit.org/show_bug.cgi?id=191421

Reviewed by Michael Catanzaro.

* Scripts/webkitdirs.pm:
(inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
the sandbox, so rely on this.
* flatpak/flatpakutils.py:
(expand_manifest): Pass explicit keywords to load_manifest() and
remove unused local variable.
(WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
(WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
(WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
build_type handling a bit.
* flatpak/org.webkit.CommonModules.yaml: Added.
* flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
* flatpak/org.webkit.WebKit.yaml: Move common dependencies
declaration to CommonModules, so it can be reused later when we
add support for building extra libraries depending on WPE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoput_by_val opcodes need to add the number tag as a 64-bit register
keith_miller@apple.com [Fri, 9 Nov 2018 09:22:24 +0000 (09:22 +0000)]
put_by_val opcodes need to add the number tag as a 64-bit register
https://bugs.webkit.org/show_bug.cgi?id=191456

Reviewed by Saam Barati.

Previously the LLInt would add it as a pointer sized value. That is
wrong if pointer size is less 64-bits.

* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: ResourceQueryController should early return when query is longer than...
mattbaker@apple.com [Fri, 9 Nov 2018 07:13:25 +0000 (07:13 +0000)]
Web Inspector: ResourceQueryController should early return when query is longer than search string
https://bugs.webkit.org/show_bug.cgi?id=191436

Reviewed by Devin Rousso.

* UserInterface/Controllers/ResourceQueryController.js:

* UserInterface/Models/ResourceQueryMatch.js:
(WI.ResourceQueryMatch):
Drive-by fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, try to fix the 32-bit macOS build
wenson_hsieh@apple.com [Fri, 9 Nov 2018 06:49:35 +0000 (06:49 +0000)]
Unreviewed, try to fix the 32-bit macOS build

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUncaught Exception: undefined is not an object (evaluating 'treeElement.parent.remove...
commit-queue@webkit.org [Fri, 9 Nov 2018 06:07:20 +0000 (06:07 +0000)]
Uncaught Exception: undefined is not an object (evaluating 'treeElement.parent.removeChild')
https://bugs.webkit.org/show_bug.cgi?id=191454

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-11-08
Reviewed by Matt Baker.

* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype._scriptsCleared):
This was intending to iterate the Map's values, which are tree elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
ross.kirsling@sony.com [Fri, 9 Nov 2018 05:30:48 +0000 (05:30 +0000)]
[JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
https://bugs.webkit.org/show_bug.cgi?id=191439

Reviewed by Saam Barati.

* CMakeLists.txt:
* runtime/ParseInt.h:
(JSC::isStrWhiteSpace):
Define isStrWhiteSpace in terms of isWhiteSpace and isLineTerminator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSource/WebCore:
commit-queue@webkit.org [Fri, 9 Nov 2018 03:23:17 +0000 (03:23 +0000)]
Source/WebCore:
Add an SPI to allow WebView clients to add additional supported image formats
https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

Add an SPI to allow additional supported image formats in WebView. These
additional formats can be set in the WKWebViewConfiguration as an NSArray
of NStrings. Each string represents an image source type aka UTI.

The ImageSourceType in the functions' names will be replaced by ImageType.
ImageType in this context is the image UTI (Uniform Type Identifier).

* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::supportedImageMIMETypes):
(WebCore::MIMETypeRegistry::additionalSupportedImageMIMETypes):
(WebCore::supportedImageMIMETypesForEncoding):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
* platform/MIMETypeRegistry.h:
* platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoderCG::filenameExtension const):
(WebCore::ImageDecoderCG::encodedDataStatus const):
* platform/graphics/cg/ImageSourceCG.h:
* platform/graphics/cg/ImageSourceCGMac.mm:
(WebCore::MIMETypeForImageType):
(WebCore::preferredExtensionForImageType):
(WebCore::MIMETypeForImageSourceType): Deleted.
(WebCore::preferredExtensionForImageSourceType): Deleted.
* platform/graphics/cg/ImageSourceCGWin.cpp:
(WebCore::MIMETypeForImageType):
(WebCore::preferredExtensionForImageType):
(WebCore::MIMETypeForImageSourceType): Deleted.
(WebCore::preferredExtensionForImageSourceType): Deleted.
* platform/graphics/cg/UTIRegistry.cpp:
(WebCore::defaultSupportedImageTypes):
(WebCore::additionalSupportedImageTypes):
(WebCore::setAdditionalSupportedImageTypes):
(WebCore::isSupportedImageType):
(WebCore::supportedDefaultImageSourceTypes): Deleted.
(WebCore::isSupportImageSourceType): Deleted.
* platform/graphics/cg/UTIRegistry.h:

Source/WebKit:
Add an SPI to allow WebView clients to add additional supported image formats
https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

* Platform/mac/StringUtilities.h:
* Platform/mac/StringUtilities.mm:
(WebKit::webCoreStringVectorFromNSStringArray):
A helper function which converts an NSArray of NSStrings to a Vector of
WTFString.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
Handle encoding and decoding the AdditionalSupportedImageTypes which will
allow transferring it from the UI process to the web process.

* UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::additionalSupportedImageTypes const):
(API::PageConfiguration::setAdditionalSupportedImageTypes):
Store the AdditionalSupportedImageTypes in the APIPageConfiguration
which is used when creating the WebPageProxy in the UIPorcess.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _additionalSupportedImageTypes]):
(-[WKWebViewConfiguration _setAdditionalSupportedImageTypes:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Setter/Getter for the AdditionalSupportedImageTypes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Copy the AdditionalSupportedImageTypes from APIPageConfiguration to
WebPageCreationParameters.

* UIProcess/WebPageProxy.h:
Delete unimplemented function.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
Copy the AdditionalSupportedImageTypes from WebPageCreationParameters to
WebCore.

Tools:
onal supported image formats
https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

Test opening a TGA image in WebView which is not allowed by default. The
TGA format will be allowed through WKWebViewConfiguration.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
* TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
* TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
(runTest):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoAdopt Reveal Framework to replace Lookup
megan_gardner@apple.com [Fri, 9 Nov 2018 01:59:10 +0000 (01:59 +0000)]
Adopt Reveal Framework to replace Lookup
https://bugs.webkit.org/show_bug.cgi?id=191097
Source/WebCore:

Reviewed by Tim Horton.

Reveal is not currently testable.

The Reveal framework does the same job as Lookup and DataDectors.
In this patch we switch from using Lookup to determine what text
to select and define to using Reveal and RVItems. Since this
code needs to work on older systems, and Reveal is newer, we also need
to keep around the old code for old systems so that they can also
continue to work. Eventually we will remove this code and also likly switch
to passing RVItems across from the web process rather than making them
on each side.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* editing/mac/DictionaryLookup.h:
* editing/mac/DictionaryLookup.mm:

Create a delegate to respond to Reveal and help draw the string or highlight.

(-[WebRevealHighlight initWithHighlightRect:useDefaultHighlight:attributedString:]):
(-[WebRevealHighlight setClearTextIndicator:]):
(-[WebRevealHighlight revealContext:rectsForItem:]):
(-[WebRevealHighlight revealContext:drawRectsForItem:]):
(-[WebRevealHighlight revealContext:shouldUseDefaultHighlightForItem:]):
(-[WebRevealHighlight revealContext:stopHighlightingItem:]):
(WebCore::showPopupOrCreateAnimationController):

Unify the code paths and utalize the Reveal framework to create and/or display the popovers.

(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Pipe the new callback through.

(WebCore::tokenRange): Deleted.

Only used with Lookup

(WebCore::selectionContainsPosition): Deleted.

Only used with Lookup.

* editing/mac/DictionaryLookupLegacy.mm: Copied from Source/WebCore/editing/mac/DictionaryLookup.mm.

Keep a copy of the previous implementation of DictionaryLookup, because Reveal not available on older
system.

(WebCore::tokenRange):
(WebCore::selectionContainsPosition):
(WebCore::expandSelectionByCharacters):
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Add in reveal SPI so WebKit will continue to build without the internal SDK.

* PAL.xcodeproj/project.pbxproj:
* pal/spi/mac/RevealSPI.h: Added.

Source/WebKit:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Pass in what it needed to clear the textIndicators. This is better than
the current notification structure.

* UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver startObservingLookupDismissalIfNeeded]):
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForText]):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):

Generate and pass in the text indicator information, as this is needed now.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin):

Source/WebKitLegacy/mac:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Pass in what it needed to clear the textIndicators. This is better than
the current notification structure.

* WebView/WebView.mm:
(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
(-[WebView _prepareForDictionaryLookup]):

LayoutTests:

Reviewed by Tim Horton.

Reveal selects spaces instead of adjacent words, no matter how interesting they are.
Update the tests to show this, and change the expections for previous platforms.

* editing/mac/selection/context-menu-select-editability-expected.txt:
* editing/mac/selection/context-menu-select-editability.html:
* platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt: Copied from LayoutTests/editing/mac/selection/context-menu-select-editability-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoClean up test expectations after r237942
ryanhaddad@apple.com [Fri, 9 Nov 2018 01:51:52 +0000 (01:51 +0000)]
Clean up test expectations after r237942
https://bugs.webkit.org/show_bug.cgi?id=191448

Unreviewed test gardening.

Add High Sierra specific expectation files for three tests, rebaseline one for Mojave, and remove failure expectations.

* platform/mac-highsierra-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt: Copied from LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt.
* platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added.
* platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoOptions::useRegExpJIT() should use jitEnabledByDefault() just like useJIT()
msaboff@apple.com [Fri, 9 Nov 2018 01:34:20 +0000 (01:34 +0000)]
Options::useRegExpJIT() should use jitEnabledByDefault() just like useJIT()
https://bugs.webkit.org/show_bug.cgi?id=191444

Reviewed by Saam Barati.

* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but...
Hironori.Fujii@sony.com [Fri, 9 Nov 2018 01:29:52 +0000 (01:29 +0000)]
[Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')
https://bugs.webkit.org/show_bug.cgi?id=191416

Reviewed by Saam Barati.

* disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86): Use PRIxPTR for uintptr_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, a proper build fix for r237983
jiewen_tan@apple.com [Fri, 9 Nov 2018 00:23:24 +0000 (00:23 +0000)]
Unreviewed, a proper build fix for r237983

Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
(TestWebKitAPI::getTestCorruptedSignResponse):
(TestWebKitAPI::getTestCredentialRawIdBytes):
(TestWebKitAPI::convertToVector):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Mojave WK1] Layout test fast/events/detect-caps-lock.html is timing out
ryanhaddad@apple.com [Fri, 9 Nov 2018 00:22:32 +0000 (00:22 +0000)]
[Mojave WK1] Layout test fast/events/detect-caps-lock.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=191424

Unreviewed test gardening.

Update expectations since this test is only expected to run on WK2.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoCreate .xcfilelist files
krollin@apple.com [Fri, 9 Nov 2018 00:13:04 +0000 (00:13 +0000)]
Create .xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=191324
<rdar://problem/45852819>

Reviewed by Alex Christensen.

As part of preparing for enabling XCBuild, create and use .xcfilelist
files. These files are using during Run Script build phases in an
Xcode project. If a Run Script build phase produces new files that are
used later as inputs to subsequent build phases, XCBuild needs to know
about these files. These files can be either specified in an "output
files" section of the Run Script phase editor, or in .xcfilelist files
that are associated with the Run Script build phase.

This patch takes the second approach. It consists of three sets of changes:

- Modify the DerivedSources.make files to have a
  'print_all_generated_files" target that produces a list of the files
  they create.

- Create a shell script that produces .xcfilelist files from the
  output of the previous step, as well as for the files created in the
  Generate Unified Sources build steps.

- Add the new .xcfilelist files to the associated projects.

Note that, with these changes, the Xcode workspace and projects can no
longer be fully loaded into Xcode 9. Xcode will attempt to load the
projects that have .xcfilelist files associated with them, but will
fail and display a placeholder for those projects instead. It's
expected that all developers are using Xcode 10 by now and that not
being able to load into Xcode 9 is not a practical issue. Keep in mind
that this is strictly an IDE issue, and that the projects can still be
built with `xcodebuild`.

Also note that the shell script that creates the .xcfilelist files can
also be used to verify that the set of files that's currently checked
in is up-to-date. This checking can be used as part of a check-in hook
or part of check-webkit-style to sooner catch cases where the
.xcfilelist files need to be regenerated.

Source/JavaScriptCore:

* DerivedSources.make:
* DerivedSources.xcfilelist: Added.
* JavaScriptCore.xcodeproj/project.pbxproj:
* UnifiedSources.xcfilelist: Added.

Source/WebCore:

No new tests -- no changed functionality.

* DerivedSources.make:
* DerivedSources.xcfilelist: Added.
* UnifiedSources.xcfilelist: Added.
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

* DerivedSources.make:
* DerivedSources.xcfilelist: Added.
* UnifiedSources.xcfilelist: Added.
* WebKit.xcodeproj/project.pbxproj:

Tools:

* DumpRenderTree/DerivedSources.make:
* DumpRenderTree/DerivedSources.xcfilelist: Added.
* Scripts/generate-xcfilelists: Added.
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/DerivedSources.xcfilelist: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238008 268f45cc-cd09-0410-ab3c-d52691b4dbfc