WebKit-https.git
3 years agowebkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
jbedard@apple.com [Tue, 7 Mar 2017 20:05:50 +0000 (20:05 +0000)]
webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
https://bugs.webkit.org/show_bug.cgi?id=169220
<rdar://problem/30879645>

Reviewed by Daniel Bates.

Provide more specific port setup functions for iOS ports to allow more sharing of common code.

* Scripts/webkitpy/port/ios.py:
(IOSPort):
(IOSPort._create_devices): Added.
(IOSPort.setup_test_run): Shared iOS device setup code.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort._create_devices): Renamed from setup_test_run.
(IOSSimulatorPort.setup_test_run): Renamed as _create_devices.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRewrite the DRT Pasteboard implementation to use UTIs and WTF types
andersca@apple.com [Tue, 7 Mar 2017 19:27:51 +0000 (19:27 +0000)]
Rewrite the DRT Pasteboard implementation to use UTIs and WTF types
https://bugs.webkit.org/show_bug.cgi?id=169289

Reviewed by Tim Horton.

* DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(-[LocalPasteboard initWithName:]):
(-[LocalPasteboard name]):
(-[LocalPasteboard declareTypes:owner:]):
(isUTI):
(toUTI):
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard changeCount]):
(-[LocalPasteboard types]):
(-[LocalPasteboard availableTypeFromArray:]):
(-[LocalPasteboard setData:forType:]):
(-[LocalPasteboard dataForType:]):
(-[LocalPasteboard writeObjects:]):
(-[LocalPasteboard dealloc]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoParsing font descriptors inside @font-face needs to accept ranges
mmaxfield@apple.com [Tue, 7 Mar 2017 19:26:21 +0000 (19:26 +0000)]
Parsing font descriptors inside @font-face needs to accept ranges
https://bugs.webkit.org/show_bug.cgi?id=168893

Reviewed by Dean Jackson.

Source/WebCore:

Parse font-weight, font-stretch, and font-style ranges according to
https://drafts.csswg.org/css-fonts-4/#font-prop-desc. There is one difference, though:
as documented in https://github.com/w3c/csswg-drafts/issues/783, slashes are a better
delimiters than hyphens, so this patch implements that instead. I'll update the spec to
include slashes as soon as possible.

Because this patch is all about creating FontSelectionValues from fonts, it doesn't
actually modify the font selection algorithm, and therefore only tests the creation of
these new values. The font selection algorithm itself is already tested elsewhere.

This new work is behind the ENABLE(VARIATION_FONTS) flag.

Test: fast/text/font-selection-font-face-parse.html

* css/CSSFontFace.cpp:
(WebCore::calculateWeightRange):
(WebCore::calculateStretchRange):
(WebCore::calculateItalicRange):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontWeightRange):
(WebCore::consumeFontStretchRange):
(WebCore::consumeFontStyleRange):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::extractVariationBounds):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::capabilitiesForFontDescriptor):

LayoutTests:

* fast/text/font-selection-font-face-parse-expected.txt:
* fast/text/font-selection-font-face-parse.html:
* platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
Variations are off on El Capitan, so this platform needs explicit results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRevise the ARES-6 explainer text
fpizlo@apple.com [Tue, 7 Mar 2017 19:21:02 +0000 (19:21 +0000)]
Revise the ARES-6 explainer text
https://bugs.webkit.org/show_bug.cgi?id=169287

Reviewed by Saam Barati.

Just did some copy-editing.

* ARES-6/about.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
clopez@igalia.com [Tue, 7 Mar 2017 19:16:09 +0000 (19:16 +0000)]
Move webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
https://bugs.webkit.org/show_bug.cgi?id=169216

Unreviewed test gardening.

Move the test webrtc/descriptionGetters.html under the directory webrtc/libwebrtc
because its still not testing the spec, but the current libwebrtc based implementation.

This way the test is skipped on the GTK+ port (The whole directory webrtc/libwebrtc is skipped).

* webrtc/libwebrtc/descriptionGetters-expected.txt: Renamed from LayoutTests/webrtc/descriptionGetters-expected.txt.
* webrtc/libwebrtc/descriptionGetters.html: Renamed from LayoutTests/webrtc/descriptionGetters.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd David Jonathan Ross to contributors.json
mmaxfield@apple.com [Tue, 7 Mar 2017 18:54:56 +0000 (18:54 +0000)]
Add David Jonathan Ross to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=169265

Unreviewed.

David Jonathan Ross very kindly offered to create and contribute his Boxis font in r211060,
which is used for testing font variations.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Mac][WK2] Expand sandbox to support access to audio component registrar
bfulgham@apple.com [Tue, 7 Mar 2017 18:06:10 +0000 (18:06 +0000)]
[Mac][WK2] Expand sandbox to support access to audio component registrar
https://bugs.webkit.org/show_bug.cgi?id=169283
<rdar://problem/30793512>

Reviewed by Alexey Proskuryakov.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAnimated GIFs fail to play in multi-column layout
hyatt@apple.com [Tue, 7 Mar 2017 17:59:13 +0000 (17:59 +0000)]
Animated GIFs fail to play in multi-column layout
https://bugs.webkit.org/show_bug.cgi?id=167901
<rdar://problem/30382262>

Reviewed by Zalan Bujtas.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
Make sure to handle the case where we pass in a null repaintContainer and need
to cross a multicolumn flow thread -> region boundary as a result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoShadowBlur::calculateLayerBoundingRect doesn't need to return the enclosingIntRect...
zalan@apple.com [Tue, 7 Mar 2017 17:33:45 +0000 (17:33 +0000)]
ShadowBlur::calculateLayerBoundingRect doesn't need to return the enclosingIntRect of layerRect
https://bugs.webkit.org/show_bug.cgi?id=168650

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-03-07
Reviewed by Simon Fraser.

No new tests, no behavior change.

* platform/graphics/ShadowBlur.h: Change the type of return value
from IntRect to IntSize.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::calculateLayerBoundingRect): Ditto.
(WebCore::ShadowBlur::drawRectShadow): Rename a variable layerRect layerSize.
(WebCore::ShadowBlur::drawInsetShadow): Ditto.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::beginShadowLayer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoReplace debug assertion with release one in Frame::setView()
cdumez@apple.com [Tue, 7 Mar 2017 17:22:35 +0000 (17:22 +0000)]
Replace debug assertion with release one in Frame::setView()
https://bugs.webkit.org/show_bug.cgi?id=169189

Reviewed by Ryosuke Niwa.

Replace debug assertion with release one in Frame::setView() to make make sure the
document does not have a living render tree. This will help identify possible
remaining cases where this can happen.

* dom/Document.cpp:
(WebCore::Document::didBecomeCurrentDocumentInView): Deleted.
* dom/Document.h:
* page/Frame.cpp:
(WebCore::Frame::setView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoExpose WebRTC current/pending description getters
commit-queue@webkit.org [Tue, 7 Mar 2017 17:15:06 +0000 (17:15 +0000)]
Expose WebRTC current/pending description getters
https://bugs.webkit.org/show_bug.cgi?id=169216

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-07
Reviewed by Alex Christensen.

Source/WebCore:

Test: webrtc/descriptionGetters.html

Implement pending and current description getters through libwebrtc.
These getters do not yet match the spec as can be seen from the test, which is written to match the implemented behavior.

* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::currentLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::currentRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingRemoteDescription):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

* webrtc/descriptionGetters-expected.txt: Added.
* webrtc/descriptionGetters.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoPort DOMTimer from std::chrono::milliseconds to WTF::Seconds type
cdumez@apple.com [Tue, 7 Mar 2017 17:11:06 +0000 (17:11 +0000)]
Port DOMTimer from std::chrono::milliseconds to WTF::Seconds type
https://bugs.webkit.org/show_bug.cgi?id=169236

Reviewed by Simon Fraser.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::minimumDOMTimerInterval):
(WebCore::Document::timerAlignmentInterval):
* dom/Document.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::adjustMinimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::minimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):
* dom/ScriptExecutionContext.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didInstallTimer):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didInstallTimer):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createTimerInstallData):
* inspector/TimelineRecordFactory.h:
* page/DOMTimer.cpp:
(WebCore::shouldForwardUserGesture):
(WebCore::userGestureTokenToForward):
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::intervalClampedToMinimum):
(WebCore::DOMTimer::alignedFireTime):
* page/DOMTimer.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):
* page/Page.cpp:
(WebCore::Page::setTimerThrottlingState):
(WebCore::Page::setDOMTimerAlignmentIntervalIncreaseLimit):
(WebCore::Page::updateDOMTimerAlignmentInterval):
* page/Page.h:
(WebCore::Page::domTimerAlignmentInterval):
* page/Settings.cpp:
(WebCore::Settings::setMinimumDOMTimerInterval):
* page/Settings.h:
(WebCore::Settings::minimumDOMTimerInterval):
* page/SuspendableTimer.h:
(WebCore::SuspendableTimer::startRepeating):
(WebCore::SuspendableTimer::startOneShot):
(WebCore::SuspendableTimer::augmentFireInterval):
(WebCore::SuspendableTimer::augmentRepeatInterval):
* platform/Timer.cpp:
(WebCore::TimerBase::setNextFireTime):
* platform/Timer.h:
(WebCore::TimerBase::alignedFireTime):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMinimumTimerInterval):
* testing/InternalSettings.h:
* testing/Internals.cpp:
(WebCore::Internals::isTimerThrottled):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):

Source/WebKit2:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setHiddenPageDOMTimerThrottlingIncreaseLimit):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setHiddenPageDOMTimerThrottlingIncreaseLimit):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoW3C importer should be able to update the import expectations file
commit-queue@webkit.org [Tue, 7 Mar 2017 17:08:57 +0000 (17:08 +0000)]
W3C importer should be able to update the import expectations file
https://bugs.webkit.org/show_bug.cgi?id=168037

LayoutTests/imported/w3c:

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

* resources/import-expectations.json:

Tools:

Patch by Youenn Fablet <youennf@gmail.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

Changing import expectations from an array to a map.
Marking all test paths as import and updating import expectations file accordingly.

* Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.__init__):
(TestDownloader._init_paths_from_expectations):
(TestDownloader):
(TestDownloader.update_import_expectations):
* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.do_import):
* Scripts/webkitpy/w3c/test_importer_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAlign initEvent / initCustomEvent / initMessageEvent with the latest specification
cdumez@apple.com [Tue, 7 Mar 2017 17:03:16 +0000 (17:03 +0000)]
Align initEvent / initCustomEvent / initMessageEvent with the latest specification
https://bugs.webkit.org/show_bug.cgi?id=169176

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync web-platform tests from upstream after:
- https://github.com/w3c/web-platform-tests/pull/5043
- https://github.com/w3c/web-platform-tests/pull/5044

* web-platform-tests/dom/events/CustomEvent-expected.txt:
* web-platform-tests/dom/events/CustomEvent.html:
* web-platform-tests/dom/events/Event-initEvent-expected.txt:
* web-platform-tests/dom/events/Event-initEvent.html:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/interfaces.html:
* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces.html:
* web-platform-tests/html/dom/resources/interfaces.idl: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html.
* web-platform-tests/html/dom/resources/untested-interfaces.idl: Added.
* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor-expected.txt: Removed.
* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html: Removed.
* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html:

Source/WebCore:

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
after:
- https://github.com/whatwg/dom/pull/417
- https://github.com/whatwg/html/pull/2410

In particular, the following changes were made:
- initEvent: The length property now properly returns 1 instead of 3 as only the
  first parameter is mandatory. We were already behaving correcting the the length
  property value was wrong because we forgot to drop a hack from the bindings
  generator.
- initCustomEvent: Make all parameters except the first optional. Previously, all
  parameters were mandatory so this is safe.
- initMessageEvent: Drop the custom code and mark the first parameter as mandatory.
  A side effect of dropping the custom code is that null is no longer considered as
  valid input for the last parameter. The parameter is of type sequence<> and the
  new behavior is consistent with the specification and Firefox. If it turns out to
  break existing content, I'll make the parameter nullable in a follow-up.

No new tests, updated existing tests.

* bindings/js/JSMessageEventCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GeneratePropertiesHashTable):
* dom/CustomEvent.idl:
* dom/MessageEvent.idl:

LayoutTests:

Updated existing tests to reflect behavior change.

* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:
* fast/eventsource/eventsource-attribute-listeners.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK][Wayland] Update list of test failing on the Wayland release test bot.
clopez@igalia.com [Tue, 7 Mar 2017 17:02:27 +0000 (17:02 +0000)]
[GTK][Wayland] Update list of test failing on the Wayland release test bot.

Unreviewed test gardening.

* platform/gtk-wayland/TestExpectations: Update list of test failing on the Wayland release test bot.
* platform/gtk/TestExpectations: media/video-played-collapse.html crashes sometimes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDifferentiate between pending head and body stylesheets in Style::Scope
antti@apple.com [Tue, 7 Mar 2017 16:54:56 +0000 (16:54 +0000)]
Differentiate between pending head and body stylesheets in Style::Scope
https://bugs.webkit.org/show_bug.cgi?id=169277

Reviewed by Andreas Kling.

Split pending stylesheet node set into separate sets for head and body elements and processing instructions.

This tightens typing and will also be useful later.

* style/StyleScope.cpp:
(WebCore::Style::Scope::~Scope):
(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):
(WebCore::Style::Scope::didRemovePendingStylesheet):
(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheetInBody):
(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet): Deleted.
* style/StyleScope.h:
(WebCore::Style::Scope::hasPendingSheet): Deleted.
(WebCore::Style::Scope::hasPendingSheets): Deleted.
* style/StyleTreeResolver.cpp:
(WebCore::Style::hasLoadingStylesheet):

    Just test for body stylesheets.

(WebCore::Style::TreeResolver::resolve):

    Treat all before-body stylesheets uniformly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Modern Media Controls] Setting a valid source after an invalid one retains the inval...
commit-queue@webkit.org [Tue, 7 Mar 2017 16:23:30 +0000 (16:23 +0000)]
[Modern Media Controls] Setting a valid source after an invalid one retains the invalid placard
https://bugs.webkit.org/show_bug.cgi?id=169280
<rdar://problem/30876078>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-07
Reviewed by Jon Lee.

Source/WebCore:

We need to track when a new load start to see if we might have recovered from an error
and hide the "invalid" placard.

Test: media/modern-media-controls/placard-support/placard-support-error-recover.html

* Modules/modern-media-controls/media/placard-support.js:
(PlacardSupport.prototype.get mediaEvents):

LayoutTests:

Add a new test that checks that we know to remove the "invalid" placard if a new source is
set and media starts loading again.

* media/modern-media-controls/placard-support/placard-support-error-recover-expected.txt: Added.
* media/modern-media-controls/placard-support/placard-support-error-recover.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Mark media/video-buffered.html as flaky.
clopez@igalia.com [Tue, 7 Mar 2017 14:45:42 +0000 (14:45 +0000)]
[GTK] Mark media/video-buffered.html as flaky.

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd pdr to the rendering watchlist
rego@igalia.com [Tue, 7 Mar 2017 13:16:22 +0000 (13:16 +0000)]
Add pdr to the rendering watchlist
https://bugs.webkit.org/show_bug.cgi?id=167298

Patch by Philip Rogers <pdr@google.com> on 2017-03-07
Reviewed by Andreas Kling.

* Scripts/webkitpy/common/config/contributors.json: Switch to pdr+autocc@chromium.org
* Scripts/webkitpy/common/config/watchlist: Add pdr to the rendering watchlist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[css-grid] Mark a few tests from the W3C suite as pass after r213480
rego@igalia.com [Tue, 7 Mar 2017 13:05:51 +0000 (13:05 +0000)]
[css-grid] Mark a few tests from the W3C suite as pass after r213480
https://bugs.webkit.org/show_bug.cgi?id=169270

Unreviewed test gardening.

r213480 was porting some Blink patches that makes these tests to pass now.
Check the following bugs for more information:
- http://webkit.org/b/169197
- http://webkit.org/b/169198

* TestExpectations: Mark grid-minimum-size-grid-items-007.xht and
grid-minimum-size-grid-items-009.xht as passing.
Keep grid-items-sizing-alignment-001.html as failure but now for a different issue
(see http://webkit.org/b/169271).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] ECDH tests from imported/w3c/web-platform-tests/WebCryptoAPI/generateKey fail.
clopez@igalia.com [Tue, 7 Mar 2017 12:46:57 +0000 (12:46 +0000)]
[GTK] ECDH tests from imported/w3c/web-platform-tests/WebCryptoAPI/generateKey fail.

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Removed myself from the Accessibility watch list
mario@webkit.org [Tue, 7 Mar 2017 10:15:38 +0000 (10:15 +0000)]
Unreviewed. Removed myself from the Accessibility watch list

Patch by Mario Sanchez Prada <mario@webkit.org> on 2017-03-07

* Scripts/webkitpy/common/config/watchlist: Removed myself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc
aestes@apple.com [Tue, 7 Mar 2017 09:51:17 +0000 (09:51 +0000)]
REGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=169266

Reviewed by Tim Horton.

r213412 added functions to create a CGImageRef from a canvas image buffer, which were used
to create data: URLs and blobs. If JPEG premultiplication is applied, though,
WebCore::cgImage() would return an image with a data provider pointing to stack memory.

I fixed a similar issue in ImageBuffer::toCGImage() by leaking the reference to a
Uint8ClampedArray then creating a CGDataProviderRef with a releaseData function that adopts
the leaked reference.

We could take that approach in cgImage() too by allocating the premultiplied data buffer on
the heap then freeing it with a releaseData function, but it's simpler to refactor
toCGImage()/cgImage() to return an encoded image as a CFDataRef instead of a CFImageRef.
This ensures that a CGDataProviderRef never outlives the data it points to.

Covered by existing tests.

* platform/graphics/ImageBuffer.h: Renamed toCGImage() to toCFData().
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::dataURL): Changed to take a CFDataRef.
(WebCore::dataVector): Renamed from data(). Changed to take a CFDataRef.
(WebCore::ImageBuffer::toDataURL): Changed to call toCFData().
(WebCore::ImageBuffer::toData): Ditto.
(WebCore::ImageBuffer::toCFData): Changed to return a CFDataRef after encoding the
CGImageRef that was previously returned.
(WebCore::cfData): Ditto.
(WebCore::dataURL): Changed to call cfData().
(WebCore::data): Ditto.
(WebCore::ImageBuffer::toCGImage): Renamed to ImageBuffer::toCFData().
(WebCore::cgImage): Renamed to WebCore::cfData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTest fix after r213505
mmaxfield@apple.com [Tue, 7 Mar 2017 08:47:03 +0000 (08:47 +0000)]
Test fix after r213505
https://bugs.webkit.org/show_bug.cgi?id=169267

Unreviewed.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWebAssembly: Implement the WebAssembly.instantiate API
sbarati@apple.com [Tue, 7 Mar 2017 07:38:41 +0000 (07:38 +0000)]
WebAssembly: Implement the WebAssembly.instantiate API
https://bugs.webkit.org/show_bug.cgi?id=165982
<rdar://problem/29760110>

Reviewed by Keith Miller.

JSTests:

* wasm/js-api/web-assembly-instantiate.js: Added.
(assert.eq.async.test):
(assert.eq):
(assert.truthy.async.test):
(assert.truthy):

Source/JavaScriptCore:

This patch is a straight forward implementation of the WebAssembly.instantiate
API: https://github.com/WebAssembly/design/blob/master/JS.md#webassemblyinstantiate

I implemented the API in a synchronous manner. We should make it
asynchronous: https://bugs.webkit.org/show_bug.cgi?id=169187

* wasm/JSWebAssembly.cpp:
(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):
(JSC::JSWebAssembly::finishCreation):
* wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::createInstance):
* wasm/js/WebAssemblyInstanceConstructor.h:
* wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::constructJSWebAssemblyModule):
(JSC::WebAssemblyModuleConstructor::createModule):
* wasm/js/WebAssemblyModuleConstructor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoApply well-known-axis variation values at the right time in preparePlatformFont()
mmaxfield@apple.com [Tue, 7 Mar 2017 07:30:27 +0000 (07:30 +0000)]
Apply well-known-axis variation values at the right time in preparePlatformFont()
https://bugs.webkit.org/show_bug.cgi?id=168896

Reviewed by Jon Lee.

Source/WebCore:

Simply plumb the FontSelectionRequest to the place where font variations are implemented.

Test: fast/text/variations/font-selection-properties.html

* platform/graphics/FontCache.h:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):

LayoutTests:

* fast/text/variations/font-selection-properties-expected.html: Added.
* fast/text/variations/font-selection-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoEnable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
aakash_jain@apple.com [Tue, 7 Mar 2017 07:19:51 +0000 (07:19 +0000)]
Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
https://bugs.webkit.org/show_bug.cgi?id=169233

Reviewed by Alexey Proskuryakov.

* Configurations/Base.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
* Configurations/WebKit.xcconfig: Pass information to TAPI about reexporting WebKitLegacy and few extra headers.
* WebKit2.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd Fujii Hironori to contributor's list
utatane.tea@gmail.com [Tue, 7 Mar 2017 07:01:12 +0000 (07:01 +0000)]
Add Fujii Hironori to contributor's list
https://bugs.webkit.org/show_bug.cgi?id=169261

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

Add myself to the contributor's lists so that my e-mail autocompletes for CC

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed post-review fixup after r213464
mmaxfield@apple.com [Tue, 7 Mar 2017 06:24:16 +0000 (06:24 +0000)]
Unreviewed post-review fixup after r213464
https://bugs.webkit.org/show_bug.cgi?id=169255

* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::computeNecessarySynthesis):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoValidate DOM after potentially destructive actions during parser insert operations
bfulgham@apple.com [Tue, 7 Mar 2017 06:10:37 +0000 (06:10 +0000)]
Validate DOM after potentially destructive actions during parser insert operations
https://bugs.webkit.org/show_bug.cgi?id=169222
<rdar://problem/30689729>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not perform an insert operation if the next child's parent is no longer
part of the tree. This can happen if JavaScript runs during node removal
events and modifies the contents of the document.

This patch was inspired by a similar Blink change by Marius Mlynski:
<https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

Tests: fast/parser/scriptexec-during-parserInsertBefore.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

LayoutTests:

This change merges a Blink test case from:
<https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

* fast/parser/scriptexec-during-parserInsertBefore-expected.txt: Added.
* fast/parser/scriptexec-during-parserInsertBefore.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed build fix to add
msaboff@apple.com [Tue, 7 Mar 2017 05:44:03 +0000 (05:44 +0000)]
Unreviewed build fix to add
-isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
for objective C++ files.

* Configurations/WebKitLegacy.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUpdate isEmojiGroupCandidate() to the latest version of Unicode
mmaxfield@apple.com [Tue, 7 Mar 2017 05:37:35 +0000 (05:37 +0000)]
Update isEmojiGroupCandidate() to the latest version of Unicode
https://bugs.webkit.org/show_bug.cgi?id=168198

Reviewed by Jon Lee.

Source/WebCore:

In the latest version of Unicode, many more code points are candidates for emoji groups.
Therefore, isEmojiGroupCandidate() should be made more permissive. This way, the function
is more future-proof.

Test: editing/deleting/delete-emoji.html

* platform/text/CharacterProperties.h:
(WebCore::icuLibraryUnderstandsSupplementalSymbolsAndPictographs):
(WebCore::isEmojiGroupCandidate):

LayoutTests:

* platform/ios-simulator/editing/deleting/delete-emoji-expected.txt:
* platform/mac/editing/deleting/delete-emoji-expected.txt:
* editing/deleting/delete-emoji.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundl...
mitz@apple.com [Tue, 7 Mar 2017 05:15:26 +0000 (05:15 +0000)]
[Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
https://bugs.webkit.org/show_bug.cgi?id=169223

Reviewed by Tim Horton.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Declared new
  delegate method -_webProcessPlugInBrowserContextControllerDidChangeByEditing:.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Added an override
  of API::InjectedBundle::EditorClient::didChange that calls the new delegate method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoBring back WebKit specific changes to disable temporarily libwebrtc video adaptation
commit-queue@webkit.org [Tue, 7 Mar 2017 04:44:26 +0000 (04:44 +0000)]
Bring back WebKit specific changes to disable temporarily libwebrtc video adaptation
https://bugs.webkit.org/show_bug.cgi?id=169229

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

* Source/webrtc/modules/video_coding/video_sender.cc: disabling frame dropping.
* Source/webrtc/video/vie_encoder.cc: disabling resolution decrease based on CPU overuse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed build fix after r213492.
msaboff@apple.com [Tue, 7 Mar 2017 04:39:15 +0000 (04:39 +0000)]
Unreviewed build fix after r213492.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
aakash_jain@apple.com [Tue, 7 Mar 2017 04:22:54 +0000 (04:22 +0000)]
Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
https://bugs.webkit.org/show_bug.cgi?id=169225

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/_WKLinkIconParameters.h:
* UIProcess/_WKWebViewPrintFormatter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUse default configuration for libwebrtc peerconnection
commit-queue@webkit.org [Tue, 7 Mar 2017 04:21:12 +0000 (04:21 +0000)]
Use default configuration for libwebrtc peerconnection
https://bugs.webkit.org/show_bug.cgi?id=169239

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::configurationFromMediaEndpointConfiguration): Using the default configuration instead of the aggressive one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
commit-queue@webkit.org [Tue, 7 Mar 2017 04:17:01 +0000 (04:17 +0000)]
[CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
https://bugs.webkit.org/show_bug.cgi?id=169244

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-03-06
Reviewed by Alex Christensen.

A distributed build system SN-DBS can not find
WebCoreTestSupportPrefix.h without an include path to it.

* CMakeLists.txt: Add 'WebCore/testing/js' to include paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed build fix after r213483.
msaboff@apple.com [Tue, 7 Mar 2017 03:37:35 +0000 (03:37 +0000)]
Unreviewed build fix after r213483.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[cairo] error C2065: 'quality': undeclared identifier since r213412
commit-queue@webkit.org [Tue, 7 Mar 2017 03:11:14 +0000 (03:11 +0000)]
[cairo] error C2065: 'quality': undeclared identifier since r213412
https://bugs.webkit.org/show_bug.cgi?id=169240

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-03-06
Reviewed by Ryosuke Niwa.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::toDataURL): Name the unnamed second argument 'quality'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Mac][WK2] Support new CoreMedia routing features
bfulgham@apple.com [Tue, 7 Mar 2017 03:09:43 +0000 (03:09 +0000)]
[Mac][WK2] Support new CoreMedia routing features
https://bugs.webkit.org/show_bug.cgi?id=169241
<rdar://problem/30077969>

Reviewed by Alexey Proskuryakov.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WebCrypto] Implement ECDH GenerateKey operation
jiewen_tan@apple.com [Tue, 7 Mar 2017 02:56:58 +0000 (02:56 +0000)]
[WebCrypto] Implement ECDH GenerateKey operation
https://bugs.webkit.org/show_bug.cgi?id=169093
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

* web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt:

Source/WebCore:

This patch implements GenerateKey operation of ECDH according to:
https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.
Note: Sad that we are not able to support P-521 at this moment due
to lack of necessary support in the underlying crypto library.

Tests: crypto/subtle/ec-generate-key-malformed-parameters.html
       crypto/subtle/ecdh-generate-key-extractable.html
       crypto/subtle/ecdh-generate-key-p256.html
       crypto/subtle/ecdh-generate-key-p384.html
       crypto/subtle/ecdh-generate-key-single-usage.html
       crypto/workers/subtle/ec-generate-key.html

* CMakeLists.txt:
* DerivedSources.make:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCryptoKeyCustom.cpp:
(WebCore::JSCryptoKey::algorithm):
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionGenerateKeyPromise):
Add support for ECDH.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
Structured clonable will be added later on.
* crypto/CommonCryptoUtilities.h:
Add SPI for EC.
* crypto/CryptoAlgorithmParameters.h:
* crypto/CryptoKey.h:
* crypto/algorithms/CryptoAlgorithmECDH.cpp: Added.
(WebCore::CryptoAlgorithmECDH::create):
(WebCore::CryptoAlgorithmECDH::identifier):
(WebCore::CryptoAlgorithmECDH::generateKey):
* crypto/algorithms/CryptoAlgorithmECDH.h: Added.
* crypto/gnutls/CryptoKeyECGnuTLS.cpp: Added.
(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):
* crypto/keys/CryptoKeyEC.cpp: Added.
(WebCore::CryptoKeyEC::CryptoKeyEC):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::buildAlgorithm):
(WebCore::CryptoKeyEC::exportData):
* crypto/keys/CryptoKeyEC.h: Added.
(WebCore::EcKeyAlgorithm::EcKeyAlgorithm):
(WebCore::EcKeyAlgorithm::namedCurve):
* crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Add support for ECDH.
* crypto/mac/CryptoKeyECMac.cpp: Added.
(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):
* crypto/parameters/CryptoAlgorithmEcKeyParams.h: Added.
* crypto/parameters/EcKeyParams.idl: Added.

LayoutTests:

* crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Added.
* crypto/subtle/ec-generate-key-malformed-parameters.html: Added.
* crypto/subtle/ecdh-generate-key-extractable-expected.txt: Added.
* crypto/subtle/ecdh-generate-key-extractable.html: Added.
* crypto/subtle/ecdh-generate-key-p256-expected.txt: Added.
* crypto/subtle/ecdh-generate-key-p256.html: Added.
* crypto/subtle/ecdh-generate-key-p384-expected.txt: Added.
* crypto/subtle/ecdh-generate-key-p384.html: Added.
* crypto/subtle/ecdh-generate-key-single-usage-expected.txt: Added.
* crypto/subtle/ecdh-generate-key-single-usage.html: Added.
* crypto/workers/subtle/ec-generate-key-expected.txt: Added.
* crypto/workers/subtle/ec-generate-key.html: Added.
* crypto/workers/subtle/resources/ec-generate-key.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, fix unused parameter warning after r213464
mcatanzaro@igalia.com [Tue, 7 Mar 2017 02:32:55 +0000 (02:32 +0000)]
Unreviewed, fix unused parameter warning after r213464

* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as...
clopez@igalia.com [Tue, 7 Mar 2017 02:31:36 +0000 (02:31 +0000)]
[GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.

Unreviewed test gardening.

The ContendedShortSection version of this tests were already marked as slow.
And the ContendedLongSection version takes more or less the same time to run.
They cause time outs on the bot sometimes.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Fix test expected error message.
sbarati@apple.com [Tue, 7 Mar 2017 02:10:14 +0000 (02:10 +0000)]
Unreviewed. Fix test expected error message.

* wasm/js-api/element.js:
(assert.throws):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTake advantage of fast permissions switching of JIT memory for devices that support it
msaboff@apple.com [Tue, 7 Mar 2017 01:51:19 +0000 (01:51 +0000)]
Take advantage of fast permissions switching of JIT memory for devices that support it
https://bugs.webkit.org/show_bug.cgi?id=169155

Reviewed by Saam Barati.

Source/JavaScriptCore:

Start using the os_thread_self_restrict_rwx_to_XX() SPIs when available to
control access to JIT memory.

Had to update the Xcode config files to handle various build variations of
public and internal SDKs.

* Configurations/Base.xcconfig:
* Configurations/FeatureDefines.xcconfig:
* jit/ExecutableAllocator.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):
* jit/ExecutableAllocator.h:
(JSC::performJITMemcpy):

Source/WebCore:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

* Configurations/Base.xcconfig:
* Configurations/FeatureDefines.xcconfig:
* Configurations/WebCore.xcconfig:

Source/WebCore/PAL:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

* Configurations/FeatureDefines.xcconfig:

Tools:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMake WKMenuItemIdentifiersPrivate.h private header
aakash_jain@apple.com [Tue, 7 Mar 2017 01:39:52 +0000 (01:39 +0000)]
Make WKMenuItemIdentifiersPrivate.h private header
https://bugs.webkit.org/show_bug.cgi?id=168981

Reviewed by Tim Horton.

Source/WebCore:

* platform/spi/mac/NSMenuSPI.h: NSUserInterfaceItemIdentification is in the public header in recent SDKs.

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj: Made WKMenuItemIdentifiersPrivate.h private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoReplace -sub_umbrella linker flag with a build setting
ap@apple.com [Tue, 7 Mar 2017 01:39:30 +0000 (01:39 +0000)]
Replace -sub_umbrella linker flag with a build setting
https://bugs.webkit.org/show_bug.cgi?id=169146

Reviewed by Tim Horton.

* Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION: Block no longer shrinks to preferred width in this flex box layout
hyatt@apple.com [Tue, 7 Mar 2017 01:29:19 +0000 (01:29 +0000)]
REGRESSION: Block no longer shrinks to preferred width in this flex box layout
https://bugs.webkit.org/show_bug.cgi?id=169203
<rdar://problem/30873895>

Reviewed by Simon Fraser.

Source/WebCore:

Added new test in css3/flexbox.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustStyleForAlignment):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::resolveCustomStyle):
Resolve auto alignment values by adjusting the render style as needed. Make a helper
function for adjusting only alignment that can be called from the inner text control
custom style creation.

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild):
Replaced items in grids should not stretch by default.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasStretchedLogicalWidth):
Patched to properly check the default alignment for the child, making sure
that if it's a replacd item inside a grid, that the default is start and not
stretch.

* rendering/RenderBox.h:
(WebCore::RenderBox::selfAlignmentNormalBehavior):
Self-alignment function now takes an optional child argument, since the behavior
varies in grids depending on the child being replaced or not.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignmentForChild):
Fixed to do the right thing when the child is anonymous.

(WebCore::RenderFlexibleBox::styleDidChange): Deleted.
* rendering/RenderFlexibleBox.h:
Deleted, since alignment changes are handled at the style diff level now.

* rendering/RenderFullScreen.h:
Patched the selfAlignmentNormalBehavior method to take an optional child argument.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::alignSelfForChild):
(WebCore::RenderGrid::justifySelfForChild):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::defaultAlignmentIsStretch): Deleted.
(WebCore::defaultAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInColumnAxis): Deleted.
(WebCore::selfAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInColumnAxis): Deleted.
* rendering/RenderGrid.h:
Removed the alignment change logic in styleDidChange for grids, since style diffing handles
it now. Updated all selfAlignmentForNormalBehavior queries to pass in the child so that
replaced elements are handled properly.

* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::overflowInlineDirection):
(WebCore::RenderStyle::overflowBlockDirection):
(WebCore::RenderStyle::setJustifySelfPosition):
New helpers used by grid and by adjustRenderStyle.

* style/StyleChange.cpp:
(WebCore::Style::determineChange):
If alignment or justification changes occur on a parent that could affect the child (e.g., align-items)
return Inherit so the child render styles get adjusted properly.

LayoutTests:

* css3/flexbox/column-inside-normal-block-preferred-width-expected.html: Added.
* css3/flexbox/column-inside-normal-block-preferred-width.html: Added.
* fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt:
* fast/css-grid-layout/grid-align-stretching-replaced-items.html:
* fast/repaint/align-items-change-expected.txt:
* fast/repaint/align-items-overflow-change-expected.txt:
* fast/repaint/justify-items-change-expected.txt:
* fast/repaint/justify-items-legacy-change-expected.txt:
* fast/repaint/justify-items-overflow-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agohttps://bugs.webkit.org/show_bug.cgi?id=169234
lforschler@apple.com [Tue, 7 Mar 2017 00:20:30 +0000 (00:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=169234
torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoASSERTION FAILED: numberOfChannels == 2 in WebCore::RealtimeIncomingAudioSource:...
commit-queue@webkit.org [Tue, 7 Mar 2017 00:09:19 +0000 (00:09 +0000)]
ASSERTION FAILED: numberOfChannels == 2 in WebCore::RealtimeIncomingAudioSource::OnData
https://bugs.webkit.org/show_bug.cgi?id=169224
<rdar://problem/30856811>

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

* platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::OnData): Updated assertion to allow 1 channel since we can handle it as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark inspector/worker/console-basic.html as flaky.
ryanhaddad@apple.com [Mon, 6 Mar 2017 23:38:02 +0000 (23:38 +0000)]
Mark inspector/worker/console-basic.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169228

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky on ios-simulator.
ryanhaddad@apple.com [Mon, 6 Mar 2017 23:33:51 +0000 (23:33 +0000)]
Mark scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=168924

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel...
ryanhaddad@apple.com [Mon, 6 Mar 2017 23:29:20 +0000 (23:29 +0000)]
Mark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169159

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragg...
ryanhaddad@apple.com [Mon, 6 Mar 2017 23:24:44 +0000 (23:24 +0000)]
Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169158

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] Throttle CSS animations to 30fps in low power mode
cdumez@apple.com [Mon, 6 Mar 2017 23:07:50 +0000 (23:07 +0000)]
[iOS] Throttle CSS animations to 30fps in low power mode
https://bugs.webkit.org/show_bug.cgi?id=169138
<rdar://problem/30837805>

Reviewed by Said Abou-Hallawa.

Source/WebCore:

Throttle software CSS animations to 30fps in low power mode on iOS
to save battery.

Test: fast/animation/css-animation-throttling-lowPowerMode.html

* page/Page.cpp:
(WebCore::Page::handleLowModePowerChange):
* page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):
(WebCore::CSSAnimationControllerPrivate::updateThrottlingState):
(WebCore::CSSAnimationControllerPrivate::animationInterval):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdate):
(WebCore::CSSAnimationController::updateThrottlingState):
(WebCore::CSSAnimationController::animationInterval):
* page/animation/CSSAnimationController.h:
* page/animation/CSSAnimationControllerPrivate.h:
* testing/Internals.cpp:
(WebCore::Internals::animationsInterval):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Add layout test coverage.

* fast/animation/css-animation-throttling-lowPowerMode-expected.txt: Added.
* fast/animation/css-animation-throttling-lowPowerMode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION(r212778): It made 400 tests crash on AArch64 Linux
ossy@webkit.org [Mon, 6 Mar 2017 23:07:27 +0000 (23:07 +0000)]
REGRESSION(r212778): It made 400 tests crash on AArch64 Linux
https://bugs.webkit.org/show_bug.cgi?id=168502

Reviewed by Filip Pizlo.

* heap/RegisterState.h: Use setjmp code path on AArch64 Linux too to fix crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMedia: notify clients when the user never plays a media element that was prevented...
mrajca@apple.com [Mon, 6 Mar 2017 23:06:08 +0000 (23:06 +0000)]
Media: notify clients when the user never plays a media element that was prevented from auto-playing
https://bugs.webkit.org/show_bug.cgi?id=169150

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
* page/AutoplayEvent.h:

Source/WebKit2:

* UIProcess/API/C/WKPageUIClient.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(TEST): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRefactor ContentExtensionParser
achristensen@apple.com [Mon, 6 Mar 2017 22:56:43 +0000 (22:56 +0000)]
Refactor ContentExtensionParser
https://bugs.webkit.org/show_bug.cgi?id=169214

Reviewed by Brady Eidson.

No change in behavior, as verified by existing API tests.
This will make it easier to use getStringList for other things in coming patches.

* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getStringList):
(WebCore::ContentExtensions::getDomainList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix URLs relative to file URLs with paths beginning with Windows drive letters
achristensen@apple.com [Mon, 6 Mar 2017 22:55:33 +0000 (22:55 +0000)]
Fix URLs relative to file URLs with paths beginning with Windows drive letters
https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as file:///C:/
which should not be removed when making other URLs relative to them.
See https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

* platform/URLParser.cpp:
(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):
* platform/URLParser.h:

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/relative-win-expected.txt:
Some tests pass now.  localhost should indeed be removed according to the latest spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix Production libwebrtc build after r213418
achristensen@apple.com [Mon, 6 Mar 2017 22:46:57 +0000 (22:46 +0000)]
Fix Production libwebrtc build after r213418
https://bugs.webkit.org/show_bug.cgi?id=169217
<rdar://problem/30876775>

Reviewed by Tim Horton.

* Source/webrtc/base/checks.h:
* libwebrtc.xcodeproj/project.pbxproj:
MakeCheckOpString was a weak export, and it wasn't needed.
There is an internal build that checks for weak exports and fails if there is one.
Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoop_get_by_id_with_this should use inline caching
commit-queue@webkit.org [Mon, 6 Mar 2017 22:03:56 +0000 (22:03 +0000)]
op_get_by_id_with_this should use inline caching
https://bugs.webkit.org/show_bug.cgi?id=162124

Patch by Caio Lima <ticaiolima@gmail.com> on 2017-03-06
Reviewed by Saam Barati.

JSTests:

* microbenchmarks/super-getter.js: Added.
(A.prototype.get f):
(A):
(B.prototype.get f):
(B):
* stress/super-force-ic-fail.js: Added.
(let.assert):
(let.aObj.get foo):
(let.obj.jaz):
(let.bObj.get foo):
(let.obj2.foo):
* stress/super-get-by-id.js: Added.
(assert):
(Base):
(Base.prototype.get name):
(Base.prototype.set name):
(Subclass.prototype.get name):
(Subclass):
(getterName):
(getterValue):
(PolymorphicSubclass.prototype.get value):
(PolymorphicSubclass):
(i.let.BaseCode):
(i.get value):
(MegamorphicSubclass.prototype.get value):
(MegamorphicSubclass):
(let.subObj.get value):
(i.catch):
(subObj.get value):
(BaseException):
(BaseException.prototype.get name):
(SubclassException.prototype.get name):
(SubclassException):
(prototype.foo):
(prototype.get name):
(SubclassExceptionComplex.prototype.get name):
(SubclassExceptionComplex):
* stress/super-getter-reset-ic.js: Added.
(let.assert):
(let.B.f):

Source/JavaScriptCore:

This patch is enabling inline cache for op_get_by_id_with_this in all
tiers. It means that operations using ```super.member``` are going to
be able to be optimized by PIC. To enable it, we introduced a new
member of StructureStubInfo.patch named thisGPR, created a new class
to manage the IC named JITGetByIdWithThisGenerator and changed
PolymorphicAccess.regenerate that uses StructureStubInfo.patch.thisGPR
to decide the correct this value on inline caches.
With inline cached enabled, ```super.member``` are ~4.5x faster,
according microbenchmarks.

* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
* bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
* bytecode/PolymorphicAccess.h:
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::reset):
* bytecode/StructureStubInfo.h:
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addGetByIdWithThis):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
* jit/ICStats.h:
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):
* jit/JIT.h:
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITGetByIdWithThisGenerator::generateFastPath):
* jit/JITInlineCacheGenerator.h:
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
* jit/Repatch.cpp:
(JSC::appropriateOptimizingGetByIdFunction):
(JSC::appropriateGenericGetByIdFunction):
(JSC::tryCacheGetByID):
* jit/Repatch.h:
* jsc.cpp:
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetterAcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoOnly use layer backing store which supports subpixel antialiased text if we know...
simon.fraser@apple.com [Mon, 6 Mar 2017 21:45:38 +0000 (21:45 +0000)]
Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
https://bugs.webkit.org/show_bug.cgi?id=169191

Reviewed by Zalan Bujtas.

Source/WebCore:

Instead of unconditionally calling setSupportsSubpixelAntialiasedText() on GraphicsLayers created
by RenderLayerBacking, only do so when we know (or suspect) that a layer contains smoothed text.

This is done by enhancing RenderLayer::isVisuallyNonEmpty() and RenderLayer::hasNonEmptyChildRenderers()
to take a PaintedContentRequest parameter, which allows the caller to specify what qualities of
the layer contents it is interested in. Most of the time, this is just any painted content, but on
platforms where GraphicsLayer::supportsSubpixelAntialiasedLayerText() returns true, the query also
asks about whether the layer will contain subpixel-antialiased text. In this case, it can't early
return as soon as painted content is found; it must keep iterating renderers while all the query
requests are unsatisfied, or until it hits depth or sibling limits. If a limit is hit, we take the
same path of assuming there is subpixel-antialiased text (via the "Undetermined" state).

RenderLayerBacking also makes use of PaintedContentRequest during its non-composited child layer walk.

To offset the additional cost of this tree walking, RenderLayerBacking now caches information about its
painted content for the duration of a single update via PaintedContentsInfo, so we no longer call
isDirectlyCompositedImage() and isSimpleContainerCompositingLayer() multiple times per backing per update.
The traversal code here too now has to continue until all necessary states in the request have been computed.

Add some functions to RenderImage so that we know if it's showing the alt text or has a non-bitmap image
(which may contain text).

Subpixel-antialiased ("smoothed") text is disabled by DRT and WTR by default, so we need Internals API to enable it.

Platforms now express their support for subpixel-antialiased text via GraphicsLayer::supportsSubpixelAntialiasedLayerText()
which only returns true on Mac.

Tests: compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html
       compositing/contents-format/subpixel-antialiased-text-configs.html
       compositing/contents-format/subpixel-antialiased-text-images.html
       compositing/contents-format/subpixel-antialiased-text-visibility.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::isShowingAltText):
(WebCore::RenderImage::hasNonBitmapImage):
* rendering/RenderImage.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::PaintedContentsInfo::PaintedContentsInfo):
(WebCore::PaintedContentsInfo::setWantsSubpixelAntialiasedTextState):
(WebCore::PaintedContentsInfo::paintsBoxDecorations):
(WebCore::PaintedContentsInfo::paintsContent):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedText):
(WebCore::PaintedContentsInfo::isSimpleContainer):
(WebCore::PaintedContentsInfo::isDirectlyCompositedImage):
(WebCore::PaintedContentsInfo::paintsBoxDecorationsDetermination):
(WebCore::PaintedContentsInfo::paintsContentDetermination):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedTextDetermination):
(WebCore::PaintedContentsInfo::contentsTypeDetermination):
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsContent):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::paintsChildRenderers): Deleted.
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
* testing/Internals.cpp:
(WebCore::Internals::setFontSmoothingEnabled):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Test lots of layer configs for subpixel antialiased text support. Only Mac results show the
"(supports subpixel antialiased text 1)" flag on layers now, since the patch makes this
dependent on platform support.

* compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
* compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html: Added.
* compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
* compositing/contents-format/subpixel-antialiased-text-configs.html: Added.
* compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
* compositing/contents-format/subpixel-antialiased-text-enabled.html:
* compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
* compositing/contents-format/subpixel-antialiased-text-images.html: Added.
* compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
* compositing/contents-format/subpixel-antialiased-text-visibility.html: Added.
* compositing/resources/circle-with-text.svg: Added.
* compositing/resources/circle.svg: Added.
* platform/mac-wk1/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
* platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Copied from LayoutTests/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWebAssembly: implement init_expr for Element
sbarati@apple.com [Mon, 6 Mar 2017 21:44:20 +0000 (21:44 +0000)]
WebAssembly: implement init_expr for Element
https://bugs.webkit.org/show_bug.cgi?id=165888
<rdar://problem/29760199>

Reviewed by Keith Miller.

JSTests:

* wasm/Builder_WebAssemblyBinary.js:
(const.emitters.Element):
* wasm/assert.js:
* wasm/js-api/element.js:
(assert.throws):
(badInstantiation.makeModule):
(badInstantiation.test):
(badInstantiation):
* wasm/js-api/global-error.js:

Source/JavaScriptCore:

This patch fixes a few bugs. The main change is allowing init_expr
for the Element's offset. To do this, I had to fix a couple of
other bugs:

- I removed our invalid early module-parse-time invalidation
of out of bound Element sections. This is not in the spec because
it can't be validated in the general case when the offset is a
get_global.

- Our get_global validation inside our init_expr parsing code was simply wrong.
It thought that the index operand to get_global went into the pool of imports,
but it does not. It indexes into the pool of globals. I changed the code to
refer to the global pool instead.

* wasm/WasmFormat.h:
(JSC::Wasm::Element::Element):
* wasm/WasmModuleParser.cpp:
* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoExpand font-weight and font-stretch to take any number
mmaxfield@apple.com [Mon, 6 Mar 2017 21:40:31 +0000 (21:40 +0000)]
Expand font-weight and font-stretch to take any number
https://bugs.webkit.org/show_bug.cgi?id=168889

Reviewed by Simon Fraser.

Source/WebCore:

This patch expands parsing support for font-weight and font-stretch so that they can accept
numbers in addition to the keyword values they accepted previously. Eventually, these numbers
will be used as inputs to select variation fonts; however, in this patch, the values are just
parsed and held in our internal data model. This means that this patch doesn't actually change
the general behavior of WebKit; instead, it parses new values, outputs them (via
getComputedStyle() and similar functions), and provides them as input to our preexisting font
selection algorithm.

This patch doesn't actually modify anything algorithmically, and therefore, it doesn't include
any additional tests for the font selection algorithm. Instead, it tests the parsing of the
newly accepted values (both input and output).

Because our internal data model needs to hold numbers now, this patch also completely eliminates
the FontWidth, FontItalic, and FontTraitsMask enum values in favor of FontSelectionValues (which
can hold numbers instead of individual enum values). Therefore, every place which we were using
these enum values is migrated in this patch to using FontSelectionValues instead.

Tests: fast/text/font-selection-font-face-parse.html
       fast/text/font-selection-font-loading-api-parse.html
       fast/text/font-style-parse.html
       fast/text/font-weight-parse.html

* accessibility/AccessibilityRenderObject.cpp: Migrate off of old enum types.
(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp: Ditto.
(getAttributeSetForAccessibilityObject):
* css/CSSComputedStyleDeclaration.cpp: Output newly parsed values.
(WebCore::fontWeightFromStyle):
(WebCore::fontStretchFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSFontFace.cpp: Migrate off old enum types.
(WebCore::calculateWeightRange):
(WebCore::CSSFontFace::setWeight):
(WebCore::calculateStretchRange):
(WebCore::CSSFontFace::setStretch):
(WebCore::calculateStyleRange):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::calculateStyleMask): Deleted.
(WebCore::CSSFontFace::calculateWeightMask): Deleted.
(WebCore::CSSFontFace::calculateStretch): Deleted.
* css/CSSFontFace.h:
* css/CSSFontFaceSet.cpp: Migrate off old enum types.
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::calculateWeightValue):
(WebCore::calculateStretchValue):
(WebCore::calculateStyleValue):
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::fontFace):
(WebCore::computeFontTraitsMask): Deleted.
(WebCore::computeFontStretch): Deleted.
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp: Migrate off old enum types.
(WebCore::CSSFontSelector::fontRangesForFamily):
* css/CSSPrimitiveValueMappings.h: font-weight and font-style are no longer
keyword properties.
(WebCore::CSSPrimitiveValue::operator FontWeight): Deleted.
(WebCore::CSSPrimitiveValue::operator FontItalic): Deleted.
* css/CSSProperties.json: Use the same infrastructure for all three of the
font selection properties.
* css/CSSSegmentedFontFace.cpp: Migrate off old enum types.
(WebCore::CSSSegmentedFontFace::fontRanges):
* css/CSSValueKeywords.in: The 100-based font-weight values are now represented
as real numbers.
* css/FontFace.cpp: Update the string output functions for the new values.
(WebCore::rangeIsSingleValue):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):
* css/StyleBuilderConverter.h: Use CSSValue conversion functions to convert
to our new data model.
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):
* css/StyleBuilderCustom.h: font-weight is no longer a completely custom
property.
(WebCore::StyleBuilderCustom::applyInitialFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyValueFontWeight): Deleted.
* css/parser/CSSParserFastPaths.cpp: font-style is no longer a keyword property.
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/parser/CSSPropertyParser.cpp: Parse the new values in the font selection
properties.
(WebCore::consumeFontWeightKeywordValue):
(WebCore::consumeFontWeightCSS21):
(WebCore::consumeFontWeight):
(WebCore::consumeFontStyleKeywordValue):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):
* editing/EditingStyle.cpp: Migrate off old enum types.
(WebCore::fontWeightIsBold):
* editing/mac/EditorMac.mm: Ditto.
(WebCore::Editor::applyFontStyles):
* platform/graphics/FontCache.h: Unify our font selection values into
their enclosing struct, FontSelectionCapabilities. Also, clean up utility
functions.
* platform/graphics/FontCascade.cpp: Migrate off old enum types.
(WebCore::FontCascade::FontCascade):
* platform/graphics/FontCascade.h: Ditto.
(WebCore::FontCascade::italic):
(WebCore::FontCascade::weight):
* platform/graphics/FontDescription.cpp: Ditto.
(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontDescription::traitsMask): Deleted.
* platform/graphics/FontDescription.h: Migrate off old enum types.
(WebCore::FontDescription::italic):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::weight):
(WebCore::FontDescription::fontSelectionRequest):
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::setItalic):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::setIsItalic):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontCascadeDescription::initialItalic):
(WebCore::FontCascadeDescription::initialWeight):
(WebCore::FontCascadeDescription::initialStretch):
* platform/graphics/FontSelectionAlgorithm.cpp: Delete code which was only
present to convert from the old enum types to the new FontSelectionRequest
type.
(WebCore::fontSelectionRequestForTraitsMask): Deleted.
(WebCore::initialFontSelectionCapabilitiesForTraitsMask): Deleted.
(WebCore::fontSelectionCapabilitiesForTraitsMask): Deleted.
* platform/graphics/FontSelectionAlgorithm.h: Migrate to new named functions
for special values.
(WebCore::isItalic):
(WebCore::boldWeightValue):
(WebCore::normalWeightValue):
(WebCore::isFontWeightBold):
(WebCore::normalStretchValue):
(WebCore::FontSelectionRequest::FontSelectionRequest):
* platform/graphics/cocoa/FontCacheCoreText.cpp: Migrate all platforms which
compile this file to know about FontDatabase. This simplifies the interaction
between @font-face fonts and installed fonts. Also, migrate off old enum types.
(WebCore::stretchFromCoreTextTraits):
(WebCore::fontWeightFromCoreText):
(WebCore::capabilitiesForFontDescriptor):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::platformFontLookupWithFamily):
(WebCore::invalidateFontCache):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::lookupFallbackFont):
(WebCore::toTraitsMask): Deleted.
(WebCore::isFontWeightBold): Deleted.
(WebCore::toCoreTextFontWeight): Deleted.
(): Deleted.
(WebCore::FontDatabase::capabilitiesForFontDescriptor): Deleted.
(WebCore::calculateFontSelectionRequest): Deleted.
* platform/graphics/freetype/FontCacheFreeType.cpp: Migrate off old enum types.
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::fontWeightToFontconfigWeight):
(): Deleted.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp: Ditto.
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/ios/FontCacheIOS.mm: Ditto.
(WebCore::baseSystemFontDescriptor):
(WebCore::systemFontModificationAttributes):
(WebCore::systemFontDescriptor):
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::FontCache::weightOfCTFont): Deleted.
* platform/graphics/mac/FontCacheMac.mm: Ditto.
(WebCore::toNSFontWeight):
(WebCore::platformFontWithFamilySpecialCase):
* platform/graphics/win/FontCacheWin.cpp: Ditto.
(WebCore::toGDIFontWeight):
(WebCore::traitsInFamilyEnumProc):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(): Deleted.
* platform/mock/MockRealtimeVideoSource.cpp: Ditto.
(WebCore::MockRealtimeVideoSource::applySize):
* platform/text/TextFlags.h: Delete old enum types.
* platform/win/DragImageWin.cpp: Migrate off old enum types.
(WebCore::dragLabelFont):
* rendering/RenderEmbeddedObject.cpp: Ditto.
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderThemeGtk.cpp: Ditto.
(WebCore::RenderThemeGtk::updateCachedSystemFontDescription):
* rendering/RenderThemeIOS.mm: Ditto.
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
* rendering/RenderThemeMac.mm: Ditto.
(WebCore::toFontWeight):
* rendering/RenderThemeWin.cpp: Ditto.
(WebCore::fillFontDescription):

Source/WebKit/mac:

Migrate off old enum types.

* WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
* WebView/WebHTMLView.mm:
(fontNameForDescription):
* WebView/WebView.mm:
(-[WebView updateTextTouchBar]):

Source/WebKit/win:

Migrate off old enum types.

* WebKitGraphics.cpp:
(makeFont):

Source/WebKit2:

Migrate off old enum types.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

Tools:

Migrate off old enum types.

* TestWebKitAPI/Tests/WebCore/FontCache.cpp:
(TestWebKitAPI::createPlatformFont):
(TestWebKitAPI::compareFonts):
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/text/font-selection-font-face-parse-expected.txt: Added.
* fast/text/font-selection-font-face-parse.html: Added.
* fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
* fast/text/font-selection-font-loading-api-parse.html: Added.
* fast/text/font-stretch-parse-expected.txt:
* fast/text/font-stretch-parse.html:
* fast/text/font-style-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
* fast/text/font-style-parse.html: Added.
* fast/text/font-weight-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
* fast/text/font-weight-parse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRefined the ARES-6 experience
jond@apple.com [Mon, 6 Mar 2017 21:14:31 +0000 (21:14 +0000)]
Refined the ARES-6 experience
https://bugs.webkit.org/show_bug.cgi?id=169205

Reviewed by Saam Barati.

* ARES-6/about.html: Copied from PerformanceTests/ARES-6/index.html.
* ARES-6/driver.js:
(Driver.prototype.start):
(Driver.prototype._updateIterations):
(Driver):
* ARES-6/index.html:
* ARES-6/stats.js:
(Stats.prototype.toString.span.span):
* ARES-6/styles.css:
(body):
(.swoop):
(p):
(.logo):
(.start):
(.test):
(.test:nth-child(odd)):
(.overall):
(.about h2):
(.button):
(.button:hover):
(.button.return:before):
(@keyframes fade-in):
(@keyframes scale-in):
(@keyframes flicker-in):
(@keyframes wipe-in):
(.flip): Deleted.
(.testing, .about): Deleted.
(.testing): Deleted.
(.about): Deleted.
(#about:target): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform...
clopez@igalia.com [Mon, 6 Mar 2017 21:13:43 +0000 (21:13 +0000)]
[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform GTK.

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStandardCanPlayThrough.html does not work on iOS.
commit-queue@webkit.org [Mon, 6 Mar 2017 20:27:21 +0000 (20:27 +0000)]
StandardCanPlayThrough.html does not work on iOS.
https://bugs.webkit.org/show_bug.cgi?id=169207

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-03-06
Reviewed by Jer Noble.

On iOS only, add muted=true and autoplay=allowed. The loading policy on iOS requires these attributes to load enough
data to trigger canPlayThrough.

* Media/StandardCanPlayThrough.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] Disable autoplay of silent videos in low power mode
cdumez@apple.com [Mon, 6 Mar 2017 19:43:27 +0000 (19:43 +0000)]
[iOS] Disable autoplay of silent videos in low power mode
https://bugs.webkit.org/show_bug.cgi?id=168985
<rdar://problem/30739051>

Reviewed by Jer Noble.

Source/WebCore:

Disable autoplay of silent videos in low power mode on iOS to save battery.
We force the display of the start button when denying autoplay in low power
mode to allow the user to start playback.

Test: media/modern-media-controls/start-support/start-support-lowPowerMode.html

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::shouldForceControlsDisplay):
* Modules/mediacontrols/MediaControlsHost.h:
* Modules/mediacontrols/MediaControlsHost.idl:
Add shouldForceControlsDisplay property on MediaControlsHost. This property
is set to true when we want to force the display for media controls. Currently,
this only returns true for autoplay videos, while in low power mode.

* Modules/modern-media-controls/media/controls-visibility-support.js:
(ControlsVisibilitySupport.prototype._updateControls):
Take into consideration MediaControlsHost.shouldForceControlsDisplay when
initializing shouldShowControls variable.

* Modules/modern-media-controls/media/start-support.js:
(StartSupport.prototype._shouldShowStartButton):
Show the start button when MediaControlsHost.shouldForceControlsDisplay
returns true.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode restriction
to the session when low power mode is enabled so we know we need to force a
gesture to start playback of autoplay videos.

(WebCore::HTMLMediaElement::shouldForceControlsDisplay):
Add convenience function to decide if we should force display of media controls.
This returns true if the media element is a video with autoplay attribute and
its session has the MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction (i.e. we are in low power mode).

(WebCore::HTMLMediaElement::configureMediaControls):
Force requireControls variable to true if shouldForceControlsDisplay() returns
true. We do this here instead of inside HTMLMediaElement::controls() because
we do not want to change the value of media.controls exposed to JavaScript.

(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode to the list
of restrictions that get removed on user gesture.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted):
Deny playback for videos that have the RequireUserGestureForVideoDueToLowPowerMode
restriction unless there is a user gesture.

* html/MediaElementSession.h:
Add new MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction.

LayoutTests:

Add layout test coverage.

* media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt: Added.
* media/modern-media-controls/start-support/start-support-lowPowerMode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
ryanhaddad@apple.com [Mon, 6 Mar 2017 19:24:48 +0000 (19:24 +0000)]
Mark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167752

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
cdumez@apple.com [Mon, 6 Mar 2017 19:14:21 +0000 (19:14 +0000)]
LayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168927

Reviewed by Simon Fraser.

Source/WebCore:

Update internals.isTimerThrottled() to return true for any kind of throttling.
It used to only account only for specific timers that do not cause changes
inside the viewport. It now accounts for all kind of throttling, such as
timer alignment due to the page being hidden.

* page/DOMTimer.h:
* testing/Internals.cpp:
(WebCore::Internals::isTimerThrottled):

LayoutTests:

* fast/dom/nested-timer-visible-element-throttling.html:
* fast/dom/repeating-timer-element-overflow-throttling.html:
* fast/dom/repeating-timer-element-overflowing-child-own-layer-throttling.html:
* fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html:
* fast/dom/repeating-timer-visible-element-throttling.html:
* fast/dom/timer-height-change-no-throttling.html:
* fast/frames/flattening/resources/iframe-to-resize.html:
Use 10 milliseconds interval for tests relying on internals.isTimerThrottled().
Using 0 is problematic because we always internally cap to 1ms and 4ms after
reaching the max nesting level. Therefore, a 0 delay timer is always considered
to be throttled.

* fast/dom/timer-throttling-hidden-page-expected.txt:
* fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
* fast/dom/timer-throttling-hidden-page-non-nested.html:
* fast/dom/timer-throttling-hidden-page.html:
Rewrite tests to stop measuring timer intervals as this is inherently
flaky and rely on internals.isTimerThrottled() instead.

* platform/mac/TestExpectations:
Unskip test that used to be flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[css-grid] Import W3C Test Suite
rego@igalia.com [Mon, 6 Mar 2017 19:09:41 +0000 (19:09 +0000)]
[css-grid] Import W3C Test Suite
https://bugs.webkit.org/show_bug.cgi?id=169196

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the CSS Grid Layout test suite from csswg-test repository:
https://github.com/w3c/csswg-test/tree/master/css-grid-1

* csswg-test/css-grid-1/OWNERS: Added.
* csswg-test/css-grid-1/README.md: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-basic.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-repeat-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/support/testing-utils.js: Added.
(checkGridTemplateRows):
(testGridTemplateColumnsRows):
(testGridTemplateAreas):
(TestingUtils):
* csswg-test/css-grid-1/grid-definition/support/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-definition/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html: Added.
* csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018.html: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/ref-filled-green-100px-square-image.html: Added.
* csswg-test/css-grid-1/grid-items/support/100x100-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/100x50-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/200x200-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/50x100-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/50x50-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-items/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-layout-properties-expected.txt: Added.
* csswg-test/css-grid-1/grid-layout-properties.html: Added.
* csswg-test/css-grid-1/grid-model/display-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-model/display-grid.html: Added.
* csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-model/display-inline-grid.html: Added.
* csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-float-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-multicol-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-support-display-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-model/grid-support-display-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht: Added.
* csswg-test/css-grid-1/grid-model/w3c-import.log: Added.
* csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html: Added.
* csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html: Added.
* csswg-test/css-grid-1/implicit-grids/w3c-import.log: Added.
* csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html: Added.
* csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html: Added.
* csswg-test/css-grid-1/layout-algorithm/w3c-import.log: Added.
* csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-grid-span.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html: Added.
* csswg-test/css-grid-1/placement/w3c-import.log: Added.
* csswg-test/css-grid-1/test-plan/index.html: Added.
* csswg-test/css-grid-1/test-plan/w3c-import.log: Added.
* csswg-test/css-grid-1/w3c-import.log: Added.
* resources/import-expectations.json:
* resources/resource-files.json:

LayoutTests:

A few tests are not passing yet, so the TextExpectations file
has been updated accordingly linking the different bugs.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
clopez@igalia.com [Mon, 6 Mar 2017 19:01:41 +0000 (19:01 +0000)]
[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
https://bugs.webkit.org/show_bug.cgi?id=169206

Unreviewed test gardening.

* stress/spread-forward-call-varargs-stack-overflow.js: Skip on Linux platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoEnable fieldsets to be flexboxes, grids and multicolumn.
hyatt@apple.com [Mon, 6 Mar 2017 18:00:35 +0000 (18:00 +0000)]
Enable fieldsets to be flexboxes, grids and multicolumn.
https://bugs.webkit.org/show_bug.cgi?id=169082

Source/WebCore:

Reviewed by Simon Fraser .

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Remove RenderFieldset from the project.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::createElementRenderer):
* html/HTMLFieldSetElement.h:
The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

* rendering/OrderIterator.cpp:
(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):
* rendering/OrderIterator.h:
Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):
* rendering/RenderBlock.h:
This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

* rendering/RenderBlockFlow.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

* rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/RenderElement.h:
Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

* rendering/RenderFieldset.cpp: Removed.
* rendering/RenderFieldset.h: Removed.
Remove RenderFieldset files from the tree.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

* rendering/RenderObject.h:
(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.
* rendering/RenderRubyRun.h:
Rename layoutSpecialExcludedChild to layoutExcludedChildren.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.
* rendering/RenderTable.h:
Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControlMultiLine.h:
Renamed the methods for doing the excluded child layout.

* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

Reviewed by Simon Fraser.

* fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
* fast/forms/fieldset/abs-pos-child-sizing.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
* fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-flexbox.html: Added.
* fast/forms/fieldset/fieldset-grid-expected.html: Added.
* fast/forms/fieldset/fieldset-grid.html: Added.
* fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
* fast/forms/fieldset/fieldset-multicolumn.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
* fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-children.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
* fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
* fast/forms/fieldset/fieldset-writing-modes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Modern Media Controls] Tracks panel should clip and scroll content when numerous...
commit-queue@webkit.org [Mon, 6 Mar 2017 17:49:50 +0000 (17:49 +0000)]
[Modern Media Controls] Tracks panel should clip and scroll content when numerous tracks are available
https://bugs.webkit.org/show_bug.cgi?id=169201
<rdar://problem/30867979>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-06
Reviewed by Eric Carlson.

Source/WebCore:

We now position and size the tracks panel dynamically and ensure a max-height is applied
to the panel so that it allows a margin of 10px above it within the media controls. We also
apply that same max-height to a new intermediary scrollable container for the track lists,
so that it scrolls independently of the container and the background tint.

Test: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.showTracksPanel): Deleted.
* Modules/modern-media-controls/controls/macos-inline-media-controls.css:
(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline .tracks-panel): Deleted.
* Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype.showTracksPanel): Deleted.
* Modules/modern-media-controls/controls/macos-media-controls.js:
(MacOSMediaControls.prototype.showTracksPanel):
* Modules/modern-media-controls/controls/tracks-panel.css:
(.tracks-panel > .background-tint > div,):
(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section:first-of-type):
(.tracks-panel section > h3):
(.tracks-panel section > ul):
(.tracks-panel section > ul > li):
(.tracks-panel section > ul > li:focus):
(.tracks-panel section > ul > li.selected:before):
(.tracks-panel section > ul > li.animated):
(.tracks-panel > .background-tint > div): Deleted.
(.tracks-panel > section): Deleted.
(.tracks-panel > section:first-of-type): Deleted.
(.tracks-panel > section > h3): Deleted.
(.tracks-panel > section > ul): Deleted.
(.tracks-panel > section > ul > li): Deleted.
(.tracks-panel > section > ul > li:focus): Deleted.
(.tracks-panel > section > ul > li.selected:before): Deleted.
(.tracks-panel > section > ul > li.animated): Deleted.
* Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.get maxHeight):
(TracksPanel.prototype.set maxHeight):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype._childrenFromDataSource):

LayoutTests:

Rebaseline a couple of existing tests to account for the DOM structure change in
the tracks panel and the fact that positioning is now dependent on the bounds of
the tracks button.

We also add a new test that checks that the tracks panel is positioned and sized
correctly to ensure that it can be scrolled when it has too many tracks to fit.

* media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
* media/modern-media-controls/tracks-panel/tracks-panel-population.html:
* media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Added.
* media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Added.
* media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt:
* media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSC] Allow indexed module namespace object fields
utatane.tea@gmail.com [Mon, 6 Mar 2017 17:26:35 +0000 (17:26 +0000)]
[JSC] Allow indexed module namespace object fields
https://bugs.webkit.org/show_bug.cgi?id=168870

Reviewed by Saam Barati.

JSTests:

* wasm/spec-tests/names.wast.js:

Source/JavaScriptCore:

While JS modules cannot expose any indexed bindings,
Wasm modules can expose them. However, module namespace
object currently does not support indexed properties.
This patch allows module namespace objects to offer
indexed binding accesses.

* runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::getOwnPropertySlotByIndex):
* runtime/JSModuleNamespaceObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoNull pointer crash when loading module with unresolved import also as a script file
utatane.tea@gmail.com [Mon, 6 Mar 2017 16:57:11 +0000 (16:57 +0000)]
Null pointer crash when loading module with unresolved import also as a script file
https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

* stress/re-execute-error-module.js: Added.
(shouldBe):
(async):
* stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

* builtins/ModuleLoaderPrototype.js:
(globalPrivate.newRegistryEntry):
* runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, fix AppleWin build
utatane.tea@gmail.com [Mon, 6 Mar 2017 16:02:51 +0000 (16:02 +0000)]
Unreviewed, fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=164032

* Source/cmake/WebKitFeatures.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK][JSCOnly] Enable WebAssembly on Linux environment
utatane.tea@gmail.com [Mon, 6 Mar 2017 15:43:30 +0000 (15:43 +0000)]
[GTK][JSCOnly] Enable WebAssembly on Linux environment
https://bugs.webkit.org/show_bug.cgi?id=164032

Reviewed by Michael Catanzaro.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

This patch enables WebAssembly on JSCOnly and GTK ports.
Basically, almost all the WASM code is portable to Linux.
One platform-dependent part is faster memory load using SIGBUS
signal handler. This patch ports this part to Linux.

* CMakeLists.txt:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* wasm/WasmFaultSignalHandler.cpp:
(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

Tools:

* Scripts/run-jsc-stress-tests:
Enable WASM tests.

* Scripts/webkitperl/FeatureList.pm:
Enable WebAssembly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[css-grid] Stretch should grow and shrink items to fit its grid area
rego@igalia.com [Mon, 6 Mar 2017 15:30:34 +0000 (15:30 +0000)]
[css-grid] Stretch should grow and shrink items to fit its grid area
https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

* fast/css-grid-layout/grid-container-percentage-columns.html:
* fast/css-grid-layout/min-width-height-auto-and-margins.html:
* fast/css-grid-layout/min-width-height-auto.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned...
magomez@igalia.com [Mon, 6 Mar 2017 14:19:40 +0000 (14:19 +0000)]
[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCurrency digits calculation in Intl.NumberFormat should call out to ICU
commit-queue@webkit.org [Mon, 6 Mar 2017 14:06:18 +0000 (14:06 +0000)]
Currency digits calculation in Intl.NumberFormat should call out to ICU
https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

* runtime/IntlNumberFormat.cpp:
(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAllow render tree building before loading stylesheet elements
antti@apple.com [Mon, 6 Mar 2017 12:19:43 +0000 (12:19 +0000)]
Allow render tree building before loading stylesheet elements
https://bugs.webkit.org/show_bug.cgi?id=169079
Source/WebCore:

<rdar://problem/30865709>

Reviewed by Andreas Kling.

Currently we don't resolve style or construct renderers if there are any pending
stylesheet loads. This patch enables style and renderer constuction up to the
first encountered loading style element.

This is a step toward allowing incremental rendering for in-body stylesheets.

* dom/Document.cpp:
(WebCore::Document::needsStyleRecalc):

    Ensure scrolling to anchor eventually happens.

* dom/Document.h:
(WebCore::Document::isIgnoringPendingStylesheets):
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::removedFrom):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* style/StyleScope.cpp:
(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):

    Track pending sheet nodes in a map so we can test if a given node has a pending sheet.
    This is also more robust in general.

(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet):
(WebCore::Style::Scope::updateActiveStyleSheets):
* style/StyleScope.h:
(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheets):
(WebCore::Style::Scope::addPendingSheet): Deleted.
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForElement):

    Instead of global test for placeholder construction check the status of the pending sheet flag.

(WebCore::Style::hasLoadingStylesheet):
(WebCore::Style::TreeResolver::resolveComposedTree):

    Set a flag when encountering a pending top level sheet during DOM traversal.

(WebCore::Style::TreeResolver::resolve):
* style/StyleTreeResolver.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

    Ensure SVG images have layout before getting the size.

LayoutTests:

Reviewed by Andreas Kling.

Ensure that style is synchronized after adding a stylesheet dynamically by doing an additional test.
Otherwise the class/attr invalidation test may as we don't know about the new stylesheet yet.
This is functionally fine (future synchronization would invalidate the style) but messes up the test
trying to verify class/attr change invalidation specifically.

* fast/css/style-invalidation-attribute-change-descendants-expected.txt:
* fast/css/style-invalidation-attribute-change-descendants.html:
* fast/css/style-invalidation-class-change-descendants-expected.txt:
* fast/css/style-invalidation-class-change-descendants.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GStreamer] Adopt nullptr
commit-queue@webkit.org [Mon, 6 Mar 2017 10:32:57 +0000 (10:32 +0000)]
[GStreamer] Adopt nullptr
https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
* platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::setEnabled):
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Removed the unused second argument on processTableOfContentsEntry function.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):
* platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):
* platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkNew):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::setSelected):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcGetProtocols):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
akling@apple.com [Mon, 6 Mar 2017 10:02:09 +0000 (10:02 +0000)]
[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
<https://webkit.org/b/169133>
<rdar://problem/29964017>

Reviewed by Antti Koivisto.

Source/WebCore:

* page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Notify the UI process when the memory pressure status changes.
If a web process crashes while under memory pressure, log the domain of the last open page
using enhanced privacy logging.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::memoryPressureStatusChanged):
(WebKit::WebProcessProxy::isUnderMemoryPressure):
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

Add a mechanism for getting a callback when the memory pressure status changes.

* wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::measurementTimerFired):
(WTF::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::endSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::setUnderMemoryPressure):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):
* wtf/MemoryPressureHandler.h:
(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setUnderMemoryPressure): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.
carlosgc@webkit.org [Mon, 6 Mar 2017 07:38:24 +0000 (07:38 +0000)]
Unreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.

* platform/gtk/fast/css/css2-system-fonts-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove new files accidentally added in r213441
beidson@apple.com [Mon, 6 Mar 2017 05:51:57 +0000 (05:51 +0000)]
Remove new files accidentally added in r213441

Unreviewed.

* UIProcess/WebLoadingProviderProxy.cpp: Removed.
* UIProcess/WebLoadingProviderProxy.h: Removed.
* UIProcess/WebLoadingProviderProxy.messages.in: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRename CustomProtocolFoo to LegacyCustomProtocolFoo.
beidson@apple.com [Mon, 6 Mar 2017 02:53:31 +0000 (02:53 +0000)]
Rename CustomProtocolFoo to LegacyCustomProtocolFoo.
https://bugs.webkit.org/show_bug.cgi?id=169188

Reviewed by Andy Estes.

* CMakeLists.txt:
* DerivedSources.make:

* NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm.
(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol initializationRunLoop]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::LegacyCustomProtocolManager::registerProtocolClass):
(WebKit::LegacyCustomProtocolManager::registerScheme):
(WebKit::LegacyCustomProtocolManager::unregisterScheme):
(WebKit::LegacyCustomProtocolManager::supportsScheme):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.cpp.
(WebKit::generateCustomProtocolID):
(WebKit::LegacyCustomProtocolManager::supplementName):
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::initialize):
(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.h.
* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.messages.in.

* NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp.
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):

* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::create):
* NetworkProcess/NetworkSession.h:

* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::globalLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::setLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCustomProtocolManager): Deleted.
(WebKit::NetworkSessionCocoa::setCustomProtocolManager): Deleted.

* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

* UIProcess/API/APICustomProtocolManagerClient.h:
(API::LegacyCustomProtocolManagerClient::~LegacyCustomProtocolManagerClient):
(API::LegacyCustomProtocolManagerClient::startLoading):
(API::LegacyCustomProtocolManagerClient::stopLoading):
(API::LegacyCustomProtocolManagerClient::invalidate):
(API::CustomProtocolManagerClient::~CustomProtocolManagerClient): Deleted.
(API::CustomProtocolManagerClient::startLoading): Deleted.
(API::CustomProtocolManagerClient::stopLoading): Deleted.
(API::CustomProtocolManagerClient::invalidate): Deleted.

* UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h.
* UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm.
(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):

* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Removed.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: Added.
(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in.

* UIProcess/Network/NetworkProcessProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.h:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Deleted.
* UIProcess/WebProcessPool.h:

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAvoid backing store for layers with empty text nodes in a few more cases
simon.fraser@apple.com [Mon, 6 Mar 2017 02:48:20 +0000 (02:48 +0000)]
Avoid backing store for layers with empty text nodes in a few more cases
https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an &nbsp;).

Rebaselined other tests.

* compositing/backing/inline-block-no-backing-expected.txt:
* compositing/backing/inline-block-no-backing.html:
* compositing/iframes/page-cache-layer-tree-expected.txt:
* css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
* platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
* platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDrop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
cdumez@apple.com [Mon, 6 Mar 2017 01:37:53 +0000 (01:37 +0000)]
Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
https://bugs.webkit.org/show_bug.cgi?id=169066

Reviewed by Sam Weinig.

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename().

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUsing <form> in <template> causes following <form> to get swallowed
cdumez@apple.com [Mon, 6 Mar 2017 01:36:30 +0000 (01:36 +0000)]
Using <form> in <template> causes following <form> to get swallowed
https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

* fast/parser/form-after-template-expected.html: Added.
* fast/parser/form-after-template.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd support for canvas.toBlob
aestes@apple.com [Sun, 5 Mar 2017 20:31:06 +0000 (20:31 +0000)]
Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878

Reviewed by Tim Horton.

Address additional review feedback received after r213412 landed.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toBlob): Passed null to the blob callback if blob conversion
fails for any reason.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::cgImage): Removed an unnecessary local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUpdate CSSFontSelector's matching algorithm to understand ranges
mmaxfield@apple.com [Sun, 5 Mar 2017 20:14:02 +0000 (20:14 +0000)]
Update CSSFontSelector's matching algorithm to understand ranges
https://bugs.webkit.org/show_bug.cgi?id=168892

Reviewed by Jon Lee.

Source/WebCore:

This patch migrates the font selection algorithm out of FontCacheCoreText and into its own file which can be shared
among all ports. It then migrates our web font selection algorithm to use it.

This patch doesn't actually change the parsing rules; it just changes the internal machinery for how fonts get
selected. Therefore, this patch simply makes zero-length ranges from the discrete values the parser emits, and passes
those zero-length ranges to the range-based font selection routine. This means that this patch doesn't actually
change the results of the font selection algorithm.

One of the inputs to the new font selection algorithm is font-stretch, which previously was not parsed inside
@font-face blocks or the CSS Font Loading API. This patch therefore adds parsing support and modifies the existing
tests for these pieces to expect parsing to work. Because the font selection algorithm itself is shared between
installed fonts and webfonts, this patch doesn't add any additional tests for it (because it is already covered under
existing tests).

No new tests because there is no behavior change.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj: Add new file for the font selection algorithm.
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::calculateStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFace::setStretch): Fill out the previously stubbed function.
* css/CSSFontFace.h: Add the range member variable to CSSFontFaces.
* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Now that we care about font-stretch, we need to
look it up for local fonts too. This current approach of an extra FontSelectionValue hanging around with a
FontTraitsMask is very ugly and will be removed soon (https://bugs.webkit.org/show_bug.cgi?id=168889 and
https://bugs.webkit.org/show_bug.cgi?id=168890).
(WebCore::computeFontStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFaceSet::matchingFaces): Educate about font-stretch.
(WebCore::CSSFontFaceSet::fontFace): Migrate to the new font-selection algorithm.
(WebCore::fontFaceComparator): Deleted.
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Educate about font-stretch.
(WebCore::CSSFontSelector::fontRangesForFamily): Ditto.
* css/FontFace.cpp:
(WebCore::FontFace::setStretch): Ditto.
(WebCore::FontFace::stretch): Ditto.
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto.
* platform/graphics/FontCache.h: Ditto.
* platform/graphics/FontDescription.h:
* platform/graphics/FontSelectionAlgorithm.cpp: Added.
(WebCore::FontSelectionAlgorithm::filterCapability):
(WebCore::FontSelectionAlgorithm::indexOfBestCapabilities):
(WebCore::fontSelectionRequestForTraitsMask):
(WebCore::initialFontSelectionCapabilitiesForTraitsMask):
(WebCore::fontSelectionCapabilitiesForTraitsMask):
* platform/graphics/FontSelectionAlgorithm.h: Added. Taken from FontCacheCoreText.cpp.
(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionRequest::operator==):
(WebCore::FontSelectionRequest::operator!=):
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey):
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue):
(WebCore::FontSelectionRequestKey::operator==):
(WebCore::FontSelectionRequestKeyHash::hash):
(WebCore::FontSelectionRequestKeyHash::equal):
(WebCore::FontSelectionCapabilities::expand):
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilitiesWithReturn):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilities):
* platform/graphics/cocoa/FontCacheCoreText.cpp: Moved to FontSelectionAlgorithm.
(WebCore::stretchFromCoreTextTraits):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::findClosestFont):
(WebCore::calculateFontSelectionRequest):
(WebCore::platformFontLookupWithFamily):
(WebCore::FontCache::getTraitsInFamily): Deleted.
(WebCore::iterateActiveFontsWithReturn): Deleted.
(WebCore::iterateActiveFonts): Deleted.
(WebCore::findClosestStretch): Deleted.
(WebCore::filterStretch): Deleted.
(WebCore::findClosestStyle): Deleted.
(WebCore::filterStyle): Deleted.
(WebCore::findClosestWeight): Deleted.
(WebCore::filterWeight): Deleted.
(WebCore::computeTargetWeight): Deleted.
* platform/text/TextFlags.h: Moved to FontSelectionAlgorithm.
(WebCore::FontSelectionValue::FontSelectionValue): Deleted.
(WebCore::FontSelectionValue::operator float): Deleted.
(WebCore::FontSelectionValue::operator+): Deleted.
(WebCore::FontSelectionValue::operator-): Deleted.
(WebCore::FontSelectionValue::operator*): Deleted.
(WebCore::FontSelectionValue::operator/): Deleted.
(WebCore::FontSelectionValue::operator==): Deleted.
(WebCore::FontSelectionValue::operator!=): Deleted.
(WebCore::FontSelectionValue::operator<): Deleted.
(WebCore::FontSelectionValue::operator<=): Deleted.
(WebCore::FontSelectionValue::operator>): Deleted.
(WebCore::FontSelectionValue::operator>=): Deleted.
(WebCore::FontSelectionValue::rawValue): Deleted.
(WebCore::FontSelectionValue::maximumValue): Deleted.
(WebCore::FontSelectionValue::minimumValue): Deleted.
(WebCore::FontSelectionRange::isValid): Deleted.
(WebCore::FontSelectionRange::expand): Deleted.
(WebCore::FontSelectionRange::includes): Deleted.
(WebCore::FontSelectionCapabilities::expand): Deleted.

LayoutTests:

Update CSS Font Loading API test to accept font-stretch values.

* fast/text/font-face-javascript-expected.txt:
* fast/text/font-face-javascript.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMake some RenderLayer tree traversal in RenderLayerBacking more generic
simon.fraser@apple.com [Sun, 5 Mar 2017 19:14:12 +0000 (19:14 +0000)]
Make some RenderLayer tree traversal in RenderLayerBacking more generic
https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.
* rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Two file reset tests are failing in the bots since they were added in r213042
commit-queue@webkit.org [Sun, 5 Mar 2017 11:10:10 +0000 (11:10 +0000)]
[GTK] Two file reset tests are failing in the bots since they were added in r213042
https://bugs.webkit.org/show_bug.cgi?id=169126

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.

* fast/forms/file/file-input-reset-using-open-panel.html:
* fast/forms/file/file-reset-in-change-using-open-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
utatane.tea@gmail.com [Sun, 5 Mar 2017 08:37:34 +0000 (08:37 +0000)]
[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
https://bugs.webkit.org/show_bug.cgi?id=168869

Reviewed by Keith Miller.

* b3/B3Width.h:
* wasm/WasmSections.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
mitz@apple.com [Sun, 5 Mar 2017 07:41:25 +0000 (07:41 +0000)]
[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
https://bugs.webkit.org/show_bug.cgi?id=169170

Reviewed by Alex Christensen.

* Configurations/Version.xcconfig: Copied from Source/JavaScriptCore/Configurations/Version.xcconfig.
  This defines DYLIB_CURRENT_VERSION.
* Configurations/libwebrtc.xcconfig: Include Version.xcconfig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRebaseline W3C test after r213412.
cdumez@apple.com [Sun, 5 Mar 2017 01:06:10 +0000 (01:06 +0000)]
Rebaseline W3C test after r213412.

* web-platform-tests/html/dom/interfaces-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] The web process should inherit application state from UI process
eric.carlson@apple.com [Sat, 4 Mar 2017 22:39:47 +0000 (22:39 +0000)]
[iOS] The web process should inherit application state from UI process
https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Alexey Proskuryakov.

* Platform/spi/ios/CelestialSPI.h: Added.

* WebKit2.xcodeproj/project.pbxproj: Include CelestialSPI.h.

* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Add entitlement.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformInitialize): Set up PID proxying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoClarify some terminology in RenderLayerBacking
simon.fraser@apple.com [Sat, 4 Mar 2017 21:49:30 +0000 (21:49 +0000)]
Clarify some terminology in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.
* rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213429 268f45cc-cd09-0410-ab3c-d52691b4dbfc