WebKit-https.git
7 years ago[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent...
commit-queue@webkit.org [Wed, 22 Aug 2012 00:07:56 +0000 (00:07 +0000)]
[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent to main thread
https://bugs.webkit.org/show_bug.cgi?id=94600

Patch by Andrew Lo <anlo@rim.com> on 2012-08-21
Reviewed by Rob Buis.

http://trac.webkit.org/changeset/116792 implements destroying
DisplayRefreshMonitor after the number of unscheduled frames exceeds 10.

Part of that change involves dispatching to the main thread whether
the frame was scheduled or not.

Make the corresponding change for the BlackBerry port that was made for
DisplayRefreshMonitorMac.cpp.

Tests covered by http://trac.webkit.org/changeset/116792

* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium/Skia] Filters should flush the SkCanvas
commit-queue@webkit.org [Wed, 22 Aug 2012 00:06:23 +0000 (00:06 +0000)]
[Chromium/Skia] Filters should flush the SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=94602

Patch by Brian Salomon <bsalomon@google.com> on 2012-08-21
Reviewed by Stephen White.

Adds a SkCanvas::flush call to FilterBufferState::swap() to ensure the textures are updated before they are consumed by the compositor.

Covered by existing css3/filters layout tests.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion that differ from the generic results.
beidson@apple.com [Tue, 21 Aug 2012 23:56:49 +0000 (23:56 +0000)]
Rebaseline various tests for Mountain Lion that differ from the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/fast/css/pseudo-any-expected.txt: Added.
* platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
* platform/mac/fast/css/pseudo-any-expected.txt: Added.
* platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css3-text] Add repaint tests for -webkit-text-decoration-line
commit-queue@webkit.org [Tue, 21 Aug 2012 23:55:27 +0000 (23:55 +0000)]
[css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-21
Reviewed by Julien Chaffraix.

Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line".
This patch adds repaint layout tests for this property.

* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line.html: Added.
Expected results generated from Chromium Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use new method to create socket handle
commit-queue@webkit.org [Tue, 21 Aug 2012 23:53:21 +0000 (23:53 +0000)]
[BlackBerry] Use new method to create socket handle
https://bugs.webkit.org/show_bug.cgi?id=89991

Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.

Update the way to create SocketStream as the platform API has changed.

No new tests as no change of behaviour, just API change adaptation.

* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move compileScript() from V8Proxy to ScriptSourceCode
haraken@chromium.org [Tue, 21 Aug 2012 23:51:39 +0000 (23:51 +0000)]
[V8] Move compileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94561

Reviewed by Adam Barth.

To kill V8Proxy, this patch moves compileScript() from V8Proxy
to ScriptSourceCode. This patch also removes fromWebCoreString().

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptSourceCode.cpp: Added.
(WebCore):
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
* bindings/v8/V8Binding.h:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion where Mountain Lion specific results overr...
beidson@apple.com [Tue, 21 Aug 2012 23:45:23 +0000 (23:45 +0000)]
Rebaseline various tests for Mountain Lion where Mountain Lion specific results override current Lion specific results,
or in some cases match the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Renamed from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.png: Renamed from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.png.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.txt.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.png: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.png.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.txt: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.txt.
* platform/mac-lion/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png.
* platform/mac-lion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.png.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.png.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.txt.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.png.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.png: Renamed from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.png.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/012-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/013-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt.
* platform/mac-lion/media/audio-repaint-expected.png: Renamed from LayoutTests/platform/mac/media/audio-repaint-expected.png.
* platform/mac-lion/media/audio-repaint-expected.txt: Added.
* platform/mac-lion/media/video-size-intrinsic-scale-expected.txt: Renamed from LayoutTests/platform/mac/media/video-size-intrinsic-scale-expected.txt.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Renamed from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt.
* platform/mac/css2.1/t1202-counter-04-b-expected.png:
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.png:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac/fast/text/emphasis-combined-text-expected.txt:
* platform/mac/fast/text/fallback-traits-fixup-expected.png:
* platform/mac/fast/text/fallback-traits-fixup-expected.txt:
* platform/mac/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.png:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
* platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move toV8Context() from V8Proxy to V8Binding
haraken@chromium.org [Tue, 21 Aug 2012 23:38:35 +0000 (23:38 +0000)]
[V8] Move toV8Context() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94597

Reviewed by Adam Barth.

To kill V8Proxy, we can move toV8Context() from V8Proxy to V8Binding.

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Further rebaselining following r126110.
leviw@chromium.org [Tue, 21 Aug 2012 23:37:43 +0000 (23:37 +0000)]
Unreviewed gardening. Further rebaselining following r126110.

* platform/chromium-linux-x86/editing/selection: Added.
* platform/chromium-linux-x86/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-win-xp/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/11241850> Block access to xpcd in WebProcess.sb
ap@apple.com [Tue, 21 Aug 2012 23:31:05 +0000 (23:31 +0000)]
    <rdar://problem/11241850> Block access to xpcd in WebProcess.sb

        Reviewed by Sam Weinig and Jon Honeycutt.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Embeddable Web Inspector
commit-queue@webkit.org [Tue, 21 Aug 2012 23:30:25 +0000 (23:30 +0000)]
Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528

Patch by Gabriel Peal <gpeal@google.com> on 2012-08-21
Reviewed by Pavel Feldman.

Adds functionality to the inspector such that it is better suited to run embedded in another webpage. It adds the ability to prepopulate the timeline panel with an existing recording among other controls.

* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.dispatchQueryParameters):
(InspectorFrontendAPI.loadTimelineFromURL):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
* inspector/front-end/InspectorView.js:
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.loadFromURL.onDataReceived):
(WebInspector.TimelineModel.prototype.loadFromURL.parseAndImportData):
(WebInspector.TimelineModel.prototype.loadFromURL.onLoad):
(WebInspector.TimelineModel.prototype.loadFromURL):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.loadFromURL):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector.loaded):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA patchable GetById right after a watchpoint should have the appropriate nop padding
fpizlo@apple.com [Tue, 21 Aug 2012 23:30:19 +0000 (23:30 +0000)]
A patchable GetById right after a watchpoint should have the appropriate nop padding
https://bugs.webkit.org/show_bug.cgi?id=94635

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::padBeforePatch):
(AbstractMacroAssembler):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::moveWithPatch):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
(JSC::MacroAssemblerX86::storePtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::moveWithPatch):
* jit/JumpReplacementWatchpoint.cpp:
(JSC::JumpReplacementWatchpoint::fireInternal):

LayoutTests:

* fast/js/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Added.
* fast/js/dfg-patchable-get-by-id-after-watchpoint.html: Added.
* fast/js/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Added.
(foo):
(O):
(O.prototype.f):
(P1):
(P2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/8900275> Remove PubSub access from WebProcess, since it is...
ap@apple.com [Tue, 21 Aug 2012 23:29:21 +0000 (23:29 +0000)]
    <rdar://problem/8900275> Remove PubSub access from WebProcess, since it is no longer necessary

        Reviewed by Mark Rowe.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DRT produces wrong back-forward list
tkent@chromium.org [Tue, 21 Aug 2012 23:24:01 +0000 (23:24 +0000)]
[Chromium] DRT produces wrong back-forward list
https://bugs.webkit.org/show_bug.cgi?id=94575

Reviewed by Adam Barth.

DRT clears its history state before running every tests. However
HistoryController in WebCore isn't reset. So, it is possible that
'isNewNavigation' flag is false even though the navigation should be
handled as "new" for DRT.

This change might fix a problem of
fast/forms/select/select-state-restore.html (Bug 90207).

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):
Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
Without this change, a navigation entry for this loading won't be recorded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add support for getUserMedia
commit-queue@webkit.org [Tue, 21 Aug 2012 23:22:09 +0000 (23:22 +0000)]
[BlackBerry] Add support for getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=94591

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-21
Reviewed by George Staikos.

Implement getUserMedia feature using the platform API.

Source/WebCore:

Tests in fast/mediastream cover this.

PR #153571

Reviewed internally by George Staikos.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamSource):
(WebCore):
(WebCore::toWebMediaStreamDescriptor):
(WebCore::MediaPlayerPrivate::lookupMediaStream):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

Source/WebKit/blackberry:

PR #153571

Reviewed internally by George Staikos.

* WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore):
(WebCore::userMediaRequestsMap):
(WebCore::toMediaStreamSource):
(WebCore::toMediaStreamDescriptor):
(WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
(WebCore::WebUserMediaRequestClientImpl::requestFailed):
(WebCore::UserMediaClientImpl::UserMediaClientImpl):
(WebCore::UserMediaClientImpl::~UserMediaClientImpl):
(WebCore::UserMediaClientImpl::requestUserMedia):
(WebCore::UserMediaClientImpl::cancelUserMediaRequest):
(WebCore::UserMediaClientImpl::webUserMedia):
* WebCoreSupport/UserMediaClientImpl.h:
(BlackBerry):
(Platform):
(UserMediaClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor
pfeldman@chromium.org [Tue, 21 Aug 2012 23:19:11 +0000 (23:19 +0000)]
Web Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=94592

Reviewed by Yury Semikhatsky.

It seems to be not necessary.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.set expanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
commit-queue@webkit.org [Tue, 21 Aug 2012 23:16:52 +0000 (23:16 +0000)]
[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=94586

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-21
Reviewed by Kentaro Hara.

Source/WebKit/blackberry:

Fix build error in the DeviceOrientationClientBlackBerry.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
(DeviceOrientationClientBlackBerry::lastOrientation):

Source/WebKit/efl:

Fix build error in the DeviceOrientationClientEfl.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientEfl.cpp:
(WebCore::DeviceOrientationClientEfl::lastOrientation):

Source/WebKit/gtk:

Fix build error in the DeviceOrientationClientGtk.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.

* WebCoreSupport/DeviceOrientationClientGtk.cpp:
(WebKit::DeviceOrientationClientGtk::lastOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF Threading leaks kernel objects on platforms that use pthreads
mhahnenberg@apple.com [Tue, 21 Aug 2012 23:16:24 +0000 (23:16 +0000)]
WTF Threading leaks kernel objects on platforms that use pthreads
https://bugs.webkit.org/show_bug.cgi?id=94636

Reviewed by Geoffrey Garen.

Source/WTF:

Creating lots of Web workers on Mac platforms leaks lots of Mach ports. Eventually, the
process can exhaust its allocation of Mach ports from the kernel, which can then cause
all sorts of badness, including the inability to allocate new virtual memory from the
kernel. ThreadingPthreads.cpp and ThreadIdentifierDataPthreads.cpp need to be refactored
so that we do not leak these kernel resources. I would assume that we also leak kernel
resources on other pthreads platforms as well.

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF):
(WTF::ThreadIdentifierData::~ThreadIdentifierData): Now calls the event threadDidExit, which
handles all relevant tear-down of the thread metadata in the thread map.
* wtf/ThreadingPthreads.cpp: Added a new class called PthreadState that encapsulates the
state of a thread and the possible transitions between those states.
(PthreadState):
(WTF::PthreadState::PthreadState):
(WTF::PthreadState::joinableState): Returns the current state of the pthread.
(WTF::PthreadState::pthreadHandle): Returns the pthread_t for this particular thread. This needs to
remain valid even after the thread has exited because somebody could come along at any time in the
future and call join on the thread.
(WTF::PthreadState::didBecomeDetached): Signals that the thread was detached.
(WTF::PthreadState::didExit): Signals that the thread's exit destructor (~ThreadIdentifierData) has run.
(WTF::PthreadState::didJoin): Signals that the thread has been joined on successfully.
(WTF::PthreadState::hasExited): Returns whether or not the thread's exit destructor has run.
(WTF):
(WTF::identifierByPthreadHandle): Changed to also check hasExited() on the threads it finds in the map. We
should only have one valid pthread_t in the map, but there are other pthread_t's that need to remain in the
thread map for when somebody joins on that thread id later.
(WTF::establishIdentifierForPthreadHandle): Changed to put the allocate the new PthreadState data structure and
put it in the map.
(WTF::pthreadHandleForIdentifierWithLockAlreadyHeld):
(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion): We now do the relevant cleanup after the specified thread has been
successfully joined on depending on if the joined thread has already exited.
(WTF::detachThread): Performs relevant cleanup if the thread has already exited. Otherwise signals to the
PthreadState that the thread has been detached.
(WTF::threadDidExit): Function called by ~ThreadIdentifierData to indicate that the thread has exited.
Only cleans up after itself if the thread isn't Joinable (i.e. Joined or Detached).

LayoutTests:

Added a test that creates a bunch of workers that immediately return. This should stress
the new WTF threading code on platforms that use pthreads, so any major regressions in correctness
will probably cause this test to fail since it creates both joinable and detached threads.

* fast/js/create-lots-of-workers-expected.txt: Added.
* fast/js/create-lots-of-workers.html: Added.
* fast/js/resources/empty-worker.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Some public API functions don't have their symbols exported
commit-queue@webkit.org [Tue, 21 Aug 2012 23:14:23 +0000 (23:14 +0000)]
[EFL] Some public API functions don't have their symbols exported
https://bugs.webkit.org/show_bug.cgi?id=94589

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.

Added missing export symbol macro to these public API functions.

* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCodeGeneratorInspector.py: Generate guards for type validators
commit-queue@webkit.org [Tue, 21 Aug 2012 23:09:56 +0000 (23:09 +0000)]
CodeGeneratorInspector.py: Generate guards for type validators
https://bugs.webkit.org/show_bug.cgi?id=94511

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Yury Semikhatsky.

Fix regression when building debug and one of the generated types is
disabled by a compile flag. We should generate guards for these type
validators the same way as we are doing on the include headers.

* inspector/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT triggered in SVGTRefTargetEventListener::handleEvent()
fmalita@chromium.org [Tue, 21 Aug 2012 23:07:54 +0000 (23:07 +0000)]
ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=94487

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The current way of tracking tref target elements by id can leave stale event listeners
under certain circumstances. This patch switches to storing a target RefPtr instead
to avoid an id lookup which may not return the original/attached element.

Test: svg/custom/tref-stale-listener-crash.html

* svg/SVGTRefElement.cpp:
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached): use m_target instead of an explicit bool.
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach): save a target RefPtr instead of an id.
(WebCore::SVGTRefTargetEventListener::detach): detach the target element directly without
going through a lookup.
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::updateReferencedText): use an explicit target pointer instead of
the id-based lookup.
(WebCore::SVGTRefElement::buildPendingResource):
* svg/SVGTRefElement.h:
(SVGTRefElement):

LayoutTests:

* svg/custom/tref-stale-listener-crash-expected.txt: Added.
* svg/custom/tref-stale-listener-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Find-in-page coordinates should use containingBlock
leandrogracia@chromium.org [Tue, 21 Aug 2012 23:06:06 +0000 (23:06 +0000)]
[Chromium] Find-in-page coordinates should use containingBlock
https://bugs.webkit.org/show_bug.cgi?id=94343

Reviewed by Julien Chaffraix.

The current implementation uses the container method to climb the render tree.
However, it would be more correct and convenient to use containingBlock instead.
Also, this patch introduces new tests for find-in-page coordinates in tables.

* src/FindInPageCoordinates.cpp:
(WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now.
(WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications.
* tests/WebFrameTest.cpp: add new tests for tables.
* tests/data/find_in_page.html:
* tests/data/find_in_page_frame.html: new tests for tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing fast/canvas tests for Mountain Lion
beidson@apple.com [Tue, 21 Aug 2012 23:04:19 +0000 (23:04 +0000)]
Rebaseline failing fast/canvas tests for Mountain Lion

Unreviewed (Bot gardening).

* platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
* platform/mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add software bitmap resources to CCResourceProvider
commit-queue@webkit.org [Tue, 21 Aug 2012 23:00:12 +0000 (23:00 +0000)]
[chromium] Add software bitmap resources to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93677

Patch by Alexandre Elias <aelias@google.com> on 2012-08-21
Reviewed by Adrienne Walker.

This adds the ability to CCResourceProvider to use software bitmaps.
They are allocated as plain-old-memory, and exposed as Skia objects.

We want the ResourceProvider to be able to handle different resource
types at the same time.  In practice, a default resource type is
desired for most uses within a single compositor instance, which is
specified by the default resource type.  Default resource types are
expected to be mostly 1-to-1 with CCRenderer types.

New tests added by parametrizing existing CCResourceProvider tests.

Source/WebCore:

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
* platform/graphics/chromium/LayerRendererChromium.h:
(DrawingFrame):
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore):
(WebCore::CCResourceProvider::createGLTexture):
(WebCore::CCResourceProvider::createBitmap):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL):
(WebCore::CCResourceProvider::populateSkBitmapWithResource):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::~ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::CCResourceProvider):
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(WebCore::CCResourceProvider::setCreationPolicy):
(WebCore::CCResourceProvider::creationPolicy):
(CCResourceProvider):
(ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::textureId):
(ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::textureId):
(ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::skBitmap):
(ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::skCanvas):
(Resource):

Source/WebKit/chromium:

* tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::getResourcePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTrack -webkit property usage.
commit-queue@webkit.org [Tue, 21 Aug 2012 22:51:54 +0000 (22:51 +0000)]
Track -webkit property usage.
https://bugs.webkit.org/show_bug.cgi?id=93420

Patch by Tab Atkins <tabatkins@google.com> on 2012-08-21
Reviewed by Ojan Vafai.

First draft of an attempt to track all usage of -webkit prefixed properties across the web.
This attempt is dumb, but should provide useful data as a first-pass.
I plan to optimize this for better data collection in the future.

No tests added, as this is untestable currently.
It should have zero effect besides histogramming.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndD...
commit-queue@webkit.org [Tue, 21 Aug 2012 22:49:58 +0000 (22:49 +0000)]
[chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete.
https://bugs.webkit.org/show_bug.cgi?id=93724

Patch by Oli Lan <olilan@chromium.org> on 2012-08-21
Reviewed by Ryosuke Niwa.

This adds two new methods to WebViewImpl.

1) setCompositionFromExistingText creates a new composition from the existing text
in the currently focused input field. The new composition is between the two offsets
provided, relative to the rootEditableElement. The current selection is left unchanged.

2) extendSelectionAndDelete extends the selection by the specified number of characters
before and after, and then deletes the selection. If the selection is just a caret, the effect
is to delete the specified number of characters before and after the current editing point.

These methods will be used e.g. by the Android port to implement IME functionality.

New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText
test the two new methods.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setComposingRegion):
(WebKit):
(WebKit::extendSelectionAndDelete):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove old update/openCursor glue
commit-queue@webkit.org [Tue, 21 Aug 2012 22:41:32 +0000 (22:41 +0000)]
IndexedDB: remove old update/openCursor glue
https://bugs.webkit.org/show_bug.cgi?id=94378

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-21
Reviewed by Tony Chang.

Source/WebCore:

Remove old openCursor and update methods after landing
https://bugs.webkit.org/show_bug.cgi?id=91125 and removing
Chromium-side glue.

No new tests: this code is dead.

* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

Remove Chromium/WebKit API for old methods that have now been
removed from chromium proper.

* public/WebIDBObjectStore.h:
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the...
jamesr@google.com [Tue, 21 Aug 2012 22:35:41 +0000 (22:35 +0000)]
[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
https://bugs.webkit.org/show_bug.cgi?id=94631

Reviewed by Adrienne Walker.

Source/WebCore:

In the depths of time when dinosaurs roamed the earth, LayerChromium and CCLayerTreeHost were both reference
counted and there was a cycle between the root LayerChromium and CCLayerTreeHost. This required all users of
CCLayerTreeHost to manually break the cycle by calling setRootLayer(0) before dropping their reference to the
host. Nowadays, CCLayerTreeHost has a single owner and LayerChromiums only have a weak pointer to their host
so we should just do this cleanup ourselves instead of imposing it on callers.

Unit test added to LayerChromiumTest.cpp

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):

Source/WebKit/chromium:

Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable CSS Text Decoration by default
commit-queue@webkit.org [Tue, 21 Aug 2012 22:35:21 +0000 (22:35 +0000)]
[EFL] Enable CSS Text Decoration by default
https://bugs.webkit.org/show_bug.cgi?id=94483

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.

.:

By enabling this feature by default, it will get tested by the bots
and we can make sure no regressions will happen.

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove test that will now pass from the skip list.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed
commit-queue@webkit.org [Tue, 21 Aug 2012 22:32:32 +0000 (22:32 +0000)]
Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed
https://bugs.webkit.org/show_bug.cgi?id=92993

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-21
Reviewed by Kenneth Russell.

Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer
is constructed and destructed so that V8's garbage collection
heuristics can account for the memory held by these objects.

.:

* ManualTests/typed-array-memory.html: Added.

Source/WebCore:

* WebCore.gypi:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBufferDeallocationObserver::instance):
(WebCore):
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferCustom.h: Added.
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

Source/WTF:

* wtf/ArrayBuffer.h:
(WTF):
(ArrayBufferDeallocationObserver):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBuffer::setDeallocationObserver):
(WTF::ArrayBufferContents::~ArrayBufferContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Completion events of InspectorFileSystemAgent should be fired asynchro...
commit-queue@webkit.org [Tue, 21 Aug 2012 22:29:29 +0000 (22:29 +0000)]
Web Inspector: Completion events of InspectorFileSystemAgent should be fired asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93933

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Yury Semikhatsky.

InspectorFileSystemAgent fires completion event too early in error case. It should wait
until JS code is ready.

Source/WebCore:

Test: http/tests/inspector/filesystem/request-directory-content.html
      http/tests/inspector/filesystem/request-file-content.html
      http/tests/inspector/filesystem/request-metadata.html

* inspector/InspectorFileSystemAgent.cpp:
(WebCore): Add ReportErrorTask class

LayoutTests:

* http/tests/inspector/filesystem/request-directory-content-expected.txt:
* http/tests/inspector/filesystem/request-directory-content.html: Add more error case test.
* http/tests/inspector/filesystem/request-file-content-expected.txt:
* http/tests/inspector/filesystem/request-file-content.html: Add more error case test.
* http/tests/inspector/filesystem/request-filesystem-root-expected.txt:
* http/tests/inspector/filesystem/request-metadata-expected.txt:
* http/tests/inspector/filesystem/request-metadata.html: Add more error case test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlocking a resource via Content Security Policy should trigger an Error event.
commit-queue@webkit.org [Tue, 21 Aug 2012 22:23:00 +0000 (22:23 +0000)]
Blocking a resource via Content Security Policy should trigger an Error event.
https://bugs.webkit.org/show_bug.cgi?id=89440

Patch by Mike West <mkwst@chromium.org> on 2012-08-21
Reviewed by Jochen Eisinger.

Source/WebCore:

If a CSP directive is violated, CachedResourceLoader will trigger a
console error, and return a null image. In that case, we now dispatch
an error on the relevant element.

Adjusted http/tests/security/contentSecurityPolicy/image-blocked.html
and http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
to test the new behavior.

This has the side-effect of also generating errors for images blocked by
Chromium's content settings. Adjusted
platform/chromium/permissionclient/image-permissions.html to agree with
the new behavior.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):

LayoutTests:

* http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/image-blocked.html:
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt:
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html:
    Adjusting existing tests to use the error event, as opposed to
    hacking around the fact that it wasn't triggered.
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
    Error events are now also generated for images blocked by Chromium's
    content settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Split out crumb list part of styles from elementsPanel.css
commit-queue@webkit.org [Tue, 21 Aug 2012 22:05:33 +0000 (22:05 +0000)]
Web Inspector: Split out crumb list part of styles from elementsPanel.css
https://bugs.webkit.org/show_bug.cgi?id=94301

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Pavel Feldman.

As a preparation to use BreadcrumbList on FileSystem, introduce breadcrumbList.css and
move crumb-related style entries into it from elementsPanel.css.

No new tests. This change does not make functional change.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/breadcrumbList.css: Added.
(.crumbs):
(.crumbs .crumb):
(.crumbs .crumb.collapsed > *):
(.crumbs .crumb.collapsed::before):
(.crumbs .crumb.compact .extra):
(.crumbs .crumb.dimmed):
(.crumbs .crumb.start):
(.crumbs .crumb.end):
(.crumbs .crumb.selected):
(.crumbs .crumb.selected:hover):
(.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
(.crumbs .crumb:hover):
(.crumbs .crumb.dimmed:hover):
(.crumbs .crumb.end:hover):
* inspector/front-end/elementsPanel.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocanvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
commit-queue@webkit.org [Tue, 21 Aug 2012 22:02:13 +0000 (22:02 +0000)]
canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
https://bugs.webkit.org/show_bug.cgi?id=50797

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Andreas Kling.

Source/WebCore:

Add a check in fast-path parseAlphaValue() to return early
if the CSS <alphavalue> ended with an invalid digit.

Test: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html

* css/CSSParser.cpp:
(WebCore::parseAlphaValue):

LayoutTests:

Unskipped tests that are now passing after this fix and removed
wrong expectations.

* platform/chromium/TestExpectations:
* platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore CString data in the CStringBuffer to avoid the double indirection
benjamin@webkit.org [Tue, 21 Aug 2012 21:58:45 +0000 (21:58 +0000)]
Store CString data in the CStringBuffer to avoid the double indirection
https://bugs.webkit.org/show_bug.cgi?id=94562

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Darin Adler.

Source/Platform:

* chromium/src/WebCString.cpp:
(WebKit::WebCString::length): Update the length() computation following the changes
in CStringBuffer.

Source/WebCore:

* bindings/cpp/WebDOMCString.cpp:
(WebDOMCString::length): With the patch, CStringBuffer hold the real string length instead of the
size of the buffer including the terminating zero. WebDOMCString is updated accordingly.

Source/WTF:

Previously, any non-trivial CString would require two allocations:
1) CStringBuffer (ref-counted container for CString's data).
2) VectorBuffer's m_buffer (the actual char data).

This patches changes CStringBuffer to hold the data previously owned by
WTF::Vector and WTF::VectorBuffer. This makes CString more efficient
both in CPU time and memory use.

* wtf/text/CString.cpp:
(WTF::CStringBuffer::createUninitialized): This new method allocate the memory
for CStringBuffer and its data. We simply allocate more memory after CStringBuffer
to hold the data.

The extra memory needed to store the terminating zero is now handled by design.
(WTF::CString::CString): Move the test for "str" one level up the stack from CString::init().
This avoid double checking the pointer when using the other constructor.
(WTF::CString::init):
(WTF::CString::newUninitialized):
(WTF::CString::copyBufferIfNeeded):
* wtf/text/CString.h:
(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(CStringBuffer):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::length):

Tools:

Add test coverage for WTF::CString.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/CString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Rebaselines following r126110.
leviw@chromium.org [Tue, 21 Aug 2012 21:52:57 +0000 (21:52 +0000)]
Unreviewed gardening. Rebaselines following r126110.

* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-linux/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/4895428-3-expected.png:
* platform/chromium-mac/editing/selection/4975120-expected.png:
* platform/chromium-mac/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac/fast/css/input-search-padding-expected.png:
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/chromium-mac/fast/css/line-height-expected.png:
* platform/chromium-mac/fast/css/square-button-appearance-expected.png:
* platform/chromium-mac/fast/css/text-overflow-input-expected.png:
* platform/chromium-mac/fast/dom/isindex-001-expected.png:
* platform/chromium-mac/fast/dom/isindex-002-expected.png:
* platform/chromium-mac/fast/events/autoscroll-expected.png:
* platform/chromium-mac/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac/fast/forms/basic-buttons-expected.png:
* platform/chromium-mac/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/button-sizes-expected.png:
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac/fast/forms/encoding-test-expected.png:
* platform/chromium-mac/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac/fast/forms/input-align-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac/fast/forms/input-baseline-expected.png:
* platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac/fast/forms/input-spaces-expected.png:
* platform/chromium-mac/fast/forms/input-table-expected.png:
* platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac/fast/forms/input-value-expected.png:
* platform/chromium-mac/fast/forms/input-width-expected.png:
* platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac/fast/forms/text-style-color-expected.png:
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac/fast/html/details-open2-expected.png:
* platform/chromium-mac/fast/html/details-open4-expected.png:
* platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
* platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac/fast/table/003-expected.png:
* platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
* platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-mac/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-win/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: ::first-letter pseudo-element is incorrectly sized
dpranke@chromium.org [Tue, 21 Aug 2012 21:39:43 +0000 (21:39 +0000)]
Text Autosizing: ::first-letter pseudo-element is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=94540

Reviewed by Ojan Vafai.

Revert the changes in bugs 94517 and 94396 so that we are
actually looking for stderr output from ImageDiff and doing
image compares on ref tests on the wk2 ports again.

Also, do an actual diff_image() call if the hash checks fail on
reftests, and only fail the test if we get real diffs (or don't,
for mismatches).

Lastly, clean up the log messages to be more helpful.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago_compare_image() swaps actual and expected images by mistake
dpranke@chromium.org [Tue, 21 Aug 2012 21:36:15 +0000 (21:36 +0000)]
_compare_image() swaps actual and expected images by mistake
https://bugs.webkit.org/show_bug.cgi?id=94567

Reviewed by Ojan Vafai.

Re-work the code so that we consistently pass (expected, actual)
across all of the compare/diff routines.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_compare_test):
(SingleTestRunner._compare_output):
(SingleTestRunner._compare_text):
(SingleTestRunner._compare_audio):
(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing fast/writing-mode tests for Mountain Lion
beidson@apple.com [Tue, 21 Aug 2012 21:30:42 +0000 (21:30 +0000)]
Rebaseline failing fast/writing-mode tests for Mountain Lion

Unreviewed (Bot gardening).

* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png.
* platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt.
* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.png.
* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt.
* platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.png.
* platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt.
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png:
* platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.png:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate CSS color output string on 8 bits
benjamin@webkit.org [Tue, 21 Aug 2012 21:23:12 +0000 (21:23 +0000)]
Create CSS color output string on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=94625

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Andreas Kling.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
Previously, the output string for a CSS color was computed on 16 bits.
This was mainly forced by the use of String::number().

Since the double to string conversion is done on 8bits anyway, I changed
the code to use dtoa's numberToFixedPrecisionString directly instead of
String::number().
All the other parts were already on 8bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Move the commit-queue to building release only. Previously,
abarth@webkit.org [Tue, 21 Aug 2012 21:21:39 +0000 (21:21 +0000)]
Unreviewed. Move the commit-queue to building release only. Previously,
we built debug too, but for some reason the debug build doesn't work on
the bots. We can re-enable debug builds once we fix the underlying
problem.

* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.build_style):
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTestExpectationsParser doesn't warn about test files that don't exist.
rniwa@webkit.org [Tue, 21 Aug 2012 21:03:26 +0000 (21:03 +0000)]
TestExpectationsParser doesn't warn about test files that don't exist.
https://bugs.webkit.org/show_bug.cgi?id=94632

Reviewed by Dirk Pranke.

Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_line):
(TestExpectationParser._check_test_exists):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline failing editing/selection tests for mountain lion
beidson@apple.com [Tue, 21 Aug 2012 20:35:28 +0000 (20:35 +0000)]
Rebaseline failing editing/selection tests for mountain lion
https://bugs.webkit.org/show_bug.cgi?id=94629

Reviewed by Simon Fraser.

Move current Mac-specific results to platform/mac-lion and add Mountain Lion results to platform/mac

* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png.
* platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Using a native window for the WebView breaks GtkOverlay
mrobinson@webkit.org [Tue, 21 Aug 2012 20:29:16 +0000 (20:29 +0000)]
[GTK] Using a native window for the WebView breaks GtkOverlay
https://bugs.webkit.org/show_bug.cgi?id=90085

Reviewed by Alejandro G. Castro.

.:

* configure.ac: Parse xcomposite pkg-config file during configuration.

Source/WebCore:

No new tests. This will be covered by pixel test for accelerated
compositing when they are activated.

* GNUmakefile.am: Add XComposite libraries to the linker list.
* GNUmakefile.list.am: Add RedirectedXCompositeWindow files to the source list.
Make a new section for GLX specific files.
* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::sharedDisplay): Expose sharedDisplay as a static method
so that it can be called by other X11 specific code.
* platform/graphics/glx/GLContextGLX.h: Ditto.
* platform/gtk/RedirectedXCompositeWindow.cpp: Added. An implementation of a GL surface
that renders to an X-window which redirects to a pixmap.
* platform/gtk/RedirectedXCompositeWindow.h: Added.

Source/WebKit/gtk:

Rewrite AcceleratedCompositingContext for TextureMapperGL to be more similar to
the WebKit2 LayerTreeHost and switch from rendering directly to the widget window
to a window redirected to a pixmap via XComposite. The AcceleratedCompositingContext
now handles painting the non-composited content itself and no longer relies on the
ChromeClient backing store.

This fixes issues with using GtkOverlay WebKitWebView as well as making it possible
to run pixel tests with accelerated compositing turned on.

* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Rename some methods to make them more similar to LayerTreeHost. Now we wait to render
the OpenGL context to the window until the widget's draw signal. Escape out of all
methods early if accelerated compositing is disabled.
* WebCoreSupport/ChromeClientGtk.cpp: Always check if accelerated compositing is on
before calling into AcceleratedCompositingContext methods. When AC is on, never paint
the backing store, deferring immediately to the AcceleratedCompositingContext. When
AC is turned on the backing store now shrinks to a small size to save memory.
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): ChromeClient is now responsible for talking to the
AcceleratedCompositingContext directly.
(webkit_web_view_size_allocate): Exit early if the allocation is not a resize. This
makes some deeper logic a bit simpler and avoids accidentally doing too much work for
widget movement.
(webkit_web_view_realize): We no longer need a native window.

Source/WebKit2:

Add XComposite libraries to the linker list for WebKit2.

* GNUmakefile.am: Add XComposite

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] about:memory and about:memory-live should show numbers for the chrome...
zhajiang@rim.com [Tue, 21 Aug 2012 19:56:21 +0000 (19:56 +0000)]
[BlackBerry] about:memory and about:memory-live should show numbers for the chrome process
https://bugs.webkit.org/show_bug.cgi?id=94531

Reviewed by Rob Buis.
Patch by Jacky Jiang  <zhajiang@rim.com>

PR: 190504
Add total committed memory of chrome process into about:memory and add
its peak into about:memory-live.

Internally reviewed by Yong Li and George Staikos.

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::clear):
(MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfCurrentProcess):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfChromeProcess):
(BlackBerry::WebKit::MemoryTracker::MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] context-creation-and-destruction layout tests are slow
kbr@google.com [Tue, 21 Aug 2012 19:44:05 +0000 (19:44 +0000)]
[Chromium] context-creation-and-destruction layout tests are slow
https://bugs.webkit.org/show_bug.cgi?id=92287

Unreviewed; marked test slow on Linux as well.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/multicol/shrink-to-column-height-for-pagination.html fails on Mac WK2 bots
beidson@apple.com [Tue, 21 Aug 2012 19:17:02 +0000 (19:17 +0000)]
fast/multicol/shrink-to-column-height-for-pagination.html fails on Mac WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=94624

Unreviewed (Bot gardening).

* platform/mac-wk2/Skipped: Skip until we fix it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Layout tests gardening
rakuco@webkit.org [Tue, 21 Aug 2012 19:12:51 +0000 (19:12 +0000)]
[EFL] Layout tests gardening
https://bugs.webkit.org/show_bug.cgi?id=94594

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Make column rules paint properly.
hyatt@apple.com [Tue, 21 Aug 2012 18:15:39 +0000 (18:15 +0000)]
[New Multicolumn] Make column rules paint properly.
https://bugs.webkit.org/show_bug.cgi?id=94616

Reviewed by Simon Fraser.

Make the new multi-column code paint column rules and also prepare it for painting
the actual column contents.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
Remove the addRegionToThread call, since this is now done automatically in RenderRegion::insertedIntoTree.

* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::flowThread):
Make public so that RenderMultiColumnSet can access it.

(RenderMultiColumnBlock):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Add a column gap fetch method. It's identical to the one on RenderBlock (which will eventually go away
when we kill the old multi-column code).

(WebCore::RenderMultiColumnSet::columnRectAt):
Also identical to the RenderBlock version of this method. Gets the rect for the nth column.

(WebCore::RenderMultiColumnSet::paintReplaced):
Subclass paintReplaced in order to do column rules and contents painting.

(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::paintColumnContents):
Similar to the methods on RenderBlock. The former paints the rules and the latter paints the contents of
the flow thread into the columns.

* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Add the declarations of all the new methods.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::installFlowThread):
Added a new virtual function for installing flow threads when they didn't exist at construction time.
This only applies to actual CSS Regions, so the subclass of the method in RenderRegionSet just does
nothing.

(WebCore::RenderRegion::attachRegion):
Get the named flow thread code out of attachRegion, since it broke multi-column. Moved it into a
virtual function, installFlowThread, that is only used by actual CSS regions. Eventually we may
want a RenderRegion subclass that represents a region for a named flow thread only, but for now
let the code sit in installFlowThread in the base class.

* rendering/RenderRegion.h:
(RenderRegion):
Add installFlowThread declaration.

* rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::installFlowThread):
installFlowThread for region sets just does nothing, since we don't use named flow threads.

* rendering/RenderRegionSet.h:
(RenderRegionSet):
Add the override of installFlowThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove free functions in test_expectations to TestExpectations class
rniwa@webkit.org [Tue, 21 Aug 2012 18:10:22 +0000 (18:10 +0000)]
Move free functions in test_expectations to TestExpectations class
https://bugs.webkit.org/show_bug.cgi?id=94557

Reviewed by Dirk Pranke.

Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
to allow further refactoring.

* Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult.did_run_as_expected):
(JSONTestResult._tokenize):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.result_was_expected):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.matches_an_expected_result):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MockBugManager.create_bug):
(test_result_was_expected):
(test_remove_pixel_failures):
(test_suffixes_for_expectations):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._tests_to_rebaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Build fix for !ENABLE(DRAG_SUPPORT).
paroga@webkit.org [Tue, 21 Aug 2012 18:00:50 +0000 (18:00 +0000)]
[WIN] Build fix for !ENABLE(DRAG_SUPPORT).

* page/win/EventHandlerWin.cpp:
(WebCore):
(WebCore::EventHandler::passMouseMoveEventToSubframe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126170.
jamesr@google.com [Tue, 21 Aug 2012 17:52:00 +0000 (17:52 +0000)]
Unreviewed, rolling out r126170.
http://trac.webkit.org/changeset/126170
https://bugs.webkit.org/show_bug.cgi?id=94614

I spoke too soon

Source/Platform:

* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
* chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
* chromium/public/WebIOSurfaceLayer.h:
(WebCore):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* chromium/public/WebImageLayer.h:
(WebCore):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebScrollableLayer.h: Copied from Source/Platform/chromium/public/WebScrollbarLayer.h.
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
* chromium/public/WebScrollbarLayer.h:
(WebCore):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebScrollbarLayer):
* chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
* chromium/public/WebVideoLayer.h:
(WebCore):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):

Source/WebCore:

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

* WebKit.gypi:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
* src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
(WebKit):
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::clearClient):
(WebKit::WebContentLayer::setDoubleSided):
(WebKit::WebContentLayer::setContentsScale):
(WebKit::WebContentLayer::setUseLCDText):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
(WebKit):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* src/WebIOSurfaceLayerImpl.h: Removed.
* src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
* src/WebLayer.cpp: Added.
(WebKit):
(WebKit::WebLayer::create):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::invalidateRect):
(WebKit::WebLayer::invalidate):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::setChildren):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::setDrawsContent):
(WebKit::WebLayer::drawsContent):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setUseParentBackfaceVisibility):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::setAnimationDelegate):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::hasActiveAnimation):
(WebKit::WebLayer::transferAnimationsTo):
(WebKit::WebLayer::setForceRenderSurface):
(WebKit::WebLayer::clearRenderSurface):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
* src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
* src/WebScrollbarLayerImpl.h: Removed.
* src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h.
(WebKit):
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate run-bindings-tests results after http://trac.webkit.org/changeset/126165
abarth@webkit.org [Tue, 21 Aug 2012 17:47:23 +0000 (17:47 +0000)]
Update run-bindings-tests results after trac.webkit.org/changeset/126165

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd parsing logic for allow-pointer-lock to iframe sandbox attribute.
scheib@chromium.org [Tue, 21 Aug 2012 17:42:50 +0000 (17:42 +0000)]
Add parsing logic for allow-pointer-lock to iframe sandbox attribute.
https://bugs.webkit.org/show_bug.cgi?id=94513

Reviewed by Adam Barth.

Pointer lock was previously blocked from all sandboxed iframes.
Parsing the sandbox="allow-pointer-lock" attribute allows pages
to control the feature and enable it in sandboxed iframes.

Source/WebCore:

Tests: http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html
       http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html
       http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):

LayoutTests:

* http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
* http/tests/pointer-lock/iframe-sandboxed.html:
* http/tests/resources/pointer-lock/iframe-allows-inner-iframe.html: Added.
* http/tests/resources/pointer-lock/iframe-common.js:
(window.onmessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126169.
jamesr@google.com [Tue, 21 Aug 2012 17:39:24 +0000 (17:39 +0000)]
Unreviewed, rolling out r126169.
http://trac.webkit.org/changeset/126169
https://bugs.webkit.org/show_bug.cgi?id=94614

Crashes already fixed downstream

Source/Platform:

* chromium/public/WebContentLayer.h:
(WebContentLayer):
* chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
* chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
* chromium/public/WebImageLayer.h:
(WebImageLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
* chromium/public/WebScrollableLayer.h: Removed.
* chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
* chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
* chromium/public/WebVideoLayer.h:
(WebVideoLayer):

Source/WebCore:

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

* WebKit.gypi:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
* src/WebContentLayer.cpp: Removed.
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
* src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
(WebKit):
(WebExternalTextureLayerImpl):
* src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
* src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
* src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
* src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
* src/WebLayer.cpp: Removed.
* src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::id):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
* src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebScrollableLayer.cpp: Removed.
* src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
* src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
* src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
* src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
* src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126076, r126099, and r126106.
commit-queue@webkit.org [Tue, 21 Aug 2012 17:34:49 +0000 (17:34 +0000)]
Unreviewed, rolling out r126076, r126099, and r126106.
http://trac.webkit.org/changeset/126076
http://trac.webkit.org/changeset/126099
http://trac.webkit.org/changeset/126106
https://bugs.webkit.org/show_bug.cgi?id=94614

Caused crashes during compositor shutdown in Aura builds of
Chromium (Requested by kbr_google on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/Platform:

* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
* chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
* chromium/public/WebIOSurfaceLayer.h:
(WebCore):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* chromium/public/WebImageLayer.h:
(WebCore):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebScrollableLayer.h: Copied from Source/Platform/chromium/public/WebScrollbarLayer.h.
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
* chromium/public/WebScrollbarLayer.h:
(WebCore):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebScrollbarLayer):
* chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
* chromium/public/WebVideoLayer.h:
(WebCore):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):

Source/WebCore:

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

* WebKit.gypi:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
* src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
(WebKit):
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::clearClient):
(WebKit::WebContentLayer::setDoubleSided):
(WebKit::WebContentLayer::setContentsScale):
(WebKit::WebContentLayer::setUseLCDText):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::paintContents):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
(WebKit):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
* src/WebIOSurfaceLayerImpl.h: Removed.
* src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
* src/WebLayer.cpp: Added.
(WebKit):
(WebKit::WebLayer::create):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::invalidateRect):
(WebKit::WebLayer::invalidate):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::setChildren):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::setDrawsContent):
(WebKit::WebLayer::drawsContent):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setUseParentBackfaceVisibility):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::setAnimationDelegate):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::hasActiveAnimation):
(WebKit::WebLayer::transferAnimationsTo):
(WebKit::WebLayer::setForceRenderSurface):
(WebKit::WebLayer::clearRenderSurface):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
* src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
* src/WebScrollbarLayerImpl.h: Removed.
* src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h.
(WebKit):
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not use window's eval in InjectedScript
pfeldman@chromium.org [Tue, 21 Aug 2012 17:03:12 +0000 (17:03 +0000)]
Web Inspector: do not use window's eval in InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=94610

Reviewed by Yury Semikhatsky.

Source/WebCore:

Otherwise, inspector does not work when eval is overriden.

Test: inspector/console/console-eval-fake.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
(WebCore):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback):
(WebCore):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):

LayoutTests:

* inspector/console/console-eval-fake-expected.txt: Added.
* inspector/console/console-eval-fake.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Accelerated In-Region Scrolling does not render correctly on rotation
tonikitoo@webkit.org [Tue, 21 Aug 2012 17:02:59 +0000 (17:02 +0000)]
[BlackBerry] Accelerated In-Region Scrolling does not render correctly on rotation
https://bugs.webkit.org/show_bug.cgi?id=94608
PR #194754

Reviewed by Goerge Staikos.
Patch by Antonio Gomes <agomes@rim.com>

When one translates/scrolls a HW accelerated scrollable layer, it makes use of
the OVERRIDE mechanism. Suppose the following scenario:

- In landscape, the overflow menu is scrollable. Then the user scrolls it so
that is has scroll position of 0, -100.
- when he rotates to portrait, the menus fit well to the available space but it
still has the OVERRIDE set, so it keeps the layer translated at 0, -100.

Fix is simple: clear the override when we stop scrolling a HW accelerated layer,
when we destroy the objects.

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Properly notify WebKit when Client stops in-region scrolling
tonikitoo@webkit.org [Tue, 21 Aug 2012 17:02:28 +0000 (17:02 +0000)]
[BlackBerry] Properly notify WebKit when Client stops in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=94603
PR #195813

Reviewed by Goerge Staikos.
Patch by Antonio Gomes <agomes@rim.com>

Simplify the API to get a notification of when a in-region
scrolling has finished.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
Removed an unneeded parameter.
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
Ditto.
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
abarth@webkit.org [Tue, 21 Aug 2012 16:54:26 +0000 (16:54 +0000)]
Implement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93407

Reviewed by Eric Seidel.

Source/WebCore:

This patch removes allowsAccessFrom and implements the security checks
in terms of shouldAllowAccessToDOMWindow directly.

* bindings/generic/BindingSecurity.cpp:
(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow):
(WebCore):
* bindings/generic/BindingSecurity.h:
(BindingSecurity):
* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore):
(WebCore::shouldAllowAccessToDOMWindow):
* bindings/js/JSDOMBinding.h:
(WebCore):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::shouldAllowAccessFrom):
(WebCore):
* bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

LayoutTests:

These test results are now more similar (although not identical) to the
results for the V8 bindings.

* http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
* http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
* http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
* http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
* http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
* http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12104508> TextIterator takes O(n^2) to iterate over n empty blocks
mitz@apple.com [Tue, 21 Aug 2012 16:43:56 +0000 (16:43 +0000)]
<rdar://problem/12104508> TextIterator takes O(n^2) to iterate over n empty blocks
https://bugs.webkit.org/show_bug.cgi?id=94429

Reviewed by Sam Weinig.

No new tests, because behavior is unchanged.

* editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero): Enhanced the check for nodes that
cannot contain VisiblePosition to also check for zero-height blocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKTR doesn't implement dumpWillCacheResponse().
beidson@apple.com [Tue, 21 Aug 2012 16:40:12 +0000 (16:40 +0000)]
WKTR doesn't implement dumpWillCacheResponse().
https://bugs.webkit.org/show_bug.cgi?id=94607

Unreviewed (Bot gardening)

* platform/wk2/Skipped: Skip http/tests/misc/willCacheResponse-delegate-callback.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: break on exceptions decoration was lost, restoring.
pfeldman@chromium.org [Tue, 21 Aug 2012 16:32:36 +0000 (16:32 +0000)]
Web Inspector: break on exceptions decoration was lost, restoring.

Not reviewed - a follow up to 126012.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._pauseOnExceptionStateChanged.get switch):
(WebInspector.ScriptsPanel.prototype._pauseOnExceptionStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126146.
ossy@webkit.org [Tue, 21 Aug 2012 16:21:26 +0000 (16:21 +0000)]
Unreviewed, rolling out r126146.
http://trac.webkit.org/changeset/126146
https://bugs.webkit.org/show_bug.cgi?id=94606

It made all tests assert (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/WebCore:

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
* bridge/qt/qt_runtime.h:
(QtRuntimeMethod):

Source/WebKit/qt:

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods_data):
(tst_QObjectBridge::introspectQtMethods):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMathML tests need rebaselining on Mac.
beidson@apple.com [Tue, 21 Aug 2012 16:17:01 +0000 (16:17 +0000)]
MathML tests need rebaselining on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94393

Reviewed by Dan Bernstein.

* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126150.
commit-queue@webkit.org [Tue, 21 Aug 2012 15:25:47 +0000 (15:25 +0000)]
Unreviewed, rolling out r126150.
http://trac.webkit.org/changeset/126150
https://bugs.webkit.org/show_bug.cgi?id=94605

Breaks 73 layout tests on chromium.webkit builder (Requested
by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.cpp:
(StringTraits):
(WebCore):
(WebCore::v8StringToWebCoreString):
(WebCore::int32ToWebCoreStringFast):
(WebCore::int32ToWebCoreString):
* bindings/v8/V8Binding.h:
(WebCore):
(V8ParameterBase):
(WebCore::V8ParameterBase::operator String):
(WebCore::V8ParameterBase::operator AtomicString):
(WebCore::V8ParameterBase::V8ParameterBase):
(WebCore::V8ParameterBase::prepareBase):
(WebCore::V8ParameterBase::object):
(WebCore::V8ParameterBase::setString):
(WebCore::V8ParameterBase::toString):
(WebCore::::prepare):
* bindings/v8/V8StringResource.cpp: Removed.
* bindings/v8/V8StringResource.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/media-document-audio-repaint.html is racy
philn@webkit.org [Tue, 21 Aug 2012 15:15:32 +0000 (15:15 +0000)]
media/media-document-audio-repaint.html is racy
https://bugs.webkit.org/show_bug.cgi?id=94454

Reviewed by Eric Carlson.

* media/media-document-audio-repaint.html: Don't rely on the play
event. Trigger the display and seek upon receipt of the pause event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEarly returns in MediaPlayer setters
philn@webkit.org [Tue, 21 Aug 2012 15:12:43 +0000 (15:12 +0000)]
Early returns in MediaPlayer setters
https://bugs.webkit.org/show_bug.cgi?id=87304

Calls to the MediaPlayerPrivate implementation can be avoided if
the value to set and the current value are equal.

Reviewed by Eric Carlson.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine): Once a new
MediaPlayerPrivate has been created propagate the playback rate
value to it, as it is done for some other attributes like preload
or preservePitch.
(WebCore::MediaPlayer::setVolume): Perform action only if current
and new values differ.
(WebCore::MediaPlayer::setMuted): Ditto.
(WebCore::MediaPlayer::setPreservesPitch): Ditto.
(WebCore::MediaPlayer::setSize): Ditto.
(WebCore::MediaPlayer::setVisible): Ditto.
(WebCore::MediaPlayer::setPreload): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: OwnPtr<T> was counted as RefPtr<T>
loislo@chromium.org [Tue, 21 Aug 2012 14:50:54 +0000 (14:50 +0000)]
Web Inspector: NMI: OwnPtr<T> was counted as RefPtr<T>
https://bugs.webkit.org/show_bug.cgi?id=94599

Reviewed by Yury Semikhatsky.

* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r115348.
paroga@webkit.org [Tue, 21 Aug 2012 13:44:29 +0000 (13:44 +0000)]
Build fix for WinCE after r115348.

* Source/cmake/OptionsWindows.cmake: Removed duplicated WEBKIT_OPTION_DEFAULT_PORT_VALUE().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember.
loislo@chromium.org [Tue, 21 Aug 2012 13:41:00 +0000 (13:41 +0000)]
Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember.
https://bugs.webkit.org/show_bug.cgi?id=94580

Reviewed by Yury Semikhatsky.

Drive by fix: immutable ElementAttrybuteData uses the same trick with placement new as in StylePropertySet.

Source/WebCore:

* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::immutableElementAttributeDataSize):
(WebCore):
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
* dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for COMPILER(MSVC) && !CPU(X86) after r126023.
paroga@webkit.org [Tue, 21 Aug 2012 13:22:38 +0000 (13:22 +0000)]
Build fix for COMPILER(MSVC) && !CPU(X86) after r126023.

* wtf/MathExtras.h:
(lrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add destroy notify for register_uri_scheme
carlosgc@webkit.org [Tue, 21 Aug 2012 12:50:18 +0000 (12:50 +0000)]
[GTK] Add destroy notify for register_uri_scheme
https://bugs.webkit.org/show_bug.cgi?id=94315

Reviewed by Philippe Normand.

For introspection to work correctly, a destroy notify needs to be
added to register_uri_scheme so that bindings know when to
finalize the user_data.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_register_uri_scheme):
(webkitWebContextReceivedURIRequest):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix range-hit-test-with-padding.html by removing unnecessary part.
keishi@webkit.org [Tue, 21 Aug 2012 11:03:50 +0000 (11:03 +0000)]
Fix range-hit-test-with-padding.html by removing unnecessary part.

Unreviewed.

* fast/forms/range/range-hit-test-with-padding.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move String related code in V8Binding to a separate file
haraken@chromium.org [Tue, 21 Aug 2012 10:22:54 +0000 (10:22 +0000)]
[V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571

Reviewed by Adam Barth.

This patch moves V8Parameter, V8ParameterBase and String related code
in V8Binding to a separate file.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8StringResource.cpp: Added.
* bindings/v8/V8StringResource.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skip new failing tests.
ossy@webkit.org [Tue, 21 Aug 2012 09:50:12 +0000 (09:50 +0000)]
[Qt] Gardening. Skip new failing tests.

Reviewed Csaba Osztrogonác.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-08-21

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Tue, 21 Aug 2012 09:49:38 +0000 (09:49 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit2: Unreviewed build fix for newer Qt 5: QT += qmltest does not imply...
hausmann@webkit.org [Tue, 21 Aug 2012 08:54:32 +0000 (08:54 +0000)]
Source/WebKit2: Unreviewed build fix for newer Qt 5: QT += qmltest does not imply QT += testlib anymore, but
the code here needs QSignalSpy from QTestLib

* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/WebView.pro:

Tools: Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
self-contained. The module name is not appended automatically anymore.

* qmake/qt_webkit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
hausmann@webkit.org [Tue, 21 Aug 2012 08:54:02 +0000 (08:54 +0000)]
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Before r125428 run-time methods (wrapped signals, slots or invokable functions) were subclasses of
JSInternalFunction and therefore real function objects in the JavaScript sense. r125428 changed them
to be just callable objects, but they did not have Function.prototype as prototype anymore for example
nor was their name correct (resulting in a layout test failure).

This patch changes run-time methods back to being real function objects that have a correct name and
have Function.prototype in their prototype change

The objects returned by JSObjectMakeFunctionWithCallbackInjected are light-weight internal function objects
that do not support JSObject{Set/Get}Private. Therefore we inject our own prototype right before the
Function.prototype prototype, which uses private data to store a pointer to our C++ QtRuntimeMethod object.
This complicates the retrieval of the pointer to that instance slightly, which is why this patch introduces
the toRuntimeMethod convenience function that looks up our prototype first and does a check for type-safety.

At the same time the patch removes the length properties from the run-time method itself as well as connect/disconnect.
The length property on a function signifies the number of arguments, but in all three cases that number is
actually variable, because of overloading. That is why we choose not to expose it in the first place.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
* bridge/qt/qt_runtime.h:
(QtRuntimeMethod): Remove unused member variables.

Source/WebKit/qt:

Fixed some test expectations.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.

LayoutTests:

* platform/qt/Skipped: Unskip test that is now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 21 Aug 2012 08:28:39 +0000 (08:28 +0000)]
Unreviewed GTK gardening.

fast/js/random-array-gc-stress.html has started to flakily crash in
release builds as well, so expanding the expectation.

The fast/forms/range/range-hit-test-with-padding.html test has been
failing since introduced in 126132. Adding a text expectation.

Marking one more frame flattening test as flaky.

Skipping two calendar picker tests. The feature is currently unsupported
and the tests take half a minute to run, so it's not really worth it.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd another interesting test that used to fire a different ASSERT before we fixed...
cevans@google.com [Tue, 21 Aug 2012 08:12:42 +0000 (08:12 +0000)]
Add another interesting test that used to fire a different ASSERT before we fixed https://bugs.webkit.org/show_bug.cgi?id=36427:
ASSERT(parents.size() >= depth + 1)
https://bugs.webkit.org/show_bug.cgi?id=84793

Reviewed by Abhishek Arya.

* fast/xpath/xpath-detached-import-assert-expected.txt: Added.
* fast/xpath/xpath-detached-import-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQuick build fix for the build fix ;(
hausmann@webkit.org [Tue, 21 Aug 2012 08:06:18 +0000 (08:06 +0000)]
Quick build fix for the build fix ;(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for newer Qt 5 versions: QVariant::WidgetStar has been removed,
hausmann@webkit.org [Tue, 21 Aug 2012 08:04:24 +0000 (08:04 +0000)]
Unreviewed build fix for newer Qt 5 versions: QVariant::WidgetStar has been removed,
but fortunately QMetaType has a much more powerful function available for us to use.

Thanks to Jedrzej Nowacki for the hint :)

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove String::New() from V8 binding (Part 1)
haraken@chromium.org [Tue, 21 Aug 2012 07:33:09 +0000 (07:33 +0000)]
[V8] Remove String::New() from V8 binding (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=94574

Reviewed by Adam Barth.

Currently, V8 binding mixes String::New(), String::NewSymbol() and v8String().
String::New() should be replaced with String::NewSymbol() or v8String(),
depending on use cases:

- If it is a symbol (e.g. attribute name, constant string, etc),
String::NewSymbol() should be used. Cache of created symbols is managed by V8.

- If it is not a symbol, v8String() should be used. Cache of created strings
is managed by V8 binding (i.e. StringCache class).

This patch replaces String::New() for symbols with String::NewSymbol().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
* bindings/v8/V8DOMConfiguration.h:
(WebCore::V8DOMConfiguration::configureAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126028.
loislo@chromium.org [Tue, 21 Aug 2012 07:24:05 +0000 (07:24 +0000)]
Unreviewed, rolling out r126028.
http://trac.webkit.org/changeset/126028
https://bugs.webkit.org/show_bug.cgi?id=94576

it broke compilation on apple webkit win. (Requested by loislo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
* inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
* inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: wrong size was reported for immutable StylePropertySet
loislo@chromium.org [Tue, 21 Aug 2012 07:17:53 +0000 (07:17 +0000)]
Web Inspector: NMI: wrong size was reported for immutable StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=94489

Reviewed by Yury Semikhatsky.

Immutable StylePropertySet is created via placement new.
The rest of the allocated buffer is used as an array of CSSProperty.
This means that we don't need to report m_properties member but have to report actual size of the buffer
used for both, the object and CSSProperty array.

* css/StylePropertySet.cpp:
(WebCore::immutableStylePropertySetSize):
(WebCore):
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
wangxianzhu@chromium.org [Tue, 21 Aug 2012 06:50:57 +0000 (06:50 +0000)]
[Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
https://bugs.webkit.org/show_bug.cgi?id=94558

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move handleOutOfMemory() from V8Proxy to V8Binding
haraken@chromium.org [Tue, 21 Aug 2012 06:50:42 +0000 (06:50 +0000)]
[V8] Move handleOutOfMemory() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94563

Reviewed by Adam Barth.

To kill V8Proxy, this patch moves handleOutOfMemory() from V8Proxy to V8Binding.

No tests. No change in behavior.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::runScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInsertionShouldCallDidNotifyDescendantInsertions should be merged to InsertionShouldC...
morrita@google.com [Tue, 21 Aug 2012 06:49:27 +0000 (06:49 +0000)]
InsertionShouldCallDidNotifyDescendantInsertions should be merged to InsertionShouldCallDidNotifySubtreeInsertions
https://bugs.webkit.org/show_bug.cgi?id=94570

Reviewed by Ryosuke Niwa.

Node::didNotifySubtreeInsertions() and Node::didNotifyDescendantInsertions() are used for similar purpose and
we could unify them to the safer one, which is didNotifySubtreeInsertions().

This change replaces the last didNotifyDescendantInsertions() implementation in HTMLBodyElement with didNotifySubtreeInsertions()
then eliminates related code which is no longer used.

No new tests. Covered by existing tests.

* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
* dom/Node.h: Removed didNotifyDescendantInsertions() stub and InsertionShouldCallDidNotifyDescendantInsertions enum value.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifySubtreeInsertions): morphed from didNotifyDescendantInsertions()
* html/HTMLBodyElement.h:
(HTMLBodyElement):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto): Remove useless InsertionShouldCallDidNotifyDescendantInsertions return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup TestExpectationParser.parse
rniwa@webkit.org [Tue, 21 Aug 2012 05:56:44 +0000 (05:56 +0000)]
Cleanup TestExpectationParser.parse
https://bugs.webkit.org/show_bug.cgi?id=94545

Reviewed by Dirk Pranke.

Refactor TestExpectations to simplify the code.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.parse): Merged _tokenize_list.
(TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
since the check is now done in _parser_modifiers.
(TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
(TestExpectationParser._tokenize_line): Renamed from _tokenize.
(TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
This is done on a local variable in _parse_modifiers, preserving the original case.
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
of 'rebaseline' against parsed modifiers.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationParserTests._tokenize):
(TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
(TestExpectationSerializerTests._tokenize):
(TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
been merged into parse.
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_csv): Preserves the case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce GradientAttributes object size
commit-queue@webkit.org [Tue, 21 Aug 2012 05:45:36 +0000 (05:45 +0000)]
Reduce GradientAttributes object size
https://bugs.webkit.org/show_bug.cgi?id=86151

Patch by Rob Buis <rbuis@rim.com> on 2012-08-20
Reviewed by Eric Seidel.

This reduces GradientAttributes in memory size by 8 bytes on my 64-bit system. It also
reduces the size of RenderSVGResourceLinearGradient and RenderSVGResourceRadialGradient.

* svg/GradientAttributes.h:
(WebCore::GradientAttributes::spreadMethod):
(WebCore::GradientAttributes::gradientUnits):
(GradientAttributes):
(WebCore):
(SameSizeAsGradientAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[jhbuild] EFL now runs jhbuild update for every build
commit-queue@webkit.org [Tue, 21 Aug 2012 05:01:06 +0000 (05:01 +0000)]
[jhbuild] EFL now runs jhbuild update for every build
https://bugs.webkit.org/show_bug.cgi?id=94267

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2012-08-20
Reviewed by Martin Robinson.

Try to fix WinCE build by returning the empty string instead of
env when no jhbuild infrastructure is found.

* Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClicking input type=range with padding or border sets wrong value
keishi@webkit.org [Tue, 21 Aug 2012 04:27:27 +0000 (04:27 +0000)]
Clicking input type=range with padding or border sets wrong value
https://bugs.webkit.org/show_bug.cgi?id=94473

Reviewed by Kent Tamura.

Source/WebCore:

We should take the padding and border width into account when calculating the value from the mouse location.

Test: fast/forms/range/range-hit-test-with-padding.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderTrackElementOf):
(WebCore):
(WebCore::SliderThumbElement::setPositionFromPoint):
* html/shadow/SliderThumbElement.h:
(WebCore):

LayoutTests:

* fast/forms/range/range-hit-test-with-padding-expected.txt: Added.
* fast/forms/range/range-hit-test-with-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoload event shouldn't fired during node insertion traversals.
morrita@google.com [Tue, 21 Aug 2012 04:21:28 +0000 (04:21 +0000)]
load event shouldn't fired during node insertion traversals.
https://bugs.webkit.org/show_bug.cgi?id=94447

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLFrameElementBase::didNotifyDescendantInsertions() with empty @src
can trigger a load event during ChildNodeInsertionNotifier
traversal, whose handler can make DOM tree state inconsistent.

This change introduces a post traversal hook,
didNotifySubtreeInsertions(), for the insertion traversal and
replaces the problematic didNotifyDescendantInsertions() with it.

Since didNotifySubtreeInsertions() is invoked after the traversal,
it is safe for event handlers to mutate the tree.

Test: fast/frames/iframe-onload-and-domnodeinserted.html

* dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier): Added a post subtree notification.
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
* dom/Node.h:
(WebCore::Node::didNotifySubtreeInsertions): Newly added.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto): Now returns InsertionShouldCallDidNotifySubtreeInsertions
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Replaced didNotifyDescendantInsertions()
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):

LayoutTests:

* fast/frames/iframe-onload-and-domnodeinserted-expected.txt: Added.
* fast/frames/iframe-onload-and-domnodeinserted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r126127): Build break on multiple platforms
shinyak@chromium.org [Tue, 21 Aug 2012 03:57:42 +0000 (03:57 +0000)]
Regression(r126127): Build break on multiple platforms
https://bugs.webkit.org/show_bug.cgi?id=94568

Reviewed by Hajime Morita.

Notation::cloneNode should also have ExceptionCode. We add it in this patch.

No new tests, no change in behavior.

* dom/Notation.cpp:
(WebCore::Notation::cloneNode):
* dom/Notation.h:
(Notation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix broken non-JIT build.
commit-queue@webkit.org [Tue, 21 Aug 2012 03:52:40 +0000 (03:52 +0000)]
Fix broken non-JIT build.
https://bugs.webkit.org/show_bug.cgi?id=94564.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-20
Reviewed by Filip Pizlo.

Added some UNUSED_PARAM() macros to make the compiler happy.

* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Select popup shows blank content when its option tags contain '\' characters
commit-queue@webkit.org [Tue, 21 Aug 2012 03:38:53 +0000 (03:38 +0000)]
[BlackBerry] Select popup shows blank content when its option tags contain '\' characters
https://bugs.webkit.org/show_bug.cgi?id=94321

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-08-20
Reviewed by George Staikos.

PR 194224

When the SelectPopupClient generates HTML, if there is a character '\' in the select options'
description, we should escape it to avoid the character being interpreted as an escape character.

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
shinyak@chromium.org [Tue, 21 Aug 2012 03:22:06 +0000 (03:22 +0000)]
ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704

Reviewed by Dimitri Glazkov.

Source/WebCore:

According to the spec, ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception. The existing implementation
returned null object instead.

We change the cloneNode() interface so that we can throw an exception from cloneNode().

Test: fast/dom/shadow/shadowroot-clonenode.html

* dom/Attr.cpp:
(WebCore::Attr::cloneNode):
* dom/Attr.h:
* dom/CDATASection.cpp:
(WebCore::CDATASection::cloneNode):
* dom/CDATASection.h:
(CDATASection):
* dom/Comment.cpp:
(WebCore::Comment::cloneNode):
* dom/Comment.h:
(Comment):
* dom/Document.cpp:
(WebCore::Document::cloneNode):
* dom/Document.h:
(Document):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::cloneNode):
* dom/DocumentFragment.h:
(DocumentFragment):
* dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNode):
* dom/DocumentType.h:
(DocumentType):
* dom/Element.cpp:
(WebCore::Element::cloneNode):
* dom/Element.h:
(Element):
* dom/EntityReference.cpp:
(WebCore::EntityReference::cloneNode):
* dom/EntityReference.h:
(EntityReference):
* dom/Node.h:
(Node):
(WebCore::Node::cloneNode):
* dom/Node.idl:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::cloneNode):
* dom/ProcessingInstruction.h:
(ProcessingInstruction):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/Text.cpp:
(WebCore::Text::cloneNode):
* dom/Text.h:
(Text):

LayoutTests:

* fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
* fast/dom/shadow/shadowroot-clonenode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-win] Use native digits in parsing/formatting dates in the textfield part...
tkent@chromium.org [Tue, 21 Aug 2012 03:04:46 +0000 (03:04 +0000)]
[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=94281

Reviewed by Hajime Morita.

Source/WebCore:

Tests: Add some cases to Source/WebKit/chromium/tests/LocaleWinTest.cpp

* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::isLocalizedDigit): A helper for parseNumber(). This
return true if the specified character is one of native digits.
(WebCore::LocaleWin::parseNumber):
Try to parse ASCII digits, then try to parse native digtis. This
becomes a member of LocaleWin because it uses
convertFromLocalizedNumber().
(WebCore::LocaleWin::appendNumber): Apply convertToLocalizedNumber().
(WebCore::LocaleWin::appendTwoDigitsNumber): ditto.
(WebCore::LocaleWin::appendFourDigitsNumber): ditto.
* platform/text/LocaleWin.h:
(LocaleWin):
- Make some static functions member functions of LocaleWin.
- Add isLocalizedDigit().

Source/WebKit/chromium:

* tests/LocaleWinTest.cpp:
(TEST_F): Added formatting and parsing tests for Persian locale to check
native digit behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a watcher for WTF changes
benjamin@webkit.org [Tue, 21 Aug 2012 02:59:22 +0000 (02:59 +0000)]
Add a watcher for WTF changes

Unreviewed.

Add myself as a watcher for changes in WTF.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126125 268f45cc-cd09-0410-ab3c-d52691b4dbfc