WebKit-https.git
6 years ago[CMake] Enable building WebKit2-only build for the EFL port
commit-queue@webkit.org [Mon, 3 Dec 2012 15:20:51 +0000 (15:20 +0000)]
[CMake] Enable building WebKit2-only build for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=103820

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-03
Reviewed by Gyuyoung Kim.

.:

To create a WebKit2-only build for EFL use the following command:
build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF".

* CMakeLists.txt: Turn on WebKit1 support if it is not explicitly set (enabled or disabled) for
all CMake based ports.

* Source/cmake/OptionsEfl.cmake: Enable WebKit2
for the EFL port if it is not explicitly set (enabled or disabled).

Tools:

Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
cmake directly. Initialize $cmakeArgs to avoid potential
warnings when running the script.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Qt gardening.
kbalazs@webkit.org [Mon, 3 Dec 2012 15:18:05 +0000 (15:18 +0000)]
Unreviewed Qt gardening.

Remove image expectation for tests that now pass.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Expectations fix up
schenney@chromium.org [Mon, 3 Dec 2012 15:04:44 +0000 (15:04 +0000)]
[Chromium] Expectations fix up

Unreviewed expectations.

Two tests appear to have been out-of-date when they were last rebaselined.

* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-win-xp/svg/carto.net: Removed.
* platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Removed.
* platform/chromium-win/svg/carto.net/colourpicker-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agosvg/custom/baseval-animval-equality.svg should use dumpAsText
kbalazs@webkit.org [Mon, 3 Dec 2012 15:00:53 +0000 (15:00 +0000)]
svg/custom/baseval-animval-equality.svg should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=103873

Reviewed by Dirk Schulze.

Turn it to a dumpAsText test.

* platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/chromium-mac/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/chromium/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/gtk/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/mac-lion/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/mac-wk2/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/mac/svg/custom/baseval-animval-equality-expected.txt: Removed.
* platform/qt/svg/custom/baseval-animval-equality-expected.txt: Removed.
* svg/custom/baseval-animval-equality-expected.txt: Added.
* svg/custom/baseval-animval-equality.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets
pierre.rossi@gmail.com [Mon, 3 Dec 2012 14:52:00 +0000 (14:52 +0000)]
[Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets
https://bugs.webkit.org/show_bug.cgi?id=103844

Patch by Pierre Rossi <pierre.rossi@digia.com> on 2012-12-03
Reviewed by Simon Hausmann.

Let's follow the common practice and have one export macro per library.
We can't rely on BUILDING_WEBKIT anymore in that case, so we use the
qmake defines instead.

* Api/qwebkitglobal.h: Updated the import/export logic.
* WidgetApi/qgraphicswebview.h: s/QWEBKIT/QWEBKITWIDGETS/
* WidgetApi/qwebframe.h: Ditto.
* WidgetApi/qwebinspector.h: Ditto.
* WidgetApi/qwebpage.h: Ditto.
* WidgetApi/qwebview.h: Ditto.
* WidgetSupport/InitWebKitQt.cpp:
(WebKit::initializeWebKitWidgets): use QWEBKITWIDGETS_EXPORT.
* WidgetSupport/InitWebKitQt.h:
(WebKit): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Acid3 test to the latest version
arv@chromium.org [Mon, 3 Dec 2012 14:28:52 +0000 (14:28 +0000)]
Update Acid3 test to the latest version
https://bugs.webkit.org/show_bug.cgi?id=102943

Reviewed by Ojan Vafai.

The Acid3 test has been updated to not break when browsers starts to implement new
standards. This updates our copy of the Acid3 test.

* fast/dom/Range/acid3-surround-contents.html:
* http/tests/misc/acid3.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeech Recognition API: Update SpeechRecognitionEvent to match the specification
tommyw@google.com [Mon, 3 Dec 2012 14:27:24 +0000 (14:27 +0000)]
Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Kentaro Hara.

Source/WebCore:

Specification for the Speech Recognition API:
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html

This patch does the following:
o Adds results, and removing result, on SpeechRecognitionEvent
o Renaming SpeechRecognitionResult::final to isFinal
o Removing emma from SpeechRecognitionResult

The emma attribute is supposed to move from SpeechRecognitionResult to the SpeechRecognitionEvent,
but that caused GC issues for unrelated code so it will be added later when properly fixed.

Existing tests updated to test the new API.

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::didReceiveResults):
(WebCore):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognitionEvent.cpp:
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::~SpeechRecognitionEvent):
* Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::results):
* Modules/speech/SpeechRecognitionEvent.idl:
* Modules/speech/SpeechRecognitionResult.cpp:
* Modules/speech/SpeechRecognitionResult.h:
(WebCore::SpeechRecognitionResult::isFinal):
(SpeechRecognitionResult):
* Modules/speech/SpeechRecognitionResult.idl:
* WebCore.gypi:
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(Dictionary):
* bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp: Removed.

Source/WebKit/chromium:

Adding the new didReceiveResults method.

* public/WebSpeechRecognizerClient.h:
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveResults):
(WebKit):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):

Tools:

Changing the mock to use the new results delivery API.

* DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

LayoutTests:

Updating basic tests and removing emma tests temporarily.

* fast/speech/scripted/emma-expected.txt: Removed.
* fast/speech/scripted/emma.html: Removed.
* fast/speech/scripted/speechrecognition-basics-expected.txt:
* fast/speech/scripted/speechrecognition-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] New resize tests fail
michael.bruning@digia.com [Mon, 3 Dec 2012 14:26:18 +0000 (14:26 +0000)]
[Qt][WK2] New resize tests fail
https://bugs.webkit.org/show_bug.cgi?id=103875

Reviewed by Jocelyn Turcotte.

Removes reference to unused viewportSpy, adds clearing the sizeSpy to the init method instead.

* UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Gardening, mark tests flaky
commit-queue@webkit.org [Mon, 3 Dec 2012 14:15:08 +0000 (14:15 +0000)]
[EFL] Gardening, mark tests flaky
https://bugs.webkit.org/show_bug.cgi?id=103884

Unreviewed gardening to mark tests flaky based on flakiness dashboard.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-03

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the...
commit-queue@webkit.org [Mon, 3 Dec 2012 14:10:42 +0000 (14:10 +0000)]
[GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the web process
https://bugs.webkit.org/show_bug.cgi?id=103729

Patch by Joaquim Rocha <jrocha@igalia.com> on 2012-12-03
Reviewed by Carlos Garcia Campos.

When a URI scheme is registered and the WebProcess is killed,
those schemes would not work anymore after the process is relaunched.

This was observed in Epiphany and possibly affects any port that
uses libsoup.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the registered URI schemes.
(WebKit::WebProcessCreationParameters::decode): Decode the registered URI schemes.
* Shared/WebProcessCreationParameters.h: Add the urlSchemesRegistered Vector to hold the registered URI schemes.
(WebProcessCreationParameters):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Assign the parameters.urlSchemesRegistered from the URI schemes
registered in the WebSoupRequestManagerProxy and removed the notImplemented() call.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Assign the parameters.urlSchemesRegistered from the URI schemes
registered in the WebSoupRequestManagerProxy.
* UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::registerURIScheme): Add the given scheme to the m_registeredURISchemes Vector.
* UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebKit::WebSoupRequestManagerProxy::registeredURISchemes): Return the m_registeredURISchemes.
(WebSoupRequestManagerProxy): Define the m_registeredURISchemes to hold the schemes that are registered.
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Call m_soupRequestManager.registerURIScheme for each URI scheme
found in the parameters.
* WebProcess/soup/WebSoupRequestManager.h: Make registerURIScheme public.
(WebSoupRequestManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Enable CSS3 background-position offsets by default.
alexis@webkit.org [Mon, 3 Dec 2012 13:23:59 +0000 (13:23 +0000)]
[Qt] Enable CSS3 background-position offsets by default.
https://bugs.webkit.org/show_bug.cgi?id=103877

Reviewed by Tor Arne Vestbø.

Tools:

Enable by default CSS3 background-position offsets.

* qmake/mkspecs/features/features.pri:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r136377.
commit-queue@webkit.org [Mon, 3 Dec 2012 13:20:23 +0000 (13:20 +0000)]
Unreviewed, rolling out r136377.
http://trac.webkit.org/changeset/136377
https://bugs.webkit.org/show_bug.cgi?id=103881

Causes crashes on debug builds that use JSC. (Requested by
mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03

Source/WebCore:

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFailSocketStream):
* css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
(WebCore::Document::processHttpEquiv):
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* dom/ViewportArguments.cpp:
(WebCore):
(WebCore::parserLineNumber):
(WebCore::reportViewportWarning):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
* inspector/ConsoleMessage.h:
(ConsoleMessage):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::count):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* page/Console.cpp:
* page/Console.h:
(Console):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::printErrorMessage):
* svg/SVGDocumentExtensions.cpp:
(WebCore):
(WebCore::parserLineNumber):
(WebCore::reportMessage):
* workers/WorkerContext.cpp:
* workers/WorkerContext.h:
(WorkerContext):

LayoutTests:

* fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/xss-auditor-handles-file-urls-expected.txt:
* html5lib/run-test11-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/misc/bubble-drag-events-expected.txt:
* http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* http/tests/misc/iframe-invalid-source-crash-expected.txt:
* http/tests/misc/image-blocked-src-change-expected.txt:
* http/tests/misc/image-blocked-src-no-change-expected.txt:
* http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* http/tests/security/frame-loading-via-document-write-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
* http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
* http/tests/security/xssAuditor/base-href-control-char-expected.txt:
* http/tests/security/xssAuditor/base-href-expected.txt:
* http/tests/security/xssAuditor/base-href-null-char-expected.txt:
* http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
* http/tests/security/xssAuditor/cookie-injection-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
* http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/embed-tag-expected.txt:
* http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/form-action-expected.txt:
* http/tests/security/xssAuditor/full-block-base-href-expected.txt:
* http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
* http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
* http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
* http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/iframe-injection-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
* http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
* http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
* http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
* http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-expected.txt:
* http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
* http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
* http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
* http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
* http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
* http/tests/security/xssAuditor/link-onclick-expected.txt:
* http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
* http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
* http/tests/security/xssAuditor/malformed-HTML-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
* http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-tag-expected.txt:
* http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/open-attribute-body-expected.txt:
* http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
* http/tests/security/xssAuditor/open-iframe-src-expected.txt:
* http/tests/security/xssAuditor/open-script-src-expected.txt:
* http/tests/security/xssAuditor/post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/property-escape-comment-expected.txt:
* http/tests/security/xssAuditor/property-escape-entity-expected.txt:
* http/tests/security/xssAuditor/property-escape-expected.txt:
* http/tests/security/xssAuditor/property-escape-long-expected.txt:
* http/tests/security/xssAuditor/property-escape-quote-expected.txt:
* http/tests/security/xssAuditor/report-script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
* http/tests/security/xssAuditor/script-tag-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
* http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
* platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
* platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
* platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
* platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
* svg/custom/invalid-length-units-expected.txt:
* svg/custom/poly-parsing-error-expected.txt:
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/path-parser-expected.txt:
* svg/dom/points-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove useless included header and change position of Proximity Events test cases
kihong.kwon@samsung.com [Mon, 3 Dec 2012 12:48:18 +0000 (12:48 +0000)]
Remove useless included header and change position of Proximity Events test cases
https://bugs.webkit.org/show_bug.cgi?id=103871

Reviewed by Antonio Gomes.

Source/WebCore:

Remove useless included header from DeviceProximityEvent.cpp.

No new tests, It is just code refactoring.

* Modules/proximity/DeviceProximityEvent.cpp:

LayoutTests:

Change the path of Proximity Events test cases from LayoutTests/fast/dom/Proximity to LayoutTests/proximity.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* proximity/check-event-deviceproximity-expected.txt: Renamed from LayoutTests/fast/dom/Proximity/check-event-deviceproximity-expected.txt.
* proximity/check-event-deviceproximity.html: Renamed from LayoutTests/fast/dom/Proximity/check-event-deviceproximity.html.
* proximity/create-event-deviceproximity-expected.txt: Renamed from LayoutTests/fast/dom/Proximity/create-event-deviceproximity-expected.txt.
* proximity/create-event-deviceproximity.html: Renamed from LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][Mac] QtWebKitWidgets has wrong install_name.
zeno.albisser@digia.com [Mon, 3 Dec 2012 12:40:42 +0000 (12:40 +0000)]
[Qt][Mac] QtWebKitWidgets has wrong install_name.

This part got lost during the library split.
It was done for QtWebKit before, but it also
needs to be applied to QtWebKitWidgets.

Reviewed by Tor Arne Vestbø.

* Source/widgetsapi.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Mark last input event for current vsync interval
commit-queue@webkit.org [Mon, 3 Dec 2012 12:39:46 +0000 (12:39 +0000)]
[chromium] Mark last input event for current vsync interval
https://bugs.webkit.org/show_bug.cgi?id=103647

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-12-03
Reviewed by James Robinson.

On Android all input events are triggered at the start of a vsync to maximize
the amount of time an application has for painting. Add a field to
WebInputEvent to indicate when the input event is the final one for the
current vsync interval. This information will be used for more efficient
render scheduling.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::WebInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] initial volume events on media elements should happen earlier
commit-queue@webkit.org [Mon, 3 Dec 2012 12:37:44 +0000 (12:37 +0000)]
[GStreamer] initial volume events on media elements should happen earlier
https://bugs.webkit.org/show_bug.cgi?id=96912

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-03
Reviewed by Philippe Normand.

Update mediaelement volume and mute properties to whatever values
playbin has as soon as possible (when the playbin reaches PAUSED state).
This will improve user experience as the volume visuals won't suddenly
change when user clicks play.

No new tests: media/event-attributes.html already tests media events.
Unfortunately this test is flaky on EFL and GTK (more specifically
it is flaky on pulseaudio-using gstreamer platforms: http://webkit.org/b/83704).

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Gardening after r136280, r136323, r136164 and r136031.
kkristof@inf.u-szeged.hu [Mon, 3 Dec 2012 12:37:14 +0000 (12:37 +0000)]
[Qt] Gardening after r136280, r136323, r136164 and r136031.
https://bugs.webkit.org/show_bug.cgi?id=103876

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-12-03
Reviewed by Csaba Osztrogonác.

r136280: Added Qt baseline for fast/events/stopPropagation-submit.html.
r136323: Skipped storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html
r136164: Skipped fast/dom/Geolocation/cached-position-iframe.html on Qt-WK2
r136031: Updated Qt-WK2 baselines for http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag* tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
* platform/qt/TestExpectations:
* platform/qt/fast/events/stopPropagation-submit-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r136378.
alexis@webkit.org [Mon, 3 Dec 2012 12:26:14 +0000 (12:26 +0000)]
Unreviewed build fix after r136378.

* css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS3 Backgrounds and Borders] Implement CSS3 background-position offsets rendering.
alexis@webkit.org [Mon, 3 Dec 2012 11:55:28 +0000 (11:55 +0000)]
[CSS3 Backgrounds and Borders] Implement CSS3 background-position offsets rendering.
https://bugs.webkit.org/show_bug.cgi?id=103440

Reviewed by Julien Chaffraix.

Source/WebCore:

Add the rendering bits of the new background-position offsets. It adds
new bits in FillLayer to store the edges used to position the
background. The old x and y members are used the same way as before, to
store the value of the offset.

Test: fast/backgrounds/background-position-rendering.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createPositionListForLayer): Refactor into a function the
code duplicated in getPropertyCSSValue to avoid more code
duplication.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add implicit conversion from the enums used in the rendering code to
CSS values.
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Add
support for the new positioning and refactor a little naming of the
variables for better readability.
* rendering/style/FillLayer.cpp:
(SameSizeAsFillLayer):
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::fillUnsetProperties): When filling the layer with
unset properties make sure we also set the x and y origins of the
background in case they were set.
* rendering/style/FillLayer.h:
(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::isBackgroundOriginSet):
(FillLayer):
(WebCore::FillLayer::setBackgroundXOrigin):
(WebCore::FillLayer::setBackgroundYOrigin):
(WebCore::FillLayer::clearPositionX):
(WebCore::FillLayer::clearPositionY):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Uncomment the computed style tests from background-position-parsing-2
and add the expected output. Add a new
background-position-rendering test to verify that the background has a
correct position with the new <position> value. I also covered some old
CSS 2.1 values for verification.

* fast/backgrounds/background-position-parsing-2-expected.txt:
* fast/backgrounds/background-position-parsing-2.html:
* fast/backgrounds/background-position-rendering-expected.html: Added.
* fast/backgrounds/background-position-rendering.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Autogenerate stack traces and line numbers when possible.
mkwst@chromium.org [Mon, 3 Dec 2012 11:07:08 +0000 (11:07 +0000)]
Web Inspector: Autogenerate stack traces and line numbers when possible.
https://bugs.webkit.org/show_bug.cgi?id=100650

Reviewed by Yury Semikhatsky.

Source/WebCore:

Console messages generated in WebCore generally are asked to do a bit of
work in order to provide a developer with a detailed report. We ask the
caller to either generate stack traces, or pass in a url/line number
pair, which can be a bit of work. Predictably, most callers don't pass
in what we'd like to see.

This patch creates a new, simpler console message generation API that we
expect most call sites to use. Source, type, level, and message are
required, and an optional request ID can be passed in. Everything else
will be autogenerated inside ConsoleMessage when appropriate.

In a subsequent patch, we expect to be able to trim down more of the
external call sites (ContentSecurityPolicy springs to mind) in order to
further consolidate the external interface. Simple is good.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFailSocketStream):
    Drop the now-redundant URL parameter from various WebSocket errors.
* css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
    Switch to Document::addConsoleMessage, which means that we can move
    line-number generation out of MediaList.
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
    Use the long-form 'addMessage()' rather than the public interface.
(WebCore::Document::processHttpEquiv):
    Drop the URL parameter, as it's now autogenerated.
(WebCore::Document::addConsoleMessage):
(WebCore):
* dom/Document.h:
(Document):
    Override the pure virtual method on ScriptExecutionContext, and pass
    the call through to the new Console::addMessage, which accepts a
    pointer to the Document in order to do line-number generation.
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
    Add a pure virtual variant of addConsoleMessage which accepts only
    bare minimum data, and expects autogeneration of the rest.
    Additionally, ensure that the other variants always have either a
    URL/line number, or a stack trace.
* dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
    Drop line numbers and URLs from Viewport warnings. We can generate
    these now.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
    Drop the URL from form autofocus warnings
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
    Drop the URL and line from sandbox attribute warnings.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
    Drop the URL from WebGL warnings.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
    Call 'autogenerateMetadata' to ensure that a stack trace is
    generated if one isn't provided. Create a new constructor that
    accepts a ScriptState/ScriptArguments pair, and use it for console
    API calls.
(WebCore):
(WebCore::ConsoleMessage::autogenerateMetadata):
    Generate a stack trace given whatever information we've got.
* inspector/ConsoleMessage.h:
(ConsoleMessage):
    Create a new constructor that accepts a ScriptState/ScriptArguments
    pair, and use it for console API calls.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
    Use the short-form ConsoleMessage constructor.
(WebCore::InspectorConsoleAgent::addMessageToConsole):
    Use the stack-only constructor, or the ScriptState
    constructor, as appropriate.
(WebCore::InspectorConsoleAgent::count):
    We generated a stack, pass it in.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
    Drop the URL parameter from the console message for X-Frame-Options
    parsing errors.
* page/Console.cpp:
(WebCore::Console::addMessage):
    When given a Document*, generate a line number if: 1) the document
    is still being parsed, 2) the document is not in document.write(),
    3) the parser isn't waiting for script, and 4) the parser isn't
    executing script. Many callsites didn't check all of these, which
    is why the SVG rebaseline (for example) drops lots and lots of line
    numbers which point at a closing '</script>' tag.
(WebCore):
* page/Console.h:
(WebCore):
(Console):
    Update the public API to accept a Document* and little else.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::printErrorMessage):
    Don't generate a stack here. We can do it later.
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
    Drop the URL and line number. We'll generate them. It'll be sweet.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addConsoleMessage):
    Generate a stack here, as we likely won't have the context to do
    so later. Pass it through.
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
    Implement the new addConsoleMessage variant.

LayoutTests:

New line numbers! Huzzah! (Also, removing some that shouldn't be there).

* http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
    One new stack trace! OMG!
* fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/xss-auditor-handles-file-urls-expected.txt:
* html5lib/run-test11-expected.txt:
* http/tests/misc/bubble-drag-events-expected.txt:
* http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* http/tests/misc/iframe-invalid-source-crash-expected.txt:
* http/tests/misc/image-blocked-src-change-expected.txt:
* http/tests/misc/image-blocked-src-no-change-expected.txt:
* http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* http/tests/security/frame-loading-via-document-write-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
* http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
* http/tests/security/xssAuditor/base-href-control-char-expected.txt:
* http/tests/security/xssAuditor/base-href-expected.txt:
* http/tests/security/xssAuditor/base-href-null-char-expected.txt:
* http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
* http/tests/security/xssAuditor/cookie-injection-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
* http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
* http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/embed-tag-expected.txt:
* http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/form-action-expected.txt:
* http/tests/security/xssAuditor/full-block-base-href-expected.txt:
* http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
* http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
* http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
* http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
* http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/get-from-iframe-expected.txt:
* http/tests/security/xssAuditor/iframe-injection-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
* http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
* http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
* http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
* http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
* http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
* http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
* http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
* http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-expected.txt:
* http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
* http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
* http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
* http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
* http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
* http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
* http/tests/security/xssAuditor/link-onclick-expected.txt:
* http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
* http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
* http/tests/security/xssAuditor/malformed-HTML-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
* http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-tag-expected.txt:
* http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/open-attribute-body-expected.txt:
* http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
* http/tests/security/xssAuditor/open-iframe-src-expected.txt:
* http/tests/security/xssAuditor/open-script-src-expected.txt:
* http/tests/security/xssAuditor/post-from-iframe-expected.txt:
* http/tests/security/xssAuditor/property-escape-comment-expected.txt:
* http/tests/security/xssAuditor/property-escape-entity-expected.txt:
* http/tests/security/xssAuditor/property-escape-expected.txt:
* http/tests/security/xssAuditor/property-escape-long-expected.txt:
* http/tests/security/xssAuditor/property-escape-quote-expected.txt:
* http/tests/security/xssAuditor/report-script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
* http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
* http/tests/security/xssAuditor/script-tag-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
* http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-expected.txt:
* http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
* http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
* platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
* platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
* platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
* svg/custom/invalid-length-units-expected.txt:
* svg/custom/poly-parsing-error-expected.txt:
* svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/path-parser-expected.txt:
* svg/dom/points-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 3 Dec 2012 10:21:18 +0000 (10:21 +0000)]
Unreviewed GTK gardening.

Adding a failure expectation for editing/selection/caret-alignment-for-vertical-text.html.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Remove an unnecessary masking from swapBgrToRgb()
rgabor@webkit.org [Mon, 3 Dec 2012 10:15:16 +0000 (10:15 +0000)]
[Qt] Remove an unnecessary masking from swapBgrToRgb()
https://bugs.webkit.org/show_bug.cgi?id=103630

Reviewed by Zoltan Herczeg.

Get rid of a masking command in swapBgrToRgb() to speed up a little bit.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::swapBgrToRgb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Accessibility gardening
commit-queue@webkit.org [Mon, 3 Dec 2012 10:01:29 +0000 (10:01 +0000)]
[EFL] Accessibility gardening
https://bugs.webkit.org/show_bug.cgi?id=103735

Unreviewed, EFL accessibility gardening.

Unskipping accessibility tests. Skipping failing ones.

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-12-03

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSS Device Adaptation: window.innerWidth returns wrong value if CSS viewport descript...
commit-queue@webkit.org [Mon, 3 Dec 2012 09:22:15 +0000 (09:22 +0000)]
CSS Device Adaptation: window.innerWidth returns wrong value if CSS viewport descriptors are applied
https://bugs.webkit.org/show_bug.cgi?id=103737

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-03
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

ViewportStyleResolver used frame view visibleContentRect size as initial viewport size.
This however caused a problem when page enabled/disabled CSS stylesheets, having viewport
descriptors. Viewport descriptors from new stylesheet were applied to the visibleContentRect
affected already by the viewport descriptors from the previous stylesheet.

New 'initialViewportSize' property (http://dev.w3.org/csswg/css-device-adapt/#initial-viewport)
was added to frame view so that viewport descriptors can always be applied to the reliable
viewport size.

Test: css3/device-adapt/viewport-width-check-window-innerwidth-correct.html

* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::ViewportStyleResolver):
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/ViewportStyleResolver.h:
(ViewportStyleResolver):
* dom/Document.cpp:
(WebCore):
(WebCore::Document::initialViewportSize):
* dom/Document.h:
(Document):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::initialViewportSize):
(WebCore::FrameView::setInitialViewportSize):

Source/WebKit2:

ViewportStyleResolver used frame view visibleContentRect size as initial viewport size.
This however caused a problem when page enabled/disabled CSS stylesheets, having viewport
descriptors. Viewport descriptors from new stylesheet were applied to the visibleContentRect
affected already by the viewport descriptors from the previous stylesheet.

New 'initialViewportSize' property (http://dev.w3.org/csswg/css-device-adapt/#initial-viewport)
was added to frame view so that viewport descriptors can always be applied to the reliable
viewport size.

Both newly added 'initialViewportSize' property and 'fixedVisibleContentRect' property
are assigned appropriately now in WebPage::sendViewportAttributesChanged().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

LayoutTests:

Added new test css3/device-adapt/viewport-width-check-window-innerwidth-correct.html.

* css3/device-adapt/viewport-width-check-window-innerwidth-correct-expected.txt: Added.
* css3/device-adapt/viewport-width-check-window-innerwidth-correct.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG should trigger rage conversion from double to contiguous if it sees a GetByVal...
fpizlo@apple.com [Mon, 3 Dec 2012 09:21:22 +0000 (09:21 +0000)]
DFG should trigger rage conversion from double to contiguous if it sees a GetByVal on Double being used in an integer context
https://bugs.webkit.org/show_bug.cgi?id=103858

Reviewed by Gavin Barraclough.

A rage conversion from double to contiguous is one where you try to convert each
double to an int32.

This is probably not the last we'll hear of rage conversion from double to contiguous.
It may be better to do this right during parsing, which will result in fewer cases of
Arrayification. But even so, this looks like a straight win already - 1% speed-up on
Kraken, no major regression anywhere else.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::arrayConversionToString):
(JSC::DFG::ArrayMode::dump):
(WTF):
(WTF::printInternal):
* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::withConversion):
(ArrayMode):
(JSC::DFG::ArrayMode::doesConversion):
(WTF):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNodeFlags.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::arrayify):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
* runtime/JSObject.cpp:
(JSC):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::rageConvertDoubleToContiguous):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::rageEnsureContiguousSlow):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::rageEnsureContiguous):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Use float variable for zoom levels for MiniBrowser
commit-queue@webkit.org [Mon, 3 Dec 2012 08:56:42 +0000 (08:56 +0000)]
[EFL][WK2] Use float variable for zoom levels for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=103863

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-03
Reviewed by Gyuyoung Kim.

Use float instead of int for zoomLevels variables for a clearer expression

* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Styles] Retain selector case as written in the source code
apavlov@chromium.org [Mon, 3 Dec 2012 08:51:07 +0000 (08:51 +0000)]
Web Inspector: [Styles] Retain selector case as written in the source code
https://bugs.webkit.org/show_bug.cgi?id=103118

Reviewed by Antti Koivisto.

Source/WebCore:

This change:
- adds parsing of selector group components in the CSSParser;
- builds the SelectorList.selectors based on the source code whenever possible.
  Strips [multiline] comments and whitespace;
- adds the MultilineMode to RegularExpression.

Test: inspector/styles/selector-list.html

* WebCore.exp.in: Update the exported symbol.
* css/CSSGrammar.y.in: Add invocations for CSSParser::markSelector[Start|End]() as required.
* css/CSSParser.cpp:
(WebCore::CSSParser::markSelectorStart): Gets invoked to mark a selector group item start offset.
(WebCore::CSSParser::markSelectorEnd): Ditto for the end offset.
* css/CSSParser.h: Add new methods and a SourceRange tracking field.
* css/CSSPropertySourceData.h: Add SelectorRangeList to the CSSRuleSourceData.
* inspector/InspectorStyleSheet.cpp:
(WebCore::selectorsFromSource): Builds the SelectorList based on the underlying source data.
Strips comments and whitespace from selectors.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
Builds SelectorList based on the availability of the source code.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._markSelectorMatches):
Update selectors in all cases to make use of the source-based information whenever possible.
* platform/text/RegularExpression.cpp:
Add the MultilineMode parameter into the constructor/factory method and ultimately pass it into YarrPattern.
(WebCore::RegularExpression::Private::create): See above.
(WebCore::RegularExpression::Private::Private): See above.
(WebCore::RegularExpression::Private::compile): See above.
(WebCore::RegularExpression::RegularExpression): See above.
* platform/text/RegularExpression.h:
Add enum MultilineMode, modify constructor and factory method signatures accordingly.

LayoutTests:

* inspector/styles/selector-list-expected.txt: Added.
* inspector/styles/selector-list.html: Added.
* inspector/styles/styles-add-new-rule-expected.txt: Rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Add support for a zoom level setting to MiniBrowser
commit-queue@webkit.org [Mon, 3 Dec 2012 07:58:40 +0000 (07:58 +0000)]
[EFL][WK2] Add support for a zoom level setting to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99285

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Gyuyoung Kim.

 Add support for a zoom level setting to MiniBrowser.
 Shortcuts for setting operations are same as common browsers:
 Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.

* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, WebKit2 gardening.
christophe.dumez@intel.com [Mon, 3 Dec 2012 07:47:33 +0000 (07:47 +0000)]
Unreviewed, WebKit2 gardening.

Skip storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html
on WebKit2 since testRunner.closeIdleLocalStorageDatabases() is not implemented yet.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
commit-queue@webkit.org [Mon, 3 Dec 2012 07:27:23 +0000 (07:27 +0000)]
Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Noam Rosenthal.

Send messages to the UI process by the tree order.
This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unskip fast/js/array-sort-modifying-tostring.html in release mode
commit-queue@webkit.org [Mon, 3 Dec 2012 06:54:04 +0000 (06:54 +0000)]
[EFL] Unskip fast/js/array-sort-modifying-tostring.html in release mode
https://bugs.webkit.org/show_bug.cgi?id=103850

Unreviewed, EFL gardening.

This case has been passed in release mode, whereas crashed occasionally in debug mode.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-02

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImageOrientation::transformFromDefault() case labels should be in numerical order
noel.gordon@gmail.com [Mon, 3 Dec 2012 06:24:56 +0000 (06:24 +0000)]
ImageOrientation::transformFromDefault() case labels should be in numerical order
https://bugs.webkit.org/show_bug.cgi?id=101596

Reviewed by Simon Fraser.

Place the orientation case labels in numerical order to better match the EXIF2.2 spec
definitions of orientation values and their ImageOrientation.h enumeration.

No change in behavior. Covered by existing tests:
   fast/images/exif-orientation-css.html
   fast/images/exif-orientation-image-document.html
   fast/images/exif-orientation.html

* platform/graphics/ImageOrientation.cpp:
(WebCore::ImageOrientation::transformFromDefault): Numerically order the orientation
case statement labels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, webkit gardening. Rebaseline of fast/css/font-weight-1.
tasak@google.com [Mon, 3 Dec 2012 06:13:09 +0000 (06:13 +0000)]
Unreviewed, webkit gardening. Rebaseline of fast/css/font-weight-1.

* platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Added.
* platform/chromium-mac/fast/css/font-weight-1-expected.png: Added.
* platform/chromium-mac/fast/css/font-weight-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime...
commit-queue@webkit.org [Mon, 3 Dec 2012 05:23:56 +0000 (05:23 +0000)]
[chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html is failing on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=103817

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-02
Reviewed by Kent Tamura.

Adding initial value to the datetime input. Without it, the test fails
because calendar picker opens current month.

* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, webkit gardening.
tasak@google.com [Mon, 3 Dec 2012 05:04:09 +0000 (05:04 +0000)]
Unreviewed, webkit gardening.
https://bugs.webkit.org/show_bug.cgi?id=103834

* platform/chromium/TestExpectations:
Mark month-multiple-fields-keyboard-events.html as FAIL for WinXP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoshould sniff it if mimetype don't contain a slash.
mary.wu@torchmobile.com.cn [Mon, 3 Dec 2012 03:30:25 +0000 (03:30 +0000)]
should sniff it if mimetype don't contain a slash.
https://bugs.webkit.org/show_bug.cgi?id=102778

Reviewed by George Staikos.

Based on http://mimesniff.spec.whatwg.org/, a valid media type
is the string represented by concatenating type, the string "/",
and subtype. So if the mimetype don't contain slash, we should
possible get sniffed type from the content like Firefox/chrome/safari.

RIM Bug# 219590, internally reviewed by Liam Quinn.

No new tests, the patch only impact qt/blackberry porting to be consistent
with chrome, other portings have their own behavior.

* platform/network/MIMESniffing.cpp:
(std::isUnknownType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG CSE should not keep alive things that aren't relevant to OSR
fpizlo@apple.com [Mon, 3 Dec 2012 03:12:08 +0000 (03:12 +0000)]
DFG CSE should not keep alive things that aren't relevant to OSR
https://bugs.webkit.org/show_bug.cgi?id=103849

Reviewed by Oliver Hunt.

Most Phantom nodes are inserted by CSE, and by default have the same children as the
node that CSE had eliminated. This change makes CSE inspect all Phantom nodes (both
those it creates and those that were created by other phases) to see if they have
children that are redundant - i.e. children that are not interesting to OSR, which
is the only reason why Phantoms exist in the first place. Being relevant to OSR is
defined as one of: (1) you're a Phi, (2) you're a SetLocal, (3) somewhere between
your definition and the Phantom there was a SetLocal that referred to you.

This is a slight speed-up in a few places.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performSubstitution):
(CSEPhase):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Update comments of header files which mentions deprecated API
ryuan.choi@samsung.com [Mon, 3 Dec 2012 02:30:04 +0000 (02:30 +0000)]
[EFL][WK2] Update comments of header files which mentions deprecated API
https://bugs.webkit.org/show_bug.cgi?id=103718

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-12-02
Reviewed by Gyuyoung Kim.

Updated comments which mentions XXX_unref() which was replaced to ewk_object_unref()

* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_database_manager.h:
* UIProcess/API/efl/ewk_storage_manager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK1] Change AC bug url appropriately
commit-queue@webkit.org [Mon, 3 Dec 2012 02:08:46 +0000 (02:08 +0000)]
[EFL][WK1] Change AC bug url appropriately
https://bugs.webkit.org/show_bug.cgi?id=103808

Unreviewed, EFL gardening.

From https://bugs.webkit.org/show_bug.cgi?id=103488 to https://bugs.webkit.org/show_bug.cgi?id=103847

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-02

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIt should be possible to build and run with DFG_ENABLE(PROPAGATION_VERBOSE)
fpizlo@apple.com [Mon, 3 Dec 2012 01:59:42 +0000 (01:59 +0000)]
It should be possible to build and run with DFG_ENABLE(PROPAGATION_VERBOSE)
https://bugs.webkit.org/show_bug.cgi?id=103848

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Fix random dataLog() and print() statements.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpBlockHeader):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):

Source/WTF:

Increase the variadicity of dataLog() and print(), and add a pointerDump()
which allows passing a pointer to something that has a printInternal(). If
the pointer is null, it'll print "(null)"; otherwise it'll invoke the
printInternal() function.

* wtf/DataLog.h:
(WTF):
(WTF::dataLog):
* wtf/PrintStream.h:
(PrintStream):
(WTF::PrintStream::print):
(WTF):
(PointerDump):
(WTF::PointerDump::PointerDump):
(WTF::PointerDump::dump):
(WTF::pointerDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, webkit gardening, fix webkit lint.
tasak@google.com [Mon, 3 Dec 2012 01:46:27 +0000 (01:46 +0000)]
Unreviewed, webkit gardening, fix webkit lint.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r134376): ASSERT(!m_mainBackingStore) hits in CoordinatedGraphicsLayer...
commit-queue@webkit.org [Mon, 3 Dec 2012 00:45:10 +0000 (00:45 +0000)]
REGRESSION(r134376): ASSERT(!m_mainBackingStore) hits in CoordinatedGraphicsLayer::syncImageBacking().
https://bugs.webkit.org/show_bug.cgi?id=103845

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Noam Rosenthal.

flushCompositingStateForThisLayerOnly() calls syncImageBacking() before calling
updateContentBuffers(). It means there can be the moment that
CoordinatedGraphicsLayer has m_mainBackingStore although
shouldHaveBackingStore() return false.
This patch changes syncImageBacking() to check shouldHaveBackingStore() instead
of m_mainBackingStore.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore):
(WebCore):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename WebSocketServerGtk.cpp as WebSocketServerSoup.cpp
commit-queue@webkit.org [Mon, 3 Dec 2012 00:21:45 +0000 (00:21 +0000)]
Rename WebSocketServerGtk.cpp as WebSocketServerSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=103743

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-02
Reviewed by Gustavo Noronha Silva.

EFL port is using a GSocket based implementation as well.
WebSocketServerSoup can be used together.

* GNUmakefile.list.am:
* UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp: Renamed from Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp.
(WebKit):
(WebKit::connectionCallback):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
commit-queue@webkit.org [Sun, 2 Dec 2012 23:43:04 +0000 (23:43 +0000)]
[EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
https://bugs.webkit.org/show_bug.cgi?id=103835

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Kentaro Hara.

Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGarden-o-matic shouldn't die when blank JSON results are received.
mkwst@chromium.org [Sun, 2 Dec 2012 21:18:38 +0000 (21:18 +0000)]
Garden-o-matic shouldn't die when blank JSON results are received.
https://bugs.webkit.org/show_bug.cgi?id=103838

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
    If the JSONP string doesn't contain '(' or ')', return an empty object.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
    Check that this behavior stays in place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agorun-perf-tests --profile should use iprofiler instead of instruments on Mac
eric@webkit.org [Sun, 2 Dec 2012 20:48:09 +0000 (20:48 +0000)]
run-perf-tests --profile should use iprofiler instead of instruments on Mac
https://bugs.webkit.org/show_bug.cgi?id=103765

Unreviewed.  Updating the unittests after my previous change.

* Scripts/webkitpy/common/system/profiler_unittest.py:
(ProfilerFactoryTest.test_basic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
commit-queue@webkit.org [Sun, 2 Dec 2012 20:29:13 +0000 (20:29 +0000)]
[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=103748

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-02
Reviewed by Rob Buis.

The logic is flipped in the previous patch.

* loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::cookiesEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Correct the location of synthetic mouse events when page is zoomed
commit-queue@webkit.org [Sun, 2 Dec 2012 19:56:07 +0000 (19:56 +0000)]
[chromium] Correct the location of synthetic mouse events when page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=103823

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-12-02
Reviewed by Adam Barth.

Source/WebKit/chromium:

The event-location conversion function expects absolute locations. Change the
function name to reflect that, and use the absolute location of the touch-points
when converting from touch events.

* src/WebInputEventConversion.cpp:
(WebKit::convertAbsoluteLocationForRenderObject):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

LayoutTests:

* platform/chromium/plugins/touch-events-synthesized-expected.txt:
* platform/chromium/plugins/touch-events-synthesized.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead code in flakiness dashboard for obsolete buildDir option
jparent@chromium.org [Sun, 2 Dec 2012 18:49:57 +0000 (18:49 +0000)]
Remove dead code in flakiness dashboard for obsolete buildDir option
https://bugs.webkit.org/show_bug.cgi?id=103792

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/dashboard_base.js:
(initBuilders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBad rendering of web page because of image's height is set to 100%
robert@webkit.org [Sun, 2 Dec 2012 17:25:18 +0000 (17:25 +0000)]
Bad rendering of web page because of image's height is set to 100%
https://bugs.webkit.org/show_bug.cgi?id=28035

Reviewed by Eric Seidel.

Source/WebCore:

Call computeReplacedLogicalHeight() to get the correct logical height of a replaced element
for calculating the element's width. RenderBox::computeLogicalHeightUsing() is a helper function designed for finding
the min and max height values and is not the way to find the actual used height of a replaced element.

WebKit's quirks-mode behaviour for the test case is unaffected by this change.

Tests: fast/css/computed-image-width-with-percent-height-quirksmode.html
       fast/css/computed-image-width-with-percent-height.html

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):

LayoutTests:

* fast/css/computed-image-width-with-percent-height-expected.html: Added.
* fast/css/computed-image-width-with-percent-height-quirksmode-expected.html: Added.
* fast/css/computed-image-width-with-percent-height-quirksmode.html: Added.
* fast/css/computed-image-width-with-percent-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] regionlayoutupdate event fires continuously
mihnea@adobe.com [Sun, 2 Dec 2012 15:35:24 +0000 (15:35 +0000)]
[CSS Regions] regionlayoutupdate event fires continuously
https://bugs.webkit.org/show_bug.cgi?id=102101

Reviewed by David Hyatt.

Source/WebCore:

According to the CSSRegions spec, http://dev.w3.org/csswg/css3-regions/#region-flow-layout-events, the regionlayoutupdate event
should be dispatched when there is a possible layout change in the region chain.
In the current implementation, regionlayoutupdate is dispatched when:
1. a region from region chain changed its regionOverset value
2. a region from region chain has regionOverset = fit| overset

In the case of a named flow having an auto-height region with regionOverset = fit, the second step of layout was done
also when there was not required, therefore the regionlayoutuodate was unnecessary triggered.

We should proceed with the 2-pass layout only if the flow-thread having auto-height regions in region chain needs layout.

Test: fast/regions/autoheight-regionlayoutupdate-multipletimes.html

* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::hasRenderNamedFlowThreadsNeedingLayout):
* rendering/FlowThreadController.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):

LayoutTests:

Add a test to make sure that for a flow thread with auto-height region, the regionlayoutupdate event is not unnecessary triggered.

* fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt: Added.
* fast/regions/autoheight-regionlayoutupdate-multipletimes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agonrwt: clean up logic for retrying failed tests a bit
dpranke@chromium.org [Sun, 2 Dec 2012 13:22:32 +0000 (13:22 +0000)]
nrwt: clean up logic for retrying failed tests a bit
https://bugs.webkit.org/show_bug.cgi?id=103829

Reviewed by Ojan Vafai.

The code for determining when to retry test failures and
show the results.html file was awkward and could stand some
cleaning up. This patch should have no functional changes.

The routine called _get_failures() returned a dict of test names
to failure types, but we only ever used the names, so I've converted
it to return a list (and renamed it); also, the show_results_html()
file was calling that routine to figure out if anything failed, when
the information was already in the result_summary (as either
unexpected_results or total_failures), so we were doing unnecessary work.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager.run):
(Manager._run_tests):
(Manager._failed_test_names):
(Manager._copy_results_html_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agonrwt: remove unused methods in manager.py
dpranke@chromium.org [Sun, 2 Dec 2012 13:12:40 +0000 (13:12 +0000)]
nrwt: remove unused methods in manager.py
https://bugs.webkit.org/show_bug.cgi?id=103828

Reviewed by Eric Seidel.

These two methods weren't being called by anything and were no
longer needed.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._get_failures):
(Manager._upload_json_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Create an enum for the kind of date input and use that on WebDateTimeChoos...
commit-queue@webkit.org [Sun, 2 Dec 2012 13:09:17 +0000 (13:09 +0000)]
[Chromium] Create an enum for the kind of date input and use that on WebDateTimeChooserParams instead of a bare WebString
https://bugs.webkit.org/show_bug.cgi?id=103746

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-12-02
Reviewed by Kent Tamura.

Using an enum makes the chromium part much simpler and prevents makes sure that new items are added explicitly.

* WebKit.gyp:
* public/WebDateTimeChooserParams.h:
(WebDateTimeChooserParams):
* public/WebDateTimeInputType.h: Copied from Source/WebKit/chromium/public/WebTextInputType.h.
(WebKit):
* public/WebTextInputType.h:
* public/WebViewClient.h:
(WebViewClient):
* src/ExternalDateTimeChooser.cpp:
(WebKit::ExternalDateTimeChooser::openDateTimeChooser):
(WebKit::ExternalDateTimeChooser::webType):
(WebKit):
* src/ExternalDateTimeChooser.h:
(ExternalDateTimeChooser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::find...
christophe.dumez@intel.com [Sun, 2 Dec 2012 13:00:22 +0000 (13:00 +0000)]
[CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::find() twice
https://bugs.webkit.org/show_bug.cgi?id=103815

Reviewed by Noam Rosenthal.

Call HashMap::take() in LayerTreeRenderer::removeImageBacking()
to avoid calling HashMap::find() twice. find() was called once
explicitly to get an iterator and a second time to remove the
value from the value from the HashMap. We could have used
remove(iterator) instead of remove(key) but using take() results
in simpler code.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::removeImageBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Images disappear randomly
commit-queue@webkit.org [Sun, 2 Dec 2012 12:49:09 +0000 (12:49 +0000)]
Coordinated Graphics: Images disappear randomly
https://bugs.webkit.org/show_bug.cgi?id=103522

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Currently, we delete layers before synchronizing layer states of layers. It
causes flash. This patch deletes layers after the synchronization.

In addiation, this patch removes updateViewport() in
LayerTreeCoordinatorProxy::deleteCompositingLayer() because
LayerTreeCoordinatorProxy::didRenderFrame() is always called after
deleting layers.

* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCorrect the spelling of the cmakeargs argument
commit-queue@webkit.org [Sun, 2 Dec 2012 12:43:24 +0000 (12:43 +0000)]
Correct the spelling of the cmakeargs argument
https://bugs.webkit.org/show_bug.cgi?id=103814

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-02
Reviewed by Darin Adler.

The script expects cmakeargs (plural), so lets get the
documentation of the script report the same.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[gtk] Enable the CSP_NEXT runtime flag.
mkwst@chromium.org [Sun, 2 Dec 2012 12:40:17 +0000 (12:40 +0000)]
[gtk] Enable the CSP_NEXT runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=103810

Reviewed by Adam Barth.

Source/WebKit/gtk:

This patch adds methods to DumpRenderTreeSupport in order to ensure that
CSP 1.1 features are enabled when running DRT tests in the GTK port.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
    Turn on the CSP_NEXT runtime flag when running tests under GTK.

LayoutTests:

* platform/gtk/TestExpectations:
    Unskipping CSP 1.1 tests for GTK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Unreviewed gardening.
mkwst@chromium.org [Sun, 2 Dec 2012 12:38:22 +0000 (12:38 +0000)]
[chromium] Unreviewed gardening.

Skipping failing tests on mac.

* platform/chromium/TestExpectations:
    Mark fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html
    and widening fast/css/font-weight-1.html to include 'Mac'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExtend JavaScript support for blending in canvas
commit-queue@webkit.org [Sun, 2 Dec 2012 12:22:29 +0000 (12:22 +0000)]
Extend JavaScript support for blending in canvas
https://bugs.webkit.org/show_bug.cgi?id=101804

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-02
Reviewed by Dirk Schulze.

Source/WebCore:

Added parsing code and variables to support additional canvas blend modes
see spec: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#canvascompositingandblending

Test: canvas/philip/tests/2d.composite.globalComposite.html

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::globalCompositeOperation):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* html/canvas/CanvasRenderingContext2D.h:
(State):
* platform/graphics/GraphicsTypes.cpp:
(WebCore):
(WebCore::parseCompositeAndBlendOperator):
(WebCore::compositeOperatorName):
* platform/graphics/GraphicsTypes.h:

LayoutTests:

Added a test that checks that all blendingmodes are supported

* canvas/philip/tests/2d.composite.globalComposite-expected.txt: Added.
* canvas/philip/tests/2d.composite.globalComposite.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows, WinCairo] Revise export definitions to match mac.
bfulgham@webkit.org [Sun, 2 Dec 2012 12:11:00 +0000 (12:11 +0000)]
[Windows, WinCairo] Revise export definitions to match mac.
https://bugs.webkit.org/show_bug.cgi?id=103687

Reviewed by Tim Horton.

Update export definition files to use the same feature exclusion
macros as other generated ports.

* win/WebKit2.def.in: Added additional build macro guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Fix build warning in GraphicsContext3DEfl.cpp
commit-queue@webkit.org [Sun, 2 Dec 2012 12:09:31 +0000 (12:09 +0000)]
[EFL] Fix build warning in GraphicsContext3DEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=103807

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Laszlo Gombos.

Because GraphicsContext3D::ImageExtractor::extractImage is not implemented yet,
comment out the parameter names for removing -Wunused-parameter warnings.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoKeep ElementAttributeData sharing cache open for a while after document parsing finishes.
akling@apple.com [Sun, 2 Dec 2012 12:03:44 +0000 (12:03 +0000)]
Keep ElementAttributeData sharing cache open for a while after document parsing finishes.
<http://webkit.org/b/103720>

Reviewed by Antti Koivisto.

Allow web pages that generate content dynamically to benefit more from the ElementAttributeData sharing
cache by keeping it open for 10 seconds after document parsing finishes. This enables elements constructed
from HTML fragments to share attribute data with other identical elements.

Elements created via Document.createElement are still unsupported since we don't know the list of attributes
at the time of construction.

401kB progression on Membuster3.

Document now holds on to a DocumentSharedObjectPool, accessible via Document::sharedObjectPool().
It is non-null during parsing and for some time afterwards, and can be used to implement additional
caches that are not worth holding on to permanently.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:

    Add new class DocumentSharedObjectPool.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setParsing):
(WebCore::Document::finishedParsing):
(WebCore::Document::sharedObjectPoolClearTimerFired):
* dom/Document.h:
(WebCore::Document::sharedObjectPool):

    Create DocumentSharedObjectPool when parsing starts, kill it on a 10s timer after parsing finishes.

* dom/DocumentSharedObjectPool.cpp: Added.
(ImmutableElementAttributeDataCacheKey):
(WebCore::ImmutableElementAttributeDataCacheKey::ImmutableElementAttributeDataCacheKey):
(WebCore::ImmutableElementAttributeDataCacheKey::operator!=):
(WebCore::ImmutableElementAttributeDataCacheKey::hash):
(ImmutableElementAttributeDataCacheEntry):
(WebCore::ImmutableElementAttributeDataCacheEntry::ImmutableElementAttributeDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedImmutableElementAttributeData):
(WebCore::DocumentSharedObjectPool::DocumentSharedObjectPool):
(WebCore::DocumentSharedObjectPool::~DocumentSharedObjectPool):
* dom/DocumentSharedObjectPool.h: Added.
(DocumentSharedObjectPool):
(WebCore::DocumentSharedObjectPool::create):
* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):

    Moved the ElementAttributeData cache to DocumentSharedObjectPool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-histor...
tkent@chromium.org [Sun, 2 Dec 2012 11:56:17 +0000 (11:56 +0000)]
[Chromium] fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96720

* platform/chromium/TestExpectations: Mark them Slow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Let Pepper Flash use integrated GPU
commit-queue@webkit.org [Sun, 2 Dec 2012 11:54:22 +0000 (11:54 +0000)]
[chromium] Let Pepper Flash use integrated GPU
https://bugs.webkit.org/show_bug.cgi?id=103800

Patch by John Bauman <jbauman@chromium.org> on 2012-12-02
Reviewed by Kenneth Russell.

Pepper Flash uses the SharedGraphicsContext3D as a parent, so don't
require that to use the discrete GPU. This means that accelerated
canvas will use the integrated GPU, but that will save battery life
and seems acceptable.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::createContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agodocumentElement should not always get a renderer
commit-queue@webkit.org [Sun, 2 Dec 2012 11:38:01 +0000 (11:38 +0000)]
documentElement should not always get a renderer
https://bugs.webkit.org/show_bug.cgi?id=103475

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-02
Reviewed by Ojan Vafai.

Source/WebCore:

Only SVG documents need a renderer on the documentElement when it's
display: none. This behavior is wrong, but there's assumptions in
FrameView and SVGImage that depend on a RenderSVGRoot existing for all
loaded SVG document and images.

The current code has logic that makes it appear as if we always create
a renderer for the documentElement even when it's display: none, but
because HTMLElement::createRenderer doesn't call super we end up with
HTMLElement::rendererIsNeeded returning true for display: none, but
HTMLElement::createRenderer returning null.

Instead of this generic documentElement logic only special case SVG
until someone can fix Bug 103493 so we don't need it.

Test: fast/css/display-none-documentElement.html

* dom/Element.cpp:
(WebCore::Element::rendererIsNeeded):
(WebCore::Element::createRenderer):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::rendererIsNeeded):
* svg/SVGSVGElement.h:
(SVGSVGElement):

LayoutTests:

Test that using display: none on the documentElement hides the document.

* fast/css/display-none-documentElement-expected.html: Added.
* fast/css/display-none-documentElement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry]Tap highlight
commit-queue@webkit.org [Sun, 2 Dec 2012 11:30:50 +0000 (11:30 +0000)]
[BlackBerry]Tap highlight
https://bugs.webkit.org/show_bug.cgi?id=103787

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-12-02
Reviewed by Rob Buis.

RIM PR 248626
Internally Reviewed by Genevieve Mak.

Draw tap highlight as soon as tap on element.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [Resource Timing] implementation of cross origin resouce timing restr...
commit-queue@webkit.org [Sun, 2 Dec 2012 11:23:04 +0000 (11:23 +0000)]
Source/WebCore: [Resource Timing] implementation of cross origin resouce timing restrictions.
https://bugs.webkit.org/show_bug.cgi?id=84886.

Patch by Pan Deng <pan.deng@intel.com> on 2012-12-02
Reviewed by Tony Gentilcore.

This patch implemented resource timing behaviors of cross origin. By default, detailed timing info is hided in cross origin resource timing, only startTime, duration, fetchStart and responseEnd can be observed. Exceptions are, server side allow its origin can be timing by another through a header with "timing-allow-origin" field.

Tests: http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html
       http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html

* page/Performance.cpp:
(WebCore::passesTimingAllowCheck):
(WebCore):
(WebCore::Performance::addResourceTiming):
* page/Performance.h:
(WebCore):
(Performance):
* page/PerformanceResourceTiming.cpp:
(WebCore):
* page/PerformanceResourceTiming.h:
(WebCore::PerformanceResourceTiming::create):
(PerformanceResourceTiming):

LayoutTests: [Resource Timing]Test cases of cross origin resource timing.
https://bugs.webkit.org/show_bug.cgi?id=84886.

Patch by Pan Deng <pan.deng@intel.com> on 2012-12-02
Reviewed by Tony Gentilcore.

Test cases in this patch validate resource timing behavior when cross origin request with/without "allow-timing-origin" response header.

* http/tests/w3c/webperf/resources/blank_page_green_with_allow_timing.php: Added.
* http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request-expected.txt: Added.
* http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html: Added.
* http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request-expected.txt: Added.
* http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify treeScope and setTreeScope
commit-queue@webkit.org [Sun, 2 Dec 2012 11:16:33 +0000 (11:16 +0000)]
Simplify treeScope and setTreeScope
https://bugs.webkit.org/show_bug.cgi?id=103708

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-02
Reviewed by Hajime Morita.

By making the default treeScope in NodeRareData the document and then
moving the m_treeScope field to NodeRareDataBase we can make treeScope
inline and make setTreeScope much simpler.

There's also no reason to save calls to rareData() now that the map has
been eliminated by r133372 so we can eliminate the return value from
setTreeScope.

No new tests, just refactoring.

* WebCore.exp.in:
* dom/Document.h:
(WebCore::Node::treeScope):
(WebCore):
* dom/Element.cpp:
(WebCore::Element::createRareData):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::setTreeScope):
(WebCore::Node::createRareData):
* dom/Node.h:
(NodeRareDataBase):
(WebCore::NodeRareDataBase::treeScope):
(WebCore::NodeRareDataBase::setTreeScope):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(Node):
* dom/NodeRareData.cpp:
(WebCore::NodeRareData::reportMemoryUsage):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agorun-perf-tests --profile should use iprofiler instead of instruments on Mac
eric@webkit.org [Sun, 2 Dec 2012 11:00:13 +0000 (11:00 +0000)]
run-perf-tests --profile should use iprofiler instead of instruments on Mac
https://bugs.webkit.org/show_bug.cgi?id=103765

Reviewed by Ryosuke Niwa.

Stephanie pointed out that iprofiler is the newer command-line interface
to replace /usr/bin/instruments in Instruments 4 (which according to the
interblags is supported on everything since 10.6.6), so I've moved --profile
to use iprofiler on Mac.

I also made the IProfiler class wait for iprofiler to complete so that
iprofiler won't continue running after run-perf-tests is complete (and
spam over the top of your shell output).

There are a couple of "got-chas" to this approach:
1.  iprofiler will ask for your password the first time you run it, which may
    cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
    directory and basename arguments, making IProfiler a somewhat awkward
    baseclass of SingleFileOutputProfiler

I suspect we'll iterate from here.  It does seem slightly faster than
/usr/bin/instruments was.

* Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(IProfiler):
(IProfiler.__init__):
(IProfiler.attach_to_pid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix occlusion culling logic to handle css background layer clipping
junov@google.com [Sun, 2 Dec 2012 10:55:24 +0000 (10:55 +0000)]
Fix occlusion culling logic to handle css background layer clipping
https://bugs.webkit.org/show_bug.cgi?id=103276

Reviewed by Simon Fraser.

Source/WebCore:

Bug was introduced by r135629
This patch fixes it by verifying layer clip.  A fill layer must
not be treated as if it occludes the layers under it unless it has
a larger or equal clip setting than the layers under it.

Test: fast/backgrounds/background-opaque-clipped-gradients.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/style/FillLayer.cpp:
(WebCore::clipMax):
(WebCore::FillLayer::computeClipMax):
(WebCore::FillLayer::clipOccludesNextLayers):
* rendering/style/FillLayer.h:
(FillLayer):

LayoutTests:

New ref test that verifies the superposition of background layers with
the layers having smaller clip regions than the layers beneath them.
This test ensures the bottom layers are not removed by culling
optimizations.

* fast/backgrounds/background-opaque-clipped-gradients-expected.html: Added.
* fast/backgrounds/background-opaque-clipped-gradients.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] make sourceDevice available to more WebGestureEvent subtypes
rjkroege@chromium.org [Sun, 2 Dec 2012 10:42:17 +0000 (10:42 +0000)]
[chromium] make sourceDevice available to more WebGestureEvent subtypes
https://bugs.webkit.org/show_bug.cgi?id=103551

Reviewed by James Robinson.

Added an additional data payload to WebGestureEvent that can
contain the source device (touchpad or touchscreen).

* public/WebInputEvent.h:
* src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid a second layout of flex items in layoutAndPlaceChildren()
tony@chromium.org [Sun, 2 Dec 2012 10:39:51 +0000 (10:39 +0000)]
Avoid a second layout of flex items in layoutAndPlaceChildren()
https://bugs.webkit.org/show_bug.cgi?id=102352

Reviewed by Ojan Vafai.

Source/WebCore:

Avoid doing a second layout if we're going to get the same size as before.
This prevents us from doing an exponential number of layouts in some
common cases.

Test: css3/flexbox/stretch-after-sibling-size-change.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout): Force a layout of the track, which positions the thumb.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::needToStretchChild): Determine if a child is going to stretch.
(WebCore::RenderFlexibleBox::resetAutoMarginsAndLogicalTopInCrossAxis): Makes sure we're in a consistent state before
we apply auto margins.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
* rendering/RenderFlexibleBox.h: Add needToStretchChild.

LayoutTests:

Add a test case to make sure we relayout when a sibling is stretching.

* css3/flexbox/stretch-after-sibling-size-change-expected.txt: Added.
* css3/flexbox/stretch-after-sibling-size-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNeed a method to close all idle localstorage databases immediately.
commit-queue@webkit.org [Sun, 2 Dec 2012 10:31:42 +0000 (10:31 +0000)]
Need a method to close all idle localstorage databases immediately.
https://bugs.webkit.org/show_bug.cgi?id=103469

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-12-02
Reviewed by David Kilzer.

Source/WebCore:

Add a new PageGroup method closeIdleLocalStorageDatabases, which walks through
all local storage areas that don't have document referencing to them and closes
their underlying databases.

Test: storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html

* WebCore.exp.in:
* page/PageGroup.cpp:
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore):
(WebCore::PageGroup::closeIdleLocalStorageDatabases): walking through all idle local storages and
    closing their databases.
* page/PageGroup.h:
(PageGroup):
* storage/StorageArea.h:
(WebCore::StorageArea::closeDatabaseIfIdle):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::closeDatabaseIfIdle): close the database if it is idle.
(WebCore):
* storage/StorageAreaImpl.h:
(StorageAreaImpl):
* storage/StorageNamespace.h:
(StorageNamespace):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::closeIdleLocalStorageDatabases):
(WebCore):
* storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):

Source/WebKit/mac:

Add a new method to WebStorageManager that we can call to close all
idle local storage databases.

* Storage/WebStorageManager.mm:
(+[WebStorageManager closeIdleLocalStorageDatabases]):
* Storage/WebStorageManagerPrivate.h:

Tools:

Add an JS method to TestRunner, to enable testing closing idle local storage databases in
DumpRenderTree layout tests.

* DumpRenderTree/TestRunner.cpp:
(closeIdleLocalStorageDatabasesCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::closeIdleLocalStorageDatabases):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::closeIdleLocalStorageDatabases):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::closeIdleLocalStorageDatabases):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::closeIdleLocalStorageDatabases):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::closeIdleLocalStorageDatabases):
* DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::closeIdleLocalStorageDatabases):

LayoutTests:

* storage/domstorage/localstorage/close-idle-localstorage-databases-immediately-expected.txt: Added.
* storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html: Added.
* storage/resources/storage-close-idle-localstorage-databases-immediately.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CoordinatedGraphics] Crash in TextureMapperLayer::setBackingStore()
commit-queue@webkit.org [Sun, 2 Dec 2012 10:29:38 +0000 (10:29 +0000)]
[CoordinatedGraphics] Crash in TextureMapperLayer::setBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=103714

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Remove a layer from the m_pendingSyncBackingStores map when it is deleted.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::deleteLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
commit-queue@webkit.org [Sun, 2 Dec 2012 10:27:33 +0000 (10:27 +0000)]
[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=103748

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-02
Reviewed by Rob Buis.

Updating CookieJarBlackBerry::cookieEnabled and have other methods in the class call that
method. Also, adding null checks for document->settings().

No change in behaviour.

* loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::cookieRequestHeaderFieldValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] MiniBrowser should have a legacy mode
commit-queue@webkit.org [Sun, 2 Dec 2012 10:12:47 +0000 (10:12 +0000)]
[EFL][WK2] MiniBrowser should have a legacy mode
https://bugs.webkit.org/show_bug.cgi?id=103679

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

We need a way to create a web view in legacy mode, while still using the default context.
WKViewCreate creates a legacy view, so change it to create a default context if a context
was not passed.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):

Tools:

Add an option to start MiniBrowser in legacy mode.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r136236.
mkwst@chromium.org [Sun, 2 Dec 2012 09:45:48 +0000 (09:45 +0000)]
Unreviewed, rolling out r136236.
http://trac.webkit.org/changeset/136236
https://bugs.webkit.org/show_bug.cgi?id=103833

[chromium] Flakey crashes in SpeechRecognitionEvent::emma
during GC. (Requested by mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-02

Source/WebCore:

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognitionEvent.cpp:
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
* Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):
* Modules/speech/SpeechRecognitionEvent.idl:
* Modules/speech/SpeechRecognitionResult.cpp:
(WebCore::emmaQualifiedName):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):
* Modules/speech/SpeechRecognitionResult.h:
(WebCore):
(WebCore::SpeechRecognitionResult::final):
(SpeechRecognitionResult):
* Modules/speech/SpeechRecognitionResult.idl:
* WebCore.gypi:
* bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8SpeechRecognitionEventCustom.cpp.
(WebCore):
(WebCore::V8SpeechRecognitionResult::opaqueRootForGC):

Source/WebKit/chromium:

* public/WebSpeechRecognizerClient.h:
* src/SpeechRecognitionClientProxy.cpp:
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):

Tools:

* DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

LayoutTests:

* fast/speech/scripted/emma-expected.txt:
* fast/speech/scripted/emma.html:
* fast/speech/scripted/speechrecognition-basics-expected.txt:
* fast/speech/scripted/speechrecognition-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCodeBlock should be able to dump bytecode to something other than WTF::dataFile()
fpizlo@apple.com [Sun, 2 Dec 2012 08:00:14 +0000 (08:00 +0000)]
CodeBlock should be able to dump bytecode to something other than WTF::dataFile()
https://bugs.webkit.org/show_bug.cgi?id=103832

Reviewed by Oliver Hunt.

Add a PrintStream& argument to all of the CodeBlock bytecode dumping methods.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecodeCommentAndNewLine):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dumpBytecode):
* bytecode/CodeBlock.h:
(CodeBlock):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpForInstructions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPDFPlugin: Support PDF form editing in <iframe>s
timothy_horton@apple.com [Sun, 2 Dec 2012 07:55:26 +0000 (07:55 +0000)]
PDFPlugin: Support PDF form editing in <iframe>s
https://bugs.webkit.org/show_bug.cgi?id=103287
<rdar://problem/10326917>

Reviewed by Dan Bernstein.

PDFPlugin form editing depends on having a Document that has the same
size and position as the plugin; this is true not only in the full-main-frame
case, but also in the <iframe> case. Therefore, we can enable form editing
for <iframe> PDFPlugins.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::supportsForms): Support form editing whenever
our Document's widget is our PluginView (which will only be true in the
full-main-frame or <iframe> case).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
timothy_horton@apple.com [Sun, 2 Dec 2012 07:51:36 +0000 (07:51 +0000)]
PDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
https://bugs.webkit.org/show_bug.cgi?id=103286
<rdar://problem/12752315>

Reviewed by Dan Bernstein.

Detecting whether or not a PDFPlugin is a full-page plugin or not is not
as simple as checking isMainFrame(), because <embed> and <object> will
cause PDFPlugin to live in the main frame, while still not being full-page.
We also have to check that the main frame's document is a PluginDocument,
and whether that PluginDocument's PluginWidget is our PDFPlugin's PluginView.

* WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add isFullFramePlugin.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::isFullFramePlugin): Check whether the main frame is
backed by a PluginDocument, and that that PluginDocument corresponds
to this PDFPlugin.
(WebKit::PDFPlugin::handlesPageScaleFactor): Use isFullFramePlugin.
(WebKit::PDFPlugin::supportsForms): Use isFullFramePlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] Use spoolRect instead of snapshots for print preview
timothy_horton@apple.com [Sun, 2 Dec 2012 07:44:46 +0000 (07:44 +0000)]
[wk2] Use spoolRect instead of snapshots for print preview
https://bugs.webkit.org/show_bug.cgi?id=103798
<rdar://problem/12686749>

Reviewed by Sam Weinig.

Revert to using spoolRect instead of snapshotting for printing; this was a bogus
change I made in http://trac.webkit.org/changeset/133935 which was irrelevant to
the core of that change, and incorrectly disregards the Frame parameter passed to
beginPrinting, instead using the WebPage's current Frame.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
zandobersek@gmail.com [Sun, 2 Dec 2012 07:06:01 +0000 (07:06 +0000)]
[XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
https://bugs.webkit.org/show_bug.cgi?id=103806

Reviewed by Dirk Pranke.

There are occasional mishaps on builders where XvfbDriver doesn't properly
clean up the Xvfb instance it was managing so the related guard lock files
are still existing when the webkitpy unit tests are run. This can cause failures
in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
with a specific number but is unable to due to the stale locks.

The solution to this is to use MockFileLock when inside unit test. This is achievable
by creating a file lock through the SystemHost instance connected to the Port object,
the latter available to the Driver.

* Scripts/webkitpy/common/system/file_lock_mock.py:
(MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
(MockFileLock.release_lock): Return True to signal lock releasing succeeded.
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._next_free_display): Create the file lock through a mockable way.
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.test_next_free_display): Enable back the unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r136015.
abarth@webkit.org [Sun, 2 Dec 2012 00:31:21 +0000 (00:31 +0000)]
Unreviewed, rolling out r136015.
http://trac.webkit.org/changeset/136015
https://bugs.webkit.org/show_bug.cgi?id=103821

Did not heal performance bot and caused other performance
regressions (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-01

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Unreviewed gardening. Skipping crashing tests.
mkwst@chromium.org [Sat, 1 Dec 2012 21:33:11 +0000 (21:33 +0000)]
[chromium] Unreviewed gardening. Skipping crashing tests.

The DEPS roll containing r170422 is causing three crashes cross-platform
in the Chromium port. Skipping them here, filed crbug.com/163785 to fix.

* platform/chromium/TestExpectations:
    Marked media/encrypted-media/encrypted-media-events.html,
    media/encrypted-media/encrypted-media-not-loaded.html, and
    media/encrypted-media/encrypted-media-syntax.html as crashing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Unreviewed gardening. Skipping calendar-picker-datetime-with-step.html.
mkwst@chromium.org [Sat, 1 Dec 2012 20:00:26 +0000 (20:00 +0000)]
[chromium] Unreviewed gardening. Skipping calendar-picker-datetime-with-step.html.

It looks like platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html
started failing at midnight PST, December 1st. I don't think it handled
the month change correctly. Filed https://bugs.webkit.org/show_bug.cgi?id=103817
to cover the fix.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDRT - crashed in WebCore::SearchFieldCancelButtonElement::defaultEventHandler
commit-queue@webkit.org [Sat, 1 Dec 2012 12:39:25 +0000 (12:39 +0000)]
DRT - crashed in WebCore::SearchFieldCancelButtonElement::defaultEventHandler
https://bugs.webkit.org/show_bug.cgi?id=103592

Patch by Xiaobo Wang <xiaobo.wang@torchmobile.com.cn> on 2012-12-01
Reviewed by Kent Tamura.

The crash happened when the search field cancel button handles mouseout
event after the search input was detached. When it happens the input
element returned from shadowHost() is null, need to check the pointer
before dereferencing.
InputFieldSpeechButton and SearchFieldResultsButtonElement have the
similar issue.

No new tests. The patch fixes the following test on BlackBerry platform.
Test: fast/forms/search-delete-while-cancel-button-clicked.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] A11y tests in WK2 report badly-formatted AX roles
zandobersek@gmail.com [Sat, 1 Dec 2012 11:09:27 +0000 (11:09 +0000)]
[GTK] A11y tests in WK2 report badly-formatted AX roles
https://bugs.webkit.org/show_bug.cgi?id=102947

Reviewed by Xan Lopez.

As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
These are expected in both tests and their baselines.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::roleToString):
(WTR):
(WTR::AccessibilityUIElement::role):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[gtk] Unreviewed gardening. Skipping CSP 1.1 tests.
mkwst@chromium.org [Sat, 1 Dec 2012 08:33:59 +0000 (08:33 +0000)]
[gtk] Unreviewed gardening. Skipping CSP 1.1 tests.

The CSP 1.1 tests are failing under GTK after r136305 made the CSP_NEXT
flag runtime enabled. Will fix in webkit.org/b/103810, skipping for now.

* platform/gtk/TestExpectations:
    Skipping CSP 1.1 tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShorten a file name as the test renamed in r136122 is still hosing Chromium Win perf...
rniwa@webkit.org [Sat, 1 Dec 2012 07:09:46 +0000 (07:09 +0000)]
Shorten a file name as the test renamed in r136122 is still hosing Chromium Win perf. bot.

* http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Renamed.
* http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Removed.
* http/tests/inspector/network/script-as-text-loading-long-url.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSP 1.1: Make the CSP_NEXT flag runtime enabled.
mkwst@chromium.org [Sat, 1 Dec 2012 06:53:25 +0000 (06:53 +0000)]
CSP 1.1: Make the CSP_NEXT flag runtime enabled.
https://bugs.webkit.org/show_bug.cgi?id=103652

Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy 1.1 continues to live behind the CSP_NEXT flag,
this patch adds another layer on top of that in order to enable runtime
decisions about whether it should be active.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
    Adds methods in order to correctly handle enabling and disabling
    CSP 1.1 features.
* dom/Document.idl:
    Gate the 'document.securityPolicy' object on the runtime flag.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::addDirective):
    Check that experimental features are runtime enabled before
    processing 1.1 directives.
(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled):
(WebCore):
* page/ContentSecurityPolicy.h:
    Adds a new method which checks against the runtime flag to determine
    whether CSP 1.1 features are enabled.

Source/WebKit/chromium:

The CSP_NEXT flag continues to be enabled on the Chromium port, but this
patch now locks the features away behind the securityPolicy runtime
flag.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures):
(WebKit):
(WebKit::WebRuntimeFeatures::isExperimentalContentSecurityPolicyFeaturesEnabled):
    Adds the feature to WebRuntimeFeatures so it can be toggled from
    inside Chromium.

Tools:

Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK1] Gardening test cases which are not crashed after r135662
ryuan.choi@samsung.com [Sat, 1 Dec 2012 06:18:59 +0000 (06:18 +0000)]
[EFL][WK1] Gardening test cases which are not crashed after r135662
https://bugs.webkit.org/show_bug.cgi?id=103803

Unreviewed, EFL gardening.

Patch by Sujin Park <sujjin.park@gmail.com> on 2012-11-30

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling into NSUserDefaults every time we start a scroll
simon.fraser@apple.com [Sat, 1 Dec 2012 06:12:31 +0000 (06:12 +0000)]
Avoid calling into NSUserDefaults every time we start a scroll
https://bugs.webkit.org/show_bug.cgi?id=103804

Reviewed by Dan Bernstein.

Cache the NSScrollAnimationEnabled preference to avoid
hitting NSUserDefaults every time we start scrolling.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAlways listen for the DidFirstLayout layout milestone
andersca@apple.com [Sat, 1 Dec 2012 02:24:18 +0000 (02:24 +0000)]
Always listen for the DidFirstLayout layout milestone
https://bugs.webkit.org/show_bug.cgi?id=103795
<rdar://problem/12790268>

Reviewed by Dan Bernstein.

The DidFirstLayout layout milestone is used to determine when to unfreeze the layer tree, so we always want to listen for it.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Removed temporary debugging change from DRT (r136300).
roger_fong@apple.com [Sat, 1 Dec 2012 01:40:35 +0000 (01:40 +0000)]
Unreviewed. Removed temporary debugging change from DRT (r136300).

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Temporary change to DRT for debugging purposes.
roger_fong@apple.com [Sat, 1 Dec 2012 01:23:11 +0000 (01:23 +0000)]
Unreviewed. Temporary change to DRT for debugging purposes.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed speculative Mac build fix after r136232
pierre.rossi@gmail.com [Sat, 1 Dec 2012 01:19:09 +0000 (01:19 +0000)]
[Qt] Unreviewed speculative Mac build fix after r136232

Source/JavaScriptCore:

Update the include path so that LLIntAssembly.h is picked up.
The bot didn't break until later when a clean build was triggered.

* JavaScriptCore.pri:

Source/WebKit2:

cleanup an oversight from r136235

* PluginProcess.pro: s/webkit/webkitwidgets/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=103790
bdakin@apple.com [Sat, 1 Dec 2012 00:53:01 +0000 (00:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=103790
The LayerPool m_pruneTimer should have a longer delay

Reviewed by Simon Fraser.

A 1 second delay is more appropriate here.
* platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::schedulePrune):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimise more cases of op_typeof
oliver@apple.com [Sat, 1 Dec 2012 00:50:39 +0000 (00:50 +0000)]
Optimise more cases of op_typeof
https://bugs.webkit.org/show_bug.cgi?id=103783

Reviewed by Mark Hahnenberg.

Increase our coverage of typeof based typechecks by
making sure that the codegenerators always uses
consistent operand ordering when feeding typeof operations
into equality operations.

* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
(JSC::StrictEqualNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Windows build fix.
jer.noble@apple.com [Sat, 1 Dec 2012 00:43:08 +0000 (00:43 +0000)]
Unreviewed Windows build fix.

Add a default: entry to an case statement to fix a build error when compiled in VS2005.

* html/MediaController.cpp:
(MediaController::playbackState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136296 268f45cc-cd09-0410-ab3c-d52691b4dbfc