WebKit-https.git
7 years ago[Qt] Make it possible to build without QtQuick
hausmann@webkit.org [Tue, 7 Aug 2012 15:04:25 +0000 (15:04 +0000)]
[Qt] Make it possible to build without QtQuick

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-08-07
Reviewed by Simon Hausmann.

.:

* Source/QtWebKit.pro:
* Source/tests.pri:

Source/WebKit:

* WebKit1.pri:

Source/WebKit2:

* Target.pri:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.cpp:
* UIProcess/API/qt/tests/util.h:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):
* WebKit2.pri:

Tools:

* Tools.pro:
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in InlineFlowBox::deleteLine.
inferno@chromium.org [Tue, 7 Aug 2012 14:51:33 +0000 (14:51 +0000)]
Crash in InlineFlowBox::deleteLine.
https://bugs.webkit.org/show_bug.cgi?id=88795

Reviewed by Tony Chang.

Source/WebCore:

When we move the fullscreen object from its parent to RenderFullScreen, we forgot to clear the
line box tree underneath the object's containing block and mark it for layout. Before the patch,
the containing block never got laid out and maintained references to removed line boxes (since the
object moved under RenderFullScreen did get laid out and its lineboxes replaced with new ones).

Test: fullscreen/full-screen-line-boxes-crash.html

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):

LayoutTests:

* fullscreen/full-screen-line-boxes-crash-expected.txt: Added.
* fullscreen/full-screen-line-boxes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update API for spell checking suggestions.
mifenton@rim.com [Tue, 7 Aug 2012 14:32:15 +0000 (14:32 +0000)]
[BlackBerry] Update API for spell checking suggestions.
https://bugs.webkit.org/show_bug.cgi?id=93356

Reviewed by Antonio Gomes.

PR 163283.

Add connections for updated spell checking options request API.  Move
all this logic into InputHandler.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
* WebKitSupport/InputHandler.h:
(Platform):
(InputHandler):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Do not disable network tracking while profiling cpu.
vsevik@chromium.org [Tue, 7 Aug 2012 13:52:42 +0000 (13:52 +0000)]
Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 7 Aug 2012 13:52:02 +0000 (13:52 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make the MemoryClassInfo class a not-template
commit-queue@webkit.org [Tue, 7 Aug 2012 13:50:52 +0000 (13:50 +0000)]
Web Inspector: make the MemoryClassInfo class a not-template
https://bugs.webkit.org/show_bug.cgi?id=93265

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-08-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
* bindings/v8/V8DOMMap.h:
* css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportDescendantMemoryUsage):
* css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
* css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportDescendantMemoryUsage):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportDescendantMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportBaseClassMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportDescendantMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
* css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/Element.h:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGColor.cpp:
(WebCore::SVGColor::reportDescendantMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial fix: Missed HAVE_QT5 removal as part of r124879
hausmann@webkit.org [Tue, 7 Aug 2012 13:10:05 +0000 (13:10 +0000)]
Unreviewed trivial fix: Missed HAVE_QT5 removal as part of r124879

Fixes failing auto-test.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::enumerate_data):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove duplicated platform test expectations
commit-queue@webkit.org [Tue, 7 Aug 2012 13:02:42 +0000 (13:02 +0000)]
[GTK] Remove duplicated platform test expectations
https://bugs.webkit.org/show_bug.cgi?id=93352

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-07
Reviewed by Martin Robinson.

Remove platform test expectations that are the same as the global
expectations.

* platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Removed.
* platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
* platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5780697-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
* platform/gtk/editing/selection/after-line-break-expected.txt: Removed.
* platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Removed.
* platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
* platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
* platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
* platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
* platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
* platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
* platform/gtk/fast/backgrounds/svg-as-mask-expected.txt: Removed.
* platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
* platform/gtk/fast/block/positioning/start-ignoring-before-expected.txt: Removed.
* platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDashed01-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDashed02-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDashed03-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDotted01-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDotted02-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusDotted03-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusSolid01-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusSolid02-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusSolid03-expected.txt: Removed.
* platform/gtk/fast/borders/borderRadiusSolid04-expected.txt: Removed.
* platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
* platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
* platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Removed.
* platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
* platform/gtk/fast/css/font-face-cache-bug-expected.txt: Removed.
* platform/gtk/fast/css/font-face-repeated-url-expected.txt: Removed.
* platform/gtk/fast/css/font-family-pictograph-expected.txt: Removed.
* platform/gtk/fast/css/hsla-color-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
* platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
* platform/gtk/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
* platform/gtk/fast/dynamic/float-at-line-break-expected.txt: Removed.
* platform/gtk/fast/dynamic/unicode-bidi-expected.txt: Removed.
* platform/gtk/fast/forms/implicit-submission-expected.txt: Removed.
* platform/gtk/fast/forms/onselect-textarea-expected.txt: Removed.
* platform/gtk/fast/html/details-position-expected.txt: Removed.
* platform/gtk/fast/lists/inline-before-content-after-list-marker-expected.txt: Removed.
* platform/gtk/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
* platform/gtk/fast/reflections/reflection-masks-expected.txt: Removed.
* platform/gtk/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
* platform/gtk/fast/ruby/float-overhang-from-ruby-text-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-horizontal-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-vertical-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-vertical-no-overlap1-expected.txt: Removed.
* platform/gtk/fast/ruby/overhang-vertical-no-overlap2-expected.txt: Removed.
* platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.
* platform/gtk/fast/ruby/ruby-remove-no-base-expected.txt: Removed.
* platform/gtk/fast/ruby/ruby-text-before-child-split-expected.txt: Removed.
* platform/gtk/fast/runin/runin-div-before-child-expected.txt: Removed.
* platform/gtk/fast/runin/runin-into-div-with-float-child-expected.txt: Removed.
* platform/gtk/fast/runin/runin-not-go-into-float-expected.txt: Removed.
* platform/gtk/fast/runin/runin-table-before-child-expected.txt: Removed.
* platform/gtk/fast/table/max-width-integer-overflow-expected.txt: Removed.
* platform/gtk/fast/text/justify-nbsp-expected.txt: Removed.
* platform/gtk/fast/text/setData-dirty-lines-expected.txt: Removed.
* platform/gtk/fast/text/splitText-dirty-lines-expected.txt: Removed.
* platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
* platform/gtk/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Removed.
* platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Removed.
* platform/gtk/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
* platform/gtk/svg/custom/getSubStringLength-expected.txt: Removed.
* platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
* platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt: Removed.
* platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
* platform/gtk/svg/dom/altGlyph-dom-expected.txt: Removed.
* platform/gtk/svg/dom/css-transforms-expected.txt: Removed.
* platform/gtk/svg/hixie/links/001-expected.txt: Removed.
* platform/gtk/svg/text/small-fonts-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline.
toyoshim@chromium.org [Tue, 7 Aug 2012 12:52:27 +0000 (12:52 +0000)]
Unreviewed, rebaseline.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-07

* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add new baselines after r124754
commit-queue@webkit.org [Tue, 7 Aug 2012 12:45:39 +0000 (12:45 +0000)]
[EFL] Add new baselines after r124754
https://bugs.webkit.org/show_bug.cgi?id=93350

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-07

* platform/efl/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
* platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
* platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
* platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
* platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove Qt 4 specific code paths
hausmann@webkit.org [Tue, 7 Aug 2012 12:06:52 +0000 (12:06 +0000)]
[Qt] Remove Qt 4 specific code paths
https://bugs.webkit.org/show_bug.cgi?id=88161

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/api.pri:
* WebKit.pro:

Source/WebCore:

* Target.pri:
* WebCore.pri:
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getPropertyNames):
(JSC::Bindings::QtInstance::stringValue):
(JSC::Bindings::QtField::setValueToInstance):
* bridge/qt/qt_runtime.h:
(QtConnectionObject):
* bridge/qt/qt_runtime_qt4.cpp: Removed.
* editing/qt/SmartReplaceQt.cpp: Removed.
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::tabsToAllFormControls):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
* platform/graphics/OpenGLShims.h:
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::create):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):
* platform/qt/DeviceMotionProviderQt.h:
* platform/qt/DeviceOrientationProviderQt.h:
* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/qt/QWebPageClient.h:
(QWebPageClient):
* platform/qt/RenderThemeQt.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp: Removed.
* plugins/qt/PluginContainerQt.cpp: Removed.
* plugins/qt/PluginContainerQt.h: Removed.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::isPluginBlacklisted):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setFocus):
(WebCore::PluginView::paintUsingXPixmap):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):
* plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):

Source/WebKit:

* WebKit.pri:
* WebKit1.pri:
* WebKit1.pro:

Source/WebKit/qt:

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::sceneEvent):
* Api/qgraphicswebview.h:
* Api/qwebframe.cpp:
* Api/qwebframe.h:
* Api/qwebframe_p.h:
* Api/qwebpage.cpp:
(QWebPage::event):
* Api/qwebpage.h:
* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):
* Api/qwebview.cpp:
(QWebView::QWebView):
(QWebView::event):
* Api/qwebview.h:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.h:
* WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget):
(QWebPageClient::ownerWindow):
* WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
* declarative/declarative.pro:
* declarative/plugin.cpp:
* declarative/public.pri:
* examples/platformplugin/WebPlugin.cpp:
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
(WebPlugin):
* examples/platformplugin/platformplugin.pro:
* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::arrayObjectEnumerable):
(tst_QObjectBridge::ownership):
(tst_QObjectBridge::qObjectWrapperWithSameIdentity):
* tests/tests.pri:
* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
(gatherAPI):
* WebKit2.pri:

Source/WTF:

* WTF.pri:
* WTF.pro:
* wtf/qt/StringQt.cpp:
(WTF::String::String):
(WTF::String::operator QString):
* wtf/qt/UtilsQt.h: Removed.
* wtf/qt/compat/QGuiApplication: Removed.
* wtf/qt/compat/qguiapplication.h: Removed.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::touchCancel):
(EventSender::sendTouchEvent):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
* DumpRenderTree/qt/ImageDiff.pro:
* DumpRenderTree/qt/main.cpp:
(main):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::setDiskCache):
* qmake/configure.pri:
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/functions.prf:
* qmake/mkspecs/features/qtwebkit.prf: Removed.
* qmake/mkspecs/features/unix/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: implement reusable progress bar
caseq@chromium.org [Tue, 7 Aug 2012 11:52:32 +0000 (11:52 +0000)]
Web Inspector: implement reusable progress bar
https://bugs.webkit.org/show_bug.cgi?id=93267

Source/WebCore:

- Generic progress bar implementation to be used
    by various long-running operations in inspector.

Test: inspector/progress-bar.html

Reviewed by Pavel Feldman.

* WebCore.gypi: Added ProgressBar.js
* WebCore.vcproj/WebCore.vcproj: ditto.
* inspector/compile-front-end.py: ditto.
* inspector/front-end/AdvancedSearchController.js: renamed style for stop button.
(WebInspector.SearchView):
* inspector/front-end/ProgressBar.js: Added.
(WebInspector.Progress): Interface for both ProgressIndicator and SubProgress.
(WebInspector.Progress.prototype.setTotalWork):
(WebInspector.Progress.prototype.setTitle):
(WebInspector.Progress.prototype.setWorked):
(WebInspector.Progress.prototype.done):
(WebInspector.Progress.prototype.isCanceled):
(WebInspector.ProgressIndicator): A UI control that implements Progress.
(WebInspector.ProgressIndicator.prototype.show):
(WebInspector.ProgressIndicator.prototype.hide):
(WebInspector.ProgressIndicator.prototype.done):
(WebInspector.ProgressIndicator.prototype._cancel):
(WebInspector.ProgressIndicator.prototype.isCanceled):
(WebInspector.ProgressIndicator.prototype.setTitle):
(WebInspector.ProgressIndicator.prototype.setTotalWork):
(WebInspector.ProgressIndicator.prototype.setWorked):
(WebInspector.CompositeProgress): A progress bar that is composed of several SubProgress bars and uses a Progress to display total progress of all tasks.
(WebInspector.CompositeProgress.prototype._childDone):
(WebInspector.CompositeProgress.prototype.createSubProgress):
(WebInspector.CompositeProgress.prototype._update):
(WebInspector.SubProgress): A child of CompositeProgress, implements Progress interface.
(WebInspector.SubProgress.prototype.isCanceled):
(WebInspector.SubProgress.prototype.setTitle):
(WebInspector.SubProgress.prototype.done):
(WebInspector.SubProgress.prototype.setTotalWork):
(WebInspector.SubProgress.prototype.setWorked):
* inspector/front-end/WebKit.qrc: Added ProgressBar.js
* inspector/front-end/inspector.css:
(.progress-bar-stop-button-item):
(.progress-bar-stop-button .glyph):
(.progress-bar-container):
(.progress-bar-container span):
(.progress-bar-container progress):
(.progress-bar-container button.status-bar-item):
* inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/progress-bar-expected.txt: Added.
* inspector/progress-bar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
abecsi@webkit.org [Tue, 7 Aug 2012 11:34:46 +0000 (11:34 +0000)]
[Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
https://bugs.webkit.org/show_bug.cgi?id=93277

Reviewed by Jocelyn Turcotte.

MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
when registering multiple touch points based on pressed mouse buttons
and sends inconsistent touch events to the WebView which triggers an
assert in the pinch gesture recognizer.
MiniBrowserApplication::updateTouchPoint should only register multiple
touch points if the Ctrl button is pressed else it should ignore the
update request.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::updateTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: display function scope in UI
commit-queue@webkit.org [Tue, 7 Aug 2012 11:28:24 +0000 (11:28 +0000)]
Web Inspector: display function scope in UI
https://bugs.webkit.org/show_bug.cgi?id=90631

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-08-07
Reviewed by Yury Semikhatsky.

Two new tree element types added: function scope group node and scope node.
Scope node is only used to represent closure and catch scopes. Scopes that
have a real object beneath are represented as a property node.
A method that reads properties from RemoteObject and populate tree element
is factored out from RemoteObjectTreeElement for reuse.

* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.Populate.callback):
(WebInspector.ObjectPropertyTreeElement.Populate):
(WebInspector.FunctionScopeMainTreeElement):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.FunctionScopeMainTreeElement.prototype.onattach):
(WebInspector.FunctionScopeMainTreeElement.prototype.update):
(WebInspector.ScopeTreeElement):
(WebInspector.ScopeTreeElement.prototype.onpopulate):
(WebInspector.ScopeTreeElement.prototype.onattach):
(WebInspector.ScopeTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObjectProperty.fromScopeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add back forward list API
commit-queue@webkit.org [Tue, 7 Aug 2012 10:46:14 +0000 (10:46 +0000)]
[EFL][WK2] Add back forward list API
https://bugs.webkit.org/show_bug.cgi?id=92345

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-07
Reviewed by Kenneth Rohde Christiansen.

Added new Back Forward list API to EFL WK2. Ewk_Back_Forward_List and
Ewk_Back_Forward_List_Item structures were added. The new API is
mostly the same as one from UIProcess/API/C/{ WKBackForwardList.h, WKBackForwardListItem.h }.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_back_forward_list.cpp: Added.
(_Ewk_Back_Forward_List):
(_Ewk_Back_Forward_List::_Ewk_Back_Forward_List):
(getOrCreateItem):
(webkit_back_forward_list_current_item_get):
(webkit_back_forward_list_back_item_get):
(webkit_back_forward_list_forward_item_get):
(webkit_back_forward_list_item_at_index_get):
(webkit_back_forward_list_length_get):
(ewk_back_forward_list_changed):
(ewk_back_forward_list_new):
(ewk_back_forward_list_free):
* UIProcess/API/efl/ewk_back_forward_list.h: Added.
* UIProcess/API/efl/ewk_back_forward_list_item.cpp: Added.
(getItemProperty):
(_Ewk_Back_Forward_List_Item):
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(_Ewk_Back_Forward_List_Item::~_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_ref):
(ewk_back_forward_list_item_unref):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):
(ewk_back_forward_list_item_new):
* UIProcess/API/efl/ewk_back_forward_list_item.h: Added.
* UIProcess/API/efl/ewk_back_forward_list_item_private.h: Added.
* UIProcess/API/efl/ewk_back_forward_list_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_back_forward_list_get): New function to get back-forward list.
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didChangeBackForwardList): The callback added to update back-forward list items cache.
(ewk_view_loader_client_attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Rebased affected subpixel-sensitive tests after r124745.
allan.jensen@nokia.com [Tue, 7 Aug 2012 10:26:55 +0000 (10:26 +0000)]
Unreviewed gardening. Rebased affected subpixel-sensitive tests after r124745.

* fast/multicol/nested-columns-expected.txt:
* fast/multicol/span/anonymous-split-block-crash-expected.txt:
* fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
* platform/chromium-linux/fast/css/input-search-padding-expected.png:
* platform/chromium-linux/fast/css/input-search-padding-expected.txt:
* platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-linux/fast/multicol/nested-columns-expected.png:
* platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-mac/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/nested-columns-expected.txt:
* platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-win/fast/css/input-search-padding-expected.png:
* platform/chromium-win/fast/css/input-search-padding-expected.txt:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-win/fast/multicol/nested-columns-expected.png:
* platform/chromium-win/fast/multicol/nested-columns-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/fast/multicol/nested-columns-expected.txt: Removed.
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt: Removed.
* platform/gtk/fast/multicol/nested-columns-expected.txt: Removed.
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
* platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
ossy@webkit.org [Tue, 7 Aug 2012 10:12:15 +0000 (10:12 +0000)]
[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Unreviewed gardening, remove unnecessary expected files and unskip now passing tests after r124808.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/editing/deleting/5144139-2-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/4806874-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/pasteboard/input-field-1-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.png: Removed.
* platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-align-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-align-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/table/003-expected.png: Removed.
* platform/qt-5.0-wk2/fast/table/003-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove custom toV8() calls for TypedArray.
commit-queue@webkit.org [Tue, 7 Aug 2012 09:27:36 +0000 (09:27 +0000)]
[V8] Remove custom toV8() calls for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93248

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-07
Reviewed by Kentaro Hara.

With the support of [TypedArray] we can remove the custom calls toV8().
TypedArray spec : http://www.khronos.org/registry/typedarray/specs/latest/#7

Tests: TestTypedArray.idl
Tests under below folders should pass as this does not cause any behavioral changes.
       fast/canvas/webgl
       compositing/webgl

* bindings/js/JSInt8ArrayCustom.cpp:
* bindings/js/JSUint8ArrayCustom.cpp:
* bindings/js/JSUint8ClampedArrayCustom.cpp:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation): Modified Generator code to generate bindings for toV8().
(IsWrapperType):
(GetTypeNameOfExternalTypedArray): Method to get view type of TypedArray.
* bindings/scripts/test/V8/V8Float64Array.cpp: Tests results.
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp: Removed custom call toV8().
* bindings/v8/custom/V8Float64ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Int16ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Int32ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Int8ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Uint16ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Uint32ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Uint8ArrayCustom.cpp: Ditto.
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Ditto.
* html/canvas/Int8Array.idl: Using TypedArray.
* html/canvas/Uint8Array.idl: Ditto.
* html/canvas/Uint8ClampedArray.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Remove pthreads linkage
hausmann@webkit.org [Tue, 7 Aug 2012 09:24:21 +0000 (09:24 +0000)]
[Qt][Win] Remove pthreads linkage

Reviewed by Csaba Osztrogon√°c.

After r124823 linkage to pthreads is not needed anymore for the Windows
build.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
ossy@webkit.org [Tue, 7 Aug 2012 09:15:12 +0000 (09:15 +0000)]
REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=93346

Rubber-stamped by Simon Hausmann.

Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_retrying_and_flaky_tests):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_unexpected_results):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor emit*Inst functions and introduce toARMWord functions in DFG-JIT's tradition...
commit-queue@webkit.org [Tue, 7 Aug 2012 08:50:43 +0000 (08:50 +0000)]
Refactor emit*Inst functions and introduce toARMWord functions in DFG-JIT's traditional ARM port
https://bugs.webkit.org/show_bug.cgi?id=93266

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-07
Reviewed by Csaba Osztrogon√°c.

First part of a bigger refactoring issue trying to make traditional
ARM DFG-JIT port easier to read and understand.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::emitInstruction):
(JSC::ARMAssembler::emitDoublePrecisionInstruction):
(JSC::ARMAssembler::emitSinglePrecisionInstruction):
(JSC::ARMAssembler::and_r):
(JSC::ARMAssembler::ands_r):
(JSC::ARMAssembler::eor_r):
(JSC::ARMAssembler::eors_r):
(JSC::ARMAssembler::sub_r):
(JSC::ARMAssembler::subs_r):
(JSC::ARMAssembler::rsb_r):
(JSC::ARMAssembler::rsbs_r):
(JSC::ARMAssembler::add_r):
(JSC::ARMAssembler::adds_r):
(JSC::ARMAssembler::adc_r):
(JSC::ARMAssembler::adcs_r):
(JSC::ARMAssembler::sbc_r):
(JSC::ARMAssembler::sbcs_r):
(JSC::ARMAssembler::rsc_r):
(JSC::ARMAssembler::rscs_r):
(JSC::ARMAssembler::tst_r):
(JSC::ARMAssembler::teq_r):
(JSC::ARMAssembler::cmp_r):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::orr_r):
(JSC::ARMAssembler::orrs_r):
(JSC::ARMAssembler::mov_r):
(JSC::ARMAssembler::movw_r):
(JSC::ARMAssembler::movt_r):
(JSC::ARMAssembler::movs_r):
(JSC::ARMAssembler::bic_r):
(JSC::ARMAssembler::bics_r):
(JSC::ARMAssembler::mvn_r):
(JSC::ARMAssembler::mvns_r):
(JSC::ARMAssembler::mul_r):
(JSC::ARMAssembler::muls_r):
(JSC::ARMAssembler::mull_r):
(JSC::ARMAssembler::vmov_f64_r):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vabs_f64_r):
(JSC::ARMAssembler::vneg_f64_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::dtrh_d):
(JSC::ARMAssembler::dtrh_dr):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::vmov_vfp64_r):
(JSC::ARMAssembler::vmov_arm64_r):
(JSC::ARMAssembler::vmov_vfp32_r):
(JSC::ARMAssembler::vmov_arm32_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vcvt_u32_f64_r):
(JSC::ARMAssembler::vcvt_f64_f32_r):
(JSC::ARMAssembler::vcvt_f32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::toARMWord):
(ARMAssembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Tue, 7 Aug 2012 08:44:58 +0000 (08:44 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [regression r121673] restore link between the command and the result.
vsevik@chromium.org [Tue, 7 Aug 2012 08:39:00 +0000 (08:39 +0000)]
Web Inspector: [regression r121673] restore link between the command and the result.
https://bugs.webkit.org/show_bug.cgi?id=93280

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-08-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Passing lost parameter along.

Test: inspector/console/console-originating-command.html

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.runScript.runCallback):
(WebInspector.ConsoleView.prototype.runScript):
(WebInspector.ConsoleView.prototype._printResult):

LayoutTests:

* http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
* inspector/console/console-originating-command-expected.txt: Added.
* inspector/console/console-originating-command.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
commit-queue@webkit.org [Tue, 7 Aug 2012 08:33:53 +0000 (08:33 +0000)]
CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=93081

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-07
Reviewed by Adam Barth.

Source/WebCore:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
The whole NavigatorRegisterProtocolHandler interface is conditional on REGISTER_PROTOCOL_HANDLER
CUSTOM_SCHEME_HANDLER-specific methods only are conditional on CUSTOM_SCHEME_HANDLER.

No new tests. No new functionality is added.

* Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
* Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:
(NavigatorRegisterProtocolHandler):
* Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl:
* Modules/protocolhandler/RegisterProtocolHandlerClient.h:

Source/WebKit:

Modified PlatformEfl.cmake so that CUSTOM_SCHEME_HANDLER flag cannot act without REGISTER_PROTOCOL_HANDLER being set.

* PlatformEfl.cmake:

Source/WebKit/efl:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.

* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
* WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
* ewk/ewk_custom_handler.cpp:
(ewk_custom_handler_register_protocol_handler):
* ewk/ewk_custom_handler_private.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

Source/WebKit2:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.

* WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h:
(WebRegisterProtocolHandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
commit-queue@webkit.org [Tue, 7 Aug 2012 08:16:37 +0000 (08:16 +0000)]
IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-07
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.
commit-queue@webkit.org [Tue, 7 Aug 2012 08:15:43 +0000 (08:15 +0000)]
[EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.
https://bugs.webkit.org/show_bug.cgi?id=90927

Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-08-07
Reviewed by Kentaro Hara.

Add ewk_view_find_client.h / files for wrapping WKPageSetPageFindClient,
add didFindString callback member of WKPageSetPageFindClient.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_text_found):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_find_client.cpp: Added.
(toEwkView):
(didFindString):
(ewk_view_find_client_attach):
* UIProcess/API/efl/ewk_view_find_client_private.h: Added.
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move some inspector tests into TestExpectations
commit-queue@webkit.org [Tue, 7 Aug 2012 07:48:55 +0000 (07:48 +0000)]
[EFL] Move some inspector tests into TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=92884

Unreviewed gardening.

New baselines after r123703.

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-08-07

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] runs platform specific tests that it shouldn't with --force
kbalazs@webkit.org [Tue, 7 Aug 2012 07:45:37 +0000 (07:45 +0000)]
[NRWT] runs platform specific tests that it shouldn't with --force
https://bugs.webkit.org/show_bug.cgi?id=91089

Reviewed by Dirk Pranke.

Ignore other platform's directories from platform/.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._expanded_paths):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_platform_tests_are_found):
Updated integration test in accordance to the new behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 7 Aug 2012 07:41:57 +0000 (07:41 +0000)]
Unreviewed GTK gardening.

Rebaselining after r124697. Also skipping two modal dialog tests that
take 30 seconds to run but are expected to fail.

* platform/gtk/TestExpectations:
* platform/gtk/fast/css/nested-layers-with-hover-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
joone@webkit.org [Tue, 7 Aug 2012 07:12:16 +0000 (07:12 +0000)]
Unreviewed EFL gardening.

Marked the following test cases as known failures
tracked by the bug 93228.

inspector/debugger/debugger-activation-crash2.html
inspector/debugger/debugger-set-breakpoint-regex.html
inspector/debugger/pause-in-internal-script.html
inspector/debugger/script-formatter-breakpoints.html
inspector/debugger/set-breakpoint.html
inspector/debugger/watch-expressions-panel-switch.html

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: itemType[index] must be undefined for out-of-range index.
arko@motorola.com [Tue, 7 Aug 2012 07:00:09 +0000 (07:00 +0000)]
Microdata: itemType[index] must be undefined for out-of-range index.
https://bugs.webkit.org/show_bug.cgi?id=92988

Reviewed by Kentaro Hara.

Source/WebCore:

Made changes in IndexedGetter property so that it returns undefined
for out-of-range index.
Spec: http://www.w3.org/TR/WebIDL/#idl-indexed-properties
Firefox and Opera's behavior is consistent with the spec. Both returns
undefined for out-of-range index.

Also renamed the function name collectionStringOrNullIndexedPropertyGetter and
setCollectionStringOrNullIndexedGetter to collectionStringOrUndefinedIndexedPropertyGetter
and setCollectionStringOrUndefinedIndexedGetter respectively.

Test: fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
* bindings/v8/V8Collection.h:
(WebCore::collectionStringOrUndefinedIndexedPropertyGetter):
(WebCore::setCollectionStringOrUndefinedIndexedGetter):

LayoutTests:

Added a test to verify itemType[index], itemRef[index], itemProp[index]
behavior for out-of-range index.

Rebased existing test cases for IndexedGetter property.

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
* fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
* fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Added.
* fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Added.
* fast/dom/StyleSheet/css-medialist-item-expected.txt:
* fast/dom/StyleSheet/script-tests/css-medialist-item.js:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/resources/database-basics.js:
(createObjectStore):
* storage/indexeddb/resources/objectstore-basics.js:
(checkMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Make leveldb store integer versions and migrate old schemas
dgrogan@chromium.org [Tue, 7 Aug 2012 06:54:55 +0000 (06:54 +0000)]
IndexedDB: Make leveldb store integer versions and migrate old schemas
https://bugs.webkit.org/show_bug.cgi?id=92883

Reviewed by Tony Chang.

Our first schema change. If an existing DB doesn't have integer
versions, this will add one to all object stores in the origin.

No new tests - chrome test for the migration forthcoming. Will involve
starting with a leveldb directory from an old build of chrome, opening
it up with the migration code in place, and checking the new database.
http://codereview.chromium.org/10826159/

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::putVarInt):
(WebCore):
(WebCore::setUpMetadata):
Uses the ASSERT-but-still-handle-corruption pattern recently discussed
in https://bugs.webkit.org/show_bug.cgi?id=92725#c13.

(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
Because we can't store negative numbers, store 0 instead of -1.

(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
* Modules/indexeddb/IDBLevelDBCoding.h:
* Modules/indexeddb/IDBMetadata.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124780.
commit-queue@webkit.org [Tue, 7 Aug 2012 06:40:42 +0000 (06:40 +0000)]
Unreviewed, rolling out r124780.
http://trac.webkit.org/changeset/124780
https://bugs.webkit.org/show_bug.cgi?id=93340

We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/mediasource/MediaSource.cpp: Removed.
* Modules/mediasource/MediaSource.h: Removed.
* Modules/mediasource/MediaSource.idl: Removed.
* Modules/mediasource/MediaSourceRegistry.cpp: Removed.
* Modules/mediasource/MediaSourceRegistry.h: Removed.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered):
(WebCore::SourceBuffer::append):
(WebCore::SourceBuffer::abort):
* Modules/mediasource/SourceBuffer.h:
(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::clear):
(SourceBuffer):
* Modules/mediasource/SourceBufferList.cpp:
* Modules/mediasource/SourceBufferList.h:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:
* html/DOMURL.cpp:
* html/DOMURL.h:
(WebCore):
(DOMURL):
* html/DOMURL.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable link prefetch
gyuyoung.kim@samsung.com [Tue, 7 Aug 2012 06:37:09 +0000 (06:37 +0000)]
[EFL] Enable link prefetch
https://bugs.webkit.org/show_bug.cgi?id=93281

Reviewed by Kentaro Hara.

.:

* Source/cmake/OptionsEfl.cmake: Enable LINK_PREFETCH by default.

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.

LayoutTests:

Unskip test cases related to link prefetch feature except for fast/dom/HTMLLinkElement/subresource.html.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline again for chromium-linux-x86.
toyoshim@chromium.org [Tue, 7 Aug 2012 06:34:29 +0000 (06:34 +0000)]
Unreviewed, rebaseline again for chromium-linux-x86.
See, also r124850.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124801.
ossy@webkit.org [Tue, 7 Aug 2012 06:07:10 +0000 (06:07 +0000)]
Unreviewed, rolling out r124801.
http://trac.webkit.org/changeset/124801
https://bugs.webkit.org/show_bug.cgi?id=93338

It broke NRWT (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_diff_image):
* Scripts/webkitpy/layout_tests/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._read):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image):
* Scripts/webkitpy/layout_tests/port/server_process_mock.py:
(MockServerProcess.__init__):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124798.
commit-queue@webkit.org [Tue, 7 Aug 2012 05:58:49 +0000 (05:58 +0000)]
Unreviewed, rolling out r124798.
http://trac.webkit.org/changeset/124798
https://bugs.webkit.org/show_bug.cgi?id=93337

We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124848.
commit-queue@webkit.org [Tue, 7 Aug 2012 05:54:42 +0000 (05:54 +0000)]
Unreviewed, rolling out r124848.
http://trac.webkit.org/changeset/124848
https://bugs.webkit.org/show_bug.cgi?id=93336

Caused 3 tests to crash on chromium Linux32/Mac10.6/Linux
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::mediaEngineError):
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::webkitSourceBuffered):
(WebCore::HTMLMediaElement::webkitSourceAppend):
(WebCore::HTMLMediaElement::webkitSourceAbort):
(WebCore::HTMLMediaElement::webkitSourceEndOfStream):
(WebCore::HTMLMediaElement::webkitSourceState):
(WebCore::HTMLMediaElement::setSourceState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::createMediaPlayer):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:

LayoutTests:

* http/tests/media/media-source/media-source.js:
(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceId):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):
(MediaSourceTest.getSourceStateName):
* http/tests/media/media-source/video-media-source-abort-expected.txt:
* http/tests/media/media-source/video-media-source-abort.html:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Removed.
* http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt.
* http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Added.
* http/tests/media/media-source/video-media-source-errors-expected.txt:
* http/tests/media/media-source/video-media-source-errors.html:
* http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
* http/tests/media/media-source/video-media-source-event-attributes.html:
* http/tests/media/media-source/video-media-source-play-expected.txt:
* http/tests/media/media-source/video-media-source-play.html:
* http/tests/media/media-source/video-media-source-seek-expected.txt:
* http/tests/media/media-source/video-media-source-seek.html:
* http/tests/media/media-source/video-media-source-state-changes-expected.txt:
* http/tests/media/media-source/video-media-source-state-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium]duplicated command line options in Android LayoutTest
commit-queue@webkit.org [Tue, 7 Aug 2012 05:47:39 +0000 (05:47 +0000)]
[Chromium]duplicated command line options in Android LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=93233

Patch by Wei James <james.wei@intel.com> on 2012-08-06
Reviewed by Tony Chang.

Duplicated options found in Android layout test command line:
--encode-binary and --enable-hardware-gpu.

If there are multiple ChromiumAndroidPort instances,
these two options will be appended for multiple times.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.additional_drt_flag):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.additional_drt_flag):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidTwoPortsTest):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline for chromium-linux-x86.
toyoshim@chromium.org [Tue, 7 Aug 2012 05:47:25 +0000 (05:47 +0000)]
Unreviewed, rebaseline for chromium-linux-x86.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline for r124836.
toyoshim@chromium.org [Tue, 7 Aug 2012 04:48:17 +0000 (04:48 +0000)]
Unreviewed, rebaseline for r124836.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate HTMLMediaElement to the new OO MediaSource API.
annacc@chromium.org [Tue, 7 Aug 2012 04:41:55 +0000 (04:41 +0000)]
Update HTMLMediaElement to the new OO MediaSource API.
https://bugs.webkit.org/show_bug.cgi?id=91775

Reviewed by Eric Carlson.

This patch rips out the old-style MediaSource API and allows a
MediaSource object to be attached to HTMLMediaElement.
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-add-and-remove-buffers.html

Tests: updates to http/tests/media/media-source/*

* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove old style API resources.
(WebCore::HTMLMediaElement::parseAttribute): Remove old style event attributes.
(WebCore::HTMLMediaElement::prepareForLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::loadResource): Get MediaSource object from blob registry
    look up and, if found, set it's MediaPlayer pointer to the current MediaPlayer.
(WebCore::HTMLMediaElement::noneSupported): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaEngineError): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened): Set source state to "open".
(WebCore::HTMLMediaElement::mediaPlayerSourceURL): Change to new blob URL.
(WebCore::HTMLMediaElement::seek): Check if source state is "closed".
(WebCore::HTMLMediaElement::setSourceState): Helper function so that we don't have to
    keep checking for m_mediaSource.
(WebCore::HTMLMediaElement::userCancelledLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::createMediaPlayer): If the current MediaPlayer is re-
    created, notify the MediaSource and reset its MediaPlayer.

* html/HTMLMediaElement.h: Remove old style API code and add a MediaSource object.
(HTMLMediaElement):
* html/HTMLMediaElement.idl: Remove old style API.

LayoutTests:

* http/tests/media/media-source/media-source.js:
(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceBuffer):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):
* http/tests/media/media-source/video-media-source-abort-expected.txt:
* http/tests/media/media-source/video-media-source-abort.html:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt.
* http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Added.
* http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Removed.
* http/tests/media/media-source/video-media-source-errors-expected.txt:
* http/tests/media/media-source/video-media-source-errors.html:
* http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
* http/tests/media/media-source/video-media-source-event-attributes.html:
* http/tests/media/media-source/video-media-source-play-expected.txt:
* http/tests/media/media-source/video-media-source-play.html:
* http/tests/media/media-source/video-media-source-seek-expected.txt:
* http/tests/media/media-source/video-media-source-seek.html:
* http/tests/media/media-source/video-media-source-state-changes-expected.txt:
* http/tests/media/media-source/video-media-source-state-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBindingSecurity::shouldAllowAccessToFrame shouldn't use a raw boolean parameter
abarth@webkit.org [Tue, 7 Aug 2012 04:08:10 +0000 (04:08 +0000)]
BindingSecurity::shouldAllowAccessToFrame shouldn't use a raw boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=93323

Reviewed by Eric Seidel.

As requested by Eric. This patch also renames the function to match its
counterpart in the JavaScriptCore bindings.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
(WebCore::BindingSecurity::allowSettingFrameSrcToJavascriptUrl):
* bindings/generic/BindingSecurity.h:
(BindingSecurity):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::V8DOMWindow::openerAccessorSetter):
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::indexedSecurityCheck):
(WebCore::V8History::namedSecurityCheck):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::toStringCallback):
(WebCore::V8Location::indexedSecurityCheck):
(WebCore::V8Location::namedSecurityCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebSocket.send() should accept ArrayBufferView
yutak@chromium.org [Tue, 7 Aug 2012 04:06:16 +0000 (04:06 +0000)]
WebSocket.send() should accept ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90877

Reviewed by Kent Tamura.

Source/WebCore:

Accept ArrayBufferView as an argument of WebSocket.send() to comply with recent change
in specification: <http://html5.org/tools/web-apps-tracker?from=7084&to=7085>.

Once WebSocket.send(ArrayBuffer) was removed from the specification, but added back
in <http://html5.org/tools/web-apps-tracker?from=7202&to=7203>. Thus the functionality
of send(ArrayBuffer) is kept as-is.

Tests: http/tests/websocket/tests/hybi/send-arraybufferview.html
       http/tests/websocket/tests/hybi/workers/send-arraybufferview.html

* Modules/websockets/ThreadableWebSocketChannel.h:
Change the signature of send() to receive offset and length so the clients can send
subrange of an ArrayBuffer.
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
WebSocket.send(ArrayBufferView) is added, which puts the sub region of the given
ArrayBuffer into the outgoing frame queue.
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocket.idl:
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Send only necessary part of data to the main thread.
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
(Bridge):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send): Accept ArrayBufferView in send().
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback): Ditto.

Source/WebKit/chromium:

* src/WebSocketImpl.cpp:
(WebKit::WebSocketImpl::sendArrayBuffer):
Apply change in function signature of WebSocketChannel::send().

LayoutTests:

Two tests are added to check whether WebSocket.send(ArrayBufferView) works in the
main thread and in a worker.

* http/tests/websocket/tests/hybi/send-arraybufferview-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-arraybufferview.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-arraybufferview.js: Added.
* http/tests/websocket/tests/hybi/workers/send-arraybufferview-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-arraybufferview.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add gyp variable to control which compositor target is depended on
commit-queue@webkit.org [Tue, 7 Aug 2012 03:59:53 +0000 (03:59 +0000)]
[chromium] Add gyp variable to control which compositor target is depended on
https://bugs.webkit.org/show_bug.cgi?id=93165

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

This adds a use_libcc_for_compositor gyp variable to control whether webcore_platform links in the compositor
code from the webcore_chromium_compositor target or from cc from the chromium repo.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTest: fast/forms/input-set-composition-scroll.html is failing on Windows.
commit-queue@webkit.org [Tue, 7 Aug 2012 03:59:24 +0000 (03:59 +0000)]
LayoutTest: fast/forms/input-set-composition-scroll.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93320

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

fast/forms/input-set-composition-scroll.html is failing after r120145
because TestInputController::setComposition() method has not been implemented.
It was added to skip list on Mac, see https://bugs.webkit.org/show_bug.cgi?id=89845 but not on Windows.

* platform/win/Skipped:
Adding test to skip list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in GenericEventQueue::timerFired since the owner of GenericEventQueue is delete...
shinyak@chromium.org [Tue, 7 Aug 2012 03:43:57 +0000 (03:43 +0000)]
Crash in GenericEventQueue::timerFired since the owner of GenericEventQueue is deleted during dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=92946

Reviewed by Eric Carlson.

Source/WebCore:

In GenericEventQueue::timerFired(), the owner of GenericEventQueue might be deleted.
We have to protect the owner of GenericEventQueue during dispatching events.

Test: media/event-queue-crash.html

* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::timerFired): Added a protection.

LayoutTests:

* media/event-queue-crash-expected.txt: Added.
* media/event-queue-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove IDBRequest::finishCursor() and plumbing
jsbell@chromium.org [Tue, 7 Aug 2012 03:40:29 +0000 (03:40 +0000)]
IndexedDB: Remove IDBRequest::finishCursor() and plumbing
https://bugs.webkit.org/show_bug.cgi?id=93274

Reviewed by Tony Chang.

Delete an unused flag and code for setting it, rendered obsolete in r123275.

No new tests - no functional changes.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
commit-queue@webkit.org [Tue, 7 Aug 2012 03:37:24 +0000 (03:37 +0000)]
[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=93319

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/Platform:

Adds a few more entry points to WebLayer that are being used by GraphicsLayerChromium.

* chromium/public/WebLayer.h:
(WebLayer):

Source/WebCore:

Gets rid of all (but one) of the remaining unwrap<LayerChromium>() calls in GraphicsLayer chromium to avoid
punching through the WebLayer API.  Covered by many layout tests, mostly in compositing/

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):

Source/WebKit/chromium:

* src/WebLayer.cpp:
(WebKit::WebLayer::setChildren):
(WebKit):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::clearRenderSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphics...
piman@chromium.org [Tue, 7 Aug 2012 03:18:39 +0000 (03:18 +0000)]
[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=93313

Reviewed by James Robinson.

Sync points already landed chromium-side, mailbos at https://chromiumcodereview.appspot.com/10829209/

* chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::insertSyncPoint):
(WebKit::WebGraphicsContext3D::waitSyncPoint):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::genMailboxCHROMIUM):
(WebKit::WebGraphicsContext3D::produceTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::consumeTextureCHROMIUM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
enne@google.com [Tue, 7 Aug 2012 03:00:10 +0000 (03:00 +0000)]
[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
https://bugs.webkit.org/show_bug.cgi?id=93308

Reviewed by James Robinson.

Source/Platform:

Convert WebScrollbarThemeGeometry to be an interface. Update
WebScrollbarLayer to take a pointer to this interface.

* chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
* chromium/public/WebScrollbarThemeGeometry.h:
(WebScrollbarThemeGeometry):

Source/WebCore:

Convert WebScrollbarThemeGeometry to be an interface. Create a new
WebScrollbarThemeGeometryNative implementation to wrap a native theme
pointer.

Update ScrollbarLayerChromium/CCScrollbarLayerImpl to use a pointer to
this interface rather than a concrete member variable. Because both
layer types need to access the theme during painting or compositing
and either layer could go away at any time, the theme is cloned during
commit rather than dealing with refcounting across threads or having
one layer type be the sole owner.

* WebCore.gypi:
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/chromium/support/WebScrollbarThemeGeometryNative.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarThemeGeometry.cpp.
(WebKit):
(WebKit::WebScrollbarThemeGeometryNative::create):
(WebKit::WebScrollbarThemeGeometryNative::WebScrollbarThemeGeometryNative):
(WebKit::WebScrollbarThemeGeometryNative::clone):
(WebKit::WebScrollbarThemeGeometryNative::thumbPosition):
(WebKit::WebScrollbarThemeGeometryNative::thumbLength):
(WebKit::WebScrollbarThemeGeometryNative::trackPosition):
(WebKit::WebScrollbarThemeGeometryNative::trackLength):
(WebKit::WebScrollbarThemeGeometryNative::hasButtons):
(WebKit::WebScrollbarThemeGeometryNative::hasThumb):
(WebKit::WebScrollbarThemeGeometryNative::trackRect):
(WebKit::WebScrollbarThemeGeometryNative::thumbRect):
(WebKit::WebScrollbarThemeGeometryNative::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometryNative::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometryNative::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometryNative::splitTrack):
* platform/chromium/support/WebScrollbarThemeGeometryNative.h: Added.
(WebKit):
(WebScrollbarThemeGeometryNative):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::setScrollbarGeometry):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(WebCore::CCScrollbarLayerImpl::scrollbarGeometry):
(CCScrollbarLayerImpl):

Source/WebKit/chromium:

Now that WebScrollbarThemeGeometry can have different implementations,
create a FakeWebScrollbarThemeGeometry for testing purposes rather
than just overriding a geometry-related virtual.

* WebKit.gyp:
* WebKit.gypi:
* src/WebScrollbarLayer.cpp:
(WebKit::WebScrollbarLayer::create):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/FakeWebScrollbarThemeGeometry.h: Added.
(WebKit):
(FakeWebScrollbarThemeGeometry):
(WebKit::FakeWebScrollbarThemeGeometry::create):
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] About: shows PAGE_CACHE not enabled.
charles.wei@torchmobile.com.cn [Tue, 7 Aug 2012 02:49:10 +0000 (02:49 +0000)]
[BlackBerry] About: shows PAGE_CACHE not enabled.
https://bugs.webkit.org/show_bug.cgi?id=93216

Reviewed by Antonio Gomes.

Page cache is a feature that can be enabled/disabled at runtime, there's no
MACRO named PAGE_CACHE to control the feature.

* WebCoreSupport/AboutDataEnableFeatures.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Throw proper exceptions
jsbell@chromium.org [Tue, 7 Aug 2012 02:44:19 +0000 (02:44 +0000)]
IndexedDB: Throw proper exceptions
https://bugs.webkit.org/show_bug.cgi?id=85513

Reviewed by Tony Chang.

Test all of the exception throwing clauses in the spec, unless they are
well covered elsewhere (indicated by a comment in the script).

* storage/indexeddb/exceptions-expected.txt: Added.
* storage/indexeddb/exceptions.html: Added.
* storage/indexeddb/resources/exceptions.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(testDatabase.request.onsuccess.trans.oncomplete):
(testDatabase.request.onsuccess):
(testDatabase):
(prepareStoreAndIndex.request.onsuccess):
(prepareStoreAndIndex):
(testObjectStore.request.onsuccess.trans.oncomplete):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex):
(testCursor.makeCursor.request.onsuccess):
(testCursor.makeCursor):
(testCursor.makeKeyCursor.request.onsuccess):
(testCursor.makeKeyCursor):
(testCursor.makeReverseCursor.request.onsuccess):
(testCursor.makeReverseCursor):
(testCursor.makeInlineCursor.request.onsuccess):
(testCursor.makeInlineCursor):
(testCursor.testCursorAdvance):
(testCursor.testCursorContinue):
(testCursor.testCursorDelete):
(testCursor.testCursorUpdate):
(testCursor.makeReadOnlyCursor.request.onsuccess):
(testCursor.makeReadOnlyCursor):
(testCursor.doReadOnlyCursorTests):
(testCursor):
(testTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline test color-suggestion-picker-appearance.html
keishi@webkit.org [Tue, 7 Aug 2012 02:18:57 +0000 (02:18 +0000)]
[Chromium] Rebaseline test color-suggestion-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92444

Unreviewed.

* platform/chromium-linux-x86/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC should use BindingState to determine the activeDOMWindow
abarth@webkit.org [Tue, 7 Aug 2012 02:04:35 +0000 (02:04 +0000)]
JSC should use BindingState to determine the activeDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=93307

Reviewed by Eric Seidel.

This patch moves activeDOMWindow from JSDOMBindings.cpp to
BindingState.cpp. This is a first step towards sharing the core
security logic in the bindings between JavaScriptCore and V8. Once the
logic is shared, we will be able to refactor the logic to avoid the
need for DOMWindow::m_securityOrigin.

This patch doesn't actually share any code (yet). It just sets the
stage by creating BindingState as a typedef of ExecState and adding the
appropriate files to the build systems.

This patch also renames activeWindow and firstWindow in the V8 bindings
to activeDOMWindow and firstDOMWindow to match the names in the
JavaScriptCore bindings.

* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore):
* bindings/js/JSDOMBinding.h:
(WebCore):
* bindings/v8/BindingState.cpp:
(WebCore::activeDOMWindow):
(WebCore::firstDOMWindow):
* bindings/v8/BindingState.h:
(WebCore):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorSetter):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAccessorSetter):
(WebCore::V8Location::hostAccessorSetter):
(WebCore::V8Location::hostnameAccessorSetter):
(WebCore::V8Location::hrefAccessorSetter):
(WebCore::V8Location::pathnameAccessorSetter):
(WebCore::V8Location::portAccessorSetter):
(WebCore::V8Location::protocolAccessorSetter):
(WebCore::V8Location::searchAccessorSetter):
(WebCore::V8Location::reloadCallback):
(WebCore::V8Location::replaceCallback):
(WebCore::V8Location::assignCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Mac] Use the default locale only if the browser locale matches to it
tkent@chromium.org [Tue, 7 Aug 2012 02:01:26 +0000 (02:01 +0000)]
[Chromium-Mac] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93227

Reviewed by Hajime Morita.

For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.

To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.

No new tests. Behavior for locale setting is not testable in WebKit.

* platform/text/mac/LocaleMac.mm:
(WebCore::languageFromLocale):
A helper for determineLocale. This returns the language part of the
specified locale identifier.
(WebCore::determineLocale):
If the browser language matches to the language of the current NSLocale,
returns the current NSLocale. Otherwise, returns a NSLocale with the
browser language.
Note that [NSLolca localeIdentifier] returns a string in
<language>_<country> format though defaultLanguage() in Chromium returns
a string in <language>-<country> format.
(WebCore::LocaleMac::currentLocale):
Use determineLocale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHandle variables in CSSParser::parseValidPrimitive(), preventing null return value.
macpherson@chromium.org [Tue, 7 Aug 2012 01:57:28 +0000 (01:57 +0000)]
Handle variables in CSSParser::parseValidPrimitive(), preventing null return value.
https://bugs.webkit.org/show_bug.cgi?id=93235

Reviewed by Tony Chang.

Source/WebCore:

By returning null here (and failing to handle the variable) the current code would cause null pointer dereferences in StyleResolver at several points.
Instead we create a primitive value for the variable reference and return it.

Test: fast/css/variables/invalid-font-reference.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive):

LayoutTests:

Exercises the code path where variables are parsed in CSSParser::parseValidPrimitive().

* fast/css/variables/invalid-font-reference-expected.txt: Added.
* fast/css/variables/invalid-font-reference.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update chromium DEPS r150037 -> r150169
commit-queue@webkit.org [Tue, 7 Aug 2012 01:46:25 +0000 (01:46 +0000)]
[chromium] Update chromium DEPS r150037 -> r150169
https://bugs.webkit.org/show_bug.cgi?id=93309

As the title says. Unreviewed.

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTest: fast/forms/validation-message-user-modify.html fails.
commit-queue@webkit.org [Tue, 7 Aug 2012 01:45:20 +0000 (01:45 +0000)]
LayoutTest: fast/forms/validation-message-user-modify.html fails.
https://bugs.webkit.org/show_bug.cgi?id=93207

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

This test uses the "required" form element property which currently does not work on Safari,
see <rdar://problem/119655018>.
This test should not be run.

* platform/win/Skipped:
Adding test to skip list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue.
commit-queue@webkit.org [Tue, 7 Aug 2012 01:41:40 +0000 (01:41 +0000)]
[Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue.
https://bugs.webkit.org/show_bug.cgi?id=93293

Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/WebCore:

No new tests.

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::update):
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
(HeadsUpDisplayLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::update):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(WebCore):
(ScrollbarLayerChromium):
* platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::update):
* platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromiumClient):
(TextureLayerChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
* platform/graphics/chromium/cc/CCTextureUpdateController.h:
(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.cpp.
(WebCore):
(WebCore::CCTextureUpdateQueue::CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::~CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::appendFullUpload):
(WebCore::CCTextureUpdateQueue::appendPartialUpload):
(WebCore::CCTextureUpdateQueue::appendCopy):
(WebCore::CCTextureUpdateQueue::takeFirstFullUpload):
(WebCore::CCTextureUpdateQueue::takeFirstPartialUpload):
(WebCore::CCTextureUpdateQueue::takeFirstCopy):
(WebCore::CCTextureUpdateQueue::hasMoreUpdates):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore):
(CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::fullUploadSize):
(WebCore::CCTextureUpdateQueue::partialUploadSize):
(WebCore::CCTextureUpdateQueue::copySize):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore):
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebExternalTextureLayer.cpp:
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/CCTextureUpdateControllerTest.cpp:
* tests/CCThreadedTest.cpp:
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::update):
* tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
* tests/Canvas2DLayerBridgeTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear out the TileCache backpointer for all tile layers when the tile cache is destroyed
andersca@apple.com [Tue, 7 Aug 2012 01:34:14 +0000 (01:34 +0000)]
Clear out the TileCache backpointer for all tile layers when the tile cache is destroyed
https://bugs.webkit.org/show_bug.cgi?id=93317
<rdar://problem/11566543>

Reviewed by Dean Jackson.

It seems that in some rare cases, the tile cache layer can be destroyed in the same transaction as tile layers
are being asked to paint. Make sure to null out the TileCache back pointer for all layers in the TileCache destructor.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Cleanup configure.ac build options output
commit-queue@webkit.org [Tue, 7 Aug 2012 01:07:01 +0000 (01:07 +0000)]
[GTK] Cleanup configure.ac build options output
https://bugs.webkit.org/show_bug.cgi?id=93245

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-06
Reviewed by Laszlo Gombos.

Remove duplicated elements, sort alphabetically.

* configure.ac: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124816.
commit-queue@webkit.org [Tue, 7 Aug 2012 00:50:43 +0000 (00:50 +0000)]
Unreviewed, rolling out r124816.
http://trac.webkit.org/changeset/124816
https://bugs.webkit.org/show_bug.cgi?id=93311

made some tests crash (Requested by noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::apply):
* platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(GraphicsLayerAnimations):
(WebCore::GraphicsLayerAnimations::remove):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Add a command-line flag to enable / disable exclusions
commit-queue@webkit.org [Tue, 7 Aug 2012 00:47:52 +0000 (00:47 +0000)]
[CSS Exclusions] Add a command-line flag to enable / disable exclusions
https://bugs.webkit.org/show_bug.cgi?id=91420

Patch by Bear Travis <betravis@adobe.com> on 2012-08-06
Reviewed by Dimitri Glazkov.

Adding the interface code to expose the css exclusions runtime flag to
Chromium.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Adding getters/setters for cssExclusions
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCSSExclusions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Remove dependency on pthread from MachineStackMarker
paroga@webkit.org [Tue, 7 Aug 2012 00:29:14 +0000 (00:29 +0000)]
[WIN] Remove dependency on pthread from MachineStackMarker
https://bugs.webkit.org/show_bug.cgi?id=68429

Reviewed by Geoffrey Garen.

Windows has no support for calling a destructor for thread specific data.
Since we need more control over creating and deleting thread specific keys
we can not simply extend WTF::ThreadSpecific with this functionality.

All thread specific keys created via the new API get stored in a list.
After a thread function finished we iterate over this list and call
the registered destructor for every item if needed.

Source/JavaScriptCore:

* heap/MachineStackMarker.cpp:  Use the new functions instead of pthread directly.
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
* heap/MachineStackMarker.h:
(MachineThreads):

Source/WTF:

* wtf/ThreadSpecific.h:
(WTF):
(WTF::threadSpecificKeyCreate): Added wrapper around pthread_key_create.
(WTF::threadSpecificKeyDelete): Added wrapper around pthread_key_delete.
(WTF::threadSpecificSet): Added wrapper around pthread_setspecific.
(WTF::threadSpecificGet): Added wrapper around pthread_getspecific.
* wtf/ThreadSpecificWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Parse mix function
commit-queue@webkit.org [Tue, 7 Aug 2012 00:00:32 +0000 (00:00 +0000)]
[CSS Shaders] Parse mix function
https://bugs.webkit.org/show_bug.cgi?id=90101

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-08-06
Reviewed by Dirk Schulze.

Source/WebCore:

Parse the mix function syntax for CSS Shaders as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction

The fragment shader argument of the custom filter function can now be a mix function with
the following syntax:
mix(<uri> [ <blend-mode> || <alpha-compositing> ]?)

For example:
-webkit-filter: custom(url(shader.vert) mix(url(shader.frag multiply source-over))

The Filter Effects spec references the Compositing and Blending spec, which defines the
supported blend modes and alpha compositing modes.

Blend modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blend-mode

This patch adds all of the blend modes in the spec.

Alpha compositing modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#alpha-compositing

This patch does not add any new CSS values for alpha compositing. Currently, we parse the
values that are the same between the spec and the -webkit-background-composite property,
including:
    clear
    copy
    source-over
    source-in
    source-out
    source-atop
    destination-over
    destination-in
    destination-out
    destination-atop
    xor

In the future, we may need to add the following CSS values for alpha compositing:
    lighter
    destination

This is currently under discussion on the www-style mailing list:
http://lists.w3.org/Archives/Public/www-style/2012Aug/0123.html

No new test files. Add test cases in:
    css3/filters/script-tests/custom-filter-property-computed-style.js:
    css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
    css3/filters/script-tests/custom-filter-property-parsing.js:

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
* css/CSSParser.cpp:
(WebCore::CSSParser::isBlendMode):
(WebCore):
(WebCore::CSSParser::isCompositeOperator):
(WebCore::CSSParser::parseMixFunction):
(WebCore::CSSParser::parseCustomFilter):
* css/CSSParser.h:
(WebCore):
* css/CSSParserValues.h:
(WebCore::CSSParserValueList::currentIndex):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator BlendMode):
* css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
* css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMixFunctionValue):
(CSSValue):
* css/CSSValueKeywords.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSMixFunctionValue.cpp: Added.
(WebCore):
(WebCore::WebKitCSSMixFunctionValue::WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::customCssText):
(WebCore::WebKitCSSMixFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
* css/WebKitCSSMixFunctionValue.h: Added.
(WebCore):
(WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::create):
* platform/graphics/GraphicsTypes.h:
* platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::CustomFilterProgram):
* platform/graphics/filters/CustomFilterProgram.h:
(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
(CustomFilterProgramMixSettings):
(WebCore):
* rendering/style/StyleCustomFilterProgram.h:
(WebCore::StyleCustomFilterProgram::create):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

LayoutTests:

Add tests for custom filter mix function parsing as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction

Remove some mac-wk2 and chromium expectations because they are the same as the general
expectations.

* css3/filters/custom/custom-filter-property-computed-style-expected.txt:
* css3/filters/custom/custom-filter-property-parsing-expected.txt:
* css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
* css3/filters/script-tests/custom-filter-property-parsing.js:
* platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Removed.
* platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify JSC date and time formating functions
paroga@webkit.org [Mon, 6 Aug 2012 23:46:11 +0000 (23:46 +0000)]
Unify JSC date and time formating functions
https://bugs.webkit.org/show_bug.cgi?id=92282

Reviewed by Geoffrey Garen.

Replace the existing functions for formating GregorianDateTime
with one single function. This removes some code duplications
in DatePrototype and is a preperation to fix encoding issues,
since we can add UChar* values to the resulting string now.

* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DateConversion.cpp:
(JSC::formatDateTime):
* runtime/DateConversion.h:
(JSC):
* runtime/DatePrototype.cpp:
(JSC::formateDateInstance):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsLayerAnimation shouldn't use HashMap<String>
noam.rosenthal@nokia.com [Mon, 6 Aug 2012 23:43:48 +0000 (23:43 +0000)]
GraphicsLayerAnimation shouldn't use HashMap<String>
https://bugs.webkit.org/show_bug.cgi?id=93284

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use a vector containing all the animations instead of a map of String to Vector.
The HashMap contains very few elements, which makes it inefficient relatively to a vector.
This has been shown to be a bottleneck in valgrind.

Covered by existing animation tests.

* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::remove):
(WebCore::GraphicsLayerAnimations::apply):
* platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimation::name):
(GraphicsLayerAnimations):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):

Source/WebKit2:

Apply the changes to GraphicsLayerAnimation API.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOut-of-process plug-ins should support asynchronous initialization
beidson@apple.com [Mon, 6 Aug 2012 23:42:36 +0000 (23:42 +0000)]
Out-of-process plug-ins should support asynchronous initialization
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Reviewed by Anders Carlsson.

Source/WebKit2:

If a plug-in has been deemed capable of asynchronous initialization when run out of process...
...then do that!

Add flags to communicate that this plugin create is meant to create a plug-in already requested asynchronously and
to include whether or not the initialize call should include an artificial delay (for testing):
* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):

Add a flag for the UI Process to tell the PluginProcess that it supports asynchronous initialization:
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::PluginProcessCreationParameters):
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
* Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):

Allow the UI Process to pass along whether the plug-on supports asynchronous initialization:
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
* UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* UIProcess/WebProcessProxy.messages.in:

Allow the Plugin Process to pass whether or not it supports asynchronous initialization, originally determined
in the UI Process, along to the WebProcess:
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::createWebProcessConnection):
* PluginProcess/PluginProcess.h:
(PluginProcess):
* UIProcess/Plugins/PluginProcessProxy.messages.in:

Add a flag so PluginProcessConnections remember whether or not they support asynchronous initialization:
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::setSupportsAsynchronousPluginInitialization):
(WebKit):
* WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::create):
(WebKit::PluginProcessConnection::supportsAsynchronousPluginInitialization):
(PluginProcessConnection):

Create PluginProcessConnections with the flag passed down from the PluginProcess about whether or not they
support asynchronous initialization:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):

Responding to messages from the WebProcess, most of the heavy decision making in asynchronous initialization is here:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::asynchronousInstanceIDsToIgnore): A set of instance IDs to *not* create asynchronously later because we know
  we no longer need to.
(WebKit):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::destroyPlugin): If the plug-in doesn't exist but is awaiting asynchronous creation, flag
  this instance ID in the "asynchronous ignore set".
(WebKit::WebProcessConnection::createPluginInternal): Renamed from createPlugin, actually does the plug-in creation.
(WebKit::WebProcessConnection::createPlugin): Adds the instance ID to the "asynchronous ignore set" then calls createPluginInternal.
(WebKit::WebProcessConnection::createPluginAsynchronously): If the instance ID is in the "asynchronous ignore set", remove it from the
  set and do nothing else. Otherwise, perform the initialization and then send the asynchronous result back to the WebProcess.
* PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
* PluginProcess/WebProcessConnection.messages.in:

Add helpers for asynchronous initialization that all plug-in types must implement:
* WebProcess/Plugins/Plugin.h:
(Plugin):

Add helpers for asynchronous initialization that plug-in controllers can override:
* WebProcess/Plugins/PluginController.h:
(PluginController):
(WebKit::PluginController::asynchronousPluginInitializationEnabled):
(WebKit::PluginController::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginController::artificialPluginInitializationDelayEnabled):

Give PluginProxys the ability to initialize either asynchronously or synchronously, and also the ability to synchronously
wait for previously asynchronous initialization (in case their PluginScriptObject is required):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::initialize): Store the plugin creation parameters as a member, and decide whether to try synchronous
  or asynchronous initialization.
(WebKit):
(WebKit::PluginProxy::canInitializeAsynchronously): Answer based on preferences and what the PluginProcessConnection says
  that it supports.
(WebKit::PluginProxy::waitForAsynchronousInitialization): Synchronously wait on initialization when asynchronous initialization
  was previously requested.
(WebKit::PluginProxy::initializeSynchronously):
(WebKit::PluginProxy::didCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call
  through to didCreatePluginInternal.
(WebKit::PluginProxy::didCreatePluginInternal): Handle completion of initialization (both synchronously and asynchronously)
(WebKit::PluginProxy::didFailToCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call
  through to didFailToCreatePluginInternal.
(WebKit::PluginProxy::didFailToCreatePluginInternal): Handle failure to initialize (both synchronously and asynchronously)
(WebKit::PluginProxy::destroy):
* WebProcess/Plugins/PluginProxy.h:
(WebKit):
(WebKit::PluginProxy::isInitializingAsynchronously):
(PluginProxy):
* WebProcess/Plugins/PluginProxy.messages.in:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView): Always destroy the plug-in even if it hasn't been initialized yet, as it might be initializing
  right now.
(WebKit::PluginView::initializePlugin): Don't handle the result of initialization immediately. Break that out in to two
  methods that will be called later.
(WebKit):
(WebKit::PluginView::didFailToInitializePlugin):
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::scriptObject): If we truly need the script object, then wait for a synchronous initialization of the plug-in.
(WebKit::PluginView::asynchronousPluginInitializationEnabled):
(WebKit::PluginView::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginView::artificialPluginInitializationDelayEnabled):
* WebProcess/Plugins/PluginView.h:
(PluginView):

These methods shouldn't be called in the PluginProcess, only in the WebProcess:
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::didInitializePlugin):
(WebKit):
(WebKit::PluginControllerProxy::didFailToInitializePlugin):
* PluginProcess/PluginControllerProxy.h:
(PluginControllerProxy):

NetscapePlugin is for in-process plug-ins:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
(WebKit::NetscapePlugin::waitForAsynchronousInitialization):
(WebKit::NetscapePlugin::isInitializingAsynchronously):

Built-in PDFView is currently only in-process:
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):
(WebKit::BuiltInPDFView::waitForAsynchronousInitialization):
(WebKit::BuiltInPDFView::isInitializingAsynchronously):

Tools:

Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
for testing asynchronous plug-in initialization.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
(SlowNPPNew):
(SlowNPPNew::SlowNPPNew):
(SlowNPPNew::NPP_New):

LayoutTests:

Add tests to make sure a plug-in with a long running NPP_New does not block the web thread.

* platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-expected.txt: Added.
* platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple-expected.txt: Added.
* platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html: Added.
* platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization.html: Added.
* platform/mac-wk2/plugins/slow/resources/asynchronous-plugin-initialization-multiple-finish.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebTouchCandidatesInfo should be part of the Client API
abarth@webkit.org [Mon, 6 Aug 2012 23:33:11 +0000 (23:33 +0000)]
[Chromium] WebTouchCandidatesInfo should be part of the Client API
https://bugs.webkit.org/show_bug.cgi?id=93088

Reviewed by Eric Seidel.

Source/Platform:

All the input related interfaces are part of the client (rather than
the platform) part of the API. This patch moves WebTouchCandidatesInfo
to the client part of the API.

* Platform.gypi:
* chromium/public/WebTouchCandidatesInfo.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h.
* src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=93199
bdakin@apple.com [Mon, 6 Aug 2012 23:23:04 +0000 (23:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=93199
REGRESSION (r124489): Crash in FrameView::scrollContentsFastPath when
scrolling Facebook and Google image search
-and corresponding-
<rdar://problem/12035066>

Reviewed by Anders Carlsson.

As the comment in setShouldUpdateScrollLayerPositionOnMainThread()
indicates, the goal of adding a call to
updateMainFrameScrollPositionAndScrollLayerPosition() within that
function was just to make sure the layer position was up-to-date
since that is what is not kept up to date when scrolling is happening
on the scrolling thread. So I'm fixing this crash by having that code
ONLY update the layer position instead of also updating the scroll
position, since it was updating the scroll position that led to this
crash.

New function updateMainFrameScrollLayerPosition() will update JUST
the layer position.
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPosition):

Update just the layer position here instead of the layer position and
the scroll position.
(WebCore)::

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Virtual test suites fail
wangxianzhu@chromium.org [Mon, 6 Aug 2012 23:22:04 +0000 (23:22 +0000)]
[Chromium-Android] Virtual test suites fail
https://bugs.webkit.org/show_bug.cgi?id=92515

Reviewed by Dirk Pranke.

The failure is because our bypassing of DriverProxy.
Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
and restart DRT when the command line changes.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
(ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
(ChromiumAndroidDriver.start): Restart DRT when the command line changes.
(ChromiumAndroidDriver._start_once):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove NRWT --shard-ref-tests
wangxianzhu@chromium.org [Mon, 6 Aug 2012 23:19:57 +0000 (23:19 +0000)]
Remove NRWT --shard-ref-tests
https://bugs.webkit.org/show_bug.cgi?id=91539

This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
(https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
(Sharder.shard_tests):
(Sharder._shard_in_two):
(Sharder._shard_by_directory):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(SharderTests):
(SharderTests.get_test_input):
(SharderTests.get_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_in_two):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._test_input_for_file):
(Manager._test_is_slow):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
commit-queue@webkit.org [Mon, 6 Aug 2012 23:05:15 +0000 (23:05 +0000)]
[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-08-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WTR wasn't using the proper font types provided by testfonts directory.
The same approach as DRT was applied and now it takes info from QFont to
update the store variable.

* UIProcess/qt/WebPreferencesQt.cpp:
(WebKit::setStringValueIfInUserDefaults):
(WebKit):
(WebKit::WebPreferences::platformInitializeStore):

Tools:

Initializing TestFonts information into WTR binary. Doing it
later leads to wrong font names usage (Dejavu Serif instead
of Liberation Serif).

* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd twiz@{chromium|google}.org to the set of non-committer contributors.
commit-queue@webkit.org [Mon, 6 Aug 2012 23:03:55 +0000 (23:03 +0000)]
Add twiz@{chromium|google}.org to the set of non-committer contributors.
https://bugs.webkit.org/show_bug.cgi?id=93288

Patch by Jeff Timanus <twiz@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTestcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html...
commit-queue@webkit.org [Mon, 6 Aug 2012 23:01:54 +0000 (23:01 +0000)]
Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=93287

Patch by Pravin D <pravind.2k4@gmai.com> on 2012-08-06
Reviewed by Ryosuke Niwa.

The testcase uses 'End' keypress event emulation to scroll the caret to the end of the line. As the behavior of 'End' keypress
is platform dependent, replacing it platform independent code.

* editing/input/editable-container-with-word-wrap-normal-expected.txt:
* editing/input/editable-container-with-word-wrap-normal.html:
  Replaced 'End' keypress event with testRunner's execCommand() to make testcase behavior independent of platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
noam.rosenthal@nokia.com [Mon, 6 Aug 2012 23:01:06 +0000 (23:01 +0000)]
[Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
https://bugs.webkit.org/show_bug.cgi?id=93147

Reviewed by Kenneth Rohde Christiansen

Allow controlling animations outside of WebCore. This is an intermediate step before moving
to threaded animations.

CoordinatedGraphicsLayer maintains the GraphicsLayerAnimation structures, and applies the
animation interpolation at the right time, before syncing the rest of the layer info and
the visible contents rect.

This also allows sending shorter IPC messages for animated opacity/transform changes,
without the rest of the layer info.

* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedTransform):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeRenderer::setAnimatedTransform):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
    account for the animated transform in the visible rect.

(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore::CoordinatedGraphicsLayer::setAnimatedTransform):
(WebCore::CoordinatedGraphicsLayer::setAnimatedOpacity):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit):
(WebKit::LayerTreeCoordinator::setLayerAnimatedOpacity):
(WebKit::LayerTreeCoordinator::setLayerAnimatedTransform):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug
dimich@chromium.org [Mon, 6 Aug 2012 22:30:12 +0000 (22:30 +0000)]
[chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug
https://bugs.webkit.org/show_bug.cgi?id=93297

Patch by Adrienne Walker <enne@google.com> on 2012-08-06
Reviewed by James Robinson.

This is a quick fix to get debug unit tests working again by
implementing a virtual function that has ASSERT_NOT_REACHED in the
base class version.

* tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea::scrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(124789): EWS errors out because --print option is missing
abarth@webkit.org [Mon, 6 Aug 2012 22:24:02 +0000 (22:24 +0000)]
REGRESSION(124789): EWS errors out because --print option is missing
https://bugs.webkit.org/show_bug.cgi?id=93299

Unreviewed.

The --print option doesn't exist anymore.  Let's try --quiet instead.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-webkit-tests should have ability to add description to its JSON output
rniwa@webkit.org [Mon, 6 Aug 2012 21:59:06 +0000 (21:59 +0000)]
run-webkit-tests should have ability to add description to its JSON output
https://bugs.webkit.org/show_bug.cgi?id=93296

Reviewed by Dirk Pranke.

PerformanceTests:

Parse description and show it with the WebKit revision on the results page. Also use bar graphs
instead of line graphs since we're not depicting the time series here per arv's suggestion.
Finally, add the ability to adjust y-axis between the adjusted value and 0 (plot even doesn't adjust
y-axis automatically now) by a mouse click.

* resources/results-template.html:

Tools:

Add --description option.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_with_description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: handle errors from image diff better
dpranke@chromium.org [Mon, 6 Aug 2012 21:00:29 +0000 (21:00 +0000)]
nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934

Reviewed by Ojan Vafai.

Currently if ImageDiff crashes, returns a weird exit code, or
produces any stderr output, it's basically swallowed. This
change ensures that we log errors to stderr, and also appends
the error to the stderr for the test (so it'll show up in
results.html).

Most importantly, it'll cause diff_image() to fail and we'll
report ImageHashMismatch ... this may be kinda untrue, but I
think it's better than ignoring the error.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.diff_image):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_diff_image_crashed):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
* Scripts/webkitpy/layout_tests/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._read):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image_crashed):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image):
(PortTestCase):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_diff_image_crashed.make_proc):
* Scripts/webkitpy/layout_tests/port/server_process_mock.py:
(MockServerProcess.__init__):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: clean up printing.py
dpranke@chromium.org [Mon, 6 Aug 2012 20:46:30 +0000 (20:46 +0000)]
nrwt: clean up printing.py
https://bugs.webkit.org/show_bug.cgi?id=93026

Reviewed by Dirk Pranke.

This patch cleans up the implementation of printing.py now
that we're not using all the original complexity.

There should be no changes in functionality and everything
should be covered by the existing tests.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.__init__):
(Printer.__del__):
(Printer.print_config):
(Printer.print_found):
(Printer.print_expected):
(Printer.print_workers_and_shards):
(Printer):
(Printer._print_expected_results_of_type):
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
(Printer._print_one_line_summary):
(Printer.print_finished_test):
(Printer._print_test_result):
(Printer._print_test_trace):
(Printer._print_baseline):
(Printer._print_unexpected_test_result):
(Printer._print_progress):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):
(Printer._print_quiet):
(Printer._print_default):
(Printer._print_debug):
(Printer._print_for_bot):
(Printer.write_update):
(Printer.writeln):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIf the Apple Java plug-in is blocked and no runtime is installed, don't load it
andersca@apple.com [Mon, 6 Aug 2012 20:42:01 +0000 (20:42 +0000)]
If the Apple Java plug-in is blocked and no runtime is installed, don't load it
https://bugs.webkit.org/show_bug.cgi?id=93289
<rdar://problem/11730092>

Reviewed by Dan Bernstein.

Source/WebKit2:

If the Apple Java plug-in is blocked, but there's no Java runtime installed (or the Java plug-in is disabled),
don't even include it in the plug-in info store.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

* UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
shouldBlockPlugin can be static.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
Return false if the Apple Java plug-in is blocked but Java isn't installed or enabled.

(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

WebKitLibraries:

Add WKJLIsRuntimeAndWebComponentsInstalled().

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaSource should use it's own list of source URLs
annacc@chromium.org [Mon, 6 Aug 2012 20:41:20 +0000 (20:41 +0000)]
MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285

Reviewed by Eric Carlson.

r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM.  This patch creates a sourceURLs list so
that MediaSource can stand on its own.

Test: builds on Andriod even when MEDIA_STREAM is disabled.

* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Unbreak debug builds with the 10.7 SDK
thakis@chromium.org [Mon, 6 Aug 2012 20:31:29 +0000 (20:31 +0000)]
[chromium/mac] Unbreak debug builds with the 10.7 SDK
https://bugs.webkit.org/show_bug.cgi?id=93202

Reviewed by James Robinson.

FMGetATSFontRefFromFont() is not available with the 10.7 SDK
when targetting 10.6. Don't delete this code completely yet,
it's still used with the 10.6 SDK when targetting 10.6 (which
chromium's build bots use).

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agochange bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
dpranke@chromium.org [Mon, 6 Aug 2012 20:22:05 +0000 (20:22 +0000)]
change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=93043

Reviewed by Ryosuke Niwa.

in preparation for the cleanup of the logging flags in new-run-webkit-tests.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test: Windows specific tests needed for fast/css/getComputedStyle/computed...
commit-queue@webkit.org [Mon, 6 Aug 2012 19:56:45 +0000 (19:56 +0000)]
Layout Test: Windows specific tests needed for fast/css/getComputedStyle/computed-style.html & computed-style-without-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=93033

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

Windows specific computed-style and computed-style-without-renderer tests are needed since CSS3 Flexbox is disabled on windows,
see https://bugs.webkit.org/show_bug.cgi?id=92047, new CSS3 Flexbox properties no longer used.

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoneed tests to ensure flexboxes play nicely with box-sizing
ojan@chromium.org [Mon, 6 Aug 2012 19:17:20 +0000 (19:17 +0000)]
need tests to ensure flexboxes play nicely with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=70771

Reviewed by Tony Chang.

Source/WebCore:

Anytime we grab the width/height off of the RenderStyle, we need to adjust
it for box-sizing. Fortunately, we only do this two places in RenderFlexibleBox.
Also, delete crossAxisLength since it's unused.

Test: css3/flexbox/box-sizing.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/box-sizing-expected.txt: Added.
* css3/flexbox/box-sizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
commit-queue@webkit.org [Mon, 6 Aug 2012 19:04:31 +0000 (19:04 +0000)]
Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-06
Reviewed by Pavel Feldman.

Source/WebCore:

Add test for WebInspector.linkifyStringAsFragment()

* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

LayoutTests:

parseInt the RegExp match for lineNumber
New test case added to linkify.html

* inspector/debugger/linkifier-expected.txt:
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Not reviewed, linting TestExpectations.
dimich@chromium.org [Mon, 6 Aug 2012 18:46:31 +0000 (18:46 +0000)]
[Chromium] Not reviewed, linting TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
commit-queue@webkit.org [Mon, 6 Aug 2012 18:42:04 +0000 (18:42 +0000)]
Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=93127

Patch by Nasko Oskov <nasko@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

Add support in the API to monitor and create frame hierarchy to allow replicating it
across different instances of WebKit.

* public/WebDocument.h:
(WebDocument): Added createElement.
* public/WebFrame.h: Added assignedName.
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.
* public/WebNode.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createElement): Added to allow for creating frame elements.
(WebKit):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
(WebKit):
(WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed
to the unique name, generated by WebKit.
(WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebNode.cpp:
(WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
(WebKit):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: clean up logging, part 1
dpranke@chromium.org [Mon, 6 Aug 2012 18:31:44 +0000 (18:31 +0000)]
nrwt: clean up logging, part 1
https://bugs.webkit.org/show_bug.cgi?id=93018

Reviewed by Ojan Vafai.

remove --print, --help-printing from nrwt, add three new options:
--quiet, which just logs warnings,errors, and unexpected results
--debug-rwt-logging, a new name for --verbose
--details, to get the old --print trace-everything behavior

This patch does not implement the new "one line per test"
--verbose behavior specified in bug 88702, and there's a bunch
of internal cleanup I can do in printing.py that I'll defer to
a later patch to make things easier to review.

This patch deletes a lot of unit tests that are no longer
necessary since there aren't so many logging combinations.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_args):
(passing_run):
(StreamTestingMixin.assertContains):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_additional_platform_directory):
(RebaselineTest.assertBaselines):
* Scripts/webkitpy/layout_tests/views/printing.py:
(print_options):
(Printer.__init__):
(Printer.enabled):
(Printer.print_unexpected_results):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.test_print_options):
(Testprinter.get_result_summary):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):
(test_default):
(test_quiet):
(test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
wangxianzhu@chromium.org [Mon, 6 Aug 2012 18:29:31 +0000 (18:29 +0000)]
[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91910

/data/local/tmp is a directory with permission 0777 by default.
Place DumpRenderTree resources here so that both the native test app and
the NRWT script can access them even if adb shell isn't running as root.

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestShellAndroid.cpp:
(createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.driver_cmd_line):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._push_executable):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.make_port):
(ChromiumAndroidPortTest.test_expectations_files):
(ChromiumAndroidDriverTest.test_drt_cmd_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Re-expose layoutTestController as various fuzzers depend on it
inferno@chromium.org [Mon, 6 Aug 2012 18:15:15 +0000 (18:15 +0000)]
[Chromium] Re-expose layoutTestController as various fuzzers depend on it
https://bugs.webkit.org/show_bug.cgi?id=93282

Reviewed by Ryosuke Niwa.

Unfortunately, various fuzzers used in the Chromium project still depends on
window.layoutTestController. Re-expose the object while they're making the transition.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
commit-queue@webkit.org [Mon, 6 Aug 2012 17:59:04 +0000 (17:59 +0000)]
[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
https://bugs.webkit.org/show_bug.cgi?id=92596

Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/WebCore:

The CCTextureUpdater interface is used by the main thread to queue
texture updates. The CCTextureUpdateController constructor takes a
CCTextureUpdater and contains the logic required to perform texture
uploads and texture copies. This class is only used by the impl thread.

No new tests.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(Parameters):
(TextureCopier):
(AcceleratedTextureCopier):
* platform/graphics/chromium/TextureUploader.h:
(Parameters):
(TextureUploader):
* platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::uploadTexture):
* platform/graphics/chromium/ThrottledTextureUploader.h:
(ThrottledTextureUploader):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Added.
(WebCore):
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::~CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
* platform/graphics/chromium/cc/CCTextureUpdateController.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore):
(CCTextureUpdateController):
(WebCore::CCTextureUpdateController::create):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::appendFullUpload):
(WebCore::CCTextureUpdater::appendPartialUpload):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::takeFirstFullUpload):
(WebCore::CCTextureUpdater::takeFirstPartialUpload):
(WebCore::CCTextureUpdater::takeFirstCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(WebCore::CCTextureUpdater::fullUploadSize):
(WebCore::CCTextureUpdater::partialUploadSize):
(WebCore::CCTextureUpdater::copySize):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
(CCThreadProxy):

Source/WebKit/chromium:

* WebKit.gypi:
* src/WebExternalTextureLayer.cpp:
* tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp.
* tests/CCTiledLayerTestCommon.h:
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):
* tests/TextureCopierTest.cpp:
(TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderListItem::updateMarkerLocation
inferno@chromium.org [Mon, 6 Aug 2012 17:46:32 +0000 (17:46 +0000)]
Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.

Source/WebCore:

In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.

Test: fast/lists/list-marker-remove-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fast/lists/list-marker-remove-crash-expected.txt: Added.
* fast/lists/list-marker-remove-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
shawnsingh@chromium.org [Mon, 6 Aug 2012 17:43:02 +0000 (17:43 +0000)]
[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
https://bugs.webkit.org/show_bug.cgi?id=85808

Reviewed by Adrienne Walker.

Source/WebCore:

When computing the screen-space transforms, z values were not
being flattened when they should be. This caused incorrect
clipping due to occlusion tracking that relied on the screen-space
transform. The fix is to flatten the screen-space transform just
like the "sublayerMatrix" is flattened, when the layer does not
preserve-3d.

In addition to making the simple fix, it was convenient to make a
helper function for the flattening code.

Additional unit test added to exercise that flattening code:
  CCLayerTreeHostCommonTest.verifyTransformsForFlatteningLayer

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::flattenTransformTo2d):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(CCMathUtil):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable...
ossy@webkit.org [Mon, 6 Aug 2012 17:37:12 +0000 (17:37 +0000)]
Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545

Unreviewed trivial test fix after r124765.

* http/tests/inspector-enabled/dedicated-workers-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate a MediaSource object.
annacc@chromium.org [Mon, 6 Aug 2012 17:28:12 +0000 (17:28 +0000)]
Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

New MediaSource object:
* Modules/mediasource/MediaSource.cpp: Added.
* Modules/mediasource/MediaSource.h: Added.
* Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:
* Modules/mediasource/MediaSourceRegistry.cpp: Added.
* Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.
* Modules/mediasource/SourceBuffer.h:
(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):
* Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
* Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL):
* html/DOMURL.h:
(WebCore):
(DOMURL):
* html/DOMURL.idl:

New MediaSource constructor:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify CSSOM style declaration's grabbing at internals.
kling@webkit.org [Mon, 6 Aug 2012 17:04:28 +0000 (17:04 +0000)]
Simplify CSSOM style declaration's grabbing at internals.
<http://webkit.org/b/93261>

Reviewed by Antti Koivisto.

It was already the case that StylePropertySets exposed in CSSOM were guaranteed mutable,
so remove the mechanism to convert immutable backing objects to mutable ones.

Made ensureCSSStyleDeclaration() non-const to prevent callers that may have an
immutable StylePropertySet from wrapping a CSSOM object around it.

* css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

    Remove indirection and access StylePropertySet member directly.

* css/StylePropertySet.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):

    Made these two non-const. CSSOM wrappers should only ever be constructed around
    mutable StylePropertySets.
    Also added ASSERT(isMutable()).

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

    Cast away the constness of StyledElement::attributeStyle(). It's not pretty,
    but these objects are guaranteed mutable, and there's an assertion to protect
    us in ensureCSSStyleDeclaration() if something changes in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124779 268f45cc-cd09-0410-ab3c-d52691b4dbfc