WebKit-https.git
6 years agoPack WebCore::Font slightly better.
akling@apple.com [Tue, 16 Jul 2013 01:19:17 +0000 (01:19 +0000)]
Pack WebCore::Font slightly better.
<http://webkit.org/b/118681>
<rdar://problem/14446014>

Reviewed by Sam Weinig.

Knock 8 bytes off of Font by packing the members better. Reduces memory consumption by 429 kB when
viewing the full HTML5 spec at <http://whatwg.org/c>

* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoXMLSerializer doesn't include namespaces on nodes in HTML documents
rwlbuis@webkit.org [Tue, 16 Jul 2013 00:37:02 +0000 (00:37 +0000)]
XMLSerializer doesn't include namespaces on nodes in HTML documents
https://bugs.webkit.org/show_bug.cgi?id=16496

Patch by Rob Buis <rwlbuis@webkit.org> on 2013-07-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce a xml fragment serialization mode as indicated by
http://html5.org/specs/dom-parsing.html#xmlserializer (commit 00b84d2). In this mode
the XML fragment serialization algorithm is respected, the changes in this patch do the following:

- elements are self-closing if otherwise this would lead to invalid xml syntax.
- the resulting xml is XML namespace-well-formed (http://www.w3.org/TR/xml-names11/#Conformance).
This is achieved by always, when in xml fragment serialization mode, attempting to write out the element/attribute namespace,
preventing using the XML namespace as a default namespace and special casing the use of element's in XML namespace by using the xml prefix.

The chosen approach matches FireFox 25 behavior.

Test: fast/dom/dom-serialize-namespace.html

* WebCore.order: Adapt to changed createMarkup signature.
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): makes sure xml namespace/prefix is known so it is never used in namespace declarations.
(WebCore::MarkupAccumulator::appendNamespace): Avoid adding namespace declarations that do not differ from current default namespace.
(WebCore::MarkupAccumulator::appendOpenTag): Print xml prefix if the element's namespace is XML to avoid conflicts.
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Also take into account xmlns attributes with no namespace.
(WebCore::MarkupAccumulator::shouldSelfClose): Force self-closing to create well-formed XML elements.
* editing/MarkupAccumulator.h: Use EFragmentSerialization.
(WebCore::MarkupAccumulator::inXMLFragmentSerialization):
* editing/markup.cpp:
(WebCore::createMarkup):
* editing/markup.h: Add EFragmentSerialization enum.
* xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):

LayoutTests:

The updated tests are progressions and match FF.

* fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
* fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
* fast/dom/XMLSerializer-xml-namespace-expected.txt:
* fast/dom/dom-serialize-namespace-expected.txt: Added.
* fast/dom/dom-serialize-namespace.html: Added.
* fast/xsl/xslt-processor-expected.txt:
* inspector/elements/set-outer-html-expected.txt:
* svg/custom/xlink-prefix-in-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Remove unused columns from select query in ImageUtilities.js
commit-queue@webkit.org [Tue, 16 Jul 2013 00:32:40 +0000 (00:32 +0000)]
Web Inspector: Remove unused columns from select query in ImageUtilities.js
https://bugs.webkit.org/show_bug.cgi?id=118694

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-15
Reviewed by Timothy Hatcher.

* UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add fallback for TestWebKitAPI if opengl is not available.
commit-queue@webkit.org [Mon, 15 Jul 2013 23:47:32 +0000 (23:47 +0000)]
[EFL] Add fallback for TestWebKitAPI if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=118583

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-15
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 API test if opengl is not available.
So, add fallback to non-opengl evas engine.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaFragmentURIParser::parseFragments shouldn't upconvert 8-bit string
rniwa@webkit.org [Mon, 15 Jul 2013 23:42:36 +0000 (23:42 +0000)]
MediaFragmentURIParser::parseFragments shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118692

Reviewed by Michael Saboff.

Merge https://chromium.googlesource.com/chromium/blink/+/2aa17cc56a807f7e05d386d6eb66cda25e6b0542.

* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNetworkStorageSession::createDefaultSession is only implemented by Soup
kseo@webkit.org [Mon, 15 Jul 2013 23:41:23 +0000 (23:41 +0000)]
NetworkStorageSession::createDefaultSession is only implemented by Soup
https://bugs.webkit.org/show_bug.cgi?id=118679

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.

No new tests, no behavior change.

* platform/network/NetworkStorageSession.h:
* platform/network/soup/NetworkStorageSessionSoup.cpp:

Source/WebKit/efl:

Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(EWKPrivate::storageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate CodeMirror to 3.14.1.
timothy@apple.com [Mon, 15 Jul 2013 23:31:12 +0000 (23:31 +0000)]
Update CodeMirror to 3.14.1.

https://bugs.webkit.org/show_bug.cgi?id=118605

Reviewed by Joseph Pecoraro.

* Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/closebrackets.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/matchbrackets.js:
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocompositionstart event should contain the text to be replaced
rniwa@webkit.org [Mon, 15 Jul 2013 23:28:50 +0000 (23:28 +0000)]
compositionstart event should contain the text to be replaced
https://bugs.webkit.org/show_bug.cgi?id=118684

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d.

DOM3 level 3 specifies compositionstart event's data to be the text to be replaced.
http://www.w3.org/TR/DOM-Level-3-Events/#event-type-compositionstart

According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
to the specified behavior.

Test: fast/events/ime-composition-events-001.html

* editing/Editor.cpp:
(WebCore::Editor::setComposition):

LayoutTests:

Add a test case.

* fast/events/ime-composition-events-001-expected.txt:
* fast/events/ime-composition-events-001.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoxmlDocPtrForString shouldn't upconvert 8-bit string
rniwa@webkit.org [Mon, 15 Jul 2013 23:27:35 +0000 (23:27 +0000)]
xmlDocPtrForString shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118693

Reviewed by Michael Saboff.

Merge https://chromium.googlesource.com/chromium/blink/+/5d9b240db74591c3689415c7b7c5180fadb379e9

Prior to this changeset, we were upconverting the entire XML document.
Let xmllib2 parse a document as iso-8859-1 when it's a 8-bit string.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::nativeEndianUTF16Encoding):
(WebCore::xmlDocPtrForString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace WKCACFTypes include with d3d9 include.
roger_fong@apple.com [Mon, 15 Jul 2013 20:46:36 +0000 (20:46 +0000)]
Replace WKCACFTypes include with d3d9 include.

Rubberstamped by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Remove unused vsprops files.
roger_fong@apple.com [Mon, 15 Jul 2013 20:44:26 +0000 (20:44 +0000)]
Unreviewed. Remove unused vsprops files.

* win/tools/vsprops/FeatureDefines.vsprops: Removed.
* win/tools/vsprops/FeatureDefinesCairo.vsprops: Removed.
* win/tools/vsprops/WinCairo.vsprops: Removed.
* win/tools/vsprops/cURL.vsprops: Removed.
* win/tools/vsprops/common.vsprops: Removed.
* win/tools/vsprops/debug.vsprops: Removed.
* win/tools/vsprops/debug_all.vsprops: Removed.
* win/tools/vsprops/debug_wincairo.vsprops: Removed.
* win/tools/vsprops/production.vsprops: Removed.
* win/tools/vsprops/release.vsprops: Removed.
* win/tools/vsprops/releaseproduction.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoText with "text-overflow:ellipsis" and an SVG font do not render correctly
ddkilzer@apple.com [Mon, 15 Jul 2013 20:07:42 +0000 (20:07 +0000)]
Text with "text-overflow:ellipsis" and an SVG font do not render correctly
https://bugs.webkit.org/show_bug.cgi?id=118669

Patch by Antoine Quint <graouts@apple.com> on 2013-07-15
Reviewed by David Kilzer.

Source/WebCore:

Partial runs may be routed through the complex path in several Font functions. While incomplete,
we can check for a non-NULL run.renderingContext() and exempt runs that have it from being forced
down the complex path. A more thorough fix is already tracked by http://webkit.org/b/100050.

Adding a new testcase which is a copy of svg/text/text-overflow-ellipsis-svgfont.html with kerning
and ligatures turned on explicitly since DRT runs with those off by default and this option is required
to be on for the issue to reproduce.

Fix courtesy of Dan Bernstein.

Test: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html

* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):

LayoutTests:

* platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.png: Added.
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
* svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake sure to add main resources for sub-frames to the Network Timeline.
timothy@apple.com [Mon, 15 Jul 2013 19:46:30 +0000 (19:46 +0000)]
Make sure to add main resources for sub-frames to the Network Timeline.

https://bugs.webkit.org/show_bug.cgi?id=118649

Reviewed by Joseph Pecoraro.

* UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProperly handle style text changes while the color popover is open.
timothy@apple.com [Mon, 15 Jul 2013 18:53:27 +0000 (18:53 +0000)]
Properly handle style text changes while the color popover is open.

https://bugs.webkit.org/show_bug.cgi?id=118575

Reviewed by Joseph Pecoraro.

* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
The original text marker might have been cleared by a style update, in this case we need to
find the new color text marker so we know the right range for the new style color text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] Download does not replace existing file.
commit-queue@webkit.org [Mon, 15 Jul 2013 18:22:49 +0000 (18:22 +0000)]
[Curl] Download does not replace existing file.
https://bugs.webkit.org/show_bug.cgi?id=118356

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-15
Reviewed by Brent Fulgham.

If the download target file already exists, it is not replaced after the download has finished.
At this point, the user would have already approved to replace the file, so it should be replaced.

* platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination): Move file and replace it if it already exists.
If the new file is on a different volume, do a copy/delete operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CoordinatedGraphics] Crash at CoordinatedGraphicsScene::updateImageBacking
luciano.wolf@openbossa.org [Mon, 15 Jul 2013 17:50:50 +0000 (17:50 +0000)]
[CoordinatedGraphics] Crash at CoordinatedGraphicsScene::updateImageBacking
https://bugs.webkit.org/show_bug.cgi?id=118613

The operations of creating/removing/updating/clearing weren't in the
right sequence. Changing the order solves the issue because when an image is
replaced the old one is deleted before the new one is created, and IDs are
not unique in cairo (they're based on the image pointer).

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::syncImageBackings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebKit/mac: [WK2] Calling Notification.requestPermission() without a callback...
jonlee@apple.com [Mon, 15 Jul 2013 17:16:12 +0000 (17:16 +0000)]
Source/WebKit/mac: [WK2] Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

* WebCoreSupport/WebNotificationClient.mm:
(-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT.
(-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event.
(-[WebNotificationPolicyListener deny]): Ditto.

Source/WebKit2: Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

When requestPermission() is called, we short-circuit if we know the permission was already set.
The callback handler gets invoked. But now that callbacks are optional, we need to check to make
sure a callback was provided.

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Check for the callback.

LayoutTests: [WK2] Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

* http/tests/notifications/notification-request-permission-expected.txt:
* http/tests/notifications/notification-request-permission.html: Add additional subtests that check
that the call succeeds even after granting or denying permission.

* http/tests/notifications/notification-request-permission-no-callback-expected.txt: Added.
* http/tests/notifications/notification-request-permission-no-callback.html: Added. Similar test to
notification-request-permission, without the callback function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocheck-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
commit-queue@webkit.org [Mon, 15 Jul 2013 16:32:41 +0000 (16:32 +0000)]
check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
* Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remote inspector server should send an error page if resources not found
commit-queue@webkit.org [Mon, 15 Jul 2013 15:36:56 +0000 (15:36 +0000)]
[GTK] Remote inspector server should send an error page if resources not found
https://bugs.webkit.org/show_bug.cgi?id=117137

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-07-15
Reviewed by Gustavo Noronha Silva.

Sometimes it is difficult to understand why remote inspector fails to deliver the content.
This patch gives an option to show error page with some basic explanation.

* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed cleanup for pixel tester bot.
zarvai@inf.u-szeged.hu [Mon, 15 Jul 2013 14:47:04 +0000 (14:47 +0000)]
[Qt][WK2] Unreviewed cleanup for pixel tester bot.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
* platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png:
* platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: Leak in WebKitAccessibleTextGetText
commit-queue@webkit.org [Mon, 15 Jul 2013 13:24:25 +0000 (13:24 +0000)]
[ATK] Leak: Leak in WebKitAccessibleTextGetText
https://bugs.webkit.org/show_bug.cgi?id=118596

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

Fixed memory leak.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getGailTextUtilForAtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.
zarvai@inf.u-szeged.hu [Mon, 15 Jul 2013 12:02:21 +0000 (12:02 +0000)]
[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Increase the JHBuild version of GStreamer to 1.0.7
commit-queue@webkit.org [Mon, 15 Jul 2013 10:01:33 +0000 (10:01 +0000)]
[GTK] Increase the JHBuild version of GStreamer to 1.0.7
https://bugs.webkit.org/show_bug.cgi?id=115166

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-15
Reviewed by Philippe Normand.

* gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.
zarvai@inf.u-szeged.hu [Mon, 15 Jul 2013 09:44:35 +0000 (09:44 +0000)]
[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsFor...
commit-queue@webkit.org [Mon, 15 Jul 2013 08:49:48 +0000 (08:49 +0000)]
[GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsForKeyEvent
https://bugs.webkit.org/show_bug.cgi?id=118530

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.

In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.

* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
commit-queue@webkit.org [Mon, 15 Jul 2013 08:14:18 +0000 (08:14 +0000)]
[WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
https://bugs.webkit.org/show_bug.cgi?id=118052

Patch by Alberto Garcia <berto@igalia.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

We don't need to check whether the drawing area is empty or not in
order to set needsResizeOnMap.

It can also happen that the drawing area pointer is null (if
e.g. the web process crashes), which is the reason for this
SIGSEGV.

A test to prevent this was added in r88646 but was later moved to
resizeWebKitWebViewBaseFromAllocation().

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSizeAllocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMinor cleaning of AtomicString::addSlowCase
benjamin@webkit.org [Mon, 15 Jul 2013 08:08:51 +0000 (08:08 +0000)]
Minor cleaning of AtomicString::addSlowCase
https://bugs.webkit.org/show_bug.cgi?id=118615

Reviewed by Geoffrey Garen.

Give the variable a proper name.
Add assertions to clarify the in and out states.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::addSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152598.
commit-queue@webkit.org [Mon, 15 Jul 2013 06:41:06 +0000 (06:41 +0000)]
Unreviewed, rolling out r152598.
http://trac.webkit.org/changeset/152598
https://bugs.webkit.org/show_bug.cgi?id=118658

totally broke the web inspector (JS ERROR: SyntaxError:
Expected token '}') (Requested by thorton on #webkit).

* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-widget):
* Tools/PrettyPrinting/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
(.do):
(moveVisually):
* Tools/PrettyPrinting/css.js:
(.):
(CodeMirror):
* Tools/PrettyPrinting/javascript.js:
(.):
* UserInterface/External/CodeMirror/codemirror.css:
(.CodeMirror-widget):
* UserInterface/External/CodeMirror/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
(.):
* UserInterface/External/CodeMirror/css.js:
(.):
(CodeMirror):
* UserInterface/External/CodeMirror/javascript.js:
(.):
* UserInterface/External/CodeMirror/matchbrackets.js:
(.):
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOrigins with invalid ports are not marked as unique (118652)
jonlee@apple.com [Mon, 15 Jul 2013 06:11:14 +0000 (06:11 +0000)]
Origins with invalid ports are not marked as unique (118652)
https://bugs.webkit.org/show_bug.cgi?id=118652
<rdar://problem/14437753>

Reviewed by Sam Weinig.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create): Return a unique origin if the port is out of range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother Qt build fix attempt after r152619.
rniwa@webkit.org [Mon, 15 Jul 2013 01:27:20 +0000 (01:27 +0000)]
Another Qt build fix attempt after r152619.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoQt build fix attempt after r152619.
rniwa@webkit.org [Mon, 15 Jul 2013 01:22:02 +0000 (01:22 +0000)]
Qt build fix attempt after r152619.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Company100 to team.html
kseo@webkit.org [Mon, 15 Jul 2013 01:01:54 +0000 (01:01 +0000)]
Add Company100 to team.html
https://bugs.webkit.org/show_bug.cgi?id=118633

Reviewed by Andreas Kling.

* team.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac build fix attempt after r152615.
rniwa@webkit.org [Mon, 15 Jul 2013 00:47:53 +0000 (00:47 +0000)]
Mac build fix attempt after r152615.

* svg/SVGFilterElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize QualifiedName by wrapping gNameCache in a function and using more early...
rniwa@webkit.org [Mon, 15 Jul 2013 00:45:12 +0000 (00:45 +0000)]
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Address Ben's review comment.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoapply-style-command-crash.html is flaky
rniwa@webkit.org [Mon, 15 Jul 2013 00:35:07 +0000 (00:35 +0000)]
apply-style-command-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118634

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/a30dad44ded92d24ed56761434cf6041688659a0.

Also replace CRLF to LF and get rid of svn:executable.

* editing/execCommand/apply-style-command-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
rniwa@webkit.org [Sun, 14 Jul 2013 14:49:38 +0000 (14:49 +0000)]
HTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118631

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/2c7c70a7bd3d61bfbf97de95c459ec9f40b46e31.

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd toSVGFilterElement() and use it.
gyuyoung.kim@samsung.com [Sun, 14 Jul 2013 13:59:31 +0000 (13:59 +0000)]
Add toSVGFilterElement() and use it.
https://bugs.webkit.org/show_bug.cgi?id=118653

Reviewed by Ryosuke Niwa.

We can use toSVGFilterElement() instead of using static_cast<..> to improve readability.
Blink also uses it.

No new tests, no behavior change.

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):
* rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
* svg/SVGFilterElement.h:
(WebCore::toSVGFilterElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce toHTMLVideoElement
kangil.han@samsung.com [Sun, 14 Jul 2013 08:55:49 +0000 (08:55 +0000)]
Introduce toHTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=118582

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLVideoElement.

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getPluginProxyParams):
* html/HTMLVideoElement.h:
(WebCore::toHTMLVideoElement):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::enterFullscreenForVideo):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoElement):

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r151978.
commit-queue@webkit.org [Sun, 14 Jul 2013 06:12:03 +0000 (06:12 +0000)]
Unreviewed, rolling out r151978.
http://trac.webkit.org/changeset/151978
https://bugs.webkit.org/show_bug.cgi?id=118651

Caused regressions at least 3 websites (Requested by rniwa on
#webkit).

Source/JavaScriptCore:

* runtime/JSCJSValue.h:
* runtime/JSString.h:

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeFromSignature):
(JSValueToNative):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
* dom/Document.idl:
* dom/Element.idl:
* dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCaret should respect text background color
joone.hur@intel.com [Sun, 14 Jul 2013 06:03:05 +0000 (06:03 +0000)]
Caret should respect text background color
https://bugs.webkit.org/show_bug.cgi?id=117493

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch allows the caret to become visible in the black background
by getting the caret color from the color of the element containing
the text, not the parent element that has the contentEditable attribute.

Test: editing/caret/caret-color.html

* editing/FrameSelection.cpp:
(WebCore::CaretBase::paintCaret):

LayoutTests:

This tests to make sure that the caret is visible in the black background
by getting the caret color from the color of the element(span) containing
the text, not the parent element(div) that has the contentEditable
attribute.

* editing/caret/caret-color-expected.txt: Added.
* editing/caret/caret-color.html: Added.
* platform/efl/editing/caret/caret-color-expected.png: Added.
* platform/mac/TestExpectations: Skip this test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid upconverting strings in various places in WebCore
rniwa@webkit.org [Sun, 14 Jul 2013 01:11:43 +0000 (01:11 +0000)]
Avoid upconverting strings in various places in WebCore
https://bugs.webkit.org/show_bug.cgi?id=118632

Reviewed by Andreas Kling.

Avoid calling String::characters() in various places since it upconverts 8-bit strings to 16-bit strings.

Merge
https://chromium.googlesource.com/chromium/blink/+/a6162e2ad7c7870e22445d3c463d17e7ac871e80
https://chromium.googlesource.com/chromium/blink/+/18095209b3f467758b83894e7b14f813f6953f81
https://chromium.googlesource.com/chromium/blink/+/fefcf2b95d55f24c60fd2e95978cf4544f3c92ca
https://chromium.googlesource.com/chromium/blink/+/8e0527b0fb33998318aedfd74b3511025f7ff294
https://chromium.googlesource.com/chromium/blink/+/feaf798b04597b0849b4000fc305264895d3eac5
https://chromium.googlesource.com/chromium/blink/+/bd1a49103a6e07b1023d2c742d8217769efbffb4

* css/CSSParser.cpp:
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::rewriteSpecifiers):
* css/CSSParserValues.h:
(WebCore::CSSParserString::init):
(WebCore::CSSParserString::clear):
* dom/DatasetDOMStringMap.cpp:
(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):
* dom/Range.cpp:
(WebCore::Range::toString):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::markFutureAndPastNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoparseHTMLInteger shouldn't upconvert 8-bit string
rniwa@webkit.org [Sat, 13 Jul 2013 15:32:07 +0000 (15:32 +0000)]
parseHTMLInteger shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118629

Reviewed by Sam Weinig.

Merge https://chromium.googlesource.com/chromium/blink/+/e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Add an email address and update my domain of experts.
kseo@webkit.org [Sat, 13 Jul 2013 03:44:16 +0000 (03:44 +0000)]
Unreviewed. Add an email address and update my domain of experts.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some dead stores pointed out by the clang static analyzer.
jberlin@webkit.org [Fri, 12 Jul 2013 23:59:16 +0000 (23:59 +0000)]
Remove some dead stores pointed out by the clang static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=118608

Reviewed by Anders Carlsson.

* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
kr is never read after this point, so there is no reason to assign to it.

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):
The extensions array is only used in the while loop. Move the declaration to the first place
it is used in the while loop. Since it is always reassigned at that location, and since it
is never read after the subsequent for loop, the assignment to an array containing the empty
string is never used. Remove it.
Similarly, the value of the description is always overwritten before used to assign to
mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is
never used. Remove it.

* WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):
maxWidth is never read (and never was since it was added in r7311) after it is used on the
line above to set windowFrame.size.width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] TextTrackRepresentation not cleared when captions are disabled
eric.carlson@apple.com [Fri, 12 Jul 2013 23:35:15 +0000 (23:35 +0000)]
[iOS] TextTrackRepresentation not cleared when captions are disabled
https://bugs.webkit.org/show_bug.cgi?id=118623

Reviewed by Dean Jackson.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately
    when captions are disabled so the necessary cleanup happens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/JavaScriptCore: Optimize addStrackTraceIfNecessary to be faster in the case...
commit-queue@webkit.org [Fri, 12 Jul 2013 22:37:51 +0000 (22:37 +0000)]
Source/JavaScriptCore: Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=118328

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.

Retrieving the stack is costly. We want to get it only once. By moving the check
for the .stack property above the code to retrieve the stack, we ensure this.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):

LayoutTests: By optimizing when the stack is added a two tests needed to be modifed to show correct results.
https://bugs.webkit.org/show_bug.cgi?id=118328

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.

* inspector/console/console-exception-stack-traces.html: This test compares the console's currect
stack with the error object's stack. The test was failing on decodeURI() and eval() which create
a new frame on the stack to execute. The console's stack was unaware of these calls and the size
of the stacks would not match. I added a check to pass if it was the specific case with decodeURI
or eval.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[jhbuild] Avoid restarting from scratch failed initial checkouts
commit-queue@webkit.org [Fri, 12 Jul 2013 20:05:08 +0000 (20:05 +0000)]
[jhbuild] Avoid restarting from scratch failed initial checkouts
https://bugs.webkit.org/show_bug.cgi?id=118603

Patch by Emanuele Aina <emanuele.aina@collabora.com> on 2013-07-12
Reviewed by Martin Robinson.

If the initial checkout is interrupted midway (eg. because the internet
connection went down) config files do not get generated and that causes
the next checkout to start from scratch (the missing files cause the
script to delete the build root and the downloaded sources).

By generating the files before invoking jhbuild, subsequent runs are able
to start where the previous run left.

* Scripts/update-webkit-libs-jhbuild:
(saveJhbuildMd5): invoke it before runJhbuild().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Remove single-worker restriction on tests.
bfulgham@apple.com [Fri, 12 Jul 2013 19:51:38 +0000 (19:51 +0000)]
[Windows] Remove single-worker restriction on tests.

* Scripts/webkitpy/port/win.py: Remove restriction of one worker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Attempt to satisfy the Open Source Windows bots.
bfulgham@apple.com [Fri, 12 Jul 2013 19:30:23 +0000 (19:30 +0000)]
[Windows] Attempt to satisfy the Open Source Windows bots.

* DerivedSources.make: Restore the HAVE_AVCF macro detection.
* config.h: Return to using HAVE_AVCF to activate AVFoundation code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152599.
commit-queue@webkit.org [Fri, 12 Jul 2013 19:05:04 +0000 (19:05 +0000)]
Unreviewed, rolling out r152599.
http://trac.webkit.org/changeset/152599
https://bugs.webkit.org/show_bug.cgi?id=118612

This patch includes a failing unit test (Requested by
mrobinson on #webkit).

* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
commit-queue@webkit.org [Fri, 12 Jul 2013 18:57:35 +0000 (18:57 +0000)]
[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=91223

Patch by Emanuele Aina <emanuele.aina@collabora.com> on 2013-07-12
Reviewed by Martin Robinson.

When run on a clean checkout, `build-webkit` complains that no
GNUmakefile exists when trying to detect the previously configured
architecture, but in this case there's no previous configuration so
the warning is pointless.

* Scripts/webkitdirs.pm:
(determineArchitecture): Redirect grep stderr to /dev/null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Build correction after r152573/r152577.
bfulgham@apple.com [Fri, 12 Jul 2013 18:54:07 +0000 (18:54 +0000)]
[Windows] Build correction after r152573/r152577.
https://bugs.webkit.org/show_bug.cgi?id=118610

Reviewed by Oliver Hunt.

* jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub): Hand-feed MSVC++ the fact that we want the second
argument of the make_pair to be a function pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocheck-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
commit-queue@webkit.org [Fri, 12 Jul 2013 18:36:25 +0000 (18:36 +0000)]
check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-12
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
* Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate CodeMirror to 7f560afa1c (3.14+).
timothy@apple.com [Fri, 12 Jul 2013 18:31:29 +0000 (18:31 +0000)]
Update CodeMirror to 7f560afa1c (3.14+).

https://bugs.webkit.org/show_bug.cgi?id=118605

Reviewed by Sam Weinig.

* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/matchbrackets.js:
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Add myself as a committer.
a.renevier@samsung.com [Fri, 12 Jul 2013 17:53:24 +0000 (17:53 +0000)]
Unreviewed. Add myself as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove StringImpl::constructInternal() method
mikhail.pozdnyakov@intel.com [Fri, 12 Jul 2013 16:40:07 +0000 (16:40 +0000)]
Improve StringImpl::constructInternal() method
https://bugs.webkit.org/show_bug.cgi?id=118503

Reviewed by Benjamin Poulain.

StringImpl::constructInternal used 'if ()' statement to decide which constructor
to invoke hence compiler had to compile both branches even though optimizer would
have then removed one of those, and as the function is inline it could affect
slightly the compilation time.

The problem is solved via template specialization.

* wtf/text/StringImpl.h:
(WTF::LChar):
(WTF::UChar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compile fix.
commit-queue@webkit.org [Fri, 12 Jul 2013 16:28:46 +0000 (16:28 +0000)]
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=118461

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-12
Reviewed by Brent Fulgham.

* config.h: Only enable AVFOUNDATION for Windows if CoreGraphics is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] --minimal build fails while linking libwebcore_efl.so
commit-queue@webkit.org [Fri, 12 Jul 2013 14:42:08 +0000 (14:42 +0000)]
[EFL] --minimal build fails while linking libwebcore_efl.so
https://bugs.webkit.org/show_bug.cgi?id=118549

Patch by Oleg Beletski <oleg.beletski@gmail.com> on 2013-07-12
Reviewed by Christophe Dumez.

* CMakeLists.txt:
Moving file plugins/PluginPackage.cpp to ENABLE_NETSCAPE_PLUGIN_API block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping new failing test on Qt.
zarvai@inf.u-szeged.hu [Fri, 12 Jul 2013 13:16:05 +0000 (13:16 +0000)]
[Qt] Unreviewed gardening. Skipping new failing test on Qt.
https://bugs.webkit.org/show_bug.cgi?id=118595

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-12

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed typo fix.
ossy@webkit.org [Fri, 12 Jul 2013 12:55:17 +0000 (12:55 +0000)]
Unreviewed typo fix.

* fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
* fast/css-grid-layout/grid-element-change-columns-repaint.html:
* platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
commit-queue@webkit.org [Fri, 12 Jul 2013 12:45:37 +0000 (12:45 +0000)]
Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-12
Reviewed by Timothy Hatcher.

sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".

* UserInterface/Main.js:
(WebInspector.contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInsufficient viewport repaints when FrameView::paintsEntireContents
allan.jensen@digia.com [Fri, 12 Jul 2013 08:22:11 +0000 (08:22 +0000)]
Insufficient viewport repaints when FrameView::paintsEntireContents
https://bugs.webkit.org/show_bug.cgi?id=118562

Reviewed by Simon Fraser.

When the frameview paints entire content, the visualOverflowRect of RenderView
should be the same as the layoutOverflowRect.

This affects the requested repaints on resize of the frameview.

* rendering/RenderView.cpp:
(WebCore::RenderView::visualOverflowRect):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd 'partner.samsung.com' to domain affiliations
commit-queue@webkit.org [Fri, 12 Jul 2013 01:59:50 +0000 (01:59 +0000)]
Add 'partner.samsung.com' to domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=118580

Patch by Bruno de Oliveira Abinader <bruno.d@partner.samsung.com> on 2013-07-11
Reviewed by Antonio Gomes.

* team.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace simple_blank.swf with lines.swf for snapshotting tests.
roger_fong@apple.com [Fri, 12 Jul 2013 00:50:15 +0000 (00:50 +0000)]
Replace simple_blank.swf with lines.swf for snapshotting tests.
https://bugs.webkit.org/show_bug.cgi?id=118581.

Reviewed by Tim Horton.

* plugins/resources/lines.swf: Added.
* plugins/snapshotting/autoplay-dominant.html:
* plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html:
* plugins/snapshotting/autoplay-similar-to-dominant.html:
* plugins/snapshotting/plugin-receives-click-event.html:
* plugins/snapshotting/restart.html:
* plugins/snapshotting/simple.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPlugins that don't support snapshotting should not all autostart.
roger_fong@apple.com [Thu, 11 Jul 2013 23:53:40 +0000 (23:53 +0000)]
Plugins that don't support snapshotting should not all autostart.
https://bugs.webkit.org/show_bug.cgi?id=118572
<rdar://problem/14324391>.

Reviewed by Dean Jackson.

Test: plugins/snapshotting/quicktime-plugin-snapshotted.html

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Pass in information about whether or not a snapshot exists
to the shadow dom.
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): We should only add the layer to the tree when the plugin
is actually playing. Otherwise we run into an issue where the contents of the layer initially appear on the screen briefly
on page load before we display the substitute for a plugin that doesn't support snapshotting.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin does not support snapshotting go straight
to the the DisplayingSnapshot state.
* WebProcess/Plugins/PluginView.h:

* platform/mac-wk2/plugins/snapshotting/quicktime-plugin-snapshotted-expected.txt: Added.
* plugins/snapshotting/quicktime-plugin-snapshotted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mac] No API for getting the page visibility state of a WebView
mitz@apple.com [Thu, 11 Jul 2013 22:33:11 +0000 (22:33 +0000)]
[mac] No API for getting the page visibility state of a WebView
https://bugs.webkit.org/show_bug.cgi?id=118578

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.exp.in: Export WebCore::Page::visibilityState().

Source/WebKit/mac:

* WebView/WebView.mm:
(kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
(-[WebView _visibilityState]): Added.
* WebView/WebViewPrivate.h: Declared -_visibilityState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed...
jberlin@webkit.org [Thu, 11 Jul 2013 22:27:04 +0000 (22:27 +0000)]
WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
clang static analyzer)
https://bugs.webkit.org/show_bug.cgi?id=118533

Reviewed by Anders Carlsson.

* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix the windows build.
oliver@apple.com [Thu, 11 Jul 2013 21:57:18 +0000 (21:57 +0000)]
Attempt to fix the windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed gardening. Added expected failures after r152574.
mario@webkit.org [Thu, 11 Jul 2013 21:40:31 +0000 (21:40 +0000)]
[GTK] Unreviewed gardening. Added expected failures after r152574.

* platform/gtk/TestExpectations: Added test failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
commit-queue@webkit.org [Thu, 11 Jul 2013 19:40:07 +0000 (19:40 +0000)]
Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
https://bugs.webkit.org/show_bug.cgi?id=118568

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-11
Reviewed by Martin Robinson.

* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk...
mario@webkit.org [Thu, 11 Jul 2013 18:57:57 +0000 (18:57 +0000)]
[GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html are failing
https://bugs.webkit.org/show_bug.cgi?id=118552

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-07-11
Reviewed by Chris Fleizach.

Source/WebCore:

Do not assume always that we have a RenderText renderer when
calling to toRenderText(), since we might be executing that part
of the code due to have requested to include all the children.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Add
missing guard for RenderText, needed after r152537.

LayoutTests:

Remove tests that are no longer expected to crash.

* platform/gtk/TestExpectations: Removed tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNativeExecutable cache needs to use both call and construct functions for key
oliver@apple.com [Thu, 11 Jul 2013 18:35:35 +0000 (18:35 +0000)]
NativeExecutable cache needs to use both call and construct functions for key
https://bugs.webkit.org/show_bug.cgi?id=118545

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make the native executable cache make use a key pair so we don't decide to
treat all subsequent functions as not being constructors.

* jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITThunks.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
* runtime/JSCell.cpp:
(JSC::JSCell::getCallData):
(JSC::JSCell::getConstructData):

LayoutTests:

Make sure we don't decide that all bound functions aren't constructors.

* fast/js/function-bind-expected.txt:
* fast/js/script-tests/function-bind.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] In a region chain with auto-height regions, lines get their length...
abucur@adobe.com [Thu, 11 Jul 2013 16:17:37 +0000 (16:17 +0000)]
[CSS Regions] In a region chain with auto-height regions, lines get their length based only on the first region
https://bugs.webkit.org/show_bug.cgi?id=118531

Reviewed by Alexandru Chiculita.

Source/WebCore:

When computing the height a flow thread it's possible to overflow the maximum LayoutUnit and obtain a negative value.
This leads to invalid results during layout when computing the region range and the RenderBoxRegion info for the
descendant boxes of the flow thread.

This issue appears especially during the auto-height algorithm because it initializes the auto-height regions
height with the LayoutUnit::max() / 2 value. Summing two such regions overflows and results in a negative value.

The fix clamps the maximum height of the flow thread to LayoutUnit::max() / 2. This doesn't affect the auto-height
algorithm because regionAtBlockOffset() will still return the correct values as the auto-height regions content
is established and their height updated.

Tests: fast/regions/autoheight-correct-region-for-lines-2.html
       fast/regions/autoheight-correct-region-for-lines.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::maxPageLogicalHeight):

LayoutTests:

Add tests verifying the lines widths are correctly computed in auto-height regions with and without a max-height set.

* fast/regions/autoheight-correct-region-for-lines-2-expected.html: Added.
* fast/regions/autoheight-correct-region-for-lines-2.html: Added.
* fast/regions/autoheight-correct-region-for-lines-expected.html: Added.
* fast/regions/autoheight-correct-region-for-lines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r152267 and soft link WebInspectorUI.framework again.
timothy@apple.com [Thu, 11 Jul 2013 15:43:53 +0000 (15:43 +0000)]
Revert r152267 and soft link WebInspectorUI.framework again.

https://bugs.webkit.org/show_bug.cgi?id=118544

Reviewed by David Kilzer.

Source/WebCore:

* platform/mac/SoftLinking.h: Rename SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL
to SOFT_LINK_STAGED_FRAMEWORK and ASSERT since we don't want to silently
fail anymore when using this macro.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:
* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):

Source/WebKit2:

* Configurations/WebKit2.xcconfig:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Coordinated Graphics] Parameter of commitSceneState should be const
commit-queue@webkit.org [Thu, 11 Jul 2013 15:17:13 +0000 (15:17 +0000)]
[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-11
Reviewed by Noam Rosenthal.

Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.

Source/WebCore:

* platform/graphics/texmap/coordinated/CompositingCoordinator.h:

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNamedFlowCollection getters should follow the same pattern as HTMLCollection
commit-queue@webkit.org [Thu, 11 Jul 2013 14:54:36 +0000 (14:54 +0000)]
NamedFlowCollection getters should follow the same pattern as HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=118561

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-11
Reviewed by Christophe Dumez.

Source/WebCore:

Modified item and namedItem methods from DOMNamedFlowCollection to return null instead of undefined.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22617
Completely removed the TreatReturnedNullObjectAs attribute as it was only used by the DOMNamedFlowCollection interface.

Test: fast/regions/webkit-named-flow-collection-empty-getters.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
* bindings/scripts/test/TestObj.idl:
* dom/DOMNamedFlowCollection.idl:

LayoutTests:

Updated test for NamedFlowCollection getters when no named flows are created.

* fast/regions/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined-expected.txt.
* fast/regions/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r149313: Don't check for @media rules affected by viewport changes in every...
akling@apple.com [Thu, 11 Jul 2013 14:45:45 +0000 (14:45 +0000)]
Revert r149313: Don't check for @media rules affected by viewport changes in every layout.
<rdar://problem/14277905>

Rubber-stamped by Antti Koivisto.

This changed caused more harm than good. setFrameRect() is not the only path in FrameView
that can cause media queries to need invalidation.

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce isHTMLTitleElement and toHTMLTitleElement
kangil.han@samsung.com [Thu, 11 Jul 2013 12:43:14 +0000 (12:43 +0000)]
Introduce isHTMLTitleElement and toHTMLTitleElement
https://bugs.webkit.org/show_bug.cgi?id=118558

Reviewed by Andreas Kling.

To enhance readability, this patch introduces isHTMLTitleElement and toHTMLTitleElement.
This also helps out to reduce duplicated use of static_cast.

* dom/Document.cpp:
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
* html/HTMLTitleElement.h:
(WebCore::isHTMLTitleElement):
(WebCore::toHTMLTitleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused Windows CE files
paroga@webkit.org [Thu, 11 Jul 2013 11:43:53 +0000 (11:43 +0000)]
Remove unused Windows CE files
https://bugs.webkit.org/show_bug.cgi?id=118557

Reviewed by Andreas Kling.

Source/WebCore:

* platform/wince/CursorWinCE.cpp: Removed.
* platform/wince/PasteboardWinCE.cpp: Removed.
* platform/wince/SearchPopupMenuWinCE.cpp: Removed.

Source/WTF:

* wtf/wince/FastMallocWinCE.h: Removed.
* wtf/wince/MemoryManager.cpp: Removed.
* wtf/wince/MemoryManager.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of SVGPathSeg* special casing in the bindings generator
ch.dumez@sisa.samsung.com [Thu, 11 Jul 2013 11:19:20 +0000 (11:19 +0000)]
Get rid of SVGPathSeg* special casing in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118525

Reviewed by Kentaro Hara.

Have one header per SVGPathSeg* type so that we no longer need special casing
for them in the JSC bindings generator.

No new tests, no behavior change.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSVGPathSegCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
* svg/SVGPathElement.cpp:
* svg/SVGPathSegArc.h:
* svg/SVGPathSegArcAbs.h: Added.
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcAbs::pathSegType):
(WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
* svg/SVGPathSegArcRel.h: Added.
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
(WebCore::SVGPathSegArcRel::pathSegType):
(WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubic.h:
* svg/SVGPathSegCurvetoCubicAbs.h: Added.
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubicRel.h: Added.
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubicSmooth.h:
* svg/SVGPathSegCurvetoCubicSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubicSmoothRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadratic.h:
* svg/SVGPathSegCurvetoQuadraticAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadraticRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadraticSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadraticSmoothRel.h: Renamed from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoAbs::pathSegType):
(WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoHorizontal.h:
* svg/SVGPathSegLinetoHorizontalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoHorizontalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
(WebCore::SVGPathSegLinetoRel::pathSegType):
(WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoVertical.h:
* svg/SVGPathSegLinetoVerticalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegType):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoVerticalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegType):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
* svg/SVGPathSegListBuilder.cpp:
* svg/SVGPathSegMovetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoAbs::pathSegType):
(WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
* svg/SVGPathSegMovetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
(WebCore::SVGPathSegMovetoRel::pathSegType):
(WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r152426.
paroga@webkit.org [Thu, 11 Jul 2013 10:53:16 +0000 (10:53 +0000)]
Build fix for WinCE after r152426.

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
commit-queue@webkit.org [Thu, 11 Jul 2013 10:28:43 +0000 (10:28 +0000)]
[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=118532

Patch by Fabienne Semeria <fsemeria@nds.com> on 2013-07-11
Reviewed by Allan Sandfeld Jensen.

* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed gardening. Added crash expectations in debug builds after r152537
mario@webkit.org [Thu, 11 Jul 2013 09:09:10 +0000 (09:09 +0000)]
[GTK] Unreviewed gardening. Added crash expectations in debug builds after r152537

* platform/gtk/TestExpectations: Added two crashing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Refactor code for translating offsets between WebCore a11y and ATK
mario@webkit.org [Thu, 11 Jul 2013 08:36:15 +0000 (08:36 +0000)]
[ATK] Refactor code for translating offsets between WebCore a11y and ATK
https://bugs.webkit.org/show_bug.cgi?id=118179

Reviewed by Chris Fleizach.

Encapsulate better and make more clear the translation of offsets
between our ATK implementation and WebCore's accessibility layer.

Values for offsets can differ sometimes between those two worlds
due to some extra flattening we need to do in ATK based ports to
properly expose the accessibility hierarchy to ATs, which
sometimes means adding extra text elements in the exposed text
through the AtkText interface (e.g. list items markers).

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(offsetAdjustmentForListItem): Helper function to refactor code
needed to translate offsets from WebCore to ATK worlds. Currently
related to considering list item markers in LTR text only.
(webCoreOffsetToAtkOffset): Convenience function for code
readability purposes. It just calls offsetAdjustmentForListItem.
(atkOffsetToWebCoreOffset): Likewise.
(getSelectionOffsetsForObject): Use webCoreOffsetToAtkOffset.
(webkitAccessibleTextGetCaretOffset): Use webCoreOffsetToAtkOffset
to translate an offset from WebCore to ATK before returning it.
(webkitAccessibleTextSetSelection): Use atkOffsetToWebCoreOffset
to translate an offset from WebCore to ATK before using it.
(webkitAccessibleTextSetCaretOffset): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHandle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
commit-queue@webkit.org [Thu, 11 Jul 2013 07:00:10 +0000 (07:00 +0000)]
Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=118538

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-10
Reviewed by Christophe Dumez.

When attempting some odd url such as ``foo'', MiniBrowser will now show an
error message such as "Cannot resolve hostname (foo)".

Previously, it had the following behavior if MiniBrowser was started with
such urls, e.g ``./MiniBrowser foo'':

- Debug:
It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.

- Release:
No asserts, naturally, but the view would remain blank, even if we tried to
change to a valid url.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/14395759> PluginProcess sometimes logs an error about being unable...
mrowe@apple.com [Thu, 11 Jul 2013 00:13:57 +0000 (00:13 +0000)]
<rdar://problem/14395759> PluginProcess sometimes logs an error about being unable to load WebKit2.framework.

Reviewed by Alexey Proskuryakov.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::createPropertyListFile): Ensure that any environment variables
specified in dynamic linker load commands are passed to the subprocess that we spawn to create
the MIME type property list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRange.getClientRects() not working correctly for partially contained vertically style...
weinig@apple.com [Wed, 10 Jul 2013 23:56:42 +0000 (23:56 +0000)]
Range.getClientRects() not working correctly for partially contained vertically styled text nodes
<rdar://problem/14305675>
https://bugs.webkit.org/show_bug.cgi?id=118447

Reviewed by David Hyatt.

Source/WebCore:

Original patch by Mac Murrett, tweaked by me.

Test: fast/dom/Range/getClientRects-vertical.html

* rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
Use the physical accessors rather than the logical ones to get the correct metrics.

LayoutTests:

* fast/dom/Range/getClientRects-vertical-expected.txt: Added.
* fast/dom/Range/getClientRects-vertical.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReduce number of header includes in SVG
ch.dumez@sisa.samsung.com [Wed, 10 Jul 2013 23:48:35 +0000 (23:48 +0000)]
Reduce number of header includes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118474

Reviewed by Rob Buis.

Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h
no longer brings SVGElement.h header include. This means that the SVGElement
class can now have animated properties.

This patch is a prerequirement to merge SVGStyledElement into SVGElement.

No new tests, no behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* svg/GradientAttributes.h:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateMotionElement.cpp:
* svg/SVGAnimateMotionElement.h:
* svg/SVGAnimatedTypeAnimator.cpp: Added.
(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
* svg/SVGAnimatedTypeAnimator.h:
* svg/SVGAnimationElement.h:
* svg/SVGCursorElement.cpp:
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
* svg/SVGElementInstanceList.cpp:
* svg/SVGElementInstanceList.h:
* svg/SVGElementRareData.h:
* svg/SVGFEImageElement.cpp:
* svg/SVGFilterElement.cpp:
* svg/SVGFitToViewBox.h:
* svg/SVGFontData.cpp:
* svg/SVGFontData.h:
* svg/SVGFontElement.h:
* svg/SVGForeignObjectElement.cpp:
* svg/SVGGlyphMap.h:
* svg/SVGGradientElement.cpp:
* svg/SVGMPathElement.cpp:
* svg/SVGMPathElement.h:
* svg/SVGPathBlender.cpp:
* svg/SVGPathBlender.h:
* svg/SVGPathBuilder.cpp:
* svg/SVGPathBuilder.h:
* svg/SVGPathParser.cpp:
* svg/SVGPathParser.h:
* svg/SVGPathSegListBuilder.h:
* svg/SVGPathTraversalStateBuilder.cpp:
* svg/SVGPathTraversalStateBuilder.h:
* svg/SVGPathUtilities.h:
* svg/SVGPatternElement.cpp:
* svg/SVGPointList.h:
* svg/SVGScriptElement.cpp:
* svg/SVGStyledElement.h:
* svg/SVGTests.h:
* svg/SVGTextElement.h:
* svg/SVGTextPathElement.cpp:
* svg/SVGTransformable.h:
* svg/SVGURIReference.cpp:
* svg/SVGURIReference.h:
* svg/SVGVKernElement.cpp:
* svg/SVGVKernElement.h:
* svg/SVGZoomAndPan.h:
* svg/properties/SVGAnimatedProperty.cpp: Added.
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::commitChange):
(WebCore::SVGAnimatedProperty::animatedPropertyCache):
* svg/properties/SVGAnimatedProperty.h:
* svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
* svg/properties/SVGListProperty.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build against GTK+ 2.0
commit-queue@webkit.org [Wed, 10 Jul 2013 22:39:03 +0000 (22:39 +0000)]
Fix build against GTK+ 2.0
https://bugs.webkit.org/show_bug.cgi?id=117895

Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-07-10
Reviewed by Martin Robinson.

GTK2 build fails for undefined GDK_IS_X11_DISPLAY
GTK 2.0 does define GDK_WINDOWING_X11,but GDK_IS_X11_DISPLAY is not
present in GTK+ 2.0. A dummy defines is sufficient, as GTK 2.0 is not
that multiple backend aware anyway...

* platform/gtk/GtkVersioning.h: Define GDK_IS_X11_DISPLAY for GTK+ 2.0
  and compatibility for gtk_widget_get_preferred_size()
* plugins/gtk/gtk2xtbin.c: Include config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDeferring layer flushes can cause painting without layout being done
timothy_horton@apple.com [Wed, 10 Jul 2013 21:15:56 +0000 (21:15 +0000)]
Deferring layer flushes can cause painting without layout being done
https://bugs.webkit.org/show_bug.cgi?id=118493

Reviewed by Simon Fraser.

r147797 added a mechanism for the TileController to inform RenderLayerCompositor
that it had performed an action (setNeedsDisplay, etc.) that would cause CoreAnimation
to call back into us to paint in this runloop, and that it shouldn't throttle the next
layer flush.

However, if tiles were created and left unparented (because the TileController was
out-of-window), when they are later parented, we failed to inform RenderLayerCompositor
that they were about to call back for painting, and so it would happily throttle the
next layer flush, and layout would be out of date, and garbage and corruption could result.

To resolve this, rework the logic surrounding parenting existing-but-unparented tiles
to ensure that they get added to the TileController's dirtyRect.

No new tests; the bug only reproduces under specific timing circumstances, and
manifests itself as an assertion failure or garbage on the screen, so it's quite
hard to make a workable test.

* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):
- Factor out the code to parent unparented tiles so that it is shared between the
    created-new-tile and reparenting-existing-tile cases.
- Keep track of whether we updated the frame of a pre-existing tile.
- If the tile is dirty and needed to be parented (because either it's new
    or hadn't been parented before), add it to the dirty rect list.
- If the tile changed size, add it to the dirty rect list.

(WebCore::TileController::ensureTilesForRect):
Ditto everything from revalidateTiles.

(WebCore::TileController::createTileLayer):
- Explicitly mark fresh tiles as needing display, so that we can depend on
    [WebTileLayer needsDisplay] in revalidateTiles to tell us that it's dirty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] every enabled text track should be listed in the track menu
eric.carlson@apple.com [Wed, 10 Jul 2013 21:03:26 +0000 (21:03 +0000)]
[Mac] every enabled text track should be listed in the track menu
https://bugs.webkit.org/show_bug.cgi?id=118477

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-controls-captions-trackmenu-includes-enabled-track.html

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Don't select the
    "Off" menu item if a track is enabled.

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Always include a track
    that is showing in the menu. Add more diagnostic logging.

LayoutTests:

* media/trackmenu-test.js: Add some new utility functions.

* media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt: Added.
* media/video-controls-captions-trackmenu-includes-enabled-track.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ElementTimeControl and expose SVGAnimationElement
ch.dumez@sisa.samsung.com [Wed, 10 Jul 2013 20:40:00 +0000 (20:40 +0000)]
Remove ElementTimeControl and expose SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=118349

Reviewed by Rob Buis.

Source/WebCore:

Remove ElementTimeControl IDL interface and move its attributes
to the SVGAnimationElement IDL interface as per the latest SVG2
specification:
https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement

Also remove [NoInterfaceObject] IDL extended attribute from
SVGAnimationElement as it is not present in the specification.

This is one step towards removing IDL multiple inheritance in SVG and
complying with the latest SVG2 specification.

No new tests, covered by existing test cases.

* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorObjC.pm:
* svg/ElementTimeControl.h: Removed.
* svg/ElementTimeControl.idl: Removed.
* svg/SVGAnimationElement.h:
* svg/SVGAnimationElement.idl:

LayoutTests:

Rebaseline several test cases now that SVGAnimationElement is exposed
on the global Window object.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:
* svg/custom/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: "Always enable" profiling does not work
commit-queue@webkit.org [Wed, 10 Jul 2013 20:31:41 +0000 (20:31 +0000)]
Web Inspector: "Always enable" profiling does not work
https://bugs.webkit.org/show_bug.cgi?id=118487

Enable profiler when loading panel if profiler is enabled in inspector
settings.

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-07-10
Reviewed by Timothy Hatcher.

* inspector/front-end/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLPluginElement's state should be Playing before firing mouse click event.
roger_fong@apple.com [Wed, 10 Jul 2013 19:30:59 +0000 (19:30 +0000)]
HTMLPluginElement's state should be Playing before firing mouse click event.
https://bugs.webkit.org/show_bug.cgi?id=118398.
<rdar://problem/14262126>

Reviewed by Dean Jackson.

Test: plugins/snapshotting/plugin-receives-click-event.html

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
The defaultEventHandler returns early if the state is not Playing.
This is because we only want the plugin to deal with user interaction normally if the
plugin is actually enabled (not being snapshotted).
When we click on the snapshotted plugin to start it, we mimic what would happen to the plugin
normally by dispatching another click event on top of where we just clicked.
However, we were sending the click event before setting the state to Playing which meant that our
simulated click was not being handled.
We should be setting this state before sending the click, not after.
* platform/mac-wk2/plugins/snapshotting/plugin-receives-click-event-expected.txt: Added.
* plugins/snapshotting/plugin-receives-click-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix a bug in MediaStreamDescriptor::removeVideoComponent
commit-queue@webkit.org [Wed, 10 Jul 2013 18:42:39 +0000 (18:42 +0000)]
Fix a bug in MediaStreamDescriptor::removeVideoComponent
https://bugs.webkit.org/show_bug.cgi?id=118446

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-10
Reviewed by Eric Carlson.

MediaStreamDescriptor::removeVideoComponent is currently trying to
remove the 'videoComponent' from the wrong vector.

* platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::removeVideoComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSome Java plugin instances can deadlock with the WebProcess on NPP_Destroy.
beidson@apple.com [Wed, 10 Jul 2013 18:34:19 +0000 (18:34 +0000)]
Some Java plugin instances can deadlock with the WebProcess on NPP_Destroy.
<rdar://problem/14286390> and https://bugs.webkit.org/show_bug.cgi?id=118535

Reviewed by Alexey Proskuryakov.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy): ASSERT this is the main thread.
(WebKit::NPObjectProxy::NP_Deallocate): If this isn't the main thread, call it again on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Allow requesting the full plain text for an object with textUnderElement()
mario@webkit.org [Wed, 10 Jul 2013 16:20:24 +0000 (16:20 +0000)]
AX: Allow requesting the full plain text for an object with textUnderElement()
https://bugs.webkit.org/show_bug.cgi?id=105214

Reviewed by Chris Fleizach.

Source/WebCore:

Allow specifying different function modes for textUnderElement(),
so we can effectively ask for the "normal" result (e.g to retrieve
test to be exposed as the 'title') or for the full text under the
element (without omitting any child in the subtree). This is
needed for the implementation of atk_text_get_text() in GTK/EFL.

* accessibility/AccessibilityObject.h: Add new enumeration to
specify the different modes for textUnderElement().
(WebCore::AccessibilityObject::textUnderElement): Added parameter.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText): Always return
'true' when using the "include all children" mode.
(WebCore::AccessibilityNodeObject::textUnderElement): Updated call
to shouldUseAccessiblityObjectInnerText().
* accessibility/AccessibilityNodeObject.h:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Removed
GTK specific code and expand the usage of text iterators beyond
text render objects, using it also when in the "include all
children" mode.
* accessibility/AccessibilityRenderObject.h:

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::getLengthForTextRange): Updated
call to textUnderElement(), preserving the previous behavior.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Updated call to textUnderElement(),
using the "include all children" mode.

LayoutTests:

Removed tests that are not longer expected to fail.

* platform/gtk/TestExpectations: Removed tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some dead code from WebNSURLExtras _web_hostString
jberlin@webkit.org [Wed, 10 Jul 2013 15:52:47 +0000 (15:52 +0000)]
Remove some dead code from WebNSURLExtras _web_hostString
https://bugs.webkit.org/show_bug.cgi?id=118519

Reviewed by Anders Carlsson.

* Misc/WebNSURLExtras.mm:
(-[NSURL _web_hostString]):
NSString initWithData:encoding: does not throw an exception when passing nil for the data, so
just delete the code that wasn't being run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Planet WebKit] Remove my website from the list of feeds
peter@chromium.org [Wed, 10 Jul 2013 14:38:34 +0000 (14:38 +0000)]
[Planet WebKit] Remove my website from the list of feeds
https://bugs.webkit.org/show_bug.cgi?id=118510

Reviewed by Andreas Kling.

With various awesome folks at Apple having taken over the Last
Week in WebKit series and my blog now featuring Last Week in
Blink, there's no reason for it to be included on the Planet
anymore.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the meshType from CoordinatedCustomFilterOperation
commit-queue@webkit.org [Wed, 10 Jul 2013 13:57:06 +0000 (13:57 +0000)]
Remove the meshType from CoordinatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=118529

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-10
Reviewed by Noam Rosenthal.

Following the removal of the meshType from CustomFilterOperation in r149153,
remove also the meshType from CoordinatedCustomFilterOperation.

No new tests, no new functionality.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h:
(WebCore::CoordinatedCustomFilterOperation::create): Remove unused meshType parameter.
(WebCore::CoordinatedCustomFilterOperation::CoordinatedCustomFilterOperation): Ditto.
 Ditto.

Source/WebKit2:

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode): Remove dead comment.
(CoreIPC::::decode): Remove meshType from CoordinatedCustomFilterOperation
call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152534 268f45cc-cd09-0410-ab3c-d52691b4dbfc