WebKit-https.git
5 years agoFix build.
andersca@apple.com [Mon, 23 Jun 2014 17:39:02 +0000 (17:39 +0000)]
Fix build.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGive read-only properties proper ownership attributes
andersca@apple.com [Mon, 23 Jun 2014 17:27:14 +0000 (17:27 +0000)]
Give read-only properties proper ownership attributes
https://bugs.webkit.org/show_bug.cgi?id=134197
<rdar://problem/16830117>

Reviewed by Dan Bernstein.

Also, make WKFrameInfo conform to NSCopying since it's a data-only object and thus intended to be copied.

* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardListItem.h:
* UIProcess/API/Cocoa/WKFrameInfo.h:
* UIProcess/API/Cocoa/WKFrameInfo.mm:
(-[WKFrameInfo copyWithZone:]):
(-[WKFrameInfo setRequest:]): Deleted.
* UIProcess/API/Cocoa/WKNavigation.h:
* UIProcess/API/Cocoa/WKNavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction setSourceFrame:]):
(-[WKNavigationAction setTargetFrame:]):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/API/Cocoa/WKNavigationResponse.h:
* UIProcess/API/Cocoa/WKScriptMessage.h:
* UIProcess/API/Cocoa/WKUserContentController.h:
* UIProcess/API/Cocoa/WKUserScript.h:
* UIProcess/API/Cocoa/WKWebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused FrameView::setUseCustomFixedPositionLayoutRect().
akling@apple.com [Mon, 23 Jun 2014 17:07:54 +0000 (17:07 +0000)]
Remove unused FrameView::setUseCustomFixedPositionLayoutRect().
<https://webkit.org/b/134194>

Reviewed by Anders Carlsson.

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::setUseCustomFixedPositionLayoutRect): Deleted.
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r160908): Unable to unset bold while entering text
antti@apple.com [Mon, 23 Jun 2014 17:02:27 +0000 (17:02 +0000)]
REGRESSION (r160908): Unable to unset bold while entering text
https://bugs.webkit.org/show_bug.cgi?id=134196
<rdar://problem/17051653>

Reviewed by Andreas Kling.

No test, this code path is used by some WK1 API clients only.

* editing/Editor.cpp:
(WebCore::Editor::styleForSelectionStart):

    This needs to update the style before requesting the renderer.

* editing/Editor.h:
* editing/ios/EditorIOS.mm:
(WebCore::styleForSelectionStart): Deleted.
* editing/mac/EditorMac.mm:
(WebCore::styleForSelectionStart): Deleted.

    Removed the duplicated functions, moved to Editor.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Fix video in WebGL.
achristensen@apple.com [Mon, 23 Jun 2014 16:39:13 +0000 (16:39 +0000)]
[iOS] Fix video in WebGL.
https://bugs.webkit.org/show_bug.cgi?id=133511

Reviewed by Jer Noble.

* WebCore.exp.in:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
(WebCore::wkAVAssetResolvedURL): Deleted.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Declare and use resolvedURL on AVURLAsset instead of using wkAVAssetResolvedURL through WebKitSystemInterface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Move WebKit2 test results into LayoutTests/platform/efl
m.pakula@samsung.com [Mon, 23 Jun 2014 15:25:49 +0000 (15:25 +0000)]
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192

Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.

* platform/efl/webaudio/oscillator-custom-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-custom-expected.wav.
* platform/efl/webaudio/oscillator-sawtooth-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-sawtooth-expected.wav.
* platform/efl/webaudio/oscillator-sine-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-sine-expected.wav.
* platform/efl/webaudio/oscillator-square-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-square-expected.wav.
* platform/efl/webaudio/oscillator-triangle-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-triangle-expected.wav.
* platform/efl/webaudio/up-mixing-mono-51-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-51-expected.wav.
* platform/efl/webaudio/up-mixing-mono-stereo-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.wav.
* platform/efl/webaudio/up-mixing-stereo-51-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.wav.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Move WebKit2 test results into LayoutTests/platform/efl
m.pakula@samsung.com [Mon, 23 Jun 2014 15:21:52 +0000 (15:21 +0000)]
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192

Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.

* platform/efl/webaudio/audiobuffersource-loop-points-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.wav.
* platform/efl/webaudio/audiobuffersource-multi-channels-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.wav.
* platform/efl/webaudio/audiobuffersource-playbackrate-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.wav.
* platform/efl/webaudio/gain-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/gain-expected.wav.
* platform/efl/webaudio/mixing-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/mixing-expected.wav.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Move WebKit2 test results into LayoutTests/platform/efl
m.pakula@samsung.com [Mon, 23 Jun 2014 15:13:31 +0000 (15:13 +0000)]
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192

Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.

* platform/efl/fast/: Renamed from LayoutTests/platform/efl-wk2/fast/.
* platform/efl/webaudio/audiobuffersource-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-expected.wav.
* platform/efl/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav.
* platform/efl/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.txt.
* platform/efl/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.txt.
* platform/efl/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.txt.
* platform/efl/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav.
* platform/efl/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.wav.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r168046): Incorrect handling of object information in WebCore::RenderFlow...
stavila@adobe.com [Mon, 23 Jun 2014 14:59:48 +0000 (14:59 +0000)]
REGRESSION (r168046): Incorrect handling of object information in WebCore::RenderFlowThread::removeLineRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=133587

Reviewed by Antti Koivisto.

When an object flowed in multicol is moved from in-flow positioning to out-of-flow positioning,
its information must be removed from the flowthread prior to the change being made.
Otherwise, the flow thread will no longer be its containing block and a reference to it
will not be possible to obtain.

No new tests can be added because the code still hits in an unrelated assertion followed by a null dereference.
The issue was discussed with Antti Koivisto and we decided its better to fix this problem first and
handle the following issue in a separate bug.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleWillChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::flowThreadContainingBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Move WebKit2 test results into LayoutTests/platform/efl
m.pakula@samsung.com [Mon, 23 Jun 2014 14:59:26 +0000 (14:59 +0000)]
[EFL] Move WebKit2 test results into LayoutTests/platform/efl

Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.

* platform/efl/accessibility/: Renamed from LayoutTests/platform/efl-wk2/accessibility/.
* platform/efl/compositing/: Renamed from LayoutTests/platform/efl-wk2/compositing/.
* platform/efl/editing/: Renamed from LayoutTests/platform/efl-wk2/editing/.
* platform/efl/fast/: Renamed from LayoutTests/platform/efl-wk2/fast/.
* platform/efl/http/: Renamed from LayoutTests/platform/efl-wk2/http/.
* platform/efl/ietestcenter: Renamed from LayoutTests/platform/efl-wk2/ietestcenter/.
* platform/efl/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Renamed from LayoutTests/platform/efl-wk2/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt.
* platform/efl/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt.
* platform/efl/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-layer-crash-expected.png.
* platform/efl/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-transformed-expected.png.
* platform/efl/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-zoom-controls-expected.png.
* platform/efl/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-zoom-expected.png.
* platform/efl/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Renamed from LayoutTests/platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt.
* platform/efl/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Renamed from LayoutTests/platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt.
* platform/efl/svg/: Renamed from LayoutTests/platform/efl-wk2/svg/.
* platform/efl/transforms/2d/hindi-rotated-expected.png:
* platform/efl/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Remove the WebKit1 EFL code
ossy@webkit.org [Mon, 23 Jun 2014 13:33:26 +0000 (13:33 +0000)]
[EFL] Remove the WebKit1 EFL code
https://bugs.webkit.org/show_bug.cgi?id=134096

Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2014-06-23
Reviewed by Gyuyoung Kim.

* PlatformEfl.cmake: Removed.
* efl: Removed entire efl directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Platform support for WebSpeech feature.
k.czech@samsung.com [Mon, 23 Jun 2014 12:13:34 +0000 (12:13 +0000)]
[EFL] Platform support for WebSpeech feature.
https://bugs.webkit.org/show_bug.cgi?id=116438

Reviewed by Csaba Osztrogonác.

.:
Add ENABLE_SPEECH_SYNTHESIS flag to have Speech Synthesis in EFL.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/WebCore:
It's a first step of adding support for Speech Synthesis in EFL port.
Just stub out required API and support for compilation.

* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake: Added some idls to not break GTK build.
* platform/PlatformSpeechSynthesizer.h:
* platform/efl/PlatformSpeechSynthesisProviderEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesisProviderEfl::PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::~PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::initializeVoiceList):
(WebCore::PlatformSpeechSynthesisProviderEfl::pause):
(WebCore::PlatformSpeechSynthesisProviderEfl::resume):
(WebCore::PlatformSpeechSynthesisProviderEfl::speak):
(WebCore::PlatformSpeechSynthesisProviderEfl::cancel):
* platform/efl/PlatformSpeechSynthesisProviderEfl.h: Added.
* platform/efl/PlatformSpeechSynthesizerEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake it clear to get m_svgExtensions using svgExtensions().
commit-queue@webkit.org [Mon, 23 Jun 2014 11:11:16 +0000 (11:11 +0000)]
Make it clear to get m_svgExtensions using svgExtensions().
https://bugs.webkit.org/show_bug.cgi?id=134186.

Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-06-23
Reviewed by Dirk Schulze.

This patch makes sure that the purpose of code is to get m_svgExtensions
as changing accessSVGExtensions() to svgExtensions().
svgExtensions() is a getter API and accessSVGExtensions() checks
the presence of m_svgExtensions and create m_svgExtensions if it does not exist.

No new tests, no behavior change.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
* svg/SVGDocumentExtensions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on Mounta...
dino@apple.com [Mon, 23 Jun 2014 08:09:38 +0000 (08:09 +0000)]
REGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on MountainLion
https://bugs.webkit.org/show_bug.cgi?id=134182

Rebaseline for Mountain Lion.

* platform/mac-mountainlion/TestExpectations: Removed.
* platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
dino@apple.com [Mon, 23 Jun 2014 08:04:35 +0000 (08:04 +0000)]
[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=134183

Reviewed by Sam Weinig.

GraphicsContext3D has a reference to a WebGLLayer that was
hidden behind a PlatformLayer. This meant we had to cast it
to use a WebGLLayer method.

* platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer>
with RefPtr<WebGLLayer>.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::~GraphicsContext3D): No need to cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, GTK build fix after r170274.
yoon@igalia.com [Mon, 23 Jun 2014 07:27:05 +0000 (07:27 +0000)]
Unreviewed, GTK build fix after r170274.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
Drawing::m_webPage changed to reference.

(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::updateBackingStoreState):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, GTK build fix after r170266.
philn@webkit.org [Mon, 23 Jun 2014 07:10:45 +0000 (07:10 +0000)]
Unreviewed, GTK build fix after r170266.

* Source/cmake/OptionsGTK.cmake: Geoclue also requires gio-unix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake offset from ancestor computation explicit by moving it to the callers.
zalan@apple.com [Mon, 23 Jun 2014 04:28:16 +0000 (04:28 +0000)]
Make offset from ancestor computation explicit by moving it to the callers.
https://bugs.webkit.org/show_bug.cgi?id=134168.

Reviewed by Simon Fraser.

Explicit offset computation helps code reading and less error-prone than passing
the offset pointer and compute it locally when it is null.

No change in functionality.

* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
(WebCore::performOverlapTests):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVersioning.
lforschler@apple.com [Mon, 23 Jun 2014 03:46:53 +0000 (03:46 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r170163): It made everything crash on EFL
gyuyoung.kim@samsung.com [Mon, 23 Jun 2014 02:25:40 +0000 (02:25 +0000)]
REGRESSION(r170163): It made everything crash on EFL
https://bugs.webkit.org/show_bug.cgi?id=134097

Unreviewed EFL layout test and perforamcne crash fix.

* WebProcess/WebPage/WebPage.cpp: Add a null check for m_mainFrame.
(WebKit::WebPage::didCompletePageTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL build fix since r170274. Use reference for m_webPage member variable.
gyuyoung.kim@samsung.com [Mon, 23 Jun 2014 02:15:00 +0000 (02:15 +0000)]
Unreviewed EFL build fix since r170274. Use reference for m_webPage member variable.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):
(WebKit::CoordinatedDrawingArea::setNeedsDisplay):
(WebKit::CoordinatedDrawingArea::setNeedsDisplayInRect):
(WebKit::CoordinatedDrawingArea::forceRepaint):
(WebKit::CoordinatedDrawingArea::updatePreferences):
(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged):
(WebKit::CoordinatedDrawingArea::layerHostDidFlushLayers):
(WebKit::CoordinatedDrawingArea::updateBackingStoreState):
(WebKit::CoordinatedDrawingArea::sendDidUpdateBackingStoreState):
(WebKit::CoordinatedDrawingArea::suspendPainting):
(WebKit::CoordinatedDrawingArea::resumePainting):
(WebKit::CoordinatedDrawingArea::enterAcceleratedCompositingMode):
(WebKit::CoordinatedDrawingArea::display):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
timothy_horton@apple.com [Mon, 23 Jun 2014 01:32:06 +0000 (01:32 +0000)]
[iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
https://bugs.webkit.org/show_bug.cgi?id=134181

Reviewed by Benjamin Poulain.

* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::removeSwipeSnapshot):
* UIProcess/mac/ViewGestureController.h:
Make it explicit that we should only remove the swipe snapshot when a
big-enough render tree size arrives *after the swipe ends*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on Mounta...
beidson@apple.com [Mon, 23 Jun 2014 01:19:57 +0000 (01:19 +0000)]
REGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on MountainLion
https://bugs.webkit.org/show_bug.cgi?id=134182

Unreviewed gardening.

* platform/mac-mountainlion/TestExpectations: Added, skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThread some references through the remote layer tree code
timothy_horton@apple.com [Mon, 23 Jun 2014 00:51:33 +0000 (00:51 +0000)]
Thread some references through the remote layer tree code
https://bugs.webkit.org/show_bug.cgi?id=134177

Reviewed by Zalan Bujtas.

A first pass at references for never-null things (first pass because I didn't touch the collections).
Things that aren't straightforward reference-threading:

* Shared/mac/RemoteLayerBackingStoreCollection.h:
* Shared/mac/RemoteLayerBackingStoreCollection.mm:
Remove the unimplemented/nonexistant RemoteLayerBackingStoreCollection::create.
Make RemoteLayerBackingStoreCollection constructor not take a context, because m_context is never used.

* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
Factor out grabbing the PlatformLayerID in a few places.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Use WebPage::mainFrameView() instead of WebPage::corePage()->mainFrame().view().

* Shared/mac/RemoteLayerTreeTransaction.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
* WebProcess/WebPage/DrawingArea.cpp:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:om):
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
* Shared/mac/RemoteLayerBackingStore.mm:
References.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTransition layer offsets from LayoutPoint to LayoutSize.
zalan@apple.com [Mon, 23 Jun 2014 00:34:25 +0000 (00:34 +0000)]
Transition layer offsets from LayoutPoint to LayoutSize.
https://bugs.webkit.org/show_bug.cgi?id=134156

Reviewed by Simon Fraser.

Use better representation for offset values.

No change in functionality.

* platform/graphics/LayoutSize.h:
(WebCore::roundedForPainting):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
* rendering/RenderLayer.cpp:
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempted iOS build fix.
dino@apple.com [Mon, 23 Jun 2014 00:13:49 +0000 (00:13 +0000)]
Attempted iOS build fix.

* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::~GraphicsContext3D): Cast to WebGLLayer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Apple] WebGL layer may use GC3D after free with remote layer hosting
dino@apple.com [Mon, 23 Jun 2014 00:00:03 +0000 (00:00 +0000)]
[Apple] WebGL layer may use GC3D after free with remote layer hosting
https://bugs.webkit.org/show_bug.cgi?id=134179
<rdar://problem/17412931>

Reviewed by Tim Horton.

With remote layer hosting, a WebGLLayer may attempt to draw after
the GraphicsContext3D has been destroyed. We need to make sure
the GC3D tells the WebGLLayer that it is no longer valid.

While here, I changed some return 0 to return nullptr, the
name of the ObjC property member from m_context to _context,
and removed some unnecessary .get() calls.

This is tested by run-webkit-tests with the --remote-layer-tree
option.

* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): No need for .get().
(WebCore::GraphicsContext3D::~GraphicsContext3D): Set the context reference on WebGLLayer
to be null.
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): No need for .get().
* platform/graphics/mac/WebGLLayer.h: Set the context reference on WebGLLayer
to be null.
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Rename m_context to _context.
(-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): Check for null.
(-[WebGLLayer copyCGLContextForPixelFormat:]): Rename to _context.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Check for null.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Ditto.
(-[WebGLLayer display]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Frameset frames are not scrollable after loading (and should be)
simon.fraser@apple.com [Sun, 22 Jun 2014 18:35:32 +0000 (18:35 +0000)]
[WK2] Frameset frames are not scrollable after loading (and should be)
https://bugs.webkit.org/show_bug.cgi?id=134151
<rdar://problem/17403365>

Reviewed by Dan Bates.

Source/WebCore:
When loading a <frameset>, we could end up with an empty non-fast-scrollable
region for the main frame, because after the initial frameset document layout,
nothing updated the non-fast scrollable region as the subframes added their
scrollable areas to the the main frame's scrollable area set.

Fix by having addScrollableArea() and removeScrollableArea() trigger an update
of the non-fast scrollable region.

Test: platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html

* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::scrollableAreaSetChanged):
* page/FrameView.h:

LayoutTests:
Frameset test that dumps the scrolling tree.

* platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/resources/scrollable-page.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReplace a couple of uses of bind with lambdas
andersca@apple.com [Sun, 22 Jun 2014 18:21:49 +0000 (18:21 +0000)]
Replace a couple of uses of bind with lambdas
https://bugs.webkit.org/show_bug.cgi?id=134172

Reviewed by Sam Weinig.

* Platform/IPC/Connection.cpp:
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchConnectionDidClose): Deleted.
* Platform/IPC/Connection.h:
* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::NP_Deallocate):
* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
(WebKit::NetscapePlugin::handlePluginThreadAsyncCall): Deleted.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r170265.
commit-queue@webkit.org [Sun, 22 Jun 2014 18:09:36 +0000 (18:09 +0000)]
Unreviewed, rolling out r170265.
https://bugs.webkit.org/show_bug.cgi?id=134174

Broke editing tests (Requested by litherum on #webkit).

Reverted changeset:

"Use unsigneds instead of ints for indexes into a string in
text layout code"
https://bugs.webkit.org/show_bug.cgi?id=133592
http://trac.webkit.org/changeset/170265

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHave scrollingTreeAsText() dump the non-fast-scrollable region
simon.fraser@apple.com [Sun, 22 Jun 2014 18:06:35 +0000 (18:06 +0000)]
Have scrollingTreeAsText() dump the non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=134149

Reviewed by Sam Weinig.

Source/WebCore:

Dump the non-fast-scrollable region (as an array of rects).

* WebCore.exp.in:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

Source/WebKit2:

Dump the non-fast-scrollable region (as an array of rects).

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingTreeTextStream::dump):

LayoutTests:

Rebaselined.

* platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisable gamepad feature on EFL and GTK ports by default
gyuyoung.kim@samsung.com [Sun, 22 Jun 2014 17:49:01 +0000 (17:49 +0000)]
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169

Reviewed by Brady Eidson.

* Source/cmake/OptionsEfl.cmake: Disable ENABLE_GAMEPAD_DEPRECATED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse unsigneds instead of ints for indexes into a string in text layout code
mmaxfield@apple.com [Sun, 22 Jun 2014 17:17:07 +0000 (17:17 +0000)]
Use unsigneds instead of ints for indexes into a string in text layout code
https://bugs.webkit.org/show_bug.cgi?id=133592

Reviewed by Zalan Bujtas.

Migrate much of the text-handling code to use unsigneds for indexes into a string.

No new tests because there is no behavior change.

* WebCore.exp.in:
* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
* platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::atEnd):
* platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
* platform/graphics/SimpleFontData.h:
* platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
* platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
* platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
* platform/graphics/WidthIterator.h:
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::adjustCharactersAndLengthForHyphen):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
* rendering/InlineTextBox.h:
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
* rendering/RenderCombineText.h:
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
* rendering/svg/SVGTextQuery.h:
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
* rendering/svg/SVGTextRunRenderingContext.h:
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
* svg/SVGFontData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd IPC decoding support to BackForwardListState
andersca@apple.com [Sun, 22 Jun 2014 16:58:27 +0000 (16:58 +0000)]
Add IPC decoding support to BackForwardListState
https://bugs.webkit.org/show_bug.cgi?id=134171

Reviewed by Dan Bernstein.

* Shared/SessionState.cpp:
(WebKit::isValidEnum):
(WebKit::HTTPBody::Element::decode):
(WebKit::HTTPBody::decode):
(WebKit::FrameState::decode):
(WebKit::PageState::decode):
(WebKit::BackForwardListState::decode):
* Shared/SessionState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAddress a review comment.
andersca@apple.com [Sun, 22 Jun 2014 16:47:20 +0000 (16:47 +0000)]
Address a review comment.

* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::decodeFormDataElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement the rest of back forward tree decoding
andersca@apple.com [Sun, 22 Jun 2014 16:34:15 +0000 (16:34 +0000)]
Implement the rest of back forward tree decoding
https://bugs.webkit.org/show_bug.cgi?id=134166

Reviewed by Sam Weinig.

* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] WKWebViewConfiguration.allowsInlineMediaPlayback has no effect
mitz@apple.com [Sun, 22 Jun 2014 16:33:40 +0000 (16:33 +0000)]
[iOS] WKWebViewConfiguration.allowsInlineMediaPlayback has no effect
https://bugs.webkit.org/show_bug.cgi?id=134170

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisable gamepad feature on EFL and GTK ports by default
gyuyoung.kim@samsung.com [Sun, 22 Jun 2014 05:52:59 +0000 (05:52 +0000)]
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169

Reviewed by Brady Eidson.

EFL and GTK ports disabled Gamepad feature now. Besides current implementation
was treated to 'deprecated' status.

ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agocreateCairoGLSurface should take in a FloatSize reference as its first parameter
zandobersek@gmail.com [Sun, 22 Jun 2014 05:50:09 +0000 (05:50 +0000)]
createCairoGLSurface should take in a FloatSize reference as its first parameter
https://bugs.webkit.org/show_bug.cgi?id=134159

Reviewed by Martin Robinson.

The ImageBuffer constructor operates with a FloatSize reference, which is also
passed to createCairoGLSurface when accelerated 2D canvas support is enabled.
That function should take in a reference to the same type.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::createCairoGLSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fixing the GTK+ build after r170253.
zandobersek@gmail.com [Sun, 22 Jun 2014 05:46:32 +0000 (05:46 +0000)]
Unreviewed. Fixing the GTK+ build after r170253.

* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): WebPreferences::create()
now takes an additional String argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Margins for new form controls need tweaking
dino@apple.com [Sat, 21 Jun 2014 23:55:44 +0000 (23:55 +0000)]
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>

Reviewed by Sam Weinig.

Source/WebCore:
Take 2 of this patch. Only the mac-mountainlion LayoutTest
results are different from the first attempt.

With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.

This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.

* platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.

LayoutTests:
Take 2 of this patch adds some Mountain Lion results.

Rebaseline a bunch of results since some <input> dimensions
changed slightly.

* platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
* platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Added.
* platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
* platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
* platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Added.
* platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
* platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
* platform/mac-mountainlion/http/tests/navigation/javascriptlink-frame-expected.txt: Added.
* platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/css1/box_properties/acid_test-expected.png:
* platform/mac/css1/box_properties/acid_test-expected.txt:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/mac/fast/block/basic/011-expected.png:
* platform/mac/fast/block/basic/011-expected.txt:
* platform/mac/fast/block/margin-collapse/103-expected.png:
* platform/mac/fast/block/margin-collapse/103-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.png:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove-expected.txt:
* platform/mac/fast/forms/formmove2-expected.png:
* platform/mac/fast/forms/formmove2-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.png:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/width100percent-radio-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove static tables for bindings that use eager reification
weinig@apple.com [Sat, 21 Jun 2014 23:27:22 +0000 (23:27 +0000)]
Remove static tables for bindings that use eager reification
https://bugs.webkit.org/show_bug.cgi?id=134126

Reviewed by Oliver Hunt.

Source/JavaScriptCore:
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectCustomAccessor):
* runtime/Structure.h:
(JSC::Structure::setHasCustomGetterSetterProperties):
Change setHasCustomGetterSetterProperties to behave like setHasGetterSetterProperties, and set
the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit if the property is not __proto__.
Without this, JSObject::put() won't think there are any setters on the prototype chain of an
object that has no static lookup table and uses eagerly reified custom getter/setter properties.

Source/WebCore:
This shaves about 1MB off of WebCore's .o files.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.h:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.h:
* bindings/scripts/test/JS/JSTestException.cpp:
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNode.h:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.h:
* bindings/scripts/test/JS/JSattribute.cpp:
* bindings/scripts/test/JS/JSattribute.h:
* bindings/scripts/test/JS/JSreadonly.cpp:
* bindings/scripts/test/JS/JSreadonly.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTried to fix the iOS build after r170235.
mitz@apple.com [Sat, 21 Jun 2014 22:33:28 +0000 (22:33 +0000)]
Tried to fix the iOS build after r170235.

* WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCallbackMap::put should be able to take an unwrapped function
mitz@apple.com [Sat, 21 Jun 2014 22:25:34 +0000 (22:25 +0000)]
CallbackMap::put should be able to take an unwrapped function
https://bugs.webkit.org/show_bug.cgi?id=134104

Reviewed by Anders Carlsson.

* UIProcess/GenericCallback.h:
(WebKit::CallbackMap::put): Added an overload that takes a function and creates and puts a
callback. Changed both overloads of put() to return the callback ID.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake it possible to override debug preferences on a per-identifier basis as well...
andersca@apple.com [Sat, 21 Jun 2014 22:02:26 +0000 (22:02 +0000)]
Make it possible to override debug preferences on a per-identifier basis as well as globally
https://bugs.webkit.org/show_bug.cgi?id=134164

Reviewed by Dan Bernstein.

* Shared/WebPreferencesDefinitions.h:
* Shared/WebPreferencesKeys.cpp:
* Shared/WebPreferencesKeys.h:
* Shared/WebPreferencesStore.cpp:
(WebKit::defaults):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::create):
(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::WebPreferences):
* UIProcess/WebPreferences.h:
* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
(WebKit::setDebugBoolValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBegin work on decoding form data
andersca@apple.com [Sat, 21 Jun 2014 21:01:26 +0000 (21:01 +0000)]
Begin work on decoding form data
https://bugs.webkit.org/show_bug.cgi?id=134163

Reviewed by Sam Weinig.

* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::isValid):
(WebKit::isValidEnum):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOnly initialize WebPreferences from NSUserDefaults if there's an identifier
andersca@apple.com [Sat, 21 Jun 2014 20:05:38 +0000 (20:05 +0000)]
Only initialize WebPreferences from NSUserDefaults if there's an identifier
https://bugs.webkit.org/show_bug.cgi?id=134162

Reviewed by Sam Weinig.

We don't want to allow changing preferences by registering user defaults.

* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::WebPreferences::platformInitializeStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBegin work on decoding the back/forward tree
andersca@apple.com [Sat, 21 Jun 2014 19:41:31 +0000 (19:41 +0000)]
Begin work on decoding the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=134161

Reviewed by Sam Weinig.

* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decodeArithmeticType):
(WebKit::HistoryEntryDataDecoder::bufferIsLargeEnoughToContain):
(WebKit::decodeBackForwardTreeNode):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
(WebKit::HistoryEntryDataDecoder::decode): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGamepad API - Deprecate the existing implementation
beidson@apple.com [Sat, 21 Jun 2014 19:07:05 +0000 (19:07 +0000)]
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108

Reviewed by Timothy Hatcher.

-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it

.:
-Add the "Deprecated" suffix to some implementation files

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:
-Move some implementation files into a "deprecated" subdirectory.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:
-Move some implementation files into a "deprecated" subdirectory.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* PlatformGTK.cmake:

* Modules/gamepad/deprecated/Gamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
* Modules/gamepad/deprecated/Gamepad.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
* Modules/gamepad/deprecated/Gamepad.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
* Modules/gamepad/deprecated/GamepadList.cpp: Renamed from Source/WebCore/Modules/gamepad/GamepadList.cpp.
* Modules/gamepad/deprecated/GamepadList.h: Renamed from Source/WebCore/Modules/gamepad/GamepadList.h.
* Modules/gamepad/deprecated/GamepadList.idl: Renamed from Source/WebCore/Modules/gamepad/GamepadList.idl.
* Modules/gamepad/deprecated/NavigatorGamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
* Modules/gamepad/deprecated/NavigatorGamepad.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
* Modules/gamepad/deprecated/NavigatorGamepad.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.

* platform/Gamepads.h:
* platform/efl/GamepadsEfl.cpp:
* platform/gtk/GamepadsGtk.cpp:
* platform/linux/GamepadDeviceLinux.cpp:
* platform/linux/GamepadDeviceLinux.h:

Source/WebKit/mac:
-Move some implementation files into a "deprecated" subdirectory.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:
-Move some implementation files into a "deprecated" subdirectory.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:
-Move some implementation files into a "deprecated" subdirectory.

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement more of HistoryEntryDataDecoder
andersca@apple.com [Sat, 21 Jun 2014 18:52:38 +0000 (18:52 +0000)]
Implement more of HistoryEntryDataDecoder
https://bugs.webkit.org/show_bug.cgi?id=134146

Reviewed by Sam Weinig.

* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decode):
(WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::alignBufferPosition):
(WebKit::HistoryEntryDataDecoder::alignedBuffer):
(WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMark TextRun's constructors as explicit
mmaxfield@apple.com [Sat, 21 Jun 2014 18:27:21 +0000 (18:27 +0000)]
Mark TextRun's constructors as explicit
https://bugs.webkit.org/show_bug.cgi?id=134124

Reviewed by Sam Weinig.

After r170072, nobody is implicitly converting a string to a TextRun. Therefore,
we can make the constructors explicit.

No new tests because there is no behavior change.

* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r170244.
commit-queue@webkit.org [Sat, 21 Jun 2014 16:24:46 +0000 (16:24 +0000)]
Unreviewed, rolling out r170244.
https://bugs.webkit.org/show_bug.cgi?id=134157

GTK/EFL bindings generator works differently, making this
patch not work there.  Will fix entire patch after a rollout.
(Requested by bradee-oh on #webkit).

Reverted changeset:

"Gamepad API - Deprecate the existing implementation"
https://bugs.webkit.org/show_bug.cgi?id=134108
http://trac.webkit.org/changeset/170244

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the mismatched header build guards in WebKitDOMNodeFilterPrivate.h
zandobersek@gmail.com [Sat, 21 Jun 2014 15:55:35 +0000 (15:55 +0000)]
Fix the mismatched header build guards in WebKitDOMNodeFilterPrivate.h
which are throwing compilation warnings when building with Clang.

* bindings/gobject/WebKitDOMNodeFilterPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGamepad API - Deprecate the existing implementation
beidson@apple.com [Sat, 21 Jun 2014 15:43:49 +0000 (15:43 +0000)]
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108

Reviewed by Timothy Hatcher.

-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
-Add the "Deprecated" suffix to some implementation files

.:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:

Source/WebCore:
* CMakeLists.txt:
* PlatformGTK.cmake:
* Configurations/FeatureDefines.xcconfig:

* Modules/gamepad/GamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
* Modules/gamepad/GamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
* Modules/gamepad/GamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.

* Modules/gamepad/GamepadList.cpp:
* Modules/gamepad/GamepadList.h:
* Modules/gamepad/GamepadList.idl:

* Modules/gamepad/NavigatorGamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
* Modules/gamepad/NavigatorGamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
* Modules/gamepad/NavigatorGamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.

* platform/Gamepads.h:
* platform/efl/GamepadsEfl.cpp:
* platform/gtk/GamepadsGtk.cpp:
* platform/linux/GamepadDeviceLinux.cpp:
* platform/linux/GamepadDeviceLinux.h:

Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:

Source/WTF:
* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics][WK2][EFL] Page is moved to (0,0) position before rendering...
gyuyoung.kim@samsung.com [Sat, 21 Jun 2014 15:06:00 +0000 (15:06 +0000)]
[CoordinatedGraphics][WK2][EFL] Page is moved to (0,0) position before rendering content
https://bugs.webkit.org/show_bug.cgi?id=133300

Reviewed by Csaba Osztrogonác.

When new page is loaded, PageViewportController::didCommitLoad() calls PageViewportController::syncVisibleContents()
with initial position via applyPositionAfterRenderingContents() before starting to render
new page by PageViewportController::didRenderFrame(). This call flow causes that webview shows
incomplete tiles to the user during a few milliseconds. To fix showing incomplete tiles during
the page loading, this patch adds a flag so that we don't show the incomplete tiles until showing
new page.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
* UIProcess/API/efl/EwkView.h:
(EwkView::setWaitingForNewPage):
(EwkView::waitingForNewPage):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r170228.
commit-queue@webkit.org [Sat, 21 Jun 2014 15:02:20 +0000 (15:02 +0000)]
Unreviewed, rolling out r170228.
https://bugs.webkit.org/show_bug.cgi?id=134155

Caused 9 layout test failures on Mountain Lion
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/19216
(Requested by bradee-oh on #webkit).

Reverted changeset:

"[Mac] Margins for new form controls need tweaking"
https://bugs.webkit.org/show_bug.cgi?id=134135
http://trac.webkit.org/changeset/170228

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Create and attach the AVPlayerLayer to the AVPlayer immediately if the media...
jer.noble@apple.com [Sat, 21 Jun 2014 14:59:07 +0000 (14:59 +0000)]
[Mac] Create and attach the AVPlayerLayer to the AVPlayer immediately if the media element is <video>.
https://bugs.webkit.org/show_bug.cgi?id=134131

Reviewed by Eric Carlson.

The AVPlayer uses the presence of an AVPlayerLayer to decide which alternate to display in the case of
HLS streams with audio-only alternates. To give the AVPlayer the most information with which to make its
decision, always create and attach an AVPlayerLayer before attaching an AVPlayerItem to the AVPlayerLayer.
In addition, retrieve the <video> element bounds and create an AVPlayerLayer with a matching size, so that
the AVPlayer can choose an alternate with the correct dimensions.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: UI fonts should pull from system fonts automatically to whatever degre...
jonowells@apple.com [Sat, 21 Jun 2014 14:55:48 +0000 (14:55 +0000)]
Web Inspector: UI fonts should pull from system fonts automatically to whatever degree possible
https://bugs.webkit.org/show_bug.cgi?id=133966

Reviewed by Timothy Hatcher.

Updated font families to use -webkit-system-font, and set this on the body to be
inherited. Also made sure that popovers use Menlo as the default. Updated
autocompletions with system font names.

* UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.

* UserInterface/Controllers/CodeMirrorGradientEditingController.css:
* UserInterface/Views/Breakpoint.css:
* UserInterface/Views/ButtonNavigationItem.css:
* UserInterface/Views/ButtonToolbarItem.css:
* UserInterface/Views/CSSStyleDeclarationSection.css:
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
* UserInterface/Views/CodeMirrorOverrides.css:
* UserInterface/Views/DataGrid.css:
* UserInterface/Views/DebuggerDashboardView.css:
* UserInterface/Views/DetailsSection.css:
* UserInterface/Views/FindBanner.css:
* UserInterface/Views/GoToLineDialog.css:
* UserInterface/Views/HierarchicalPathComponent.css:
* UserInterface/Views/Main.css:
* UserInterface/Views/NavigationSidebarPanel.css:
* UserInterface/Views/ProbeSetDataGrid.css:
* UserInterface/Views/RulesStyleDetailsPanel.css:
* UserInterface/Views/ScopeBar.css:
* UserInterface/Views/SourceCodeTextEditor.css:
* UserInterface/Views/TimelineDataGrid.css:
* UserInterface/Views/TimelineRuler.css:
* UserInterface/Views/TimelineSidebarPanel.css:
Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement ios -[WAKWindow convertBaseToScreen:]
commit-queue@webkit.org [Sat, 21 Jun 2014 14:52:31 +0000 (14:52 +0000)]
Implement ios -[WAKWindow convertBaseToScreen:]
https://bugs.webkit.org/show_bug.cgi?id=134053

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-21
Reviewed by Eric Carlson.

* platform/ios/wak/WAKWindow.mm:
(-[WAKWindow convertBaseToScreen:]):
Traverse layer hierarchy and convert point.

(-[WAKWindow convertScreenToBase:]):
Traverse layer hierarchy and convert point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Esc in quick console no longer toggles console drawer
commit-queue@webkit.org [Sat, 21 Jun 2014 14:51:12 +0000 (14:51 +0000)]
Web Inspector: Esc in quick console no longer toggles console drawer
https://bugs.webkit.org/show_bug.cgi?id=134068

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-06-21
Reviewed by Timothy Hatcher.

For Escape to toggle console behavior we were relying on the Escape
keyboard event to propagate up to the window and be handled by
QuickConsole's global keyboard shortcut. With CodeMirror 4, all
editors have a default "Esc" key handler to reduce multiple selections
to a single selection. Unfortunately this always prevents default,
which our keyboard shortcut respects and doesn't toggle the console.

Workaround this by putting a specific handler for when a Console
Prompt is empty and the Escape key is triggered. This does not go
through the normal ConsolePrompt delegate because the delegate
is never the QuickConsole, it is actually the JavaScript log.

* UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
(WebInspector.ConsolePrompt.prototype.set escapeKeyHandlerWhenEmpty):
(WebInspector.ConsolePrompt.prototype._handleEscapeKey):
* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.this.prompt.escapeKeyHandlerWhenEmpty):
(WebInspector.QuickConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCommit queue has been failing due to a build failure in WKFoundation.h
beidson@apple.com [Sat, 21 Jun 2014 14:43:35 +0000 (14:43 +0000)]
Commit queue has been failing due to a build failure in WKFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=134152

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2014-06-21
Reviewed by Csaba Osztrogonác.
Landed by Brady Eidson.

The build failure was caused by WKFoundation.h erroneously redefining
NSURLSessionAuthChallengeDisposition even when building with 10.9 SDK.

The availability of this type depends on the version of SDK,
not the target operating system.

* Shared/API/Cocoa/WKFoundation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Inspector][EFL] Can't resume a special break point on EFL inspector
ossy@webkit.org [Sat, 21 Jun 2014 08:53:20 +0000 (08:53 +0000)]
[Inspector][EFL] Can't resume a special break point on EFL inspector
https://bugs.webkit.org/show_bug.cgi?id=129294

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gyuyoung Kim.

Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
by Ryuan Choi - <https://phab.enlightenment.org/D790>

* efl/jhbuild.modules:
* efl/patches/ecore.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving PAGE_VISIBILITY_API compile guard.
ossy@webkit.org [Sat, 21 Jun 2014 08:49:35 +0000 (08:49 +0000)]
Removing PAGE_VISIBILITY_API compile guard.
https://bugs.webkit.org/show_bug.cgi?id=133844

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gavin Barraclough.

.:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:

Source/WebCore:
No new tests because no functional changes.

* Configurations/FeatureDefines.xcconfig:
* Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
* dom/Document.cpp:
(WebCore::Document::hidden):
* dom/Document.h:
* dom/Document.idl:
* dom/Element.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
* page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
* page/Page.h:
* page/PageVisibilityState.cpp:
* page/PageVisibilityState.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled):
* page/Settings.h:
* platform/audio/MediaSession.cpp:
(WebCore::MediaSession::updateClientDataBuffering):
* platform/audio/MediaSession.h:

Source/WebKit/efl:
* ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):

Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _visibilityState]):

Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WTF:
* wtf/FeatureDefines.h:

Tools:
* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:
* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoARM traditional buildfix after r169942.
ossy@webkit.org [Sat, 21 Jun 2014 08:46:39 +0000 (08:46 +0000)]
ARM traditional buildfix after r169942.
https://bugs.webkit.org/show_bug.cgi?id=134100

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::abortWithReason): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][EFL] Use OpenType MATH fonts by default.
fred.wang@free.fr [Sat, 21 Jun 2014 08:07:37 +0000 (08:07 +0000)]
[GTK][EFL] Use OpenType MATH fonts by default.
https://bugs.webkit.org/show_bug.cgi?id=133604

Reviewed by Chris Fleizach.

In order to support stretching of horizontal operators and large
operators in display mode as well as to improve the drawing of radicals,
we need to use an OpenType MATH table. This commit makes the MathML code
try "Latin Modern Math" first, which is an OpenType version of Knuth's
popular Computer Modern font and is packaged with most TeX
distributions (e.g. TeX Live on Linux). This should work well on the
EFL & GTK ports for which the initial OpenType MATH support has been
tested. Other ports will be handled later.

No new tests. This is already tested in LayoutTests/mathml/opentype/.

* css/mathml.css:
(math): Add "Latin Modern Math" as the first font-family of the <math> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove latinmodern-math.woff from LayoutTests/mathml/opentype
fred.wang@free.fr [Sat, 21 Jun 2014 06:04:26 +0000 (06:04 +0000)]
Remove latinmodern-math.woff from LayoutTests/mathml/opentype
https://bugs.webkit.org/show_bug.cgi?id=134094

Reviewed by Martin Robinson.

We remove latinmodern-math.woff from the source and make mathml/opentype/*LatinModern* tests not font-specific, so that each platform will use whatever OpenType MATH is available.
Until bug 133604 is fixed and Latin Modern Math installed on the Linux bots, the tests are marked as failed. More generally, we need to fix bug 133603.
The test mathml/opentype/roots-LatinModern is removed since it will duplicate mathml/presentation/roots.xhtml when OpenType MATH fonts are available.

* mathml/opentype/LICENSE-LatinModern.txt: Removed.
* mathml/opentype/horizontal-munderover.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern-munderover.html.
* mathml/opentype/horizontal.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern.html.
* mathml/opentype/large-operators-LatinModern.html: Removed.
* mathml/opentype/large-operators.html: Added.
* mathml/opentype/latinmodern-math.woff: Removed.
* mathml/opentype/opentype-stretchy-horizontal.html:
* mathml/opentype/roots-LatinModern.html: Removed.
* mathml/opentype/vertical.html: Renamed from LayoutTests/mathml/opentype/vertical-LatinModern.html.
* platform/efl/TestExpectations:
* platform/efl/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt.
* platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
* platform/efl/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.png.
* platform/efl/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt.
* platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Removed.
* platform/efl/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.png.
* platform/efl/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.txt.
* platform/gtk/TestExpectations:
* platform/gtk/mathml/opentype/horizontal-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.png.
* platform/gtk/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.txt.
* platform/gtk/mathml/opentype/horizontal-munderover-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.png.
* platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
* platform/gtk/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.png.
* platform/gtk/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.txt.
* platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Removed.
* platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Removed.
* platform/gtk/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.png.
* platform/gtk/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.txt.
* platform/mac-wk2/mathml/opentype/large-operators-LatinModern-expected.txt: Removed.
* platform/mac-wk2/mathml/opentype/vertical-LatinModern-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-expected.txt.
* platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
* platform/mac/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/large-operators-LatinModern-expected.txt.
* platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Removed.
* platform/mac/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/vertical-LatinModern-expected.txt.
* platform/win/TestExpectations:
* platform/win/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-expected.txt.
* platform/win/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
* platform/win/mathml/opentype/roots-LatinModern-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Remove WebKit1 test results
ryuan.choi@samsung.com [Sat, 21 Jun 2014 06:00:37 +0000 (06:00 +0000)]
[EFL] Remove WebKit1 test results
https://bugs.webkit.org/show_bug.cgi?id=134137

Reviewed by Daniel Bates.

* platform/efl-wk1: Removed entire directory which contains the WebKit1 EFL test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Remove DumpRenderTree/efl and EWebLauncher
ryuan.choi@samsung.com [Sat, 21 Jun 2014 05:53:30 +0000 (05:53 +0000)]
[EFL] Remove DumpRenderTree/efl and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=134138

Reviewed by Gyuyoung Kim.

DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.

* CMakeLists.txt:
* DumpRenderTree/PlatformEfl.cmake: Removed.
* DumpRenderTree/efl: Removed entire directory.
* EWebLauncher: Ditto.
* WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):
* WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
* WebKitTestRunner/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL build fix since r170224.
gyuyoung.kim@samsung.com [Sat, 21 Jun 2014 05:09:38 +0000 (05:09 +0000)]
Unreviewed EFL build fix since r170224.

Add retainPlatformLayer() and releasePlatformLayer() in ScrollingStateNodeCoordinatedGraphics.cpp
as well. Thouse functions were missed in r170224.

* page/scrolling/ScrollingStateNode.h:
* page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp:
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Margins for new form controls need tweaking
dino@apple.com [Sat, 21 Jun 2014 03:10:15 +0000 (03:10 +0000)]
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>

Reviewed by Sam Weinig.

Source/WebCore:
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.

This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.

* platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.

LayoutTests:
Rebaseline a bunch of results since some <input> dimensions
changed slightly.

* platform/mac/css1/box_properties/acid_test-expected.png:
* platform/mac/css1/box_properties/acid_test-expected.txt:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/mac/fast/block/basic/011-expected.png:
* platform/mac/fast/block/basic/011-expected.txt:
* platform/mac/fast/block/margin-collapse/103-expected.png:
* platform/mac/fast/block/margin-collapse/103-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.png:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove-expected.txt:
* platform/mac/fast/forms/formmove2-expected.png:
* platform/mac/fast/forms/formmove2-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.png:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/width100percent-radio-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix css jit on armv7.
benjamin@webkit.org [Sat, 21 Jun 2014 02:33:04 +0000 (02:33 +0000)]
Fix css jit on armv7.
https://bugs.webkit.org/show_bug.cgi?id=134143
<rdar://problem/17348060>

Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-20
Reviewed by Benjamin Poulain.

This fixes the acid3 test.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Correct high and low bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement more of LegacySessionStateDecoder
andersca@apple.com [Sat, 21 Jun 2014 00:11:57 +0000 (00:11 +0000)]
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134145

Reviewed by Sam Weinig.

* Shared/SessionState.h:
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::finishDecoding):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
* UIProcess/mac/LegacySessionStateCoding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement more of LegacySessionStateDecoder
andersca@apple.com [Fri, 20 Jun 2014 23:48:37 +0000 (23:48 +0000)]
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134144

Reviewed by Sam Weinig.

* Shared/SessionState.cpp:
(WebKit::BackForwardListState::encode):
(WebKit::SessionState::encode): Deleted.
* Shared/SessionState.h:
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionState):
(WebKit::LegacySessionStateDecoder::decodeSessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
* UIProcess/mac/LegacySessionStateCoding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttps://bugs.webkit.org/show_bug.cgi?id=134117
bdakin@apple.com [Fri, 20 Jun 2014 23:44:01 +0000 (23:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=134117
Unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode()
from messaging a deleted Obj-C object
-and corresponding-
<rdar://problem/17149252>

Reviewed by Simon Fraser.

This is a speculative fix. It makes LayerRepresentation retain m_platformLayer.

* WebCore.exp.in:
* page/scrolling/ScrollingStateNode.h:
(WebCore::LayerRepresentation::LayerRepresentation):
(WebCore::LayerRepresentation::~LayerRepresentation):
(WebCore::LayerRepresentation::operator=):
(WebCore::LayerRepresentation::operator==):
(WebCore::LayerRepresentation::operator ==): Deleted.

Make this ASSERT an ASSERT_WITH_SECURITY_IMPLICATION
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):

Moved ScrollingStateNodeMac.mm, which was empty anyway, to cocoa/
ScrollingStateNode.mm so that iOS can use it too.
* page/scrolling/cocoa: Added.
* page/scrolling/cocoa/ScrollingStateNode.mm: Copied from page/scrolling/mac/ScrollingStateNodeMac.mm.

Actual implementation for retain and release.
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):

Deleted.
* page/scrolling/mac/ScrollingStateNodeMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. build fix for the cmake based ports since r170188
ryuan.choi@samsung.com [Fri, 20 Jun 2014 23:40:21 +0000 (23:40 +0000)]
Unreviewed. build fix for the cmake based ports since r170188

* CMakeLists.txt: Added LegacySessionState.cpp in source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] No way to get the main frame’s main resource’s data
mitz@apple.com [Fri, 20 Jun 2014 23:37:38 +0000 (23:37 +0000)]
[Cocoa] No way to get the main frame’s main resource’s data
https://bugs.webkit.org/show_bug.cgi?id=134113

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getMainResourceDataWithCompletionHandler:]): Added. Calls
WebPageProxy::getMainResourceDataOfFrame and invokes the completion handler form the
callback.
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new method.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getMainResourceDataOfFrame): Made it safe to pass a NULL frame into
this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoName moving. Unreviewed.
zalan@apple.com [Fri, 20 Jun 2014 23:21:51 +0000 (23:21 +0000)]
Name moving. Unreviewed.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIntroduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls...
zalan@apple.com [Fri, 20 Jun 2014 22:57:42 +0000 (22:57 +0000)]
Introduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls with
LayoutPoint(0, 0) as parameter more explicit.
https://bugs.webkit.org/show_bug.cgi?id=134092

Reviewed by Simon Fraser.

Most of the RenderLayer::convertToLayerCoords() callers are only interested in
the offset from the ancestor layer by passing LayoutPoint(0, 0) as the coordinate to convert.
Introducing offsetFromAncestorLayer() makes those calls more explicit/self-explanatory.
It helps simplifying the callsite's code.

No change in functionality.

* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeOffsetFromRoot):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestorLayer):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGeometry):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIntroduce a WKSessionStateRef object
andersca@apple.com [Fri, 20 Jun 2014 22:46:30 +0000 (22:46 +0000)]
Introduce a WKSessionStateRef object
https://bugs.webkit.org/show_bug.cgi?id=134136

Reviewed by Tim Horton.

WKSessionStateRef is going to hold session state, making it possible to migrate state from one
webpage to another without having to do any serialization/deserialization.

* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/SessionState.cpp:
(WebKit::SessionState::encode):
* Shared/SessionState.h:
* UIProcess/API/APISessionState.cpp: Added.
(API::SessionState::create):
(API::SessionState::SessionState):
(API::SessionState::~SessionState):
* UIProcess/API/APISessionState.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
* UIProcess/API/C/WKSessionStateRef.h:
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::~LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::decodeSessionState):
* UIProcess/mac/LegacySessionStateCoding.h:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS WebKit2: selection handles become too large when zooming a page.
enrica@apple.com [Fri, 20 Jun 2014 22:42:06 +0000 (22:42 +0000)]
iOS WebKit2: selection handles become too large when zooming a page.
https://bugs.webkit.org/show_bug.cgi?id=134084
<rdar://problem/16799164>

Reviewed by Benjamin Poulain.

Since the document view is zoomed, we add a subview that has the inverse transform
of the document view. This new view becomes the root for the selection hierarchy.
The new view has zero size, not to interfere with the existing gestures on the WKContenView
therefore we implement hitTest to detect interaction with the selection elements.

* UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView hitTest:withEvent:::]):
(-[WKContentView selectedTextRange]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSnapshotting WKThumbnailViews should not tell Web processes backing unparented WKView...
timothy_horton@apple.com [Fri, 20 Jun 2014 22:40:30 +0000 (22:40 +0000)]
Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
https://bugs.webkit.org/show_bug.cgi?id=134134
<rdar://problem/17402119>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setThumbnailView:]):
Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
expensive things in the Web process which we can avoid if using snapshots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKThumbnailView should only use live layer trees before the snapshot arrives for...
timothy_horton@apple.com [Fri, 20 Jun 2014 22:38:21 +0000 (22:38 +0000)]
WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
https://bugs.webkit.org/show_bug.cgi?id=134129
<rdar://problem/17401591>

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView initWithFrame:fromWKView:]):
Add a white background to WKThumbnailView, so that if we have no snapshot and no layer tree,
the view isn't transparent.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateThumbnailViewLayer]):
We currently pull the live layer tree into the WKThumbnailView even in snapshot mode,
before the snapshot arrives, to avoid flashing when transitioning a live WKView to a thumbnail view.
This is, however, not useful for unparented WKViews, because their layer tree will be detached
and we'll flash anyway. So, only do that when the WKView is parented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebKit delegate methods should document their default behaviors
ggaren@apple.com [Fri, 20 Jun 2014 22:10:37 +0000 (22:10 +0000)]
WebKit delegate methods should document their default behaviors
https://bugs.webkit.org/show_bug.cgi?id=134132

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKNavigationDelegate.h:
* UIProcess/API/Cocoa/WKUIDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix lots of WK2 test crashes.
simon.fraser@apple.com [Fri, 20 Jun 2014 22:06:11 +0000 (22:06 +0000)]
Fix lots of WK2 test crashes.

We don't always have a ScrollingCoordinator.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways use XPC on iOS
andersca@apple.com [Fri, 20 Jun 2014 22:05:04 +0000 (22:05 +0000)]
Always use XPC on iOS
https://bugs.webkit.org/show_bug.cgi?id=134130

Reviewed by Sam Weinig.

* UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
(WebKit::shouldUseXPC): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build.
andersca@apple.com [Fri, 20 Jun 2014 22:00:35 +0000 (22:00 +0000)]
Fix build.

* Shared/SessionState.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd ArgumentEncoder support to PageState and friends
andersca@apple.com [Fri, 20 Jun 2014 21:55:19 +0000 (21:55 +0000)]
Add ArgumentEncoder support to PageState and friends
https://bugs.webkit.org/show_bug.cgi?id=134128

Reviewed by Andreas Kling.

Change the classes to structs, get rid of the constructors/destructors
and add encode member functions.

* Shared/SessionState.cpp:
(WebKit::HTTPBody::Element::encode):
(WebKit::HTTPBody::encode):
(WebKit::FrameState::encode):
(WebKit::PageState::encode):
(WebKit::HTTPBody::Element::Element): Deleted.
(WebKit::HTTPBody::Element::~Element): Deleted.
(WebKit::FrameState::FrameState): Deleted.
(WebKit::FrameState::~FrameState): Deleted.
(WebKit::PageState::PageState): Deleted.
(WebKit::PageState::~PageState): Deleted.
* Shared/SessionState.h:
(WebKit::HTTPBody::Element::type): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd encoding and decoding support for WTF::Optional
andersca@apple.com [Fri, 20 Jun 2014 21:36:36 +0000 (21:36 +0000)]
Add encoding and decoding support for WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134125

Reviewed by Andreas Kling.

Source/WebKit2:
* Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<WTF::Optional<T>>::encode):
(IPC::ArgumentCoder<WTF::Optional<T>>::decode):

Source/WTF:
* wtf/Optional.h:
(WTF::Optional::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving dead code in platform/graphics/gpu
mmaxfield@apple.com [Fri, 20 Jun 2014 21:21:00 +0000 (21:21 +0000)]
Removing dead code in platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=134065

Reviewed by Simon Fraser.

No new tests because there is no behavior change.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/LoopBlinnClassifier.cpp: Removed.
* platform/graphics/gpu/LoopBlinnClassifier.h: Removed.
* platform/graphics/gpu/LoopBlinnConstants.h: Removed.
* platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Removed.
* platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Removed.
* platform/graphics/gpu/LoopBlinnMathUtils.cpp: Removed.
* platform/graphics/gpu/LoopBlinnMathUtils.h: Removed.
* platform/graphics/gpu/LoopBlinnPathCache.cpp: Removed.
* platform/graphics/gpu/LoopBlinnPathCache.h: Removed.
* platform/graphics/gpu/LoopBlinnPathProcessor.h: Removed.
* platform/graphics/gpu/LoopBlinnShader.cpp: Removed.
* platform/graphics/gpu/LoopBlinnShader.h: Removed.
* platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Removed.
* platform/graphics/gpu/LoopBlinnSolidFillShader.h: Removed.
* platform/graphics/gpu/LoopBlinnTextureCoords.cpp: Removed.
* platform/graphics/gpu/LoopBlinnTextureCoords.h: Removed.
* platform/graphics/gpu/Shader.cpp: Removed.
* platform/graphics/gpu/Shader.h: Removed.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
* platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
* platform/graphics/gpu/mac/DrawingBufferMac.mm: Removed.
* platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Removed.
* platform/graphics/gpu/opencl/FilterContextOpenCL.h: Removed.
* platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Removed.
* platform/graphics/gpu/opencl/OpenCLHandle.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Support Khmer and Lao fallback fonts
mmaxfield@apple.com [Fri, 20 Jun 2014 21:17:39 +0000 (21:17 +0000)]
[iOS] Support Khmer and Lao fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=134114

Reviewed by Enrica Casucci.

Source/WebCore:
iOS has fonts which have glyphs for the Khmer and Lao languages.

This patch also does a little refactoring of the language-specific fallback
font path to increase readability.

Test: fast/text/khmer-lao-font.html

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:
Simply dump the render tree of a page that includes Khmer and Lao text. The success
of this test depends on font font metrics being different than system fallback font
(which just shows rectangles instead of glyphs).

* fast/text/khmer-lao-font.html: Added.
* platform/ios-sim/fast/text/khmer-lao-font-expected.txt: Added.
* platform/mac/fast/text/khmer-lao-font-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Adding myself to committers.
jfernandez@igalia.com [Fri, 20 Jun 2014 21:08:37 +0000 (21:08 +0000)]
Unreviewed. Adding myself to committers.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGive NPAPI post requests a default content type
andersca@apple.com [Fri, 20 Jun 2014 21:03:37 +0000 (21:03 +0000)]
Give NPAPI post requests a default content type
https://bugs.webkit.org/show_bug.cgi?id=134120

Reviewed by Andreas Kling.

Source/WebCore:
* WebCore.exp.in:

Source/WebKit2:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways commit the scrolling tree when we flush layers
simon.fraser@apple.com [Fri, 20 Jun 2014 21:00:53 +0000 (21:00 +0000)]
Always commit the scrolling tree when we flush layers
https://bugs.webkit.org/show_bug.cgi?id=134115

Reviewed by Beth Dakin.

The scrolling state tree contains bare pointers to GraphicsLayers, which get
converted to CALayers at commit time. To avoid a window of time where those
GraphicsLayer pointers go stale, commit the scrolling tree whenever we flush the
compositing layer tree.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r169972): fix issue when removing masks from compositing layers
simon.fraser@apple.com [Fri, 20 Jun 2014 20:56:16 +0000 (20:56 +0000)]
REGRESSION (r169972): fix issue when removing masks from compositing layers
https://bugs.webkit.org/show_bug.cgi?id=134118
<rdar://problem/17366654>

Reviewed by Dean Jackson.

Source/WebCore:
After r169972 when removing the mask, we could destroy the mask
layer before the call into m_graphicsLayer->setMaskLayer(), which would
try to call functions on the old mask. Fix by clearing the mask layer
on the GraphicsLayer before the mask layer gets destroyed.

Test: compositing/masks/toggle-mask.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateMaskLayer):
* rendering/RenderLayerBacking.h:

LayoutTests:
Test that toggles the mask on a composited element.

* compositing/masks/toggle-mask-expected.txt: Added.
* compositing/masks/toggle-mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd copy/move constructors and assignment operators to WTF::Optional
andersca@apple.com [Fri, 20 Jun 2014 20:54:57 +0000 (20:54 +0000)]
Add copy/move constructors and assignment operators to WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134119

Reviewed by Andreas Kling.

* wtf/Optional.h:
(WTF::Optional::Optional):
(WTF::Optional::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Release freed up blocks from the JS heap after simulated memory pressure.
akling@apple.com [Fri, 20 Jun 2014 20:48:13 +0000 (20:48 +0000)]
[Cocoa] Release freed up blocks from the JS heap after simulated memory pressure.
<https://webkit.org/b/134112>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:
* heap/BlockAllocator.h:

Source/WebCore:
* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove redundant RenderLayer::computeOffsetFromRoot() function.
zalan@apple.com [Fri, 20 Jun 2014 20:36:44 +0000 (20:36 +0000)]
Remove redundant RenderLayer::computeOffsetFromRoot() function.
https://bugs.webkit.org/show_bug.cgi?id=134088

Reviewed by Benjamin Poulain.

No change in functionality.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::computeOffsetFromRoot): Deleted.
* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Adding myself to committers.
utatane.tea@gmail.com [Fri, 20 Jun 2014 20:22:50 +0000 (20:22 +0000)]
Unreviewed. Adding myself to committers.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord...
simon.fraser@apple.com [Fri, 20 Jun 2014 19:16:30 +0000 (19:16 +0000)]
[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
https://bugs.webkit.org/show_bug.cgi?id=134085

Source/WebCore:
<rdar://problem/16440586>

Reviewed by Tim Horton.

When nodes were detached from the scrolling tree, we would previously throw away
all descendant nodes, expecting that they would be re-attached as we walk the compositing
layer tree in RenderLayerCompositor.

However, this doesn't work across frame boundaries; the subframe may never update
its compositing layers again, so would lose all its scrolling nodes.

Fix by having ScrollingStateTree::detachNode() by default set aside subframe nodes
into a hash map. On reattach, we'll look in the hash map and pull out an existing node
(with its children intact) if possible.

Tests: platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html
       platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html
       platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html

* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
* page/scrolling/ScrollingStateTree.h:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState): Go back to removing the deleted
nodes from m_nodeMap first.
(WebCore::ScrollingTree::removeDestroyedNodes): There is no need for this to
actually make use of ScrollingTreeNode* any more; the ASSERT(!node->parent())
is bogus because it can fire when whole subtrees are removed, and to clear the
latched node we just need the ID.

Source/WebKit2:
<rdar://problem/16440586>

Reviewed by Tim Horton.

Add some debug-only assertions that check that the number of nodes we encoded is
the expected number.

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):

LayoutTests:

Reviewed by Tim Horton.

Tests that add and remove a fixed container of a scroll-coordinated iframe.

* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHandle scrolling tree modifications which remove intermediate nodes
simon.fraser@apple.com [Fri, 20 Jun 2014 19:14:50 +0000 (19:14 +0000)]
Handle scrolling tree modifications which remove intermediate nodes
https://bugs.webkit.org/show_bug.cgi?id=134082

Reviewed by Tim Horton.

When updating the scrolling tree from the state tree, we failed to maintain
the children arrays correctly. Fix by removing all children on scrolling nodes,
and allowing the calls on children to add them back. A temporary hash map
keeps the nodes alive.

The state tree's m_nodesRemovedSinceLastCommit was also made into a HashSet,
to make it easier to handle removal followed by re-insertion.

Source/WebCore:
* WebCore.exp.in:
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode): If a node is (possibly re-)added,
remove it from m_nodesRemovedSinceLastCommit.remove.
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::setRemovedNodes):
* page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::removedNodes):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode): Clean up to have only one call
to updateBeforeChildren(), and remove all children from the scrolling node
before visiting state children.
(WebCore::ScrollingTree::removeDestroyedNodes): It was very wrong to assume
that all non-root nodes were parented in the root! Now we don't need to
remove from the parent anyway.
* page/scrolling/ScrollingTree.h:
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::children):

Source/WebKit2:
* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170197 268f45cc-cd09-0410-ab3c-d52691b4dbfc