WebKit-https.git
10 years agoUnreviewed, adding myself to reviewers list.
slewis@apple.com [Wed, 14 Oct 2009 01:54:47 +0000 (01:54 +0000)]
Unreviewed, adding myself to reviewers list.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix null assignment so root tests work again.
slewis@apple.com [Wed, 14 Oct 2009 01:52:00 +0000 (01:52 +0000)]
Fix null assignment so root tests work again.

Reviewed by Mark Rowe.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix DumpRenderTree to account for API changes in the user script stuff.
hyatt@apple.com [Wed, 14 Oct 2009 01:38:04 +0000 (01:38 +0000)]
Fix DumpRenderTree to account for API changes in the user script stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Change the order of arguments on some of the user stylesheet/script function...
hyatt@apple.com [Wed, 14 Oct 2009 01:37:13 +0000 (01:37 +0000)]
WebCore: Change the order of arguments on some of the user stylesheet/script functions.  Split the removal functions
out into separate ones for scripts and stylesheets.

Reviewed by Adam Roben.

* WebCore.base.exp:
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
* page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):

WebKit/mac: Change the order of arguments on some methods.  Split removal for user stylesheets and script into
separate functions based off the type of object being removed.

Reviewed by Adam Roben.

* WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
* WebView/WebViewPrivate.h:

WebKit/win: Split removal functions for user scripts and stylehseets based on type.

Reviewed by Adam Roben..

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChrome's "Skia" theme paints select controls backwards in RTL.
dimich@chromium.org [Wed, 14 Oct 2009 01:16:01 +0000 (01:16 +0000)]
Chrome's "Skia" theme paints select controls backwards in RTL.

Patch by Evan Martin <evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=30320

Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)

* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30318
dimich@chromium.org [Wed, 14 Oct 2009 01:15:53 +0000 (01:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.

Reviewed by Alexey Proskuryakov.

WebCore:

Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.

* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.

All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

LayoutTests:

Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.

* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Jon Honeycutt.
bweinstein@apple.com [Wed, 14 Oct 2009 00:41:57 +0000 (00:41 +0000)]
Rubber-stamped by Jon Honeycutt.

Add trailing newline to the Windows Skipped List.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd bug number to previous ChangeLog entry.
bweinstein@apple.com [Wed, 14 Oct 2009 00:36:05 +0000 (00:36 +0000)]
Add bug number to previous ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Anders Carlsson.
bweinstein@apple.com [Wed, 14 Oct 2009 00:34:42 +0000 (00:34 +0000)]
Rubber-stamped by Anders Carlsson.

Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 13 Oct 2009 23:58:45 +0000 (23:58 +0000)]
2009-10-13  Simon Fraser  <simon.fraser@apple.com>

        Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable SHARED_WORKERS for Chromium
atwilson@chromium.org [Tue, 13 Oct 2009 23:39:42 +0000 (23:39 +0000)]
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289

Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.

WebCore:

Cleaned up bitrot in SharedWorker V8 bindings.

* WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
* bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
* bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
* bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
* bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
* bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
* page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.

WebKit:

* chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 13 Oct 2009 23:36:15 +0000 (23:36 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=30345
        HTTP tests for credential handling fail on Tiger

        We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
        let it do its work without intervention. Once again, we pass explicitly passed credentials
        in URL, fixing regressions from Safari 3.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Tue, 13 Oct 2009 23:19:28 +0000 (23:19 +0000)]
2009-10-13  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Adam Barth.

        Bug 28964 -  [Chromium] ChromiumDataObject should have getter/setter interface

        Reworked and added to the getter/setter interface in ChromiumDataObject:
        - added contains...() methods to just query the state
        - added containsValid...URL() methods for URL data members
        - removed takeFileNames() as this was too type-dependent
        - changed return type of fileNames() to Vector<String>
        - added interface methods to allow appending to and iteration over file names

        No new tests (no functional behavior changed).

        * platform/chromium/ChromiumDataObject.h:
        (WebCore::ChromiumDataObject::containsMainURL):
        (WebCore::ChromiumDataObject::containsValidMainURL):
        (WebCore::ChromiumDataObject::containsMainURLTitle):
        (WebCore::ChromiumDataObject::containsTextPlain):
        (WebCore::ChromiumDataObject::containsTextHTML):
        (WebCore::ChromiumDataObject::containsHTMLBaseURL):
        (WebCore::ChromiumDataObject::containsValidHTMLBaseURL):
        (WebCore::ChromiumDataObject::containsContent):
        (WebCore::ChromiumDataObject::containsContentFileExtension):
        (WebCore::ChromiumDataObject::containsContentFileName):
        (WebCore::ChromiumDataObject::setContentFileName):
        (WebCore::ChromiumDataObject::containsFileNames):
        (WebCore::ChromiumDataObject::fileNames):
        (WebCore::ChromiumDataObject::clearFileNames):
        (WebCore::ChromiumDataObject::countFileNames):
        (WebCore::ChromiumDataObject::fileNameAt):
        (WebCore::ChromiumDataObject::setFileNames):
        (WebCore::ChromiumDataObject::appendToFileNames):
        (WebCore::ChromiumDataObject::popFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 13 Oct 2009 22:53:34 +0000 (22:53 +0000)]
2009-10-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Visibility:visible inside a compositing layer doesn't make the element visible
        https://bugs.webkit.org/show_bug.cgi?id=30339

        When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
        only consulted hasVisibleContent(), which does not take into a account child layers which
        may be visible. We also have to consult hasVisibleDescendant() as well.

        Test: compositing/compositing-visible-descendant.html

        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::hasVisibleDescendant):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
eric@webkit.org [Tue, 13 Oct 2009 22:51:12 +0000 (22:51 +0000)]
2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
        out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
        This is done in preparation of implementing missing features in DRT.
        No functionality changes made yet.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/EventSenderQt.cpp: Added.
        (EventSender::EventSender):
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        (EventSender::leapForward):
        (EventSender::keyDown):
        (EventSender::contextClick):
        (EventSender::scheduleAsynchronousClick):
        (EventSender::frameUnderMouse):
        * DumpRenderTree/qt/EventSenderQt.h: Added.
        (EventSender::clearKillRing):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        (LayoutTestController::processWork):
        (LayoutTestController::maybeDump):
        (LayoutTestController::waitUntilDone):
        (LayoutTestController::notifyDone):
        (LayoutTestController::windowCount):
        (LayoutTestController::clearBackForwardList):
        (LayoutTestController::dumpEditingCallbacks):
        (LayoutTestController::dumpResourceLoadCallbacks):
        (LayoutTestController::queueBackNavigation):
        (LayoutTestController::queueForwardNavigation):
        (LayoutTestController::queueLoad):
        (LayoutTestController::queueReload):
        (LayoutTestController::queueScript):
        (LayoutTestController::provisionalLoad):
        (LayoutTestController::timerEvent):
        (LayoutTestController::encodeHostName):
        (LayoutTestController::decodeHostName):
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setFixedContentsSize):
        (LayoutTestController::setPrivateBrowsingEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::numberOfActiveAnimations):
        (LayoutTestController::disableImageLoading):
        (LayoutTestController::dispatchPendingLoadRequests):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::clearAllDatabases):
        (LayoutTestController::whiteListAccessFromOrigin):
        (LayoutTestController::waitForPolicyDelegate):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
        (LayoutTestController::isLoading):
        (LayoutTestController::setLoading):
        (LayoutTestController::shouldDumpAsText):
        (LayoutTestController::shouldDumpBackForwardList):
        (LayoutTestController::shouldDumpChildrenAsText):
        (LayoutTestController::shouldDumpDatabaseCallbacks):
        (LayoutTestController::shouldDumpStatusCallbacks):
        (LayoutTestController::shouldWaitUntilDone):
        (LayoutTestController::canOpenWindows):
        (LayoutTestController::shouldDumpTitleChanges):
        (LayoutTestController::waitForPolicy):
        (LayoutTestController::dumpAsText):
        (LayoutTestController::dumpChildFramesAsText):
        (LayoutTestController::dumpDatabaseCallbacks):
        (LayoutTestController::dumpStatusCallbacks):
        (LayoutTestController::setCanOpenWindows):
        (LayoutTestController::dumpBackForwardList):
        (LayoutTestController::setCloseRemainingWindowsWhenComplete):
        (LayoutTestController::display):
        (LayoutTestController::dumpTitleChanges):
        (LayoutTestController::dumpSelectionRect):
        * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
        (TextInputController::TextInputController):
        (TextInputController::doCommand):
        * DumpRenderTree/qt/TextInputControllerQt.h: Added.
        * DumpRenderTree/qt/WorkQueue.cpp:
        * DumpRenderTree/qt/WorkQueue.h:
        * DumpRenderTree/qt/WorkQueueItem.h:
        * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
        (findFrameNamed):
        (LoadItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 13 Oct 2009 22:17:32 +0000 (22:17 +0000)]
2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        https://bugs.webkit.org/show_bug.cgi?id=30278

        Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        from the make system into common code.

        Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
        support is not enabled.

        Remove notImplemented() from PluginPackageNone.cpp and
        PluginDataNone.cpp make them just empty functions.

        * GNUmakefile.am:
        * WebCore.pro:
        * plugins/PluginDataNone.cpp:
        (WebCore::PluginData::initPlugins):
        (WebCore::PluginData::refresh):
        * plugins/PluginPackageNone.cpp:
        (WebCore::PluginPackage::determineQuirks):
        (WebCore::PluginPackage::fetchInfo):
        (WebCore::PluginPackage::load):

2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        https://bugs.webkit.org/show_bug.cgi?id=30278

        Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        from the make system into common code.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, adding myself to the list of reviewers.
dimich@chromium.org [Tue, 13 Oct 2009 22:02:54 +0000 (22:02 +0000)]
Not reviewed, adding myself to the list of reviewers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Tue, 13 Oct 2009 22:02:38 +0000 (22:02 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=30150
        <rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types

        Test: editing/pasteboard/crash-accessing-clipboardData-types.html

        * platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String
        class doesn't have operator bool, it's operator NSString* that is invoked instead, and it
        converts null strings to non-null @"".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
andersca@apple.com [Tue, 13 Oct 2009 21:59:54 +0000 (21:59 +0000)]
<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API

Reviewed by Sam Weinig.

WebKit/mac:

Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.

* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
* Plugins/Hosted/WebKitPluginHost.defs:
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):

WebKitTools:

Make the private browsing mode testable by the test plug-in.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):

LayoutTests:

Add test.

* platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.

* plugins/private-browsing-mode-expected.txt: Added.
* plugins/private-browsing-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowindow attributes (like localStorage) that are disabled at runtime are still visible
atwilson@chromium.org [Tue, 13 Oct 2009 21:44:38 +0000 (21:44 +0000)]
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.

Adding codegen/bindings to support runtime disabling of attributes.

No new tests (only supported by chrome currently)

* bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
* bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
* bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
* bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
* page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 13 Oct 2009 21:24:39 +0000 (21:24 +0000)]
2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        ARM compiler does not understand reinterpret_cast<void*>
        https://bugs.webkit.org/show_bug.cgi?id=29034

        Change reinterpret_cast<void*> to regular C style (void*) cast
        for the ARM RVCT compiler.

        * assembler/MacroAssemblerCodeRef.h:
        (JSC::FunctionPtr::FunctionPtr):
        * jit/JITOpcodes.cpp: Cast to FunctionPtr first
           instead of directly casting to reinterpret_cast
        * jit/JITStubCall.h: Ditto + change the type of m_stub
          from void* to FunctionPtr.
        (JSC::JITStubCall::JITStubCall):
        (JSC::JITStubCall::call):
        * jit/JITStubs.cpp: Ditto.
        (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
eric@webkit.org [Tue, 13 Oct 2009 20:53:12 +0000 (20:53 +0000)]
2009-10-13  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27457
        Test case for static email validation on type=email input elements as
        per HTML5 specs:
        http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state

        * fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
        * fast/forms/ValidityState-typeMismatch-email.html: Added.
        * fast/forms/resources/ValidityState-typeMismatch-email.js: Added.
        ():
2009-10-13  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27457
        Added support for static validation on type=email input elements as per
        HTML5 specs:
        http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state

        Test: fast/forms/ValidityState-typeMismatch-email.html

        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch
        performs validation on type=email input elements now.
        (WebCore::ValidityState::isValidEmailAddress): simple validation method
        * html/ValidityState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Dmitry Titov <dimich@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 20:27:04 +0000 (20:27 +0000)]
2009-10-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Adam Barth.

        Event listeners installed on a window object returned from window.open() don't work
        https://bugs.webkit.org/show_bug.cgi?id=28716

        * http/tests/security/resources/has-window-events.html: Added.
        * http/tests/security/window-events-clear-domain-expected.txt: Added.
        * http/tests/security/window-events-clear-domain.html: Added.
        * http/tests/security/window-events-clear-port-expected.txt: Added.
        * http/tests/security/window-events-clear-port.html: Added.
        * http/tests/security/window-events-pass-expected.txt: Added.
        * http/tests/security/window-events-pass.html: Added.
2009-10-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Adam Barth.

        Event listeners installed on a window object returned from window.open() don't work
        https://bugs.webkit.org/show_bug.cgi?id=28716

        Tests: http/tests/security/window-events-clear-domain.html
               http/tests/security/window-events-clear-port.html
               http/tests/security/window-events-pass.html

        * dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all
        window event handlers when implicitOpen is called. It is called in 2 cases - on
        committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).

        (WebCore::Document::open): in addition to calling implicitOpen it also removes window
        event handlers, to preserve the behavior of document.open().

        (WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
        does not remove window event handlers.

        * dom/Document.h: Removed clear().

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers
        if we transition from temporary empty document to a loaded one.

        (WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
        (WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a leak in the inspector by calling didRemoveNode with
bweinstein@apple.com [Tue, 13 Oct 2009 20:03:23 +0000 (20:03 +0000)]
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.

Reviewed by Pavel Feldman.

* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/front-end/ElementsTreeOutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
bweinstein@apple.com [Tue, 13 Oct 2009 19:01:02 +0000 (19:01 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.

Reviewed by Timothy Hatcher.

When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.

* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
* inspector/InspectorFrontend.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
bweinstein@apple.com [Tue, 13 Oct 2009 17:08:18 +0000 (17:08 +0000)]
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.

Reviewed by Timothy Hatcher.

Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 17:04:39 +0000 (17:04 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        No review, just adding self to the list of reviewers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Tue, 13 Oct 2009 14:27:11 +0000 (14:27 +0000)]
2009-10-13  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.

        This is a bug for two reasons:
        1. Everytime we use winId(), we end up creating a native widget. This causes an
        unnecessary copy of contents from the backing store to the native widget.
        2. Neither windowed nor windowless plugins require the winId of the QWebView or
        QGraphicsView.

        Introduce ownerWidget() which returns a QWidget * without creating a native widget
        (as opposed to QWidget::find(winId)).

       https://bugs.webkit.org/show_bug.cgi?id=30170

        * platform/qt/PlatformScreenQt.cpp:
        (WebCore::screenDepthPerComponent):
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::show):
        * platform/qt/QWebPageClient.h:
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::setSharedXEventFields):
        (WebCore::PluginView::initXEvent):
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::platformStart):
2009-10-13  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.

        This is a bug for two reasons:
        1. Everytime we use winId(), we end up creating a native widget. This causes an
        unnecessary copy of contents from the backing store to the native widget.
        2. Neither windowed nor windowless plugins require the winId of the QWebView or
        QGraphicsView.

        Introduce ownerWidget() which returns a QWidget * without creating a native widget
        (as opposed to QWidget::find(winId)).

        https://bugs.webkit.org/show_bug.cgi?id=30170

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::ownerWidget):
        * Api/qwebview.cpp:
        (QWebViewPrivate::ownerWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for typo in filename
kov@webkit.org [Tue, 13 Oct 2009 13:26:21 +0000 (13:26 +0000)]
Unreviewed fix for typo in filename

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 12:14:11 +0000 (12:14 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        Layout test fix, reverting previous change.

        Reverting r49499 as it caused several layout test failures.

        * inspector/console-tests-expected.txt: Removed.
        * inspector/console-tests.html: Removed.
        * inspector/elements-panel-structure-expected.txt: Removed.
        * inspector/elements-panel-structure.html: Removed.
        * inspector/evaluate-in-frontend-expected.txt: Removed.
        * inspector/evaluate-in-frontend.html: Removed.
        * inspector/evaluate-in-frontend.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 11:53:48 +0000 (11:53 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add initial layout tests for web inspector.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * inspector/console-tests-expected.txt: Added.
        * inspector/console-tests.html: Added.
        * inspector/elements-panel-structure-expected.txt: Added.
        * inspector/elements-panel-structure.html: Added.
        * inspector/evaluate-in-frontend-expected.txt: Added.
        * inspector/evaluate-in-frontend.html: Added.
        * inspector/evaluate-in-frontend.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
tonikitoo@webkit.org [Tue, 13 Oct 2009 11:35:36 +0000 (11:35 +0000)]
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.

* tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] better handle possible edge cases on qwebframe::requestedUrl use
tonikitoo@webkit.org [Tue, 13 Oct 2009 10:57:13 +0000 (10:57 +0000)]
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.

QWebFrame::requestedUrl can be called at any time during the load
process, including:

* An error handling (whereas an alternate error page for unsuccessful
  load is being set);
* A ssl error exception call;
* Navigation notifications (titleChanged, urlChanged, progresses,
  addHistoryEntry, etc);
* Among others.

This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.

Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.

* Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:28:45 +0000 (08:28 +0000)]
2009-10-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Adam Roben.

        Web Inspector: Use proper web view in inspector layout
        tests for windows.

        https://bugs.webkit.org/show_bug.cgi?id=30298

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Alexander Pavlov <apavlov@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:26:34 +0000 (08:26 +0000)]
2009-10-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.
        Alter profile link format to enable multiple profile types
        https://bugs.webkit.org/show_bug.cgi?id=30253

        The new profile URL includes the profile type along with the
        profile title and uid.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfileFinishedMessageToConsole):
        (WebCore::InspectorController::addStartProfilingMessageToConsole):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.linkifyStringAsFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Alexander Pavlov <apavlov@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:19:52 +0000 (08:19 +0000)]
2009-10-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Fix same-named profiles grouping in the Profiles panel.

        The tree node re-parenting while adding a new group node was broken.

        https://bugs.webkit.org/show_bug.cgi?id=30299

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:16:53 +0000 (08:16 +0000)]
2009-10-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Enforce async interaction between inspector controller and frontend.

        https://bugs.webkit.org/show_bug.cgi?id=30300

        * inspector/front-end/inspector.js:
        (WebInspector.dispatch.delayDispatch):
        (WebInspector.dispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 13 Oct 2009 06:11:19 +0000 (06:11 +0000)]
2009-10-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Missing default value for the default text encoding.
        https://bugs.webkit.org/show_bug.cgi?id=30311

        QtWebKit has provided a default, hardcoded value for default charset but since
        the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
        value has had no effect.

        Added a regression test and unskipped fast/dom/Document/document-charset.html,
        which is passing now.

        * platform/qt/Skipped:
2009-10-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Missing default value for the default text encoding.
        https://bugs.webkit.org/show_bug.cgi?id=30311

        QtWebKit has provided a default, hardcoded value for default charset but since
        the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
        value has had no effect.

        Added a regression test and unskipped fast/dom/Document/document-charset.html,
        which is passing now.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::defaultTextEncoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange <a name> to id="" to fix styling problems
cam@webkit.org [Tue, 13 Oct 2009 05:38:56 +0000 (05:38 +0000)]
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283

Reviewed by Eric Seidel.

This prevents the headings from being styled like links.

* coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Xiaomei Ji <xji@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 04:59:36 +0000 (04:59 +0000)]
2009-10-12  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Sam Weinig.

        Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
        scrolled page.
        https://bugs.webkit.org/show_bug.cgi?id=30034

        * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
        * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
        * fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
        * fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Sam Weinig.

        Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
        scrolled page.
        https://bugs.webkit.org/show_bug.cgi?id=30034

        * dom/Document.cpp:
        (WebCore::Document::elementFromPoint): calculate the correct point
        relative to document when the page is zoomed and scrolled.
        (WebCore::Document::caretRangeFromPoint): calculate the correct point
        relative to document when the page is zoomed and scrolled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 13 Oct 2009 04:22:11 +0000 (04:22 +0000)]
2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.  Fix 4 layout test failures by webkit r49488

        WebKit r49488 enables window.WebSocket back.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
ukai@chromium.org [Tue, 13 Oct 2009 01:44:18 +0000 (01:44 +0000)]
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

Test: fast/websockets/websocket-event-target.html

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* websockets/WebSocket.idl:

WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

* fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
* fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
* fast/websockets/websocket-event-target-expected.txt: Added.
* fast/websockets/websocket-event-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=29078
weinig@apple.com [Tue, 13 Oct 2009 00:47:41 +0000 (00:47 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>

Reviewed by Darin Adler.

WebCore:

Add a mechanism to blacklist certain codecs.  Initially, just blacklist UTF-7 as HTML5 encourages.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

LayoutTests:

Test the lack of UTF-7 support. Remove old UTF-7 tests.

* fast/encoding/char-decoding-expected.txt:
* fast/encoding/char-decoding.html:
* http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-get-in-utf7.html: Removed.
* http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-post-in-utf7.html: Removed.
* http/tests/misc/url-in-utf7-expected.txt: Removed.
* http/tests/misc/url-in-utf7.html: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for the beforeload event to frames. Complete support of the beforeload...
hyatt@apple.com [Tue, 13 Oct 2009 00:37:02 +0000 (00:37 +0000)]
Add support for the beforeload event to frames.  Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed).  Add support
for the Objective-C wrapper class as well.

Reviewed by Darin Adler.

Added fast/dom/beforeload/frame-before-load.html

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMEvents.mm:
(kitClass):
* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
* dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
* dom/Event.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 00:27:10 +0000 (00:27 +0000)]
2009-10-12  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium Port - Windows
        https://bugs.webkit.org/show_bug.cgi?id=29969

        * chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium Port - Windows
        https://bugs.webkit.org/show_bug.cgi?id=29969

        * Scripts/pdevenv: removed msvc's /useenv for chromium builds
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix <rdar://problem/7094146> Reproducible crash at
mitz@apple.com [Mon, 12 Oct 2009 23:49:46 +0000 (23:49 +0000)]
WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

Test: fast/dynamic/position-absolute-to-fixed-crash.html

The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.

LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

* fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
* fast/dynamic/position-absolute-to-fixed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Mon, 12 Oct 2009 23:20:33 +0000 (23:20 +0000)]
2009-10-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Add a palette() method that is needed by our RenderTheme.

        * platform/qt/QWebPageClient.h:
2009-10-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Implement the new palette() methods on the page clients

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::palette):
        * Api/qwebview.cpp:
        (QWebViewPrivate::palette):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Mon, 12 Oct 2009 23:05:21 +0000 (23:05 +0000)]
2009-10-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Three old test results give back the absolute position instead of the realtive position.
        The new test will check the correct behavior of gradients in userSpaceOnUse mode and
        values in percentage.

        * platform/mac/svg/custom/gradient-attr-update-expected.txt:
        * platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
        * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
        * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
        * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
        * platform/mac/svg/custom/text-gradient-no-content-expected.txt:
        * svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.
2009-10-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Gradients can't handle percentage values in userSpaceOnUse mode
        [https://bugs.webkit.org/show_bug.cgi?id=30286]

        Fixed *GradientAttributes to take SVGLength instead of double. This casues
        the problem, that we can't calculate the correct size of a gradient on
        userSpaceOnUse mode with percentage values.

        Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg

        * svg/LinearGradientAttributes.h:
        (WebCore::LinearGradientAttributes::LinearGradientAttributes):
        (WebCore::LinearGradientAttributes::x1):
        (WebCore::LinearGradientAttributes::y1):
        (WebCore::LinearGradientAttributes::x2):
        (WebCore::LinearGradientAttributes::y2):
        (WebCore::LinearGradientAttributes::setX1):
        (WebCore::LinearGradientAttributes::setY1):
        (WebCore::LinearGradientAttributes::setX2):
        (WebCore::LinearGradientAttributes::setY2):
        * svg/RadialGradientAttributes.h:
        (WebCore::RadialGradientAttributes::RadialGradientAttributes):
        (WebCore::RadialGradientAttributes::cx):
        (WebCore::RadialGradientAttributes::cy):
        (WebCore::RadialGradientAttributes::r):
        (WebCore::RadialGradientAttributes::fx):
        (WebCore::RadialGradientAttributes::fy):
        (WebCore::RadialGradientAttributes::setCx):
        (WebCore::RadialGradientAttributes::setCy):
        (WebCore::RadialGradientAttributes::setR):
        (WebCore::RadialGradientAttributes::setFx):
        (WebCore::RadialGradientAttributes::setFy):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::buildGradient):
        (WebCore::SVGLinearGradientElement::collectGradientProperties):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::buildGradient):
        (WebCore::SVGRadialGradientElement::collectGradientProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <http://webkit.org/b/30315>.
bweinstein@apple.com [Mon, 12 Oct 2009 22:33:25 +0000 (22:33 +0000)]
Fixes <http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.

Reviewed by Timothy Hatcher.

Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agojsc scripts cleanup and Qt/GTK fix
ossy@webkit.org [Mon, 12 Oct 2009 22:25:45 +0000 (22:25 +0000)]
jsc scripts cleanup and Qt/GTK fix
https://bugs.webkit.org/show_bug.cgi?id=30288

Patch by Csaba Osztrogonac <ossy@webkit.org> on 2009-10-12
Reviewed by Darin Adler.

Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.

* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc:
* Scripts/run-sunspider:
* Scripts/sunspider-compare-results:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 12 Oct 2009 21:30:15 +0000 (21:30 +0000)]
2009-10-12  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r49429, because it broke layout tests.
        http://trac.webkit.org/changeset/49429

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 12 Oct 2009 21:15:12 +0000 (21:15 +0000)]
2009-10-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        SVG - crash on feMerge when input not available
        [https://bugs.webkit.org/show_bug.cgi?id=30297]

        Make a early return in SVGFEMergeElement if the needed
        filter effect doesn't exist.

        Test: svg/filters/feMerge-wrong-input.svg

        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):

2009-10-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eirc Seidel.

        feMergeNod has a reference to an effect that doesn't exist. This test will
        check if SVGFEMergeElement handles this correctly and stops the filter process.

        * svg/filters/feMerge-wrong-input-expected.checksum: Added.
        * svg/filters/feMerge-wrong-input-expected.png: Added.
        * svg/filters/feMerge-wrong-input-expected.txt: Added.
        * svg/filters/feMerge-wrong-input.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Csaba Osztrogonac <ossy@webkit.org>
ossy@webkit.org [Mon, 12 Oct 2009 20:42:56 +0000 (20:42 +0000)]
2009-10-12 Csaba Osztrogonac <ossy@webkit.org>

        Unreviewed. Added myself to committers.py.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Added automatic flush before compositing
cmarrin@apple.com [Mon, 12 Oct 2009 20:00:42 +0000 (20:00 +0000)]
    Added automatic flush before compositing
        https://bugs.webkit.org/show_bug.cgi?id=30236

        This causes image to always render correctly. In writing a testcase
        I needed to implement readPixels. This exposed a bug in reading back
        values from a CanvasArray subclass, so I fixed that as well. Now when
        you wrap a CanvasArray in a JSValue it actually wraps the specific
        subclass. To do this I need to add virtual methods to each CanvasArray
        subclass to determine the type and a custom toJS method for CanvasArray
        to create the proper wrapper.

        Test: fast/canvas/webgl/triangle.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 12 Oct 2009 19:38:01 +0000 (19:38 +0000)]
2009-10-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
        https://bugs.webkit.org/show_bug.cgi?id=30302

        Closely match the default httpd.conf for layout tests.

        * http/conf/fedora-httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Mon, 12 Oct 2009 18:09:13 +0000 (18:09 +0000)]
2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30307

        Fix 0 sentinel for g_object_set() function call.

        * platform/graphics/gtk/DataSourceGStreamer.cpp:
        (webkit_data_src_uri_set_uri):
        0 is passed as 32 bit value on x86-64 in vararg functions, but
        g_object_set() expects a 64 bit 0. This will cause crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 12 Oct 2009 18:05:37 +0000 (18:05 +0000)]
2009-10-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Remove unnecessary self-include.

        * webkit/webkitsecurityorigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 12 Oct 2009 16:29:42 +0000 (16:29 +0000)]
2009-10-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Video keeps playing after going fullscreen, then closing window
        https://bugs.webkit.org/show_bug.cgi?id=30164

        Clear the QTMovie on the QTMovieView when coming out of fullscreen,
        to fix issue where the underlying movie keeps playing.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController windowDidExitFullscreen]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Andras Becsi <becsi.andras@stud.u-szeged.hu>
eric@webkit.org [Mon, 12 Oct 2009 15:52:06 +0000 (15:52 +0000)]
2009-10-12  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add expected files for new passing fast tests.

        * platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
        * platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
        * platform/qt/fast/css/text-rendering-expected.txt: Added.
        * platform/qt/fast/forms/basic-buttons-expected.txt: Added.
        * platform/qt/fast/forms/basic-inputs-expected.txt: Added.
        * platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
        * platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
        * platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Cameron McCormack <cam@mcc.id.au>
krit@webkit.org [Mon, 12 Oct 2009 15:26:53 +0000 (15:26 +0000)]
2009-10-12  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        Drop in="" from <feFlood>
        https://bugs.webkit.org/show_bug.cgi?id=29001

        This makes <feFlood in="bogus"> have an effect, too.

        http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

        Test: svg/dom/feFlood-no-in1.html

        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::SVGFEFloodElement):
        (WebCore::SVGFEFloodElement::build):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEFloodElement.idl:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::FEFlood):
        (WebCore::FEFlood::create):
        * svg/graphics/filters/SVGFEFlood.h:

        LayoutTest:

        Drop in="" from <feFlood>
        https://bugs.webkit.org/show_bug.cgi?id=29001

        This makes <feFlood in="bogus"> have an effect, too.

        http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

        * svg/dom/feFlood-no-in1-expected.txt: Added.
        * svg/dom/feFlood-no-in1.html: Added.
        * svg/dom/script-tests/feFlood-no-in1.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Mon, 12 Oct 2009 15:05:59 +0000 (15:05 +0000)]
2009-10-12  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        QWebPage's createViewlessPlugin autotest crash fix.

        It is possible that plugins that are QWidgets or QGraphicsWidgets
        are created before a view has been assigned to a QWebPage. The
        plug-ins won't be fully functional, as by design, they should
        visualise something, but they won't crash and will stay in memory.

        An autotest that covers this use-case, is included.

        https://bugs.webkit.org/show_bug.cgi?id=30118

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):
        * tests/qwebpage/tst_qwebpage.cpp:
        (PluginTrackedPageWidget::PluginTrackedPageWidget):
        (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget):
        (PluginTrackedPageGraphicsWidget::createPlugin):
        (tst_QWebPage::destroyPlugin):
        (tst_QWebPage::createViewlessPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Mon, 12 Oct 2009 14:34:39 +0000 (14:34 +0000)]
2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=29998

        Scale video to completely fill the target surface while
        keeping the aspect ratio. This fixes displaying of the
        YouTube HTML5 sample website.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        Scale video to completely fill the target surface, keep
        the aspect ratio and center it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Mon, 12 Oct 2009 14:18:48 +0000 (14:18 +0000)]
2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=29997

        Fixes double memcpy of all rendered video frames.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateRepaintCallback):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::duration):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_timeout_func):
        (webkit_video_sink_dispose):
        (unlock_buffer_mutex):
        (webkit_video_sink_unlock):
        (marshal_VOID__MINIOBJECT):
        (webkit_video_sink_class_init):
        (webkit_video_sink_new):
        * platform/graphics/gtk/VideoSinkGStreamer.h:
        Directly pass the buffers up to the MediaPlayerPrivate::paint()
        method instead of rendering them first to an intermediate cairo
        surface. This should increase performance and peak memory usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Christian Dywan <christian@twotoasts.de>
jmalonzo@webkit.org [Mon, 12 Oct 2009 14:15:16 +0000 (14:15 +0000)]
2009-10-12  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        [GTK] Crash when right-clicking misspelled word
        https://bugs.webkit.org/show_bug.cgi?id=29772

        Make sure the dictionary exist before adding it to the list of
        dictionaries.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::checkSpellingOfString):
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_set_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 12 Oct 2009 11:56:15 +0000 (11:56 +0000)]
2009-10-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubberstamped by Eric Seidel.

        [Gtk] Fix icu CFLAG for Darwin
        https://bugs.webkit.org/show_bug.cgi?id=29517

        Don't escape the srcdir variable. Also use $host instead of the
        os_foo variables.

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 12 Oct 2009 11:55:57 +0000 (11:55 +0000)]
2009-10-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
        https://bugs.webkit.org/show_bug.cgi?id=29518

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 12 Oct 2009 06:50:09 +0000 (06:50 +0000)]
2009-10-11  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=30242

        Fixes an issue where JavaScript URLs that are URL-encoded twice can
        bypass the XSSAuditor.

        JavaScript URLs that are completed by method Document::completeURL have added
        URL-encoded characters such that a direct comparison with the URL-decoded
        outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
        HTTP parameters must be URL-decoded before comparison.

        Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html
               http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
               http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor
        the URL-decoded source code for the JavaScript URL.
        * page/XSSAuditor.cpp:
        (WebCore::isIllegalURICharacter): Minor syntactical change to the comment.
        (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added
        parameter decodeURLEscapeSequencesTwice.
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
        (WebCore::XSSAuditor::decodeURL): Ditto.
        (WebCore::XSSAuditor::findInRequest): Ditto.
        * page/XSSAuditor.h:
        (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.
2009-10-11  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=30242

        Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.

        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
mitz@apple.com [Mon, 12 Oct 2009 04:17:43 +0000 (04:17 +0000)]
WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

Test: plugins/setProperty.html

* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.

LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

* plugins/setProperty-expected.txt: Added.
* plugins/setProperty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Dominic Cooney <dominicc@google.com>
eric@webkit.org [Mon, 12 Oct 2009 03:30:38 +0000 (03:30 +0000)]
2009-10-11  Dominic Cooney  <dominicc@google.com>

        Reviewed by Adam Barth.

        Fixes a build break in the V8 bindings caused by revision 49420.
        https://bugs.webkit.org/show_bug.cgi?id=30294

        Revision 49420 introduces an IDL-defined CanvasActiveInfo
        type. This causes a build break in the V8 bindings where
        CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
        non-ref type.

        * WebCore.gypi: Include CanvasActiveInfo.idl in build.
        * bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref
          ptr type.
        * bindings/v8/DOMObjectsInclude.h: Include generated
          CanvasActiveInfo files.
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Collin Jackson <collinj@webkit.org>
eric@webkit.org [Mon, 12 Oct 2009 03:15:10 +0000 (03:15 +0000)]
2009-10-11  Collin Jackson  <collinj@webkit.org>

        Reviewed by Adam Barth.

        Log mixed content warnings to console

        https://bugs.webkit.org/show_bug.cgi?id=30290

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkIfDisplayInsecureContent):
        (WebCore::FrameLoader::checkIfRunInsecureContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 12 Oct 2009 02:53:36 +0000 (02:53 +0000)]
2009-10-11  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Add Collin to committers.py.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Søren Gjesse <sgjesse@chromium.org>
eric@webkit.org [Sun, 11 Oct 2009 22:48:54 +0000 (22:48 +0000)]
2009-10-11  Søren Gjesse  <sgjesse@chromium.org>

        Reviewed by Adam Barth.

        [V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
        https://bugs.webkit.org/show_bug.cgi?id=30250

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Lyon Chen <lyon.chen@torchmobile.com>
eric@webkit.org [Sun, 11 Oct 2009 22:34:05 +0000 (22:34 +0000)]
2009-10-11  Lyon Chen  <lyon.chen@torchmobile.com>

        Reviewed by Alexey Proskuryakov.

        Correct the position of #endif sentence inside WebCore::Document::finishedParsing().

        https://bugs.webkit.org/show_bug.cgi?id=30244

        This change requires no test case as it fix a compiling error.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-11 Dominic Cooney <dominicc@google.com>
eric@webkit.org [Sun, 11 Oct 2009 22:17:16 +0000 (22:17 +0000)]
2009-10-11  Dominic Cooney  <dominicc@google.com>

        Reviewed by Adam Barth.

        Sets a 500K stack limit for JavaScript workers in Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=29797

        Runaway recursion in JavaScript workers crashes the Chromium
        worker process on OS X. This is because V8's default stack limit
        is 512K on ia32 or 1M on x64, but the worker process runs workers
        on a thread with the OS X default stack size--512K. Because there
        are already some C++ frames on the stack when V8 establishes its
        512K default stack limit, and V8 doesn't precisely enforce the
        stack limit, runaway recursion in V8 workers overflows the OS
        stack and segfaults, killing the worker process. This is described
        in Chromium bug 21653 <http://crbug.com/21653>.

        This patch sets the V8 stack limit for worker JavaScript in
        Chromium to a more conservative 500K on all platforms. This allows
        some "headroom" for the C++ stack in use when the limit is set up,
        and some "legroom" for the V8 helper functions which in practice
        briefly flout the V8 stack limit.

        Test: LayoutTests/fast/workers/use-machine-stack.html

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
        * bindings/v8/WorkerContextExecutionProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable the JIT.
oliver@apple.com [Sun, 11 Oct 2009 21:30:50 +0000 (21:30 +0000)]
Re-enable the JIT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.
kevino@webkit.org [Sun, 11 Oct 2009 20:01:25 +0000 (20:01 +0000)]
wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow [Reflect] on SVG elements.
cam@webkit.org [Sun, 11 Oct 2009 09:46:45 +0000 (09:46 +0000)]
Allow [Reflect] on SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=28936

Reviewed by Sam Weinig.

Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element.  Make
SVGElement::id use [Reflect].

Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.

WebCore:

Test: svg/dom/id-reflect.html

* bindings/scripts/CodeGenerator.pm: Add a function to determine the
appropriate C++ namespace for attribute name constants.
* bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling
code for [Reflect] on an attribute with a setter exception.
* bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of
"HTMLNames" when appropriate.
* bindings/scripts/CodeGeneratorJS.pm: Ditto.
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* svg/SVGElement.cpp: Remove getter and setter methods for id.
* svg/SVGElement.h: Ditto.
* svg/SVGElement.idl: Add [Reflect] to id.

LayoutTests:

* svg/dom/script-tests/id-reflect.js: Added.
* svg/dom/id-reflect-expected.txt: Added.
* svg/dom/id-reflect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport for String.trim(), String.trimLeft() and String.trimRight() methods
oliver@apple.com [Sun, 11 Oct 2009 03:47:01 +0000 (03:47 +0000)]
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590

Reviewed by Maciej Stachowiak.

Implement trim, trimLeft, and trimRight

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
rniwa@webkit.org [Sat, 10 Oct 2009 22:10:30 +0000 (22:10 +0000)]
REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.

* platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
* platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix paths in xcode.
oliver@apple.com [Sat, 10 Oct 2009 21:46:37 +0000 (21:46 +0000)]
Fix paths in xcode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement getActiveAttrib and getActiveUniform
oliver@apple.com [Sat, 10 Oct 2009 21:16:58 +0000 (21:16 +0000)]
Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276

Reviewed by Eric Carlson.

Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.

Test: fast/canvas/webgl/getActiveTest.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 10 Oct 2009 19:21:31 +0000 (19:21 +0000)]
2009-10-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Adding new attributes in Element Panel is
        counterintuitive.

        https://bugs.webkit.org/show_bug.cgi?id=30057

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._onmousemove):
        (WebInspector.ElementsTreeElement.prototype.set hovered):
        (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sat, 10 Oct 2009 16:19:26 +0000 (16:19 +0000)]
2009-10-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Build fix if Netscape plugin support is turned off
        https://bugs.webkit.org/show_bug.cgi?id=30275

        In addition to fixing the build break with guards
        remove notImplemented() from PluginViewNone.cpp and
        make them just just be empty functions.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::handleEvent):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::setFocus):
        (WebCore::PluginView::show):
        (WebCore::PluginView::hide):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::setParent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::handlePostReadFile):
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::invalidateRect):
        (WebCore::PluginView::invalidateRegion):
        (WebCore::PluginView::forceRedraw):
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):
        (WebCore::PluginView::setParentVisible):
        (WebCore::PluginView::updatePluginWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sat, 10 Oct 2009 15:56:20 +0000 (15:56 +0000)]
2009-10-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        [Qt] Build fix for QtWebKit after r49415.

        Add HistoryController.cpp to the build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Darin Fisher <darin@chromium.org>
darin@chromium.org [Sat, 10 Oct 2009 13:53:52 +0000 (13:53 +0000)]
2009-10-09  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
        https://bugs.webkit.org/show_bug.cgi?id=30262

        This is not testable from WebKit since WebKit never uses the member
        function form of protocolIs with input that can be controlled from a
        web page.  It always passes string literals lacking hyphens.

        * platform/KURLGoogle.cpp:
        (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would
        transform the input character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 10 Oct 2009 09:11:39 +0000 (09:11 +0000)]
2009-10-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        Move HistoryController to its own file
        https://bugs.webkit.org/show_bug.cgi?id=30272

        Purely mechanical.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/HistoryController.cpp: Added.
        * loader/HistoryController.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoApplyStyleCommand removes presentational tags even when not necessary
rniwa@webkit.org [Sat, 10 Oct 2009 03:36:51 +0000 (03:36 +0000)]
ApplyStyleCommand removes presentational tags even when not necessary
https://bugs.webkit.org/show_bug.cgi?id=28091

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.

WebCore:

This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.

Test: editing/execCommand/toggle-style-3.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements
* editing/ApplyStyleCommand.h:

LayoutTests:

This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later

* editing/execCommand/19653-2-expected.txt: Two b elements are merged.
* editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
* editing/execCommand/script-tests/toggle-style-3.js: Added.
(testSingleToggle):
* editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
* editing/execCommand/toggle-style-3-expected.txt: Added.
* editing/execCommand/toggle-style-3.html: Added.
* editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
* platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
* platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 10 Oct 2009 02:27:21 +0000 (02:27 +0000)]
2009-10-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor HistoryController out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30246

        Update API call.

        * WebView.cpp:
        (WebView::loadBackForwardListFromOtherView):
2009-10-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor HistoryController out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30246

        Update API call.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::restoreViewState):
        * WebView/WebView.mm:
        (-[WebView _loadBackForwardListFromOtherView:]):
2009-10-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor HistoryController out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30246

        HistoryController is in charge of managing the current / previous /
        provisional HistoryItems.  The split isn't perfect, but it's a place to
        start.  I'll move HistoryController into its own file in another patch.

        * WebCore.base.exp:
        * loader/FrameLoader.cpp:
        (WebCore::HistoryController::HistoryController):
        (WebCore::HistoryController::~HistoryController):
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::closeURL):
        (WebCore::FrameLoader::begin):
        (WebCore::HistoryController::restoreDocumentState):
        (WebCore::HistoryController::setCurrentItem):
        (WebCore::HistoryController::setProvisionalItem):
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::canCachePageContainingThisFrame):
        (WebCore::FrameLoader::logCanCacheFrameDecision):
        (WebCore::FrameLoader::scrollToAnchor):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::didFirstLayout):
        (WebCore::HistoryController::updateForFrameLoadCompleted):
        (WebCore::FrameLoader::frameLoadCompleted):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::HistoryController::addHistoryItemForFragmentScroll):
        (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
        (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
        (WebCore::HistoryController::createHistoryItem):
        (WebCore::FrameLoader::checkDidPerformFirstNavigation):
        (WebCore::HistoryController::addBackForwardItemClippedAtTarget):
        (WebCore::HistoryController::createHistoryItemTree):
        (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
        (WebCore::HistoryController::restoreScrollPositionAndViewState):
        (WebCore::HistoryController::invalidateCurrentItemCachedPage):
        (WebCore::HistoryController::saveDocumentState):
        (WebCore::FrameLoader::loadItem):
        (WebCore::HistoryController::urlsMatchItem):
        (WebCore::HistoryController::goToItem):
        (WebCore::HistoryController::recursiveGoToItem):
        (WebCore::HistoryController::childFramesMatchItem):
        (WebCore::HistoryController::updateForStandardLoad):
        (WebCore::HistoryController::updateForClientRedirect):
        (WebCore::HistoryController::updateForBackForwardNavigation):
        (WebCore::HistoryController::updateForReload):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::updateForCommit):
        (WebCore::HistoryController::updateForAnchorScroll):
        (WebCore::HistoryController::saveDocumentAndScrollState):
        (WebCore::HistoryController::setCurrentItemTitle):
        (WebCore::FrameLoader::didChangeTitle):
        * loader/FrameLoader.h:
        (WebCore::HistoryController::current):
        (WebCore::HistoryController::provisional):
        (WebCore::FrameLoader::policyChecker):
        (WebCore::FrameLoader::history):
        (WebCore::FrameLoader::creatingInitialEmptyDocument):
        * page/Page.cpp:
        (WebCore::Page::goToItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix Windows build by adding needed exports.
bweinstein@apple.com [Sat, 10 Oct 2009 00:53:21 +0000 (00:53 +0000)]
Try to fix Windows build by adding needed exports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with...
mrowe@apple.com [Sat, 10 Oct 2009 00:46:39 +0000 (00:46 +0000)]
WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in

Reviewed by Brady Eidson.

At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out.  This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.

WebKitTools: Enable plug-in halting in DumpRenderTree.

We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:shouldHaltPlugin:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed - fixing an obvious typo in my previous check-in.
ap@apple.com [Sat, 10 Oct 2009 00:38:25 +0000 (00:38 +0000)]
    Unreviewed - fixing an obvious typo in my previous check-in.

        https://bugs.webkit.org/show_bug.cgi?id=30260
        <rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

        Fixes existing tests (which I thought I had run the previous time).

        * platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the
        set by reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminated some legacy bytecode weirdness.
ggaren@apple.com [Sat, 10 Oct 2009 00:30:49 +0000 (00:30 +0000)]
Eliminated some legacy bytecode weirdness.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.

Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.

To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.

Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.

SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.

* bytecode/CodeBlock.cpp:
(JSC::printConditionalJump):
(JSC::CodeBlock::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
* bytecompiler/Label.h:
(JSC::Label::setLocation):
(JSC::Label::bind):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] Need change to V8WorkerContextEventListener::reportError signature to match...
levin@chromium.org [Fri, 9 Oct 2009 23:28:04 +0000 (23:28 +0000)]
[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
https://bugs.webkit.org/show_bug.cgi?id=30264

Patch by David Levin <levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.

The base class method changed in r48884.

Test: fast/worker/worker-script-error.html

* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::reportError):
* bindings/v8/V8WorkerContextEventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix bad ChangeLog entry merge in r49019 by the commit queue script.
ddkilzer@apple.com [Fri, 9 Oct 2009 22:45:33 +0000 (22:45 +0000)]
Fix bad ChangeLog entry merge in r49019 by the commit queue script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Fri, 9 Oct 2009 22:29:41 +0000 (22:29 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=30260
        <rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

        Tests: http/tests/xmlhttprequest/logout.html
               http/tests/xmlhttprequest/re-login-async.html
               http/tests/xmlhttprequest/re-login.html

        Fix several issues with existing credential handling code.

        * platform/network/CredentialStorage.cpp:
        (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one.
        (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't
        want to iterate paths for origins that never had credentials associated with them. Changed
        to use a separate HashSet for this.
        (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't
        match the spec very well. UAs are supposed to deduce protection space from an URL, and then
        use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap
        is now PathToDefaultProtectionSpaceMap.
        (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory
        URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap.
        (WebCore::CredentialStorage::set): Updated for above changes.
        (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find
        a prefix in OriginToDefaultBasicCredentialMap.
        (WebCore::CredentialStorage::set): Another version of set() can update credentials for a
        URL default protection space. It does nothing if the given URL doesn't correspond to a known
        protection space.
        (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.

        * platform/network/CredentialStorage.h: Made the distinction between methods that use a known
        protection space and those that deduce one from URL more clear.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start): Update credentials before starting the request for real.
        This makes the following pattern work:
          var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); // wrong credentials
          req.send("");
          req.abort();
        Abort() is used here to avoid having UA present an auth dialog after getting a 401 response.
        Note that one cannot log in using the same method, because there isn't a known protection
        space for the URL yet in that case, so the added code has no effect.
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for
        calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of
        course), and matches sync case.
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
        Renamed getDefaultAuthenticationCredential() to get().

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::WebCoreSynchronousLoader::load):
        Same changes as in Mac code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Enrica Casucci <enrica@apple.com>
eric@webkit.org [Fri, 9 Oct 2009 22:01:07 +0000 (22:01 +0000)]
2009-10-09  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Undoing a indent removes text instead of it's formatting.
        <rdar://problem/7169206>
        https://bugs.webkit.org/show_bug.cgi?id=28722
        Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995

        * editing/execCommand/19653-1-expected.txt: Re-baselined.
        * editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
        * editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
        * editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
        * editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
        * editing/execCommand/indent-with-style-expected.txt: Added.
        * editing/execCommand/indent-with-style.html: Added.
        * editing/undo/undo-indent-expected.txt: Added.
        * editing/undo/undo-indent.html: Added.
        * platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
        * platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
        * platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
        * platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
        * platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.
2009-10-09  Enrica Casucci  <enrica@apple.com>

        Reviewed by Adele Peterson.

        Undoing a indent removes text instead of it's formatting.
        <rdar://problem/7169206>
        https://bugs.webkit.org/show_bug.cgi?id=28722
        Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
        indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.

        Added editing/undo/undo-indent.html test.

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored.
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes.
        (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored.
        (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to
        ensure TextIterator could correctly calculate the position starting from the index.
        * editing/IndentOutdentCommand.h: Restored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Rimas Kudelis <rq@akl.lt>
kov@webkit.org [Fri, 9 Oct 2009 21:24:31 +0000 (21:24 +0000)]
2009-10-09  Rimas Kudelis  <rq@akl.lt>

        Rubber-stamped by Gustavo Noronha

        https://bugs.webkit.org/show_bug.cgi?id=30054
        Localization of WebKit GTK into Lithuanian

        * lt.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Jens Alfke <snej@chromium.org>
eric@webkit.org [Fri, 9 Oct 2009 21:24:28 +0000 (21:24 +0000)]
2009-10-09  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Adler.

        Optimization: Many StringImpl transformations are no-ops and should just return 'this'
        https://bugs.webkit.org/show_bug.cgi?id=30186

        Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
        detect no-ops and return this instead of creating a new instance.
        Empirical testing shows that the majority of calls to these methods are no-ops, making
        this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
        Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::lower):
        (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized
        (WebCore::StringImpl::stripWhiteSpace):
        (WebCore::StringImpl::simplifyWhiteSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 9 Oct 2009 20:51:19 +0000 (20:51 +0000)]
2009-10-09  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        SVG Filter feGaussianBlur implementation is missing
        [https://bugs.webkit.org/show_bug.cgi?id=28141]

        This is the implementation of GaussianBlur filter for SVG.

        There is already a test for feGaussianBlur
        Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg

        Test: svg/filters/feGaussianBlur.svg

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::FilterEffect):
        * platform/graphics/filters/FilterEffect.h:
        (WebCore::FilterEffect::isAlphaImage):
        (WebCore::FilterEffect::setIsAlphaImage):
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::apply):
        * svg/graphics/filters/SVGFEGaussianBlur.cpp:
        (WebCore::boxBlur):
        (WebCore::FEGaussianBlur::apply):

        Test for feGaussianBlur implementation

        * platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
        * platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
        * platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
        * svg/filters/feGaussianBlur.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-09 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Fri, 9 Oct 2009 19:37:40 +0000 (19:37 +0000)]
2009-10-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] QoS support in the video sink
        https://bugs.webkit.org/show_bug.cgi?id=29959

        Removed the async buffer queue from the sink. Synchronize the
        render method of the sink using a g_timeout_add() combined with a
        gcond triggered when the buffer has been rendered.
        Also fixed the video sink reference handling in the player, now
        that the idle is not there anymore to mess up things.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_init):
        (webkit_video_sink_timeout_func):
        (webkit_video_sink_render):
        (webkit_video_sink_dispose):
        (unlock_buffer_mutex):
        (webkit_video_sink_unlock):
        (webkit_video_sink_stop):
        (webkit_video_sink_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49401 268f45cc-cd09-0410-ab3c-d52691b4dbfc