WebKit-https.git
7 years ago[chromium] Lower priority of preloaded images
simonjam@chromium.org [Wed, 27 Feb 2013 23:47:52 +0000 (23:47 +0000)]
[chromium] Lower priority of preloaded images
https://bugs.webkit.org/show_bug.cgi?id=110527

Source/WebCore:

Reviewed by Nate Chapin.

This improves Speed Index by ~5%, because it encourages us to load images that are needed for
painting over speculative preloads. Ideally, all embedders would use this, but it relies on
ResourceHandle::didChangePriority being implemented. Currently, only Chrome does that.

Test: http/tests/loading/promote-img-preload-priority.html

* loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchDidChangeResourcePriority): Added callback to enable testing.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setLoadPriority): Signal callback.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload): Actual behavior change.

Source/WebKit/chromium:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

* public/WebFrameClient.h:
(WebKit):
(WebKit::WebFrameClient::didChangeResourcePriority):
(WebFrameClient):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Tools:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::didChangeResourcePriority):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourcePriorities):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceRequestPriorities):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
(WebTestRunner):

LayoutTests:

Reviewed by Nate Chapin.

* http/tests/loading/promote-img-preload-priority-expected.txt: Added.
* http/tests/loading/promote-img-preload-priority.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial buildfix after r144190.
ossy@webkit.org [Wed, 27 Feb 2013 23:25:14 +0000 (23:25 +0000)]
Unreviewed trivial buildfix after r144190.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-27

* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.
ossy@webkit.org [Wed, 27 Feb 2013 23:13:31 +0000 (23:13 +0000)]
[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-27

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline 2 SVG tests after WK108429
pdr@google.com [Wed, 27 Feb 2013 23:04:14 +0000 (23:04 +0000)]
Rebaseline 2 SVG tests after WK108429

This patch rebaselines svg/repaint after WK108429 and removes a stale
test expectations entry for svg/custom/text-ctm.

Unreviewed update of test expectations.

* platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
* platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebSpeech: support speech cancel
cfleizach@apple.com [Wed, 27 Feb 2013 22:55:18 +0000 (22:55 +0000)]
WebSpeech: support speech cancel
https://bugs.webkit.org/show_bug.cgi?id=107349

Reviewed by Beth Dakin.

Source/WebCore:

Add the ability to cancel speech utterances and make it work with Mac
and the mock speech synthesizer.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(WebCore::PlatformSpeechSynthesizer::cancel):
(WebCore):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::cancel):
(WebCore):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-cancel-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.
zandobersek@gmail.com [Wed, 27 Feb 2013 22:53:43 +0000 (22:53 +0000)]
Unreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnlock partially decoded images after passing them to the ImageDecodingStore
commit-queue@webkit.org [Wed, 27 Feb 2013 22:49:32 +0000 (22:49 +0000)]
Unlock partially decoded images after passing them to the ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=110778

Patch by Min Qin <qinmin@chromium.org> on 2013-02-27
Reviewed by Stephen White.

Source/WebCore:

For partially decoded images, we need to unlock them so that the memory can be freed.
This change unlocks all the image frames after they are passed to ImageDecodingStore.
Unit tests are added in ImageFrameGeneratorTest.

* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):
* platform/image-decoders/ImageDecoder.h:
(ImageDecoder):
(WebCore::ImageDecoder::lockFrameBuffers):
(WebCore::ImageDecoder::unlockFrameBuffers):

Source/WebKit/chromium:

Test for testing that image frames are unlocked after passing to ImageDecodingStore.

* tests/ImageFrameGeneratorTest.cpp:
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(WebCore::MockImageDecoderClient::frameBuffersLocked):
(WebCore::MockImageDecoderClient::frameBuffersUnlocked):
(WebCore::MockImageDecoder::unlockFrameBuffers):
(WebCore::MockImageDecoder::lockFrameBuffers):
(MockImageDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInsufficient validation when uploading depth textures to WebGL
kbr@google.com [Wed, 27 Feb 2013 22:44:29 +0000 (22:44 +0000)]
Insufficient validation when uploading depth textures to WebGL
https://bugs.webkit.org/show_bug.cgi?id=110931

Reviewed by Abhishek Arya.

Source/WebCore:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
    Check for valid format/type combinations, depth, and
    depth+stencil formats when uploading HTML elements and
    ImageData as textures.

LayoutTests:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases. These changes will be
added to the Khronos repository.

* webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:
    Added more test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThreaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows...
abarth@webkit.org [Wed, 27 Feb 2013 22:39:19 +0000 (22:39 +0000)]
Threaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html in debug
https://bugs.webkit.org/show_bug.cgi?id=110951

Reviewed by Eric Seidel.

We were triggering this ASSERT because we didn't understand that a
given frame might have multiple DocumentLoaders in various states. That
caused us to think that a DocumentLoader in the provisional state was
actually loading.

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Mac platform should support ability to scroll an element into visible
cfleizach@apple.com [Wed, 27 Feb 2013 22:10:11 +0000 (22:10 +0000)]
AX: Mac platform should support ability to scroll an element into visible
https://bugs.webkit.org/show_bug.cgi?id=109860

Reviewed by Beth Dakin.

Source/WebCore:

Support the scrollToMakeVisible() action for MacOS accessibility clients.

Tests: platform/mac/accessibility/scroll-to-visible-action.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(scrollToMakeVisibleCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR):

LayoutTests:

* platform/mac/accessibility/scroll-to-visible-action.html: Added.
* platform/mac/accessibility/scroll-to-visible-action-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlugin in iframe may not display
commit-queue@webkit.org [Wed, 27 Feb 2013 22:05:07 +0000 (22:05 +0000)]
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879

Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.

Source/WebCore:

Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.

Test: plugins/plugin-clip-subframe.html

* platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
* platform/ScrollView.h:
* platform/Widget.h:
(WebCore::Widget::clipRectChanged):
* plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
* plugins/PluginView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):

Source/WebKit/chromium:

Use clipRectChanged to update the geometry.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
* src/WebPluginContainerImpl.h:

Source/WebKit/mac:

Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.

* Plugins/WebBaseNetscapePluginView.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):

Source/WebKit2:

Update geometry when cliprect changes.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
* WebProcess/Plugins/PluginView.h:

Tools:

LogNPPSetWindow will be used with other ports as well.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

LayoutTests:

Use log-npp-set-window to ensure plugin clip changes correctly.

* platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
* platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
* plugins/plugin-clip-subframe-expected.txt: Added.
* plugins/plugin-clip-subframe.html: Added.
* plugins/resources/plugin-clip-subframe-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement channel up-mixing and down-mixing rules
crogers@google.com [Wed, 27 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Implement channel up-mixing and down-mixing rules
https://bugs.webkit.org/show_bug.cgi?id=110812

Reviewed by Kenneth Russell.

Source/WebCore:

Please see Web Audio specification for details of the AudioNode mixing rules attributes:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

Test: webaudio/audionode-channel-rules.html

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::channelCount):
(WebCore):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::channelInterpretation):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::updateChannelsForInputs):
* Modules/webaudio/AudioNode.h:
(AudioNode):
(WebCore::AudioNode::internalChannelCountMode):
(WebCore::AudioNode::internalChannelInterpretation):
* Modules/webaudio/AudioNode.idl:
* Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):
* Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::speakersSumFrom5_1_ToMono):
(WebCore):
* platform/audio/AudioBus.h:
(AudioBus):

LayoutTests:

* webaudio/audionode-channel-rules-expected.txt: Added.
* webaudio/audionode-channel-rules.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableCellDeathTest unit test fails on mac
schenney@chromium.org [Wed, 27 Feb 2013 21:42:18 +0000 (21:42 +0000)]
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed second attempt. Trying to get the right define for the OS.

* tests/RenderTableCellTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Need WebPage API for animating scroll position & zoom changes
commit-queue@webkit.org [Wed, 27 Feb 2013 21:30:16 +0000 (21:30 +0000)]
[BlackBerry] Need WebPage API for animating scroll position & zoom changes
https://bugs.webkit.org/show_bug.cgi?id=110912

Patch by Andrew Lo <anlo@rim.com> on 2013-02-27
Reviewed by Rob Buis.

Internally reviewed by Jakob Petsovits.
Internal PR 285468.

Add an API to WebPage for animated scroll position & zoom level
adjustments.

Have InputHandler use the new API.

Rename some variables to reflect the fact that they are not only
used by block zoom now.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
(WebKit):
(BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThreaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
abarth@webkit.org [Wed, 27 Feb 2013 21:23:05 +0000 (21:23 +0000)]
Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Darin Adler.

This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Introduce WebHyphenator class to consolidate hyphenation related method...
jochen@chromium.org [Wed, 27 Feb 2013 21:20:38 +0000 (21:20 +0000)]
[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform
https://bugs.webkit.org/show_bug.cgi?id=110953

Reviewed by Adam Barth.

This patch makes it easier to mock the hyphenation related methods.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::hyphenator):
* chromium/public/WebHyphenator.h: Added.
(WebKit):
(WebHyphenator):
(WebKit::WebHyphenator::canHyphenate):
(WebKit::WebHyphenator::computeLastHyphenLocation):
(WebKit::WebHyphenator::~WebHyphenator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip media tests that fail on content_shell
jochen@chromium.org [Wed, 27 Feb 2013 20:58:05 +0000 (20:58 +0000)]
Skip media tests that fail on content_shell

Unreviewed gardening.

* platform/chromium/ContentShellTestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] User credentials is not correctly handled
liachen@rim.com [Wed, 27 Feb 2013 20:50:35 +0000 (20:50 +0000)]
[BlackBerry] User credentials is not correctly handled
https://bugs.webkit.org/show_bug.cgi?id=110994

Source/WebCore:

Internal PR: 280990
Internal reviewed by Leo Yang.

Reviewed by Yong Li.

Following changes are made:
    Remove url from generating the hash to index user credential.
    Remove url from database.
    Use new CertMgrWrapper API to remove password from CertMgr.
    Handle encrypted password as binary data, instead of normal text string.
    When authentication fails, remove the saved user credential only when they match.
    Remove some url related API from CredentialBackingStore, as they are obsolete now.

No new tests as this is platform specific change about user credential.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::purgeCredentials):

Source/WebKit/blackberry:

Reviewed by Yong Li.

Following change are made:
    Remove url from CredentialTransformData, as url is not used anymore.
    Adapt to updated CredentialBackingStore API about removing url.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
* WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (48533): Full-frame plugins stopped working (download instead of loading...
jer.noble@apple.com [Wed, 27 Feb 2013 20:44:46 +0000 (20:44 +0000)]
REGRESSION (48533): Full-frame plugins stopped working (download instead of loading the plugin)
https://bugs.webkit.org/show_bug.cgi?id=111003

Reviewed by Anders Carlsson.

Also query the Page's pluginData when determining whether a given MIME type can be shown.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canShowMIMEType):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableCellDeathTest unit test fails on mac
schenney@chromium.org [Wed, 27 Feb 2013 20:43:46 +0000 (20:43 +0000)]
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed disabling of test that is hanging or crashing on Mac.

* tests/RenderTableCellTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor transform painting/hit testing code in RenderLayer.
hyatt@apple.com [Wed, 27 Feb 2013 20:40:28 +0000 (20:40 +0000)]
Refactor transform painting/hit testing code in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=110998

Reviewed by Eric Seidel.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
Pull the code that applies the transform for painting into a new
function that can also apply an additional translation offset. This
offset will be used by the new columns code when that patch lands.

(WebCore::RenderLayer::createLocalTransformState):
Also patched to be able to apply an additional translation offset.

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
Same as with painting, pull the code that applies the transform into
its own function and also enable an extra translation offset to be
applied.

* rendering/RenderLayer.h:
Added the new functions to the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove suppression invalidation logic from WebViewImpl
commit-queue@webkit.org [Wed, 27 Feb 2013 20:39:40 +0000 (20:39 +0000)]
[chromium] Remove suppression invalidation logic from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=110999

Patch by James Robinson <jamesr@chromium.org> on 2013-02-27
Reviewed by Adrienne Walker.

This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
by DumpRenderTree.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::scheduleComposite):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoplugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct...
jochen@chromium.org [Wed, 27 Feb 2013 20:38:31 +0000 (20:38 +0000)]
plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=110973

Reviewed by Adam Barth.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):

LayoutTests:

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
* plugins/netscape-plugin-setwindow-size-2.html:
* plugins/netscape-plugin-setwindow-size.html:
* plugins/pass-different-npp-struct.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTouch CSSGrammar.y.in to fix an internal buildbot
ddkilzer@apple.com [Wed, 27 Feb 2013 20:37:12 +0000 (20:37 +0000)]
Touch CSSGrammar.y.in to fix an internal buildbot

* css/CSSGrammar.y.in: Add copyright dates based on previous
commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Disable MathML support in release builds
zandobersek@gmail.com [Wed, 27 Feb 2013 20:21:39 +0000 (20:21 +0000)]
[GTK] Disable MathML support in release builds
https://bugs.webkit.org/show_bug.cgi?id=110981

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.

* Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds
as the code is not yet deemed production-ready.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd smartInsertDeleteEnabled setting to WebCore::Page
commit-queue@webkit.org [Wed, 27 Feb 2013 20:20:37 +0000 (20:20 +0000)]
Add smartInsertDeleteEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=107840

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-02-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Covered by editing/deleting/smart-editing-disabled.html.

* page/Settings.in: Add new setting with true as initial value.

Source/WebKit2:

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode): Remove code related to
isSmartInsertDeleteEnabled.
* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters): Remove isSmartInsertDeleteEnabled.
* Shared/WebPreferencesStore.h:
(WebKit): Add macro for smartInsertDeleteEnabled setting.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSmartInsertDeleteEnabled):
(WKPreferencesGetSmartInsertDeleteEnabled): Implement methods using the
new setting.
* UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Set smartInsertDeleteEnabled
setting using m_isSmartInsertDeleteEnabled to keep initial value on Mac.
(WebKit::WebPageProxy::creationParameters): Remove usage of
parameters.isSmartInsertDeleteEnabled.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::smartInsertDeleteEnabled): Enable method for
all platforms.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Remove m_isSmartInsertDeleteEnabled
initialization.
(WebKit::WebPage::updatePreferences): Set smartInsertDeleteEnabled
setting.
(WebKit::WebPage::isSmartInsertDeleteEnabled): Implement method using
settings.
(WebKit):
(WebKit::WebPage::setSmartInsertDeleteEnabled): Implement method using
settings.
* WebProcess/WebPage/WebPage.h:
(WebPage): Enable methods dealing with smartInsertDeleteEnabled for all
platforms and remove m_isSmartInsertDeleteEnabled as it will be a
setting.

LayoutTests:

Replace testRunner.setSmartInsertDeleteEnabled by
internals.settings.setSmartInsertDeleteEnabled in tests.

* editing/deleting/smart-editing-disabled.html:
* editing/selection/doubleclick-beside-cr-span.html:
* editing/selection/doubleclick-whitespace-crash.html:
* editing/selection/doubleclick-whitespace-img-crash.html:
* editing/selection/doubleclick-whitespace.html:
* platform/wk2/TestExpectations: Unflag
editing/deleting/smart-editing-disabled.html as it passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebSpeech: Support pause/resume ability
cfleizach@apple.com [Wed, 27 Feb 2013 20:14:45 +0000 (20:14 +0000)]
WebSpeech: Support pause/resume ability
https://bugs.webkit.org/show_bug.cgi?id=107345

Reviewed by Beth Dakin.

Source/WebCore:

Add in the pause/resume functionality to SpeechSynthesis. Also hook up
the callback events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
(WebCore):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::resume):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable some unsound DFG DCE
fpizlo@apple.com [Wed, 27 Feb 2013 20:11:40 +0000 (20:11 +0000)]
Disable some unsound DFG DCE
https://bugs.webkit.org/show_bug.cgi?id=110948

Reviewed by Michael Saboff.

DCE of bitops is not sound since the bitops might call some variant of valueOf.

This used to work right because ValueToInt32 was MustGenerate. From the DFG IR
standpoint it feels weird to make ValueToInt32 be MustGenerate since that node is
implemented entirely as a pure conversion. If we ever gave the DFG the ability to
do effectful bitops, we would most likely implement them as special nodes not
related to the ValueToInt32 and bitop nodes we have now.

This change is performance neutral.

* dfg/DFGNodeType.h:
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore storage scaffolding
andersca@apple.com [Wed, 27 Feb 2013 20:04:58 +0000 (20:04 +0000)]
More storage scaffolding
https://bugs.webkit.org/show_bug.cgi?id=110997

Reviewed by Andreas Kling.

* DerivedSources.make:
Add StorageAreaProxy.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::setItem):
Send back a DidSetItem message.

* WebKit2.xcodeproj/project.pbxproj:
Add generated files.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
Add the message receiver.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Remove the message receiver.

(WebKit::StorageAreaProxy::didSetItem):
add stub.

* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageAreaProxy.messages.in: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
weinig@apple.com [Wed, 27 Feb 2013 19:40:54 +0000 (19:40 +0000)]
REGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
<rdar://problem/13229828>

Reviewed by Dan Bernstein.

Due the change in CFBundleIdentifier, the WebProcess and PluginProcess were
unnecessarily muxing (they used to be whitelisted by OpenGL) to the discrete
GPU.

* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
Add NSSupportsAutomaticGraphicsSwitching YES.

* WebKit2.xcodeproj/project.pbxproj:
Re-add the PluginService.32-64.Info.plist plist to the project file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Don't add a body to platform request until necessary
ap@apple.com [Wed, 27 Feb 2013 19:14:16 +0000 (19:14 +0000)]
    Don't add a body to platform request until necessary
        https://bugs.webkit.org/show_bug.cgi?id=110900

        Reviewed by NOBODY (OOPS!).

        Reviewed by Brady Eidson.

        ResourceRequest now has more state for syncing between resource and platform parts.
        In addition to tracking which is up to date, we also track which has up to date
        HTTP Body.

        The reason is that we don't need the body on request before it's actually sent,
        and we actually cannot build it when networking is out of process.

        * WebCore.exp.in: Updated exports.

        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::setHTTPBody): Update HTTP body before returning it.
        (WebCore::ResourceRequestBase::updatePlatformRequest): Update according to HTTPBodyUpdatePolicy.
        (WebCore::ResourceRequestBase::updateResourceRequest): Ditto.

        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::formDataStreamLengthPropertyName):
        (WebCore::formCopyProperty):
        (WebCore::setHTTPBody):
        Changed to not update Content-Length in platform request directly. We need to keep it
        in sync with resource request, and it's easier to do in a caller. Exposed computed
        length as a property do avoid duplicating the work.

        * platform/network/cf/FormDataStreamCFNet.h: Removed unnecessary httpBodyFromStream().

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):
        (WebCore::didReceiveResponse):
        (WebCore::ResourceHandle::createCFURLConnection):
        Update body when necessary.

        (WebCore::ResourceRequest::nsURLRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        (WebCore::ResourceRequest::doUpdateResourceHTTPBody):
        (WebCore):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        (WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
        (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
        (WebCore::ResourceRequest::applyWebArchiveHackForMail):
        Ditto.

        * platform/network/cf/ResourceRequest.h: Track body up-to-date state.

        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::cfURLRequest): Honor HTTPBodyUpdatePolicy.
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't update body here.
        (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Update the body, and make sure
        that Content-Length is correct.
        (WebCore::ResourceRequest::doUpdateResourceRequest): Don't update body here.
        (WebCore::ResourceRequest::doUpdateResourceHTTPBody): Update the body, fixing a bug
        where body stream was lost if this function got called.
        (WebCore::ResourceRequest::applyWebArchiveHackForMail): No need to update body for this one.

        * platform/network/mac/ResourceRequestMac.mm: Ditto (but this didn't have a bug
        with streams in doUpdateResourceRequest()).

        * platform/network/mac/FormDataStreamMac.h: Forward declare formDataStreamLengthPropertyName().

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::createNSURLConnection):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        Update body when necessary.

        * platform/network/blackberry/ResourceRequest.h:
        * platform/network/chromium/ResourceRequest.h:
        * platform/network/curl/ResourceRequest.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/network/soup/ResourceRequest.h:
        * platform/network/win/ResourceRequest.h:
        Added stubs for new functions. These ports don't keep a platform request in ResourceRequest,
        and don't need updating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectations updates
schenney@chromium.org [Wed, 27 Feb 2013 19:03:00 +0000 (19:03 +0000)]
[Chromium] Test expectations updates

Unreviewed expectations after recent bug fixes.

* platform/chromium-mac-lion/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png:
* platform/chromium-win/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ENABLE_CSS3_TEXT_LINE_BREAK flag.
glenn@skynav.com [Wed, 27 Feb 2013 18:46:00 +0000 (18:46 +0000)]
Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
https://bugs.webkit.org/show_bug.cgi?id=110944

Reviewed by Dean Jackson.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in...
abucur@adobe.com [Wed, 27 Feb 2013 18:43:52 +0000 (18:43 +0000)]
REGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in MoveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=93247

Reviewed by Darin Adler.

Source/WebCore:

The listifyParagraph function inside InsertListCommand triggered a layout for the new list and updated
only the "start" Position. The insertion and layout may have changed the "end" Position as well. The patch
makes sure "end" is also recomputed.

Test: No new test, the patch fixes a regression.

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):

LayoutTests:

Update TestExpectations because the test doesn't crash any more.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ENABLE_STREAM guards to FileReaderLoader
commit-queue@webkit.org [Wed, 27 Feb 2013 18:38:44 +0000 (18:38 +0000)]
Add ENABLE_STREAM guards to FileReaderLoader
https://bugs.webkit.org/show_bug.cgi?id=110938

Patch by Zach Kuznia <zork@chromium.org> on 2013-02-27
Reviewed by Hajime Morrita.

* fileapi/FileReaderLoader.cpp:
* fileapi/FileReaderLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Remove myself from watchlist.
commit-queue@webkit.org [Wed, 27 Feb 2013 18:38:27 +0000 (18:38 +0000)]
Unreviewed. Remove myself from watchlist.

Patch by Yong Li <yong.li.webkit@outlook.com> on 2013-02-27

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build when DFG_JIT is not enabled
commit-queue@webkit.org [Wed, 27 Feb 2013 18:34:33 +0000 (18:34 +0000)]
Fix build when DFG_JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=110991

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

* jit/JIT.h:
(JSC::JIT::canBeOptimizedOrInlined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5...
commit-queue@webkit.org [Wed, 27 Feb 2013 18:19:04 +0000 (18:19 +0000)]
Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
https://bugs.webkit.org/show_bug.cgi?id=110905

Patch by John Griggs <jgriggs@rim.com> on 2013-02-27
Reviewed by Yong Li.

Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch QtWebKit to GStreamer 1.0.
allan.jensen@digia.com [Wed, 27 Feb 2013 18:18:13 +0000 (18:18 +0000)]
Switch QtWebKit to GStreamer 1.0.
https://bugs.webkit.org/show_bug.cgi?id=106669.

Original patch by Sebastian Dröge.
Reviewed by Csaba Osztrogonác.

Source/WebCore:

* WebCore.pri:

Tools:

Build with GStreamer 1.0 if available, but support GStreamer 0.10
temporarily to make upgrading easy and the patch suitable for Qt5.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Martin Robinson's blog to the planet
commit-queue@webkit.org [Wed, 27 Feb 2013 18:01:48 +0000 (18:01 +0000)]
Add Martin Robinson's blog to the planet
https://bugs.webkit.org/show_bug.cgi?id=110990

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-27
Reviewed by Eric Seidel.

* config.ini: Add my blog to the planet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebViewImpl::animate shimmy out through compositor
jamesr@google.com [Wed, 27 Feb 2013 17:53:04 +0000 (17:53 +0000)]
[chromium] Remove WebViewImpl::animate shimmy out through compositor
https://bugs.webkit.org/show_bug.cgi?id=110935

Reviewed by Adrienne Walker.

WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
important part of this indirection is that whenever the compositor is active, all animation calls must
route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
can set the appropriate rate limiting state. Animations may originate from
content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
redirect to the compositor when appropriate.

Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
all cases.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix BlackBerry::Platform::String to WTF::String conversion when the...
efidler@rim.com [Wed, 27 Feb 2013 17:48:07 +0000 (17:48 +0000)]
[BlackBerry] Fix BlackBerry::Platform::String to WTF::String conversion when the string is Latin-1-encoded.
https://bugs.webkit.org/show_bug.cgi?id=110986

Reviewed by Yong Li.

Internally reviewed by Nima Ghanavatian.
BlackBerry PR 292922

We were assuming all platform strings were valid UTF-8, which isn't true for Latin-1 strings.

* platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] REGRESSION(144183): It make negative delay tests fails
allan.jensen@digia.com [Wed, 27 Feb 2013 17:42:08 +0000 (17:42 +0000)]
[TexMap] REGRESSION(144183): It make negative delay tests fails
https://bugs.webkit.org/show_bug.cgi?id=110989

Reviewed by Noam Rosenthal.

Do not apply a negative offset to the animation starttime send to the GraphicLayerClient,
it needs the actual animation start not a virtual start.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix SourceBufferList so SourceBuffer.append() calls are always rejected after the...
acolwell@chromium.org [Wed, 27 Feb 2013 17:35:04 +0000 (17:35 +0000)]
Fix SourceBufferList so SourceBuffer.append() calls are always rejected after the MediaSource is closed.
https://bugs.webkit.org/show_bug.cgi?id=110917

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-reject-append-after-reopening.html

* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::clear):

LayoutTests:

* http/tests/media/media-source/video-media-source-reject-append-after-reopening-expected.txt: Added.
* http/tests/media/media-source/video-media-source-reject-append-after-reopening.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Context menu cannot be invoked after doing text selection in landscape...
commit-queue@webkit.org [Wed, 27 Feb 2013 17:20:15 +0000 (17:20 +0000)]
[BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
https://bugs.webkit.org/show_bug.cgi?id=110860

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.

PR 290248 Internally reviewed by Mike Fenton

Add a parameter to notify the webpage client which parts of selection have
changed in visual or in its selected DOM content. Refactor the selection details
parameter to platform repo.

The reason of this issue is that when javascript triggers webpage layout, the selection
will update its apperance event when the selected content is not changed. We want
to hide the context menu only when the selected content is changed not when only its
visual is changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added myself to committers.py
szledan@inf.u-szeged.hu [Wed, 27 Feb 2013 17:18:13 +0000 (17:18 +0000)]
Unreviewed. Added myself to committers.py

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] The virtual keyboard hides part of Signing In dialog
commit-queue@webkit.org [Wed, 27 Feb 2013 17:12:37 +0000 (17:12 +0000)]
[BlackBerry] The virtual keyboard hides part of Signing In dialog
https://bugs.webkit.org/show_bug.cgi?id=110836

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.

PR # 283427 Internally reviewed by Mike Fenton.

Store form credentials before javascript "onSubmit" event and notify
webpage client to save credentials after that event since javascript
may check credentials and stop the submission in its event handler.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
* WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r144192.
szledan@inf.u-szeged.hu [Wed, 27 Feb 2013 17:07:37 +0000 (17:07 +0000)]
Unreviewed, rolling out r144192.
http://trac.webkit.org/changeset/144192
https://bugs.webkit.org/show_bug.cgi?id=110984

Stored svn password on wrong computer (Requested by kkristof
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove unused WebKitPlatformSupport class
pilgrim@chromium.org [Wed, 27 Feb 2013 17:02:20 +0000 (17:02 +0000)]
[Chromium] Remove unused WebKitPlatformSupport class
https://bugs.webkit.org/show_bug.cgi?id=110982

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* chromium/public/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskipp inspector tests after r144071.
kadam@inf.u-szeged.hu [Wed, 27 Feb 2013 16:59:21 +0000 (16:59 +0000)]
[Qt] Unreviewed gardening. Unskipp inspector tests after r144071.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r134631) of border-radius percentage with border pixel
junov@google.com [Wed, 27 Feb 2013 16:48:03 +0000 (16:48 +0000)]
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889

Reviewed by Simon Fraser.

Source/WebCore:

Fixing background color filling to handle "non renderable" rounded
rectangles.

Test: fast/borders/border-radius-percent.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.

* fast/borders/border-radius-percent-expected.txt: Added.
* fast/borders/border-radius-percent.html: Added.
* platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing
fmalita@chromium.org [Wed, 27 Feb 2013 16:45:06 +0000 (16:45 +0000)]
[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=76557

Reviewed by Stephen Chenney.

Source/WebCore:

Always use kDst_Mode transfer for the shadow looper. Using kSrc_Mode to enforce CSS
box-shadow opaqueness at this level is not necessary since the RenderBoxModel box
decoration code already makes sure that shadows are filled with opaque black.

This change aligns the SVG shadow behavior (and pixel results) with CG/Safari.

No new tests, coverage provided by existing tests.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests:

* platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Generate a wrapper function for ReplaceableAttrSetter()
haraken@chromium.org [Wed, 27 Feb 2013 16:42:06 +0000 (16:42 +0000)]
[V8] Generate a wrapper function for ReplaceableAttrSetter()
https://bugs.webkit.org/show_bug.cgi?id=110781

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection function
for xxxReplaceableAttrSetter(), like this:

// For non-custom replaceable setters (Note: One implementation
is enough for all replaceable setters in one interface.)
void V8XXX:::ReplaceableAttrSetterCallback(...) {
  V8XXX::ReplaceableAttrSetter(...);
}

// For custom replaceable setters. (Note: This is treated as
a normal custom setter.)
void xxxAttrSetterCallback(...) {
  return xxxAttrSetterCustom(...);
}

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetterCallback):
(TestObjV8Internal):
(WebCore):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetterCallback):
(TestTypedefsV8Internal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Accept key events even when composing region is active.
mifenton@rim.com [Wed, 27 Feb 2013 16:26:05 +0000 (16:26 +0000)]
[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617

Reviewed by Rob Buis.

PR 293598.

Fix a regression in the previous patch caused
by an unhandled Alt key down being sent through
by IMF.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added myself to committers.py
kkristof@inf.u-szeged.hu [Wed, 27 Feb 2013 16:21:56 +0000 (16:21 +0000)]
Unreviewed. Added myself to committers.py

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Flash objects won't load until scrolling page
allan.jensen@digia.com [Wed, 27 Feb 2013 16:18:14 +0000 (16:18 +0000)]
[Qt] Flash objects won't load until scrolling page
https://bugs.webkit.org/show_bug.cgi?id=110149

Reviewed by Simon Hausmann.

Revert r134222. The issue from bug 101836 is no longer reproducable,
and the fix was causing flash objects to not load properly.

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] TextureMapper is too eager to use intermediate surfaces
commit-queue@webkit.org [Wed, 27 Feb 2013 16:16:16 +0000 (16:16 +0000)]
[Texmap] TextureMapper is too eager to use intermediate surfaces
https://bugs.webkit.org/show_bug.cgi?id=110762

Patch by No'am Rosenthal <noam@webkit.org> on 2013-02-27
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Refactor the way intermediate surfaces are handled in TextureMapperLayer.
Beforehand, we would create an intermediate surface whenever there is a chance of overlap, and
the intermediate surface would be the largest possible. The result would then be drawn to the
target surface with the layer's opacity and mask.

This would make it so that (1) surfaces are created even when they're not needed, i.e. when there
is no actual overlap, and (2) mask wouldn't be applied correctly.

In this patch the behavior is changed so that the area to be painted is divided to "overlapping"
and "non overlapping" regions. The non-overlapping regions are painted directly, while the overlapping
regions are tiled to smaller rectangles painted using an intermediate surface.
Masks are applied to those intermediate surfaces based on the transform of the actual mask, not drawn
together with the content texture like before.

This optimizes for the more common case of opacity animations on a large tree, while making the quite
rare case of composited masks slightly less optimized but always correct.

Tests: compositing/overlap-blending/children-opacity-huge.html
       compositing/overlap-blending/reflection-opacity-huge.html
       compositing/overlap-blending/children-opacity-no-overlap.html

* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/cairo/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::paintToTextureMapper):
* platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperBackingStore):
* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(TextureMapperPlatformLayer):
* platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
* platform/graphics/texmap/TextureMapperSurfaceBackingStore.h:
(TextureMapperSurfaceBackingStore):
* platform/graphics/texmap/TextureMapperTile.cpp:
(WebCore::TextureMapperTile::paint):
* platform/graphics/texmap/TextureMapperTile.h:
(TextureMapperTile):
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
* platform/graphics/texmap/TextureMapperTiledBackingStore.h:
(TextureMapperTiledBackingStore):
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
        Removed the "mask" parameter from TextureMapperPlatformLayer and overrides, since
        we no longer paint the contents and the mask in the same pass.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::TextureMapper):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setMaskMode):
(TextureMapper):
(WebCore::TextureMapper::isInMaskMode):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawNumber):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::draw):
(WebCore):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::TextureMapperImageBuffer::drawTexture):
(WebCore::TextureMapperImageBuffer::drawSolidColor):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(TextureMapperImageBuffer):
        Instead of painting the mask together with the texture/color, paint the mask
        by drawing with DestinationIn to an existing surface.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(TextureMapperPaintOptions):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::shouldBlend):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::replicaTransform):
(WebCore):
(WebCore::applyFilters):
(WebCore::resolveOverlaps):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::TextureMapperLayer::applyMask):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
* platform/graphics/texmap/TextureMapperLayer.h:
(WebCore):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::hasFilters):
* platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore):
(WebCore::TextureMapperShaderProgram::create):
* platform/graphics/texmap/TextureMapperShaderProgram.h:

LayoutTests:

Added a few ref-tests for correct overlap blending in accelearated compositing mode.
Skipping the new reflection test on Mac/Chromium since it's not rendered
properly on those platforms.

* compositing/overlap-blending/children-opacity-huge-expected.html: Added.
* compositing/overlap-blending/children-opacity-huge.html: Added.
* compositing/overlap-blending/children-opacity-no-overlap-expected.html: Added.
* compositing/overlap-blending/children-opacity-no-overlap.html: Added.
* compositing/overlap-blending/reflection-opacity-huge-expected.html: Added.
* compositing/overlap-blending/reflection-opacity-huge.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 27 Feb 2013 16:13:55 +0000 (16:13 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Template element support is already enabled in
development builds. Removing skip entries for related tests as they all pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 27 Feb 2013 16:11:21 +0000 (16:11 +0000)]
Unreviewed GTK gardening.

Rebaselining after r144096.

* platform/gtk/TestExpectations:
* platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/gtk/css2.1/replaced-elements-001-expected.png: Added.
* platform/gtk/css3/flexbox/button-expected.png: Added.
* platform/gtk/css3/flexbox/button-expected.txt: Added.
* platform/gtk/svg/custom/foreign-object-skew-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd plugins test expectations for content_shell
jochen@chromium.org [Wed, 27 Feb 2013 16:03:01 +0000 (16:03 +0000)]
Add plugins test expectations for content_shell

Unreviewed gardening.

* platform/chromium/ContentShellTestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [REGRESSION] [Audits] Disabled "Run" button styling is the same as...
apavlov@chromium.org [Wed, 27 Feb 2013 15:48:34 +0000 (15:48 +0000)]
Web Inspector: [REGRESSION] [Audits] Disabled "Run" button styling is the same as the enabled one
https://bugs.webkit.org/show_bug.cgi?id=110971

Reviewed by Yury Semikhatsky.

Split out PanelEnablerView-related rules into panelEnabledView.css and restored the missing rules
in inspector.css.

* inspector/front-end/inspector.css:
* inspector/front-end/panelEnablerView.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r144179.
vsevik@chromium.org [Wed, 27 Feb 2013 15:35:09 +0000 (15:35 +0000)]
Unreviewed, rolling out r144179.
http://trac.webkit.org/changeset/144179
https://bugs.webkit.org/show_bug.cgi?id=110980

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27

* public/WebTextInputType.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit::WebViewImpl::textInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type...
tkent@chromium.org [Wed, 27 Feb 2013 15:29:52 +0000 (15:29 +0000)]
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974

Reviewed by Kentaro Hara.

Source/WebCore:

Input elements with the multiple fields UI require flexible box
layout. We should use RenderFlexibleBox regardless of display
property values.

Tests: Update fast/forms/date/date-apparance-basic.html

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer):
Always use RenderFlexibleBox.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare createRenderer.

LayoutTests:

* fast/forms/date/date-appearance-basic-expected.txt:
* fast/forms/date/date-appearance-basic.html:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] Flickering after transitions on Apple HTML5 demo
allan.jensen@digia.com [Wed, 27 Feb 2013 15:27:21 +0000 (15:27 +0000)]
[TexMap] Flickering after transitions on Apple HTML5 demo
https://bugs.webkit.org/show_bug.cgi?id=102501

Reviewed by Noam Rosenthal.

Notify about animation start after the new animation is actually commited.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Refactor AuditsPanel with AuditController as newly introduced entity
vivek.vg@samsung.com [Wed, 27 Feb 2013 15:11:54 +0000 (15:11 +0000)]
Web Inspector: Refactor AuditsPanel with AuditController as newly introduced entity
https://bugs.webkit.org/show_bug.cgi?id=110866

Reviewed by Alexander Pavlov.

Source/WebCore:

AuditController is being introduced in order to follow MVC pattern with the Audits.
This is the first step about the refactoring. Moving the methods from the AuditsPanel
into AuditController would ease the event driven approach to de-couple the AuditsPanel
and the AuditLauncherView.

No new tests as code refactoring.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AuditController.js: Added.
(WebInspector.AuditController):
(WebInspector.AuditController.prototype.ruleResultReadyCallback):
(WebInspector.AuditController.prototype.categoryDoneCallback):
(WebInspector.AuditController.prototype._executeAudit):
(WebInspector.AuditController.prototype._auditFinishedCallback):
(WebInspector.AuditController.prototype.startAuditWhenResourcesReady):
(WebInspector.AuditController.prototype.initiateAudit):
(WebInspector.AuditController.prototype._reloadResources):
(WebInspector.AuditController.prototype._didMainResourceLoad):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._startAudit):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype.auditFinishedCallback):
* inspector/front-end/WebKit.qrc:

LayoutTests:

* inspector/extensions/extensions-audits-tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
schenney@chromium.org [Wed, 27 Feb 2013 15:11:19 +0000 (15:11 +0000)]
[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
https://bugs.webkit.org/show_bug.cgi?id=110922

Unreviewed build fix.

* tests/GIFImageDecoderTest.cpp:
(WebKit):
(WebKit::TEST): Disable the entire test on Android.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 15:00:34 +0000 (15:00 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Should not return WebTextInputTypeNone for date input element.
commit-queue@webkit.org [Wed, 27 Feb 2013 14:54:00 +0000 (14:54 +0000)]
[Chromium] Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740

Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused.  So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.

* public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Region overset property is not properly computed when there is a region...
commit-queue@webkit.org [Wed, 27 Feb 2013 14:50:21 +0000 (14:50 +0000)]
[CSS Regions] Region overset property is not properly computed when there is a region break
https://bugs.webkit.org/show_bug.cgi?id=92497

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-02-27
Reviewed by David Hyatt.

Source/WebCore:

For "paginated" content in regions that has -webkit-region-break-after:always, the bottom margin was being passed
along for the next region in the chain, which shouldn't happen.

The fix is, at layout, to clear the bottom margin for the nodes (inside paginated contexts) that have
-webkit-region-break-after:always.

Tests: fast/multicol/break-after-always-bottom-margin.html
       fast/regions/overset-break-nested.html
       fast/regions/overset-break-with-sibling.html
       fast/regions/overset-break.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::applyAfterBreak):

LayoutTests:

* fast/multicol/break-after-always-bottom-margin-expected.txt: Added.
* fast/multicol/break-after-always-bottom-margin.html: Added.
* fast/regions/overset-break-expected.txt: Added.
* fast/regions/overset-break-nested-expected.txt: Added.
* fast/regions/overset-break-nested.html: Added.
* fast/regions/overset-break-with-sibling-expected.txt: Added.
* fast/regions/overset-break-with-sibling.html: Added.
* fast/regions/overset-break.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 14:47:41 +0000 (14:47 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBindings test results update after r144126
schenney@chromium.org [Wed, 27 Feb 2013 14:46:57 +0000 (14:46 +0000)]
Bindings test results update after r144126
https://bugs.webkit.org/show_bug.cgi?id=108196

Unreviewed test update.

* bindings/scripts/test/JS/JSTestObj.cpp: Add include of CallbackFunction.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Adapt test expectations to V8 __proto__ changes.
commit-queue@webkit.org [Wed, 27 Feb 2013 13:49:31 +0000 (13:49 +0000)]
[chromium] Adapt test expectations to V8 __proto__ changes.
https://bugs.webkit.org/show_bug.cgi?id=110887

Patch by Michael Starzinger <mstarzinger@chromium.org> on 2013-02-27
Reviewed by Stephen Chenney.

ad window-custom-prototype) This is expected bahavior, consistent with
SpiderMonkey. The test expectation is broken. Assigning 'null' to
'__proto__' makes the accessor installed on Object.prototype disappear.

ad JSON-parse) The result of JSON.parse() doesn't match the result we
get when evaluating the same string through eval() as V8 still has
special handling of the __proto__ property for object literals.

ad cyclic-prototypes) Test fully matches the WebKit expectation now and
no longer fails. However the exception message has a slightly different
format and hence causes a text diff.

* platform/chromium/TestExpectations: Temporary mark tests failing.
* platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
* platform/chromium/fast/js/JSON-parse-expected.txt:
* platform/chromium/fast/js/cyclic-prototypes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug in atomicIncrement implementation for MIPS GCC
commit-queue@webkit.org [Wed, 27 Feb 2013 13:34:06 +0000 (13:34 +0000)]
Bug in atomicIncrement implementation for MIPS GCC
https://bugs.webkit.org/show_bug.cgi?id=110969

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

Fix of __sync_[add|sub]_and_fetch_8 for GCC patch.

* wtf/Atomics.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector front-end closure compilaiton fix.
vsevik@chromium.org [Wed, 27 Feb 2013 13:07:46 +0000 (13:07 +0000)]
Unreviewed inspector front-end closure compilaiton fix.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 12:49:29 +0000 (12:49 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 12:38:20 +0000 (12:38 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 ...
commit-queue@webkit.org [Wed, 27 Feb 2013 12:09:18 +0000 (12:09 +0000)]
REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
https://bugs.webkit.org/show_bug.cgi?id=108632

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

It appears that mprotect() is very slow on ARM/Linux, so disable the
approach of unreserved mappings there and fall back to overcomitting
memory, based on Uli Schlachter's recommendation.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[texmap] Do not apply clip state if redundant
bruno.abinader@basyskom.com [Wed, 27 Feb 2013 12:05:58 +0000 (12:05 +0000)]
[texmap] Do not apply clip state if redundant
https://bugs.webkit.org/show_bug.cgi?id=110790

Reviewed by Noam Rosenthal.

Add a bool to check if clip state has changed since last apply.

No behavior changes, thus covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::pop):
(WebCore::TextureMapperGL::ClipStack::apply):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::ClipStack::ClipStack):
(ClipStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Fix massive parallel builds
hausmann@webkit.org [Wed, 27 Feb 2013 12:05:56 +0000 (12:05 +0000)]
[Qt][Mac] Fix massive parallel builds

Reviewed by Tor Arne Vestbø.

There exists a race condition that LLIntDesiredOffsets.h is written to
by two parllel instances of the ruby script. This patch ensures that similar to the output file,
the generated file is also prefixed according to the build configuration.

* LLIntOffsetsExtractor.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 12:03:36 +0000 (12:03 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream constructor test should cover ended MediaStreamTrack.
li.yin@intel.com [Wed, 27 Feb 2013 11:51:09 +0000 (11:51 +0000)]
MediaStream constructor test should cover ended MediaStreamTrack.
https://bugs.webkit.org/show_bug.cgi?id=110941

Reviewed by Kentaro Hara.

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream
If tracks has ended, it should skip these tracks and continue with the next one.

* fast/mediastream/MediaStreamConstructor-expected.txt:
* fast/mediastream/MediaStreamConstructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Replace use of WebPreferences with use of WKPrefences C API
michael.bruning@digia.com [Wed, 27 Feb 2013 11:40:36 +0000 (11:40 +0000)]
[Qt][WK2] Replace use of WebPreferences with use of WKPrefences C API
https://bugs.webkit.org/show_bug.cgi?id=108952

Reviewed by Simon Hausmann.

Signed off for WebKit2 by Benjamin Poulain.

This patch moves the view classes and preferences in the Qt API
to use the C API for accessing and manipulating preferences as
part of the cleanup and move towards using the C API as base for
the Qt WebKit2 API.

Adds the function WebKit::adoptToQString for convenience when
dealing with QString and copied String objects.

Removes the ScrollAnimatorEnabled options from QWebPreferences.

* UIProcess/API/cpp/qt/WKStringQt.cpp:
(WebKit::adoptToQString):
* UIProcess/API/cpp/qt/WKStringQt.h:
(WebKit):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/API/qt/qwebpreferences_p_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening
thiago.santos@intel.com [Wed, 27 Feb 2013 11:07:19 +0000 (11:07 +0000)]
[EFL] Unreviewed gardening

Updated tests baselines.

* platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXHR should fire 'abort' event when navigation interrupts a request.
mkwst@chromium.org [Wed, 27 Feb 2013 10:53:30 +0000 (10:53 +0000)]
XHR should fire 'abort' event when navigation interrupts a request.
https://bugs.webkit.org/show_bug.cgi?id=110867

Reviewed by Alexey Proskuryakov.

Adding a layout test to ensure that navigation-canceled XMLHttpRequests
fire an 'abort' event rather than an 'error' event.

* http/tests/xmlhttprequest/navigation-should-abort-expected.txt: Added.
* http/tests/xmlhttprequest/navigation-should-abort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r144155. The report page is located at /api/report, not /api/test...
rniwa@webkit.org [Wed, 27 Feb 2013 10:16:08 +0000 (10:16 +0000)]
Build fix after r144155. The report page is located at /api/report, not /api/test/report.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: timeline stops working on certain sites
eustas@chromium.org [Wed, 27 Feb 2013 10:15:10 +0000 (10:15 +0000)]
Web Inspector: timeline stops working on certain sites
https://bugs.webkit.org/show_bug.cgi?id=110955

Reviewed by Alexander Pavlov.

Analysis: "timerId" value is number,
so it is not wrapped to node as expected.

Solution: wrap values of all types except Node.

* inspector/front-end/TimelinePresentationModel.js:
Wrap nonstring values to text nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening
thiago.santos@intel.com [Wed, 27 Feb 2013 10:03:38 +0000 (10:03 +0000)]
[EFL] Unreviewed gardening

Mark custom elements tests as failures until we enable them.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove test related to html5lib after r144032
commit-queue@webkit.org [Wed, 27 Feb 2013 09:22:23 +0000 (09:22 +0000)]
[EFL] Remove test related to html5lib after r144032
https://bugs.webkit.org/show_bug.cgi?id=110946

Unreviewed, EFL gardening.

Test was removed after r144032. And remove it from TestExpectations.
html5lib/generated/run-template.html.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-02-27

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT...
abarth@webkit.org [Wed, 27 Feb 2013 09:21:56 +0000 (09:21 +0000)]
HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=110949

Reviewed by Eric Seidel.

We can hit this ASSERT if didReceiveParsedChunkFromBackgroundParser is
called from the background thread while we're processing
m_speculations (i.e., if processing m_speculations is taking a while
and we've yielded to the event loop).

It's hard to write a deterministic test for this patch, but it's hit
quite often with existing LayoutTests.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Generate a wrapper function for named constructor callbacks
haraken@chromium.org [Wed, 27 Feb 2013 09:09:20 +0000 (09:09 +0000)]
[V8] Generate a wrapper function for named constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=110794

Reviewed by Adam Barth.

This would be the final step of generating wrapper functions.
The patch generates the following wrapper function for named
constructor callbacks.

Handle<Value> namedConstructorCallback(...)
{
    return namedConstructor(...);
}

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 09:02:55 +0000 (09:02 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop uploading results to webkit-perf.appspot.com
rniwa@webkit.org [Wed, 27 Feb 2013 08:56:33 +0000 (08:56 +0000)]
Stop uploading results to webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=110954

Reviewed by Benjamin Poulain.

When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
Also, always use the new JSON format. Removed the code to generate the old format.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
(PerfTestsRunner._merge_slave_config_json):
(PerfTestsRunner._generate_output_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: show raster tasks on Timeline
caseq@chromium.org [Wed, 27 Feb 2013 08:37:15 +0000 (08:37 +0000)]
Web Inspector: show raster tasks on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851

- add DeferPaint, Paint & RasterTask trace events handling to trace event processor;
- upon begin frame, emit aggregated background event for all raster tasks related to inspected page.

Reviewed by Pavel Feldman.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):
* inspector/InspectorInstrumentation.h:
(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
* inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
(WebCore):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
* inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
* inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(TimelineTraceEventProcessor):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Wed, 27 Feb 2013 08:33:20 +0000 (08:33 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the tests based on computedStyleIncludingVisitedInfo for asynchronous update...
benjamin@webkit.org [Wed, 27 Feb 2013 08:23:06 +0000 (08:23 +0000)]
Fix the tests based on computedStyleIncludingVisitedInfo for asynchronous update of the visited style
https://bugs.webkit.org/show_bug.cgi?id=110708

Reviewed by Ryosuke Niwa.

The tests using computedStyleIncludingVisitedInfo were using the asumption that visited style
is updated synchronously with the loading of resources.
This assumption is valid for Mac WebKit1, but does not hold for multiprocess
WebKit because the list of visited URLs is maintained outside the WebProcess.

This patch changes the tests to use the 'shouldBecomeXXX' test functions in order to wait
for the asynchronous update. With the change, all the tests succeed reliably on WebKit2.

* fast/history/multiple-classes-visited-expected.txt:
* fast/history/multiple-classes-visited.html:
* fast/history/nested-visited-test-expected.txt:
* fast/history/nested-visited-test.html:
* fast/history/self-is-visited-expected.txt:
* fast/history/self-is-visited.html:
* fast/history/sibling-visited-test-expected.txt:
* fast/history/sibling-visited-test.html:
* fast/js/resources/js-test-pre.js:
(.condition):
(.failureHandler):
(shouldBecomeDifferent):
* platform/wk2/TestExpectations:
* platform/chromium/TestExpectations: The tests can now also timeout due to
computedStyleIncludingVisitedInfo missing from Chromium's DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Wed, 27 Feb 2013 08:09:16 +0000 (08:09 +0000)]
Unreviewed gardening.

* platform/efl/TestExpectations: Removing expectation for html5lib/runner.html, the test was removed in r144032.
* platform/gtk/TestExpectations: Ditto.
* platform/gtk/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added. Required after r144105.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r144136, r144143, and r144147.
commit-queue@webkit.org [Wed, 27 Feb 2013 08:04:01 +0000 (08:04 +0000)]
Unreviewed, rolling out r144136, r144143, and r144147.
http://trac.webkit.org/changeset/144136
http://trac.webkit.org/changeset/144143
http://trac.webkit.org/changeset/144147
https://bugs.webkit.org/show_bug.cgi?id=110950

Caused some timeouts and flaky crashes (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27

Tools:

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

* platform/chromium-mac/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
* platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
* platform/chromium-win/http/tests/loading/redirect-methods-expected.txt:
* platform/chromium-win/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
* platform/chromium/TestExpectations:
* platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
* platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Removed.
* platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Removed.
* platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
* platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
* platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Removed.
* platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Removed.
* platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Removed.
* platform/chromium/security/block-test-no-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOne more unreviewed fix after r144032 and r144051.
ossy@webkit.org [Wed, 27 Feb 2013 07:32:15 +0000 (07:32 +0000)]
One more unreviewed fix after r144032 and r144051.
https://bugs.webkit.org/show_bug.cgi?id=110734

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-26

* TestExpectations: Unskip tests.
* html5lib/generated/run-template-write.html: Revert an accidental change by r144051.
* platform/gtk/TestExpectations: Skip run-template-data.html and run-template-write.html instead of run-template.html
* platform/mac/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.
* platform/wincairo/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r144129.
vsevik@chromium.org [Wed, 27 Feb 2013 07:17:48 +0000 (07:17 +0000)]
Unreviewed, rolling out r144129.
http://trac.webkit.org/changeset/144129
https://bugs.webkit.org/show_bug.cgi?id=110947

Breaks compilation on chromium mac and win (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26

Source/Platform:

* chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willBeginFrame):
(WebKit):
(WebKit::WebViewImpl::didBeginFrame):
* src/WebViewImpl.h:
* tests/WebLayerTreeViewTestCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Wed, 27 Feb 2013 06:18:58 +0000 (06:18 +0000)]
Unreviewed.

Note another multipart failure to work through.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144147 268f45cc-cd09-0410-ab3c-d52691b4dbfc