WebKit-https.git
11 years ago2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Wed, 15 Jul 2009 01:11:29 +0000 (01:11 +0000)]
2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
        https://bugs.webkit.org/show_bug.cgi?id=27249

        ParserArenaDeletable customizes operator new, to avoid double inheritance
        ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.

        * parser/Nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jparent@chromium.org [Wed, 15 Jul 2009 01:02:12 +0000 (01:02 +0000)]
WebCore:

2009-07-14  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        Outdenting a line inside a blockquote tag does nothing
        https://bugs.webkit.org/show_bug.cgi?id=25316

        The bug was caused by the code checking whether the blockquote is created by WebKit or not.
        We simply remove this code to be consistent with Firefox and Internet Explorer.
        Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
        the placeholder before the enclosingNode because there could be contents before the current paragraph.
        Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
        It turned out that this solves the bug 25315 also: https://bugs.webkit.org/show_bug.cgi?id=25315

        Test: editing/execCommand/outdent-regular-blockquote.html

        * editing/IndentOutdentCommand.cpp:
        (WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not.
        (WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode

LayoutTests:

2009-07-14  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        Outdenting a line inside a blockquote tag does nothing
        https://bugs.webkit.org/show_bug.cgi?id=25315
        https://bugs.webkit.org/show_bug.cgi?id=25316

        The expected result for /editing/execCommand/outdent-selection-expected.html
        was rebaselined since the original expected result was wrong (Bug 25315).
        Namely, "ipsum" moved to the same paragraph as "more Lorem!"
        ("ipsum" was in the blockblock immediately below "more Lorem!")
        and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".

        * editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
        * editing/execCommand/outdent-regular-blockquote.html: Added.
        * platform/mac/editing/execCommand/outdent-selection-expected.checksum:
        * platform/mac/editing/execCommand/outdent-selection-expected.png:
        * platform/mac/editing/execCommand/outdent-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Wed, 15 Jul 2009 00:47:46 +0000 (00:47 +0000)]
2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Add RefCountedCustomAllocated to RefCounted.h
        https://bugs.webkit.org/show_bug.cgi?id=27232

        Some class which are inherited from RefCounted customize
        operator new, but RefCounted is inherited from Noncopyable
        which will be inherited from FastAllocBase. To avoid
        conflicts Noncopyable inheriting was moved down to RefCounted
        and to avoid double inheritance this class has been added.

        * wtf/RefCounted.h:
        (WTF::RefCountedCustomAllocated::deref):
        (WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 15 Jul 2009 00:10:46 +0000 (00:10 +0000)]
2009-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix isolated world wrappers for Node prototypes
        https://bugs.webkit.org/show_bug.cgi?id=27277

        This change does two things:

        1) We bypass the wrapper cache in the isolated world.  This is because
           the wrapper template cache has prototypes that lead to the main
           world.  We can add a template cache for the isolated world if
           performance warrants.

        2) We introduce a smarter way to grab the wrapper context for a frame
           that is aware that proxy <-> context do not stand in one-to-one
           correspondence.  This generalizes our solution for the node wrapper
           case to prototypes.

        The net result is that Node wrappers get the right prototypes.  As
        before, tests to follow.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::setHiddenWindowReference):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertNodeToV8Object):
        (WebCore::V8DOMWrapper::convertWindowToV8Object):
        (WebCore::V8DOMWrapper::getWrapperContext):
        * bindings/v8/V8DOMWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Wed, 15 Jul 2009 00:05:12 +0000 (00:05 +0000)]
2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Add NoncopyableCustomAllocated to Noncopyable.h.
        https://bugs.webkit.org/show_bug.cgi?id=27228

        Some classes which inherited from Noncopyable overrides operator new
        since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
        needs to be extended with this new class to support the overriding.

        * wtf/Noncopyable.h:
        (WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated):
        (WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 14 Jul 2009 23:36:49 +0000 (23:36 +0000)]
2009-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix isolated world wrappers for Nodes
        https://bugs.webkit.org/show_bug.cgi?id=27271

        Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
        caused us to miss the branch in V8DOMMap.cpp for isolated worlds.

        I have tests, but I can't land them until I get this feature under
        control.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertNodeToV8Object):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Tue, 14 Jul 2009 23:16:12 +0000 (23:16 +0000)]
2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
        https://bugs.webkit.org/show_bug.cgi?id=27260

        Inherits IdentifierTable class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.

        * runtime/Identifier.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 14 Jul 2009 23:09:09 +0000 (23:09 +0000)]
2009-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix isolated world crash on getting window.location
        https://bugs.webkit.org/show_bug.cgi?id=27268

        I have a test for this locally, but it requires a compile-time hack to
        run.  Once I get the feature's stability under control, we can turn the
        feature on and add the tests.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::setHiddenWindowReference):
        * bindings/v8/V8IsolatedWorld.h:
        (WebCore::V8IsolatedWorld::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Tue, 14 Jul 2009 23:02:40 +0000 (23:02 +0000)]
2009-07-14  Brent Fulgham  <bfulgham@webkit.org>

        Correct failing tests after r45875.  The original patch did not
        test the m_player member for null, causing crashes.  This will
        happen fairly frequently in real use.  Was this original patch
        ever tested?
        https://bugs.webkit.org/show_bug.cgi?id=27246

        Test via existing media tests.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer.
        (WebCore::HTMLMediaElement::supportsSave): Check for null pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Avi Drissman <avi@chromium.org>
darin@chromium.org [Tue, 14 Jul 2009 22:50:06 +0000 (22:50 +0000)]
2009-07-14  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Fisher.

        Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
        The Windows clipboard format is explicitly documented as being UTF-8,
        and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
        indicated, Windows-1252 is assumed, which is wrong.

        Bug: https://bugs.webkit.org/show_bug.cgi?id=27262

        No new tests.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeRange):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Tue, 14 Jul 2009 22:43:30 +0000 (22:43 +0000)]
2009-07-14  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's Profiler class
        https://bugs.webkit.org/show_bug.cgi?id=27253

        Inherits Profiler class from FastAllocBase because it has been instantiated by
        'new' in JavaScriptCore/profiler/Profiler.cpp:56.

        * profiler/Profiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Albert J. Wong <ajwong@chromium.org>
japhet@chromium.org [Tue, 14 Jul 2009 22:35:31 +0000 (22:35 +0000)]
2009-07-14  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream V8NPObject.h and V8NPObject.cpp.
        https://bugs.webkit.org/show_bug.cgi?id=27103

        This just upstreams the files from the chromium code base. Only
        minor changes to formatting and similar were done, so no testing
        is required because nothing really changed.  Code verified to compile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Albert J. Wong <ajwong@chromium.org>
bfulgham@webkit.org [Tue, 14 Jul 2009 22:20:19 +0000 (22:20 +0000)]
2009-07-14  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Darin Adler.

        Add HTMLMediaElement::supportSave() and a
        HitTestResult::absoluteMediaURL() functions
        https://bugs.webkit.org/show_bug.cgi?id=27246

        Added an implementation of supportsSave() into HTMLMediaElement
        that delegates to MediaPlayerPrivateImpl so that the media engine
        is able to signal whether or not a media source supports saving.

        Also added a function to HitTestResult that allows for retrieval
        of the currentSrc associated with the "hit" media element.

        These functions are just pipeing with no visible UI change so there
        are no related layout test changes.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::supportsFullscreen):
        (WebCore::HTMLMediaElement::supportsSave):
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::supportsSave):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::supportsFullscreen):
        (WebCore::MediaPlayerPrivateInterface::supportsSave):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::altDisplayString):
        (WebCore::HitTestResult::absoluteMediaURL):
        * rendering/HitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 14 Jul 2009 22:00:24 +0000 (22:00 +0000)]
2009-07-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Implement Reflect and ReflectURL attribute support.
        https://bugs.webkit.org/show_bug.cgi?id=27273

        * bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Dmitry Titov <dimich@chromium.org>
bfulgham@webkit.org [Tue, 14 Jul 2009 21:28:38 +0000 (21:28 +0000)]
2009-07-14  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27266
        Add hasCurrentPoint() to WebCore::Path.
        This fixes Skia-based Chromium regression caused by the fix for
        https://bugs.webkit.org/show_bug.cgi?id=27187.
        For Skia, the new method always returns 'true', pending actual implementation.
        This means Chromium still will differ from Gecko behavior, but at least its Canvas
        will not be completely broken.

        Existing Canvas Layout Tests should pass in Chromium after this change.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint().
        (WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto.
        (WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.

        * platform/graphics/Path.h:
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::hasCurrentPoint):
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::isEmpty):
        (WebCore::Path::hasCurrentPoint):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::hasCurrentPoint):
        * platform/graphics/skia/PathSkia.cpp:
        (WebCore::Path::hasCurrentPoint):
        * platform/graphics/wx/PathWx.cpp:
        (WebCore::Path::hasCurrentPoint):
        All these files add a Path::hasCurrentPoint() for various platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 14 Jul 2009 21:15:24 +0000 (21:15 +0000)]
2009-07-14  Nate Chapin  <japhet@chromium.org>

        Reviewed by Sam Weinig.

        Upstream RGBColor from src.chromium.org.

        https://bugs.webkit.org/show_bug.cgi?id=27133

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-10 Matt Perry <mpcomplete@chromium.org>
mpcomplete@chromium.org [Tue, 14 Jul 2009 21:05:05 +0000 (21:05 +0000)]
2009-07-10  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Rename the didCreate/DestroyScriptContext calls to make it
        clear that that those refer to the frame's contxt.  Add another
        similar call for when creating contexts via evaluateInNewContext.
        https://bugs.webkit.org/show_bug.cgi?id=27104

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInNewContext):
        (WebCore::V8Proxy::disposeContextHandles):
        (WebCore::V8Proxy::initContextIfNeeded):
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
        (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
        (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
        * loader/FrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Tue, 14 Jul 2009 20:39:17 +0000 (20:39 +0000)]
2009-07-14  Brent Fulgham  <bfulgham@webkit.org>

        Revert http://trac.webkit.org/changeset/45864 after
        breaking of Windows build.

        * storage/LocalStorageTask.cpp:
        * storage/LocalStorageTask.h:
        * storage/Storage.cpp:
        * storage/Storage.h:
        * storage/StorageArea.cpp:
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        * storage/StorageAreaImpl.h:
        * storage/StorageAreaSync.cpp:
        * storage/StorageAreaSync.h:
        * storage/StorageEvent.cpp:
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::StorageEvent):
        * storage/StorageNamespace.h:
        * storage/StorageNamespaceImpl.cpp:
        * storage/StorageNamespaceImpl.h:
        * storage/StorageSyncManager.cpp:
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-06 George Staikos <george.staikos@torchmobile.com>
treat@webkit.org [Tue, 14 Jul 2009 20:21:59 +0000 (20:21 +0000)]
2009-07-06  George Staikos  <george.staikos@torchmobile.com>

        Reviewed by Adam Treat.

        Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura

        https://bugs.webkit.org/show_bug.cgi?id=27030
        Implement custom RNG for WinCE using Mersenne Twister

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):
        * wtf/RandomNumberSeed.h:
        (WTF::initializeRandomNumberGenerator):
        * wtf/wince/mt19937ar.c: Added.
        (init_genrand):
        (init_by_array):
        (genrand_int32):
        (genrand_int31):
        (genrand_real1):
        (genrand_real2):
        (genrand_real3):
        (genrand_res53):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-11 Jeremy Orlow <jorlow@chromium.org>
bfulgham@webkit.org [Tue, 14 Jul 2009 19:36:50 +0000 (19:36 +0000)]
2009-07-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Cleanup DOM Storage dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=27180

        DOM Storage had several unnecessary (and probably unintended)
        dependencies.  This patch replaces many includes of header files with
        forward declaration of classes, making some destructors explicit, and
        taking some factories out of the header files.

        This will allow things like StorageAreaSync to take a StorageAreaImpl*
        (as it should) rather than a StorageArea* which previously weren't
        possible because the dependencies were such a tangled mess.

        * storage/LocalStorageTask.cpp:
        (WebCore::LocalStorageTask::~LocalStorageTask):
        * storage/LocalStorageTask.h:
        * storage/Storage.cpp:
        (WebCore::Storage::~Storage):
        * storage/Storage.h:
        * storage/StorageArea.cpp:
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        * storage/StorageAreaImpl.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::~StorageAreaSync):
        * storage/StorageAreaSync.h:
        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::StorageEvent):
        * storage/StorageEvent.h:
        * storage/StorageNamespace.h:
        * storage/StorageNamespaceImpl.cpp:
        * storage/StorageNamespaceImpl.h:
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::~StorageSyncManager):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 14 Jul 2009 17:54:23 +0000 (17:54 +0000)]
2009-07-14  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=26983

        Check to make sure the view is attached to a frame() in the visibleContentsResized()
        method as it can be triggered before the view is attached by Frame::createView(...)
        setting various values such as setScrollBarModes(...) for example.  An ASSERT is
        triggered when a view is layout before being attached to a frame().

        * page/FrameView.cpp:
        (WebCore::FrameView::visibleContentsResized):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 14 Jul 2009 16:56:10 +0000 (16:56 +0000)]
2009-07-14  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Zack Rusin.

        https://bugs.webkit.org/show_bug.cgi?id=26983

        The default constructed values for QSize and WebCore::IntSize are different.  The former
        produces an invalid size whereas the latter produces a size of zero.  This was causing
        a layout to be triggered when constructing a view and an assert to be hit.  This patch fixes
        the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 14 Jul 2009 16:29:16 +0000 (16:29 +0000)]
2009-07-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: show last opened panel when invoking inspector.

        https://bugs.webkit.org/show_bug.cgi?id=27263

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::storeLastActivePanel):
        (WebCore::InspectorController::specialPanelForJSName):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::Setting::Setting):
        * inspector/InspectorController.idl:
        * inspector/front-end/inspector.js:
        (WebInspector.set currentPanel):
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Anton Muhin <antonm@chromium.org>
dglazkov@chromium.org [Tue, 14 Jul 2009 16:25:28 +0000 (16:25 +0000)]
2009-07-14  Anton Muhin  <antonm@chromium.org>

        Reviewed by Dimitri Glazkov.

        Speed up access to NodeList length.
        https://bugs.webkit.org/show_bug.cgi?id=27264

        That's a minimal alternation of the code.

        * bindings/v8/custom/V8NodeListCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use
        v8::Integer::New instead of v8::Number::New.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Anton Muhin <antonm@chromium.org>
dglazkov@chromium.org [Tue, 14 Jul 2009 16:16:10 +0000 (16:16 +0000)]
2009-07-14  Anton Muhin  <antonm@chromium.org>

        Reviewed by Dimitri Glazkov.

        Do not do unnecessary conversions from v8::Handle<v8::Value> to
        v8::Handle<v8::Object> and accompanying changes.
        https://bugs.webkit.org/show_bug.cgi?id=26953

        Three things:

        1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
        but are not free (they check for emptiness of handle);
        2) inline conversion from wrapper to node;
        3) simplify case to an ASSERT.

        This is just a refactoring, so no new tests are needed.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluateInNewContext):
        (WebCore::V8Proxy::convertToSVGPODTypeImpl):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::convertDOMWrapperToNative):
        (WebCore::V8Proxy::convertToNativeObject):
        (WebCore::V8Proxy::convertToNativeEvent):
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        (WebCore::toCanvasStyle):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8CustomBinding.cpp:
        (WebCore::V8Custom::GetTargetFrame):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::V8Custom::ClearTimeoutImpl):
        (WebCore::NAMED_ACCESS_CHECK):
        (WebCore::INDEXED_ACCESS_CHECK):
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 14 Jul 2009 16:06:18 +0000 (16:06 +0000)]
WebCore:

2009-07-14  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Straight quotes should match fancy quotes in in-page search
        https://bugs.webkit.org/show_bug.cgi?id=27217

        Tests: fast/text/find-quotes.html

        * editing/TextIterator.cpp:
        (WebCore::foldQuoteMark): Added.
        (WebCore::foldQuoteMarks): Added.
        (WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string.
        (WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are
        added to the search buffer.

        * platform/text/CharacterNames.h: Added more quotation mark character names.
        Sorted character names with the sort tool.

LayoutTests:

2009-07-14  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Straight quotes should match fancy quotes in in-page search
        https://bugs.webkit.org/show_bug.cgi?id=27217

        * fast/text/find-quotes-expected.txt: Added.
        * fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 14 Jul 2009 15:42:12 +0000 (15:42 +0000)]
2009-07-14  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        WebKit needs a style linting tool
        https://bugs.webkit.org/show_bug.cgi?id=25884

        Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
        based on WebKit's style guide.

        * Scripts/cpplint.py: Added.
        * Scripts/cpplint_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Tue, 14 Jul 2009 13:04:35 +0000 (13:04 +0000)]
2009-07-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] DumpRenderTree no longer builds with Qt4.4
        https://bugs.webkit.org/show_bug.cgi?id=27257

        Flag Qt 4.5 dependency to allow building with Qt 4.4.

        * DumpRenderTree/qt/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 14 Jul 2009 05:35:40 +0000 (05:35 +0000)]
2009-07-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: handle debugger shortcuts while on source frame or on
        script file selector.

        https://bugs.webkit.org/show_bug.cgi?id=27224

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 14 Jul 2009 04:00:01 +0000 (04:00 +0000)]
2009-07-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Use standard HashCountedSet instead of a hand rolled one
        in HTMLDocument.

        * html/HTMLDocument.cpp:
        (WebCore::addItemToMap):
        (WebCore::removeItemFromMap):
        * html/HTMLDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 14 Jul 2009 02:44:12 +0000 (02:44 +0000)]
2009-07-13  Brady Eidson  <beidson@apple.com>

        Fix Leopard regression I just introduced.

        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 14 Jul 2009 02:01:40 +0000 (02:01 +0000)]
2009-07-13  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mark Rowe.

        Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.

        * platform/mac-leopard/platform/mac/fast/loader: Added.
        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
        * platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
        * platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
        * platform/mac/fast/loader/file-url-mimetypes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 14 Jul 2009 01:04:19 +0000 (01:04 +0000)]
WebCore:

2009-07-13  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler and Maciej Stachowiak.

        Implement HTML5 draggable
        https://bugs.webkit.org/show_bug.cgi?id=26262

        This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
        to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

        Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

        Test: fast/html/draggable.html

        * css/html.css:
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::draggable):
        * html/HTMLAnchorElement.h:
        * html/HTMLAttributeNames.in:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::draggable):
        (WebCore::HTMLElement::setDraggable):
        * html/HTMLElement.h:
        * html/HTMLElement.idl:
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::draggable):
        * html/HTMLImageElement.h:

LayoutTests:

2009-07-13  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler and Maciej Stachowiak.

        Implement HTML5 draggable
        https://bugs.webkit.org/show_bug.cgi?id=26262

        This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
        to the CSS properties -webkit-user-drag and -webkit-user-select respectively.

        Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute

        * fast/html/draggable-expected.txt: Added.
        * fast/html/draggable.html: Added.
        * fast/html/resources: Added.
        * fast/html/resources/images: Added.
        * fast/html/resources/images/lime.png: Added.

        * fast/dom/resources/domListEnumeration.js: Updated.
        * fast/dom/domListEnumeration-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 14 Jul 2009 00:47:59 +0000 (00:47 +0000)]
2009-07-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Image rendered as layer contents looks different from image rendered via CG.
        <rdar://problem/7048830>

        Fix a visible color profile difference between between images rendered via Core Graphics
        and those rendered via a compositing layer, by assigning the GenericRGB profile to
        untagged images (which come through as having the DeviceRGB profile) when they are set
        as layer contents.

        Test: compositing/color-matching/image-color-matching.html

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 14 Jul 2009 00:20:25 +0000 (00:20 +0000)]
2009-07-13  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=27220
        Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)

        * editing/TextIterator.cpp:
        (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code
        in the assertion. Affects only the assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 14 Jul 2009 00:07:03 +0000 (00:07 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26925
        <rdar://problem/7027850> URL Fragment Breaks Application Cache Loads

        Test: http/tests/appcache/main-resource-hash.html

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::resourceForURL):
        (WebCore::ApplicationCache::resourceForRequest):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheForMainRequest):
        (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
        (WebCore::ApplicationCacheGroup::selectCache):
        (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
        (WebCore::ApplicationCacheGroup::didReceiveResponse):
        (WebCore::ApplicationCacheGroup::didFail):
        (WebCore::ApplicationCacheGroup::addEntry):
        Remove URL fragment at appcache code borders.

        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::create):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
        Assert that there is no URL fragment in URL at key points in appcache code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 14 Jul 2009 00:02:45 +0000 (00:02 +0000)]
WebCore:

2009-07-13  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27166
        rdar://problem/7015857
        Find for strings composed entirely of spaces doesn't work

        Test: fast/text/find-spaces.html

        * editing/TextIterator.cpp:
        (WebCore::findPlainText): Removed unneeded special case.
        The empty string case already works correctly.

LayoutTests:

2009-07-13  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27166
        rdar://problem/7015857
        Find for strings composed entirely of spaces doesn't work

        * fast/text/find-spaces-expected.txt: Added.
        * fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Mon, 13 Jul 2009 23:42:10 +0000 (23:42 +0000)]
2009-07-13  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
        https://bugs.webkit.org/show_bug.cgi?id=27240.

        * WebFrame.cpp:
        (WebFrame::printHeader): New shared method to print the header.
        (WebFrame::printFooter): New shared method to print the footer.
        (WebFrame::spoolPage): New conditionally-compiled method to print
         a page.
        (WebFrame::spoolPages): Revised to call the platform-specific spoolPage
         for each page.
        * WebFrame.h: Add new method prototypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 13 Jul 2009 23:23:37 +0000 (23:23 +0000)]
2009-07-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Remove NPPVpluginPrivateModeBool, it was removed from the spec.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Feng Qian <feng@chromium.org>
feng@chromium.org [Mon, 13 Jul 2009 23:08:01 +0000 (23:08 +0000)]
2009-07-13  Feng Qian  <feng@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27237

        Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.

        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::WeakReferenceMap):
        (WebCore::WeakReferenceMap::~WeakReferenceMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jul 2009 23:03:30 +0000 (23:03 +0000)]
2009-07-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.

        * WebCore.gypi: Removed bidi.cpp and bidi.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jul 2009 22:46:41 +0000 (22:46 +0000)]
2009-07-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Update WebCore.gyp in preparation to hooking it up.

        * WebCore.gypi: Added files that were mid-stream while switching over.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Leopard-specific results for fast/text/international/khmer-selection.html.
mrowe@apple.com [Mon, 13 Jul 2009 22:41:08 +0000 (22:41 +0000)]
Add Leopard-specific results for fast/text/international/khmer-selection.html.

* platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Mon, 13 Jul 2009 22:08:04 +0000 (22:08 +0000)]
2009-07-13  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, another small fix for Chromium build.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Mon, 13 Jul 2009 22:00:00 +0000 (22:00 +0000)]
2009-07-13  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, fix Chromium build bustage.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::JavaScriptConsoleMessage::addToPage):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::handleConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a missing layout test result to improve the quality of life of the Mac buildbots.
mrowe@apple.com [Mon, 13 Jul 2009 20:45:41 +0000 (20:45 +0000)]
Add a missing layout test result to improve the quality of life of the Mac buildbots.

* platform/mac/fast/text/international/khmer-selection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 13 Jul 2009 20:32:58 +0000 (20:32 +0000)]
2009-07-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Adam Roben.

        "Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
        <rdar://problem/6994893

        attachRootGraphicsLayer() should not assume that the frameView's documentView
        is a WebHTMLView.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::attachRootGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 13 Jul 2009 20:16:18 +0000 (20:16 +0000)]
WebCore:

2009-07-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27234
        <rdar://problem/7054356>

        Add null page check in HTMLDocument::hasFocus.

        Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::hasFocus): Add page null check.
        (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.

LayoutTests:

2009-07-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=27234
        <rdar://problem/7054356>

        * fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
        * fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 13 Jul 2009 20:13:17 +0000 (20:13 +0000)]
    Reviewed by Darin Adler.

        Disable continuous spell checking in the inspector
        https://bugs.webkit.org/show_bug.cgi?id=27131

        * inspector/front-end/inspector.html: Added spellcheck="false" to the
            main-panels and console-prompt containers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 13 Jul 2009 19:38:50 +0000 (19:38 +0000)]
2009-07-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler and Kevin Decker.

        <rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView setLayer:]):
        Add a FIXME.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView setLayer:]):
        Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted
        into the layer tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Adam Langley <agl@google.com>
agl@chromium.org [Mon, 13 Jul 2009 19:14:22 +0000 (19:14 +0000)]
2009-07-13  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium Linux: fix assertion when rendering google.com.kh

        https://bugs.webkit.org/show_bug.cgi?id=26924

        Some shapers (i.e. Khmer) will produce cluster logs which report that
        /no/ code points contributed to certain glyphs. Because of this, we
        take any code point which contributed to the glyph in question, or any
        subsequent glyph.  If we run off the end, then we take the last code
        point.

        Added LayoutTests/fast/text/international/khmar-selection.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::offsetForPositionForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 13 Jul 2009 19:05:12 +0000 (19:05 +0000)]
    Reviewed by Darin Adler.

        spellcheck="false" is ignored
        <rdar://problem/7054177>

        * editing/Editor.cpp:
        (WebCore::markMisspellingsOrBadGrammar): Moved code to check the
            spellcheck attribute from here...
        (WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out
            if spell chcking is disabled by the spellcheck attribute.
        * editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Mon, 13 Jul 2009 18:34:44 +0000 (18:34 +0000)]
WebCore:

2009-07-13  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Add new configuration flag for redistributable Windows build.
        https://bugs.webkit.org/show_bug.cgi=27087

        * WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to
          Debug_Cairo and Release_Cairo builds.
        * config.h: Check for presence of WIN_CAIRO and select appropriate
          configuration.  Defaults to standard Apple build.

WebKit/win:

2009-07-13  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Add new configuration flag for redistributable Windows build.
        https://bugs.webkit.org/show_bug.cgi=27087

        * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
          Debug_Cairo and Release_Cairo targets.

WebKitLibraries:

2009-07-13  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Add new configuration flag for redistributable Windows build.
        https://bugs.webkit.org/show_bug.cgi=27087

        * win/tools/vsprops/WinCairo.vsprops: Added.  Defines the
          new WIN_CAIRO flag used to drive non-Apple Windows build.

WebKitTools:

2009-07-13  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Add new configuration flag for redistributable Windows build.
        https://bugs.webkit.org/show_bug.cgi=27087

        * DumpRenderTree/config.h: Check for presence of WIN_CAIRO and
          select appropriate configuration. Defaults to standard Apple build.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops
          to Debug_Cairo and Release_Cairo targets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
pkasting@chromium.org [Mon, 13 Jul 2009 18:15:50 +0000 (18:15 +0000)]
WebCore:

2009-07-13  Peter Kasting  <pkasting@google.com>

        https://bugs.webkit.org/show_bug.cgi?id=19562
        Back out previous patch for this bug (too many problems).

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/HTMLButtonElement.idl:
        * html/HTMLFieldSetElement.idl:
        * html/HTMLFormControlElement.cpp:
        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::form):
        * html/HTMLInputElement.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/ValidityState.cpp: Removed.
        * html/ValidityState.h: Removed.
        * html/ValidityState.idl: Removed.

LayoutTests:

2009-07-13  Peter Kasting  <pkasting@google.com>

        https://bugs.webkit.org/show_bug.cgi?id=19562
        Back out previous patch for this bug (too many problems).
        This also re-enables fast/dom/domListEnumeration.html.

        * fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
        * fast/dom/domListEnumeration.html-disabled: Removed.
        * fast/forms/ValidityState-001-expected.txt: Removed.
        * fast/forms/ValidityState-001.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 13 Jul 2009 18:11:29 +0000 (18:11 +0000)]
2009-07-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add HTMLAllCollection to WebCore.gypi.

        https://bugs.webkit.org/show_bug.cgi?id=27223

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 13 Jul 2009 17:08:58 +0000 (17:08 +0000)]
2009-07-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        Correct these delegate methods' declarations by adding parameter names.

        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Jul 2009 16:44:21 +0000 (16:44 +0000)]
2009-07-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Late NEWS file for 1.1.11.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Mon, 13 Jul 2009 16:40:14 +0000 (16:40 +0000)]
WebCore:

2009-07-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
        https://bugs.webkit.org/show_bug.cgi?id=27218

        Test: fast/css/matrix-as-function-crash.html

        * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
        (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

LayoutTests:

2009-07-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Make sure that calling WebKitCSSMatrix as function does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=27218

        * fast/css/matrix-as-function-crash-expected.txt: Added.
        * fast/css/matrix-as-function-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Jul 2009 15:29:20 +0000 (15:29 +0000)]
2009-07-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Changes to the doc control files for 1.1.11.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Jul 2009 15:23:19 +0000 (15:23 +0000)]
2009-07-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Require the correct libsoup version now that
        it's released.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded .pro file missing from r45813
hausmann@webkit.org [Mon, 13 Jul 2009 14:55:22 +0000 (14:55 +0000)]
Added .pro file missing from r45813

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
vestbo@webkit.org [Mon, 13 Jul 2009 14:54:07 +0000 (14:54 +0000)]
2009-07-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Build fix for QtWebKit on Win
        https://bugs.webkit.org/show_bug.cgi?id=27205

        * WebKit.pri: Include the major version number in the QtWebKit
        library file for Win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 14:32:06 +0000 (14:32 +0000)]
2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
        how to re-implement it.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Jul 2009 14:20:38 +0000 (14:20 +0000)]
2009-07-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Holger Freyther.

        Fix unit test to use the correct assumption that the SoupMessage
        will be NULL when WebKitNetworkRequest is created from an URI.

        * tests/testnetworkrequest.c:
        (test_network_request_create_destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 13:15:37 +0000 (13:15 +0000)]
2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Unskip three more fast/js tests that pass with the Qt DRT.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
hausmann@webkit.org [Mon, 13 Jul 2009 13:04:55 +0000 (13:04 +0000)]
WebKitTools:

2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Always run the Qt DRT with the raster graphicssystem on X11, for
        increased stability in the image based tests, in particular canvas.

        * DumpRenderTree/qt/main.cpp:
        (main):

LayoutTests:

2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Removed Qt DRT specific result for canvas-getImageData as we pass this
        test with the raster graphicssystem.

        * platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed make dist build fix.
kov@webkit.org [Mon, 13 Jul 2009 12:29:57 +0000 (12:29 +0000)]
Unreviewed make dist build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>
vestbo@webkit.org [Mon, 13 Jul 2009 12:27:25 +0000 (12:27 +0000)]
2009-07-13  Cédric Luthi  <cedric.luthi@gmail.com>

        Reviewed by Tor Arne Vestbø.

        Fix NPWindow clip rect in PluginViewMac

        The rect should be in window-coordinates. This bug can be observed
        with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/

        * plugins/mac/PluginViewMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 13 Jul 2009 10:55:48 +0000 (10:55 +0000)]
2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Fix crash with plugins when the plugin stream is cancelled.

        Similar to r26667 handle the case where didReceiveResponse on the
        plugin view results in failure to set up the stream and
        setMainDocumentError being called instead. This will set the
        m_pluginView back to 0 and we need check for it before calling
        didReceiveData.

        This was triggered by consecutive execution of
        LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
        followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.:
hausmann@webkit.org [Mon, 13 Jul 2009 10:55:07 +0000 (10:55 +0000)]
.:

2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Add the test netscape plugin for the Qt DRT to the build.

        * WebKit.pro:

WebKitTools:

2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix test netscape plugin usage with the Qt DRT.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage): Enable plugins in the settings.
        * Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build
        directory to make Qt DRT find the test netscape plugin.

LayoutTests:

2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Enable a bunch of plugin layout tests for the Qt DRT.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 13 Jul 2009 10:53:44 +0000 (10:53 +0000)]
2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Make sure to disable the fixed contents size when resetting the page/view
        state between test runs, to avoid side-effects.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid
        QSize to disable the fixed layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
hausmann@webkit.org [Mon, 13 Jul 2009 10:52:55 +0000 (10:52 +0000)]
WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        When creating new windows, don't forget to connect the new
        page's main frame. This ensures that for example the layoutTestController
        is also available there.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::createWindow):

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Removed two more storage tests from the Qt DRT skip list that relied on
        layoutTestController to be accessible in newly opened windows.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
hausmann@webkit.org [Mon, 13 Jul 2009 10:50:53 +0000 (10:50 +0000)]
WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Added support for LayoutTestController.setPrivateBrowsingEnabled.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setPrivateBrowsingEnabled):
        * DumpRenderTree/qt/jsobjects.h:

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Removed three tests from the Qt DRT Skip list that rely on
        LayoutTestController.setPrivateBrowsingEnabled and pass now.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/qt:
hausmann@webkit.org [Mon, 13 Jul 2009 10:49:35 +0000 (10:49 +0000)]
WebKit/qt:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Added QWebDatabase::removeAllDatabases, as a way to delete all
        databases from the offline storage path.

        Used by the Qt DRT.

        * Api/qwebdatabase.cpp:
        (QWebDatabase::removeAllDatabases):
        * Api/qwebdatabase.h:

WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Added support for database callbacks, storage quota setting,
        and clearing of all databases.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::dumpDatabaseQuota):
        * DumpRenderTree/qt/DumpRenderTree.h:
        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::clearAllDatabases):
        * DumpRenderTree/qt/jsobjects.h:
        (LayoutTestController::shouldDumpDatabaseCallbacks):
        (LayoutTestController::dumpDatabaseCallbacks):
        * DumpRenderTree/qt/main.cpp:
        (main):

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Enable a bunch of more storage layout tests for the Qt DRT, now that
        they pass.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
hausmann@webkit.org [Mon, 13 Jul 2009 10:48:14 +0000 (10:48 +0000)]
WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
        the storage layout tests.

        * DumpRenderTree/qt/main.cpp:
        (main):

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Enable some storage layout tests in the Qt DRT, as the pass now.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 13 Jul 2009 10:46:43 +0000 (10:46 +0000)]
2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Fix Qt implementation of WebCore::directoryName to return the absolute
        directory name instead of the base file name.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::directoryName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/qt:
hausmann@webkit.org [Mon, 13 Jul 2009 10:45:21 +0000 (10:45 +0000)]
WebKit/qt:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Added loadStarted() and loadFinished() signals to QWebFrame,
        to allow load tracking of individual frames, as opposed to
        QWebPage's loadStarted/loadFinished signals that are emitted
        whenever _any_ child frame loads/finishes.

        * Api/qwebframe.cpp: Document new signals.
        * Api/qwebframe.h: Add new signals.
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.

WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Make the test output more robust by dumping only when the main
        frame finishes loading, instead of when _any_ frame finishes.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree): Connect to the
        main frame's loadFinished() signal instead of the page's one.

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Removed 20 more frame tests from the Qt skip list as they pass now
        after making sure we only dump after the main frame's loadFinished
        signal.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/qt:
hausmann@webkit.org [Mon, 13 Jul 2009 10:40:45 +0000 (10:40 +0000)]
WebKit/qt:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Add hooks for the GCController JavaScript interface needed by the
        Qt DRT.

        Fixed sort order of includes in qwebframe.cpp.

        * Api/qwebframe.cpp:
        (qt_drt_javaScriptObjectsCount):
        (qt_drt_garbageCollector_collect):
        (qt_drt_garbageCollector_collectOnAlternateThread):

WebKitTools:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Implement the GCController DRT interface in the Qt DRT.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController.
        (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
        * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
        * DumpRenderTree/qt/jsobjects.cpp: Implement GCController.
        (GCController::GCController):
        (GCController::collect):
        (GCController::collectOnAlternateThread):
        (GCController::getJSObjectCount):
        * DumpRenderTree/qt/jsobjects.h: Declare GCController.

LayoutTests:

2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Remove fast/frames/removal-before-attach-crash.html and
        fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
        list, as they pass now with support for the GCController.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 13 Jul 2009 10:34:25 +0000 (10:34 +0000)]
2009-07-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Ariya Hidayat.

        Fix WebCore::Path::isEmpty() for the Qt port to return true
        if there is no element in the path.

        QPainterPath::isEmpty() returns also true if there is one single
        MoveTo element inside, which makes sense but doesn't patch Webcore's
        is-empty definition.

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::isEmpty): Use elementCount() == 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Reinout van Schouwen <reinouts@gnome.org>
jmalonzo@webkit.org [Mon, 13 Jul 2009 10:22:41 +0000 (10:22 +0000)]
2009-07-13  Reinout van Schouwen  <reinouts@gnome.org>

        <https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation

        Rubber-stamped by Jan Alonzo.

        * nl.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 13 Jul 2009 10:11:13 +0000 (10:11 +0000)]
2009-07-13  Jan Michael Alonzo  <jmalonzo@webkit.org>

        <https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
        REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

        Reviewed by Gustavo Noronha.

        Unskip fast/events/frame-programmatic-focus.html

        * platform/gtk/Skipped:

        focus-in and focus-out events only get triggered when there's user
        interaction, hence setFocused(bool) never gets called when
        focusEvent is triggered when running the layout tests. The
        solution seems to be to implement grab-focus too so we can call
        setFocused(bool) when a widget has focus.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_grab_focus):
        (webkit_web_view_focus_in_event):
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascrip...
jmalonzo@webkit.org [Mon, 13 Jul 2009 09:57:52 +0000 (09:57 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT

        Reviewed by Gustavo Noronha and Xan Lopez.

        Unskip tests that now pass due to support for JS windows in Gtk DRT.

        * platform/gtk/Skipped:

        Add API to support opening and closing of JavaScript windows automatically.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::closeWindowSoon):
        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_real_close_web_view):
        (webkit_web_view_class_init):
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):
        (webkit_web_view_set_group_name):
        * webkit/webkitwebview.h:

        Support running of tests that open and close JS windows automatically.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpFramesAsText):
        (dumpBackForwardListForAllWebViews):
        (resetWebViewToConsistentStateBeforeTesting):
        (dump):
        (runTest):
        (webViewClose):
        (createWebView):
        (webViewCreate):
        (main):
        * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::windowCount):
        (LayoutTestController::setPopupBlockingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 09:47:33 +0000 (09:47 +0000)]
2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Oliver Hunt.

        Tweak mouseout-dead-subframe.html to be more robust.

        The test calls notifyDone() and then dumpAsText(). The latter call has no effect
        as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
        of the .html file is detected as text/plain and therefore the text is dumped instead
        of the render tree.

        Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
        pass without relying on the mime type detection.

        That also makes the test pass in the Qt DRT.

        * fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to
        call the former before the latter.
        * platform/qt/Skipped: Removed skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Mon, 13 Jul 2009 09:36:59 +0000 (09:36 +0000)]
2009-07-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Maciej Stachowiak.

        prepare-ChangeLog should decode HTML entities in short description
        https://bugs.webkit.org/show_bug.cgi?id=27122

        Decode the short description by adding a function which decodes HTML
        entities. It can decode &, <, >, ", and ' . They may be sufficient
        as the description seems to be encoded by xml_quote in
        http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Mon, 13 Jul 2009 09:31:16 +0000 (09:31 +0000)]
2009-07-13  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
        https://bugs.webkit.org/show_bug.cgi?id=27127

        There were a number of bugs introduced during the last upstreaming
        effort that broke around 30 layout tests.  This fixes those bugs.
        It also has compile fixes to match the recent cutting apart of
        V8Proxy.

        * bindings/v8/NPV8Object.cpp:
        (freeV8NPObject):
        (npCreateV8ScriptObject):
        (NPN_Invoke):
        (NPN_InvokeDefault):
        (NPN_EvaluateHelper):
        (NPN_SetException):
        (NPN_Construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Mads Ager <ager@chromium.org>
levin@chromium.org [Mon, 13 Jul 2009 09:31:12 +0000 (09:31 +0000)]
2009-07-13  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        Fix memory leak in the V8 binding layer.
        https://bugs.webkit.org/show_bug.cgi?id=27163

        Reinitializing the context is not necessary when clearing the proxy for navigation
        and it will lead us to hold on to an empty context for each frame.

        Test for empty context instead of empty global object handle when
        updating the document for a context.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::clearForNavigation):
        (WebCore::V8Proxy::updateDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 John Gregg <johnnyg@google.com>
levin@chromium.org [Mon, 13 Jul 2009 09:31:06 +0000 (09:31 +0000)]
2009-07-13  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Correct the logic to determine if a V8 callback returns a value.
        https://bugs.webkit.org/show_bug.cgi?id=27155

        * bindings/v8/custom/V8CustomVoidCallback.cpp:
        (WebCore::invokeCallback):
        - Don't crash if result.IsEmpty().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Drew Wilson <atwilson@google.com>
levin@chromium.org [Mon, 13 Jul 2009 08:58:48 +0000 (08:58 +0000)]
2009-07-13  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
        https://bugs.webkit.org/show_bug.cgi?id=26932

.:

        Added ENABLE(SHARED_WORKERS) flag.

       * configure.ac:

JavaScriptCore:

        Added ENABLE(SHARED_WORKERS) flag (off by default).

        * Configurations/FeatureDefines.xcconfig:

WebCore:

        Initial IDL definition and bindings for SharedWorkers.

        * Configurations/FeatureDefines.xcconfig:
        Added new files for SharedWorker support.
        * DerivedSources.make:
        Added new files for SharedWorker support.
        * GNUmakefile.am:
        Added new files for SharedWorker support.
        * WebCore.gypi:
        Added new files for SharedWorker support.
        * WebCore.pro:
        Added new files for SharedWorker support.
        * WebCore.xcodeproj/project.pbxproj:
        Added new files for SharedWorker support.
        * bindings/js/JSAbstractWorkerCustom.cpp: Added.
        (WebCore::JSAbstractWorker::mark):
        Custom mark handler that marks the event listeners.
        (WebCore::JSAbstractWorker::addEventListener):
        (WebCore::JSAbstractWorker::removeEventListener):
        (WebCore::JSAbstractWorker::toJS):
        Custom toJS handler which differentiates between various subclasses.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::sharedWorker):
        SharedWorker constructor (only enabled when SHARED_WORKERS is
        enabled).
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        (WebCore::toEventTarget):
        Added support for converting to/from SharedWorkers.
        * bindings/js/JSSharedWorkerConstructor.cpp: Added.
        (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):
        (WebCore::constructSharedWorker):
        (WebCore::JSSharedWorkerConstructor::getConstructData):
        * bindings/js/JSSharedWorkerConstructor.h: Added.
        (WebCore::JSSharedWorkerConstructor::classInfo):
        * bindings/js/JSSharedWorkerCustom.cpp: Added.
        (WebCore::JSSharedWorker::mark):
        Custom mark function that marks the internal MessagePort.
        * bindings/v8/DOMObjectsInclude.h:
        Updated to include new header files.
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added.
        (WebCore::getEventListener):
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        V8 handlers for add/removeEventListener().
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8SharedWorkerCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        Custom constructor for SharedWorker.
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toSharedWorker):
        * dom/EventTarget.h:
        * page/DOMWindow.idl:
        * workers/AbstractWorker.cpp: Added.
        (WebCore::AbstractWorker::AbstractWorker):
        Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp.
        This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing.
        (WebCore::AbstractWorker::~AbstractWorker):
        (WebCore::AbstractWorker::addEventListener):
        (WebCore::AbstractWorker::removeEventListener):
        (WebCore::AbstractWorker::dispatchEvent):
        (WebCore::AbstractWorker::dispatchLoadErrorEvent):
        (WebCore::AbstractWorker::dispatchScriptErrorEvent):
        * workers/AbstractWorker.h: Added.
        Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker.
        (WebCore::AbstractWorker::scriptExecutionContext):
        (WebCore::AbstractWorker::setOnerror):
        (WebCore::AbstractWorker::onerror):
        (WebCore::AbstractWorker::eventListeners):
        (WebCore::AbstractWorker::refEventTarget):
        (WebCore::AbstractWorker::derefEventTarget):
        * workers/AbstractWorker.idl: Added.
        * workers/SharedWorker.cpp: Added.
        (WebCore::SharedWorker::SharedWorker):
        (WebCore::SharedWorker::~SharedWorker):
        * workers/SharedWorker.h: Added.
        (WebCore::SharedWorker::create):
        (WebCore::SharedWorker::port):
        (WebCore::SharedWorker::toSharedWorker):
        * workers/SharedWorker.idl: Added.

WebKit/mac:

        Added ENABLE(SHARED_WORKERS) flag (disabled by default).

        * Configurations/FeatureDefines.xcconfig:

WebKitTools:

        Added support for --shared-workers (turned off by default)

        * Scripts/build-webkit:

LayoutTests:

        Unit tests for new SharedWorker APIs (disabled by default).

        * fast/workers/shared-worker-constructor-expected.txt: Added.
        * fast/workers/shared-worker-constructor.html-disabled: Added.
        * fast/workers/shared-worker-event-listener-expected.txt: Added.
        * fast/workers/shared-worker-event-listener.html-disabled: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 08:32:38 +0000 (08:32 +0000)]
2009-07-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Cleanup - Remove prf install target
        https://bugs.webkit.org/show_bug.cgi?id=27191

        qtwebkit.prf has been removed; this cleans up the related
        install target as well.

        * WebCore.pro: Remove prf install target

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-07 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 08:30:41 +0000 (08:30 +0000)]
2009-07-07  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Maciej Stachoviak.

        https://bugs.webkit.org/show_bug.cgi?id=27058

        Removed superfluous parenthesis around single expression.
        Compilers on Symbian platform fail to properly parse and compile.

        * JavaScriptCore/wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 08:24:08 +0000 (08:24 +0000)]
2009-07-13  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Maciej Stachoviak.

        https://bugs.webkit.org/show_bug.cgi?id=27054

        Renamed Translator to HashTranslator

        Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
        mismatch between template declaration and definition
        (HashTranslator / Translator)

        * wtf/HashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-13 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Mon, 13 Jul 2009 08:20:08 +0000 (08:20 +0000)]
2009-07-13  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=27053

        Ambiguity in LabelScope initialization

        Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
        type of "0" unambiguously. Set expression explicitly to
        PassRefPtr<Label>::PassRefPtr()

        * bytecompiler/BytecodeGenerator.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/gtk:
bfulgham@webkit.org [Mon, 13 Jul 2009 06:12:09 +0000 (06:12 +0000)]
WebKit/gtk:

2009-07-12  Brent Fulgham  <bfulgham@gmail.com>

        Speculative build fix after http://trac.webkit.org/changeset/45786.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::addMessageToConsole):
        * WebCoreSupport/ChromeClientGtk.h:

WebKit/qt:

2009-07-12  Brent Fulgham  <bfulgham@gmail.com>

        Speculative build fix after http://trac.webkit.org/changeset/45786.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::addMessageToConsole):
        * WebCoreSupport/ChromeClientQt.h:

WebKit/wx:

2009-07-12  Brent Fulgham  <bfulgham@gmail.com>

        Speculative build fix after http://trac.webkit.org/changeset/45786.

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::addMessageToConsole):
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-12 Brent Fulgham <bfulgham@gmail.com>
bfulgham@webkit.org [Mon, 13 Jul 2009 06:02:48 +0000 (06:02 +0000)]
2009-07-12  Brent Fulgham  <bfulgham@gmail.com>

        Speculative Windows build fix after http://trac.webkit.org/changeset/45786.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::addMessageToConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix executable bit. We should fix bugzilla-tool to understand executable bits.
abarth@webkit.org [Mon, 13 Jul 2009 05:38:09 +0000 (05:38 +0000)]
Fix executable bit.  We should fix bugzilla-tool to understand executable bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jul 2009 05:36:15 +0000 (05:36 +0000)]
2009-07-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        Facebook Chat is broken due to XSS auditor
        https://bugs.webkit.org/show_bug.cgi?id=27179

        Instead of just using the script's URL as to detect an XSS attack, we
        now use a bit of context before the URL.  In particular, we use the
        bytes from the beginning of the attribute name to the end of the
        attribute value.  In virtually all injection attacks, the attacker
        would need to supply the attribute name as well as the attribute value.
        However, in the Facebook false positive, the attribute name is not
        present in the URL.

        Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html
               http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
               http/tests/security/xssAuditor/script-tag-with-source-no-quote.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * html/HTMLTokenizer.h:
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        * page/XSSAuditor.h:

2009-07-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        Facebook Chat is broken due to XSS auditor
        https://bugs.webkit.org/show_bug.cgi?id=27179

        Add some more test coverage to our handling of script tags with src
        attributes.  Also, ensure that we don't raise the alarm when a URL
        parameter is injected directly into the attribute value.

        * http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
        * http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
        * http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
        * http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
        * http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Mon, 13 Jul 2009 05:08:46 +0000 (05:08 +0000)]
WebCore:

2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Refactor ConsoleMessage to add MessageType attribute.
        https://bugs.webkit.org/show_bug.cgi?id=20625

        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::printErrorMessage):
        * dom/Document.cpp:
        (WebCore::Document::reportException):
        (WebCore::Document::addMessage):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reportErrorToConsole):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::startGroup):
        (WebCore::InspectorController::endGroup):
        (WebCore::InspectorController::addProfileFinishedMessageToConsole):
        (WebCore::InspectorController::addStartProfilingMessageToConsole):
        (WebCore::InspectorController::count):
        * inspector/InspectorController.h:
        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.addMessage):
        (WebInspector.ConsoleMessage): Added type property.
        (WebInspector.ConsoleMessage.prototype.toMessageElement):
        (WebInspector.ConsoleMessage.prototype.toString):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        (WebInspector.ConsoleCommandResult):
        (WebInspector.ConsoleGroup.prototype.addMessage):
        (WebInspector.ConsoleGroup.prototype._titleClicked):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._addTip):
        (WebInspector.Resource.prototype._checkWarning):
        * inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
        * inspector/front-end/inspector.js:
        (WebInspector.addMessageToConsole):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::printAccessDeniedMessage):
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::addMessageToConsole):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::reportLocalLoadFailed):
        (WebCore::FrameLoader::shouldAllowNavigation):
        * page/ChromeClient.h:
        * page/Console.cpp:
        (WebCore::printMessageSourceAndLevelPrefix):
        (WebCore::Console::addMessage):
        (WebCore::Console::error):
        (WebCore::Console::log):
        (WebCore::Console::dir):
        (WebCore::Console::trace):
        (WebCore::Console::assertCondition):
        (WebCore::Console::timeEnd):
        (WebCore::Console::warn):
        * page/Console.h: Added MessageType enum.
        (WebCore::):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        (WebCore::XSSAuditor::canLoadObject):
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::reportWarning):
        (WebCore::SVGDocumentExtensions::reportError):
        * wml/WMLErrorHandling.cpp:
        (WebCore::reportWMLError):
        * workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument.
        (WebCore::GenericWorkerTask8::create):
        (WebCore::GenericWorkerTask8::GenericWorkerTask8):
        (WebCore::GenericWorkerTask8::performTask):
        (WebCore::createCallbackTask):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::addMessage):
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::postConsoleMessageTask):
        (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerObjectProxy.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::reportUnsafeUsage):
        (WebCore::XMLHttpRequest::didFinishLoading):
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::parseErrorFunc):

WebKit/mac:

2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Refactor ConsoleMessage to add MessageType attribute.
        https://bugs.webkit.org/show_bug.cgi?id=20625

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::addMessageToConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-12 Nate Chapin <japhet@chromium.org>
bfulgham@webkit.org [Mon, 13 Jul 2009 04:07:52 +0000 (04:07 +0000)]
2009-07-12  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.

        https://bugs.webkit.org/show_bug.cgi?id=27132

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * dom/HTMLAllCollection.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-12 Joseph Pecoraro <joepeck02@gmail.com>
bfulgham@webkit.org [Mon, 13 Jul 2009 03:55:23 +0000 (03:55 +0000)]
2009-07-12  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Maciej Stachowiak.

        Inspector: Duplicate Computation in Autocompletion
        https://bugs.webkit.org/show_bug.cgi?id=26778

        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype._completionsReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 13 Jul 2009 01:43:29 +0000 (01:43 +0000)]
2009-07-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27197
        QuickTime supports data: urls, add a layout test.

        * media/audio-data-url-expected.txt: Added.
        * media/audio-data-url.html: Added.
            New test.

        * platform/gtk/Skipped:
            Skip the new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45783 268f45cc-cd09-0410-ab3c-d52691b4dbfc