WebKit-https.git
8 years ago[CSSRegions]-webkit-flow-into initial value should be none instead of auto
mihnea@adobe.com [Mon, 27 Feb 2012 20:36:46 +0000 (20:36 +0000)]
[CSSRegions]-webkit-flow-into initial value should be none instead of auto
https://bugs.webkit.org/show_bug.cgi?id=79670

Reviewed by Simon Fraser.

Source/WebCore:

No new tests, modified expectations for existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlowThread):
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/regions/css-regions-disabled-expected.txt:
* fast/regions/script-tests/css-regions-disabled.js:
* fast/regions/script-tests/webkit-flow-parsing.js:
* fast/regions/webkit-flow-parsing-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoimplement display: -webkit-inline-flexbox
ojan@chromium.org [Mon, 27 Feb 2012 20:33:27 +0000 (20:33 +0000)]
implement display: -webkit-inline-flexbox
https://bugs.webkit.org/show_bug.cgi?id=77772

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/inline-flexbox-expected.html
       css3/flexbox/inline-flexbox.html

* rendering/style/RenderStyle.h:
-Add INLINE_FLEXBOX to the list of replaced display types.
-Restructure the isDisplayInline methods to avoid code duplication.

LayoutTests:

* css3/flexbox/inline-flexbox-expected.html: Added.
* css3/flexbox/inline-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Dragging a selection handle outside of the content bounding box does...
commit-queue@webkit.org [Mon, 27 Feb 2012 20:03:09 +0000 (20:03 +0000)]
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not apply padding to a
direction that would cause the selection to shrink when performing the
handle direction detection.

Patch by Ed Baker <edbaker@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::clamp):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
* WebKitSupport/SelectionHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAbsolute positioned elements with Inline Relative Positioned Container are not layout...
commit-queue@webkit.org [Mon, 27 Feb 2012 19:48:09 +0000 (19:48 +0000)]
Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-27
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/positioned-in-relative-position-inline-crash.html

Patch originally by Robin Cao.

This is a regression. r104183 changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous block itself. We should
change markContainingBlocksForLayout() to match the change in containingBlock().

* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Test case originally by Robin Cao. This exercises the crashing
condition in bug 78713.

* fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
* fast/css/positioned-in-relative-position-inline-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move record formatting into the timeline presentation model.
pfeldman@chromium.org [Mon, 27 Feb 2012 19:14:28 +0000 (19:14 +0000)]
Web Inspector: move record formatting into the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79684

Source/WebCore:

Drive-by: fix for stop recording in reset; cpu time restored.
Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.reset):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update.updateBoundaries):
(WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._rootRecord):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.createFormattedRecord):
(WebInspector.TimelinePresentationModel.prototype._createRootRecord):
(WebInspector.TimelinePresentationModel.prototype.rootRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype._resetWindow):
(WebInspector.TimelinePresentationModel.prototype._addCategory):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.get lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get cpuTime):
(WebInspector.TimelinePresentationModel.Record.prototype.isLong):
(WebInspector.TimelinePresentationModel.Record.prototype.get children):
(WebInspector.TimelinePresentationModel.Record.prototype.containsTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generateAggregatedInfo):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyScriptLocation):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):
(WebInspector.TimelinePresentationModel.Record.prototype.get aggregatedStats):
(WebInspector.TimelinePresentationModel.PopupContentHelper):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._createCell):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendElementRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/timelinePanel.css:
(.timeline-graph-bar.cpu):

LayoutTests:

Reviewed by Vsevolod Vlasov.

* inspector/timeline/timeline-receive-response-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegExp lastIndex should behave as a regular property
barraclough@apple.com [Mon, 27 Feb 2012 18:29:04 +0000 (18:29 +0000)]
RegExp lastIndex should behave as a regular property
https://bugs.webkit.org/show_bug.cgi?id=79446

Reviewed by Sam Weinig.

lastIndex should be a regular data descriptor, with the attributes configurable:false,
enumerable:false, writable:true. As such, it should be possible to reconfigure writable
as false. If the lastIndex property is reconfigured to be read-only, we should respect
this correctly.

Source/JavaScriptCore:

* runtime/CommonIdentifiers.h:
    - Removed some unused identifiers, added lastIndex.
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyDescriptor):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::deleteProperty):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyNames):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getPropertyNames):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::reject):
    - helper function for defineOwnProperty.
(JSC::RegExpObject::defineOwnProperty):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::put):
    - lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::match):
    - Pass setLastIndex an ExecState, so it can throw if read-only.
* runtime/RegExpObject.h:
(JSC::RegExpObject::setLastIndex):
    - Pass setLastIndex an ExecState, so it can throw if read-only.
(RegExpObjectData):
    - Added lastIndexIsWritable.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
    - Pass setLastIndex an ExecState, so it can throw if read-only.

LayoutTests:

* fast/regex/lastIndex-expected.txt: Added.
* fast/regex/lastIndex.html: Added.
* fast/regex/script-tests/lastIndex.js: Added.
    - Added test cases for correct handling of lastIndex.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement support for op_negate and op_bitnot in the DFG JIT
barraclough@apple.com [Mon, 27 Feb 2012 18:26:23 +0000 (18:26 +0000)]
Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Sam Weinig.

Remove op_bitnop - this is redundant, ~x === x^-1.
This is a fractional (<1%) progression.

Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X).
Remove CanReuse from the result type - this was unused.
Remove op_bitnot.

* assembler/MacroAssemblerARM.h:
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::xor32):
* assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::xor32):
* assembler/MacroAssemblerMIPS.h:
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::xor32):
* assembler/MacroAssemblerSH4.h:
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::xor32):
* assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::xor32):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/NodesCodegen.cpp:
(JSC):
(JSC::BitwiseNotNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JIT):
* jit/JITArithmetic32_64.cpp:
(JSC):
* jit/JITOpcodes.cpp:
(JSC):
* jit/JITStubs.cpp:
(JSC):
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
(LLInt):
* llint/LLIntSlowPaths.h:
(LLInt):
* llint/LowLevelInterpreter32_64.asm:
* parser/NodeConstructors.h:
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::SubNode::SubNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
* parser/Nodes.h:
(BitwiseNotNode):
(JSC::BitwiseNotNode::expr):
(JSC):
* parser/ResultType.h:
(ResultType):
(JSC::ResultType::numberTypeIsInt32):
(JSC::ResultType::stringOrNumberType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forBitOp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Scripts navigator overlay should not consume mouse actions.
vsevik@chromium.org [Mon, 27 Feb 2012 18:15:43 +0000 (18:15 +0000)]
Web Inspector: Scripts navigator overlay should not consume mouse actions.
https://bugs.webkit.org/show_bug.cgi?id=79674

Reviewed by Pavel Feldman.

* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.registerShortcut):
(WebInspector.Panel.prototype.unregisterShortcut):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
* inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype._containingElementFocused):
(WebInspector.SidebarOverlay.prototype.position):
(WebInspector.SidebarOverlay.prototype.hide):
(WebInspector.SidebarOverlay.prototype._setWidth):
* inspector/front-end/dialog.css:
(.go-to-line-dialog button:active):
* inspector/front-end/scriptsPanel.css:
(#scripts-editor-view .sidebar-overlay):
* inspector/front-end/splitView.css:
(.split-view-resizer):
(.sidebar-overlay):
(.sidebar-overlay-resizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
philn@webkit.org [Mon, 27 Feb 2012 18:04:18 +0000 (18:04 +0000)]
[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=77089

Reviewed by Martin Robinson.

Basic port to GStreamer 0.11 APIs. This patch excludes the video
painting changes and the GStreamerGWorld changes which are handled
in two other patches (bugs 77087 and 77088).

* GNUmakefile.list.am: Add GStreamerVersioning files to the build.
* Source/WebCore/PlatformEfl.cmake: Ditto.
* Source/WebCore/Target.pri: Ditto.
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
* platform/graphics/gstreamer/GStreamerVersioning.cpp: Added.
(webkit_gst_object_ref_sink):
(webkit_gst_element_get_pad_caps):
* platform/graphics/gstreamer/GStreamerVersioning.h: Added.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links...
mitz@apple.com [Mon, 27 Feb 2012 18:00:23 +0000 (18:00 +0000)]
Source/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm

This was caused by not mapping the mouse event coordinates from window coordinates to
document coordinates.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame
coordinates when performing the hit test.
(WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused
frame coordinates when perfomring the hit test.
(WebKit::WebPage::acceptsFirstMouse): Ditto.

Tools: Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
(TestWebKitAPI::AcceptsFirstMouse::url):
(TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
(TestWebKitAPI::AcceptsFirstMouse::runTest):
(TestWebKitAPI::TEST_F):
* TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop recomputing SVG path data twice during layout
commit-queue@webkit.org [Mon, 27 Feb 2012 17:57:55 +0000 (17:57 +0000)]
Stop recomputing SVG path data twice during layout
https://bugs.webkit.org/show_bug.cgi?id=79672

Patch by Philip Rogers <pdr@google.com> on 2012-02-27
Reviewed by Nikolas Zimmermann.

* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WKInspector API to know when the Web Inspector is the frontmost window.
timothy@apple.com [Mon, 27 Feb 2012 17:51:06 +0000 (17:51 +0000)]
Add WKInspector API to know when the Web Inspector is the frontmost window.

https://webkit.org/b/79649

Reviewed by John Sullivan.

Source/WebCore: Updated for WebKit2 string changes.

* English.lproj/Localizable.strings: Updated.

Source/WebKit2: Also makes the Safari Develop menu items work when the Web Inspector is frontmost.

* UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsFront): Added. Call WebInspectorProxy::isFront.
* UIProcess/API/C/WKInspector.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::isFront): Added. Call platformIsFront.
* UIProcess/WebInspectorProxy.h:
* UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter showWebInspector:]): Added. Makes the Develop menu items in Safari work when
the Web Inspector window is front.
(-[WKWebInspectorProxyObjCAdapter showErrorConsole:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter showResources:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter viewSource:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleDebuggingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleProfilingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter validateUserInterfaceItem:]): Added. Update the menu item titles.
(WebKit::WebInspectorProxy::platformIsFront): Added. Return if visible and the window is main.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
enne@google.com [Mon, 27 Feb 2012 17:42:51 +0000 (17:42 +0000)]
[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
https://bugs.webkit.org/show_bug.cgi?id=79679

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Ctrl+K should not zoom in
pfeldman@chromium.org [Mon, 27 Feb 2012 17:34:37 +0000 (17:34 +0000)]
Web Inspector: Ctrl+K should not zoom in
https://bugs.webkit.org/show_bug.cgi?id=79676

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoError check regexp min quantifier
msaboff@apple.com [Mon, 27 Feb 2012 17:22:29 +0000 (17:22 +0000)]
Error check regexp min quantifier
https://bugs.webkit.org/show_bug.cgi?id=70648

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added checking for min or only quantifier being UINT_MAX.
When encountered this becomes a SyntaxError during parsing.

* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parse):
(Parser):

LayoutTests:

New test added to check for newly generated SyntaxError.

* fast/regex/overflow-expected.txt:
* fast/regex/script-tests/overflow.js:
(quantifyMaxInt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract TimelineModel and TimelinePresentationModel into their own...
pfeldman@chromium.org [Mon, 27 Feb 2012 16:58:09 +0000 (16:58 +0000)]
Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/TimelineAgent.js: Removed.
* inspector/front-end/TimelineModel.js: Added.
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadFromFile.onError):
(WebInspector.TimelineModel.prototype._saveToFile):
(WebInspector.TimelineModel.prototype._reset):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/TimelinePresentationModel.js: Added.
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/timeline/timeline-enum-stability.html:
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-paint.html:
* inspector/timeline/timeline-script-tag-1.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for building with GTK+ 2.x.
kov@webkit.org [Mon, 27 Feb 2012 16:54:29 +0000 (16:54 +0000)]
Build fix for building with GTK+ 2.x.

Patch by Vincent Untz  <vuntz@gnome.org>> and Gustavo Noronha Silva  <gns@gnome.org> on 2012-02-27

* tests/testwebview.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration...
apavlov@chromium.org [Mon, 27 Feb 2012 16:36:53 +0000 (16:36 +0000)]
Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
https://bugs.webkit.org/show_bug.cgi?id=79662

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._applyUserInput):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

* inspector/styles/styles-add-blank-property-expected.txt:
* inspector/styles/styles-add-blank-property.html:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-history.html:
* inspector/styles/undo-add-property-expected.txt:
* inspector/styles/undo-add-property.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed fix for lint error after r108992.
loislo@chromium.org [Mon, 27 Feb 2012 15:49:04 +0000 (15:49 +0000)]
Unreviewed fix for lint error after r108992.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experime...
pfeldman@chromium.org [Mon, 27 Feb 2012 15:22:31 +0000 (15:22 +0000)]
Source/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

* dom/ShadowTree.cpp:
(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore):
(WebCore::InspectorDOMAgent::willPopShadowRoot):
* inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didPushShadowRootImpl):
(WebCore):
(WebCore::InspectorInstrumentation::willPopShadowRootImpl):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
* inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::addInspectedNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.isInShadowTree):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._shadowRootPopped):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.shadowRootPushed):
(WebInspector.DOMDispatcher.prototype.shadowRootPopped):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/MemoryStatistics.js:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/inspector.css:
(.webkit-html-tag.shadow, .webkit-html-fragment.shadow):

LayoutTests: [Shadow]: Expose one ShadowRoot in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

* inspector/console/console-dirxml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: drop protocol-level tests
pfeldman@chromium.org [Mon, 27 Feb 2012 15:13:12 +0000 (15:13 +0000)]
Web Inspector: drop protocol-level tests
https://bugs.webkit.org/show_bug.cgi?id=79671

Reviewed by Vsevolod Vlasov.

* inspector/protocol/console-agent-expected.txt: Removed.
* inspector/protocol/console-agent.html: Removed.
* inspector/protocol/runtime-agent-expected.txt: Removed.
* inspector/protocol/runtime-agent.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
commit-queue@webkit.org [Mon, 27 Feb 2012 15:07:23 +0000 (15:07 +0000)]
[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
https://bugs.webkit.org/show_bug.cgi?id=79031

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-27
Reviewed by Zoltan Herczeg.

- Get the pixel data when the cairo surface is created.
- evas_object_image_data_get increases the reference count and returns the image buffer pointer.
evas_object_image_data_set decreases the reference count and when the ref count become zero,
the function releases the cached image inside evas engine.
We should make a pair between evas_object_image_data_set/get to return evas resource.

* ewk/ewk_tiled_backing_store.h:
(_Ewk_Tile):
* ewk/ewk_tiled_model.cpp:
(tile_account):
(ewk_tile_new):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [refactoring] remove dependencies from TimelinePanel from most of...
caseq@chromium.org [Mon, 27 Feb 2012 15:05:01 +0000 (15:05 +0000)]
Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
https://bugs.webkit.org/show_bug.cgi?id=79665

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: reveal corresponding timeline record when user clicks on memory graph
yurys@chromium.org [Mon, 27 Feb 2012 14:56:52 +0000 (14:56 +0000)]
Web Inspector: reveal corresponding timeline record when user clicks on memory graph
https://bugs.webkit.org/show_bug.cgi?id=79669

When user clicks on DOM counter graph corresponding timeline record is
revealed in timelime grid and all its ancestors are expanded.

Reviewed by Pavel Feldman.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onClick):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.HeapGraph.prototype._clear):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.forAllRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed single line fix for r108983.
loislo@chromium.org [Mon, 27 Feb 2012 14:43:34 +0000 (14:43 +0000)]
Unreviewed single line fix for r108983.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: repaint counter graphs when timeline splitter moves
yurys@chromium.org [Mon, 27 Feb 2012 13:47:26 +0000 (13:47 +0000)]
Web Inspector: repaint counter graphs when timeline splitter moves
https://bugs.webkit.org/show_bug.cgi?id=79644

Immediately refresh timeline panel on splitter move.

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._splitterDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Skip one more crashing test.
ossy@webkit.org [Mon, 27 Feb 2012 13:14:35 +0000 (13:14 +0000)]
[Qt][WK2] Skip one more crashing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 27 Feb 2012 12:28:43 +0000 (12:28 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.am: Add missing files.
* GNUmakefile.list.am: Ditto.

Tools:

* GNUmakefile.am: Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Build fix after r108709.
paroga@webkit.org [Mon, 27 Feb 2012 12:04:38 +0000 (12:04 +0000)]
[CMake] Build fix after r108709.

* CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [chromium] Profiles - Tooltip with object/property types stays on...
loislo@chromium.org [Mon, 27 Feb 2012 11:56:14 +0000 (11:56 +0000)]
Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
https://bugs.webkit.org/show_bug.cgi?id=79654

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove page/PageSupplement.h from WebCore's Target.pri
vestbo@webkit.org [Mon, 27 Feb 2012 11:38:34 +0000 (11:38 +0000)]
[Qt] Remove page/PageSupplement.h from WebCore's Target.pri

The file itself was removed in r108958.

Reviewed by Kenneth Rohde Christiansen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
vestbo@webkit.org [Mon, 27 Feb 2012 11:30:29 +0000 (11:30 +0000)]
[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder

Reviewed by Kenneth Rohde Christiansen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Removing <ul>, <li> inside shadow DOM triggers assertion in updateLis...
morrita@google.com [Mon, 27 Feb 2012 11:13:44 +0000 (11:13 +0000)]
Source/WebCore: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=79630

Reviewed by Ryosuke Niwa.

This problem was caused by the inconsistent detach order of DOM tree where
Element::detach() called ContainerNode::detach() before shadow tree is detached.
This resulted the renderer of the element being destroyed even if its children,
each of which came from an element in the shadow tree, are alive.
In principle, child renderers should be destroyed before its parent.

This change aligns the detach order with the attach order. The shadow tree is
now deatched before parent's ContainerNode::detach() is called.

Test: fast/dom/shadow/shadow-ul-li.html

* dom/Element.cpp:
(WebCore::Element::detach):

LayoutTests: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=72440

Reviewed by Ryosuke Niwa.

* fast/dom/shadow/shadow-ul-li-expected.txt: Added.
* fast/dom/shadow/shadow-ul-li.html: Added.
* fast/dom/shadow/shadow-ul-li.html:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
ossy@webkit.org [Mon, 27 Feb 2012 11:05:12 +0000 (11:05 +0000)]
Unreviewed gardening.

* platform/qt-5.0-wk1/Skipped: Skip a new timeouting test.
* platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test.
* platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update.
bashi@chromium.org [Mon, 27 Feb 2012 10:42:50 +0000 (10:42 +0000)]
[Chromium] Unreviewed test expectations update.

Following tests are flaky:
- compositing/reflections/remove-add-reflection.html
- compositing/reflections/nested-reflection-transition.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes.
ossy@webkit.org [Mon, 27 Feb 2012 10:27:46 +0000 (10:27 +0000)]
[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoColor input type should be clickable through keyboard
keishi@webkit.org [Mon, 27 Feb 2012 10:23:24 +0000 (10:23 +0000)]
Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629

Reviewed by Kent Tamura.

Introduced BaseClickableWithKeyInputType that represents an input type
that can be clicked by pressing space/return keys.
ColorInputType, FileInputType directly inherit it because it doesn't
want the other methods(like appendFormData) in BaseButtonInputType.

* CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
* GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
* Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
* html/BaseButtonInputType.cpp:
* html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
(BaseButtonInputType):
* html/BaseCheckableInputType.cpp: Changed comment.
* html/BaseClickableWithKeyInputType.cpp:
(WebCore):
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::accessKeyAction): Moved from BaseButtonInputType
* html/BaseClickableWithKeyInputType.h:
(WebCore):
(BaseClickableWithKeyInputType): Input type that can be clicked by pressing space/return keys.
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
* html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType): Inherits BaseClickableWithKeyInputType now.
* html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType):
* html/FileInputType.h:
(FileInputType): Inherits BaseClickableWithKeyInputType now.
* html/RangeInputType.cpp: Changed comment.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing include to ColorInputType.cpp
keishi@webkit.org [Mon, 27 Feb 2012 10:21:06 +0000 (10:21 +0000)]
Add missing include to ColorInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=79632

Reviewed by Kent Tamura.

* html/ColorInputType.cpp: Include ShadowTree.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a ChromiumGpuAndroid port.
commit-queue@webkit.org [Mon, 27 Feb 2012 10:06:06 +0000 (10:06 +0000)]
Add a ChromiumGpuAndroid port.
https://bugs.webkit.org/show_bug.cgi?id=79628

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

Android does have a gpu port, so revert r107697.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(ChromiumGpuAndroidPort):
(ChromiumGpuAndroidPort.__init__):
(ChromiumGpuAndroidPort.baseline_search_path):
(ChromiumGpuAndroidPort.default_child_processes):
(ChromiumGpuAndroidPort.tests):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update.
bashi@chromium.org [Mon, 27 Feb 2012 10:01:36 +0000 (10:01 +0000)]
[Chromium] Unreviewed test expectations update.

Following tests are flaky:
- compositing/reflections/reflection-ordering.html
- compositing/reflections/reflection-positioning.html
- compositing/reflections/nested-reflection-transformed.html
- compositing/reflections/nested-reflection-transformed2.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse built-in bind in ExtensionAPI.js
caseq@chromium.org [Mon, 27 Feb 2012 09:44:02 +0000 (09:44 +0000)]
Use built-in bind in ExtensionAPI.js

Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
https://bugs.webkit.org/show_bug.cgi?id=79570

Reviewed by Pavel Feldman.

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(injectedExtensionAPI):
(injectedExtensionAPI.Panels.prototype.create):
(injectedExtensionAPI.AuditResultImpl):
(injectedExtensionAPI.ExtensionServerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: get rid of RawSourceCode.sourceMapping getter.
podivilov@chromium.org [Mon, 27 Feb 2012 09:27:18 +0000 (09:27 +0000)]
Web Inspector: get rid of RawSourceCode.sourceMapping getter.
https://bugs.webkit.org/show_bug.cgi?id=79461

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.get location):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._restoreExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._updateCallFrame):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/callstack-placards-discarded-expected.txt:
* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]Implement NamedFlow::getRegionsByContentNode
mihnea@adobe.com [Mon, 27 Feb 2012 09:21:51 +0000 (09:21 +0000)]
[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html
       fast/regions/get-regions-by-content-node-horiz-tb.html
       fast/regions/get-regions-by-content-node-vert-lr.html
       fast/regions/get-regions-by-content-node-vert-rl.html
       fast/regions/get-regions-by-content-node.html
       fast/regions/get-regions-by-content-node2.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Node.cpp:
(WebCore::Node::removeCachedRegionNodeList):
(WebCore):
(WebCore::Node::getRegionsByContentNode):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
* dom/Node.h:
(WebCore):
(Node):
* dom/NodeRareData.h:
(NodeListsNodeData):
* dom/RegionNodeList.cpp:
(WebCore):
(WebCore::RegionNodeList::RegionNodeList):
(WebCore::RegionNodeList::~RegionNodeList):
(WebCore::RegionNodeList::nodeMatches):
* dom/RegionNodeList.h:
(WebCore):
(RegionNodeList):
(WebCore::RegionNodeList::create):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::flowThread):

LayoutTests:

* fast/regions/get-regions-by-content-node-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
* fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
* fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
* fast/regions/get-regions-by-content-node-vert-lr.html: Added.
* fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
* fast/regions/get-regions-by-content-node-vert-rl.html: Added.
* fast/regions/get-regions-by-content-node.html: Added.
* fast/regions/get-regions-by-content-node2-expected.txt: Added.
* fast/regions/get-regions-by-content-node2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectaion update.
bashi@chromium.org [Mon, 27 Feb 2012 09:16:40 +0000 (09:16 +0000)]
[Chromium] Unreviewed test expectaion update.

* platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update.
bashi@chromium.org [Mon, 27 Feb 2012 09:08:25 +0000 (09:08 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79642

Following tests time out:
- accessibility/aria-describedby-on-input.html
- fast/loader/subresource-willSendRequest-null.html
- http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
- media/video-playbackrate.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: counter graphs should resize after console showing
yurys@chromium.org [Mon, 27 Feb 2012 09:00:40 +0000 (09:00 +0000)]
Web Inspector: counter graphs should resize after console showing
https://bugs.webkit.org/show_bug.cgi?id=79640

Invoke Panel.doResize after showing drawer.

Reviewed by Pavel Feldman.

* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Close TabbedPanes on middle click of tab handle
pfeldman@chromium.org [Mon, 27 Feb 2012 08:51:14 +0000 (08:51 +0000)]
Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518

Patch by Dan Beam <dbeam@chromium.org> on 2012-02-27
Reviewed by Pavel Feldman.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: crash in fake workers
yurys@chromium.org [Mon, 27 Feb 2012 08:42:23 +0000 (08:42 +0000)]
Web Inspector: crash in fake workers
https://bugs.webkit.org/show_bug.cgi?id=79637

Notify front-end about worker creation/destruction synchronously instead of
posting a task.

Reviewed by Pavel Feldman.

* inspector/InspectorAgent.cpp:
(WebCore):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
* inspector/InspectorAgent.h:
(InspectorAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip the following crashing svg test.
ossy@webkit.org [Mon, 27 Feb 2012 08:40:13 +0000 (08:40 +0000)]
[Qt] Unreviewed gardening, skip the following crashing svg test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream accelerated compositing helper class
leo.yang@torchmobile.com.cn [Mon, 27 Feb 2012 08:27:54 +0000 (08:27 +0000)]
[BlackBerry] Upstream accelerated compositing helper class
https://bugs.webkit.org/show_bug.cgi?id=78448

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* WebKitSupport/FrameLayers.cpp: Added.
* WebKitSupport/FrameLayers.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing and crashing tests to paint the bots...
ossy@webkit.org [Mon, 27 Feb 2012 07:50:54 +0000 (07:50 +0000)]
[Qt] Unreviewed gardening, skip new failing and crashing tests to paint the bots green.

* platform/qt-5.0/Skipped:
* platform/qt-mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add InjectedBundleEfl.cpp
commit-queue@webkit.org [Mon, 27 Feb 2012 07:47:48 +0000 (07:47 +0000)]
[EFL][WK2] Add InjectedBundleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75463

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-26
Reviewed by Andreas Kling.

Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().

* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::load):
(WebKit::InjectedBundle::activateMacFontAscentHack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
abarth@webkit.org [Mon, 27 Feb 2012 06:54:04 +0000 (06:54 +0000)]
Unreviewed.

Fix some warnings in the build from referencing the non-existent
websockets directory.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename ShadowRootList to ShadowTree.
shinyak@chromium.org [Mon, 27 Feb 2012 06:50:19 +0000 (06:50 +0000)]
Rename ShadowRootList to ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79342

Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

This patch renames ShadowRootList ot ShadowTree.

No new tests, no change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Element.cpp:
(WebCore::Element::willRemove):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadowTree):
(WebCore::Element::setShadowRoot):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::removeShadowRoot):
(WebCore::Element::childrenChanged):
* dom/Element.h:
(WebCore):
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
* dom/Node.cpp:
(WebCore::oldestShadowRoot):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(WebCore):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::tree):
(WebCore::ShadowRoot::attach):
* dom/ShadowRoot.h:
(WebCore):
(ShadowRoot):
* dom/ShadowTree.cpp: Renamed from Source/WebCore/dom/ShadowRootList.cpp.
(WebCore):
(WebCore::ShadowTree::ShadowTree):
(WebCore::ShadowTree::~ShadowTree):
(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):
(WebCore::ShadowTree::insertedIntoDocument):
(WebCore::ShadowTree::removedFromDocument):
(WebCore::ShadowTree::insertedIntoTree):
(WebCore::ShadowTree::removedFromTree):
(WebCore::ShadowTree::willRemove):
(WebCore::ShadowTree::attach):
(WebCore::ShadowTree::detach):
(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::isSelectorActive):
(WebCore::ShadowTree::reattach):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
(WebCore::ShadowTree::recalcShadowTreeStyle):
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
(WebCore::ShadowTree::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::reattachHostChildrenAndShadow):
(WebCore::ShadowTree::ensureSelector):
* dom/ShadowTree.h: Renamed from Source/WebCore/dom/ShadowRootList.h.
(WebCore):
(ShadowTree):
(WebCore::ShadowTree::hasShadowRoot):
(WebCore::ShadowTree::youngestShadowRoot):
(WebCore::ShadowTree::oldestShadowRoot):
(WebCore::ShadowTree::selector):
(WebCore::ShadowTree::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::host):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowRootFor):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::findMainSummary):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLSummaryElement.cpp:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::deleteBubbleTree):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):
* page/FocusController.cpp:
(WebCore::shadowRoot):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtract Supplementable base class from Page and Navigator
abarth@webkit.org [Mon, 27 Feb 2012 06:33:45 +0000 (06:33 +0000)]
Extract Supplementable base class from Page and Navigator
https://bugs.webkit.org/show_bug.cgi?id=79624

Reviewed by Hajime Morita.

We'll use this pattern again soon for ScriptExecutionContext.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
* Modules/gamepad/NavigatorGamepad.h:
* Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore::NavigatorGeolocation::from):
* Modules/geolocation/NavigatorGeolocation.h:
* Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* Modules/mediastream/UserMediaController.cpp:
(WebCore::provideUserMediaTo):
* Modules/mediastream/UserMediaController.h:
(WebCore::UserMediaController::from):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DeviceMotionController.cpp:
(WebCore::provideDeviceMotionTo):
* dom/DeviceMotionController.h:
(WebCore::DeviceMotionController::from):
* dom/DeviceOrientationController.cpp:
(WebCore::provideDeviceOrientationTo):
* dom/DeviceOrientationController.h:
(WebCore):
(WebCore::DeviceOrientationController::from):
* notifications/NotificationController.cpp:
(WebCore::provideNotification):
* notifications/NotificationController.h:
(WebCore):
(WebCore::NotificationController::from):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::page):
(WebCore):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
* page/DOMWindow.h:
(WebCore):
(DOMWindow):
* page/Navigator.cpp:
(WebCore):
* page/Navigator.h:
(Navigator):
* page/NavigatorSupplement.cpp: Removed.
* page/NavigatorSupplement.h: Removed.
* page/Page.cpp:
(WebCore):
* page/Page.h:
(Page):
* page/PageSupplement.cpp: Removed.
* page/PageSupplement.h: Removed.
* page/SpeechInput.cpp:
(WebCore::provideSpeechInputTo):
* page/SpeechInput.h:
(WebCore::SpeechInput::from):
* platform/Supplementable.h: Added.
(WebCore):
(Supplement):
(WebCore::Supplement::~Supplement):
(WebCore::Supplement::provideTo):
(WebCore::Supplement::from):
(Supplementable):
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove ChromeClient::showContextMenu() to ContextMenuClient
commit-queue@webkit.org [Mon, 27 Feb 2012 06:31:00 +0000 (06:31 +0000)]
Move ChromeClient::showContextMenu() to ContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=79427

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-26
Reviewed by Adam Barth.

Source/JavaScriptCore:

Added ACCESSIBILITY_CONTEXT_MENUS.

* wtf/Platform.h:

Source/WebCore:

- Removed ChromeClient::showContextMenu(), Chrome::showContextMenu()
- Added ContextMenuController::showContextMenuAt(), ContextMenuClient::showContextMenu()
- Hided showContextMenu() behind ACCESSIBILITY_CONTEXT_MENUS

This change localizes context menu related code and will make it easy to
modularize CONTEXT_MENUS code.

Refactoring. No new tests.

* WebCore.exp.in:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
* loader/EmptyClients.h:
(EmptyContextMenuClient):
(WebCore::EmptyContextMenuClient::showContextMenu):
* page/ContextMenuClient.h:
(ContextMenuClient):
* page/ContextMenuController.cpp:
(WebCore):
(WebCore::ContextMenuController::showContextMenuAt):
* page/ContextMenuController.h:
(ContextMenuController):
* page/Chrome.cpp:
* page/Chrome.h:
(Chrome):
* page/ChromeClient.h:
(ChromeClient):

Source/WebKit/blackberry:

* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Source/WebKit/chromium:

* src/ChromeClientImpl.h:
(ChromeClientImpl):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):

Source/WebKit/mac:

* WebCoreSupport/WebContextMenuClient.h:
(WebContextMenuClient):
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::showContextMenu): Moved from WebChromeClient
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.h:
(ChromeClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit):
(WebKit::WebContextMenuClient::showContextMenu): Moved from WebChromeClient
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
(WebContextMenuClient):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Release localized Strings instead of AutoRelease
benjamin@webkit.org [Mon, 27 Feb 2012 06:27:07 +0000 (06:27 +0000)]
[Mac] Release localized Strings instead of AutoRelease
https://bugs.webkit.org/show_bug.cgi?id=79552

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-26
Reviewed by Sam Weinig.

By using the CoreFoundation API, we can release the memory as soon as
the WTF::String is created.

* WebCore.xcodeproj/project.pbxproj:
* platform/mac/LocalizedStringsMac.cpp: Renamed from Source/WebCore/platform/mac/LocalizedStringsMac.mm.
(WebCore):
(WebCore::localizedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayoutTests/fast/forms/number/input-number-events.html is failing since r108228
commit-queue@webkit.org [Mon, 27 Feb 2012 05:27:43 +0000 (05:27 +0000)]
LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Update input-number-events.html test for r108228. Spin buttons of number input field
fire both input and change events.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-26
Reviewed by Kent Tamura.

* fast/forms/number/input-number-events-expected.txt: We get one change event from spin button click.
* fast/forms/number/input-number-events.html: Change to one for change event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContextDestructionObserver should live in its own file
abarth@webkit.org [Mon, 27 Feb 2012 05:10:08 +0000 (05:10 +0000)]
ContextDestructionObserver should live in its own file
https://bugs.webkit.org/show_bug.cgi?id=79619

Reviewed by Hajime Morita.

WebKit prefers to have one class per file.  (This patch is paying a
build system hacking debt I incurred earlier.)

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ActiveDOMObject.cpp:
(WebCore):
* dom/ActiveDOMObject.h:
(ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
(WebCore::ActiveDOMObject::setPendingActivity):
(WebCore::ActiveDOMObject::unsetPendingActivity):
* dom/ContextDestructionObserver.cpp: Added.
(WebCore):
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
* dom/ContextDestructionObserver.h: Added.
(WebCore):
(ContextDestructionObserver):
(WebCore::ContextDestructionObserver::scriptExecutionContext):
* dom/DOMAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate .gitignore for project property files generated by Eclipse.
commit-queue@webkit.org [Mon, 27 Feb 2012 05:05:49 +0000 (05:05 +0000)]
Update .gitignore for project property files generated by Eclipse.
https://bugs.webkit.org/show_bug.cgi?id=79463

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-02-26
Reviewed by Andreas Kling.

* .gitignore: Ignore .project and .cproject

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 27 Feb 2012 04:16:09 +0000 (04:16 +0000)]
2012-02-26  Dirk Schulze  <krit@webkit.org>

        Cleanup of Adobes copyright text. The text got harmonized with copyright texts of other companies.

        Rubber stamped by Adam Barth.

        * css/CSSWrapShapes.cpp:
        * css/CSSWrapShapes.h:
        * css/WebKitCSSRegionRule.cpp:
        * css/WebKitCSSRegionRule.h:
        * css/WebKitCSSRegionRule.idl:
        * css/WebKitCSSShaderValue.cpp:
        * css/WebKitCSSShaderValue.h:
        * dom/WebKitNamedFlow.cpp:
        * dom/WebKitNamedFlow.h:
        * dom/WebKitNamedFlow.idl:
        * loader/cache/CachedShader.cpp:
        * loader/cache/CachedShader.h:
        * platform/graphics/filters/CustomFilterMesh.cpp:
        * platform/graphics/filters/CustomFilterMesh.h:
        * platform/graphics/filters/CustomFilterNumberParameter.h:
        * platform/graphics/filters/CustomFilterOperation.cpp:
        * platform/graphics/filters/CustomFilterOperation.h:
        * platform/graphics/filters/CustomFilterParameter.h:
        * platform/graphics/filters/CustomFilterProgram.cpp:
        * platform/graphics/filters/CustomFilterProgram.h:
        * platform/graphics/filters/CustomFilterProgramClient.h:
        * platform/graphics/filters/CustomFilterShader.cpp:
        * platform/graphics/filters/CustomFilterShader.h:
        * platform/graphics/filters/FECustomFilter.cpp:
        * platform/graphics/filters/FECustomFilter.h:
        * rendering/FilterEffectObserver.h:
        * rendering/RenderFlowThread.cpp:
        * rendering/RenderFlowThread.h:
        * rendering/RenderRegion.cpp:
        * rendering/RenderRegion.h:
        * rendering/style/StyleCachedShader.cpp:
        * rendering/style/StyleCachedShader.h:
        * rendering/style/StyleCustomFilterProgram.h:
        * rendering/style/StylePendingShader.h:
        * rendering/style/StyleShader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse Functional instead of a MessageQueue for messages to the LayerTreeHostProxy
commit-queue@webkit.org [Mon, 27 Feb 2012 04:13:32 +0000 (04:13 +0000)]
Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy
renderer.
https://bugs.webkit.org/show_bug.cgi?id=79478

This makes a lot of the broilerplate code for message-passing unnecessary, and
results in a much more succinct implementation.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-26
Reviewed by Noam Rosenthal.

* UIProcess/LayerTreeHostProxy.h:
(WebKit):
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayoutTests/fast/xpath/xpath-functional-test.html is crashing in the DFG
fpizlo@apple.com [Mon, 27 Feb 2012 04:07:56 +0000 (04:07 +0000)]
LayoutTests/fast/xpath/xpath-functional-test.html is crashing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=79616

Reviewed by Oliver Hunt.

Guard against the fact that in JSVALUE64, JSValue().isCell() == true.

* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::validate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should support activations and nested functions
fpizlo@apple.com [Mon, 27 Feb 2012 04:05:26 +0000 (04:05 +0000)]
DFG should support activations and nested functions
https://bugs.webkit.org/show_bug.cgi?id=79554

Reviewed by Sam Weinig.

Fix 32-bit. The 32-bit function+activation code had some really weird
register reuse bugs.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update expectation files due to slight changes in the text
fpizlo@apple.com [Mon, 27 Feb 2012 04:02:12 +0000 (04:02 +0000)]
Unreviewed, update expectation files due to slight changes in the text
of exceptions.

* sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for SL.
fpizlo@apple.com [Mon, 27 Feb 2012 03:50:07 +0000 (03:50 +0000)]
Build fix for SL.

* Platform/mac/RemoteLayerClient.mm:
(WebKit::RemoteLayerClient::RemoteLayerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEncapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class
weinig@apple.com [Mon, 27 Feb 2012 03:12:36 +0000 (03:12 +0000)]
Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class
https://bugs.webkit.org/show_bug.cgi?id=79612

Reviewed by Anders Carlsson.

* Platform/mac/RemoteLayerClient.h:
* Platform/mac/RemoteLayerClient.mm:
(WebKit::RemoteLayerClient::create):
(WebKit::RemoteLayerClient::RemoteLayerClient):
(WebKit::RemoteLayerClient::~RemoteLayerClient):
(WebKit::RemoteLayerClient::clientID):
(WebKit::RemoteLayerClient::invalidate):
New class that encapsulates calls to WKSI WKCARemoteLayerClient*. For platforms
where the use of WKSI is not necessary, due to CARemoteLayerClient being available,
stop using WKSI.

* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformInitialize):
(WebKit::PluginControllerProxy::platformDestroy):
(WebKit::PluginControllerProxy::remoteLayerClientID):
(WebKit::PluginControllerProxy::platformGeometryDidChange):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::disposeOfLayerClient):
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
(LayerTreeHostCAMac):
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Switch to using RemoteLayerClient.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Use CARemoteLayerServer directly if available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update after r108892.
bashi@chromium.org [Mon, 27 Feb 2012 02:57:22 +0000 (02:57 +0000)]
[Chromium] Unreviewed test expectations update after r108892.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update after r108896
bashi@chromium.org [Mon, 27 Feb 2012 02:45:24 +0000 (02:45 +0000)]
[Chromium] Unreviewed test expectations update after r108896

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGetting the instruction stream for a code block should not require two loads
fpizlo@apple.com [Mon, 27 Feb 2012 02:07:34 +0000 (02:07 +0000)]
Getting the instruction stream for a code block should not require two loads
https://bugs.webkit.org/show_bug.cgi?id=79608

Reviewed by Sam Weinig.

Introduced the RefCountedArray class, which contains a single inline pointer
to a ref-counted non-resizeable vector backing store. This satisfies the
requirements of CodeBlock, which desires the ability to share instruction
streams with other CodeBlocks. It also reduces the number of loads required
for getting the instruction stream by one.

This patch also gets rid of the bytecode discarding logic, since we don't
use it anymore and it's unlikely to ever work right with DFG or LLInt. And
I didn't feel like porting dead code to use RefCountedArray.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::instructionOffsetForNth):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::Label::setLocation):
(JSC):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::newLabel):
* bytecompiler/BytecodeGenerator.h:
(JSC):
(BytecodeGenerator):
(JSC::BytecodeGenerator::instructions):
* bytecompiler/Label.h:
(JSC::Label::Label):
(Label):
* dfg/DFGByteCodeCache.h:
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):
* jit/JITExceptions.cpp:
(JSC::genericThrow):
* llint/LowLevelInterpreter32_64.asm:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
* wtf/RefCountedArray.h: Added.
(WTF):
(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::operator=):
(WTF::RefCountedArray::~RefCountedArray):
(WTF::RefCountedArray::size):
(WTF::RefCountedArray::data):
(WTF::RefCountedArray::begin):
(WTF::RefCountedArray::end):
(WTF::RefCountedArray::at):
(WTF::RefCountedArray::operator[]):
(Header):
(WTF::RefCountedArray::Header::size):
(WTF::RefCountedArray::Header::payload):
(WTF::RefCountedArray::Header::fromPayload):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
haraken@chromium.org [Mon, 27 Feb 2012 01:48:01 +0000 (01:48 +0000)]
[Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=79593

Reviewed by Adam Barth.

This patch halves the execution time of Bindings/dom-attributes.html
in order to avoid timeout in Chromium. The reason for the timeout is that
V8 DOM bindings are too much slower than JSC bindings.
I am a bit afraid that this patch will reduce the accuracy of the
perf test results, but it would make sense to reduce the execution time
until we fix the performance issue in V8 DOM bindings.

* Bindings/dom-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTake 2 build fix.
jamesr@google.com [Mon, 27 Feb 2012 01:19:59 +0000 (01:19 +0000)]
Take 2 build fix.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update expectations for svg carto.net tests
noel.gordon@gmail.com [Mon, 27 Feb 2012 01:14:05 +0000 (01:14 +0000)]
[chromium] Update expectations for svg carto.net tests
https://bugs.webkit.org/show_bug.cgi?id=79423

Unreviewed. Optimize svg/carto.net/scrollbar.svg and svg/carto.net/selectionlist.svg
test baselines.

* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.txt: Removed.
* platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Removed.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCompile fix for CCLayerTreeHostImpl test.
jamesr@google.com [Mon, 27 Feb 2012 01:12:27 +0000 (01:12 +0000)]
Compile fix for CCLayerTreeHostImpl test.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implementation of GraphicsContext3D for EFL port
commit-queue@webkit.org [Mon, 27 Feb 2012 01:11:20 +0000 (01:11 +0000)]
[EFL] Implementation of GraphicsContext3D for EFL port
https://bugs.webkit.org/show_bug.cgi?id=79452

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-26
Reviewed by Noam Rosenthal.

Evas_GL is used to do OpenGL rendering on Evas, in which
a structure 'Evas_GL_API' contains all the OpenGL functions.

GraphicsContext3D in EFL port should call OpenGL functions indirectly
through the Evas_GL_API, and not use GraphicsContext3DOpenGL(Common).

So, we use the GraphicsContext3DPrivate to delegate all OpenGL function calls,
and it will be implemented to use Evas_GL (bug 62961).

No new tests. No behavior change.

* platform/graphics/efl/GraphicsContext3DEfl.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::isResourceSafe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Wire up shouldUpdateScrollPositionOnMainThread and nonFastScrollableRegion...
jamesr@google.com [Mon, 27 Feb 2012 01:04:20 +0000 (01:04 +0000)]
[chromium] Wire up shouldUpdateScrollPositionOnMainThread and nonFastScrollableRegion to compositor
https://bugs.webkit.org/show_bug.cgi?id=79155

Reviewed by Adam Barth.

Source/WebCore:

This hooks up ScrollingCoordinator::setNonFastScrollableRegion() and
ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread() to the chromium compositor
implementation and implements them on the impl thread.

New compositor behavior is covered by unit tests in LayerChromiumTests and CCLayerTreeHostImplTests. The rest is
just glue code.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setShouldScrollOnMainThread):
(WebCore):
(WebCore::LayerChromium::setNonFastScrollableRegion):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::shouldScrollOnMainThread):
(WebCore::CCLayerImpl::setShouldScrollOnMainThread):
(CCLayerImpl):
(WebCore::CCLayerImpl::nonFastScrollableRegion):
(WebCore::CCLayerImpl::setNonFastScrollableRegion):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

Add new tests for shouldScrollOnMainThread and nonFastScrollableRegion properties.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Mon, 27 Feb 2012 00:25:40 +0000 (00:25 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_supplemental_method4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name
commit-queue@webkit.org [Sun, 26 Feb 2012 22:51:38 +0000 (22:51 +0000)]
StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name
https://bugs.webkit.org/show_bug.cgi?id=79571

Patch by Yusuke Suzuki <utatane.tea@gmail.com> on 2012-02-26
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* parser/ASTBuilder.h:
(JSC::ASTBuilder::createGetterOrSetterProperty):
* parser/Parser.cpp:
(JSC::::parseProperty):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createGetterOrSetterProperty):

LayoutTests:

* fast/js/property-getters-and-setters-expected.txt:
* fast/js/script-tests/property-getters-and-setters.js:
(o9.string_appeared_here.7.get string_appeared_here):
(o9.set string_appeared_here):
(get shouldBe):
(o10.string_appeared_here.7.get 42):
(o10.set 42):
* platform/chromium/fast/js/property-getters-and-setters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement fast path for op_new_array in the baseline JIT
mhahnenberg@apple.com [Sun, 26 Feb 2012 22:41:41 +0000 (22:41 +0000)]
Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

heap/CopiedAllocator.h:
(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.
* heap/CopiedSpace.h:
(CopiedSpace): Friended the JIT to allow access to isOversize.
(JSC::CopiedSpace::allocator):
* heap/Heap.h:
(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.
* jit/JIT.h:
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): New slow path that just bails out to a stub call if we
fail in any way on the fast path.
* runtime/JSArray.cpp:
(JSC):
* runtime/JSArray.h: Added lots of offset functions for all the fields that we need to
initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108547.
inferno@chromium.org [Sun, 26 Feb 2012 18:06:55 +0000 (18:06 +0000)]
Unreviewed, rolling out r108547.
http://trac.webkit.org/changeset/108547
https://bugs.webkit.org/show_bug.cgi?id=79606

Crashes on ClusterFuzz (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-26

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

* fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Removed.
* fast/css-generated-content/first-letter-textbox-parent-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r108681.
paroga@webkit.org [Sun, 26 Feb 2012 11:11:00 +0000 (11:11 +0000)]
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r108681.

* interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::Interpreter::getStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for !ENABLE(JIT) after r108681.
paroga@webkit.org [Sun, 26 Feb 2012 08:55:02 +0000 (08:55 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r108681.

* interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove websockets to Modules/websockets
abarth@webkit.org [Sun, 26 Feb 2012 07:28:37 +0000 (07:28 +0000)]
Move websockets to Modules/websockets
https://bugs.webkit.org/show_bug.cgi?id=79598

Reviewed by Eric Seidel.

Nowadays, the only ENABLE(WEB_SOCKETS) ifdef in WebCore proper is in
WebCore::Settings, and that will be removed (soon?) once Apple drops
support for the old WebSockets protocol.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/websockets: Copied from Source/WebCore/websockets.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* websockets: Removed.
* websockets/CloseEvent.h: Removed.
* websockets/CloseEvent.idl: Removed.
* websockets/DOMWindowWebSocket.idl: Removed.
* websockets/ThreadableWebSocketChannel.cpp: Removed.
* websockets/ThreadableWebSocketChannel.h: Removed.
* websockets/ThreadableWebSocketChannelClientWrapper.cpp: Removed.
* websockets/ThreadableWebSocketChannelClientWrapper.h: Removed.
* websockets/WebSocket.cpp: Removed.
* websockets/WebSocket.h: Removed.
* websockets/WebSocket.idl: Removed.
* websockets/WebSocketChannel.cpp: Removed.
* websockets/WebSocketChannel.h: Removed.
* websockets/WebSocketChannelClient.h: Removed.
* websockets/WebSocketDeflater.cpp: Removed.
* websockets/WebSocketDeflater.h: Removed.
* websockets/WebSocketExtensionDispatcher.cpp: Removed.
* websockets/WebSocketExtensionDispatcher.h: Removed.
* websockets/WebSocketExtensionProcessor.h: Removed.
* websockets/WebSocketFrame.h: Removed.
* websockets/WebSocketHandshake.cpp: Removed.
* websockets/WebSocketHandshake.h: Removed.
* websockets/WebSocketHandshakeRequest.cpp: Removed.
* websockets/WebSocketHandshakeRequest.h: Removed.
* websockets/WebSocketHandshakeResponse.cpp: Removed.
* websockets/WebSocketHandshakeResponse.h: Removed.
* websockets/WorkerThreadableWebSocketChannel.cpp: Removed.
* websockets/WorkerThreadableWebSocketChannel.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of KURL::deprecatedString()
benjamin@webkit.org [Sun, 26 Feb 2012 07:05:20 +0000 (07:05 +0000)]
Get rid of KURL::deprecatedString()
https://bugs.webkit.org/show_bug.cgi?id=79594

Reviewed by Andreas Kling.

The method KURL::deprecatedString() is unused, remove it from WebCore.

The last reference to the method was removed in r96779.

* platform/KURL.cpp:
(WebCore):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore):
* platform/KURLWTFURL.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of copyParsedQueryTo()
benjamin@webkit.org [Sun, 26 Feb 2012 06:51:12 +0000 (06:51 +0000)]
Get rid of copyParsedQueryTo()
https://bugs.webkit.org/show_bug.cgi?id=79590

Reviewed by Andreas Kling.

The function KURL::copyParsedQueryTo() is unused. Remove it from WebCore.

The function was used by HTMLAnchorElement::getParameter() but that feature
was removed in r100164.

* WebCore.order:
* platform/KURL.cpp:
(WebCore):
* platform/KURL.h:
(WebCore):
(KURL):
* platform/KURLGoogle.cpp:
(WebCore):
* platform/KURLWTFURL.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108924.
commit-queue@webkit.org [Sun, 26 Feb 2012 06:35:41 +0000 (06:35 +0000)]
Unreviewed, rolling out r108924.
http://trac.webkit.org/changeset/108924
https://bugs.webkit.org/show_bug.cgi?id=79597

broke 4 inspector tests (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

* dom/StyledElement.cpp:
(WebCore::StyledElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in comment. This #endif is for a different ENABLE macro.
abarth@webkit.org [Sun, 26 Feb 2012 06:16:00 +0000 (06:16 +0000)]
Fix typo in comment.  This #endif is for a different ENABLE macro.

* page/NavigatorRegisterProtocolHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove an ASSERT to avoid it firing due to a race condition
andersca@apple.com [Sun, 26 Feb 2012 05:40:40 +0000 (05:40 +0000)]
Move an ASSERT to avoid it firing due to a race condition
https://bugs.webkit.org/show_bug.cgi?id=79596

Reviewed by Andreas Kling.

ScrollingThread::isCurrentThread() can return false if called too early.
Move it into ScrollingThread::initializeRunLoop where we know that the thread has
been set up correctly.

* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::threadBody):
* page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::initializeRunLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSetting style="" should destroy the element's inline style.
kling@webkit.org [Sun, 26 Feb 2012 05:08:28 +0000 (05:08 +0000)]
Setting style="" should destroy the element's inline style.
<http://webkit.org/b/79595>

Reviewed by Anders Carlsson.

There's no reason for an element with style="" to have an inline style object.
Remove the inline style in that case, just like we do when removing the style
attribute altogether.

* dom/StyledElement.cpp:
(WebCore::StyledElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange Build bot with BuildAndTest bot for EFL port.
gyuyoung.kim@samsung.com [Sun, 26 Feb 2012 04:12:27 +0000 (04:12 +0000)]
Change Build bot with BuildAndTest bot for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77518

Reviewed by Ryosuke Niwa.

Tools:

EFL build bot starts to support layout test.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
* BuildSlaveSupport/test-result-archive:
(archiveTestResults):
* Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
(generateBuildSystemFromCMakeProject):

LayoutTests:

* platform/efl/Skipped: Update skip list with test cases which don't have expected result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate EFL port's Skipped file for Ubuntu 11.10.
gyuyoung.kim@samsung.com [Sun, 26 Feb 2012 03:38:34 +0000 (03:38 +0000)]
Update EFL port's Skipped file for Ubuntu 11.10.
https://bugs.webkit.org/show_bug.cgi?id=79440

Reviewed by Ryosuke Niwa.

To run EFL layout test on Ubuntu 11.10, Skipped file needs to be updated.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerf-o-matic build fix after r108917. I need a scrollbar in order see all the tests.
rniwa@webkit.org [Sun, 26 Feb 2012 02:35:52 +0000 (02:35 +0000)]
Perf-o-matic build fix after r108917. I need a scrollbar in order see all the tests.

* Websites/webkit-perf.appspot.com/css/admin.css:
(html):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAddress review feedback from Andreas Kling.
andersca@apple.com [Sun, 26 Feb 2012 02:02:31 +0000 (02:02 +0000)]
Address review feedback from Andreas Kling.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMouse tracking incorrect in Silverlight when using multi monitor with offset arrangement
andersca@apple.com [Sun, 26 Feb 2012 01:59:49 +0000 (01:59 +0000)]
Mouse tracking incorrect in Silverlight when using multi monitor with offset arrangement
https://bugs.webkit.org/show_bug.cgi?id=79589
<rdar://problem/9719592>

Reviewed by Sam Weinig.

In the Carbon event model, mouse event coordinates are flipped relative to the first screen,
whereas the coordinates we get from the WebMouseEvent are flipped relative to the screen where
the containing WKView is on.

Instead of passing the global coordinates to NPP_HandleEvent, convert them to the flipped screen coordinate
system that the plug-in expects.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQuickLook events don't make it to WebKit plugins.
weinig@apple.com [Sun, 26 Feb 2012 01:32:51 +0000 (01:32 +0000)]
QuickLook events don't make it to WebKit plugins.
<rdar://problem/10931721>

Reviewed by Anders Carlsson.

* WebView/WebHTMLView.mm:
(isQuickLookEvent):
(-[WebHTMLView hitTest:]):
Allow QuickLook events to hit test down to subviews.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoperf-o-matic needs a better admin page
rniwa@webkit.org [Sun, 26 Feb 2012 01:22:39 +0000 (01:22 +0000)]
perf-o-matic needs a better admin page
https://bugs.webkit.org/show_bug.cgi?id=79585

Reviewed by Sam Weinig.

Add admin/ to replace admin/create-models.html and admin/merge-tests.

Also update MergeTestHandler to accept JSON requests and add "Admin" navigation link on all pages.

* Websites/webkit-perf.appspot.com/admin_handlers.py: Added.
* Websites/webkit-perf.appspot.com/controller.py:
(RunsUpdateHandler.post): Fix a regression from r108399.
* Websites/webkit-perf.appspot.com/css/admin.css: Added.
* Websites/webkit-perf.appspot.com/js/admin.js: Added.
* Websites/webkit-perf.appspot.com/js/config.js:
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/merge_tests.html: Removed.
* Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler):
(MergeTestsHandler.post):
* Websites/webkit-perf.appspot.com/static: Removed.
* Websites/webkit-perf.appspot.com/static/create-models.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow matched property cache for elements with additional attribute style.
kling@webkit.org [Sun, 26 Feb 2012 00:49:00 +0000 (00:49 +0000)]
Allow matched property cache for elements with additional attribute style.
<http://webkit.org/b/79583>

Reviewed by Antti Koivisto.

There's no reason to disallow the matched style property cache for elements
that return something from additionalAttributeStyle(). The only requirement
for a property set to be cached is that it either doesn't mutate OR that it
invalidates the document's CSSStyleSelector when doing so.

This allows some more match caching for table-related elements, though we
are still held back by explicitly 'inherited' properties in html.css.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108900.
commit-queue@webkit.org [Sun, 26 Feb 2012 00:28:26 +0000 (00:28 +0000)]
Unreviewed, rolling out r108900.
http://trac.webkit.org/changeset/108900
https://bugs.webkit.org/show_bug.cgi?id=79587

broke some API tests, will investigate and re-commit
(Requested by noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

* UIProcess/API/qt/qquickwebpage.cpp:
(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean-up RenderTableSection::calcRowLogicalHeight
jchaffraix@webkit.org [Sun, 26 Feb 2012 00:19:22 +0000 (00:19 +0000)]
Clean-up RenderTableSection::calcRowLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=77705

Reviewed by Nikolas Zimmermann.

Refactoring / simplication of the code.

This change removes some variables that were unneeded and were
hiding what the code was really doing. Also some of the code was
split and moved down to RenderTableCell.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
* rendering/RenderTableCell.h:
(RenderTableCell):
Added the previous helper function to calculate the cell's
adjusted logical height.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
Removed some variables, simplified the rowspan logic to be clearer
(and added a comment about how we handle rowspans).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLLInt assembly file should be split into 32-bit and 64-bit parts
fpizlo@apple.com [Sun, 26 Feb 2012 00:19:07 +0000 (00:19 +0000)]
LLInt assembly file should be split into 32-bit and 64-bit parts
https://bugs.webkit.org/show_bug.cgi?id=79584

Reviewed by Sam Weinig.

Moved LowLevelInterpreter.asm to LowLevelInterpreter32_64.asm. Gave offlineasm
the ability to include files, and correctly track dependencies: it restricts
the include mechanism to using the same directory as the source file, and uses
the SHA1 hash of all .asm files in that directory as an input hash.

* llint/LLIntOfflineAsmConfig.h:
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm: Added.
    - This is just the entire contents of what was previously LowLevelInterpreter.asm
* llint/LowLevelInterpreter64.asm: Added.
* offlineasm/asm.rb:
* offlineasm/ast.rb:
* offlineasm/generate_offset_extractor.rb:
* offlineasm/parser.rb:
* offlineasm/self_hash.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108913 268f45cc-cd09-0410-ab3c-d52691b4dbfc