WebKit-https.git
7 years agoPass the right color space over to the web process so we can set it on our CA context
andersca@apple.com [Tue, 12 Jun 2012 00:29:34 +0000 (00:29 +0000)]
Pass the right color space over to the web process so we can set it on our CA context
https://bugs.webkit.org/show_bug.cgi?id=88819
<rdar://problem/11629050>

Reviewed by John Sullivan.

Source/WebKit2:

* Platform/mac/LayerHostingContext.h:
(LayerHostingContext):
* Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
Use a single constructor and explicitly set up the parameters of the constructed object.

(WebKit::LayerHostingContext::setColorSpace):
(WebKit::LayerHostingContext::colorSpace):
Add getter and setter.

* Scripts/webkit2/messages.py:
(struct_or_class):
WebKit::ColorSpaceData is a struct.

* Shared/WebPageCreationParameters.cpp:
Encode and decode the color space parameter.

* Shared/WebPageCreationParameters.h:
Add the color space.

* Shared/mac/ColorSpaceData.h: Added.
* Shared/mac/ColorSpaceData.mm: Added.
Add a new class that represents a color space that can be sent over the wire.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::colorSpace):
Call through to the WKView.

* UIProcess/API/mac/WKView.mm:
(-[WKView _windowDidChangeBackingProperties:]):
Fix whitespace.

(-[WKView viewDidChangeBackingProperties]):
Check if our new color space is different from the current one and null the current one out if that is the case,
it will be reinitialized by the next call to -[WKView _colorSpace].

(-[WKView _colorSpace:]):
Compute the color space. If we're not in a window we'll get the main screen's color space.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::colorSpaceDidChange):
Add empty stub.

* UIProcess/PageClient.h:
Add colorSpace getter.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Initialize the color space.

* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::colorSpaceDidChange):
Send the new color space over to the web process.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::colorSpace):
Call through to the page client.

* WebKit2.xcodeproj/project.pbxproj:
Add ColorSpaceData.h and ColorSpaceData.mm.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
Add SetColorSpace message.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Set the color space from the creation parameters.

(WebKit::TiledCoreAnimationDrawingArea::setColorSpace):
Set the color space on the layer hosting context.

(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext):
Make sure we apply the color space from the previous layer hosting context if one exists.

WebKitLibraries:

Add WKCAContextSetColorSpace and WKCAContextGetColorSpace.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Seek calls are being unnecessarily delayed
commit-queue@webkit.org [Tue, 12 Jun 2012 00:02:08 +0000 (00:02 +0000)]
[BlackBerry] Seek calls are being unnecessarily delayed
https://bugs.webkit.org/show_bug.cgi?id=88732

Patch by Max Feil <mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

There is a problem with the way the m_userDrivenSeekTimer is
implemented. When MediaPlayerPrivate::seek() is called, there
is always a 100ms delay even if the timer is not running. The
timer is supposed to space out (i.e. throttle) repeated seeks
that come in too soon after a previous seek, but currently it
is slowing down even single seeks and seeks that come in with
adequate delay after a previous seek. I fixed this in my patch
by improving the way the timer fired function is called.

A note on the new m_lastSeekTimePending flag: This flag is
needed so that userDrivenSeekTimerFired() knows whether or not
to perform the seek. The only case where this flag will not be
set is if no MediaPlayerPrivate::seek() call came in while the
timer was active, in which case it's important to do nothing.
I could encode this flag's information into the m_lastSeekTime
float, for example by initializing it and resetting it to NAN
and using isnan(). But I feel that using a separate bool is a
more portable approach.

No new tests. I would like to propose not including a layout test
with this fix. Doing timing tests for 100ms delays is tricky
from Javascript, and I don't think the benefit of such a test
outweighs the extra time it would take to develop one. The test
would also be a problem to maintain as it may give different
results over different runs and across different target hardware.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't consider show warnings in the garden-o-matic UI for non-layout test failures
ojan@chromium.org [Mon, 11 Jun 2012 23:48:11 +0000 (23:48 +0000)]
Don't consider show warnings in the garden-o-matic UI for non-layout test failures
https://bugs.webkit.org/show_bug.cgi?id=88816

Reviewed by Dirk Pranke.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
Expose a way to clear AsynchronousCaches.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Unexpected repeats of short media
commit-queue@webkit.org [Mon, 11 Jun 2012 23:18:15 +0000 (23:18 +0000)]
[BlackBerry] Unexpected repeats of short media
https://bugs.webkit.org/show_bug.cgi?id=88733

Patch by Max Feil <mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

Source/WebCore:

The m_userDrivenSeekTimer is causing unwanted repeats of short
media such as sound effects because it is causing the current
time to not reflect that the media has finished playing.
This problem only affects media whose duration is close to
or less than the SeekSubmissionDelay, which is currently
set to 100ms. My fix is to ignore the userDrivenSeekTimer in
MediaPlayerPrivate::currentTime() if the duration of the media
is within twice the SeekSubmissionDelay. Seek drag smoothness
is a non-issue for such short media.

Test: platform/blackberry/media/short-media-repeats-correctly.html

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

LayoutTests:

Test for problem where short media repeats unintentionally.

* media/content/short.wav: Added.
* platform/blackberry/media/short-media-repeats-correctly-expected.txt: Added.
* platform/blackberry/media/short-media-repeats-correctly.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccount for margin after when laying out <legend> element
jchaffraix@webkit.org [Mon, 11 Jun 2012 23:14:38 +0000 (23:14 +0000)]
Account for margin after when laying out <legend> element
https://bugs.webkit.org/show_bug.cgi?id=35981

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/forms/legend-after-margin-horizontal-writing-mode.html
       fast/forms/legend-after-margin-vertical-writing-mode.html
       fast/forms/legend-after-margin-with-before-border-horizontal-mode.html
       fast/forms/legend-small-after-margin-before-border-horizontal-mode.html

The existing code would ignore margin after when layouting out the <legend>. This
change only adds the code to handle the margin after, the margin before is still
ignored as it's not obvious how it should be working.

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
Split the code in 2 code paths to reflect how we position and size. Those are covered by the
tests above.

LayoutTests:

* fast/forms/legend-after-margin-horizontal-writing-mode-expected.html: Added.
* fast/forms/legend-after-margin-horizontal-writing-mode.html: Added.
* fast/forms/legend-after-margin-vertical-writing-mode-expected.html: Added.
* fast/forms/legend-after-margin-vertical-writing-mode.html: Added.
* fast/forms/legend-after-margin-with-before-border-horizontal-mode-expected.html: Added.
* fast/forms/legend-after-margin-with-before-border-horizontal-mode.html: Added.
* fast/forms/legend-small-after-margin-before-border-horizontal-mode-expected.html: Added.
* fast/forms/legend-small-after-margin-before-border-horizontal-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
jamesr@google.com [Mon, 11 Jun 2012 23:12:28 +0000 (23:12 +0000)]
[chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
https://bugs.webkit.org/show_bug.cgi?id=86259

Reviewed by Adrienne Walker.

This refactors the compositor's rate limiting implementation to use the Platform API's WebGraphicsContext3D
directly instead of WebCore::GraphicsContext3D to cut down on the number of spurious WebCore dependencies in the
compositor.  The one change in contract is that the caller to CCLayerTreeHost::startRateLimit() now has to call
CCLayerTreeHost::stopRateLimit() before allowing the referenced context to go away since CCLayerTreeHost no
longer retains a reference, but this was always happening already.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
* platform/graphics/chromium/RateLimiter.cpp:
(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::rateLimitContext):
* platform/graphics/chromium/RateLimiter.h:
(WebKit):
(RateLimiter):
* platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by...
danakj@chromium.org [Mon, 11 Jun 2012 22:58:16 +0000 (22:58 +0000)]
[chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad
https://bugs.webkit.org/show_bug.cgi?id=88363

Reviewed by Adrienne Walker.

Source/Platform:

* Platform.gypi:
* chromium/public/WebVideoFrame.h:
* chromium/src/WebVideoFrame.cpp: Removed.

Source/WebCore:

CCVideoDrawQuad should not contain any pointers to data in the layer
tree so we are able to serialize it across process boundaries. This
patch removes the ManagedTexture pointers from the quad class,
replacing them with texture ids. It removes the WebVideoFrame* from
the quad, replacing it with the frame provider's texture id included
in the WebVideoFrame structure. And it uses a WebTransformationMatrix
instead of a pointer to an array of floats.

Texture allocation is done in CCVideoLayerImpl via the
contentsTextureAllocator, so that the memory usage can be tracked.

We move the copyPlaneToTextures() method back from LayerRendererChromium
to CCVideoLayerImpl, as this method uses the texture data pointer in the
WebVideoFrame, and we do not want to give this pointer to the quad
class. Instead, this method makes use of the LayerTextureSubImage class
to copy the pixel data into the texture.

LayerTextureSubImage is updated to allow non-4byte texture formats.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
* platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::planes):
(WebCore::CCVideoDrawQuad::frameProviderTextureId):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(FramePlane):
(WebCore::CCVideoLayerImpl::FramePlane::FramePlane):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCTiledLayerTestCommon.h:
(WebKitTests::FakeTextureCopier::copyToTexture):
* tests/Canvas2DLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Object stores are not successfully deleted
jsbell@chromium.org [Mon, 11 Jun 2012 22:41:55 +0000 (22:41 +0000)]
IndexedDB: Object stores are not successfully deleted
https://bugs.webkit.org/show_bug.cgi?id=88788

Reviewed by Tony Chang.

Source/WebCore:

Discovered while working on http://webkit.org/b/83074 - object stores are not
being deleted from the backing store. Deletion would succeed in the in-memory
data structures, but after closing/re-opening the backing store the object store
(but not its indexes/data) would reappear. Due to 83074, this isn't detectable
by DRT without a full restart.

Test: [chromium] webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

Source/WebKit/chromium:

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in fast/files/read tests during Garbage Collection
ericu@chromium.org [Mon, 11 Jun 2012 22:29:32 +0000 (22:29 +0000)]
Crash in fast/files/read tests during Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=87165

Reviewed by Michael Saboff

Source/WebCore:

Fix previous fix for hasPendingActivity, and fix a bug in a complex
abort case as well--abort during the final progress event of a write
would hang the writer.

* Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::didWrite):
(WebCore::FileWriter::didTruncate):
(WebCore::FileWriter::didFail):
(WebCore::FileWriter::completeAbort):
(WebCore::FileWriter::doOperation):
(WebCore::FileWriter::signalCompletion):

LayoutTests:

Simplify file-writer-abort-continue.js a bit, and add a new test case
for a write that gets aborted in the final progress event, which
previously would have hung the FileWriter.

* fast/filesystem/file-writer-abort-continue-expected.txt:
* fast/filesystem/resources/file-writer-abort-continue.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Replace obsolete mkdir_p variable with MKDIR_P
commit-queue@webkit.org [Mon, 11 Jun 2012 22:16:11 +0000 (22:16 +0000)]
.: Replace obsolete mkdir_p variable with MKDIR_P
https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

* GNUmakefile.am:
* configure.ac:

Source/WebKit/gtk/po: Replace obsolete mkdir_p variables with MKDIR_P
https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebAudio tests need to set WebKitWebAudioEnabled.
commit-queue@webkit.org [Mon, 11 Jun 2012 22:05:36 +0000 (22:05 +0000)]
WebAudio tests need to set WebKitWebAudioEnabled.
https://bugs.webkit.org/show_bug.cgi?id=88624

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-11
Reviewed by Chris Rogers.

* webaudio/audiochannelmerger-basic.html: Set WebKitWebAudioEnabled by including 'audio-testing.js'.
* webaudio/audionode-connect-order.html: ditto.
* webaudio/biquadfilternode-basic.html: ditto.
* webaudio/delaynode-maxdelay.html: ditto.
* webaudio/delaynode-scheduling.html: ditto.
* webaudio/delaynode.html: ditto.
* webaudio/javascriptaudionode-downmix8-2channel-input.html: ditto.
* webaudio/javascriptaudionode-upmix2-8channel-input.html: ditto.
* webaudio/mediaelementaudiosourcenode-gc.html: ditto.
* webaudio/mediaelementaudiosourcenode.html: ditto.
* webaudio/realtimeanalyser-fft-sizing.html: ditto.
* webaudio/stereo2mono-down-mixing.html: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not...
tonikitoo@webkit.org [Mon, 11 Jun 2012 22:04:07 +0000 (22:04 +0000)]
[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
https://bugs.webkit.org/show_bug.cgi?id=88809

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Adjust the media container dimensions, whenever the FrameView::frameRect
(aka viewport rect) changes

Reviewed internally by Jacky Jiang.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobrowser video player fullscreen mode (portrait) does not play well with viewport...
tonikitoo@webkit.org [Mon, 11 Jun 2012 22:03:55 +0000 (22:03 +0000)]
browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen https://bugs.webkit.org/show_bug.cgi?id=88719 PR #164026

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Instead of using WebPage's viewport size, which suffers from
dealing with transformed coordinates, viewport metatag changes,
etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
which abstract all these variations.

It fixes an overscale issue we were having when video player entered
fullscreen, and webpage had viewport metatag set.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Implement position:fixed in compositor thread
shawnsingh@chromium.org [Mon, 11 Jun 2012 21:37:44 +0000 (21:37 +0000)]
[chromium] Implement position:fixed in compositor thread
https://bugs.webkit.org/show_bug.cgi?id=70103

Reviewed by Adrienne Walker.

Source/WebCore:

Significant contributions to this patch by Alpha Lam and Sami Kyostila.

This patch is the compositor-side change that adds support for
fixed-position layers to be composited layers. Before this patch,
fixed-position elements were positioned only by WebCore (i.e. main
thread when painting), and the compositor did not have enough
knowledge on its own to position it properly. This patch adds the
necessary math and plumbs the necessary layer information so that
the impl thread can properly position fixed-position elements on
its own. This support is necessary for correctness of composited
fixed-position elements, which can greatly help to avoid
repainting container layers when scrolling with a fixed-position
layer.

There also needs to be WebCore-side support for this, which is
addressed in https://bugs.webkit.org/show_bug.cgi?id=78864

Unit tests added to CCLayerTreeHostCommonTest:
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDirectContainer
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithTransformedDirectContainer
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainer
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainerAndTransforms
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleScrollDeltas
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithIntermediateSurfaceAndTransforms
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleIntermediateSurfaces
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithContainerLayerThatHasSurface
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatIsAlsoFixedPositionContainer
  CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatHasNoContainer

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsContainerForFixedPositionLayers):
(WebCore::LayerChromium::isContainerForFixedPositionLayers):
(LayerChromium):
(WebCore::LayerChromium::setFixedToContainerLayerVisibleRect):
(WebCore::LayerChromium::fixedToContainerLayerVisibleRect):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsContainerForFixedPositionLayers):
(WebCore::CCLayerImpl::isContainerForFixedPositionLayers):
(CCLayerImpl):
(WebCore::CCLayerImpl::setFixedToContainerLayerVisibleRect):
(WebCore::CCLayerImpl::fixedToContainerLayerVisibleRect):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationForThisLayer):
(WebCore):
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt exits early too frequently
dpranke@chromium.org [Mon, 11 Jun 2012 21:17:58 +0000 (21:17 +0000)]
nrwt exits early too frequently
https://bugs.webkit.org/show_bug.cgi?id=73843

Reviewed by Ryosuke Niwa.

Change the defaults for new-run-webkit-tests for both
--exit-after-n-failures and --exit-after-n-crashes-or-timeouts
to zero (i.e., we will never exit early by default).

If people want their buildbots to exit early it is their
responsibility to update their buildbot configs appropriately.

Note that we have tests that ensure that these flags work for
non-zero numbers, but we don't have tests that either test the
default or ensure that zero means "run all of the tests". I
think that's okay but can add tests if others disagree.

Also note that it looks like no changes on the build.webkit.org
master.cfg are necessary; all of the bots seem to be using the
RunWebKitTests wrapper which is already setting the flags. There
is a NewRunWebKitTests wrapper, but that looks to be unused; I
will delete that in a separate patch.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for disconnected/excluded from search frames, they are not used by...
weinig@apple.com [Mon, 11 Jun 2012 20:52:14 +0000 (20:52 +0000)]
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

* WebCore.exp.in:
Update export.
* editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/blackberry:

* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):

Source/WebKit/mac:

* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLast large slew of Chromium windows png rebaselines. See http://crbug.com/131829...
ojan@chromium.org [Mon, 11 Jun 2012 20:30:42 +0000 (20:30 +0000)]
Last large slew of Chromium windows png rebaselines. See  crbug.com/131829 for more information.
List of rebaselined files excluded because it's too long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap
commit-queue@webkit.org [Mon, 11 Jun 2012 20:22:00 +0000 (20:22 +0000)]
[chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap
https://bugs.webkit.org/show_bug.cgi?id=88789

Patch by Varun Jain <varunjain@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when a plug-in tries to use the NPRuntime API with JavaScript disabled
andersca@apple.com [Mon, 11 Jun 2012 20:16:58 +0000 (20:16 +0000)]
Crash when a plug-in tries to use the NPRuntime API with JavaScript disabled
https://bugs.webkit.org/show_bug.cgi?id=88797
<rdar://problem/11574844>

Reviewed by Brady Eidson.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::initialize):
Handle the windowNPObjectID being 0.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Handle m_windownPObject being null.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
Return null if JavaScript is disabled.

(WebKit::PluginView::pluginElementNPObject):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] Reset CacheModel before running each test
commit-queue@webkit.org [Mon, 11 Jun 2012 20:16:27 +0000 (20:16 +0000)]
[EFL] [DRT] Reset CacheModel before running each test
https://bugs.webkit.org/show_bug.cgi?id=87534

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Gustavo Noronha Silva.

Reset cache model to default before running each test to fix some
flaky tests on EFL build bots. Also fix case value in setCacheModel.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCacheModel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVGImageCache leaks image data
wangxianzhu@chromium.org [Mon, 11 Jun 2012 20:15:47 +0000 (20:15 +0000)]
SVGImageCache leaks image data
https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:
- CachedResource::removeClient()
- CachedImage::removeClientForRenderer().
It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

* loader/cache/CachedFont.h:
(WebCore::CachedFontClient::resourceClientType): Added 'const'.
* loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
* loader/cache/CachedImage.h:
(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.
* loader/cache/CachedRawResource.h:
(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().
* loader/cache/CachedResource.h:
(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.
* loader/cache/CachedResourceClient.h:
(WebCore::CachedResourceClient::resourceClientType): Added 'const'.
* loader/cache/CachedSVGDocument.h:
(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.
* loader/cache/CachedStyleSheetClient.h:
(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::removeClient):
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::removeClient):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):
* svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

* svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
* svg/as-image/svg-image-leak-cached-data.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Memory leaks in DRT EventSender.cpp
commit-queue@webkit.org [Mon, 11 Jun 2012 19:50:00 +0000 (19:50 +0000)]
[GTK] Memory leaks in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=88774

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Martin Robinson.

Fix a few possible memory leaks in EventSender code.

* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback): Free the event returned by gdk_event_new().
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
commit-queue@webkit.org [Mon, 11 Jun 2012 19:45:20 +0000 (19:45 +0000)]
[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
https://bugs.webkit.org/show_bug.cgi?id=88661

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Dirk Pranke.

Tools:

Pass string length explicitly when creating String object from
non-null-terminated UChar* returned by characters().

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pathToLocalResource):

LayoutTests:

Unskip test cases which rely on pathToLocalResource().

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call shared timer functions directly
pilgrim@chromium.org [Mon, 11 Jun 2012 18:54:52 +0000 (18:54 +0000)]
[Chromium] Call shared timer functions directly
https://bugs.webkit.org/show_bug.cgi?id=88781

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRelative pos. input fields in columns vanish when you start typing in them
commit-queue@webkit.org [Mon, 11 Jun 2012 18:48:47 +0000 (18:48 +0000)]
Relative pos. input fields in columns vanish when you start typing in them
https://bugs.webkit.org/show_bug.cgi?id=76834

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/multicol/multicol-with-child-renderLayer-for-input.html

* page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
Helper function to prepare the UpdateLayerPositionsFlags based on the input parameters.
If didFullRepaint flag is set, then CheckForRepaints flag is removed from the default flags.
Also during a relayout of a subtree, if the RenderLayer of the subtree root is paginated then updatePagination flag is
included in the flags.

(WebCore):
(WebCore::FrameView::layout):
Now uses the helper function updateLayerPositionFlags() to get the final set of UpdateLayerPositionsFlags.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::isPaginated):
(RenderLayer):
isPaginated function is made public so that FrameView class can use it prepare UpdateLayerPositionsFlags.

LayoutTests:

* fast/multicol/multicol-with-child-renderLayer-for-input-expected.html: Added.
* fast/multicol/multicol-with-child-renderLayer-for-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove some dead code in PasteboardChromium
pilgrim@chromium.org [Mon, 11 Jun 2012 18:36:12 +0000 (18:36 +0000)]
[Chromium] Remove some dead code in PasteboardChromium
https://bugs.webkit.org/show_bug.cgi?id=88782

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.
Leftover detritus from bug 88038.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Removing long WebDeviceOrientation constructor
commit-queue@webkit.org [Mon, 11 Jun 2012 18:35:09 +0000 (18:35 +0000)]
[Chromium] Removing long WebDeviceOrientation constructor
https://bugs.webkit.org/show_bug.cgi?id=88779

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Removing the WebDeviceOrientation constructor with nine parameters.
Chromium has been changed to use the default constructor and setter
functions instead (see https://chromiumcodereview.appspot.com/10542025/).

* public/WebDeviceOrientation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in compositing tests
rniwa@webkit.org [Mon, 11 Jun 2012 18:29:22 +0000 (18:29 +0000)]
Use testRunner instead of layoutTestController in compositing tests
https://bugs.webkit.org/show_bug.cgi?id=88766

Reviewed by Tony Chang.

* compositing/:
* compositing/animation/:
* compositing/backface-visibility/:
* compositing/backing/:
* compositing/culling/:
* compositing/geometry/:
* compositing/iframes/:
* compositing/iframes/resources/:
* compositing/images/:
* compositing/layer-creation/:
* compositing/masks/:
* compositing/overflow/:
* compositing/plugins/:
* compositing/reflections/:
* compositing/repaint/:
* compositing/resources/:
* compositing/rtl/:
* compositing/scaling/:
* compositing/tiling/:
* compositing/transitions/:
* compositing/video/:
* compositing/visibility/:
* compositing/webgl/:
* platform/chromium/compositing/:
* platform/chromium/compositing/force-compositing-mode/:
* platform/chromium/compositing/rubberbanding/:
* platform/mac/compositing/canvas/:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLarge slew of Chromium windows png rebaselines. See http://crbug.com/131829 for more...
ojan@chromium.org [Mon, 11 Jun 2012 18:26:01 +0000 (18:26 +0000)]
Large slew of Chromium windows png rebaselines. See crbug.com/131829 for more information.

List of rebaselined files excluded because it's too long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests
rniwa@webkit.org [Mon, 11 Jun 2012 18:23:57 +0000 (18:23 +0000)]
Use testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests
https://bugs.webkit.org/show_bug.cgi?id=88769

Reviewed by Tony Chang.

* css1/units/zero-duration-without-units.html:
* css3/calc/:
* css3/filters/:
* css3/filters/custom/:
* css3/filters/resources/:
* css3/filters/script-tests/:
* css3/flexbox/:
* css3/font-feature-settings-rendering.html:
* css3/images/cross-fade-invalidation.html:
* css3/images/optimize-contrast-canvas.html:
* css3/images/optimize-contrast-image.html:
* css3/khtml-background-size-0x0-bmp.html:
* css3/parsing-css3-nthchild.html:
* css3/style-zoomed-image.html:
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
* css3/zoom-coords.xhtml:
* platform/win/css2.1/resources/run-webkit-tests-epilogue.html:
* platform/win/css2.1/resources/run-webkit-tests-prologue.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Provide access to the WebPlugin created by the helper plugin widget
commit-queue@webkit.org [Mon, 11 Jun 2012 18:14:15 +0000 (18:14 +0000)]
[chromium] Provide access to the WebPlugin created by the helper plugin widget
https://bugs.webkit.org/show_bug.cgi?id=88028

Patch by David Dorwin <ddorwin@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Source/WebKit/chromium:

A WebPlugin is created when the document created by createHelperPlugin() is laid out.
Expose it so the embedder can interact with the plugin instance.

* public/WebHelperPlugin.h:
(WebKit):
(WebHelperPlugin):
* public/WebMediaPlayerClient.h:
(WebKit):
* public/WebPlugin.h:
(WebKit::WebPlugin::isPlaceholder):
(WebPlugin):
* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit):
(WebKit::WebHelperPluginImpl::getPlugin):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::close):
* src/WebHelperPluginImpl.h:
(WebKit):
(WebHelperPluginImpl):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebPagePopupImpl.cpp:

Tools:

Added isPlaceholder() to WebPlugin.

* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::isPlaceholder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
peter@chromium.org [Mon, 11 Jun 2012 18:13:57 +0000 (18:13 +0000)]
[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
https://bugs.webkit.org/show_bug.cgi?id=88775

Reviewed by Adam Barth.

For Chrome on Android, use the width of the scrollbar down arrow instead
of the scrollbar's width for determining the arrow padding to apply for
menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).

Furthermore, change the default active selection background color to be
equal to the tap highlighting color.

These changes should be covered by existing layout tests.

* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.
* rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding
    and platformActiveSelectionBackgroundColor methods, and add a static
    static RGBA32 color for the default active selection bg color.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to
    the scrollbar thickness, not changing behavior for non-Android.
(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead
    of polling the scrollbar thickness, call menuListArrowPadding().
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorebaseline from garden-o-matic leaves N processes each time it is run
tony@chromium.org [Mon, 11 Jun 2012 17:39:41 +0000 (17:39 +0000)]
rebaseline from garden-o-matic leaves N processes each time it is run
https://bugs.webkit.org/show_bug.cgi?id=88586

Reviewed by Dirk Pranke.

This appears to only be a problem on python 2.7. Maybe a bug causing
pools to not be garbage collected?

* Scripts/webkitpy/common/system/executive.py:
(Executive.run_in_parallel): close() and join() the process pool.
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_in_parallel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in animations tests
rniwa@webkit.org [Mon, 11 Jun 2012 17:22:07 +0000 (17:22 +0000)]
Use testRunner instead of layoutTestController in animations tests
https://bugs.webkit.org/show_bug.cgi?id=88757

Reviewed by Tony Chang.

* animations/3d/change-transform-in-end-event.html:
* animations/3d/replace-filling-transform.html:
* animations/3d/state-at-end-event-transform.html:
* animations/3d/transform-origin-vs-functions.html:
* animations/animation-add-events-in-handler.html:
* animations/animation-border-overflow.html:
* animations/animation-controller-drt-api.html:
* animations/animation-direction-reverse-fill-mode-hardware.html:
* animations/animation-direction-reverse-fill-mode.html:
* animations/animation-drt-api-multiple-keyframes.html:
* animations/animation-drt-api.html:
* animations/animation-end-event-destroy-renderer.html:
* animations/animation-end-event-short-iterations.html:
* animations/animation-hit-test-transform.html:
* animations/animation-hit-test.html:
* animations/animation-iteration-event-destroy-renderer.html:
* animations/animation-matrix-negative-scale-unmatrix.html:
* animations/animation-on-inline-crash.html:
* animations/animation-shorthand-overriding.html:
* animations/animation-shorthand-removed.html:
* animations/animation-shorthand.html:
* animations/animation-start-event-destroy-renderer.html:
* animations/animation-welcome-safari.html:
* animations/body-removal-crash.html:
* animations/change-keyframes-name.html:
* animations/change-transform-style-during-animation.html:
* animations/combo-transform-translate+scale.html:
* animations/empty-keyframes.html:
* animations/fill-mode-forwards.html:
* animations/fill-mode-iteration-count-non-integer.html:
* animations/fill-mode-missing-from-to-keyframes.html:
* animations/fill-mode-multiple-keyframes.html:
* animations/fill-mode-removed.html:
* animations/fill-mode-reverse.html:
* animations/fill-mode-transform.html:
* animations/fill-mode.html:
* animations/fill-unset-properties.html:
* animations/font-size-using-ems.html-disabled:
* animations/import-crash.html:
* animations/keyframe-timing-functions-transform.html:
* animations/keyframe-timing-functions2.html:
* animations/keyframes-iteration-count-non-integer.html:
* animations/longhand-timing-function.html:
* animations/missing-from-to-transforms.html:
* animations/missing-from-to.html:
* animations/pause-crash.html:
* animations/resources/animation-test-helpers.js:
(checkExpectedValue):
(endTest):
* animations/state-at-end-event.html:
* animations/suspend-resume-animation-events.html:
* animations/suspend-transform-animation.html:
* animations/transition-and-animation-3.html:
* animations/unanimated-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd css3-images image-resolution (dppx only)
commit-queue@webkit.org [Mon, 11 Jun 2012 17:19:26 +0000 (17:19 +0000)]
Add css3-images image-resolution (dppx only)
https://bugs.webkit.org/show_bug.cgi?id=85332

Patch by David Barr <davidbarr@chromium.org> on 2012-06-11
Reviewed by Tony Chang.

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution

Source/WebCore:

Test: fast/css/image-resolution.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::detectNumberToken):
* css/CSSParser.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
* css/CSSPrimitiveValue.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StyleBuilder.cpp:
(WebCore):
(ApplyPropertyImageResolution):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyImageResolution::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageDimensionsChanged):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

LayoutTests:

* fast/css/image-resolution/image-resolution-expected.txt: Added.
* fast/css/image-resolution/image-resolution.html: Added.
* platform/chromium/TestExpectations: Skip tests until image-resolution implementation lands.
* platform/efl/TestExpectations: Skip tests until image-resolution implementation lands.
* platform/gtk/TestExpectations: Skip tests until image-resolution implementation lands.
* platform/mac/TestExpectations: Skip tests until image-resolution implementation lands.
* platform/qt/TestExpectations: Skip tests until image-resolution implementation lands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake media (<video> and <audio>) slide draggable again https://bugs.webkit.org/show_b...
tonikitoo@webkit.org [Mon, 11 Jun 2012 16:57:27 +0000 (16:57 +0000)]
Make media (<video> and <audio>) slide draggable again https://bugs.webkit.org/show_bug.cgi?id=88742 PR #158199

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

First check if the element is a range type then gets its
shadow DOM ancestor.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::shouldConvertTouchToMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
danakj@chromium.org [Mon, 11 Jun 2012 16:49:22 +0000 (16:49 +0000)]
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck issues.
carlosgc@webkit.org [Mon, 11 Jun 2012 15:31:19 +0000 (15:31 +0000)]
Unreviewed. Fix make distcheck issues.

.:

* GNUmakefile.am: Initialize jscore nosource variables.

Source/JavaScriptCore:

* GNUmakefile.list.am: Remove non existent header file.

Source/WebCore:

* GNUmakefile.am: Add idl files in editing dir to EXTRA_DIST.
* GNUmakefile.list.am: Add missing header file.

Source/WTF:

* GNUmakefile.list.am: Add missing header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Rebaseline more SVG tests on Windows.
dominicc@chromium.org [Mon, 11 Jun 2012 14:59:42 +0000 (14:59 +0000)]
[Chromium] Unreviewed: Rebaseline more SVG tests on Windows.

* platform/chromium-linux-x86/svg/batik/filters/filterRegions-expected.png: Removed.
* platform/chromium-win-vista/svg/batik/paints/gradientLimit-expected.png: Added.
* platform/chromium-win-xp/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
* platform/chromium-win-xp/svg/batik/text/smallFonts-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png:
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Rebaselines for svg/as-background-image tests on Windows.
dominicc@chromium.org [Mon, 11 Jun 2012 14:37:20 +0000 (14:37 +0000)]
[Chromium] Unreviewed: Rebaselines for svg/as-background-image tests on Windows.

* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReverted r119940 because it caused multiple media tests to fail on Lion.
mitz@apple.com [Mon, 11 Jun 2012 14:33:03 +0000 (14:33 +0000)]
Reverted r119940 because it caused multiple media tests to fail on Lion.

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore):
(WebCore::HTMLMediaElement::userCancelledLoad):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

* http/tests/media/video-src-invalid-error-expected.txt: Removed.
* http/tests/media/video-src-invalid-error.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE...
zoltan@webkit.org [Mon, 11 Jun 2012 14:05:59 +0000 (14:05 +0000)]
Source/WebCore: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)$
https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

No new tests were needed.

* Target.pri:
* WebCore.pri:
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):

Tools: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

* qmake/config.tests/libwebp/libwebp.cpp: Added.
(main):
* qmake/config.tests/libwebp/libwebp.pro: Added.
* qmake/sync.profile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r119962. Four inspector/debugger tests still fail after they...
ossy@webkit.org [Mon, 11 Jun 2012 14:02:21 +0000 (14:02 +0000)]
[Qt] Gardening after r119962. Four inspector/debugger tests still fail after they have been re-enabled.
https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd QML api for setting device width and height
kenneth@webkit.org [Mon, 11 Jun 2012 13:53:11 +0000 (13:53 +0000)]
Add QML api for setting device width and height
https://bugs.webkit.org/show_bug.cgi?id=88777

Reviewed by Simon Hausmann.

Source/WebCore:

Change the default values for deviceWidth/Height to be 0 (unset). The
original values were introduced by Qt and 0 makes it possible to
detect if a value has never been set and therefore fall back.

Only Qt depended on the former values.

* page/Settings.cpp:
(WebCore::Settings::Settings):

Source/WebKit2:

Add the new API and set the default values to 0 (unset). The
current values were introduced by Qt and only Qt depends on them.

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::deviceWidth):
(QQuickWebViewExperimental::setDeviceWidth):
(QQuickWebViewExperimental::deviceHeight):
(QQuickWebViewExperimental::setDeviceHeight):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::viewportItemSizeChanged):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Should call frameDetached() in WebPagePopupImpl::close()
tkent@chromium.org [Mon, 11 Jun 2012 13:20:47 +0000 (13:20 +0000)]
[Chromium] Should call frameDetached() in WebPagePopupImpl::close()
https://bugs.webkit.org/show_bug.cgi?id=88754

Reviewed by Adam Barth.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Rebaselines and updated expectations for media tests
dominicc@chromium.org [Mon, 11 Jun 2012 12:49:31 +0000 (12:49 +0000)]
[Chromium] Unreviewed: Rebaselines and updated expectations for media tests

Pixel differences are due to antialiasing and different rounded
corners on the media progress bar. The difference is not
noticeable.

* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-layout-direction-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/media-controls-clone-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-layer-crash-expected.png:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium-win/media/video-transformed-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Mark track-cue-rendering-inner-timestamps.html failing on...
dominicc@chromium.org [Mon, 11 Jun 2012 12:19:05 +0000 (12:19 +0000)]
[Chromium] Unreviewed: Mark track-cue-rendering-inner-timestamps.html failing on Vista

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skipping http/tests/security/mixedContent/filesystem-url-in-iframe.html
commit-queue@webkit.org [Mon, 11 Jun 2012 11:27:42 +0000 (11:27 +0000)]
[Qt] Skipping http/tests/security/mixedContent/filesystem-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88770

ENABLE(FILE_SYSTEM) is disabled; this test should be skipped until
that feature is enabled. Moving it up into the proper section of the
Skipped file to make sure it's enabled if and when the feature makes
it into the port.

Patch by Mike West <mkwst@chromium.org> on 2012-06-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Add missing includes to fix the build
ossy@webkit.org [Mon, 11 Jun 2012 10:29:09 +0000 (10:29 +0000)]
[Qt][Win] Add missing includes to fix the build
https://bugs.webkit.org/show_bug.cgi?id=88538

Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/IconDatabaseClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
ossy@webkit.org [Mon, 11 Jun 2012 10:24:32 +0000 (10:24 +0000)]
[Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
https://bugs.webkit.org/show_bug.cgi?id=88310

Reviewed by Simon Hausmann.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getPropertyNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Compute and set cache capacities using the current CacheModel
hausmann@webkit.org [Mon, 11 Jun 2012 09:49:59 +0000 (09:49 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Unreviewed build fix.

No new tests added as this is a build fix.

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-11

* platform/qt/FileSystemQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRect-based hittesting doesn't work in tables.
commit-queue@webkit.org [Mon, 11 Jun 2012 09:38:48 +0000 (09:38 +0000)]
Rect-based hittesting doesn't work in tables.
https://bugs.webkit.org/show_bug.cgi?id=86605

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

The existing code only performed a single binary lookup for the central
hit-test point. This meant area-based hit-testing did not work across
table-cell borders. All cells spanned by a hit-test area must be hit
tested.

This patch introduces three auxilary functions to help calculate rows
and columns spanned by an rect. These are intended to also be used by
repaint logic in a later patch.

For point-based hit-testing we maintain unchanged behavior and still
only hit test a single column in a single row.

Test: fast/dom/nodesFromRect-table.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(RenderTableSection):

LayoutTests:

Test nodesFromRect on tables.

* fast/dom/nodesFromRect-table-expected.txt: Added.
* fast/dom/nodesFromRect-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding a flag to show fullscreen media controls in chromium
commit-queue@webkit.org [Mon, 11 Jun 2012 09:26:31 +0000 (09:26 +0000)]
Adding a flag to show fullscreen media controls in chromium
https://bugs.webkit.org/show_bug.cgi?id=88266

Patch by Min Qin <qinmin@google.com> on 2012-06-11
Reviewed by Adam Barth.

Source/WebCore:

The default chromium shadow DOM for media element does not contain fullscreen button.
This change adds a flag to display the fullscreen button.
It will be used by the android port.

No new tests needed. We will use the same layout tests as desktop chromium.
However, new test result expections will be added later.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::reportedError):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):

Source/WebKit/chromium:

Adding a flag to the gyp file so that we can enable fullscreen media control

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Compute and set cache capacities using the current CacheModel
commit-queue@webkit.org [Mon, 11 Jun 2012 09:17:07 +0000 (09:17 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests needed / applicable (using operating system functionality).

Added method to read free file system space for a path to support cache model
implementation in Qt WK 2.

* platform/FileSystem.h:
(WebCore):
* platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath): Added for Qt ports.
(WebCore):

Source/WebKit2:

Added implementation of cache model for Qt WK 2 port including supporting
functionality such as WebProcess creation parameters and default values
for disk cache directories.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::physicalMemorySizeInBytes):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening, skip new failing tests.
ossy@webkit.org [Mon, 11 Jun 2012 09:00:40 +0000 (09:00 +0000)]
[Qt] Gardening, skip new failing tests.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-06-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
commit-queue@webkit.org [Mon, 11 Jun 2012 08:26:10 +0000 (08:26 +0000)]
[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
https://bugs.webkit.org/show_bug.cgi?id=88751

Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Web Inspector: implement breaking from native callback
commit-queue@webkit.org [Mon, 11 Jun 2012 08:24:02 +0000 (08:24 +0000)]
[JSC] Web Inspector: implement breaking from native callback
https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
* bindings/js/ScriptDebugServer.h:
(WebCore::supportsNativeBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Remove expectations for passing tests
dominicc@chromium.org [Mon, 11 Jun 2012 08:23:01 +0000 (08:23 +0000)]
[Chromium] Unreviewed: Remove expectations for passing tests

The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpellchecker crash in async scenario.
morrita@google.com [Mon, 11 Jun 2012 08:17:14 +0000 (08:17 +0000)]
Spellchecker crash in async scenario.
https://bugs.webkit.org/show_bug.cgi?id=88617

Reviewed by Tony Chang.

SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.

No new tests. It's hard to reproduce this.

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::invokeRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
commit-queue@webkit.org [Mon, 11 Jun 2012 08:11:59 +0000 (08:11 +0000)]
[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88752

Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Extract CursorMap from WidgetEfl.cpp.
ryuan.choi@samsung.com [Mon, 11 Jun 2012 07:41:19 +0000 (07:41 +0000)]
[EFL] Extract CursorMap from WidgetEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=88633

Reviewed by Ryosuke Niwa.

In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.

No new tests, refactoring only.

* platform/efl/EflScreenUtilities.cpp:
(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):
* platform/efl/EflScreenUtilities.h:
(WebCore):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119955.
commit-queue@webkit.org [Mon, 11 Jun 2012 06:58:40 +0000 (06:58 +0000)]
Unreviewed, rolling out r119955.
http://trac.webkit.org/changeset/119955
https://bugs.webkit.org/show_bug.cgi?id=88758

Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-10

Source/WebCore:

* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):
* WebView/WebFramePrivate.h:

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUsing BlobBuilder should show a deprecation warning message (if it is enabled)
kinuko@chromium.org [Mon, 11 Jun 2012 06:23:59 +0000 (06:23 +0000)]
Using BlobBuilder should show a deprecation warning message (if it is enabled)
https://bugs.webkit.org/show_bug.cgi?id=88644

Reviewed by Jian Li.

Source/WebCore:

Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.

Tests: fast/files/blob-builder-crash.html

* fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::WebKitBlobBuilder::create):
* fileapi/WebKitBlobBuilder.h:
(WebCore):
(WebKitBlobBuilder):
* fileapi/WebKitBlobBuilder.idl:

LayoutTests:

* fast/files/blob-builder-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for disconnected/excluded from search frames, they are not used by...
weinig@apple.com [Mon, 11 Jun 2012 06:11:39 +0000 (06:11 +0000)]
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

* WebCore.exp.in:
Update export.
* editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/mac:

* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Quota related code out of DOMWindow and into the quota/ folder
kinuko@chromium.org [Mon, 11 Jun 2012 06:03:31 +0000 (06:03 +0000)]
Move Quota related code out of DOMWindow and into the quota/ folder
https://bugs.webkit.org/show_bug.cgi?id=88512

Patch by Kinuko Yasuda <kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.

No new tests: no visible changes.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* Modules/quota/DOMWindowQuota.cpp: Added.
* Modules/quota/DOMWindowQuota.h: Added.
* Modules/quota/DOMWindowQuota.idl: Added.
* Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
* Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
* Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
* Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
* Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
* Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
* Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
* Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
* Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Add expectations for svg-as-background-6.html
dominicc@chromium.org [Mon, 11 Jun 2012 05:47:38 +0000 (05:47 +0000)]
[Chromium] Unreviewed: Add expectations for svg-as-background-6.html

Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale...
dominicc@chromium.org [Mon, 11 Jun 2012 05:35:36 +0000 (05:35 +0000)]
[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale on Linux, Win

These differ in antialiasing only, where there are already
platform differences antialiasing.

* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Update
dominicc@chromium.org [Mon, 11 Jun 2012 04:45:21 +0000 (04:45 +0000)]
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Update
dominicc@chromium.org [Mon, 11 Jun 2012 04:38:23 +0000 (04:38 +0000)]
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAn inheritance of '-webkit-user-modify' does not stop at shadow boundary.
hayato@chromium.org [Mon, 11 Jun 2012 03:58:56 +0000 (03:58 +0000)]
An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=88514

Reviewed by Ryosuke Niwa.

Source/WebCore:

In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough.  We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.

Test: fast/dom/shadow/user-modify-inheritance.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):
* css/StyleResolver.h:
(StyleResolver):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritFrom):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
* fast/dom/shadow/user-modify-inheritance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Introduce Decimal behind the InputNumber type
yosin@chromium.org [Mon, 11 Jun 2012 02:30:39 +0000 (02:30 +0000)]
[Forms] Introduce Decimal behind the InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88383

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.

Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.

Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.

Test: fast/forms/range/range-value-rounding.html

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.
* html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/InputType.cpp:
(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.
* html/InputType.h:
(InputType): Removed parseToNumberWIthDecimaplPlaces.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed for Decimal type.
* html/NumberInputType.cpp:
(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.
* html/NumberInputType.h:
(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble):  Changed to real implementation.
* html/StepRange.h:
(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange): Changed for Decimal type.
* html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Changed for Decimal type.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.
* html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed for Decimal type.

LayoutTests:

* fast/forms/range/range-value-rounding-expected.txt: Added.
* fast/forms/range/range-value-rounding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Possible to clobber httponly cookie.
commit-queue@webkit.org [Mon, 11 Jun 2012 02:16:19 +0000 (02:16 +0000)]
[BlackBerry] Possible to clobber httponly cookie.
https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

* platform/blackberry/CookieJarBlackBerry.cpp:
(WebCore::setCookies):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
* platform/blackberry/CookieMap.h:
(CookieMap):

LayoutTests:

* http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
* http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
* platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose layoutTestController as testRunner
rniwa@webkit.org [Sun, 10 Jun 2012 21:36:29 +0000 (21:36 +0000)]
Expose layoutTestController as testRunner
https://bugs.webkit.org/show_bug.cgi?id=88210

Reviewed by Darin Adler.

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::makeWindowObject):

LayoutTests:

Add a test for testRunner object.

* fast/harness/testrunner-object-expected.txt: Added.
* fast/harness/testrunner-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccess control allow lists starting with a comma are parsed incorrectly (CORS)
commit-queue@webkit.org [Sun, 10 Jun 2012 20:18:36 +0000 (20:18 +0000)]
Access control allow lists starting with a comma are parsed incorrectly (CORS)
https://bugs.webkit.org/show_bug.cgi?id=88461

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.

Source/WebCore:

The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.

Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html

* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):

LayoutTests:

* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
* http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoving mixed content tests' dependency on WebKitBlobBuilder:
commit-queue@webkit.org [Sun, 10 Jun 2012 19:48:56 +0000 (19:48 +0000)]
Removing mixed content tests' dependency on WebKitBlobBuilder:
https://bugs.webkit.org/show_bug.cgi?id=88736

http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.

It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).

Patch by Mike West <mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.

* http/tests/security/mixedContent/blob-url-in-iframe.html:
* http/tests/security/mixedContent/filesystem-url-in-iframe.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome additional tweaks to keep TreeShared code simple/clean
darin@apple.com [Sun, 10 Jun 2012 19:19:19 +0000 (19:19 +0000)]
Some additional tweaks to keep TreeShared code simple/clean
https://bugs.webkit.org/show_bug.cgi?id=88738

Reviewed by Adam Barth.

* platform/TreeShared.h: Make constructor and destructor both protected.
It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
commit-queue@webkit.org [Sun, 10 Jun 2012 18:44:05 +0000 (18:44 +0000)]
[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88725

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10
Reviewed by Eric Carlson.

* media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values
so that the test passes for EFL and GTK ports.
* platform/efl/TestExpectations: Unskip test.
* platform/gtk/TestExpectations: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip fast/dom/frame-loading-via-document-write.html
commit-queue@webkit.org [Sun, 10 Jun 2012 18:41:53 +0000 (18:41 +0000)]
[EFL] Skip fast/dom/frame-loading-via-document-write.html
https://bugs.webkit.org/show_bug.cgi?id=88737

Unreviewed EFL gardening. Skipping test that is flaky after r119788.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Setting invalid media "src" does not cause "error" event
jer.noble@apple.com [Sun, 10 Jun 2012 18:18:44 +0000 (18:18 +0000)]
REGRESSION: Setting invalid media "src" does not cause "error" event
https://bugs.webkit.org/show_bug.cgi?id=88423

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/video-src-invalid-error.html

Two problems here.  When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled.  It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.

Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.

Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):
* html/HTMLMediaElement.h:

And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

* http/tests/media/video-src-invalid-error-expected.txt: Added.
* http/tests/media/video-src-invalid-error.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd logging functions to MediaPlayerPrivateQTKit.
jer.noble@apple.com [Sun, 10 Jun 2012 18:14:40 +0000 (18:14 +0000)]
Add logging functions to MediaPlayerPrivateQTKit.
https://bugs.webkit.org/show_bug.cgi?id=88425

Reviewed by Eric Carlson.

No new tests; adds logging functions to aide debugging.

MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.

Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):

Add LOG messages for each of the following functions:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore should use a single definition of an invalid media time.
jer.noble@apple.com [Sun, 10 Jun 2012 18:09:52 +0000 (18:09 +0000)]
WebCore should use a single definition of an invalid media time.
https://bugs.webkit.org/show_bug.cgi?id=88572

Reviewed by Eric Carlson.

No new tests; no change in functionality, so covered by existing tests.

Add a new, universal definition for an invalid media time:
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::invalidTime):

Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unneeded callRemovedLastRef function from TreeShared refactoring
darin@apple.com [Sun, 10 Jun 2012 17:15:55 +0000 (17:15 +0000)]
Remove unneeded callRemovedLastRef function from TreeShared refactoring
https://bugs.webkit.org/show_bug.cgi?id=88653

Reviewed by Sam Weinig.

.:

* Source/autotools/symbols.filter: Filter removedLastRef instead of
callRemovedLastRef.

Source/WebCore:

* WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.

* dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer
needed and also had a bad cast in it.

* dom/Document.h: Made removedLastRef private and non-virtual and made Node
a friend so it can call the private function.

* dom/Node.cpp:
(WebCore::Node::removedLastRef): Moved here. This should not be an inline
function. Added comments explaining why it should not be inlined. Also added
explicit code to call to Document::removedLastRef, and added a comment why
that's the right thing to do here.
* dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the
removedLastRef function non-virtual and removed it from the header file.
Updated TreeShared using statements. Made the TreeShared template class a
friend so it can call the private removedLastRef.

* html/HTMLFormControlElement.h: Updated TreeShared using statements to specify
Node instead, which accomplishes the same thing.
* html/HTMLObjectElement.h: Ditto.

* platform/TreeShared.h: Made TreeShared take two template arguments for the
node type and the parent node type. Removed the callRemovedLastRef functions and
the extra forward declarations it required. Removed the private unused
removedLastRef function; not sure why it was left in here at all.
(WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
(WebCore::TreeShared::setParent): Use ParentNodeType.
(WebCore::TreeShared::parent): Ditto.
(WebCore::adopted): Updated to have both template arguments.

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
this. Moved the body out of the header and added a comment explaining why the
function should not be inlined.
* svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and
private. Made TreeShared a friend so it can call the private removedLastRef.
Updated TreeShared using statements.

Source/WebKit2:

* win/WebKit2.def: Export removedLastRef instead of callRemovedLastRef.
* win/WebKit2CFLite.def: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating a few animations tests baselines,
zandobersek@gmail.com [Sun, 10 Jun 2012 16:54:03 +0000 (16:54 +0000)]
Unreviewed GTK gardening. Updating a few animations tests baselines,
adding test expectations for one FileSystem test.

* platform/gtk/TestExpectations:
* platform/gtk/animations/3d/change-transform-in-end-event-expected.txt:
* platform/gtk/animations/3d/matrix-transform-type-animation-expected.txt: Added.
* platform/gtk/animations/3d/state-at-end-event-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTemporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the...
mitz@apple.com [Sun, 10 Jun 2012 16:33:01 +0000 (16:33 +0000)]
Temporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the Mac skip
list. <http://webkit.org/b/88736> tracks moving this test off of the legacy
WebKitBlobBuilder API.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip...
mitz@apple.com [Sun, 10 Jun 2012 16:14:50 +0000 (16:14 +0000)]
Added http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip list,
because FILE_SYSTEM is not enabled.

Part of: http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html are failing
<http://webkit.org/b/88736>

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] 2 fast/multicol/span tests are flaky
commit-queue@webkit.org [Sun, 10 Jun 2012 16:14:12 +0000 (16:14 +0000)]
[EFL] 2 fast/multicol/span tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=88734

Unreviewed EFL gardening. Move to TestExpectations 2 tests that
are flaky on the bot.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago* WebCore.exp.in: Re-sorted and alphabetized the file.
darin@apple.com [Sun, 10 Jun 2012 15:37:01 +0000 (15:37 +0000)]
* WebCore.exp.in: Re-sorted and alphabetized the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
commit-queue@webkit.org [Sun, 10 Jun 2012 15:32:37 +0000 (15:32 +0000)]
[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
https://bugs.webkit.org/show_bug.cgi?id=88728

Unreviewed gardening. Skip new test added in r119911 which fails for both
GTK and EFL ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Several test cases can be unskipped
commit-queue@webkit.org [Sun, 10 Jun 2012 15:29:44 +0000 (15:29 +0000)]
[EFL] Several test cases can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=88731

Unreviewed EFL gardening. Unskip a few tests that are passing after
r118618 was rolled out.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
commit-queue@webkit.org [Sun, 10 Jun 2012 14:53:44 +0000 (14:53 +0000)]
[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
https://bugs.webkit.org/show_bug.cgi?id=88730

Unreviewed EFL gardening. Skip a few tests causing flakiness.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
ryuan.choi@samsung.com [Sun, 10 Jun 2012 14:21:31 +0000 (14:21 +0000)]
[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
https://bugs.webkit.org/show_bug.cgi?id=84124

Reviewed by Chang Shu.

Modify ewk_view and add ewk_context to provide a platform-depedent WebKit2
API.
This patch provides the minimum to support MiniBrowser.

* PlatformEfl.cmake: add ewk_context.cpp.
* UIProcess/API/efl/EWebKit2.h: Added.
* UIProcess/API/efl/ewk_context.cpp: Added.
(_Ewk_Context):
(createDefaultWebContext):
(ewk_context_WKContext_get):
(ewk_context_default_get):
* UIProcess/API/efl/ewk_context.h: Added.
* UIProcess/API/efl/ewk_context_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_add):
(ewk_view_uri_set):
(ewk_view_uri_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
kbalazs@webkit.org [Sun, 10 Jun 2012 13:44:32 +0000 (13:44 +0000)]
[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=88308

Reviewed by Simon Hausmann.

No new tests, just a build fix.

Use ownerWindow() from page client. It has been
introduced for x11 plugins to solve exactly the
same problem.

* plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.
paroga@webkit.org [Sun, 10 Jun 2012 12:49:32 +0000 (12:49 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.

* runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::clearCodeVirtual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r119844.
paroga@webkit.org [Sun, 10 Jun 2012 12:25:57 +0000 (12:25 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r119844.

* runtime/Executable.h:
(ExecutableBase):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix building ImageQt.cpp
kbalazs@webkit.org [Sun, 10 Jun 2012 12:09:37 +0000 (12:09 +0000)]
[Qt][Win] Fix building ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=88306

Reviewed by Simon Hausmann.

No new tests, this is just a build fix.

* platform/graphics/qt/ImageQt.cpp:
(WebCore):
(WebCore::BitmapImage::create):
Adapt to the "API" changes in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
commit-queue@webkit.org [Sun, 10 Jun 2012 11:43:40 +0000 (11:43 +0000)]
[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
https://bugs.webkit.org/show_bug.cgi?id=88726

Unreviewed gardening. Skip test added in r119907 for GTK and EFL ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WebGL mark draws for compositing even if the draw count is zero
commit-queue@webkit.org [Sun, 10 Jun 2012 06:36:27 +0000 (06:36 +0000)]
Make WebGL mark draws for compositing even if the draw count is zero
https://bugs.webkit.org/show_bug.cgi?id=88718

Patch by Gregg Tavares <gman@google.com> on 2012-06-09
Reviewed by Kenneth Russell.

No new tests as no new functionality.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove JavaScriptCore dependencies from gyp
dominicc@chromium.org [Sun, 10 Jun 2012 06:31:14 +0000 (06:31 +0000)]
[Chromium] Remove JavaScriptCore dependencies from gyp
https://bugs.webkit.org/show_bug.cgi?id=88510

Reviewed by Adam Barth.

Chromium doesn't support JSC any more and there doesn't seem to be
a strong interest in using GYP as the common build system in other
ports.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp: WebCore still depends on YARR interpreter.
* JavaScriptCore.gypi: Only include YARR source.
* gyp/JavaScriptCore.gyp: Removed.
* gyp/gtk.gyp: Removed.

Source/WebCore:

No new functionality => No new tests.

* gyp/WebCore.gyp: Removed.
* gyp/copy-forwarding-and-icu-headers.sh: Removed.
* gyp/copy-inspector-resources.sh: Removed.
* gyp/generate-derived-sources.sh: Removed.
* gyp/generate-webcore-export-file-generator.sh: Removed.
* gyp/gtk.gyp: Removed.
* gyp/run-if-exists.sh: Removed.
* gyp/streamline-inspector-source.sh: Removed.
* gyp/update-info-plist.sh: Removed.

Source/WTF:

* WTF.gyp/WTF.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* Scripts/generate-project-files: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove a Chromium test expectation for the test that has been rolled out in r119918.
rniwa@webkit.org [Sun, 10 Jun 2012 02:45:59 +0000 (02:45 +0000)]
Remove a Chromium test expectation for the test that has been rolled out in r119918.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor and improve code style in TextResourceDecoder to prepare for buffering impro...
darin@apple.com [Sun, 10 Jun 2012 01:08:27 +0000 (01:08 +0000)]
Refactor and improve code style in TextResourceDecoder to prepare for buffering improvement
https://bugs.webkit.org/show_bug.cgi?id=88566

Reviewed by Alexey Proskuryakov.

* loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual): Added helper function to make comparing against sequences of bytes
easier to read at the call site.
(WebCore::KanjiCode::judge): Changed to use bytesEqual in a few places, merged multiple if
statements, got rid of else after goto.
(WebCore::TextResourceDecoder::checkForCSSCharset): Changed to use early return instead of
nesting the whole function. Changed to use bytesEqual.
(WebCore::skipComment): Changed to use early return for more cases. Changed to use bytesEqual.
(WebCore::TextResourceDecoder::checkForHeadCharset): Changed to use bytesEqual.
(WebCore::TextResourceDecoder::decode): Changed to use emptyString() instead of "", since
the former is more efficient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119919 268f45cc-cd09-0410-ab3c-d52691b4dbfc