WebKit-https.git
9 years ago2011-02-22 Chang Shu <cshu@webkit.org>
chang.shu@nokia.com [Wed, 23 Feb 2011 01:37:26 +0000 (01:37 +0000)]
2011-02-22  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] editing/deleting/5408255.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54964

        Move WebCore resource file to QtWebKit since they are referred in WebKit.

        * QtWebKit.pro:

2011-02-22  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] editing/deleting/5408255.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54964

        Move WebCore resource file to QtWebKit since they are referred in WebKit.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix it Windows-style.
beidson@apple.com [Wed, 23 Feb 2011 01:25:56 +0000 (01:25 +0000)]
Fix it Windows-style.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 23 Feb 2011 01:21:13 +0000 (01:21 +0000)]
2011-02-22  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update to catch up r79359.

        * platform/chromium-linux/media/audio-repaint-expected.checksum:
        * platform/chromium-linux/media/audio-repaint-expected.png:
        * platform/chromium-linux/media/audio-repaint-expected.txt: Removed.
        * platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
        * platform/chromium-mac/media/audio-repaint-expected.checksum:
        * platform/chromium-mac/media/audio-repaint-expected.png:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.checksum:
        * platform/chromium-win/media/audio-repaint-expected.png:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove no-longer-necessary test expectation (LINUX video-cancel-load)
atwilson@chromium.org [Wed, 23 Feb 2011 00:58:41 +0000 (00:58 +0000)]
Remove no-longer-necessary test expectation (LINUX video-cancel-load)
https://bugs.webkit.org/show_bug.cgi?id=55003

Patch by Ami Fischman <fischman@chromium.org> on 2011-02-22
Reviewed by Peter Kasting.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert "Unreviewed rebaselines for Chromium." because the baselines were put in the...
atwilson@chromium.org [Wed, 23 Feb 2011 00:48:11 +0000 (00:48 +0000)]
Revert "Unreviewed rebaselines for Chromium." because the baselines were put in the wrong directory.

This partially reverts r79034 (we keep test_expectations the same as it is currently to avoid breaking the canaries).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 23 Feb 2011 00:42:06 +0000 (00:42 +0000)]
2011-02-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Rename WebProcess::shutdownIfPossible to WebProcess::terminateIfPossible
        https://bugs.webkit.org/show_bug.cgi?id=55008

        * WebProcess/Downloads/DownloadManager.cpp:
        (WebKit::DownloadManager::downloadFinished):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::removeWebPage):
        (WebKit::WebProcess::terminateIfPossible):
        (WebKit::WebProcess::getSitesWithPluginData):
        * WebProcess/WebProcess.h:
        * WebProcess/gtk/WebProcessGtk.cpp:
        (WebKit::WebProcess::platformTerminate):
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformTerminate):
        * WebProcess/qt/WebProcessQt.cpp:
        (WebKit::WebProcess::platformTerminate):
        * WebProcess/win/WebProcessWin.cpp:
        (WebKit::WebProcess::platformTerminate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build-fix attempt.
beidson@apple.com [Wed, 23 Feb 2011 00:30:02 +0000 (00:30 +0000)]
Windows build-fix attempt.

* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 23 Feb 2011 00:14:48 +0000 (00:14 +0000)]
Unreviewed.

<rdar://problem/8762042> and  https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

[Qt][WK2] Buildfix after r79364.

* DerivedSources.pro:
* WebKit2.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
beidson@apple.com [Wed, 23 Feb 2011 00:10:50 +0000 (00:10 +0000)]
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

Implement these to be used by WK2 API:
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 22 Feb 2011 23:23:42 +0000 (23:23 +0000)]
2011-02-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
        https://bugs.webkit.org/show_bug.cgi?id=54999

        SunSpider reports no change.

        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: So many build systems, so little time.
        * wtf/CMakeLists.txt:

        * runtime/MarkedBlock.cpp:
        (JSC::MarkedBlock::MarkedBlock):
        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::setPrev):
        (JSC::MarkedBlock::setNext):
        (JSC::MarkedBlock::prev):
        (JSC::MarkedBlock::next): Added linked list data members and accessors.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::destroy):
        (JSC::MarkedSpace::allocateBlock): Stop using vector, since it doesn't exist anymore.

        (JSC::MarkedSpace::freeBlocks): New helper function for updating relevant
        data structures when freeing blocks.

        (JSC::MarkedSpace::allocate): Updated for nextBlock being a pointer and
        not a vector index.

        (JSC::MarkedSpace::shrink): Construct a temporary list of empties and
        then free them, to avoid modifying our hash table while iterating it.
        This wasn't a concern before because we were using indirect array
        indexing, not direct pointer indexing.

        (JSC::MarkedSpace::reset): Updated for nextBlock being a pointer and
        not a vector index.

        * runtime/MarkedSpace.h:
        (JSC::CollectorHeap::CollectorHeap): Changed data type from vector to linked list.

        * wtf/DoublyLinkedList.h: Added. New linked list class.
        (WTF::::DoublyLinkedList):
        (WTF::::isEmpty):
        (WTF::::head):
        (WTF::::append):
        (WTF::::remove):
2011-02-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
        https://bugs.webkit.org/show_bug.cgi?id=54999

        New WTF header.

        * ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
2011-02-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
        https://bugs.webkit.org/show_bug.cgi?id=54999

        New WTF header.

        * ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Brady Eidson <beidson@apple.com>
andersca@apple.com [Tue, 22 Feb 2011 23:22:24 +0000 (23:22 +0000)]
2011-02-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson and looked over by Brian Weinstein.

        <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
        API to view and delete Application Cache data by origin.

        I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
        it's sorting was wrong due to a last minute name change.

        Project file changes:
        * GNUmakefile.am:
        * win/WebKit2.vcproj:
        * win/WebKit2Common.vsprops:
        * win/WebKit2Generated.make:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:

        WK2 build-system and API paperwork:
        * DerivedSources.make:
        * Platform/CoreIPC/MessageID.h:
        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * UIProcess/API/C/WKAPICast.h:

        Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:
        * Shared/SecurityOriginData.cpp:
        (WebKit::performAPICallbackWithSecurityOriginDataVector):
        * Shared/SecurityOriginData.h:
        * UIProcess/WebResourceCacheManagerProxy.cpp:
        (WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

        Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::~WebContext):
        (WebKit::WebContext::processDidClose):
        (WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
        * UIProcess/WebContext.h:
        (WebKit::WebContext::applicationCacheManagerProxy):
        (WebKit::WebContext::resourceCacheManagerProxy):

        Add API to get the ApplicationCacheManager for a context:
        * UIProcess/API/C/WKContext.cpp:
        (WKContextGetApplicationCacheManager):
        (WKContextGetResourceCacheManager):
        * UIProcess/API/C/WKContext.h:

        Route messages to the right place:
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveMessage):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::didReceiveMessage):

        Add the API object, which wraps to WebApplicationCacheManagerProxy:
        * UIProcess/API/C/WKApplicationCacheManager.cpp: Added.
        (WKApplicationCacheManagerGetTypeID):
        (WKApplicationCacheManagerGetApplicationCacheOrigins):
        (WKApplicationCacheManagerDeleteEntriesForOrigin):
        (WKApplicationCacheManagerDeleteAllEntries):
        * UIProcess/API/C/WKApplicationCacheManager.h: Added.

        The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
        * UIProcess/WebApplicationCacheManagerProxy.cpp: Added.
        (WebKit::WebApplicationCacheManagerProxy::create):
        (WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
        (WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
        (WebKit::WebApplicationCacheManagerProxy::invalidate):
        (WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
        (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
        (WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
        (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
        (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
        * UIProcess/WebApplicationCacheManagerProxy.h: Added.
        (WebKit::WebApplicationCacheManagerProxy::clearContext):
        (WebKit::WebApplicationCacheManagerProxy::type):
        * UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

        The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
        * WebProcess/ApplicationCache: Added.
        * WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.
        (WebKit::WebApplicationCacheManager::shared):
        (WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
        (WebKit::WebApplicationCacheManager::didReceiveMessage):
        (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
        (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
        (WebKit::WebApplicationCacheManager::deleteAllEntries):
        * WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
        * WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; neglected to update an expected result after changing some
jer.noble@apple.com [Tue, 22 Feb 2011 23:01:02 +0000 (23:01 +0000)]
Unreviewed; neglected to update an expected result after changing some
boilerplate text at the top of the test.

* media/audio-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
beidson@apple.com [Tue, 22 Feb 2011 22:52:37 +0000 (22:52 +0000)]
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson and looked over by Brian Weinstein.

I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.

Project file changes:
* GNUmakefile.am:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:

WK2 build-system and API paperwork:
* DerivedSources.make:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:

Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:
* Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
* Shared/SecurityOriginData.h:
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
* UIProcess/WebContext.h:
(WebKit::WebContext::applicationCacheManagerProxy):
(WebKit::WebContext::resourceCacheManagerProxy):

Add API to get the ApplicationCacheManager for a context:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
(WKContextGetResourceCacheManager):
* UIProcess/API/C/WKContext.h:

Route messages to the right place:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebApplicationCacheManagerProxy:
* UIProcess/API/C/WKApplicationCacheManager.cpp: Added.
(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):
* UIProcess/API/C/WKApplicationCacheManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
* UIProcess/WebApplicationCacheManagerProxy.cpp: Added.
(WebKit::WebApplicationCacheManagerProxy::create):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::invalidate):
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebApplicationCacheManagerProxy.h: Added.
(WebKit::WebApplicationCacheManagerProxy::clearContext):
(WebKit::WebApplicationCacheManagerProxy::type):
* UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
* WebProcess/ApplicationCache: Added.
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.
(WebKit::WebApplicationCacheManager::shared):
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::didReceiveMessage):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
* WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
* WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Ami Fischman <fischman@chromium.org>
eric.carlson@apple.com [Tue, 22 Feb 2011 22:34:37 +0000 (22:34 +0000)]
2011-02-22  Ami Fischman  <fischman@chromium.org>

        Reviewed by Eric Carlson.

        Second attempt at removing flakiness from media/video-poster.html (in
        service of http://crbug.com/60845).  First attempt (r79161)
        relied on load & error events firing on the video element for
        poster-related events, which the standard does not specify (and
        are thus a bug).  This change instead relies on a 20ms sleep loop to
        observe the new expected dimensions (and relies on the test
        runner to time out if the expectations fail to be met).

        https://bugs.webkit.org/show_bug.cgi?id=54685

        * media/video-poster.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Feb 2011 22:29:58 +0000 (22:29 +0000)]
2011-02-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Get rid of WebProcessManager::getAllWebProcessContexts
        https://bugs.webkit.org/show_bug.cgi?id=55000

        * Shared/WebURLRequest.cpp:
        (WebKit::WebURLRequest::setDefaultTimeoutInterval):
        Call WebContext::allContexts instead.

        * UIProcess/WebContext.cpp:
        * UIProcess/WebContext.h:
        Add a vector of WebContext objects. Update it when creating and destroying contexts.

        * UIProcess/WebProcessManager.cpp:
        * UIProcess/WebProcessManager.h:
        Remove WebProcessManager::getAllWebProcessContexts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 22 Feb 2011 22:29:26 +0000 (22:29 +0000)]
2011-02-22  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79339.
        http://trac.webkit.org/changeset/79339
        https://bugs.webkit.org/show_bug.cgi?id=54974

        Baselines were put in the wrong directory, so we need to
        continue to ignore failures

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=54991
bdakin@apple.com [Tue, 22 Feb 2011 22:28:52 +0000 (22:28 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
Scrollbars
-and corresponding-
<rdar://problem/9034318>

Reviewed by Sam Weinig.

Instead of consulting the theme directly, callers should ask the Scrollbar or
ScrollableArea if the scrollbars are overlay or not.

* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::hasOverlayScrollbars):
* platform/ScrollableArea.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::isOverlayScrollbar):
* platform/Scrollbar.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::verticalScrollbarWidth):
* rendering/RenderScrollbar.h:
(WebCore::RenderScrollbar::isOverlayScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 22 Feb 2011 22:09:38 +0000 (22:09 +0000)]
2011-02-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        media/audio-repaint.html flakey.
        https://bugs.webkit.org/show_bug.cgi?id=54970

        Audio repaint tests flakey, as they took a snapshot 1.5s into a 7s file.  Tests
        modified to test against a 1s file, and will trigger a snapshot when the audio
        finishes seeking to the 1/2way point.

        * media/audio-repaint-expected.txt:
        * media/audio-repaint.html:
        * media/content/silence.wav: Added.
        * media/media-document-audio-repaint-expected.txt:
        * media/media-document-audio-repaint.html:
        * platform/mac/media/audio-repaint-expected.checksum:
        * platform/mac/media/audio-repaint-expected.png:
        * platform/mac/media/media-document-audio-repaint-expected.checksum:
        * platform/mac/media/media-document-audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
weinig@apple.com [Tue, 22 Feb 2011 22:09:30 +0000 (22:09 +0000)]
Re-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
a crash running fast/loader/empty-embed-src-attribute.html. This matches a
bail out in the default policy delegate in WebKit1.

Reviewed by Anders Carlsson.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Tue, 22 Feb 2011 22:00:43 +0000 (22:00 +0000)]
Unreviewed.

[Qt] New fails caused by change(s) between r79317-r79320.

* platform/qt/Skipped: Skip tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
barraclough@apple.com [Tue, 22 Feb 2011 21:55:35 +0000 (21:55 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 54988 - Re-create StructureTransitionTable class, encapsulate transition table
barraclough@apple.com [Tue, 22 Feb 2011 21:49:59 +0000 (21:49 +0000)]
Bug 54988 - Re-create StructureTransitionTable class, encapsulate transition table

Reviewed by Sam Weinig.

The Structure class keeps a table of transitions to derived Structure types. Since
this table commonly contains a single entry we employ an optimization where instead
of holding a map, we may hold a pointer directly to a single instance of the mapped
type. We use an additional bit of data to flag whether the pointer is currently
pointing to a table of transitions, or a singleton transition. Previously we had
commonly used a pattern of storing data in the low bits of pointers, but had moved
away from this since it causes false leaks to be reported by the leaks tool. However
in this case, the entries in the map are weak links - this pointer will never be
responsible for keeping an object alive.  As such we can use this approach provided
that the bit is set when a table is not in use (otherwise the table would appear to
be leaked).

Additionally, the transition table currently allows two entries to exist for a given
key - one specialized to a particular value, and one not specialized. This is
unnecessary, wasteful, and a little inconsistent. (If you create an entry for a
specialized value, then a non-specialized entry, both will exist.  If you create an
entry for a non-specialized value, then try to create a specialized entry, only a
non-specialized form will be allowed.)

This shows a small progression on v8.

* JavaScriptCore.exp:
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::get):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
(JSC::StructureTransitionTable::Hash::equal):
(JSC::StructureTransitionTable::HashTraits::emptyValue):
(JSC::StructureTransitionTable::HashTraits::constructDeletedValue):
(JSC::StructureTransitionTable::HashTraits::isDeletedValue):
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::isUsingSingleSlot):
(JSC::StructureTransitionTable::map):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 21:45:47 +0000 (21:45 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] WebWorkerBase::openFileSystem confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54920

        Rename WebWorkerBase::openFileSystem() to openFileSystemForWorker() to
        make it obvious it's not an override of
        WebFrameClient::openFileSystem().

        Remove a failed attempt to override it in WebWorkerClientImpl (the
        override didn't change the behavior).

        No intended functionality change.

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::requestFileSystem):
        Call new name.
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::openFileSystemForWorker):
        Rename openFileSystem() to openFileSystemForWorker().
        * src/WebWorkerBase.h:
        Rename openFileSystem() to openFileSystemForWorker().
        * src/WebWorkerClientImpl.h:
        (WebKit::WebWorkerClientImpl::allowDatabase):
        Remove unsuccessful (and pointless) override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations change.
atwilson@chromium.org [Tue, 22 Feb 2011 21:35:31 +0000 (21:35 +0000)]
Unreviewed expectations change.

[Chromium] Generate results for media/audio-repaint.html and media/media-document-audio-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=54983

* platform/chromium-linux/media/audio-repaint-expected.checksum: Added.
* platform/chromium-linux/media/audio-repaint-expected.png: Added.
* platform/chromium-linux/media/audio-repaint-expected.txt: Added.
* platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Added.
* platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-mac/media/audio-repaint-expected.checksum: Added.
* platform/chromium-mac/media/audio-repaint-expected.png: Added.
* platform/chromium-mac/media/audio-repaint-expected.txt: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-win/media/audio-repaint-expected.checksum: Added.
* platform/chromium-win/media/audio-repaint-expected.png: Added.
* platform/chromium-win/media/audio-repaint-expected.txt: Added.
* platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Added.
* platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Redesign the build system
abecsi@webkit.org [Tue, 22 Feb 2011 21:19:43 +0000 (21:19 +0000)]
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Csaba Osztrogonác.

Move inspector's resource files into the final build step to fix the layout test regression.

Source/WebCore:

No new tests needed.

* WebCore.pro: Move inspector's resource files into QtWebKit.pro.

Source/WebKit/qt:

* QtWebKit.pro: Add inspector's reaource files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 22 Feb 2011 21:15:33 +0000 (21:15 +0000)]
2011-02-22  Martin Robinson  <mrobinson@igalia.com>

        Add some GTK+-specific expectations for new media tests.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 22 Feb 2011 21:06:35 +0000 (21:06 +0000)]
2011-02-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
        https://bugs.webkit.org/show_bug.cgi?id=54990

        No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
        to start passing again.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::visibleContentRect): Update this method to match the original
        in the parent class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 22 Feb 2011 21:01:43 +0000 (21:01 +0000)]
2011-01-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49177

        * platform/gtk/Skipped: Unskip passing test.
2011-01-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49177

        * platform/ScrollView.cpp: Remove the GTK+ guards around the implementation
        of platformAddChild and platformRemoveChild. This code can be shared.
        * platform/gtk/MainFrameScrollbarGtk.cpp:
        (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached
        adjustment. Connect the adjustment value-changed signal handler after resetting the
        adjustment. This prevents the rest from stomping on pre-existing WebCore values.
        (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to
        a scrollview do not listing for value changes. These scrollbars are defunct.
        * platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Feb 2011 21:01:04 +0000 (21:01 +0000)]
2011-02-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Grammar correction from Spelling & Grammar window doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=54982
        <rdar://problem/8940918>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView isGrammarCheckingEnabled]):
        (-[WKView setGrammarCheckingEnabled:]):
        Call down to the text checker.

        * UIProcess/TextChecker.h:
        Add updateSpellingUIWithGrammarString.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::updateSpellingUIWithGrammarString):
        Call TextChecker::updateSpellingUIWithGrammarString.

        * UIProcess/WebPageProxy.messages.in:
        Add UpdateSpellingUIWithGrammarString message.

        * UIProcess/gtk/TextCheckerGtk.cpp:
        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
        * UIProcess/qt/TextCheckerQt.cpp:
        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
        * UIProcess/win/TextCheckerWin.cpp:
        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
        Add stubs.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
        Update the spelling panel.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::updateSpellingUIWithGrammarString):
        Send an UpdateSpellingUIWithGrammarString message to the UI process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 22 Feb 2011 20:42:18 +0000 (20:42 +0000)]
2011-02-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] position:fixed elements flicker while scrolling after r74196
        https://bugs.webkit.org/show_bug.cgi?id=54981

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations
        boolean to false.
        (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we
        having pending scrolling invalidations, instruct GDK to process updates now.
        (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set
        m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
        * WebCoreSupport/ChromeClientGtk.h: Add new boolean member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, adding new pixel tests to the skipped list of various platforms.
jer.noble@apple.com [Tue, 22 Feb 2011 20:40:28 +0000 (20:40 +0000)]
Unreviewed, adding new pixel tests to the skipped list of various platforms.

media/audio-repaint.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=54970

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 22 Feb 2011 20:18:12 +0000 (20:18 +0000)]
2011-02-22  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
        https://bugs.webkit.org/show_bug.cgi?id=54954

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::toNode):
        (WebCore::JSInjectedScriptHost::inspect):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::toNode):
        (WebCore::V8InjectedScriptHost::inspectCallback):
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::nodeForObjectId):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspect):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::focusNode):
        * inspector/InspectorAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::inspect):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.evaluateInTargetWindow):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
        (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.prototype.pushNodeToFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
beidson@apple.com [Tue, 22 Feb 2011 19:38:05 +0000 (19:38 +0000)]
Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

../WebCore:

Stub these out for now:
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
(WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac
* loader/appcache/ApplicationCacheStorage.h:

Export the new symbols:
* WebCore.exp.in:

../WebKit/mac:

* WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix debug build.
andersca@apple.com [Tue, 22 Feb 2011 19:36:48 +0000 (19:36 +0000)]
Fix debug build.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 22 Feb 2011 19:28:05 +0000 (19:28 +0000)]
2011-02-22  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79337.
        http://trac.webkit.org/changeset/79337

        GPU-only test should have GPU baselines

        * platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
        * platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
        * platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
        * platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
        * platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Adrienne Walker <enne@google.com>
enne@google.com [Tue, 22 Feb 2011 18:59:58 +0000 (18:59 +0000)]
2011-02-22  Adrienne Walker  <enne@google.com>

        Unreviewed rebaseline of some GPU tests.

        This cleans up the rest of the BUGWK54409 expectations after r79084.

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Prospectively removing test_expectations entries for some tests that...
atwilson@chromium.org [Tue, 22 Feb 2011 18:56:10 +0000 (18:56 +0000)]
Unreviewed. Prospectively removing test_expectations entries for some tests that seem to be passing now on the canaries.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a flaky Inspector test on Windows
aroben@apple.com [Tue, 22 Feb 2011 18:53:52 +0000 (18:53 +0000)]
Skip a flaky Inspector test on Windows

<http://webkit.org/b/54974> tracks the failure.

* platform/win/Skipped: Added inspector/extensions/extensions-events.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations update for deeply-nested-reflections.html
atwilson@chromium.org [Tue, 22 Feb 2011 18:51:51 +0000 (18:51 +0000)]
Unreviewed expectations update for deeply-nested-reflections.html

* platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
* platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
* platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
* platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
* platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 22 Feb 2011 18:47:08 +0000 (18:47 +0000)]
2011-02-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Default to 500 for --exit-after-n-failures
        https://bugs.webkit.org/show_bug.cgi?id=54773

        Make 500 the default value for --exit-after-n-failures (ORWT bots
        already default to this as of r75726). Similarly, change the default for
        --exit-after-n-crashes-or-timeouts to 20.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonotImplemented() should behave identical in WebCore and WebKit2
kbalazs@webkit.org [Tue, 22 Feb 2011 18:45:56 +0000 (18:45 +0000)]
notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Source/WebCore:

No functional change so no new tests.

* WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header
to be able to use it in WebKit2.

Source/WebKit2:

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Removed.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
* config.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Redesign the build system
abecsi@webkit.org [Tue, 22 Feb 2011 18:41:18 +0000 (18:41 +0000)]
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.

The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.

Source/WebCore:

No new tests needed.

* WebCore.pri: Add common LIB and CONFIG options.
* WebCore.pro: Add accidentally moved sections.

Source/WebKit/qt:

* QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 18:26:33 +0000 (18:26 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.12 release preparation
        https://bugs.webkit.org/show_bug.cgi?id=54967

        Version bump for 1.3.12 and updated NEWS file with release notes.
        Also bumped libsoup requirement to 2.33.6 as agreed with Sergio
        and Martin.

        * Source/WebKit/gtk/NEWS:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 18:24:54 +0000 (18:24 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r79321.
        http://trac.webkit.org/changeset/79321
        https://bugs.webkit.org/show_bug.cgi?id=53146

        Regresses  fast/forms/listbox-typeahead-cyrillic.html and fast
        /spatial-navigation/snav-single-select.html on GTK

        * platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
        * platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, rolling out r79321.
        http://trac.webkit.org/changeset/79321
        https://bugs.webkit.org/show_bug.cgi?id=53146

        Regresses  fast/forms/listbox-typeahead-cyrillic.html and fast
        /spatial-navigation/snav-single-select.html on GTK

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::notifyChildrenSelectionChange):
        (WebCore::AXObjectCache::postPlatformNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInvalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.
bweinstein@apple.com [Tue, 22 Feb 2011 18:19:09 +0000 (18:19 +0000)]
Invalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.

Rubber-stamped by Brady Eidson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, revert the duplicate ChangeLog entries added in r79307, r79312, r79313...
philn@webkit.org [Tue, 22 Feb 2011 17:45:41 +0000 (17:45 +0000)]
Unreviewed, revert the duplicate ChangeLog entries added in r79307, r79312, r79313 and r79314

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 22 Feb 2011 17:39:35 +0000 (17:39 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
        https://bugs.webkit.org/show_bug.cgi?id=53603

        * platform/gtk/Skipped: Unskip passing tests.
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
        https://bugs.webkit.org/show_bug.cgi?id=53603

        Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
        setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
        listens to this value during DRT runs. Perhaps later we can expose this to the public
        API.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added
        (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk
        for the appropriate return value.
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
        https://bugs.webkit.org/show_bug.cgi?id=53603

        Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
        to DumpRenderTreeSupportGtk for this functionality.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
        false when reseting values between tests.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
        with the appropriate value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected failure results for new tests from r79318
aroben@apple.com [Tue, 22 Feb 2011 17:16:55 +0000 (17:16 +0000)]
Add Windows expected failure results for new tests from r79318

<http://webkit.org/b/54966> tracks the failure.

* platform/win/media/audio-repaint-expected.txt: Added.
* platform/win/media/media-document-audio-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't trigger a Windows build when the top-level ChangeLog changes
aroben@apple.com [Tue, 22 Feb 2011 16:08:47 +0000 (16:08 +0000)]
Don't trigger a Windows build when the top-level ChangeLog changes

r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.

Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web...
aroben@apple.com [Tue, 22 Feb 2011 16:07:01 +0000 (16:07 +0000)]
Make DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web process

This will be useful for sending repeated messages for the same state ID to the web process.
We don't do this currently, but will need to if we're asked to paint after we've thrown away
our backing store to save memory.

Fixes <http://webkit.org/b/54916> DrawingAreaProxyImpl should keep track of the state ID it
last sent to the web process

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_requestedStateID, and
reordered member initialization to match the new declaration order.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Added an assertion that the stateID we got
from the web process is no newer than the most recent one we requested.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Changed to increment and send
m_requestedStateID instead of a new global stateID.

* UIProcess/DrawingAreaProxyImpl.h: Added m_requestedStateID, and moved the state IDs before
other data members. Also beefed the comment explaining m_currentStateID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Feb 2011 16:01:30 +0000 (16:01 +0000)]
2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Inspector.IDL change. rename attribute notify -> event.
        https://bugs.webkit.org/show_bug.cgi?id=54958

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 22 Feb 2011 15:44:31 +0000 (15:44 +0000)]
2011-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78691.
        http://trac.webkit.org/changeset/78691
        https://bugs.webkit.org/show_bug.cgi?id=54956

        Leopard Debug is successfully building again (Requested by
        aroben on #webkit).

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 22 Feb 2011 15:32:29 +0000 (15:32 +0000)]
2011-02-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Timeline agent should have same lifetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54951

        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
        * inspector/timeline/timeline-trivial.html:
2011-02-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Timeline agent should have same lifetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54951

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        (WebCore::InspectorAgent::loadEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::timelineProfilerEnabled):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::setFrontend):
        (WebCore::InspectorTimelineAgent::clearFrontend):
        (WebCore::InspectorTimelineAgent::restore):
        (WebCore::InspectorTimelineAgent::startTimelineProfiler):
        (WebCore::InspectorTimelineAgent::stopTimelineProfiler):
        (WebCore::InspectorTimelineAgent::timelineProfilerStarted):
        (WebCore::InspectorTimelineAgent::didCommitLoad):
        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::clearRecordStack):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::create):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Feb 2011 15:28:20 +0000 (15:28 +0000)]
2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Web Inspector: flakyness of inspector tests.
        https://bugs.webkit.org/show_bug.cgi?id=54729

        As far as we have the protocol with sequence numbers we can simplify test harness support
        and drop out chomium specific methods.

        Source/WebCore:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/TestController.js:
        (WebInspector.TestController):
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.TestController.prototype.runAfterPendingDispatches):
        (WebInspector.TestController.prototype._evaluateForTestInFrontend):
        * inspector/front-end/inspector.js:
        (WebInspector.dispatch):

        Source/WebKit/chromium:
        * src/js/DevTools.js:

        LayoutTests:
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):

        Tools:
        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        (DRTDevToolsAgent::sendMessageToInspectorFrontend):
        (DRTDevToolsAgent::runtimePropertyChanged):
        (DRTDevToolsAgent::asyncCall):
        (DRTDevToolsAgent::call):
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
        * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
        * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
        (DRTDevToolsClient::sendMessageToBackend):
        (DRTDevToolsClient::asyncCall):
        (DRTDevToolsClient::call):
        * DumpRenderTree/chromium/DRTDevToolsClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 22 Feb 2011 15:26:23 +0000 (15:26 +0000)]
2011-02-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Combo boxes should emit object:selection-changed even when collapsed
        https://bugs.webkit.org/show_bug.cgi?id=53146

        New GTK-specific layout test to check the right signals are emitted.

        * platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
        * platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.
2011-02-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Combo boxes should emit object:selection-changed even when collapsed
        https://bugs.webkit.org/show_bug.cgi?id=53146

        Emit the selection-changed signals when the menu list value has changed

        Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::getListObject): New, return the right list object for
        menu lists and list boxes.
        (WebCore::notifyChildrenSelectionChange): Support menu lists.
        (WebCore::AXObjectCache::postPlatformNotification): Call function
        notifyChildrenSelectionChange for AXMenuListValueChanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 22 Feb 2011 15:14:57 +0000 (15:14 +0000)]
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        * Source/WebKit.pri: Add common include paths
        * Source/WebKit.pro: Add new project file to SUBDIRS
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        * JavaScriptCore.pri: Remove the workaround.
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        * QtWebKit.pro: Added.
        Project file for the final build step.
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        No new tests needed.

        * WebCore.pri: Add needed rules for handling the static library.
        * WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
2011-02-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] Redesign the build system
        https://bugs.webkit.org/show_bug.cgi?id=51339

        Part 2.

        Build WebCore as a static library, compile the WebKit API and WebKit2 API
        in a final step and link to WebKit2, WebCore and JSC libraries to fix
        linking issues resulting from stripped away symbols.

        * WebKit2.pri: Add include paths.
        * WebKit2.pro: Move include paths to WebKit2.pri and move
        the API source to WebKit/qt/QtWebKit.pro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 22 Feb 2011 15:09:12 +0000 (15:09 +0000)]
2011-02-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
        https://bugs.webkit.org/show_bug.cgi?id=54947

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::loadFromCookie):
        * inspector/InspectorState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-15 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 22 Feb 2011 15:07:16 +0000 (15:07 +0000)]
2011-02-15  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
        https://bugs.webkit.org/show_bug.cgi?id=46142

        Added a repaint test which ensures the timeline controls repaint in an audio-only MediaDocument.  Since
        the change also affects in-page audio, also added a repaint test for those cases as well.

        Other platforms will need to have results generated.

        * media/audio-repaint.html: Added.
        * media/media-document-audio-repaint-expected.txt: Added.
        * media/media-document-audio-repaint.html: Added.
        * platform/mac/media/audio-repaint-expected.checksum: Added.
        * platform/mac/media/audio-repaint-expected.png: Added.
        * platform/mac/media/audio-repaint-expected.txt: Added.
        * platform/mac/media/media-document-audio-repaint-expected.checksum: Added.
        * platform/mac/media/media-document-audio-repaint-expected.png: Added.
2011-02-15  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
        https://bugs.webkit.org/show_bug.cgi?id=46142

        Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
        container elements.  This is necessary because, during layout(), the child renderers
        query the current LayoutState to determine where they will be repainting.  If a new
        LayoutState is not pushed here, child renderers will attempt to repaint relative to
        their grandparent's origin instead of their parents', and repaint operations will fail.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 22 Feb 2011 14:49:45 +0000 (14:49 +0000)]
2011-02-22  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
        https://bugs.webkit.org/show_bug.cgi?id=54952

        Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
        a valid reference for the input type FileInputType.

        * page/Chrome.cpp:
        (WebCore::Chrome::setToolTip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 22 Feb 2011 13:25:15 +0000 (13:25 +0000)]
2011-02-22  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
        https://bugs.webkit.org/show_bug.cgi?id=54902

        Refactor the context menu handling of Qt to make it simpler to manage memory.

        WebContextMenuProxyQt uses smart pointer for all the references to menu so
        there is no need to delete it explicitely.

        Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
        the client can choose to handle the memory, but there is no leak if it does not.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        (QGraphicsWKView::showContextMenu):
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/qt/WebContextMenuProxyQt.cpp:
        (WebKit::WebContextMenuProxyQt::showContextMenu):
        (WebKit::WebContextMenuProxyQt::createContextMenu):
        * UIProcess/qt/WebContextMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:20:42 +0000 (13:20 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing inspector test on GTK

        * platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:20:31 +0000 (13:20 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Added new headers and removed references to deleted files.

        * GNUmakefile.am:

2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Removed reference to NotImplemented.h which was removed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Andrey Kosyakov <caseq@chromium.org>
philn@webkit.org [Tue, 22 Feb 2011 13:20:20 +0000 (13:20 +0000)]
2011-02-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
        https://bugs.webkit.org/show_bug.cgi?id=54671

        - factored toolbar handling out of inspector.js
        - added toolbar dropdown

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.get toolbarItem):
        * inspector/front-end/Toolbar.js: Added.
        (WebInspector.Toolbar):
        (WebInspector.Toolbar.prototype.resize):
        (WebInspector.Toolbar.prototype.addPanel):
        (WebInspector.Toolbar.prototype._toolbarDragStart):
        (WebInspector.Toolbar.prototype._toolbarDragEnd):
        (WebInspector.Toolbar.prototype._toolbarDrag):
        (WebInspector.Toolbar.prototype._onClose):
        (WebInspector.Toolbar.prototype._setDropdownVisible):
        (WebInspector.Toolbar.prototype._toggleDropdown):
        (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
        (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
        (WebInspector.Toolbar.createPanelToolbarItem):
        (WebInspector.ToolbarDropdown):
        (WebInspector.ToolbarDropdown.prototype.show):
        (WebInspector.ToolbarDropdown.prototype.hide):
        (WebInspector.ToolbarDropdown.prototype.get visible):
        (WebInspector.ToolbarDropdown.prototype._populate):
        (WebInspector.ToolbarDropdown.prototype._onKeyDown):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (#toolbar):
        (.toolbar-item):
        (.toolbar-item.toggleable):
        (.toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-icon):
        (#toolbar-dropdown .toolbar-label):
        (#toolbar-controls):
        (#toolbar-dropdown-arrow):
        (body.attached #toolbar-dropdown-arrow):
        (#toolbar-dropdown-arrow.dropdown-visible):
        (#toolbar-dropdown-arrow:hover):
        (#toolbar-dropdown-arrow:active):
        (#toolbar-dropdown):
        (body.detached.platform-mac-snowleopard #toolbar-dropdown):
        (#toolbar-dropdown .scrollable-content):
        (#toolbar-dropdown .toolbar-item):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-icon):
        (#toolbar-dropdown .toolbar-label):
        (#toolbar-controls):
        (#toolbar-dropdown-arrow):
        (body.attached #toolbar-dropdown-arrow):
        (#toolbar-dropdown-arrow.dropdown-visible):
        (#toolbar-dropdown-arrow:hover):
        (#toolbar-dropdown-arrow:active):
        (#toolbar-dropdown):
        (body.detached.platform-mac-snowleopard #toolbar-dropdown):
        (#toolbar-dropdown .scrollable-content):
        (#toolbar-dropdown .toolbar-item):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-item:hover):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
        (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
        (.scrollable-content):
        (.scrollable-content::-webkit-scrollbar):
        (.scrollable-content::-webkit-resizer):
        (.scrollable-content::-webkit-scrollbar-thumb:vertical):
        (.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
        (.scrollable-content::-webkit-scrollbar-track:vertical):
        (.toolbar-search-item):
        (#search):
        (body.attached #search):
        (#search-results-matches):
        (#close-button-left, #close-button-right):
        (.close-left):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.set attached):
        (WebInspector.addPanel):
        (WebInspector.windowResize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
philn@webkit.org [Tue, 22 Feb 2011 13:20:07 +0000 (13:20 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 22 Feb 2011 13:17:02 +0000 (13:17 +0000)]
2011-02-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=54645

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.createWrapper.return.try):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        * inspector/debugger/source-frame-expected.txt: Added.
        * inspector/debugger/source-frame.html: Added.
2011-02-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
        https://bugs.webkit.org/show_bug.cgi?id=54645

        This is needed to map one script to several source files.

        Test: inspector/debugger/source-frame.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DebuggerPresentationModel.js: Added.
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
        (WebInspector.ScriptsPanel.prototype._addSourceFrame):
        (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.get loaded):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype.addBreakpoint):
        (WebInspector.SourceFrame.prototype.removeBreakpoint):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame.prototype._findBreakpoint.filter):
        (WebInspector.SourceFrame.prototype._findBreakpoint):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
2011-02-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=54645

        * src/js/Tests.js:
        (.TestSuite.prototype._checkExecutionLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:11:52 +0000 (13:11 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of fast/forms/placeholder-position.html

        * platform/gtk/fast/forms/placeholder-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:08:05 +0000 (13:08 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of media/video-aspect-ratio.html

        * platform/gtk/media/video-aspect-ratio-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:06:11 +0000 (13:06 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing inspector test on GTK

        * platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 13:05:58 +0000 (13:05 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Added new headers and removed references to deleted files.

        * GNUmakefile.am:

2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Removed reference to NotImplemented.h which was removed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 22 Feb 2011 12:16:42 +0000 (12:16 +0000)]
2011-02-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
        https://bugs.webkit.org/show_bug.cgi?id=54671

        - factored toolbar handling out of inspector.js
        - added toolbar dropdown

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.get toolbarItem):
        * inspector/front-end/Toolbar.js: Added.
        (WebInspector.Toolbar):
        (WebInspector.Toolbar.prototype.resize):
        (WebInspector.Toolbar.prototype.addPanel):
        (WebInspector.Toolbar.prototype._toolbarDragStart):
        (WebInspector.Toolbar.prototype._toolbarDragEnd):
        (WebInspector.Toolbar.prototype._toolbarDrag):
        (WebInspector.Toolbar.prototype._onClose):
        (WebInspector.Toolbar.prototype._setDropdownVisible):
        (WebInspector.Toolbar.prototype._toggleDropdown):
        (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
        (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
        (WebInspector.Toolbar.createPanelToolbarItem):
        (WebInspector.ToolbarDropdown):
        (WebInspector.ToolbarDropdown.prototype.show):
        (WebInspector.ToolbarDropdown.prototype.hide):
        (WebInspector.ToolbarDropdown.prototype.get visible):
        (WebInspector.ToolbarDropdown.prototype._populate):
        (WebInspector.ToolbarDropdown.prototype._onKeyDown):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (#toolbar):
        (.toolbar-item):
        (.toolbar-item.toggleable):
        (.toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-icon):
        (#toolbar-dropdown .toolbar-label):
        (#toolbar-controls):
        (#toolbar-dropdown-arrow):
        (body.attached #toolbar-dropdown-arrow):
        (#toolbar-dropdown-arrow.dropdown-visible):
        (#toolbar-dropdown-arrow:hover):
        (#toolbar-dropdown-arrow:active):
        (#toolbar-dropdown):
        (body.detached.platform-mac-snowleopard #toolbar-dropdown):
        (#toolbar-dropdown .scrollable-content):
        (#toolbar-dropdown .toolbar-item):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-icon):
        (#toolbar-dropdown .toolbar-label):
        (#toolbar-controls):
        (#toolbar-dropdown-arrow):
        (body.attached #toolbar-dropdown-arrow):
        (#toolbar-dropdown-arrow.dropdown-visible):
        (#toolbar-dropdown-arrow:hover):
        (#toolbar-dropdown-arrow:active):
        (#toolbar-dropdown):
        (body.detached.platform-mac-snowleopard #toolbar-dropdown):
        (#toolbar-dropdown .scrollable-content):
        (#toolbar-dropdown .toolbar-item):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
        (#toolbar-dropdown .toolbar-item:hover):
        (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
        (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
        (.scrollable-content):
        (.scrollable-content::-webkit-scrollbar):
        (.scrollable-content::-webkit-resizer):
        (.scrollable-content::-webkit-scrollbar-thumb:vertical):
        (.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
        (.scrollable-content::-webkit-scrollbar-track:vertical):
        (.toolbar-search-item):
        (#search):
        (body.attached #search):
        (#search-results-matches):
        (#close-button-left, #close-button-right):
        (.close-left):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.set attached):
        (WebInspector.addPanel):
        (WebInspector.windowResize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Tue, 22 Feb 2011 12:12:52 +0000 (12:12 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 22 Feb 2011 11:11:34 +0000 (11:11 +0000)]
2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Added new headers and removed references to deleted files.

        * GNUmakefile.am:

2011-02-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] make distcheck fails
        https://bugs.webkit.org/show_bug.cgi?id=54943

        Removed reference to NotImplemented.h which was removed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 22 Feb 2011 09:34:15 +0000 (09:34 +0000)]
2011-02-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54891

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::instrumentingAgents):
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::setFrontend):
        (WebCore::InspectorDOMStorageAgent::clearFrontend):
        (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
        (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
        (WebCore::InspectorDOMStorageAgent::clearResources):
        * inspector/InspectorDOMStorageAgent.h:
        (WebCore::InspectorDOMStorageAgent::create):
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::didOpenDatabase):
        (WebCore::InspectorDatabaseAgent::clearResources):
        (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::setFrontend):
        (WebCore::InspectorDatabaseAgent::clearFrontend):
        (WebCore::InspectorDatabaseAgent::databaseForId):
        (WebCore::InspectorDatabaseAgent::selectDatabase):
        * inspector/InspectorDatabaseAgent.h:
        (WebCore::InspectorDatabaseAgent::create):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
        (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
commit-queue@webkit.org [Tue, 22 Feb 2011 09:12:14 +0000 (09:12 +0000)]
2011-02-22  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtWebProcess should be installed with 'make install'
        https://bugs.webkit.org/show_bug.cgi?id=44100

        Follow the standard in other project files and allow install
        location to be changed with INSTALL_BINS variable.

        * WebProcess.pro: Install QtWebProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Tue, 22 Feb 2011 09:03:17 +0000 (09:03 +0000)]
2011-02-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by Darin Fisher.

        Rename new media statistics apis to better names

        https://bugs.webkit.org/show_bug.cgi?id=54784

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount):
        (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::webkitDecodedFrameCount):
        (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
        * html/HTMLVideoElement.h:
        * html/HTMLVideoElement.idl:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::decodedFrameCount):
        (WebCore::MediaPlayer::droppedFrameCount):
        (WebCore::MediaPlayer::audioDecodedByteCount):
        (WebCore::MediaPlayer::videoDecodedByteCount):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::decodedFrameCount):
        (WebCore::MediaPlayerPrivateInterface::droppedFrameCount):
        (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount):
        (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 08:41:23 +0000 (08:41 +0000)]
2011-02-22 MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        Removed more BUGWK54736 lines which are no longer failed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 08:32:11 +0000 (08:32 +0000)]
2011-02-22  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        Mark styles-update-from-js.html as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 22 Feb 2011 08:23:55 +0000 (08:23 +0000)]
2011-02-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
        https://bugs.webkit.org/show_bug.cgi?id=54435

        Changed the function to a series of early-exit 'if's,
        removed most temporary variables.

        No new tests. (refactoring)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r79296.
kbalazs@webkit.org [Tue, 22 Feb 2011 08:18:18 +0000 (08:18 +0000)]
Unreviewed, rolling out r79296.
http://trac.webkit.org/changeset/79296
https://bugs.webkit.org/show_bug.cgi?id=54941

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-22
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).

* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
* config.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonotImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit...
kbalazs@webkit.org [Tue, 22 Feb 2011 07:42:12 +0000 (07:42 +0000)]
notImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Removed.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Tue, 22 Feb 2011 07:21:09 +0000 (07:21 +0000)]
2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
        https://bugs.webkit.org/show_bug.cgi?id=54806

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new): spatial navigation setting initialization added
2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
        https://bugs.webkit.org/show_bug.cgi?id=54806

        * EWebLauncher/main.c:
        (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 07:05:28 +0000 (07:05 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54923

        Rename PopupContainer::show() to showInRect(), to make it obvious it's
        not an override of ScrollView::show().

        No intended functionality change.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showInRect):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54923

        Rename PopupContainer::show() to showInRect(), to make it obvious it's
        not an override of ScrollView::show().

        No intended functionality change.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::applyAutoFillSuggestions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Tue, 22 Feb 2011 06:48:22 +0000 (06:48 +0000)]
2011-02-21  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Antti Koivisto.

        Improve the local{SharedStyle,CousinList} algorithm
        https://bugs.webkit.org/show_bug.cgi?id=45507

        This change improves the algorithm to find shared styles: the old
        algorithm would stop the search after the first cousin, even if
        the search threshold is not met. As such, the algorithm would
        systematically miss sharings across second cousins and beyond.
        The new algorithm continues the search, as long as threshold is
        not met. It also separates the threshold for sibling/cousins
        search, from that on the levels of search, which is easier to
        optimize.
        The new algorithm finds up to 30% more sharings on some sites
        (e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.

        No new test, refactoring only.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::locateCousinList):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        While changing the algorithm, cleaned up the style of those 2 methods
        (use early return, renamed some variables).

        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 06:46:24 +0000 (06:46 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54922

        RenderTableCell::baselinePosition() has the same name as a virtual
        method in superclass RenderBlock. Rename the subclass method to make
        it clear it's not an attempted override.

        No intended functionality change.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::cellBaselinePosition):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowLogicalHeight):
        (WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 06:45:15 +0000 (06:45 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        r79285 removes too much lines. recover failed one.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Benjamin Kalman <kalman@chromium.org>
kalman@chromium.org [Tue, 22 Feb 2011 06:24:36 +0000 (06:24 +0000)]
2011-02-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
        start/end of selection for RTL
        https://bugs.webkit.org/show_bug.cgi?id=54724

        Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.

        * editing/selection/extend-left-right-by-lineboundary-expected.txt:
        * editing/selection/extend-left-right-by-lineboundary.html:
2011-02-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
        start/end of selection for RTL
        https://bugs.webkit.org/show_bug.cgi?id=54724

        On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
        This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
        extending from the end when for the "right" direction (e.g. pressing right arrow key).

        However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
        direction is obviously reversed) and likewise extend from the start when extending right.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 06:19:39 +0000 (06:19 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation rebaseline for r79284.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
        * platform/chromium-linux/fast/forms/search-styled-expected.checksum:
        * platform/chromium-linux/fast/forms/search-styled-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-win/fast/forms/placeholder-position-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
        * platform/chromium-win/fast/forms/search-styled-expected.checksum:
        * platform/chromium-win/fast/forms/search-styled-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 06:10:29 +0000 (06:10 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        ImageDocument::imageChanged() confuses clang's -Woverride-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54924

        Rename ImageDocument::imageChanged() to imageUpdated() to make clear
        that it's not an override of CachedResourceClient::imageChanged().

        * html/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::appendBytes):
        (WebCore::ImageDocumentParser::finish):
        (WebCore::ImageDocument::imageUpdated):
        * html/ImageDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 22 Feb 2011 05:58:49 +0000 (05:58 +0000)]
2011-02-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 54934 - Sort the WebCore project file(s)
        https://bugs.webkit.org/show_bug.cgi?id=54934

        No new tests. (no code affected)

        * GNUmakefile.am:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 05:51:51 +0000 (05:51 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54909

        Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
        unconfuse clang. No intended functionality change.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::checkLinesForTextOverflow):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::applyLineClamp):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
        * rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 05:14:59 +0000 (05:14 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        Removed BUGWK54736 lines which are no longer failed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
adele@apple.com [Tue, 22 Feb 2011 04:56:14 +0000 (04:56 +0000)]
Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Test: updated fast/forms/placeholder-position.html and tested manually

Consider padding and margin for the results and cancel buttons.  This is important for the Windows
theme which uses padding to correctly position those buttons.  This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.

* fast/forms/placeholder-position.html: Added a case for a search field with the results button.
* platform/mac/fast/forms/placeholder-position-expected.checksum:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 22 Feb 2011 03:59:52 +0000 (03:59 +0000)]
2011-02-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] focus comment on accept
        https://bugs.webkit.org/show_bug.cgi?id=54930

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 03:57:28 +0000 (03:57 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Kent Tamura.

        GIFImageDecoder::setSize() tries to override the superclass method but fails
        https://bugs.webkit.org/show_bug.cgi?id=54305

        The superclass uses unsigned instead of int for its parameters, so
        GIFImageDecoder::setSize() was an overload, not an override.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::setSize):
        * platform/image-decoders/gif/GIFImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 22 Feb 2011 03:44:54 +0000 (03:44 +0000)]
2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This patch changes a test to work around a bug in PrettyPatch where
        it will crash if lines starting with "--" are missing from the actual
        output. The actual fix needed to PrettyPatch is described in the
        bug.

        https://bugs.webkit.org/show_bug.cgi?id=54918

        * platform/mac/fast/objc/dom-html-select-activate-expected.txt:
        * platform/mac/fast/objc/dom-html-select-activate.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 22 Feb 2011 03:38:28 +0000 (03:38 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] avoid overriding ctrl/cmd + r
        https://bugs.webkit.org/show_bug.cgi?id=54852

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 22 Feb 2011 03:31:35 +0000 (03:31 +0000)]
2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kent Tamura.

        nrwt: revert behavior on 10.5 to "old-threads". It's possible
        that r79062 has introduced a bunch of flakiness, although I
        can't explain why right now. This change should restore the
        old behavior, and then we can look at the build logs to see
        if the tests stop timing out or being flaky.

        https://bugs.webkit.org/show_bug.cgi?id=54925

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 22 Feb 2011 02:28:19 +0000 (02:28 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
        https://bugs.webkit.org/show_bug.cgi?id=54528

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init): Allows style to be a null pointer.
        (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
        -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
        to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
        whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
        (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
        (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
        (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
        (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
        ApplyStyleCommand::applyInlineStyle already does it.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
        (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
        * editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclam...
mrowe@apple.com [Tue, 22 Feb 2011 02:14:10 +0000 (02:14 +0000)]
<webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO

Reviewed by Darin Adler and Alexey Proskuryakov.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 02:08:08 +0000 (02:08 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] ChromePluginPrintContext::begin() fails to override superclass method
        https://bugs.webkit.org/show_bug.cgi?id=54914

        Update subclass method signature to match superclass again. This
        regressed in http://trac.webkit.org/changeset/71964

        * src/WebFrameImpl.cpp:
        (WebKit::ChromePluginPrintContext::begin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79276 268f45cc-cd09-0410-ab3c-d52691b4dbfc